WebKit-https.git
12 years ago2009-02-09 Gustavo Noronha Silva <gns@gnome.org>
aroben@apple.com [Tue, 10 Feb 2009 21:12:42 +0000 (21:12 +0000)]
2009-02-09  Gustavo Noronha Silva  <gns@gnome.org>

        Fix Bug 23851: Add my blog's webkit category to Planet

        <https://bugs.webkit.org/show_bug.cgi?id=23851>

        Reviewed by Mark Rowe.

        * config.ini: Add Gustavo Noronha's blog webkit category.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix Bug 23871: Assertion failure beneath WebCore::openFunc when running http...
aroben@apple.com [Tue, 10 Feb 2009 21:12:32 +0000 (21:12 +0000)]
    Fix Bug 23871: Assertion failure beneath WebCore::openFunc when running http/tests/security/xss-DENIED-xsl-document-redirect.xml

        <https://bugs.webkit.org/show_bug.cgi?id=23871>

        Reviewed by Alexey Proskuryakov.

        Covered by existing tests.

        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::openFunc): Use the two-parameter KURL constructor so that
        the string will be parsed. libxml2 gives us a UTF-8-encoded string
        that needs to be parsed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Add Michael(tm) Smith's blog to Planet WebKit
aroben@apple.com [Tue, 10 Feb 2009 21:10:07 +0000 (21:10 +0000)]
    Add Michael(tm) Smith's blog to Planet WebKit

        Rubberstamped by Alexey Proskuryakov.

        * config.ini:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Tue, 10 Feb 2009 19:50:00 +0000 (19:50 +0000)]
2009-02-10  David Hyatt  <hyatt@apple.com>

        Shrink the size of all replaced elements (images, form controls, plugins) by 4 bytes by packing the
        overflow boolean into the RenderObject base class.

        Reviewed by Sam Weinig

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::RenderObject):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::replacedHasOverflow):
        (WebCore::RenderObject::setReplacedHasOverflow):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::RenderReplaced):
        (WebCore::RenderReplaced::~RenderReplaced):
        (WebCore::RenderReplaced::adjustOverflowForBoxShadow):
        (WebCore::RenderReplaced::overflowHeight):
        (WebCore::RenderReplaced::overflowWidth):
        (WebCore::RenderReplaced::overflowLeft):
        (WebCore::RenderReplaced::overflowTop):
        (WebCore::RenderReplaced::overflowRect):
        * rendering/RenderReplaced.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-10 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 10 Feb 2009 19:32:35 +0000 (19:32 +0000)]
2009-02-10  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=23870
        Make it possible for a port to require a user gesture for an <audio> or <video> element
        to load a url.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_loadRestrictions.
        (WebCore::HTMLMediaElement::attributeChanged): Only one attribute can change so put an "else" between tests.
        (WebCore::HTMLMediaElement::load): Return INVALID_STATE_ERR if RequireUserGestureLoadRestriction is set
        and we are not preocessing a user gesture.
        (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): Remove unnecessary white space.
        (WebCore::HTMLMediaElement::play): Ditto.
        (WebCore::HTMLMediaElement::endScrubbing): Remove unnecessary braces added in r40789.
        (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Cache currentTime() in a local instead of calling it
        multiple times.
        (WebCore::HTMLMediaElement::processingUserGesture): New.
        * html/HTMLMediaElement.h:
        (WebCore::HTMLMediaElement::): Define LoadRestrictions, add m_loadRestrictions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-10 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Tue, 10 Feb 2009 19:12:36 +0000 (19:12 +0000)]
2009-02-10  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Sam Weinig.

        Remove the SVG checks from FloatPoint3D as it is used
        by TransformationMatrix.

        * platform/graphics/FloatPoint3D.cpp:
        * platform/graphics/FloatPoint3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Tue, 10 Feb 2009 19:06:48 +0000 (19:06 +0000)]
2009-02-10  David Hyatt  <hyatt@apple.com>

        Remove the m_baseline member variable from all line boxes, since it can easily be computed when needed and did not need to be cached.

        Reviewed by Sam Weinig

        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::paint):
        (WebCore::EllipsisBox::nodeAtPoint):
        * rendering/EllipsisBox.h:
        (WebCore::EllipsisBox::EllipsisBox):
        * rendering/InlineBox.h:
        (WebCore::InlineBox::InlineBox):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::verticallyAlignBoxes):
        (WebCore::InlineFlowBox::computeLogicalBoxHeights):
        (WebCore::InlineFlowBox::placeBoxesVertically):
        (WebCore::InlineFlowBox::paintTextDecorations):
        * rendering/InlineFlowBox.h:
        (WebCore::InlineFlowBox::marginBorderPaddingLeft):
        (WebCore::InlineFlowBox::marginBorderPaddingRight):
        (WebCore::InlineFlowBox::marginLeft):
        (WebCore::InlineFlowBox::marginRight):
        (WebCore::InlineFlowBox::borderLeft):
        (WebCore::InlineFlowBox::borderRight):
        (WebCore::InlineFlowBox::borderTop):
        (WebCore::InlineFlowBox::borderBottom):
        (WebCore::InlineFlowBox::paddingLeft):
        (WebCore::InlineFlowBox::paddingRight):
        (WebCore::InlineFlowBox::paddingTop):
        (WebCore::InlineFlowBox::paddingBottom):
        (WebCore::InlineFlowBox::includeLeftEdge):
        (WebCore::InlineFlowBox::includeRightEdge):
        (WebCore::InlineFlowBox::baseline):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        (WebCore::InlineTextBox::paintDecoration):
        (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
        (WebCore::InlineTextBox::paintCompositionUnderline):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::getBaselineOfFirstLineBox):
        (WebCore::RenderBlock::getBaselineOfLastLineBox):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::baselinePosition):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::placeEllipsis):
        * rendering/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::paintDecoration):
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::applyTextAnchorToTextChunk):
        (WebCore::SVGRootInlineBox::layoutInlineBoxes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix Bug 23869: Pixel tests can't be run on Windows
aroben@apple.com [Tue, 10 Feb 2009 17:56:35 +0000 (17:56 +0000)]
    Fix Bug 23869: Pixel tests can't be run on Windows

        <https://bugs.webkit.org/show_bug.cgi?id=23869>

        This patch gets the pixel tests limping along on Windows again.

        Reviewed by Dan Bernstein.

        * DumpRenderTree/DumpRenderTree.sln: Changed to use the new
        Debug_Internal configuration of ImageDiff in the Debug_Internal
        configuration of this solution.

        * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
        (printPNG): Changed to call fwrite in a loop, since this call was
        failing due to the buffer being too large on Windows.
        (dumpWebViewAsPixelsAndCompareWithExpected): Removed an unnecessary
        #if PLATFORM(MAC)/#endif.

        * DumpRenderTree/win/ImageDiff.vcproj: Added a Debug_Internal
        configuration that matches the Debug configuration but also references
        debug_internal.vsprops.

        * DumpRenderTree/win/PixelDumpSupportWin.cpp:
        (createBitmapContextFromWebView): Renamed from
        getBitmapContextFromWebView to match the name used in the
        cross-platform code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Tue, 10 Feb 2009 17:33:33 +0000 (17:33 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23867
        Eliminate obsolete frame->document() checks

        * page/FrameView.cpp: (WebCore::FrameView::paintContents): Apparently due to a typo
        (document vs. !document), fillWithRed was always set to false, and other branches were
        never taken. Removing the check for document restores debug-only red color filling.

        * loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Only call dispatchWindowObjectAvailable()
        after a document is created. A client can do anything in its delegate method, so we'd need
        to have frame->document() checks otherwise. DumpRenderTree uses this delegate to add its
        custom property, and it was crashing due to null document in JSDOMWindowBase::getOwnPropertySlot().

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::getOwnPropertySlot):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::addEventListener):
        (WebCore::JSDOMWindow::removeEventListener):
        * bindings/js/JSNavigatorCustom.cpp:
        (WebCore::needsYouTubeQuirk):
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::execute):
        * bindings/js/ScriptControllerMac.mm:
        (WebCore::updateRenderingForBindings):
        * dom/Document.cpp:
        (WebCore::Document::initSecurityContext):
        * editing/Editor.cpp:
        (WebCore::Editor::deleteWithDirection):
        (WebCore::Editor::dispatchCPPEvent):
        (WebCore::Editor::applyStyle):
        (WebCore::Editor::applyParagraphStyle):
        * editing/EditorCommand.cpp:
        (WebCore::Editor::Command::execute):
        (WebCore::Editor::Command::isEnabled):
        (WebCore::Editor::Command::state):
        (WebCore::Editor::Command::value):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::recomputeCaretRect):
        (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
        (WebCore::SelectionController::selectAll):
        (WebCore::SelectionController::setFocused):
        * inspector/InspectorController.cpp:
        (WebCore::getResourceDocumentNode):
        * inspector/JavaScriptDebugServer.cpp:
        (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
        * loader/DocumentLoader.cpp:
        (WebCore::canonicalizedTitle):
        (WebCore::DocumentLoader::stopLoading):
        (WebCore::DocumentLoader::isLoadingInAPISense):
        (WebCore::DocumentLoader::subresource):
        (WebCore::DocumentLoader::getSubresources):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::urlSelected):
        (WebCore::FrameLoader::stop):
        (WebCore::FrameLoader::iconURL):
        (WebCore::FrameLoader::executeIfJavaScriptURL):
        (WebCore::FrameLoader::clear):
        (WebCore::FrameLoader::endIfNotLoadingMainResource):
        (WebCore::FrameLoader::restoreDocumentState):
        (WebCore::FrameLoader::gotoAnchor):
        (WebCore::FrameLoader::loadDone):
        (WebCore::FrameLoader::checkCompleted):
        (WebCore::FrameLoader::checkCallImplicitClose):
        (WebCore::FrameLoader::scheduleRefresh):
        (WebCore::FrameLoader::outgoingOrigin):
        (WebCore::FrameLoader::canCachePageContainingThisFrame):
        (WebCore::FrameLoader::logCanCacheFrameDecision):
        (WebCore::FrameLoader::updatePolicyBaseURL):
        (WebCore::FrameLoader::setPolicyBaseURL):
        (WebCore::FrameLoader::frameDetached):
        (WebCore::FrameLoader::shouldScrollToAnchor):
        (WebCore::FrameLoader::saveDocumentState):
        * loader/archive/cf/LegacyWebArchive.cpp:
        (WebCore::LegacyWebArchive::create):
        * loader/icon/IconFetcher.cpp:
        (WebCore::IconFetcher::create):
        * loader/icon/IconLoader.cpp:
        (WebCore::IconLoader::startLoading):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
        * page/Chrome.cpp:
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::sessionStorage):
        (WebCore::DOMWindow::alert):
        (WebCore::DOMWindow::confirm):
        (WebCore::DOMWindow::prompt):
        (WebCore::DOMWindow::scrollX):
        (WebCore::DOMWindow::scrollY):
        (WebCore::DOMWindow::getMatchedCSSRules):
        (WebCore::DOMWindow::openDatabase):
        (WebCore::DOMWindow::scrollBy):
        (WebCore::DOMWindow::scrollTo):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::allowDHTMLDrag):
        (WebCore::EventHandler::scrollOverflow):
        (WebCore::EventHandler::handleMousePressEvent):
        (WebCore::EventHandler::handleMouseDoubleClickEvent):
        (WebCore::EventHandler::handleMouseMoveEvent):
        (WebCore::EventHandler::handleMouseReleaseEvent):
        (WebCore::EventHandler::updateDragAndDrop):
        (WebCore::EventHandler::handleWheelEvent):
        (WebCore::EventHandler::sendContextMenuEvent):
        (WebCore::EventHandler::capsLockStateMayHaveChanged):
        (WebCore::EventHandler::sendResizeEvent):
        (WebCore::EventHandler::sendScrollEvent):
        * page/FocusController.cpp:
        (WebCore::deepFocusableNode):
        (WebCore::FocusController::advanceFocus):
        * page/Frame.cpp:
        (WebCore::Frame::setFocusedNodeIfNeeded):
        (WebCore::Frame::shouldApplyTextZoom):
        (WebCore::Frame::shouldApplyPageZoom):
        (WebCore::Frame::setZoomFactor):
        (WebCore::Frame::setPrinting):
        (WebCore::Frame::reapplyStyles):
        (WebCore::Frame::isContentEditable):
        (WebCore::Frame::computeAndSetTypingStyle):
        (WebCore::Frame::selectionComputedStyle):
        (WebCore::Frame::applyEditingStyleToBodyElement):
        (WebCore::Frame::removeEditingStyleFromBodyElement):
        (WebCore::Frame::contentRenderer):
        (WebCore::Frame::styleForSelectionStart):
        (WebCore::Frame::setSelectionFromNone):
        (WebCore::Frame::findString):
        (WebCore::Frame::markAllMatchesForText):
        (WebCore::Frame::setMarkedTextMatchesAreHighlighted):
        (WebCore::Frame::documentTypeString):
        (WebCore::Frame::shouldClose):
        (WebCore::Frame::respondToChangedSelection):
        * page/FrameView.cpp:
        (WebCore::FrameView::~FrameView):
        (WebCore::FrameView::createScrollbar):
        (WebCore::FrameView::layout):
        (WebCore::FrameView::layoutTimerFired):
        (WebCore::FrameView::scheduleRelayout):
        (WebCore::FrameView::needsLayout):
        (WebCore::FrameView::unscheduleRelayout):
        (WebCore::FrameView::windowClipRect):
        * page/Geolocation.cpp:
        (WebCore::Geolocation::disconnectFrame):
        * page/Page.cpp:
        (WebCore::networkStateChanged):
        (WebCore::Page::~Page):
        (WebCore::Page::unmarkAllTextMatches):
        (WebCore::Page::setMediaVolume):
        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::updateRenderingDispatcherFired):
        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::currentKeyboardEvent):
        (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
        * page/mac/FrameMac.mm:
        (WebCore::Frame::dashboardRegionsDictionary):
        (WebCore::Frame::setUserStyleSheetLocation):
        (WebCore::Frame::setUserStyleSheet):
        * storage/LocalStorageArea.cpp:
        (WebCore::LocalStorageArea::dispatchStorageEvent):
        * storage/SessionStorageArea.cpp:
        (WebCore::SessionStorageArea::dispatchStorageEvent):
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::setContainerSize):
        (WebCore::SVGImage::usesContainerSize):
        (WebCore::SVGImage::size):
        (WebCore::SVGImage::hasRelativeWidth):
        (WebCore::SVGImage::hasRelativeHeight):
        Removed frame->document() checks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-10 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Tue, 10 Feb 2009 17:00:12 +0000 (17:00 +0000)]
2009-02-10  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by George Staikos.

        Attempt to fix the Qt build after r40791.

        * rendering/RenderSVGRoot.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixing ChangeLog entry to include a bug link and description. Thanks to Darin
darin@chromium.org [Tue, 10 Feb 2009 16:55:04 +0000 (16:55 +0000)]
Fixing ChangeLog entry to include a bug link and description.  Thanks to Darin
Adler for noticing the omission.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Robustify DumpRenderTree/win a little
aroben@apple.com [Tue, 10 Feb 2009 15:52:08 +0000 (15:52 +0000)]
    Robustify DumpRenderTree/win a little

        DumpRenderTree was previously not holding a ref to the WebViews it
        created via window.open. It was getting away with this because
        WebViews get reffed by being preference notification observers and by
        registering for drag-n-drop messages. Now DRT does hold a ref, in case
        this situation changes in the future.

        Reviewed by Alexey Proskuryakov.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (dumpBackForwardListForAllWindows): Added a .get().
        (windowToWebViewMap): Changed to use the WindowToWebViewMap typedef.
        * DumpRenderTree/win/DumpRenderTreeWin.h: Changed the
        windowToWebViewMap() to hold a ref to the WebViews it contains.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix recursive WebView destruction when running DumpRenderTree
aroben@apple.com [Tue, 10 Feb 2009 15:51:47 +0000 (15:51 +0000)]
    Fix recursive WebView destruction when running DumpRenderTree

        DumpRenderTree would call DestroyWindow on a WebView's host window,
        which would send a WM_DESTROY message to the WebView's window. Inside
        the WebView's WndProc, we would hold a ref to the WebView, then call
        close() and revokeDragDrop(), which would release all remaining
        references to the WebView other than the ref we held in the WndProc.
        When the WndProc exited, the final ref to the WebView would be
        released, invoking WebView's destructor. At this point,
        IsWindow(m_viewWindow) would return true, since we were still in the
        process of handling WM_DESTROY, so we would call DestroyWindow on the
        WebView's window again, re-entering the WndProc and re-reffing the
        WebView, leading to recursive destruction.

        Reviewed by Alexey Proskuryakov.

        * WebView.cpp:
        (WebView::~WebView): Don't call DestroyWindow if our window is already
        being destroyed.
        (WebViewWndProc): Only hold an extra ref to the WebView when we're not
        being destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-10 Karsten Heimrich <kheimric@trolltech.com>
hausmann@webkit.org [Tue, 10 Feb 2009 15:28:56 +0000 (15:28 +0000)]
2009-02-10  Karsten Heimrich  <kheimric@trolltech.com>

        Reviewed by Simon Hausmann.

        Fixes missing navigation/url update while clicking on anchor inside
        webpage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-10 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Tue, 10 Feb 2009 15:16:48 +0000 (15:16 +0000)]
2009-02-10  Adam Treat  <adam.treat@torchmobile.com>

        Fix the Qt build as class Selection is now VisibleSelection.

        * Api/qwebpage.cpp:
        (QWebPage::inputMethodQuery):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix after r40813
aroben@apple.com [Tue, 10 Feb 2009 14:34:04 +0000 (14:34 +0000)]
    Windows build fix after r40813

        * JavaScriptCore.vcproj/jsc/jsc.vcproj: Added profiler/ to the include
        path so that Profiler.h can be found.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-10 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Tue, 10 Feb 2009 14:28:59 +0000 (14:28 +0000)]
2009-02-10  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by George Staikos.

        Minor code cleanup.

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::replaceChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-10 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Tue, 10 Feb 2009 14:27:06 +0000 (14:27 +0000)]
2009-02-10  Adam Treat  <adam.treat@torchmobile.com>

        Fix Qt build following r40793.

        * editing/qt/EditorQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-10 Feng Qian <feng@chromium.org>
ap@webkit.org [Tue, 10 Feb 2009 09:20:09 +0000 (09:20 +0000)]
2009-02-10  Feng Qian <feng@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fix crashes when accessing navigator object of a deleted frame.
        https://bugs.webkit.org/show_bug.cgi?id=23626
        A layout test is added: fast/dom/navigator-detached-no-crash.html

        * page/Navigator.cpp:
        (WebCore::Navigator::cookieEnabled):
        (WebCore::Navigator::javaEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-09 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Tue, 10 Feb 2009 08:43:32 +0000 (08:43 +0000)]
2009-02-09  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Provide a class type for a generated block of JIT code.
        Also changes the return address -> bytecode index map to
        track the return addess as an unsigned offset into the code
        instead of a ptrdiff_t in terms of void**s - the latter is
        equal to the actual offset / sizeof(void*), making it a
        potentially lossy representation.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * assembler/AbstractMacroAssembler.h:
        (JSC::AbstractMacroAssembler::PatchBuffer::returnAddressOffset):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::getCallReturnOffset):
        * bytecode/CodeBlock.h:
        (JSC::CallReturnOffsetToBytecodeIndex::CallReturnOffsetToBytecodeIndex):
        (JSC::getCallReturnOffset):
        (JSC::CodeBlock::getBytecodeIndex):
        (JSC::CodeBlock::jitCode):
        (JSC::CodeBlock::callReturnIndexVector):
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::execute):
        (JSC::Interpreter::cti_vm_dontLazyLinkCall):
        (JSC::Interpreter::cti_vm_lazyLinkCall):
        * jit/JIT.cpp:
        (JSC::JIT::privateCompile):
        * jit/JIT.h:
        (JSC::):
        * jit/JITCall.cpp:
        (JSC::JIT::linkCall):
        * jit/JITCode.h: Added.
        (JSC::):
        (JSC::JITCode::JITCode):
        (JSC::JITCode::operator bool):
        (JSC::JITCode::addressForCall):
        (JSC::JITCode::offsetOf):
        (JSC::JITCode::execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-10 Sverrir Berg <sverrir@chromium.org>
darin@chromium.org [Tue, 10 Feb 2009 08:34:15 +0000 (08:34 +0000)]
2009-02-10  Sverrir Berg  <sverrir@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23630
        Add complex font rendering using Skia instead of Windows ScriptTextOut.
        This adds support for enhanced webkit styles when drawing complex
        glyphs.

        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::Font::drawGlyphs):
        (WebCore::Font::drawComplexText):
        * platform/graphics/chromium/UniscribeHelper.cpp:
        (WebCore::containsMissingGlyphs):
        (WebCore::UniscribeHelper::draw):
        (WebCore::UniscribeHelper::shape):
        * platform/graphics/chromium/UniscribeHelper.h:
        * platform/graphics/skia/SkiaFontWin.cpp:
        (WebCore::windowsCanHandleTextDrawing):
        (WebCore::skiaDrawText):
        (WebCore::paintSkiaText):
        * platform/graphics/skia/SkiaFontWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-09 John Grabowski <jrg@chromium.org>
darin@chromium.org [Tue, 10 Feb 2009 08:26:16 +0000 (08:26 +0000)]
2009-02-09  John Grabowski  <jrg@chromium.org>

        Reviewed by Darin Adler.

        * wtf/ThreadingPthreads.cpp:
        (WTF::initializeThreading):
        (WTF::isMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-10 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 10 Feb 2009 08:16:37 +0000 (08:16 +0000)]
2009-02-10  Darin Fisher  <darin@chromium.org>

        Revert r40797 as requested by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=23809

        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Document.idl:
        * html/HTMLCanvasElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-09 Darin Fisher <darin@chromium.org>
darin@chromium.org [Tue, 10 Feb 2009 08:12:12 +0000 (08:12 +0000)]
2009-02-09  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23855
        Fix TransformationMatrixSkia.cpp and GraphicsContextSkia.cpp bustage

        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::getCTM):
        * platform/graphics/skia/TransformationMatrixSkia.cpp:
        (WebCore::TransformationMatrix::operator SkMatrix):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dave Hyatt.
mitz@apple.com [Tue, 10 Feb 2009 05:41:29 +0000 (05:41 +0000)]
    Reviewed by Dave Hyatt.

        - fix <rdar://problem/6568942> REGRESSION: Font rendering in Wikipedia input field is incorrect (default GDI text mode)

        * platform/graphics/win/SimpleFontDataWin.cpp:
        (WebCore::SimpleFontData::widthForGDIGlyph): Make sure that the DC is
        in the advanced graphics mode before calling GetCharWidthI(), because
        otherwise that function returns incorrect results for the default UI
        font at a certain size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-09 Chris Marrin <cmarrin@apple.com>
simon.fraser@apple.com [Tue, 10 Feb 2009 05:22:08 +0000 (05:22 +0000)]
2009-02-09  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser

        https://bugs.webkit.org/show_bug.cgi?id=23689

        Added 3D functions to WebKitCSSMatrix. This depends on the 3D functions
        added to TransformationMatrix in https://bugs.webkit.org/show_bug.cgi?id=6868

        Test: transforms/3d/cssmatrix-3d-interface.xhtml

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix <https://bugs.webkit.org/show_bug.cgi?id=23863> / <rdar://problem/6571390>.
mrowe@apple.com [Tue, 10 Feb 2009 05:20:47 +0000 (05:20 +0000)]
Fix <https://bugs.webkit.org/show_bug.cgi?id=23863> / <rdar://problem/6571390>.
Bug 23863: Reproducible crash in Mail with TOT WebKit when creating a new message

Reviewed by Dan Bernstein.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _removeMouseMovedObserverUnconditionally]): Nil-check _private as it may have not
yet been initialized if this WebHTMLView was loaded from a nib.
(-[WebHTMLView _removeSuperviewObservers]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLand updated layout tests after recent changes.
hyatt@apple.com [Tue, 10 Feb 2009 03:13:34 +0000 (03:13 +0000)]
Land updated layout tests after recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix <https://bugs.webkit.org/show_bug.cgi?id=23858>
mrowe@apple.com [Tue, 10 Feb 2009 03:13:06 +0000 (03:13 +0000)]
Fix <https://bugs.webkit.org/show_bug.cgi?id=23858>
Bug 23858: Crash when removing a HTMLSelectElement from the document from inside its focus event handler

Reviewed by Darin Adler.

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Don't store the renderer in a local variable
as it can be invalidated by any of the calls to focus() within the function.  Instead, retrieve it and
null-check it when it is needed.

Test for <https://bugs.webkit.org/show_bug.cgi?id=23858>
Bug 23858: Crash when removing a HTMLSelectElement from the document from inside its focus event handler

Reviewed by Sam Weinig.

* fast/dom/HTMLSelectElement/remove-element-from-within-focus-handler-crash-expected.txt: Added.
* fast/dom/HTMLSelectElement/remove-element-from-within-focus-handler-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLand updated svg layout tests after recent changes.
hyatt@apple.com [Tue, 10 Feb 2009 03:00:17 +0000 (03:00 +0000)]
Land updated svg layout tests after recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-09 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Tue, 10 Feb 2009 02:47:45 +0000 (02:47 +0000)]
2009-02-09  David Hyatt  <hyatt@apple.com>

        Remove the m_height member from InlineBox.  This shaves 4 bytes off of all inline boxes.  Unfortunately SVG
        sets heights that are independent of the renderer or of the font, and so all SVG boxes have to retain m_height
        member variables.

        height() on InlineBox is now a virtual function that does a dynamic computation (including shrinking boxes
        with no text children).  For SVG boxes there is also a non-virtual setHeight function for updating the
        m_height member variable like before.

        Reviewed by Darin Adler

        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::nodeAtPoint):
        * rendering/EllipsisBox.h:
        (WebCore::EllipsisBox::EllipsisBox):
        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::height):
        (WebCore::InlineBox::root):
        * rendering/InlineBox.h:
        (WebCore::InlineBox::InlineBox):
        (WebCore::InlineBox::isInlineFlowBox):
        (WebCore::InlineBox::isRootInlineBox):
        (WebCore::InlineBox::topOverflow):
        (WebCore::InlineBox::bottomOverflow):
        (WebCore::InlineBox::leftOverflow):
        (WebCore::InlineBox::rightOverflow):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::height):
        (WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
        (WebCore::InlineFlowBox::computeLogicalBoxHeights):
        (WebCore::InlineFlowBox::placeBoxesVertically):
        (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
        (WebCore::InlineFlowBox::nodeAtPoint):
        * rendering/InlineFlowBox.h:
        (WebCore::InlineFlowBox::isInlineFlowBox):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::height):
        (WebCore::InlineTextBox::nodeAtPoint):
        (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
        (WebCore::InlineTextBox::paintCompositionUnderline):
        * rendering/InlineTextBox.h:
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::height):
        (WebCore::RootInlineBox::placeEllipsis):
        (WebCore::RootInlineBox::setVerticalOverflowPositions):
        * rendering/RootInlineBox.h:
        (WebCore::RootInlineBox::isRootInlineBox):
        (WebCore::RootInlineBox::topOverflow):
        (WebCore::RootInlineBox::bottomOverflow):
        (WebCore::RootInlineBox::leftOverflow):
        (WebCore::RootInlineBox::rightOverflow):
        (WebCore::RootInlineBox::selectionBottom):
        (WebCore::RootInlineBox::Overflow::Overflow):
        (WebCore::RootInlineBox::setVerticalSelectionPositions):
        * rendering/SVGInlineFlowBox.h:
        (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
        (WebCore::SVGInlineFlowBox::height):
        (WebCore::SVGInlineFlowBox::setHeight):
        * rendering/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::SVGInlineTextBox):
        * rendering/SVGInlineTextBox.h:
        (WebCore::SVGInlineTextBox::height):
        (WebCore::SVGInlineTextBox::setHeight):
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::layoutInlineBoxes):
        * rendering/SVGRootInlineBox.h:
        (WebCore::SVGRootInlineBox::SVGRootInlineBox):
        (WebCore::SVGRootInlineBox::height):
        (WebCore::SVGRootInlineBox::setHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig.
eric@webkit.org [Tue, 10 Feb 2009 01:32:17 +0000 (01:32 +0000)]
    Reviewed by Sam Weinig.

        Document our Selection DOM extensions
        (in preparation for re-writing Selection to work with ranges)

        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::type):
        * page/DOMSelection.h:
        * page/DOMSelection.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-09 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Tue, 10 Feb 2009 01:31:58 +0000 (01:31 +0000)]
2009-02-09  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Minor bugfix, incorrect check meant that subtraction causing integer overflow
        would be missed on x86-64 JIT.

        * jit/JITArithmetic.cpp:
        (JSC::JIT::compileBinaryArithOp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-09 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Tue, 10 Feb 2009 01:28:15 +0000 (01:28 +0000)]
2009-02-09  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        A more sensible register allocation for x86-64.

        When WREC was ported to x86-64 it stuck with the same register allocation as x86.
        This requires registers to be reordered on entry into WREC generated code, since
        argument passing is different on x86-64 and x86 (regparm(3)).  This patch switches
        x86-64 to use a native register allocation, that does not require argument registers
        to be reordered.

        * wrec/WRECGenerator.cpp:
        (JSC::WREC::Generator::generateEnter):
        (JSC::WREC::Generator::generateReturnSuccess):
        (JSC::WREC::Generator::generateReturnFailure):
        * wrec/WRECGenerator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Attempt to fix wx build
eric@webkit.org [Tue, 10 Feb 2009 01:10:03 +0000 (01:10 +0000)]
    Attempt to fix wx build

        * WebCoreSources.bkl: change Selection to VisibleSelection

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-06 Darin Fisher <darin@chromium.org>
darin@chromium.org [Mon, 9 Feb 2009 22:32:27 +0000 (22:32 +0000)]
2009-02-06  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23809
        Return CanvasRenderingContext2D instead of DOMObject in IDL to avoid V8 #ifdefs

        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Document.idl:
        * html/HTMLCanvasElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix the gtk build by adding VisibleSelection and removing Selection.
eric@webkit.org [Mon, 9 Feb 2009 22:17:22 +0000 (22:17 +0000)]
    Fix the gtk build by adding VisibleSelection and removing Selection.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-09 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 9 Feb 2009 22:09:42 +0000 (22:09 +0000)]
2009-02-09  Dirk Schulze  <krit@webkit.org>

        Reviewed by Eric Seidel.

        Transform the gradient instead of the context for most platforms and
        transform the context after CGContextReplacePathWithStrokedPath for CG.

        REGRESSION: SVG gradient transformation/BoundingBox can cause ugly stroke thickness
        https://bugs.webkit.org/show_bug.cgi?id=23547

        * platform/graphics/Gradient.h:
        (WebCore::Gradient::setGradientSpaceTransform):
        (WebCore::Gradient::gradientSpaceTransform):
        * platform/graphics/cairo/GradientCairo.cpp:
        (WebCore::Gradient::platformGradient):
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        * platform/graphics/skia/GradientSkia.cpp:
        (WebCore::Gradient::platformGradient):
        * svg/graphics/SVGPaintServerGradient.cpp:
        (WebCore::SVGPaintServerGradient::SVGPaintServerGradient):
        (WebCore::clipToTextMask):
        (WebCore::SVGPaintServerGradient::setup):
        (WebCore::SVGPaintServerGradient::teardown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-09 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 9 Feb 2009 22:05:26 +0000 (22:05 +0000)]
2009-02-09  Sam Weinig  <sam@webkit.org>

        Reviewed by David Hyatt.

        Fix the highlight when inspecting inline elements.

        * inspector/InspectorController.cpp:
        (WebCore::drawHighlightForBox):
        (WebCore::drawHighlightForLineBoxes):
        (WebCore::InspectorController::drawNodeHighlight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFirst pass at s/Selection/VisibleSelection
eric@webkit.org [Mon, 9 Feb 2009 21:43:24 +0000 (21:43 +0000)]
First pass at s/Selection/VisibleSelection

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
dglazkov@chromium.org [Mon, 9 Feb 2009 21:07:00 +0000 (21:07 +0000)]
WebCore:

2009-02-09  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=23806
        Fix a regression crash where an empty src value and a "text/html" type
        on an EMBED element did not finish ResourceRequest initialization due to
        an early return.

        Test: fast/loader/empty-embed-src-attribute.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::addExtraFieldsToRequest):

LayoutTests:

2009-02-09  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=23806
        New test for the crash with an embed element with an empty src and
        "text/html" type.

        * fast/loader/empty-embed-src-attribute-expected.txt: Added.
        * fast/loader/empty-embed-src-attribute.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Eric Seidel.
rwlbuis@webkit.org [Mon, 9 Feb 2009 20:55:20 +0000 (20:55 +0000)]
    Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23816
        Clean up RenderSVGRoot.cpp

        Clean up RenderSVGRoot.cpp.

        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::paint):
        (WebCore::RenderSVGRoot::calcViewport):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-09 Calvin Walton <calvin.walton@gmail.com>
zecke@webkit.org [Mon, 9 Feb 2009 20:41:14 +0000 (20:41 +0000)]
2009-02-09  Calvin Walton  <calvin.walton@gmail.com>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=23823

        [Gtk] Fix build with recent autotools

        Current versions of automake/libtool don't assume you want C++ enabled
        by default any more, so explicitly check for a C++ compiler.

        * configure.ac: Add AC_PROG_CXX macro

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-09 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 9 Feb 2009 19:48:27 +0000 (19:48 +0000)]
2009-02-09  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Antti Koivisto

        https://bugs.webkit.org/show_bug.cgi?id=23737
        Make it possible to control media element playback without knowing so many
        internal implementation details.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::togglePlayState): New, toggle between playing and paused state.
        (WebCore::HTMLMediaElement::beginScrubbing): New, pause as necessary for scrubbing mode.
        (WebCore::HTMLMediaElement::endScrubbing): New, resume playback if paused for scrubbing mode.
        * html/HTMLMediaElement.h:

        (WebCore::HTMLMediaElement::hasVideo): New, added so clients don't need to access MediaPlayer directly.
        * html/HTMLVideoElement.h:

        (WebCore::HTMLVideoElement::hasVideo): New.

        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlPlayButtonElement::defaultEventHandler): Use new media element
        togglePlayState method.
        (WebCore::MediaControlTimelineElement::defaultEventHandler): Tell media element when scrubbing
        begins and ends so it can deal with pausing logic. Don't call setCurrentTime unless the time
        will change.

        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::updateControls): Ask media element if it is able to play instead of including
        internal logic here.
        (WebCore::RenderMedia::updateControlVisibility): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-09 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 9 Feb 2009 19:37:26 +0000 (19:37 +0000)]
2009-02-09  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Antti Koivisto

        Change RenderPart and RenderPartObject constructors to take a Node*
        instead of a HTMLFrameOwnerElement* since that is all then need.

        * rendering/RenderPart.cpp:
        (WebCore::RenderPart::RenderPart): take Node* instead of HTMLFrameOwnerElement*
        * rendering/RenderPart.h:
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::RenderPartObject):  take Node* instead of HTMLFrameOwnerElement*
        * rendering/RenderPartObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - fix -Wmissing-prototypes builds
mitz@apple.com [Mon, 9 Feb 2009 19:28:32 +0000 (19:28 +0000)]
    - fix -Wmissing-prototypes builds

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::isHeaderElement): Marked this function static.
        (WebCore::haveSameTagName): Ditto.
        * editing/markup.cpp:
        (WebCore::isSpecialAncestorBlock): Ditto.
        * platform/graphics/transforms/TransformationMatrix.cpp:
        (WebCore::makeMapBetweenRects): Removed unused function.
        * platform/graphics/transforms/TransformationMatrix.h: Removed unused
        declaration of private member makeMapBetweenRects().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 9 Feb 2009 19:21:40 +0000 (19:21 +0000)]
2009-02-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Fix crash when plug-in host dies.

        * Plugins/Hosted/HostedNetscapePluginStream.mm:
        (WebKit::HostedNetscapePluginStream::didFail):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-09 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Mon, 9 Feb 2009 19:03:43 +0000 (19:03 +0000)]
2009-02-09  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=23850
        Code cleanup of HTMLParser class which was using a mix of m_* and bare
        class member variable names which helps to obfuscate the code.  Also
        changed a few of the static helper functions to take a const pointer type
        as they should not be modifying the node.

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::HTMLParser):
        (WebCore::HTMLParser::~HTMLParser):
        (WebCore::HTMLParser::reset):
        (WebCore::HTMLParser::setCurrent):
        (WebCore::HTMLParser::parseToken):
        (WebCore::HTMLParser::parseDoctypeToken):
        (WebCore::isTableSection):
        (WebCore::isTablePart):
        (WebCore::isTableRelated):
        (WebCore::HTMLParser::insertNode):
        (WebCore::HTMLParser::handleError):
        (WebCore::HTMLParser::textCreateErrorCheck):
        (WebCore::HTMLParser::commentCreateErrorCheck):
        (WebCore::HTMLParser::headCreateErrorCheck):
        (WebCore::HTMLParser::bodyCreateErrorCheck):
        (WebCore::HTMLParser::framesetCreateErrorCheck):
        (WebCore::HTMLParser::formCreateErrorCheck):
        (WebCore::HTMLParser::isindexCreateErrorCheck):
        (WebCore::HTMLParser::noscriptCreateErrorCheck):
        (WebCore::HTMLParser::pCloserStrictCreateErrorCheck):
        (WebCore::HTMLParser::mapCreateErrorCheck):
        (WebCore::HTMLParser::getNode):
        (WebCore::HTMLParser::allowNestedRedundantTag):
        (WebCore::HTMLParser::processCloseTag):
        (WebCore::HTMLParser::isInline):
        (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
        (WebCore::HTMLParser::reopenResidualStyleTags):
        (WebCore::HTMLParser::pushBlock):
        (WebCore::HTMLParser::popBlock):
        (WebCore::HTMLParser::popOneBlockCommon):
        (WebCore::HTMLParser::popOneBlock):
        (WebCore::HTMLParser::moveOneBlockToStack):
        (WebCore::HTMLParser::checkIfHasPElementInScope):
        (WebCore::HTMLParser::popInlineBlocks):
        (WebCore::HTMLParser::freeBlock):
        (WebCore::HTMLParser::createHead):
        (WebCore::HTMLParser::handleIsindex):
        (WebCore::HTMLParser::startBody):
        (WebCore::HTMLParser::finished):
        (WebCore::HTMLParser::reportErrorToConsole):
        * html/HTMLParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Applying review comment on a second location.
ap@webkit.org [Mon, 9 Feb 2009 18:38:04 +0000 (18:38 +0000)]
    Applying review comment on a second location.

        * rendering/RenderText.cpp: (WebCore::RenderText::nextOffset):
        Use "ifdef BUILDING_ON_TIGER".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Mon, 9 Feb 2009 18:35:26 +0000 (18:35 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23845
        editing/deleting/backward-deletion.html fails on Tiger

        * rendering/RenderText.cpp:
        (WebCore::RenderText::previousOffset):
        (WebCore::RenderText::nextOffset):
        Work around a bug in older ICU versions by hardcoding narrow voiced marks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix
aroben@apple.com [Mon, 9 Feb 2009 15:49:08 +0000 (15:49 +0000)]
    Windows build fix

        * WebCore.vcproj/WebCore.vcproj: Fix the XML syntax.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-09 Jian Li <jianli@chromium.org>
ap@webkit.org [Mon, 9 Feb 2009 10:13:49 +0000 (10:13 +0000)]
2009-02-09  Jian Li  <jianli@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Make WorkerMessagingProxy derive from two base proxy classes.
        https://bugs.webkit.org/show_bug.cgi?id=23777

        * bindings/js/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::evaluate):
        * dom/Worker.cpp:
        (WebCore::Worker::terminate):
        (WebCore::Worker::hasPendingActivity):
        * dom/WorkerContext.cpp:
        (WebCore::WorkerContext::reportException):
        * dom/WorkerMessagingProxy.cpp:
        (WebCore::WorkerThreadActivityReportTask::performTask):
        (WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
        (WebCore::WorkerMessagingProxy::workerObjectDestroyed):
        (WebCore::WorkerMessagingProxy::terminateWorkerContext):
        (WebCore::WorkerMessagingProxy::confirmWorkerThreadMessage):
        (WebCore::WorkerMessagingProxy::reportPendingActivity):
        (WebCore::WorkerMessagingProxy::reportPendingActivityInternal):
        (WebCore::WorkerMessagingProxy::hasPendingActivity):
        * dom/WorkerMessagingProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-09 Jian Li <jianli@chromium.org>
ap@webkit.org [Mon, 9 Feb 2009 10:00:38 +0000 (10:00 +0000)]
2009-02-09  Jian Li  <jianli@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Introduce 2 base classes to split WorkerMessagingProxy.
        https://bugs.webkit.org/show_bug.cgi?id=23776

        * GNUmakefile.am:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/WorkerContextProxy.h: Added.
        (WebCore::WorkerContextProxy::~WorkerContextProxy):
        * dom/WorkerObjectProxy.h: Added.
        (WebCore::WorkerObjectProxy::~WorkerObjectProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Land results for a recently added test (https://bugs.webkit.org/show_bug...
ap@webkit.org [Mon, 9 Feb 2009 09:32:06 +0000 (09:32 +0000)]
    Land results for a recently added test (https://bugs.webkit.org/show_bug.cgi?id=23601).

        * fast/dom/Selection/getRangeAt-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-08 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 9 Feb 2009 07:15:23 +0000 (07:15 +0000)]
2009-02-08  David Hyatt  <hyatt@apple.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23839

        Make sure that generated content is properly handled when content is moved from a block run-in
        to an inline run-in.

        Reviewed by Sam Weinig

        Added fast/runin/002.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::handleRunInChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-08 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 9 Feb 2009 06:03:23 +0000 (06:03 +0000)]
2009-02-08  David Hyatt  <hyatt@apple.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23832, crash when inspecting an image using the
        Web inspector.

        Reviewed by Mark Rowe

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::absoluteRectsForRange):
        (WebCore::RenderObject::absoluteQuadsForRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-08 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sun, 8 Feb 2009 20:44:40 +0000 (20:44 +0000)]
2009-02-08  Dirk Schulze  <krit@webkit.org>

        Unreviewed Qt build fix.

        TransformationMatrix changes in r40761 broke QT build.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::getCTM):
        (WebCore::GraphicsContext::scale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-08 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sun, 8 Feb 2009 20:03:21 +0000 (20:03 +0000)]
2009-02-08  Dirk Schulze  <krit@webkit.org>

        Reviewed by Holger Freyther.

        This is a follow up of the last commit. It cleans up TransformationMatrix.h
        and convert to a series of #elif.

        * platform/graphics/transforms/TransformationMatrix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-08 Gustavo Noronha Silva <gns@gnome.org>
krit@webkit.org [Sun, 8 Feb 2009 19:49:47 +0000 (19:49 +0000)]
2009-02-08  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Simon Fraser.

        [CAIRO] build broken by TransformationMatrix rework
        https://bugs.webkit.org/show_bug.cgi?id=23831

        Fixed cairo build after the TransformationMatrix rework done in
        revision 40761.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::getCTM):
        (WebCore::GraphicsContext::concatCTM):
        * platform/graphics/cairo/TransformationMatrixCairo.cpp:
        (WebCore::TransformationMatrix::operator cairo_matrix_t):
        * platform/graphics/transforms/TransformationMatrix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-07 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sun, 8 Feb 2009 07:03:43 +0000 (07:03 +0000)]
2009-02-07  David Hyatt  <hyatt@apple.com>

        Shrink the size of all InlineTextBoxes and all InlineBoxes (for images and replaced elements) by four bytes.
        Change the overflow variable on InlineFlowBoxes into a short and move the bits for InlineFlowBoxes out of the
        base InlineBox class.  Since the number of bits in the base class was 35, shoving the 3 bits for InlineFlowBoxes
        back down into that class (into the 16 bits exposed by making the overflow variable into a short), all text
        boxes and image boxes shrink by 4 bytes.

        Reviewed by Anders

        * rendering/InlineBox.h:
        (WebCore::InlineBox::InlineBox):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::placeBoxesHorizontally):
        (WebCore::InlineFlowBox::computeLogicalBoxHeights):
        (WebCore::InlineFlowBox::placeBoxesVertically):
        * rendering/InlineFlowBox.h:
        (WebCore::InlineFlowBox::InlineFlowBox):
        (WebCore::InlineFlowBox::maxHorizontalVisualOverflow):
        (WebCore::InlineFlowBox::hasTextChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-07 Dean Jackson <dino@apple.com>
dino@apple.com [Sun, 8 Feb 2009 06:17:07 +0000 (06:17 +0000)]
2009-02-07  Dean Jackson  <dino@apple.com>

        Attempted build fix for Qt. Not reviewed.

        TransformationMatrix changes in r40761 broke non-Apple builds.

        * platform/graphics/qt/TransformationMatrixQt.cpp:
        (WebCore::TransformationMatrix::operator QMatrix):
        * platform/graphics/transforms/TransformationMatrix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-07 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sun, 8 Feb 2009 05:39:22 +0000 (05:39 +0000)]
2009-02-07  David Hyatt  <hyatt@apple.com>

        This patch changes the base class of RenderInline from RenderBox to RenderBoxModelObject.  This shift
        in base class knocks 32 bytes off the size of every RenderInline.  All of the necessary functions
        for both RenderInline and RenderBox have either been pulled up into RenderBoxModelObject for sharing
        or split into two functions (one in each derived class).

        Reviewed by Anders and Antti

        * dom/Element.cpp:
        (WebCore::Element::offsetLeft):
        (WebCore::Element::offsetTop):
        (WebCore::Element::offsetWidth):
        (WebCore::Element::offsetHeight):
        (WebCore::Element::offsetParent):
        (WebCore::Element::clientWidth):
        (WebCore::Element::clientHeight):
        (WebCore::Element::scrollWidth):
        (WebCore::Element::scrollHeight):
        * dom/Node.cpp:
        (WebCore::Node::renderBox):
        (WebCore::Node::renderBoxModelObject):
        * dom/Node.h:
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::isKeyboardFocusable):
        * rendering/InlineBox.h:
        (WebCore::InlineBox::boxModelObject):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::marginLeft):
        (WebCore::InlineFlowBox::marginRight):
        (WebCore::InlineFlowBox::placeBoxesHorizontally):
        (WebCore::InlineFlowBox::computeLogicalBoxHeights):
        (WebCore::InlineFlowBox::placeBoxesVertically):
        (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
        * rendering/InlineFlowBox.h:
        (WebCore::InlineFlowBox::borderLeft):
        (WebCore::InlineFlowBox::borderRight):
        (WebCore::InlineFlowBox::paddingLeft):
        (WebCore::InlineFlowBox::paddingRight):
        * rendering/RenderBlock.cpp:
        (WebCore::getBorderPaddingMargin):
        (WebCore::RenderBlock::calcInlinePrefWidths):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::imageChanged):
        (WebCore::RenderBox::calcReplacedWidthUsing):
        (WebCore::RenderBox::calcReplacedHeightUsing):
        (WebCore::RenderBox::containingBlockWidthForPositioned):
        (WebCore::RenderBox::containingBlockHeightForPositioned):
        (WebCore::RenderBox::calcAbsoluteHorizontal):
        (WebCore::RenderBox::calcAbsoluteHorizontalValues):
        (WebCore::RenderBox::calcAbsoluteVertical):
        (WebCore::RenderBox::calcAbsoluteVerticalValues):
        (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
        (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
        (WebCore::RenderBox::positionForCoordinates):
        * rendering/RenderBox.h:
        (WebCore::RenderBox::borderBoundingBox):
        (WebCore::RenderBox::offsetHeight):
        (WebCore::RenderBox::marginTop):
        (WebCore::RenderBox::marginBottom):
        (WebCore::RenderBox::marginLeft):
        (WebCore::RenderBox::marginRight):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::offsetLeft):
        (WebCore::RenderBoxModelObject::offsetTop):
        (WebCore::RenderBoxModelObject::paddingTop):
        (WebCore::RenderBoxModelObject::paddingBottom):
        (WebCore::RenderBoxModelObject::paddingLeft):
        (WebCore::RenderBoxModelObject::paddingRight):
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        (WebCore::RenderBoxModelObject::calculateBackgroundSize):
        (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
        * rendering/RenderBoxModelObject.h:
        (WebCore::RenderBoxModelObject::borderTop):
        (WebCore::RenderBoxModelObject::borderBottom):
        (WebCore::RenderBoxModelObject::borderLeft):
        (WebCore::RenderBoxModelObject::borderRight):
        (WebCore::RenderBoxModelObject::hasHorizontalBordersPaddingOrMargin):
        (WebCore::RenderBoxModelObject::hasHorizontalBordersOrPadding):
        (WebCore::RenderBoxModelObject::childBecameNonInline):
        (WebCore::RenderBoxModelObject::isBoxModelObject):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::RenderInline):
        (WebCore::RenderInline::destroy):
        (WebCore::RenderInline::styleDidChange):
        (WebCore::nextContinuation):
        (WebCore::RenderInline::continuationBefore):
        (WebCore::RenderInline::addChildIgnoringContinuation):
        (WebCore::RenderInline::splitInlines):
        (WebCore::RenderInline::splitFlow):
        (WebCore::RenderInline::addChildToContinuation):
        (WebCore::RenderInline::absoluteRects):
        (WebCore::RenderInline::offsetLeft):
        (WebCore::RenderInline::offsetTop):
        (WebCore::RenderInline::marginLeft):
        (WebCore::RenderInline::marginRight):
        (WebCore::RenderInline::positionForCoordinates):
        (WebCore::RenderInline::clippedOverflowRectForRepaint):
        (WebCore::RenderInline::rectWithOutlineForRepaint):
        (WebCore::RenderInline::computeRectForRepaint):
        (WebCore::RenderInline::updateDragState):
        (WebCore::RenderInline::childBecameNonInline):
        (WebCore::RenderInline::updateHitTestResult):
        (WebCore::RenderInline::imageChanged):
        (WebCore::RenderInline::addFocusRingRects):
        * rendering/RenderInline.h:
        (WebCore::RenderInline::marginTop):
        (WebCore::RenderInline::marginBottom):
        (WebCore::RenderInline::continuation):
        (WebCore::RenderInline::setContinuation):
        * rendering/RenderLineBoxList.cpp:
        (WebCore::RenderLineBoxList::paint):
        (WebCore::RenderLineBoxList::hitTest):
        * rendering/RenderLineBoxList.h:
        * rendering/RenderObject.cpp:
        (WebCore::addLayers):
        (WebCore::RenderObject::removeLayers):
        (WebCore::RenderObject::moveLayers):
        (WebCore::RenderObject::findNextLayer):
        (WebCore::RenderObject::enclosingLayer):
        (WebCore::RenderObject::enclosingCompositingLayer):
        (WebCore::RenderObject::setLayerNeedsFullRepaint):
        (WebCore::RenderObject::handleDynamicFloatPositionChange):
        (WebCore::RenderObject::destroy):
        (WebCore::RenderObject::offsetParent):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isInlineContinuation):
        * rendering/RenderSVGTSpan.cpp:
        (WebCore::RenderSVGTSpan::absoluteRects):
        (WebCore::RenderSVGTSpan::absoluteQuads):
        * rendering/RenderSVGTextPath.cpp:
        (WebCore::RenderSVGTextPath::absoluteRects):
        (WebCore::RenderSVGTextPath::absoluteQuads):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::operator<<):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::setBestTruncatedAt):
        * rendering/RenderView.h:
        * rendering/bidi.cpp:
        (WebCore::getBorderPaddingMargin):
        (WebCore::inlineWidth):
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::inlineFlowRequiresLineBox):
        (WebCore::requiresLineBox):
        (WebCore::RenderBlock::findNextLineBreak):
        * wml/WMLAElement.cpp:
        (WebCore::WMLAElement::isKeyboardFocusable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-07 Yael Aharon <yael.aharon@nokia.com>
bfulgham@webkit.org [Sun, 8 Feb 2009 05:20:47 +0000 (05:20 +0000)]
2009-02-07  Yael Aharon <yael.aharon@nokia.com>

        Reviewed by Timothy Hatcher <timothy@hatcher.name>

        Partial fix for <https://bugs.webkit.org/show_bug.cgi?id=21051>
        Include localStorage and sessionStorage in DatabasesPanel.

        * WebCore.vcproj/WebCore.vcproj:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorDOMStorageResource::create):
        (WebCore::InspectorDOMStorageResource::setScriptObject):
        (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::addDOMStorageScriptResource):
        (WebCore::InspectorController::removeDOMStorageScriptResource):
        (WebCore::InspectorController::resetScriptObjects):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::didUseDOMStorage):
        * inspector/InspectorController.h:
        * inspector/front-end/DOMStorage.js: Added.
        (WebInspector.DOMStorage):
        (WebInspector.DOMStorage.prototype.get domStorage):
        (WebInspector.DOMStorage.prototype.set domStorage):
        (WebInspector.DOMStorage.prototype.get domain):
        (WebInspector.DOMStorage.prototype.set domain):
        (WebInspector.DOMStorage.prototype.get isLocalStorage):
        (WebInspector.DOMStorage.prototype.set isLocalStorage):
        * inspector/front-end/DOMStorageItemsView.js: Added.
        (WebInspector.DOMStorageItemsView):
        (WebInspector.DOMStorageItemsView.prototype.show):
        (WebInspector.DOMStorageItemsView.prototype.update):
        * inspector/front-end/DatabaseQueryView.js:
        (WebInspector.DatabaseQueryView):
        * inspector/front-end/DatabaseTableView.js:
        (WebInspector.DatabaseTableView):
        (WebInspector.DatabaseTableView.prototype._queryFinished):
        (WebInspector.DatabaseTableView.prototype._queryError):
        * inspector/front-end/DatabasesPanel.js:
        (WebInspector.DatabasesPanel):
        (WebInspector.DatabasesPanel.prototype.reset):
        (WebInspector.DatabasesPanel.prototype.addDatabase):
        (WebInspector.DatabasesPanel.prototype.addDOMStorage):
        (WebInspector.DatabasesPanel.prototype.showDatabase):
        (WebInspector.DatabasesPanel.prototype.showDOMStorage):
        (WebInspector.DatabasesPanel.prototype.closeVisibleView):
        (WebInspector.DatabasesPanel.prototype.updateDatabaseTables):
        (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
        (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
        (WebInspector.DOMStorageSidebarTreeElement):
        (WebInspector.DOMStorageSidebarTreeElement.prototype.onselect):
        (WebInspector.DOMStorageSidebarTreeElement.prototype.get mainTitle):
        (WebInspector.DOMStorageSidebarTreeElement.prototype.set mainTitle):
        (WebInspector.DOMStorageSidebarTreeElement.prototype.get subtitle):
        (WebInspector.DOMStorageSidebarTreeElement.prototype.set subtitle):
        * inspector/front-end/Images/domStorage.png: Added.
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.addDOMStorage):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::sessionStorage):
        (WebCore::DOMWindow::localStorage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-07 Feng Qian <feng@chromium.org>
bfulgham@webkit.org [Sun, 8 Feb 2009 02:47:56 +0000 (02:47 +0000)]
2009-02-07  Feng Qian <feng@chromium.org>

        Reviewed by Eric Seidel <eric@webkit.org>

        Put #if ENABLE(PAN_SCROLLING) around EventHandler::setPanScrollCursor.
        https://bugs.webkit.org/show_bug.cgi?id=23574

        * page/EventHandler.cpp:
        * page/EventHandler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-07 Zalan Bujtas <zbujtas@gmail.com>
bfulgham@webkit.org [Sun, 8 Feb 2009 02:10:55 +0000 (02:10 +0000)]
2009-02-07  Zalan Bujtas  <zbujtas@gmail.com>

        Reviewed by Rob Buis <rwlbuis@gmail.com>

        https://bugs.webkit.org/show_bug.cgi?id=23788
        call style()->isOriginalDisplayInlineType() on RenderBox instead of RenderObject.

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::skipLeadingWhitespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-07 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 7 Feb 2009 21:18:16 +0000 (21:18 +0000)]
2009-02-07  Darin Adler  <darin@apple.com>

        * StringsNotToBeLocalized.txt: Updated for recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix date.
rwlbuis@webkit.org [Sat, 7 Feb 2009 21:13:15 +0000 (21:13 +0000)]
Fix date.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
rwlbuis@webkit.org [Sat, 7 Feb 2009 21:10:21 +0000 (21:10 +0000)]
    Reviewed by Darin.

        https://bugs.webkit.org/show_bug.cgi?id=3248
        Bug 3248: Mouse events on OPTION element seem to be ignored

        Support mouse events on options in a select when it forms a list box.

        Test: fast/forms/option-mouseevents.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-07 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Sat, 7 Feb 2009 20:46:45 +0000 (20:46 +0000)]
2009-02-07  Adam Treat  <adam.treat@torchmobile.com>

        Prospective build fix for all non-Apple platforms.

        * platform/graphics/transforms/TransformationMatrix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Simon Fraser.
cmarrin@apple.com [Sat, 7 Feb 2009 18:40:47 +0000 (18:40 +0000)]
    Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=6868

        I have not only made TransformationMatrix platform independent
        but I've also added 3D methods, which will be used when I update
        WebKitCSSMatrix to include 3D (see https://bugs.webkit.org/show_bug.cgi?id=23689).
        I am now keeping a full 4x4 matrix in TransformationMatrix. I'm also doing all
        the math as doubles rather than floats. This makes a TransformationMatrix
        go from 24 bytes to 128 bytes, but I don't think this class is used enough to
        make this overhead will be significant.

        The change from floats to doubles has caused some differences in rounding and
        display (sometimes things that displayed as -0.0 now display as 0.0 or vice versa),
        so I've had to change some LayoutTest results in the SVG tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-07 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Sat, 7 Feb 2009 17:53:12 +0000 (17:53 +0000)]
2009-02-07  Holger Hans Peter Freyther  <zecke@selfish.org>

        Unreviewed build fix Use toNormalizedRange().

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::clipboard_get_contents_cb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-07 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Sat, 7 Feb 2009 15:33:19 +0000 (15:33 +0000)]
2009-02-07  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        For the Qt port implement Image::drawPattern via
        BitmapImage::drawPatterns' implementation and implement
        Gradient::fill.

        This partially fixes rendering of generated gradient content.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix
aroben@apple.com [Sat, 7 Feb 2009 02:44:56 +0000 (02:44 +0000)]
    Build fix

        Reviewed by Sam Weinig.

        * WebCoreSupport/WebFrameLoaderClient.cpp: Added missing #include.
        (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Removed
        incorrect .get(), and changed to use the new overload of
        WebHistory::itemForURLString.

        * WebHistory.cpp:
        (WebHistory::itemForURLString): Made this const.
        (WebHistory::itemForURLString): Added an overload that takes a
        WebCore::String and returns the IWebHistoryItem instead of using an
        out parameter.

        * WebHistory.h: Added public overload of itemForURLString.

        * WebView.cpp:
        (WebView::prepareCandidateWindow):
        (WebView::onIMERequestCharPosition):
        (WebView::onIMERequestReconvertString):
        Updated for toRange -> toNormalizedRange rename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Justin Garcia.
eric@webkit.org [Sat, 7 Feb 2009 01:28:59 +0000 (01:28 +0000)]
    Reviewed by Justin Garcia.

        DOMSelection.getRangeAt() returns a different range than the selection
        https://bugs.webkit.org/show_bug.cgi?id=23601

        Rename toRange to toNormalizedRange and add new firstRange which returns an unmodified range

        Test: fast/dom/Selection/getRangeAt.html

        * WebCore.base.exp:
        * dom/InputElement.cpp:
        (WebCore::InputElement::handleBeforeTextInsertedEvent):
        * editing/DeleteButtonController.cpp:
        (WebCore::enclosingDeletableElement):
        * editing/Editor.cpp:
        (WebCore::Editor::selectedRange):
        (WebCore::Editor::fontForSelection):
        (WebCore::Editor::applyStyleToSelection):
        (WebCore::Editor::applyParagraphStyleToSelection):
        (WebCore::Editor::insertTextWithoutSendingTextEvent):
        (WebCore::Editor::insertLineBreak):
        (WebCore::Editor::insertParagraphSeparator):
        (WebCore::Editor::ignoreSpelling):
        (WebCore::Editor::isSelectionUngrammatical):
        (WebCore::Editor::guessesForUngrammaticalSelection):
        (WebCore::markMisspellingsOrBadGrammar):
        (WebCore::Editor::rangeForPoint):
        * editing/EditorCommand.cpp:
        (WebCore::expandSelectionToGranularity):
        (WebCore::executeDeleteToMark):
        (WebCore::executeSelectToMark):
        * editing/RemoveFormatCommand.cpp:
        (WebCore::RemoveFormatCommand::doApply):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment):
        * editing/Selection.cpp:
        (WebCore::Selection::firstRange):
        (WebCore::Selection::toNormalizedRange):
        * editing/Selection.h:
        * editing/SelectionController.h:
        (WebCore::SelectionController::toNormalizedRange):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        * editing/markup.cpp:
        (WebCore::createMarkup):
        * loader/archive/cf/LegacyWebArchive.cpp:
        (WebCore::LegacyWebArchive::createFromSelection):
        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::ariaSelectedTextDOMRange):
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::getRangeAt):
        (WebCore::DOMSelection::addRange):
        (WebCore::DOMSelection::deleteFromDocument):
        (WebCore::DOMSelection::containsNode):
        (WebCore::DOMSelection::toString):
        * page/DragController.cpp:
        (WebCore::setSelectionToDragCaret):
        (WebCore::DragController::concludeEditDrag):
        (WebCore::DragController::startDrag):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::dispatchMouseEvent):
        * page/Frame.cpp:
        (WebCore::Frame::selectedText):
        (WebCore::Frame::shouldChangeSelection):
        (WebCore::Frame::shouldDeleteSelection):
        (WebCore::Frame::selectionComputedStyle):
        (WebCore::Frame::selectionTextRects):
        (WebCore::Frame::findString):
        (WebCore::Frame::respondToChangedSelection):
        * platform/ContextMenu.cpp:
        (WebCore::selectionContainsPossibleWord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-06 Brady Eidson <beidson@apple.com>
beidson@apple.com [Sat, 7 Feb 2009 01:26:54 +0000 (01:26 +0000)]
2009-02-06  Brady Eidson  <beidson@apple.com>

        Reviewed by Dan Bernstein

        <rdar://problem/6563402> - Workaround a case where ::didReceiveData() might be called on a ResourceHandleClient
        before ::didReceiveResponse().

        No layout test, as we don't have a concrete way to reproduce these conditions.  To that effect, I've added an ASSERT
        to catch the conditions before the workaround takes effect in case any WebKit Debug-build developer runs across
        this case and can come up with something more reproducible.

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::didReceiveData): If the response is null create a dummy response.  This is much
          like the FrameLoader::init() response that is used for initial document creation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-06 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sat, 7 Feb 2009 01:16:10 +0000 (01:16 +0000)]
2009-02-06  Geoffrey Garen  <ggaren@apple.com>

        Build fix.

        * WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit/gtk:
ggaren@apple.com [Sat, 7 Feb 2009 01:10:19 +0000 (01:10 +0000)]
WebKit/gtk:

2009-02-06  Geoffrey Garen  <ggaren@apple.com>

        Build fix.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::updateGlobalHistoryRedirectLinks):
        * WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/qt:

2009-02-06  Geoffrey Garen  <ggaren@apple.com>

        Build fix.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::updateGlobalHistoryRedirectLinks):
        * WebCoreSupport/FrameLoaderClientQt.h:

WebKit/wx:

2009-02-06  Geoffrey Garen  <ggaren@apple.com>

        Build fix.

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::updateGlobalHistoryRedirectLinks):
        * WebKitSupport/FrameLoaderClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-06 Xan Lopez <xan@gnome.org>
zecke@webkit.org [Sat, 7 Feb 2009 01:05:42 +0000 (01:05 +0000)]
2009-02-06  Xan Lopez  <xan@gnome.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=23621

        Do not use m_scrollOffset to check if we are setting the same
        value than we already have.

        m_scrollOffset starts at 0 for ScrollView, so when opening a new
        page and scrolling to 0 (the usual case) the check will fail and
        we won't update the adjustment value, resulting in a possibly
        mispositioned scrollbar. Use the adjustment value directly
        instead, which is what we are updating anyway.

        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::platformHandleHorizontalAdjustment):
        (WebCore::ScrollView::platformHandleVerticalAdjustment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Sat, 7 Feb 2009 00:42:34 +0000 (00:42 +0000)]
WebCore:

2009-02-06  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=23800
        Header elements are not always preserved during paste

        At paste time, don't merge out of header elements.  At copy time, be sure to include
        headers in the list of special common ancestor blocks, so that copying a paragraph or less
        of content inside a header will include the header element in the copied markup.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::areSameHeaderElements):
        (WebCore::ReplaceSelectionCommand::shouldMerge):
        * editing/markup.cpp:
        (WebCore::isSpecialAncestorBlock):
        (WebCore::createMarkup):

LayoutTests:

2009-02-06  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=23800
        Header elements are not always preserved during paste

        * editing/execCommand/4128080-1-expected.txt: Added.
        * editing/execCommand/4128080-1.html: Added.
        * editing/execCommand/4128080-2-expected.txt: Added.
        * editing/execCommand/4128080-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
ggaren@apple.com [Sat, 7 Feb 2009 00:28:29 +0000 (00:28 +0000)]
WebCore:

2009-02-06  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Part III of <rdar://problem/6552272>.

        Make redirect data available to WebKit. (I tried having WebKit track this
        data for itself, but that went wrong -- it's just too hard to figure
        out the weird corners of the WebCore loader from within another framework.)

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::DocumentLoader):
        * loader/DocumentLoader.h: Store a flag indicating whether we created
        a global history entry. If we didn't, then we know that the next redirect
        should not link to us, since we're not in history.

        (WebCore::DocumentLoader::clientRedirectSourceForHistory):
        (WebCore::DocumentLoader::clientRedirectDestinationForHistory):
        (WebCore::DocumentLoader::setClientRedirectSourceForHistory):
        (WebCore::DocumentLoader::serverRedirectSourceForHistory):
        (WebCore::DocumentLoader::serverRedirectDestinationForHistory):
        (WebCore::DocumentLoader::didCreateGlobalHistoryEntry):
        (WebCore::DocumentLoader::setDidCreateGlobalHistoryEntry): Added accessors
        to help WebKit wade through the muck of WebCore history.

        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryRedirectLinks): Renamed
        this client function to say what it does, instead of when it's called.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::loadWithNavigationAction): In the case of a redirect,
        store a link to the previous history URL in the new DocumentLoader, so
        it can update WebKit with that link when the load commits.

        (WebCore::FrameLoader::updateHistory*): Use our new flags and names,
        described above.

        * loader/FrameLoader.h:
        (WebCore::FrameLoader::documentLoader):
        (WebCore::FrameLoader::policyDocumentLoader):
        (WebCore::FrameLoader::provisionalDocumentLoader):
        (WebCore::FrameLoader::state): Inlined a few trivial functions because
        performance mistakes give me the itches.

        * loader/FrameLoaderClient.h: Renamed this client function to say what
        it does, instead of when it's called.

WebKit/mac:

2009-02-06  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Part III of <rdar://problem/6552272>.

        Refactored to use the redirect data WebCore makes available, instead of
        tracking loading state in WebKit.

        * History/WebHistory.mm:
        (-[WebHistoryPrivate dealloc]):
        (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
        (-[WebHistory _visitedURLForRedirectWithoutHistoryItem:]):
        * History/WebHistoryInternal.h:
        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::updateGlobalHistory):
        (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):

WebKit/win:

2009-02-06  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Part III of <rdar://problem/6552272>.

        Refactored to use the redirect data WebCore makes available, instead of
        tracking loading state in WebKit.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::updateGlobalHistory):
        (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebHistory.cpp:
        (WebHistory::visitedURL):
        * WebHistory.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-06 Xan Lopez <xan@gnome.org>
zecke@webkit.org [Sat, 7 Feb 2009 00:10:01 +0000 (00:10 +0000)]
2009-02-06  Xan Lopez  <xan@gnome.org>

        Reviewed by Holger Freyther.

        Reported by Daniel Macks.

        https://bugs.webkit.org/show_bug.cgi?id=20412

        Use positive numbers for the target info IDs, gtk_target_list_add
        casts them to 'guint'. Also just start them from 0, since the
        values are not relevant or magic in any way, they are just used as
        tokens for the user of the API.

        * webkit/webkitwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Justin Garcia.
eric@webkit.org [Sat, 7 Feb 2009 00:04:48 +0000 (00:04 +0000)]
    Reviewed by Justin Garcia.

        Minor refactoring and cleanup to Selection code
        https://bugs.webkit.org/show_bug.cgi?id=23774

        No functional changes, thus no tests.

        * editing/Editor.cpp:
        (WebCore::Editor::applyStyle):
        (WebCore::Editor::applyParagraphStyle):
        * editing/Selection.cpp:
        (WebCore::Selection::Selection):
        (WebCore::Selection::setBaseAndExtentToDeepEquivalents):
        (WebCore::Selection::setStartAndEndFromBaseAndExtentRespectingGranularity):
        (WebCore::Selection::updateSelectionType):
        (WebCore::Selection::validate):
        (WebCore::Selection::setWithoutValidation):
        (WebCore::Selection::adjustSelectionToAvoidCrossingEditingBoundaries):
        * editing/Selection.h:
        (WebCore::Selection::):
        (WebCore::Selection::selectionType):
        (WebCore::Selection::extent):
        (WebCore::Selection::isNone):
        (WebCore::Selection::isCaret):
        (WebCore::Selection::isRange):
        (WebCore::Selection::isCaretOrRange):
        * editing/SelectionController.h:
        (WebCore::SelectionController::selectionType):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        * page/Frame.cpp:
        (WebCore::Frame::revealSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-06 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 6 Feb 2009 23:39:09 +0000 (23:39 +0000)]
2009-02-06  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23801
        Add custom V8 bindings for SVG.

        * bindings/v8/custom/V8SVGElementInstanceCustom.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8SVGLengthCustom.cpp: Added.
        (WebCore::ACCESSOR_GETTER):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8SVGMatrixCustom.cpp: Added.
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-06 David Levin <levin@chromium.org>
darin@chromium.org [Fri, 6 Feb 2009 23:29:52 +0000 (23:29 +0000)]
2009-02-06  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        Bug 23792: unused param is used in RenderLayer.cp but not #include'd
        <https://bugs.webkit.org/show_bug.cgi?id=23792>

        Add include file for UnusedParam which is used in this file.

        * rendering/RenderLayer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-06 David Levin <levin@chromium.org>
eric@webkit.org [Fri, 6 Feb 2009 23:25:18 +0000 (23:25 +0000)]
2009-02-06  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        <https://bugs.webkit.org/show_bug.cgi?id=23741>

        Bug 23798: KURLGoogle needs support for protocolInHTTPFamily
        <https://bugs.webkit.org/show_bug.cgi?id=23798>

        Add protocolInHTTPFamily() to the KURLGoogle implementation.
        This is another chromium build fix to mirror r40553.

        While in this file, I did some style fixes and consistency fixes:
        + fixed many_occurences_of_underscoring_naming
        + usages of NULL
        + comparisons to 0
        + changed the copyright remove an extraneous , and capitalize the (C)
          which was suggested for other files that I've submitted.

        No observable change in behavior, so no test.

        * platform/KURL.h:
        (WebCore::KURL::protocolInHTTPFamily):
        * platform/KURLGoogle.cpp:
        (WebCore::KURLCharsetConverter::ConvertFromUTF16):
        (WebCore::lowerCaseEqualsASCII):
        (WebCore::KURLGooglePrivate::KURLGooglePrivate):
        (WebCore::KURLGooglePrivate::setUtf8):
        (WebCore::KURLGooglePrivate::setAscii):
        (WebCore::KURLGooglePrivate::init):
        (WebCore::KURLGooglePrivate::initProtocolInHTTPFamily):
        (WebCore::KURLGooglePrivate::copyTo):
        (WebCore::KURLGooglePrivate::replaceComponents):
        (WebCore::KURL::KURL):
        (WebCore::KURL::createCFURL):
        (WebCore::KURL::isEmpty):
        (WebCore::KURL::protocolInHTTPFamily):
        (WebCore::KURL::query):
        (WebCore::decodeURLEscapeSequences):
        (WebCore::KURL::protocolIs):
        (WebCore::encodeWithURLEscapeSequences):
        (WebCore::KURL::invalidate):
        (WebCore::equalIgnoringRef):
        * platform/KURLGooglePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Bug 23741: StyleRareNonInheritedData::operator==() should not compare Content...
ddkilzer@apple.com [Fri, 6 Feb 2009 22:48:16 +0000 (22:48 +0000)]
    Bug 23741: StyleRareNonInheritedData::operator==() should not compare ContentData objects by pointer

        <https://bugs.webkit.org/show_bug.cgi?id=23741>

        Reviewed by Darin Adler.

        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::contentDataEquivalent): Moved method to
        WebCore::StyleRareNonInheritedData class.
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::contentDataEquivalent): Replaced declaration
        with inline method that calls contentDataEquivalent() on
        WebCore::StyleRareNonInheritedData instead.
        * rendering/style/StyleRareNonInheritedData.cpp:
        (WebCore::StyleRareNonInheritedData::operator==): This is the bug fix!
        Replaced pointer comparison of ContentData objects with call to
        StyleRareNonInheritedData::contentDataEquivalent().
        (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Added.
        * rendering/style/StyleRareNonInheritedData.h:
        (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Added
        declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 6 Feb 2009 22:42:13 +0000 (22:42 +0000)]
2009-02-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/6562220>
        CrashTracer: [USER] 21 crashes in Safari at com.apple.WebKit • WebKit::NetscapePluginHostProxy::port

        Make the handling of crashes in the plug-in host more robust.

        * Plugins/Hosted/NetscapePluginHostProxy.h:
        Add m_portSet.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
        Initialize m_portSet.

        (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy):
        Free m_portSet.

        (WebKit::NetscapePluginHostProxy::processRequests):
        Listen for messages on the port set. If we get a message to the port death notification port,
        then call pluginHostDied. Otherwise, process the message.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::cleanup):
        Factor code that should be shared between destroy() and pluginHostDied() into cleanup.

        (WebKit::NetscapePluginInstanceProxy::destroy):
        Call cleanup().

        (WebKit::NetscapePluginInstanceProxy::pluginHostDied):
        Call cleanup().

        (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply):
        Call NetscapePluginHostProxy::processRequests.

        * Plugins/Hosted/ProxyInstance.mm:
        (WebKit::ProxyInstance::invalidate):
        Add a null check for the host proxy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 Feb 2009 22:17:44 +0000 (22:17 +0000)]
2009-02-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel

        Factor code that checks whether the object is rooted in
        repaint() and repaintRectangle() into a common isRooted()
        method.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaint):
        (WebCore::RenderObject::repaintRectangle):
        (WebCore::RenderObject::isRooted):
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 Feb 2009 22:16:19 +0000 (22:16 +0000)]
2009-02-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel

        Expose an isRootLayer() method on RenderLayer that works whether the
        layer is rooted or not, and use that in a few places in the
        accelerated compositing code.

        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::isRootLayer):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::paintingGoesToWindow):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
        (WebCore::RenderLayerCompositor::requiresCompositingLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 Feb 2009 22:13:17 +0000 (22:13 +0000)]
2009-02-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel

        Make RenderStyle::transitionForProperty() const.

        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::transitionForProperty):
        * rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
mitz@apple.com [Fri, 6 Feb 2009 21:44:27 +0000 (21:44 +0000)]
    Reviewed by Darin Adler.

        - fix <rdar://problem/6552338> FontCache::releaseFontData() called on a small caps font that is not in the cache

        Most platforms do not retrieve the small caps font from the FontCache,
        but cross-platform code in ~SimpleFontData() assumes the the small caps
        font data did come from the cache and therefore calls releaseFontData()
        on it.

        * platform/graphics/SimpleFontData.cpp:
        (WebCore::SimpleFontData::~SimpleFontData): Reordered to call
        platformDestroy() before releasing the small caps font and pruning the
        glyph page tree. This allows platformDestroy() to reset
        m_smallCapsFontData to 0 if it was not obtained from the cache.
        * platform/graphics/chromium/SimpleFontDataLinux.cpp:
        (WebCore::SimpleFontData::platformDestroy): Set m_smallCapsFontData to
        0 after deleting it.
        * platform/graphics/gtk/SimpleFontDataGtk.cpp:
        (WebCore::SimpleFontData::platformDestroy): Ditto.
        * platform/graphics/gtk/SimpleFontDataPango.cpp:
        (WebCore::SimpleFontData::platformDestroy): Ditto.
        * platform/graphics/win/SimpleFontDataWin.cpp:
        (WebCore::SimpleFontData::platformCommonDestroy): Ditto.
        * platform/graphics/wx/SimpleFontDataWx.cpp:
        (WebCore::SimpleFontData::platformDestroy): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 Feb 2009 21:30:37 +0000 (21:30 +0000)]
2009-02-06  Simon Fraser  <simon.fraser@apple.com>

        Fix build when ACCELERATED_COMPOSITING is turned on.

        Remove font smoothing changes that will be committed
        separately.

        * platform/graphics/mac/WebLayer.mm:
        (WebCore::if):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - try to fix the Tiger build
mitz@apple.com [Fri, 6 Feb 2009 21:09:05 +0000 (21:09 +0000)]
    - try to fix the Tiger build

        * Misc/WebNSArrayExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Fri, 6 Feb 2009 20:49:23 +0000 (20:49 +0000)]
    Reviewed by Anders Carlsson.

        - fix an assertion failure in Vector::at() beneath
          WebHistoryItem::dictionaryRepresentation.

        * WebHistoryItem.cpp:
        (WebHistoryItem::dictionaryRepresentation): Give the numbers vector initial
        size. Also reduced the inline capacity of the vector used for weekly visit
        counts to 5, which is the expected maximum size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 6 Feb 2009 20:33:33 +0000 (20:33 +0000)]
2009-02-06  Anders Carlsson  <andersca@apple.com>

        Build fix.

        * bridge/npapi.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-06 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 6 Feb 2009 20:16:12 +0000 (20:16 +0000)]
2009-02-06  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23790
        Custom -> JSCCustom in SVGPointList.idl

        * svg/SVGPointList.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 6 Feb 2009 19:22:31 +0000 (19:22 +0000)]
2009-02-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6563650>
        Add Netscape plug-in API to tell the browser not to load streams (some plug-ins handle network loading manually)

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView loadStream]):
        (-[WebNetscapePluginView pluginView:receivedData:]):
        (-[WebNetscapePluginView _shouldCancelSrcStream]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-06 Anantanarayanan Iyengar <ananta@chromium.org>
dglazkov@chromium.org [Fri, 6 Feb 2009 18:08:44 +0000 (18:08 +0000)]
2009-02-06  Anantanarayanan Iyengar  <ananta@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23309
        Fix whitespace indent errors. The rest of the original patch has already
        landed.

        * platform/graphics/cairo/ImageSourceCairo.cpp:
        (WebCore::ImageSource::clear):
        * platform/graphics/cg/ImageSourceCG.cpp:
        (WebCore::ImageSource::clear):
        * platform/graphics/qt/ImageSourceQt.cpp:
        (WebCore::ImageSource::clear):
        * platform/graphics/wx/ImageSourceWx.cpp:
        (WebCore::ImageSource::clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-02-06 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 6 Feb 2009 17:37:42 +0000 (17:37 +0000)]
2009-02-06  Dirk Schulze  <krit@webkit.org>

        Reviewed by Simon Hausmann.

        Fix bug in clearRect(). Use fillRect() instead of eraseRect() to get
        the context transparent.

        [QT] clearRect fill's a given rect with white
        https://bugs.webkit.org/show_bug.cgi?id=23728

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::clearRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix. Re-enable missing file in Release_Cairo target.
bfulgham@webkit.org [Fri, 6 Feb 2009 17:32:48 +0000 (17:32 +0000)]
Build fix.  Re-enable missing file in Release_Cairo target.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40720 268f45cc-cd09-0410-ab3c-d52691b4dbfc