WebKit-https.git
15 years ago2006-12-18 Kirby White <KWhiteRight@gmail.com>
bdash [Mon, 18 Dec 2006 23:22:20 +0000 (23:22 +0000)]
2006-12-18  Kirby White  <KWhiteRight@gmail.com>

        Reviewed by Darin.

        Changed hidden input controls to reset to their initial values
        when the form is reset.  Also added layout tests for resetting
        other input controls.

        Fixes http://bugs.webkit.org/show_bug.cgi?id=11866

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setValue):
        (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):

2006-12-18  Kirby White  <KWhiteRight@gmail.com>

        Reviewed by Darin.

        Layout tests for http://bugs.webkit.org/show_bug.cgi?id=11866

        * fast/dom/HTMLInputElement/input-checked-reset-expected.txt: Added.
        * fast/dom/HTMLInputElement/input-checked-reset.html: Added.
        * fast/dom/HTMLInputElement/input-text-reset-expected.txt: Added.
        * fast/dom/HTMLInputElement/input-text-reset.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Oops forgot a file.
aliceli1 [Mon, 18 Dec 2006 22:49:32 +0000 (22:49 +0000)]
    Oops forgot a file.

        * editing/EditorDeleteAction.h: Added.
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
aliceli1 [Mon, 18 Dec 2006 22:47:27 +0000 (22:47 +0000)]
WebCore:

        Reviewed by Adam.

        Have the Editor handle deletion instead of WebHTMLView

        * WebCore.exp:
        Exposed Editor::deleteWithDirection and ::deleteRange()

        * WebCore.xcodeproj/project.pbxproj:
        Added EditorDeleteAction.h

        * editing/Editor.cpp:
        (WebCore::Editor::deleteRange):
        (WebCore::Editor::deleteWithDirection):
        Implemented

        (WebCore::Editor::deleteSelectionWithSmartDelete):
        Overloaded to take no params, in which case canSmartCopyOrDelete is called

        (WebCore::execCopy):
        (WebCore::execCut):
        (WebCore::execDelete):
        (WebCore::execPaste):
        Call the editor instead of asking frame to cut/copy/paste/delete

        (WebCore::execBackwardDelete):
        (WebCore::execForwardDelete):
        Call deleteWithDirection instead of just executing a TypingCommand

        (WebCore::CommandEntry::):
        distinguished delete (which deletes selection) from backwards delete (single character, no selection)

        (WebCore::Editor::cut):
        (WebCore::Editor::performDelete):
        Trivial changes

        * editing/Editor.h:
        Added some functons.
        (WebCore::Editor::setStartNewKillRingSequence):
        (WebCore::Editor::propogateDOMException):
        (WebCore::Editor::addToKillRing):
        * editing/mac/EditorMac.mm:
        Factored out support for Kill Rings to this file

        * platform/mac/PasteboardMac.mm:
        Trivial change

WebKit:

        Reviewed by Adam.

        Have the Editor handle deletion instead of WebHTMLView

        * WebKitPrefix.h:
        Turned on WebCore deletion

        * WebView/WebHTMLViewInternal.h:
        Moved ownership of startNewKillRingSequence to the WebCore::Editor

        * WebView/WebHTMLView.m:
        (-[NSArray becomeFirstResponder]):
        Use the Editor's startNewKillRingSequence flag

        (-[NSArray deleteForward:]):
        (-[NSArray deleteBackward:]):
        (-[NSArray deleteWordForward:]):
        (-[NSArray deleteWordBackward:]):
        (-[NSArray deleteToBeginningOfLine:]):
        (-[NSArray deleteToEndOfLine:]):
        (-[NSArray deleteToBeginningOfParagraph:]):
        (-[NSArray deleteToEndOfParagraph:]):
        (-[NSArray deleteToMark:]):
        use Editor::deleteWithDirection instead of WebHTMLView's

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
kmccullo [Mon, 18 Dec 2006 22:32:56 +0000 (22:32 +0000)]
    Reviewed by Oliver.

        - Removed CG header include

        * platform/graphics/ImageSource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Hatcher
sullivan [Mon, 18 Dec 2006 22:18:34 +0000 (22:18 +0000)]
    Reviewed by Tim Hatcher

        - fixed <rdar://problem/4887764> GMAIL: Crash occurs at WebCore::Range::cloneRange()
          when I ctrl-click in a empty list item

        * editing/mac/EditorMac.mm:
        (WebCore::isRangeUngrammatical):
        bail out immediately for nil range (which selectionController()->toRange().get()
        can return). Also save some work by bailing out immediately for collapsed ranges.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
ap [Mon, 18 Dec 2006 20:27:58 +0000 (20:27 +0000)]
    Reviewed by Mitz.

        Test for http://bugs.webkit.org/show_bug.cgi?id=7170
        `window.parent.[frameName].location=' fails if the target frame has not yet loaded a document

        * fast/frames/resources/set-unloaded-frame-location-1.html: Added.
        * fast/frames/resources/set-unloaded-frame-location-2.html: Added.
        * fast/frames/set-unloaded-frame-location-expected.txt: Added.
        * fast/frames/set-unloaded-frame-location.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Leopard build fix.
aliceli1 [Mon, 18 Dec 2006 18:44:52 +0000 (18:44 +0000)]
    Leopard build fix.

        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::checkOrEnableIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agofix compiltion, after the const changes
zack [Sun, 17 Dec 2006 22:23:28 +0000 (22:23 +0000)]
fix compiltion, after the const changes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
rwlbuis [Sun, 17 Dec 2006 21:48:12 +0000 (21:48 +0000)]
Reviewed by Eric.

    Add missing checksum file, thnx to Wildfox for noticing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Eric.
zimmermann [Sun, 17 Dec 2006 21:29:15 +0000 (21:29 +0000)]
Reviewed by Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=10956
Long standing regression. The old code in FontMac.mm, used set the fill/stroke
color "[nsColor(graphicsContext->pen().color()) set];", and current code only
sets the fill color. Reverting to old behaviour fixes gradient-on-stroke-of-text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-12-17 Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
ap [Sun, 17 Dec 2006 19:25:47 +0000 (19:25 +0000)]
2006-12-17  Lars Naesbye Christensen  <larsnaesbye@stud.ku.dk>

        Reviewed, tweaked and landed by Alexey.

        http://bugs.webkit.org/show_bug.cgi?id=11798
        [CSS 3] missing cursor support for 'none'

        * Resources/noneCursor.png: Added.
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSValueKeywords.in:
        * css/cssparser.cpp: Also fixed previously broken -webkit-background-composite: copy.
        * manual-tests/cursor.html:
        * page/EventHandler.cpp:
        (WebCore::selectCursor):
        * platform/Cursor.h:
        * platform/gdk/CursorGdk.cpp:
        (WebCore::noneCursor):
        * platform/mac/CursorMac.mm:
        (WebCore::noneCursor):
        * platform/qt/CursorQt.cpp:
        (WebCore::noneCursor):
        * platform/win/CursorWin.cpp:
        (WebCore::noneCursor):
        * rendering/RenderStyle.h:
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBuild fix, not reviewed.
zimmermann [Sun, 17 Dec 2006 12:52:00 +0000 (12:52 +0000)]
Build fix, not reviewed.

This should hopefully fix Qt build.
* ksvg2/svg/SVGLength.cpp: Include math.h for Qt/Linux build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Rob.
zimmermann [Sun, 17 Dec 2006 12:47:18 +0000 (12:47 +0000)]
Reviewed by Rob.

Remove SVGHelper class. Move the last static function "parseSeparatedList"
to the only place using it: SVGAnimationElement. Update all build files.

Remove any lazy_create macro usage, by what it does - cleaner.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Rob.
zimmermann [Sun, 17 Dec 2006 12:16:31 +0000 (12:16 +0000)]
Reviewed by Rob.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11813
Pass SVGLength around by value, remove any SVGLength* usage.
Bindings work fine, as the SVG POD JS Wrapper stuff is already in svn.

No new regressions, none fixed. But the code itself is much cleaner.
And some problems with width-full-percentage.svg have been fixed, viewport
clipping works in any case now, also for percentual width/height values set on <svg>.

Still unsure if we can simulate window resizes in a layout test,
not through "width/height" property changes, but directly in any way.
If anyone knows if we can do that, please drop me a line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agomake testkjs.pro work on machines other than mine :)
hausmann [Sun, 17 Dec 2006 11:58:39 +0000 (11:58 +0000)]
make testkjs.pro work on machines other than mine :)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agofor the Qt build also build testkjs now
hausmann [Sun, 17 Dec 2006 10:50:27 +0000 (10:50 +0000)]
for the Qt build also build testkjs now

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Sun, 17 Dec 2006 04:11:20 +0000 (04:11 +0000)]
LayoutTests:

        Reviewed by Maciej.

        Update tests for http://bugs.webkit.org/show_bug.cgi?id=11856
        Update renderName() methods to return current class names.

        * dom/svg/level3/xpath/Conformance_ID-expected.txt:
        * editing/inserting/before-after-input-element-expected.txt:
        * editing/pasteboard/4806874-expected.txt:
        * editing/pasteboard/drop-text-without-selection-expected.txt:
        * editing/pasteboard/input-field-1-expected.txt:
        * editing/pasteboard/nested-blocks-with-text-area-expected.txt:
        * editing/pasteboard/nested-blocks-with-text-field-expected.txt:
        * editing/pasteboard/pasting-tabs-expected.txt:
        * editing/selection/3690703-2-expected.txt:
        * editing/selection/3690703-expected.txt:
        * editing/selection/3690719-expected.txt:
        * editing/selection/drag-select-1-expected.txt:
        * editing/selection/select-from-textfield-outwards-expected.txt:
        * fast/block/float/032-expected.txt:
        * fast/block/margin-collapse/103-expected.txt:
        * fast/css/resize-corner-tracking-expected.txt:
        * fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
        * fast/dom/isindex-002-expected.txt:
        * fast/dynamic/008-expected.txt:
        * fast/events/label-focus-expected.txt:
        * fast/forms/8250-expected.txt:
        * fast/forms/encoding-test-expected.txt:
        * fast/forms/fieldset-align-expected.txt:
        * fast/forms/floating-textfield-relayout-expected.txt:
        * fast/forms/form-element-geometry-expected.txt:
        * fast/forms/input-appearance-bkcolor-expected.txt:
        * fast/forms/input-appearance-default-bkcolor-expected.txt:
        * fast/forms/input-appearance-disabled-expected.txt:
        * fast/forms/input-appearance-focus-expected.txt:
        * fast/forms/input-appearance-height-expected.txt:
        * fast/forms/input-appearance-minWidth-expected.txt:
        * fast/forms/input-appearance-preventDefault-expected.txt:
        * fast/forms/input-appearance-readonly-expected.txt:
        * fast/forms/input-appearance-selection-expected.txt:
        * fast/forms/input-appearance-visibility-expected.txt:
        * fast/forms/input-appearance-width-expected.txt:
        * fast/forms/input-baseline-expected.txt:
        * fast/forms/input-disabled-color-expected.txt:
        * fast/forms/input-double-click-selection-gap-bug-expected.txt:
        * fast/forms/input-maxlength-2-expected.txt:
        * fast/forms/input-paste-undo-expected.txt:
        * fast/forms/input-readonly-dimmed-expected.txt:
        * fast/forms/input-readonly-empty-expected.txt:
        * fast/forms/input-spaces-expected.txt:
        * fast/forms/input-table-expected.txt:
        * fast/forms/input-text-click-inside-expected.txt:
        * fast/forms/input-text-click-outside-expected.txt:
        * fast/forms/input-text-double-click-expected.txt:
        * fast/forms/input-text-drag-down-expected.txt:
        * fast/forms/input-text-maxlength-expected.txt:
        * fast/forms/input-text-option-delete-expected.txt:
        * fast/forms/input-text-paste-maxlength-expected.txt:
        * fast/forms/input-text-scroll-left-on-blur-expected.txt:
        * fast/forms/input-text-self-emptying-click-expected.txt:
        * fast/forms/input-type-change2-expected.txt:
        * fast/forms/input-value-expected.txt:
        * fast/forms/input-width-expected.txt:
        * fast/forms/minWidthPercent-expected.txt:
        * fast/forms/negativeLineHeight-expected.txt:
        * fast/forms/plaintext-mode-2-expected.txt:
        * fast/forms/tabbing-input-iframe-expected.txt:
        * fast/forms/textAreaLineHeight-expected.txt:
        * fast/forms/textarea-scroll-height-expected.txt:
        * fast/forms/textarea-scrollbar-expected.txt:
        * fast/forms/textarea-scrolled-type-expected.txt:
        * fast/forms/textarea-setinnerhtml-expected.txt:
        * fast/forms/textfield-drag-into-disabled-expected.txt:
        * fast/forms/visual-hebrew-text-field-expected.txt:
        * fast/lists/dynamic-marker-crash-expected.txt:
        * fast/overflow/overflow-x-y-expected.txt:
        * fast/replaced/width100percent-expected.txt:
        * fast/table/003-expected.txt:
        * fast/table/colspanMinWidth-expected.txt:
        * fast/table/spanOverlapRepaint-expected.txt:
        * fast/table/text-field-baseline-expected.txt:
        * fast/text/international/rtl-white-space-pre-wrap-expected.txt:
        * fast/text/textIteratorNilRenderer-expected.txt:
        * http/tests/navigation/anchor-basic-expected.txt:
        * http/tests/navigation/anchor-frames-expected.txt:
        * http/tests/navigation/anchor-goback-expected.txt:
        * http/tests/navigation/anchor-subframeload-expected.txt:
        * http/tests/navigation/javascriptlink-basic-expected.txt:
        * http/tests/navigation/javascriptlink-frames-expected.txt:
        * http/tests/navigation/javascriptlink-goback-expected.txt:
        * http/tests/navigation/javascriptlink-subframeload-expected.txt:
        * http/tests/navigation/metaredirect-basic-expected.txt:
        * http/tests/navigation/metaredirect-frames-expected.txt:
        * http/tests/navigation/metaredirect-goback-expected.txt:
        * http/tests/navigation/metaredirect-subframeload-expected.txt:
        * http/tests/navigation/post-goback2-expected.txt:
        * http/tests/navigation/postredirect-goback2-expected.txt:
        * http/tests/navigation/redirect302-basic-expected.txt:
        * http/tests/navigation/redirect302-frames-expected.txt:
        * http/tests/navigation/redirect302-goback-expected.txt:
        * http/tests/navigation/redirect302-subframeload-expected.txt:
        * http/tests/navigation/relativeanchor-basic-expected.txt:
        * http/tests/navigation/relativeanchor-frames-expected.txt:
        * http/tests/navigation/relativeanchor-goback-expected.txt:
        * http/tests/navigation/slowmetaredirect-basic-expected.txt:
        * http/tests/navigation/slowtimerredirect-basic-expected.txt:
        * http/tests/navigation/success200-basic-expected.txt:
        * http/tests/navigation/success200-frames-expected.txt:
        * http/tests/navigation/success200-frames-loadsame-expected.txt:
        * http/tests/navigation/success200-goback-expected.txt:
        * http/tests/navigation/success200-loadsame-expected.txt:
        * http/tests/navigation/success200-reload-expected.txt:
        * http/tests/navigation/success200-subframeload-expected.txt:
        * http/tests/navigation/timerredirect-basic-expected.txt:
        * http/tests/navigation/timerredirect-frames-expected.txt:
        * http/tests/navigation/timerredirect-goback-expected.txt:
        * http/tests/navigation/timerredirect-subframeload-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
        * svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
        * svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
        * svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
        * svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
        * svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
        * svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
        * svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
        * svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
        * svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
        * svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
        * svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
        * svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
        * svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
        * svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
        * svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
        * svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
        * svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
        * svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
        * svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
        * svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
        * svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
        * svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
        * svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
        * svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
        * svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
        * svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
        * svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
        * svg/W3C-SVG-1.1/linking-a-01-b-expected.txt:
        * svg/W3C-SVG-1.1/linking-a-02-b-expected.txt:
        * svg/W3C-SVG-1.1/linking-a-03-b-expected.txt:
        * svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
        * svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
        * svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
        * svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
        * svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
        * svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
        * svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
        * svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
        * svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
        * svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
        * svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
        * svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
        * svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
        * svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
        * svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
        * svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
        * svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
        * svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
        * svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
        * svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
        * svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
        * svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
        * svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
        * svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-01-t-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-02-t-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-03-t-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
        * svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
        * svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
        * svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
        * svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
        * svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
        * svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
        * svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
        * svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
        * svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
        * svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
        * svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
        * svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-frag-01-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-group-01-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-group-02-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
        * svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
        * svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
        * svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
        * svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
        * svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
        * svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
        * svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
        * svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
        * svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
        * svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
        * svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
        * svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
        * svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
        * svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
        * svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
        * svg/custom/SVGNumber-interface-expected.txt:
        * svg/custom/SVGPoint-interface-expected.txt:
        * svg/custom/SVGPoint-matrixTransform-expected.txt:
        * svg/custom/SVGRect-interface-expected.txt:
        * svg/custom/baseval-animval-equality-expected.txt:
        * svg/custom/class-selector-expected.txt:
        * svg/custom/clip-path-with-transform-expected.txt:
        * svg/custom/conditional-processing-outside-switch-expected.txt:
        * svg/custom/control-points-for-S-and-T-expected.txt:
        * svg/custom/coords-relative-units-transforms-expected.txt:
        * svg/custom/create-metadata-element-expected.txt:
        * svg/custom/createelement-expected.txt:
        * svg/custom/dasharrayOrigin-expected.txt:
        * svg/custom/display-none-expected.txt:
        * svg/custom/dynamic-empty-path-expected.txt:
        * svg/custom/empty-merge-expected.txt:
        * svg/custom/evt-onload-expected.txt:
        * svg/custom/feComponentTransfer-Discrete-expected.txt:
        * svg/custom/feComponentTransfer-Gamma-expected.txt:
        * svg/custom/feComponentTransfer-Linear-expected.txt:
        * svg/custom/feComponentTransfer-Table-expected.txt:
        * svg/custom/feDisplacementMap-01-expected.txt:
        * svg/custom/fill-update-expected.txt:
        * svg/custom/filter-source-alpha-expected.txt:
        * svg/custom/foreign-object-skew-expected.txt:
        * svg/custom/fractional-rects-expected.txt:
        * svg/custom/getTransformToElement-expected.txt:
        * svg/custom/getsvgdocument-expected.txt:
        * svg/custom/gradient-attr-update-expected.txt:
        * svg/custom/gradient-stroke-width-expected.txt:
        * svg/custom/grayscale-gradient-mask-expected.txt:
        * svg/custom/hover-default-fill-expected.txt:
        * svg/custom/image-clipped-hit-expected.txt:
        * svg/custom/image-with-transform-clip-filter-expected.txt:
        * svg/custom/inner-percent-expected.txt:
        * svg/custom/invalid-css-expected.txt:
        * svg/custom/invalid-fill-expected.txt:
        * svg/custom/invalid-transforms-expected.txt:
        * svg/custom/invalid-viewbox1-expected.txt:
        * svg/custom/invalid-viewbox2-expected.txt:
        * svg/custom/junk-data-expected.txt:
        * svg/custom/marker-overflow-clip-expected.txt:
        * svg/custom/mask-inside-defs-expected.txt:
        * svg/custom/missing-xlink-expected.txt:
        * svg/custom/non-opaque-filters-expected.txt:
        * svg/custom/path-bad-data-expected.txt:
        * svg/custom/path-update-expected.txt:
        * svg/custom/pattern-in-defs-expected.txt:
        * svg/custom/pattern-y-offset-expected.txt:
        * svg/custom/percentage-rect-expected.txt:
        * svg/custom/percentage-rect2-expected.txt:
        * svg/custom/pointer-events-path-expected.txt:
        * svg/custom/polyline-hittest-expected.txt:
        * svg/custom/polyline-invalid-points-expected.txt:
        * svg/custom/polyline-setattribute-points-null-expected.txt:
        * svg/custom/recursive-clippath-expected.txt:
        * svg/custom/rootelement-expected.txt:
        * svg/custom/rounded-rects-expected.txt:
        * svg/custom/sheet-title-expected.txt:
        * svg/custom/simpleCDF-expected.txt:
        * svg/custom/svg-overflow-types-expected.txt:
        * svg/custom/svgpolyparser-extra-space-expected.txt:
        * svg/custom/text-clip-expected.txt:
        * svg/custom/text-ctm-expected.txt:
        * svg/custom/text-filter-expected.txt:
        * svg/custom/text-gradient-no-content-expected.txt:
        * svg/custom/text-hit-test-expected.txt:
        * svg/custom/text-image-opacity-expected.txt:
        * svg/custom/transform-ignore-after-invalid-expected.txt:
        * svg/custom/transform-invalid-expected.txt:
        * svg/custom/transform-scale-parse-expected.txt:
        * svg/custom/transform-with-ending-space-expected.txt:
        * svg/custom/tref-update-expected.txt:
        * svg/custom/use-forward-refs-expected.txt:
        * svg/custom/viewport-clip-expected.txt:
        * svg/custom/viewport-em-expected.txt:
        * svg/custom/viewport-no-width-height-expected.txt:
        * svg/custom/viewport-update-expected.txt:
        * svg/custom/viewport-update2-expected.txt:
        * svg/custom/width-full-percentage-expected.txt:
        * svg/hixie/cascade/002-expected.txt:
        * svg/hixie/viewbox/003-expected.txt:
        * tables/mozilla/bugs/45621-expected.txt:
        * tables/mozilla/bugs/bug1188-expected.txt:
        * tables/mozilla/bugs/bug12384-expected.txt:
        * tables/mozilla/bugs/bug18359-expected.txt:
        * tables/mozilla/bugs/bug194024-expected.txt:
        * tables/mozilla/bugs/bug24200-expected.txt:
        * tables/mozilla/bugs/bug2479-3-expected.txt:
        * tables/mozilla/bugs/bug2479-4-expected.txt:
        * tables/mozilla/bugs/bug28928-expected.txt:
        * tables/mozilla/bugs/bug30559-expected.txt:
        * tables/mozilla/bugs/bug30692-expected.txt:
        * tables/mozilla/bugs/bug4382-expected.txt:
        * tables/mozilla/bugs/bug4527-expected.txt:
        * tables/mozilla/bugs/bug46368-1-expected.txt:
        * tables/mozilla/bugs/bug46368-2-expected.txt:
        * tables/mozilla/bugs/bug51037-expected.txt:
        * tables/mozilla/bugs/bug55545-expected.txt:
        * tables/mozilla/bugs/bug59354-expected.txt:
        * tables/mozilla/bugs/bug7342-expected.txt:
        * tables/mozilla/bugs/bug96334-expected.txt:
        * tables/mozilla/bugs/bug99948-expected.txt:
        * tables/mozilla/dom/tableDom-expected.txt:
        * tables/mozilla/other/move_row-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug2479-2-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

WebCore:

        Reviewed by Maciej.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=11856
        Update renderName() methods to return current class names.

        * rendering/RenderPath.h:
        (WebCore::RenderPath::renderName): Returns "RenderPath" instead of "KCanvasItem".
        * rendering/RenderSVGContainer.h:
        (WebCore::RenderSVGContainer::renderName): Returns "RenderSVGContainer" instead of "KCanvasContainer".
        * rendering/RenderTextControl.h:
        (WebCore::RenderTextControl::renderName): Returns "RenderTextControl" instead of "RenderTextField".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
weinig [Sat, 16 Dec 2006 23:36:48 +0000 (23:36 +0000)]
    Reviewed by Mitz.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=11844
        Code Cleanup for more of the rendering code

        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderCounter.cpp:
        (WebCore::RenderCounter::calcMinMaxWidth):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::RenderText):
        (WebCore::RenderText::setStyle):
        (WebCore::RenderText::destroy):
        (WebCore::RenderText::attachTextBox):
        (WebCore::RenderText::findNextInlineTextBox):
        (WebCore::RenderText::positionForCoordinates):
        (WebCore::firstRendererOnNextLine):
        (WebCore::lastRendererOnPrevLine):
        (WebCore::RenderText::caretRect):
        (WebCore::RenderText::posOfChar):
        (WebCore::RenderText::allAscii):
        (WebCore::RenderText::shouldUseMonospaceCache):
        (WebCore::RenderText::cacheWidths):
        (WebCore::RenderText::widthFromCache):
        (WebCore::RenderText::trimmedMinMaxWidth):
        (WebCore::RenderText::calcMinMaxWidth):
        (WebCore::isSpaceAccordingToStyle):
        (WebCore::RenderText::containsOnlyWhitespace):
        (WebCore::RenderText::minXPos):
        (WebCore::RenderText::setSelectionState):
        (WebCore::RenderText::setTextWithOffset):
        (WebCore::RenderText::setText):
        (WebCore::RenderText::position):
        (WebCore::RenderText::width):
        (WebCore::RenderText::getAbsoluteRepaintRect):
        (WebCore::RenderText::selectionRect):
        (WebCore::RenderText::verticalPositionHint):
        (WebCore::RenderText::font):
        (WebCore::RenderText::caretMinOffset):
        (WebCore::RenderText::caretMaxOffset):
        (WebCore::RenderText::previousOffset):
        (WebCore::RenderText::nextOffset):
        (WebCore::RenderText::inlineBox):
        * rendering/RenderText.h:
        (WebCore::RenderText::isTextFragment):
        (WebCore::RenderText::data):
        (WebCore::RenderText::string):
        (WebCore::RenderText::paint):
        (WebCore::RenderText::layout):
        (WebCore::RenderText::nodeAtPoint):
        (WebCore::RenderText::length):
        (WebCore::RenderText::text):
        (WebCore::RenderText::stringLength):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::setStyle):
        (WebCore::disabledTextColor):
        (WebCore::RenderTextControl::createInnerBlockStyle):
        (WebCore::RenderTextControl::createInnerTextStyle):
        (WebCore::RenderTextControl::createResultsButtonStyle):
        (WebCore::RenderTextControl::createCancelButtonStyle):
        (WebCore::RenderTextControl::showPlaceholderIfNeeded):
        (WebCore::RenderTextControl::hidePlaceholderIfNeeded):
        (WebCore::RenderTextControl::createSubtreeIfNeeded):
        (WebCore::RenderTextControl::updateFromElement):
        (WebCore::RenderTextControl::selectionStart):
        (WebCore::RenderTextControl::setSelectionRange):
        (WebCore::RenderTextControl::visiblePositionForIndex):
        (WebCore::RenderTextControl::subtreeHasChanged):
        (WebCore::RenderTextControl::textWithHardLineBreaks):
        (WebCore::RenderTextControl::calcHeight):
        (WebCore::RenderTextControl::nodeAtPoint):
        (WebCore::RenderTextControl::layout):
        (WebCore::RenderTextControl::calcMinMaxWidth):
        (WebCore::RenderTextControl::addSearchResult):
        (WebCore::RenderTextControl::showPopup):
        (WebCore::RenderTextControl::itemText):
        (WebCore::RenderTextControl::itemIsEnabled):
        (WebCore::RenderTextControl::listSize):
        (WebCore::RenderTextControl::scroll):
        * rendering/RenderTextControl.h:
        (WebCore::RenderTextControl::renderName):
        (WebCore::RenderTextControl::removeLeftoverAnonymousBoxes):
        * rendering/RenderTextFragment.cpp:
        (WebCore::RenderTextFragment::RenderTextFragment):
        (WebCore::RenderTextFragment::originalString):
        * rendering/RenderTextFragment.h:
        (WebCore::RenderTextFragment::isTextFragment):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::adjustStyle):
        (WebCore::RenderTheme::isControlStyled):
        (WebCore::RenderTheme::stateChanged):
        (WebCore::RenderTheme::adjustCheckboxStyle):
        (WebCore::RenderTheme::adjustRadioStyle):
        * rendering/RenderTheme.h:
        (WebCore::):
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::RenderThemeMac):
        (WebCore::RenderThemeMac::platformActiveSelectionBackgroundColor):
        (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor):
        (WebCore::RenderThemeMac::activeListBoxSelectionBackgroundColor):
        (WebCore::RenderThemeMac::systemFont):
        (WebCore::RenderThemeMac::isControlStyled):
        (WebCore::RenderThemeMac::adjustRepaintRect):
        (WebCore::RenderThemeMac::updateCheckedState):
        (WebCore::RenderThemeMac::controlSupportsTints):
        (WebCore::RenderThemeMac::setFontFromControlSize):
        (WebCore::RenderThemeMac::paintCheckbox):
        (WebCore::RenderThemeMac::checkboxMargins):
        (WebCore::RenderThemeMac::setCheckboxCellState):
        (WebCore::RenderThemeMac::setCheckboxSize):
        (WebCore::RenderThemeMac::paintRadio):
        (WebCore::RenderThemeMac::radioMargins):
        (WebCore::RenderThemeMac::setRadioCellState):
        (WebCore::RenderThemeMac::setRadioSize):
        (WebCore::RenderThemeMac::adjustButtonStyle):
        (WebCore::RenderThemeMac::buttonMargins):
        (WebCore::RenderThemeMac::setButtonSize):
        (WebCore::RenderThemeMac::setButtonCellState):
        (WebCore::RenderThemeMac::adjustTextFieldStyle):
        (WebCore::RenderThemeMac::adjustTextAreaStyle):
        (WebCore::RenderThemeMac::popupButtonMargins):
        (WebCore::RenderThemeMac::popupButtonPadding):
        (WebCore::TopGradientInterpolate):
        (WebCore::BottomGradientInterpolate):
        (WebCore::MainGradientInterpolate):
        (WebCore::TrackGradientInterpolate):
        (WebCore::RenderThemeMac::paintMenuListButtonGradients):
        (WebCore::RenderThemeMac::paintMenuListButton):
        (WebCore::RenderThemeMac::adjustMenuListStyle):
        (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
        (WebCore::RenderThemeMac::paintSliderTrack):
        (WebCore::RenderThemeMac::paintSliderThumb):
        (WebCore::RenderThemeMac::paintSearchField):
        (WebCore::RenderThemeMac::setSearchCellState):
        (WebCore::RenderThemeMac::adjustSearchFieldStyle):
        (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
        (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::operator<<):
        (WebCore::writeIndent):
        (WebCore::printBorderStyle):
        (WebCore::getTagName):
        (WebCore::isEmptyOrUnstyledAppleStyleSpan):
        (WebCore::writeTextRun):
        (WebCore::write):
        (WebCore::writeLayers):
        (WebCore::nodePosition):
        (WebCore::writeSelection):
        * rendering/RenderTreeAsText.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::RenderView):
        (WebCore::RenderView::calcMinMaxWidth):
        (WebCore::RenderView::layout):
        (WebCore::RenderView::absolutePosition):
        (WebCore::RenderView::paint):
        (WebCore::RenderView::repaintViewRectangle):
        (WebCore::rendererAfterPosition):
        (WebCore::RenderView::selectionRect):
        (WebCore::RenderView::setSelection):
        (WebCore::RenderView::selectionStartEnd):
        (WebCore::RenderView::updateWidgetPositions):
        (WebCore::RenderView::addWidget):
        (WebCore::RenderView::removeWidget):
        (WebCore::RenderView::viewRect):
        (WebCore::RenderView::docHeight):
        (WebCore::RenderView::docWidth):
        (WebCore::RenderView::setBestTruncatedAt):
        * rendering/RenderView.h:
        (WebCore::RenderView::renderName):
        (WebCore::RenderView::selectionStart):
        (WebCore::RenderView::selectionEnd):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::destroy):
        (WebCore::RenderWidget::resizeWidget):
        (WebCore::RenderWidget::setStyle):
        (WebCore::RenderWidget::paint):
        (WebCore::RenderWidget::updateWidgetPosition):
        (WebCore::RenderWidget::setSelectionState):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::placeEllipsis):
        (WebCore::RootInlineBox::fillLineSelectionGap):
        (WebCore::RootInlineBox::selectionState):
        (WebCore::RootInlineBox::firstSelectedBox):
        (WebCore::RootInlineBox::lastSelectedBox):
        (WebCore::RootInlineBox::selectionTop):
        (WebCore::RootInlineBox::closestLeafChildForXPos):
        * rendering/RootInlineBox.h:
        (WebCore::RootInlineBox::isRootInlineBox):
        (WebCore::RootInlineBox::setVerticalOverflowPositions):
        (WebCore::RootInlineBox::setHorizontalOverflowPositions):
        (WebCore::RootInlineBox::setVerticalSelectionPositions):
        (WebCore::RootInlineBox::lineBreakObj):
        (WebCore::RootInlineBox::lineBreakPos):
        (WebCore::RootInlineBox::setLineBreakPos):
        (WebCore::RootInlineBox::blockHeight):
        (WebCore::RootInlineBox::setBlockHeight):
        (WebCore::RootInlineBox::endsWithBreak):
        (WebCore::RootInlineBox::setEndsWithBreak):
        * rendering/SVGInlineFlowBox.cpp:
        (WebCore::SVGInlineFlowBox::paint):
        (WebCore::paintSVGInlineFlow):
        (WebCore::translateBox):
        (WebCore::placePositionedBoxesHorizontally):
        (WebCore::placeBoxesVerticallyWithAbsBaseline):
        (WebCore::placeSVGFlowVertically):
        * rendering/SVGInlineFlowBox.h:
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::TextStreamSeparator::TextStreamSeparator):
        (WebCore::operator<<):
        (WebCore::hasFractions):
        (WebCore::writeIndent):
        (WebCore::writeStyle):
        (WebCore::getTagName):
        (WebCore::write):
        (WebCore::writeRenderResources):
        * rendering/SVGRenderTreeAsText.h:
        (WebCore::operator<<):
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::paint):
        (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
        * rendering/SVGRootInlineBox.h:
        * rendering/TableLayout.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fixes.
aroben [Sat, 16 Dec 2006 23:34:50 +0000 (23:34 +0000)]
    Build fixes.

        * platform/ContextMenuItem.h: Fixed const declarations.
        * platform/mac/ContextMenuItemMac.mm: Dito.
        (WebCore::ContextMenuItem::type):
        (WebCore::ContextMenuItem::setTitle):
        (WebCore::ContextMenuItem::setChecked):
        (WebCore::ContextMenuItem::setEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Sat, 16 Dec 2006 21:30:18 +0000 (21:30 +0000)]
LayoutTests:

        Reviewed by Maciej.

        Test for http://bugs.webkit.org/show_bug.cgi?id=11189
        <rdar://problem/4770249> REGRESSION (NativeListBox): When a list box has focus, pressing command- A (select all) doesn't selected all items in list

        * fast/forms/listbox-select-all-expected.txt: Added.
        * fast/forms/listbox-select-all.html: Added.

WebCore:

        Reviewed by Maciej.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=11189
        <rdar://problem/4770249> REGRESSION (NativeListBox): When a list box has focus, pressing command- A (select all) doesn't selected all items in list

        Test: fast/forms/listbox-select-all.html

        * dom/Node.h: We should try to find a more appropriate place to put these methods.
        (WebCore::Node::canSelectAll): Added.
        (WebCore::Node::selectAll): Added.
        * editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): Before selecting editable content, give the focused node
          a chance to select its content.
        * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::selectAll): Selects all items in a multi-select list box.  Single-select
          list boxes will just do nothing, but we still want the select to handle this case when it has focus, rather than selecting other content.
        * html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::canSelectAll): Returns true for list boxes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd a stub for SearchPopupMenu for Qt.
zack [Sat, 16 Dec 2006 16:54:34 +0000 (16:54 +0000)]
Add a stub for SearchPopupMenu for Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdjust Qt code to the last nights changes (make it compile)
zack [Sat, 16 Dec 2006 16:45:36 +0000 (16:45 +0000)]
Adjust Qt code to the last nights changes (make it compile)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Rob.
ap [Sat, 16 Dec 2006 12:31:30 +0000 (12:31 +0000)]
    Reviewed by Rob.

        A deleted object was accessed to prepare RegExp construction error messages.

        * kjs/regexp_object.cpp:
        (RegExpObjectImp::construct): Wrap the RegExp into an OwnPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago One more...
adele [Sat, 16 Dec 2006 10:56:03 +0000 (10:56 +0000)]
    One more...

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Missed one instance of isNonWidgetTextField.
adele [Sat, 16 Dec 2006 10:51:41 +0000 (10:51 +0000)]
    Missed one instance of isNonWidgetTextField.

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::doApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-12-16 Hunter L. Williams <hlwebkit@gmail.com>
ap [Sat, 16 Dec 2006 10:47:35 +0000 (10:47 +0000)]
2006-12-16  Hunter L. Williams <hlwebkit@gmail.com>

        Reviewed by Adele.

        Fix mouse wheel scrolling in <textarea> controls.

        * rendering/RenderTextControl.cpp:
        * rendering/RenderTextControl.h:
        Override |scroll| on RenderTextControl to forward the call to the RenderObject of the
        inner m_innerText, which has a layer that can be scrolled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago RS by Adam.
adele [Sat, 16 Dec 2006 10:38:15 +0000 (10:38 +0000)]
    RS by Adam.

        Removed RenderLineEdit, TextField, WebCoreTextField classes, and use of isNonWidgetTextField,

        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::isKeyboardFocusable):
        (WebCore::HTMLInputElement::isMouseFocusable):
        (WebCore::HTMLInputElement::focus):
        (WebCore::HTMLInputElement::updateFocusAppearance):
        (WebCore::HTMLInputElement::aboutToUnload):
        (WebCore::HTMLInputElement::dispatchFocusEvent):
        (WebCore::HTMLInputElement::dispatchBlurEvent):
        (WebCore::HTMLInputElement::setValue):
        (WebCore::HTMLInputElement::defaultEventHandler):
        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::isTextField):
        * html/HTMLTextFieldInnerElement.cpp:
        (WebCore::HTMLTextFieldInnerTextElement::defaultEventHandler):
        * platform/TextField.h: Removed.
        * platform/mac/TextFieldMac.mm: Removed.
        * platform/mac/WebCoreTextField.h: Removed.
        * platform/mac/WebCoreTextField.mm: Removed.
        * rendering/RenderLineEdit.cpp: Removed.
        * rendering/RenderLineEdit.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Two more files I forgot to svn add for search fields.
adele [Sat, 16 Dec 2006 10:18:53 +0000 (10:18 +0000)]
    Two more files I forgot to svn add for search fields.

        * platform/SearchPopupMenu.h: Added.
        (WebCore::SearchPopupMenu::create):
        * platform/mac/SearchPopupMenuMac.mm: Added.
        (WebCore::SearchPopupMenu::SearchPopupMenu):
        (WebCore::autosaveKey):
        (WebCore::SearchPopupMenu::saveRecentSearches):
        (WebCore::SearchPopupMenu::loadRecentSearches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
adele [Sat, 16 Dec 2006 10:12:23 +0000 (10:12 +0000)]
    Reviewed by Adam.

        * platform/PopupMenuClient.h: Added. Broken out of PopupMenu class.
        (WebCore::PopupMenuClient::~PopupMenuClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-12-16 Mitz Pettel <mitz@webkit.org>
ap [Sat, 16 Dec 2006 10:00:07 +0000 (10:00 +0000)]
2006-12-16  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Oliver.

        - http://bugs.webkit.org/show_bug.cgi?id=11831
          REGRESSION: pixel test failing for editing/selection/select-all-005.html

        * editing/selection/select-all-005-expected.txt: Reverted to the original
          expected result for this test.
        * editing/selection/select-all-005.html: Eliminated a script element that was
          added outside the body, so that the selection will encompass the entire html
          element as originally intended.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Sat, 16 Dec 2006 09:56:49 +0000 (09:56 +0000)]
LayoutTests:

        Reviewed by Adam.

        Updated test results for:
        <rdar://problem/4463829> Switch to use new search field implementation for <input type="search">

        * fast/events/onchange-searchfield-expected.txt:
        * fast/forms/input-appearance-height-expected.checksum:
        * fast/forms/input-appearance-height-expected.png:
        * fast/forms/input-appearance-height-expected.txt:

WebCore:

        Reviewed by Adam.

        WebCore part of fix for:
        <rdar://problem/4463829> Switch to use new search field implementation for <input type="search">

        * WebCore.xcodeproj/project.pbxproj: Added SearchPopupMenu.h, SearchPopupMenuMac.mm, and PopupMenuClient.h.

        Added pseudo classes and corresponding values for -webkit appearance for the cancel button and for the three types of "decoration" that
        correspond to the different functions of the magnifier glass in the search field.  One for the button that will show and hide the
        recent searches menu.  One for decoration when the results attribute is set, but no results are saved.  And one for decoration
        when no results attribute is set.  We added these different pseudo elements so that RenderTextControl can decide which pseudo class
        is appropriate, and each theme can decide for itself which kind of image is appropriate for each function.

        * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h: (WebCore::CSSSelector::): Added to PseudoType enum.
        * css/CSSValueKeywords.in: Added searchfield-decoration, searchfield-results-decoration, searchfield-results-button, searchfield-cancel-button values.
        * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Added cases for -webkit-search-cancel-button,
          -webkit-search-decoration, -webkit-search-results-decoration, -webkit-search-results-button
        * rendering/RenderStyle.cpp: Addes new pseudoBits for matching pseudoIds.
        (WebCore::):
        (WebCore::pseudoBit):
        * rendering/RenderStyle.h: Added new appearance values and pseudoIds.
        (WebCore::):
        (WebCore::RenderStyle::):
        * css/html4.css: Added style for input[type=search], and the new pseudo elements.

        The structure of the shadow DOM for new search field adds an intermediate block that contains 3 inline-blocks for the magnifier, text element, and cancel button.
        Since the tree has become deeper, some editing and event code that used to check for a shadowParent, really needs to check the shadowAncestorNode.

        * editing/Editor.cpp: (WebCore::Editor::dispatchCPPEvent): Check shadowAncestorNode instead of shadowParentNode.
        * editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): ditto.
        * editing/htmlediting.cpp:
        (WebCore::firstEditablePositionAfterPositionInRoot): ditto.
        (WebCore::lastEditablePositionBeforePositionInRoot): ditto.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment): ditto.
        (WebCore::ReplaceSelectionCommand::shouldMerge): Nil check enclosingBlock call.  I ran into this while testing search fields in mixed editability.
        (WebCore::ReplaceSelectionCommand::doApply): ditto.

        * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Remove use of RenderLineEdit.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::selectionStart): ditto.
        (WebCore::HTMLInputElement::selectionEnd): ditto.
        (WebCore::HTMLInputElement::setSelectionStart): ditto.
        (WebCore::HTMLInputElement::setSelectionEnd): ditto.
        (WebCore::HTMLInputElement::select): ditto.
        (WebCore::HTMLInputElement::setSelectionRange): ditto.
        (WebCore::HTMLInputElement::parseMappedAttribute): ditto.
        (WebCore::HTMLInputElement::createRenderer): ditto.
        (WebCore::HTMLInputElement::defaultEventHandler): ditto.
        (WebCore::HTMLInputElement::addSearchResult): Added. Calls addSearchResult on the renderer.
        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::isNonWidgetTextField): Added case for search field.
        (WebCore::HTMLInputElement::isSearchField): Added.

        * platform/PopupMenu.h: Broke PopupMenuClient out into a separate file.
        * platform/PopupMenuClient.h: Added.
        (WebCore::PopupMenuClient::~PopupMenuClient):
        * platform/graphics/Icon.h:

        * platform/SearchPopupMenu.h: Added. Saves and loads recent search vector.
        (WebCore::SearchPopupMenu::create):
        * platform/mac/SearchPopupMenuMac.mm: Added.
        (WebCore::SearchPopupMenu::SearchPopupMenu):
        (WebCore::autosaveKey):
        (WebCore::SearchPopupMenu::saveRecentSearches):
        (WebCore::SearchPopupMenu::loadRecentSearches):

        * html/HTMLTextFieldInnerElement.h: Reorganized this class.
          Added subclasses HTMLTextFieldInnerTextElement, HTMLSearchFieldResultsButtonElement, HTMLSearchFieldCancelButtonElement
        (WebCore::HTMLTextFieldInnerElement::isMouseFocusable): Added.  Returns false so setFocusNodeIfNeeded
         will try to focus the input element instead of nodes in the shadow tree.
        (WebCore::HTMLTextFieldInnerElement::isShadowNode): Now returns whether or not a shadowParent has been specified.
         * html/HTMLTextFieldInnerElement.cpp:
        (WebCore::HTMLTextFieldInnerTextElement::HTMLTextFieldInnerTextElement):
        (WebCore::HTMLTextFieldInnerTextElement::defaultEventHandler): Moved this from the old HTMLTextFieldInnerElement class.
        (WebCore::HTMLSearchFieldResultsButtonElement::HTMLSearchFieldResultsButtonElement):
        (WebCore::HTMLSearchFieldResultsButtonElement::defaultEventHandler): Shows and hides recent searches menu.
        (WebCore::HTMLSearchFieldCancelButtonElement::HTMLSearchFieldCancelButtonElement):
        (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler): On mouse up, clears the value from the text field.

       * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::listSize): Changed return type to unsigned.
        * rendering/RenderMenuList.h: (WebCore::RenderMenuList::valueShouldChangeOnHotTrack): Added.

        * WebCore.exp: Export _wkDrawTextFieldCellFocusRing.
        * platform/mac/WebCoreSystemInterface.h: Added wkDrawTextFieldCellFocusRing
        * platform/mac/WebCoreSystemInterface.mm: ditto.

        * rendering/RenderTextControl.h:
        (WebCore::RenderTextControl::popupIsVisible): Added so HTMLSearchFieldResultsButtonElement knows whether or not the menu is already up.
        (WebCore::RenderTextControl::shouldPopOver): Added as a PopupClient method so the results menu shows up under the control instead of over.
        (WebCore::RenderTextControl::valueShouldChangeOnHotTrack):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::RenderTextControl): Initialize m_placeholderIsVisible, m_searchPopup, and m_searchPopupIsVisible.
        (WebCore::RenderTextControl::~RenderTextControl): Detach the node at the top of the shadow tree (m_innerBlock for search fields, and m_innerText for other text controls).
        (WebCore::RenderTextControl::setStyle): Sets style on new elements.
        (WebCore::disabledTextColor): Added so this can be used in setPlaceholder.
        (WebCore::RenderTextControl::createInnerBlockStyle): Added.
        (WebCore::RenderTextControl::createInnerTextStyle): Added.
        (WebCore::RenderTextControl::createResultsButtonStyle): Added.
        (WebCore::RenderTextControl::createCancelButtonStyle): Added.
        (WebCore::RenderTextControl::showPlaceholderIfNeeded): Added. Shows the placeholder if there's no value and the field doesn't have focus.
        (WebCore::RenderTextControl::hidePlaceholderIfNeeded): Added. Clears the placeholder if there's a value or the field has focus.
        (WebCore::RenderTextControl::createSubtreeIfNeeded): Added. Creates all of the shadow tree elements.
        (WebCore::RenderTextControl::updateFromElement): Calls showPlaceholderIfNeeded.
        (WebCore::RenderTextControl::visiblePositionForIndex): Renaming (m_div to m_innerText).
        (WebCore::RenderTextControl::indexForVisiblePosition): ditto.
        (WebCore::RenderTextControl::updateCancelButtonVisibility): Shows and hides cancel button based on the value of the control.
        (WebCore::RenderTextControl::subtreeHasChanged): Fires onSearch if the incremental attribute is set.
        (WebCore::RenderTextControl::text): Renaming.
        (WebCore::RenderTextControl::textWithHardLineBreaks): ditto.
        (WebCore::RenderTextControl::calcHeight): Take the size of the results button and cancel button into account when calculating height.
        (WebCore::RenderTextControl::nodeAtPoint): Act as if we've hit the shadow tree elements based on the x coordinate of the mouse event.
        (WebCore::RenderTextControl::layout): Set the height and width of the text block taking the other shadow tree elements into account.
        (WebCore::RenderTextControl::calcMinMaxWidth): Take new shadow tree elements into account when calculating width.
        (WebCore::RenderTextControl::forwardEvent): Forward events to appropriate shadow nodes.
        (WebCore::RenderTextControl::scrollWidth): Renaming.
        (WebCore::RenderTextControl::scrollHeight): ditto.
        (WebCore::RenderTextControl::scrollLeft): ditto.
        (WebCore::RenderTextControl::scrollTop): ditto.
        (WebCore::RenderTextControl::setScrollLeft): ditto.
        (WebCore::RenderTextControl::setScrollTop): ditto.
        (WebCore::RenderTextControl::autosaveName): ditto.
        (WebCore::RenderTextControl::addSearchResult): Added. Saves value to search result list.
        (WebCore::RenderTextControl::onSearch): Added. Dispatches search event.
        (WebCore::RenderTextControl::showPopup): Added. Loads searches, and displays menu.
        (WebCore::RenderTextControl::hidePopup): Added PopupClient method.
        (WebCore::RenderTextControl::valueChanged): Added PopupClient method. Interprets the selected menu item index, and either sets the value and
         fires onSearch, or clears all recent searches for this autosave name.
        (WebCore::RenderTextControl::itemText): Added PopupClient method.
        (WebCore::RenderTextControl::itemIsEnabled): Added PopupClient method.
        (WebCore::RenderTextControl::itemStyle): ditto.
        (WebCore::RenderTextControl::clientStyle): ditto.
        (WebCore::RenderTextControl::clientDocument): ditto.
        (WebCore::RenderTextControl::clientPaddingLeft): ditto.
        (WebCore::RenderTextControl::clientPaddingRight): ditto.
        (WebCore::RenderTextControl::listSize): ditto.
        (WebCore::RenderTextControl::selectedIndex): ditto.
        (WebCore::RenderTextControl::itemIsSeparator): ditto.
        (WebCore::RenderTextControl::itemIsLabel): ditto.
        (WebCore::RenderTextControl::itemIsSelected): ditto.
        (WebCore::RenderTextControl::setTextFromItem): ditto.

        * rendering/RenderTheme.cpp: Added search field theme.
        (WebCore::RenderTheme::adjustStyle):
        (WebCore::RenderTheme::paint):
        (WebCore::RenderTheme::paintBorderOnly):
        (WebCore::RenderTheme::paintDecorations):
        (WebCore::RenderTheme::isControlStyled): Returns false for search fields, until we've worked out the kinks.
        (WebCore::RenderTheme::adjustSearchFieldStyle):
        (WebCore::RenderTheme::adjustSearchFieldCancelButtonStyle):
        (WebCore::RenderTheme::adjustSearchFieldDecorationStyle):
        (WebCore::RenderTheme::adjustSearchFieldResultsDecorationStyle):
        (WebCore::RenderTheme::adjustSearchFieldResultsButtonStyle):
        * rendering/RenderTheme.h:
        (WebCore::RenderTheme::paintSearchField):
        (WebCore::RenderTheme::paintSearchFieldCancelButton):
        (WebCore::RenderTheme::paintSearchFieldDecoration):
        (WebCore::RenderTheme::paintSearchFieldResultsDecoration):
        (WebCore::RenderTheme::paintSearchFieldResultsButton):
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::RenderThemeMac):
        (WebCore::RenderThemeMac::sizeForSystemFont): Added.  Compares style's font to systemFontSizeForControlSize to determine
         what controlSize to use after a style's font has already been initially adjusted.
        (WebCore::RenderThemeMac::controlSizeForSystemFont): Added. ditto.
        (WebCore::RenderThemeMac::paintCheckbox):
        (WebCore::RenderThemeMac::paintRadio):
        (WebCore::RenderThemeMac::menuListSizes):
        (WebCore::RenderThemeMac::minimumMenuListSize): Uses sizeForSystemFont instead of hardcoded adjusted font sizes.
        (WebCore::RenderThemeMac::paintSearchField):
        (WebCore::RenderThemeMac::setSearchCellState):
        (WebCore::RenderThemeMac::adjustSearchFieldStyle):
        (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
        (WebCore::RenderThemeMac::cancelButtonSizes):
        (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
        (WebCore::RenderThemeMac::resultsButtonSizes):
        (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
        (WebCore::RenderThemeMac::paintSearchFieldDecoration):
        (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
        (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
        (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
        (WebCore::RenderThemeMac::paintSearchFieldResultsButton):

WebKit:

        Reviewed by Adam.

        WebKit part of fix for:
        <rdar://problem/4463829> Switch to use new search field implementation for <input type="search">

        * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Initialize WKDrawTextFieldCellFocusRing.
        * WebInspector/webInspector/inspector.css: Set -webkit-user-select:text and text-shadow:none on the search field.
          These are both properties that we didn't honor in the old control, and the inherited values didn't work or look right.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-12-16 Mitz Pettel <mitz@webkit.org>
ap [Sat, 16 Dec 2006 09:51:22 +0000 (09:51 +0000)]
2006-12-16  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Alexey.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11814
          REGRESSION(r18098): Find does not work with capital letters

        Test: editing/execCommand/findString-3.html

        * wtf/unicode/icu/UnicodeIcu.h:
        (WTF::Unicode::foldCase): Changed to not return an error if the result fits
        in the buffer without a null terminator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
adele [Sat, 16 Dec 2006 09:50:46 +0000 (09:50 +0000)]
    Reviewed by Adam.

        WebKitLibraries part of fix for:
        <rdar://problem/4463829> Switch to use new search field implementation for <input type="search">

        Added wkDrawTextFieldCellFocusRing.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterface.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
bdakin [Sat, 16 Dec 2006 09:33:51 +0000 (09:33 +0000)]
WebCore:
        Reviewed by Adam (and partially Geoff).

        Primarily, this patch gives WebCore context menus the ability to
        enable/disable and set state. It does a few other things along the
        way, though. Some of the more noticeable things:
               -Re-architects the ContextMenuItem class a bit so that the
                ownership model is a bit less confusing. ContextMenuItem is
                now *purely* a wrapper for the platformDescription. There
                are no other member variables. If you ever need the
                platformDescription outside of the MenuItem class, you have
                to call releasePlatformDescription(), which transfers
                ownership of the platformDescription to the caller.
               -Moves fontForSelection() from FrameMac into Editor.cpp.
                Turns out I don't need to use this function for my patch
                after all, but it doesn't seem like a terrible idea to move
                it anyway since we seem to be moving things from FrameMac
                into Editor these days anyway.
WebKit:
        Reviewed by Adam.

        WebKit side of making WebCore context menus support state and
        enabled/disabled.

        * WebCoreSupport/WebContextMenuClient.h: contextMenuItemSelected
        takes a pointer to the parentMenu now since menu items no longer
        hold onto it.
        * WebCoreSupport/WebContextMenuClient.mm: Same.
        (WebContextMenuClient::contextMenuItemSelected): Same.
        * WebView/WebHTMLView.m: Must call setAutoenablesItems:NO on our
        menu.
        (-[NSArray menuForEvent:]):
        * WebView/WebUIDelegatePrivate.h: No need for if-def.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-12-15 MorganL <morganl.webkit@yahoo.com>
bdash [Sat, 16 Dec 2006 02:50:12 +0000 (02:50 +0000)]
2006-12-15  MorganL  <morganl.webkit@yahoo.com>

        Reviewed by Oliver.

        Allow images to load into frames again.  Tidy up code a bit and
        add some much needed documentation.

        * platform/MimeTypeRegistry.cpp:
        (WebCore::initialiseSupportedImageMIMETypes):
        (WebCore::initialiseSupportedNonImageMimeTypes):
        * platform/MimeTypeRegistry.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix build.
andersca [Sat, 16 Dec 2006 00:41:15 +0000 (00:41 +0000)]
    Fix build.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::response):
        (WebCore::DocumentLoader::setResponse):
        (WebCore::DocumentLoader::isStopping):
        (WebCore::DocumentLoader::mainDocumentError):
        * loader/DocumentLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
andersca [Sat, 16 Dec 2006 00:05:59 +0000 (00:05 +0000)]
WebCore:

        Reviewed by Geoff.

        More loader cleanup.

        * loader/DocumentLoader.h:
        (WebCore::DocumentLoader::isStopping):
        (WebCore::DocumentLoader::response):
        (WebCore::DocumentLoader::mainDocumentError):
        (WebCore::DocumentLoader::setResponse):
        * loader/FrameLoader.h:
        * loader/FrameLoaderClient.h:
        * loader/mac/DocumentLoaderMac.mm:
        (WebCore::DocumentLoader::DocumentLoader):
        (WebCore::DocumentLoader::stopLoading):
        (WebCore::DocumentLoader::receivedData):
        (WebCore::DocumentLoader::setupForReplaceByMIMEType):
        (WebCore::DocumentLoader::prepareForLoadStart):
        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::commitProvisionalLoad):
        (WebCore::FrameLoader::setResponse):
        * loader/mac/ImageDocumentMac.mm:
        (WebCore::finishImageLoad):

WebKit:

        Reviewed by Geoff.

        Update for WebCore changes.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
        * WebView/WebDataSource.mm:
        (-[WebDataSource response]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * loader/DocumentLoader.h:
andersca [Fri, 15 Dec 2006 22:58:57 +0000 (22:58 +0000)]
    * loader/DocumentLoader.h:
        Whoops, didn't mean to commit this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin and Brady (in no particular order).
andersca [Fri, 15 Dec 2006 22:57:28 +0000 (22:57 +0000)]
    Reviewed by Darin and Brady (in no particular order).

        More loader cleanup.

        * loader/FrameLoader.h:
        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::cancelledError):
        (WebCore::FrameLoader::fileDoesNotExistError):
        (WebCore::FrameLoader::cannotShowMIMEType):
        (WebCore::FrameLoader::interruptionForPolicyChangeError):
        * loader/mac/MainResourceLoaderMac.mm:
        * loader/mac/NetscapePlugInStreamLoaderMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoTry to fix Windows build: add EventTarget.{h,cpp}.
ap [Fri, 15 Dec 2006 22:02:14 +0000 (22:02 +0000)]
Try to fix Windows build: add EventTarget.{h,cpp}.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Fri, 15 Dec 2006 21:49:43 +0000 (21:49 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=11610
        XMLHttpRequest.onreadystatechange doesn't provide access to the request object

        Created a separate EventTarget class, now that EventTargetNode isn't the only kind.

WebCore:
        * WebCore.xcodeproj/project.pbxproj: Added EventTarget.{h,cpp}

        * bindings/js/kjs_dom.cpp:
        (KJS::toJS): Added an EventTarget variant.
        * bindings/js/kjs_dom.h: Added toJS() for EventTarget; some minor style fixes.

        * bindings/objc/DOM.mm:
        (+[DOMNode _eventTargetWith:WebCore::]):
        * bindings/scripts/CodeGeneratorObjC.pm:
        Added an EventTarget->DOMEventTarget converter in DOMNode (WebCoreInternal).
        It only works for nodes, since we don't have an ObjC binding for XMLHttpRequest.
        Corrected spelling of internalHeaderContent.

        * dom/Event.cpp:
        (WebCore::Event::setTarget):
        * dom/Event.h:
        (WebCore::Event::target):
        (WebCore::Event::currentTarget):
        (WebCore::Event::setCurrentTarget):
        These methods now work with EventTargets instead of Nodes.

        * dom/EventTarget.cpp: Added.
        (WebCore::EventTarget::~EventTarget):
        (WebCore::EventTarget::toNode):
        (WebCore::EventTarget::toXMLHttpRequest):
        * dom/EventTarget.h: Added.
        (WebCore::EventTarget::ref):
        (WebCore::EventTarget::deref):
        Originally, my intention was to share much of the implementation between
        EventTargetNode and XHR, but now I don't see anything substantial worth sharing.

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchGenericEvent): Cast Node to EventTargetNode.

        * dom/EventTargetNode.h: Made EventTarget methods virtual.
        (WebCore::EventTargetNode::toNode): Added poor man's RTTI to upcast from EventTarget.
        (WebCore::EventTargetNode::refEventTarget):
        (WebCore::EventTargetNode::derefEventTarget):

        * dom/MouseEvent.cpp:
        (WebCore::MouseEvent::toElement):
        (WebCore::MouseEvent::fromElement):
        * dom/MouseRelatedEvent.cpp:
        (WebCore::MouseRelatedEvent::receivedTarget):
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::defaultEventHandler):
        * html/HTMLLabelElement.cpp:
        (WebCore::HTMLLabelElement::defaultEventHandler):
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::handleContextMenuEvent):
        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::mouseEventIsInThumb):
        Cast from EventTarget to Node as appropriate.

        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::dispatchEvent):
        (WebCore::XMLHttpRequest::callReadyStateChangeListener):
        Set target and currentTarget before dispatching.

        * xml/xmlhttprequest.h: Made EventTarget methods virtual, added a bool tempEvent parameter
        to match EventTargetNode.
        (WebCore::XMLHttpRequest::toXMLHttpRequest): Added poor man's RTTI to upcast from EventTarget.
        (WebCore::XMLHttpRequest::refEventTarget):
        (WebCore::XMLHttpRequest::derefEventTarget):

LayoutTests:
        * fast/dom/xmlhttprequest-get-expected.txt:
        * http/tests/xmlhttprequest/event-target-expected.txt:
        * http/tests/xmlhttprequest/event-target.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
andersca [Fri, 15 Dec 2006 21:08:11 +0000 (21:08 +0000)]
WebCore:

        Reviewed by Darin.

        More loader cleanup, use KURL instead of NSURL in a couple of places.

        * loader/DocumentLoader.h:
        * loader/FrameLoader.h:
        * loader/FrameLoaderClient.h:
        * loader/ResourceLoader.h:
        * loader/mac/DocumentLoaderMac.mm:
        (WebCore::DocumentLoader::DocumentLoader):
        (WebCore::DocumentLoader::prepareForLoadStart):
        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::willUseArchive):
        * loader/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::load):

WebKit:

        Reviewed by Darin.

        Update for WebCore changes.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::willUseArchive):
        * WebView/WebDataSource.mm:
        (-[WebDataSource _URLForHistory]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-12-15 Marvin Decker <marv.decker@gmail.com>
ap [Fri, 15 Dec 2006 20:40:38 +0000 (20:40 +0000)]
2006-12-15  Marvin Decker  <marv.decker@gmail.com>

        Reviewed by Darin and Alexey.

        Fix the Windows build, move various Client implementations out of
        WebCore and into WebKit.

WebCore:
        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * bridge/win/ChromeClientWin.h: Removed.
        * bridge/win/ContextMenuClientWin.h: Removed.
        * bridge/win/EditorClientWin.h: Removed.
        * bridge/win/FrameWin.cpp:
        (WebCore::FrameWin::FrameWin):
        * bridge/win/FrameWin.h:
        * loader/win/FrameLoaderClientWin.cpp: Removed.
        * loader/win/FrameLoaderClientWin.h: Removed.
        * platform/network/win/ResourceHandleWin.cpp:
        (WebCore::ResourceHandle::start):
        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::DocumentLoader::URL):
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::createFrame):
        (WebCore::FrameLoader::loadResourceSynchronously):
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::writeURL):
        (WebCore::Pasteboard::clear):
        (WebCore::Pasteboard::~Pasteboard):
        (WebCore::PolicyCheck::call):
        (WebCore::PopupMenu::PopupMenu):
        (WebCore::ResourceHandle::loadsBlocked):
        (WebCore::ResourceLoader::cancel):

WebKit:
        * COM/ChromeClientWin.cpp: Added.
        (ChromeClientWin::~ChromeClientWin):
        (ChromeClientWin::chromeDestroyed):
        (ChromeClientWin::setWindowRect):
        (ChromeClientWin::windowRect):
        (ChromeClientWin::pageRect):
        (ChromeClientWin::scaleFactor):
        (ChromeClientWin::focus):
        (ChromeClientWin::unfocus):
        (ChromeClientWin::createWindow):
        (ChromeClientWin::createModalDialog):
        (ChromeClientWin::show):
        (ChromeClientWin::canRunModal):
        (ChromeClientWin::runModal):
        (ChromeClientWin::setToolbarsVisible):
        (ChromeClientWin::toolbarsVisible):
        (ChromeClientWin::setStatusbarVisible):
        (ChromeClientWin::statusbarVisible):
        (ChromeClientWin::setScrollbarsVisible):
        (ChromeClientWin::scrollbarsVisible):
        (ChromeClientWin::setMenubarVisible):
        (ChromeClientWin::menubarVisible):
        (ChromeClientWin::setResizable):
        (ChromeClientWin::addMessageToConsole):
        * COM/ChromeClientWin.h: Added.
        * COM/ContextMenuClientWin.cpp: Added.
        (ContextMenuClientWin::~ContextMenuClientWin):
        (ContextMenuClientWin::contextMenuDestroyed):
        (ContextMenuClientWin::addCustomContextMenuItems):
        (ContextMenuClientWin::contextMenuItemSelected):
        (ContextMenuClientWin::copyLinkToClipboard):
        (ContextMenuClientWin::downloadURL):
        (ContextMenuClientWin::copyImageToClipboard):
        (ContextMenuClientWin::lookUpInDictionary):
        (ContextMenuClientWin::speak):
        (ContextMenuClientWin::stopSpeaking):
        * COM/ContextMenuClientWin.h: Added.
        * COM/EditorClientWin.cpp: Added.
        (EditorClientWin::~EditorClientWin):
        (EditorClientWin::pageDestroyed):
        (EditorClientWin::shouldDeleteRange):
        (EditorClientWin::shouldShowDeleteInterface):
        (EditorClientWin::smartInsertDeleteEnabled):
        (EditorClientWin::isContinuousSpellCheckingEnabled):
        (EditorClientWin::toggleContinuousSpellChecking):
        (EditorClientWin::isGrammarCheckingEnabled):
        (EditorClientWin::toggleGrammarChecking):
        (EditorClientWin::spellCheckerDocumentTag):
        (EditorClientWin::selectWordBeforeMenuEvent):
        (EditorClientWin::isEditable):
        (EditorClientWin::shouldBeginEditing):
        (EditorClientWin::shouldEndEditing):
        (EditorClientWin::shouldInsertNode):
        (EditorClientWin::shouldInsertText):
        (EditorClientWin::shouldApplyStyle):
        (EditorClientWin::didBeginEditing):
        (EditorClientWin::respondToChangedContents):
        (EditorClientWin::didEndEditing):
        (EditorClientWin::registerCommandForUndo):
        (EditorClientWin::registerCommandForRedo):
        (EditorClientWin::clearUndoRedoOperations):
        (EditorClientWin::canUndo):
        (EditorClientWin::canRedo):
        (EditorClientWin::undo):
        (EditorClientWin::redo):
        * COM/EditorClientWin.h: Added.
        * COM/WebFrame.cpp:
        (WebFrame::WebFrame):
        (WebFrame::initWithName):
        * COM/WebFrame.h:
        * COM/WebFrameLoaderClient.cpp: Added.
        (WebFrameLoaderClient::WebFrameLoaderClient):
        (WebFrameLoaderClient::~WebFrameLoaderClient):
        (WebFrameLoaderClient::frameLoaderDestroyed):
        (WebFrameLoaderClient::hasWebView):
        (WebFrameLoaderClient::hasFrameView):
        (WebFrameLoaderClient::hasBackForwardList):
        (WebFrameLoaderClient::resetBackForwardList):
        (WebFrameLoaderClient::provisionalItemIsTarget):
        (WebFrameLoaderClient::loadProvisionalItemFromPageCache):
        (WebFrameLoaderClient::invalidateCurrentItemPageCache):
        (WebFrameLoaderClient::privateBrowsingEnabled):
        (WebFrameLoaderClient::makeDocumentView):
        (WebFrameLoaderClient::makeRepresentation):
        (WebFrameLoaderClient::forceLayout):
        (WebFrameLoaderClient::forceLayoutForNonHTML):
        (WebFrameLoaderClient::updateHistoryForCommit):
        (WebFrameLoaderClient::updateHistoryForBackForwardNavigation):
        (WebFrameLoaderClient::updateHistoryForReload):
        (WebFrameLoaderClient::updateHistoryForStandardLoad):
        (WebFrameLoaderClient::updateHistoryForInternalLoad):
        (WebFrameLoaderClient::updateHistoryAfterClientRedirect):
        (WebFrameLoaderClient::setCopiesOnScroll):
        (WebFrameLoaderClient::tokenForLoadErrorReset):
        (WebFrameLoaderClient::resetAfterLoadError):
        (WebFrameLoaderClient::doNotResetAfterLoadError):
        (WebFrameLoaderClient::willCloseDocument):
        (WebFrameLoaderClient::detachedFromParent1):
        (WebFrameLoaderClient::detachedFromParent2):
        (WebFrameLoaderClient::detachedFromParent3):
        (WebFrameLoaderClient::detachedFromParent4):
        (WebFrameLoaderClient::loadedFromPageCache):
        (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
        (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
        (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
        (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
        (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
        (WebFrameLoaderClient::dispatchWillClose):
        (WebFrameLoaderClient::dispatchDidReceiveIcon):
        (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
        (WebFrameLoaderClient::dispatchDidReceiveTitle):
        (WebFrameLoaderClient::dispatchDidCommitLoad):
        (WebFrameLoaderClient::dispatchDidFinishLoad):
        (WebFrameLoaderClient::dispatchDidFirstLayout):
        (WebFrameLoaderClient::dispatchShow):
        (WebFrameLoaderClient::cancelPolicyCheck):
        (WebFrameLoaderClient::dispatchWillSubmitForm):
        (WebFrameLoaderClient::dispatchDidLoadMainResource):
        (WebFrameLoaderClient::clearLoadingFromPageCache):
        (WebFrameLoaderClient::isLoadingFromPageCache):
        (WebFrameLoaderClient::revertToProvisionalState):
        (WebFrameLoaderClient::clearUnarchivingState):
        (WebFrameLoaderClient::progressStarted):
        (WebFrameLoaderClient::progressCompleted):
        (WebFrameLoaderClient::setMainFrameDocumentReady):
        (WebFrameLoaderClient::willChangeTitle):
        (WebFrameLoaderClient::didChangeTitle):
        (WebFrameLoaderClient::finishedLoading):
        (WebFrameLoaderClient::finalSetupForReplace):
        (WebFrameLoaderClient::setDefersLoading):
        (WebFrameLoaderClient::isArchiveLoadPending):
        (WebFrameLoaderClient::cancelPendingArchiveLoad):
        (WebFrameLoaderClient::clearArchivedResources):
        (WebFrameLoaderClient::canHandleRequest):
        (WebFrameLoaderClient::canShowMIMEType):
        (WebFrameLoaderClient::representationExistsForURLScheme):
        (WebFrameLoaderClient::generatedMIMETypeForURLScheme):
        (WebFrameLoaderClient::frameLoadCompleted):
        (WebFrameLoaderClient::restoreScrollPositionAndViewState):
        (WebFrameLoaderClient::provisionalLoadStarted):
        (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
        (WebFrameLoaderClient::addHistoryItemForFragmentScroll):
        (WebFrameLoaderClient::didFinishLoad):
        (WebFrameLoaderClient::prepareForDataSourceReplacement):
        (WebFrameLoaderClient::setTitle):
        (WebFrameLoaderClient::userAgent):
        * COM/WebFrameLoaderClient.h: Added.
        * COM/WebKitDLL.h:
        * WebKit.vcproj/WebKit.vcproj:

WebKitTools:
        * Spinneret/Spinneret.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
andersca [Fri, 15 Dec 2006 20:11:26 +0000 (20:11 +0000)]
    Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=11842
        REGRESSION: Using Safari's snippet editor leaves applewebdata: URLs in history

        * loader/mac/DocumentLoaderMac.mm:
        (WebCore::DocumentLoader::URLForHistory):
        Don't return appleweburls without an unreachable url.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
andersca [Fri, 15 Dec 2006 19:48:34 +0000 (19:48 +0000)]
WebCore:

        Reviewed by Darin.

        Replace more instances of NSError with ResourceError.

        Also remove a check for a selector that was added pre-Tiger.

        * WebCore.exp:
        * loader/DocumentLoader.h:
        * loader/FrameLoader.h:
        * loader/ResourceLoader.h:
        * loader/mac/DocumentLoaderMac.mm:
        (WebCore::DocumentLoader::setMainDocumentError):
        (WebCore::DocumentLoader::mainDocumentError):
        (WebCore::DocumentLoader::clearErrors):
        (WebCore::DocumentLoader::mainReceivedError):
        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::cancelMainResourceLoad):
        (WebCore::FrameLoader::opened):
        (WebCore::FrameLoader::mainReceivedError):
        (WebCore::FrameLoader::cancelledError):
        (WebCore::FrameLoader::fileDoesNotExistError):
        (WebCore::FrameLoader::handleUnimplementablePolicy):
        (WebCore::FrameLoader::setMainDocumentError):
        (WebCore::FrameLoader::mainReceivedCompleteError):
        (WebCore::FrameLoader::sendRemainingDelegateMessages):
        (WebCore::FrameLoader::requestFromDelegate):
        (WebCore::FrameLoader::loadedResourceFromMemoryCache):
        (WebCore::FrameLoader::loadResourceSynchronously):
        * loader/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::willSendRequest):
        (WebCore::ResourceLoader::didCancel):
        (WebCore::ResourceLoader::cancel):
        (WebCore::ResourceLoader::cancelledError):
        * loader/mac/SubresourceLoaderMac.mm:
        (WebCore::SubresourceLoader::didCancel):

WebKit:

        Reviewed by Darin.

        Include ResourceError.h.

        * Plugins/WebNetscapePluginStream.mm:
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
rwlbuis [Fri, 15 Dec 2006 19:31:43 +0000 (19:31 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=11824
        CSSStyleSheet.title property is always null

        Set title on the stylesheet just after creating it, for the HTML
        elements <link> and <style>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix compilation (from lars)
zack [Fri, 15 Dec 2006 12:26:41 +0000 (12:26 +0000)]
Fix compilation (from lars)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
andersca [Fri, 15 Dec 2006 04:04:29 +0000 (04:04 +0000)]
WebCore:

        Reviewed by Maciej.

        Use char* pointer + length instead of NSData in a bunch of places.

        * loader/DocumentLoader.h:
        * loader/FrameLoader.h:
        * loader/FrameLoaderClient.h:
        * loader/MainResourceLoader.h:
        * loader/NetscapePlugInStreamLoader.h:
        * loader/ResourceLoader.h:
        (WebCore::ResourceLoader::willStopBufferingData):
        * loader/SubresourceLoader.h:
        * loader/mac/DocumentLoaderMac.mm:
        (WebCore::DocumentLoader::commitLoad):
        (WebCore::DocumentLoader::receivedData):
        (WebCore::DocumentLoader::setupForReplaceByMIMEType):
        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::didReceiveData):
        (WebCore::FrameLoader::receivedData):
        (WebCore::FrameLoader::committedLoad):
        * loader/mac/MainResourceLoaderMac.mm:
        (WebCore::MainResourceLoader::addData):
        (WebCore::MainResourceLoader::didReceiveData):
        * loader/mac/NetscapePlugInStreamLoaderMac.mm:
        (WebCore::NetscapePlugInStreamLoader::didReceiveData):
        * loader/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::addData):
        (WebCore::ResourceLoader::didReceiveData):
        (WebCore::ResourceLoader::willStopBufferingData):
        * loader/mac/SubresourceLoaderMac.mm:
        (WebCore::SubresourceLoader::didReceiveData):
        * platform/network/ResourceHandleClient.h:
        (WebCore::ResourceHandleClient::willStopBufferingData):
        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):

WebKit:

        Reviewed by Maciej.

        Update for WebCore changes.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::incrementProgress):
        (WebFrameLoaderClient::committedLoad):
        (WebFrameLoaderClient::deliverArchivedResources):
        * WebView/WebView.mm:
        (-[WebView _incrementProgressForIdentifier:length:]):
        * WebView/WebViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
adele [Fri, 15 Dec 2006 04:02:56 +0000 (04:02 +0000)]
    Reviewed by Adam.

        Added PopupMenuClient class so the PopupMenu class no longer needs to know
        about the RenderMenuList or the DOM.

        * platform/PopupMenu.h:
        (WebCore::PopupMenuClient::~PopupMenuClient):
        (WebCore::PopupMenu::create): Made this protected so PopupMenu can be subclassed.
        (WebCore::PopupMenu::disconnectClient): Renamed from disconnectMenuList.
        (WebCore::PopupMenu::client): Added.
        * platform/mac/PopupMenuMac.mm:
        (WebCore::PopupMenu::PopupMenu): Created using PopupMenuClient instead of RenderMenuList.
        (WebCore::PopupMenu::populate): Asks the client for info about the list items instead of looking at the DOM or the renderer.
        (WebCore::PopupMenu::show): ditto.
        (WebCore::PopupMenu::hide): ditto.
        * rendering/RenderMenuList.h: Now also inherits from PopupMenuClient.
        (WebCore::RenderMenuList::shouldPopOver): Added.  Tells the popup whether the menu should pop over the client, or under.
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::~RenderMenuList): Calls disconnectClient().
        (WebCore::RenderMenuList::calcMinMaxWidth): Removed unnecessary (and harmful) call to updateFromElement. updateFromElmeent
         can add children, and you don't want to do that in the middle of calculating width.
        (WebCore::RenderMenuList::itemText): Added PopupClient method to provide information about the items in the menu list.
        (WebCore::RenderMenuList::itemIsEnabled): ditto.
        (WebCore::RenderMenuList::itemStyle): ditto.
        (WebCore::RenderMenuList::clientStyle): ditto.
        (WebCore::RenderMenuList::clientDocument): ditto.
        (WebCore::RenderMenuList::clientPaddingLeft): ditto.
        (WebCore::RenderMenuList::clientPaddingRight): ditto.
        (WebCore::RenderMenuList::listSize): ditto.
        (WebCore::RenderMenuList::selectedIndex): ditto.
        (WebCore::RenderMenuList::itemIsSeparator): ditto.
        (WebCore::RenderMenuList::itemIsLabel): ditto.
        (WebCore::RenderMenuList::itemIsSelected): ditto.
        (WebCore::RenderMenuList::setTextFromItem): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
ggaren [Fri, 15 Dec 2006 03:43:51 +0000 (03:43 +0000)]
LayoutTests:

        Updated these results now that I've rolled out my change to move focus
        to the page level:

        * editing/undo/undo-iframe-location-change-expected.txt:
        * fast/forms/focus2-expected.txt:

        Added this test for one of the regressions that moving focus to the page
        level caused:

        * editing/selection/inactive-selection-expected.txt: Added.
        * editing/selection/inactive-selection.html: Added.

WebCore:

        Fixed <rdar://problem/4882713> GMAIL (REGRESSION): Can't apply font style,
        foreground or background to selected text

        Also <rdar://problem/4883751> REGRESSION: Caret fails to insert itself
        automatically in a new note window

        I'm rolling out my change to move focus to the page level because it caused
        too many unexpected and bizarre regressions. Our code relies on focus
        being per-document so that it can make focus changes that are effectively
        no-ops, and so that it can conflate focus and selection in some cases (a bad
        idea, since they're not the same).

        Hopefully we can revisit this, along with hover and active, in the future.

        * dom/Document.cpp:
        (WebCore::widgetForNode):
        (WebCore::relinquishesEditingFocus):
        (WebCore::acceptsEditingFocus):
        (WebCore::clearSelectionIfNeeded):
        (WebCore::Document::removedLastRef):
        (WebCore::Document::detach):
        (WebCore::Document::focusedNodeDetached):
        (WebCore::Document::setFocusedNode):
        * dom/Document.h:
        (WebCore::Document::focusedNode):
        * page/FocusController.cpp:
        * page/FocusController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
mjs [Fri, 15 Dec 2006 03:14:13 +0000 (03:14 +0000)]
    Reviewed by Geoff.

        - fix failing drag & drop layout tests

        * platform/mac/KURLMac.mm:
        (WebCore::KURL::getNSURL): Turn empty KURL into empty NSURL, but null KURL into
        nil.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
thatcher [Fri, 15 Dec 2006 02:25:22 +0000 (02:25 +0000)]
    Reviewed by Darin.

        <rdar://problem/4827549> need NSRange-based selection support exposed.

        * WebView/WebFrame.mm:
        (-[WebFrame _selectedNSRange]):
        (-[WebFrame _selectNSRange:]):
        * WebView/WebFramePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-12-14 Steve Falkenburg <sfalken@apple.com>
sfalken [Fri, 15 Dec 2006 01:30:52 +0000 (01:30 +0000)]
2006-12-14  Steve Falkenburg  <sfalken@apple.com>

        Build fix.

        * loader/MainResourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
andersca [Fri, 15 Dec 2006 00:41:29 +0000 (00:41 +0000)]
WebCore:

        Reviewed by John.

        Convert a bunch of NSErrors to ResourceError.

        Make the ResourceError accessor functions const.

        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * loader/FrameLoader.h:
        * loader/FrameLoaderClient.h:
        * loader/MainResourceLoader.h:
        * loader/NetscapePlugInStreamLoader.h:
        * loader/ResourceLoader.h:
        * loader/SubresourceLoader.h:
        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::didFailToLoad):
        (WebCore::FrameLoader::receivedMainResourceError):
        (WebCore::FrameLoader::interruptionForPolicyChangeError):
        * loader/mac/MainResourceLoaderMac.mm:
        (WebCore::MainResourceLoader::receivedError):
        (WebCore::MainResourceLoader::didCancel):
        (WebCore::MainResourceLoader::interruptionForPolicyChangeError):
        (WebCore::MainResourceLoader::didFail):
        * loader/mac/NetscapePlugInStreamLoaderMac.mm:
        (WebCore::NetscapePlugInStreamLoader::didFail):
        (WebCore::NetscapePlugInStreamLoader::didCancel):
        * loader/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::didFail):
        (WebCore::ResourceLoader::didCancel):
        * loader/mac/SubresourceLoaderMac.mm:
        (WebCore::SubresourceLoader::didFail):
        (WebCore::SubresourceLoader::didCancel):
        * platform/network/ResourceError.h:
        (WebCore::ResourceError::domain):
        (WebCore::ResourceError::errorCode):
        (WebCore::ResourceError::failingURL):
        (WebCore::ResourceError::localizedDescription):
        (WebCore::ResourceError::unpackPlatformErrorIfNeeded):

WebKit:

        Reviewed by John.

        Update for WebKit changes.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchDidFailLoading):
        (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
        (WebFrameLoaderClient::dispatchDidFailLoad):
        (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
        (WebFrameLoaderClient::setMainDocumentError):
        (WebFrameLoaderClient::cancelledError):
        (WebFrameLoaderClient::cannotShowURLError):
        (WebFrameLoaderClient::interruptForPolicyChangeError):
        (WebFrameLoaderClient::cannotShowMIMETypeError):
        (WebFrameLoaderClient::fileDoesNotExistError):
        (WebFrameLoaderClient::shouldFallBack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLink, after the last loader changes. Please update this directory with stubs when...
staikos [Fri, 15 Dec 2006 00:10:41 +0000 (00:10 +0000)]
Link, after the last loader changes.  Please update this directory with stubs when modifying the loader. (also fixes some Changelog typos)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Thu, 14 Dec 2006 23:30:11 +0000 (23:30 +0000)]
LayoutTests:

        Reviewed by harrison

        <rdar://problem/4866671>
        CrashTracer: 1 crashes in Mail after deleting a list item at WebCore::DeleteSelectionCommand::doApply()

        * editing/deleting/4866671-expected.checksum: Added.
        * editing/deleting/4866671-expected.png: Added.
        * editing/deleting/4866671-expected.txt: Added.
        * editing/deleting/4866671.html: Added.
        * editing/pasteboard/4866671-expected.checksum: Added.
        * editing/pasteboard/4866671-expected.png: Added.
        * editing/pasteboard/4866671-expected.txt: Added.
        * editing/pasteboard/4866671.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/4866671>
        CrashTracer: 1 crashes in Mail after deleting a list item at WebCore::DeleteSelectionCommand::doApply()

        Don't allow VisiblePositions inside -webkit-user-select:none regions.
        Renamed inRenderedContent to isCandidate.

        * dom/Document.cpp:
        (WebCore::Document::updateSelection):
        * dom/Position.cpp:
        (WebCore::Position::previousCharacterPosition):
        (WebCore::Position::nextCharacterPosition):
        (WebCore::nodeIsUserSelectNone):
        (WebCore::Position::isCandidate):
        (WebCore::Position::rendersInDifferentPosition):
        * dom/Position.h:
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::input):
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::canonicalPosition):
        * editing/htmlediting.cpp:
        (WebCore::nextCandidate):
        (WebCore::nextVisuallyDistinctCandidate):
        (WebCore::previousCandidate):
        (WebCore::previousVisuallyDistinctCandidate):
        * editing/visible_units.cpp:
        (WebCore::previousLinePosition):
        (WebCore::nextLinePosition):
        (WebCore::startOfParagraph):
        * page/Frame.cpp:
        (WebCore::Frame::styleForSelectionStart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Get rid of the containsStart check and just rely on the selectionState
hyatt [Thu, 14 Dec 2006 23:16:48 +0000 (23:16 +0000)]
    Get rid of the containsStart check and just rely on the selectionState
        bits.  This allows selection gap filling to behave properly in the presence
        of inline blocks and inline tables on lines when the selection originates
        inside the inline block.

        Reviewed by ggaren

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::fillInlineSelectionGaps):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John.
andersca [Thu, 14 Dec 2006 22:13:59 +0000 (22:13 +0000)]
    Reviewed by John.

        General loader cleanup, convert NSURLResponse to ResourceResponse in some places.

        * loader/DocumentLoader.h:
        * loader/SubresourceLoader.h:
        * loader/mac/DocumentLoaderMac.mm:
        (WebCore::DocumentLoader::addResponse):
        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::opened):
        * loader/mac/SubresourceLoaderMac.mm:
        (WebCore::SubresourceLoader::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
andersca [Thu, 14 Dec 2006 20:50:10 +0000 (20:50 +0000)]
    Reviewed by Darin.

        Add loadResourceSynchronously to ResourceHandle and have FrameLoader use it instead of
        calling NSURLConnection directly.

        Add an isNull flag to ResourceError so we can convert correctly between nil NSErrors and ResourceErrors.

        Get rid of ServeSynchronousRequest and use the loader instead.

        * WebCore.exp:
        * dom/XMLTokenizer.cpp:
        (WebCore::openFunc):
        * loader/FrameLoader.h:
        * loader/LoaderFunctions.h:
        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::canLoad):
        (WebCore::FrameLoader::loadResourceSynchronously):
        * loader/mac/LoaderFunctionsMac.mm:
        * platform/network/ResourceError.h:
        (WebCore::ResourceError::ResourceError):
        (WebCore::ResourceError::isNull):
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceRequest.cpp:
        (WebCore::ResourceRequest::isConditional):
        * platform/network/ResourceRequest.h:
        * platform/network/mac/ResourceErrorMac.mm:
        (-[NSError WebCore]):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::loadResourceSynchronously):
        * xml/XSLTProcessor.cpp:
        (WebCore::docLoaderFunc):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::send):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Darin.
zimmermann [Thu, 14 Dec 2006 20:42:10 +0000 (20:42 +0000)]
Reviewed by Darin.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11830
Fix fundamental problems with JS SVG POD types.
(currently: FloatPoint/FloatRect/AffineTransform)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agotop level:
thatcher [Thu, 14 Dec 2006 19:30:36 +0000 (19:30 +0000)]
top level:

        Reviewed by Brady.

        * Makefile.shared: use $PIPESTATUS[0] and a sub-shell to exit with xcodebuild's exit status

WebKitTools:

        Reviewed by Brady.

        * Makefile.shared: use $PIPESTATUS[0] and a sub-shell to exit with xcodebuild's exit status

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Thu, 14 Dec 2006 18:05:16 +0000 (18:05 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=11828
        Fix a leak of NSURLRequest on each update - RetainPtr retains the object itself.

        * platform/network/mac/ResourceRequestMac.mm:
        (WebCore::ResourceRequest::doUpdatePlatformRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-12-14 Simon Hausmann <hausmann@kde.org>
hausmann [Thu, 14 Dec 2006 17:32:52 +0000 (17:32 +0000)]
2006-12-14  Simon Hausmann  <hausmann@kde.org>

        Reviewed by Zack.

        * QtLauncher/QtLauncher.pro: Link this little test program
        with rpath, for convenience. (This is never going to get installed
        anyway)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-12-14 Simon Hausmann <hausmann@kde.org>
hausmann [Thu, 14 Dec 2006 16:47:26 +0000 (16:47 +0000)]
2006-12-14  Simon Hausmann  <hausmann@kde.org>

        Reviewed by Zack Rusin.

        * WebCore.pro: Clean up the xpath grammar generation rule.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMake it link with temporary stubs (from lars, icefox)
zack [Thu, 14 Dec 2006 14:22:13 +0000 (14:22 +0000)]
Make it link with temporary stubs (from lars, icefox)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoCompilation fixes for the Qt port after last nights changes
zack [Thu, 14 Dec 2006 11:40:25 +0000 (11:40 +0000)]
Compilation fixes for the Qt port after last nights changes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
rwlbuis [Thu, 14 Dec 2006 10:36:15 +0000 (10:36 +0000)]
    Reviewed by Oliver.

        http://bugs.webkit.org/show_bug.cgi?id=11726
        SVG Image do not take into account clip/overflow when hit testing

        Take into account the overflowRect when hit-testing <svg> container.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for bug 11825, dragging elements via -khtml-user-drag is broken (affects...
hyatt [Thu, 14 Dec 2006 07:52:14 +0000 (07:52 +0000)]
    Fix for bug 11825, dragging elements via -khtml-user-drag is broken (affects Dashboard).  Make sure
        to clear the paintingRoot properly when recurring into children.  It would be nice to find a design
        that prevented this mistake from being made and didn't require explicit clearing of the root.

        Reviewed by olliej

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paint):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintChildren):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paint):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * loader/FrameLoader.h:
andersca [Thu, 14 Dec 2006 01:30:02 +0000 (01:30 +0000)]
    * loader/FrameLoader.h:
        id is mac-only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Implicitly reviewed by Darin, Hyatt, Maciej, and others!
beidson [Wed, 13 Dec 2006 23:34:09 +0000 (23:34 +0000)]
    Implicitly reviewed by Darin, Hyatt, Maciej, and others!

        Fixes a document tear down crash.
        Changes a few long standing assertions to our new style

        * dom/Document.cpp:
        (WebCore::Document::~Document):
        (WebCore::Document::topDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady and Anders.
mjs [Wed, 13 Dec 2006 23:22:44 +0000 (23:22 +0000)]
    Reviewed by Brady and Anders.

        * Makefile.shared: Stop spewing the environment all the time, at least for command-line builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
mjs [Wed, 13 Dec 2006 23:20:13 +0000 (23:20 +0000)]
JavaScriptCore:

        Reviewed by Anders.

        - added equality and inequality operations for HashMap and Vector, useful for comparing more complex types

        * wtf/HashMap.h:
        (WTF::operator==):
        (WTF::operator!=):
        * wtf/Vector.h:
        (WTF::operator==):
        (WTF::operator!=):

WebCore:

        Reviewed by Anders.

        - converted many places to use ResourceRequest instead of NSURLRequest

        * WebCore.exp:
        * loader/DocumentLoader.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stopPolicyCheck):
        * loader/FrameLoader.h:
        (WebCore::PolicyCheck::request):
        * loader/FrameLoaderClient.h:
        * loader/MainResourceLoader.h:
        * loader/mac/DocumentLoaderMac.mm:
        (WebCore::DocumentLoader::DocumentLoader):
        (WebCore::DocumentLoader::originalRequest):
        (WebCore::DocumentLoader::originalRequestCopy):
        (WebCore::DocumentLoader::request):
        (WebCore::DocumentLoader::initialRequest):
        (WebCore::DocumentLoader::actualRequest):
        (WebCore::DocumentLoader::URL):
        (WebCore::DocumentLoader::unreachableURL):
        (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
        (WebCore::DocumentLoader::setRequest):
        (WebCore::DocumentLoader::stopLoading):
        (WebCore::DocumentLoader::setLastCheckedRequest):
        (WebCore::DocumentLoader::lastCheckedRequest):
        (WebCore::DocumentLoader::URLForHistory):
        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::startLoadingMainResource):
        (WebCore::FrameLoader::applyUserAgent):
        (WebCore::FrameLoader::originalRequest):
        (WebCore::FrameLoader::receivedMainResourceError):
        (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
        (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
        (WebCore::FrameLoader::commitProvisionalLoad):
        (WebCore::FrameLoader::initialRequest):
        (WebCore::FrameLoader::setRequest):
        (WebCore::FrameLoader::checkNavigationPolicy):
        (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
        (WebCore::FrameLoader::reloadAllowingStaleData):
        (WebCore::FrameLoader::reload):
        (WebCore::FrameLoader::checkNewWindowPolicy):
        (WebCore::FrameLoader::continueAfterNewWindowPolicy):
        (WebCore::FrameLoader::continueAfterNavigationPolicy):
        (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
        (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
        (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
        (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
        (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
        (WebCore::FrameLoader::post):
        (WebCore::FrameLoader::addExtraFieldsToRequest):
        (WebCore::FrameLoader::isReloading):
        (WebCore::FrameLoader::referrer):
        (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
        (WebCore::FrameLoader::loadResourceSynchronously):
        (WebCore::FrameLoader::originalRequestURL):
        (WebCore::PolicyCheck::set):
        (WebCore::PolicyCheck::call):
        (WebCore::PolicyCheck::clearRequest):
        * loader/mac/MainResourceLoaderMac.mm:
        (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
        (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
        (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
        * loader/mac/SubresourceLoaderMac.mm:
        (WebCore::SubresourceLoader::create):
        * loader/mac/WebDataProtocol.h:
        * loader/mac/WebDataProtocol.mm:
        * platform/KURL.cpp:
        (WebCore::operator!=):
        * platform/KURL.h:
        * platform/mac/KURLMac.mm:
        (WebCore::KURL::getNSURL):
        * platform/network/FormData.h:
        (WebCore::operator==):
        (WebCore::operator!=):
        * platform/network/ResourceRequest.cpp:
        (WebCore::operator==):
        * platform/network/ResourceRequest.h:
        * platform/network/mac/ResourceRequestMac.mm:
        (WebCore::ResourceRequest::doUpdatePlatformRequest):

WebKit:

        Reviewed by Anders.

        - adjusted for changes from NSURLRequest to ResourceRequest

        * Plugins/WebPluginController.mm:
        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::updateHistoryForReload):
        (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
        (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
        (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
        (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
        (WebFrameLoaderClient::startDownload):
        (WebFrameLoaderClient::cannotShowURLError):
        (WebFrameLoaderClient::createDocumentLoader):
        * WebView/WebDataSource.mm:
        (-[WebDataSource _initWithDocumentLoader:]):
        (-[WebDataSource initialRequest]):
        (-[WebDataSource request]):
        * WebView/WebDocumentLoaderMac.h:
        * WebView/WebDocumentLoaderMac.mm:
        (WebDocumentLoaderMac::WebDocumentLoaderMac):
        * WebView/WebFrame.mm:
        (-[WebFrame _createItem:]):
        (-[WebFrame _loadItem:withLoadType:]):
        (-[WebFrame loadArchive:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler, Dave Hyatt.
ggaren [Wed, 13 Dec 2006 23:10:32 +0000 (23:10 +0000)]
    Reviewed by Darin Adler, Dave Hyatt.

        Beefed up FocusController to handle frame focus. Changed implementors to
        use FocusController, rather than the widget hierarchy, to focus frames.

        (WebCore::FocusController::focusedNode): Made a minor change to focus a frame
        before focusing the element inside of it. This matches FF.
        (WebCore::FocusController::focusedFrame):
        * platform/Widget.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by adele
justing [Wed, 13 Dec 2006 21:33:23 +0000 (21:33 +0000)]
    Reviewed by adele

        <rdar://problem/4818145>
        Cannot setSelectedDOMRange to non-editable island unless it has editable content on both sides

        There are editable positions before/after a "non-editable island" if its
        a table, but the code in canonicalPosition was not using
        editableRootForPosition to find root editable elements.

        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::canonicalPosition): Use editableRootForPosition
        to fix the table case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-12-13 Steve Falkenburg <sfalken@apple.com>
sfalken [Wed, 13 Dec 2006 20:02:12 +0000 (20:02 +0000)]
2006-12-13  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam.

        Added missing forwarding headers.

        * ForwardingHeaders/kjs/value.h: Added.
        * ForwardingHeaders/wtf/HashTable.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Updated results to match Justin Garcia's addition of rangeCount to
ggaren [Wed, 13 Dec 2006 17:05:33 +0000 (17:05 +0000)]
    Updated results to match Justin Garcia's addition of rangeCount to
        the selection object.

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMake qmake the default build environment for the Qt port.
zack [Wed, 13 Dec 2006 14:45:38 +0000 (14:45 +0000)]
Make qmake the default build environment for the Qt port.
CMake currently doesn't work and updates to qmake will happen
a lot faster. Review by Rob

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agomake it compile after last nights changes from lars (r=maciej,me)
zack [Wed, 13 Dec 2006 13:16:53 +0000 (13:16 +0000)]
make it compile after last nights changes from lars (r=maciej,me)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders.
aroben [Wed, 13 Dec 2006 02:34:10 +0000 (02:34 +0000)]
    Reviewed by Anders.

        Changed #import to #include to match the rest of our ForwardingHeaders.

        * ForwardingHeaders/wtf/StringExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Wed, 13 Dec 2006 00:48:23 +0000 (00:48 +0000)]
LayoutTests:

        Reviewed by harrison

        <rdar://problem/4757667>
        GoogleDocs: Style menu does not open

        * editing/selection/rangeCount-expected.txt: Added.
        * editing/selection/rangeCount.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/4757667>
        GoogleDocs: Style menu does not open

        * bindings/js/kjs_window.cpp:
        (KJS::Selection::getValueProperty): Added rangeCount.
        * bindings/js/kjs_window.h:
        (KJS::Selection::):
        * editing/SelectionController.h:
        (WebCore::SelectionController::rangeCount): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
aliceli1 [Tue, 12 Dec 2006 23:58:55 +0000 (23:58 +0000)]
    Reviewed by Oliver.

        * bindings/js/JSSVGMatrixCustom.cpp:
        added #ifdef SVG_SUPPORT

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Suggested by Darin.
andersca [Tue, 12 Dec 2006 23:45:20 +0000 (23:45 +0000)]
    Suggested by Darin.

        * loader/ResourceLoader.cpp:
        Move down include of ResourceHandle.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixing up svn properties on FocusController.*
ggaren [Tue, 12 Dec 2006 23:30:09 +0000 (23:30 +0000)]
Fixing up svn properties on FocusController.*

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben, Dave Hyatt, Darin Adler.
ggaren [Tue, 12 Dec 2006 22:11:18 +0000 (22:11 +0000)]
    Reviewed by Adam Roben, Dave Hyatt, Darin Adler.

        Factored focus control into a FocusController class. I inted to use this
        class for handling window active state and the focused frame, as well.

        Layout tests pass.

        * WebCore.xcodeproj/project.pbxproj:
        * dom/Document.cpp:
        (WebCore::Document::view):
        (WebCore::Document::page): New helper function.
        * dom/Document.h: Moved setters before getters.
        (WebCore::Document::hoverNode):
        (WebCore::Document::activeNode):
        * dom/Node.cpp:
        (WebCore::Node::detach): Use the FocusController.
        * page/FocusController.cpp: Added.
        (WebCore::shouldFocus): renamed and refactored this helper function.
        (WebCore::shouldUnfocus): ditto.
        * page/FocusController.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber Stamped by Geoff.
andersca [Tue, 12 Dec 2006 22:03:27 +0000 (22:03 +0000)]
    Rubber Stamped by Geoff.

        * platform/Base64.cpp:
        * platform/Base64.h:
        Put functions inside of the WebCore namespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Try fixing the non-Mac builds.
andersca [Tue, 12 Dec 2006 21:42:24 +0000 (21:42 +0000)]
    Try fixing the non-Mac builds.

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::willSendRequest):
        (WebCore::ResourceLoader::didReceiveResponse):
        (WebCore::ResourceLoader::didReceiveData):
        (WebCore::ResourceLoader::didFinishLoading):
        (WebCore::ResourceLoader::didFail):
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::create):
        * loader/SubresourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
andersca [Tue, 12 Dec 2006 21:14:50 +0000 (21:14 +0000)]
WebCore:

        Reviewed by Darin.

        Turn ResourceLoader into a ResourceHandleClient and stop using NSURLConnection in the loader.

        * WebCore.exp:
        Add new methods needed by WebKit.

        * WebCore.xcodeproj/project.pbxproj:
        Make ResourceHandle.h a private header.

        * loader/FrameLoaderClient.h:
        Change the download method to take a ResourceHandle instead of an NSURLConnection.

        * loader/MainResourceLoader.h:
        Get rid of the proxy instance variable, that's handled by ResourceHandlw now.

        * loader/ResourceLoader.h:
        (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
        (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
        (WebCore::ResourceLoader::willStopBufferingData):
        (WebCore::ResourceLoader::willCacheResponse):
        (WebCore::ResourceLoader::receivedCredential):
        (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
        (WebCore::ResourceLoader::receivedCancellation):
        (WebCore::ResourceLoader::handle):
        * loader/SubresourceLoader.h:
        Make ResourceLoader a ResourceHandleClient, moving the methods from SubresourceLoader.

        * loader/mac/MainResourceLoaderMac.mm:
        (WebCore::MainResourceLoader::MainResourceLoader):
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        (WebCore::MainResourceLoader::loadNow):
        (WebCore::MainResourceLoader::load):
        Use a ResourceHandle instead of an NSURLConnection.

        * loader/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::~ResourceLoader):
        (WebCore::ResourceLoader::releaseResources):
        (WebCore::ResourceLoader::load):
        (WebCore::ResourceLoader::setDefersLoading):
        (WebCore::ResourceLoader::resourceData):
        (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
        (WebCore::ResourceLoader::didCancel):
        (WebCore::ResourceLoader::willSendRequest):
        (WebCore::ResourceLoader::didReceiveResponse):
        (WebCore::ResourceLoader::didReceiveData):
        (WebCore::ResourceLoader::didFinishLoading):
        (WebCore::ResourceLoader::didFail):
        Remove the WebCoreResourceLoaderAsDelegate class, use a ResourceHandle instead of an NSURLConnection.

        * loader/mac/SubresourceLoaderMac.mm:
        Remove ResourceHandleClient methods.

        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::ResourceHandle):
        (WebCore::ResourceHandle::create):
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        Add an extra argument denoting whether this ResourceHandle can possibly be "converted" into one used for downloads.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::~ResourceHandle):
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::releaseProxy):
        (WebCore::ResourceHandle::connection):
        New methods for creating a NSURLConnectionDelegateProxy which is used when creating a NSURLDownload from an existing
        connection.

WebKit:

        Reviewed by Darin.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::download):
        Get the handle and proxy from the ResourceHandle now that they aren't passed to us.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff. Based on a patch by Maks Orlovich.
ap [Tue, 12 Dec 2006 20:09:58 +0000 (20:09 +0000)]
    Reviewed by Geoff. Based on a patch by Maks Orlovich.

        http://bugs.webkit.org/show_bug.cgi?id=6257
        Throw errors on invalid expressions (KJS merge)

JavaScriptCore:
        * kjs/regexp.cpp:
        (KJS::RegExp::RegExp):
        (KJS::RegExp::~RegExp):
        (KJS::RegExp::match):
        * kjs/regexp.h:
        (KJS::RegExp::flags):
        (KJS::RegExp::isValid):
        (KJS::RegExp::errorMessage):
        (KJS::RegExp::subPatterns):
        Remember and report RegExp construction failures. Renamed data members not to start with underscores.

        * kjs/regexp_object.cpp:
        (RegExpObjectImp::construct): Raise an exception if RegExp construction fails.
        (RegExpObjectImp::callAsFunction): Removed an obsolete comment.

        * tests/mozilla/ecma_3/RegExp/regress-119909.js: Reduced the number of nested parentheses to
        a value supported by PCRE.

LayoutTests:
        * fast/js/kde/RegExp-expected.txt: One more test passes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
andersca [Tue, 12 Dec 2006 19:42:03 +0000 (19:42 +0000)]
    Reviewed by Geoff.

        * loader/mac/SubresourceLoaderMac.mm:
        (WebCore::SubresourceLoader::load):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start):
        Move the didTellBridgeAboutLoad call to SubresourceLoader in preparation for getting rid of
        the DocLoader parameter to ResourceHandle::create.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoOops. Forgot to check in this file.
ggaren [Tue, 12 Dec 2006 19:32:35 +0000 (19:32 +0000)]
Oops. Forgot to check in this file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMake the last checkin compile
staikos [Tue, 12 Dec 2006 12:09:51 +0000 (12:09 +0000)]
Make the last checkin compile

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixes: http://bugs.webkit.org/show_bug.cgi?id=11797
zimmermann [Tue, 12 Dec 2006 11:19:34 +0000 (11:19 +0000)]
Fixes: bugs.webkit.org/show_bug.cgi?id=11797
Remove SVGMatrix, replace it by AffineTransform usage everywhere.
Changed AffineTransform API to be able to be used within generation
(m11() -> a(), m12() -> b(), ...). Add some methods needed for SVG.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix the Qt build
staikos [Tue, 12 Dec 2006 09:55:16 +0000 (09:55 +0000)]
Fix the Qt build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
ggaren [Tue, 12 Dec 2006 09:02:13 +0000 (09:02 +0000)]
LayoutTests:

        Reviewed by Beth Dakin.

        Added some focus-related tests.

        * editing/undo/undo-iframe-location-change-expected.txt: Updated to reflect
        the fact that we now unfocus nodes when they're removed from the document.

        * fast/events/keypress-removed-node-expected.txt: Added.
        * fast/events/keypress-removed-node.html: Added.
        * fast/forms/focus2-expected.txt: Added.
        * fast/forms/focus2.html: Added.

WebCore:

        Reviewed by Beth Dakin.

        Moved focus control to the page level. Fixed a minor bug where a node
        would retain keyboard focus even when removed from the document.

        We should probably move this, along with hover and active, into a separate
        FocusController. But I'm too tired right now.

        * dom/Document.cpp: Migrated code to Page
        (WebCore::Document::removedLastRef):
        (WebCore::Document::detach):
        (WebCore::Document::setFocusedNode):
        (WebCore::Document::focusedNode):
        * dom/Document.h:
        * dom/Node.cpp:
        (WebCore::Node::detach): Clear ourselves from keyboard focus. This fixes
        the minor bug and was also necessary to prevent regressions caused by hanging
        on to a focused node after the document was replaced.
        * dom/Node.h:
        (WebCore::Node::inDetach):
        * page/Page.cpp: Migrated code from Document
        (WebCore::shouldAcquireEditingFocus):
        (WebCore::shouldRelinquishEditingFocus):
        (WebCore::clearSelectionIfNeeded):
        (WebCore::widgetForNode):
        (WebCore::Page::setFocusedNode):
        * page/Page.h:
        (WebCore::Page::focusedNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agobuild fix
ggaren [Tue, 12 Dec 2006 08:45:48 +0000 (08:45 +0000)]
build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Added the new XHR EventTarget methods to test results.
ap [Tue, 12 Dec 2006 08:28:15 +0000 (08:28 +0000)]
    Added the new XHR EventTarget methods to test results.

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Tue, 12 Dec 2006 07:59:58 +0000 (07:59 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=11053
        XMLHttpRequest should be an EventTarget

        Test: http/tests/xmlhttprequest/event-target.html

        * bindings/js/JSXMLHttpRequest.cpp:
        (KJS::JSXMLHttpRequest::mark):
        (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
        (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
        * bindings/js/JSXMLHttpRequest.h:
        (KJS::JSXMLHttpRequest::):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::addEventListener):
        (WebCore::XMLHttpRequest::removeEventListener):
        (WebCore::XMLHttpRequest::dispatchEvent):
        (WebCore::XMLHttpRequest::callReadyStateChangeListener):
        * xml/xmlhttprequest.h:
        (WebCore::XMLHttpRequest::eventListeners):
        Implement EventTarget methods (except for NS variations, which Firefox doesn't have either).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
darin [Tue, 12 Dec 2006 07:13:35 +0000 (07:13 +0000)]
    Reviewed by Geoff.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11809
          fast/dom/gc-8.html crash in alternate-thread marking code in ScriptInterpreter

        DocumentType objects were getting filed under the wrong document in the
        DOM objects structure.

        * bindings/js/kjs_binding.h: Added a destructor for debugging purposes only.
        * bindings/js/kjs_binding.cpp:
        (KJS::wrapperSet): Added. Set of outstanding wrappers for debugging.
        (KJS::addWrapper): Added.
        (KJS::removeWrapper): Added.
        (KJS::removeWrappers): Added.
        (KJS::DOMObject::~DOMObject): Added. Asserts that there is no outstanding reference
        to this wrapper since it's being destroyed.
        (KJS::ScriptInterpreter::putDOMObject): Added a call to ADD_WRAPPER.
        (KJS::ScriptInterpreter::forgetDOMObject): Added a call to REMOVE_WRAPPER.
        (KJS::ScriptInterpreter::forgetDOMNodeForDocument): Added a call to REMOVE_WRAPPER.
        (KJS::ScriptInterpreter::putDOMNodeForDocument): Added a call to ADD_WRAPPER.
        (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Added a call to REMOVE_WRAPPERS.
        (KJS::ScriptInterpreter::updateDOMNodeDocument): Added calls to REMOVE_WRAPPER and
        ADD_WRAPPER so the out-of-order transaction doesn't upset the assertions in the functions
        we're calling. Another solution would be to reorder the two, but I think that would
        create a race where another thread could garbage collect after the forget but before the put.
        (KJS::ScriptInterpreter::wasRunByUserGesture): Tweaked formatting.

        * dom/Document.cpp: (WebCore::Document::adoptNode): Removed call to updateDOMNodeDocument
        since setDocument now takes care of that.
        * dom/Node.cpp:
        (WebCore::Node::setDocument): Added call to updateDOMNodeDocument here.
        (WebCore::Node::checkAddChild): Removed call to updateDOMNodeDocument since setDocument
        now takes care of that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago http://bugs.webkit.org/show_bug.cgi?id=9673
ap [Tue, 12 Dec 2006 06:47:43 +0000 (06:47 +0000)]
    bugs.webkit.org/show_bug.cgi?id=9673
        Add support for window.atob() and window.btoa()

        Reviewed by Darin.

JavaScriptCore:
        * JavaScriptCore.exp: Export UString::is8Bit().
        * JavaScriptCore.xcodeproj/project.pbxproj: Added StringExtras.h as
        a private header.

WebCore:
        * WebCore.xcodeproj/project.pbxproj: Added Base64.{h,cpp}
        * bindings/js/kjs_window.cpp:
        (KJS::WindowFunc::callAsFunction):
        * bindings/js/kjs_window.h:
        (KJS::Window::):
        * platform/Base64.cpp: Added.
        (base64Encode):
        (base64Decode):
        * platform/Base64.h: Added.
        * ForwardingHeaders/wtf/StringExtras.h: Added.
        * platform/DeprecatedString.cpp: Use strncasecmp from StringExtras.

LayoutTests:
        * fast/dom/Window/atob-btoa-expected.txt: Added.
        * fast/dom/Window/atob-btoa.html: Added.
        * fast/dom/Window/btoa-pnglet-expected.checksum: Added.
        * fast/dom/Window/btoa-pnglet-expected.png: Added.
        * fast/dom/Window/btoa-pnglet-expected.txt: Added.
        * fast/dom/Window/btoa-pnglet.html: Added.
        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin [Tue, 12 Dec 2006 05:56:20 +0000 (05:56 +0000)]
WebCore:

        Reviewed by Brady.

        - did some of the Mac-specific file moves mentioned in my recent mail to the WebKit list

        * WebCore.xcodeproj/project.pbxproj: Updated project for file moves.

        * bridge/mac/FrameMac.h: Moved to page/mac.
        * bridge/mac/FrameMac.mm: Ditto.
        * bridge/mac/WebCoreFrameBridge.h: Ditto.
        * bridge/mac/WebCoreFrameBridge.mm: Ditto.
        * bridge/mac/WebCoreFrameView.h: Ditto.
        * bridge/mac/WebCoreViewFactory.h: Ditto.
        * bridge/mac/WebCoreViewFactory.m: Ditto.
        * bridge/mac/WebDashboardRegion.h: Ditto.
        * bridge/mac/WebDashboardRegion.m: Ditto.

        * bridge/mac/WebCoreKeyboardAccess.h: Moved to page/mac,
        renamed WebCoreKeyboardUIMode.h, and made a C++ header.

        * page/EventHandler.h: Updated for change to WebCoreKeyboardAccess.
        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::tabsToLinks): Ditto.
        (WebCore::EventHandler::tabsToAllControls): Ditto.
        (WebCore::EventHandler::keyboardUIMode): Ditto.

WebKit:

        Reviewed by Brady.

        - did some of the Mac-specific file moves mentioned in my recent mail to the WebKit list

        * WebCoreSupport/WebFrameBridge.h: Updated for change to WebCoreKeyboardAccess.
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): Ditto.
        (-[WebFrameBridge keyboardUIMode]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18169 268f45cc-cd09-0410-ab3c-d52691b4dbfc