aroben@apple.com [Wed, 1 Dec 2010 23:09:38 +0000 (23:09 +0000)]
Don't let harmless errorlevels from the "set" utility leak into project-specific build scripts
When using set to unset an environment variable that didn't previously
exist, set raises the errorlevel to 1. This was leaking into
project-specific scripts, causing them to think the build has failed.
We now clear the errorlevel after we finish setting environment
variables.
Fixes <http://webkit.org/b/50350> Windows builds mysteriously fail in
some configurations
Reviewed by Steve Falkenburg.
* win/tools/vsprops/common.vsprops: Call "cmd /c" after setting
environment variables to get rid of any errorlevel that "set" set.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73075
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 1 Dec 2010 23:08:52 +0000 (23:08 +0000)]
Teach git to ignore files installed by WebKitSupportLibrary and WebKitAuxiliaryLibrary
Fixes <http://webkit.org/b/50348> Git complains about lots of
untracked files in WebKitLibraries/win
Reviewed by Steve Falkenburg.
* .gitignore: Added files from these libraries.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73074
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 1 Dec 2010 23:04:01 +0000 (23:04 +0000)]
2010-12-01 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson.
Size changes on layer-backed drawing areas don't always end up with the correct value
https://bugs.webkit.org/show_bug.cgi?id=50351
<rdar://problem/
8692966>
When the UI process does not receive didSetSize messages promptly,
LayerBackedDrawingAreaProxy::setSize() bails early based on the
m_isWaitingForDidSetFrameNotification flag.
In this situation, the final size may be incorrect. didSetSize()
needs to compare the size that the web process has to the expected size,
and send a final setSize if they differ.
* UIProcess/LayerBackedDrawingAreaProxy.cpp:
(WebKit::LayerBackedDrawingAreaProxy::didSetSize):
(WebKit::LayerBackedDrawingAreaProxy::didReceiveMessage):
* UIProcess/LayerBackedDrawingAreaProxy.h:
* WebProcess/WebPage/LayerBackedDrawingArea.cpp:
(WebKit::LayerBackedDrawingArea::setSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73073
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 1 Dec 2010 22:44:07 +0000 (22:44 +0000)]
2010-12-01 Tony Chang <tony@chromium.org>
Unreviewed, one more try to get chromium drt bots green.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73072
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 1 Dec 2010 22:27:16 +0000 (22:27 +0000)]
Fix <rdar://problem/
8717674>.
Reviewed by Sam Weinig..
* WebProcess/com.apple.WebProcess.sb:
Allow the UI process to issue file-write extensions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73071
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 1 Dec 2010 22:24:31 +0000 (22:24 +0000)]
Fix windows build.
* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73070
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 1 Dec 2010 22:16:34 +0000 (22:16 +0000)]
2010-12-01 Martin Robinson <mrobinson@igalia.com>
Add missing file to the TestNetscapePlugin sources list after r73057.
* GNUmakefile.am: Add missing file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73069
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 1 Dec 2010 22:15:37 +0000 (22:15 +0000)]
Another windows build fix.
* UIProcess/API/C/win/WKView.cpp:
(WKViewCreate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73068
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 1 Dec 2010 22:08:49 +0000 (22:08 +0000)]
Attempt to fix Windows build.
* UIProcess/API/C/win/WKViewPrivate.cpp:
* UIProcess/API/C/win/WKViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73067
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 1 Dec 2010 22:00:01 +0000 (22:00 +0000)]
Add PageGrouping to WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=50332
Reviewed by Anders Carlsson.
WebKit2:
- Adds WKPageGroupRef and WKBundlePageGroupRef API objects
(backed by WebPageGroup and WebPageGroupProxy respectively).
- Moves visibleToInjectedBundle from page to PageGroup.
- Make userScript/userStyleSheet functions take a page group parameter.
* Shared/API/c/WKBase.h:
* Shared/APIObject.h:
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* Shared/WebPageGroupData.cpp: Added.
(WebKit::WebPageGroupData::encode):
(WebKit::WebPageGroupData::decode):
* Shared/WebPageGroupData.h: Added.
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageGetPageGroup):
* UIProcess/API/C/WKPage.h:
* UIProcess/API/C/WKPageGroup.cpp: Added.
(WKPageGroupGetTypeID):
(WKPageGroupCreateWithIdentifier):
(WKPageGroupCopyIdentifier):
* UIProcess/API/C/WKPageGroup.h: Added.
* UIProcess/API/C/WebKit2.h:
* UIProcess/API/C/win/WKView.cpp:
(WKViewCreate):
* UIProcess/API/C/win/WKView.h:
* UIProcess/API/mac/WKView.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:pageNamespaceRef:pageGroupRef:]):
(-[WKView initWithFrame:pageNamespaceRef:]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::QWKPagePrivate):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::createWebPage):
* UIProcess/WebContext.h:
* UIProcess/WebContextUserMessageCoders.h:
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::inspectorPageGroup):
* UIProcess/WebInspectorProxy.h:
* UIProcess/WebPageGroup.cpp: Added.
(WebKit::generatePageGroupID):
(WebKit::webPageGroupMap):
(WebKit::WebPageGroup::create):
(WebKit::WebPageGroup::get):
(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::~WebPageGroup):
* UIProcess/WebPageGroup.h: Added.
(WebKit::WebPageGroup::identifier):
(WebKit::WebPageGroup::pageGroupID):
(WebKit::WebPageGroup::data):
(WebKit::WebPageGroup::type):
* UIProcess/WebPageNamespace.cpp:
(WebKit::WebPageNamespace::createWebPage):
* UIProcess/WebPageNamespace.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::creationParameters):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::pageGroup):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createWebPage):
* UIProcess/WebProcessProxy.h:
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
* UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView):
* UIProcess/win/WebView.h:
(WebKit::WebView::create):
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleAddUserScript):
(WKBundleAddUserStyleSheet):
(WKBundleRemoveUserScript):
(WKBundleRemoveUserStyleSheet):
(WKBundleRemoveUserScripts):
(WKBundleRemoveUserStyleSheets):
(WKBundleRemoveAllUserContent):
(WKBundleOverrideXSSAuditorEnabledForTestRunner):
* WebProcess/InjectedBundle/API/c/WKBundle.h:
* WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageGetPageGroup):
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/API/c/WKBundlePageGroup.cpp: Added.
(WKBundlePageGroupGetTypeID):
(WKBundlePageGroupCopyIdentifier):
* WebProcess/InjectedBundle/API/c/WKBundlePageGroup.h: Added.
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideXSSAuditorEnabledForTestRunner):
(WebKit::InjectedBundle::addUserScript):
(WebKit::InjectedBundle::addUserStyleSheet):
(WebKit::InjectedBundle::removeUserScript):
(WebKit::InjectedBundle::removeUserStyleSheet):
(WebKit::InjectedBundle::removeUserScripts):
(WebKit::InjectedBundle::removeUserStyleSheets):
(WebKit::InjectedBundle::removeAllUserContent):
(WebKit::InjectedBundle::didInitializePageGroup):
* WebProcess/InjectedBundle/InjectedBundle.h:
* WebProcess/InjectedBundle/InjectedBundleClient.cpp:
(WebKit::InjectedBundleClient::didInitializePageGroup):
* WebProcess/InjectedBundle/InjectedBundleClient.h:
* WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::create):
(WebKit::WebPage::WebPage):
(WebKit::WebPage::close):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::pageGroup):
* WebProcess/WebPage/WebPageGroupProxy.cpp: Added.
(WebKit::WebPageGroupProxy::create):
(WebKit::WebPageGroupProxy::~WebPageGroupProxy):
* WebProcess/WebPage/WebPageGroupProxy.h: Added.
(WebKit::WebPageGroupProxy::identifier):
(WebKit::WebPageGroupProxy::pageGroupID):
(WebKit::WebPageGroupProxy::isVisibleToInjectedBundle):
(WebKit::WebPageGroupProxy::WebPageGroupProxy):
(WebKit::WebPageGroupProxy::type):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::webPageGroup):
* WebProcess/WebProcess.h:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:
WebKitTools:
- Update testing harnesses to deal with new PageGroup API.
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(WKBundleInitialize):
* TestWebKitAPI/InjectedBundleController.cpp:
(TestWebKitAPI::InjectedBundleController::initialize):
(TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
(TestWebKitAPI::InjectedBundleController::initializeTestNamed):
* TestWebKitAPI/InjectedBundleController.h:
* TestWebKitAPI/InjectedBundleTest.h:
(TestWebKitAPI::InjectedBundleTest::initialize):
(TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
* TestWebKitAPI/PlatformUtilities.cpp:
(TestWebKitAPI::Util::createContextForInjectedBundleTest):
* TestWebKitAPI/PlatformUtilities.h:
* TestWebKitAPI/PlatformWebView.h:
* TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
(TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
* TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
* TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didInitializePageGroup):
(WTR::InjectedBundle::initialize):
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::pageGroup):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::addUserScript):
(WTR::LayoutTestController::addUserStyleSheet):
(WTR::LayoutTestController::setXSSAuditorEnabled):
* WebKitTestRunner/TestController.cpp:
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::PlatformWebView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73066
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 1 Dec 2010 21:53:59 +0000 (21:53 +0000)]
JavaScriptCore: 010-12-01 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
vcproj changes can't be applied cleanly by the Windows EWS bot
https://bugs.webkit.org/show_bug.cgi?id=50328
* JavaScriptCore.vcproj/JavaScriptCore.sln: Modified property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Modified property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCF.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCFLite.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Modified property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Modified property svn:eol-style.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Modified property svn:eol-style.
* JavaScriptCore.vcproj/WTF/WTFCommon.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/jsc/jsc.vcproj: Modified property svn:eol-style.
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/testapi/testapi.vcproj: Modified property svn:eol-style.
* JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Added property svn:eol-style.
LayoutTests: Bug 50298 - /()()()()()()()()()(?:(\10a|b)(X|Y))+/.exec("bXXaYYaY") ASSERTs
Reviewed by Sam Weinig.
* fast/regex/script-tests/pcre-test-1.js:
Enable regex643, this now works.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73065
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 1 Dec 2010 21:49:22 +0000 (21:49 +0000)]
2010-12-01 Ojan Vafai <ojan@chromium.org>
[chromium] Green tree.
-http://trac.webkit.org/changeset/73057 caused plugins/get-user-agent-with-null-npp-from-npp-new.html
-Clean up a couple mistakes from http://trac.webkit.org/changeset/73059
-add a bug ID for fast/regex/pcre-test-1.html
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73064
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 1 Dec 2010 21:31:50 +0000 (21:31 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46645
Reviewed by Darin Adler.
Part 1 of making scrolling work with vertical text. This patch generalizes the scrollOriginX concept
recently added for horizontal RTL documents and applies it to writing modes as well. Now the
scrollOrigin is a point, since you can start off locked to the bottom or locked to the right.
This patch also fixes numerous bugs with the scrollOrigin code using native Mac NSScrollViews and
makes them behave the same as the cross-platform code (allowing for cross-platform results to be
landed).
WebCore:
* page/FrameView.cpp:
(WebCore::FrameView::adjustViewSize):
* page/mac/WebCoreFrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::maximumScrollPosition):
(WebCore::ScrollView::minimumScrollPosition):
(WebCore::ScrollView::valueChanged):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
(WebCore::ScrollView::scrollOrigin):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformSetScrollPosition):
(WebCore::ScrollView::platformSetScrollOrigin):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintRootBoxDecorations):
* rendering/RenderView.cpp:
(WebCore::RenderView::layout):
(WebCore::RenderView::docTop):
(WebCore::RenderView::docHeight):
(WebCore::RenderView::docLeft):
(WebCore::RenderView::docWidth):
* rendering/RenderView.h:
WebKit/mac:
* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView adjustForScrollOriginChange]):
(-[WebDynamicScrollBarsView updateScrollers]):
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
(-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
(-[WebDynamicScrollBarsView scrollOrigin]):
* WebView/WebFrameView.mm:
(-[WebFrameView _scrollToBeginningOfDocument]):
(-[WebFrameView _scrollToEndOfDocument]):
LayoutTests:
* fast/dom/vertical-scrollbar-in-rtl-doesnt-fire-onscroll-expected.txt: Added.
* fast/dom/vertical-scrollbar-in-rtl-doesnt-fire-onscroll.html: Added.
* fast/dom/vertical-scrollbar-in-rtl-expected.txt: Added.
* fast/dom/vertical-scrollbar-in-rtl.html: Added.
* fast/dom/vertical-scrollbar-when-dir-change-expected.txt: Added.
* fast/dom/vertical-scrollbar-when-dir-change.html: Added.
* platform/mac/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Removed.
* platform/mac/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73063
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Wed, 1 Dec 2010 21:21:18 +0000 (21:21 +0000)]
2010-11-30 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Upstream recent changes to WebCore/platform/network/android
https://bugs.webkit.org/show_bug.cgi?id=50224
Android implementation changes only, no new tests.
* platform/network/NetworkingContext.h:
* platform/network/android/CookieJarAndroid.cpp:
(WebCore::setCookies):
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
* platform/network/android/ProxyServerAndroid.cpp: Added.
(WebCore::proxyServersForURL):
* platform/network/android/ResourceHandleAndroid.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
* platform/network/android/ResourceRequestAndroid.cpp:
(WebCore::initializeMaximumHTTPConnectionCountPerHost):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73062
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
victorw@chromium.org [Wed, 1 Dec 2010 21:10:25 +0000 (21:10 +0000)]
2010-12-01 Victor Wang <victorw@chromium.org>
Unreviewed.
[Chromium] update chromium test expectations.
* platform/chromium/fast/xmlhttprequest: Added.
* platform/chromium/fast/xmlhttprequest/xmlhttprequest-responsetype-abort-expected.txt: Added.
* platform/chromium/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt: Added.
* platform/chromium/http/tests/xmlhttprequest/send-array-buffer-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73061
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Wed, 1 Dec 2010 21:01:27 +0000 (21:01 +0000)]
.: vcproj changes can't be applied cleanly by the Windows EWS bot
https://bugs.webkit.org/show_bug.cgi?id=50328
Reviewed by Adam Roben.
* .gitattributes:
ANGLE: vcproj changes can't be applied cleanly by the Windows EWS bot
https://bugs.webkit.org/show_bug.cgi?id=50328
Reviewed by Adam Roben.
* src/libEGL/libEGL.vcproj: Added property svn:eol-style.
* src/libGLESv2/libGLESv2.vcproj: Added property svn:eol-style.
JavaScriptCore: 010-12-01 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
vcproj changes can't be applied cleanly by the Windows EWS bot
https://bugs.webkit.org/show_bug.cgi?id=50328
* JavaScriptCore.vcproj/JavaScriptCore.sln: Modified property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Modified property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCF.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCFLite.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Modified property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Modified property svn:eol-style.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Modified property svn:eol-style.
* JavaScriptCore.vcproj/WTF/WTFCommon.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/jsc/jsc.vcproj: Modified property svn:eol-style.
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/testapi/testapi.vcproj: Modified property svn:eol-style.
* JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Added property svn:eol-style.
WebCore: vcproj changes can't be applied cleanly by the Windows EWS bot
https://bugs.webkit.org/show_bug.cgi?id=50328
Reviewed by Adam Roben.
* WebCore.vcproj/QTMovieWin.vcproj: Modified property svn:eol-style.
* WebCore.vcproj/QTMovieWinCommon.vsprops: Added property svn:eol-style.
* WebCore.vcproj/WebCore.sln: Modified property svn:eol-style.
* WebCore.vcproj/WebCore.submit.sln: Modified property svn:eol-style.
* WebCore.vcproj/WebCore.vcproj: Modified property svn:eol-style.
* WebCore.vcproj/WebCoreCFNetwork.vsprops: Added property svn:eol-style.
* WebCore.vcproj/WebCoreCG.vsprops: Added property svn:eol-style.
* WebCore.vcproj/WebCoreCURL.vsprops: Added property svn:eol-style.
* WebCore.vcproj/WebCoreCairo.vsprops: Added property svn:eol-style.
* WebCore.vcproj/WebCoreCommon.vsprops: Added property svn:eol-style.
* WebCore.vcproj/WebCoreGenerated.vcproj: Modified property svn:eol-style.
* WebCore.vcproj/WebCoreGeneratedCairo.vsprops: Added property svn:eol-style.
* WebCore.vcproj/WebCoreGeneratedCommon.vsprops: Added property svn:eol-style.
* WebCore.vcproj/WebCoreMediaQT.vsprops: Added property svn:eol-style.
* WebCore.vcproj/WebCorePthreads.vsprops: Added property svn:eol-style.
* WebCore.vcproj/WebCoreQuartzCore.vsprops: Added property svn:eol-style.
WebKit/win: vcproj changes can't be applied cleanly by the Windows EWS bot
https://bugs.webkit.org/show_bug.cgi?id=50328
Reviewed by Adam Roben.
* WebKit.vcproj/Interfaces.vcproj: Modified property svn:eol-style.
* WebKit.vcproj/InterfacesCommon.vsprops: Added property svn:eol-style.
* WebKit.vcproj/WebKit.sln: Modified property svn:eol-style.
* WebKit.vcproj/WebKit.submit.sln: Modified property svn:eol-style.
* WebKit.vcproj/WebKit.vcproj: Modified property svn:eol-style.
* WebKit.vcproj/WebKitGUID.vcproj: Modified property svn:eol-style.
* WebKit.vcproj/WebKitGUIDCommon.vsprops: Added property svn:eol-style.
* WebKit.vcproj/WebKitLibCommon.vsprops: Added property svn:eol-style.
WebKit2: vcproj changes can't be applied cleanly by the Windows EWS bot
https://bugs.webkit.org/show_bug.cgi?id=50328
Reviewed by Adam Roben.
* win/WebKit2.submit.sln: Added property svn:eol-style.
* win/WebKit2.vcproj: Added property svn:eol-style.
* win/WebKit2Apple.vsprops: Added property svn:eol-style.
* win/WebKit2CFLite.vsprops: Added property svn:eol-style.
* win/WebKit2Common.vsprops: Added property svn:eol-style.
* win/WebKit2DirectX.vsprops: Added property svn:eol-style.
* win/WebKit2Generated.vcproj: Added property svn:eol-style.
* win/WebKit2GeneratedCommon.vsprops: Added property svn:eol-style.
* win/WebKit2WebProcess.vcproj: Added property svn:eol-style.
* win/WebKit2WebProcessCommon.vsprops: Added property svn:eol-style.
WebKitLibraries: vcproj changes can't be applied cleanly by the Windows EWS bot
https://bugs.webkit.org/show_bug.cgi?id=50328
Reviewed by Adam Roben.
* win/tools/vsprops/WinCairo.vsprops: Added property svn:eol-style.
* win/tools/vsprops/cURL.vsprops: Added property svn:eol-style.
* win/tools/vsprops/debug_wincairo.vsprops: Added property svn:eol-style.
WebKitTools: vcproj changes can't be applied cleanly by the Windows EWS bot
https://bugs.webkit.org/show_bug.cgi?id=50328
Reviewed by Adam Roben.
* CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
* CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
* DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
* DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
* DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
* DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
* DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
* DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
* DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
* DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
* FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
* FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
* MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
* MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
* MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
* MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
* MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
* MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
* TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
* TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
* TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
* TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
* TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
* TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
* TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
* WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
* WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
* WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
* WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
* WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
* WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
* WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
* WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
* WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
* WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
* WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
* WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
* WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
* WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
* WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
* WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
* WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
* record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
* record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73060
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 1 Dec 2010 20:47:26 +0000 (20:47 +0000)]
2010-12-01 Tony Chang <tony@chromium.org>
Unreviewed, merging drt_expectations into test_expectations in
anticipation of the switch.
* platform/chromium/drt_expectations.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73059
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 1 Dec 2010 20:46:48 +0000 (20:46 +0000)]
2010-12-01 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson.
Crash when closing WebKit2 window with accelerated composting content
https://bugs.webkit.org/show_bug.cgi?id=50307
<rdar://problem/
8640126>
When the web page is closing, notify the drawing area, so that
the layer-backed drawing area can kill the runloop obsever,
then clear it. Clearing it is not sufficient, since the drawing
area is ref-counted.
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::onPageClose):
* WebProcess/WebPage/LayerBackedDrawingArea.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):
* WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
(WebKit::LayerBackedDrawingArea::platformClear):
(WebKit::LayerBackedDrawingArea::onPageClose):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73058
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 1 Dec 2010 20:12:50 +0000 (20:12 +0000)]
Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
https://bugs.webkit.org/show_bug.cgi?id=50336
Reviewed by Darin Adler.
WebKit2:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_UserAgent):
Call the static NetscapePlugin::userAgent function instead.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::userAgent):
If the passed in NPP is null, get the NetscapePlugin currently executing NPP_New.
(WebKit::NetscapePlugin::initialize):
Keep track of the plug-in currently executing NPP_New.
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
WebKitTools:
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Add new test.
* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPP_New):
Add default implementation/
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
* DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
(GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
(GetUserAgentWithNullNPPFromNPPNew::NPP_New):
Get the user agent.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New):
Call PluginTest::NPP_New.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
Add new files.
* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_new_instance):
Call PluginTest::NPP_New.
LayoutTests:
Add tests.
* plugins/get-user-agent-with-null-npp-from-npp-new-expected.txt: Added.
* plugins/get-user-agent-with-null-npp-from-npp-new.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73057
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 1 Dec 2010 20:04:22 +0000 (20:04 +0000)]
Bug 50297 - \s in YARR should match BOMs.
Rubber stamped by Sam Weinig.
JavaScriptCore:
* create_regex_tables:
LayoutTests:
This exposes a Sputnik bug, tracked by:
http://code.google.com/p/sputniktests/issues/detail?id=34
Checking in expected failing results.
* fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.12_CharacterClassEscape/S15.10.2.12_A1_T1-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.12_CharacterClassEscape/S15.10.2.12_A2_T1-expected.txt:
* fast/regex/script-tests/pcre-test-1.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73056
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vangelis@chromium.org [Wed, 1 Dec 2010 20:04:05 +0000 (20:04 +0000)]
2010-11-30 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Darin Fisher.
Get the value of the accelerated compositing triggers from the Settings
class. This allows setting the triggers via command line flags.
https://bugs.webkit.org/show_bug.cgi?id=50301
* public/WebSettings.h:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::allowedCompositingTriggers):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setAcceleratedCompositingFor3DTransformsEnabled):
(WebKit::WebSettingsImpl::setAcceleratedCompositingForVideoEnabled):
(WebKit::WebSettingsImpl::setAcceleratedCompositingForPluginsEnabled):
(WebKit::WebSettingsImpl::setAcceleratedCompositingForCanvasEnabled):
(WebKit::WebSettingsImpl::setAcceleratedCompositingForAnimationEnabled):
* src/WebSettingsImpl.h:
2010-11-30 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Darin Fisher.
Adds accelerated compositing trigger flags to Settings to allow
ports to set them via command line flags, etc.
https://bugs.webkit.org/show_bug.cgi?id=50301
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setAcceleratedCompositingFor3DTransformsEnabled):
(WebCore::Settings::setAcceleratedCompositingForVideoEnabled):
(WebCore::Settings::setAcceleratedCompositingForPluginsEnabled):
(WebCore::Settings::setAcceleratedCompositingForCanvasEnabled):
(WebCore::Settings::setAcceleratedCompositingForAnimationEnabled):
* page/Settings.h:
(WebCore::Settings::acceleratedCompositingFor3DTransformsEnabled):
(WebCore::Settings::acceleratedCompositingForVideoEnabled):
(WebCore::Settings::acceleratedCompositingForPluginsEnabled):
(WebCore::Settings::acceleratedCompositingForCanvasEnabled):
(WebCore::Settings::acceleratedCompositingForAnimationEnabled):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73055
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 1 Dec 2010 19:55:20 +0000 (19:55 +0000)]
Re-added Leopard-specific results for editing/text-iterator/findString.html. In the Leopard version
of ICU, the full stop character is a word separator, so an at-word-starts search for "org" in
"webkit.org" matches.
* platform/mac-leopard/editing/text-iterator: Added.
* platform/mac-leopard/editing/text-iterator/findString-expected.txt: Copied from LayoutTests/editing/text-iterator/findString-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73054
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 1 Dec 2010 19:54:27 +0000 (19:54 +0000)]
Fixed warning seen on buildbot.
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::SharedValues::SharedValues): Added #if.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73053
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 1 Dec 2010 19:50:55 +0000 (19:50 +0000)]
2010-12-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci.
chrome.dll!WebCore::RangeBoundaryPoint::toPosition ReadAV@NULL (
cf0d0f28bc56f2591cc74f71b46036ea)
https://bugs.webkit.org/show_bug.cgi?id=47808
The crash was caused by moveParagraphWithClones' not copying the entire paragraph
when called by doApplyForSingleParagraph, which was induced by a bug in
cloneParagraphUnderNewElement which ended the cloning process early when the start node
and the end node didn't share the same parent node. Fixed the bug in cloneParagraphUnderNewElement
by calling traverseNextSibling(outerNode) instead of nextSibling().
Also added an early exit to InsertListCommand::doApply when lastSelectionRange is null.
Tests: editing/execCommand/switch-multiple-list-items-crash.html
editing/execCommand/switch-multiple-list-items.html
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply):
2010-12-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci.
chrome.dll!WebCore::RangeBoundaryPoint::toPosition ReadAV@NULL (
cf0d0f28bc56f2591cc74f71b46036ea)
https://bugs.webkit.org/show_bug.cgi?id=47808
Added tests to ensure WebKit can switch the type of multiple list items without a crash.
* editing/execCommand/switch-multiple-list-items-crash-expected.txt: Added.
* editing/execCommand/switch-multiple-list-items-crash.html: Added.
* editing/execCommand/switch-multiple-list-items-expected.txt: Added.
* editing/execCommand/switch-multiple-list-items.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73052
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Wed, 1 Dec 2010 19:46:19 +0000 (19:46 +0000)]
[wx] Build fixes after recent trunk changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73051
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Wed, 1 Dec 2010 19:41:14 +0000 (19:41 +0000)]
Not reviewed, upstreaming test suppression.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73050
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 1 Dec 2010 19:39:04 +0000 (19:39 +0000)]
2010-12-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73047.
http://trac.webkit.org/changeset/73047
https://bugs.webkit.org/show_bug.cgi?id=50339
missing bug number (Requested by rniwa on #webkit).
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply):
2010-12-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73047.
http://trac.webkit.org/changeset/73047
https://bugs.webkit.org/show_bug.cgi?id=50339
missing bug number (Requested by rniwa on #webkit).
* editing/execCommand/switch-multiple-list-items-crash-expected.txt: Removed.
* editing/execCommand/switch-multiple-list-items-crash.html: Removed.
* editing/execCommand/switch-multiple-list-items-expected.txt: Removed.
* editing/execCommand/switch-multiple-list-items.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73049
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Wed, 1 Dec 2010 19:34:07 +0000 (19:34 +0000)]
Add failing Windows expected results for tests that involve the xhr.arrayBuffer = 'arraybuffer',
which works on Mac, but not on Windows.
Getting arrayBuffer working on Windows is being tracked by https://bugs.webkit.org/show_bug.cgi?id=50334.
* platform/win/fast/xmlhttprequest: Added.
* platform/win/fast/xmlhttprequest/xmlhttprequest-responsetype-abort-expected.txt: Added.
* platform/win/fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt: Added.
* platform/win/http/tests/xmlhttprequest: Added.
* platform/win/http/tests/xmlhttprequest/send-array-buffer-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73048
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 1 Dec 2010 19:28:42 +0000 (19:28 +0000)]
2010-12-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci.
The crash was caused by moveParagraphWithClones' not copying the entire paragraph
when called by doApplyForSingleParagraph, which was induced by a bug in
cloneParagraphUnderNewElement which ended the cloning process early when the start node
and the end node didn't share the same parent node. Fixed the bug in cloneParagraphUnderNewElement
by calling traverseNextSibling(outerNode) instead of nextSibling().
Also added an early exit to InsertListCommand::doApply when lastSelectionRange is null.
Tests: editing/execCommand/switch-multiple-list-items-crash.html
editing/execCommand/switch-multiple-list-items.html
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply):
2010-12-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci.
Added tests to ensure WebKit can switch the type of multiple list items without a crash.
* editing/execCommand/switch-multiple-list-items-crash-expected.txt: Added.
* editing/execCommand/switch-multiple-list-items-crash.html: Added.
* editing/execCommand/switch-multiple-list-items-expected.txt: Added.
* editing/execCommand/switch-multiple-list-items.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73047
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Wed, 1 Dec 2010 19:13:41 +0000 (19:13 +0000)]
2010-12-01 Grace Kloba <klobag@chromium.org>
Reviewed by Kenneth Russell.
[chromium] ContentLayerChromium shader should honor the platform Sk_x_SHIFT value instead of assuming BGRA color
https://bugs.webkit.org/show_bug.cgi?id=50189
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::SharedValues::SharedValues):Use SK_B32_SHIFT to decide whether to use RGBA or BGRA shader for Skia port.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73046
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Wed, 1 Dec 2010 19:08:23 +0000 (19:08 +0000)]
One last Windows build fix.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::switchToDrawingAreaTypeIfNecessary):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73045
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 1 Dec 2010 18:59:57 +0000 (18:59 +0000)]
Fix Windows build.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::pageDidEnterAcceleratedCompositing):
(WebKit::WebView::pageDidLeaveAcceleratedCompositing):
(WebKit::WebView::switchToDrawingAreaTypeIfNecessary):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73044
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Wed, 1 Dec 2010 18:51:16 +0000 (18:51 +0000)]
Skip another HTMLProgressElement test on Windows, because it's not turned on for Windows yet. Adding
progress element support on Windows is being tracked by https://bugs.webkit.org/show_bug.cgi?id=49769.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73043
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 1 Dec 2010 18:43:33 +0000 (18:43 +0000)]
Fix build.
* UIProcess/win/WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73042
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vitalyr@chromium.org [Wed, 1 Dec 2010 18:40:27 +0000 (18:40 +0000)]
2010-12-01 Vitaly Repeshko <vitalyr@chromium.org>
Unreviewed.
[chromium] Updating test expectations and rebaselining.
* platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.checksum:
* platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum:
* platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.checksum:
* platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.txt:
* platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum:
* platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73041
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 1 Dec 2010 18:36:44 +0000 (18:36 +0000)]
WebKitTestRunner needs layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50238
Reviewed by Darin Adler.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73039
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 1 Dec 2010 18:34:31 +0000 (18:34 +0000)]
2010-12-01 Tony Chang <tony@chromium.org>
Unreviewed, rolling chromium deps to r67811.
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73038
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 1 Dec 2010 18:23:13 +0000 (18:23 +0000)]
Get rid of DrawingAreaBase
https://bugs.webkit.org/show_bug.cgi?id=50329
Reviewed by Andreas Kling.
* Scripts/webkit2/messages.py:
* Shared/DrawingAreaInfo.h:
(WebKit::DrawingAreaInfo::DrawingAreaInfo):
* Shared/WebPageCreationParameters.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):
(-[WKView _pageDidEnterAcceleratedCompositing]):
(-[WKView _pageDidLeaveAcceleratedCompositing]):
* UIProcess/API/qt/qgraphicswkview.cpp:
(QGraphicsWKView::takeSnapshot):
(QGraphicsWKViewPrivate::commitScale):
* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):
(WebKit::ChunkedUpdateDrawingAreaProxy::setSize):
(WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible):
(WebKit::ChunkedUpdateDrawingAreaProxy::update):
* UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::nextIdentifier):
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::info):
* UIProcess/LayerBackedDrawingAreaProxy.cpp:
(WebKit::LayerBackedDrawingAreaProxy::LayerBackedDrawingAreaProxy):
(WebKit::LayerBackedDrawingAreaProxy::setSize):
(WebKit::LayerBackedDrawingAreaProxy::setPageIsVisible):
(WebKit::LayerBackedDrawingAreaProxy::update):
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeAcceleratedCompositing):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::switchToDrawingAreaTypeIfNecessary):
* WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
(WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea):
(WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
* WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
(WebKit::DrawingArea::DrawingArea):
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::info):
* WebProcess/WebPage/LayerBackedDrawingArea.cpp:
(WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea):
(WebKit::LayerBackedDrawingArea::didReceiveMessage):
* WebProcess/WebPage/LayerBackedDrawingArea.h:
* WebProcess/WebPage/TiledDrawingArea.cpp:
(WebKit::TiledDrawingArea::TiledDrawingArea):
* WebProcess/WebPage/TiledDrawingArea.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::changeAcceleratedCompositingMode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73036
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vitalyr@chromium.org [Wed, 1 Dec 2010 18:15:52 +0000 (18:15 +0000)]
2010-12-01 Vitaly Repeshko <vitalyr@chromium.org>
Unreviewed.
[chromium] Cleaning up test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73034
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 1 Dec 2010 17:58:57 +0000 (17:58 +0000)]
2010-12-01 Tony Chang <tony@chromium.org>
Unreviewed, update drt expectations.
* platform/chromium/drt_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73033
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Wed, 1 Dec 2010 17:49:09 +0000 (17:49 +0000)]
2010-12-01 Nico Weber <thakis@chromium.org>
Reviewed by Dimitri Glazkov.
Fix clang warnings caused by -Wlogical-op-parentheses
https://bugs.webkit.org/show_bug.cgi?id=50324
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73032
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 1 Dec 2010 17:25:09 +0000 (17:25 +0000)]
2010-12-01 Martin Robinson <mrobinson@igalia.com>
Build fix for GTK+.
* platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenuGtk::typeAheadFind): Uncomment mistakenly commented line.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73030
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vitalyr@chromium.org [Wed, 1 Dec 2010 17:18:07 +0000 (17:18 +0000)]
2010-12-01 Vitaly Repeshko <vitalyr@chromium.org>
Unreviewed.
[chromium] Updating test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73029
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Wed, 1 Dec 2010 17:07:16 +0000 (17:07 +0000)]
Try using svn:eol-style native on a vcproj file.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73028
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 1 Dec 2010 17:04:29 +0000 (17:04 +0000)]
Unrreviewed.
[Qt] Add focus ring outline color support
https://bugs.webkit.org/show_bug.cgi?id=50325
Focus ring outline color is unsupported now.
Add failing tests to the Skipped list until fix.
* platform/qt/Skipped:
- fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html added
- fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html added
- fast/images/imagemap-focus-ring-outline-color.html added
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73027
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 1 Dec 2010 16:49:35 +0000 (16:49 +0000)]
2010-12-01 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
[WINCE] Add WinCELauncher
https://bugs.webkit.org/show_bug.cgi?id=50217
* WinCELauncher/main.cpp: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73026
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 1 Dec 2010 16:46:39 +0000 (16:46 +0000)]
2010-12-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Open menulists should support typeahead find
https://bugs.webkit.org/show_bug.cgi?id=27443
Added a GTK+-specific layout test to track typeahead find state.
* platform/gtk/fast/forms/menulist-typeahead-find-expected.txt: Added.
* platform/gtk/fast/forms/menulist-typeahead-find.html: Added.
2010-12-01 Apelete Seketeli <apelete@seketeli.org> and Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Open menulists should support typeahead find
https://bugs.webkit.org/show_bug.cgi?id=27443
Added typeahead find support for open GTK+ menulists.
Test: platform/gtk/fast/forms/menulist-typeahead-find.html
* platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenuGtk::PopupMenuGtk): Initialize new members.
(WebCore::PopupMenuGtk::show): Track currently selected menu item
via a signal handler.
(WebCore::PopupMenuGtk::typeAheadFind): Added.
(WebCore::PopupMenuGtk::menuUnmapped): Reset typeahead find state
when menu is unmapped.
(WebCore::PopupMenuGtk::resetTypeAheadFindState): Added.
(WebCore::PopupMenuGtk::selectItemCallback): Added.
(WebCore::PopupMenuGtk::keyPressEventCallback): Added.
* platform/gtk/PopupMenuGtk.h: Added new members to track typeahead
find state.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73025
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 1 Dec 2010 16:36:29 +0000 (16:36 +0000)]
2010-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Xan Lopez.
Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGAnimatedNumber
https://bugs.webkit.org/show_bug.cgi?id=50323
Continuing the work on bug 42025: Introduce DECLARE_ANIMATED_NUMBER / DEFINE_ANIMATED_NUMBER.
The animated property declaration lives in the header, the definition in the cpp file, to avoid the dependency on SVGNames.h in all headers.
No functional changes, thus no new tests.
* svg/SVGAnimatedNumber.h:
* svg/SVGComponentTransferFunctionElement.cpp:
* svg/SVGComponentTransferFunctionElement.h:
* svg/SVGFECompositeElement.cpp:
* svg/SVGFECompositeElement.h:
* svg/SVGFEConvolveMatrixElement.cpp:
* svg/SVGFEConvolveMatrixElement.h:
* svg/SVGFEDiffuseLightingElement.cpp:
* svg/SVGFEDiffuseLightingElement.h:
* svg/SVGFEDisplacementMapElement.cpp:
* svg/SVGFEDisplacementMapElement.h:
* svg/SVGFEGaussianBlurElement.cpp:
* svg/SVGFEGaussianBlurElement.h:
* svg/SVGFELightElement.cpp:
* svg/SVGFELightElement.h:
* svg/SVGFEMorphologyElement.cpp:
* svg/SVGFEMorphologyElement.h:
* svg/SVGFEOffsetElement.cpp:
* svg/SVGFEOffsetElement.h:
* svg/SVGFESpecularLightingElement.cpp:
* svg/SVGFESpecularLightingElement.h:
* svg/SVGFETurbulenceElement.cpp:
* svg/SVGFETurbulenceElement.h:
* svg/SVGPathElement.cpp:
* svg/SVGPathElement.h:
* svg/SVGStopElement.cpp:
* svg/SVGStopElement.h:
(WebCore::SVGStopElement::isGradientStop):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73024
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 1 Dec 2010 16:15:17 +0000 (16:15 +0000)]
2010-12-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
Sliders are not transformed after r50188
https://bugs.webkit.org/show_bug.cgi?id=50317
Need to call updateLayerTransform during slider layout, as sliders
may be transformed.
No new tests. This patch should make fast/forms/slider-transformed.html
pass on the GTK+ bots.
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::layout): Call updateLayerTransform here.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73023
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 1 Dec 2010 16:13:28 +0000 (16:13 +0000)]
2010-12-01 Martin Robinson <mrobinson@igalia.com>
Skip failing tests for text height on GTK
https://bugs.webkit.org/show_bug.cgi?id=50314
* platform/gtk/Skipped: Skip failing tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73022
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 1 Dec 2010 15:52:26 +0000 (15:52 +0000)]
2010-11-30 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: do not make helpScreen.css lazily loaded.
https://bugs.webkit.org/show_bug.cgi?id=50304
* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen):
(WebInspector.HelpScreen.prototype._onBlur):
* inspector/front-end/inspector.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73021
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 1 Dec 2010 15:41:53 +0000 (15:41 +0000)]
2010-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Xan Lopez.
Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGLengthList/SVGNumberList/SVGTransformList
https://bugs.webkit.org/show_bug.cgi?id=50322
Continuing the work on bug 42025: Introduce DECLARE_ANIMATED_(LENGTH|NUMBER|TRANSFORM)_LIST / DEFINE_ANIMATED_(LENGTH|NUMBER|TRANSFORM).
The animated property declaration lives in the header, the definition in the cpp file, to avoid the dependency on SVGNames.h in all headers.
No functional changes, thus no new tests.
* svg/SVGAnimatedLengthList.h:
* svg/SVGAnimatedNumberList.h:
* svg/SVGAnimatedTransformList.h:
* svg/SVGComponentTransferFunctionElement.cpp:
* svg/SVGComponentTransferFunctionElement.h:
* svg/SVGFEColorMatrixElement.cpp:
* svg/SVGFEColorMatrixElement.h:
* svg/SVGFEConvolveMatrixElement.cpp:
* svg/SVGFEConvolveMatrixElement.h:
* svg/SVGGradientElement.cpp:
* svg/SVGGradientElement.h:
(WebCore::SVGGradientElement::needsPendingResourceHandling):
* svg/SVGPatternElement.cpp:
* svg/SVGPatternElement.h:
* svg/SVGPolygonElement.cpp:
* svg/SVGPolylineElement.cpp:
* svg/SVGStyledTransformableElement.cpp:
* svg/SVGStyledTransformableElement.h:
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::SVGTextElement):
* svg/SVGTextElement.h:
(WebCore::SVGTextElement::localCoordinateSpaceTransform):
* svg/SVGTextPositioningElement.cpp:
* svg/SVGTextPositioningElement.h:
* svg/properties/SVGAnimatedPropertyMacros.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73020
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
chang.shu@nokia.com [Wed, 1 Dec 2010 15:32:13 +0000 (15:32 +0000)]
2010-12-01 Chang Shu <chang.shu@nokia.com>
Reviewed by Laszlo Gombos.
Move orientation event test case to a better place.
https://bugs.webkit.org/show_bug.cgi?id=32492
* fast/dom/DeviceOrientation/create-event-orientationchange-expected.txt: Removed.
* fast/dom/DeviceOrientation/create-event-orientationchange.html: Removed.
* fast/dom/DeviceOrientation/script-tests/create-event-orientationchange.js: Removed.
* fast/dom/Orientation: Added.
* fast/dom/Orientation/create-event-orientationchange-expected.txt: Copied from LayoutTests/fast/dom/DeviceOrientation/create-event-orientationchange-expected.txt.
* fast/dom/Orientation/create-event-orientationchange.html: Copied from LayoutTests/fast/dom/DeviceOrientation/create-event-orientationchange.html.
* fast/dom/Orientation/script-tests: Added.
* fast/dom/Orientation/script-tests/create-event-orientationchange.js: Copied from LayoutTests/fast/dom/DeviceOrientation/script-tests/create-event-orientationchange.js.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73019
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 1 Dec 2010 14:14:19 +0000 (14:14 +0000)]
2010-12-01 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: name-only property appears in style declaration but not in the Styles pane
https://bugs.webkit.org/show_bug.cgi?id=49663
Check that at least one property has been parsed from the user input.
WebCore:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
LayoutTests:
* inspector/styles-new-API.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73018
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 1 Dec 2010 13:29:50 +0000 (13:29 +0000)]
2010-12-01 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: disable cookies tab in network resource view by default, enable for chromium
https://bugs.webkit.org/show_bug.cgi?id=50249
* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView):
(WebInspector.NetworkItemView.prototype.resize):
* inspector/front-end/Settings.js:
2010-12-01 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: disable cookies tab in network resource view by default, enable for chromium
https://bugs.webkit.org/show_bug.cgi?id=50249
* src/js/DevTools.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73017
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 1 Dec 2010 12:17:12 +0000 (12:17 +0000)]
2010-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Xan Lopez.
Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGLength
https://bugs.webkit.org/show_bug.cgi?id=50316
Introduce DECLARE_ANIMATED_LENGTH / DEFINE_ANIMATED_LENGTH, splitting up the original DECLARE_ANIMATED_PROPERTY_NEW macro
in a part that goes in the .cpp file and another that remains in the header. This avoids having to include SVGNames.h
in all SVG*Element files.
No functional changes, thus no new tests.
* svg/SVGAnimatedLength.h:
* svg/SVGCircleElement.cpp:
* svg/SVGCircleElement.h:
(WebCore::SVGCircleElement::isValid):
* svg/SVGCursorElement.cpp:
* svg/SVGCursorElement.h:
(WebCore::SVGCursorElement::isValid):
* svg/SVGEllipseElement.cpp:
* svg/SVGEllipseElement.h:
(WebCore::SVGEllipseElement::isValid):
* svg/SVGFilterElement.cpp:
* svg/SVGFilterElement.h:
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
* svg/SVGFilterPrimitiveStandardAttributes.h:
* svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
* svg/SVGForeignObjectElement.h:
(WebCore::SVGForeignObjectElement::isValid):
* svg/SVGImageElement.cpp:
* svg/SVGImageElement.h:
(WebCore::SVGImageElement::isValid):
* svg/SVGLineElement.cpp:
* svg/SVGLineElement.h:
(WebCore::SVGLineElement::isValid):
(WebCore::SVGLineElement::supportsMarkers):
* svg/SVGLinearGradientElement.cpp:
* svg/SVGLinearGradientElement.h:
* svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::SVGMarkerElement):
* svg/SVGMarkerElement.h:
* svg/SVGMaskElement.cpp:
* svg/SVGMaskElement.h:
(WebCore::SVGMaskElement::isValid):
(WebCore::SVGMaskElement::needsPendingResourceHandling):
* svg/SVGPatternElement.cpp:
* svg/SVGPatternElement.h:
(WebCore::SVGPatternElement::isValid):
(WebCore::SVGPatternElement::needsPendingResourceHandling):
* svg/SVGRadialGradientElement.cpp:
* svg/SVGRadialGradientElement.h:
* svg/SVGRectElement.cpp:
* svg/SVGRectElement.h:
(WebCore::SVGRectElement::isValid):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
* svg/SVGSVGElement.h:
(WebCore::SVGSVGElement::isValid):
(WebCore::SVGSVGElement::setContainerSize):
(WebCore::SVGSVGElement::containerSize):
(WebCore::SVGSVGElement::hasSetContainerSize):
(WebCore::SVGSVGElement::currentTranslate):
(WebCore::SVGSVGElement::timeContainer):
(WebCore::SVGSVGElement::isSVG):
(WebCore::SVGSVGElement::rendererIsNeeded):
* svg/SVGTextContentElement.cpp:
* svg/SVGTextContentElement.h:
(WebCore::SVGTextContentElement::isValid):
(WebCore::SVGTextContentElement::isTextContent):
* svg/SVGTextPathElement.cpp:
* svg/SVGTextPathElement.h:
* svg/SVGTextPositioningElement.h:
* svg/SVGUseElement.cpp:
* svg/SVGUseElement.h:
(WebCore::SVGUseElement::isValid):
(WebCore::SVGUseElement::setUpdatesBlocked):
(WebCore::SVGUseElement::isPendingResource):
* svg/properties/SVGAnimatedPropertyMacros.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73016
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 1 Dec 2010 12:03:53 +0000 (12:03 +0000)]
2010-12-01 Anton D'Auria <adauria@apple.com>
Reviewed by Kevin Decker.
Private browsing denies read access to local and session storage,
so updating expected test results.
https://bugs.webkit.org/show_bug.cgi?id=49329
* storage/domstorage/localstorage/private-browsing-affects-storage-expected.txt:
* storage/domstorage/sessionstorage/private-browsing-affects-storage-expected.txt:
2010-12-01 Anton D'Auria <adauria@apple.com>
Reviewed by Kevin Decker.
Deny access to local and session storage in private browsing mode.
https://bugs.webkit.org/show_bug.cgi?id=49329
* storage/Storage.cpp:
(WebCore::Storage::length):
(WebCore::Storage::key):
(WebCore::Storage::getItem):
(WebCore::Storage::contains):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73015
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 1 Dec 2010 11:41:04 +0000 (11:41 +0000)]
2010-12-01 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
Volume control not correctly initialized
https://bugs.webkit.org/show_bug.cgi?id=36299
Replaced the mute/volume Timers with g_timeouts which are (for
now, at least) more reliable than Timers for one-shot-fire-now
actions.
Test: media/video-volume.html
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::~MediaPlayer): Reset the raw pointers to 0
when destructing the player.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateVolumeChangeTimeoutCallback):
(WebCore::mediaPlayerPrivateMuteChangeTimeoutCallback):
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVolumeChange):
(WebCore::MediaPlayerPrivateGStreamer::volumeChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfMute):
(WebCore::MediaPlayerPrivateGStreamer::muteChanged):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Set
playbin2 volume/mute base on MediaPlayer related values.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Wed, 1 Dec 2010 11:32:32 +0000 (11:32 +0000)]
2010-12-01 Hayato Ito <hayato@chromium.org>
Unreviewed trivial fix.
Removed fast/regex/{test1,test4}.html because they were removed from tree by r72990
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac-wk2/Skipped:
* platform/qt-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 1 Dec 2010 10:47:20 +0000 (10:47 +0000)]
2010-12-01 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
Cleanup main CMakeLists.txt after r72664, r72672 and r72667
https://bugs.webkit.org/show_bug.cgi?id=50232
* CMakeLists.txt: Removed obsolete dependencies.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73012
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 1 Dec 2010 08:57:20 +0000 (08:57 +0000)]
2010-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Cleanup SVGPropertyTraits
https://bugs.webkit.org/show_bug.cgi?id=50229
Move all template specializations for non-POD types (eg. SVGLength, SVGLengthList, etc.) from SVGPropertyTraits
into the right SVG* classes, to avoid having to include a dozen SVG*.h files in SVGPropertyTraits.h, which is
included by all DOM/JS/V8 binding files and SVGElement.h.
No new functionality, thus no new tests.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/CodeGenerator.pm:
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* svg/SVGAngle.h:
* svg/SVGLength.h:
* svg/SVGLengthList.h:
* svg/SVGMarkerElement.h:
* svg/SVGNumberList.h:
* svg/SVGPatternElement.h:
* svg/SVGPointList.h:
* svg/SVGPreserveAspectRatio.h:
* svg/SVGRect.h: Added.
* svg/SVGSVGElement.h:
* svg/SVGStringList.h:
* svg/SVGSymbolElement.h:
* svg/SVGTransformList.h:
* svg/SVGViewElement.h:
* svg/SVGViewSpec.h:
* svg/properties/SVGListProperty.h:
* svg/properties/SVGPropertyTraits.h:
* svg/properties/SVGTransformListPropertyTearOff.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73011
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 1 Dec 2010 08:13:15 +0000 (08:13 +0000)]
Unreviewed trivial fix.
* platform/qt/Skipped:
- editing/selection/
5109817.html: removed, because it was removed from tree by r73009
- fast/regex/test1.html: removed, because it was removed from tree by r72990
- fast/regex/test4.html: removed, because it was removed from tree by r72990
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73010
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 1 Dec 2010 05:37:32 +0000 (05:37 +0000)]
2010-11-30 Avi Drissman <avi@google.com>
Reviewed by Darin Adler.
Add preference to not select when right-clicked
https://bugs.webkit.org/show_bug.cgi?id=23351
Removed
5109817 because it is entirely superseded by
context-menu-text-selection; updated
5354455-1 to explicitly set the
editing behavior and test all three platforms.
* editing/selection/
5109817.html: Removed.
* editing/selection/
5354455-1-expected.txt: Added.
* editing/selection/
5354455-1.html:
* platform/chromium-win/editing/selection/
5109817-expected.txt: Removed.
* platform/chromium-win/editing/selection/
5354455-1-expected.txt: Removed.
* platform/gtk/editing/selection/
5109817-expected.txt: Removed.
* platform/gtk/editing/selection/
5354455-1-expected.txt: Removed.
* platform/mac-leopard/editing/selection/
5109817-expected.checksum: Removed.
* platform/mac-leopard/editing/selection/
5109817-expected.png: Removed.
* platform/mac/editing/selection/
5109817-expected.checksum: Removed.
* platform/mac/editing/selection/
5109817-expected.png: Removed.
* platform/mac/editing/selection/
5109817-expected.txt: Removed.
* platform/mac/editing/selection/
5354455-1-expected.txt: Removed.
* platform/win/editing/selection/
5109817-expected.checksum: Removed.
* platform/win/editing/selection/
5109817-expected.png: Removed.
* platform/win/editing/selection/
5109817-expected.txt: Removed.
* platform/win/editing/selection/
5354455-1-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73009
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 1 Dec 2010 04:36:46 +0000 (04:36 +0000)]
Refactor HTMLInputElement: Move a part of HTMLInputElement::
defaultEventHandler() to InputTypes
https://bugs.webkit.org/show_bug.cgi?id=50097
Reviewed by Darin Adler.
Move all of keyboard-related event handling to InputType.
No new tests because this should not change any behavior.
* html/BaseButtonInputType.cpp:
(WebCore::BaseButtonInputType::handleKeydownEvent):
(WebCore::BaseButtonInputType::handleKeypressEvent):
(WebCore::BaseButtonInputType::handleKeyupEvent):
* html/BaseButtonInputType.h:
* html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::handleKeydownEvent):
(WebCore::BaseCheckableInputType::handleKeypressEvent):
* html/BaseCheckableInputType.h:
* html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::handleKeyupEvent):
* html/CheckboxInputType.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
We remove !implicitSubmission check for callBaseClassEarly because
implicitSubmission can not be true for keydown event and keypress
event at this point.
* html/InputType.cpp:
(WebCore::InputType::shouldSubmitImplicitly):
Returns true for a keypress event with "\r". Note that we don't overload
this function for BUTTON, FILE, IMAGE, RESET, and SUBMIT because a
keypress event with "\r" for these types returns from HTMLInputElement::defaultEventHandler()
before implicit submission checking.
(WebCore::InputType::handleKeypressEvent):
(WebCore::InputType::handleKeyupEvent):
* html/InputType.h:
* html/RadioInputType.cpp:
(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::handleKeyupEvent):
* html/RadioInputType.h:
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::shouldSubmitImplicitly):
* html/TextFieldInputType.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73008
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin.poulain@nokia.com [Wed, 1 Dec 2010 04:18:47 +0000 (04:18 +0000)]
2010-11-30 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50236
Add support for the new advanced findString().
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::findString):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-11-30 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Implement layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50236
Add the missing function to the LayoutTestController.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::findString):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73007
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 1 Dec 2010 03:59:53 +0000 (03:59 +0000)]
2010-11-30 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Fix wrong type in assert return value
https://bugs.webkit.org/show_bug.cgi?id=50208
Use appropriate return type in different g_return_val_if_fail(). This
removes some compiler warning.
* webkit/webkitwebdatasource.cpp:
(webkit_web_data_source_is_loading):
* webkit/webkitwebframe.cpp:
(webkit_web_frame_page_number_for_element_by_id):
(webkit_web_frame_number_of_pages):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73006
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 1 Dec 2010 03:38:33 +0000 (03:38 +0000)]
2010-11-30 Rob Buis <rwlbuis@gmail.com>
Reviewed by Xan Lopez.
[gtk] SVGLineElement-dom-requiredFeatures.html and
SVGLineElement-svgdom-requiredFeatures.html failing in the bots
https://bugs.webkit.org/show_bug.cgi?id=49529
Replaced fill with stroke and increased the line size. This fixes
the problem clicking the element.
* platform/gtk/Skipped:
* svg/dynamic-updates/script-tests/SVGLineElement-dom-requiredFeatures.js:
* svg/dynamic-updates/script-tests/SVGLineElement-svgdom-requiredFeatures.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73005
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 1 Dec 2010 03:19:32 +0000 (03:19 +0000)]
2010-11-30 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed speculative build fix for Windows.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::pageDidEnterAcceleratedCompositing):
(WebKit::WebView::pageDidLeaveAcceleratedCompositing):
(WebKit::WebView::switchToDrawingAreaTypeIfNecessary):
* UIProcess/win/WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73004
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 1 Dec 2010 03:19:14 +0000 (03:19 +0000)]
2010-11-30 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
Move CSS generator logic into main CMakeLists.txt file
https://bugs.webkit.org/show_bug.cgi?id=50230
* CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73003
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 1 Dec 2010 03:12:25 +0000 (03:12 +0000)]
2010-11-30 Ojan Vafai <ojan@chromium.org>
Revert r72876. It caused a ~30% perf regression in chromium's bloat-http test
https://bugs.webkit.org/show_bug.cgi?id=50288
2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
Reviewed by Darin Adler.
Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182
A display-isolated URL can only be displayed (e.g., put in an iframe,
hyperlinked to) by documents from that scheme. In a sense, this is a
generalization of some of the protections we give file URLs, but
instead of lumping them all together into one "local" bucket, this
patch creates a separate bucket for each scheme.
For a while, I tried using a separate bucket for each origin. That
would have played nicely with what Blob URLs are trying to do, but some
"chrome" URL pages rely on being able to display other chrome URL
pages, even in different origins. For example, the New Tab Page shows
thumbnails from the "thumbnail" host.
This patch also removes a bunch of unused code. I've also propagated
the "deprecated" status of deprecatedCanDisplay to
deprecatedShouldTreatURLAsLocal because that method has no other
callers and is really asking for uppercase/lowercase bugs. I dream of
someday removing these functions.
page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canDisplay):
(WebCore::SecurityOrigin::deprecatedCanDisplay):
platform/SchemeRegistry.cpp:
(WebCore::displayIsolatedURLSchemes):
(WebCore::SchemeRegistry::registerURLSchemeAsLocal):
(WebCore::SchemeRegistry::deprecatedShouldTreatURLAsLocal):
(WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
(WebCore::SchemeRegistry::registerURLSchemeAsDisplayIsolated):
(WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
platform/SchemeRegistry.h:
2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
Reviewed by Darin Adler.
Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182
This patch adds a Chromium API for registering schemes as
display-isolated. In a subsequent patch, I'll change the "chrome"
scheme in Chrome to be display isolated instead of local. That will
prevent file URLs from linking to chrome URLs.
public/WebSecurityPolicy.h:
src/WebSecurityPolicy.cpp:
(WebKit::WebSecurityPolicy::registerURLSchemeAsDisplayIsolated):
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canDisplay):
(WebCore::SecurityOrigin::deprecatedCanDisplay):
* platform/SchemeRegistry.cpp:
(WebCore::SchemeRegistry::registerURLSchemeAsLocal):
(WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal):
(WebCore::SchemeRegistry::localURLSchemes):
(WebCore::SchemeRegistry::shouldTreatURLAsLocal):
(WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
* platform/SchemeRegistry.h:
2010-11-30 Ojan Vafai <ojan@chromium.org>
Revert r72876. It caused a ~30% perf regression in chromium's bloat-http test
https://bugs.webkit.org/show_bug.cgi?id=50288
2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
Reviewed by Darin Adler.
Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182
A display-isolated URL can only be displayed (e.g., put in an iframe,
hyperlinked to) by documents from that scheme. In a sense, this is a
generalization of some of the protections we give file URLs, but
instead of lumping them all together into one "local" bucket, this
patch creates a separate bucket for each scheme.
For a while, I tried using a separate bucket for each origin. That
would have played nicely with what Blob URLs are trying to do, but some
"chrome" URL pages rely on being able to display other chrome URL
pages, even in different origins. For example, the New Tab Page shows
thumbnails from the "thumbnail" host.
This patch also removes a bunch of unused code. I've also propagated
the "deprecated" status of deprecatedCanDisplay to
deprecatedShouldTreatURLAsLocal because that method has no other
callers and is really asking for uppercase/lowercase bugs. I dream of
someday removing these functions.
2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
Reviewed by Darin Adler.
Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182
This patch adds a Chromium API for registering schemes as
display-isolated. In a subsequent patch, I'll change the "chrome"
scheme in Chrome to be display isolated instead of local. That will
prevent file URLs from linking to chrome URLs.
* public/WebSecurityPolicy.h:
* src/WebSecurityPolicy.cpp:
2010-11-30 Ojan Vafai <ojan@chromium.org>
Revert r72876. It caused a ~30% perf regression in chromium's bloat-http test
https://bugs.webkit.org/show_bug.cgi?id=50288
2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
Reviewed by Darin Adler.
Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182
A display-isolated URL can only be displayed (e.g., put in an iframe,
hyperlinked to) by documents from that scheme. In a sense, this is a
generalization of some of the protections we give file URLs, but
instead of lumping them all together into one "local" bucket, this
patch creates a separate bucket for each scheme.
For a while, I tried using a separate bucket for each origin. That
would have played nicely with what Blob URLs are trying to do, but some
"chrome" URL pages rely on being able to display other chrome URL
pages, even in different origins. For example, the New Tab Page shows
thumbnails from the "thumbnail" host.
This patch also removes a bunch of unused code. I've also propagated
the "deprecated" status of deprecatedCanDisplay to
deprecatedShouldTreatURLAsLocal because that method has no other
callers and is really asking for uppercase/lowercase bugs. I dream of
someday removing these functions.
2010-11-29 Adam Barth <abarth@webkit.org (:abarth) (r)>
Reviewed by Darin Adler.
Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182
This patch adds a Chromium API for registering schemes as
display-isolated. In a subsequent patch, I'll change the "chrome"
scheme in Chrome to be display isolated instead of local. That will
prevent file URLs from linking to chrome URLs.
* Api/qwebsecurityorigin.cpp:
(QWebSecurityOrigin::localSchemes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73002
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 1 Dec 2010 03:00:24 +0000 (03:00 +0000)]
2010-11-30 Ojan Vafai <ojan@chromium.org>
[chromium] Update inaccurate test expectation and mark fast/regex/pcre-test-1.html as
timing out after http://trac.webkit.org/changeset/72990/.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73001
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Wed, 1 Dec 2010 02:51:51 +0000 (02:51 +0000)]
WebKit duplicates AXValue and AXDescription on abbr
https://bugs.webkit.org/show_bug.cgi?id=50260
Reviewed by Beth Dakin.
WebCore:
stringValue() and accessibilityDescription() were returning the same value for static text with
an aria-label. Static text elements should not have an accessibility description, they
should only have a stringValue.
Test: platform/mac/accessibility/static-text-with-aria-label.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaAccessibilityDescription):
(WebCore::AccessibilityRenderObject::accessibilityDescription):
(WebCore::AccessibilityRenderObject::text):
* accessibility/AccessibilityRenderObject.h:
LayoutTests:
* platform/mac/accessibility/static-text-with-aria-label-expected.txt: Added.
* platform/mac/accessibility/static-text-with-aria-label.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73000
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 1 Dec 2010 02:46:28 +0000 (02:46 +0000)]
JavaScriptCore: Fixed review comments following bug #48101.
Mostly typos, plus gave quantifyInfinite a symbolic name.
Reviewed by Darin Adler.
* yarr/RegexCompiler.cpp:
(JSC::Yarr::RegexPatternConstructor::quantifyAtom):
(JSC::Yarr::RegexPatternConstructor::checkForTerminalParentheses):
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):
(JSC::Yarr::Interpreter::matchParenthesesTerminalBegin):
(JSC::Yarr::Interpreter::backtrackParenthesesTerminalBegin):
(JSC::Yarr::Interpreter::backtrackParenthesesTerminalEnd):
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::RegexGenerator::generatePatternCharacterNonGreedy):
(JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):
* yarr/RegexParser.h:
(JSC::Yarr::Parser::parseTokens):
(JSC::Yarr::parse):
LayoutTests: Ooops, file checked in with incorrect properties.
Reviewed by Darin Adler.
* fast/regex/script-tests/repeat-match-waldemar.js: Removed property svn:executable.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72999
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 1 Dec 2010 02:20:09 +0000 (02:20 +0000)]
Fix Qt build.
* UIProcess/API/qt/qgraphicswkview.cpp:
(QGraphicsWKView::takeSnapshot):
(QGraphicsWKViewPrivate::commitScale):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72998
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 1 Dec 2010 02:19:41 +0000 (02:19 +0000)]
2010-11-30 Martin Robinson <mrobinson@igalia.com>
Rebaseline a GTK+ test.
* platform/gtk/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
This platform-specific result is needed because of bug #50303.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72997
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 1 Dec 2010 02:11:50 +0000 (02:11 +0000)]
Change DrawingArea and DrawingAreaProxy to not inherit from DrawingAreaBase
https://bugs.webkit.org/show_bug.cgi?id=50300
Reviewed by Sam Weinig.
* UIProcess/API/mac/WKView.mm:
(-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaBase::]):
(-[WKView _pageDidEnterAcceleratedCompositing]):
(-[WKView _pageDidLeaveAcceleratedCompositing]):
* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):
* UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::nextDrawingAreaID):
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::info):
* UIProcess/LayerBackedDrawingAreaProxy.cpp:
(WebKit::LayerBackedDrawingAreaProxy::LayerBackedDrawingAreaProxy):
* WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
(WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea):
(WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
* WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
(WebKit::DrawingArea::DrawingArea):
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::info):
* WebProcess/WebPage/LayerBackedDrawingArea.cpp:
(WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea):
(WebKit::LayerBackedDrawingArea::didReceiveMessage):
* WebProcess/WebPage/LayerBackedDrawingArea.h:
* WebProcess/WebPage/TiledDrawingArea.cpp:
(WebKit::TiledDrawingArea::TiledDrawingArea):
* WebProcess/WebPage/TiledDrawingArea.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::changeAcceleratedCompositingMode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72996
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 1 Dec 2010 02:09:33 +0000 (02:09 +0000)]
2010-11-30 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
[HTML5] Rename member variables of HTMLScriptElement
https://bugs.webkit.org/show_bug.cgi?id=49705
Renamed m_wasCreatedByParser to m_wasInsertedByParser, m_requested to m_isExternalScript,
m_isEvaluated to m_wasAlreadyStarted, and m_firedLoad to m_haveFiredLoad.
Also made ScriptElement's haveFiredLoadEvent and removed HTMLScriptElement's haveFiredLoadEvent.
This effectively adds the same function to SVGScriptElement, which isn't currently used anywhere.
No new tests are added since this is a refactoring.
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::insertedIntoDocument):
(WebCore::ScriptElement::childrenChanged):
(WebCore::ScriptElement::finishParsingChildren):
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::evaluateScript):
(WebCore::ScriptElement::executeScript):
(WebCore::ScriptElement::ignoresLoadRequest):
* dom/ScriptElement.h:
(WebCore::ScriptElement::haveFiredLoadEvent):
(WebCore::ScriptElement::setHaveFiredLoadEvent):
(WebCore::ScriptElement::wasInsertedByParser):
(WebCore::ScriptElement::wasAlreadyStarted):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::HTMLScriptElement):
(WebCore::HTMLScriptElement::create):
(WebCore::HTMLScriptElement::cloneElementWithoutAttributesAndChildren):
* html/HTMLScriptElement.h:
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::SVGScriptElement):
(WebCore::SVGScriptElement::create):
(WebCore::SVGScriptElement::svgAttributeChanged):
(WebCore::SVGScriptElement::insertedIntoDocument):
(WebCore::SVGScriptElement::dispatchLoadEvent):
(WebCore::SVGScriptElement::cloneElementWithoutAttributesAndChildren):
* svg/SVGScriptElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72995
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 1 Dec 2010 02:00:21 +0000 (02:00 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72994
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 1 Dec 2010 01:53:21 +0000 (01:53 +0000)]
Rolled back most of the FileReaderLoader changes to fix 32-bit builds.
* fileapi/FileReaderLoader.cpp: Changed types back to unsigned from unsigned long long
* fileapi/FileReaderLoader.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72991
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 1 Dec 2010 01:52:26 +0000 (01:52 +0000)]
LayoutTests/fast/regex currently contains a number of test cases ported from PCRE's test suites.
There are two key problems with these tests:
* They use their own harness, and cannot be run from jsc without building all of WebKit.
* They expect PCRE expression syntax, including extended syntax, backwards assertions, etc.
Rubber stamped by Oliver Hunt.
Rewrite all tests to comply to ECMA compatible syntax
(ish - we support octal escapes), and use the normal 'shouldBe' test style.
* fast/js/resources/standalone-pre.js:
(areArraysEqual):
Fixed bug, where expected is an array we call areArraysEqual,
this should first check that actual is an array.
* fast/regex/pcre-test-1-expected.txt: Added.
* fast/regex/pcre-test-1.html: Added.
* fast/regex/pcre-test-4-expected.txt: Added.
* fast/regex/pcre-test-4.html: Added.
* fast/regex/script-tests/pcre-test-1.js: Added.
* fast/regex/script-tests/pcre-test-4.js: Added.
Added new version of PCRE tests.
* fast/regex/pcre-test-runner.js: Removed.
* fast/regex/test1-expected.txt: Removed.
* fast/regex/test1.html: Removed.
* fast/regex/test4-expected.txt: Removed.
* fast/regex/test4.html: Removed.
* fast/regex/testinput1: Removed.
* fast/regex/testinput4: Removed.
* fast/regex/testoutput1: Removed.
* fast/regex/testoutput4: Removed.
Removed old version of PCRE tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72990
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 1 Dec 2010 01:48:07 +0000 (01:48 +0000)]
Text search should treat all matches as word-start matches when the target begins with a separator character
https://bugs.webkit.org/show_bug.cgi?id=50302
Reviewed by Darin Adler.
WebCore:
* editing/TextIterator.cpp:
(WebCore::SearchBuffer::SearchBuffer): Disable the AtWordStarts option if it was specified and
the target string begins with one of the "separator" characters.
LayoutTests:
* editing/text-iterator/findString.html:
* editing/text-iterator/findString-expected.txt:
* platform/mac-leopard/editing/text-iterator: Removed.
* platform/mac-leopard/editing/text-iterator/findString-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72989
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 1 Dec 2010 01:42:33 +0000 (01:42 +0000)]
2010-11-30 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Dave Hyatt.
Web Inspector: [CRASH] on "Revert to this revision" of style with import.
https://bugs.webkit.org/show_bug.cgi?id=50256
Rolled back one line from http://trac.webkit.org/changeset/36904 as agreed with
David.
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::insertedIntoParent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72988
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 1 Dec 2010 01:36:11 +0000 (01:36 +0000)]
2010-11-30 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] fillRect shadow has incorrect behavior when using ctx.scale(x,y)
https://bugs.webkit.org/show_bug.cgi?id=50283
Add platform exceptions for these tests. While this change fixes most issues
with them there are still bugs with our shadow code which prevents a total
pass.
* platform/gtk/fast/canvas/canvas-scale-fillPath-shadow-expected.txt: Added.
* platform/gtk/fast/canvas/canvas-scale-fillRect-shadow-expected.txt: Added.
2010-11-30 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] fillRect shadow has incorrect behavior when using ctx.scale(x,y)
https://bugs.webkit.org/show_bug.cgi?id=50283
Adjust the mask rectangle for Cairo shadows, so that the origin
is not affected by the scale of the transformation matrix.
* platform/graphics/ContextShadow.h: Make this Qt-only member global.
* platform/graphics/cairo/ContextShadowCairo.cpp:
(WebCore::ContextShadow::beginShadowLayer): Save the original layer area.
(WebCore::ContextShadow::endShadowLayer): If the target context has a scale
transform, make sure not to scale the blur distance when blitting the shadow.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72987
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 1 Dec 2010 01:27:45 +0000 (01:27 +0000)]
2010-11-30 Darin Adler <darin@apple.com>
Reviewed by Alexey Proskuryakov.
Make ProgressEvent 64-bit instead of 32-bit
https://bugs.webkit.org/show_bug.cgi?id=50289
* dom/ProgressEvent.cpp:
(WebCore::ProgressEvent::ProgressEvent): Changed arguments to unsigned long long.
(WebCore::ProgressEvent::initProgressEvent): Ditto.
* dom/ProgressEvent.h: Fixed formatting. Changed types to unsigned long long.
Made isProgressEvent override private.
* dom/ProgressEvent.idl: Tweaked formatting and changed types to unsigned long long.
* fileapi/FileReader.cpp: Removed unneeded includes.
Used static on const so we'd get an error if the same constant was in a header.
(WebCore::FileReader::didReceiveData): Removed unneeded WTF prefix.
(WebCore::FileReader::fireEvent): Got rid of local variables that would narrow
bytes loaded and total bytes to 32-bit.
* fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::didReceiveResponse): Restructured code a bit and
added comments. Also added handling for when ArrayBuffer::create returns 0.
(WebCore::FileReaderLoader::didReceiveData): Fixed handling of case where more
data arrives than is expected so it won't overrun the buffer. Also broke an
assertion into two and improved a comment.
* fileapi/FileReaderLoader.h: Changed bytesLoaded and totalBytes to unsigned long long.
* fileapi/FileWriter.cpp:
(WebCore::FileWriter::fireEvent): Removed narrowing casts in call to
ProgressEvent::create.
* html/canvas/ArrayBuffer.cpp:
(WebCore::ArrayBuffer::tryAllocate): Added a comment because the code here seems wrong.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::didSendData): Removed narrowing casts in call to
XMLHttpRequestProgressEvent::create.
(WebCore::XMLHttpRequest::didReceiveData): Removed narrowing casts in call to
dispatchProgressEvent.
* xml/XMLHttpRequestProgressEvent.h: Fixed formatting. Changed types to unsigned long long.
Made isXMLHttpRequestProgressEvent override private.
* xml/XMLHttpRequestProgressEvent.idl: Tweaked formatting and changed types to unsigned long long.
* xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): Changed types to
unsigned long long.
* xml/XMLHttpRequestProgressEventThrottle.h: Changed types to unsigned long long.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72985
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Wed, 1 Dec 2010 01:11:45 +0000 (01:11 +0000)]
2010-11-30 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
WTF project missing build-stopping code from its pre-build event
https://bugs.webkit.org/show_bug.cgi?id=50281
* JavaScriptCore.vcproj/WTF/WTFPreBuild.cmd:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72983
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 1 Dec 2010 00:59:03 +0000 (00:59 +0000)]
2010-11-30 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
Context menus broken after WebKit2 goes into accelerated composting mode.
https://bugs.webkit.org/show_bug.cgi?id=50296
Override hitTest: on the WKView to exclude the child layer-backed view from
hit testing, so that context menus work.
* UIProcess/API/mac/WKView.mm:
(-[WKView hitTest:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72982
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 1 Dec 2010 00:56:49 +0000 (00:56 +0000)]
Build fix.
Reviewed by Sam Weinig.
* Configurations/BaseTarget.xcconfig: Don't run Copy Files and Run Script build phases
during installhdrs. It's not necessary, and it results in Xcode attempting to copy the
plug-in shim dylib when it has not yet been built.
* WebKit2.xcodeproj/project.pbxproj: Stop copying the .xcconfig file in to the application
wrapper.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72981
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 1 Dec 2010 00:53:31 +0000 (00:53 +0000)]
Fix build.
* Scripts/webkit2/messages.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72980
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Wed, 1 Dec 2010 00:40:17 +0000 (00:40 +0000)]
2010-11-30 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Cleanup UTF8.cpp
https://bugs.webkit.org/show_bug.cgi?id=49581
Use macros and functions instead of range values directly.
* wtf/unicode/UTF8.cpp:
(WTF::Unicode::inlineUTF8SequenceLength):
(WTF::Unicode::UTF8SequenceLength):
(WTF::Unicode::convertUTF16ToUTF8):
(WTF::Unicode::readUTF8Sequence):
(WTF::Unicode::convertUTF8ToUTF16):
* wtf/unicode/UnicodeMacrosFromICU.h: Added U_IS_SUPPLEMENTARY macro.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72979
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 1 Dec 2010 00:37:28 +0000 (00:37 +0000)]
Rename DrawingAreaBase.h to DrawingAreaInfo.h.
Reviewed by Sam Weinig.
* Shared/DrawingAreaInfo.h: Renamed from WebKit2/Shared/DrawingAreaBase.h.
(WebKit::DrawingAreaBase::DrawingAreaInfo::DrawingAreaInfo):
(WebKit::DrawingAreaBase::~DrawingAreaBase):
(WebKit::DrawingAreaBase::info):
(WebKit::DrawingAreaBase::DrawingAreaBase):
* Shared/WebPageCreationParameters.h:
* UIProcess/DrawingAreaProxy.h:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/DrawingArea.h:
* win/WebKit2.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72978
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 1 Dec 2010 00:32:06 +0000 (00:32 +0000)]
2010-11-30 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
REGRESSION(r72861): editing/selection/click-left-of-rtl-wrapping-text.html and
modify-up-on-rtl-wrapping-text.html fail on all but Mac platform
https://bugs.webkit.org/show_bug.cgi?id=50204
Fixed the tests. Instead of using "ex" to specify the width of the container div,
the tests now auto-detect the correct width by comparing the computed height to
the expected height deduced from the height of one line and the expected number of lines.
* editing/selection/click-left-of-rtl-wrapping-text-expected.txt:
* editing/selection/click-left-of-rtl-wrapping-text.html:
* editing/selection/modify-up-on-rtl-wrapping-text.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72977
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Wed, 1 Dec 2010 00:13:33 +0000 (00:13 +0000)]
Progress and meter elements should take a form in their constructor like any other form control.
https://bugs.webkit.org/show_bug.cgi?id=50195
Reviewed by Darin Adler.
WebCore:
Tests: fast/dom/HTMLMeterElement/meter-element-form.html
fast/dom/HTMLProgressElement/progress-element-form.html
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::HTMLMeterElement):
(WebCore::HTMLMeterElement::create):
* html/HTMLMeterElement.h:
* html/HTMLProgressElement.h:
* html/HTMLTagNames.in:
LayoutTests:
* fast/dom/HTMLMeterElement/meter-element-form-expected.txt: Added.
* fast/dom/HTMLMeterElement/meter-element-form.html: Added.
* fast/dom/HTMLProgressElement/progress-element-form-expected.txt: Added.
* fast/dom/HTMLProgressElement/progress-element-form.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 1 Dec 2010 00:01:42 +0000 (00:01 +0000)]
2010-11-30 Tony Chang <tony@chromium.org>
Unreviewed, remove dupe expectation for chromium win drt.
* platform/chromium/drt_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72975
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 30 Nov 2010 23:55:46 +0000 (23:55 +0000)]
2010-11-30 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
[chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
https://bugs.webkit.org/show_bug.cgi?id=49036
No new tests: Covered by plugins/npruntime/get-int-identifier-special-values.html
In http://codereview.chromium.org/11574, the forked chromium test
plugin changed how it testGetIntIdentifier to work around a change
caused by a silverlight specific plugin fix:
http://codereview.chromium.org/11569/diff/1/2
It's not clear to me that this change is needed anymore since
silverlight has had multiple releases, testing without this patch
works on a test windows build, and safari win seems to run silverlight
without this either. Since there's no test for this behavior, I'm
rolling it out so we can match the upstream test.
* bindings/v8/V8NPUtils.cpp:
(WebCore::convertV8ObjectToNPVariant):
2010-11-30 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
[chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
https://bugs.webkit.org/show_bug.cgi?id=49036
* DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
for CppVariants.
(LayoutTestController::cppVariantToBool):
(LayoutTestController::cppVariantToInt32):
(LayoutTestController::setDatabaseQuota):
(LayoutTestController::evaluateInWebInspector):
(LayoutTestController::setMockGeolocationError):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72974
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 30 Nov 2010 23:48:07 +0000 (23:48 +0000)]
Fix build.
* PluginProcess/mac/PluginProcessShim.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72973
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 30 Nov 2010 23:44:16 +0000 (23:44 +0000)]
Add a simple shim function for Debugger().
https://bugs.webkit.org/show_bug.cgi?id=50268
Reviewed by Dan Bernstein.
* PluginProcess/PluginProcess.h:
* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::initShouldCallRealDebugger):
We only want to call the real Debugger() function when USERBREAK is set.
(WebKit::shouldCallRealDebugger):
Return whether USERBREAK is set.
(WebKit::PluginProcess::initializeShim):
Initialize the shim.
* PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
Call PluginProcess::initializeShim.
* PluginProcess/mac/PluginProcessShim.cpp:
(WebKit::WebKitPluginProcessShimInitialize):
This now takes a struct of callbacks.
(WebKit::shimDebugger):
Call the shouldCallDebugger function. If it returns true, the real Debugger() function should be called.
* PluginProcess/mac/PluginProcessShim.h:
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72972
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 30 Nov 2010 23:31:52 +0000 (23:31 +0000)]
2010-11-30 Tony Chang <tony@chromium.org>
Unreviewed, try to green the chromium win DRT bot.
* platform/chromium/drt_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72971
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 30 Nov 2010 23:27:36 +0000 (23:27 +0000)]
2010-11-30 Ojan Vafai <ojan@chromium.org>
[chromium] Mark failing tests after http://trac.webkit.org/changeset/72962/
to green the chromium tree.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72970
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Tue, 30 Nov 2010 23:21:15 +0000 (23:21 +0000)]
2010-11-30 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Computing style on a stale node while sending pending accessibility notification.
https://bugs.webkit.org/show_bug.cgi?id=50162
Retain node pointer members of AccessibilityImageMapLink.
Test: accessibility/image-map-title-causes-crash.html
* accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::parentObject):
(WebCore::AccessibilityImageMapLink::anchorElement):
(WebCore::AccessibilityImageMapLink::url):
(WebCore::AccessibilityImageMapLink::elementRect):
* accessibility/AccessibilityImageMapLink.h:
(WebCore::AccessibilityImageMapLink::areaElement):
(WebCore::AccessibilityImageMapLink::mapElement):
(WebCore::AccessibilityImageMapLink::node):
* dom/Document.cpp:
(WebCore::Document::clearAXObjectCache):
2010-11-30 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Computing style on a stale node while sending pending accessibility notification.
https://bugs.webkit.org/show_bug.cgi?id=50162
* accessibility/image-map-title-causes-crash-expected.txt: Added.
* accessibility/image-map-title-causes-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72969
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Tue, 30 Nov 2010 23:17:48 +0000 (23:17 +0000)]
2010-11-30 James Robinson <jamesr@chromium.org>
Reviewed by Tony Chang.
Build fix - add parens in foo || bar && baz to make gcc happy
https://bugs.webkit.org/show_bug.cgi?id=50276
gcc 4.4 warns that statements of the form "foo || bar && baz". It wants
parens around the "bar && baz" part to make it clear which way the logical
operators bind.
* editing/TextIterator.cpp:
(WebCore::SearchBuffer::search):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72968
268f45cc-cd09-0410-ab3c-
d52691b4dbfc