WebKit-https.git
8 years agoUnreviewed, rolling out r143100.
commit-queue@webkit.org [Mon, 18 Feb 2013 09:30:22 +0000 (09:30 +0000)]
Unreviewed, rolling out r143100.
http://trac.webkit.org/changeset/143100
https://bugs.webkit.org/show_bug.cgi?id=110088

Breaks file system support in workspace. (Requested by vsevik
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-18

Source/WebCore:

* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
* inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleProjectDelegate):
(WebInspector.SimpleProjectDelegate.prototype.id):
(WebInspector.SimpleProjectDelegate.prototype.displayName):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFile):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.uri):
* inspector/front-end/Workspace.js:
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.uiSourceCodeForURI):
(WebInspector.Workspace.prototype.projectForUISourceCode):

LayoutTests:

* inspector/debugger/live-edit-breakpoints-expected.txt:
* inspector/debugger/live-edit-breakpoints.html:
* inspector/uisourcecode-revisions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening.
zandobersek@gmail.com [Mon, 18 Feb 2013 09:27:42 +0000 (09:27 +0000)]
Unreviewed gardening.

Adding failure expectations for two tests that are failing on GTK and Qt,
most likely due to disabled subpixel layout.

* platform/gtk/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix indentation of StructureStubInfo.h
fpizlo@apple.com [Mon, 18 Feb 2013 09:26:38 +0000 (09:26 +0000)]
Fix indentation of StructureStubInfo.h

Rubber stamped by Mark Hahnenberg.

* bytecode/StructureStubInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix indentation of JSGlobalObject.h and JSGlobalObjectFunctions.h
fpizlo@apple.com [Mon, 18 Feb 2013 09:25:33 +0000 (09:25 +0000)]
Fix indentation of JSGlobalObject.h and JSGlobalObjectFunctions.h

Rubber stamped by Mark Hahnenberg.

* runtime/JSGlobalObject.h:
* runtime/JSGlobalObjectFunctions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix indention of Operations.h
fpizlo@apple.com [Mon, 18 Feb 2013 09:20:28 +0000 (09:20 +0000)]
Fix indention of Operations.h

Rubber stamped by Mark Hahnenberg.

* runtime/Operations.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Clean up a few EFL unexpected passes.
ch.dumez@sisa.samsung.com [Mon, 18 Feb 2013 09:16:51 +0000 (09:16 +0000)]
Unreviewed. Clean up a few EFL unexpected passes.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Removed.
* platform/efl/ietestcenter/css3/text/textshadow-005-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove DFG::SpeculativeJIT::isKnownNumeric(), since it's not called from anywhere.
fpizlo@apple.com [Mon, 18 Feb 2013 09:16:01 +0000 (09:16 +0000)]
Remove DFG::SpeculativeJIT::isKnownNumeric(), since it's not called from anywhere.

Rubber stamped by Andy Estes.

* dfg/DFGSpeculativeJIT.cpp:
(DFG):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove DFG::SpeculativeJIT::isStrictInt32(), since it's not called from anywhere.
fpizlo@apple.com [Mon, 18 Feb 2013 09:11:43 +0000 (09:11 +0000)]
Remove DFG::SpeculativeJIT::isStrictInt32(), since it's not called from anywhere.

Rubber stampted by Andy Estes.

* dfg/DFGSpeculativeJIT.cpp:
(DFG):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove dead code for ValueToNumber from the DFG.
fpizlo@apple.com [Mon, 18 Feb 2013 08:59:05 +0000 (08:59 +0000)]
Remove dead code for ValueToNumber from the DFG.

Rubber stamped by Andy Estes.

We killed ValueToNumber at some point, but forgot to kill all of the backend support
for it.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleMinMax):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
* dfg/DFGSpeculativeJIT64.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Clean up a few EFL unexpected passes.
ch.dumez@sisa.samsung.com [Mon, 18 Feb 2013 08:59:02 +0000 (08:59 +0000)]
Unreviewed. Clean up a few EFL unexpected passes.

* platform/efl/TestExpectations:
* platform/efl/fast/repaint/block-selection-gap-in-table-cell-expected.png: Removed.
* platform/efl/fast/repaint/block-selection-gap-in-table-cell-expected.txt: Removed.
* platform/efl/fast/repaint/caret-with-transformation-expected.png: Removed.
* platform/efl/fast/repaint/caret-with-transformation-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Remove invalid EFL results that were wrongly added in r140249.
ch.dumez@sisa.samsung.com [Mon, 18 Feb 2013 08:46:52 +0000 (08:46 +0000)]
Unreviewed. Remove invalid EFL results that were wrongly added in r140249.

* platform/efl/TestExpectations:
* platform/efl/fast/css/color-correction-on-background-image-expected.png: Removed.
* platform/efl/fast/css/color-correction-on-background-image-expected.txt: Removed.
* platform/efl/fast/css/color-correction-on-backgrounds-expected.png: Removed.
* platform/efl/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
* platform/efl/fast/css/color-correction-on-box-shadow-expected.png: Removed.
* platform/efl/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
* platform/efl/fast/css/color-correction-on-text-expected.png: Removed.
* platform/efl/fast/css/color-correction-on-text-expected.txt: Removed.
* platform/efl/fast/css/color-correction-on-text-shadow-expected.png: Removed.
* platform/efl/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
* platform/efl/fast/css/color-correction-untagged-images-expected.png: Removed.
* platform/efl/fast/css/color-correction-untagged-images-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWKR build fix. Always use ascii since irclib/ircbot doesn't support unicode.
rniwa@webkit.org [Mon, 18 Feb 2013 08:38:22 +0000 (08:38 +0000)]
WKR build fix. Always use ascii since irclib/ircbot doesn't support unicode.

* Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot.next_work_item):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Unskip several test cases that are now passing on
ch.dumez@sisa.samsung.com [Mon, 18 Feb 2013 08:37:19 +0000 (08:37 +0000)]
Unreviewed. Unskip several test cases that are now passing on
EFL port, most of them due to enabling subpixel layout.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Unskip several compositing tests that are now
ch.dumez@sisa.samsung.com [Mon, 18 Feb 2013 08:22:53 +0000 (08:22 +0000)]
Unreviewed. Unskip several compositing tests that are now
passing on WK2 EFL.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Introduce ProfilesPanelDescriptor.
eustas@chromium.org [Mon, 18 Feb 2013 07:51:52 +0000 (07:51 +0000)]
Web Inspector: Introduce ProfilesPanelDescriptor.
https://bugs.webkit.org/show_bug.cgi?id=109906

Reviewed by Pavel Feldman.

Source/WebCore:

Some constants/methods should be accesible before ProfilesPanel
is instantiated.

Extracted methods to check if profile is "user-initiated" and what is
its index.

Also profile URL regexp moved to ProfilesPanelDescriptor.

* inspector/front-end/ProfilesPanelDescriptor.js: Added.
* WebCore.gypi: Added ProfilesPanelDescriptor.js
* WebCore.vcproj/WebCore.vcproj: Ditto.
* inspector/compile-front-end.py: Ditto.
* inspector/front-end/WebKit.qrc: Ditto.
* inspector/front-end/inspector.html: Ditto.
* inspector/front-end/HeapSnapshotView.js: Adopted changes.
* inspector/front-end/ProfilesPanel.js: Ditto.
* inspector/front-end/externs.js: Ditto.
* inspector/front-end/inspector.js: Ditto.

LayoutTests:

* inspector/profiler/heap-snapshot-test.js: Adopted changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Add myself as a committer.
kangil.han@samsung.com [Mon, 18 Feb 2013 07:47:23 +0000 (07:47 +0000)]
Unreviewed. Add myself as a committer.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, update test expectation for chromium.
toyoshim@chromium.org [Mon, 18 Feb 2013 07:46:03 +0000 (07:46 +0000)]
Unreviewed, update test expectation for chromium.
https://bugs.webkit.org/show_bug.cgi?id=110079

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGCE EWS bots are all offline
commit-queue@webkit.org [Mon, 18 Feb 2013 07:44:26 +0000 (07:44 +0000)]
GCE EWS bots are all offline
https://bugs.webkit.org/show_bug.cgi?id=110069

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-17
Reviewed by Eric Seidel.

Updated GCE EWS build scripts to use the gcel-10-04-v20130104 image instead of the obsoleted ubuntu-10-04-v20120621.
This changed the ephemeral disk path to /dev/sdb and required /etc/hosts to be chmodded to 644.

* EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
* EWSTools/GoogleComputeEngine/build-commit-queue.sh:
* EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
* EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
* EWSTools/build-vm.sh:
* EWSTools/start-queue.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd missing braces in fast/parser/noscript-with-javascript-enabled.html
vivek.vg@samsung.com [Mon, 18 Feb 2013 07:35:26 +0000 (07:35 +0000)]
Add missing braces in fast/parser/noscript-with-javascript-enabled.html
https://bugs.webkit.org/show_bug.cgi?id=110078

Unreviewed gardening. Adding the missing braces.

* fast/parser/noscript-with-javascript-enabled.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed buildfix for JSVALUE32_64 builds after r143147.
ossy@webkit.org [Mon, 18 Feb 2013 07:18:56 +0000 (07:18 +0000)]
Unreviewed buildfix for JSVALUE32_64 builds after r143147.

* jit/JIT.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, add myself to commiters.py.
eustas@chromium.org [Mon, 18 Feb 2013 06:50:19 +0000 (06:50 +0000)]
Unreviewed, add myself to commiters.py.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStop passing around SelectorChecker in SelectorQuery, now that it's stack-allocated.
dglazkov@chromium.org [Mon, 18 Feb 2013 06:44:13 +0000 (06:44 +0000)]
Stop passing around SelectorChecker in SelectorQuery, now that it's stack-allocated.
https://bugs.webkit.org/show_bug.cgi?id=110038

Reviewed by Andreas Kling.

No functional changes, covered by existing tests.

* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::matches): Moved instantiation of SelectorChecker in here.
(WebCore::SelectorDataList::queryAll): Got rid of unneeded SelectorChecker arg.
(WebCore::SelectorDataList::queryFirst): Ditto.
(WebCore::SelectorDataList::execute): Moved instantiation of SelectorChecker in here.
(WebCore::SelectorQuery::matches): Removed instantiation of SelectorChecker here.
(WebCore::SelectorQuery::queryAll): Ditto.
(WebCore::SelectorQuery::queryFirst): Ditto.
* dom/SelectorQuery.h:
(WebCore): Tweaked headers to make SelectorChecker just an implementation detail.
(SelectorDataList): Tweaked decls to remove SelectorChecker args.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, update test expectation for chromium.
toyoshim@chromium.org [Mon, 18 Feb 2013 06:38:12 +0000 (06:38 +0000)]
Unreviewed, update test expectation for chromium.
https://bugs.webkit.org/show_bug.cgi?id=110076

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStop passing around SelectorChecker in ContentSelectorQuery.
dglazkov@chromium.org [Mon, 18 Feb 2013 06:37:10 +0000 (06:37 +0000)]
Stop passing around SelectorChecker in ContentSelectorQuery.
https://bugs.webkit.org/show_bug.cgi?id=110041

Now that SelectorChecker has no interesting state, we can simplify ContentSelectorQuery and get rid of a class.

Reviewed by Andreas Kling.

No functional changes, covered by existing tests.

* html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorDataList::checkContentSelector): Zapped ContentSelectorChecker and moved its only remaining method here.
(WebCore::ContentSelectorDataList::matches): Removed SelectorChecker argument.
(WebCore::ContentSelectorQuery::ContentSelectorQuery): Removed an unnecessary member.
(WebCore::ContentSelectorQuery::matches): Removed unnecessary argument.
* html/shadow/ContentSelectorQuery.h:
(WebCore): Cleaned up the file.
(ContentSelectorDataList): Updated decls.
(ContentSelectorQuery): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Add myself as a committer.
dw.im@samsung.com [Mon, 18 Feb 2013 06:33:45 +0000 (06:33 +0000)]
Unreviewed. Add myself as a committer.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWheelEvent should not target text nodes.
mkwst@chromium.org [Mon, 18 Feb 2013 06:31:19 +0000 (06:31 +0000)]
WheelEvent should not target text nodes.
https://bugs.webkit.org/show_bug.cgi?id=109939

Reviewed by Darin Adler.

Source/WebCore:

WheelEvent, like other mouse events, should not target text nodes.
EventHandler correctly handles other mouse events by retargeting
events to text nodes' parents; this patch adds that logic to the
WheelEvent handler.

This should allow jQuery to stop working around WebKit's behavior[1].

[1]: https://github.com/jquery/jquery/commit/c61150427fc8ccc8e884df8f221a6c9bb5477929

Test: fast/events/wheelevent-in-text-node.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):
    If a WheelEvent's hit test lands on a text node, retarget the
    event to the text node's parent. Do this before latching the node.

LayoutTests:

* fast/events/wheelevent-in-text-node-expected.txt: Added.
* fast/events/wheelevent-in-text-node.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove all Structure out-of-line inline methods to StructureInlines.h
fpizlo@apple.com [Mon, 18 Feb 2013 06:28:54 +0000 (06:28 +0000)]
Move all Structure out-of-line inline methods to StructureInlines.h
https://bugs.webkit.org/show_bug.cgi?id=110024

Source/JavaScriptCore:

Rubber stamped by Mark Hahnenberg and Sam Weinig.

This was supposed to be easy.

But, initially, there was a Structure inline method in CodeBlock.h, and moving that
into StructureInlines.h meant that Operations.h included CodeBlock.h. This would
cause WebCore build failures, because CodeBlock.h transitively included the JSC
parser (via many, many paths), and the JSC parser defines tokens using enumeration
elements that CSSGrammar.cpp (generated by bison) would #define. For example,
bison would give CSSGrammar.cpp a #define FUNCTION 123, and would do so before
including anything interesting. The JSC parser would have an enum that included
FUNCTION as an element. Hence the JSC parser included into CSSGrammar.cpp would have
a token element called FUNCTION declared in an enumeration, but FUNCTION was
#define'd to 123, leading to a parser error.

Wow.

So I removed all transitive include paths from CodeBlock.h to the JSC Parser. I
believe I was able to do so without out-of-lining anything interesting or performance
critical. This is probably a purely good thing to have done: it will be nice to be
able to make changes to the parser without having to compile the universe.

Of course, doing this caused a bunch of other things to not compile, since a bunch of
headers relied on things being implicitly included for them when they transitively
included the parser. I fixed a lot of that.

Finally, I ended up removing the method that depended on CodeBlock.h from
StructureInlines.h, and putting it in Structure.cpp. That might seem like all of this
was a waste of time, except that I suspect it was a worthwhile forcing function for
cleaning up a bunch of cruft.

* API/JSCallbackFunction.cpp:
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/CodeBlock.h:
(JSC):
* bytecode/EvalCodeCache.h:
* bytecode/SamplingTool.h:
* bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::parameterCount):
(JSC):
* bytecode/UnlinkedCodeBlock.h:
(UnlinkedFunctionExecutable):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/Label.h:
(JSC):
* dfg/DFGByteCodeParser.cpp:
* dfg/DFGByteCodeParser.h:
* dfg/DFGFPRInfo.h:
* dfg/DFGRegisterBank.h:
* heap/HandleStack.cpp:
* jit/JITWriteBarrier.h:
* parser/Nodes.h:
(JSC):
* parser/Parser.h:
* parser/ParserError.h: Added.
(JSC):
(JSC::ParserError::ParserError):
(ParserError):
(JSC::ParserError::toErrorObject):
* parser/ParserModes.h:
* parser/SourceProvider.cpp: Added.
(JSC):
(JSC::SourceProvider::SourceProvider):
(JSC::SourceProvider::~SourceProvider):
* parser/SourceProvider.h:
(JSC):
(SourceProvider):
* runtime/ArrayPrototype.cpp:
* runtime/DatePrototype.cpp:
* runtime/Executable.h:
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h:
(JSC):
* runtime/Operations.h:
* runtime/Structure.cpp:
(JSC::Structure::prototypeForLookup):
(JSC):
* runtime/Structure.h:
(JSC):
* runtime/StructureInlines.h: Added.
(JSC):
(JSC::Structure::create):
(JSC::Structure::createStructure):
(JSC::Structure::get):
(JSC::Structure::masqueradesAsUndefined):
(JSC::SlotVisitor::internalAppend):
(JSC::Structure::transitivelyTransitionedFrom):
(JSC::Structure::setEnumerationCache):
(JSC::Structure::enumerationCache):
(JSC::Structure::prototypeForLookup):
(JSC::Structure::prototypeChain):
(JSC::Structure::isValid):
* runtime/StructureRareData.cpp:

Source/WebCore:

Rubber stamped by Sam Weinig.

No new tests because no new behavior. Just rewiring includes.

* ForwardingHeaders/parser/SourceProviderCache.h: Added.
* loader/cache/CachedScript.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unnecessary public method DrawingAreaImpl::createGraphicsContext()
commit-queue@webkit.org [Mon, 18 Feb 2013 05:53:12 +0000 (05:53 +0000)]
Remove unnecessary public method DrawingAreaImpl::createGraphicsContext()
https://bugs.webkit.org/show_bug.cgi?id=109893

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-02-17
Reviewed by Anders Carlsson.

DrawingAreaImpl::createGraphicsContext() is unnecessary since
createGraphicsContext can be called directly using ShareableBitmap.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake EventDispatcher take an Event object in its constructor.
hayato@chromium.org [Mon, 18 Feb 2013 05:51:49 +0000 (05:51 +0000)]
Make EventDispatcher take an Event object in its constructor.
https://bugs.webkit.org/show_bug.cgi?id=109898

Reviewed by Dimitri Glazkov.

That makes EventDispatcher more RAII-like so that we can calculate
an EventPath in its constructor.  I'll remove
EventDispatcher::ensureEventPath() in a following patch.

No tests. No change in behavior.

* dom/EventDispatchMediator.cpp:
(WebCore::EventDispatchMediator::dispatchEvent):
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::ensureEventPath):
(WebCore::EventDispatcher::dispatchSimulatedClick):
(WebCore::EventDispatcher::dispatch):
(WebCore::EventDispatcher::dispatchEventPreProcess):
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtTarget):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
(WebCore::EventDispatcher::dispatchEventPostProcess):
* dom/EventDispatcher.h:
(EventDispatcher):
(WebCore::EventDispatcher::node):
(WebCore::EventDispatcher::event):
* dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
* dom/GestureEvent.cpp:
(WebCore::GestureEventDispatchMediator::dispatchEvent):
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix non-root SVG viewport under zoom
pdr@google.com [Mon, 18 Feb 2013 05:38:40 +0000 (05:38 +0000)]
Fix non-root SVG viewport under zoom
https://bugs.webkit.org/show_bug.cgi?id=99453

Reviewed by Dirk Schulze.

Source/WebCore:

The root SVG element handles zoom differently than other SVG nodes because it needs
to translate between CSS (where zoom is applied to all units) and SVG (where zoom is only
applied at the top level). A good description of this difference can be found here:
http://trac.webkit.org/browser/trunk/Source/WebCore/css/StyleResolver.cpp?rev=142855#L2598

SVG elements can appear as children in the SVG tree as well, and in this mode
SVGSVGElement should not consider the current zoom level. This patch fixes a bug
where non-root viewport calculations were removing zoom.

Test: svg/custom/symbol-zoom.html

* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::currentViewportSize):
    This change removes the unnecessary zoom calculation for non-root nodes. This is similar
    to how zoom is handled elsewhere, e.g., SVGSVGElement::localCoordinateSpaceTransform.

LayoutTests:

* svg/custom/symbol-zoom-expected.html: Added.
* svg/custom/symbol-zoom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: Upstream iOS Accessibility files
cfleizach@apple.com [Mon, 18 Feb 2013 05:30:08 +0000 (05:30 +0000)]
AX: Upstream iOS Accessibility files
https://bugs.webkit.org/show_bug.cgi?id=110071

Reviewed by David Kilzer.

Upstream the iOS Accessibility files for WebCore.

* WebCore.xcodeproj/project.pbxproj:
* accessibility/ios: Added.
* accessibility/ios/AXObjectCacheIOS.mm: Added.
(WebCore):
(WebCore::AXObjectCache::detachWrapper):
(WebCore::AXObjectCache::attachWrapper):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::nodeTextChangePlatformNotification):
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::handleScrolledToAnchor):
* accessibility/ios/AccessibilityObjectIOS.mm: Added.
(-[WAKView accessibilityIsIgnored]):
(WebCore):
(WebCore::AccessibilityObject::detachFromParent):
(WebCore::AccessibilityObject::overrideAttachmentParent):
(WebCore::AccessibilityObject::accessibilityPasswordFieldLength):
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
* accessibility/ios/AccessibilityObjectWrapperIOS.h: Added.
(WAKView):
* accessibility/ios/AccessibilityObjectWrapperIOS.mm: Added.
(AccessibilityUnignoredAncestor):
(-[WebAccessibilityTextMarker initWithTextMarker:cache:]):
(-[WebAccessibilityTextMarker initWithData:cache:]):
(-[WebAccessibilityTextMarker initWithData:accessibilityObject:]):
(+[WebAccessibilityTextMarker textMarkerWithVisiblePosition:cache:]):
(-[WebAccessibilityTextMarker dataRepresentation]):
(-[WebAccessibilityTextMarker visiblePosition]):
(-[WebAccessibilityTextMarker description]):
(-[WebAccessibilityObjectWrapper initWithAccessibilityObject:]):
(-[WebAccessibilityObjectWrapper detach]):
(-[WebAccessibilityObjectWrapper dealloc]):
(-[WebAccessibilityObjectWrapper _prepareAccessibilityCall]):
(-[WebAccessibilityObjectWrapper accessibilityObject]):
(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
(-[WebAccessibilityObjectWrapper accessibilityPostProcessHitTest:]):
(-[WebAccessibilityObjectWrapper accessibilityHitTest:]):
(-[WebAccessibilityObjectWrapper accessibilityElementCount]):
(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
(-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]):
(-[WebAccessibilityObjectWrapper accessibilityLanguage]):
(-[WebAccessibilityObjectWrapper _accessibilityIsLandmarkRole:]):
(-[WebAccessibilityObjectWrapper _accessibilityListAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityLandmarkAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityTableAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]):
(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
(-[WebAccessibilityObjectWrapper isAccessibilityElement]):
(-[WebAccessibilityObjectWrapper stringValueShouldBeUsedInLabel]):
(-[WebAccessibilityObjectWrapper accessibilityLabel]):
(-[WebAccessibilityObjectWrapper tableCellParent]):
(-[WebAccessibilityObjectWrapper tableParent]):
(-[WebAccessibilityObjectWrapper accessibilityTitleElement]):
(-[WebAccessibilityObjectWrapper accessibilityHeaderElements]):
(-[WebAccessibilityObjectWrapper accessibilityElementForRow:andColumn:]):
(-[WebAccessibilityObjectWrapper accessibilityRowRange]):
(-[WebAccessibilityObjectWrapper accessibilityColumnRange]):
(-[WebAccessibilityObjectWrapper accessibilityPlaceholderValue]):
(-[WebAccessibilityObjectWrapper accessibilityValue]):
(-[WebAccessibilityObjectWrapper accessibilityIsComboBox]):
(-[WebAccessibilityObjectWrapper accessibilityHint]):
(-[WebAccessibilityObjectWrapper accessibilityURL]):
(-[WebAccessibilityObjectWrapper _convertIntRectToScreenCoordinates:]):
(-[WebAccessibilityObjectWrapper accessibilityElementRect]):
(-[WebAccessibilityObjectWrapper accessibilityActivationPoint]):
(-[WebAccessibilityObjectWrapper accessibilityFrame]):
(-[WebAccessibilityObjectWrapper containsUnnaturallySegmentedChildren]):
(-[WebAccessibilityObjectWrapper accessibilityContainer]):
(-[WebAccessibilityObjectWrapper accessibilityFocusedUIElement]):
(-[WebAccessibilityObjectWrapper _accessibilityWebDocumentView]):
(-[WebAccessibilityObjectWrapper _accessibilityNextElementsWithCount:]):
(-[WebAccessibilityObjectWrapper _accessibilityPreviousElementsWithCount:]):
(-[WebAccessibilityObjectWrapper accessibilityRequired]):
(-[WebAccessibilityObjectWrapper accessibilityFlowToElements]):
(-[WebAccessibilityObjectWrapper accessibilityLinkedElement]):
(-[WebAccessibilityObjectWrapper isAttachment]):
(-[WebAccessibilityObjectWrapper _accessibilityActivate]):
(-[WebAccessibilityObjectWrapper attachmentView]):
(rendererForView):
(-[WebAccessibilityObjectWrapper _accessibilityParentForSubview:]):
(-[WebAccessibilityObjectWrapper postFocusChangeNotification]):
(-[WebAccessibilityObjectWrapper postSelectedTextChangeNotification]):
(-[WebAccessibilityObjectWrapper postLayoutChangeNotification]):
(-[WebAccessibilityObjectWrapper postLiveRegionChangeNotification]):
(-[WebAccessibilityObjectWrapper postLoadCompleteNotification]):
(-[WebAccessibilityObjectWrapper postChildrenChangedNotification]):
(-[WebAccessibilityObjectWrapper postInvalidStatusChangedNotification]):
(-[WebAccessibilityObjectWrapper accessibilityElementDidBecomeFocused]):
(-[WebAccessibilityObjectWrapper accessibilityModifySelection:increase:]):
(-[WebAccessibilityObjectWrapper accessibilityIncreaseSelection:]):
(-[WebAccessibilityObjectWrapper accessibilityDecreaseSelection:]):
(-[WebAccessibilityObjectWrapper accessibilityMoveSelectionToMarker:]):
(-[WebAccessibilityObjectWrapper accessibilityIncrement]):
(-[WebAccessibilityObjectWrapper accessibilityDecrement]):
(-[WebAccessibilityObjectWrapper _addAccessibilityObject:toTextMarkerArray:]):
(-[WebAccessibilityObjectWrapper stringForTextMarkers:]):
(blockquoteLevel):
(AXAttributeStringSetBlockquoteLevel):
(AXAttributeStringSetHeadingLevel):
(AXAttributeStringSetFont):
(AXAttributeStringSetNumber):
(AXAttributeStringSetStyle):
(AXAttributedStringAppendText):
(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):
(-[WebAccessibilityObjectWrapper _convertToNSRange:]):
(-[WebAccessibilityObjectWrapper _convertToDOMRange:]):
(-[WebAccessibilityObjectWrapper positionForTextMarker:]):
(-[WebAccessibilityObjectWrapper textMarkerRange]):
(-[WebAccessibilityObjectWrapper elementTextRange]):
(-[WebAccessibilityObjectWrapper accessibilityObjectForTextMarker:]):
(-[WebAccessibilityObjectWrapper textMarkerRangeForSelection]):
(-[WebAccessibilityObjectWrapper textMarkerForPosition:]):
(-[WebAccessibilityObjectWrapper _stringForRange:attributed:]):
(-[WebAccessibilityObjectWrapper stringForRange:]):
(-[WebAccessibilityObjectWrapper attributedStringForRange:]):
(-[WebAccessibilityObjectWrapper elementsForRange:]):
(-[WebAccessibilityObjectWrapper selectionRangeString]):
(-[WebAccessibilityObjectWrapper selectedTextMarker]):
(-[WebAccessibilityObjectWrapper lineEndMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper lineStartMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper nextMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper previousMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper frameForTextMarkers:]):
(-[WebAccessibilityObjectWrapper textMarkerForPoint:]):
(-[WebAccessibilityObjectWrapper accessibilityIdentifier]):
(-[WebAccessibilityObjectWrapper accessibilitySpeechHint]):
(-[WebAccessibilityObjectWrapper accessibilityARIAIsBusy]):
(-[WebAccessibilityObjectWrapper accessibilityARIALiveRegionStatus]):
(-[WebAccessibilityObjectWrapper accessibilityARIARelevantStatus]):
(-[WebAccessibilityObjectWrapper accessibilityARIALiveRegionIsAtomic]):
(-[WebAccessibilityObjectWrapper accessibilityInvalidStatus]):
(-[WebAccessibilityObjectWrapper accessibilityMathRootIndexObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathRadicandObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathNumeratorObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathDenominatorObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathBaseObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathSubscriptObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathSuperscriptObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathUnderObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathOverObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathFencedOpenString]):
(-[WebAccessibilityObjectWrapper accessibilityMathFencedCloseString]):
(-[WebAccessibilityObjectWrapper accessibilityIsMathTopObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathType]):
(-[WebAccessibilityObjectWrapper accessibilitySetPostedNotificationCallback:withContext:]):
(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:WebCore::AXObjectCache::]):
(-[WebAccessibilityObjectWrapper description]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: rename WebAccessibilityObjectWrapper to WebAccessibilityObjectWrapperBase
cfleizach@apple.com [Mon, 18 Feb 2013 03:34:54 +0000 (03:34 +0000)]
AX: rename WebAccessibilityObjectWrapper to WebAccessibilityObjectWrapperBase
https://bugs.webkit.org/show_bug.cgi?id=110061

Reviewed by David Kilzer.

Rename the base accessibility wrapper class so that the iOS class can share the same name.

* WebCore.xcodeproj/project.pbxproj:
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::attachWrapper):
* accessibility/mac/WebAccessibilityObjectWrapper.h: Replaced with Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h.
* accessibility/mac/WebAccessibilityObjectWrapper.mm: Replaced with Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm.
* accessibility/mac/WebAccessibilityObjectWrapperBase.h: Copied from Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.h.
* accessibility/mac/WebAccessibilityObjectWrapperBase.mm: Copied from Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm.
* accessibility/mac/WebAccessibilityObjectWrapperMac.h: Removed.
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Windows build fix.
roger_fong@apple.com [Mon, 18 Feb 2013 03:33:40 +0000 (03:33 +0000)]
Unreviewed. Windows build fix.

* runtime/CodeCache.h:
(CodeCacheMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix typo in script.
roger_fong@apple.com [Mon, 18 Feb 2013 03:13:04 +0000 (03:13 +0000)]
Unreviewed. Fix typo in script.

* EWSTools/start-queue-win.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPass in bot name as parameter to start-queue-win script.
roger_fong@apple.com [Mon, 18 Feb 2013 01:58:39 +0000 (01:58 +0000)]
Pass in bot name as parameter to start-queue-win script.
https://bugs.webkit.org/show_bug.cgi?id=109998.

Reviewed by Darin Adler.

* EWSTools/start-queue-win.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Add myself as a committer.
bw80.lee@samsung.com [Mon, 18 Feb 2013 01:25:53 +0000 (01:25 +0000)]
Unreviewed. Add myself as a committer.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r143125): ~5% performance hit on Chromium's intl2 page cycler.
akling@apple.com [Sun, 17 Feb 2013 23:26:10 +0000 (23:26 +0000)]
REGRESSION(r143125): ~5% performance hit on Chromium's intl2 page cycler.
<http://webkit.org/b/108835>

Reviewed by Ojan Vafai.

Streamline the case where GlyphPage has a per-glyph SimpleFontData* lookup table to allow
taking earlier branches on pages with lots of mixed-font text.
We accomplish this by explicitly storing a null SimpleFontData* for glyph #0 in the per-glyph
lookup table instead of relying on "if (!glyph)" checks in getters.

This is a speculative optimization, I can't get stable enough numbers locally to tell if this
will resolve the issue on the bots.

* platform/graphics/GlyphPage.h:
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):
(WebCore::GlyphPage::setGlyphDataForIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebSpeech: plumb through a method to generate fake speech jobs for testing
cfleizach@apple.com [Sun, 17 Feb 2013 20:57:42 +0000 (20:57 +0000)]
WebSpeech: plumb through a method to generate fake speech jobs for testing
https://bugs.webkit.org/show_bug.cgi?id=107351

Reviewed by Adam Barth.

Source/WebCore:

We can't reliably use the platforms synthesizer to test speech synthesis internals.
This patch adds an Internals method to enable a mock synthesizer, which is inherits
from the PlatformSpeechSythesizer.

The fake synthesizer goes through all the motions of a real synthesizer but doesn't do anything.
A bunch of changes were needed here to make PlatformSpeechSynthesizer subclassable so that the
right virtual are used.

The Mock synthesizer only lives in WebCoreTestSupport. Because PlatformSpeechSynthesizer uses
a RetainPtr, I needed to make WebCoreTestSupport link CoreFoundation

LayoutTests:

* platform/mac/fast/speechsynthesis/speech-synthesis-speak.html:
* platform/mac/fast/speechsynthesis/speech-synthesis-voices.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 17 Feb 2013 20:05:43 +0000 (20:05 +0000)]
Unreviewed EFL gardening.

Mark compositing/layer-creation/fixed-position-out-of-view-scaled.html as
flaky on WebKit2 EFL. It sometimes hits an assertion.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2][EFL] Remove fullscreen manager proxy as a message receiver on invalidate()
ch.dumez@sisa.samsung.com [Sun, 17 Feb 2013 19:55:58 +0000 (19:55 +0000)]
[WK2][EFL] Remove fullscreen manager proxy as a message receiver on invalidate()
https://bugs.webkit.org/show_bug.cgi?id=109451

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-02-17
Reviewed by Anders Carlsson.

Remove fullscreen manager proxy as a message receiver on invalidate(), like
other ports do after r142160.

* UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:
(WebKit::WebFullScreenManagerProxy::invalidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCode cache should be explicit about what it caches
ggaren@apple.com [Sun, 17 Feb 2013 19:15:30 +0000 (19:15 +0000)]
Code cache should be explicit about what it caches
https://bugs.webkit.org/show_bug.cgi?id=110039

Reviewed by Oliver Hunt.

This patch makes the code cache more explicit in two ways:

(1) The cache caches top-level scripts. Any sub-functions executed as a
part of a script are cached with it and evicted with it.

This simplifies things by eliminating out-of-band sub-function tracking,
and fixes pathological cases where functions for live scripts would be
evicted in favor of functions for dead scripts, and/or high probability
functions executed early in script lifetime would be evicted in favor of
low probability functions executed late in script lifetime, due to LRU.

Statistical data from general browsing and PLT confirms that caching
functions independently of scripts is not profitable.

(2) The cache tracks script size, not script count.

This reduces the worst-case cache size by a factor of infinity.

Script size is a reasonable first-order estimate of in-memory footprint
for a cached script because there are no syntactic constructs that have
super-linear memory footprint.

* bytecode/UnlinkedCodeBlock.cpp:
(JSC::generateFunctionCodeBlock): Moved this function out of the cache
because it does not consult the cache, and is not managed by it.

(JSC::UnlinkedFunctionExecutable::visitChildren): Visit our code blocks
because they are strong references now, rather than weak, a la (1).

(JSC::UnlinkedFunctionExecutable::codeBlockFor): Updated for interface changes.

* bytecode/UnlinkedCodeBlock.h:
(UnlinkedFunctionExecutable):
(UnlinkedFunctionCodeBlock): Strong now, not weak, a la (1).

* runtime/CodeCache.cpp:
(JSC::CodeCache::CodeCache):
* runtime/CodeCache.h:
(JSC::SourceCodeKey::length):
(SourceCodeKey):
(CodeCacheMap):
(JSC::CodeCacheMap::CodeCacheMap):
(JSC::CodeCacheMap::find):
(JSC::CodeCacheMap::set):
(JSC::CodeCacheMap::clear):
(CodeCache):
(JSC::CodeCache::clear): Removed individual function tracking, due to (1).
Added explicit character counting, for (2).

You might think 16000000 characters is a lot. It is. But this patch
didn't establish that limit -- it just took the existing limit and
made it more visible. I intend to reduce the size of the cache in a
future patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegression(r143124): Caused plugins/plugin-javascript-access.html to fail
ch.dumez@sisa.samsung.com [Sun, 17 Feb 2013 18:59:45 +0000 (18:59 +0000)]
Regression(r143124): Caused plugins/plugin-javascript-access.html to fail
https://bugs.webkit.org/show_bug.cgi?id=110053

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

Clear m_plugins in loadPluginsIfNecessary() before populating the
vector again. We get duplicates otherwise.

* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::loadPluginsIfNecessary):

LayoutTests:

Unskip plugins/plugin-javascript-access.html for WK2 EFL now that the
Test is passing again.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Remove duplicates from EFL port's TestExpectations.
ch.dumez@sisa.samsung.com [Sun, 17 Feb 2013 18:53:04 +0000 (18:53 +0000)]
Unreviewed. Remove duplicates from EFL port's TestExpectations.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 17 Feb 2013 15:39:55 +0000 (15:39 +0000)]
Unreviewed EFL gardening.

Generate baseline for svg/filters/filter-hidden-content.svg on EFL
port.

* platform/efl/svg/filters/filter-hidden-content-expected.png: Added.
* platform/efl/svg/filters/filter-hidden-content-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 17 Feb 2013 15:35:53 +0000 (15:35 +0000)]
Unreviewed EFL gardening.

Mark compositing/geometry/limit-layer-bounds-fixed.html as failing on
EFL WK2. This test was introduced in r143073 but never passed on EFL.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sun, 17 Feb 2013 15:19:53 +0000 (15:19 +0000)]
Unreviewed EFL gardening.

Mark plugins/plugin-javascript-access.html as failing on WK2 EFL
due to a regression in r143124.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed buildfix for !USE(LIBXML) builds after r143112.
ossy@webkit.org [Sun, 17 Feb 2013 09:14:58 +0000 (09:14 +0000)]
[Qt] Unreviewed buildfix for !USE(LIBXML) builds after r143112.

* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename new-commit-bot to WKR to disambiguate it from commit-queue.
rniwa@webkit.org [Sun, 17 Feb 2013 08:44:14 +0000 (08:44 +0000)]
Rename new-commit-bot to WKR to disambiguate it from commit-queue.

Rubber-stamped by Andreas Kling.

* Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot.begin_work_queue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOptimize GlyphPage for case where all glyphs are available in the same font.
akling@apple.com [Sun, 17 Feb 2013 08:17:42 +0000 (08:17 +0000)]
Optimize GlyphPage for case where all glyphs are available in the same font.
<http://webkit.org/b/108835>
<rdar://problem/13157042>

Reviewed by Antti Koivisto.

Let GlyphPage begin optimistically assuming that all its glyphs will be represented in
the same SimpleFontData*. In this (very common) case, only keep a single SimpleFontData*.

If glyphs from multiple fonts are mixed in one page, an array of per-glyph SimpleFontData*
is allocated transparently.

This was landed before with some bogus branch prediction hints and didn't fare well on
page cyclers (intl2 specifically.) These have been removed this time around, and will
hopefully be regression-free.

4.98 MB progression on Membuster3.

* platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):
* platform/graphics/GlyphPage.h:
(WebCore::GlyphPage::createUninitialized):
(WebCore::GlyphPage::createZeroedSystemFallbackPage):
(WebCore::GlyphPage::createCopiedSystemFallbackPage):

    There are now three ways of constructing a GlyphPage, two of them are only used for
    creating system fallback pages.

(WebCore::GlyphPage::setGlyphDataForIndex):

    Hold off creating a SimpleFontData* array until we're sure there are two different
    SimpleFontData* backing the glyphs in this page.
    We don't store font data for glyph #0, instead we let the getters always return null for it.

(WebCore::GlyphPage::~GlyphPage):

    Free the SimpleFontData* array if needed.

(WebCore::GlyphPage::glyphDataForCharacter):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):

    The font data for glyph #0 is always a null pointer now.

(WebCore::GlyphPage::clearForFontData):

    Updated for new storage format.

* rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):

    Fix bug where non-zero glyph was temporarily associated with null font data,
    which triggered the new assertion in setGlyphDataForIndex().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Remove multi-threading gunk from WebKit2's PluginInfoStore.
akling@apple.com [Sun, 17 Feb 2013 06:01:39 +0000 (06:01 +0000)]
Source/WebCore: Remove multi-threading gunk from WebKit2's PluginInfoStore.
<http://webkit.org/b/110046>

Reviewed by Alexey Proskuryakov.

Remove now-unused code for making deep (isolated) copies of WebCore plugin structures.

* plugins/PluginData.h:
(MimeClassInfo):
(PluginInfo):

Source/WebKit2: Remove multi-threading gunk from PluginInfoStore.
<http://webkit.org/b/110046>

Reviewed by Alexey Proskuryakov.

PluginInfoStore is never accessed from multiple threads anymore, so remove the Mutex locking
and stop making isolated copies of everything.

* Shared/Plugins/PluginModuleInfo.h:
(PluginModuleInfo):
* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::loadPluginsIfNecessary):
(WebKit::PluginInfoStore::plugins):
(WebKit::PluginInfoStore::findPluginForMIMEType):
(WebKit::PluginInfoStore::findPluginForExtension):
(WebKit::PluginInfoStore::findPlugin):
(WebKit::PluginInfoStore::infoForPluginWithPath):
* UIProcess/Plugins/PluginInfoStore.h:
(PluginInfoStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Identifier generated twice in FrameLoader::loadResourceSynchronously()
ap@apple.com [Sun, 17 Feb 2013 05:42:45 +0000 (05:42 +0000)]
    Identifier generated twice in FrameLoader::loadResourceSynchronously()
        https://bugs.webkit.org/show_bug.cgi?id=110022

        Reviewed by Darin Adler.

        * loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously):
        Fix an apparent refactoring mistake.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove support for bytecode comments, since it doesn't build, and hasn't been used...
fpizlo@apple.com [Sun, 17 Feb 2013 05:36:48 +0000 (05:36 +0000)]
Remove support for bytecode comments, since it doesn't build, and hasn't been used in a while.
https://bugs.webkit.org/show_bug.cgi?id=110035

Rubber stamped by Andreas Kling.

There are other ways of achieving the same effect, like adding print statements to the bytecode generator.
The fact that this feature doesn't build and nobody noticed implies that it's probably not a popular
feature. As well, the amount of wiring that was required for it was quite big considering its relatively
modest utility.

* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
* bytecode/CodeBlock.h:
(CodeBlock):
* bytecode/Comment.h: Removed.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitOpcode):
(JSC):
* bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
(JSC::BytecodeGenerator::symbolTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Add myself as a committer.
glenn@skynav.com [Sun, 17 Feb 2013 05:19:16 +0000 (05:19 +0000)]
Unreviewed. Add myself as a committer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows] Unreviewed Visual Studio 2010 build fix after r143117
bfulgham@webkit.org [Sun, 17 Feb 2013 04:08:07 +0000 (04:08 +0000)]
[Windows] Unreviewed Visual Studio 2010 build fix after r143117

* JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractorDebug.props: Reference new path to property sheets.
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
Build correction after new operator == added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonew-commit-bot should report the full name of committer and reviewer instead of just...
rniwa@webkit.org [Sun, 17 Feb 2013 01:03:59 +0000 (01:03 +0000)]
new-commit-bot should report the full name of committer and reviewer instead of just nicks
https://bugs.webkit.org/show_bug.cgi?id=110040

Reviewed by Darin Adler.

Have it report names like "Ryosuke Niwa (rniwa)" instead of just "rniwa".

* Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot):
(NewCommitBot._summarize_commit_log):
* Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[JSC] Remove custom mark function for NamedNodeMap.
akling@apple.com [Sun, 17 Feb 2013 01:02:08 +0000 (01:02 +0000)]
[JSC] Remove custom mark function for NamedNodeMap.
<http://webkit.org/b/110029>

Reviewed by Darin Adler.

NamedNodeMap refs and unrefs its Element owner, so there's no need for the wrapper to keep the Element alive.

Covered by fast/dom/Attr/access-after-element-destruction.html

* bindings/js/JSNamedNodeMapCustom.cpp:
* dom/NamedNodeMap.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix non-production builds.
weinig@apple.com [Sun, 17 Feb 2013 00:11:56 +0000 (00:11 +0000)]
Fix non-production builds.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove redundant use of inline keyword in StringHasher.h
darin@apple.com [Sat, 16 Feb 2013 23:51:45 +0000 (23:51 +0000)]
Remove redundant use of inline keyword in StringHasher.h
https://bugs.webkit.org/show_bug.cgi?id=110036

Reviewed by Geoffrey Garen.

I have some other improvements for StringHasher.h, but wanted to get the simplest ones
out of the way first.

* wtf/StringHasher.h: Remove inline keyword on functions inside the class definition,
since functions defined inside the class are automatically inline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r143076): Crash when calling removeNamedItem or removeNamedItemNS with...
akling@apple.com [Sat, 16 Feb 2013 23:47:14 +0000 (23:47 +0000)]
REGRESSION(r143076): Crash when calling removeNamedItem or removeNamedItemNS with a non-existent attribute of newly created element.
<http://webkit.org/b/110019>

Patch by Peter Nelson <peter@peterdn.com> on 2013-02-16
Reviewed by Andreas Kling.

Now checks Element::hasAttributes() before calling Element::getAttributeItemIndex().

Test: http/tests/misc/acid3.html

* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoElement: Devirtualize attribute synchronization functions.
akling@apple.com [Sat, 16 Feb 2013 23:34:22 +0000 (23:34 +0000)]
Element: Devirtualize attribute synchronization functions.
<http://webkit.org/b/110033>

Reviewed by Darin Adler.

Devirtualize the functions that perform re-serialization of lazy attributes and give
them "synchronize"-style names:

    - SVGElement::synchronizeAnimatedSVGAttribute()
    - StyledElement::synchronizeStyleAttributeInternal()

* dom/Element.cpp:
(WebCore::Element::synchronizeAllAttributes):
(WebCore::Element::synchronizeAttribute):
* dom/Element.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::synchronizeStyleAttribute):
* dom/StyledElement.h:
(StyledElement):
* rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::RenderSVGResourceGradient::applyResource):
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::buildPattern):
* svg/SVGElement.cpp:
(WebCore::SVGElement::synchronizeAnimatedSVGAttribute):
* svg/SVGElement.h:
(SVGElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe Plugin.32 target does not build
weinig@apple.com [Sat, 16 Feb 2013 23:02:08 +0000 (23:02 +0000)]
The Plugin.32 target does not build
https://bugs.webkit.org/show_bug.cgi?id=110032

Reviewed by Anders Carlsson.

* PluginProcess/EntryPoint/mac/XPCService/PluginService.32/PluginService.32.Main.mm: Removed.
This was meant to be removed already.

* WebKit2.xcodeproj/project.pbxproj:
Add Plugin.32 as dependency in All as it should be.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoElement: Avoid unrelated attribute synchronization on other attribute access.
akling@apple.com [Sat, 16 Feb 2013 22:57:02 +0000 (22:57 +0000)]
Element: Avoid unrelated attribute synchronization on other attribute access.
<http://webkit.org/b/110025>

Reviewed by Darin Adler.

We've been extremely trigger happy with re-serializing the style attribute (and SVG animatables)
whenever any Element attribute API was used. This patch narrows this down to (almost always)
only synchronizing an attribute when someone specifically wants to read/update it.

Also removed two more confusing ElementData accessors:

    - Element::elementDataWithSynchronizedAttributes()
    - Element::ensureElementDataWithSynchronizedAttributes()

* dom/Element.h:
* dom/Element.cpp:
(WebCore::Element::hasAttributes):
(WebCore::Element::hasEquivalentAttributes):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::synchronizeAllAttributes):

    Renamed updateInvalidAttributes() to synchronizeAllAttributes().
    This function should only be used when we need every single attribute to be up-to-date.

(WebCore::Element::synchronizeAttribute):

    Broke out logic for synchronizing a specific attribute, given either a full QualifiedName
    or a localName.

(WebCore::Element::setSynchronizedLazyAttribute):

    Don't call ensureUniqueElementData() indisciminately here. This avoids converting the attribute
    storage when re-serializing the inline style yields the same CSS text that was already in the
    style attribute.

(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::getAttribute):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):

    Only synchronize the attribute in question.

* dom/Node.cpp:
(WebCore::Node::compareDocumentPosition):

    Call synchronizeAllAttributes() when comparing two Attr nodes on the same Element instead
    of relying on the side-effects of another function doing this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix WKDOMRangePrivate.h mistakes
darin@apple.com [Sat, 16 Feb 2013 22:27:12 +0000 (22:27 +0000)]
Fix WKDOMRangePrivate.h mistakes
https://bugs.webkit.org/show_bug.cgi?id=110028

Reviewed by Ryosuke Niwa.

* WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:
Added include of WKDOMRangePrivate.h.

* WebProcess/InjectedBundle/API/mac/WKDOMRangePrivate.h:
Fixed class name and include to be WKDOMRange.
Fixed method name, _copyBundleRangeHandleRef, to match the
name in the source file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a flaky image only failure expectation to the test added in r142979 on Mac per...
rniwa@webkit.org [Sat, 16 Feb 2013 22:24:54 +0000 (22:24 +0000)]
Add a flaky image only failure expectation to the test added in r142979 on Mac per bug 110027.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWe need a CIA replacement
rniwa@webkit.org [Sat, 16 Feb 2013 21:57:17 +0000 (21:57 +0000)]
We need a CIA replacement
https://bugs.webkit.org/show_bug.cgi?id=110008

Reviewed by Andreas Kling.

Added new-commit-bot.

* Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine.__init__):
(QueueEngine): Made the sleep tiem configurable.
(QueueEngine._sleep_message):
(QueueEngine._sleep):
* Scripts/webkitpy/tool/bot/queueengine_unittest.py:
(QueueEngineTest.test_sleep_message):
* Scripts/webkitpy/tool/commands/__init__.py:
* Scripts/webkitpy/tool/commands/newcommitbot.py: Added.
(PingPong): Added. Implements the ping pong protocol.
(NewCommitBot):
(NewCommitBot.begin_work_queue):
(NewCommitBot.work_item_log_path):
(NewCommitBot.next_work_item): Update SVN revision and report any new commits made since
the last time we checked the head SVN revision.
(NewCommitBot.process_work_item):
(NewCommitBot._update_checkout): svn up.
(NewCommitBot._new_svn_revisions): Returns a range of new revisions.
(NewCommitBot._summarize_commit_log): Summarize a commit log to be posted on IRC.
(NewCommitBot.handle_unexpected_error):
(NewCommitBot.handle_script_error):
* Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Added.
(NewCommitBotTest.test_summarize_commit_log_basic): Tests for summarizing non-rollout commits.
(NewCommitBotTest.test_summarize_commit_log_rollout): Tests for summarizing rollouts.
* Scripts/webkitpy/tool/commands/queues.py:
(AbstractQueue.execute):
* Scripts/webkitpy/tool/commands/queuestest.py:
(MockQueueEngine.__init__):
* Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
(SheriffBotTest.test_command_aliases):
* Scripts/webkitpy/tool/main.py:
(WebKitPatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix build warnings after r139853
commit-queue@webkit.org [Sat, 16 Feb 2013 21:00:36 +0000 (21:00 +0000)]
Fix build warnings after r139853
https://bugs.webkit.org/show_bug.cgi?id=109929

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-02-16
Reviewed by Alexey Proskuryakov.

Use UNUSED_PARAM macro to fix build warning -Wunused-parameter
when INSPECTOR is disabled.

No new tests, no behavior change.

* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::frameStartedLoading):
(WebCore::InspectorInstrumentation::frameStoppedLoading):
(WebCore::InspectorInstrumentation::frameScheduledNavigation):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix indentation of Structure.h
fpizlo@apple.com [Sat, 16 Feb 2013 20:07:05 +0000 (20:07 +0000)]
Fix indentation of Structure.h

Rubber stamped by Mark Hahnenberg.

* runtime/Structure.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] initialize all variables of TestRunner classes
jochen@chromium.org [Sat, 16 Feb 2013 18:27:07 +0000 (18:27 +0000)]
[chromium] initialize all variables of TestRunner classes
https://bugs.webkit.org/show_bug.cgi?id=110013

Reviewed by Adam Barth.

* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] destroy the TestPlugin when the destroy() method is invoked.
jochen@chromium.org [Sat, 16 Feb 2013 18:08:47 +0000 (18:08 +0000)]
[chromium] destroy the TestPlugin when the destroy() method is invoked.
https://bugs.webkit.org/show_bug.cgi?id=110012

Reviewed by Adam Barth.

* DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
(WebTestRunner::TestPlugin::destroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r142734.
commit-queue@webkit.org [Sat, 16 Feb 2013 17:09:01 +0000 (17:09 +0000)]
Unreviewed, rolling out r142734.
http://trac.webkit.org/changeset/142734
https://bugs.webkit.org/show_bug.cgi?id=110018

"Triggered crashes on lots of websites" (Requested by ggaren
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-16

Source/WebCore:

* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::getOwnPropertySlotDelegate):

LayoutTests:

* http/tests/plugins/resources/cross-frame-object-access.html:
* http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
* http/tests/security/cross-frame-access-location-get-expected.txt:
* http/tests/security/cross-frame-access-location-get.html:
* http/tests/security/resources/cross-frame-access.js:
* http/tests/security/resources/cross-frame-iframe-callback-explicit-domain-DENY.html:
* http/tests/security/resources/cross-frame-iframe-for-location-get-test.html:
* http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt:
* platform/chromium/http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt: Removed.
* platform/chromium/http/tests/security/cross-frame-access-location-get-expected.txt: Removed.
* platform/chromium/http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline for Win7.
toyoshim@chromium.org [Sat, 16 Feb 2013 16:35:36 +0000 (16:35 +0000)]
Rebaseline for Win7.

Unreviewed chromium gardening.

* platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Removed.
* platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agopercentage top value of position:relative element not calculated using parent's min...
robert@webkit.org [Sat, 16 Feb 2013 13:06:03 +0000 (13:06 +0000)]
percentage top value of position:relative element not calculated using parent's min-height unless height set
https://bugs.webkit.org/show_bug.cgi?id=14762

Reviewed by Julien Chaffraix.

Source/WebCore:

Percentage height "is calculated with respect to the height of the generated box's containing block" says
http://www.w3.org/TR/CSS21/visudet.html#the-height-property and "If the height of the containing block is not
specified explicitly (i.e., it depends on content height), and this element is not absolutely positioned, the
value computes to 'auto'." So when calculating the used height of a replaced element do not crawl through ancestor
blocks except when traversing anonymous blocks. Ensure that anonymous table cells are not skipped through though.

http://www.w3.org/TR/CSS21/tables.html#height-layout adds "In CSS 2.1, the height of a cell box is the minimum
height required by the content." This height is decided by allowing table cells to report their height as auto.
It's not clear why http://trac.webkit.org/changeset/91242 decided it should no longer do this - doing so caused
us to regress in our rendering of computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor.html.

Tests: fast/block/percent-top-parent-respects-min-height.html
       fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor-vertical-lr.html
       fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor.html
       fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor-vertical-lr.html
       fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight):
(WebCore):
(WebCore::RenderBoxModelObject::relativePositionOffset):
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::hasReplacedLogicalHeight):

LayoutTests:

* fast/block/percent-top-parent-respects-min-height-expected.txt: Added.
* fast/block/percent-top-parent-respects-min-height.html: Added.
* fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor-expected.txt: Added.
* fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor-vertical-lr-expected.txt: Added.
* fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor-vertical-lr.html: Added.
* fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor.html: Added.
* fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor-expected.txt: Added.
* fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor-vertical-lr-expected.txt: Added.
* fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor-vertical-lr.html: Added.
* fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[skia] FEOffset should have a Skia implementation.
senorblanco@chromium.org [Sat, 16 Feb 2013 12:45:57 +0000 (12:45 +0000)]
[skia] FEOffset should have a Skia implementation.
https://bugs.webkit.org/show_bug.cgi?id=109831

Reviewed by James Robinson.

Source/WebCore:

Covered by css3/filters/effect-reference.html and -hw.html.

* WebCore.gypi:
* platform/graphics/filters/FEOffset.h:  Implement createImageFilter()
for the Skia path.
* platform/graphics/filters/skia/FEOffsetSkia.cpp: Added.
(WebCore::FEOffset::createImageFilter):
Instantiate an SkOffsetImageFilter when building the Skia DAG.

LayoutTests:

* css3/filters/effect-reference-hw.html:
* css3/filters/effect-reference.html:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Create separate project for each domain for UISourceCode based on...
vsevik@chromium.org [Sat, 16 Feb 2013 11:28:19 +0000 (11:28 +0000)]
Web Inspector: Create separate project for each domain for UISourceCode based on browser resources.
https://bugs.webkit.org/show_bug.cgi?id=109691

Reviewed by Pavel Feldman.

Source/WebCore:

Separate project of certain type is now created for each domain.
UISourceCode path represents a path in the project now.
UISourceCode uri is now calculated based on project id and path.
It is also possible to calculate path based on projectId and URI, which is used for uiSourceCodeForURI() methods.

* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
* inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleProjectDelegate):
(WebInspector.SimpleProjectDelegate.projectId):
(WebInspector.SimpleProjectDelegate.prototype.id):
(WebInspector.SimpleProjectDelegate.prototype.displayName):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.splitURL):
(WebInspector.SimpleWorkspaceProvider._pathForSplittedURL):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._projectDelegate):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileByName):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFile):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFileByName):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.uri):
(WebInspector.UISourceCode.path):
(WebInspector.UISourceCode.prototype.uri):
* inspector/front-end/Workspace.js:
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.uiSourceCodeForURI):

LayoutTests:

* inspector/debugger/live-edit-breakpoints-expected.txt:
* inspector/debugger/live-edit-breakpoints.html:
* inspector/uisourcecode-revisions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix.
ch.dumez@sisa.samsung.com [Sat, 16 Feb 2013 08:46:41 +0000 (08:46 +0000)]
Unreviewed build fix.

Export symbol for new CString operator== operator to fix Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: Split WebAccessibilityObjectWrapper so code can be shared with iOS
cfleizach@apple.com [Sat, 16 Feb 2013 05:56:28 +0000 (05:56 +0000)]
AX: Split WebAccessibilityObjectWrapper so code can be shared with iOS
https://bugs.webkit.org/show_bug.cgi?id=109849

Reviewed by David Kilzer.

Split up the WebAccessibilityObjectWrapper so that iOS can share more
code with MacOS. I imagine over time, more code will move into this base class,
but for now this will be a good start.

A base class called WebAccessibilityObjectWrapper now exists, and Mac has a subclass
of that. iOS will be able to do the same.

* WebCore.xcodeproj/project.pbxproj:
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::attachWrapper):
* accessibility/mac/WebAccessibilityObjectWrapper.h:
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper detach]):
(-[WebAccessibilityObjectWrapper attachmentView]):
(-[WebAccessibilityObjectWrapper accessibilityObject]):
(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:]):
(-[WebAccessibilityObjectWrapper titleTagShouldBeUsedInDescriptionField]):
(-[WebAccessibilityObjectWrapper accessibilityTitle]):
(-[WebAccessibilityObjectWrapper accessibilityDescription]):
(-[WebAccessibilityObjectWrapper accessibilityHelpText]):
* accessibility/mac/WebAccessibilityObjectWrapperMac.h: Added.
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Added.
(std):
(-[WebAccessibilityObjectWrapperMac detach]):
(-[WebAccessibilityObjectWrapperMac attachmentView]):
(CFAutoreleaseHelper):
(AXObjectIsTextMarker):
(AXObjectIsTextMarkerRange):
(AXTextMarkerRange):
(AXTextMarkerRangeStart):
(AXTextMarkerRangeEnd):
(SearchKeyEntry):
(createAccessibilitySearchKeyMap):
(accessibilitySearchKeyForString):
(textMarkerForVisiblePosition):
(-[WebAccessibilityObjectWrapperMac textMarkerForVisiblePosition:]):
(visiblePositionForTextMarker):
(-[WebAccessibilityObjectWrapperMac visiblePositionForTextMarker:]):
(visiblePositionForStartOfTextMarkerRange):
(visiblePositionForEndOfTextMarkerRange):
(textMarkerRangeFromMarkers):
(AXAttributedStringRangeIsValid):
(AXAttributeStringSetFont):
(CreateCGColorIfDifferent):
(AXAttributeStringSetColor):
(AXAttributeStringSetNumber):
(AXAttributeStringSetStyle):
(AXAttributeStringSetBlockquoteLevel):
(AXAttributeStringSetSpelling):
(AXAttributeStringSetHeadingLevel):
(AXAttributeStringSetElement):
(AXAttributedStringAppendText):
(nsStringForReplacedNode):
(-[WebAccessibilityObjectWrapperMac doAXAttributedStringForTextMarkerRange:]):
(textMarkerRangeFromVisiblePositions):
(-[WebAccessibilityObjectWrapperMac textMarkerRangeFromVisiblePositions:endPosition:]):
(-[WebAccessibilityObjectWrapperMac accessibilityActionNames]):
(-[WebAccessibilityObjectWrapperMac additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapperMac accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapperMac visiblePositionRangeForTextMarkerRange:]):
(-[WebAccessibilityObjectWrapperMac renderWidgetChildren]):
(-[WebAccessibilityObjectWrapperMac remoteAccessibilityParentObject]):
(convertToVector):
(convertToNSArray):
(-[WebAccessibilityObjectWrapperMac textMarkerRangeForSelection]):
(-[WebAccessibilityObjectWrapperMac position]):
(createAccessibilityRoleMap):
(roleValueToNSString):
(-[WebAccessibilityObjectWrapperMac role]):
(-[WebAccessibilityObjectWrapperMac subrole]):
(-[WebAccessibilityObjectWrapperMac roleDescription]):
(-[WebAccessibilityObjectWrapperMac scrollViewParent]):
(-[WebAccessibilityObjectWrapperMac titleTagShouldBeUsedInDescriptionField]):
(-[WebAccessibilityObjectWrapperMac accessibilityTitle]):
(-[WebAccessibilityObjectWrapperMac accessibilityDescription]):
(-[WebAccessibilityObjectWrapperMac accessibilityHelpText]):
(-[WebAccessibilityObjectWrapperMac accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapperMac accessibilityFocusedUIElement]):
(-[WebAccessibilityObjectWrapperMac accessibilityHitTest:]):
(-[WebAccessibilityObjectWrapperMac accessibilityIsAttributeSettable:]):
(-[WebAccessibilityObjectWrapperMac accessibilityIsIgnored]):
(-[WebAccessibilityObjectWrapperMac accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformPressAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformIncrementAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformDecrementAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformShowMenuAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityShowContextMenu]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformAction:]):
(-[WebAccessibilityObjectWrapperMac accessibilitySetValue:forAttribute:]):
(rendererForView):
(-[WebAccessibilityObjectWrapperMac _accessibilityParentForSubview:]):
(-[WebAccessibilityObjectWrapperMac accessibilityActionDescription:]):
(-[WebAccessibilityObjectWrapperMac doAXAttributedStringForRange:]):
(-[WebAccessibilityObjectWrapperMac _convertToNSRange:]):
(-[WebAccessibilityObjectWrapperMac _indexForTextMarker:]):
(-[WebAccessibilityObjectWrapperMac _textMarkerForIndex:]):
(-[WebAccessibilityObjectWrapperMac doAXRTFForRange:]):
(-[WebAccessibilityObjectWrapperMac accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapperMac accessibilitySupportsOverriddenAttributes]):
(-[WebAccessibilityObjectWrapperMac accessibilityShouldUseUniqueId]):
(-[WebAccessibilityObjectWrapperMac accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapperMac accessibilityArrayAttributeCount:]):
(-[WebAccessibilityObjectWrapperMac accessibilityArrayAttributeValues:index:maxCount:]):
([WebAccessibilityObjectWrapperMac accessibilitySetShouldRepostNotifications:]):
(-[WebAccessibilityObjectWrapperMac accessibilityPostedNotification:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStructure should be more methodical about the relationship between m_offset and m_pro...
fpizlo@apple.com [Sat, 16 Feb 2013 05:31:00 +0000 (05:31 +0000)]
Structure should be more methodical about the relationship between m_offset and m_propertyTable
https://bugs.webkit.org/show_bug.cgi?id=109978

Reviewed by Mark Hahnenberg.

Allegedly, the previous relationship was that either m_propertyTable or m_offset
would be set, and if m_propertyTable was not set you could rebuild it.  In reality,
we would sometimes "reset" both: some transitions wouldn't set m_offset, and other
transitions would clear the previous structure's m_propertyTable.  So, in a
structure transition chain of A->B->C you could have:

A transitions to B: B doesn't copy m_offset but does copy m_propertyTable, because
    that seemed like a good idea at the time (this was a common idiom in the code).
B transitions to C: C steals B's m_propertyTable, leaving B with neither a
    m_propertyTable nor a m_offset.

Then we would ask for the size of the property storage of B and get the answer
"none".  That's not good.

Now, there is a new relationship, which, hopefully, should fix things: m_offset is
always set and always refers to the maximum offset ever used by the property table.
From this, you can infer both the inline and out-of-line property size, and
capacity.  This is accomplished by having PropertyTable::add() take a
PropertyOffset reference, which must be Structure::m_offset.  It will update this
offset.  As well, all transitions now copy m_offset.  And we frequently assert
(using RELEASE_ASSERT) that the m_offset matches what m_propertyTable would tell
you.  Hence if you ever modify the m_propertyTable, you'll also update the offset.
If you ever copy the property table, you'll also copy the offset.  Life should be
good, I think.

* runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::add):
* runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::checkConsistency):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):
(JSC::PropertyTable::checkConsistency):
* runtime/Structure.h:
(JSC):
(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::outOfLineCapacity):
(JSC::Structure::outOfLineSize):
(JSC::Structure::isEmpty):
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):
(Structure):
(JSC::Structure::checkOffsetConsistency):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] remove wkCaptionAppearance from WebKitSystemInterface
benjamin@webkit.org [Sat, 16 Feb 2013 05:19:33 +0000 (05:19 +0000)]
[Mac] remove wkCaptionAppearance from WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=109996

Patch by Eric Carlson <eric.carlson@apple.com> on 2013-02-15
Reviewed by Simon Fraser.

Source/WebCore:

* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKit2:

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r143088.
commit-queue@webkit.org [Sat, 16 Feb 2013 04:31:14 +0000 (04:31 +0000)]
Unreviewed, rolling out r143088.
http://trac.webkit.org/changeset/143088
https://bugs.webkit.org/show_bug.cgi?id=110000

Breaks the build (Requested by dgorbik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-15

Source/WebCore:

* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKit2:

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnhance AudioBus copyFrom() and sumFrom() to be able to handle discrete and speakers...
crogers@google.com [Sat, 16 Feb 2013 03:47:19 +0000 (03:47 +0000)]
Enhance AudioBus copyFrom() and sumFrom() to be able to handle discrete and speakers up and down-mixing
https://bugs.webkit.org/show_bug.cgi?id=109983

Reviewed by Kenneth Russell.

The Web Audio spec has a more detailed explanation for how channels are to be up and down-mixed:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#UpMix

This patch adds the initial support for handling ChannelInterpretation, although no
new JS API is yet implemented.

No new tests since no new APIs have yet been exposed.

* platform/audio/AudioBus.cpp:
(WebCore::AudioBus::copyFrom):
(WebCore):
(WebCore::AudioBus::sumFrom):
(WebCore::AudioBus::speakersCopyFrom):
(WebCore::AudioBus::speakersSumFrom):
(WebCore::AudioBus::discreteCopyFrom):
(WebCore::AudioBus::discreteSumFrom):
* platform/audio/AudioBus.h:
(AudioBus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Spread the gyp build files throughout the tree
mrobinson@webkit.org [Sat, 16 Feb 2013 03:26:06 +0000 (03:26 +0000)]
[GTK] Spread the gyp build files throughout the tree
https://bugs.webkit.org/show_bug.cgi?id=109960

Reviewed by Dirk Pranke.

Source/JavaScriptCore:

* JavaScriptCore.gyp/JavaScriptCoreGTK.gyp: Renamed from Source/WebKit/gtk/gyp/JavaScriptCore.gyp.
* JavaScriptCore.gyp/generate-derived-sources.sh: Renamed from Source/WebKit/gtk/gyp/generate-derived-sources.sh.

Source/WebKit/gtk:

* gyp/Configuration.gypi.in: Remove the 'Source', since now it cannot be shared.
* gyp/run-gyp: Update the path to the JavaScriptCore gypfile.

Source/WTF:

* WTF.gyp/WTFGTK.gyp: Renamed from Source/WebKit/gtk/gyp/WTF.gyp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPadding and border changes doesn't trigger relayout of children
tony@chromium.org [Sat, 16 Feb 2013 03:06:19 +0000 (03:06 +0000)]
Padding and border changes doesn't trigger relayout of children
https://bugs.webkit.org/show_bug.cgi?id=109639

Reviewed by Kent Tamura.

Source/WebCore:

In RenderBlock::layoutBlock, we only relayout our children if our logical width
changes. This misses cases where our logical width doesn't change (i.e., padding
or border changes), but our content width does change.

Also convert the needsLayout ASSERT into the if statement. This is because
RenderScrollbarPart can change border widths and not need a layout if the scrollbar
doesn't have a parent. In this case, we don't need to set any children for layout.

This is a more general case of bug 104997.

Test: fast/block/dynamic-padding-border.html

* rendering/RenderBox.cpp:
(WebCore::borderOrPaddingLogicalWidthChanged): Only check if the logical width changed.
(WebCore::RenderBox::styleDidChange): Drop the border-box condition since this can happen
even without border-box box sizing.

LayoutTests:

* fast/block/dynamic-padding-border-expected.txt: Added.
* fast/block/dynamic-padding-border.html: Added.
* fast/table/border-collapsing/cached-change-row-border-width-expected.txt: We should have been relaying
out the table when the border changed. The pixel results in this case is the same, but the
render tree shows the difference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDisable sudden termination on Mac
commit-queue@webkit.org [Sat, 16 Feb 2013 03:06:11 +0000 (03:06 +0000)]
Disable sudden termination on Mac
https://bugs.webkit.org/show_bug.cgi?id=109990

Patch by Kiran Muppala <cmuppala@apple.com> on 2013-02-15
Reviewed by Mark Rowe.

Sudden Termination is causing WebContent XPC services to be killed in
response to memory pressure.  Hence, disable it until we can identify
if it is being enabled in error or not.

* Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::platformInitialize): Add call to
[NSProcessInfo disableSuddenTermination].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSplit SQLStatement work between the frontend and backend.
mark.lam@apple.com [Sat, 16 Feb 2013 03:03:50 +0000 (03:03 +0000)]
Split SQLStatement work between the frontend and backend.
https://bugs.webkit.org/show_bug.cgi?id=104751.

Reviewed by Geoffrey Garen.

This is part of the webdatabase refactoring for webkit2.

1. Copied SQLTransaction to SQLTransactionBackend, and then reduce the
   2 to only handle frontend and backend work respectively.

2. Changed how statements are created.

   - SQLTransaction::executeSQL() first creates a SQLStatement frontend
     which encapsulates the 2 script callbacks. It then passes the
     SQLStatement to the backend database to create the
     SQLStatementBackend.
   - The SQLStatementBackend manages all sqlite work.

3. Remove the Database::reportExecuteStatementResult() wrapper because
   it is only needed in the backend now.

4. Added new files to the build / project files.

5. Updated / added comments about how the SQLStatement life-cycle works.

No new tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/webdatabase/Database.cpp:
* Modules/webdatabase/Database.h:
(Database):
(WebCore::Database::reportCommitTransactionResult):
* Modules/webdatabase/DatabaseBackend.h:
(DatabaseBackend):
* Modules/webdatabase/SQLStatement.cpp:
(WebCore::SQLStatement::create):
(WebCore::SQLStatement::SQLStatement):
(WebCore::SQLStatement::setBackend):
(WebCore::SQLStatement::hasCallback):
(WebCore::SQLStatement::hasErrorCallback):
(WebCore::SQLStatement::performCallback):
* Modules/webdatabase/SQLStatement.h:
(SQLStatement):
* Modules/webdatabase/SQLStatementBackend.cpp: Copied from Source/WebCore/Modules/webdatabase/SQLStatement.cpp.
(WebCore::SQLStatementBackend::create):
(WebCore::SQLStatementBackend::SQLStatementBackend):
(WebCore::SQLStatementBackend::frontend):
(WebCore::SQLStatementBackend::sqlError):
(WebCore::SQLStatementBackend::sqlResultSet):
(WebCore::SQLStatementBackend::execute):
(WebCore::SQLStatementBackend::setDatabaseDeletedError):
(WebCore::SQLStatementBackend::setVersionMismatchedError):
(WebCore::SQLStatementBackend::setFailureDueToQuota):
(WebCore::SQLStatementBackend::clearFailureDueToQuota):
(WebCore::SQLStatementBackend::lastExecutionFailedDueToQuota):
* Modules/webdatabase/SQLStatementBackend.h: Copied from Source/WebCore/Modules/webdatabase/SQLStatement.h.
(SQLStatementBackend):
(WebCore::SQLStatementBackend::hasStatementCallback):
(WebCore::SQLStatementBackend::hasStatementErrorCallback):
* Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverStatementCallback):
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback):
(WebCore::SQLTransaction::executeSQL):
* Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::currentStatement):
(WebCore::SQLTransactionBackend::enqueueStatementBackend):
(WebCore::SQLTransactionBackend::executeSQL):
(WebCore::SQLTransactionBackend::runStatements):
(WebCore::SQLTransactionBackend::getNextStatement):
(WebCore::SQLTransactionBackend::runCurrentStatementAndGetNextState):
(WebCore::SQLTransactionBackend::nextStateForCurrentStatementError):
* Modules/webdatabase/SQLTransactionBackend.h:
(SQLTransactionBackend):
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename HasCustomCallbacks to HasCustomStyleCallbacks
esprehn@chromium.org [Sat, 16 Feb 2013 02:36:29 +0000 (02:36 +0000)]
Rename HasCustomCallbacks to HasCustomStyleCallbacks
https://bugs.webkit.org/show_bug.cgi?id=109982

Reviewed by Eric Seidel.

Now that inside ChildFrameDisconnector we only call isFrameOwnerElement()
on elements that report having descendants (or themselves) have connected
frames we don't need to be as agressive about avoiding the virtual call
to isFrameOwnerElement() which lets us rename hasCustomCallbacks to
hasCustomStyleCallbacks to better reflect it's purpose.

* dom/ContainerNodeAlgorithms.h:
(WebCore::ChildFrameDisconnector::collectFrameOwners):
* dom/Element.cpp:
(WebCore::Element::styleForRenderer):
(WebCore::Element::recalcStyle):
(WebCore::Element::willRecalcStyle):
(WebCore::Element::didRecalcStyle):
(WebCore::Element::customStyleForRenderer):
* dom/Node.h:
(WebCore::Node::pseudoId):
(WebCore::Node::hasCustomStyleCallbacks):
(WebCore::Node::customPseudoId):
(WebCore::Node::setHasCustomStyleCallbacks):
* dom/PseudoElement.cpp:
(WebCore::PseudoElement::PseudoElement):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::recalcStyle):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
* html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
(WebCore::HTMLFrameOwnerElement::disconnectContentFrame):
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::HTMLIFrameElement):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
* html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::HTMLOptionElement):
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::DateTimeEditElement):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::TextControlInnerElement):
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
* html/shadow/TextFieldDecorationElement.cpp:
(WebCore::TextFieldDecorationElement::TextFieldDecorationElement):
* svg/SVGElement.cpp:
(WebCore::SVGElement::SVGElement):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::SVGUseElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] remove wkCaptionAppearance from WebKitSystemInterface
eric.carlson@apple.com [Sat, 16 Feb 2013 02:33:40 +0000 (02:33 +0000)]
[Mac] remove wkCaptionAppearance from WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=109996

Reviewed by Simon Fraser.

Source/WebCore:

* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKit2:

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Crash on window resize if WebProcess is closed/crashed
commit-queue@webkit.org [Sat, 16 Feb 2013 01:42:13 +0000 (01:42 +0000)]
[Qt][WK2] Crash on window resize if WebProcess is closed/crashed
https://bugs.webkit.org/show_bug.cgi?id=109216

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-02-15
Reviewed by Benjamin Poulain.

Only make calls into DrawingAreaProxy pointer after checking its state.

When the WebProcess was closed or crashed, WebKit::WebPageProxy will set
its DrawingAreaProxy pointer to null. Resize events on UIProcess/client will
try to access the object to update the geometry and forward this information
into the WebProcess. This would create a crash scenario that is fixed by this patch.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::didRelaunchProcess):
(QQuickWebViewLegacyPrivate::updateViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCalling DOM Element.attributes shouldn't force creation of ElementData.
akling@apple.com [Sat, 16 Feb 2013 01:39:19 +0000 (01:39 +0000)]
Calling DOM Element.attributes shouldn't force creation of ElementData.
<http://webkit.org/b/109976>

Reviewed by Darin Adler.

Don't create ElementData for an Element unnecessarily just because someone calls .attributes on it.
Previously, JS like this would create empty ElementData when 'element' has no attributes:

    for (i = 0; i < element.attributes.length; ++i)
        doStuff(element.attributes[i]);

Make NamedNodeMap::length() short-circuit and return 0 if !Element::hasAttributes().

* dom/Element.cpp:
(WebCore::Element::attributes):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::length):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] An "EvenTarget" type in IDL should be converted to EventTarget*, not to Node*
haraken@chromium.org [Sat, 16 Feb 2013 01:24:03 +0000 (01:24 +0000)]
[V8] An "EvenTarget" type in IDL should be converted to EventTarget*, not to Node*
https://bugs.webkit.org/show_bug.cgi?id=109895

Reviewed by Adam Barth.

Currently an "EventTarget" type in IDL is converted to Node*.
This is wrong because there are non-Node interfaces that inherit
a EventTarget. We should convert an "EventTarget" type to EventTarget*.
This will fix FIXMEs in CodeGeneratorV8.pm.

* bindings/scripts/CodeGeneratorV8.pm:
(GetNativeType):
(JSValueToNative):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r142505?): Crashes in WebCore::ScrollingStateNode::appendChild when using...
simon.fraser@apple.com [Sat, 16 Feb 2013 01:20:38 +0000 (01:20 +0000)]
REGRESSION (r142505?): Crashes in WebCore::ScrollingStateNode::appendChild when using back/forward buttons
https://bugs.webkit.org/show_bug.cgi?id=109826
<rdar://problem/13216100>

Source/WebCore:

Reviewed by Beth Dakin.

Fix a crash when going Back on some pages with fixed position elements.

When a page was being restored from the page cache, and a layout from
FrameLoader::commitProvisionalLoad() caused us to try to register the fixed
position layer before the main scrolling layer, we'd crash trying to dereference
the root node.

Fix by bailing from ScrollingStateTree::attachNode() if we can't find the parent
node.

Test: platform/mac-wk2/tiled-drawing/null-parent-back-crash.html

* page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::stateNodeForID):
* page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::updateViewportConstrainedNode):

LayoutTests:

Reviewed by Beth Dakin.

Test having a page with an iframe that navigates forwards then back.

* platform/mac-wk2/tiled-drawing/null-parent-back-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConstrain fixed layers to the viewport, not the document
simon.fraser@apple.com [Sat, 16 Feb 2013 01:05:20 +0000 (01:05 +0000)]
Constrain fixed layers to the viewport, not the document
https://bugs.webkit.org/show_bug.cgi?id=109646

Source/WebCore:

Reviewed by Beth Dakin.

It's bad to constrain position:fixed compositing layers to the
document rect, because their bounds will change every time the scroll
position changes, and we're not good currently at synchronizing scrolling
thread layer updates with main thread layer updates, so jiggles ensue.

Fix by constraining position:fixed layers to the viewport.

Test: compositing/geometry/limit-layer-bounds-fixed.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):

LayoutTests:

Reviewed by Beth Dakin.

Test with a big fixed element in a compositing layer.

* compositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
* compositing/geometry/limit-layer-bounds-fixed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a CDMClient class which allows the CDM to query for the currently attached MediaP...
jer.noble@apple.com [Sat, 16 Feb 2013 01:03:29 +0000 (01:03 +0000)]
Add a CDMClient class which allows the CDM to query for the currently attached MediaPlayer.
https://bugs.webkit.org/show_bug.cgi?id=109702

Reviewed by Eric Carlson.

Some CDM implementations will need to work closely with an associated
MediaPlayer in order to generate key requests and provide keys. Add a
client protocol to be implemented by the MediaKeys object which can
provide access to the associated MediaPlayer if present.

* Modules/encryptedmedia/CDM.cpp:
(WebCore::CDM::CDM): Initialize the m_client ivar.
(WebCore::CDM::mediaPlayer): Pass to the client, if present.
* Modules/encryptedmedia/CDM.h:
(WebCore::CDM::client): Simple getter.
(WebCore::CDM::setClient): Simple setter.
* Modules/encryptedmedia/MediaKeys.cpp:
(WebCore::MediaKeys::MediaKeys): Initialize the m_mediaElement ivar
    and call setClient() on the passed in CDM.
(WebCore::MediaKeys::setMediaElement): Simple setter.
(WebCore::MediaKeys::cdmMediaPlayer): Retrieve the MediaPlayer from
    the m_mediaElement if present.
* Modules/encryptedmedia/MediaKeys.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement): Call setMediaKeys(0)
    to clear the mediaElement in any associated MediaKeys.
(WebCore::HTMLMediaElement::setMediaKeys): Clear the mediaElement on
    any associated MediaKeys, and set the mediaElement on the newly
    associated MediaKeys.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd HashMap::isValidKey and HashSet::isValidValue
andersca@apple.com [Sat, 16 Feb 2013 01:01:03 +0000 (01:01 +0000)]
Add HashMap::isValidKey and HashSet::isValidValue
https://bugs.webkit.org/show_bug.cgi?id=109977

Reviewed by Sam Weinig and Darin Adler.

Source/WebKit2:

Just call HashMap::isValidKey directly.

* UIProcess/WebProcessProxy.cpp:
(WebKit::generatePageID):
Initialize the id to 0 and use prefix increment.

(WebKit::WebProcessProxy::webFrame):
(WebKit::WebProcessProxy::canCreateFrame):
(WebKit::WebProcessProxy::didDestroyFrame):

Source/WTF:

Add helper functions for determining whether keys are valid, i.e. if
they are _not_ empty or deleted according to the hash traits.

* wtf/HashMap.h:
* wtf/HashSet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agodrop-shadow filter with overflow:hidden child misbehaves
simon.fraser@apple.com [Sat, 16 Feb 2013 00:55:44 +0000 (00:55 +0000)]
drop-shadow filter with overflow:hidden child misbehaves
https://bugs.webkit.org/show_bug.cgi?id=109783

Source/WebCore:

Reviewed by Dean Jackson.

The change in r112745 was not sufficient; it failed to account
for descendant layers that needed to not clipping to avoid artefacts
with filters like drop-shadow.

Test: css3/filters/filter-repaint-shadow-layer-child.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents): Remove the useClipRect bool.
Replace it with a clipToDirtyRect member on the LayerPaintingInfo, which
gets passed to descendants. Remove some "Restore the clip" comments that added
nothing.
* rendering/RenderLayer.h:
(WebCore::RenderLayer::LayerPaintingInfo::LayerPaintingInfo):
(LayerPaintingInfo):

LayoutTests:

Reviewed by Dean Jackson.

* css3/filters/filter-repaint-shadow-layer-child-expected.html: Added.
* css3/filters/filter-repaint-shadow-layer-child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r143066.
commit-queue@webkit.org [Sat, 16 Feb 2013 00:52:07 +0000 (00:52 +0000)]
Unreviewed, rolling out r143066.
http://trac.webkit.org/changeset/143066
https://bugs.webkit.org/show_bug.cgi?id=109986

Broke the Apple Lion build (among others). (Requested by
ddkilzer on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-15

* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::attachWrapper):
* accessibility/mac/WebAccessibilityObjectWrapper.h:
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper unregisterUniqueIdForUIElement]):
(-[WebAccessibilityObjectWrapper detach]):
(-[WebAccessibilityObjectWrapper accessibilityObject]):
(-[WebAccessibilityObjectWrapper attachmentView]):
(CFAutoreleaseHelper):
(AXObjectIsTextMarker):
(AXObjectIsTextMarkerRange):
(AXTextMarkerRange):
(AXTextMarkerRangeStart):
(AXTextMarkerRangeEnd):
(SearchKeyEntry):
(createAccessibilitySearchKeyMap):
(accessibilitySearchKeyForString):
(textMarkerForVisiblePosition):
(-[WebAccessibilityObjectWrapper textMarkerForVisiblePosition:]):
(visiblePositionForTextMarker):
(-[WebAccessibilityObjectWrapper visiblePositionForTextMarker:]):
(visiblePositionForStartOfTextMarkerRange):
(visiblePositionForEndOfTextMarkerRange):
(textMarkerRangeFromMarkers):
(AXAttributedStringRangeIsValid):
(AXAttributeStringSetFont):
(CreateCGColorIfDifferent):
(AXAttributeStringSetColor):
(AXAttributeStringSetNumber):
(AXAttributeStringSetStyle):
(AXAttributeStringSetBlockquoteLevel):
(AXAttributeStringSetSpelling):
(AXAttributeStringSetHeadingLevel):
(AXAttributeStringSetElement):
(AXAttributedStringAppendText):
(nsStringForReplacedNode):
(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
(textMarkerRangeFromVisiblePositions):
(-[WebAccessibilityObjectWrapper textMarkerRangeFromVisiblePositions:endPosition:]):
(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
(-[WebAccessibilityObjectWrapper renderWidgetChildren]):
(-[WebAccessibilityObjectWrapper remoteAccessibilityParentObject]):
(convertToVector):
(convertToNSArray):
(-[WebAccessibilityObjectWrapper textMarkerRangeForSelection]):
(-[WebAccessibilityObjectWrapper position]):
(createAccessibilityRoleMap):
(roleValueToNSString):
(-[WebAccessibilityObjectWrapper role]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
(-[WebAccessibilityObjectWrapper scrollViewParent]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityFocusedUIElement]):
(-[WebAccessibilityObjectWrapper accessibilityHitTest:]):
(-[WebAccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
(-[WebAccessibilityObjectWrapper accessibilityIsIgnored]):
(-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityPerformPressAction]):
(-[WebAccessibilityObjectWrapper accessibilityPerformIncrementAction]):
(-[WebAccessibilityObjectWrapper accessibilityPerformDecrementAction]):
(-[WebAccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
(-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):
(-[WebAccessibilityObjectWrapper accessibilityPerformAction:]):
(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(rendererForView):
(-[WebAccessibilityObjectWrapper _accessibilityParentForSubview:]):
(-[WebAccessibilityObjectWrapper accessibilityActionDescription:]):
(-[WebAccessibilityObjectWrapper doAXAttributedStringForRange:]):
(-[WebAccessibilityObjectWrapper _convertToNSRange:]):
(-[WebAccessibilityObjectWrapper _indexForTextMarker:]):
(-[WebAccessibilityObjectWrapper _textMarkerForIndex:]):
(-[WebAccessibilityObjectWrapper doAXRTFForRange:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapper accessibilitySupportsOverriddenAttributes]):
(-[WebAccessibilityObjectWrapper accessibilityShouldUseUniqueId]):
(-[WebAccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
* accessibility/mac/WebAccessibilityObjectWrapperMac.h: Removed.
* accessibility/mac/WebAccessibilityObjectWrapperMac.m: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange MouseRelatedEvent to use LayoutPoint::scale
eae@chromium.org [Sat, 16 Feb 2013 00:33:06 +0000 (00:33 +0000)]
Change MouseRelatedEvent to use LayoutPoint::scale
https://bugs.webkit.org/show_bug.cgi?id=109979

Reviewed by Dimitri Glazkov.

Change MouseRelatedEvent::MouseRelatedEvent to use LayoutPoint::
scale to adjust location and scroll offset for scale factor and
zooming.

No new tests, no change in functionality.

* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Write a test to simulate crashed WebProcess followed by Window resize
benjamin@webkit.org [Sat, 16 Feb 2013 00:22:08 +0000 (00:22 +0000)]
[WK2] Write a test to simulate crashed WebProcess followed by Window resize
https://bugs.webkit.org/show_bug.cgi?id=109842

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-02-15
Reviewed by Benjamin Poulain.

This new test will kill WebProcess, followed by next resizing the Window. It helps to
identify if the port is testing for WebPageProxy data members state (e.g. DrawingArea, Frames)
before making calls into them.

* TestWebKitAPI/GNUmakefile.am:
* TestWebKitAPI/PlatformEfl.cmake:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::didFinishLoad):
(TestWebKitAPI::didCrash):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: Split WebAccessibilityObjectWrapper so code can be shared with iOS
cfleizach@apple.com [Sat, 16 Feb 2013 00:17:50 +0000 (00:17 +0000)]
AX: Split WebAccessibilityObjectWrapper so code can be shared with iOS
https://bugs.webkit.org/show_bug.cgi?id=109849

Reviewed by David Kilzer.

Split up the WebAccessibilityObjectWrapper so that iOS can share more
code with MacOS. I imagine over time, more code will move into this base class,
but for now this will be a good start.

A base class called WebAccessibilityObjectWrapper now exists, and Mac has a subclass
of that. iOS will be able to do the same.

* WebCore.xcodeproj/project.pbxproj:
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::attachWrapper):
* accessibility/mac/WebAccessibilityObjectWrapper.h:
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper detach]):
(-[WebAccessibilityObjectWrapper attachmentView]):
(-[WebAccessibilityObjectWrapper accessibilityObject]):
(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:]):
(-[WebAccessibilityObjectWrapper titleTagShouldBeUsedInDescriptionField]):
(-[WebAccessibilityObjectWrapper accessibilityTitle]):
(-[WebAccessibilityObjectWrapper accessibilityDescription]):
(-[WebAccessibilityObjectWrapper accessibilityHelpText]):
* accessibility/mac/WebAccessibilityObjectWrapperMac.h: Added.
* accessibility/mac/WebAccessibilityObjectWrapperMac.m: Added.
(std):
(-[WebAccessibilityObjectWrapperMac detach]):
(-[WebAccessibilityObjectWrapperMac attachmentView]):
(CFAutoreleaseHelper):
(AXObjectIsTextMarker):
(AXObjectIsTextMarkerRange):
(AXTextMarkerRange):
(AXTextMarkerRangeStart):
(AXTextMarkerRangeEnd):
(SearchKeyEntry):
(createAccessibilitySearchKeyMap):
(accessibilitySearchKeyForString):
(textMarkerForVisiblePosition):
(-[WebAccessibilityObjectWrapperMac textMarkerForVisiblePosition:]):
(visiblePositionForTextMarker):
(-[WebAccessibilityObjectWrapperMac visiblePositionForTextMarker:]):
(visiblePositionForStartOfTextMarkerRange):
(visiblePositionForEndOfTextMarkerRange):
(textMarkerRangeFromMarkers):
(AXAttributedStringRangeIsValid):
(AXAttributeStringSetFont):
(CreateCGColorIfDifferent):
(AXAttributeStringSetColor):
(AXAttributeStringSetNumber):
(AXAttributeStringSetStyle):
(AXAttributeStringSetBlockquoteLevel):
(AXAttributeStringSetSpelling):
(AXAttributeStringSetHeadingLevel):
(AXAttributeStringSetElement):
(AXAttributedStringAppendText):
(nsStringForReplacedNode):
(-[WebAccessibilityObjectWrapperMac doAXAttributedStringForTextMarkerRange:]):
(textMarkerRangeFromVisiblePositions):
(-[WebAccessibilityObjectWrapperMac textMarkerRangeFromVisiblePositions:endPosition:]):
(-[WebAccessibilityObjectWrapperMac accessibilityActionNames]):
(-[WebAccessibilityObjectWrapperMac additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapperMac accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapperMac visiblePositionRangeForTextMarkerRange:]):
(-[WebAccessibilityObjectWrapperMac renderWidgetChildren]):
(-[WebAccessibilityObjectWrapperMac remoteAccessibilityParentObject]):
(convertToVector):
(convertToNSArray):
(-[WebAccessibilityObjectWrapperMac textMarkerRangeForSelection]):
(-[WebAccessibilityObjectWrapperMac position]):
(createAccessibilityRoleMap):
(roleValueToNSString):
(-[WebAccessibilityObjectWrapperMac role]):
(-[WebAccessibilityObjectWrapperMac subrole]):
(-[WebAccessibilityObjectWrapperMac roleDescription]):
(-[WebAccessibilityObjectWrapperMac scrollViewParent]):
(-[WebAccessibilityObjectWrapperMac titleTagShouldBeUsedInDescriptionField]):
(-[WebAccessibilityObjectWrapperMac accessibilityTitle]):
(-[WebAccessibilityObjectWrapperMac accessibilityDescription]):
(-[WebAccessibilityObjectWrapperMac accessibilityHelpText]):
(-[WebAccessibilityObjectWrapperMac accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapperMac accessibilityFocusedUIElement]):
(-[WebAccessibilityObjectWrapperMac accessibilityHitTest:]):
(-[WebAccessibilityObjectWrapperMac accessibilityIsAttributeSettable:]):
(-[WebAccessibilityObjectWrapperMac accessibilityIsIgnored]):
(-[WebAccessibilityObjectWrapperMac accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformPressAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformIncrementAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformDecrementAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformShowMenuAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityShowContextMenu]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformAction:]):
(-[WebAccessibilityObjectWrapperMac accessibilitySetValue:forAttribute:]):
(rendererForView):
(-[WebAccessibilityObjectWrapperMac _accessibilityParentForSubview:]):
(-[WebAccessibilityObjectWrapperMac accessibilityActionDescription:]):
(-[WebAccessibilityObjectWrapperMac doAXAttributedStringForRange:]):
(-[WebAccessibilityObjectWrapperMac _convertToNSRange:]):
(-[WebAccessibilityObjectWrapperMac _indexForTextMarker:]):
(-[WebAccessibilityObjectWrapperMac _textMarkerForIndex:]):
(-[WebAccessibilityObjectWrapperMac doAXRTFForRange:]):
(-[WebAccessibilityObjectWrapperMac accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapperMac accessibilitySupportsOverriddenAttributes]):
(-[WebAccessibilityObjectWrapperMac accessibilityShouldUseUniqueId]):
(-[WebAccessibilityObjectWrapperMac accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapperMac accessibilityArrayAttributeCount:]):
(-[WebAccessibilityObjectWrapperMac accessibilityArrayAttributeValues:index:maxCount:]):
([WebAccessibilityObjectWrapperMac accessibilitySetShouldRepostNotifications:]):
(-[WebAccessibilityObjectWrapperMac accessibilityPostedNotification:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTypo fix after r143064.
ossy@webkit.org [Fri, 15 Feb 2013 23:58:53 +0000 (23:58 +0000)]
Typo fix after r143064.

* Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::sendOutgoingMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOne more buildfix after r143052.
ossy@webkit.org [Fri, 15 Feb 2013 23:47:43 +0000 (23:47 +0000)]
One more buildfix after r143052.

* Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::sendOutgoingMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143064 268f45cc-cd09-0410-ab3c-d52691b4dbfc