WebKit-https.git
10 years ago2011-05-09 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 9 May 2011 17:19:36 +0000 (17:19 +0000)]
2011-05-09  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add guidelines for feature addition to webkit.org (per disccusion at contributor meeting)
        https://bugs.webkit.org/show_bug.cgi?id=59672

        * coding/adding-features.html: Added.
        * nav.inc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-08 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Mon, 9 May 2011 16:32:26 +0000 (16:32 +0000)]
2011-05-08  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Add a crash test for r85964.
        https://bugs.webkit.org/show_bug.cgi?id=59473

        * fast/block/positioning/removing-inside-relpositioned-inline-crash-expected.txt: Added.
        * fast/block/positioning/removing-inside-relpositioned-inline-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-09 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Mon, 9 May 2011 16:29:36 +0000 (16:29 +0000)]
2011-05-09  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Regression(r85869): Restore dirty line logic in RenderInline::destroy.
        https://bugs.webkit.org/show_bug.cgi?id=60448

        Test: fast/inline/inline-destroy-dirty-lines-crash.html

        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::destroy):
2011-05-09  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Tests that we do not when failing to dirty lines while removing
        a inline.
        https://bugs.webkit.org/show_bug.cgi?id=60448

        * fast/inline/inline-destroy-dirty-lines-crash-expected.txt: Added.
        * fast/inline/inline-destroy-dirty-lines-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-09 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 9 May 2011 16:15:39 +0000 (16:15 +0000)]
2011-05-09  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, skip 2 more flaky svg tests failing by one pixel in
        32-bits Debug, see bug 39022.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-09 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 9 May 2011 15:38:12 +0000 (15:38 +0000)]
2011-05-09  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] WidgetGtk setFocus can not access directly the widget in WK2
        https://bugs.webkit.org/show_bug.cgi?id=60016

        Added code to check the situation where we do not have direct
        access to the widget. We use the page to grab the focus which
        would send a request to the UIProcess in WK2.

        * platform/gtk/WidgetGtk.cpp:
        (WebCore::Widget::setFocus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-09 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Mon, 9 May 2011 15:23:01 +0000 (15:23 +0000)]
2011-05-09  Andreas Kling  <andreas.kling@nokia.com>

        Unreviewed. Re-skip two failing inspector tests on Qt.

        They still fail in the bot's environment for whatever reason.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAutomatically touch WebKit.idl whenever any other WebKit1 IDL file changes
aroben@apple.com [Mon, 9 May 2011 15:00:34 +0000 (15:00 +0000)]
Automatically touch WebKit.idl whenever any other WebKit1 IDL file changes

Fixes <http://webkit.org/b/60468> WebKit.idl needs to be manually touched whenever any other
WebKit1 IDL file changes to avoid build errors

Reviewed by Tim Hatcher.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
Updated for script rename.

* JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py: Removed.
* JavaScriptCore.vcproj/JavaScriptCore/work-around-vs-dependency-tracking-bugs.py: Renamed
from react-to-vsprops-changes.py.
(top level): Moved a constant here from main.
(main): Moved most code from here to react_to_vsprops_changes. Added a call to the new
react_to_webkit1_interface_changes function.
(react_to_vsprops_changes): Moved code here from main. Updated to use the
TOP_LEVEL_DIRECTORY global. Moved some code from here to mtime_of_newest_file_matching_globa
and touch_if_older_than.
(react_to_webkit1_interface_changes): Added. Touches WebKit.idl if any other WebKit1 IDL
file has changed.
(mtime_of_newest_file_matching_glob): Added. Code came from main.
(touch_if_older_than): Added. Code came from main.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-09 Leandro Gracia Gil <leandrogracia@chromium.org>
commit-queue@webkit.org [Mon, 9 May 2011 14:58:13 +0000 (14:58 +0000)]
2011-05-09  Leandro Gracia Gil  <leandrogracia@chromium.org>

        Reviewed by Tony Gentilcore.

        Media Stream API: add exception raising to the getUserMedia method.
        https://bugs.webkit.org/show_bug.cgi?id=60387

        Update the expected results for the argument types after the lastest updates
        in the getUserMedia specification. The test has been disabled temporarily
        and will be re-enabled by 60177 since some exceptions are risen after parsing
        the provided options.

        * fast/dom/MediaStream/argument-types-expected.txt:
        * fast/dom/MediaStream/script-tests/argument-types.js:
        (ObjectThrowingException.prototype.toString):
        * platform/chromium/test_expectations.txt:
2011-05-09  Leandro Gracia Gil  <leandrogracia@chromium.org>

        Reviewed by Tony Gentilcore.

        Media Stream API: add exception raising to the getUserMedia method.
        https://bugs.webkit.org/show_bug.cgi?id=60387

        Perform the required changes to support rising exceptions in the
        navigator.getUserMedia method. This is required by the latest changes in the spec:
        http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#dom-navigator-getusermedia

        Test: fast/dom/MediaStream/argument-types.html

        * bindings/js/JSNavigatorCustom.cpp:
        (WebCore::JSNavigator::webkitGetUserMedia):
        * bindings/v8/custom/V8NavigatorCustom.cpp:
        (WebCore::V8Navigator::webkitGetUserMediaCallback):
        * page/Navigator.cpp:
        (WebCore::Navigator::webkitGetUserMedia):
        * page/Navigator.h:
        * page/Navigator.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed Qt 4.8 fix.
ossy@webkit.org [Mon, 9 May 2011 14:13:40 +0000 (14:13 +0000)]
Unreviewed Qt 4.8 fix.

* WebCore.pro: 4.8 bots are updated with the full QRawFont APIs, so we can set HAVE_QRAWFONT now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-09 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Mon, 9 May 2011 14:06:43 +0000 (14:06 +0000)]
2011-05-09  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Benjamin Poulain.

        [Qt] Minor skiplist cleanup.

        Unskip two inspector tests that aren't failing.
        Added explanation for why http/tests/misc/redirect-to-external-url.html is skipped.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows project file fix after r86047
aroben@apple.com [Mon, 9 May 2011 14:06:30 +0000 (14:06 +0000)]
Windows project file fix after r86047

* WebCore.vcproj/WebCore.vcproj: Added missing closing tags.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Mon, 9 May 2011 13:51:44 +0000 (13:51 +0000)]
2011-05-06  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Darin Adler.

        Fix layer names to say "tiled" and show CALayer addresses, not PlatformCALayer addresses
        https://bugs.webkit.org/show_bug.cgi?id=60417

        Layer name now has "Tiled" prepended if it is a TiledLayer. This is true on Mac where
        the layer is a CATiledLayer and on Win where the layer is actually still a CACFLayer
        but implements a tiled layer. I also now print the address of the CALayer or CACFLayer
        instead of the PlatformCALayer everywhere.

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-09 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Mon, 9 May 2011 13:41:55 +0000 (13:41 +0000)]
2011-05-09  Rob Buis  <rbuis@rim.com>

        Reviewed by Dirk Schulze.

        Elements should assert that the QualifiedName given to their constructor corresponds to the Element constructed
        https://bugs.webkit.org/show_bug.cgi?id=22576

        Add tag name ASSERTs in SVG Element constructors.

        No new tests, since no change in behaviour.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-09 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
mahesh.kulkarni@nokia.com [Mon, 9 May 2011 11:22:56 +0000 (11:22 +0000)]
2011-05-09  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] fix fast/dom/Geolocation/window-close-crash.html
        https://bugs.webkit.org/show_bug.cgi?id=60458

        Update all pages with Mock position/error/permission.

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setGeolocationPermission):
        (LayoutTestController::setMockGeolocationError):
        (LayoutTestController::setMockGeolocationPosition):
2011-05-09  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] fix fast/dom/Geolocation/window-close-crash.html
        https://bugs.webkit.org/show_bug.cgi?id=60458

        Unskipping fast/dom/Geolocation/window-close-crash.html.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-09 Srinivasulu Chereddy <srinivasulu.chereddy@nokia.com>
commit-queue@webkit.org [Mon, 9 May 2011 11:17:23 +0000 (11:17 +0000)]
2011-05-09  Srinivasulu Chereddy  <srinivasulu.chereddy@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] one skipped 2d-transforms layout test passes on Qt Linux - skip list to be updated
        https://bugs.webkit.org/show_bug.cgi?id=60399

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-09 Shishir Agrawal <shishir@chromium.org>
commit-queue@webkit.org [Mon, 9 May 2011 11:00:47 +0000 (11:00 +0000)]
2011-05-09  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by Tony Gentilcore.

        Implement Page Visibility API.
        https://bugs.webkit.org/show_bug.cgi?id=54181

        * fast/events/page-visibility-iframe-delete-test-expected.txt: Added.
        * fast/events/page-visibility-iframe-delete-test.html: Added.
        * fast/events/page-visibility-iframe-move-test-expected.txt: Added.
        * fast/events/page-visibility-iframe-move-test.html: Added.
        * fast/events/page-visibility-iframe-propagation-test-expected.txt: Added.
        * fast/events/page-visibility-iframe-propagation-test.html: Added.
        * fast/events/page-visibility-transition-test-expected.txt: Added.
        * fast/events/page-visibility-transition-test.html: Added.
        * fast/events/resources/page-visibility-iframe-delete-test-frame.html: Added.
        * fast/events/resources/page-visibility-iframe-move-new-page.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-05-09  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by Tony Gentilcore.

        Implement Page Visibility API.
        https://bugs.webkit.org/show_bug.cgi?id=54181

        Tests: fast/events/page-visibility-iframe-delete-test.html
               fast/events/page-visibility-iframe-move-test.html
               fast/events/page-visibility-iframe-propagation-test.html
               fast/events/page-visibility-transition-test.html

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/Document.cpp:
        (WebCore::Document::visibilityState):
        (WebCore::Document::webkitVisibilityState):
        (WebCore::Document::webkitIsVisible):
        (WebCore::Document::dispatchVisibilityStateChangeEvent):
        * dom/Document.h:
        * dom/Document.idl:
        * dom/EventNames.h:
        * page/Frame.cpp:
        (WebCore::Frame::dispatchVisibilityStateChangeEvent):
        * page/Frame.h:
        * page/Page.cpp:
        (WebCore::Page::Page):
        (WebCore::Page::setVisibilityState):
        (WebCore::Page::visibilityState):
        * page/Page.h:
        * page/PageVisibilityState.cpp: Added.
        (WebCore::GetPageVisibilityStateString):
        * page/PageVisibilityState.h: Added.
2011-05-09  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by Tony Gentilcore.

        Implement Page Visibility API.
        https://bugs.webkit.org/show_bug.cgi?id=54181

        * WebKit.gyp:
        * public/WebPageVisibilityState.h: Added.
        * public/WebView.h:
        (WebKit::WebView::setVisibilityState):
        * public/WebViewClient.h:
        (WebKit::WebViewClient::visibilityState):
        * src/AssertMatchingEnums.cpp:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):
        (WebKit::WebViewImpl::setVisibilityState):
        * src/WebViewImpl.h:
2011-05-09  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by Tony Gentilcore.

        Implement Page Visibility API.
        https://bugs.webkit.org/show_bug.cgi?id=54181

        * DumpRenderTree/LayoutTestController.cpp:
        (setPageVisibilityCallback):
        (resetPageVisibilityCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        (LayoutTestController::setPageVisibility):
        (LayoutTestController::resetPageVisibility):
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::resetPageVisibility):
        (LayoutTestController::setPageVisibility):
        * DumpRenderTree/chromium/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-09 Venkat Penukonda <venkat.2.penukonda@nokia.com>
commit-queue@webkit.org [Mon, 9 May 2011 10:55:33 +0000 (10:55 +0000)]
2011-05-09  Venkat Penukonda  <venkat.2.penukonda@nokia.com>

        Reviewed by Csaba Osztrogonác.

        [Qt]6 of the skipped canvas layout tests pass on Qt Linux
        https://bugs.webkit.org/show_bug.cgi?id=60382

        * platform/qt/Skipped: Removed passing canvas tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix for WebKit 2 on Qt
benjamin.poulain@nokia.com [Mon, 9 May 2011 10:48:18 +0000 (10:48 +0000)]
Build fix for WebKit 2 on Qt

Reviewed by Andreas Kling.

Qt treats warnings as errors so it does not build with unused variables. This patch removed two unused variable in WebKit 2.

* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::createTiles):
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::~PluginView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-09 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Mon, 9 May 2011 09:19:18 +0000 (09:19 +0000)]
2011-05-09  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Eric Seidel.

        Implement expanding CSS border properties in CSSStyleApplyProperty.
        https://bugs.webkit.org/show_bug.cgi?id=60456

        No new tests added as no functionality changed.

        * css/CSSStyleApplyProperty.cpp:
        (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
        Create CSS border expanding property handlers.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        Remove property handlers that are no longer needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-08 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 9 May 2011 04:37:26 +0000 (04:37 +0000)]
2011-05-08  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r86042.
        http://trac.webkit.org/changeset/86042

        The change contains an incorrect specification.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-08 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 9 May 2011 04:19:01 +0000 (04:19 +0000)]
2011-05-08  MORITA Hajime  <morrita@google.com>

        Unreviewed marking flaky test (insecure-plugin-in-iframe.html)

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 9 May 2011 03:29:42 +0000 (03:29 +0000)]
2011-05-08  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        selectstart event does not fire when selection is made via select all
        https://bugs.webkit.org/show_bug.cgi?id=60376

        Added tests to ensure selectstart event is fired when a user selects all contents
        and script can prevent such selection change in selectstart's event handler.

        * fast/events/selectstart-on-selectall-expected.txt: Added.
        * fast/events/selectstart-on-selectall.html: Added.
        * fast/events/selectstart-prevent-selectall-expected.txt: Added.
        * fast/events/selectstart-prevent-selectall.html: Added.
2011-05-08  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        selectstart event does not fire when selection is made via select all
        https://bugs.webkit.org/show_bug.cgi?id=60376

        Fire selectstart event when a user selects all contents (i.e. document.execCommand('SelectAll')) in
        document, editable region, or text control.

        Tests: editing/selection/selectstart-on-selectall.html
               editing/selection/selectstart-prevent-selectall.html

        * dom/Node.h: Removed canSelectAll and selectAll as they are left over from WMLSelectElement.
        * editing/FrameSelection.cpp:
        (WebCore::FrameSelection::selectAll): Dispatch selectstart event on selectStartTarget, which is
        input element or textarea element when the current selection is inside a shadow DOM, and the root
        editable element if it's inside a non-shadow editable region, and the body element otherwise.
        * html/HTMLSelectElement.h: Made canSelectAll and selectAll public since they are no longer
        declared in Node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-08 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Mon, 9 May 2011 02:16:39 +0000 (02:16 +0000)]
2011-05-08  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Eric Seidel.

        Make RenderStyle::setColumnBreakInside() reject unsupported enum values.
        https://bugs.webkit.org/show_bug.cgi?id=60249

        No new tests added as no functionality changed.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        Remove special-case code and use appropriate macro.
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::setColumnBreakInside):
        Assert that supported values are used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 9 May 2011 00:40:11 +0000 (00:40 +0000)]
2011-05-08  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Extract a DragCaretController from FrameSelection
        https://bugs.webkit.org/show_bug.cgi?id=60273

        Extracted CaretBase and DragCaretController from FrameSelection. CaretBase is a base class for
        DragCaretController and FrameSelection and provides functions to paint caret.

        Since DragCaretController doesn't need to store selection, it only holds one VisiblePosition.

        * WebCore.exp.in:
        * editing/FrameSelection.cpp:
        (WebCore::CaretBase::CaretBase): Added.
        (WebCore::DragCaretController::DragCaretController): Added; Set m_caretVisible true.
        (WebCore::DragCaretController::isContentRichlyEditable): Added.
        (WebCore::FrameSelection::FrameSelection): Several member variables are move to CaretBase.
        (WebCore::DragCaretController::setCaretPosition): Extracted from FrameSelection::setSelection.
        (WebCore::FrameSelection::setSelection): Removed an early exit for DragCaretController.
        (WebCore::clearRenderViewSelection): Extracted from FrameSelection::respondToNodeModification.
        (WebCore::DragCaretController::nodeWillBeRemoved): Extracted from FrameSelection::nodeWillBeRemoved
        and respondToNodeModification. Note that the position DragCaretController holds is equivalent to
        FrameSelection's base or start so when removingNodeRemovesPosition returns true for m_position,
        we used to execute the first if clause and cleared render tree selection and DOM tree selection.
        This is exactly what new DragCaretController::nodeWillBeRemoved does.
        (WebCore::FrameSelection::nodeWillBeRemoved): Simplified early exist conditions.
        (WebCore::FrameSelection::respondToNodeModification): Calls clearRenderViewSelection.
        (WebCore::CaretBase::updateCaretRect): Takes document, caretPosition, selection type, and boolean isOrphaned.
        Note that we can't obtain the document from caretPosition because VisiblePosition can be null even if
        FrameSelection's start was not null.
        (WebCore::caretRendersInsideNode): Moved; Made static local.
        (WebCore::CaretBase::caretRenderer): Extracted from FrameSelection::caretRenderer.
        (WebCore::FrameSelection::caretRenderer): Calls CaretBase::caretRenderer.
        (WebCore::DragCaretController::caretRenderer): Ditto.
        (WebCore::FrameSelection::localCaretRect): Calls updateCaretRect with extra arguments.
        (WebCore::CaretBase::absoluteBoundsForLocalRect): Moved from FrameSelection; Takes Node*.
        (WebCore::CaretBase::caretRepaintRect): Ditto.
        (WebCore::FrameSelection::recomputeCaretRect): Calls absoluteBoundsForLocalRect, caretRepaintRect,
        and shouldRepaintCaret with extra arguments.
        (WebCore::CaretBase::shouldRepaintCaret): Takes a boolean isContentEditable.
        (WebCore::FrameSelection::invalidateCaretRect): Calls CaretBase::invalidateCaretRect.
        (WebCore::CaretBase::invalidateCaretRect): Extracted from FrameSelection::invalidateCaretRect.
        (WebCore::FrameSelection::paintCaret): Calls CaretBase::paintCaret.
        (WebCore::CaretBase::paintCaret): Extracted from FrameSelection::paintCaret.
        (WebCore::FrameSelection::updateAppearance): Removed an assertion that this function is never called for
        DragCaretController.
        (WebCore::DragCaretController::paintDragCaret): Moved from FrameSelection::paintDragCaret.
        * editing/FrameSelection.h:
        (WebCore::CaretBase::localCaretRectForPainting): Added.
        (WebCore::DragCaretController::isContentEditable): Added.
        (WebCore::DragCaretController::hasCaret): Added.
        (WebCore::DragCaretController::caretPosition): Added.
        (WebCore::DragCaretController::clear): Added.
        * page/DragController.cpp:
        (WebCore::DragController::tryDocumentDrag): Uses DragCaretController.
        (WebCore::DragController::dispatchTextInputEventFor): Ditto.
        (WebCore::DragController::concludeEditDrag): Ditto.
        (WebCore::DragController::placeDragCaret): Ditto.
        * page/Page.cpp:
        (WebCore::Page::Page): Instantiates DragCaretController instead of FrameSelection.
        * page/Page.h:
        (WebCore::Page::dragCaretController): Returns DragCaretController* instead of FrameSelection*.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintCaret): Uses FrameSelection and DragCaretController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-08 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Sun, 8 May 2011 21:49:31 +0000 (21:49 +0000)]
2011-05-08  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86037.
        http://trac.webkit.org/changeset/86037
        https://bugs.webkit.org/show_bug.cgi?id=60453

        broke Windows tests (Requested by jessieberlin on #webkit).

        * win/lib/WebKitSystemInterface.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate the WKSI libraries.
jberlin@webkit.org [Sun, 8 May 2011 21:30:17 +0000 (21:30 +0000)]
Update the WKSI libraries.

Rubber-stamped by Alice Liu.

* win/lib/WebKitSystemInterface.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake JSRetainPtr work with JSGlobalContextRefs.
jberlin@webkit.org [Sun, 8 May 2011 20:56:30 +0000 (20:56 +0000)]
Make JSRetainPtr work with JSGlobalContextRefs.
https://bugs.webkit.org/show_bug.cgi?id=60452

Reviewed by Dan Bernstein.

Add specialized functions for JSRetain and JSRelease when dealing with JSGlobalContextRefs.

* API/JSRetainPtr.h:
(JSRetain):
(JSRelease):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-08 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Sun, 8 May 2011 20:24:01 +0000 (20:24 +0000)]
2011-05-08  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        More rebaselines for r86028.

        * platform/chromium-linux/fast/text/basic/002-expected.png:
        * platform/chromium-win/fast/text/basic/002-expected.png:
        * platform/chromium-win/fast/text/basic/002-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-08 Kenji Imasaki <imasaki@chromium.org>
imasaki@chromium.org [Sun, 8 May 2011 20:13:40 +0000 (20:13 +0000)]
2011-05-08  Kenji Imasaki  <imasaki@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] add rebaseline for video-volume-slider for GPU.
        https://bugs.webkit.org/show_bug.cgi?id=60427

        These tests are failing due to text.
        http://code.google.com/p/chromium/issues/detail?id=81482

        * platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
        * platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
        * platform/chromium-gpu-win/media/video-volume-slider-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-08 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Sun, 8 May 2011 19:47:57 +0000 (19:47 +0000)]
2011-05-08  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        More chromium rebaseline for r86028.

        * platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.png:
        * platform/chromium-linux/fast/text/justified-selection-expected.png:
        * platform/chromium-linux/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
        * platform/chromium-linux/fast/text/justify-nbsp-expected.png: Removed.
        * platform/chromium-linux/fast/text/trailing-white-space-2-expected.png:
        * platform/chromium-linux/fast/text/trailing-white-space-expected.png:
        * platform/chromium-mac-leopard/fast/text/justify-nbsp-expected.png: Removed.
        * platform/chromium-mac/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
        * platform/chromium-mac/fast/text/justify-ideograph-leading-expansion-expected.txt:
        * platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
        * platform/chromium-win/css1/box_properties/float_on_text_elements-expected.png:
        * platform/chromium-win/css1/box_properties/float_on_text_elements-expected.txt:
        * platform/chromium-win/fast/text/justified-selection-expected.png:
        * platform/chromium-win/fast/text/justified-selection-expected.txt:
        * platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
        * platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
        * platform/chromium-win/fast/text/justify-nbsp-expected.png: Added.
        * platform/chromium-win/fast/text/trailing-white-space-2-expected.png:
        * platform/chromium-win/fast/text/trailing-white-space-2-expected.txt:
        * platform/chromium-win/fast/text/trailing-white-space-expected.png:
        * platform/chromium-win/fast/text/trailing-white-space-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-08 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Sun, 8 May 2011 18:58:38 +0000 (18:58 +0000)]
2011-05-08  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Chromium Rebaselines for r86028.

        * platform/chromium-linux/css1/box_properties/clear_float-expected.png:
        * platform/chromium-linux/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
        * platform/chromium-linux/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
        * platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
        * platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
        * platform/chromium-linux/css2.1/t1602-c546-txt-align-00-b-expected.png:
        * platform/chromium-linux/fast/multicol/float-avoidance-expected.png:
        * platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png:
        * platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.png:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.png:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.png:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.png:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.png:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.png:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.png:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.png:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.png:
        * platform/chromium-linux/fast/repaint/line-flow-with-floats-9-expected.png:
        * platform/chromium-linux/fast/text/justified-selection-at-edge-expected.png:
        * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-linux/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
        * platform/chromium-linux/tables/mozilla/marvin/x_td_align_justify-expected.png:
        * platform/chromium-linux/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
        * platform/chromium-linux/tables/mozilla/marvin/x_th_align_justify-expected.png:
        * platform/chromium-linux/tables/mozilla/marvin/x_thead_align_justify-expected.png:
        * platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.png:
        * platform/chromium-mac-leopard/css1/box_properties/clear_float-expected.png: Added.
        * platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Added.
        * platform/chromium-mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
        * platform/chromium-mac-leopard/css2.1/t1602-c546-txt-align-00-b-expected.png:
        * platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.png:
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.png:
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.png:
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.png:
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.png:
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.png:
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.png:
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.png:
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.png:
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.png:
        * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.png:
        * platform/chromium-mac-leopard/fast/text/justified-selection-at-edge-expected.png:
        * platform/chromium-mac-leopard/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
        * platform/chromium-mac-leopard/tables/mozilla/marvin/x_td_align_justify-expected.png:
        * platform/chromium-mac-leopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
        * platform/chromium-mac-leopard/tables/mozilla/marvin/x_th_align_justify-expected.png:
        * platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png: Added.
        * platform/chromium-mac-leopard/tables/mozilla/marvin/x_tr_align_justify-expected.png:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.png:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.png:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.png:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.png:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.png:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.png:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.png:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.png:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.png:
        * platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.png:
        * platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-win/css1/box_properties/clear_float-expected.png:
        * platform/chromium-win/css1/box_properties/clear_float-expected.txt:
        * platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
        * platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
        * platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
        * platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
        * platform/chromium-win/css2.1/t1602-c546-txt-align-00-b-expected.png:
        * platform/chromium-win/css2.1/t1602-c546-txt-align-00-b-expected.txt:
        * platform/chromium-win/fast/multicol/float-avoidance-expected.png:
        * platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
        * platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
        * platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.txt:
        * platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
        * platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.txt:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.png:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.txt:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.png:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.txt:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.png:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.txt:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.png:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.txt:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.png:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.txt:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.png:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.txt:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.png:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.txt:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.png:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.txt:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.png:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.txt:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.png:
        * platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.txt:
        * platform/chromium-win/fast/text/justified-selection-at-edge-expected.png:
        * platform/chromium-win/fast/text/justified-selection-at-edge-expected.txt:
        * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
        * platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
        * platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.txt:
        * platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
        * platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.txt:
        * platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
        * platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.png:
        * platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-08 Kamil Blank <k.blank@samsung.com>
commit-queue@webkit.org [Sun, 8 May 2011 18:53:32 +0000 (18:53 +0000)]
2011-05-08  Kamil Blank  <k.blank@samsung.com>

        Reviewed by Antonio Gomes.

        Added new commands to be called by ewk_view_editor_command.
        Due to this change ewk_view_select_* functions have been removed.
        https://bugs.webkit.org/show_bug.cgi?id=60435

        * ewk/ewk_view.cpp:
        (ewk_view_execute_editor_command):
        * ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdated a platform-specific expected result again after r86028.
mitz@apple.com [Sun, 8 May 2011 17:36:41 +0000 (17:36 +0000)]
Updated a platform-specific expected result again after r86028.

* platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdated some platform-specific expected results after r86028.
mitz@apple.com [Sun, 8 May 2011 17:13:18 +0000 (17:13 +0000)]
Updated some platform-specific expected results after r86028.

* platform/gtk/css1/box_properties/clear_float-expected.txt:
* platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
* platform/gtk/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
* platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
* platform/gtk/css2.1/t1602-c546-txt-align-00-b-expected.txt:
* platform/gtk/fast/multicol/float-avoidance-expected.txt:
* platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.txt:
* platform/gtk/fast/repaint/line-flow-with-floats-1-expected.txt:
* platform/gtk/fast/repaint/line-flow-with-floats-10-expected.txt:
* platform/gtk/fast/repaint/line-flow-with-floats-2-expected.txt:
* platform/gtk/fast/repaint/line-flow-with-floats-3-expected.txt:
* platform/gtk/fast/repaint/line-flow-with-floats-4-expected.txt:
* platform/gtk/fast/repaint/line-flow-with-floats-5-expected.txt:
* platform/gtk/fast/repaint/line-flow-with-floats-6-expected.txt:
* platform/gtk/fast/repaint/line-flow-with-floats-7-expected.txt:
* platform/gtk/fast/repaint/line-flow-with-floats-8-expected.txt:
* platform/gtk/fast/repaint/line-flow-with-floats-9-expected.txt:
* platform/gtk/fast/text/justified-selection-at-edge-expected.txt:
* platform/gtk/fast/text/trailing-white-space-2-expected.txt:
* platform/gtk/svg/custom/svg-fonts-in-html-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_td_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
* platform/mac-leopard/fast/text/justify-ideograph-leading-expansion-expected.txt:
* platform/qt/css1/box_properties/clear_float-expected.txt:
* platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
* platform/qt/css1/box_properties/float_on_text_elements-expected.txt:
* platform/qt/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
* platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
* platform/qt/css2.1/t1602-c546-txt-align-00-b-expected.txt:
* platform/qt/fast/multicol/float-avoidance-expected.txt:
* platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt:
* platform/qt/fast/text/justified-selection-at-edge-expected.txt:
* platform/qt/fast/text/justify-nbsp-expected.txt:
* platform/qt/svg/custom/svg-fonts-in-html-expected.txt:
* platform/qt/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
* platform/qt/tables/mozilla/marvin/x_td_align_justify-expected.txt:
* platform/qt/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
* platform/qt/tables/mozilla/marvin/x_th_align_justify-expected.txt:
* platform/qt/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
* platform/qt/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
* platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9401853> REGRESSION (r78846): Insufficient expansion for justificatio...
mitz@apple.com [Sun, 8 May 2011 16:27:31 +0000 (16:27 +0000)]
<rdar://problem/9401853> REGRESSION (r78846): Insufficient expansion for justification when there are multiple inline boxes
https://bugs.webkit.org/show_bug.cgi?id=60432

Reviewed by Darin Adler.

Source/WebCore:

* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::setExpansion): Changed back to take a int, since the m_expansion member
variable is a (truncated) int anyway.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::computeExpansionForJustifiedText): Changed the expansion local variable into an int
so that the right amount is added to the total width. Also changed to use an early return.

LayoutTests:

* fast/text/justify-nbsp-expected.png:
* fast/text/justify-nbsp-expected.txt:
* platform/mac-snowleopard/fast/text/justify-ideograph-leading-expansion-expected.txt:
* platform/mac/css1/box_properties/clear_float-expected.png:
* platform/mac/css1/box_properties/clear_float-expected.txt:
* platform/mac/css1/box_properties/float_on_text_elements-expected.txt:
* platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
* platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
* platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
* platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
* platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.png:
* platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.txt:
* platform/mac/fast/multicol/float-avoidance-expected.png:
* platform/mac/fast/multicol/float-avoidance-expected.txt:
* platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-1-expected.png:
* platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-10-expected.png:
* platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-2-expected.png:
* platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-3-expected.png:
* platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-4-expected.png:
* platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-5-expected.png:
* platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-6-expected.png:
* platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-7-expected.png:
* platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-8-expected.png:
* platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-9-expected.png:
* platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt:
* platform/mac/fast/text/hyphenate-character-expected.png:
* platform/mac/fast/text/hyphenate-character-expected.txt:
* platform/mac/fast/text/hyphens-expected.png:
* platform/mac/fast/text/hyphens-expected.txt:
* platform/mac/fast/text/justified-selection-at-edge-expected.png:
* platform/mac/fast/text/justified-selection-at-edge-expected.txt:
* platform/mac/fast/text/justify-ideograph-leading-expansion-expected.png:
* platform/mac/svg/custom/svg-fonts-in-html-expected.png:
* platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
* platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
* platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.png:
* platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
* platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
* platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.png:
* platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.txt:
* platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.png:
* platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
* platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.png:
* platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-08 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sun, 8 May 2011 16:09:46 +0000 (16:09 +0000)]
2011-05-08  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: ignore 0 responses in the inspector network instrumentation.

        * inspector/front-end/NetworkManager.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-08 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
commit-queue@webkit.org [Sun, 8 May 2011 12:18:53 +0000 (12:18 +0000)]
2011-05-08  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] GraphicsContext3D::getImageData() does not retrieve image data correctly
        https://bugs.webkit.org/show_bug.cgi?id=58556

        Tests: fast/canvas/webgl/gl-teximage.html

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::getImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReverted unintended changes in r86024
mitz@apple.com [Sun, 8 May 2011 06:47:45 +0000 (06:47 +0000)]
Reverted unintended changes in r86024

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9403055> REGRESSION (r85499): Inline images in iChat overflow their...
mitz@apple.com [Sun, 8 May 2011 06:42:20 +0000 (06:42 +0000)]
<rdar://problem/9403055> REGRESSION (r85499): Inline images in iChat overflow their chat bubbles
https://bugs.webkit.org/show_bug.cgi?id=60443

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/replaced/table-percent-height-positioned.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalHeightUsing): Do not apply the logic to prevent precent-height
replaced elements from being squeezed by table cells when the replaced element is positioned (and thus
doesn’t affect the table cell’s height).

LayoutTests:

* fast/replaced/table-percent-height-positioned-expected.png: Added.
* fast/replaced/table-percent-height-positioned-expected.txt: Added.
* fast/replaced/table-percent-height-positioned.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-07 Justin Novosad <junov@chromium.org>
commit-queue@webkit.org [Sun, 8 May 2011 05:20:28 +0000 (05:20 +0000)]
2011-05-07  Justin Novosad  <junov@chromium.org>

        Reviewed by Kenneth Russell.

        [Chromium] Cleanup unexpected test passes in the gpu webkit tests
        https://bugs.webkit.org/show_bug.cgi?id=60393

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9365358> REGRESSION (WebKit2): When clicking in the page, Find overla...
mitz@apple.com [Sun, 8 May 2011 04:42:40 +0000 (04:42 +0000)]
<rdar://problem/9365358> REGRESSION (WebKit2): When clicking in the page, Find overlay fades out instead of disappearing immediately

Reviewed by Timothy Hatcher.

* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::hideFindUI): Do not fade out the overlay.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAvoid copying a header file into the WebKit2 framework wrapper.
mitz@apple.com [Sun, 8 May 2011 04:42:11 +0000 (04:42 +0000)]
Avoid copying a header file into the WebKit2 framework wrapper.

* WebKit2.xcodeproj/project.pbxproj: Corrected the target membership of HTTPCookieAcceptPolicy.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 8 May 2011 02:50:09 +0000 (02:50 +0000)]
2011-05-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Testing EWS spins on patches with a large number of failures
        https://bugs.webkit.org/show_bug.cgi?id=60441

        In cases where the tree has a small number of persistent failures but a
        patch has a large number of failures, we weren't believing any results.
        That lead to us retrying the patch forever while we waited for
        trustworthy results that would never come.

        This patch loosens the semantics of unexpected_failures to return a
        subset (rather than the exact set) of unexpected failures.  In the case
        where the tree has a bounded number of failures and the patch has an
        unbounded number of failures, we can accurately compute such a subset
        and reject the patch.

        * Scripts/webkitpy/tool/bot/expectedfailures.py:
        * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
        * Scripts/webkitpy/tool/bot/patchanalysistask.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Windows WebKit2 Release Tests]
jberlin@webkit.org [Sun, 8 May 2011 01:25:26 +0000 (01:25 +0000)]
[Windows WebKit2 Release Tests]
platform/win/plugins/window-geometry-initialized-before-set-window.html and
platform/win/plugins/window-region-is-set-to-clip-rect.html failing since r85795.
https://bugs.webkit.org/show_bug.cgi?id=60442

Add win-wk2 failing expected results to get the bots green.

* platform/win-wk2/platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt: Added.
* platform/win-wk2/platform/win/plugins/window-region-is-set-to-clip-rect-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Sun, 8 May 2011 01:09:26 +0000 (01:09 +0000)]
2011-05-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86016.
        http://trac.webkit.org/changeset/86016
        https://bugs.webkit.org/show_bug.cgi?id=60445

        caused crashes on the WK2 Windows bots (Requested by
        jessieberlin on #webkit).

        * platform/network/ResourceHandle.h:
        * platform/network/cf/CookieStorageCFNet.cpp:
        (WebCore::currentCookieStorage):
        (WebCore::defaultCookieStorage):
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::willSendRequest):
        (WebCore::makeFinalRequest):
        (WebCore::ResourceHandle::willSendRequest):
        * platform/network/cf/ResourceRequestCFNet.cpp:
        (WebCore::ResourceRequest::doUpdatePlatformRequest):
2011-05-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86016.
        http://trac.webkit.org/changeset/86016
        https://bugs.webkit.org/show_bug.cgi?id=60445

        caused crashes on the WK2 Windows bots (Requested by
        jessieberlin on #webkit).

        * WebView.cpp:
        (WebView::setCacheModel):
2011-05-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86016.
        http://trac.webkit.org/changeset/86016
        https://bugs.webkit.org/show_bug.cgi?id=60445

        caused crashes on the WK2 Windows bots (Requested by
        jessieberlin on #webkit).

        * Shared/WebProcessCreationParameters.cpp:
        (WebKit::WebProcessCreationParameters::encode):
        (WebKit::WebProcessCreationParameters::decode):
        * Shared/WebProcessCreationParameters.h:
        * Shared/win/WebCoreArgumentCodersWin.cpp:
        (CoreIPC::decodeResourceRequest):
        * UIProcess/win/WebContextWin.cpp:
        (WebKit::WebContext::platformInitializeWebProcess):
        * WebProcess/WebPage/win/WebPageWin.cpp:
        (WebKit::cachedResponseForURL):
        * WebProcess/win/WebProcessWin.cpp:
        (WebKit::WebProcess::platformSetCacheModel):
        (WebKit::WebProcess::platformClearResourceCaches):
        (WebKit::WebProcess::platformInitializeWebProcess):
2011-05-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86016.
        http://trac.webkit.org/changeset/86016
        https://bugs.webkit.org/show_bug.cgi?id=60445

        caused crashes on the WK2 Windows bots (Requested by
        jessieberlin on #webkit).

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>
inferno@chromium.org [Sun, 8 May 2011 00:58:25 +0000 (00:58 +0000)]
2011-05-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r85974.
        http://trac.webkit.org/changeset/85974
        https://bugs.webkit.org/show_bug.cgi?id=60444

        broke browser tests (Requested by inferno-sec on #webkit).

        * src/WebURLResponse.cpp:
        (WebKit::WebURLResponse::downloadFilePath):
        (WebKit::WebURLResponse::setDownloadFilePath):
2011-05-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r85974.
        http://trac.webkit.org/changeset/85974
        https://bugs.webkit.org/show_bug.cgi?id=60444

        broke browser tests (Requested by inferno-sec on #webkit).

        * platform/network/chromium/ResourceResponse.cpp:
        (WebCore::ResourceResponse::doPlatformCopyData):
        (WebCore::ResourceResponse::doPlatformAdopt):
        * platform/network/chromium/ResourceResponse.h:
        (WebCore::ResourceResponse::downloadFilePath):
        (WebCore::ResourceResponse::setDownloadFilePath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Windows WebKit2] Use cookies set in WebKit1
jberlin@webkit.org [Sun, 8 May 2011 00:49:26 +0000 (00:49 +0000)]
[Windows WebKit2] Use cookies set in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=60274

Reviewed by Steve Falkenburg.

Source/WebCore:

Share the default storage session between the UI and Web Processes.

* platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::defaultSessionCookieStorage):
Keep track of the default storage session cookie storage.
(WebCore::currentCookieStorage):
Call defaultCookieStorage to get the default cookie storage.
(WebCore::defaultCookieStorage):
If there is a default storage session cookie storage, prefer that over getting the default
cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly
without specifying a storage session will not get the cookie storage being shared by the UI
and Web Processes.

* platform/network/ResourceHandle.h:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).
(WebCore::makeFinalRequest):
Ditto.
(WebCore::ResourceHandle::willSendRequest):
Ditto.
(WebCore::ResourceHandle::currentStorageSession):
If there is a Private Browsing storage session, return that.
If not, on Windows return the default storage session that is being shared with the UI
Process and on Mac return 0.
(WebCore::defaultCFURLStorageSession):
(WebCore::ResourceHandle::setDefaultStorageSession):
(WebCore::ResourceHandle::defaultStorageSession):

* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session (which is not the one shared
with the UI Process).

Source/WebKit/win:

* WebView.cpp:
(WebView::setCacheModel):
Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.

Source/WebKit2:

Share the default storage session between the UI and Web Processes.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
Add a parameter for a serialized default storage session, used only on Windows.

* Shared/win/WebCoreArgumentCodersWin.cpp:
(CoreIPC::decodeResourceRequest):
Make sure to set the current storage session on any requests used by the Web
Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
doing anything with the Web Process's default storage session.

* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
Serialize the default storage session in the UI Process and add it to the
WebProcessCreationParameters.

* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::cachedResponseForURL):
Use the cache associated with the current storage session and make sure the request has the
current storage session set on it before doing anything with it.

* WebProcess/win/WebProcessWin.cpp:
(WebKit::WebProcess::platformSetCacheModel):
Use the default storage session.
(WebKit::WebProcess::platformClearResourceCaches):
Ditto.
(WebKit::WebProcess::platformInitializeWebProcess):
Deserialize the default storage session passed in by the UI Process and hand it to the
ResourceHandle.

WebKitLibraries:

* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
jberlin@webkit.org [Sat, 7 May 2011 23:46:05 +0000 (23:46 +0000)]
WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled

Add another test (fast/events/popup-blocked-from-mousemove.html) to the mac-wk2 Skipped list
to get the bots green.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-07 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sat, 7 May 2011 23:39:54 +0000 (23:39 +0000)]
2011-05-07  Daniel Bates  <dbates@webkit.org>

        Update title of bug in change log entry for changeset <http://trac.webkit.org/changeset/86012>
        so as to be consistent with the name of the bug in <https://bugs.webkit.org/show_bug.cgi?id=60151>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-07 Joe Mason <jmason@rim.com>
commit-queue@webkit.org [Sat, 7 May 2011 23:37:35 +0000 (23:37 +0000)]
2011-05-07  Joe Mason  <jmason@rim.com>

        Reviewed by Daniel Bates.

        FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
        https://bugs.webkit.org/show_bug.cgi?id=52211

        Add willPerformClientRedirect to the user-gesture tests.

        * fast/frames/location-redirect-user-gesture-expected.txt:
        * fast/frames/meta-refresh-user-gesture-expected.txt:
2011-05-07  Joe Mason  <jmason@rim.com>

        Reviewed by Daniel Bates.

        FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
        https://bugs.webkit.org/show_bug.cgi?id=52211

        Create a UserGestureIndicator when calling the clientRedirected callback.

        * loader/NavigationScheduler.cpp:
        (WebCore::ScheduledURLNavigation::didStartTimer):
        (WebCore::ScheduledURLNavigation::didStopTimer):
        (WebCore::ScheduledFormSubmission::didStartTimer):
        (WebCore::ScheduledFormSubmission::didStopTimer):
2011-05-07  Joe Mason  <jmason@rim.com>

        Reviewed by Daniel Bates.

        FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
        https://bugs.webkit.org/show_bug.cgi?id=52211

        Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
2011-05-07  Joe Mason  <jmason@rim.com>

        Reviewed by Daniel Bates.

        FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
        https://bugs.webkit.org/show_bug.cgi?id=52211

        Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
        (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::willPerformClientRedirect):
        (WebViewHost::didStartProvisionalLoad):
        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-07 Tomasz Morawski <t.morawski@samsung.com>
commit-queue@webkit.org [Sat, 7 May 2011 23:34:46 +0000 (23:34 +0000)]
2011-05-07  Tomasz Morawski  <t.morawski@samsung.com>

        Reviewed by Daniel Bates.

        [EFL] Remove ewk_tile_unused_cache_free function form public api
        https://bugs.webkit.org/show_bug.cgi?id=60151

        The ewk_tile_unused_cache_free function should be only called by
        ewk_tile_unused_cache_unref function. Calling this function without
        considering reference counting may lead to fatal results.

        * ewk/ewk_tiled_model.c:
        (_ewk_tile_unused_cache_free):
        (ewk_tile_unused_cache_unref):
        * ewk/ewk_tiled_model.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WebKit2] editing/selection/select-across-readonly-input-{1-5}.html failing since
jberlin@webkit.org [Sat, 7 May 2011 23:34:04 +0000 (23:34 +0000)]
[WebKit2] editing/selection/select-across-readonly-input-{1-5}.html failing since
introduction in r85669.
https://bugs.webkit.org/show_bug.cgi?id=60272

Add expected failing text results to get the bots green.

Note: these tests still need pixel results to be generated both for mac-wk2 and win-wk2.

* platform/mac-wk2/editing/selection: Added.
* platform/mac-wk2/editing/selection/select-across-readonly-input-1-expected.txt: Added.
* platform/mac-wk2/editing/selection/select-across-readonly-input-2-expected.txt: Added.
* platform/mac-wk2/editing/selection/select-across-readonly-input-3-expected.txt: Added.
* platform/mac-wk2/editing/selection/select-across-readonly-input-4-expected.txt: Added.
* platform/mac-wk2/editing/selection/select-across-readonly-input-5-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-07 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sat, 7 May 2011 23:15:05 +0000 (23:15 +0000)]
2011-05-07  Daniel Bates  <dbates@webkit.org>

        Update change log entry for changeset <http://trac.webkit.org/changeset/86009> to
        explain that this was an attempt to fix the build after changeset 86007
        <http://trac.webkit.org/changeset/86007> (bug #60438).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-07 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sat, 7 May 2011 23:08:50 +0000 (23:08 +0000)]
2011-05-07  Daniel Bates  <dbates@webkit.org>

        Remove some more references to isTiger(), which was removed in changeset 86007
        <http://trac.webkit.org/changeset/86007> (bug #60438).

        * Scripts/old-run-webkit-tests:
          - Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and
            file local variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-07 Dawit Alemayehu <adawit@kde.org>
dbates@webkit.org [Sat, 7 May 2011 22:59:09 +0000 (22:59 +0000)]
2011-05-07  Dawit Alemayehu  <adawit@kde.org>

        Reviewed by Daniel Bates.

        Fix compile with GCC 4.6.0
        https://bugs.webkit.org/show_bug.cgi?id=60380

        Remove unused local variable from code.

        * runtime/StringPrototype.cpp:
        (JSC::stringProtoFuncMatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove references to Tiger in scripts
psolanki@apple.com [Sat, 7 May 2011 19:56:39 +0000 (19:56 +0000)]
Remove references to Tiger in scripts
https://bugs.webkit.org/show_bug.cgi?id=60438

Reviewed by Darin Adler.

Remove isTiger() and all of the code that depends on it.

* Scripts/build-webkit:
* Scripts/ensure-valid-python:
* Scripts/gdb-safari:
* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-07 Keith Kyzivat <keith.kyzivat@nokia.com>
commit-queue@webkit.org [Sat, 7 May 2011 14:36:25 +0000 (14:36 +0000)]
2011-05-07  Keith Kyzivat  <keith.kyzivat@nokia.com>

        Reviewed by Adam Roben.

        [Qt] Webkit2 PLUGIN_ARCHITECTURE(UNSUPPORTED) configuration broken by r85961
        https://bugs.webkit.org/show_bug.cgi?id=60420

        * WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:
        (WebKit::NetscapePlugin::platformVisibilityDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash when sending a wheel event to a node with no shadow ancestor node
jonlee@apple.com [Sat, 7 May 2011 07:08:09 +0000 (07:08 +0000)]
Crash when sending a wheel event to a node with no shadow ancestor node
https://bugs.webkit.org/show_bug.cgi?id=60429
<rdar://problem/9389619>

Reviewed by Alice Liu.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):add check to see if the shadow ancestor node of the node that was under the mouse exists before trying to dispatch the wheel event to it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Sat, 7 May 2011 05:49:50 +0000 (05:49 +0000)]
2011-05-06  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Forgot it since my last svg rebaseline r85981.

        * platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Sat, 7 May 2011 05:02:36 +0000 (05:02 +0000)]
2011-05-06  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Chromium rebaselines for r85990

        * platform/chromium-linux/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
        * platform/chromium-mac-leopard/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
        * platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
        * platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
        * platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Sat, 7 May 2011 04:24:09 +0000 (04:24 +0000)]
2011-05-06  Kent Tamura  <tkent@chromium.org>

        Reviewed by Ryosuke Niwa.

        Eliminate WebCore/dom/InputElement.{cpp,h}
        https://bugs.webkit.org/show_bug.cgi?id=60262

        - Fold in all of the code of InputElement.{cpp,h} into HTMLInputElement
          and TextFieldInputType.
        - Change the return type of Node::toInputElement():
          InputElement* -> HTMLInputElement*

        No new tests. This change should not change the existing behaviour.

        * CMakeLists.txt: Remove InpuntElement.cpp and/or InputElement.h.
        * GNUmakefile.list.am: ditto.
        * WebCore.exp.in: Add symbols of functions exposed to WebKit.
        * WebCore.gypi: Remove InpuntElement.cpp and/or InputElement.h.
        * WebCore.pro: ditto.
        * WebCore.vcproj/WebCore.vcproj: ditto.
        * WebCore.xcodeproj/project.pbxproj: ditto.
        * accessibility/AXObjectCache.cpp:
        (WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
          Follow the return type change of Node::toInputElement().
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::isPasswordField): ditto.
        (WebCore::AccessibilityRenderObject::isIndeterminate): ditto.
        (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio): ditto.
        (WebCore::AccessibilityRenderObject::isChecked): ditto.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::canShareStyleWithElement): ditto.
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto.
        * dom/CheckedRadioButtons.cpp:
        (WebCore::CheckedRadioButtons::removeButton): ditto.
        * dom/DOMAllInOne.cpp: Remove InputElement.h.
        * dom/InputElement.cpp: Removed.
        * dom/InputElement.h: Removed.
        * dom/Node.cpp:
        (WebCore::Node::toInputElement):
          Change the return type from InputElement* to HTMLInputElement*.
        * dom/Node.h: ditto.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::HTMLInputElement):
        (WebCore::HTMLInputElement::formControlName):
        (WebCore::HTMLInputElement::tooLong):
        (WebCore::HTMLInputElement::updateFocusAppearance):
        (WebCore::HTMLInputElement::aboutToUnload):
        (WebCore::HTMLInputElement::handleFocusEvent):
        (WebCore::HTMLInputElement::handleBlurEvent):
        (WebCore::HTMLInputElement::updateType):
        (WebCore::HTMLInputElement::parseMappedAttribute):
        (WebCore::HTMLInputElement::size):
        (WebCore::HTMLInputElement::copyNonAttributeProperties):
        (WebCore::HTMLInputElement::value):
        (WebCore::HTMLInputElement::suggestedValue):
        (WebCore::HTMLInputElement::setSuggestedValue):
        (WebCore::HTMLInputElement::setValue):
        (WebCore::HTMLInputElement::setValueFromRenderer):
        (WebCore::HTMLInputElement::setFileListFromRenderer):
        (WebCore::HTMLInputElement::setDefaultName):
        (WebCore::HTMLInputElement::maxLength):
        (WebCore::HTMLInputElement::cacheSelection):
        (WebCore::formatCodes): Moved from InputElement.
        (WebCore::cursorPositionToMaskIndex): ditto.
        (WebCore::HTMLInputElement::isConformToInputMask): ditto.
        (WebCore::HTMLInputElement::validateInputMask): ditto.
        (WebCore::HTMLInputElement::setWapInputFormat): ditto.
        (WebCore::HTMLInputElement::notifyFormStateChanged): ditto.
        (WebCore::HTMLInputElement::parseMaxLengthAttribute): ditto.
        (WebCore::HTMLInputElement::updateValueIfNeeded):ditto.
        * html/HTMLInputElement.h:
          - Add data members which were defined in InputElementData.
          - Make some functions public because the public interface InputElement is removed.
          - Make some functions non-virtual because they don't override
            corresponding virtual functions of InputElement anymore.
        (WebCore::HTMLInputElement::toInputElement):
          Follow the return type change of Node::toInputElement().
        (WebCore::HTMLInputElement::isIndeterminate):
        (WebCore::HTMLInputElement::isAutofilled):
        (WebCore::HTMLInputElement::supportsMaxLength):
        (WebCore::HTMLInputElement::cachedSelectionStart):
        (WebCore::HTMLInputElement::cachedSelectionEnd):
        * html/HTMLTextAreaElement.cpp: Remove unused InputElement.h.
        * html/InputType.cpp:
        (WebCore::InputType::handleBeforeTextInsertedEvent): Remove the code.
        * html/InputType.h: Update for the above.
        * html/TextFieldInputType.cpp:
        (WebCore::replaceEOLAndLimitLength): Moved from InputElement.cpp.
        (WebCore::TextFieldInputType::sanitizeValue): Implement with replaceEOLAndLimitLength().
        (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):
          Move the code from InputElement::handleBeforeTextInsertedEvent().
        * html/TextFieldInputType.h: Update declarations.
        * rendering/RenderTextControlSingleLine.cpp:
          - Remove ASSERT(node()->isHTMLElement()) because it is checked in the constructor.
          - Follow the return type change of inputElement().
        (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
          Make sure node() is an HTMLInputElement instance.
        (WebCore::RenderTextControlSingleLine::addSearchResult):
        (WebCore::RenderTextControlSingleLine::stopSearchEventTimer):
        (WebCore::RenderTextControlSingleLine::showPopup):
        (WebCore::RenderTextControlSingleLine::hidePopup):
        (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
        (WebCore::RenderTextControlSingleLine::updateFromElement):
        (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
        (WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
        (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
        (WebCore::RenderTextControlSingleLine::createInnerSpinButtonStyle):
        (WebCore::RenderTextControlSingleLine::createOuterSpinButtonStyle):
        (WebCore::RenderTextControlSingleLine::createSpeechButtonStyle):
        (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
        (WebCore::RenderTextControlSingleLine::startSearchEventTimer):
        (WebCore::RenderTextControlSingleLine::searchEventTimerFired):
        (WebCore::RenderTextControlSingleLine::valueChanged):
        (WebCore::RenderTextControlSingleLine::setTextFromItem):
        (WebCore::RenderTextControlSingleLine::inputElement):
        * rendering/RenderTextControlSingleLine.h:
          Change the return type of inputElement(): InputElement* -> HTMLInputElement*.
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::isChecked):
          Follow the return type change of Node::toInputElement().
        (WebCore::RenderTheme::isIndeterminate): ditto.
        (WebCore::RenderTheme::shouldHaveSpinButton):
          Change the parameter type: InputElement* -> HTMLInputElement*.
        * rendering/RenderTheme.h: ditto.
2011-05-06  Kent Tamura  <tkent@chromium.org>

        Reviewed by Ryosuke Niwa.

        Eliminate WebCore/dom/InputElement.{cpp,h}
        https://bugs.webkit.org/show_bug.cgi?id=60262

        * src/WebInputElement.cpp:
        (WebKit::WebInputElement::defaultMaxLength):
          Replace InputElement::s_maximumLength with HTMLInputElement::maximumLength.
        (WebKit::toWebInputElement):
          Follow the return type change of Node::toInputElement().
2011-05-06  Kent Tamura  <tkent@chromium.org>

        Reviewed by Ryosuke Niwa.

        Eliminate WebCore/dom/InputElement.{cpp,h}
        https://bugs.webkit.org/show_bug.cgi?id=60262

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::setAutofilled):
          Follow the return type change of Node::toInputElement().
        (DumpRenderTreeSupportGtk::setValueForUser): ditto.
2011-05-06  Kent Tamura  <tkent@chromium.org>

        Reviewed by Ryosuke Niwa.

        Eliminate WebCore/dom/InputElement.{cpp,h}
        https://bugs.webkit.org/show_bug.cgi?id=60262

        * Api/qwebpage.cpp:
        (QWebPage::inputMethodQuery):
          Replace InputElement::s_maximumLength with HTMLInputElement::maximumLength.
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::setAutofilled):
          Follow the return type change of Node::toInputElement().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 7 May 2011 02:13:06 +0000 (02:13 +0000)]
2011-05-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement "Report-Only" mode for CSP
        https://bugs.webkit.org/show_bug.cgi?id=60402

        * http/tests/security/contentSecurityPolicy/report-only-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/report-only.html: Added.
2011-05-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement "Report-Only" mode for CSP
        https://bugs.webkit.org/show_bug.cgi?id=60402

        This mode lets web sites try out CSP by getting violation reports (and
        console spam) without actually changing the behavior of their web sites.

        Test: http/tests/security/contentSecurityPolicy/report-only.html

        * dom/Document.cpp:
        (WebCore::Document::processHttpEquiv):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::didBeginDocument):
        * page/ContentSecurityPolicy.cpp:
        (WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
        (WebCore::ContentSecurityPolicy::didReceiveHeader):
        (WebCore::ContentSecurityPolicy::reportViolation):
        (WebCore::ContentSecurityPolicy::checkInlineAndReportViolation):
        (WebCore::ContentSecurityPolicy::checkEvalAndReportViolation):
        (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation):
        (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
        * page/ContentSecurityPolicy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Kenji Imasaki <imasaki@chromium.org>
imasaki@chromium.org [Sat, 7 May 2011 01:18:49 +0000 (01:18 +0000)]
2011-05-06  Kenji Imasaki  <imasaki@chromium.org>

        Reviewed by David Levin.

        [Chromium] Add rebaseline to chromium for video-layer.
        https://bugs.webkit.org/show_bug.cgi?id=60423

        These expected files are produced by the rebaseline tool.
        http://code.google.com/p/chromium/issues/detail?id=81833

        * platform/chromium-linux/fast/layers/video-layer-expected.png:
        * platform/chromium-mac-leopard/fast/layers/video-layer-expected.png:
        * platform/chromium-mac/fast/layers/video-layer-expected.png:
        * platform/chromium-mac/fast/layers/video-layer-expected.txt:
        * platform/chromium-win/fast/layers/video-layer-expected.png:
        * platform/chromium-win/fast/layers/video-layer-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Sat, 7 May 2011 00:56:11 +0000 (00:56 +0000)]
2011-05-06  Steve Lacey  <sjl@chromium.org>

        Reviewed by David Levin.

        [chromium] Rebaseline needed for media/audio-repaint
        https://bugs.webkit.org/show_bug.cgi?id=60416

        * platform/chromium-linux/media/audio-repaint-expected.png:
        * platform/chromium-mac-leopard/media/audio-repaint-expected.png:
        * platform/chromium-mac-leopard/media/audio-repaint-expected.txt: Removed.
        * platform/chromium-mac/media/audio-repaint-expected.png:
        * platform/chromium-mac/media/audio-repaint-expected.txt:
        * platform/chromium-win/media/audio-repaint-expected.png:
        * platform/chromium-win/media/audio-repaint-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=60421
bdakin@apple.com [Sat, 7 May 2011 00:52:30 +0000 (00:52 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60421
Custom scrollbars nested inside an overlay scrollbar overflow region end up
painting twice
-and corresponding-
<rdar://problem/9389072>

Reviewed by Darin Adler.

Source/WebCore:

Be sure not to paint custom css scrollbars during the special overlay-scrollbar
painting pass.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintOverflowControls):

LayoutTests:

* platform/mac/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
* platform/mac/scrollbars/scrollbars-on-positioned-content-expected.txt: Added.
* scrollbars/scrollbars-on-positioned-content.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Cary Clark <caryclark@google.com>
commit-queue@webkit.org [Sat, 7 May 2011 00:47:24 +0000 (00:47 +0000)]
2011-05-06  Cary Clark  <caryclark@google.com>

        Reviewed by Eric Seidel.

        Add utility for converting SkCanvas to CGContext
        https://bugs.webkit.org/show_bug.cgi?id=59808

        Skia on Mac uses Skia to render WebKit, and CG
        to render UI elements. The CG elements need a
        transcribed graphics context that preserves the
        canvas matrix, and the canvas clip.

        The BitLockerSkia utility class sets up a CGContext
        from the SkCanvas, locks the bitmap's bits, and
        releases the lock when the class goes out of scope.

        Each time the CGContext is retrieved, it is rebuilt.
        This permits the caller to modify the same canvas
        between calls.

        This change adds utilities but does not modify any
        existing code. For now, there are no callers to these
        utilities, so there is no functional change.

        No new tests.

        * platform/graphics/skia/BitLockerSkia.cpp: Added.
        (WebCore::SkMatrixToCGAffineTransform): Conversion utility.
        (WebCore::BitLockerSkia::BitLockerSkia): Takes SkCanvas.
        (WebCore::BitLockerSkia::~BitLockerSkia): Unlocks, cleans up.
        (WebCore::BitLockerSkia::release): Internal private helper.
        (WebCore::BitLockerSkia::cgContext): Returns CGContextRef.
        * platform/graphics/skia/BitLockerSkia.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 David Grogan <dgrogan@chromium.org>
commit-queue@webkit.org [Sat, 7 May 2011 00:11:04 +0000 (00:11 +0000)]
2011-05-06  David Grogan  <dgrogan@chromium.org>

        Reviewed by Eric Seidel.

        update link to message about mac 64bit git binaries
        https://bugs.webkit.org/show_bug.cgi?id=60411

        The original message implied (correctly, at-the-time) that
        http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
        binaries. The new message notes that they do. This might prevent someone
        else from spending a few minutes confused.

        * Scripts/webkitpy/common/checkout/scm/git.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 6 May 2011 23:29:43 +0000 (23:29 +0000)]
2011-05-06  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] [WebKit2] WebView::windowToScreen needs an implementation
        https://bugs.webkit.org/show_bug.cgi?id=55960

        Abstract coordinate system translation code from WebKit into WebCore.
        This will allow the code to be shared between WebKit and WebKit2. The code
        now lives in a new GtkUtilities.cpp helper file.

        * GNUmakefile.list.am: Added GtkUtilities to the source list.
        * platform/gtk/GtkUtilities.cpp: Added.
        (WebCore::convertWidgetRectToScreenRect):
        * platform/gtk/GtkUtilities.h: Added.
2011-05-06  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] [WebKit2] WebView::windowToScreen needs an implementation
        https://bugs.webkit.org/show_bug.cgi?id=55960

        Abstract the code to translate from widget space to screen space into
        a helper method in WebCore.

        * WebCoreSupport/ChromeClientGtk.cpp: Use the new helper method from GtkUtilities.
        (WebKit::ChromeClient::windowToScreen):
        (WebKit::ChromeClient::screenToWindow):
2011-05-06  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] [WebKit2] WebView::windowToScreen needs an implementation
        https://bugs.webkit.org/show_bug.cgi?id=55960

        Add an implementation of PageClient::windowToScreen for GTK+ WebKit2 using
        the newly abstracted widget to screen coordinate translation code in WebCore.

        * UIProcess/API/gtk/PageClientImpl.cpp:
        (WebKit::PageClientImpl::windowToScreen): Added implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 6 May 2011 23:12:56 +0000 (23:12 +0000)]
2011-05-06  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Disable platform/win/plugins/visibility-hidden.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 6 May 2011 23:07:45 +0000 (23:07 +0000)]
2011-05-06  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        Remove some unnecessary static methods in ResourceHandleSoup.

        No new tests. This is only a small cleanup.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::restartedCallback): Call ResourceResponse::updateFromSoupMessage directly.
        (WebCore::gotHeadersCallback):Ditto.
        (WebCore::contentSniffedCallback):Ditto.
        (WebCore::sendRequestCallback):Ditto.
        (WebCore::ResourceHandle::defaultSession): Create the soup session directly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 6 May 2011 23:06:02 +0000 (23:06 +0000)]
2011-05-06  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [Soup] ResourceHandles are leaked on 304 responses
        https://bugs.webkit.org/show_bug.cgi?id=60413

        Always call cleanupSoupRequestOperation, even when the request was not
        canceled. Before the code would call didFinishLoading and then never clean up
        the request.

        No new tests. This simply fixes a memory leak.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::sendRequestCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 6 May 2011 22:50:44 +0000 (22:50 +0000)]
2011-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Simplify the PluginInfoStore interface
        https://bugs.webkit.org/show_bug.cgi?id=60406

        Just expose a single API for getting a list of plug-ins from the info store,
        PluginInfoStore::plugins and remove PluginInfoStore::getPlugins and PluginInfoStore::getPluginPaths.

        Also, change the WebContext::pluginInfoStore() getter to return a reference.

        * UIProcess/Plugins/PluginInfoStore.cpp:
        (WebKit::PluginInfoStore::plugins):
        * UIProcess/Plugins/PluginInfoStore.h:
        * UIProcess/Plugins/PluginProcessManager.cpp:
        (WebKit::PluginProcessManager::getPluginProcessConnection):
        * UIProcess/Plugins/PluginProcessManager.h:
        * UIProcess/Plugins/WebPluginSiteDataManager.cpp:
        (WebKit::WebPluginSiteDataManager::GetSitesWithDataState::GetSitesWithDataState):
        (WebKit::WebPluginSiteDataManager::ClearSiteDataState::ClearSiteDataState):
        (WebKit::WebPluginSiteDataManager::getSitesWithData):
        (WebKit::WebPluginSiteDataManager::clearSiteData):
        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::getPlugins):
        (WebKit::WebContext::getPluginPath):
        * UIProcess/WebContext.h:
        (WebKit::WebContext::pluginInfoStore):
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::canShowMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 6 May 2011 22:38:43 +0000 (22:38 +0000)]
2011-05-06  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: crashes in race with crashing DRT
        https://bugs.webkit.org/show_bug.cgi?id=60238

        This fixes a race where if we wrote the URL to DRT and
        DRT crashed immediately, we could get a broken pipe
        error back during the write() and not handle it correctly,
        causing NRWT to also crash.

        * Scripts/webkitpy/layout_tests/port/server_process.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 6 May 2011 22:16:37 +0000 (22:16 +0000)]
2011-05-06  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Rebaselines for r85926.
        https://bugs.webkit.org/show_bug.cgi?id=60356

        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/chromium-linux/svg/batik/filters/feTile-expected.png:
        * platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
        * platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
        * platform/chromium-linux/svg/filters/filter-on-tspan-expected.png:
        * platform/chromium-linux/svg/filters/filterRes-expected.png: Added.
        * platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png:
        * platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png:
        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Added.
        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/chromium-mac-leopard/svg/batik/filters: Added.
        * platform/chromium-mac-leopard/svg/batik/filters/feTile-expected.png: Added.
        * platform/chromium-mac-leopard/svg/batik/filters/filterRegions-expected.png: Added.
        * platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png:
        * platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png:
        * platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png:
        * platform/chromium-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
        * platform/chromium-mac-leopard/svg/filters/feGaussianBlur-expected.png: Added.
        * platform/chromium-mac-leopard/svg/filters/feOffset-expected.png:
        * platform/chromium-mac-leopard/svg/filters/feTile-expected.png: Added.
        * platform/chromium-mac-leopard/svg/filters/filter-on-tspan-expected.png: Added.
        * platform/chromium-mac-leopard/svg/filters/filter-rounding-issues-expected.png: Added.
        * platform/chromium-mac-leopard/svg/filters/filterRes-expected.png:
        * platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/chromium-mac/svg/batik/filters/feTile-expected.png: Added.
        * platform/chromium-mac/svg/batik/filters/filterRegions-expected.png: Added.
        * platform/chromium-mac/svg/batik/text/textFeatures-expected.png: Added.
        * platform/chromium-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
        * platform/chromium-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
        * platform/chromium-mac/svg/custom/feComponentTransfer-Linear-expected.png:
        * platform/chromium-mac/svg/custom/feComponentTransfer-Table-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
        * platform/chromium-mac/svg/filters/feGaussianBlur-expected.png: Added.
        * platform/chromium-mac/svg/filters/feOffset-expected.png: Added.
        * platform/chromium-mac/svg/filters/feTile-expected.png: Added.
        * platform/chromium-mac/svg/filters/filter-on-tspan-expected.png: Added.
        * platform/chromium-mac/svg/filters/filter-rounding-issues-expected.png: Added.
        * platform/chromium-mac/svg/filters/filterRes-expected.png: Added.
        * platform/chromium-mac/svg/filters/filterRes1-expected.png: Added.
        * platform/chromium-mac/svg/filters/filterRes3-expected.png: Added.
        * platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.png: Added.
        * platform/chromium-mac/svg/filters/subRegion-one-effect-expected.png: Added.
        * platform/chromium-mac/svg/filters/subRegion-two-effects-expected.png: Added.
        * platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/chromium-win/svg/batik/filters/feTile-expected.png:
        * platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
        * platform/chromium-win/svg/batik/text/textFeatures-expected.png:
        * platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
        * platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
        * platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
        * platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
        * platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
        * platform/chromium-win/svg/filters/feOffset-expected.png:
        * platform/chromium-win/svg/filters/feTile-expected.png:
        * platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
        * platform/chromium-win/svg/filters/filter-rounding-issues-expected.png:
        * platform/chromium-win/svg/filters/filterRes-expected.png: Added.
        * platform/chromium-win/svg/filters/filterRes1-expected.png:
        * platform/chromium-win/svg/filters/filterRes3-expected.png:
        * platform/chromium-win/svg/filters/parent-children-with-same-filter-expected.png:
        * platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
        * platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
andersca@apple.com [Fri, 6 May 2011 22:08:33 +0000 (22:08 +0000)]
Windows build fix.

* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::PluginInfoStore::shouldUsePlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 6 May 2011 21:52:12 +0000 (21:52 +0000)]
2011-05-06  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Chromium Rebaselines for r85964, r85971 and r85967.

        * platform/chromium-linux/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
        * platform/chromium-linux/fast/forms/date-input-visible-strings-expected.png: Added.
        * platform/chromium-linux/fast/inline/nested-top-alignment-expected.png: Added.
        * platform/chromium-mac-leopard/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
        * platform/chromium-mac-leopard/fast/forms/date-input-visible-strings-expected.png: Added.
        * platform/chromium-mac-leopard/fast/inline/nested-top-alignment-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.
        * platform/chromium-win/fast/forms/date-input-visible-strings-expected.png: Added.
        * platform/chromium-win/fast/forms/date-input-visible-strings-expected.txt: Added.
        * platform/chromium-win/fast/inline/nested-top-alignment-expected.png: Added.
        * platform/chromium-win/fast/inline/nested-top-alignment-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 6 May 2011 21:17:42 +0000 (21:17 +0000)]
2011-05-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Make more PluginInfoStore member functions static
        https://bugs.webkit.org/show_bug.cgi?id=60401

        This is a first step towards making PluginInfoStore thread safe.

        * UIProcess/Plugins/PluginInfoStore.cpp:
        (WebKit::PluginInfoStore::loadPluginsIfNecessary):
        (WebKit::PluginInfoStore::loadPlugin):
        * UIProcess/Plugins/PluginInfoStore.h:
        * UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
        (WebKit::PluginInfoStore::shouldUsePlugin):
        * UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:
        (WebKit::PluginInfoStore::shouldUsePlugin):
        * UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
        (WebKit::PluginInfoStore::shouldUsePlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Fri, 6 May 2011 21:12:58 +0000 (21:12 +0000)]
2011-05-06  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Adam Barth.

        [Chromium] Whitelist input events interpreted as user gestures
        https://bugs.webkit.org/show_bug.cgi?id=60213

        * fast/events/popup-blocked-from-mousemove-expected.txt: Added.
        * fast/events/popup-blocked-from-mousemove.html: Added.
2011-05-06  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Adam Barth.

        [Chromium] Whitelist input events interpreted as user gestures
        https://bugs.webkit.org/show_bug.cgi?id=60213

        * public/WebInputEvent.h:
        (WebKit::WebInputEvent::isUserGestureEventType):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::handleInputEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 6 May 2011 21:06:32 +0000 (21:06 +0000)]
2011-05-06  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Fix error due to duplicate entry.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 6 May 2011 21:03:57 +0000 (21:03 +0000)]
2011-05-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add disable-javascript-urls CSP directive
        https://bugs.webkit.org/show_bug.cgi?id=60301

        * http/tests/security/contentSecurityPolicy/javascript-urls-blocked-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html: Added.
2011-05-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add disable-javascript-urls CSP directive
        https://bugs.webkit.org/show_bug.cgi?id=60301

        This CSP directive is not in the CSP spec.  This patch is somewhat of
        an experiment to see whether this feature is useful.  Based on our
        implementation experience, we will coordinate with folks via the W3C to
        see if this makes sense to add to the spec.

        Test: http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html

        * page/ContentSecurityPolicy.cpp:
        (WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
        (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
        (WebCore::ContentSecurityPolicy::addDirective):
        * page/ContentSecurityPolicy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Brett Wilson <brettw@chromium.org>
brettw@chromium.org [Fri, 6 May 2011 20:52:53 +0000 (20:52 +0000)]
2011-05-06  Brett Wilson  <brettw@chromium.org>

        Reviewed by Adam Barth.

        Use a File object to store the downloaded file reference rather than
        just the path. This keeps the file and permissions in scope (using the
        already-existing blob system) so the browser won't delete the file
        when the load is complete. Instead, the file will be cleaned up when
        the request objects are deleted.
        https://bugs.webkit.org/show_bug.cgi?id=60281

        * platform/network/chromium/ResourceResponse.cpp:
        (WebCore::ResourceResponse::doPlatformCopyData):
        (WebCore::ResourceResponse::doPlatformAdopt):
        * platform/network/chromium/ResourceResponse.h:
        (WebCore::ResourceResponse::downloadedFile):
        (WebCore::ResourceResponse::setDownloadedFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Fri, 6 May 2011 20:29:58 +0000 (20:29 +0000)]
2011-05-06  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Darin Adler.

        Fix two warnings of unused variables.
        https://bugs.webkit.org/show_bug.cgi?id=60370

        Remove two unused local variable from the code.

        No new tests, the existing ones should cover.

        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutVerticalBox):
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::SVGSMILElement::calculateNextProgressTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 6 May 2011 20:13:43 +0000 (20:13 +0000)]
2011-05-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Wire up CSP's eval blocking to V8's new API
        https://bugs.webkit.org/show_bug.cgi?id=60384

        * platform/chromium/http/tests/security/contentSecurityPolicy/eval-blocked-expected.txt: Added.
            - Boo different error messages.
        * platform/chromium/test_expectations.txt:
            - Test progression.
2011-05-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Wire up CSP's eval blocking to V8's new API
        https://bugs.webkit.org/show_bug.cgi?id=60384

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::disableEval):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
hyatt@apple.com [Fri, 6 May 2011 20:07:38 +0000 (20:07 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
REGRESSION (r81684?): cox.com sign in button is missing

Reviewed by Dan Bernstein.

Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
This restores the original behavior before the refactoring messed it up.

Source/WebCore:

Added fast/inline/nested-top-alignment.html

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights):

LayoutTests:

* fast/inline/nested-top-alignment.html: Added.
* platform/mac/fast/inline/nested-top-alignment-expected.png: Added.
* platform/mac/fast/inline/nested-top-alignment-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 6 May 2011 19:22:25 +0000 (19:22 +0000)]
2011-05-06  Adrienne Walker  <enne@google.com>

        [chromium] Unreviewed, rebaseline changes after r85959
        https://bugs.webkit.org/show_bug.cgi?id=59020

        * platform/chromium-gpu-mac/compositing/flat-with-transformed-child-expected.png: Added.
        * platform/chromium-gpu-win/compositing/flat-with-transformed-child-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 6 May 2011 19:17:01 +0000 (19:17 +0000)]
2011-05-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add a --skip-integrationtests mode to test-webkitpy
        https://bugs.webkit.org/show_bug.cgi?id=60354

        These two test suites account for 2/3 of test-webkitpy's running time
        because they're not actually unit tests.  They're integration tests.
        This patch adds the ability to skip integration tests by passing a
        command line argument to test-webkitpy.  The buildbots will continue to
        run these integration tests to make sure they don't regress.  This
        option is for use by developers when working on parts of the code that
        are well-covered by unit tests.

        * Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
        * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
        * Scripts/webkitpy/test/main.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 6 May 2011 19:14:43 +0000 (19:14 +0000)]
2011-05-06  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        [results.html] label the zoomed pixel containers (expected, actual, diff)
        https://bugs.webkit.org/show_bug.cgi?id=60383

        * fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Fri, 6 May 2011 19:10:53 +0000 (19:10 +0000)]
2011-05-06  Joseph Pecoraro  <joepeck@webkit.org>

        Unreviewed. Add pixel results for mac.

        * platform/mac/fast/forms/date-input-visible-strings-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Fri, 6 May 2011 19:09:31 +0000 (19:09 +0000)]
2011-05-06  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by James Robinson.

        [chromium]: Reland using WebPermissionClient for checking indexed db usage
        https://bugs.webkit.org/show_bug.cgi?id=60386

        * public/WebPermissionClient.h:
        (WebKit::WebPermissionClient::allowIndexedDB):
        * src/IDBFactoryBackendProxy.cpp:
        (WebKit::IDBFactoryBackendProxy::open):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Fri, 6 May 2011 19:05:58 +0000 (19:05 +0000)]
2011-05-06  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Add baselines to chromium for video-source-error that reflect the fact that
        chromium does not support mp4.

        [chromium] Rebaseline needed for video-source-error
        https://bugs.webkit.org/show_bug.cgi?id=60292

        * platform/chromium/media/video-source-error-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=60390 (<rdar://problem/9364449>)
hyatt@apple.com [Fri, 6 May 2011 18:50:08 +0000 (18:50 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60390 (<rdar://problem/9364449>)
REGRESSION (r81992): portions of ticketmaster site render blank

Reviewed by Dan Bernstein.

Make simplified layout skip from a positioned object out to its containing block.  There is no
need to dirty the intermediate inlines, and in this case it's actively harmful, since the
block responsible for the layout of the positioned object doesn't get m_posChildNeedsLayout set.

Source/WebCore:

Added fast/block/positioning/hiding-inside-relpositioned-inline.html

* rendering/RenderObject.h:
(WebCore::RenderObject::markContainingBlocksForLayout):

LayoutTests:

* fast/block/positioning/hiding-inside-relpositioned-inline.html: Added.
* platform/mac/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
* platform/mac/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 6 May 2011 18:49:17 +0000 (18:49 +0000)]
2011-05-06  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: move selection test into the text area branch.

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype._contextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac build fix
aroben@apple.com [Fri, 6 May 2011 18:48:03 +0000 (18:48 +0000)]
Mac build fix

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: Added a
missing #import.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoShow/hide windowed plugins according to the plugin element's visibility CSS property
aroben@apple.com [Fri, 6 May 2011 18:41:32 +0000 (18:41 +0000)]
Show/hide windowed plugins according to the plugin element's visibility CSS property

Fixes <http://webkit.org/b/60285> <rdar://problem/9152400> REGRESSION (WebKit2): A white
rectangle covers up important UI elements when composing a new message at mail.yahoo.com
with BrowserPlus! plug-in installed

Reviewed by Anders Carlsson.

Source/WebKit2:

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::isPluginVisible):
* PluginProcess/PluginControllerProxy.h:
Stubbed out.

* Shared/win/WindowGeometry.cpp:
(WebKit::WindowGeometry::WindowGeometry):
(WebKit::WindowGeometry::encode):
(WebKit::WindowGeometry::decode):
* Shared/win/WindowGeometry.h:
Added visible member.

* UIProcess/win/WebView.cpp:
(WebKit::WebView::updateChildWindowGeometries): Show or hide the window as specified in the
geometry.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::visibilityDidChange):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
Added. Calls through to platform-specific code.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformVisibilityDidChange):
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformVisibilityDidChange):
Stubbed out.

* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::platformGeometryDidChange): Moved most logic from here to
scheduleWindowedGeometryUpdate.
(WebKit::NetscapePlugin::platformVisibilityDidChange): Added. Calls through to
scheduleWindowedGeometryUpdate.
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate): Added. Code came from
platformGeometryDidChange. Now also records whether the plugin element is visible.

* WebProcess/Plugins/Plugin.h: Added visibilityDidChange.

* WebProcess/Plugins/PluginController.h: Added isPluginVisible.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::visibilityDidChange):
* WebProcess/Plugins/PluginProxy.h:
Stubbed out.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::show):
(WebKit::PluginView::hide):
Added. These Widget overrides were based on WebCore's PluginView class.

(WebKit::PluginView::viewVisibilityDidChange): Added. Similar to viewGeometryDidChange.
Calls down to the plugin if it's been initialized.
(WebKit::PluginView::isPluginVisible): Added. Just calls up to the Widget base class.

* WebProcess/Plugins/PluginView.h: Updated for PluginController changes.

LayoutTests:

Add a test that shows that windowed plugins with visibility:hidden do not appear on screen

I could only figure out how to make this a pixel test. Note that the pixel test doesn't pass
in WebKit2 due to <http://webkit.org/b/58050>, but I verified it works correctly in
MiniBrowser.

* platform/win/plugins/visibility-hidden-expected.png: Added.
* platform/win/plugins/visibility-hidden-expected.txt: Added.
* platform/win/plugins/visibility-hidden.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 6 May 2011 18:35:21 +0000 (18:35 +0000)]
2011-05-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        The results.zip generated by the Chromium EWS are too big
        https://bugs.webkit.org/show_bug.cgi?id=60352

        Currently results.zip created by the Chromium EWS bot contain roughly
        1000 tests that we expect to fail.  These test results are not helpful
        to contributors.

        There are several approaches to solving this problem:

        1) We could be more selective about which files to include in the zip.
        2) We could ask new-run-webkit-tests not to generate results for
           expected failures.
        3) We could ask new-run-webkit-tests not to run tests that we expect to
           fail.

        This patch takes approach (3).  Currently, we're ignoring the outcome
        of failing tests anyway, so there's not much point in actually running
        them.  As a side benefit, this will speed up the test run by about 6%.
        In the future, we might revisit this decision and choose another
        approach.

        * Scripts/webkitpy/common/config/ports.py:
        * Scripts/webkitpy/common/config/ports_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 6 May 2011 17:41:46 +0000 (17:41 +0000)]
2011-05-04  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Fix incorrect scissor rect for layers that render into a rendersurface
        https://bugs.webkit.org/show_bug.cgi?id=59020

        * compositing/flat-with-transformed-child-expected.txt: Added.
        * compositing/flat-with-transformed-child.html: Added.
        * platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.checksum: Added.
        * platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Added.
        * platform/chromium/test_expectations.txt:
2011-05-04  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Fix incorrect scissor rect for layers that render into a rendersurface
        https://bugs.webkit.org/show_bug.cgi?id=59020

        Allow for empty scissor rects, which implies scissoring to the render
        surface. The previous code and previous patch on this bug both didn't
        take into account that the scissor rect should be the render surface
        and not the projection of the layer itself, because child layers
        aren't necessarily contained within the bounds of their superlayer.

        Test: compositing/flat-with-transformed-child.html

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::paintLayerContents):
        (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
        (WebCore::LayerRendererChromium::drawLayer):
        (WebCore::LayerRendererChromium::setScissorToRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a WindowGeometry struct for use in the ScheduleChildWindowGeometryUpdate message
aroben@apple.com [Fri, 6 May 2011 17:30:10 +0000 (17:30 +0000)]
Add a WindowGeometry struct for use in the ScheduleChildWindowGeometryUpdate message

This will make it easier to add more info to this message in the future (like whether the
window is visible).

Fixes <http://webkit.org/b/60374> Adding parameters to ScheduleChildWindowGeometryUpdate
message is tedious

Reviewed by Anders Carlsson.

* Scripts/webkit2/messages.py:
(struct_or_class): Added WindowGeometry to the list of structs.

* Shared/win/WindowGeometry.cpp: Added.
* Shared/win/WindowGeometry.h: Added.

* win/WebKit2.vcproj: Added new files.

* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/win/WebPageProxyWin.cpp:
(WebKit::WebPageProxy::scheduleChildWindowGeometryUpdate):
* UIProcess/win/WebView.cpp:
(WebKit::WebView::scheduleChildWindowGeometryUpdate):
(WebKit::WebView::updateChildWindowGeometries):
* UIProcess/win/WebView.h:
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::platformGeometryDidChange):
* WebProcess/Plugins/PluginController.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::scheduleWindowedPluginGeometryUpdate):
* WebProcess/Plugins/PluginView.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::scheduleChildWindowGeometryUpdate):
Changed to use WindowGeometry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 6 May 2011 17:22:52 +0000 (17:22 +0000)]
2011-05-05  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Mihai Parparita.

        [results.html] zoomed pixel results should not be antialiased
        https://bugs.webkit.org/show_bug.cgi?id=60330

        -Use canvas instead of CSS zoom.
        -Only zoom the part of the image we need to show.
        -Make pixel zooming mostly work in Firefox.
        -Increase the zoom from 3x to 6x.

        * fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unused GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings
ddkilzer@apple.com [Fri, 6 May 2011 17:22:32 +0000 (17:22 +0000)]
Remove unused GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings

Reviewed by Jon Honeycutt.

This fixes an Xcode 4 warning about using obsolete settings.

Source/JavaScriptGlue:

* JavaScriptGlue.xcodeproj/project.pbxproj: Removed
GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings.

Source/WebKit2:

* WebKit2.xcodeproj/project.pbxproj: Removed
GCC_ENABLE_FIX_AND_CONTINUE and ZERO_LINK settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 6 May 2011 17:12:48 +0000 (17:12 +0000)]
2011-05-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        Lazily allocate ScrollAnimator in ScrollableArea
        https://bugs.webkit.org/show_bug.cgi?id=60327

        Avoid allocating the ScrollAnimator up-front, because we
        create lots of ScrollableAreas via RenderLayer, and we should
        only need the animator when scrolling.

        * platform/ScrollableArea.cpp:
        (WebCore::ScrollableArea::ScrollableArea):
        (WebCore::ScrollableArea::scrollAnimator):
        (WebCore::ScrollableArea::scroll):
        (WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):
        (WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation):
        (WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation):
        (WebCore::ScrollableArea::handleWheelEvent):
        (WebCore::ScrollableArea::handleGestureEvent):
        * platform/ScrollableArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85955 268f45cc-cd09-0410-ab3c-d52691b4dbfc