git://git.webkit.org / WebKit-https.git / log
? search:
summary | shortlog | log | commit | commitdiff | tree
first ⋅ prev ⋅ next
WebKit-https.git
16 years ago Reviewed by Anders.
commit | commitdiff | tree
ap [Wed, 21 Jun 2006 16:21:19 +0000 (16:21 +0000)]
    Reviewed by Anders.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9516
          Would like a script to run a httpd server with the same configuration as run-webkit-tests http

        * Scripts/run-webkit-httpd: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-06-21 Joost de Valk <jdevalk@opendarwin.org>
commit | commitdiff | tree
andersca [Wed, 21 Jun 2006 15:27:57 +0000 (15:27 +0000)]
2006-06-21  Joost de Valk  <jdevalk@opendarwin.org>

        Reviewed and landed by Anders.

        * blog/wp-content/themes/webkit/sidebar.php:
         Add link to Wiki in the navigation menu here too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-06-21 Joost de Valk <jdevalk@opendarwin.org>
commit | commitdiff | tree
andersca [Wed, 21 Jun 2006 13:50:46 +0000 (13:50 +0000)]
2006-06-21  Joost de Valk  <jdevalk@opendarwin.org>

        Reviewed and landed by Anders.

        * nav.inc: Add link to Wiki in the navigation menu.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-06-21 Anders Carlsson <acarlsson@apple.com>
commit | commitdiff | tree
andersca [Wed, 21 Jun 2006 13:24:51 +0000 (13:24 +0000)]
2006-06-21  Anders Carlsson  <acarlsson@apple.com>

        Move FrameWin::shouldInterruptJavaScript to TemporaryLinkStubs.cpp

        * bridge/win/FrameWin.cpp:
        * platform/win/TemporaryLinkStubs.cpp:
        (FrameWin::shouldInterruptJavaScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
commit | commitdiff | tree
adele [Wed, 21 Jun 2006 08:40:32 +0000 (08:40 +0000)]
    Reviewed by Maciej.

        Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=9523
        More Win32 build bustage.

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * bridge/win/FrameWin.cpp:
        (WebCore::FrameWin::shouldInterruptJavaScript):
        * bridge/win/FrameWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
commit | commitdiff | tree
thatcher [Wed, 21 Jun 2006 07:45:15 +0000 (07:45 +0000)]
    Reviewed by Eric.

        Builds Drosera and a launcher to include with the nightly.

        * BuildSlaveSupport/build-launcher-app:
        * BuildSlaveSupport/build-launcher-dmg:
        * Drosera/Drosera.xcodeproj/project.pbxproj:
        * Drosera/Info.plist:
        * Drosera/LauncherInfo.plist: Added.
        * Drosera/launcher.m: Added.
        (displayErrorAndQuit):
        (checkMacOSXVersion):
        (myExecve):
        (main):
        * Scripts/build-drosera
        * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
        * WebKitLauncher/main.m:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago No review - updated results for earlier patch.
commit | commitdiff | tree
mjs [Wed, 21 Jun 2006 07:27:58 +0000 (07:27 +0000)]
    No review - updated results for earlier patch.

        - updated SVG test results where my recent fix affected bounding boxes

        I think the new results are more accurate bounding boxes and in
        any case there is no actual difference in rendered output.

        * svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
        * svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
        * svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
        * svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
        * svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
        * svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
        * svg/custom/foreign-object-skew-expected.txt:
        * svg/custom/image-with-transform-clip-filter-expected.txt:
        * svg/custom/text-image-opacity-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoUpdated results for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
commit | commitdiff | tree
adele [Wed, 21 Jun 2006 07:27:24 +0000 (07:27 +0000)]
Updated results for: bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoUpdated results for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
commit | commitdiff | tree
adele [Wed, 21 Jun 2006 07:26:17 +0000 (07:26 +0000)]
Updated results for: bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Anders.
commit | commitdiff | tree
adele [Wed, 21 Jun 2006 07:23:47 +0000 (07:23 +0000)]
    Reviewed by Anders.

        Updated results for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
        Switch to use new text field implementation for <textarea>

        Changes include some size differences since the new textareas have 4 pixels less horizontal padding,
        and the renderer name for textareas has changed from RenderTextArea to RenderTextField.

        * dom/html/level2/html/HTMLTextAreaElement14-expected.txt:
        * dom/html/level2/html/HTMLTextAreaElement15-expected.txt:
        * dom/xhtml/level2/html/HTMLTextAreaElement14-expected.txt:
        * dom/xhtml/level2/html/HTMLTextAreaElement15-expected.txt:
        * fast/block/margin-collapse/103-expected.checksum:
        * fast/block/margin-collapse/103-expected.png:
        * fast/block/margin-collapse/103-expected.txt:
        * fast/dynamic/008-expected.checksum:
        * fast/dynamic/008-expected.png:
        * fast/dynamic/008-expected.txt:
        * fast/forms/001-expected.checksum:
        * fast/forms/002-expected.checksum:
        * fast/forms/003-expected.checksum:
        * fast/forms/004-expected.checksum:
        * fast/forms/005-expected.checksum:
        * fast/forms/006-expected.checksum:
        * fast/forms/007-expected.checksum:
        * fast/forms/8250-expected.checksum:
        * fast/forms/blankbuttons-expected.checksum:
        * fast/forms/button-cannot-be-nested-expected.checksum:
        * fast/forms/button-default-title-expected.checksum:
        * fast/forms/button-inner-block-reuse-expected.checksum:
        * fast/forms/button-positioned-expected.checksum:
        * fast/forms/button-sizes-expected.checksum:
        * fast/forms/button-table-styles-expected.checksum:
        * fast/forms/button-white-space-expected.checksum:
        * fast/forms/checkbox-radio-onchange-expected.checksum:
        * fast/forms/cursor-position-expected.txt:
        * fast/forms/double-focus-expected.txt:
        * fast/forms/file-input-disabled-expected.checksum:
        * fast/forms/form-element-geometry-expected.checksum:
        * fast/forms/form-element-geometry-expected.png:
        * fast/forms/form-element-geometry-expected.txt:
        * fast/forms/form-hides-table-expected.checksum:
        * fast/forms/formmove-expected.checksum:
        * fast/forms/formmove2-expected.checksum:
        * fast/forms/formmove3-expected.checksum:
        * fast/forms/indeterminate-expected.checksum:
        * fast/forms/input-appearance-bkcolor-expected.checksum:
        * fast/forms/input-appearance-default-bkcolor-expected.checksum:
        * fast/forms/input-appearance-disabled-expected.checksum:
        * fast/forms/input-appearance-focus-expected.checksum:
        * fast/forms/input-appearance-minWidth-expected.checksum:
        * fast/forms/input-appearance-preventDefault-expected.checksum:
        * fast/forms/input-appearance-readonly-expected.checksum:
        * fast/forms/input-appearance-selection-expected.checksum:
        * fast/forms/input-appearance-visibility-expected.checksum:
        * fast/forms/input-appearance-width-expected.checksum:
        * fast/forms/input-baseline-expected.checksum:
        * fast/forms/input-disabled-color-expected.checksum:
        * fast/forms/input-double-click-selection-gap-bug-expected.checksum:
        * fast/forms/input-maxlength-2-expected.checksum:
        * fast/forms/input-no-renderer-expected.checksum:
        * fast/forms/input-paste-undo-expected.checksum:
        * fast/forms/input-readonly-dimmed-expected.checksum:
        * fast/forms/input-readonly-empty-expected.checksum:
        * fast/forms/input-spaces-expected.checksum:
        * fast/forms/input-table-expected.checksum:
        * fast/forms/input-text-click-inside-expected.checksum:
        * fast/forms/input-text-click-outside-expected.checksum:
        * fast/forms/input-text-double-click-expected.checksum:
        * fast/forms/input-text-drag-down-expected.checksum:
        * fast/forms/input-text-maxlength-expected.checksum:
        * fast/forms/input-text-option-delete-expected.checksum:
        * fast/forms/input-text-paste-maxlength-expected.checksum:
        * fast/forms/input-text-scroll-left-on-blur-expected.checksum:
        * fast/forms/input-text-self-emptying-click-expected.checksum:
        * fast/forms/input-value-expected.checksum:
        * fast/forms/input-width-expected.checksum:
        * fast/forms/minWidthPercent-expected.checksum:
        * fast/forms/negativeLineHeight-expected.checksum:
        * fast/forms/negativeLineHeight-expected.png:
        * fast/forms/negativeLineHeight-expected.txt:
        * fast/forms/option-index-expected.checksum:
        * fast/forms/option-script-expected.checksum:
        * fast/forms/option-strip-whitespace-expected.checksum:
        * fast/forms/plaintext-mode-2-expected.checksum:
        * fast/forms/radio-attr-order-expected.checksum:
        * fast/forms/radio_checked-expected.checksum:
        * fast/forms/radio_checked_dynamic-expected.checksum:
        * fast/forms/selection-functions-expected.txt:
        * fast/forms/tabbing-input-iframe-expected.checksum:
        * fast/forms/textAreaLineHeight-expected.checksum:
        * fast/forms/textAreaLineHeight-expected.png:
        * fast/forms/textAreaLineHeight-expected.txt:
        * fast/forms/textarea-crlf-expected.txt:
        * fast/forms/textarea-setinnerhtml-expected.checksum:
        * fast/forms/textarea-setinnerhtml-expected.png:
        * fast/forms/textarea-setinnerhtml-expected.txt:
        * fast/forms/textarea-setvalue-submit-expected.txt:
        * fast/forms/visual-hebrew-text-field-expected.checksum:
        * fast/replaced/width100percent-expected.checksum:
        * fast/replaced/width100percent-expected.png:
        * fast/replaced/width100percent-expected.txt:
        * fast/table/003-expected.checksum:
        * fast/table/003-expected.png:
        * fast/table/003-expected.txt:
        * tables/mozilla/bugs/bug194024-expected.checksum:
        * tables/mozilla/bugs/bug194024-expected.png:
        * tables/mozilla/bugs/bug194024-expected.txt:
        * tables/mozilla/bugs/bug30559-expected.checksum:
        * tables/mozilla/bugs/bug30559-expected.png:
        * tables/mozilla/bugs/bug30559-expected.txt:
        * tables/mozilla/bugs/bug30692-expected.checksum:
        * tables/mozilla/bugs/bug30692-expected.png:
        * tables/mozilla/bugs/bug30692-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Anders.
commit | commitdiff | tree
adele [Wed, 21 Jun 2006 07:23:06 +0000 (07:23 +0000)]
    Reviewed by Anders.

        Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
        Switch to use new text field implementation for <textarea>

        * css/html4.css:
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::selectionStart):
        (WebCore::HTMLTextAreaElement::selectionEnd):
        (WebCore::HTMLTextAreaElement::setSelectionStart):
        (WebCore::HTMLTextAreaElement::setSelectionEnd):
        (WebCore::HTMLTextAreaElement::select):
        (WebCore::HTMLTextAreaElement::setSelectionRange):
        (WebCore::HTMLTextAreaElement::createRenderer):
        (WebCore::HTMLTextAreaElement::appendFormData):
        (WebCore::HTMLTextAreaElement::isKeyboardFocusable):
        (WebCore::HTMLTextAreaElement::isMouseFocusable):
        (WebCore::HTMLTextAreaElement::focus):
        (WebCore::HTMLTextAreaElement::defaultEventHandler):
        (WebCore::HTMLTextAreaElement::updateValue):
        (WebCore::HTMLTextAreaElement::setValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej
commit | commitdiff | tree
beidson [Wed, 21 Jun 2006 01:42:48 +0000 (01:42 +0000)]
    Reviewed by Maciej

        Fixed capitalization mistake that I made, someone else fixed, then I accidentally made it go back to the old way

        * icon/SQLStatement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
commit | commitdiff | tree
beidson [Wed, 21 Jun 2006 01:29:57 +0000 (01:29 +0000)]
WebCore:

        Reviewed by Maciej.

        More changes/additions setting the stage for the major IconDatabase hookup.

        * WebCore.xcodeproj/project.pbxproj:  Added SQLTransaction.cpp

        * bridge/mac/WebCoreIconDatabaseBridge.h: Added call-throughs and translations to pass WebKit DB to WebCore DB
        * bridge/mac/WebCoreIconDatabaseBridge.mm:
        (+[WebCoreIconDatabaseBridge sharedBridgeInstance]):
        (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
        (-[WebCoreIconDatabaseBridge iconForURL:withSize:]):
        (-[WebCoreIconDatabaseBridge iconURLForURL:]):
        (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
        (-[WebCoreIconDatabaseBridge retainIconForURL:]):
        (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
        (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
        (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
        (-[WebCoreIconDatabaseBridge _setIconURL:forURL:]):
        (-[WebCoreIconDatabaseBridge _hasIconForIconURL:]):

        * bridge/mac/WebCorePageBridge.mm: Added WebCore's IconDatabase logging channel to the user-prefs check
        (initializeLoggingChannelsIfNecessary):

        * icon/IconDatabase.cpp:  Added stubs and basic SQL usage to create the sqlite DB and respond to WebKit calls
        (WebCore::IconDatabase::IconDatabase):
        (WebCore::IconDatabase::open):
        (WebCore::IconDatabase::close):
        (WebCore::IconDatabase::isValidDatabase):
        (WebCore::IconDatabase::recreateDatabase):
        (WebCore::IconDatabase::setPrivateBrowsingEnabled):
        (WebCore::IconDatabase::iconForURL):
        (WebCore::IconDatabase::iconURLForURL):
        (WebCore::IconDatabase::defaultIcon):
        (WebCore::IconDatabase::retainIconForURL):
        (WebCore::IconDatabase::releaseIconForURL):
        (WebCore::IconDatabase::setIconForIconURL):
        (WebCore::IconDatabase::setHaveNoIconForIconURL):
        (WebCore::IconDatabase::setIconURLForPageURL):
        (WebCore::IconDatabase::hasIconForIconURL):

        * icon/IconDatabase.h:  WebIcon will be an internal class used in IconDatabase but is not complete yet
        (WebCore::WebIcon::getExpiration):
        (WebCore::WebIcon::getTouch):

        * icon/SQLDatabase.cpp:  Added more SQLite convenience methods
        (SQLDatabase::setFullsync):
        (SQLDatabase::setBusyTimeout):
        (SQLDatabase::setBusyHandler):
        * icon/SQLDatabase.h:
        * icon/SQLStatement.cpp:
        (WebCore::SQLStatement::returnsAtLeastOneResult):

        * icon/SQLTransaction.cpp: Added basic commit/rollback support with this simple class
        (SQLTransaction::SQLTransaction):
        (SQLTransaction::~SQLTransaction):
        (SQLTransaction::begin):
        (SQLTransaction::commit):
        (SQLTransaction::rollback):

WebKit:

        Reviewed by Maciej

        Added calls through to the WebCoreIconDatabaseBridge for all the major WebIconDatabase API.  For now these calls
        are wrapped with #ifdef's and are for debugging only.

        * Misc/WebIconDatabase.h:
        * Misc/WebIconDatabase.m:
        (-[NSMutableDictionary _scaleIcon:toSize:]):
        (-[NSMutableDictionary init]):
        (-[NSMutableDictionary iconForURL:withSize:cache:]):
        (-[NSMutableDictionary iconURLForURL:]):
        (-[NSMutableDictionary retainIconForURL:]):
        (-[NSMutableDictionary releaseIconForURL:]):
        (-[WebIconDatabase _setHaveNoIconForIconURL:]):
        (-[WebIconDatabase _setIconURL:forURL:]):
        (-[WebIconDatabase _hasIconForIconURL:]):
        * Misc/WebIconLoader.m:
        (-[WebIconLoader didFinishLoading]):

        * Misc/WebKitLogging.h:  Added a logging channel for WebIconDatabase debugging
        * Misc/WebKitLogging.m:
        (WebKitInitializeLoggingChannelsIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff.
commit | commitdiff | tree
thatcher [Wed, 21 Jun 2006 00:20:00 +0000 (00:20 +0000)]
    Reviewed by Geoff.

        Make sure we clear the exception before returning so
        that future calls will not fail because of an earlier
        exception state. Assert on entry that the WebScriptObject
        is working with an ExecState that dose not have an exception.
        Document that evaluateWebScript and callWebScriptMethod return
        WebUndefined when an exception is thrown.

        * bindings/objc/WebScriptObject.h:
        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject callWebScriptMethod:withArguments:]):
        (-[WebScriptObject evaluateWebScript:]):
        (-[WebScriptObject setValue:forKey:]):
        (-[WebScriptObject valueForKey:]):
        (-[WebScriptObject removeWebScriptKey:]):
        (-[WebScriptObject webScriptValueAtIndex:]):
        (-[WebScriptObject setWebScriptValueAtIndex:value:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
commit | commitdiff | tree
adele [Wed, 21 Jun 2006 00:10:31 +0000 (00:10 +0000)]
LayoutTests:

        Reviewed by Maciej.

        Tests for:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8724
        REGRESSION: onSelect handler doesn't work for text fields

        http://bugzilla.opendarwin.org/show_bug.cgi?id=7676
        REGRESSION: Selection methods on new text fields don't work if text field is hidden

        http://bugzilla.opendarwin.org/show_bug.cgi?id=8867
        REGRESSION: selectionStart/End return 0 for input element once it no longer has focus

        * fast/forms/double-focus-expected.txt:
        * fast/forms/input-selection-hidden-expected.txt: Added.
        * fast/forms/input-selection-hidden.html: Added.
        * fast/forms/input-selection-restore-expected.txt: Added.
        * fast/forms/input-selection-restore.html: Added.
        * fast/forms/input-text-paste-maxlength-expected.txt:
        * fast/forms/onselect-textarea-expected.txt: Added.
        * fast/forms/onselect-textarea.html: Added.
        * fast/forms/onselect-textfield-expected.txt: Added.
        * fast/forms/onselect-textfield.html: Added.
        * fast/forms/selection-functions-expected.txt:

WebCore:

        Reviewed by Maciej.

        Fixes for:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8724
        REGRESSION: onSelect handler doesn't work for text fields

        http://bugzilla.opendarwin.org/show_bug.cgi?id=7676
        REGRESSION: Selection methods on new text fields don't work if text field is hidden

        http://bugzilla.opendarwin.org/show_bug.cgi?id=8867
        REGRESSION: selectionStart/End return 0 for input element once it no longer has focus

        Implemented onSelect for new text fields and textareas.  Also fixed selection restore
        behavior to better match other browsers and Safari 2.0 behavior.

        Tests:
        * fast/forms/input-selection-restore.html
        * fast/forms/input-selection-hidden.html
        * fast/forms/onselect-textarea.html
        * fast/forms/onselect-textfield.html

        * html/HTMLInputElement.h: (WebCore::HTMLInputElement::cacheSelection): Added.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::init): Initializes cached selection.
        (WebCore::HTMLInputElement::selectionStart): If this element doesn't have focus, return the cached selection value.
        (WebCore::HTMLInputElement::selectionEnd): ditto.
        (WebCore::HTMLInputElement::setValue): Restore a caret at the starting point of the old selection.  Matches Safari 2.0 behavior.

        * html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::cacheSelection): Added.
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Initializes cached selection.
        (WebCore::HTMLTextAreaElement::selectionStart): If this element doesn't have focus, return the cached selection value.
        (WebCore::HTMLTextAreaElement::selectionEnd): ditto.
        (WebCore::HTMLTextAreaElement::focus): If this is the first focus, set a caret at the end of the text.  Otherwise,
        restore the cached selection.  This matches other browsers' behavior.
        (WebCore::HTMLTextAreaElement::setValue): Restore a caret at the starting point of the old selection.  Matches Safari 2.0 behavior.

        * page/Frame.h: Added notifyRendererOfSelectionChange method.
        * page/Frame.cpp:
        (WebCore::Frame::notifyRendererOfSelectionChange): Added.  Calls selectionChanged for text fields and textareas.  Forwards a userTriggered
        argument so selectionChanged knows whether or not to fire onSelect.
        (WebCore::Frame::setSelection): Calls notifyRendererOfSelectionChange(false).  This gets called for all selection changes, so the renderer
        can always update its cached selection values.
        (WebCore::Frame::handleMouseReleaseEvent): Calls notifyRendererOfSelectionChange(true) so onSelect will get fired when the user is done
        making a selection with the mouse.
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]): Calls notifyRendererOfSelectionChange(true) so onSelect gets
        fired when the user makes a selection with the keyboard.
        (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]): ditto.

        * rendering/RenderTextField.h: Add userTriggered parameter to selectionChanged.
        * rendering/RenderTextField.cpp:
        (WebCore::RenderTextField::setSelectionRange): For visibility:hidden, cache the selection and
        return early since we won't be able to actually set the selection.
        (WebCore::RenderTextField::selectionChanged): Caches the selection.
        If the selection is a range, and its triggered by user action, then fire the onSelect event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-06-21 Anders Carlsson <acarlsson@apple.com>
commit | commitdiff | tree
andersca [Tue, 20 Jun 2006 22:11:12 +0000 (22:11 +0000)]
2006-06-21  Anders Carlsson  <acarlsson@apple.com>

        * bridge/win/FrameWin.cpp:
        (WebCore::shouldInterruptJavaScript):
        * bridge/win/FrameWin.h:
        Try fixing the Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago RS by Tim Hatcher.
commit | commitdiff | tree
adele [Tue, 20 Jun 2006 22:07:28 +0000 (22:07 +0000)]
    RS by Tim Hatcher.

        Renamed RenderSelect to DeprecatedRenderSelect to prepare for new popup menu and list menu implementations.

        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLOptionElement.h:
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::recalcStyle):
        (WebCore::HTMLSelectElement::createRenderer):
        (WebCore::HTMLSelectElement::setRecalcListItems):
        (WebCore::HTMLSelectElement::reset):
        (WebCore::HTMLSelectElement::notifyOptionSelected):
        * html/HTMLSelectElement.h:
        * rendering/DeprecatedRenderSelect.cpp: Added.
        (WebCore::DeprecatedRenderSelect::DeprecatedRenderSelect):
        (WebCore::DeprecatedRenderSelect::setWidgetWritingDirection):
        (WebCore::DeprecatedRenderSelect::setStyle):
        (WebCore::DeprecatedRenderSelect::updateFromElement):
        (WebCore::DeprecatedRenderSelect::baselinePosition):
        (WebCore::DeprecatedRenderSelect::calcMinMaxWidth):
        (WebCore::DeprecatedRenderSelect::layout):
        (WebCore::DeprecatedRenderSelect::valueChanged):
        (WebCore::DeprecatedRenderSelect::selectionChanged):
        (WebCore::DeprecatedRenderSelect::setOptionsChanged):
        (WebCore::DeprecatedRenderSelect::createListBox):
        (WebCore::DeprecatedRenderSelect::updateSelection):
        * rendering/DeprecatedRenderSelect.h: Added.
        (WebCore::DeprecatedRenderSelect::renderName):
        * rendering/RenderSelect.cpp: Removed.
        * rendering/RenderSelect.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoCommit for real this time - Not just the ChangeLog and some white-space
commit | commitdiff | tree
andersca [Tue, 20 Jun 2006 22:01:13 +0000 (22:01 +0000)]
Commit for real this time - Not just the ChangeLog and some white-space

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-06-20 Anders Carlsson <acarlsson@apple.com>
commit | commitdiff | tree
andersca [Tue, 20 Jun 2006 21:34:35 +0000 (21:34 +0000)]
2006-06-20  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9509
        Would like a way to pause/resume XML parsing

        * dom/xml_tokenizer.cpp:
        (WebCore::PendingCallbacks::PendingCallbacks):
        (WebCore::PendingCallbacks::appendStartElementNSCallback):
        (WebCore::PendingCallbacks::appendEndElementNSCallback):
        (WebCore::PendingCallbacks::appendCharactersCallback):
        (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
        (WebCore::PendingCallbacks::appendCDATABlockCallback):
        (WebCore::PendingCallbacks::appendCommentCallback):
        (WebCore::PendingCallbacks::appendInternalSubsetCallback):
        (WebCore::PendingCallbacks::appendErrorCallback):
        (WebCore::PendingCallbacks::callAndRemoveFirstCallback):
        (WebCore::PendingCallbacks::isEmpty):
        (WebCore::PendingCallbacks::PendingCallback::~PendingCallback):
        (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback):
        (WebCore::PendingCallbacks::PendingStartElementNSCallback::call):
        (WebCore::PendingCallbacks::PendingEndElementNSCallback::call):
        (WebCore::PendingCallbacks::PendingCharactersCallback::~PendingCharactersCallback):
        (WebCore::PendingCallbacks::PendingCharactersCallback::call):
        (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::~PendingProcessingInstructionCallback):
        (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::call):
        (WebCore::PendingCallbacks::PendingCDATABlockCallback::~PendingCDATABlockCallback):
        (WebCore::PendingCallbacks::PendingCDATABlockCallback::call):
        (WebCore::PendingCallbacks::PendingCommentCallback::~PendingCommentCallback):
        (WebCore::PendingCallbacks::PendingCommentCallback::call):
        (WebCore::PendingCallbacks::PendingInternalSubsetCallback::~PendingInternalSubsetCallback):
        (WebCore::PendingCallbacks::PendingInternalSubsetCallback::call):
        (WebCore::PendingCallbacks::):
        New classes which manage a list of pending SAX callbacks that have not yet
        been sent to the tokenizer.

        (WebCore::XMLTokenizer::XMLTokenizer):
        Initialize new member variables.

        (WebCore::XMLTokenizer::~XMLTokenizer):
        Delete PendingCallbacks object.

        (WebCore::XMLTokenizer::write):
        If the parser is paused, queue the data to be written.

        (WebCore::XMLTokenizer::startElementNs):
        (WebCore::XMLTokenizer::endElementNs):
        (WebCore::XMLTokenizer::characters):
        (WebCore::XMLTokenizer::error):
        (WebCore::XMLTokenizer::processingInstruction):
        (WebCore::XMLTokenizer::cdataBlock):
        (WebCore::XMLTokenizer::comment):
        (WebCore::XMLTokenizer::internalSubset):
        If the parser has been paused, queue the callbacks instead.

        (WebCore::XMLTokenizer::handleError):
        New function, called by both ::error and :PendingCallbacks::callAndRemoveFirstCallback

        (WebCore::XMLTokenizer::finish):
        (WebCore::XMLTokenizer::pauseParsing):
         Set m_parserPaused to true.

        (WebCore::XMLTokenizer::resumeParsing):
        Call the pending callbacks and then parse the pending source.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Don't send the custom highlighter callback when painting is disabled.
commit | commitdiff | tree
hyatt [Tue, 20 Jun 2006 21:24:04 +0000 (21:24 +0000)]
    Don't send the custom highlighter callback when painting is disabled.

        Reviewed by harrison

        * WebCore.xcodeproj/project.pbxproj:
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim Hatcher.
commit | commitdiff | tree
adele [Tue, 20 Jun 2006 21:04:08 +0000 (21:04 +0000)]
    Reviewed by Tim Hatcher.

        * WebView/WebMainResourceLoader.m: Added missing header to fix build on Leopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
commit | commitdiff | tree
andersca [Tue, 20 Jun 2006 19:44:08 +0000 (19:44 +0000)]
WebCore:

2006-06-20  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by John.

        <rdar://problem/4592244> REGRESSION (417.9.3 - 420+): (some?) plain text files have all lines concatenated into one line

        * loader/TextDocument.cpp:
        (WebCore::TextTokenizer::checkBuffer):
        (WebCore::TextTokenizer::TextTokenizer):
        (WebCore::TextTokenizer::write):
        (WebCore::TextTokenizer::finish):
        Add a text buffer which is used for translation of CR and CRLF to plain LF,
        like the HTML tokenizer does.

LayoutTests:

2006-06-20  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by John.

        <rdar://problem/4592244> REGRESSION (417.9.3 - 420+): (some?) plain text files have all lines concatenated into one line

        * fast/text/plain-text-line-breaks-expected.checksum: Added.
        * fast/text/plain-text-line-breaks-expected.png: Added.
        * fast/text/plain-text-line-breaks-expected.txt: Added.
        * fast/text/plain-text-line-breaks.html: Added.
        * fast/text/resources/line-breaks-cr.txt: Added.
        * fast/text/resources/line-breaks-crlf.txt: Added.
        * fast/text/resources/line-breaks-lf.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
commit | commitdiff | tree
thatcher [Tue, 20 Jun 2006 19:12:19 +0000 (19:12 +0000)]
    Reviewed by Darin.

        Adds a JavaScript debugger, called Drosera. Named after
        a genus of bug eating plants.

        * Drosera/DebuggerApplication.h: Added.
        * Drosera/DebuggerApplication.m: Added.
        (-[DebuggerApplication applicationDidFinishLaunching:]):
        (-[DebuggerApplication serverLoaded:]):
        (-[DebuggerApplication serverUnloaded:]):
        (-[DebuggerApplication awakeFromNib]):
        (-[DebuggerApplication showAttachPanel:]):
        (-[DebuggerApplication attach:]):
        (-[DebuggerApplication numberOfRowsInTableView:]):
        (-[DebuggerApplication tableView:objectValueForTableColumn:row:]):
        (-[DebuggerApplication tableView:willDisplayCell:forTableColumn:row:]):
        (-[DebuggerApplication tableViewSelectionDidChange:]):
        * Drosera/DebuggerDocument.h: Added.
        * Drosera/DebuggerDocument.m: Added.
        (+[WebScriptCallFrame isSelectorExcludedFromWebScript:]):
        (+[WebScriptCallFrame isKeyExcludedFromWebScript:]):
        (+[DebuggerDocument isSelectorExcludedFromWebScript:]):
        (+[DebuggerDocument isKeyExcludedFromWebScript:]):
        (-[DebuggerDocument initWithServerName:]):
        (-[DebuggerDocument windowWillClose:]):
        (-[DebuggerDocument dealloc]):
        (-[DebuggerDocument isPaused]):
        (-[DebuggerDocument pause]):
        (-[DebuggerDocument resume]):
        (-[DebuggerDocument step]):
        (-[DebuggerDocument windowNibName]):
        (-[DebuggerDocument windowDidLoad]):
        (-[DebuggerDocument switchToServerNamed:]):
        (-[DebuggerDocument applicationTerminating:]):
        (-[DebuggerDocument serverConnectionDidDie:]):
        (-[DebuggerDocument webView:windowScriptObjectAvailable:]):
        (-[DebuggerDocument webView:didFinishLoadForFrame:]):
        (-[DebuggerDocument webView:didParseSource:fromURL:sourceId:forWebFrame:]):
        (-[DebuggerDocument webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
        (-[DebuggerDocument webView:willExecuteStatement:sourceId:line:forWebFrame:]):
        (-[DebuggerDocument webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
        * Drosera/Drosera.pch: Added.
        * Drosera/Drosera.xcodeproj/project.pbxproj: Added.
        * Drosera/English.lproj/Debugger.nib/classes.nib: Added.
        * Drosera/English.lproj/Debugger.nib/info.nib: Added.
        * Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Added.
        * Drosera/English.lproj/MainMenu.nib/classes.nib: Added.
        * Drosera/English.lproj/MainMenu.nib/info.nib: Added.
        * Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Added.
        * Drosera/Images/breakPoint.tif: Added.
        * Drosera/Images/breakPointDisabled.tif: Added.
        * Drosera/Images/continue.tif: Added.
        * Drosera/Images/finishFunction.tif: Added.
        * Drosera/Images/glossyFooterFill.tif: Added.
        * Drosera/Images/glossyHeader.png: Added.
        * Drosera/Images/gradientBackground.png: Added.
        * Drosera/Images/gutter.png: Added.
        * Drosera/Images/navLeftDisabled.png: Added.
        * Drosera/Images/navLeftNormal.png: Added.
        * Drosera/Images/navLeftPressed.png: Added.
        * Drosera/Images/navRightDisabled.png: Added.
        * Drosera/Images/navRightNormal.png: Added.
        * Drosera/Images/navRightPressed.png: Added.
        * Drosera/Images/pause.tif: Added.
        * Drosera/Images/popUpArrows.png: Added.
        * Drosera/Images/programCounter.tif: Added.
        * Drosera/Images/programCounterBreakPoint.tif: Added.
        * Drosera/Images/programCounterBreakPointDisabled.tif: Added.
        * Drosera/Images/run.tif: Added.
        * Drosera/Images/splitterBar.tif: Added.
        * Drosera/Images/splitterDimple.tif: Added.
        * Drosera/Images/step.tif: Added.
        * Drosera/Images/stepOver.tif: Added.
        * Drosera/Images/stop.tif: Added.
        * Drosera/Images/toolbarBackground.png: Added.
        * Drosera/Info.plist: Added.
        * Drosera/debugger.css: Added.
        * Drosera/debugger.html: Added.
        * Drosera/debugger.js: Added.
        * Drosera/main.m: Added.
        (main):
        * Drosera/viewer.css: Added.
        * Drosera/viewer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
commit | commitdiff | tree
thatcher [Tue, 20 Jun 2006 19:08:16 +0000 (19:08 +0000)]
    Reviewed by Darin.

        Removes the @try/@catch from the callbacks to improve performance,
        simply check if the proxy object's connection is still valid first.
        Listener objects are now required to be NSDistantObjects.

        Adds pause, resume and step support. The debugger process use to handle this,
        but it caused problems when there were multiple listeners.

        Sends the bundle identifier in the notification userInfo dictionary along with
        process name and process ID.

        * DefaultDelegates/WebScriptDebugServer.h:
        * DefaultDelegates/WebScriptDebugServer.m:
        (-[WebScriptDebugServer serverQuery:]):
        (-[WebScriptDebugServer addListener:]):
        (-[WebScriptDebugServer removeListener:]):
        (-[WebScriptDebugServer step]):
        (-[WebScriptDebugServer pause]):
        (-[WebScriptDebugServer resume]):
        (-[WebScriptDebugServer isPaused]):
        (-[WebScriptDebugServer suspendProcessIfPaused]):
        (-[WebScriptDebugServer webView:didParseSource:fromURL:sourceId:forWebFrame:]):
        (-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
        (-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]):
        (-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
        * DefaultDelegates/WebScriptDebugServerPrivate.h:
        * WebKit.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
commit | commitdiff | tree
mjs [Tue, 20 Jun 2006 08:14:30 +0000 (08:14 +0000)]
    Reviewed by Eric.

        - fix crasher on one of the layout tests caused by my recent checkin

        * kcanvas/RenderSVGText.cpp:
        (WebCore::RenderSVGText::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
commit | commitdiff | tree
ap [Tue, 20 Jun 2006 05:17:14 +0000 (05:17 +0000)]
    Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=5499
        Page reload does not send any cache control headers

WebCore:
        * bindings/js/kjs_window.cpp:
        (KJS::LocationFunc::callAsFunction): Call scheduleRefresh() for Location::Reload.

        * page/Frame.h: Add scheduleRefresh(). Don't derive from TransferJob or implement its methods - that was
        used only for storing response HTTP headers, which was an overkill.

        * page/FramePrivate.h: Replace TransferJob with a HashMap for storing response headers.

        * page/Frame.cpp:
        (WebCore::Frame::didOpenURL): Don't needlessly change d->m_cachePolicy. Don't create a TransferJob.
        (WebCore::Frame::stopLoading): Directly access the metadata map, instead of going through a TransferJob.
        (WebCore::Frame::receivedFirstData): Ditto.
        (WebCore::Frame::addMetaData): Ditto.
        (WebCore::Frame::scheduleRefresh): A new function that schedules a refresh, similarly to what
        scheduleRedirection() does.
        (WebCore::Frame::changeLocation): Set request.reload attribute based on the current cache policy.

WebKit:
        * WebView/WebFrame.m:
        (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): Set a proper Cache-Control header for
        reload requests.
        (-[WebFrame loadRequest:]): Reset loadType to WebFrameLoadTypeStandard (after a reload, it stayed at
        WebFrameLoadTypeReload, so _addExtraFieldsToRequest erroneously added a Cache-Control header to them).

LayoutTests:
        * http/tests/misc/refresh-headers-expected.txt: Added.
        * http/tests/misc/refresh-headers.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
commit | commitdiff | tree
ddkilzer [Tue, 20 Jun 2006 03:20:14 +0000 (03:20 +0000)]
WebCore:

        Reviewed by Darin.  Patch by Ben Goodger.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9501
        Windows build fails with link error CharsetTable not defined

        * platform/make-charset-table.pl:
        (process_iana_charsets): Move test for equality to alias "None" until after
        normalization steps to ensure escape characters in the input data don't
        interfere with processing.  Convert nearby tabs to 4 spaces in this function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
commit | commitdiff | tree
mjs [Tue, 20 Jun 2006 02:43:10 +0000 (02:43 +0000)]
    Reviewed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=9488
        "Animated GIFs do not respect transforms in SVG"

        http://bugzilla.opendarwin.org/show_bug.cgi?id=6946
        "SVG shows invalidation issues in WebKit"

        http://www.treebuilder.de/default.asp?file=441875.xml
        "Invalidation issues with "SVG 3d" demo"

        http://code.google.com/webstats/2005-12/pages.html
        "SVG text doesn't repaint correctly"

        * kcanvas/KCanvasContainer.cpp:
        (WebCore::KCanvasContainer::computeAbsoluteRepaintRect): Override base class, and apply
        appropriate transforms, so damage rects in transformed SVG content get propagated up properly.
        (WebCore::KCanvasContainer::getAbsoluteRepaintRect): note a FIXME; this method
        seems wrong.
        * kcanvas/KCanvasContainer.h: Prototype new method.

        * css/svg.css: Don't apply overflow:hidden to foreignObject, since that makes it a RenderLayer
        so it paints twice.
        * kcanvas/RenderForeignObject.cpp:
        (WebCore::RenderForeignObject::paint): Transform the damage rect before passing it down to HTML content,
        so everything paints that is supposed to. Also handle opacity here since we won't get layers.
        (WebCore::RenderForeignObject::computeAbsoluteRepaintRect): Override base class, and apply
        appropriate transforms, so damage rects in HTML embedded in SVG get propagated up properly.
        (WebCore::RenderForeignObject::requiresLayer): Never use a RenderLayer.
        (WebCore::RenderForeignObject::layout): Make sure to dirty our previous bounds when layout
        changes, as by transform.
        * kcanvas/RenderForeignObject.h:

        * kcanvas/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::paint): Transform the damage rect when painting. Also handle opacity
        here since we won't get layers.
        (WebCore::RenderForeignObject::computeAbsoluteRepaintRect): Override base class, and apply
        appropriate transforms, so damage rects in SVG images  get propagated up properly.
        (WebCore::RenderSVGImage::translationForAttributes): New helper method, factored out of below.
        (WebCore::RenderSVGImage::translateForAttributes): Use above.
        (WebCore::RenderSVGImage::requiresLayer): Never use a RenderLayer.
        (WebCore::RenderSVGImage::layout): Make sure to properly dirty the old bounds, accounting
        for transforms.
        (WebCore::RenderSVGImage::relativeBBox): Correct bbox computation.
        * kcanvas/RenderSVGImage.h:

        * kcanvas/RenderSVGText.cpp:
        (WebCore::RenderSVGText::paint): Transform incoming damage rect. Handle opacity here since we
        won't get a layer.
        (WebCore::RenderSVGText::computeAbsoluteRepaintRect): Apply transforms.
        (WebCore::RenderSVGText::requiresLayer): Never use a RenderLayer.
        (WebCore::RenderSVGText::layout): Make sure to dirty the old bounds.

        * platform/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::roundToDevicePixels): Instead of transforming rect to device space
        and back to user space, do this for the origin and lower right corner of the rect. Otherwise the
        rect will get inflated if user space is rotated or skewed.

        * kcanvas/RenderPath.cpp:
        (WebCore::RenderPath::layout): Make sure to dirty the old bounds.
        (WebCore::RenderPath::paint): Hhandle opacity here.

        Bonus fix:

        * kcanvas/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::nodeAtPoint): Fix hit testing. Wasn't applying the x/y
        attribute transform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBuild fix.
commit | commitdiff | tree
thatcher [Mon, 19 Jun 2006 23:31:31 +0000 (23:31 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@14916 268f45cc-cd09-0410...
commit | commitdiff | tree
weinig [Mon, 19 Jun 2006 22:58:36 +0000 (22:58 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
commit | commitdiff | tree
sullivan [Mon, 19 Jun 2006 21:58:12 +0000 (21:58 +0000)]
    Reviewed by Darin.

        - added mechanism to notify UIDelegate when part of the webview is redrawn. For now, it only
          works for HTML views.

        * WebView/WebUIDelegatePrivate.h:
        Define a new UIDelegate method -webView:didDrawRect:
        * WebView/WebHTMLView.m:
        (-[WebView drawSingleRect:]):
        Call through to UIDelegate if it implements that method. I tested that this does not impact PLT numbers
        in the case where the delegate implements the method but does nothing in it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Brady.
commit | commitdiff | tree
darin [Mon, 19 Jun 2006 21:39:28 +0000 (21:39 +0000)]
    Reviewed by Brady.

        - removed a few empty/unused files Brady found by tracking down the nm error message

        * editing/VisibleRange.cpp: Removed.
        * editing/VisibleRange.h: Removed.
        * kcanvas/KCanvasImage.cpp: Removed.

        * WebCore.vcproj/WebCore/WebCore.vcproj: Removed VisibleRange.cpp/h.
        * WebCore.xcodeproj/project.pbxproj: Removed VisibleRange.cpp/h and KCanvasImage.cpp.
        * WebCoreSources.bkl: Removed VisibleRange.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-06-19 Anders Carlsson <acarlsson@apple.com>
commit | commitdiff | tree
andersca [Mon, 19 Jun 2006 19:23:18 +0000 (19:23 +0000)]
2006-06-19  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by John.

        * kjs/interpreter.cpp:
        (KJS::TimeoutChecker::pauseTimeoutCheck):
        (KJS::TimeoutChecker::resumeTimeoutCheck):
        Fix argument order in setitimer calls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
commit | commitdiff | tree
ap [Mon, 19 Jun 2006 16:42:35 +0000 (16:42 +0000)]
    Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9492
        Fix or remove window.debug.

        It was only available in newly created windows, and became undefined after changing the URL
        or reloading. Let's try removing it; hopefully, no-one will notice.

        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::initScriptIfNeeded): Don't add window.debug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
commit | commitdiff | tree
ap [Mon, 19 Jun 2006 16:15:31 +0000 (16:15 +0000)]
    Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8972
        REGRESSION: invalid UTF-8 sequences are not displayed

        Test: LayoutTests/fast/encoding/invalid-UTF-8.html

        * dom/xml_tokenizer.cpp:
        (WebCore::getXHTMLEntity): Properly null-terminate the result. This didn't matter
        before, because the garbage at the end was guaranteed to be invalid UTF-8, and was
        omitted in appendOmittingUnwanted();

        * platform/StreamingTextDecoder.cpp:
        (WebCore::StreamingTextDecoder::appendOmittingBOM): Only omit BOM characters.
        Renamed back from appendOmittingUnwanted();

        (WebCore::StreamingTextDecoder::convertUsingICU):
        * platform/StreamingTextDecoder.h:
        Update for the above function renaming.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebKit:
commit | commitdiff | tree
ddkilzer [Mon, 19 Jun 2006 10:51:11 +0000 (10:51 +0000)]
WebKit:

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9452
          Assertion failure in -[WebFramePrivate setProvisionalDataSource:]

        * WebView/WebFrame.m:
        (-[WebFrame _checkLoadCompleteForThisFrame]): Avoid re-entering the delegate's
        -[webView:didFailProvisionalLoadWithError:forFrame].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebKitTools:
commit | commitdiff | tree
ddkilzer [Mon, 19 Jun 2006 00:00:53 +0000 (00:00 +0000)]
WebKitTools:

        Reviewed by darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9485
        Teach svn-apply and svn-unapply to use full path names

        * Scripts/svn-apply: Changed to use full path names.  Cleaned up code.
        * Scripts/svn-unapply: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
commit | commitdiff | tree
ddkilzer [Sun, 18 Jun 2006 23:54:59 +0000 (23:54 +0000)]
WebCore:

        Reviewed by darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9498
        Remove dead code left in JSHTMLDocument::getOwnPropertySlot() from r14298 (Bug 7838)

        * bindings/js/kjs_html.cpp:
        (KJS::JSHTMLDocument::getOwnPropertySlot): Remove dead code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
commit | commitdiff | tree
ddkilzer [Sun, 18 Jun 2006 22:20:04 +0000 (22:20 +0000)]
LayoutTests:

        Reviewed by ggaren.

        * fast/history/clicked-link-is-visited.html: Changed to use DOM mouse event.

WebCore:

        Reviewed by ggaren.

        * manual-tests/redraw-page-cache-visited-links.html: Changed to use DOM mouse event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebKit:
commit | commitdiff | tree
ddkilzer [Sun, 18 Jun 2006 17:58:53 +0000 (17:58 +0000)]
WebKit:

        Reviewed by xenon.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9479
          Disassociate the inspector from the frame when it detaches from its parent

        * WebInspector/WebInspector.m:
        (-[NSWindow setWebFrame:]): Added code to (de)register with the WebFrame
        the inspector is (no longer) targeting.
        (-[WebInspector _webFrameDetached:]): Added. Moved the code that was previously
        in -[inspectedWindowWillClose:] here. This is called by the WebFrame when it
        is detached from its parent.
        * WebInspector/WebInspectorInternal.h:
        * WebView/WebFrame.m:
        (-[WebFramePrivate dealloc]):
        (-[WebFrame _detachFromParent]): Added code to notify all registered inspectors
        that the WebFrame is detaching.
        (-[WebFrame _addInspector:]): Added.
        (-[WebFrame _removeInspector:]): Added.
        * WebView/WebFrameInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
commit | commitdiff | tree
ddkilzer [Sun, 18 Jun 2006 17:54:35 +0000 (17:54 +0000)]
LayoutTests:

        Reviewed by ggaren.

        - test and results for http://bugzilla.opendarwin.org/show_bug.cgi?id=9150
          DumpRenderTree should be able to keep URL history during runs

        * fast/history/clicked-link-is-visited-expected.checksum: Added.
        * fast/history/clicked-link-is-visited-expected.png: Added.
        * fast/history/clicked-link-is-visited-expected.txt: Added.
        * fast/history/clicked-link-is-visited.html: Added.
        * fast/history/resources/clicked-link-is-visited-2.html: Added.

WebCore:

        Reviewed by ggaren.

        - Update a manual test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9150
          DumpRenderTree should be able to keep URL history during runs

        * manual-tests/redraw-page-cache-visited-links.html: Added note about window.history hack.
        Fixed coordinates for mouse events.  Added call to keepWebHistory().
        * manual-tests/resources/redraw-page-cache-visited-links-2.html: Added note about
        window.history hack.

WebKitTools:

        Reviewed by ggaren.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9150
          DumpRenderTree should be able to keep URL history during runs

        Test: LayoutTests/fast/history/clicked-link-is-visited.html

        * DumpRenderTree/DumpRenderTree.m: Add keepWebHistory function to layoutTestController
        (+[LayoutTestController isSelectorExcludedFromWebScript:]): Updated for keepWebHistory.
        (-[LayoutTestController keepWebHistory]): Added.  We only set optional shared history if
        it is currently nil since keepWebHistory() might be called more than once incidentally
        for the same test.
        (dumpRenderTree): Set optional shared history in WebHistory to nil by default.
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Xcode 2.3 clean up.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
commit | commitdiff | tree
andersca [Sun, 18 Jun 2006 17:11:51 +0000 (17:11 +0000)]
JavaScriptCore:

2006-06-18  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        * kjs/interpreter.cpp:
        (KJS::TimeoutChecker::pauseTimeoutCheck):
        Do nothing if the timeout check hasn't been started.

        (KJS::TimeoutChecker::resumeTimeoutCheck):
        Do nothing if the timeout check hasn't been started.
        Use the right signal handler when unblocking.

        (KJS::Interpreter::handleTimeout):
        pause/resume the timeout check around the call to
        shouldInterruptScript().

WebCore:

2006-06-17  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        * bindings/js/kjs_binding.cpp:
        (KJS::ScriptInterpreter::ScriptInterpreter):
        Set the default script timeout.

        (KJS::ScriptInterpreter::shouldInterruptScript):
        New function which asks the frame if the script should be interrupted.

        * bindings/js/kjs_binding.h:

        * bindings/js/kjs_events.cpp:
        (KJS::JSAbstractEventListener::handleEvent):
        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::evaluate):
        Add calls to startTimeoutCheck/stopTimeoutCheck

        * bindings/js/kjs_window.cpp:
        (KJS::WindowFunc::callAsFunction):
        Add calls to pauseTimeoutCheck/unpauseTimeoutCheck

        (KJS::ScheduledAction::execute):
        Add calls to startTimeoutCheck/stopTimeoutCheck

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::shouldInterruptJavaScript):
        New function which asks the bridge if the script should be interrupted.

        * bridge/mac/WebCoreFrameBridge.h:
        * page/Frame.h:
        Add function declarations.

WebKit:

2006-06-18  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge shouldInterruptJavaScript]):
        Ask the UI delegate if the script should be interrupted.

        * WebView/WebUIDelegatePrivate.h:
        Declare webViewShouldInterruptJavaScript: delegate method

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by ggaren.
commit | commitdiff | tree
ap [Sun, 18 Jun 2006 07:00:54 +0000 (07:00 +0000)]
    Reviewed by ggaren.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8131
        Some properties and methods of window and document objects cannot be converted to a string

        Most of the properties were already fixed, this just adds adds a prototype to window.debug.

        Test: fast/dom/everything-to-string.html

        * bindings/js/kjs_proxy.cpp:
        (WebCore::TestFunctionImp::TestFunctionImp):
        (WebCore::KJSProxy::initScriptIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej
commit | commitdiff | tree
mjs [Sun, 18 Jun 2006 06:25:06 +0000 (06:25 +0000)]
    Reviewed by Maciej

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9491
        Windows build breaks in interpreter.cpp

        * kjs/interpreter.cpp
        (KJS::TimeoutChecker::pauseTimeoutCheck):
        (KJS::TimeoutChecker::resumeTimeoutCheck):
        Make sure to only assert equality with s_executingInterpreter when it
        is being used (i.e. when HAVE(SYS_TIME_H) == true)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
commit | commitdiff | tree
ddkilzer [Sun, 18 Jun 2006 04:22:56 +0000 (04:22 +0000)]
WebCore:

        Reviewed by Maciej.

        - Fix capitalization issue for case-sensitive filesystems.

        * icon/SQLStatement.cpp: Change assertions.h to Assertions.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
commit | commitdiff | tree
ddkilzer [Sun, 18 Jun 2006 00:30:57 +0000 (00:30 +0000)]
JavaScriptCore:

        Reviewed by darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9477
        REGRESSION: fast/dom/replaceChild.html crashes on WebKit ToT in debug build

        * kjs/function.cpp:
        (KJS::FunctionImp::callAsFunction): Refetch the debugger after executing the function
        in case the WebFrame it was running in has since been destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
commit | commitdiff | tree
adele [Sat, 17 Jun 2006 15:54:58 +0000 (15:54 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - test and updated results for http://bugzilla.opendarwin.org/show_bug.cgi?id=7395
          Table not properly re-flowed when floated div removed from layout

        * css2.1/t0905-c5525-fltmult-00-d-g-expected.checksum: Updated.
        * css2.1/t0905-c5525-fltmult-00-d-g-expected.png: Updated.
        * css2.1/t0905-c5525-fltmult-00-d-g-expected.txt: Updated.
        * fast/block/float/table-relayout-expected.checksum: Added.
        * fast/block/float/table-relayout-expected.png: Added.
        * fast/block/float/table-relayout-expected.txt: Added.
        * fast/block/float/table-relayout.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7395
          Table not properly re-flowed when floated div removed from layout

        Test: fast/block/float/table-relayout.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout): Added marking
        of children that use lineWidth.
        * rendering/RenderBlock.h: Added a FIXME.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
commit | commitdiff | tree
adele [Sat, 17 Jun 2006 15:37:58 +0000 (15:37 +0000)]
LayoutTests:

        Reviewed by Darin.

        Test cases for
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=6282>

        * fast/dom/select-selectedIndex-multiple.html: Added.
        * fast/dom/select-selectedIndex.html: Added.

WebCore:

        Reviewed by Darin.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6282:
        Adding new Option with new Option(text, value, defaultSelected, selected) fails to update selectedIndex

        Update selectedIndex when a new option is added using javascript.

        * bindings/js/kjs_html.cpp:
        (KJS::JSHTMLSelectCollection::put):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setSelectedIndex):
        (WebCore::HTMLSelectElement::setOption):
        (WebCore::HTMLSelectElement::setLength):
        * html/HTMLSelectElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
commit | commitdiff | tree
adele [Sat, 17 Jun 2006 15:29:59 +0000 (15:29 +0000)]
WebCore:

        Reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9466
          Assertion failure when dragging an image from the document into Safari's address bar

        * manual-tests/reset-initiatedDrag.html: Added.

WebKit:

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9466
          Assertion failure when dragging an image from the document into Safari's address bar

        * WebView/WebFrameView.m:
        (-[WebFrameView _setDocumentView:]): Reset the WebView's initiatedDrag flag
        when the document view is changed.
        * WebView/WebHTMLView.m:
        (-[WebHTMLView draggedImage:endedAt:operation:]): Changed the ASSERT to allow
        for drags that end after the view has been removed from the WebView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
commit | commitdiff | tree
ddkilzer [Sat, 17 Jun 2006 10:48:33 +0000 (10:48 +0000)]
JavaScriptCore:

        Reviewed by ggaren.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9476
        REGRESSION: Reproducible crash after closing window after viewing
        css2.1/t0803-c5501-imrgn-t-00-b-ag.html

        * kjs/debugger.cpp:
        (Debugger::detach): Call setDebugger(0) for all interpreters removed from
        the 'attached to a debugger' list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
commit | commitdiff | tree
ddkilzer [Sat, 17 Jun 2006 01:15:54 +0000 (01:15 +0000)]
WebCore:

        Reviewed by darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9463
        REGRESSION (r14879): Assertion failure in CSSParser::sinkFloatingSelector()
        (m_floatingSelectors.contains(selector)) in some CSS tests

        * css/CSSGrammar.y: Create CSSSelector for FUNCTION using CSSParser::createFloatingSelector()
        instead of the bare constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago <rdar://problem/4565312> Mail has a weird drawing artifact with dotted red...
commit | commitdiff | tree
harrison [Sat, 17 Jun 2006 01:08:52 +0000 (01:08 +0000)]
    <rdar://problem/4565312> Mail has a weird drawing artifact with dotted red lines running across the window

        Problem was that revision lost a check to not draw the markers
        when paintingDisabled().   This led the markers to be drawn when
        the window deactivated, at which time the view happens to be flipped.

        It is similar but not the same as the Mail ToDo highlighting
        issue, which is due to the custom highlight method
        drawing when the focusView is nil.  Mail team knows this
        and has tested the fix.

        * platform/mac/GraphicsContextMac.mm:
        (WebCore::GraphicsContext::drawLineForMisspelling):
        Early return if paintingDisabled().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-06-17 Anders Carlsson <acarlsson@apple.com>
commit | commitdiff | tree
andersca [Fri, 16 Jun 2006 23:47:20 +0000 (23:47 +0000)]
2006-06-17  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Maciej and Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=7080
        Provide some way to stop a JavaScript infinite loop

        * kjs/completion.h:
        (KJS::):
        Add Interrupted completion type.

        * kjs/function.cpp:
        (KJS::FunctionImp::callAsFunction):
        (KJS::GlobalFuncImp::callAsFunction):
        Only set the exception on the new ExecState if the current one has had one.

        * kjs/interpreter.cpp:
        (KJS::TimeoutChecker::startTimeoutCheck):
        (KJS::TimeoutChecker::stopTimeoutCheck):
        (KJS::TimeoutChecker::alarmHandler):
        (KJS::TimeoutChecker::pauseTimeoutCheck):
        (KJS::TimeoutChecker::resumeTimeoutCheck):
        New TimeoutChecker class which handles setting Interpreter::m_timedOut flag after a given
        period of time. This currently only works on Unix platforms where setitimer and signals are used.

        (KJS::Interpreter::Interpreter):
        Initialize new member variables.

        (KJS::Interpreter::~Interpreter):
        Destroy the timeout checker.

        (KJS::Interpreter::startTimeoutCheck):
        (KJS::Interpreter::stopTimeoutCheck):
        (KJS::Interpreter::pauseTimeoutCheck):
        (KJS::Interpreter::resumeTimeoutCheck):
        Call the timeout checker.

        (KJS::Interpreter::handleTimeout):
        Called on timeout. Resets the m_timedOut flag and calls shouldInterruptScript.

        * kjs/interpreter.h:
        (KJS::Interpreter::setTimeoutTime):
        New function for setting the timeout time.

        (KJS::Interpreter::shouldInterruptScript):
        New function. The idea is that this should be overridden by subclasses in order to for example
        pop up a dialog asking the user if the script should be interrupted.

        (KJS::Interpreter::checkTimeout):
        New function which checks the m_timedOut flag and calls handleTimeout if it's set.

        * kjs/nodes.cpp:
        (DoWhileNode::execute):
        (WhileNode::execute):
        (ForNode::execute):
        Call Interpreter::checkTimeout after each iteration of the loop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Hyatt.
commit | commitdiff | tree
adele [Fri, 16 Jun 2006 23:45:07 +0000 (23:45 +0000)]
    Reviewed by Hyatt.

        Adjust padding of inner div so text lines up with text fields.
        Adjust height of textarea so it only leaves room for the horizontal
        scrollbar if overflow is set to scroll, or if overflow is set to
        auto and there's no word wrap.

        These changes will be tested by current layout tests when the
        new textarea implementation takes effect.

        * rendering/RenderTextField.cpp:
        (WebCore::RenderTextField::createDivStyle):
        (WebCore::RenderTextField::calcHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin
commit | commitdiff | tree
sullivan [Fri, 16 Jun 2006 21:49:23 +0000 (21:49 +0000)]
    Reviewed by Darin

        - fixed <rdar://problem/4590062> crash in marker code with particular set of steps on daringfireball.net

        * dom/Document.cpp:
        (WebCore::Document::addMarker):
        Store [it - markers.begin()] in a local variable before modifying markers, since modifying markers can
        change value of [it - markers.begin()].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim O.
commit | commitdiff | tree
thatcher [Fri, 16 Jun 2006 21:10:40 +0000 (21:10 +0000)]
    Reviewed by Tim O.

        Exposes a distributed objects server for clients to register for script debugger calls.
        For preformance concerns this is disabled by default, you will need to enable this per application.
        To enable for Safari do this: defaults write com.apple.Safari WebKitScriptDebuggerEnabled -bool true

        Clients will need to listen to the following distributed notification to discover servers:
        WebScriptDebugServerDidLoadNotification

        To discover servers that previously loaded before the client, the client needs to send the following notification:
        WebScriptDebugServerQueryNotification

        All servers will reply with the WebScriptDebugServerQueryReplyNotification notification that contains the
        registered server connection name to use with distributed objects.

        * DefaultDelegates/WebScriptDebugServer.h: Added.
        * DefaultDelegates/WebScriptDebugServer.m: Added.
        (+[WebScriptDebugServer sharedScriptDebugServer]):
        (-[WebScriptDebugServer init]):
        (-[WebScriptDebugServer dealloc]):
        (-[WebScriptDebugServer serverQuery:]):
        (-[WebScriptDebugServer listenerConnectionDidDie:]):
        (-[WebScriptDebugServer addListener:]):
        (-[WebScriptDebugServer removeListener:]):
        (-[WebScriptDebugServer webView:didParseSource:fromURL:sourceId:forWebFrame:]):
        (-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
        (-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]):
        (-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
        * DefaultDelegates/WebScriptDebugServerPrivate.h: Added.
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge windowObjectCleared]):
        * WebKit.exp:
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebScriptDebugDelegate.m:
        (-[WebScriptCallFrame parsedSource:fromURL:sourceId:]):
        (-[WebScriptCallFrame enteredFrame:sourceId:line:]):
        (-[WebScriptCallFrame hitStatement:sourceId:line:]):
        (-[WebScriptCallFrame leavingFrame:sourceId:line:]):
        * WebView/WebView.m:
        (+[WebView _developerExtrasEnabled]):
        (+[WebView _scriptDebuggerEnabled]):
        (-[WebView _menuForElement:defaultItems:]):
        (-[WebView _commonInitializationWithFrameName:groupName:]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
commit | commitdiff | tree
adele [Fri, 16 Jun 2006 18:27:54 +0000 (18:27 +0000)]
WebCore:

        Reviewed by Alice.

        Added code to draw Cocoa-like border for textareas instead of just using CSS.

        * WebCore.exp:
        * css/html4.css: Sets a 1px solid border.
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
        * rendering/RenderThemeMac.h: Formatting changes.
        * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintTextArea):
        Uses new wkDrawBezeledTextArea to draw border.

WebKit:

        Reviewed by Alice.

        Added initialization for WKDrawBezeledTextArea.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):

WebKitLibraries:

        Reviewed by Alice.

        * WebKitSystemInterface.h: Added WKDrawBezeledTextArea().
        * libWebKitSystemInterface.a: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
commit | commitdiff | tree
adele [Fri, 16 Jun 2006 17:02:30 +0000 (17:02 +0000)]
    Reviewed by Maciej.

        Adding missing expected result for test from yesterday.

        * fast/events/window-load-capture-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
commit | commitdiff | tree
ddkilzer [Fri, 16 Jun 2006 13:13:55 +0000 (13:13 +0000)]
LayoutTests:

        Reviewed by hyatt.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9432
          REGRESSION: crash in capitalization code due to empty-string generated content

        * fast/text/capitalize-empty-generated-string-expected.checksum: Added.
        * fast/text/capitalize-empty-generated-string-expected.png: Added.
        * fast/text/capitalize-empty-generated-string-expected.txt: Added.
        * fast/text/capitalize-empty-generated-string.html: Added.

WebCore:

        Reviewed by hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9432
          REGRESSION: crash in capitalization code due to empty-string generated content

        Test: fast/text/capitalize-empty-generated-string.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::setText): Skip empty-string text renderers when
        looking for the previous character.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
commit | commitdiff | tree
justing [Fri, 16 Jun 2006 00:45:02 +0000 (00:45 +0000)]
LayoutTests:

        Reviewed by levi

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8637>
        REGRESSION (11-16-05): Selection gaps left behind after delete

        * fast/repaint/selection-after-delete-expected.checksum: Added.
        * fast/repaint/selection-after-delete-expected.png: Added.
        * fast/repaint/selection-after-delete-expected.txt: Added.
        * fast/repaint/selection-after-delete.html: Added.
        * fast/repaint/selection-after-remove-expected.checksum: Added.
        * fast/repaint/selection-after-remove-expected.png: Added.
        * fast/repaint/selection-after-remove-expected.txt: Added.
        * fast/repaint/selection-after-remove.html: Added.

WebCore:

        Reviewed by levi

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8637>
        REGRESSION (11-16-05): Selection gaps left behind after delete

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::nodeWillBeRemoved): Invalidate the selection so that
        selection gaps are invalidated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
commit | commitdiff | tree
thatcher [Thu, 15 Jun 2006 22:33:56 +0000 (22:33 +0000)]
JavaScriptCore:

        Reviewed by Geoff and Darin.

        Prefer the DWARF debugging symbols format for use in Xcode 2.3.

        * JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

        Reviewed by Geoff and Darin.

        Prefer the DWARF debugging symbols format for use in Xcode 2.3.

        * JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

        Reviewed by Geoff and Darin.

        Prefer the DWARF debugging symbols format for use in Xcode 2.3.

        * WebCore.xcodeproj/project.pbxproj:

WebKit:

        Reviewed by Geoff and Darin.

        Prefer the DWARF debugging symbols format for use in Xcode 2.3.

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoAnd now with the ugly line gone, and the proper expected test results
commit | commitdiff | tree
jdevalk [Thu, 15 Jun 2006 22:31:25 +0000 (22:31 +0000)]
And now with the ugly line gone, and the proper expected test results

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoupdate testresults
commit | commitdiff | tree
jdevalk [Thu, 15 Jun 2006 22:28:48 +0000 (22:28 +0000)]
update testresults

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
commit | commitdiff | tree
justing [Thu, 15 Jun 2006 22:26:52 +0000 (22:26 +0000)]
LayoutTests:

        Reviewed by harrison

        * editing/deleting/pruning-after-merge-2-expected.checksum: Added.
        * editing/deleting/pruning-after-merge-2-expected.png: Added.
        * editing/deleting/pruning-after-merge-2-expected.txt: Added.
        * editing/deleting/pruning-after-merge-2.html: Added.

WebCore:

        Reviewed by harrison

        * editing/CompositeEditCommand.cpp:
        (WebCore::hasARenderedDescendant):
        (WebCore::CompositeEditCommand::prune): Ascend using the DOM
        (WebCore::CompositeEditCommand::moveParagraphs): Placeholder insertion
        during deletion is fixed, removing the fall back.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoAdding :lang support, patch by Nicholas Shanks, review by Hyatt
commit | commitdiff | tree
jdevalk [Thu, 15 Jun 2006 21:37:13 +0000 (21:37 +0000)]
Adding :lang support, patch by Nicholas Shanks, review by Hyatt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoImprove wording of first paragraph of index.html
commit | commitdiff | tree
jdevalk [Thu, 15 Jun 2006 21:09:32 +0000 (21:09 +0000)]
Improve wording of first paragraph of index.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
commit | commitdiff | tree
justing [Thu, 15 Jun 2006 20:05:00 +0000 (20:05 +0000)]
LayoutTests:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=9456>
        REGRESSION (417.9.2-420+): Cmd-G doesn't work in Safari after double-click and Cmd-E

        * editing/execCommand/findString-2-expected.checksum: Added.
        * editing/execCommand/findString-2-expected.png: Added.
        * editing/execCommand/findString-2-expected.txt: Added.
        * editing/execCommand/findString-2.html: Added.

WebCore:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=9456>
        REGRESSION (417.9.2-420+): Cmd-G doesn't work in Safari after double-click and Cmd-E

        * page/Frame.cpp:
        (WebCore::Frame::findString): When comparing the found range with
        what's currently selected a) build a selection with the found
        range to remove collapsed whitespace and b) compare ranges
        instead of selection objects to ignore the way that the
        current selection was made (to ignore the base and extent).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim O.
commit | commitdiff | tree
sullivan [Thu, 15 Jun 2006 17:37:44 +0000 (17:37 +0000)]
    Reviewed by Tim O.

        Fixed bug in WebKit support for computing but not highlighting rects for text matches.

        * WebView/WebView.m:
        (-[WebView rectsForTextMatches]):
        leave out empty rects, and convert rects to WebView coordinates. Since this makes a batch
        of autoreleased NSValue objects, use a local autorelease pool

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John Sullivan.
commit | commitdiff | tree
sullivan [Thu, 15 Jun 2006 13:37:17 +0000 (13:37 +0000)]
    Reviewed by John Sullivan.

        * Plugins/WebPluginController.m:
        (-[WebPluginController _cancelOutstandingChecks]):
        add nil check before calling CFSetApplyFunction

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
commit | commitdiff | tree
ddkilzer [Thu, 15 Jun 2006 11:12:18 +0000 (11:12 +0000)]
WebCore:

        Reviewed by mjs.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9382
        IDL files missing copyright/license headers

        Add Apple BSD license and copyright to IDL files.

        * ksvg2/bindings/idl/svg/GetSVGDocument.idl:
        * ksvg2/bindings/idl/svg/SVGAElement.idl:
        * ksvg2/bindings/idl/svg/SVGAnimateColorElement.idl:
        * ksvg2/bindings/idl/svg/SVGAnimateElement.idl:
        * ksvg2/bindings/idl/svg/SVGAnimateTransformElement.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedAngle.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedBoolean.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedEnumeration.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedInteger.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedLengthList.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedNumber.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedNumberList.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedPathData.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedPoints.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedPreserveAspectRatio.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedRect.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedString.idl:
        * ksvg2/bindings/idl/svg/SVGAnimatedTransformList.idl:
        * ksvg2/bindings/idl/svg/SVGAnimationElement.idl:
        * ksvg2/bindings/idl/svg/SVGCircleElement.idl:
        * ksvg2/bindings/idl/svg/SVGClipPathElement.idl:
        * ksvg2/bindings/idl/svg/SVGComponentTransferFunctionElement.idl:
        * ksvg2/bindings/idl/svg/SVGCursorElement.idl:
        * ksvg2/bindings/idl/svg/SVGDOMImplementation.idl:
        * ksvg2/bindings/idl/svg/SVGDefsElement.idl:
        * ksvg2/bindings/idl/svg/SVGDescElement.idl:
        * ksvg2/bindings/idl/svg/SVGElementInstance.idl:
        * ksvg2/bindings/idl/svg/SVGElementInstanceList.idl:
        * ksvg2/bindings/idl/svg/SVGEllipseElement.idl:
        * ksvg2/bindings/idl/svg/SVGEvent.idl:
        * ksvg2/bindings/idl/svg/SVGException.idl:
        * ksvg2/bindings/idl/svg/SVGExternalResourcesRequired.idl:
        * ksvg2/bindings/idl/svg/SVGFEBlendElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEColorMatrixElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEComponentTransferElement.idl:
        * ksvg2/bindings/idl/svg/SVGFECompositeElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEFloodElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEFuncAElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEFuncBElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEFuncGElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEFuncRElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEGaussianBlurElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEImageElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEMergeElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEMergeNodeElement.idl:
        * ksvg2/bindings/idl/svg/SVGFEOffsetElement.idl:
        * ksvg2/bindings/idl/svg/SVGFETileElement.idl:
        * ksvg2/bindings/idl/svg/SVGFETurbulenceElement.idl:
        * ksvg2/bindings/idl/svg/SVGFilterElement.idl:
        * ksvg2/bindings/idl/svg/SVGFilterPrimitiveStandardAttributes.idl:
        * ksvg2/bindings/idl/svg/SVGFitToViewBox.idl:
        * ksvg2/bindings/idl/svg/SVGGElement.idl:
        * ksvg2/bindings/idl/svg/SVGGradientElement.idl:
        * ksvg2/bindings/idl/svg/SVGICCColor.idl:
        * ksvg2/bindings/idl/svg/SVGImageElement.idl:
        * ksvg2/bindings/idl/svg/SVGLangSpace.idl:
        * ksvg2/bindings/idl/svg/SVGLengthList.idl:
        * ksvg2/bindings/idl/svg/SVGLineElement.idl:
        * ksvg2/bindings/idl/svg/SVGLinearGradientElement.idl:
        * ksvg2/bindings/idl/svg/SVGLocatable.idl:
        * ksvg2/bindings/idl/svg/SVGMarkerElement.idl:
        * ksvg2/bindings/idl/svg/SVGNumberList.idl:
        * ksvg2/bindings/idl/svg/SVGPaint.idl:
        * ksvg2/bindings/idl/svg/SVGPathElement.idl:
        * ksvg2/bindings/idl/svg/SVGPathSeg.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegArc.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegClosePath.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubic.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubicSmooth.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadratic.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadraticSmooth.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegLineto.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegLinetoHorizontal.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegLinetoVertical.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegList.idl:
        * ksvg2/bindings/idl/svg/SVGPathSegMoveto.idl:
        * ksvg2/bindings/idl/svg/SVGPatternElement.idl:
        * ksvg2/bindings/idl/svg/SVGPointList.idl:
        * ksvg2/bindings/idl/svg/SVGPolygonElement.idl:
        * ksvg2/bindings/idl/svg/SVGPolylineElement.idl:
        * ksvg2/bindings/idl/svg/SVGPreserveAspectRatio.idl:
        * ksvg2/bindings/idl/svg/SVGRadialGradientElement.idl:
        * ksvg2/bindings/idl/svg/SVGRectElement.idl:
        * ksvg2/bindings/idl/svg/SVGRenderingIntent.idl:
        * ksvg2/bindings/idl/svg/SVGScriptElement.idl:
        * ksvg2/bindings/idl/svg/SVGSetElement.idl:
        * ksvg2/bindings/idl/svg/SVGStopElement.idl:
        * ksvg2/bindings/idl/svg/SVGStringList.idl:
        * ksvg2/bindings/idl/svg/SVGStylable.idl:
        * ksvg2/bindings/idl/svg/SVGStyleElement.idl:
        * ksvg2/bindings/idl/svg/SVGSwitchElement.idl:
        * ksvg2/bindings/idl/svg/SVGSymbolElement.idl:
        * ksvg2/bindings/idl/svg/SVGTSpanElement.idl:
        * ksvg2/bindings/idl/svg/SVGTests.idl:
        * ksvg2/bindings/idl/svg/SVGTextContentElement.idl:
        * ksvg2/bindings/idl/svg/SVGTextElement.idl:
        * ksvg2/bindings/idl/svg/SVGTextPositioningElement.idl:
        * ksvg2/bindings/idl/svg/SVGTitleElement.idl:
        * ksvg2/bindings/idl/svg/SVGTransformList.idl:
        * ksvg2/bindings/idl/svg/SVGTransformable.idl:
        * ksvg2/bindings/idl/svg/SVGURIReference.idl:
        * ksvg2/bindings/idl/svg/SVGUnitTypes.idl:
        * ksvg2/bindings/idl/svg/SVGUseElement.idl:
        * ksvg2/bindings/idl/svg/SVGViewElement.idl:
        * ksvg2/bindings/idl/svg/SVGZoomAndPan.idl:
        * ksvg2/bindings/idl/svg/SVGZoomEvent.idl:
        * ksvg2/svg/SVGAnimatedLength.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
commit | commitdiff | tree
justing [Thu, 15 Jun 2006 00:12:49 +0000 (00:12 +0000)]
LayoutTests:

        Reviewed by levi

        <rdar://problem/4439248>
        REGRESSION(412-417): [RTL] Serious problem with RTL signatures in Mail.app in 10.4.4 (7766)

        * editing/pasteboard/copy-paste-bidi-expected.checksum: Added.
        * editing/pasteboard/copy-paste-bidi-expected.png: Added.
        * editing/pasteboard/copy-paste-bidi-expected.txt: Added.
        * editing/pasteboard/copy-paste-bidi.html: Added.

WebCore:

        Reviewed by levi

        <rdar://problem/4439248>
        REGRESSION(412-417): [RTL] Serious problem with RTL signatures in Mail.app in 10.4.4 (7766)

        * editing/markup.cpp:
        (WebCore::renderedText): Use plainText so that we'll pull rendered text but in DOM order.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
commit | commitdiff | tree
justing [Wed, 14 Jun 2006 23:23:50 +0000 (23:23 +0000)]
LayoutTests:

        Reviewed by justin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
        TinyMCE: Implement execCommand(formatBlock, ...)

        * editing/deleting/delete-ws-fixup-002-expected.checksum:
        * editing/deleting/delete-ws-fixup-002-expected.png:
        * editing/deleting/delete-ws-fixup-002-expected.txt:
        * editing/deleting/delete-ws-fixup-002.html:
        * editing/execCommand/format-block-expected.checksum: Added.
        * editing/execCommand/format-block-expected.png: Added.
        * editing/execCommand/format-block-expected.txt: Added.
        * editing/execCommand/format-block-from-range-selection-expected.checksum: Added.
        * editing/execCommand/format-block-from-range-selection-expected.png: Added.
        * editing/execCommand/format-block-from-range-selection-expected.txt: Added.
        * editing/execCommand/format-block-from-range-selection.html: Added.
        * editing/execCommand/format-block.html: Added.

WebCore:

        Reviewed by justin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
        TinyMCE: Implement execCommand(formatBlock, ...)

        * WebCore.xcodeproj/project.pbxproj: Added FormatBlock.{h,cpp} to the project.
        * WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
        * bridge/mac/WebCoreFrameBridge.h: Added WebUndoActions
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraph): Added a preserveStyle bool.
        (WebCore::CompositeEditCommand::moveParagraphs): Ditto.  downstream() the start
        or else we'll move collapsed whitespace and uncollapse it.
        * editing/CompositeEditCommand.h:
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializePositionData):
        (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Don't update m_endingPosition
        because that's removeNode's responsibility.
        (WebCore::updatePositionForNodeRemoval): Added.
        (WebCore::DeleteSelectionCommand::removeNode): Turned removeFullySelectedNode into a virtual
        overload of removeNode so that we can update positions as we remove nodes.
        (WebCore::updatePositionForTextRemoval): Added.
        (WebCore::DeleteSelectionCommand::deleteTextFromNode):
        (WebCore::DeleteSelectionCommand::handleGeneralDelete):
        (WebCore::DeleteSelectionCommand::fixupWhitespace): Got rid of m_trailingWhitespaceValid
        since m_trailingWhitespace is always valid (we update it as we remove nodes).
        (WebCore::DeleteSelectionCommand::mergeParagraphs):
        (WebCore::DeleteSelectionCommand::doApply): Leading and trailing spaces should
        be fixed if they have collapsed before merging paragraphs.
        * editing/DeleteSelectionCommand.h:
        * editing/EditAction.h:
        (WebCore::):
        * editing/FormatBlockCommand.cpp: Added.
        (WebCore::FormatBlockCommand::FormatBlockCommand):
        (WebCore::FormatBlockCommand::modifyRange): Similar to InsertListCommand::modifyRange().
        (WebCore::FormatBlockCommand::doApply):
        * editing/FormatBlockCommand.h: Added.
        (WebCore::FormatBlockCommand::editingAction):
        * editing/InsertListCommand.h:
        (WebCore::InsertListCommand::editingAction):
        * editing/JSEditor.cpp:
        * editing/MergeIdenticalElementsCommand.cpp:
        (WebCore::MergeIdenticalElementsCommand::doApply):
        * editing/htmlediting.cpp:
        (WebCore::validBlockTag):
        (WebCore::createElement):
        * editing/htmlediting.h:

WebKit:

        Reviewed by justin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
        TinyMCE: Implement execCommand(formatBlock, ...)

        * English.lproj/Localizable.strings:
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge nameForUndoAction:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by John Sullivan.
commit | commitdiff | tree
tomernic [Wed, 14 Jun 2006 22:59:18 +0000 (22:59 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4577988> GC: WebPluginController uses inefficient resurrecting enumeration

        * Plugins/WebPluginController.m:
        (cancelOutstandingCheck):
        (-[WebPluginController _cancelOutstandingChecks]):
        Use CFSetApplyFunction() instead of an enumerator to guard against modifications to the set while enumerating.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
commit | commitdiff | tree
mjs [Wed, 14 Jun 2006 22:21:34 +0000 (22:21 +0000)]
LayoutTests:

        Test case by Anders, reviewed and tweaked by Maciej.

        - fixed <rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work

        * fast/events/window-load-capture.html: Added.

WebCore:

        Reviewed by Anders.

        - fixed <rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchWindowEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Beth.
commit | commitdiff | tree
ggaren [Wed, 14 Jun 2006 21:45:06 +0000 (21:45 +0000)]
    Reviewed by Beth.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=9438
        Someone broke ToT: cannot build

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bindings/runtime_root.h: Changed "Interpreter.h" to "interpreter.h"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Rename RenderSlider to DeprecatedSlider, so that I can start work on
commit | commitdiff | tree
hyatt [Wed, 14 Jun 2006 21:17:46 +0000 (21:17 +0000)]
    Rename RenderSlider to DeprecatedSlider, so that I can start work on
        the new NSView-less slider.

        Reviewed by john

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::createRenderer):
        * rendering/DeprecatedSlider.cpp: Added.
        (WebCore::DeprecatedSlider::DeprecatedSlider):
        (WebCore::DeprecatedSlider::calcMinMaxWidth):
        (WebCore::DeprecatedSlider::updateFromElement):
        (WebCore::DeprecatedSlider::valueChanged):
        * rendering/DeprecatedSlider.h: Added.
        (WebCore::DeprecatedSlider::renderName):
        * rendering/RenderSlider.cpp: Removed.
        * rendering/RenderSlider.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
commit | commitdiff | tree
ggaren [Wed, 14 Jun 2006 05:54:06 +0000 (05:54 +0000)]
LayoutTests:

        Test for createHTMLDocument.

        * fast/dom/implementation-createHTMLDocument-expected.txt: Added.
        * fast/dom/implementation-createHTMLDocument.html: Added.

WebCore:

        Reviewed by Maciej.

        - Fixed <rdar://problem/4562192> Creating a new DOMHTMLDocument
        appears challenging.

        - Added createHTMLDocument to Objc bindings, fixed up implementation
        to comply with the DOM 2 Candidate Recommendation in which is was defined.
        (It never made the final spec.) Also removed use of deprecatedString,
        to avoid unnecessary killing of puppies.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        (-[DOMImplementation createHTMLDocument:]):
        * bindings/objc/DOMPrivate.h:
        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createDocument):
        (WebCore::DOMImplementation::createHTMLDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - fixed up results of the layout test I committed for 4583892,
commit | commitdiff | tree
mjs [Wed, 14 Jun 2006 05:03:16 +0000 (05:03 +0000)]
    - fixed up results of the layout test I committed for 4583892,
        they were guaranteed to fail

        * fast/events/no-window-load-expected.txt:
        * fast/events/resources/greenbox.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago RS by MacDome. Added missing results for this test.
commit | commitdiff | tree
ggaren [Wed, 14 Jun 2006 05:01:56 +0000 (05:01 +0000)]
    RS by MacDome. Added missing results for this test.

        * fast/css/xml-stylesheet-pi-not-in-prolog-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Adele.
commit | commitdiff | tree
aliceli1 [Wed, 14 Jun 2006 01:35:01 +0000 (01:35 +0000)]
    Reviewed by Adele.

        fixed <rdar://problem/4457902> HTMLSelectElement.remove() can't handle an option obj being passed to it, results in hang on http://www.ibc-solar.de/www_ibc/fst_solarmonitoring.jsp

        * bindings/js/kjs_html.cpp:
        (KJS::HTMLElementFunction::callAsFunction):
        support this by converting the argument to an options object
        before passing to remove()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
commit | commitdiff | tree
darin [Wed, 14 Jun 2006 01:33:34 +0000 (01:33 +0000)]
LayoutTests:

        Reviewed by Geoff.

        - test for <rdar://problem/4585333> Changing location for weather on yahoo.com home page redirects to another page

        * fast/events/event-listener-html-non-html-confusion-expected.txt: Added.
        * fast/events/event-listener-html-non-html-confusion.html: Added.

WebCore:

        Reviewed by Geoff.

        - fix <rdar://problem/4585333> Changing location for weather on yahoo.com home page redirects to another page

        This patch fixes a bug where the event listener cache does not distinguish
        HTML and non-HTML listeners. Incorrect behavior where stopPropagation also
        prevented default masked a case of this bug on the yahoo.com home page until
        we fixed bug 5180 on 2005-10-03.

        Test: fast/events/event-listener-html-non-html-confusion.html

        * bindings/js/kjs_window.h: Add additional listener maps for HTML event listeners.

        * bindings/js/kjs_window.cpp:
        (KJS::Window::~Window): Go through the additional maps when clearing the window object
        pointer in event listeners.
        (KJS::Window::getJSEventListener): Look in the HTML or non-HTML map depending on the
        argument passed.
        (KJS::Window::getJSUnprotectedEventListener): Ditto.

        * bindings/js/kjs_events.cpp:
        (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): Add to either the HTML
        or non-HTML map depending on the argument passed.
        (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): Remove from either the
        HTML or non-HTML map depending on whether the HTML flag is set.
        (KJS::JSEventListener::JSEventListener): More of the same.
        (KJS::JSEventListener::~JSEventListener): Ditto.
        (KJS::JSLazyEventListener::parseCode): Same thing here. In a lazy event listener there
        is not a listener at construction time, thus the code here to put the listener into a
        map needs the HTML vs. non-HTML logic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
commit | commitdiff | tree
mjs [Wed, 14 Jun 2006 01:25:42 +0000 (01:25 +0000)]
LayoutTests:

        Reviewed by Geoff.

        - test case for <rdar://problem/4583892> 10.4.7 regression: Hang occurs when attempting to load
        search results at mapquest.com

        * fast/events/no-window-load-expected.txt: Added.
        * fast/events/no-window-load.html: Added.

WebCore:

        Reviewed by Darin.

        <rdar://problem/4583892> 10.4.7 regression: Hang occurs when attempting to load search results at mapquest.com

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchGenericEvent): Don't allow
        "load" events to propagate up to the window. We need this quirk to
        avoid site hangs, because they depend on an old Mozilla bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
commit | commitdiff | tree
antti [Tue, 13 Jun 2006 23:19:33 +0000 (23:19 +0000)]
LayoutTests:

        Reviewed by Hyatt

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9314

        * fast/block/positioning/relative-overflow-block-expected.checksum: Added.
        * fast/block/positioning/relative-overflow-block-expected.png: Added.
        * fast/block/positioning/relative-overflow-block-expected.txt: Added.
        * fast/block/positioning/relative-overflow-block.html: Added.
        * fast/block/positioning/relative-overflow-replaced-expected.checksum: Added.
        * fast/block/positioning/relative-overflow-replaced-expected.png: Added.
        * fast/block/positioning/relative-overflow-replaced-expected.txt: Added.
        * fast/block/positioning/relative-overflow-replaced-float-expected.checksum: Added.
        * fast/block/positioning/relative-overflow-replaced-float-expected.png: Added.
        * fast/block/positioning/relative-overflow-replaced-float-expected.txt: Added.
        * fast/block/positioning/relative-overflow-replaced-float.html: Added.
        * fast/block/positioning/relative-overflow-replaced.html: Added.

WebCore:

        Reviewed by Hyatt.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9314
        Relative positioned block size doesnt update root layer size

        - take relative positioning into account in leftmost/rightmost/lowestPosition()
        - ignore zero width/height boxes in leftmost/rightmost/lowestPosition()
        - split relativePositionOffset() to x and y functions

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::absolutePosition):
        (WebCore::RenderBox::relativePositionOffsetX):
        (WebCore::RenderBox::relativePositionOffsetY):
        (WebCore::RenderBox::lowestPosition):
        (WebCore::RenderBox::rightmostPosition):
        (WebCore::RenderBox::leftmostPosition):
        * rendering/RenderBox.h:
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::lowestPosition):
        (WebCore::RenderFlow::rightmostPosition):
        (WebCore::RenderFlow::leftmostPosition):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPosition):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::offsetLeft):
        (WebCore::RenderObject::offsetTop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
commit | commitdiff | tree
andersca [Tue, 13 Jun 2006 22:20:00 +0000 (22:20 +0000)]
WebCore:

2006-06-13  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Dave Hyatt.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9427
        xml-stylesheet processing instructions outside of the prolog should have no effect.

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::checkStyleSheet):
        Remove todo comment.

        * dom/xml_tokenizer.cpp:
        (WebCore::XMLTokenizer::processingInstruction):
        Only check for style sheet if the root element hasn't yet been encountered.

LayoutTests:

2006-06-13  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Dave Hyatt.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9427

        * fast/css/resources/xml-stylesheet-pi-not-in-prolog.css: Added.
        * fast/css/xml-stylesheet-pi-not-in-prolog.xml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim O.
commit | commitdiff | tree
sullivan [Tue, 13 Jun 2006 22:19:46 +0000 (22:19 +0000)]
    Reviewed by Tim O.

        - fixed <rdar://problem/4498606> REGRESSION (417.8-420+): 3 missing items (but extra separators) in context
        menu in Mail message body

        * WebView/WebView.m:
        (-[WebView _menuForElement:defaultItems:]):
        Add special-case hackery to recover from this SPI -> API mismatch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Clarified my previous ChangeLog entry.
commit | commitdiff | tree
tomernic [Tue, 13 Jun 2006 21:58:14 +0000 (21:58 +0000)]
    Clarified my previous ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Anders.
commit | commitdiff | tree
tomernic [Tue, 13 Jun 2006 21:56:30 +0000 (21:56 +0000)]
    Reviewed by Anders.

        Fixed a recently-introduced assertion failure when handling 404 errors.

        * WebView/WebDataSource.m:
        (-[WebDataSource _handleFallbackContent]):
        Use the -[WebFrame _bridge] instead of -[WebDataSource _bridge].  The former is not valid until the data
        source has been committed, as is the case when the resource fails to load.  The latter is safe to call at
        any time.  This broke last night with Maciej's change to WebFrameResourceLoader.  The old code used to call
        -[WebFrame _bridge].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
commit | commitdiff | tree
andersca [Tue, 13 Jun 2006 13:37:18 +0000 (13:37 +0000)]
WebCore:

2006-06-13  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9406
        REGRESSION: fix for bug 9390 broke two layout tests

        * loader/PluginDocument.cpp:
        (WebCore::PluginTokenizer::writeRawData):
        Call finished() after setting up the document structure so we'll emit onload events.

WebKit:

2006-06-13  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9406
        REGRESSION: fix for bug 9390 broke two layout tests

        * Plugins/WebPluginDatabase.h:
        (-[WebPluginDatabase isMIMETypeRegistered:]):
        Add new function isMIMETypeRegistered which returns whether a given MIME type has a
        plugin registered.

        * Plugins/WebPluginDatabase.m:
        (-[WebPluginDatabase init]):
        Init set of registered MIME types.

        (-[WebPluginDatabase refresh]):
        Add and remove MIME types from the set of registered MIME types when registering and unregistering
        plugin MIME types.

        (-[WebPluginDatabase dealloc]):
        Release set of registered MIME types.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
        Use isMIMETypeRegistered here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago build fix -- forgot to svn add this file
commit | commitdiff | tree
ggaren [Tue, 13 Jun 2006 06:37:21 +0000 (06:37 +0000)]
    build fix -- forgot to svn add this file

        * ForwardingHeaders/kjs/SavedBuiltins.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago build fix
commit | commitdiff | tree
ggaren [Tue, 13 Jun 2006 06:27:30 +0000 (06:27 +0000)]
    build fix

        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject throwException:]): Restore assignment I accidentally
        deleted in previous commit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
commit | commitdiff | tree
beidson [Tue, 13 Jun 2006 06:10:56 +0000 (06:10 +0000)]
    Reviewed by Maciej.

        Fixed a bug in append(char) and append(UChar) where our intended copy-on-write semantics was ignored!

        * platform/String.cpp:
        (WebCore::String::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
commit | commitdiff | tree
ggaren [Tue, 13 Jun 2006 06:08:52 +0000 (06:08 +0000)]
JavaScriptCore:

        Reviewed by TimO, Maciej.

        - Merged InterpreterImp code into Interpreter, which implements
        all interpreter functionality now. This is part of my continuing quest
        to create an external notion of JS "execution context" that is unified and simple --
        something to replace the mix of Context, ContextImp, ExecState, Interpreter,
        InterpreterImp, and JSRun.

        All tests pass. Leaks test has not regressed from its baseline ~207 leaks
        with ~3460 leaked nodes.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bindings/NP_jsobject.cpp:
        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject throwException:]):
        * bindings/runtime_root.cpp:
        * bindings/runtime_root.h:
        * kjs/Context.cpp:
        (KJS::Context::Context):
        * kjs/ExecState.cpp: Added.
        (KJS::ExecState::lexicalInterpreter):
        * kjs/ExecState.h: Added.
        (KJS::ExecState::dynamicInterpreter):
        * kjs/SavedBuiltins.h: Added.
        * kjs/bool_object.cpp:
        (BooleanPrototype::BooleanPrototype):
        * kjs/collector.cpp:
        (KJS::Collector::collect):
        (KJS::Collector::numInterpreters):
        * kjs/context.h:
        * kjs/debugger.cpp:
        (Debugger::attach):
        (Debugger::detach):
        * kjs/function.cpp:
        (KJS::FunctionImp::callAsFunction):
        (KJS::GlobalFuncImp::callAsFunction):
        * kjs/function_object.cpp:
        (FunctionObjectImp::construct):
        * kjs/internal.cpp:
        * kjs/internal.h:
        * kjs/interpreter.cpp:
        (KJS::interpreterMap):
        (KJS::Interpreter::Interpreter):
        (KJS::Interpreter::init):
        (KJS::Interpreter::~Interpreter):
        (KJS::Interpreter::globalObject):
        (KJS::Interpreter::initGlobalObject):
        (KJS::Interpreter::globalExec):
        (KJS::Interpreter::checkSyntax):
        (KJS::Interpreter::evaluate):
        (KJS::Interpreter::builtinObject):
        (KJS::Interpreter::builtinFunction):
        (KJS::Interpreter::builtinArray):
        (KJS::Interpreter::builtinBoolean):
        (KJS::Interpreter::builtinString):
        (KJS::Interpreter::builtinNumber):
        (KJS::Interpreter::builtinDate):
        (KJS::Interpreter::builtinRegExp):
        (KJS::Interpreter::builtinError):
        (KJS::Interpreter::builtinObjectPrototype):
        (KJS::Interpreter::builtinFunctionPrototype):
        (KJS::Interpreter::builtinArrayPrototype):
        (KJS::Interpreter::builtinBooleanPrototype):
        (KJS::Interpreter::builtinStringPrototype):
        (KJS::Interpreter::builtinNumberPrototype):
        (KJS::Interpreter::builtinDatePrototype):
        (KJS::Interpreter::builtinRegExpPrototype):
        (KJS::Interpreter::builtinErrorPrototype):
        (KJS::Interpreter::builtinEvalError):
        (KJS::Interpreter::builtinRangeError):
        (KJS::Interpreter::builtinReferenceError):
        (KJS::Interpreter::builtinSyntaxError):
        (KJS::Interpreter::builtinTypeError):
        (KJS::Interpreter::builtinURIError):
        (KJS::Interpreter::builtinEvalErrorPrototype):
        (KJS::Interpreter::builtinRangeErrorPrototype):
        (KJS::Interpreter::builtinReferenceErrorPrototype):
        (KJS::Interpreter::builtinSyntaxErrorPrototype):
        (KJS::Interpreter::builtinTypeErrorPrototype):
        (KJS::Interpreter::builtinURIErrorPrototype):
        (KJS::Interpreter::mark):
        (KJS::Interpreter::interpreterWithGlobalObject):
        (KJS::Interpreter::saveBuiltins):
        (KJS::Interpreter::restoreBuiltins):
        * kjs/interpreter.h:
        (KJS::Interpreter::setCompatMode):
        (KJS::Interpreter::compatMode):
        (KJS::Interpreter::firstInterpreter):
        (KJS::Interpreter::nextInterpreter):
        (KJS::Interpreter::prevInterpreter):
        (KJS::Interpreter::debugger):
        (KJS::Interpreter::setDebugger):
        (KJS::Interpreter::setContext):
        (KJS::Interpreter::context):
        * kjs/nodes.cpp:
        (StatementNode::hitStatement):
        (RegExpNode::evaluate):
        * kjs/protect.h:

JavaScriptGlue:

        Reviewed by TimO, Maciej.

        - JSGlue part of merging InterpreterImp into Interpreter.

        Since there's now a kjs forwarding header, I moved all forwarding
        headers into a "ForwardingHeaders" directory, like in WebCore.

        * ForwardingHeaders: Added.
        * ForwardingHeaders/kjs: Added.
        * ForwardingHeaders/kjs/ExecState.h: Added.
        * ForwardingHeaders/wtf: Added.
        * JavaScriptGlue.xcodeproj/project.pbxproj:
        * config.h:
        * wtf: Removed.
        * wtf/AlwaysInline.h: Removed.
        * wtf/Assertions.h: Removed.
        * wtf/FastMalloc.h: Removed.
        * wtf/Forward.h: Removed.
        * wtf/HashCountedSet.h: Removed.
        * wtf/HashSet.h: Removed.
        * wtf/Noncopyable.h: Removed.
        * wtf/OwnArrayPtr.h: Removed.
        * wtf/OwnPtr.h: Removed.
        * wtf/PassRefPtr.h: Removed.
        * wtf/Platform.h: Removed.
        * wtf/RefPtr.h: Removed.
        * wtf/Vector.h: Removed.

WebCore:

        Reviewed by TimO, Maciej.

        - WebCore part of merging InterpreterImp into Interpreter. No test
        because there's no behavior change.

        A substantive change here is that ScriptInterpreter::mark must now chain to
        Interpreter::mark, since Interpreter needs to mark the things that
        InterpreterImp used to mark.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/kjs_binding.cpp:
        * bindings/js/kjs_window.cpp:
        (KJS::Window::put):
        * bridge/mac/WebCoreFrameBridge.mm:
        * bridge/mac/WebCoreScriptDebugger.mm:
        (-[WebCoreScriptCallFrame evaluateWebScript:]):
        * kwq/KWQPageState.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - fix for cocoa exception (whoops)
commit | commitdiff | tree
mjs [Tue, 13 Jun 2006 05:09:15 +0000 (05:09 +0000)]
    - fix for cocoa exception (whoops)

        * WebView/WebView.m:
        (+[WebView _generatedMIMETypeForURLScheme:]): put this back
        * WebView/WebDataSource.m:
        (+[WebDataSource _generatedMIMETypeForURLScheme:]): call WebView

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
commit | commitdiff | tree
mjs [Tue, 13 Jun 2006 03:36:10 +0000 (03:36 +0000)]
    Reviewed by Darin.

        - remove use of WebView and related from WebMainResourceLoader

        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDataSource.m:
        (+[WebDataSource _generatedMIMETypeForURLScheme:]):
        (+[WebDataSource _representationExistsForURLScheme:]):
        (+[WebDataSource _canShowMIMEType:]):
        (-[WebDataSource _handleFallbackContent]):
        (-[WebDataSource _decidePolicyForMIMEType:decisionListener:]):
        * WebView/WebDataSourceInternal.h:
        * WebView/WebFrame.m:
        (-[WebFrame _isMainFrame]):
        * WebView/WebFrameInternal.h:
        * WebView/WebMainResourceLoader.m:
        (-[WebMainResourceLoader willSendRequest:redirectResponse:]):
        (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
        (-[WebMainResourceLoader checkContentPolicyForResponse:]):
        (-[WebMainResourceLoader loadWithRequestNow:]):
        * WebView/WebView.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
commit | commitdiff | tree
beidson [Tue, 13 Jun 2006 01:04:42 +0000 (01:04 +0000)]
    Reviewed by Maciej.

        Changed String::ascii() to return a Vector<char> instead of const char*
        This allows us to use it "regularly" as the returned vector will destruct
        and not leak memory like the previous approach.
        We can now do a String.ascii().data() to get a char* buffer instead of
        String.deprecatedString().ascii().  It doesn't improve the style much but
        dumping the memory-leak issue is a plus.

        * icon/IconDatabase.cpp:
        (WebCore::IconDatabase::open):
        (WebCore::IconDatabase::clearDatabase):
        * icon/SQLDatabase.cpp:
        (SQLDatabase::open):
        * icon/SQLStatement.cpp:
        (WebCore::SQLStatement::prepare):
        (WebCore::SQLStatement::step):
        (WebCore::SQLStatement::returnTextResults):
        (WebCore::SQLStatement::returnTextResults16):
        (WebCore::SQLStatement::returnIntResults):
        (WebCore::SQLStatement::returnInt64Results):
        (WebCore::SQLStatement::returnDoubleResults):
        In addition to the changes to the string classes, changed my database code over to the new
        preferred method.

        * platform/PlatformString.h:
        * platform/String.cpp:
        (WebCore::String::ascii):
        * platform/StringImpl.cpp:
        (WebCore::StringImpl::ascii):
        * platform/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
commit | commitdiff | tree
tomernic [Tue, 13 Jun 2006 00:27:35 +0000 (00:27 +0000)]
    Reviewed by Maciej.

        <rdar://problem/4526052> intermittent assertion failure in -[WebBasePluginPackage dealloc] running layout tests

        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage _initWithPath:]):
        Renamed from -initWithPath:.  Instead of releasing/deallocating self on error, return NO.
        (-[WebNetscapePluginPackage initWithPath:]):
        Call the new -_initWithPath:.  If it returns NO, unload the plugin package before deallocating it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoAdd selection foreground color on Win32.
commit | commitdiff | tree
hyatt [Mon, 12 Jun 2006 23:03:56 +0000 (23:03 +0000)]
Add selection foreground color on Win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin Adler.
commit | commitdiff | tree
sullivan [Mon, 12 Jun 2006 23:02:20 +0000 (23:02 +0000)]
    Reviewed by Darin Adler.

        * page/Frame.cpp:
        (WebCore::Frame::markAllMatchesForText):
        Do a "fake" paint here so that the rectangles for the text matches will have been
        computed by the time this method returns.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Levi and Tim Omernick.
commit | commitdiff | tree
beidson [Mon, 12 Jun 2006 22:43:46 +0000 (22:43 +0000)]
    Reviewed by Levi and Tim Omernick.

        -Added a skeleton sqlite3 icon database file to IconDatabase
        -Added functionality to validate and recreate this icon.db file
        -Fixed some buggys in SQLDatabase.cpp

        * icon/IconDatabase.cpp:
        (WebCore::IconDatabase::open):
        (WebCore::IconDatabase::isValidDatabase):
        (WebCore::IconDatabase::clearDatabase):
        (WebCore::IconDatabase::recreateDatabase):
        * icon/IconDatabase.h:

        * icon/SQLStatement.cpp:
        (WebCore::SQLStatement::columnCount):
        (WebCore::SQLStatement::getColumnName):
        (WebCore::SQLStatement::getColumnName16):
        (WebCore::SQLStatement::getColumnText):
        (WebCore::SQLStatement::getColumnText16):
        (WebCore::SQLStatement::getColumnDouble):
        (WebCore::SQLStatement::getColumnInt):
        (WebCore::SQLStatement::getColumnInt64):
        (WebCore::SQLStatement::getColumnBlob):
        -Added checks to make sure we had a valid working sqlite3_statement as the sqlite3_*
        function calls weren't as error-tolerant as documentation advertised
        (maybe differences between the 3.3 docs I looked at and the 3.1.3 version installed on OSX)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix Win32 build bustage.
commit | commitdiff | tree
hyatt [Mon, 12 Jun 2006 19:53:53 +0000 (19:53 +0000)]
Fix Win32 build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

next
Mirror of the WebKit open source project from svn.webkit.org.