WebKit-https.git
10 years ago2010-08-25 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Thu, 26 Aug 2010 03:25:24 +0000 (03:25 +0000)]
2010-08-25  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kevin Ollivier.

        [BREWMP] Add build system
        https://bugs.webkit.org/show_bug.cgi?id=44645

        Make waf script portable so that we can add more ports.

        * wscript:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Michael Saboff <msaboff@apple.com>
commit-queue@webkit.org [Thu, 26 Aug 2010 03:09:44 +0000 (03:09 +0000)]
2010-08-25  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        Added new test to check for regression as reported in
        https://bugs.webkit.org/show_bug.cgi?id=44600.

        * fast/js/script-tests/string-split-double-empty.js: Added.
        * fast/js/string-split-double-empty-expected.txt: Added.
        * fast/js/string-split-double-empty.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Michael Nordman <michaeln@google.com>
commit-queue@webkit.org [Thu, 26 Aug 2010 02:54:04 +0000 (02:54 +0000)]
2010-08-25  Michael Nordman  <michaeln@google.com>

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=44133
        IDL bindings for XmlHttpRequest.responseBlob support, doesn't do anything yet.
        Adds two new attributes, asBlob and responseBlob.
        Runtime disabled by default, also behind a new ENABLE_XHR_RESPONSE_BLOB compile time guard.

        No new tests, just adding some stubs.

        * bindings/generic/RuntimeEnabledFeatures.cpp:
        * bindings/generic/RuntimeEnabledFeatures.h:
        (WebCore::RuntimeEnabledFeatures::setResponseBlobEnabled):
        (WebCore::RuntimeEnabledFeatures::responseBlobEnabled):
        (WebCore::RuntimeEnabledFeatures::asBlobEnabled):
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::responseText): Changed to allow an exceptional return path.
        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::V8XMLHttpRequest::responseTextAccessorGetter): Changed to allow an exceptional return path.
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::responseText): Changed to raise an exception when accessed with asBlob set to true.
        (WebCore::XMLHttpRequest::responseXML): Changed to raise an exception when accessed with asBlob set to true.
        (WebCore::XMLHttpRequest::responseBlob): Added stub method, returns 0 for now.
        (WebCore::XMLHttpRequest::setAsBlob): Sets the asBlob attribute, raises exception if called at an inappropriate time.
        (WebCore::XMLHttpRequest::open): Resets asBlob to false, the default value.
        (WebCore::XMLHttpRequest::abort): Clears m_responseBlob.
        (WebCore::XMLHttpRequest::clearResponse): Clears m_responseBlob.
        (WebCore::XMLHttpRequest::didFinishLoading): Added a FIXME to populate m_responseBlob.
        * xml/XMLHttpRequest.h:
        (WebCore::XMLHttpRequest::asBlob):
        * xml/XMLHttpRequest.idl:
2010-08-25  Michael Nordman  <michaeln@google.com>

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=44133
        WebKitAPI to allow runtime enablement of XmlHttpRequest.responseBlob.

        * features.gypi: Define ENABLE_XHR_RESPONSE_BLOB.
        * public/WebRuntimeFeatures.h:
        * src/WebRuntimeFeatures.cpp:
        (WebKit::WebRuntimeFeatures::enableXHRResponseBlob):
        (WebKit::WebRuntimeFeatures::isXHRResponseBlobEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 26 Aug 2010 01:59:10 +0000 (01:59 +0000)]
2010-08-25  Martin Robinson  <mrobinson@igalia.com>

        Skip a test that requires editing delegate dumps.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Adding a means of communication between WebKit/WebCore and
hclam@chromium.org [Thu, 26 Aug 2010 01:45:43 +0000 (01:45 +0000)]
WebCore: Adding a means of communication between WebKit/WebCore and
chromium in order to share video frames. This adds the necessary
WebKit-side classes and methods, but does not actually use them
yet - that will be committed in a separate patch after the
corresponding Chromium side is committed.

Reviewed by Darin Fisher.
Submitted for Victoria Kirst (vrk@google.com).

https://bugs.webkit.org/show_bug.cgi?id=44539

No new tests, as these new classes/APIs are not yet used.

* platform/graphics/chromium/VideoFrameChromium.h: Added.
(WebCore::VideoFrameChromium::):
* platform/graphics/chromium/VideoFrameProvider.h: Added.
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::create):
(WebCore::VideoLayerChromium::VideoLayerChromium):
* platform/graphics/chromium/VideoLayerChromium.h:

WebKit/chromium: Adding a way to communicate video frames between Chromium and WebKit.
The WebKit side acts as a middleman between Chromium and WebCore.
The VideoFrameChromiumImpl is not being used by WebCore yet, as there
still needs to be an implementation of WebVideoFrame in Chromium
-- coming soon in a subsequent patch.

Reviewed by Darin Fisher.
Submitted for Victoria Kirst (vrk@google.com).

API changes for Video Frame sharing between WebKit and Chromium
https://bugs.webkit.org/show_bug.cgi?id=44539

* WebKit.gyp:
* public/WebMediaPlayer.h:
(WebKit::WebMediaPlayer::getCurrentFrame):
(WebKit::WebMediaPlayer::putCurrentFrame):
* public/WebVideoFrame.h: Added.
* src/VideoFrameChromiumImpl.cpp: Added.
(WebKit::VideoFrameChromiumImpl::toWebVideoFrame):
(WebKit::VideoFrameChromiumImpl::VideoFrameChromiumImpl):
(WebKit::VideoFrameChromiumImpl::type):
(WebKit::VideoFrameChromiumImpl::format):
(WebKit::VideoFrameChromiumImpl::width):
(WebKit::VideoFrameChromiumImpl::height):
(WebKit::VideoFrameChromiumImpl::planes):
(WebKit::VideoFrameChromiumImpl::stride):
(WebKit::VideoFrameChromiumImpl::data):
* src/VideoFrameChromiumImpl.h: Added.
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::create):
* src/WebMediaPlayerClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 26 Aug 2010 01:39:33 +0000 (01:39 +0000)]
2010-08-25  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        confirm dialog should show OK/Cancel instead of Yes/No for consistency
        https://bugs.webkit.org/show_bug.cgi?id=32877

        Change the button labels for the fallback confirmation dialog to be
        OK and Cancel.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_script_dialog):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 26 Aug 2010 01:37:17 +0000 (01:37 +0000)]
2010-08-25  Martin Robinson  <mrobinson@igalia.com>

        Updating webkitpy test expectations.

        * Scripts/webkitpy/tool/steps/steps_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 26 Aug 2010 01:00:25 +0000 (01:00 +0000)]
2010-08-25  Kenneth Russell  <kbr@google.com>

        Reviewed by Simon Fraser.

        Source data passed to TypedArray creators should be const
        https://bugs.webkit.org/show_bug.cgi?id=44649

        Compiled and ran existing WebGL tests to verify.

        * html/canvas/Float32Array.cpp:
        (WebCore::Float32Array::create):
        * html/canvas/Float32Array.h:
        * html/canvas/TypedArrayBase.h:
        (WebCore::TypedArrayBase::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 26 Aug 2010 00:40:51 +0000 (00:40 +0000)]
2010-08-25  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        fix the always squash git config
        https://bugs.webkit.org/show_bug.cgi?id=44651

        Fix help text and apparently underscores are not allowed
        in git config keys.

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/tool/steps/commit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Thu, 26 Aug 2010 00:40:10 +0000 (00:40 +0000)]
2010-08-25  Chris Marrin  <cmarrin@apple.com>

        Unreviewed.

        Skipping a couple of compositing tests because layerTreeAsText() is not implemented on Wk2 yet.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 26 Aug 2010 00:33:40 +0000 (00:33 +0000)]
2010-08-25  Eric Seidel  <eric@webkit.org>

        Unreviewed, just removing a dead enum.

        Remove endTagRequirement now that the LegacyHTMLDocumentParser is dead
        https://bugs.webkit.org/show_bug.cgi?id=44626

        Remove HTMLTagStatus since it's not used anymore.

        * html/HTMLElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: CSS first letter text transform causes crash
cfleizach@apple.com [Thu, 26 Aug 2010 00:31:19 +0000 (00:31 +0000)]
AX: CSS first letter text transform causes crash
https://bugs.webkit.org/show_bug.cgi?id=44352

Reviewed by David Kilzer.

WebCore:

Test: accessibility/first-letter-text-transform-causes-crash.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::nextContinuation):

LayoutTests:

* accessibility/first-letter-text-transform-causes-crash-expected.txt: Added.
* accessibility/first-letter-text-transform-causes-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 26 Aug 2010 00:23:14 +0000 (00:23 +0000)]
2010-08-25  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Build fix.

        Make Chromiums Broken WebPageSerializerImpl compile again
        https://bugs.webkit.org/show_bug.cgi?id=44652

        Make it compile again.  This code is still horribly wrong.

        * src/WebPageSerializerImpl.cpp:
        (WebKit::WebPageSerializerImpl::endTagToString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* Scripts/commit-log-editor: Fix perl warning for people who have no
darin@apple.com [Thu, 26 Aug 2010 00:10:20 +0000 (00:10 +0000)]
* Scripts/commit-log-editor: Fix perl warning for people who have no
value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.

Reviewed by John Sullivan.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 26 Aug 2010 00:07:42 +0000 (00:07 +0000)]
2010-08-25  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        stop blocking commits when the bots are red
        https://bugs.webkit.org/show_bug.cgi?id=44644

        This check currently is just annoying. It doesn't actually
        help keep the tree green. We can always add it back later
        if we decide the tree is generally more green.

        * Scripts/webkitpy/tool/commands/download_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 26 Aug 2010 00:02:46 +0000 (00:02 +0000)]
2010-08-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Remove endTagRequirement now that the LegacyHTMLDocumentParser is dead
        https://bugs.webkit.org/show_bug.cgi?id=44626

        Serialization is covered by a bunch of tests.  innerHTML behavior is sadly not.
        In either case, this is just moving code and should have no functional change.

        * editing/markup.cpp:
        (WebCore::elementCannotHaveEndTag):
        (WebCore::MarkupAccumulator::shouldSelfClose):
        (WebCore::MarkupAccumulator::appendEndMarkup):
        (WebCore::serializeNodesWithNamespaces):
        * html/HTMLAnchorElement.h:
        * html/HTMLAreaElement.h:
        * html/HTMLBRElement.h:
        * html/HTMLBaseElement.h:
        * html/HTMLBaseFontElement.h:
        * html/HTMLBlockquoteElement.h:
        * html/HTMLBodyElement.h:
        * html/HTMLCanvasElement.cpp:
        * html/HTMLCanvasElement.h:
        * html/HTMLDListElement.h:
        * html/HTMLDataGridCellElement.h:
        * html/HTMLDataGridColElement.h:
        * html/HTMLDirectoryElement.h:
        * html/HTMLDivElement.h:
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::nodeName):
        (WebCore::HTMLElement::ieForbidsInsertHTML):
        (WebCore::HTMLElement::deprecatedCreateContextualFragment):
        (WebCore::HTMLElement::setInnerText):
        (WebCore::HTMLElement::setOuterText):
        * html/HTMLElement.h:
        * html/HTMLEmbedElement.h:
        * html/HTMLFontElement.h:
        * html/HTMLFormControlElement.h:
        * html/HTMLFormElement.h:
        * html/HTMLFrameElement.h:
        * html/HTMLFrameSetElement.h:
        * html/HTMLHRElement.h:
        * html/HTMLHeadElement.h:
        * html/HTMLHeadingElement.h:
        * html/HTMLHtmlElement.h:
        * html/HTMLIFrameElement.h:
        * html/HTMLImageElement.h:
        * html/HTMLInputElement.h:
        * html/HTMLIsIndexElement.h:
        * html/HTMLLIElement.h:
        * html/HTMLLinkElement.h:
        * html/HTMLMapElement.h:
        * html/HTMLMarqueeElement.h:
        * html/HTMLMenuElement.h:
        * html/HTMLMetaElement.h:
        * html/HTMLModElement.h:
        * html/HTMLOListElement.h:
        * html/HTMLOptionElement.h:
        * html/HTMLParagraphElement.h:
        * html/HTMLParamElement.h:
        * html/HTMLPlugInElement.h:
        * html/HTMLPreElement.h:
        * html/HTMLQuoteElement.h:
        * html/HTMLScriptElement.h:
        * html/HTMLSourceElement.h:
        * html/HTMLStyleElement.h:
        * html/HTMLTableCaptionElement.h:
        * html/HTMLTableCellElement.h:
        * html/HTMLTableColElement.cpp:
        * html/HTMLTableColElement.h:
        * html/HTMLTableElement.h:
        * html/HTMLTableRowElement.h:
        * html/HTMLTableSectionElement.h:
        * html/HTMLUListElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 25 Aug 2010 23:55:52 +0000 (23:55 +0000)]
2010-08-25  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        test conversion: editing/style/typing-style-003.html should use runDumpAsTextEditingTest instead of runEditingTest
        https://bugs.webkit.org/show_bug.cgi?id=44646

        * editing/style/typing-style-003-expected.txt: Added.
        * editing/style/typing-style-003.html: Calls runDumpAsTextEditingTest instead of runEditingTest.
        * platform/chromium-linux/editing/style/typing-style-003-expected.checksum: Removed.
        * platform/chromium-win/editing/style/typing-style-003-expected.checksum: Removed.
        * platform/chromium-win/editing/style/typing-style-003-expected.png: Removed.
        * platform/chromium-win/editing/style/typing-style-003-expected.txt: Removed.
        * platform/gtk/editing/style/typing-style-003-expected.txt: Removed.
        * platform/mac/editing/style/typing-style-003-expected.checksum: Removed.
        * platform/mac/editing/style/typing-style-003-expected.png: Removed.
        * platform/mac/editing/style/typing-style-003-expected.txt: Removed.
        * platform/qt/Skipped: Run typing-style-003.html on qt again.
        * platform/qt/editing/style/typing-style-003-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-20 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 25 Aug 2010 23:40:58 +0000 (23:40 +0000)]
2010-08-20  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        WebGL must enforce restrictions even if running on OpenGL ES 2.0
        https://bugs.webkit.org/show_bug.cgi?id=42908

        * public/WebGraphicsContext3D.h: Add two new flags.
        * src/GraphicsContext3D.cpp: Ditto.
        (WebCore::GraphicsContext3DInternal::isGLES2NPOTStrict):
        (WebCore::GraphicsContext3DInternal::isErrorGeneratedOnOutOfBoundsAccesses):
        (WebCore::GraphicsContext3D::isGLES2NPOTStrict):
        (WebCore::GraphicsContext3D::isErrorGeneratedOnOutOfBoundsAccesses):
        * src/WebGraphicsContext3DDefaultImpl.cpp: Ditto.
        (WebKit::WebGraphicsContext3DDefaultImpl::isGLES2NPOTStrict):
        (WebKit::WebGraphicsContext3DDefaultImpl::isErrorGeneratedOnOutOfBoundsAccesses):
        * src/WebGraphicsContext3DDefaultImpl.h: Ditto.
2010-08-20  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        WebGL must enforce restrictions even if running on OpenGL ES 2.0
        https://bugs.webkit.org/show_bug.cgi?id=42908

        * html/canvas/WebGLFramebuffer.cpp:
        (WebCore::WebGLFramebuffer::getColorBufferFormat): Get format at given level instead of 0.
        * html/canvas/WebGLRenderingContext.cpp: Add two new flags and use them to replace the original isGLES2Compliant().
        (WebCore::WebGLRenderingContext::WebGLRenderingContext):
        (WebCore::WebGLRenderingContext::bindTexture):
        (WebCore::WebGLRenderingContext::blendEquation):
        (WebCore::WebGLRenderingContext::blendEquationSeparate):
        (WebCore::WebGLRenderingContext::bufferData):
        (WebCore::WebGLRenderingContext::bufferSubData):
        (WebCore::WebGLRenderingContext::checkFramebufferStatus):
        (WebCore::WebGLRenderingContext::clear):
        (WebCore::WebGLRenderingContext::copyTexImage2D):
        (WebCore::WebGLRenderingContext::copyTexSubImage2D):
        (WebCore::WebGLRenderingContext::disable):
        (WebCore::WebGLRenderingContext::drawArrays):
        (WebCore::WebGLRenderingContext::drawElements):
        (WebCore::WebGLRenderingContext::enable):
        (WebCore::WebGLRenderingContext::generateMipmap):
        (WebCore::WebGLRenderingContext::hint):
        (WebCore::WebGLRenderingContext::isEnabled):
        (WebCore::WebGLRenderingContext::texImage2DBase):
        (WebCore::WebGLRenderingContext::texParameter):
        (WebCore::WebGLRenderingContext::isGLES2NPOTStrict):
        (WebCore::WebGLRenderingContext::isErrorGeneratedOnOutOfBoundsAccesses):
        * html/canvas/WebGLRenderingContext.h: Declare two new flags.
        * html/canvas/WebGLTexture.cpp: Get format at given level instead of 0.
        (WebCore::WebGLTexture::getInternalFormat):
        * html/canvas/WebGLTexture.h: Ditto.
        * platform/graphics/GraphicsContext3D.h: Add three new flags.
        * platform/graphics/mac/GraphicsContext3DMac.mm: Ditto.
        (WebCore::GraphicsContext3D::isGLES2NPOTStrict):
        (WebCore::GraphicsContext3D::isErrorGeneratedOnOutOfBoundsAccesses):
        * platform/graphics/qt/GraphicsContext3DQt.cpp: Ditto.
        (WebCore::GraphicsContext3D::isGLES2NPOTStrict):
        (WebCore::GraphicsContext3D::isErrorGeneratedOnOutOfBoundsAccesses):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Build correction, no review.
bfulgham@webkit.org [Wed, 25 Aug 2010 23:38:58 +0000 (23:38 +0000)]
WebCore: Build correction, no review.

* WebCore.vcproj/WebCore.vcproj: Add missing implementation
  for PlatformRefPtrCairo.

WebKit2: Build fix, no review.

Add conditional guards around Safari-specific
include files.

* WebProcess/WebPage/win/WebPageWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 25 Aug 2010 23:37:26 +0000 (23:37 +0000)]
2010-08-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Simon Fraser.

        REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
        https://bugs.webkit.org/show_bug.cgi?id=38912

        I know of nothing else to do but skip all media tests for the cq.

        * Scripts/webkitpy/tool/steps/runtests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Cris Neckar <cdn@chromium.org>
inferno@chromium.org [Wed, 25 Aug 2010 23:10:28 +0000 (23:10 +0000)]
2010-08-25  Cris Neckar  <cdn@chromium.org>

        Reviewed by Darin Adler.

        Added abort condition for RenderCounters when traversing a detached render tree.
        https://bugs.webkit.org/show_bug.cgi?id=43812

        Test: fast/css/counters/counter-traverse-object-crash.html

        * rendering/RenderCounter.cpp:
        (WebCore::findPlaceForCounter):
2010-08-25  Cris Neckar  <cdn@chromium.org>

        Reviewed by Darin Adler.

        Assertion failure in RenderCounter when traversing a detached render trees.
        https://bugs.webkit.org/show_bug.cgi?id=43812

        * fast/css/counters/counter-traverse-object-crash-expected.txt: Added.
        * fast/css/counters/counter-traverse-object-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 25 Aug 2010 22:49:38 +0000 (22:49 +0000)]
2010-08-25  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=44629
        Add layer consistency checking and fix found crashing bug

        The crash was being caused by some of the calls which mutated
        the sublayer list leaving the list in an inconsistent state.
        This eventually lead to a crash. It would also lead to visual
        artifacts if the crash didn't occur. Added consistency checking
        to catch this and any other inconsistencies in the sublayer list.

        The particular bug in this case was caused by clamping an index
        for insertion to the current size of the sublayer list. CACF uses
        an index equal to the current length to indicate an append operation.
        With tiled layers the apparent size of the list is one less than its
        actual size (to accomodate the layer which holds the list of tiles)
        so this clamping was causing the new layer to get inserted before the
        tile parent. The tile parent was then mistaken for a WKCACFLayer and
        it eventually tried to deref that layer, causing the crash.

        I also added some protection when destroying a WKCACFLayer. The user data
        for the corresponding CACFLayer is now changed to 0xDeadBeef rather than
        null. This allows dangling layers to be more easily identified. This
        value is checked and ASSERTed if seen. I also remove the sublayers
        on destruction to make the consistency checks work properly while
        a layer is being destroyed.

        Test: compositing/tiling/crash-reparent-tiled-layer.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 25 Aug 2010 22:17:19 +0000 (22:17 +0000)]
2010-08-25  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: add more unit tests for test_expectations
        This adds unit tests to cover (almost?) all of the non-rebaselining
        functionality.

        https://bugs.webkit.org/show_bug.cgi?id=44579

        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 25 Aug 2010 22:15:47 +0000 (22:15 +0000)]
2010-08-25  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        WebCore::InsertListCommand::modifyRange infinite loop (100% CPU usage)
        https://bugs.webkit.org/show_bug.cgi?id=33668

        The bug was caused by enclosingListChild returning a list child whose enclosing list is
        a sibling of the current list child. Fixed enclosingListChild to traverse upwards
        in the DOM to find the list child which is a sibling of the current list child.
        Also fixed adjacentEnclosingList to only returns the list that belongs to the same outer list.

        In doApplyForSingleParagraph, if the start or the end of currentSelection existed inside a list content
        moved by moveParagraphWithClones, either end could point to a wrong position after the move.
        Fixed this problem by checking this condition upfront and restoring later.

        In doApply, if moveParagraph or moveParagraphWithClones, endOfSelection or startOfLastParagraph
        could be null or orphaned, fixed this problem by indexForVisiblePosition.

        Test: editing/execCommand/insert-list-orphaned-item-with-nested-lists.html

        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::doApply):
        (WebCore::enclosingListChild):
        (WebCore::InsertListCommand::doApplyForSingleParagraph):
        (WebCore::adjacentEnclosingList):
        (WebCore::InsertListCommand::listifyParagraph):
2010-08-25  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        WebCore::InsertListCommand::modifyRange infinite loop (100% CPU usage)
        https://bugs.webkit.org/show_bug.cgi?id=33668

        Added a test to convert nested lists with an orphaned list child to an ordered nested list.
        Selection in switch-list-type-with-inner-list.html is restored correctly after inserting list.

        * editing/execCommand/insert-list-orphaned-item-with-nested-lists-expected.txt: Added.
        * editing/execCommand/insert-list-orphaned-item-with-nested-lists.html: Added.
        * editing/execCommand/switch-list-type-with-inner-list-expected.txt: Selection is restored correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild corrections, no review.
bfulgham@webkit.org [Wed, 25 Aug 2010 21:58:55 +0000 (21:58 +0000)]
Build corrections, no review.

* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  Add include for new (missing) "CairoPath.h" class.
* platform/graphics/cairo/PlatformRefPtrCairo.h: Correct
  include and compilation guards to match coding conventions.
* platform/graphics/win/FontCustomPlatformDataCairo.cpp:
  Change implementation to match CG version, using the
  FontCustomPlatformData name, rather than the original
  FontCustomPlatformDataCairo.
* platform/graphics/win/FontCustomPlatformDataCairo.h:
  Same as for the .cpp file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 25 Aug 2010 21:45:26 +0000 (21:45 +0000)]
2010-08-25  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: add more unit tests

        This change adds more unit tests for the image_diff, test_failures,
        and test_files modules, bringing them to 100% coverage (and adds a
        couple tests to run_webkit_tests while we're at it).

        This test also turns on the "dryrun" port for testing when run on
        the mac, increasing coverage in a few other places.

        https://bugs.webkit.org/show_bug.cgi?id=44578

        * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
        * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
        * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
        * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
        * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
        * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
        * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
        * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
        * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
        * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
        * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 25 Aug 2010 21:41:12 +0000 (21:41 +0000)]
2010-08-25  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: add more unit tests for layout_package/printing.py

        This change adds more unit tests to get the test coverage to 100%
        for the printing module. This code is actually pretty crufty and
        has some layering violations that need to be cleaned up but I'll
        save that for another CL after we get all the unit tests written and
        we fix the multithreading issues. At least now we'll be able to tell
        if we break things.

        https://bugs.webkit.org/show_bug.cgi?id=44576

        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Krzysztof Czech <k.czech@samsung.com>
commit-queue@webkit.org [Wed, 25 Aug 2010 21:27:36 +0000 (21:27 +0000)]
2010-08-25  Krzysztof Czech  <k.czech@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Crash while calling PopupMenuEfl destructor
        https://bugs.webkit.org/show_bug.cgi?id=44497

        Condition checks if m_view is defined
        before popup is hide

        * platform/efl/PopupMenuEfl.cpp:
        (WebCore::PopupMenuEfl::~PopupMenuEfl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 25 Aug 2010 21:16:47 +0000 (21:16 +0000)]
2010-08-25  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        new-run-webkit-tests should respect set-webkit-configuration
        https://bugs.webkit.org/show_bug.cgi?id=44633

        Moves the getting of the configuration into the base Port so that
        chromium ports use it as well. In the downstream chromium port,
        this should still just return Release.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 25 Aug 2010 21:15:34 +0000 (21:15 +0000)]
2010-08-24  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        Creating a link when selecting multiple nodes creates multiple links
        https://bugs.webkit.org/show_bug.cgi?id=30836

        The bug was caused by applyInlineStyleToRange calling addInlineStyleIfNeeded
        on each inline element. Modified applyInlineStyleToRange to call addInlineStyleIfNeeded
        once for all inline elements with the same style difference.

        Because this implies that anchor element may wrap other inline elements when added,
        modified pushDownInlineStyleAroundNode to push down styled elements.

        Removed pushPartiallySelectedAnchorElementsDown from CompositeEditCommand since
        ApplyStyleCommand now correctly pushes down anchors at the start and the end of the selection.

        Test: editing/execCommand/toggle-link.html

        * editing/ApplyStyleCommand.cpp:
        (WebCore::StyleChange::operator==): Added.
        (WebCore::StyleChange::operator!=): Added.
        (WebCore::ApplyStyleCommand::applyInlineStyleToRange): Wraps inline elements with
        the same style difference by one element instead of wrapping each element separately.
        (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Extracts styled element.
        (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Avoids adding styled element.
        (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Pushes down styled element.
        (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): No longer checks inline-ness.
        (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Adds style even when m_removeOnly.
        Callers should set addStyledElement = DoNotAddStyledElement to avoid adding styled element.
        * editing/ApplyStyleCommand.h:
        * editing/CompositeEditCommand.cpp: Removed pushPartiallySelectedAnchorElementsDown.
        * editing/CompositeEditCommand.h: Removed pushPartiallySelectedAnchorElementsDown.
        * editing/CreateLinkCommand.cpp:
        (WebCore::CreateLinkCommand::doApply): used to call pushPartiallySelectedAnchorElementsDown.
        * editing/UnlinkCommand.cpp:
        (WebCore::UnlinkCommand::doApply): Used to call pushPartiallySelectedAnchorElementsDown.
2010-08-24  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        Creating a link when selecting multiple nodes creates multiple links
        https://bugs.webkit.org/show_bug.cgi?id=30836

        Added a test to ensure WebKit creates single anchor element on execCommand('createLink') if possible.
        Also rebaselined several tests to match new behavior.

        * editing/execCommand/createLink-expected.txt: Merged some anchor elements.
        * editing/execCommand/script-tests/toggle-link.js: Added.
        (testSingleToggle):
        (selectAll):
        (selectFirstTwoWords):
        (selectLastWord):
        * editing/execCommand/script-tests/toggle-style-3.js: i elements are merged.
        * editing/execCommand/toggle-style-3-expected.txt: Ditto.
        * editing/execCommand/toggle-link-expected.txt: Added.
        * editing/execCommand/toggle-link.html: Added.
        * editing/execCommand/unlink-expected.txt: Merged some anchor elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Zhenyao Mo <zmo@google.com>
zmo@google.com [Wed, 25 Aug 2010 20:28:59 +0000 (20:28 +0000)]
2010-08-24  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (skia)
        https://bugs.webkit.org/show_bug.cgi?id=38282

        * src/WebImageDecoder.cpp:
        (WebKit::WebImageDecoder::init): Add premultiplyAlpha flag.
2010-08-24  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (skia)
        https://bugs.webkit.org/show_bug.cgi?id=38282

        Test: fast/canvas/webgl/gl-teximage.html

        * platform/graphics/GraphicsContext3D.cpp: Fix a bug where alpha channel is ignored.
        * platform/graphics/ImageSource.cpp: Add premultiplyAlpha flag.
        (WebCore::ImageSource::ImageSource):
        (WebCore::ImageSource::setData):
        * platform/graphics/ImageSource.h: Ditto.
        * platform/graphics/cg/ImageSourceCG.cpp: Ditto.
        (WebCore::ImageSource::ImageSource):
        * platform/graphics/qt/ImageDecoderQt.cpp: Ditto.
        (WebCore::ImageDecoder::create):
        (WebCore::ImageDecoderQt::ImageDecoderQt):
        (WebCore::ImageDecoderQt::frameCount):
        (WebCore::ImageDecoderQt::forceLoadEverything):
        * platform/graphics/qt/ImageDecoderQt.h: Ditto.
        * platform/graphics/skia/GraphicsContext3DSkia.cpp: Fix the premultiplyAlpha data loss issue in skia.
        (WebCore::GraphicsContext3D::getImageData):
        * platform/image-decoders/ImageDecoder.cpp: Add premultiplyAlpha flag.
        (WebCore::ImageDecoder::create):
        (WebCore::RGBA32Buffer::RGBA32Buffer):
        (WebCore::RGBA32Buffer::operator=):
        * platform/image-decoders/ImageDecoder.h: Ditto.
        (WebCore::RGBA32Buffer::premultiplyAlpha):
        (WebCore::RGBA32Buffer::setPremultiplyAlpha):
        (WebCore::RGBA32Buffer::setRGBA):
        (WebCore::ImageDecoder::ImageDecoder):
        * platform/image-decoders/bmp/BMPImageDecoder.cpp: Ditto.
        (WebCore::BMPImageDecoder::BMPImageDecoder):
        (WebCore::BMPImageDecoder::frameBufferAtIndex):
        * platform/image-decoders/bmp/BMPImageDecoder.h: Ditto.
        * platform/image-decoders/gif/GIFImageDecoder.cpp: Ditto.
        (WebCore::GIFImageDecoder::GIFImageDecoder):
        (WebCore::GIFImageDecoder::frameCount):
        * platform/image-decoders/gif/GIFImageDecoder.h: Ditto.
        * platform/image-decoders/ico/ICOImageDecoder.cpp: Ditto.
        (WebCore::ICOImageDecoder::ICOImageDecoder):
        (WebCore::ICOImageDecoder::frameCount):
        (WebCore::ICOImageDecoder::decodeAtIndex):
        * platform/image-decoders/ico/ICOImageDecoder.h: Ditto.
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Ditto.
        (WebCore::JPEGImageDecoder::JPEGImageDecoder):
        (WebCore::JPEGImageDecoder::frameBufferAtIndex):
        * platform/image-decoders/jpeg/JPEGImageDecoder.h: Ditto.
        * platform/image-decoders/png/PNGImageDecoder.cpp: Ditto.
        (WebCore::PNGImageDecoder::PNGImageDecoder):
        (WebCore::PNGImageDecoder::frameBufferAtIndex):
        * platform/image-decoders/png/PNGImageDecoder.h: Ditto.
        * platform/image-decoders/skia/ImageDecoderSkia.cpp: Ditto.
        (WebCore::RGBA32Buffer::RGBA32Buffer):
        (WebCore::RGBA32Buffer::operator=):
2010-08-24  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Passing premultiplyAlpha=false to tex{Sub}Image2D loses information (skia)
        https://bugs.webkit.org/show_bug.cgi?id=38282

        * fast/canvas/webgl/gl-teximage-expected.txt: Added.
        * fast/canvas/webgl/gl-teximage.html: Added.
        * fast/canvas/webgl/resources/3x3.png: Added.
        * fast/canvas/webgl/resources/gray-ramp-256-with-128-alpha.png: Added.
        * fast/canvas/webgl/resources/gray-ramp-256.png: Added.
        * fast/canvas/webgl/resources/gray-ramp-default-gamma.png: Added.
        * fast/canvas/webgl/resources/gray-ramp-gamma0.1.png: Added.
        * fast/canvas/webgl/resources/gray-ramp-gamma1.0.png: Added.
        * fast/canvas/webgl/resources/gray-ramp-gamma2.0.png: Added.
        * fast/canvas/webgl/resources/gray-ramp-gamma4.0.png: Added.
        * fast/canvas/webgl/resources/gray-ramp-gamma9.0.png: Added.
        * fast/canvas/webgl/resources/gray-ramp.png: Added.
        * fast/canvas/webgl/resources/webgl-test-utils.js: Sync with khronos.
        (WebGLTestUtils):
        * fast/canvas/webgl/resources/zero-alpha.png: Added.
        * platform/chromium/test_expectations.txt: Don't run gl-teximage.html for mac.
        * platform/mac/Skipped: Don't run gl-teximage.html for mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Jaehun Lim <ljaehun.lim@samsung.com>
demarchi@webkit.org [Wed, 25 Aug 2010 20:27:56 +0000 (20:27 +0000)]
2010-08-25  Jaehun Lim  <ljaehun.lim@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] enable libsoup's content decode feature
        https://bugs.webkit.org/show_bug.cgi?id=44147

        libsoup's content decode feature is enabled during initializaton.

        * ewk/ewk_main.cpp:
        (ewk_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 25 Aug 2010 20:23:58 +0000 (20:23 +0000)]
2010-08-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove XBL
        https://bugs.webkit.org/show_bug.cgi?id=44621

        This patch removes support for XBL.  XBL seems cool, but this code is
        old and pretty bitrotten.  If we decide to support XBL in the future,
        we can recover this code from this revision.  As it stands, it doesn't
        seem worth half-maintaining this code.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::~Document):
        * dom/Document.h:
        * loader/Cache.cpp:
        (WebCore::createResource):
        (WebCore::Cache::getStatistics):
        * loader/Cache.h:
        * loader/CachedResource.h:
        (WebCore::CachedResource::):
        * loader/CachedResourceClient.h:
        (WebCore::CachedResourceClient::setXSLStyleSheet):
        (WebCore::CachedResourceClient::fontLoaded):
        * loader/CachedXBLDocument.cpp: Removed.
        * loader/CachedXBLDocument.h: Removed.
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::canRequest):
        * loader/DocLoader.h:
        * loader/loader.cpp:
        (WebCore::cachedResourceTypeToTargetType):
        (WebCore::Loader::determinePriority):
        * rendering/style/BindingURI.cpp: Removed.
        * rendering/style/BindingURI.h: Removed.
        * rendering/style/RenderStyle.cpp:
        * rendering/style/RenderStyle.h:
        * rendering/style/StyleRareNonInheritedData.cpp:
        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
        (WebCore::StyleRareNonInheritedData::operator==):
        * rendering/style/StyleRareNonInheritedData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Wed, 25 Aug 2010 20:08:20 +0000 (20:08 +0000)]
2010-08-25  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] GraphicsContext: Construct with the correct default LineJoin (MiterJoin)

        We weren't setting it explicitly which caused us to use Qt::MiterJoin when
        we actually want Qt::SvgMiterJoin.

        Fixes display glitches on the "Monster" chrome experiment among other things.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::GraphicsContext):
2010-08-25  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] GraphicsContext: Construct with the correct default LineJoin (MiterJoin)

        Skip canvas/philip/tests/2d.path.rect.zero.1.html
        It was working because we didn't properly initialize the GC's LineJoin mode.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClean up Connection::open on Windows
aroben@apple.com [Wed, 25 Aug 2010 20:06:53 +0000 (20:06 +0000)]
Clean up Connection::open on Windows

Fixes <http://webkit.org/b/44185>.

Reviewed by Steve Falkenburg.

* Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::platformInitialize): Set m_isConnected to true
since the pipe got connected before it was even given to us.
(CoreIPC::Connection::readEventHandler): Removed code that will never
run now that m_isConnected is always true when this function is
called. Since no outgoing messages will have been queued before
m_isConnected is set to true, there's no need to send them explicitly
here; they'll get sent as they're queued.
(CoreIPC::Connection::open): Removed the call to ::ConnectNamedPipe,
since the pipe is already connected by this point. Changed to schedule
a read in the server and client the same way (rather than using
::SetEvent in the server).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Fady Samuel <fsamuel@chromium.org>
dglazkov@chromium.org [Wed, 25 Aug 2010 19:54:31 +0000 (19:54 +0000)]
2010-08-25  Fady Samuel  <fsamuel@chromium.org>

        Reviewed by Dimitri Glazkov.

        Table Rendering Layout Test Expectations Updated
        https://bugs.webkit.org/show_bug.cgi?id=44429

        Simple Paint test appears to render the same on Mac, Windows, and Linux.

        Updated test expectations to match this and moved the expectations into the test directory.

        * fast/table/simple_paint-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/fast/table/simple_paint-expected.checksum.
        * fast/table/simple_paint-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/table/simple_paint-expected.png.
        * fast/table/simple_paint-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/table/simple_paint-expected.txt.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Rafael Antognolli <antognolli@profusion.mobi>
demarchi@webkit.org [Wed, 25 Aug 2010 19:25:01 +0000 (19:25 +0000)]
2010-08-25  Rafael Antognolli  <antognolli@profusion.mobi>

        Unreviewed build fix.

        [EFL] Build fix for revision 66024
        https://bugs.webkit.org/show_bug.cgi?id=44631

        No new features added, so no new tests.

        * CMakeListsEfl.txt: change GRefPtrCairo.cpp by PlatformRefPtrCairo.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 25 Aug 2010 19:19:26 +0000 (19:19 +0000)]
2010-08-25  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Various designmode=&quot;on&quot;/&quot;off&quot; &amp; execCommand(&quot;Undo&quot;) NULL pointer crashes
        https://bugs.webkit.org/show_bug.cgi?id=32823

        The bug was caused by changeSelectionAfterCommand which updates the selection
        without checking the whether new selection is valid or not.

        Fixed changeSelectionAfterCommand so that it won't update the selection
        when either end of the new selection is orphaned. Also fixed various editing commands
        to exit early if either end of the selection is orphaned.

        Tests: editing/undo/orphaned-selection-crash-bug32823-1.html
               editing/undo/orphaned-selection-crash-bug32823-2.html
               editing/undo/orphaned-selection-crash-bug32823-3.html
               editing/undo/orphaned-selection-crash-bug32823-4.html

        * editing/Editor.cpp:
        (WebCore::Editor::changeSelectionAfterCommand): No longer sets orphaned selection.
        * editing/VisibleSelection.h:
        (WebCore::VisibleSelection::isNonOrphanedRange): Added.
        (WebCore::VisibleSelection::isNonOrphanedCaretOrRange): Added.
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::doApply): Added an early exist. See above.
        * editing/FormatBlockCommand.cpp:
        (WebCore::FormatBlockCommand::doApply): Ditto.
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::doApply): Ditto.
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply): Ditto.
        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::doApply): Ditto.
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::input): Ditto.
        * editing/MoveSelectionCommand.cpp:
        (WebCore::MoveSelectionCommand::doApply): Ditto.
        * editing/RemoveFormatCommand.cpp:
        (WebCore::RemoveFormatCommand::doApply): Ditto.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Ditto.
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::doApply): Ditto.
        * editing/UnlinkCommand.cpp:
        (WebCore::UnlinkCommand::doApply): Ditto.
2010-08-25  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Various designmode="on"/"off" & execCommand("Undo") NULL pointer crashes
        https://bugs.webkit.org/show_bug.cgi?id=32823

        These tests ensure WebKit doesn't crash when undoing some editing commands failed
        and either end of endingSelection() became orphaned.
        All tests are copied from the bug to prevent regression.

        * editing/undo/orphaned-selection-crash-bug32823-1-expected.txt: Added.
        * editing/undo/orphaned-selection-crash-bug32823-1.html: Added.
        * editing/undo/orphaned-selection-crash-bug32823-2-expected.txt: Added.
        * editing/undo/orphaned-selection-crash-bug32823-2.html: Added.
        * editing/undo/orphaned-selection-crash-bug32823-3-expected.txt: Added.
        * editing/undo/orphaned-selection-crash-bug32823-3.html: Added.
        * editing/undo/orphaned-selection-crash-bug32823-4-expected.txt: Added.
        * editing/undo/orphaned-selection-crash-bug32823-4.html: Added.
        * editing/undo/redo-split-text-with-removal-expected.txt: Caret is restored.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Michael Saboff <msaboff@apple.com>
commit-queue@webkit.org [Wed, 25 Aug 2010 18:55:26 +0000 (18:55 +0000)]
2010-08-25  Michael Saboff  <msaboff@apple.com>

        Reviewed by Sam Weinig.

        Remove the single entry regular expression cache introduced as part of
        the fix for https://bugs.webkit.org/show_bug.cgi?id=41238.
        The performance problem in Dromaeo that initiated that bug is no
        longer present. Dromaeo has been modified so that the regular
        expression tests are somewhat random and don't benefit from a
        single entry cache.

        * runtime/RegExp.cpp:
        (JSC::RegExp::RegExp):
        (JSC::RegExp::match):
        * runtime/RegExp.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Leo Yang <leo.yang@torchmobile.com.cn>
commit-queue@webkit.org [Wed, 25 Aug 2010 18:30:20 +0000 (18:30 +0000)]
2010-08-25  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Simon Hausmann.

        In FrameLoaderClientQt::createFrame we should call loadURLIntoChildFrame
        with parent frame's loader instead of child frame's loader.
        https://bugs.webkit.org/show_bug.cgi?id=43930

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::createFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 25 Aug 2010 18:26:22 +0000 (18:26 +0000)]
2010-08-25  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        make perf tests work with V8
        https://bugs.webkit.org/show_bug.cgi?id=44623

        V8 doesn't support getJSObjectCount.

        * resources/magnitude-perf.js:
        (Magnitude._runIteration):
        (Magnitude):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 25 Aug 2010 18:24:17 +0000 (18:24 +0000)]
2010-08-25  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Flash content draws in front of site's drop down menu at http://www.monster.com/
        https://bugs.webkit.org/show_bug.cgi?id=41330

        If an iframe with composited content became overlapped, we failed to
        consider that iframe for compositing if it had no RenderLayer, so the layering
        would be incorrect.

        Overlap is detected at painting time, but it's bad for FrameView::setIsOverlapped()
        to call setNeedsStyleRecalc(), because this would cause subsequent calls to
        FrameView::paintContents() in the same painting batch to bail with needsLayout().

        Instead, we do the setNeedsStyleRecalc() from RenderLayerCompositor::notifyIFramesOfCompositingChange(),
        so that the parent document has a chance to update style, and give the iframe a RenderLayer.
        Then setIsOverlapped() simply needs to schedule a layer update, which we do on a timer.

        When dumping layers via Frame::layerTreeAsText(), if a layer update is pending, then
        update the layers.

        Test: compositing/iframes/become-overlapped-iframe.html

        * page/Frame.cpp:
        (WebCore::Frame::layerTreeAsText):
        * page/FrameView.cpp:
        (WebCore::FrameView::setIsOverlapped):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::RenderLayerCompositor):
        (WebCore::RenderLayerCompositor::scheduleCompositingLayerUpdate):
        (WebCore::RenderLayerCompositor::compositingLayerUpdatePending):
        (WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired):
        (WebCore::RenderLayerCompositor::updateCompositingLayers):
        (WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):
        * rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 25 Aug 2010 18:22:17 +0000 (18:22 +0000)]
2010-08-25  Tony Chang  <tony@chromium.org>

        Not reviewed, changing svn props for a script.

        * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 25 Aug 2010 18:17:47 +0000 (18:17 +0000)]
2010-08-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove WebKit2 from core builders
        https://bugs.webkit.org/show_bug.cgi?id=44625

        This builder was added to the core builders by accident.  It doesn't
        appear to be green enough to be a core builder yet.

        * Scripts/webkitpy/common/net/buildbot.py:
        * Scripts/webkitpy/common/net/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCall NP_GetEntryPoints before NP_Initialize on Windows
aroben@apple.com [Wed, 25 Aug 2010 18:12:47 +0000 (18:12 +0000)]
Call NP_GetEntryPoints before NP_Initialize on Windows

Doing otherwise will cause Flash and QuickTime to crash inside
NP_Initialize.

Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
NP_Initialize when loading QuickTime when running
plugins/embed-attributes-setting.html in WebKit2 on Windows

Reviewed by John Sullivan.

WebKit2:

* WebProcess/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad): On Windows, first call
NP_GetEntryPoints, then NP_Initialize. Do the reverse on Mac to
prevent Silverlight (e.g.) from crashing (see r38858).

WebKitTools:

Test that NP_Initialize and NP_GetEntryPoints are called in the
correct order

The order differs between Mac and Windows (see r38858).

* DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
a boolean to record whether NP_GetEntryPoints has been called.
(NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
called yet. This matches Flash and QuickTime's behavior.
(NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
yet. This matches Silverlight's behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 25 Aug 2010 18:00:13 +0000 (18:00 +0000)]
2010-08-25  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        Cairo and EFL port shouldn't depend on glib.
        https://bugs.webkit.org/show_bug.cgi?id=44354

        Replace GRefPtr with PlatformRefPtr. Keep GLib specific bits in
        GRefPtr.h.

        * GNUmakefile.am: Add PlatformRefPtr.h to the source list.
        * wtf/PlatformRefPtr.h: Migrated from GRefPtr.h.
        (WTF::PlatformRefPtr::PlatformRefPtr): Ditto.
        (WTF::PlatformRefPtr::~PlatformRefPtr): Ditto.
        (WTF::PlatformRefPtr::clear): Ditto.
        (WTF::PlatformRefPtr::get): Ditto.
        (WTF::PlatformRefPtr::operator*): Ditto.
        (WTF::PlatformRefPtr::operator->): Ditto.
        (WTF::PlatformRefPtr::operator!): Ditto.
        (WTF::PlatformRefPtr::operator UnspecifiedBoolType): Ditto.
        (WTF::PlatformRefPtr::hashTableDeletedValue): Ditto.
        (WTF::::operator): Ditto.
        (WTF::::swap): Ditto.
        (WTF::swap): Ditto.
        (WTF::operator==): Ditto.
        (WTF::operator!=): Ditto.
        (WTF::static_pointer_cast): Ditto.
        (WTF::const_pointer_cast): Ditto.
        (WTF::getPtr): Ditto.
        (WTF::adoptPlatformRef): Ditto.
        * wtf/gobject/GRefPtr.cpp: Changes to reflect new names.
        (WTF::refPlatformPtr):
        (WTF::derefPlatformPtr):
        * wtf/gobject/GRefPtr.h: Ditto.
        (WTF::refPlatformPtr):
        (WTF::derefPlatformPtr):
2010-08-25  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        Cairo and EFL port shouldn't depend on glib.
        https://bugs.webkit.org/show_bug.cgi?id=44354

        No new tests as functionality has not changed.

        Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
        adoptPlatformRef. Rename GRefPtrCairo to PlatformRefPtrCairo.

        * GNUmakefile.am:
        * platform/Cursor.h:
        * platform/graphics/cairo/GRefPtrCairo.cpp: Removed.
        * platform/graphics/cairo/GRefPtrCairo.h: Removed.
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/cairo/PlatformRefPtrCairo.cpp: Added.
        (WTF::refPlatformPtr):
        (WTF::derefPlatformPtr):
        * platform/graphics/cairo/PlatformRefPtrCairo.h: Added.
        * platform/graphics/gtk/ImageBufferGtk.cpp:
        (WebCore::ImageBuffer::toDataURL):
        * platform/gtk/ClipboardGtk.cpp:
        (WebCore::ClipboardGtk::declareAndWriteDragImage):
        * platform/gtk/CursorGtk.cpp:
        (WebCore::createNamedCursor):
        (WebCore::createCustomCursor):
        (WebCore::Cursor::ensurePlatformCursor):
        * platform/gtk/DataObjectGtk.h:
        * platform/gtk/GRefPtrGtk.cpp:
        (WTF::refPlatformPtr):
        (WTF::derefPlatformPtr):
        * platform/gtk/GRefPtrGtk.h:
        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::Pasteboard::writeImage):
        * platform/gtk/PasteboardHelper.cpp:
        (WebCore::PasteboardHelper::dropAtomsForContext):
        * platform/gtk/PopupMenuGtk.h:
        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::RenderThemeGtk):
        (WebCore::paintMozillaGtkWidget):
        * platform/gtk/RenderThemeGtk.h:
2010-08-25  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        Cairo and EFL port shouldn't depend on glib.
        https://bugs.webkit.org/show_bug.cgi?id=44354

        Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
        adoptPlatformRef.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::requestGeolocationPermissionForFrame):
        * WebCoreSupport/DragClientGtk.cpp:
        (WebKit::DragClient::startDrag):
        * WebCoreSupport/EditorClientGtk.h:
        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchWillSendRequest):
        (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
        (WebKit::FrameLoaderClient::createPlugin):
        * WebCoreSupport/FullscreenVideoController.h:
        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::populateSetting):
        (WebKit::InspectorClient::storeSetting):
        * webkit/webkitdownload.cpp:
        (webkit_download_error):
        * webkit/webkitnetworkrequest.cpp:
        (webkit_network_request_new_with_core_request):
        * webkit/webkitnetworkresponse.cpp:
        (webkit_network_response_new_with_core_response):
2010-08-25  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        Cairo and EFL port shouldn't depend on glib.
        https://bugs.webkit.org/show_bug.cgi?id=44354

        Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
        adoptPlatformRef.

        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
        (AccessibilityUIElement::isSelected):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 25 Aug 2010 17:51:26 +0000 (17:51 +0000)]
2010-08-25  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Alexey Proskuryakov.

        HTMLMediaElement.canPlayType must be case insensitive for MIME type.
        https://bugs.webkit.org/show_bug.cgi?id=44577

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::load):
        (WebCore::MediaPlayer::supportsType):

2010-08-24  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Alexey Proskuryakov.

        HTMLMediaElement.canPlayType must be case insensitive for MIME type.
        https://bugs.webkit.org/show_bug.cgi?id=44577

        * media/media-can-play-octet-stream-expected.txt:
        * media/media-can-play-octet-stream.html:
        * media/media-can-play-ogg-expected.txt:
        * media/media-can-play-ogg.html:
        * media/video-can-play-type-expected.txt:
        * media/video-can-play-type.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 25 Aug 2010 17:35:24 +0000 (17:35 +0000)]
2010-08-25  Ojan Vafai  <ojan@chromium.org>

        Fix order of Timothy's email address. The script, and
        other tools all assume that the first email is the bugzilla address.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 25 Aug 2010 17:33:22 +0000 (17:33 +0000)]
2010-08-25  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] CodeGeneratorGObject not picking up FEATURE_DEFINES
        https://bugs.webkit.org/show_bug.cgi?id=44608

        Move FEATURE_DEFINES declaration here, since it's used by the
        bindings code generator. Also, fix typo in the variable holding
        the defines.

        * GNUmakefile.am:

WebCore:

2010-08-25  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] CodeGeneratorGObject not picking up FEATURE_DEFINES
        https://bugs.webkit.org/show_bug.cgi?id=44608

        Move FEATURE_DEFINES declaration to the toplevel GNUmakefile.am,
        since it's used there now too.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 25 Aug 2010 17:10:11 +0000 (17:10 +0000)]
2010-08-25  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        [chromium] remove chromium.Interval layout test
        https://bugs.webkit.org/show_bug.cgi?id=44614

        chromium.Interval is moving into the benchmarking namespace
        and not being exposed by default.

        * platform/chromium/fast/dom/interval-expected.txt: Removed.
        * platform/chromium/fast/dom/interval.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 25 Aug 2010 17:02:20 +0000 (17:02 +0000)]
2010-08-25  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Alexey Proskuryakov.

        Remove dead code in JSGlobalObject
        https://bugs.webkit.org/show_bug.cgi?id=44615

        The recursion data member in the JSGlobalObject and its getter
        plus inc/dec methods seems to be unused, remove them.

        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::init):
        * runtime/JSGlobalObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Rafael Antognolli <antognolli@profusion.mobi>
demarchi@webkit.org [Wed, 25 Aug 2010 16:39:36 +0000 (16:39 +0000)]
2010-08-25  Rafael Antognolli  <antognolli@profusion.mobi>

        Unreviewed build fix.

        [EFL] Build fix for revision 65332
        https://bugs.webkit.org/show_bug.cgi?id=44543

        Generated variables are now returned from FindPkgConfig, so no need
        to document the custom ones.

        * cmake/FindGthread.cmake:
2010-08-25  Rafael Antognolli  <antognolli@profusion.mobi>

        Unreviewed build fix.

        [EFL] Build fix for revision 65332
        https://bugs.webkit.org/show_bug.cgi?id=44543

        Use Gthread_LIBRARIES instead of GTHREAD_LIBRARIES. This fix
        the build when using ENABLE_GLIB_SUPPORT=ON and NETWORK_BACKEND=curl.

        * CMakeListsEfl.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Dawit Alemayehu <adawit@kde.org>
girish@forwardbias.in [Wed, 25 Aug 2010 16:33:34 +0000 (16:33 +0000)]
2010-08-25  Dawit Alemayehu  <adawit@kde.org>

        Reviewed by Ariya Hidayat.

        Proper workaround for missing Gtk initialization in Adobe's flash plugins.
        https://bugs.webkit.org/show_bug.cgi?id=44405

        * plugins/qt/PluginPackageQt.cpp:
        (WebCore::initializeGtk):
        (WebCore::PluginPackage::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed -- no code change. Sort WebCore/English.lproj/localizedStrings.js.
mnaganov@chromium.org [Wed, 25 Aug 2010 16:18:52 +0000 (16:18 +0000)]
Unreviewed -- no code change. Sort WebCore/English.lproj/localizedStrings.js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 25 Aug 2010 15:48:23 +0000 (15:48 +0000)]
2010-08-25  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: support checked and disabled context menu items.
        https://bugs.webkit.org/show_bug.cgi?id=44612

        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::checkOrEnableIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 25 Aug 2010 14:42:55 +0000 (14:42 +0000)]
2010-08-25  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: InspectorBackendStub.js is not updated when Inspector.idl changes.
        https://bugs.webkit.org/show_bug.cgi?id=44604

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Pavel Podivilov <podivilov@chromium.org>
yurys@chromium.org [Wed, 25 Aug 2010 14:24:42 +0000 (14:24 +0000)]
2010-08-25  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: don't stop on DOM breakpoints when all breakpoints are deactivated
        https://bugs.webkit.org/show_bug.cgi?id=44509

        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::ScriptDebugServer):
        (WebCore::ScriptDebugServer::setBreakpointsActivated):
        (WebCore::ScriptDebugServer::breakProgram):
        * bindings/v8/ScriptDebugServer.h:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 25 Aug 2010 14:14:21 +0000 (14:14 +0000)]
2010-08-25  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: lazily request frontend settings instead of pushing them on connect
        https://bugs.webkit.org/show_bug.cgi?id=44607

        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::createParser):
        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::getSettings):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::populateScriptObjects): this method is now called explicitely from the frontend,
        it should be gone eventually once all panels request initial data lazily.
        * inspector/InspectorController.h:
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.show):
        (WebInspector.ProfilesPanel.prototype.profilerWasEnabled):
        (WebInspector.ProfilesPanel.prototype._reset):
        * inspector/front-end/Settings.js:
        (WebInspector.Settings):
        (WebInspector.Settings.initialize.populateApplicationSettings):
        (WebInspector.Settings.initialize.populateSessionSettings):
        (WebInspector.Settings.initialize):
        * inspector/front-end/inspector.js:
        (WebInspector.doLoadedDone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Unreviewed test expectations update for the 307-after-303-after-post test.
mnaganov@chromium.org [Wed, 25 Aug 2010 13:54:41 +0000 (13:54 +0000)]
[Chromium] Unreviewed test expectations update for the 307-after-303-after-post test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 25 Aug 2010 13:50:08 +0000 (13:50 +0000)]
2010-08-25  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: support disabled and checked context menu items.
        https://bugs.webkit.org/show_bug.cgi?id=44601

        * bindings/js/JSInspectorFrontendHostCustom.cpp:
        (WebCore::JSInspectorFrontendHost::showContextMenu):
        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
        (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
        * inspector/front-end/ContextMenu.js:
        (WebInspector.ContextMenu.prototype.appendItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Zaheer Ahmad <zaheer.mot@gmail.com>
commit-queue@webkit.org [Wed, 25 Aug 2010 13:08:19 +0000 (13:08 +0000)]
2010-08-25  Zaheer Ahmad <zaheer.mot@gmail.com>

        Reviewed by Xan Lopez.

        [GTK] GTK port doesnt compile with video turned off
        https://bugs.webkit.org/show_bug.cgi?id=44236

        Generate the audio GObject DOM bindings only if video enabled
        * WebCore/GNUMakefile.am
        * WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:
        Make the audio code invocation conditional

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Pavel Podivilov <podivilov@chromium.org>
pfeldman@chromium.org [Wed, 25 Aug 2010 12:16:50 +0000 (12:16 +0000)]
2010-08-24  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add "Attribute Modified" and "Node Removed" DOM breakpoints
        https://bugs.webkit.org/show_bug.cgi?id=44532

        Test: inspector/dom-breakpoint.html

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::setDOMBreakpoint):
        (WebCore::InspectorDOMAgent::removeDOMBreakpoint):
        (WebCore::InspectorDOMAgent::didInsertDOMNode):
        (WebCore::InspectorDOMAgent::didRemoveDOMNode):
        (WebCore::InspectorDOMAgent::didModifyDOMAttr):
        * inspector/front-end/DOMAgent.js:
        * inspector/front-end/ElementsTreeOutline.js:
2010-08-25  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add "Attribute Modified" and "Node Removed" DOM breakpoints
        https://bugs.webkit.org/show_bug.cgi?id=44532

        * http/tests/inspector/debugger-test2.js:
        (initialize_DebuggerTest.InspectorTest.waitUntilPaused.pausedScript):
        (initialize_DebuggerTest.InspectorTest.waitUntilPaused):
        * http/tests/inspector/inspector-test2.js:
        (initialize_InspectorTest.):
        (initialize_InspectorTest):
        * inspector/dom-breakpoints-expected.txt:
        * inspector/dom-breakpoints.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Satish Sampath <satish@chromium.org>
jorlow@chromium.org [Wed, 25 Aug 2010 11:59:41 +0000 (11:59 +0000)]
2010-08-25  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        Pass the element's bounds to embedder during speech recognition.
        https://bugs.webkit.org/show_bug.cgi?id=44427

        The embedder would typically want to show a native UI with information, settings etc.
        By passing the display bounds of the html element, the embedder can position the
        native speech recognition UI appropriately.

        * page/SpeechInput.cpp:
        (WebCore::SpeechInput::startRecognition):
        * page/SpeechInput.h:
        * page/SpeechInputClient.h:
        * platform/mock/SpeechInputClientMock.cpp:
        (WebCore::SpeechInputClientMock::startRecognition):
        * platform/mock/SpeechInputClientMock.h:
        * rendering/TextControlInnerElements.cpp:
        (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
        (WebCore::InputFieldSpeechButtonElement::detach):
2010-08-25  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        Pass the element's bounds to embedder during speech recognition.
        https://bugs.webkit.org/show_bug.cgi?id=44427

        * public/WebSpeechInputController.h:
        (WebKit::WebSpeechInputController::startRecognition):
        (WebKit::WebSpeechInputController::cancelRecognition):
        (WebKit::WebSpeechInputController::stopRecording):
        * src/SpeechInputClientImpl.cpp:
        (WebKit::SpeechInputClientImpl::startRecognition):
        * src/SpeechInputClientImpl.h:
        * src/WebSpeechInputControllerMockImpl.cpp:
        (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
        * src/WebSpeechInputControllerMockImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Pawel Hajdan <phajdan.jr@chromium.org>
commit-queue@webkit.org [Wed, 25 Aug 2010 11:52:32 +0000 (11:52 +0000)]
2010-08-25  Pawel Hajdan  <phajdan.jr@chromium.org>

        Reviewed by Darin Fisher.

        Add an assertion to prevent re-initializing WebKit.
        https://bugs.webkit.org/show_bug.cgi?id=44545

        This will help prevent crashes like:
        - http://code.google.com/p/chromium/issues/detail?id=52731
        - http://code.google.com/p/chromium/issues/detail?id=52643

        * src/WebKit.cpp:
        (WebKit::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Yongjun Zhang <yongjun_zhang@apple.com>
commit-queue@webkit.org [Wed, 25 Aug 2010 11:36:54 +0000 (11:36 +0000)]
2010-08-25  Yongjun Zhang  <yongjun_zhang@apple.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=44461
        Assertion failure at WebCore/platform/network/CredentialStorage.cpp:85.

        Remove the assertion at CredentialStorage.cpp:85 since it is legal to have
        multiple forward slashes after the path component.

        No test needed.

        * platform/network/CredentialStorage.cpp:
        (WebCore::protectionSpaceMapKeyFromURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Michael Saboff <msaboff@apple.com>
commit-queue@webkit.org [Wed, 25 Aug 2010 11:03:26 +0000 (11:03 +0000)]
2010-08-25  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Changed the initial and subsequent allocation of vector storage to
        Array()s. The changes are to limit sparse arrays to 100000 entries
        and fixed the sparse map to vector storage conversion to use the
        minimum amount of memory needed to store the current number of entries.
        These changes address https://bugs.webkit.org/show_bug.cgi?id=43707

        * runtime/JSArray.cpp:
        (JSC::JSArray::putSlowCase):
        (JSC::JSArray::getNewVectorLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Wed, 25 Aug 2010 10:41:29 +0000 (10:41 +0000)]
2010-08-25  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Dimitri Glazkov.

        Adding missing test files and reenabling the WebFrame unit-test.
        https://bugs.webkit.org/show_bug.cgi?id=44492

        * tests/WebFrameTest.cpp:
        (WebKit::TEST_F):
        * tests/data/iframes_test.html: Added.
        * tests/data/invisible_iframe.html: Added.
        * tests/data/visible_iframe.html: Added.
        * tests/data/zero_sized_iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 25 Aug 2010 10:06:06 +0000 (10:06 +0000)]
2010-08-25  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: search in Scripts panel brings ui back to original search view.
        https://bugs.webkit.org/show_bug.cgi?id=44516

        * inspector/front-end/Panel.js:
        (WebInspector.Panel.prototype.searchCanceled):
        (WebInspector.Panel.prototype.jumpToNextSearchResult):
        (WebInspector.Panel.prototype.jumpToPreviousSearchResult):
        * inspector/front-end/ResourcesPanel.js:
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.searchCanceled):
        (WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
        (WebInspector.ScriptsPanel.prototype.performSearch):
        (WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult):
        (WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<input type=number>: Support auto-repeat by mouse press
tkent@chromium.org [Wed, 25 Aug 2010 09:45:06 +0000 (09:45 +0000)]
<input type=number>: Support auto-repeat by mouse press
https://bugs.webkit.org/show_bug.cgi?id=44476

Reviewed by Shinichiro Hamaji

WebCore:

Like arrow button of scrollbars, spinbuttons of <input
type=number> should continue to increase/decrease their values
while the mouse button is pressed.

No new tests because the new behavior strongly depends on a timer.

* rendering/TextControlInnerElements.cpp:
(WebCore::SpinButtonElement::SpinButtonElement):
 Initializes the timer.
(WebCore::SpinButtonElement::defaultEventHandler):
 Starts the timer by a mousedown event.
(WebCore::SpinButtonElement::startRepeatingTimer):
(WebCore::SpinButtonElement::stopRepeatingTimer):
(WebCore::SpinButtonElement::repeatingTimerFired):
* rendering/TextControlInnerElements.h:

LayoutTests:

Update existing tests.

* fast/forms/script-tests/input-spinbutton-capturing.js:
* platform/mac/fast/forms/input-appearance-spinbutton-up-expected.checksum:
* platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png:
* platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 25 Aug 2010 09:37:35 +0000 (09:37 +0000)]
2010-08-25  Kent Tamura  <tkent@chromium.org>

        Unreviewed, skip list update.

        input-spinbutton-capturing.html should be skipped in platforms
        without spinbutton implementation.

        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAvoid increasing required alignment of target type warning
loki@webkit.org [Wed, 25 Aug 2010 09:36:51 +0000 (09:36 +0000)]
Avoid increasing required alignment of target type warning
https://bugs.webkit.org/show_bug.cgi?id=43963

Reviewed by Gavin Barraclough.

Fix alignment warnings on Qt.

WebCore:

* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertQVariantToValue):
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::getImageData):
(WebCore::putImageData):
* platform/image-decoders/ImageDecoder.h:
(WebCore::RGBA32Buffer::getAddr):
* platform/text/qt/TextCodecQt.cpp:
(WebCore::TextCodecQt::decode):

WebKit/qt:

* Api/qwebelement.cpp:
(QWebElement::evaluateJavaScript):
* Api/qwebframe.cpp:
(QWebFrame::addToJavaScriptWindowObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Balazs Kelemen <kb@inf.u-szeged.hu>
commit-queue@webkit.org [Wed, 25 Aug 2010 09:28:50 +0000 (09:28 +0000)]
2010-08-25  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Implement WebKit::Module for qt
        https://bugs.webkit.org/show_bug.cgi?id=44527

        * Platform/Module.h:
        * Platform/qt/ModuleQt.cpp:
        (WebKit::Module::load):
        (WebKit::Module::unload):
        (WebKit::Module::platformFunctionPointer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a bug that a spin-button doesn't release mouse capturing
tkent@chromium.org [Wed, 25 Aug 2010 08:38:49 +0000 (08:38 +0000)]
Fix a bug that a spin-button doesn't release mouse capturing
https://bugs.webkit.org/show_bug.cgi?id=44411

Reviewed by Shinichiro Hamaji

WebCore:

- LeftButton should be checked only for clickEvent.
  Note that this change doesn't change the behavior because
  button() value is initialized with LeftButton even for
  mousemoveEvent.
- Should pass a SpinButtonElement node to setCapturingMouseEventsNode().

Test: fast/forms/input-spinbutton-capturing.html

* rendering/TextControlInnerElements.cpp:
(WebCore::SpinButtonElement::defaultEventHandler):

LayoutTests:

* fast/forms/input-spinbutton-capturing-expected.txt: Added.
* fast/forms/input-spinbutton-capturing.html: Added.
* fast/forms/script-tests/input-spinbutton-capturing.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Gavin Peters <gavinp@chromium.org>
commit-queue@webkit.org [Wed, 25 Aug 2010 08:25:27 +0000 (08:25 +0000)]
2010-08-25  Gavin Peters  <gavinp@chromium.org>

        Reviewed by Adam Barth.

        Change expectations on a test that now passes.
        https://bugs.webkit.org/show_bug.cgi?id=44524

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAvoid increasing required alignment of target type warning
loki@webkit.org [Wed, 25 Aug 2010 08:23:58 +0000 (08:23 +0000)]
Avoid increasing required alignment of target type warning
https://bugs.webkit.org/show_bug.cgi?id=43963

Reviewed by Gavin Barraclough.

Fix platform independent alignment warnings.

JavaScriptCore:

* wtf/ListHashSet.h:
(WTF::ListHashSetNodeAllocator::pool):

WebCore:

* loader/CachedMetadata.h:
(WebCore::CachedMetadata::readUnsigned):
* platform/text/TextCodecLatin1.cpp:
(WebCore::TextCodecLatin1::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Wed, 25 Aug 2010 08:06:58 +0000 (08:06 +0000)]
2010-08-25  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        Add missing methods at ResourceHandleWin
        https://bugs.webkit.org/show_bug.cgi?id=44453

        * platform/network/win/ResourceHandleWin.cpp:
        (WebCore::ResourceHandle::willLoadFromCache):
        (WebCore::prefetchDNS):
        (WebCore::ResourceHandle::bufferedData):
        (WebCore::ResourceHandle::supportsBufferedData):
        (WebCore::ResourceHandle::loadsBlocked):
        (WebCore::ResourceHandle::platformSetDefersLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEnable truncated floating point feature on ARM
loki@webkit.org [Wed, 25 Aug 2010 07:52:16 +0000 (07:52 +0000)]
Enable truncated floating point feature on ARM
https://bugs.webkit.org/show_bug.cgi?id=44233

Reviewed by Gavin Barraclough.

Enable truncated floating point feature with the help of VCVTR.S32.F64
instruction. If VCVTR.S32.F64 can't fit the result into a 32-bit
integer/register, it saturates at INT_MAX or INT_MIN. Testing this
looks quicker than testing FPSCR for exception.

Inspired by Jacob Bramley's patch from JaegerMonkey

* assembler/ARMAssembler.h:
(JSC::ARMAssembler::):
(JSC::ARMAssembler::cmn_r):
(JSC::ARMAssembler::vcvtr_s32_f64_r):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 25 Aug 2010 07:21:36 +0000 (07:21 +0000)]
2010-08-25  Adam Barth  <abarth@webkit.org>

        Second attempt to fix Qt build

        * dom/XMLDocumentParserQt.cpp:
        (WebCore::XMLDocumentParser::parseDtd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-25 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 25 Aug 2010 07:19:51 +0000 (07:19 +0000)]
2010-08-25  Kent Tamura  <tkent@chromium.org>

        Unreviewed, build fix.

        * DEPS: Roll Chromium revision to 57298 to fix upstream build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 25 Aug 2010 06:57:14 +0000 (06:57 +0000)]
2010-08-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Remove more DTD junk now that the LegacyHTMLDocumentParser is gone
        https://bugs.webkit.org/show_bug.cgi?id=44588

        Just removing dead code, thus no tests.

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::nodeName):
        * html/HTMLElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 25 Aug 2010 06:53:30 +0000 (06:53 +0000)]
2010-08-24  Adam Barth  <abarth@webkit.org>

        Qt build fix.

        * dom/XMLDocumentParserQt.cpp:
        (WebCore::XMLDocumentParser::parseStartElement):
        (WebCore::XMLDocumentParser::parseProcessingInstruction):
        (WebCore::XMLDocumentParser::parseCdata):
        (WebCore::XMLDocumentParser::parseComment):
        (WebCore::XMLDocumentParser::parseDtd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 25 Aug 2010 06:52:01 +0000 (06:52 +0000)]
2010-08-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Pavel Feldman.

        [DRT/Chromium] Fix 26 inspector test crashes
        https://bugs.webkit.org/show_bug.cgi?id=44580

        * platform/chromium/drt_expectations.txt:
2010-08-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Pavel Feldman.

        [DRT/Chromium] Fix 26 inspector test crashes
        https://bugs.webkit.org/show_bug.cgi?id=44580

        - DRTDevToolsAgent has a reference to the main WebView. So we
          should not clear it in closeDevTools() and should clear it in
          ~TestShell().
        - DRTDevToolsClient has a reference to a DevTools WebView and no
          way to update it. So we should delete DRTDevToolsClient instances
          in closeDevTools().

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::~TestShell):
        (TestShell::closeDevTools):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 25 Aug 2010 06:46:43 +0000 (06:46 +0000)]
2010-08-24  Adam Barth  <abarth@webkit.org>

        Unskip XSSAuditor test and fix the source of flakiness.  I'll make the
        test pass again in the XSSAuditor redesign.

        * http/tests/security/xssAuditor/dom-write-innerHTML-expected.txt:
        * http/tests/security/xssAuditor/dom-write-innerHTML.html:
        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 25 Aug 2010 06:21:44 +0000 (06:21 +0000)]
2010-08-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Delete HTMLElement::checkDTD
        https://bugs.webkit.org/show_bug.cgi?id=44563

        This function existed to service the LegacyHTMLTreeBuilder.  The new
        HTMLTreeBuilder has this logic internalized.  Pulling on this thread
        caused me to remove a legacyParserAddChild and to discover some code
        that shouldn't be calling these parser-specific APIs.

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::parserAddChild):
        (WebCore::ContainerNode::deprecatedParserAddChild):
        * dom/ContainerNode.h:
        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createDocument):
        * dom/Node.cpp:
        (WebCore::Node::deprecatedParserAddChild):
        * dom/Node.h:
        * dom/XMLDocumentParser.cpp:
        (WebCore::XMLDocumentParser::enterText):
        * dom/XMLDocumentParser.h:
        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::XMLDocumentParser::startElementNs):
        (WebCore::XMLDocumentParser::characters):
        (WebCore::XMLDocumentParser::processingInstruction):
        (WebCore::XMLDocumentParser::cdataBlock):
        (WebCore::XMLDocumentParser::comment):
        (WebCore::XMLDocumentParser::internalSubset):
        * dom/XMLDocumentParserQt.cpp:
        (WebCore::XMLDocumentParser::parse):
        (WebCore::XMLDocumentParser::parseStartElement):
        (WebCore::XMLDocumentParser::parseCharacters):
        (WebCore::XMLDocumentParser::parseProcessingInstruction):
        (WebCore::XMLDocumentParser::parseCdata):
        (WebCore::XMLDocumentParser::parseComment):
        (WebCore::XMLDocumentParser::parseDtd):
        * html/HTMLDataGridElement.cpp:
        * html/HTMLDataGridElement.h:
        * html/HTMLDataGridRowElement.cpp:
        * html/HTMLDataGridRowElement.h:
        * html/HTMLDataListElement.cpp:
        * html/HTMLDataListElement.h:
        * html/HTMLDocument.cpp:
        * html/HTMLDocument.h:
        * html/HTMLElement.cpp:
        * html/HTMLElement.h:
        * html/HTMLFieldSetElement.cpp:
        * html/HTMLFieldSetElement.h:
        * html/HTMLFrameSetElement.cpp:
        * html/HTMLFrameSetElement.h:
        * html/HTMLHeadElement.cpp:
        * html/HTMLHeadElement.h:
        * html/HTMLHeadingElement.cpp:
        * html/HTMLHeadingElement.h:
        * html/HTMLHtmlElement.cpp:
        * html/HTMLHtmlElement.h:
        * html/HTMLKeygenElement.cpp:
        (WebCore::HTMLKeygenElement::HTMLKeygenElement):
        * html/HTMLMapElement.cpp:
        * html/HTMLMapElement.h:
        * html/HTMLMediaElement.cpp:
        * html/HTMLMediaElement.h:
        * html/HTMLNoScriptElement.cpp:
        * html/HTMLNoScriptElement.h:
        * html/HTMLOptGroupElement.cpp:
        * html/HTMLOptGroupElement.h:
        * html/HTMLOptionElement.cpp:
        * html/HTMLOptionElement.h:
        * html/HTMLParagraphElement.cpp:
        * html/HTMLParagraphElement.h:
        * html/HTMLPlugInElement.cpp:
        * html/HTMLPlugInElement.h:
        * html/HTMLScriptElement.h:
        * html/HTMLSelectElement.cpp:
        * html/HTMLSelectElement.h:
        * html/HTMLStyleElement.h:
        * html/HTMLTableColElement.cpp:
        * html/HTMLTableColElement.h:
        * html/HTMLTableElement.cpp:
        * html/HTMLTableElement.h:
        * html/HTMLTableRowElement.cpp:
        * html/HTMLTableRowElement.h:
        * html/HTMLTableSectionElement.cpp:
        * html/HTMLTableSectionElement.h:
        * html/HTMLTextAreaElement.h:
        * html/HTMLTitleElement.h:
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlElement::attachToParent):
        (WebCore::MediaControlInputElement::attachToParent):
        * rendering/TextControlInnerElements.cpp:
        (WebCore::TextControlInnerElement::attachInnerElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 25 Aug 2010 06:02:18 +0000 (06:02 +0000)]
2010-08-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTML5 spec changed to coalesce text nodes even when they were not created by the parser
        https://bugs.webkit.org/show_bug.cgi?id=44586

        See http://www.w3.org/Bugs/Public/show_bug.cgi?id=10221 for more info.

        * html5lib/resources/adoption01.dat:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 25 Aug 2010 05:53:35 +0000 (05:53 +0000)]
2010-08-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
        https://bugs.webkit.org/show_bug.cgi?id=44584

        * Scripts/webkitpy/tool/commands/queues_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix: Remove setHTML5ParserEnabled(), it's no longer used.
dumi@chromium.org [Wed, 25 Aug 2010 05:41:36 +0000 (05:41 +0000)]
Build fix: Remove setHTML5ParserEnabled(), it's no longer used.

Reviewed by Adam Barth.

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
* src/WebSettingsImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 25 Aug 2010 05:38:36 +0000 (05:38 +0000)]
2010-08-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove tagPriority
        https://bugs.webkit.org/show_bug.cgi?id=44557

        This code used to be used by the old parser.  Now it's unused.

        * html/HTMLAnchorElement.h:
        * html/HTMLAppletElement.h:
        * html/HTMLAreaElement.h:
        * html/HTMLAudioElement.h:
        * html/HTMLBRElement.h:
        * html/HTMLBaseElement.h:
        * html/HTMLBaseFontElement.h:
        * html/HTMLBlockquoteElement.h:
        * html/HTMLBodyElement.h:
        * html/HTMLCanvasElement.cpp:
        * html/HTMLCanvasElement.h:
        * html/HTMLDListElement.h:
        * html/HTMLDataGridCellElement.h:
        * html/HTMLDataGridColElement.h:
        * html/HTMLDataGridElement.h:
        * html/HTMLDataGridRowElement.h:
        * html/HTMLDirectoryElement.h:
        * html/HTMLDivElement.h:
        * html/HTMLElement.cpp:
        * html/HTMLElement.h:
        * html/HTMLEmbedElement.h:
        * html/HTMLFieldSetElement.h:
        * html/HTMLFontElement.h:
        * html/HTMLFormControlElement.h:
        * html/HTMLFormElement.h:
        * html/HTMLFrameElement.h:
        * html/HTMLFrameSetElement.h:
        * html/HTMLHRElement.h:
        * html/HTMLHeadElement.h:
        * html/HTMLHeadingElement.h:
        * html/HTMLHtmlElement.h:
        * html/HTMLIFrameElement.h:
        * html/HTMLImageElement.h:
        * html/HTMLInputElement.h:
        * html/HTMLIsIndexElement.h:
        * html/HTMLKeygenElement.h:
        * html/HTMLLIElement.h:
        * html/HTMLLabelElement.h:
        * html/HTMLLinkElement.h:
        * html/HTMLMapElement.h:
        * html/HTMLMarqueeElement.h:
        * html/HTMLMenuElement.h:
        * html/HTMLMetaElement.h:
        * html/HTMLModElement.h:
        * html/HTMLOListElement.h:
        * html/HTMLObjectElement.h:
        * html/HTMLOptionElement.h:
        * html/HTMLParagraphElement.h:
        * html/HTMLParamElement.h:
        * html/HTMLPreElement.h:
        * html/HTMLQuoteElement.h:
        * html/HTMLScriptElement.h:
        * html/HTMLSelectElement.h:
        * html/HTMLSourceElement.h:
        * html/HTMLStyleElement.h:
        * html/HTMLTableCaptionElement.h:
        * html/HTMLTableCellElement.h:
        * html/HTMLTableColElement.cpp:
        * html/HTMLTableColElement.h:
        * html/HTMLTableElement.h:
        * html/HTMLTableRowElement.h:
        * html/HTMLTableSectionElement.h:
        * html/HTMLUListElement.h:
        * html/HTMLVideoElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Dumitru Daniliuc <dumi@chromium.org>
eric@webkit.org [Wed, 25 Aug 2010 05:35:19 +0000 (05:35 +0000)]
2010-08-24  Dumitru Daniliuc  <dumi@chromium.org>

        Unreviewed, Chromium's LayoutTestController does not implement markerTextForListItem() yet.

        * platform/chromium/test_expectations.txt:
2010-08-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Fix one more html5lib test case for button scoping
        https://bugs.webkit.org/show_bug.cgi?id=44583

        I <3 test driven development.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTagForInBody):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, Chromium's LayoutTestController does not implement markerTextForListItem...
dumi@chromium.org [Wed, 25 Aug 2010 05:21:42 +0000 (05:21 +0000)]
Unreviewed, Chromium's LayoutTestController does not implement markerTextForListItem() yet.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 25 Aug 2010 05:11:56 +0000 (05:11 +0000)]
2010-08-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue and EWS bots should report all failures
        https://bugs.webkit.org/show_bug.cgi?id=41820

        Right now commit-queue/EWS only report failures when the
        patch under testing fails.  We should report all failures
        to the status server so that we can diagnose when the bots
        are wedged w/o needing to log into the machines.

        I also reduced the amount of data we upload since we've seen
        timeouts during status upload.

        * Scripts/webkitpy/common/system/executive.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 25 Aug 2010 05:01:57 +0000 (05:01 +0000)]
2010-08-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Remove HTML5 parser testing infrastructure now that we don't need it
        https://bugs.webkit.org/show_bug.cgi?id=44581

        * html5lib/runner-expected-html5.txt: Removed.
        * html5lib/webkit-resumer-expected-html5.txt: Removed.
2010-08-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Remove HTML5 parser testing infrastructure now that we don't need it
        https://bugs.webkit.org/show_bug.cgi?id=44581

        Just removing dead code, no tests.

        * dom/DocumentFragment.cpp:
        * dom/DocumentFragment.h:
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:
2010-08-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Remove HTML5 parser testing infrastructure now that we don't need it
        https://bugs.webkit.org/show_bug.cgi?id=44581

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):
2010-08-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Remove HTML5 parser testing infrastructure now that we don't need it
        https://bugs.webkit.org/show_bug.cgi?id=44581

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):
        (initializeGlobalsFromCommandLineOptions):
        * Scripts/old-run-webkit-tests:
        * Scripts/test-html5-parser: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 25 Aug 2010 04:47:22 +0000 (04:47 +0000)]
2010-08-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove unneeded include in HTMLPreloadScanner
        https://bugs.webkit.org/show_bug.cgi?id=44552

        Slowly but steadily sweeping up the dust in the HTML parser.

        * html/HTMLPreloadScanner.cpp:
        * html/HTMLPreloadScanner.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 25 Aug 2010 04:33:54 +0000 (04:33 +0000)]
2010-08-24  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Just adding test results.

        XMLDocumentParser needs to implement DocumentParser::detach()
        https://bugs.webkit.org/show_bug.cgi?id=44533

        I was lame before and forgot to add results or mark this test
        as dumpAsText().

        * fast/css/font-face-svg-decoding-error-expected.txt: Added.
        * fast/css/font-face-svg-decoding-error.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Wed, 25 Aug 2010 04:31:20 +0000 (04:31 +0000)]
2010-08-24  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Dumitru Daniliuc.

        Implement virtual path utilities for FileSystem API
        https://bugs.webkit.org/show_bug.cgi?id=44132

        No new tests; tests will be added later. (Each DOMFilePath's method is briefly tested locally.)

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * storage/DOMFilePath.cpp: Added.
        * storage/DOMFilePath.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, updating Chromium expectations.
dumi@chromium.org [Wed, 25 Aug 2010 04:27:34 +0000 (04:27 +0000)]
Unreviewed, updating Chromium expectations.

* platform/chromium-mac/fast/js/kde/Number-expected.txt:
* platform/chromium-mac/fast/js/number-toExponential-expected.txt:
* platform/chromium-mac/fast/js/number-tofixed-expected.txt:
* platform/chromium-mac/fast/js/number-toprecision-expected.txt:
* platform/chromium-win/fast/js/kde/Number-expected.txt:
* platform/chromium-win/fast/js/number-toExponential-expected.txt:
* platform/chromium-win/fast/js/number-tofixed-expected.txt:
* platform/chromium-win/fast/js/number-toprecision-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 25 Aug 2010 04:20:46 +0000 (04:20 +0000)]
2010-08-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTMLParserScheduler::create
        https://bugs.webkit.org/show_bug.cgi?id=44551

        * html/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::HTMLDocumentParser):
        * html/HTMLParserScheduler.h:
        (WebCore::HTMLParserScheduler::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] WebBlobRegistry cleanup.
jianli@chromium.org [Wed, 25 Aug 2010 04:18:36 +0000 (04:18 +0000)]
[chromium] WebBlobRegistry cleanup.
https://bugs.webkit.org/show_bug.cgi?id=44571

Reviewed by Darin Fisher.

Remove unneeded method from WebBlobRegistry interface.
Also remove unneeded WebBlobRegistryImpl.* files. They're already
excluded from gyp files.

* public/WebBlobRegistry.h:
* src/WebBlobRegistryImpl.cpp: Removed.
* src/WebBlobRegistryImpl.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 25 Aug 2010 03:55:48 +0000 (03:55 +0000)]
2010-08-24  Adam Barth  <abarth@webkit.org>

        Add http/tests/security/xssAuditor/dom-write-location-inline-event.html
        to the Skipped list.  It's flaky after enabling the HTML5 fragment
        parser.  I need to investigate.  However, I'm planning to redesign the
        XSSAuditor to make use of the new parser, so it seems to make sense to
        wait a bit.

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-08-24 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Wed, 25 Aug 2010 03:16:55 +0000 (03:16 +0000)]
2010-08-24  Daniel Bates  <dbates@rim.com>

        Fix the change log date associated with changeset 65967
        <http://trac.webkit.org/changeset/65967> in both the
        LayoutTests and WebCore change log.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65970 268f45cc-cd09-0410-ab3c-d52691b4dbfc