WebKit-https.git
10 years ago<rdar://problem/10294191> REGRESSION (WebKit2): Lookup bubble sized and positioned...
mitz@apple.com [Sat, 12 Nov 2011 22:13:00 +0000 (22:13 +0000)]
<rdar://problem/10294191> REGRESSION (WebKit2): Lookup bubble sized and positioned incorrectly (vertically off)
https://bugs.webkit.org/show_bug.cgi?id=72217

Reviewed by Dave Hyatt.

* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup): Rather than adding the NSFont’s ascender
to the top of the text rect to establish the baseline here...
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupForRange): ...do it here, using the WebCore::Font’s
ascender, which is what’s actually used when drawing the text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Add ENABLE(DFG_JIT) around DFGCorrectableJumpPoint code.
paroga@webkit.org [Sat, 12 Nov 2011 18:43:42 +0000 (18:43 +0000)]
Unreviewed. Add ENABLE(DFG_JIT) around DFGCorrectableJumpPoint code.

* dfg/DFGCorrectableJumpPoint.cpp:
* dfg/DFGCorrectableJumpPoint.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[CMake] Move list of DFG source files into correct file
paroga@webkit.org [Sat, 12 Nov 2011 17:30:48 +0000 (17:30 +0000)]
[CMake] Move list of DFG source files into correct file
https://bugs.webkit.org/show_bug.cgi?id=72212

Reviewed by Daniel Bates.

The DFG files are platform independent. So move them from
the EFL specific file into the general CMakeLists.txt.

* CMakeLists.txt:
* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix "unused variable" warning in JSLock
paroga@webkit.org [Sat, 12 Nov 2011 16:14:34 +0000 (16:14 +0000)]
Fix "unused variable" warning in JSLock
https://bugs.webkit.org/show_bug.cgi?id=72213

Reviewed by Anders Carlsson.

Use ASSERT_UNUSED() instead of ASSERT() to make sure
that the variable is also used in the release build.

* runtime/JSLock.cpp:
(JSC::JSLock::lock):
(JSC::JSLock::unlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd stub implementation for SVGResources::filter()
paroga@webkit.org [Sat, 12 Nov 2011 13:51:58 +0000 (13:51 +0000)]
Add stub implementation for SVGResources::filter()
https://bugs.webkit.org/show_bug.cgi?id=72211

Reviewed by Dirk Schulze.

Add an empty implementation, which only returns 0 for !ENABLE(FILTERS)
to reduce the #if ENABLE(FILTERS) complexity a bit.

* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::selfWillPaint):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::selfWillPaint):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::filtersForceContainerLayout):
* rendering/svg/SVGResources.h:
(WebCore::SVGResources::filter):
* rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientLayoutChanged):
(WebCore::SVGResourcesCache::clientUpdatedFromElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r98542): Rendering error on Google maps
antti@apple.com [Sat, 12 Nov 2011 13:33:26 +0000 (13:33 +0000)]
REGRESSION(r98542): Rendering error on Google maps
https://bugs.webkit.org/show_bug.cgi?id=71996

Source/WebCore:

Reviewed by Andreas Kling.

r98542 exposed that StyleBoxData copy constructor and operator== are missing a field.

Test reduction by David Barr.

Test: fast/css/vertical-align-length-copy-bug.html

* rendering/style/StyleBoxData.cpp:
(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleBoxData::operator==):

LayoutTests:

Reviewed by Andreas Kling.

Test reduction by David Barr.

* fast/css/vertical-align-length-copy-bug-expected.txt: Added.
* fast/css/vertical-align-length-copy-bug.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix minor config typo in the build tool documentation
commit-queue@webkit.org [Sat, 12 Nov 2011 12:01:43 +0000 (12:01 +0000)]
[Qt] Fix minor config typo in the build tool documentation
https://bugs.webkit.org/show_bug.cgi?id=72194

Patch by Ariya Hidayat <ariya@sencha.com> on 2011-11-12
Reviewed by Andreas Kling.

* qmake/README:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r100013.
commit-queue@webkit.org [Sat, 12 Nov 2011 11:09:33 +0000 (11:09 +0000)]
Unreviewed, rolling out r100013.
http://trac.webkit.org/changeset/100013
https://bugs.webkit.org/show_bug.cgi?id=72210

It breaks all mac builds (Requested by WildFox on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-12

Source/WebCore:

* html/HTMLAnchorElement.idl:
* html/HTMLAreaElement.idl:
* html/HTMLButtonElement.idl:
* html/HTMLElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLLabelElement.idl:
* html/HTMLLegendElement.idl:
* html/HTMLTextAreaElement.idl:

LayoutTests:

* fast/forms/access-key-for-all-elements-expected.txt: Removed.
* fast/forms/access-key-for-all-elements.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-11-12 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 12 Nov 2011 10:39:17 +0000 (10:39 +0000)]
2011-11-12  Nikolas Zimmermann  <nzimmermann@rim.com>

        Finish SVGLengthContext conversion in svg/
        https://bugs.webkit.org/show_bug.cgi?id=72105

        Reviewed by Antti Koivisto.

        Make SVGLengthContext(const SVGElement*) explicit, adapt all remaining call sites.
        Now that this process is finished, SVGLengthContext can be shared across renders,
        so that its possible to override the length context in a single place. This will
        be done in future patches.

        Doesn't affect any tests yet.

        * bindings/js/JSSVGLengthCustom.cpp:
        (WebCore::JSSVGLength::value):
        (WebCore::JSSVGLength::setValue):
        (WebCore::JSSVGLength::convertToSpecifiedUnits):
        * bindings/scripts/CodeGeneratorObjC.pm:
        (GenerateImplementation):
        * bindings/v8/custom/V8SVGLengthCustom.cpp:
        (WebCore::V8SVGLength::valueAccessorGetter):
        (WebCore::V8SVGLength::valueAccessorSetter):
        (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
        * css/CSSCursorImageValue.cpp:
        (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
        * rendering/svg/RenderSVGForeignObject.cpp:
        (WebCore::RenderSVGForeignObject::layout):
        * rendering/svg/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::updateFromElement):
        * rendering/svg/RenderSVGPath.cpp:
        (WebCore::RenderSVGPath::zeroLengthSubpathRect):
        (WebCore::RenderSVGPath::calculateMarkerBoundsIfNeeded):
        * rendering/svg/RenderSVGResourceMarker.cpp:
        (WebCore::RenderSVGResourceMarker::referencePoint):
        (WebCore::RenderSVGResourceMarker::calcViewport):
        * rendering/svg/RenderSVGText.cpp:
        (WebCore::RenderSVGText::strokeBoundingBox):
        * rendering/svg/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::calcViewport):
        * rendering/svg/SVGRenderSupport.cpp:
        (WebCore::SVGRenderSupport::applyStrokeStyleToContext):
        * rendering/svg/SVGRenderTreeAsText.cpp:
        (WebCore::writeStyle):
        (WebCore::operator<<):
        * rendering/svg/SVGShadowTreeElements.cpp:
        (WebCore::SVGShadowTreeContainerElement::containerTranslation):
        * rendering/svg/SVGTextChunkBuilder.cpp:
        (WebCore::SVGTextChunkBuilder::addTextChunk):
        * rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
        (WebCore::extractFloatValuesFromSVGLengthList):
        * rendering/svg/SVGTextLayoutEngine.cpp:
        (WebCore::SVGTextLayoutEngine::parentDefinesTextLength):
        (WebCore::SVGTextLayoutEngine::beginTextPathLayout):
        * rendering/svg/SVGTextLayoutEngineBaseline.cpp:
        (WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift):
        * rendering/svg/SVGTextLayoutEngineSpacing.cpp:
        (WebCore::SVGTextLayoutEngineSpacing::calculateCSSKerningAndSpacing):
        * svg/SVGElement.h:
        * svg/SVGLengthContext.cpp:
        (WebCore::SVGLengthContext::determineViewport):
        * svg/SVGLengthContext.h:
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::viewport):
        (WebCore::SVGSVGElement::localCoordinateSpaceTransform):
        (WebCore::SVGSVGElement::currentViewBoxRect):
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::toClipPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[CMake] Use MAIN_DEPENDENCY in GENERATE_* macros
paroga@webkit.org [Sat, 12 Nov 2011 08:52:57 +0000 (08:52 +0000)]
[CMake] Use MAIN_DEPENDENCY in GENERATE_* macros
https://bugs.webkit.org/show_bug.cgi?id=71365

Reviewed by Daniel Bates.

Use the MAIN_DEPENDENCY instead of DEPENDS in the custom build commands.
This adds better IDE support for such targets.

* Source/cmake/WebKitMacros.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix for !ENABLE(FILTERS) after r100036.
paroga@webkit.org [Sat, 12 Nov 2011 08:40:41 +0000 (08:40 +0000)]
Unreviewed build fix for !ENABLE(FILTERS) after r100036.

* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::filtersForceContainerLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WIN] Fix build without precompiled header.
paroga@webkit.org [Sat, 12 Nov 2011 07:57:33 +0000 (07:57 +0000)]
[WIN] Fix build without precompiled header.
https://bugs.webkit.org/show_bug.cgi?id=72115

Unreviewed. Add missing includes to fix build without precompiled header.

* platform/ContextMenu.h:
* platform/graphics/win/DIBPixelData.h:
* platform/graphics/win/FontCustomPlatformData.h:
* platform/network/cf/ResourceError.h:
* platform/win/LanguageWin.cpp:
* platform/win/LocalizedStringsWin.cpp:
* platform/win/LoggingWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/72205> Remove Duplicate Symbol Exports
joepeck@webkit.org [Sat, 12 Nov 2011 07:11:13 +0000 (07:11 +0000)]
<webkit.org/b/72205> Remove Duplicate Symbol Exports

Reviewed by Dan Bernstein.

* WebCore.exp.in: Remove duplicate symbols listed.
Each dup in this case was already always exported.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Remove 2 static initializers and 3 exit time destructors. Turn on -Wexit...
thakis@chromium.org [Sat, 12 Nov 2011 05:24:07 +0000 (05:24 +0000)]
[chromium] Remove 2 static initializers and 3 exit time destructors. Turn on -Wexit-time-destructors.
https://bugs.webkit.org/show_bug.cgi?id=72146

Reviewed by Nate Chapin.

Source/WebCore:

* WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

* WebKit.gyp:
* src/DebuggerAgentManager.cpp:
(WebKit::DebuggerAgentManager::debugHostDispatchHandler):
(WebKit::DebuggerAgentManager::onWebViewClosed):
* src/DebuggerAgentManager.h:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::keyboardShortcut):
* src/WebViewImpl.cpp:
(WebKit::pageGroupLoadDeferrerStack):
(WebKit::WebView::willEnterModalLoop):
(WebKit::WebView::didExitModalLoop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium layout test rebaselines after http://trac.webkit.org/changeset/100045
ojan@chromium.org [Sat, 12 Nov 2011 04:48:36 +0000 (04:48 +0000)]
Chromium layout test rebaselines after trac.webkit.org/changeset/100045
and http://trac.webkit.org/changeset/100036.

Also add line for failing text test after http://trac.webkit.org/changeset/99963.

* platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/foreignObject/filter-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/foreignObject/mask-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/repaint/filter-child-repaint-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/repaint/filter-child-repaint-expected.png: Added.
* platform/chromium-win/svg/foreignObject/clip-expected.txt: Added.
* platform/chromium-win/svg/foreignObject/filter-expected.txt: Added.
* platform/chromium-win/svg/foreignObject/mask-expected.txt: Added.
* platform/chromium-win/svg/repaint/filter-child-repaint-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/repaint/filter-child-repaint-expected.png.
* platform/chromium/svg/foreignObject/clip-expected.txt: Added.
* platform/chromium/svg/foreignObject/filter-expected.txt: Added.
* platform/chromium/svg/foreignObject/mask-expected.txt: Added.
* platform/chromium/svg/repaint/filter-child-repaint-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/repaint/filter-child-repaint-expected.txt.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSince GraphicsContext3D::makeContextCurrent can fail, return bool.
nduca@chromium.org [Sat, 12 Nov 2011 04:45:00 +0000 (04:45 +0000)]
Since GraphicsContext3D::makeContextCurrent can fail, return bool.

https://bugs.webkit.org/show_bug.cgi?id=72101

Reviewed by Kenneth Russell.

Source/WebCore:

* platform/graphics/GraphicsContext3D.h:
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::makeContextCurrent):
* platform/graphics/gtk/GraphicsContext3DGtk.cpp:
(WebCore::GraphicsContext3D::makeContextCurrent):
* platform/graphics/gtk/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::makeContextCurrent):
* platform/graphics/gtk/GraphicsContext3DPrivate.h:
* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::makeContextCurrent):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::makeContextCurrent):

Source/WebKit/chromium:

* src/GraphicsContext3DChromium.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Unreviewed. Rollout http://trac.webkit.org/changeset/99744.
ojan@chromium.org [Sat, 12 Nov 2011 04:40:28 +0000 (04:40 +0000)]
Source/WebCore: Unreviewed. Rollout trac.webkit.org/changeset/99744.
https://bugs.webkit.org/show_bug.cgi?id=72203
r99744 causes crash in Chromium's dom_perf test.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addCell):
(WebCore::RenderTableSection::recalcCells):
(WebCore::RenderTableSection::appendColumn):

LayoutTests: Unreviewed. Rollout http://trac.webkit.org/changeset/99744.
https://bugs.webkit.org/show_bug.cgi?id=72203
r99744 causes crash in Chromium's dom_perf test.

* fast/table/crash-splitColumn-2-expected.txt: Removed.
* fast/table/crash-splitColumn-2.html: Removed.
* fast/table/crash-splitColumn-3-expected.txt: Removed.
* fast/table/crash-splitColumn-3.html: Removed.
* fast/table/crash-splitColumn-expected.txt: Removed.
* fast/table/crash-splitColumn.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Removed unused local from CCThreadProxy::scheduledActionCommit
commit-queue@webkit.org [Sat, 12 Nov 2011 04:28:19 +0000 (04:28 +0000)]
[chromium] Removed unused local from CCThreadProxy::scheduledActionCommit
https://bugs.webkit.org/show_bug.cgi?id=72200

Patch by James Robinson <jamesr@chromium.org> on 2011-11-11
Reviewed by Kenneth Russell.

How did I get here I am not good with computers.

* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Fix a crash when an anonymous render block is in a continuation.
dmazzoni@google.com [Sat, 12 Nov 2011 04:23:59 +0000 (04:23 +0000)]
Source/WebCore: Fix a crash when an anonymous render block is in a continuation.
https://bugs.webkit.org/show_bug.cgi?id=70994

Reviewed by Chris Fleizach.

Test: accessibility/anonymous-render-block-in-continuation-causes-crash.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::renderParentObject):

LayoutTests: Add test to ensure that an anonymous render block in a continuation doesn't crash.
https://bugs.webkit.org/show_bug.cgi?id=70994

Reviewed by Chris Fleizach.

* accessibility/anonymous-render-block-in-continuation-causes-crash.html: Added.
* accessibility/anonymous-render-block-in-continuation-causes-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStorage and retrieval of TextTrackCues during video playback, including
annacc@chromium.org [Sat, 12 Nov 2011 03:37:39 +0000 (03:37 +0000)]
Storage and retrieval of TextTrackCues during video playback, including
cuechange, enter, and exit events.
https://bugs.webkit.org/show_bug.cgi?id=70452

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-cues-cuechange.html
       media/track/track-cues-enter-exit.html
       media/track/track-cues-seeking.html

Add cuechange, enter, and exit events and make TextTrack and
TextTrackCue EventTargets:
* dom/EventNames.h:
* dom/EventTarget.h:
* dom/EventTargetFactory.in:

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadTimerFired):
    Use scheduleLoad() instead of configureTextTracks() to start an async load.
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
    Updates the list of currently active cues during playback.
(WebCore::HTMLMediaElement::textTrackAddCues):
    Adds cues to cueTree.  Called when cues are discovered/loaded.
(WebCore::HTMLMediaElement::textTrackRemoveCues):
    Removes cues from cueTree.  Called when cues and/or tracks die.
(WebCore::HTMLMediaElement::textTrackAddCue):
    Adds a cue to cueTree.  Called when cues are discovered/loaded.
(WebCore::HTMLMediaElement::textTrackRemoveCue):
    Removes a cue from cueTree.  Called when cues and/or tracks die.

(WebCore::HTMLMediaElement::playbackProgressTimerFired):
    Update the active TextTrackCues when playbackProgressTimerFired.
(WebCore::HTMLMediaElement::addTrack):
    Pass along a ScriptExecutionContext to TextTrack::create().
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
    Update the active TextTrackCues when the media player time changes.
* html/HTMLMediaElement.h:
    Use a PodIntervalTree cueTree to store and retrieve TextTrackCues
    during playback.

* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::ensureTrack):
    Pass along a ScriptExecutionContext needed for EventTarget interface.
* html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::LoadableTextTrack):
    Pass along a ScriptExecutionContext needed for EventTarget interface.
(WebCore::LoadableTextTrack::fireCueChangeEvent):
    Fire a cue change event on this TextTrack's <track>
* html/LoadableTextTrack.h:
(WebCore::LoadableTextTrack::create):
    Pass along a ScriptExecutionContext needed for EventTarget interface.
* html/TextTrack.cpp:
(WebCore::TextTrack::TextTrack):
    Pass along a ScriptExecutionContext needed for EventTarget interface.
(WebCore::TextTrack::cues):
(WebCore::TextTrack::activeCues):
    Return a TextTrackCueList that represents the currently active cues.
(WebCore::TextTrack::fireCueChangeEvent):
    Fires a cue change event.
* html/TextTrack.h:
(WebCore::TextTrack::create):
    Pass along a ScriptExecutionContext needed for EventTarget interface.
* html/TextTrack.idl:
    Makes TextTrack extend EventTarget interface and add oncuechange.
* html/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue):
    TextTrackCue should extend EventTarget, not ActiveDOMObject.
(WebCore::TextTrackCue::isActive):
(WebCore::TextTrackCue::setIsActive):
    Dispatch an enter or exit event depending on active state and notify
    the corresponding track to fire a cuechange event.

The following are needed for EventTarget interface:
(WebCore::TextTrackCue::interfaceName):
(WebCore::TextTrackCue::scriptExecutionContext):
(WebCore::TextTrackCue::eventTargetData):
(WebCore::TextTrackCue::ensureEventTargetData):
* html/TextTrackCue.h:
(WebCore::TextTrackCue::refEventTarget):
(WebCore::TextTrackCue::derefEventTarget):

* html/TextTrackCue.idl:
    Extend EventTarget and add onenter and onexit.
* html/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::activeCues):
    Update and return the list of currently active cues.
(WebCore::TextTrackCueList::clear):
    Clear the cues from list (needed to return same object each time).
* html/TextTrackCueList.h:

The following are needed for EventTarget interface:
* html/track/TrackBase.cpp:
(WebCore::TrackBase::TrackBase):
(WebCore::TrackBase::interfaceName):
(WebCore::TrackBase::scriptExecutionContext):
(WebCore::TrackBase::eventTargetData):
(WebCore::TrackBase::ensureEventTargetData):
* html/track/TrackBase.h:
(WebCore::TrackBase::refEventTarget):
(WebCore::TrackBase::derefEventTarget):

LayoutTests:

* media/track/captions-webvtt/cues-chrono-order.vtt: Added.
* media/track/captions-webvtt/cues-overlapping.vtt: Added.
* media/track/track-cues-cuechange-expected.txt: Added.
* media/track/track-cues-cuechange.html: Added.
* media/track/track-cues-enter-exit-expected.txt: Added.
* media/track/track-cues-enter-exit.html: Added.
* media/track/track-cues-seeking-expected.txt: Added.
* media/track/track-cues-seeking.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Remove unused variable added by r99813.
commit-queue@webkit.org [Sat, 12 Nov 2011 03:29:48 +0000 (03:29 +0000)]
[Chromium] Remove unused variable added by r99813.
https://bugs.webkit.org/show_bug.cgi?id=72199

Patch by David Reveman <reveman@chromium.org> on 2011-11-11
Reviewed by James Robinson.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Rolled DEPS.
ojan@chromium.org [Sat, 12 Nov 2011 03:15:03 +0000 (03:15 +0000)]
Unreviewed. Rolled DEPS.
https://bugs.webkit.org/show_bug.cgi?id=72174

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Removing unneeded #ifdef from PopupMenuQt.cpp
commit-queue@webkit.org [Sat, 12 Nov 2011 02:58:11 +0000 (02:58 +0000)]
[Qt] Removing unneeded #ifdef from PopupMenuQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=72193

Patch by Luiz Agostini <luiz.agostini@palm.com> on 2011-11-11
Reviewed by Noam Rosenthal.

Part of PopupMenuQt.cpp code is guarded by #ifndef QT_NO_COMBOBOX although that
code is not related to the class QComboBox.

* WebCoreSupport/PopupMenuQt.cpp:
(WebCore::PopupMenuQt::show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRollout http://trac.webkit.org/changeset/99844
jamesr@google.com [Sat, 12 Nov 2011 02:56:27 +0000 (02:56 +0000)]
Rollout http://trac.webkit.org/changeset/99844
Solution is more complicated than the problem it was intended to solve.

Source/WebCore:

* platform/graphics/chromium/LayerChromium.cpp:
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerImpl.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::applyScrollAndScale):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert Page to operate on integers
leviw@chromium.org [Sat, 12 Nov 2011 02:53:52 +0000 (02:53 +0000)]
Revert Page to operate on integers
https://bugs.webkit.org/show_bug.cgi?id=72185

Reviewed by Eric Seidel.

Reverting the page classes to integers from LayoutUnits. It's not necessary to expose
LayoutUnits in these classes, so we'll avoid doing so.

No new tests, no change in behavior.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::dragHysteresisExceeded):
(WebCore::EventHandler::handleDrag):
* page/EventHandler.h:
* page/Frame.cpp:
(WebCore::Frame::documentAtPoint):
* page/Frame.h:
* page/FrameView.cpp:
(WebCore::FrameView::create):
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::invalidateScrollbarRect):
(WebCore::FrameView::getTickmarks):
(WebCore::FrameView::windowResizerRect):
(WebCore::FrameView::setVisibleScrollerThumbRect):
(WebCore::FrameView::updateScrollCorner):
(WebCore::FrameView::paintScrollCorner):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::paintOverhangAreas):
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):
(WebCore::FrameView::convertToContainingView):
(WebCore::FrameView::convertFromContainingView):
* page/FrameView.h:
* page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
* page/Page.h:
* page/SpatialNavigation.cpp:
(WebCore::scrollInDirection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdating the expected value, missed in r81312
commit-queue@webkit.org [Sat, 12 Nov 2011 02:24:27 +0000 (02:24 +0000)]
Updating the expected value, missed in r81312
https://bugs.webkit.org/show_bug.cgi?id=72170

Patch by Chris Hutten-Czapski <chutten@rim.com> on 2011-11-11
Reviewed by Daniel Bates.

* fast/viewport/viewport-128-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNew iframe content may not be reflected in the ax tree.
dmazzoni@google.com [Sat, 12 Nov 2011 02:23:09 +0000 (02:23 +0000)]
New iframe content may not be reflected in the ax tree.
https://bugs.webkit.org/show_bug.cgi?id=72100

Reviewed by Chris Fleizach.

Source/WebCore:

The core issue was that when childrenChanged was called on a
web area from an iframe that was just detached, it wasn't calling
childrenChanged on its parent scroll area, or that scroll area's
parent iframe element. To fix this, now AccessibilityScrollView
implements setNeedsToUpdateChildren and parentObjectIfExists,
and childrenChanged calls setNeedsToUpdateChildren on every object
in the parent chain, not just AccessibilityRenderObjects.

Test: accessibility/loading-iframe-updates-axtree.html

* accessibility/AXObjectCache.h:
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::setNeedsToUpdateChildren):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::childrenChanged):
* accessibility/AccessibilityRenderObject.h:
(WebCore::AccessibilityRenderObject::setNeedsToUpdateChildren):
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::AccessibilityScrollView):
(WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):
* accessibility/AccessibilityScrollView.h:
(WebCore::AccessibilityScrollView::setNeedsToUpdateChildren):

LayoutTests:

Add new test that makes sure that if you explore the accessibility
tree of an iframe and that iframe subsequently loads new content,
the iframe AccessibilityObject's descendants are updated to point
to the new content, not the old content.

* accessibility/loading-iframe-updates-axtree-expected.txt: Added.
* accessibility/loading-iframe-updates-axtree.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK][WEBKIT2] Add font and charset properties to WebKitWebSettings
commit-queue@webkit.org [Sat, 12 Nov 2011 02:10:55 +0000 (02:10 +0000)]
[GTK][WEBKIT2] Add font and charset properties to WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=68996

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-11-11
Reviewed by Martin Robinson.

Provision to query and set the font related properties (such as
font-family, font-size) and charset properties (such as default-
charset) is added.

* UIProcess/API/gtk/WebKitSettings.cpp: Added font and encoding properties.
(webKitSettingsSetProperty): GObject set property function.
(webKitSettingsGetProperty): GObject get property function.
(webkit_settings_class_init): Few more signals installed.
(webkit_settings_init): Initialization of instance variables.
(webkit_web_settings_get_default_font_family): Get 'default-font-family'.
(webkit_web_settings_set_default_font_family): Set 'default-font-family'.
(webkit_web_settings_get_monospace_font_family): Get 'monospace-font-family'.
(webkit_web_settings_set_monospace_font_family): Set 'monospace-font-family'.
(webkit_web_settings_get_serif_font_family): Get 'serif-font-family'.
(webkit_web_settings_set_serif_font_family): Set 'serif-font-family'.
(webkit_web_settings_get_sans_serif_font_family): Get 'sans-serif-font-family'.
(webkit_web_settings_set_sans_serif_font_family): Get 'sans-serif-font-family'.
(webkit_web_settings_get_cursive_font_family): Get 'cursive-font-family'.
(webkit_web_settings_set_cursive_font_family): Set 'cursive-font-family'.
(webkit_web_settings_get_fantasy_font_family): Get 'fantasy-font-family'.
(webkit_web_settings_set_fantasy_font_family): Set 'fantasy-font-family'.
(webkit_web_settings_get_pictograph_font_family): Get 'pictograph-font-family'.
(webkit_web_settings_set_pictograph_font_family): Set 'pictograph-font-family'.
(webkit_web_settings_get_default_font_size): Get 'default-font-size'.
(webkit_web_settings_set_default_font_size): Set 'default-font-size'.
(webkit_web_settings_get_default_monospace_font_size): Get 'default-monospace-font-size'.
(webkit_web_settings_set_default_monospace_font_size): Set 'default-monospace-font-size'.
(webkit_web_settings_get_minimum_font_size): Get 'minimum-font-size'.
(webkit_web_settings_set_minimum_font_size): Set 'minimum-font-size'.
(webkit_web_settings_get_default_charset): Get 'default-charset'.
(webkit_web_settings_set_default_charset): Set 'default-charset'.
* UIProcess/API/gtk/WebKitSettings.h: Add new sections for gtk-doc generation.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Expose new public APIs.
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings): Add new tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Fix CCThreadProxy::setVisible
commit-queue@webkit.org [Sat, 12 Nov 2011 02:05:39 +0000 (02:05 +0000)]
[chromium] Fix CCThreadProxy::setVisible
https://bugs.webkit.org/show_bug.cgi?id=71903

The behavior is different depending on whether we're showing
or hiding the compositor. This patch fixes both code paths.

Patch by Iain Merrick <husky@google.com> on 2011-11-11
Reviewed by James Robinson.

* platform/graphics/chromium/cc/CCCompletionEvent.h:
(WebCore::CCCompletionEvent::CCCompletionEvent):
(WebCore::CCCompletionEvent::~CCCompletionEvent):
(WebCore::CCCompletionEvent::wait):
(WebCore::CCCompletionEvent::signal):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] CCThreadProxy::finishAllRendering hangs if !visible
commit-queue@webkit.org [Sat, 12 Nov 2011 01:52:27 +0000 (01:52 +0000)]
[chromium] CCThreadProxy::finishAllRendering hangs if !visible
https://bugs.webkit.org/show_bug.cgi?id=71920

Patch by Iain Merrick <husky@google.com> on 2011-11-11
Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::setNeedsForcedRedraw):
* platform/graphics/chromium/cc/CCScheduler.h:
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::setNeedsForcedRedraw):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::requestReadbackOnImplThread):
(WebCore::CCThreadProxy::finishAllRenderingOnImplThread):

Source/WebKit/chromium:

* tests/CCSchedulerStateMachineTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Skip tests when no network is present
commit-queue@webkit.org [Sat, 12 Nov 2011 01:38:02 +0000 (01:38 +0000)]
[Qt] Skip tests when no network is present
https://bugs.webkit.org/show_bug.cgi?id=72031

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2011-11-11
Reviewed by Simon Hausmann.

Some benchmark tests requires network connection (they fetch data from
external URL's) and so they fail if no network is present. These tests
should be skipped instead.

* tests/benchmarks/loading/tst_loading.cpp:
(tst_Loading::load): Skip test if no network is present.
* tests/benchmarks/painting/tst_painting.cpp:
(tst_Painting::paint): Skip test if no network is present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Enable building without shared workers.
jknotten@chromium.org [Sat, 12 Nov 2011 01:37:06 +0000 (01:37 +0000)]
[Chromium] Enable building without shared workers.
https://bugs.webkit.org/show_bug.cgi?id=72122

Reviewed by Yury Semikhatsky.

* bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::retrieveWorkerContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash in styleDidChange when changing a table cell's height.
jchaffraix@webkit.org [Sat, 12 Nov 2011 01:26:22 +0000 (01:26 +0000)]
Crash in styleDidChange when changing a table cell's height.
<http://webkit.org/b/72004>

Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/table/crash-table-cell-change-height.html
       fast/table/table-cell-change-height-with-needsCellRecalc-section.html
       fast/table/table-cell-change-last-row-with-needsCellRecalc-section.html
       fast/table/table-row-change-height-with-needsCellRecalc-section.html

r99212 removed our call to recalcCells when the logical height changed. This
means that we could end up with a cells without having set its row() properly
which would crash.

The change exposes the was-the-row-properly-set information so that we don't
try to access a bogus index. This should work properly even if the section
needs a cell recalc as the current section's row structure would still be
accurate in this case.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleDidChange): Check that our row index
was properly set before calling

* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::rowWasSet): Helper function to detect
if we have set up our a row.
(WebCore::RenderTableCell::row): Use the previous function in the
ASSERT.

LayoutTests:

* fast/table/crash-table-cell-change-height-expected.txt: Added.
* fast/table/crash-table-cell-change-height.html: Added.

* fast/table/table-cell-change-height-with-needsCellRecalc-section-expected.txt: Added.
* fast/table/table-cell-change-height-with-needsCellRecalc-section.html: Added.
* fast/table/table-cell-change-last-row-with-needsCellRecalc-section-expected.txt: Added.
* fast/table/table-cell-change-last-row-with-needsCellRecalc-section.html: Added.
* fast/table/table-row-change-height-with-needsCellRecalc-section-expected.txt: Added.
* fast/table/table-row-change-height-with-needsCellRecalc-section.html: Added.
Those tests checks that we don't try to access bad rows when the section needs a recalc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement legacy text check emulation in unified text check interface.
commit-queue@webkit.org [Sat, 12 Nov 2011 01:21:44 +0000 (01:21 +0000)]
Implement legacy text check emulation in unified text check interface.
https://bugs.webkit.org/show_bug.cgi?id=70299

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-11
Reviewed by Hajime Morita.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

When UNIFIED_TEXT_CHECKING is off, WebCore::checkTextOfParagraph() emulates
TextCheckerClient::checkTextOfParagraph() using checkSpellingOfString and checkGrammarOfString.

This emulation can be used by setting the flag on.
This can be done by WebCore::Internals::setUnifiedTextCheckingEnabled.

Test: editing/spelling/spelling-unified-emulation.html

* editing/TextCheckingHelper.cpp:
(WebCore::findBadGrammars): Added.
(WebCore::findMisspellings): Added.
(WebCore::checkTextOfParagraph):
  Emulates TextCheckerClients::checkTextOfParagraph if UNIFIED_TEXT_CHECKING is off.
* testing/Internals.cpp:
(WebCore::Internals::setUnifiedTextCheckingEnabled): flag setter.
(WebCore::Internals::unifiedTextCheckingEnabled): flag getter.
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

Added tests for the case unified text checker is used when WebCore::checkTextOfParagraph() is not supported.

* editing/spelling/spelling-unified-emulation-expected.txt: Added.
* editing/spelling/spelling-unified-emulation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[CMAKE] Add a missing file to PlatformEfl.cmake for curl network backend.
gyuyoung.kim@samsung.com [Sat, 12 Nov 2011 01:15:04 +0000 (01:15 +0000)]
[CMAKE] Add a missing file to PlatformEfl.cmake for curl network backend.
https://bugs.webkit.org/show_bug.cgi?id=72092

Unreviewed. Fix build break when using curl.

ProxyServerCurl.cpp file is not included in PlatformEfl.cmake. So, the file is not built
when EFL port uses curl as network backend.

* PlatformEfl.cmake: Add missing ProxyServerCurl.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch remaining RenderBlock/Box methods to to new layout types
eae@chromium.org [Sat, 12 Nov 2011 01:12:58 +0000 (01:12 +0000)]
Switch remaining RenderBlock/Box methods to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=72075

Reviewed by Eric Seidel.

Move margins, floats and line layout block logic to layout abstraction.

No new tests.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::borderPaddingMarginStart):
(WebCore::borderPaddingMarginEnd):
(WebCore::inlineLogicalWidth):
(WebCore::setStaticPositions):
(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::setRepaintRange):
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::checkFloatsInCleanLine):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
(WebCore::RenderBlock::addOverflowFromInlineChildren):
(WebCore::RenderBlock::checkLinesForTextOverflow):
(WebCore::RenderBlock::positionNewFloatOnLine):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::positionLineBox):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
* rendering/RenderBox.h:
(WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Add translation/scaling to WebExternalTextureLayer
commit-queue@webkit.org [Sat, 12 Nov 2011 00:57:48 +0000 (00:57 +0000)]
[chromium] Add translation/scaling to WebExternalTextureLayer
https://bugs.webkit.org/show_bug.cgi?id=72087

Patch by Antoine Labour <piman@chromium.org> on 2011-11-11
Reviewed by James Robinson.

Source/WebCore:

Covered by WebLayerTest.

* platform/graphics/chromium/PluginLayerChromium.cpp:
(WebCore::PluginLayerChromium::PluginLayerChromium):
(WebCore::PluginLayerChromium::setUVRect):
(WebCore::PluginLayerChromium::pushPropertiesTo):
* platform/graphics/chromium/PluginLayerChromium.h:
(WebCore::PluginLayerChromium::uvRect):
* platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::VertexShaderPosTexStretch::VertexShaderPosTexStretch):
(WebCore::VertexShaderPosTexStretch::init):
(WebCore::VertexShaderPosTexStretch::getShaderString):
* platform/graphics/chromium/ShaderChromium.h:
(WebCore::VertexShaderPosTexStretch::matrixLocation):
(WebCore::VertexShaderPosTexStretch::offsetLocation):
(WebCore::VertexShaderPosTexStretch::scaleLocation):
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
(WebCore::CCPluginLayerImpl::draw):
* platform/graphics/chromium/cc/CCPluginLayerImpl.h:
(WebCore::CCPluginLayerImpl::setUVRect):

Source/WebKit/chromium:

* public/WebExternalTextureLayer.h:
* src/WebExternalTextureLayer.cpp:
(WebKit::WebExternalTextureLayer::setUVRect):
(WebKit::WebExternalTextureLayer::uvRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNull deref when no use element exists for SVG element instance
commit-queue@webkit.org [Sat, 12 Nov 2011 00:34:57 +0000 (00:34 +0000)]
Null deref when no use element exists for SVG element instance
https://bugs.webkit.org/show_bug.cgi?id=59136

Second attempt, with a fix to handle JS garbage collection.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/custom/element-instance-held-by-js-crash.svg

* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::~SVGElementInstance): Added call to detach() to clear
  anything not yet cleared.
(WebCore::SVGElementInstance::detach): New method to replace old clear methods. This one
  clears all the pointers it can, and removes the instance from the corresponding elements
  instance list.
* svg/SVGElementInstance.h: Removed clear methods and replaced with detach.
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::detachInstance): Modified calls to clean up an SVGElementInstance.

LayoutTests:

* svg/custom/element-instance-held-by-js-crash-expected.txt: Added.
* svg/custom/element-instance-held-by-js-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoclipPath does not work on foreignObject
commit-queue@webkit.org [Sat, 12 Nov 2011 00:30:05 +0000 (00:30 +0000)]
clipPath does not work on foreignObject
https://bugs.webkit.org/show_bug.cgi?id=68251

Patch by Florin Malita <fmalita@google.com> on 2011-11-11
Reviewed by Dirk Schulze.

Source/WebCore:

Add ForeignObject clipping, filtering and masking support using the SVGRenderSupport helpers
(prepareToRenderSVGContent, finishRenderSVGContent) on RenderSVGForeignObject's paint path.
This also allows us to remove explicit transparency handling, since the helpers already cover it.

Tests: svg/foreignObject/clip.html
       svg/foreignObject/filter.html
       svg/foreignObject/mask.html

* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::paint):
* rendering/svg/SVGResources.cpp:
(WebCore::clipperFilterMaskerTags):

LayoutTests:

* svg/foreignObject/clip-expected.png: Added.
* svg/foreignObject/clip-expected.txt: Added.
* svg/foreignObject/clip.html: Added.
* svg/foreignObject/filter-expected.png: Added.
* svg/foreignObject/filter-expected.txt: Added.
* svg/foreignObject/filter.html: Added.
* svg/foreignObject/mask-expected.png: Added.
* svg/foreignObject/mask-expected.txt: Added.
* svg/foreignObject/mask.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert http://trac.webkit.org/changeset/100008.
ojan@chromium.org [Sat, 12 Nov 2011 00:07:11 +0000 (00:07 +0000)]
Revert http://trac.webkit.org/changeset/100008.
Caused hundreds of failures on the Chromium Leopard bots.
https://bugs.webkit.org/show_bug.cgi?id=68270

* platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
* platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png:
* platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate expectations for failing test.
ojan@chromium.org [Sat, 12 Nov 2011 00:02:43 +0000 (00:02 +0000)]
Update expectations for failing test.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove no-op StorageNamespace::unlock method
adamk@chromium.org [Fri, 11 Nov 2011 23:54:14 +0000 (23:54 +0000)]
Remove no-op StorageNamespace::unlock method
https://bugs.webkit.org/show_bug.cgi?id=72181

Reviewed by Darin Adler.

Source/WebCore:

The method was meant to support the localStorage mutex,
but the approach of using a mutex for localStorage has never been
implemented (and almost certainly won't be). Even if it were implemented,
it's not being called at the right time, due to bugs in the V8 bindings'
use of V8Proxy (see http://webkit.org/b/72063 for details).

If, in the future, some replacement for a mutex is used to synchronize
localStorage access, it can easily be re-added to the (hopefully
fixed-by-then) replacement for V8Proxy::didLeaveScriptContext.

* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::didLeaveScriptContext): Stop calling unlock().
* page/Navigator.cpp:
(WebCore::Navigator::getStorageUpdates): Remove implementation (a call to unlock), but leave code as it's exposed to the platform.
* page/Navigator.idl: Added a FIXME to remove getStorageUpdates from the platform.
* storage/StorageNamespace.h:
* storage/StorageNamespaceImpl.cpp:
* storage/StorageNamespaceImpl.h:

Source/WebKit/chromium:

* src/StorageNamespaceProxy.cpp:
* src/StorageNamespaceProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
commit-queue@webkit.org [Fri, 11 Nov 2011 23:52:09 +0000 (23:52 +0000)]
[Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
https://bugs.webkit.org/show_bug.cgi?id=49257

Source/WebKit/chromium:

Add the WebFrame::getPageProperty method for Chromium.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Darin Fisher.

* public/WebFrame.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::getPageProperty):
* src/WebFrameImpl.h:

Tools:

Adds the remaining missing layout test functionality for printing.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Darin Fisher.

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController): Add bindings for new JS methods
(parsePageNumber): Method to parse JS arguments for a page number
(parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
(LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
(LayoutTestController::isPageBoxVisible): get the visibility status for printing
(LayoutTestController::pageProperty): get a specific CSS property when in printing mode
* DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods

LayoutTests:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-11
Reviewed by Darin Fisher.

* platform/chromium/test_expectations.txt: Removed expected fails for
printing tests that were using missing functionality in LayoutTestController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate iOS compiler version.
barraclough@apple.com [Fri, 11 Nov 2011 23:50:19 +0000 (23:50 +0000)]
Update iOS compiler version.

Reviewed by David Kilzer.

* Configurations/CompilerVersion.xcconfig:
    - Update compiler version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Make sure Scrollbars are in their own layer.
alexis.menard@openbossa.org [Fri, 11 Nov 2011 23:44:59 +0000 (23:44 +0000)]
[Qt][WK2] Make sure Scrollbars are in their own layer.
https://bugs.webkit.org/show_bug.cgi?id=72064

Reviewed by Kenneth Rohde Christiansen.

Make sure we render our scrollbars in a separate layer.

No new tests : existing ones should cover.

* platform/qt/ScrollbarThemeQt.h:
(WebCore::ScrollbarThemeQt::usesOverlayScrollbars):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate iOS port's configuration setting, particularly in Platform.h
barraclough@apple.com [Fri, 11 Nov 2011 23:43:00 +0000 (23:43 +0000)]
Update iOS port's configuration setting, particularly in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=72187

Reviewed by David Kilzer.

* interpreter/Interpreter.h:
    - Lower the reentry depth.
* runtime/DatePrototype.cpp:
    - iOS also uses CF.
* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::IncrementalScavenge):
    - Update fastmalloc configuration for iOS.
* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):
    - Added flag.
* wtf/Platform.h:
    - Update platform configuration for iOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRepaint broken when children of filtered SVG elements are updated
commit-queue@webkit.org [Fri, 11 Nov 2011 23:40:57 +0000 (23:40 +0000)]
Repaint broken when children of filtered SVG elements are updated
https://bugs.webkit.org/show_bug.cgi?id=71733

Patch by Joel Webber <jgw@google.com> on 2011-11-11
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/repaint/filter-child-repaint.svg

* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::setNeedsLayoutForFilteredContainer):

LayoutTests:

* platform/chromium-linux/svg/repaint/filter-child-repaint-expected.png: Added.
* platform/chromium-linux/svg/repaint/filter-child-repaint-expected.txt: Added.
* svg/repaint/filter-child-repaint.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't remove InspectorBackendStub.js in Release builds after it has been
timothy@apple.com [Fri, 11 Nov 2011 23:19:05 +0000 (23:19 +0000)]
Don't remove InspectorBackendStub.js in Release builds after it has been
combined into inspector.js. Also remove any *.qrc file on Mac.

https://webkit.org/b/72186

Reviewed by Joseph Pecoraro.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago WebProcess should use AppSandbox style quarantine
ap@apple.com [Fri, 11 Nov 2011 23:06:35 +0000 (23:06 +0000)]
    WebProcess should use AppSandbox style quarantine
        https://bugs.webkit.org/show_bug.cgi?id=72168
        <rdar://problem/10434292>

        Reviewed by Darin Adler.

        * WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox): Just enable it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Patch that implementing the changes required to allow WebGL
commit-queue@webkit.org [Fri, 11 Nov 2011 22:55:11 +0000 (22:55 +0000)]
[chromium] Patch that implementing the changes required to allow WebGL
to share its backing store directly with the compositor.
WebGL rendering contexts create and render to FBOs managed by a
DrawingBuffer instance. All PlatformLayer lifetime management is
performed by the DrawingBuffer.
Changes are only relevant to Chromium ports. Functionality is
unchanged for other ports.
https://bugs.webkit.org/show_bug.cgi?id=53201

Patch by Jeff Timanus <twiz@chromium.org> on 2011-11-11
Reviewed by Stephen White.

Source/WebCore:

* html/canvas/WebGLRenderingContext.cpp: Construct a DrawingBuffer
during initialization, and forward all framebuffer management calls to
it.
(WebCore::WebGLRenderingContext::create):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::markContextChanged):
(WebCore::WebGLRenderingContext::clearIfComposited):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::paintRenderingResultsToImageData):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::drawingBufferWidth):
(WebCore::WebGLRenderingContext::drawingBufferHeight):
(WebCore::WebGLRenderingContext::bindFramebuffer):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::deleteFramebuffer):
(WebCore::WebGLRenderingContext::disable):
(WebCore::WebGLRenderingContext::enable):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::platformLayer):
(WebCore::WebGLRenderingContext::getBoundFramebufferWidth):
(WebCore::WebGLRenderingContext::getBoundFramebufferHeight):
(WebCore::WebGLRenderingContext::maybeRestoreContext):
* html/canvas/WebGLRenderingContext.h:
* platform/graphics/GraphicsContext3D.cpp:
* platform/graphics/GraphicsContext3D.h:  WebGLLayerChromium instances
are no longer tracked by GraphicsContext3D. Callers can now pass a
DrawingBuffer instance to provide access to the WebGLLayerChromium data.
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::generateColorTexture):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::initialize):
(WebCore::DrawingBuffer::publishToPlatformLayer):
(WebCore::DrawingBuffer::platformLayer):
(WebCore::DrawingBuffer::platformColorBuffer):
(WebCore::DrawingBuffer::framebuffer):
(WebCore::DrawingBuffer::markContextChanged):
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::WebGLLayerChromium):
(WebCore::WebGLLayerChromium::~WebGLLayerChromium):
(WebCore::WebGLLayerChromium::drawsContent):
(WebCore::WebGLLayerChromium::updateCompositorResources):
(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):
(WebCore::WebGLLayerChromium::contentChanged):
(WebCore::WebGLLayerChromium::setDrawingBuffer):
(WebCore::WebGLLayerChromium::context):
* platform/graphics/chromium/WebGLLayerChromium.h: WebGLLayerChromium instances
have a raw reference to their owning DrawingBuffer.  This reference is set to NULL on
destruction of the DrawingBuffer.  This follows the old code, which had the WebGLLayerChromium
refer rawly to a GraphicsContext3D instance, which was also revoked during tear-down of the
GraphicsContext3D.
(WebCore::WebGLLayerChromium::drawingBuffer):
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
* platform/graphics/gpu/DrawingBuffer.cpp: The DrawingBuffer is now the
central point between the GraphicsContext3D, WebGLRenderingContext, and
WebGLLayerChromium classes.  GraphicsContext3D, and WebGLLayerChromium only
depend on the DrawingBuffer interface.
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::clearFramebuffer):
(WebCore::DrawingBuffer::reset):
(WebCore::DrawingBuffer::commit):
(WebCore::DrawingBuffer::multisample):
(WebCore::DrawingBuffer::paintRenderingResultsToImageData):
(WebCore::DrawingBuffer::discardResources):
* platform/graphics/gpu/DrawingBuffer.h:
(WebCore::DrawingBuffer::setScissorEnabled):
* platform/graphics/gpu/mac/DrawingBufferMac.mm:
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/gpu/qt/DrawingBufferQt.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

Source/WebKit/chromium:

* src/GraphicsContext3DChromium.cpp: GraphicsContext3DPrivate no longer caches
the WebGLLayerChromium instance.  Instead, it is accessed via DrawingBuffer instances
passed as arguments to the necessary routines.
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3DPrivate::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
* src/GraphicsContext3DPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOnly define BUILDING_ON_* and TARGETING_* macros when building for Mac OS X
ddkilzer@apple.com [Fri, 11 Nov 2011 22:54:40 +0000 (22:54 +0000)]
Only define BUILDING_ON_* and TARGETING_* macros when building for Mac OS X
<http://webkit.org/b/72175>

Reviewed by Joseph Pecoraro.

* wtf/Platform.h: Move the definition of the BUILDING_ON_* and
TARGETING_* macros to where the WTF_OS_MAC_OS_X macro is defined
so that they're only defined on Mac OS X builds.  Also include
Availability.h, which is needed on iOS builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove all releaseRef implementations except for RetainPtr
darin@apple.com [Fri, 11 Nov 2011 22:51:58 +0000 (22:51 +0000)]
Remove all releaseRef implementations except for RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=71423

Reviewed by Julien Chaffraix.

Source/JavaScriptCore:

* API/JSRetainPtr.h: Removed releaseRef.
* wtf/PassRefPtr.h: Removed releaseRef.

Source/WebCore:

* platform/win/COMPtr.h: Removed releaseRef.

Tools:

* DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
(createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* WebCore.xcodeproj/project.pbxproj: Let a newer Xcode update this file.
darin@apple.com [Fri, 11 Nov 2011 22:50:09 +0000 (22:50 +0000)]
* WebCore.xcodeproj/project.pbxproj: Let a newer Xcode update this file.
If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r99953.
ojan@chromium.org [Fri, 11 Nov 2011 22:41:35 +0000 (22:41 +0000)]
Unreviewed, rolling out r99953.
Caused 4 tests to hit an assert.
https://bugs.webkit.org/show_bug.cgi?id=72163

Source/WebCore:

* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didStartWorkerContext):
* inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::setFrontend):
(WebCore::InspectorWorkerAgent::restore):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
(WebCore::InspectorWorkerAgent::workerContextTerminated):
* inspector/InspectorWorkerAgent.h:

LayoutTests:

* http/tests/inspector-enabled/dedicated-workers-list-expected.txt: Removed.
* http/tests/inspector-enabled/dedicated-workers-list.html: Removed.
* http/tests/inspector-enabled/resources/dedicated-worker.js: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r100024.
scheib@chromium.org [Fri, 11 Nov 2011 22:37:13 +0000 (22:37 +0000)]
Unreviewed, rolling out r100024.
http://trac.webkit.org/changeset/100024
https://bugs.webkit.org/show_bug.cgi?id=72158

Broke chromium build

* dom/MouseEvent.cpp:
(WebCore::MouseEvent::initMouseEvent):
(WebCore::MouseEventDispatchMediator::dispatchEvent):
* dom/MouseEvent.h:
* dom/MouseEvent.idl:
* dom/MouseRelatedEvent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixup wrong expectations from http://trac.webkit.org/changeset/100008.
ojan@chromium.org [Fri, 11 Nov 2011 22:35:52 +0000 (22:35 +0000)]
Fixup wrong expectations from trac.webkit.org/changeset/100008.
Pull in expectations from downstream expectations due to V8 roll.
Add new expectation for failure.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Remove unused flags in pre-render implementation
commit-queue@webkit.org [Fri, 11 Nov 2011 22:30:03 +0000 (22:30 +0000)]
[EFL] Remove unused flags in pre-render implementation
https://bugs.webkit.org/show_bug.cgi?id=65504

The high priority pre-render flag was not used anywhere,
so we can get rid of the whole concept and always consider the requests have low priority

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2011-11-11
Reviewed by Daniel Bates.

* ewk/ewk_tiled_backing_store.cpp:
(_ewk_tiled_backing_store_pre_render_request_add):
(ewk_tiled_backing_store_pre_render_region):
(ewk_tiled_backing_store_pre_render_relative_radius):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMouse Lock: MouseEvent IDL
scheib@chromium.org [Fri, 11 Nov 2011 22:29:56 +0000 (22:29 +0000)]
Mouse Lock: MouseEvent IDL
https://bugs.webkit.org/show_bug.cgi?id=72158

Reviewed by Dimitri Glazkov.

Tests for movementX/Y pending mock mouse lock test infrastructure.

* dom/MouseEvent.cpp:
(WebCore::MouseEvent::initMouseEvent):
(WebCore::MouseEventDispatchMediator::dispatchEvent):
* dom/MouseEvent.h:
* dom/MouseEvent.idl:
* dom/MouseRelatedEvent.h:
(WebCore::MouseRelatedEvent::movementX):
(WebCore::MouseRelatedEvent::movementY):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r99990.
ojan@chromium.org [Fri, 11 Nov 2011 22:20:38 +0000 (22:20 +0000)]
Unreviewed, rolling out r99990.
http://trac.webkit.org/changeset/99990
https://bugs.webkit.org/show_bug.cgi?id=72134

Caused worker tests to fail on the chromium bots.

* fast/workers/resources/worker-replace-self.js:
(worker.onmessage):
* fast/workers/worker-call.html:
* fast/workers/worker-close.html:
* fast/workers/worker-messageport-gc.html:
* fast/workers/worker-replace-self.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=72167
bdakin@apple.com [Fri, 11 Nov 2011 22:19:24 +0000 (22:19 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=72167
REGRESSION: Scroll position not restored on back after scroll
-and corresponding-
<rdar://problem/10410684>

Reviewed by Simon Fraser.

We can't just return early if we are not on an active page.
notifyPositionChanged() is called when a page is going into the page cache (and
therefore when not on an active page). We should not notify AppKit that the page
has scrolled in that case, but we still need to call
ScrollAnimator::notifyPositionChanged();. So this patch removes the early return,
and replaces it with a conditional around the relevant code.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::notifyPositionChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdded TileCairo and TiledBackingStoreBackendCairo files
commit-queue@webkit.org [Fri, 11 Nov 2011 22:18:29 +0000 (22:18 +0000)]
Added TileCairo and TiledBackingStoreBackendCairo files
https://bugs.webkit.org/show_bug.cgi?id=71350

Patch by Julien Chaffraix  <jchaffraix@codeaurora.org>, Zaheer Ahmad  <zahimad@codeaurora.org>, Joone Hur  <joone.hur@collabora.co.uk>, Tomasz Morawski <t.morawski@samsung.com> on 2011-11-11
Reviewed by Martin Robinson.

Added TileCairo and TiledBackingStoreBackend files needed by Tiled Backing Store implementation that uses cairo
library eg. EFL and Gtk WebKit port.

This patch contains some parts of rebased and updated code from 45423 bug. Originals authors of the code are:
- Julien Chaffraix  <jchaffraix@codeaurora.org>
- Zaheer Ahmad  <zahmad@codeaurora.org>
- Joone Hur  <joone.hur@collabora.co.uk>

* platform/graphics/cairo/RefPtrCairo.cpp: Added support of RefPtr for cairo_region object.
(WTF::refIfNotNull): New refIfNotNull function for cairo_region object.
(WTF::derefIfNotNull): New derefIfNotNull function for cairo_region object.
* platform/graphics/cairo/RefPtrCairo.h: Added support of RefPtr for cairo_region object.
* platform/graphics/cairo/TileCairo.cpp: Added a new file. Implementation of TileCairo class.
(WebCore::TileCairo::TileCairo):
(WebCore::TileCairo::~TileCairo):
(WebCore::TileCairo::isDirty):
(WebCore::TileCairo::isReadyToPaint):
(WebCore::TileCairo::invalidate):
(WebCore::TileCairo::updateBackBuffer):
(WebCore::TileCairo::swapBackBufferToFront):
(WebCore::TileCairo::paint):
(WebCore::TileCairo::resize):
* platform/graphics/cairo/TileCairo.h: Added a new file. Implementation of TileCairo class.
(WebCore::TileCairo::create):
(WebCore::TileCairo::coordinate):
(WebCore::TileCairo::rect):
* platform/graphics/cairo/TiledBackingStoreBackendCairo.cpp: Added a new file. Implementation of
TiledBackingStoreBackend methods.
(WebCore::TiledBackingStoreBackend::createTile):
(WebCore::checkeredSurface): Helper function that creates checkered surface (see below function)
(WebCore::TiledBackingStoreBackend::paintCheckerPattern): Function is used to draw a place holder when tile no
exist or it is not ready to paint yet. The checkered surface is used here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* JavaScriptCore.xcodeproj/project.pbxproj: Let a newer Xcode update this file.
darin@apple.com [Fri, 11 Nov 2011 22:15:57 +0000 (22:15 +0000)]
* JavaScriptCore.xcodeproj/project.pbxproj: Let a newer Xcode update this file.
If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* ANGLE.xcodeproj/project.pbxproj: Let a newer Xcode update this file.
darin@apple.com [Fri, 11 Nov 2011 22:15:25 +0000 (22:15 +0000)]
* ANGLE.xcodeproj/project.pbxproj: Let a newer Xcode update this file.
If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* WebKit2.xcodeproj/project.pbxproj: Let a newer Xcode update this file.
darin@apple.com [Fri, 11 Nov 2011 22:15:05 +0000 (22:15 +0000)]
* WebKit2.xcodeproj/project.pbxproj: Let a newer Xcode update this file.
If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* WebKit.xcodeproj/project.pbxproj: Let a newer Xcode update this file.
darin@apple.com [Fri, 11 Nov 2011 22:14:55 +0000 (22:14 +0000)]
* WebKit.xcodeproj/project.pbxproj: Let a newer Xcode update this file.
If an older Xcode downgrades this file and we have a risk of some kind of
oscillating commit situation, please contact me so I know not to do this again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate expected results for composited canvas operations
commit-queue@webkit.org [Fri, 11 Nov 2011 22:02:04 +0000 (22:02 +0000)]
Update expected results for composited canvas operations
https://bugs.webkit.org/show_bug.cgi?id=71995

Patch by Ben Wells <benwells@chromium.org> on 2011-11-11
Reviewed by Kenneth Russell.

* canvas/philip/tests/2d.composite.uncovered.image.copy-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.image.destination-atop-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.image.destination-in-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.image.source-in-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.image.source-out-expected.txt:
* canvas/philip/tests/2d.composite.uncovered.pattern.copy-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unneeded frame check in FrameView::detachCustomScrollbars
jchaffraix@webkit.org [Fri, 11 Nov 2011 22:01:24 +0000 (22:01 +0000)]
Remove unneeded frame check in FrameView::detachCustomScrollbars
https://bugs.webkit.org/show_bug.cgi?id=71980

Reviewed by Anders Carlsson.

Change covered by the existing tests in scrollbars/.

* page/FrameView.cpp:
(WebCore::FrameView::detachCustomScrollbars):
Remove the leftover check that was forgotten by the different refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAccess key should work on all elements.
commit-queue@webkit.org [Fri, 11 Nov 2011 21:58:49 +0000 (21:58 +0000)]
Access key should work on all elements.
https://bugs.webkit.org/show_bug.cgi?id=71854

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-11-11
Reviewed by Adam Barth.

Source/WebCore:

As per specification http://dev.w3.org/html5/spec/Overview.html#elements-in-the-dom
says All HTML elements can have the accesskey content attribute set. Adding "accessKey"
attribute idl file as [Reflect].

Test: fast/forms/access-key-for-all-elements.html

* html/HTMLAnchorElement.idl: Removed redundant IDL attribute entries.
* html/HTMLAreaElement.idl: Ditto.
* html/HTMLButtonElement.idl: Ditto.
* html/HTMLElement.idl: Added accessKey IDL attribute.
* html/HTMLInputElement.idl: Ditto.
* html/HTMLLabelElement.idl: Ditto.
* html/HTMLLegendElement.idl: Ditto.
* html/HTMLTextAreaElement.idl: Ditto.

LayoutTests:

Added test case to check whether all elements can also have accessKey attribute.

* fast/forms/access-key-for-all-elements-expected.txt: Added.
* fast/forms/access-key-for-all-elements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove color space information from canvas composited drawImage tests
commit-queue@webkit.org [Fri, 11 Nov 2011 21:42:38 +0000 (21:42 +0000)]
Remove color space information from canvas composited drawImage tests
https://bugs.webkit.org/show_bug.cgi?id=71970

Patch by Ben Wells <benwells@chromium.org> on 2011-11-11
Reviewed by Stephen White.

* fast/canvas/canvas-composite-canvas.html:
* fast/canvas/canvas-composite-image.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r100010.
ojan@chromium.org [Fri, 11 Nov 2011 21:25:15 +0000 (21:25 +0000)]
Unreviewed, rolling out r100010.
http://trac.webkit.org/changeset/100010
https://bugs.webkit.org/show_bug.cgi?id=72172

"Broke gclient syncing on the chromium bots." (Requested by
ojan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Rolled DEPS.
ojan@chromium.org [Fri, 11 Nov 2011 21:05:03 +0000 (21:05 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAssertion failed if text field is cleared while drag&drop.
commit-queue@webkit.org [Fri, 11 Nov 2011 20:52:53 +0000 (20:52 +0000)]
Assertion failed if text field is cleared while drag&drop.
https://bugs.webkit.org/show_bug.cgi?id=61008

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-11-11
Reviewed by Ryosuke Niwa.

Test to drag-drop text from one input element to another clearing the first input
element. Fixed in Change set - http://trac.webkit.org/changeset/99085

* fast/events/drag-text-with-clear-expected.txt: Added.
* fast/events/drag-text-with-clear.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRe-enable layout test comparisons on chromium-mac-leopard.
commit-queue@webkit.org [Fri, 11 Nov 2011 20:51:01 +0000 (20:51 +0000)]
Re-enable layout test comparisons on chromium-mac-leopard.
https://bugs.webkit.org/show_bug.cgi?id=68270

Patch by Elliot Poger <epoger@google.com> on 2011-11-11
Reviewed by Adam Barth.

* platform/chromium-mac-leopard/fast/css/input-search-padding-expected.png:
* platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
* platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoving the 4th test in factory-deletedatabase-interactions.html
jochen@chromium.org [Fri, 11 Nov 2011 20:48:31 +0000 (20:48 +0000)]
Removing the 4th test in factory-deletedatabase-interactions.html
https://bugs.webkit.org/show_bug.cgi?id=72037

Reviewed by Ojan Vafai.

Removing the test since it's testing not-yet-written code. Once the new
code is written it will obviously come with the appropriate tests.

* storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
* storage/indexeddb/factory-deletedatabase-interactions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd jsCast to replace static_cast
mhahnenberg@apple.com [Fri, 11 Nov 2011 20:40:10 +0000 (20:40 +0000)]
Add jsCast to replace static_cast
https://bugs.webkit.org/show_bug.cgi?id=72071

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::toStringCallback):
(JSC::JSCallbackFunction::valueOfCallback):
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::visitChildren):
* API/JSCallbackObjectFunctions.h:
(JSC::::className):
(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertyDescriptor):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::deletePropertyByIndex):
(JSC::::getConstructData):
(JSC::::hasInstance):
(JSC::::getCallData):
(JSC::::getOwnPropertyNames):
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::visitChildren):
(JSC::DebuggerActivation::className):
(JSC::DebuggerActivation::getOwnPropertySlot):
(JSC::DebuggerActivation::put):
(JSC::DebuggerActivation::putWithAttributes):
(JSC::DebuggerActivation::deleteProperty):
(JSC::DebuggerActivation::getOwnPropertyNames):
(JSC::DebuggerActivation::getOwnPropertyDescriptor):
(JSC::DebuggerActivation::defineGetter):
(JSC::DebuggerActivation::defineSetter):
* runtime/Arguments.cpp:
(JSC::Arguments::visitChildren):
(JSC::Arguments::getOwnPropertySlotByIndex):
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::getOwnPropertyNames):
(JSC::Arguments::putByIndex):
(JSC::Arguments::put):
(JSC::Arguments::deletePropertyByIndex):
(JSC::Arguments::deleteProperty):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::getOwnPropertySlot):
(JSC::ArrayConstructor::getOwnPropertyDescriptor):
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::getOwnPropertySlot):
(JSC::BooleanPrototype::getOwnPropertyDescriptor):
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::getOwnPropertySlot):
(JSC::DateConstructor::getOwnPropertyDescriptor):
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::getOwnPropertySlot):
(JSC::DatePrototype::getOwnPropertyDescriptor):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::getOwnPropertySlot):
(JSC::ErrorPrototype::getOwnPropertyDescriptor):
* runtime/Executable.cpp:
(JSC::ExecutableBase::clearCode):
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):
* runtime/GetterSetter.cpp:
(JSC::GetterSetter::visitChildren):
* runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildren):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::getOwnPropertySlot):
(JSC::JSActivation::put):
(JSC::JSActivation::putWithAttributes):
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertySlotByIndex):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putByIndex):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::deletePropertyByIndex):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::visitChildren):
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::hasInstance):
(JSC::JSBoundFunction::visitChildren):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::getOwnPropertySlot):
(JSC::JSByteArray::getOwnPropertyDescriptor):
(JSC::JSByteArray::getOwnPropertySlotByIndex):
(JSC::JSByteArray::put):
(JSC::JSByteArray::putByIndex):
(JSC::JSByteArray::getOwnPropertyNames):
* runtime/JSCell.h:
(JSC::JSCell::visitChildren):
(JSC::jsCast):
* runtime/JSFunction.cpp:
(JSC::JSFunction::visitChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::getConstructData):
* runtime/JSGlobalData.cpp:
(JSC::StackPreservingRecompiler::operator()):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::put):
(JSC::JSGlobalObject::putWithAttributes):
(JSC::JSGlobalObject::defineGetter):
(JSC::JSGlobalObject::defineSetter):
(JSC::JSGlobalObject::visitChildren):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):
(JSC::JSGlobalObject::clearRareData):
* runtime/JSGlobalThis.cpp:
(JSC::JSGlobalThis::visitChildren):
* runtime/JSONObject.cpp:
(JSC::JSONObject::getOwnPropertySlot):
(JSC::JSONObject::getOwnPropertyDescriptor):
* runtime/JSObject.cpp:
(JSC::JSObject::finalize):
(JSC::JSObject::visitChildren):
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::put):
(JSC::JSObject::putByIndex):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::deletePropertyByIndex):
* runtime/JSObject.h:
(JSC::JSObject::getOwnPropertySlot):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::visitChildren):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::visitChildren):
(JSC::JSStaticScopeObject::put):
(JSC::JSStaticScopeObject::putWithAttributes):
(JSC::JSStaticScopeObject::getOwnPropertySlot):
* runtime/JSString.cpp:
(JSC::JSString::visitChildren):
(JSC::JSString::toThisObject):
(JSC::JSString::getOwnPropertySlot):
(JSC::JSString::getOwnPropertySlotByIndex):
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::deleteProperty):
(JSC::JSVariableObject::getOwnPropertyNames):
* runtime/JSWrapperObject.cpp:
(JSC::JSWrapperObject::visitChildren):
* runtime/MathObject.cpp:
(JSC::MathObject::getOwnPropertySlot):
(JSC::MathObject::getOwnPropertyDescriptor):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::visitChildren):
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::getOwnPropertySlot):
(JSC::NumberPrototype::getOwnPropertyDescriptor):
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getOwnPropertySlot):
(JSC::ObjectConstructor::getOwnPropertyDescriptor):
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::getOwnPropertySlotByIndex):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getOwnPropertySlot):
(JSC::RegExpConstructor::getOwnPropertyDescriptor):
(JSC::RegExpConstructor::put):
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertySlot):
(JSC::RegExpMatchesArray::getOwnPropertySlotByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
(JSC::RegExpMatchesArray::put):
(JSC::RegExpMatchesArray::putByIndex):
(JSC::RegExpMatchesArray::deleteProperty):
(JSC::RegExpMatchesArray::deletePropertyByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyNames):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::visitChildren):
(JSC::RegExpObject::getOwnPropertySlot):
(JSC::RegExpObject::getOwnPropertyDescriptor):
(JSC::RegExpObject::put):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::getOwnPropertyDescriptor):
* runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::visitChildren):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::getOwnPropertySlot):
(JSC::StringConstructor::getOwnPropertyDescriptor):
* runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertySlot):
(JSC::StringObject::getOwnPropertySlotByIndex):
(JSC::StringObject::getOwnPropertyDescriptor):
(JSC::StringObject::deleteProperty):
(JSC::StringObject::getOwnPropertyNames):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::getOwnPropertySlot):
(JSC::StringPrototype::getOwnPropertyDescriptor):
* runtime/Structure.cpp:
(JSC::Structure::visitChildren):
* runtime/StructureChain.cpp:
(JSC::StructureChain::visitChildren):

Source/JavaScriptGlue:

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

* UserObjectImp.cpp:
(UserObjectImp::getCallData):
(UserObjectImp::getOwnPropertyNames):
(UserObjectImp::getOwnPropertySlot):
(UserObjectImp::put):
(UserObjectImp::visitChildren):

Source/WebCore:

No new tests.

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

* bindings/js/JSAttrCustom.cpp:
(WebCore::JSAttr::visitChildren):
* bindings/js/JSAudioContextCustom.cpp:
(WebCore::JSAudioContext::visitChildren):
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::JSCSSRule::visitChildren):
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::visitChildren):
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::toHTMLCanvasStyle):
* bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::JSCanvasRenderingContext::visitChildren):
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::visitChildren):
* bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::getOwnPropertyNames):
(WebCore::JSDOMStringMap::deleteProperty):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::toThisObject):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::visitChildren):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::deleteProperty):
(WebCore::JSDOMWindow::getPropertyNames):
(WebCore::JSDOMWindow::getOwnPropertyNames):
(WebCore::JSDOMWindow::defineGetter):
(WebCore::JSDOMWindow::defineSetter):
(WebCore::JSDOMWindow::defineOwnProperty):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::className):
(WebCore::JSDOMWindowShell::getOwnPropertySlot):
(WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):
(WebCore::JSDOMWindowShell::put):
(WebCore::JSDOMWindowShell::putWithAttributes):
(WebCore::JSDOMWindowShell::defineOwnProperty):
(WebCore::JSDOMWindowShell::deleteProperty):
(WebCore::JSDOMWindowShell::getPropertyNames):
(WebCore::JSDOMWindowShell::getOwnPropertyNames):
(WebCore::JSDOMWindowShell::defineGetter):
(WebCore::JSDOMWindowShell::defineSetter):
* bindings/js/JSHTMLAppletElementCustom.cpp:
(WebCore::JSHTMLAppletElement::getCallData):
* bindings/js/JSHTMLEmbedElementCustom.cpp:
(WebCore::JSHTMLEmbedElement::getCallData):
* bindings/js/JSHTMLObjectElementCustom.cpp:
(WebCore::JSHTMLObjectElement::getCallData):
* bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::deleteProperty):
(WebCore::JSHistory::getOwnPropertyNames):
* bindings/js/JSJavaScriptAudioNodeCustom.cpp:
(WebCore::JSJavaScriptAudioNode::visitChildren):
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::getOwnPropertyNames):
* bindings/js/JSMessageChannelCustom.cpp:
(WebCore::JSMessageChannel::visitChildren):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::visitChildren):
* bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::visitChildren):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::visitChildren):
* bindings/js/JSNodeFilterCustom.cpp:
(WebCore::JSNodeFilter::visitChildren):
* bindings/js/JSNodeIteratorCustom.cpp:
(WebCore::JSNodeIterator::visitChildren):
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::visitChildren):
* bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorker::visitChildren):
* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::JSStyleSheet::visitChildren):
* bindings/js/JSTreeWalkerCustom.cpp:
(WebCore::JSTreeWalker::visitChildren):
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::visitChildren):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::visitChildren):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::visitChildren):
* bindings/js/JSXPathResultCustom.cpp:
(WebCore::JSXPathResult::visitChildren):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterface::getOwnPropertySlot):
(WebCore::JSTestInterface::getOwnPropertyDescriptor):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestMediaQueryListListener::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListener::getOwnPropertyDescriptor):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructor::getOwnPropertySlot):
(WebCore::JSTestNamedConstructor::getOwnPropertyDescriptor):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjPrototype::getOwnPropertySlot):
(WebCore::JSTestObjPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestObj::getOwnPropertySlot):
(WebCore::JSTestObj::getOwnPropertyDescriptor):
(WebCore::JSTestObj::put):
(WebCore::JSTestObj::visitChildren):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor):
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::getCallData):
(JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObject::visitChildren):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor):
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertyNames):
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertyDescriptor):
(JSC::RuntimeArray::getOwnPropertySlotByIndex):
(JSC::RuntimeArray::put):
(JSC::RuntimeArray::putByIndex):
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::getOwnPropertySlot):
(JSC::RuntimeMethod::getOwnPropertyDescriptor):
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::getOwnPropertySlot):
(JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):
(JSC::Bindings::RuntimeObject::put):
(JSC::Bindings::RuntimeObject::defaultValue):
(JSC::Bindings::RuntimeObject::getCallData):
(JSC::Bindings::RuntimeObject::getConstructData):
(JSC::Bindings::RuntimeObject::getOwnPropertyNames):

Source/WebKit2:

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::getCallData):
(WebKit::JSNPObject::getConstructData):
(WebKit::JSNPObject::getOwnPropertySlot):
(WebKit::JSNPObject::getOwnPropertyDescriptor):
(WebKit::JSNPObject::put):
(WebKit::JSNPObject::deleteProperty):
(WebKit::JSNPObject::deletePropertyByIndex):
(WebKit::JSNPObject::getOwnPropertyNames):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEnable DFG JIT for ARMv7/iOS.
barraclough@apple.com [Fri, 11 Nov 2011 20:31:16 +0000 (20:31 +0000)]
Enable DFG JIT for ARMv7/iOS.

Rubber stamped by Oliver Hunt.

* wtf/Platform.h:
    - enable DFG JIT for ARMv7/iOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r99994.
scheib@chromium.org [Fri, 11 Nov 2011 20:24:33 +0000 (20:24 +0000)]
Unreviewed, rolling out r99994.
http://trac.webkit.org/changeset/99994
https://bugs.webkit.org/show_bug.cgi?id=72150

Broke chromium windows build

* WebCore.gypi:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitLockMouseEnabled):
(WebCore::RuntimeEnabledFeatures::webkitUnlockMouseEnabled):
(WebCore::RuntimeEnabledFeatures::webkitMouseLockedEnabled):
* page/MouseLockable.cpp: Removed.
* page/MouseLockable.h: Removed.
* page/MouseLockable.idl: Removed.
* page/Navigator.cpp:
* page/Navigator.h:
* page/Navigator.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[v8] Remove unused V8Proxy::executingScript method
adamk@chromium.org [Fri, 11 Nov 2011 19:49:20 +0000 (19:49 +0000)]
[v8] Remove unused V8Proxy::executingScript method
https://bugs.webkit.org/show_bug.cgi?id=72160

Reviewed by Nate Chapin.

* bindings/v8/V8Proxy.cpp:
* bindings/v8/V8Proxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
rniwa@webkit.org [Fri, 11 Nov 2011 19:47:14 +0000 (19:47 +0000)]
Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
https://bugs.webkit.org/show_bug.cgi?id=72090

Reviewed by Eric Seidel.

Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.

yay! r100002.

* Scripts/webkitpy/common/checkout/changelog.py:
* Scripts/webkitpy/common/checkout/changelog_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubberstamped by Andy Estes
beidson@apple.com [Fri, 11 Nov 2011 19:45:36 +0000 (19:45 +0000)]
Rubberstamped by Andy Estes

100,000!
Congratulations WebKit, and here's to hundreds of thousands more!

* ChangeLog: Point out revision 100,000.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago100,000 !!!
ossy@webkit.org [Fri, 11 Nov 2011 19:45:34 +0000 (19:45 +0000)]
100,000 !!!

Reviewed by Zoltan Herczeg.

* ChangeLog: Point out revision 100,000.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/71921> Remove use of strcpy in KURL
ddkilzer@apple.com [Fri, 11 Nov 2011 19:45:13 +0000 (19:45 +0000)]
<webkit.org/b/71921> Remove use of strcpy in KURL

Reviewed by Antti Koivisto.

* platform/KURL.cpp:
(WebCore::KURL::init): Replace strcpy() with strncpy().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove --force from gclient sync. The bots seem to have made it past
tony@chromium.org [Fri, 11 Nov 2011 19:41:23 +0000 (19:41 +0000)]
Remove --force from gclient sync.  The bots seem to have made it past
the update step.

* Scripts/update-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDe-virtualize supportsProfiling, supportsRichSourceInfo, shouldInterruptScript in...
mhahnenberg@apple.com [Fri, 11 Nov 2011 19:32:59 +0000 (19:32 +0000)]
De-virtualize supportsProfiling, supportsRichSourceInfo, shouldInterruptScript in JSGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=72035

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

De-virtualized the methods through the use of a new method table just for JSGlobalObject and subclasses.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* bytecompiler/BytecodeGenerator.cpp: Changed call sites to use the new GlobalObjectMethodTable.
(JSC::BytecodeGenerator::BytecodeGenerator):
* interpreter/Interpreter.cpp: Ditto.
(JSC::Interpreter::execute):
* runtime/JSGlobalObject.cpp: Added a static const GlobalObjectMethodTable with the correct function pointers.
* runtime/JSGlobalObject.h: Added a field in JSGlobalObject to keep track of the current method table.
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::globalObjectMethodTable): The new struct to contain the function pointers.
(JSC::JSGlobalObject::supportsProfiling): Made static to put in the method table.
(JSC::JSGlobalObject::supportsRichSourceInfo): Ditto.
(JSC::JSGlobalObject::shouldInterruptScript): Ditto.
* runtime/TimeoutChecker.cpp: Changed call sites to use the new GlobalObjectMethodTable for lookup.
(JSC::TimeoutChecker::didTimeOut):

Source/WebCore:

No new tests.

* bindings/js/JSDOMGlobalObject.cpp: Changed constructor to support passing new GlobalObjectMethodTable pointer to parent class.
(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMWindowBase.cpp: Added static const GlobalObjectMethodTable and filled it in with the proper function pointers.
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::supportsProfiling): Changed to static to put in the method table.
(WebCore::JSDOMWindowBase::supportsRichSourceInfo): Ditto.
(WebCore::JSDOMWindowBase::shouldInterruptScript): Ditto.
* bindings/js/JSDOMWindowBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd --force to gclient sync. Once the cq bots cycle, we can remove
tony@chromium.org [Fri, 11 Nov 2011 19:28:34 +0000 (19:28 +0000)]
Add --force to gclient sync. Once the cq bots cycle, we can remove
this since it slows down the normal sync.

* Scripts/update-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r99869.
ojan@chromium.org [Fri, 11 Nov 2011 19:14:25 +0000 (19:14 +0000)]
Unreviewed, rolling out r99869.
http://trac.webkit.org/changeset/99869
https://bugs.webkit.org/show_bug.cgi?id=72157

"Caused a ~400% perf regression on the Chromium intl1 page
cyclers" (Requested by ojan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
* dom/Document.h:
* html/CollectionType.h:

LayoutTests:

* fast/dom/gc-9-expected.txt:
* fast/dom/gc-9.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMouse Lock Navigator IDL
scheib@chromium.org [Fri, 11 Nov 2011 19:09:49 +0000 (19:09 +0000)]
Mouse Lock Navigator IDL
https://bugs.webkit.org/show_bug.cgi?id=72150

Reviewed by Dimitri Glazkov.

Tests require mocking (similar to geolocation) that will be built after this.

* WebCore.gypi:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):
* page/MouseLockable.cpp: Added.
(WebCore::MouseLockable::MouseLockable):
(WebCore::MouseLockable::~MouseLockable):
(WebCore::MouseLockable::webkitLock):
(WebCore::MouseLockable::webkitUnlock):
(WebCore::MouseLockable::webkitIsLocked):
* page/MouseLockable.h: Added.
(WebCore::MouseLockable::create):
* page/MouseLockable.idl: Added.
* page/Navigator.cpp:
(WebCore::Navigator::webkitPointer):
* page/Navigator.h:
* page/Navigator.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDe-virtualize JSGlobalObject::allowsAccessFrom
mhahnenberg@apple.com [Fri, 11 Nov 2011 19:07:22 +0000 (19:07 +0000)]
De-virtualize JSGlobalObject::allowsAccessFrom
https://bugs.webkit.org/show_bug.cgi?id=71969

Reviewed by Darin Adler.

Source/JavaScriptCore:

* runtime/JSGlobalObject.h: Removed allowsAccessFrom from JSGlobalObject since it is exclusive to
JSDOMWindowBase and WebScriptObject.

Source/WebCore:

No new tests.

Since allowsAccessFrom is only used by WebScriptObject, we know that we'll always have a
JSDOMWindowBase, so we can simply have allowsAccessFrom to live in JSDOMWindowBase rather
than JSGlobalObject.

* bindings/js/JSDOMWindowBase.h: De-virtualized allowsAccessFrom.
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject _isSafeScript]): Added a cast from a JSGlobalObject to a JSDOMWindowBase in
order to call the allowsAccessFrom method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[MutationObservers] Support attributeFilter for attribute mutations
adamk@chromium.org [Fri, 11 Nov 2011 18:56:02 +0000 (18:56 +0000)]
[MutationObservers] Support attributeFilter for attribute mutations
https://bugs.webkit.org/show_bug.cgi?id=70860

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-11
Reviewed by Dimitri Glazkov.

Source/WebCore:

This patch adds an attributeFilter to the MutationObserverRegistration and
adds support for only observing attributes whose name are in the provided
filter set (array of strings).

Test: fast/mutation/observe-attributes.html.

* bindings/js/JSWebKitMutationObserverCustom.cpp:
(WebCore::JSWebKitMutationObserver::observe):
* bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::get):
* bindings/v8/OptionsObject.h:
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::observeCallback):
* dom/Element.cpp:
(WebCore::enqueueAttributesMutationRecord):
* dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::resetObservation):
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):
(WebCore::MutationObserverRegistration::caseInsensitiveAttributeFilter):
* dom/MutationObserverRegistration.h:
* dom/Node.cpp:
(WebCore::Node::collectMatchingObserversForMutation):
(WebCore::Node::getRegisteredMutationObserversOfType):
* dom/Node.h:
* dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::observe):
* dom/WebKitMutationObserver.h:

LayoutTests:

* fast/mutation/observe-attributes-expected.txt:
* fast/mutation/observe-attributes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWhen --force is used, also use --reset
tony@chromium.org [Fri, 11 Nov 2011 18:40:30 +0000 (18:40 +0000)]
When --force is used, also use --reset
https://bugs.webkit.org/show_bug.cgi?id=72129

Patch by Marc-Antoine Ruel <maruel@chromium.org> on 2011-11-11
Reviewed by Dimitri Glazkov.

* Scripts/update-webkit-chromium:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSpeculative fix for a few worker tests.
tony@chromium.org [Fri, 11 Nov 2011 18:35:20 +0000 (18:35 +0000)]
Speculative fix for a few worker tests.
https://bugs.webkit.org/show_bug.cgi?id=72134

Looking at the recent failures, it looks like the test starts and completes
before the page is done loading completely (the test output is correct except
for the HTML on top of the files). So start the tests from an onload callback so
that the plain HTML text also gets printed correctly.

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-11-11
Reviewed by Tony Chang.

* fast/workers/resources/worker-replace-self.js:
(startTest.worker.onmessage):
(startTest):
* fast/workers/worker-call.html:
* fast/workers/worker-close.html:
* fast/workers/worker-messageport-gc.html:
* fast/workers/worker-replace-self.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoallow two chromium drivers to run at the same time in NRWT
tony@chromium.org [Fri, 11 Nov 2011 18:30:46 +0000 (18:30 +0000)]
allow two chromium drivers to run at the same time in NRWT
https://bugs.webkit.org/show_bug.cgi?id=72067

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
    posix prevents the subprocesses from sharing the same fd for stdin.
    Sharing the same fd prevents us from closing the files unless all references
    to the fd are closed.
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
    to adding a test for this, speed up a test (from 3sec to 0) by fixing
    the timeout override. It looks like it regressed in r95875.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoApplication cache status indicator gets stuck at DOWNLOADING after a failure
vsevik@chromium.org [Fri, 11 Nov 2011 18:28:50 +0000 (18:28 +0000)]
Application cache status indicator gets stuck at DOWNLOADING after a failure
https://bugs.webkit.org/show_bug.cgi?id=60793

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html

* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::restore):
(WebCore::InspectorApplicationCacheAgent::enable):
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::restoreInspectorStateFromCookie):
* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype.updateStatus):

LayoutTests:

* http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt:
* http/tests/inspector/resource-tree/appcache-iframe-manifests.html:
* http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Added.
* http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html: Added.
* http/tests/inspector/resource-tree/appcache-test.js: Added.
(createAndNavigateIFrame):
(removeIFrame):
(navigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame.frameDetached):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheTree):
(initialize_ApplicationCacheTest.InspectorTest.frameIdToString):
(initialize_ApplicationCacheTest.InspectorTest.applicationCacheStatusToString):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.waitForFrameManifestURLAndStatus):
(initialize_ApplicationCacheTest.InspectorTest.startApplicationCacheStatusesRecording):
(initialize_ApplicationCacheTest.InspectorTest.ensureFrameManifestStatusEventReceived):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords):
(initialize_ApplicationCacheTest):
* http/tests/inspector/resource-tree/resources/manifest.php:
* platform/chromium/http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Added.
* platform/chromium/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] failing media/track/tracklist-is-reachable
tonyg@chromium.org [Fri, 11 Nov 2011 18:20:19 +0000 (18:20 +0000)]
[chromium] failing media/track/tracklist-is-reachable
https://bugs.webkit.org/show_bug.cgi?id=72149

* platform/chromium/test_expectations.txt: Expect test to fail for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOnly use the textured window style mask when there is no override inspector page.
timothy@apple.com [Fri, 11 Nov 2011 18:03:59 +0000 (18:03 +0000)]
Only use the textured window style mask when there is no override inspector page.

https://webkit.org/b/72142

Reviewed by Dan Bernstein.

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformOpen): Don't set NSTexturedBackgroundWindowMask if
there is an override inspector page. Make setAutorecalculatesContentBorderThickness:,
setContentBorderThickness: and WKNSWindowMakeBottomCornersSquare conditional.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExpect chromium to pass this test after r99958.
tonyg@chromium.org [Fri, 11 Nov 2011 17:58:24 +0000 (17:58 +0000)]
Expect chromium to pass this test after r99958.

* platform/chromium/fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement TextTrackList and the textTracks attribute of HTMLMediaElement
eric.carlson@apple.com [Fri, 11 Nov 2011 17:33:51 +0000 (17:33 +0000)]
Implement TextTrackList and the textTracks attribute of HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=71123

Reviewed by Sam Weinig.

Source/WebCore:

Test: media/track/track-add-track.html
      media/track/tracklist-is-reachable.html

* CMakeLists.txt: Add new files for TextTrackList.
* DerivedSources.cpp: Ditto.
* DerivedSources.make: Ditto.
* DerivedSources.pri: Ditto.
* GNUmakefile.list.am: Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/js/JSBindingsAllInOne.cpp: Ditto.

* bindings/js/JSTextTrackListCustom.cpp: Added.
(WebCore::JSTextTrackListOwner::isReachableFromOpaqueRoots):

* dom/EventTargetFactory.in: Add TextTrackList, conditional on VIDEO_TRACK.

* html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::createForJSConstructor): Update for scheduleLoad change.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement): Update for m_textTracks change from
    generic Vector to TextTrackList.
(WebCore::HTMLMediaElement::attributeChanged): Ditto.
(WebCore::HTMLMediaElement::insertedIntoDocument): Update for scheduleLoad change.
(WebCore::HTMLMediaElement::scheduleLoad): Add a parameter so caller can specify if
    the main resource or a text track should be loaded.
(WebCore::HTMLMediaElement::loadTimerFired): Update to allow text track loading.
(WebCore::HTMLMediaElement::loadInternal): Don't call loadTextTracks.
(WebCore::HTMLMediaElement::isSafeToLoadURL): Log when CSP denies load.
(WebCore::HTMLMediaElement::playInternal): Update for scheduleLoad change.
(WebCore::HTMLMediaElement::pauseInternal): Ditto.
(WebCore::HTMLMediaElement::addTrack): Update for m_textTracks change from
    generic Vector to TextTrackList.
(WebCore::HTMLMediaElement::addTextTrack): New, add track to m_textTracks and configure.
(WebCore::HTMLMediaElement::configureTextTracks): New, add comments about what this should
    do eventually.
(WebCore::HTMLMediaElement::textTracks): New, return TextTrackList.
(WebCore::HTMLMediaElement::trackWasAdded): Bail if runtime feature is not enabled, schedule
    asynchronous text track load.
(WebCore::HTMLMediaElement::trackWillBeRemoved): Minor cleanup.
(WebCore::HTMLMediaElement::selectNextSourceChild): Ditto.
(WebCore::HTMLMediaElement::sourceWasAdded): Update for scheduleLoad change.
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl: Add textTracks attribute.

* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedIntoTree): Use new mediaElement() method.
(WebCore::HTMLTrackElement::willRemove): Ditto.
(WebCore::HTMLTrackElement::attributeChanged): When 'src' is changed, call scheduleLoad
    instead of HTMLMediaElement
(WebCore::HTMLTrackElement::isDefault): hasAttribute -> fastHasAttribute.
(WebCore::HTMLTrackElement::track): Allocate track if necessary.
(WebCore::HTMLTrackElement::scheduleLoad): New, tell the track to schedule a load.
(WebCore::HTMLTrackElement::canLoadUrl): New, check security policy to see if it is OK
    to load a text track. If so, dispatch 'beforeload' event to give it a chance to disallow
    load.
(WebCore::HTMLTrackElement::loadingCompleted): Renamed from textTrackLoadingCompleted.
(WebCore::HTMLTrackElement::textTrackReadyStateChanged): New, TextTrackLoadingClient interface
    used to inform parent of TextTrack state changes.
(WebCore::HTMLTrackElement::textTrackModeChanged): Ditto.
(WebCore::HTMLTrackElement::textTrackAddCues): Ditto.
(WebCore::HTMLTrackElement::textTrackRemoveCues): Ditto.
(WebCore::HTMLTrackElement::textTrackAddCue): Ditto.
(WebCore::HTMLTrackElement::textTrackRemoveCue): Ditto.
(WebCore::HTMLTrackElement::mediaElement): New, return parent element.
* html/HTMLTrackElement.h:

* html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::LoadableTextTrack): Initialize new instance variables.
(WebCore::LoadableTextTrack::scheduleLoad): New, prime a timer to kick off loading.
(WebCore::LoadableTextTrack::loadTimerFired): Cancel current load, if any, check to see if
    new url is allowed to load, and start new load.
(WebCore::LoadableTextTrack::cueLoadingCompleted):
* html/LoadableTextTrack.h:
(WebCore::LoadableTextTrackClient::~LoadableTextTrackClient): TextTrackLoadingClient -> LoadableTextTrackClient
(WebCore::LoadableTextTrackClient::canLoadUrl):
(WebCore::LoadableTextTrackClient::loadingCompleted):
(WebCore::LoadableTextTrack::create):

* html/TextTrack.cpp:
(WebCore::TextTrack::TextTrack): setClient(0) -> clearClient().
* html/TextTrack.h:
(WebCore::TextTrack::clearClient): Renamed from setClient, because it is only used to clear the client pointer.

* html/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::add): Get rid of a compiler warning that breaks the OS X build.

* html/track/TextTrackList.cpp: Added. Implement the TextTrackList object.
(TextTrackList::TextTrackList):
(TextTrackList::~TextTrackList):
(TextTrackList::length):
(TextTrackList::item):
(TextTrackList::append):
(TextTrackList::remove):
(TextTrackList::interfaceName):
(TextTrackList::scheduleAddTrackEvent):
(TextTrackList::asyncEventTimerFired):
* html/track/TextTrackList.h: Added.
(WebCore::TextTrackList::create):
(WebCore::TextTrackList::scriptExecutionContext):
(WebCore::TextTrackList::clearOwner):
(WebCore::TextTrackList::owner):
(WebCore::TextTrackList::refEventTarget):
(WebCore::TextTrackList::derefEventTarget):
(WebCore::TextTrackList::eventTargetData):
(WebCore::TextTrackList::ensureEventTargetData):
* html/track/TextTrackList.idl: Added.

* loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::cancelLoad): New, cancel pending or in progress load and delete loader.
(WebCore::TextTrackLoader::notifyFinished): Call cancelLoad.
(WebCore::TextTrackLoader::load): Ditto.
* loader/TextTrackLoader.h:
* page/DOMWindow.idl: Add TextTrackList.

LayoutTests:

* media/track/track-add-track-expected.txt: Added.
* media/track/track-add-track.html: Added.
* media/track/tracklist-is-reachable-expected.txt: Added.
* media/track/tracklist-is-reachable.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: reimplement DOM search using no XPath.
pfeldman@chromium.org [Fri, 11 Nov 2011 17:18:22 +0000 (17:18 +0000)]
Web Inspector: reimplement DOM search using no XPath.
https://bugs.webkit.org/show_bug.cgi?id=72125

Reviewed by Yury Semikhatsky.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::buildObjectForNode):
* inspector/InspectorDOMAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoProtect Document during error responses
gavinp@chromium.org [Fri, 11 Nov 2011 16:55:31 +0000 (16:55 +0000)]
Protect Document during error responses
https://bugs.webkit.org/show_bug.cgi?id=72068

Add a Document protector to the error response code handler, just
as exists for other ends of requests.

Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/misc/xslt-bad-import.html

* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::didReceiveData):

LayoutTests:

* http/tests/misc/resources/xslt-bad-import-uri.xml: Added.
* http/tests/misc/resources/xslt-bad-import-uri.xsl: Added.
* http/tests/misc/xslt-bad-import-expected.txt: Added.
* http/tests/misc/xslt-bad-import.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r99979.
gavinp@chromium.org [Fri, 11 Nov 2011 16:53:33 +0000 (16:53 +0000)]
Unreviewed, rolling out r99979.
http://trac.webkit.org/changeset/99979
https://bugs.webkit.org/show_bug.cgi?id=72136

bad commit message (Requested by gavinp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::didReceiveData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99981 268f45cc-cd09-0410-ab3c-d52691b4dbfc