15 years ago Add preprocessor define accidently dropped in my unification,
sfalken@apple.com [Thu, 17 Jan 2008 08:27:19 +0000 (08:27 +0000)]
    Add preprocessor define accidently dropped in my unification,
        and required by some builds.  Fixes an issue that caused both
        debug and release DLLs to be loaded.

        Rubber-stamped by Jon Honeycutt.

        * win/tools/vsprops/debug_internal.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
hyatt@apple.com [Thu, 17 Jan 2008 06:20:16 +0000 (06:20 +0000)]

        Fix for http://bugs.webkit.org/show_bug.cgi?id=16611

        Make sure vertical-align length values are offset from their parents rather than being absolute to the

        Reviewed by olliej

        Added fast/css/vertical-align-lengths.html

        * rendering/RenderObject.cpp:


       Fix for http://bugs.webkit.org/show_bug.cgi?id=16611

       Reviewed by olliej

        * ChangeLog:
        * fast/css/vertical-align-lengths.html: Added.
        * platform/mac/fast/css/vertical-align-lengths-expected.checksum: Added.
        * platform/mac/fast/css/vertical-align-lengths-expected.png: Added.
        * platform/mac/fast/css/vertical-align-lengths-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Thu, 17 Jan 2008 06:13:21 +0000 (06:13 +0000)]

        Reviewed by Dave Hyatt.

        - fix for @font-face rules with unicode-range: always use a local font where not
          explicitly overlaid.

        Test: fast/css/font-face-implicit-local-font.html

        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::addFontFaceRule): Changed to insert an implicit
        @font-face rule with the local font the matches the family and description before
        any explicit @font-face rules that overlay specific ranges of the same font.
        * css/CSSSegmentedFontFace.h:
        (WebCore::CSSSegmentedFontFace::numRanges): Addded.


        Reviewed by Dave Hyatt.

        - add test for @font-face rules with unicode-range: always use a local
          font where not explicitly overlaid.

        * fast/css/font-face-implicit-local-font.html: Added.
        * platform/mac-leopard/fast/css/font-face-implicit-local-font-expected.checksum: Added.
        * platform/mac-leopard/fast/css/font-face-implicit-local-font-expected.png: Added.
        * platform/mac/fast/css/font-face-implicit-local-font-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago <rdar://problem/5097419> Cursor flickers when over window resizer
sfalken@apple.com [Thu, 17 Jan 2008 02:53:13 +0000 (02:53 +0000)]
    <rdar://problem/5097419> Cursor flickers when over window resizer

        Reviewed by Sam.

        * WebView.cpp:
        (WebViewWndProc): Don't set the resize cursor when over the non-border resize area.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2008-01-16 Alp Toker <alp@atoker.com>
alp@webkit.org [Thu, 17 Jan 2008 02:27:31 +0000 (02:27 +0000)]
2008-01-16  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        [GTK] API: Should this entry point be called go_back rather than go_backward?

        Obsolete 'backward' terminology in API in favour of 'back'. Introduce
        step-based back/forward functions.

        Document more functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix Tiger build.
antti@apple.com [Thu, 17 Jan 2008 01:11:25 +0000 (01:11 +0000)]
    Fix Tiger build.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add tests for unsupported types to Windows skip list for now.
antti@apple.com [Thu, 17 Jan 2008 00:45:03 +0000 (00:45 +0000)]
    Add tests for unsupported types to Windows skip list for now.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
antti@apple.com [Thu, 17 Jan 2008 00:34:50 +0000 (00:34 +0000)]

        Reviewed by Adele.

        OS X fix for <rdar://problem/5605682>
        Disallow streaming protocols for media elements
        and <rdar://problem/5668711>
        Limit the container and codec types that the <video> tag supports

        - Disable unsupported QuickTime tracks types.
        - Disallow streaming protocols (for now).
        - Set QTMovie QTMoviePreventExternalURLLinksAttribute and QTSecurityPolicyNoCrossSiteAttribute
          to limit QuickTime's access to external resources.

        Windows patch coming up.

        Tests: media/broken-video.html

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:


        Reviewed by Adele.

        Tests for <rdar://problem/5605682>
        Disallow streaming protocols for media elements
        and <rdar://problem/5668711>
        Limit the container and codec types that the <video> tag supports

        - test that rtsp: protocol is disabled (for now).
        - test that QuickTime files with unsupported track types are handled correctly
        - test that broken video file produces an error

        * media/broken-video-expected.txt: Added.
        * media/broken-video.html: Added.
        * media/content/garbage.mp4: Added.
        * media/content/unsupported_track.mov: Added.
        * media/unsupported-rtsp-expected.txt: Added.
        * media/unsupported-rtsp.html: Added.
        * media/unsupported-tracks-expected.txt: Added.
        * media/unsupported-tracks.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2008-01-16 Rodney Dawes <dobey@wayofthemonkey.com>
alp@webkit.org [Thu, 17 Jan 2008 00:15:49 +0000 (00:15 +0000)]
2008-01-16  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Alp Toker.

        Add shared plugins directory to INCLUDE path

        Add the plugins directory to INCLUDEPATH

        * GNUmakefile.am:
        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Use recommended security-related compiler settings.
sfalken@apple.com [Wed, 16 Jan 2008 23:59:42 +0000 (23:59 +0000)]
    Use recommended security-related compiler settings.

        Reviewed by Adam.

        * win/tools/vsprops/common.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam Weinig.
ggaren@apple.com [Wed, 16 Jan 2008 23:54:28 +0000 (23:54 +0000)]
    Reviewed by Sam Weinig.

        Added a debug counter for SQL transactions. This helped me debug an SQL

        * bindings/js/JSCustomSQLTransactionCallback.cpp:
        * bindings/js/JSCustomSQLTransactionCallback.h:

        * bindings/js/kjs_window.cpp: Removed a silly comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam and Dan
sullivan@apple.com [Wed, 16 Jan 2008 23:36:44 +0000 (23:36 +0000)]
    Reviewed by Adam and Dan

        - cleaned up some existing logging

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView setNeedsDisplay:]):
        add method name to log, use "YES" and "NO" instead of (int)flag
        (-[WebHTMLView setNeedsLayout:]):
        (-[WebHTMLView setNeedsToApplyStyles:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
mjs@apple.com [Wed, 16 Jan 2008 23:16:53 +0000 (23:16 +0000)]

        Reviewed by Maciej & Darin.

        Fixes Bug 16868: Gmail crash
          and Bug 16871: Crash when loading apple.com/startpage



        Adds ActivationImp tear-off for cross-window eval() and fixes an
        existing garbage collection issue exposed by the ActivationImp tear-off
        patch (r29425) that can occur when an ExecState's m_callingExec is
        different than its m_savedExec.

        * kjs/ExecState.cpp:
        * kjs/function.cpp:


        Reviewed by Maciej.

        Added a test that checks whether ActivationImp tear-off occurs before
        a cross-window eval(). Relevant to

        Bug 16868: Gmail crash


        * fast/js/window-eval-tearoff-expected.txt: Added.
        * fast/js/window-eval-tearoff.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
weinig@apple.com [Wed, 16 Jan 2008 22:31:17 +0000 (22:31 +0000)]
    Reviewed by Oliver.

        Clean up MathObjectImp, it needed a little scrubbing.

        * kjs/math_object.cpp:
        * kjs/math_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Update layout tests after fix for <rdar://problem/5681647>.
hyatt@apple.com [Wed, 16 Jan 2008 22:13:24 +0000 (22:13 +0000)]
    Update layout tests after fix for <rdar://problem/5681647>.

        * platform/mac/tables/mozilla/bugs/bug101674-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug2973-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug57828-2-expected.txt:
        * platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
hyatt@apple.com [Wed, 16 Jan 2008 21:56:43 +0000 (21:56 +0000)]

        Fix for http://bugs.webkit.org/show_bug.cgi?id=14846, cell padding can't be changed dynamically.

        Reviewed by Eric Seidel

        Added fast/table/dynamic-cellpadding.html

        * html/HTMLTableElement.cpp:
        * rendering/RenderTable.cpp:
        * rendering/RenderTable.h:


        Reviewed by Eric Seidel


        * fast/table/dynamic-cellpadding.html: Added.
        * platform/mac/fast/table/dynamic-cellpadding-expected.checksum: Added.
        * platform/mac/fast/table/dynamic-cellpadding-expected.png: Added.
        * platform/mac/fast/table/dynamic-cellpadding-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoffrey Garen.
weinig@apple.com [Wed, 16 Jan 2008 21:53:11 +0000 (21:53 +0000)]
    Reviewed by Geoffrey Garen.

        Rename Lexer variable bol to atLineStart.

        * kjs/lexer.cpp:
        * kjs/lexer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoffrey Garen and Anders Carlsson.
weinig@apple.com [Wed, 16 Jan 2008 21:50:19 +0000 (21:50 +0000)]
    Reviewed by Geoffrey Garen and Anders Carlsson.

        Remove uses of KJS_PURE_ECMA as we don't ever build with it defined,
        and we have many features that are not included in the ECMA spec.

        * kjs/lexer.cpp:
        * kjs/lexer.h:
        * kjs/string_object.cpp:
        * kjs/string_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for <rdar://problem/5681647> Item pages on http://www.stendmarsofa.com...
hyatt@apple.com [Wed, 16 Jan 2008 21:27:30 +0000 (21:27 +0000)]
    Fix for <rdar://problem/5681647> Item pages on stendmarsofa.com/ hang Safari

        This regression was caused by an attempt to implement a WinIE quirk in RenderBlock::calcInlinePrefWidths.
        The original patch introduced pathological O(n^2) behavior into this function even when the quirk didn't need
        to apply.  In addition the quirk was only partially implemented (the full quirk did not care what was adjacent
        to images and also needed bidi.cpp patched, since the quirk applies both when computing pref widths and when
        laying out).

        This new patch rewrites the quirk to be complete.  The original test case attached to the bug that tested a variety
        of image/text combinations now fully matches WinIE.

        Reviewed by Beth

        Added fast/table/unbreakable-images-quirk.html

        * rendering/RenderBlock.cpp:
        * rendering/bidi.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoI don't know what happened here. It did not commit with my checkin.
hyatt@apple.com [Wed, 16 Jan 2008 21:24:21 +0000 (21:24 +0000)]
I don't know what happened here. It did not commit with my checkin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Windows build fix after r29488
aroben@apple.com [Wed, 16 Jan 2008 21:22:46 +0000 (21:22 +0000)]
    Windows build fix after r29488

        * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
        Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
        expects to find the plugin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Beth.
hyatt@apple.com [Wed, 16 Jan 2008 21:20:53 +0000 (21:20 +0000)]
    Reviewed by Beth.

        <rdar://problem/5681647> Item pages on http://www.stendmarsofa.com/ hang Safari

        * fast/table/unbreakable-images-quirk.html: Added.
        * platform/mac/fast/table/unbreakable-images-quirk-expected.checksum: Added.
        * platform/mac/fast/table/unbreakable-images-quirk-expected.png: Added.
        * platform/mac/fast/table/unbreakable-images-quirk-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2008-01-16 Rodney Dawes <dobey@wayofthemonkey.com>
jhoneycutt@apple.com [Wed, 16 Jan 2008 21:13:56 +0000 (21:13 +0000)]
2008-01-16  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Jon Honeycutt

        Move isPluginBlacklisted to PluginPackageWin.cpp, to avoid
        a circular dependency on PluginDatabaseWin
        Remove the getFileVersion method, and just check the versions directly
        in isPluginBlacklisted, as it was the only caller


        * plugins/win/PluginDatabaseWin.cpp:
        * plugins/win/PluginDatabaseWin.h:
        * plugins/win/PluginPackageWin.cpp:
        * plugins/win/PluginPackageWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
mitz@apple.com [Wed, 16 Jan 2008 17:14:44 +0000 (17:14 +0000)]
    Reviewed by Adam Roben.

        - copied Windows expected results for
          svg/hixie/viewbox/preserveAspectRatio/001.xml from Tiger

        * platform/win/svg: Added.
        * platform/win/svg/hixie: Added.
        * platform/win/svg/hixie/viewbox: Added.
        * platform/win/svg/hixie/viewbox/preserveAspectRatio: Added.
        * platform/win/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Copied from LayoutTests/platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agohttp://bugs.webkit.org/show_bug.cgi?id=16732
alp@webkit.org [Wed, 16 Jan 2008 12:07:47 +0000 (12:07 +0000)]
Update svn:ignore properties for autotools build

Reviewed by Alp Toker.

Ignore files placed in the source tree by the autotools build (these
files are generated even during an out-of-tree build).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemoved a whole bunch of notImplemented() warnings.
hausmann@webkit.org [Wed, 16 Jan 2008 10:34:23 +0000 (10:34 +0000)]
Removed a whole bunch of notImplemented() warnings.

I don't want to hide the real warnings in lots of things that
I am by now pretty certain we won't need.

Signed-off-by: Simon Hausmann <simon.hausmann@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Set the cursor on the containingWindow() instead of the
hausmann@webkit.org [Wed, 16 Jan 2008 10:18:45 +0000 (10:18 +0000)]
* Set the cursor on the containingWindow() instead of the
* This should be safe even with plugins as the cursor is set
  on the mouse events.

Signed-Off-By: Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix crash when bringing up the context menu on maps.google.com.
hausmann@webkit.org [Wed, 16 Jan 2008 10:18:31 +0000 (10:18 +0000)]
Fix crash when bringing up the context menu on maps.google.com.

If the website provides its own context menu then we don't have a ContextMenu pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoDon't crash when receiving all sorts of events on a default constructed QWebView...
hausmann@webkit.org [Wed, 16 Jan 2008 10:18:18 +0000 (10:18 +0000)]
Don't crash when receiving all sorts of events on a default constructed QWebView without a page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoImprove the sqlite3 dependency when building WebKit inside Qt.
hausmann@webkit.org [Wed, 16 Jan 2008 10:18:04 +0000 (10:18 +0000)]
Improve the sqlite3 dependency when building WebKit inside Qt.

Build sqlite3 into QtWebKit if a system sqlite3 development package
can't be found.

Signed-off-by: Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoImplement GraphicsContext::clipOut and fix transparency layers.
hausmann@webkit.org [Wed, 16 Jan 2008 10:17:51 +0000 (10:17 +0000)]
Implement GraphicsContext::clipOut and fix transparency layers.

Transparency layers where broken in two ways: It always used the
complete device rect as the size of the layer pixmap and the pixmaps
where not correctly initialized to transparent.

This fixes the worst drawing errors in the Inspector and makes drawing it
10 times faster.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMade the url property read-write.
hausmann@webkit.org [Wed, 16 Jan 2008 10:17:35 +0000 (10:17 +0000)]
Made the url property read-write.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoDon't crash when showing a default initialized QWebView that has no page/frame yet.
hausmann@webkit.org [Wed, 16 Jan 2008 10:17:22 +0000 (10:17 +0000)]
Don't crash when showing a default initialized QWebView that has no page/frame yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoTrivially implement the themed search field by mapping it to a text field
hausmann@webkit.org [Wed, 16 Jan 2008 10:17:07 +0000 (10:17 +0000)]
Trivially implement the themed search field by mapping it to a text field

Also add a bunch of notImplemented warnings for other places where we don't
have an implementatin in RenderTheme.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoChange hoveringOverLink implementation to have less issues.
hausmann@webkit.org [Wed, 16 Jan 2008 09:56:20 +0000 (09:56 +0000)]
Change hoveringOverLink implementation to have less issues.

* Currently we only compare a pointer. In the worst case we
  could delete the Element we have pointed to and a new one
  gets the same address. But even if that doesn't happen the
  WebCore::Element is mutable and JavaScript could change the
  URL, Title or Content. So we have to compare all these three
* This does not seem to be a performance impact.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Follow the EventHandlerWin.cpp and always return true in the handlers.
hausmann@webkit.org [Wed, 16 Jan 2008 09:55:50 +0000 (09:55 +0000)]
* Follow the EventHandlerWin.cpp and always return true in the handlers.
* Match the windows implementation more closely as well.
* This is fixing "selection" bugs with the Web Inspector

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Move the hoverElement from QWebFrame to QWebPage. As it is
hausmann@webkit.org [Wed, 16 Jan 2008 09:55:21 +0000 (09:55 +0000)]
* Move the hoverElement from QWebFrame to QWebPage. As it is
  only used there.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoEventHandler changes/fixes in QWebPage:
hausmann@webkit.org [Wed, 16 Jan 2008 09:54:32 +0000 (09:54 +0000)]
EventHandler changes/fixes in QWebPage:
        Send the event always to the mainFrame of the QWebPage.

    -contextMenuEvent, key{Press,Release}Event:
        Send the event to the focused frame.

This is following the Windows port and fixes a issue with the
Web Inspector where we were sending the events to a wrong frame.

It is guaranteed that the mainFrame will always have an eventHandler
and frameView set. There is no need to check for this in QWebPage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Add core and kit functions to QWebFramePrivate to convert from
hausmann@webkit.org [Wed, 16 Jan 2008 09:52:41 +0000 (09:52 +0000)]
* Add core and kit functions to QWebFramePrivate to convert from
  QWebFrame to WebCore::Frame and vice versa.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix crashes in the new networking code.
hausmann@webkit.org [Wed, 16 Jan 2008 09:38:40 +0000 (09:38 +0000)]
Fix crashes in the new networking code.

When the ResourceLoader cancels the handle we have to make sure not to access
the resource handle afterwards again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoadd conversion methods from and to QUrl to KURL.
hausmann@webkit.org [Wed, 16 Jan 2008 09:38:23 +0000 (09:38 +0000)]
add conversion methods from and to QUrl to KURL.

Use them in the places I found at the moment. Fixes a bug
where form data was encoded twice.
Also fix QWebSettings to take a QUrl for the user style sheet

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Make the InspectorClientView inherit from QWebView instead of QWidget. This
hausmann@webkit.org [Wed, 16 Jan 2008 09:37:48 +0000 (09:37 +0000)]
* Make the InspectorClientView inherit from QWebView instead of QWidget. This
  way paintEvent, mouse{Press,Release}Event and other events get forwarded to
  the QWebPage/WebInspector automatically.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix.
sfalken@apple.com [Wed, 16 Jan 2008 08:18:24 +0000 (08:18 +0000)]
    Build fix.

        * win/tools/vsprops/release.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber-stamped by Maciej Stachowiak and Oliver Hunt.
darin@apple.com [Wed, 16 Jan 2008 08:02:07 +0000 (08:02 +0000)]
    Rubber-stamped by Maciej Stachowiak and Oliver Hunt.

        - fix <rdar://problem/5689748> REGRESSION: Cannot redirect to protocols handled by external applications

        Put navigation policy delegate calls back for redirects.
        Just rolled out the change where I took them out.

        * loader/MainResourceLoader.cpp:
        * loader/MainResourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam.
adele@apple.com [Wed, 16 Jan 2008 06:54:48 +0000 (06:54 +0000)]
    Reviewed by Sam.

        Remove unused variable for old media control background drawing code.

        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix typos in ChangeLog
weinig@apple.com [Wed, 16 Jan 2008 06:46:46 +0000 (06:46 +0000)]
Fix typos in ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
weinig@apple.com [Wed, 16 Jan 2008 06:43:15 +0000 (06:43 +0000)]

        Reviewed by Geoffrey Garen.

        Fix <rdar://problem/5595552> r27608 introduced a 20% increase in JS binary size, 4% increase in WebCore binary size

        - This changes the way JS functions that use Lookup tables are handled.  Instead using
          one class per function, which allowed specialization of the virtual callAsFunction
          method, we now use on class, PrototypeFunction, which takes a pointer to a static
          function to use as the implementation.  This significantly decreases the binary size
          of JavaScriptCore (about 145k on an Intel only build) while still keeping some of the
          speedup r27608 garnered (SunSpider says this is 1.005x as slow, which should leave some
          wiggle room from the original 1% speedup) and keeps the functions implementations in separate
          functions to help with optimizations.

        * JavaScriptCore.exp:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/array_object.cpp:
        * kjs/array_object.h:
        * kjs/date_object.cpp:
        * kjs/date_object.h:
        * kjs/function.cpp:
        * kjs/function.h:
        * kjs/lookup.h:
        * kjs/math_object.cpp:
        * kjs/math_object.h:
        * kjs/string_object.cpp:
        * kjs/string_object.h:


        Reviewed by Geoffrey Garen.

        Fix <rdar://problem/5595552> r27608 introduced a 20% increase in JS binary size, 4% increase in WebCore binary size

        - Update JS Function implementations to use a static function based method. This decreases
          the binary size of an Intel only build by 1013.5K.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMWindowCustom.cpp:
        * bindings/js/JSEventTargetBase.cpp:
        * bindings/js/JSEventTargetBase.h:
        * bindings/js/JSHTMLInputElementBase.cpp:
        * bindings/js/JSHTMLInputElementBase.h:
        * bindings/js/JSLocation.cpp:
        * bindings/js/JSLocation.h:
        * bindings/js/JSXMLHttpRequest.cpp:
        * bindings/js/JSXMLHttpRequest.h:
        * bindings/js/JSXSLTProcessor.cpp:
        * bindings/js/JSXSLTProcessor.h:
        * bindings/js/kjs_events.cpp:
        * bindings/js/kjs_events.h:
        * bindings/js/kjs_navigator.cpp:
        * bindings/js/kjs_navigator.h:
        * bindings/js/kjs_window.cpp:
        * bindings/js/kjs_window.h:
        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Dan.
adele@apple.com [Wed, 16 Jan 2008 06:30:49 +0000 (06:30 +0000)]
    Reviewed by Dan.

        Fix for <rdar://problem/5682492> With the <video> element, the audio is heard when forwarding or rewinding a movie while it's playing

        * rendering/MediaControlElements.cpp: (WebCore::MediaControlSeekButtonElement::defaultEventHandler):
          Instead of pausing the media when you stop seeking on mouse up, pause the video when you first start seeking on mouse down.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
ggaren@apple.com [Wed, 16 Jan 2008 05:23:06 +0000 (05:23 +0000)]
    Reviewed by Adam Roben.

        Some tweaks to our headerdoc, suggested by David Gatwood on the docs

        * API/JSBase.h:
        * API/JSObjectRef.h:
        * API/JSStringRef.h:
        * API/JSValueRef.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago.:
alp@webkit.org [Wed, 16 Jan 2008 03:32:29 +0000 (03:32 +0000)]

        Rubber-stamped by Anders.

        Make the HTTP backend configurable in the GTK+ port. curl is currently
        the only option.

        * GNUmakefile.am:
        * WebKit.pri:
        * configure.ac:


        Rubber-stamped by Anders.

        Make the HTTP backend configurable in the GTK+ port. curl is currently
        the only option.

        * wtf/Platform.h: Don't hard-code WTF_USE_CURL for GTK


        Rubber-stamped by Anders.

        Make the HTTP backend configurable in the GTK+ port. curl is currently
        the only option.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix.
adele@apple.com [Wed, 16 Jan 2008 01:53:31 +0000 (01:53 +0000)]
    Build fix.

        * rendering/RenderThemeSafari.cpp: Removing MediaBackgroundAppearance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Beth Dakin.
weinig@apple.com [Wed, 16 Jan 2008 01:22:25 +0000 (01:22 +0000)]
    Reviewed by Beth Dakin.

        Remove unneeded variable.

        * kjs/string_object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
weinig@apple.com [Wed, 16 Jan 2008 01:16:10 +0000 (01:16 +0000)]
    Reviewed by Darin.

        Fix for <rdar://problem/5671040>
        REGRESSION: 6% HTML iBench regression from r28722 (getElementsByClassName)

        On my most consistent tests, this brings the HTML iBench from 1.46 -> 1.41,
        which does not completely make up reported regression, but I was not able to
        reproduce those findings either.

        * css/CSSStyleSelector.cpp:
        * dom/ClassNames.cpp:
        * dom/ClassNames.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix. This time for real.
adele@apple.com [Wed, 16 Jan 2008 01:12:44 +0000 (01:12 +0000)]
    Build fix.  This time for real.

        * rendering/RenderThemeSafari.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - updated Tiger results for <rdar://problem/5666926>
mitz@apple.com [Wed, 16 Jan 2008 00:53:13 +0000 (00:53 +0000)]
    - updated Tiger results for <rdar://problem/5666926>

        * platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix.
adele@apple.com [Wed, 16 Jan 2008 00:46:09 +0000 (00:46 +0000)]
    Build fix.

        * rendering/RenderThemeSafari.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago <rdar://problem/5663888> Cannot type into a JavaScript prompt created from...
sfalken@apple.com [Wed, 16 Jan 2008 00:43:37 +0000 (00:43 +0000)]
    <rdar://problem/5663888> Cannot type into a JavaScript prompt created from a timer

        Allow nested timers from javascript prompts to allow for WebView-based edit fields.

        Reviewed by Darin.

        * WebChromeClient.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Wed, 16 Jan 2008 00:37:02 +0000 (00:37 +0000)]

        Reviewed by Darin Adler.

        - fix <rdar://problem/5666926> svg/custom/use-css-no-effect-on-shadow-tree.svg is failing

        * svg/SVGPreserveAspectRatio.cpp:
        (WebCore::SVGPreserveAspectRatio::getCTM): Changed the arguments' type
        from float to double in order to make the values passed to scale() and
        translate() on Mac OS X and on Windows the same.
        * svg/SVGPreserveAspectRatio.h:


        Reviewed by Darin Adler.

        - updated results for <rdar://problem/5666926> svg/custom/use-css-no-effect-on-shadow-tree.svg is failing

        * platform/mac-leopard/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
        * platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt:
        * platform/mac/svg/hixie/links/001-expected.txt:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Andre Boule.
ggaren@apple.com [Tue, 15 Jan 2008 22:50:21 +0000 (22:50 +0000)]
    Reviewed by Andre Boule.

        Fixed <rdar://problem/5667627> [WebCache empty] implementation should
        not disable/enable the cache

        Toggle the cache model instead -- toggling disable/enable just causes
        the cache to forget about resources, not reclaim their memory.

        * Misc/WebCache.mm:
        (+[WebCache empty]):
        * WebView/WebView.mm:
        * WebView/WebViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam Weinig.
ggaren@apple.com [Tue, 15 Jan 2008 22:14:27 +0000 (22:14 +0000)]
    Reviewed by Sam Weinig.

        Fixed the waitUntilDone watchdog timer -- the old code never added the
        timer to the run loop, so it didn't do anything.

        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2008-01-15 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 15 Jan 2008 21:47:25 +0000 (21:47 +0000)]
2008-01-15  Alp Toker  <alp@atoker.com>

        GTK+/autotools build fix for GCC < 4. Use the -fvisibility compiler
        flags only when they're available.

        Additionally, use -fvisibility-inlines-hidden in both debug and
        release builds when available to match the Mac build.

        * GNUmakefile.am:
        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap@webkit.org [Tue, 15 Jan 2008 21:10:23 +0000 (21:10 +0000)]
    Reviewed by Darin.

        <rdar://problem/5342813> REGRESSION: Safari encodes mailto URLs incorrectly

        Test: fast/encoding/mailto-always-utf-8.html

        * platform/KURL.cpp: (WebCore::encodeRelativeString): Always use UTF-8 for mailto URLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
adele@apple.com [Tue, 15 Jan 2008 20:37:25 +0000 (20:37 +0000)]

        Reviewed by Adam and Antti.

        WebCore part of fix for <rdar://problem/5619062> Add load progress indicator to video controls

        * WebCore.base.exp: Removed symbol for wkGetMediaControlBackgroundImageData.  Added symbol for wkDrawMediaSliderTrack.
        * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Removed case for MediaBackgroundAppearance.
        * css/html4.css: Removed -webkit-appearance: media-background rule for the media panel element.  Removed unnecessary margin for slider.
        * rendering/RenderStyle.h: (WebCore::): Removed MediaBackgroundAppearance.

        * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::initAndDispatchProgressEvent):
          Call updateMediaPlayer more frequently so the load progress control gets updated appropriately.
        * platform/mac/WebCoreSystemInterface.h: Removed wkGetMediaControlBackgroundImageData.  Added wkDrawMediaSliderTrack.
        * platform/mac/WebCoreSystemInterface.mm: ditto.

        * rendering/RenderTheme.h: Removed paintMediaBackground. Added paintMediaSliderTrack.
        * rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): Call paintMediaSliderTrack for elements with MediaSliderAppearance.
        * rendering/RenderThemeMac.h: Removed paintMediaBackground. Added paintMediaSliderTrack.
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::adjustSliderThumbSize): Added different sizes for the media slider thumb.
        (WebCore::RenderThemeMac::paintMediaSliderTrack): Added.  Calls wkDrawMediaSliderTrack with the percentage the media has loaded.
        * rendering/RenderThemeSafari.cpp: ditto.
        * rendering/RenderThemeSafari.h:


        Reviewed by Adam and Antti.

        WebKit part of fix for <rdar://problem/5619062> Add load progress indicator to video controls

        * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
          Removed initialization for GetMediaControlBackgroundImageData.  Added initialization for DrawMediaSliderTrack.


        Reviewed by Adam and Antti.

        Updated libraries for <rdar://problem/5619062> Add load progress indicator to video controls

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:
        * win/include/SafariTheme: Added.
        * win/include/SafariTheme/SafariThemeConstants.h: Added. Placeholder empty header until we release an updated WebKitSupportLibrary.


        Reviewed by Adam and Antti.

        Updated tests for <rdar://problem/5619062> Add load progress indicator to video controls

        * platform/mac/media/audio-controls-rendering-expected.checksum:
        * platform/mac/media/audio-controls-rendering-expected.png:
        * platform/mac/media/audio-controls-rendering-expected.txt:
        * platform/mac/media/video-controls-rendering-expected.checksum:
        * platform/mac/media/video-controls-rendering-expected.png:
        * platform/mac/media/video-controls-rendering-expected.txt:
        * platform/mac/media/video-display-toggle-expected.checksum:
        * platform/mac/media/video-display-toggle-expected.png:
        * platform/mac/media/video-display-toggle-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoVersioning.
mrowe@apple.com [Tue, 15 Jan 2008 19:06:57 +0000 (19:06 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark Rowe.
ap@webkit.org [Tue, 15 Jan 2008 09:27:06 +0000 (09:27 +0000)]
    Reviewed by Mark Rowe.

        Some logging channels weren't initialized from user defaults.

        * platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):
        Initialize LogPlatformLeaks, LogStorageAPI, LogMedia, LogPlugin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
sfalken@apple.com [Tue, 15 Jan 2008 08:50:24 +0000 (08:50 +0000)]

        Use shared vsprops for most vcproj properties.

        Reviewed by Darin.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add missing Debug_Internal config.
        * JavaScriptCore.vcproj/WTF/WTF.vcproj: Add missing Debug_Internal config.
        * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:


        Use shared vsprops for most vcproj properties.

        Reviewed by Darin.

        * WebCore.vcproj/QTMovieWin.vcproj:
        * WebCore.vcproj/WebCore.vcproj:
        * platform/graphics/win/QTMovieWin.cpp:
        (QTMovieWin::initializeQuickTime): Fix compiler warning.


        Use shared vsprops for most vcproj properties.

        Reviewed by Darin.

        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/WebKit.vcproj:
        * WebKit.vcproj/WebKitGUID.vcproj: Add missing Debug_Internal config.


        Use shared vsprops for most vcproj properties.

        Reviewed by Darin.

        * win/tools/vsprops/common.vsprops:
        * win/tools/vsprops/debug.vsprops:
        * win/tools/vsprops/debug_internal.vsprops:
        * win/tools/vsprops/release.vsprops:


        Use shared vsprops for most vcproj properties.

        Reviewed by Darin.

        * Drosera/win/Drosera.vcproj/Drosera.vcproj:
        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/ImageDiff.vcproj:
        * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
        * FindSafari/FindSafari.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by mjs.
eric@webkit.org [Tue, 15 Jan 2008 05:43:16 +0000 (05:43 +0000)]
    Reviewed by mjs.

Remove a couple more uses of DeprecatedString

        No functional changes, thus no test case.

        * dom/Document.cpp:
        * dom/Document.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2008-01-14 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>
alp@webkit.org [Tue, 15 Jan 2008 05:41:22 +0000 (05:41 +0000)]
2008-01-14  Pierre-Luc Beaudoin  <pierre-luc.beaudoin@collabora.co.uk>

        Reviewed by Alp Toker.

        Build fix: missing symbols when compiling WebKit/Gtk+ with --enable-svg-filters

        * GNUmakefile.am:
        * svg/graphics/cairo/SVGResourceFilterCairo.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2008-01-14 Stephanie <slewis@apple.com>
slewis@apple.com [Tue, 15 Jan 2008 03:59:03 +0000 (03:59 +0000)]
2008-01-14  Stephanie  <slewis@apple.com>

       revert accidental character.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2008-01-14 Stephanie <slewis@apple.com>
slewis@apple.com [Tue, 15 Jan 2008 03:52:52 +0000 (03:52 +0000)]
2008-01-14  Stephanie  <slewis@apple.com>


add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>

        * Scripts/run-webkit-tests:
add svg/css/glyph-orientation-rounding-test.xhtml to skip list. See <rdar://problem/5686552>

        * platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by hyatt & eseidel.
eric@webkit.org [Tue, 15 Jan 2008 01:31:19 +0000 (01:31 +0000)]
    Reviewed by hyatt & eseidel.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16844
        RenderText::addLineBoxRects erroneously includes last char for boundingBox

        This patch fixes an issue with addLineBoxRects not correctly calculating the
        rects due to an off-by-one error in using box->end(). We were assuming that
        end() gives the index past the last character, when in fact it gives the
        index _of_ the last character.

        Eric Seidel and I could not find a way to test this via DRT. This method is
        only used by WebKit or Safari for displaying selection rects AFAICT.

        * rendering/RenderText.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
darin@apple.com [Tue, 15 Jan 2008 01:03:11 +0000 (01:03 +0000)]
    Reviewed by Geoff.

        - fix crash seen in layout tests

        * html/HTMLFrameSetElement.cpp:
        Remove incorrect cast to HTMLElement* for parentNode(). The parent is either an
        HTMLElement or a Document, not necessarily an HTMLElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam.
darin@apple.com [Mon, 14 Jan 2008 22:51:59 +0000 (22:51 +0000)]
    Reviewed by Sam.

        - fix mistakes Sam noticed in my re-speed-up patch

        * dom/Element.cpp:
        (WebCore::Element::virtualHasTagName): Moved out of header file. No reason to make
        this inline.
        * dom/Element.h: Moved virtualHasTagName out of header file.

        * dom/Node.cpp:
        (WebCore::Node::virtualHasTagName): Moved out of header file. No reason to make
        this inline.
        * dom/Node.h: Removed incorrect "virtual" on hasTagName and moved virtualHasTagName
        out of header file.

        * platform/text/StringBuffer.h: Added. Has just the new StringBuffer class.

        * platform/text/StringImpl.h: Removed StringBuffer class.

        * loader/DocumentLoader.cpp: Added StringBuffer.h include.
        * platform/text/String.cpp: Ditto.
        * platform/text/StringImpl.cpp: Ditto.
        * platform/text/TextCodecLatin1.cpp: Ditto.
        * platform/text/TextCodecUTF16.cpp: Ditto.
        * platform/text/TextCodecUserDefined.cpp: Ditto.

        * WebCore.vcproj/WebCore.vcproj: Added StringBuffer.h.
        * WebCore.xcodeproj/project.pbxproj: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * Scripts/do-webcore-rename: Queue up another rename.
darin@apple.com [Mon, 14 Jan 2008 22:35:00 +0000 (22:35 +0000)]
    * Scripts/do-webcore-rename: Queue up another rename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoClean up VS project file after graphics files moved.
hyatt@apple.com [Mon, 14 Jan 2008 21:05:36 +0000 (21:05 +0000)]
Clean up VS project file after graphics files moved.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam Weinig.
ggaren@apple.com [Mon, 14 Jan 2008 20:13:28 +0000 (20:13 +0000)]
    Reviewed by Sam Weinig.

        Some cleanup to my last patch.

        Removed one unused setter declaration and one unused setter definition.

        Renamed DoNotCheckDomainSecurityOnRead to DoNotCheckDomainSecurityOnGet
        because "get" is all over the IDL files, and "read" is not.

        * bindings/scripts/CodeGeneratorJS.pm:
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber-stamped by Alice Liu.
mitz@apple.com [Mon, 14 Jan 2008 19:26:56 +0000 (19:26 +0000)]
    Rubber-stamped by Alice Liu.

        - remove reference to nonexistent file

        * WebCore.vcproj/WebCore.vcproj: Removed reference to SVGFont.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix date; restore '<'.
ddkilzer@apple.com [Mon, 14 Jan 2008 19:25:24 +0000 (19:25 +0000)]
Fix date; restore '<'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added
aroben@apple.com [Mon, 14 Jan 2008 19:11:50 +0000 (19:11 +0000)]
    * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added
        some headers that were missing from the vcproj so their contents will
        be included in Find in Files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix Bug 16871: Crash when loading apple.com/startpage
aroben@apple.com [Mon, 14 Jan 2008 19:02:46 +0000 (19:02 +0000)]
    Fix Bug 16871: Crash when loading apple.com/startpage


        Patch written by Darin, reviewed by me.

        * kjs/ExecState.cpp:
        (KJS::ExecState::mark): Call ActivationImp::markChildren if our
        m_activation is on the stack. This is what ScopeChain::mark also does,
        but apparently in some cases it's possible for an ExecState's
        ActivationImp to not be in any ScopeChain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Allow to run the tests in reverse order to spot test cases where the result depends...
zecke@webkit.org [Mon, 14 Jan 2008 18:38:02 +0000 (18:38 +0000)]
* Allow to run the tests in reverse order to spot test cases where the result depends on the order
  the tests were ran.
* This is from http://bugs.webkit.org/show_bug.cgi?id=16869

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
kmccullough@apple.com [Mon, 14 Jan 2008 18:28:43 +0000 (18:28 +0000)]

        Reviewed by Oliver.

        -<rdar://problem/5622667> REGRESSION (Leopard-ToT): Endless loading loop
        trying to view techreport.com comments
        - We need to set values in the map, because if they are already in the
        map they will not be reset when we use add().

        * kjs/array_instance.cpp:


        Reviewed by Oliver.

        - <rdar://problem/5622667> REGRESSION (Leopard-ToT): Endless loading
        loop trying to view techreport.com comments
        - Any resetting of a value in an array of sufficient size, would cause
        the second value to be lost.

        * fast/js/array-reset-large-index-expected.txt: Added.
        * fast/js/array-reset-large-index.html: Added.
        * fast/js/resources/array-reset-large-index.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Randomize tests array to spot test cases where the results depends on the order
zecke@webkit.org [Mon, 14 Jan 2008 18:24:08 +0000 (18:24 +0000)]
* Randomize tests array to spot test cases where the results depends on the order
  the tests are ran.
* This is from http://bugs.webkit.org/show_bug.cgi?id=16869

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
darin@apple.com [Mon, 14 Jan 2008 17:51:10 +0000 (17:51 +0000)]

        Reviewed by Adam.

        - re-speed-up the page load test (my StringImpl change slowed it down)

        * wtf/RefCounted.h:
        (WTF::RefCounted::RefCounted): Allow derived classes to start with a reference
        count other than 0. Eventually everyone will want to start with a 1. This is a
        staged change. For now, there's a default of 0, and you can specify 1. Later,
        there will be no default and everyone will have to specify. And then later, there
        will be a default of 1. Eventually, we can take away even the option of starting
        with 0!

        * wtf/Vector.h:
        (WTF::Vector::Vector): Sped up creation of non-empty vectors by removing the
        overhead of first constructing something empty and then calling resize.
        (WTF::Vector::clear): Sped up the common case of calling clear on an empty
        vector by adding a check for that case.
        (WTF::Vector::releaseBuffer): Marked this function inline and removed a branch
        in the case of vectors with no inline capacity (normal vectors) by leaving out
        the code to copy the inline buffer in that case.


        Reviewed by Adam.

        - re-speed-up the page load test (my StringImpl change slowed it down)
          <rdar://problem/5677241> 1.5% PLT regression from r29098

        To reverse the slowdown I caused by changing StringImpl, I tightened it up,
        and also did a little optimization in the HTML tokenizer and in other clients
        of Vector.

        * WebCore.base.exp: Removed export of a now-inline function.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseTransitionProperty): Removed use of DeprecatedString
        to get property ID. This could be sped up even more by writing a fast path
        to use a local Vector<char> rather than allocating a string.
        (WebCore::convertASCIIToFloat): Added. Allows numeric conversion without
        allocating a string object to hold the number.
        (WebCore::CSSParser::lex): Changed to call convertASCIIToFloat instead of

        * dom/Element.h:
        (WebCore::Element::hasTagName): Made this non-virtual and inline if you have
        an Element*. It's still virtual if you have a Node*.
        (WebCore::Element::virtualHasTagName): Virtual version that makes the Node*
        case work.

        * dom/Node.h:
        (WebCore::Node::hasTagName): Made this non-virtual and inline so that Element
        can override it with an inline. This is the same technique we use for
        firstChild and lastChild.
        (WebCore::Node::virtualHasTagName): This is the private virtual that Element

        * dom/Text.cpp:
        (WebCore::Text::splitText): Clean up by using a RefPtr here instead of a

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseSpecial): Use the new advancePastNonNewline(),
        which is more efficient in cases where we know the character is not a newline
        and hence we don't have to update the line number.
        (WebCore::HTMLTokenizer::parseComment): Ditto.
        (WebCore::HTMLTokenizer::parseServer): Ditto.
        (WebCore::HTMLTokenizer::parseProcessingInstruction): Ditto.
        (WebCore::HTMLTokenizer::parseText): Ditto.
        (WebCore::HTMLTokenizer::parseEntity): Ditto.
        (WebCore::HTMLTokenizer::parseTag): Ditto. Also streamline the QuotedValue case
        so there's one less branch taken for non-punctuation characters since this
        code path is *so* hot.
        (WebCore::HTMLTokenizer::write): More of the same.

        * loader/Cache.cpp:
        (WebCore::Cache::lruListFor): Use Vector::grow instead of resize.

        * loader/DocumentLoader.cpp:
        (WebCore::canonicalizedTitle): Use StringBuffer instead of Vector<UChar>.

        * loader/TextResourceDecoder.cpp:
        (WebCore::TextResourceDecoder::checkForCSSCharset): Use Vector::grow instead of resize.
        (WebCore::TextResourceDecoder::checkForHeadCharset): Ditto.
        (WebCore::TextResourceDecoder::decode): Use Vector::grow and shrink instead of resize.
        (WebCore::TextResourceDecoder::flush): Use Vector::shrink instead of resize.

        * platform/KURL.cpp:
        (WebCore::KURL::decode_string): Use Vector::grow instead of resize.

        * platform/SharedBuffer.cpp:
        (WebCore::SharedBuffer::clear): Use Vector::shrink instead of resize.

        * platform/graphics/BitmapImage.cpp:
        (WebCore::BitmapImage::cacheFrame): Use Vector::grow instead of resize.

        * platform/network/FormData.cpp:
        (WebCore::FormData::appendData): Use Vector::grow instead of resize.
        (WebCore::FormData::flatten): Ditto.

        * platform/text/AtomicString.cpp:
        (WebCore::CStringTranslator::translate): Use a new StringImpl constructor made just
        for use by AtomicString. Avoids setting fields twice, and also preserves reference
        count behavior (which I changed for the other constructors, since they're entirely
        private and used only inside the class).
        (WebCore::UCharBufferTranslator::translate): Ditto.

        * platform/text/Base64.cpp:
        (WebCore::base64Encode): Use Vector::grow instead of resize.
        (WebCore::base64Decode): Use Vector::grow and shrink instead of resize.

        * platform/text/PlatformString.h:
        (WebCore::String::adopt): Added an overload for the new StringBuffer class. Also
        made both versions inline.

        * platform/text/SegmentedString.h:
        (WebCore::SegmentedString::advancePastNewline): Added. One less branch for case
        where the character is known to be a newline.
        (WebCore::SegmentedString::advancePastNonNewline): Added. Less code for case where
        the character is known not to be a newline.

        * platform/text/String.cpp:
        (WebCore::String::append): Use StringBuffer instead of Vector<UChar>.
        (WebCore::String::insert): Ditto.
        (WebCore::String::truncate): Ditto.
        (WebCore::String::remove): Ditto.
        (WebCore::String::format): Use Vector::grow instead of resize.

        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::StringImpl): Changed constructors to start with a refCount
        of 1 instead of 0, and made them all inline. Eliminates the WithOneRef constructor
        since they all behave this way now. The only exceptions are the constructors for
        AtomicString, which retain the old behavior.
        (WebCore::StringImpl::empty): Simplified, since we no longer need to use the
        special WithOneRef constructor.
        (WebCore::StringImpl::toCoordsArray): Use StringBuffer instead of Vector<UChar>.
        (WebCore::StringImpl::lower): Ditto.
        (WebCore::StringImpl::upper): Ditto.
        (WebCore::StringImpl::secure): Ditto.
        (WebCore::StringImpl::foldCase): Ditto.
        (WebCore::StringImpl::simplifyWhiteSpace): Ditto. Also change to use Vector::shrink
        instead of resize (since half of the function uses Vector<UChar>).
        (WebCore::StringImpl::capitalize): Use StringBuffer instead of Vector<UChar>.
        (WebCore::StringImpl::replace): Ditto.
        (WebCore::StringImpl::ascii): Streamlined a bit.
        (WebCore::StringImpl::createStrippingNullCharacters): Use StringBuffer insetad of
        Vector<UChar>. Took out checks for null characters and 0 length that aren't needed.
        Coded the check for null characters in a slightly more efficient way. Since this
        is so hot, didn't call adopt at all, putting the code right in here, including
        the call to the StringImpl constructor and adoptRef (for the fast case).
        (WebCore::StringImpl::adopt): Added a version for the new StringBuffer class.
        Removed the attempt to resize the buffer at the time we adopt based on measuring
        actual use and realizing that it's just a character here or there and not worth
        a call to fastRealloc. Changed to use adoptRef since the constructor now starts
        with a refCount of 1.
        (WebCore::StringImpl::create): Changed to use adoptRef since the constructor now
        starts with a refCount of 1.
        (WebCore::StringImpl::createWithTerminatingNullCharacter): Ditto.
        (WebCore::StringImpl::copy): Ditto. Also made non-inline since the constructor
        itself is now inline.

        * platform/text/StringImpl.h: Added a StringBuffer class that's useful for
        putting characters into a buffer before creating an immutable string. Not good
        at resizing the way Vector<UChar> is, so only useful for things that rarely need
        to be resized. Added a new AdoptBuffer constructor and empty constructor, but
        made all constructors private so they can be inlined and only used inside the
        StringImpl class. Added two new constructors for AtomicString. Made copy()
        no longer inline. Changed the type of the [] operator to unsigned instead of
        int and added an assertion. Made the hash functions inline.

        * platform/text/TextCodecICU.cpp:
        (WebCore::TextCodecICU::encode): Use Vector::grow instead of resize.

        * platform/text/TextCodecLatin1.cpp:
        (WebCore::TextCodecLatin1::decode): Use StringBuffer instead of Vector<UChar>.
        (WebCore::encodeComplexWindowsLatin1): Use Vector::grow instead of resize.

        * platform/text/TextCodecUTF16.cpp:
        (WebCore::TextCodecUTF16::decode): Use StringBuffer instead of Vector<UChar>.

        * platform/text/TextCodecUserDefined.cpp:
        (WebCore::TextCodecUserDefined::decode): Use StringBuffer instead of Vector<UChar>.
        (WebCore::encodeComplexUserDefined): Use Vector::grow instead of resize.

        * platform/text/TextEncoding.cpp:
        (WebCore::TextEncoding::encode): Use Vector::grow instead of resize.

        * platform/text/TextStream.cpp:
        (WebCore::TextStream::operator<<): Use Vector::grow instead of resize.

        * platform/text/mac/TextCodecMac.cpp:
        (WebCore::TextCodecMac::encode): Use Vector::grow instead of resize.

        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::insertSpanCell): Use Vector::grow instead of resize.

        * rendering/RenderFrameSet.h:
        (WebCore::FrameEdgeInfo::FrameEdgeInfo): Allocate vectors with the correct initial
        size instead of calling resize on them after allocating empty.

        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint): Use Vector::grow instead of resize.

        * rendering/RenderStyle.cpp: Removed CursorList::operator==.
        * rendering/RenderStyle.h:
        (WebCore::CursorList::operator==): Implemented using the Vector ==.
        (WebCore::CursorList::operator!=): Ditto.

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::splitColumn): Use Vector::grow instead of resize.
        (WebCore::RenderTable::appendColumn): Ditto.

        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::ensureRows): Use Vector::grow instead of resize.

        * rendering/bidi.cpp:
        (WebCore::addMidpoint): Use Vector::grow instead of resize.

        * xml/XPathNodeSet.h:
        (WebCore::XPath::NodeSet::clear): Use Vector::shrink instead of resize.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * Scripts/run-webkit-tests: More ignore list tweaking.
darin@apple.com [Mon, 14 Jan 2008 17:47:49 +0000 (17:47 +0000)]
    * Scripts/run-webkit-tests: More ignore list tweaking.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * Scripts/run-webkit-tests: Add another leak to the ignore list.
darin@apple.com [Mon, 14 Jan 2008 17:45:57 +0000 (17:45 +0000)]
    * Scripts/run-webkit-tests: Add another leak to the ignore list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * platform/win/Skipped: Fixed a typo pointed out by Alexey.
aroben@apple.com [Mon, 14 Jan 2008 17:03:32 +0000 (17:03 +0000)]
    * platform/win/Skipped: Fixed a typo pointed out by Alexey.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * platform/win/Skipped: Added some intermittent failures.
aroben@apple.com [Mon, 14 Jan 2008 16:44:48 +0000 (16:44 +0000)]
    * platform/win/Skipped: Added some intermittent failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * platform/win/Skipped: Put back a failing test.
aroben@apple.com [Mon, 14 Jan 2008 16:35:48 +0000 (16:35 +0000)]
    * platform/win/Skipped: Put back a failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
mitz@apple.com [Mon, 14 Jan 2008 15:39:21 +0000 (15:39 +0000)]
    Reviewed by Adam Roben.

        - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
          build bots

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting): Focus the web view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Re-added two tests that weren't failing for me, but fail on the buildbot.
ap@webkit.org [Mon, 14 Jan 2008 15:36:01 +0000 (15:36 +0000)]
    Re-added two tests that weren't failing for me, but fail on the buildbot.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Added fast/frames/frame-name-reset.html, which crashes, and sometimes freezes...
ap@webkit.org [Mon, 14 Jan 2008 15:20:50 +0000 (15:20 +0000)]
    Added fast/frames/frame-name-reset.html, which crashes, and sometimes freezes buildbot.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Removed some more tests, moved one to a better place.
ap@webkit.org [Mon, 14 Jan 2008 14:15:14 +0000 (14:15 +0000)]
    Removed some more tests, moved one to a better place.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Remove a test that doesn't fail for me - let's see what the bot thinks.
ap@webkit.org [Mon, 14 Jan 2008 12:33:11 +0000 (12:33 +0000)]
    Remove a test that doesn't fail for me - let's see what the bot thinks.

        * platform/win/Skipped: Removed http/tests/xmlhttprequest/XMLHttpRequestException.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by David Kilzer.
ap@webkit.org [Mon, 14 Jan 2008 09:12:18 +0000 (09:12 +0000)]
    Reviewed by David Kilzer.

        array.splice() with 1 element not working

        Test: fast/js/array-splice.html

        * kjs/array_object.cpp:
        (KJS::ArrayProtoFuncSplice::callAsFunction): Implement this Mozilla extension, and fix
        some other edge cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
sfalken@apple.com [Mon, 14 Jan 2008 06:05:38 +0000 (06:05 +0000)]

        Share common files across projects.

        Unify vsprops files
        Debug:          common.vsprops, debug.vsprops
        Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
        Release:        common.vsprops, release.vsprops

        Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
        debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

        Reviewed by Adam Roben.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.vcproj/debug.vsprops: Removed.
        * JavaScriptCore.vcproj/debug_internal.vsprops: Removed.
        * JavaScriptCore.vcproj/release.vsprops: Removed.
        * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:


        Share common files across projects.

        Unify vsprops files
        Debug:          common.vsprops, debug.vsprops
        Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
        Release:        common.vsprops, release.vsprops

        Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
        debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

        Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

        Reviewed by Adam Roben.

        * WebCore.vcproj/PRODUCTVERSION: Removed.
        * WebCore.vcproj/QTMovieWin.vcproj:
        * WebCore.vcproj/VERSION: Removed.
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/auto-version.sh: Removed.
        * WebCore.vcproj/debug.vsprops: Removed.
        * WebCore.vcproj/debug_internal.vsprops: Removed.
        * WebCore.vcproj/release.vsprops: Removed.


        Share common files across projects.

        Unify vsprops files
        Debug:          common.vsprops, debug.vsprops
        Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
        Release:        common.vsprops, release.vsprops

        Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
        debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

        Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

        Reviewed by Adam Roben.

        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/PRODUCTVERSION: Removed.
        * WebKit.vcproj/VERSION: Removed.
        * WebKit.vcproj/WebKit.vcproj:
        * WebKit.vcproj/WebKitGUID.vcproj:
        * WebKit.vcproj/auto-version.sh: Removed.
        * WebKit.vcproj/debug.vsprops: Removed.
        * WebKit.vcproj/debug_internal.vsprops: Removed.
        * WebKit.vcproj/release.vsprops: Removed.


        Share common files across projects.

        Unify vsprops files
        Debug:          common.vsprops, debug.vsprops
        Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
        Release:        common.vsprops, release.vsprops

        Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
        debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

        Moved auto-version.sh, VERSION, PRODUCTVERSION to tools.

        Reviewed by Adam Roben.

        * win/tools/WinTools.make:
        * win/tools/scripts: Added.
        * win/tools/scripts/PRODUCTVERSION: Added.
        * win/tools/scripts/VERSION: Added.
        * win/tools/scripts/auto-version.sh: Copied from WebCore/WebCore.vcproj/auto-version.sh.
        * win/tools/vsprops/debug.vsprops:
        * win/tools/vsprops/debug_internal.vsprops: Added.
        * win/tools/vsprops/release.vsprops:


        Share common files across projects.

        Unify vsprops files
        Debug:          common.vsprops, debug.vsprops
        Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
        Release:        common.vsprops, release.vsprops

        Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
        debug_internal.vsprops will be mostly empty except for file path prefix modifiers.

        Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.

        Reviewed by Adam Roben.

        * Drosera/win/Drosera.vcproj/Drosera.vcproj:
        * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
        * Drosera/win/Drosera.vcproj/VERSION: Removed.
        * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
        * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
        * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
        * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
        * DumpRenderTree/win/debug.vsprops: Removed.
        * DumpRenderTree/win/debug_internal.vsprops: Removed.
        * DumpRenderTree/win/release.vsprops: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler.
mitz@apple.com [Mon, 14 Jan 2008 04:40:46 +0000 (04:40 +0000)]
    Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16865
          fast/layers/resize-layer-deletion-crash.html crashes under GuardMalloc

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::destroy): Removed the call to
        RenderLayer::destroy() from here, because ~RenderLayer() calls
        RenderObject() methods.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::destroy): Added the call to
        RenderLayer::destroy() here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by darin.
eric@webkit.org [Mon, 14 Jan 2008 01:35:00 +0000 (01:35 +0000)]
    Reviewed by darin.

        Range.insertNode does not update endContainer endIndex correctly
        in the case where it had to split a text node.

        Darin pointed out during review that we still don't handle the dynamic
        range case (where the dom tree changes not using range methods)
        Thus this code will get ripped out when we add that.  The test cases
        are still valid and useful however, so I'm landing this as-is.

        Tests: fast/dom/Range/range-insertNode-separate-endContainer.html

        * dom/Range.cpp:
        (WebCore::Range::insertNode): handle the splitText case correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin@apple.com [Sun, 13 Jan 2008 19:54:53 +0000 (19:54 +0000)]
    Reviewed by Maciej.

        - http://bugs.webkit.org/show_bug.cgi?id=16314
          Script to launch Drosera

        * Scripts/gdb-drosera: Added.
        * Scripts/run-drosera: Added.
        * Scripts/run-drosera-nightly.cmd: Added.
        * Scripts/webkitdirs.pm: Added runDrosera function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Contributions and review by Adriaan de Groot,
darin@apple.com [Sun, 13 Jan 2008 19:47:56 +0000 (19:47 +0000)]
    Contributions and review by Adriaan de Groot,
        Simon Hausmann, Eric Seidel, and Darin Adler.

        - http://bugs.webkit.org/show_bug.cgi?id=16590
          Compilation fixes for Solaris.

        * kjs/DateMath.h:
        (KJS::GregorianDateTime::GregorianDateTime): Use the WIN_OS code path
        for SOLARIS too, presumably because Solaris also lacks the tm_gtoff and tm_zone
        (KJS::GregorianDateTime::operator tm): Ditto.

        * kjs/collector.cpp:
        (KJS::currentThreadStackBase): Use thr_stksegment on Solaris.

        * wtf/MathExtras.h:
        (isfinite): Implement for Solaris.
        (isinf): Ditto.
        (signbit): Ditto. But this one is wrong, so I added a FIXME.

        * wtf/Platform.h: Define PLATFORM(SOLARIS) when "sun" or "__sun" is defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29454 268f45cc-cd09-0410-ab3c-d52691b4dbfc