mrowe@apple.com [Mon, 14 Mar 2011 03:02:27 +0000 (03:02 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80990
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 14 Mar 2011 02:36:48 +0000 (02:36 +0000)]
Updated expected results after r80982.
* platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80988
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 14 Mar 2011 01:35:16 +0000 (01:35 +0000)]
Not reviewed.
Try to fix the Mac build.
* JavaScriptCore.xcodeproj/project.pbxproj: Make sure to forward
ConervativeSet.h, since it's now visible when compiling other projects.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80987
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 14 Mar 2011 01:27:37 +0000 (01:27 +0000)]
Fix windows build.
* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::ResourceError):
Add missing constructor.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80986
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 14 Mar 2011 01:16:15 +0000 (01:16 +0000)]
2011-03-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed another case of DeprecatedPtr (ConservativeSet)
https://bugs.webkit.org/show_bug.cgi?id=56281
The ConservativeSet is an internal data structure used during marking,
so direct pointers are fine.
* runtime/ConservativeSet.cpp:
(JSC::ConservativeSet::grow):
* runtime/ConservativeSet.h: Added some accessors, for use by MarkStack::append.
(JSC::ConservativeSet::~ConservativeSet): Fixed a typo where we calculated
the size of the set based on sizeof(DeprecatedPtr<T>*) instead of
sizeof(DeprecatedPtr<T>). I'm not sure if this had real-world implications or not.
(JSC::ConservativeSet::size):
(JSC::ConservativeSet::set): Use direct pointers, as stated above.
* runtime/Heap.cpp:
(JSC::Heap::markRoots):
* runtime/MarkStack.h:
(JSC::MarkStack::append): Created a special case of append for
ConservativeSet. I didn't want to add back a generic "append JSCell*"
function, since other class might start using that wrong. (In the end,
this function might go away, since the Heap will want to do something
slightly more interesting with the conservative set, but this is OK for
now.)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80985
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 14 Mar 2011 01:09:26 +0000 (01:09 +0000)]
Source/WebCore: REGRESSION: Soft hyphen is not always rendered
https://bugs.webkit.org/show_bug.cgi?id=56017
Patch by David Sosby <dsosby@rim.com> on 2011-03-13
Reviewed by Dan Bernstein.
The check to flag a text block as hyphenated was only
occurring at break points in the line. If no break points
were found after the soft hyphen then the line would not
be flagged hyphenated. Adding a check for soft hyphen at
the end of the text run resolves the issue.
Test: fast/text/soft-hyphen-4.html
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak):
LayoutTests: Reviewed and tweaked by Dan Bernstein.
Patch by David Sosby <dsosby@rim.com> on 2011-03-13
REGRESSION: Soft hyphen is not always rendered
https://bugs.webkit.org/show_bug.cgi?id=56017
Adding new test that verifies soft hyphen is rendered
when it is the last breakable point in a line.
* fast/text/soft-hyphen-4-expected.checksum: Added.
* fast/text/soft-hyphen-4-expected.png: Added.
* fast/text/soft-hyphen-4-expected.txt: Added.
* fast/text/soft-hyphen-4.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80984
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Mon, 14 Mar 2011 00:58:03 +0000 (00:58 +0000)]
Update some baselines due to r80868.
Also, add MAC to a failure line where I should have put it previously.
* platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.checksum: Added.
* platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.png: Added.
* platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.checksum: Added.
* platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80983
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 14 Mar 2011 00:54:59 +0000 (00:54 +0000)]
REGRESSION (r80438): fast/text/hyphenate-character failing in pixel mode
https://bugs.webkit.org/show_bug.cgi?id=56280
Reviewed by Mark Rowe.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::tryHyphenating): Avoid subtracting 1 from an unsigned 0.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80982
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 14 Mar 2011 00:34:34 +0000 (00:34 +0000)]
Add ability to create a WKErrorRef
<rdar://problem/
9115768>
https://bugs.webkit.org/show_bug.cgi?id=56279
Reviewed by Anders Carlsson.
Source/WebCore:
* WebCore.exp.in:
Add new exports.
* platform/network/cf/ResourceError.h:
* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::platformCompare):
(WebCore::ResourceError::cfError):
(WebCore::ResourceError::operator CFErrorRef):
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::cfStreamError):
(WebCore::ResourceError::operator CFStreamError):
* platform/network/mac/ResourceErrorMac.mm:
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::platformCompare):
(WebCore::ResourceError::nsError):
(WebCore::ResourceError::operator NSError *):
(WebCore::ResourceError::cfError):
(WebCore::ResourceError::operator CFErrorRef):
Clean up ResourceError a bit and add ability to create a ResourceError from a CFErrorRef
regardless of whether CFNetwork is being used.
Source/WebKit2:
* Shared/API/c/cf/WKErrorCF.cpp: Added.
(WKErrorCreateWithCFError):
(WKErrorCopyCFError):
* Shared/API/c/cf/WKErrorCF.h: Added.
Add new API to create a WKErrorRef from a CFErrorRef
and vice-versa.
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:
Add new files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80981
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 14 Mar 2011 00:34:32 +0000 (00:34 +0000)]
2011-03-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed another case of DeprecatedPtr (PutPropertySlot)
https://bugs.webkit.org/show_bug.cgi?id=56278
* runtime/PutPropertySlot.h:
(JSC::PutPropertySlot::setExistingProperty):
(JSC::PutPropertySlot::setNewProperty):
(JSC::PutPropertySlot::base): Direct pointer is fine for PutPropertySlot,
since it's a stack-allocated temporary.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80980
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Mon, 14 Mar 2011 00:31:59 +0000 (00:31 +0000)]
Add one more failure which is related to change in this range:
http://trac.webkit.org/log/?verbose=on&rev=80866&stop_rev=80860
that I haven't been able to narrow down yet.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80979
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Mon, 14 Mar 2011 00:31:52 +0000 (00:31 +0000)]
Add more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80978
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 14 Mar 2011 00:15:31 +0000 (00:15 +0000)]
2011-03-13 Joe Wild <joseph.wild@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] QtLauncher does not load the same set of fonts as the DRT
https://bugs.webkit.org/show_bug.cgi?id=34959
This patch adds the option "-use-test-fonts" to the QtTestBrowser.
When this option is used the webkit fonts are loaded the same
as they are in DumpRenderTree. This option can be used on
QtTestBrowser and run-launcher. It can only be used
on Linux systems with FcInit and is configured as such.
* QtTestBrowser/launcherwindow.h:
(WindowOptions::WindowOptions):
* QtTestBrowser/main.cpp:
(initWebKitTestFonts):
(launcherMain):
(LauncherApplication::handleUserOptions):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80977
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 14 Mar 2011 00:14:18 +0000 (00:14 +0000)]
2011-03-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed one case of DeprecatedPtr (ScopeChainIterator)
https://bugs.webkit.org/show_bug.cgi?id=56277
* runtime/ScopeChain.h: Direct pointer is fine for ScopeChainIterator,
since it's a stack-allocated temporary.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
psolanki@apple.com [Mon, 14 Mar 2011 00:10:38 +0000 (00:10 +0000)]
Make adjustMIMETypeIfNecessary use CFNetwork directly
https://bugs.webkit.org/show_bug.cgi?id=55912
Reviewed by Brady Eidson.
Source/WebCore:
Convert category method [NSURLResponse adjustMIMETypeIfNecessary] to C function
WebCore::adjustMIMETypeIfNecessary() that takes a CFURLResponseRef and is functionally
identical.
Testing is covered by existing LayoutTests.
* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
* platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
* platform/network/mac/WebCoreURLResponse.h:
* platform/network/mac/WebCoreURLResponse.mm:
(WebCore::createBinaryExtensionsSet):
(WebCore::createExtensionToMIMETypeMap):
(WebCore::mimeTypeFromUTITree):
(WebCore::adjustMIMETypeIfNecessary):
Source/WebKit/mac:
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Support for new WKSI functions.
Source/WebKit2:
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Support for new WKSI functions.
WebKitLibraries:
Add new WKSI functions needed to implement adjustMIMETypeIfNecessary.
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80975
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sun, 13 Mar 2011 22:41:00 +0000 (22:41 +0000)]
Fix the expectation to refer to transitions/default-timing-function.html
instead of bug1318. My change log description also made the same mistake.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80974
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sun, 13 Mar 2011 22:37:37 +0000 (22:37 +0000)]
Sort some test expectations into a better place. Move a linux debug
crash to be near the other instances of it.
Remove fast/text/font-size-zero.html as it appears to be passing consistently.
Add the expectation for bug1318.html due to r80806 changing its output in a way
that looks less optimal than it did before.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80973
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Sun, 13 Mar 2011 22:11:13 +0000 (22:11 +0000)]
Bug 56273 - Add three operand forms to MacroAssember operations.
Reviewed by Sam Weinig.
Adding for X86(_64) for now, should be rolled out to other backends as necessary.
These may allow more efficient code generation in some cases, avoiding the need
for unnecessary register-register move instructions.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
- marked these methods const.
(JSC::AbstractMacroAssembler::Jump::isSet):
- add a method to check whether a Jump object has been set to
reference an instruction, or is in a null, unset state.
* assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):
- add non-explicit constructor, for FunctionPtr's to C/C++ functions.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::and32):
(JSC::MacroAssemblerX86Common::lshift32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::rshift32):
(JSC::MacroAssemblerX86Common::urshift32):
(JSC::MacroAssemblerX86Common::xor32):
(JSC::MacroAssemblerX86Common::moveDouble):
(JSC::MacroAssemblerX86Common::addDouble):
(JSC::MacroAssemblerX86Common::divDouble):
(JSC::MacroAssemblerX86Common::subDouble):
(JSC::MacroAssemblerX86Common::mulDouble):
(JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerX86Common::branchTest32):
(JSC::MacroAssemblerX86Common::branchTest8):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::branchMul32):
(JSC::MacroAssemblerX86Common::branchSub32):
- add three operand forms of these instructions.
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::addDouble):
(JSC::MacroAssemblerX86_64::convertInt32ToDouble):
(JSC::MacroAssemblerX86_64::loadPtr):
(JSC::MacroAssemblerX86_64::branchTestPtr):
* assembler/X86Assembler.h:
(JSC::X86Assembler::JmpSrc::isSet):
- add a method to check whether a JmpSrc object has been set to
reference an instruction, or is in a null, unset state.
(JSC::X86Assembler::movsd_rr):
- added FP register-register move.
(JSC::X86Assembler::linkJump):
- Add an assert to check jumps aren't linked more than once.
* jit/JITInlineMethods.h:
(JSC::JIT::emitLoadInt32ToDouble):
- load integers to the FPU via regsiters on x86-64.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80972
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sun, 13 Mar 2011 22:05:54 +0000 (22:05 +0000)]
Add some more crashing tests to an existing bug about the same issue
for Chromium Linux Debug.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80971
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Sun, 13 Mar 2011 21:26:16 +0000 (21:26 +0000)]
ARM build fix.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load32):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80970
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Sun, 13 Mar 2011 21:16:29 +0000 (21:16 +0000)]
Bug 56270 - The JIT 'friend's many classes in JSC; start unwinding this.
Reviewed by Sam Weinig.
The JIT need to 'friend' other classes in order to be able to calculate offsets
of various properties, or the absolute addresses of members within specific objects,
in order to JIT generate code that will access members within the class when run.
Instead of using friends in these cases, switch to providing specific accessor
methods to provide this information. In the case of offsets, these can be static
functions, and in the case of pointers to members within a specific object these can
be const methods returning pointers to const values, to prevent clients from
modifying values otherwise encapsulated within classes.
* bytecode/SamplingTool.h:
* interpreter/Register.h:
* interpreter/RegisterFile.h:
* runtime/JSArray.h:
* runtime/JSCell.h:
* runtime/JSTypeInfo.h:
* runtime/JSVariableObject.h:
* runtime/Structure.h:
* wtf/RefCounted.h:
- Change these classes to no longer friend the JIT, add accessors for member offsets.
* jit/JIT.cpp:
* jit/JITCall32_64.cpp:
* jit/JITInlineMethods.h:
* jit/JITOpcodes.cpp:
* jit/JITOpcodes32_64.cpp:
* jit/JITPropertyAccess.cpp:
* jit/JITPropertyAccess32_64.cpp:
- Change the JIT to use class accessors, rather than taking object ofsets directly.
* assembler/AbstractMacroAssembler.h:
* assembler/MacroAssemblerX86_64.h:
* assembler/X86Assembler.h:
- Since the accessors for objects members return const pointers to retain encapsulation,
methods generating code with absolute addresses must be able to handle const pointers
(the JIT doesn't write to these values, do dies treat the pointer to value as const
from within the C++ code of the JIT, if not at runtime!).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80969
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 13 Mar 2011 20:30:21 +0000 (20:30 +0000)]
WebPageProxy cleanup
https://bugs.webkit.org/show_bug.cgi?id=56267
Reviewed by Darin Adler.
* UIProcess/WebPageProxy.cpp: Moved all Mac-only function implementations from
here to WebPageProxyMac.mm.
* UIProcess/WebPageProxy.h: Cleaned up #includes.
* UIProcess/mac/WebPageProxyMac.mm: Moved all Mac-only function implementations
here.
(WebKit::WebPageProxy::updateWindowIsVisible):
(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::getMarkedRange):
(WebKit::WebPageProxy::characterIndexForPoint):
(WebKit::WebPageProxy::firstRectForCharacterRange):
(WebKit::WebPageProxy::writeSelectionToPasteboard):
(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::performDictionaryLookupAtLocation):
(WebKit::WebPageProxy::interpretKeyEvent):
(WebKit::WebPageProxy::sendComplexTextInputToPlugin):
(WebKit::WebPageProxy::uppercaseWord):
(WebKit::WebPageProxy::lowercaseWord):
(WebKit::WebPageProxy::capitalizeWord):
(WebKit::WebPageProxy::setSmartInsertDeleteEnabled):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):
(WebKit::WebPageProxy::setComplexTextInputEnabled):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80968
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 13 Mar 2011 20:28:08 +0000 (20:28 +0000)]
<rdar://problem/
8949683> WebKit2: Drag image is offset when the page is scrolled down
https://bugs.webkit.org/show_bug.cgi?id=56265
Reviewed by Darin Adler.
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag): Send the location in view coordinates rather than
document coordinates.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80967
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 13 Mar 2011 20:24:06 +0000 (20:24 +0000)]
Fix a crash when dragging.
Reviewed by Mark Rowe.
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::convertImageToBitmap): Retain the saved context.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80966
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeremy@chromium.org [Sun, 13 Mar 2011 19:46:06 +0000 (19:46 +0000)]
2011-03-13 Jeremy Moskovich <jeremy@chromium.org>
Reviewed by Dimitri Glazkov.
Update comment in CSSValueKeywords.in
https://bugs.webkit.org/show_bug.cgi?id=56266
The enums the comment refers to were moved from RenderStyle.h to RenderStyleConstants.h
in r36579 but it appears that the comment in CSSValueKeywords.in wasn't updated.
No tests - just updating a comment.
* css/CSSValueKeywords.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80965
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 13 Mar 2011 19:07:55 +0000 (19:07 +0000)]
2011-03-13 Anton D'Auria <adauria@apple.com>
Reviewed by Alice Liu.
StorageTracker constructor shouldn't have initialization code and isMainThread() assertion
https://bugs.webkit.org/show_bug.cgi?id=56259
Move all StorageTracker initialization to
StorageTracker::initializeTracker. This also removes the
requirement that the StorageTracker constructor isn't run
on the main thread.
* storage/StorageTracker.cpp:
(WebCore::StorageTracker::initializeTracker):
(WebCore::StorageTracker::tracker):
(WebCore::StorageTracker::StorageTracker):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80964
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Sun, 13 Mar 2011 18:47:27 +0000 (18:47 +0000)]
2011-03-13 Rob Buis <rwlbuis@gmail.com>
Reviewed by Dave Hyatt.
REGRESSION (r61383): Navigation menu laid out incorrectly on aboardtheworld.com
https://bugs.webkit.org/show_bug.cgi?id=53470
Prefer !important over normal properties when dealing with duplicate properties in style rules.
Test: fast/css/duplicate-property-in-rule-important.html
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80963
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sun, 13 Mar 2011 18:42:20 +0000 (18:42 +0000)]
Add expectation (and bug) for test that has failed with an image
mismatch ever since it was added in r80867.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80962
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sun, 13 Mar 2011 18:09:33 +0000 (18:09 +0000)]
Update test expections due to the OSX specific ex size change done in r80755.
* platform/chromium-mac/fast/lists/008-expected.checksum: Added.
* platform/chromium-mac/fast/lists/008-expected.png: Added.
* platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Added.
* platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Added.
* platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.checksum: Added.
* platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png: Added.
* platform/chromium-mac/fast/replaced/width100percent-radio-expected.checksum: Added.
* platform/chromium-mac/fast/replaced/width100percent-radio-expected.png: Added.
* platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum: Added.
* platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80961
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sun, 13 Mar 2011 17:04:49 +0000 (17:04 +0000)]
Fix test expectations due to bad update:
r80820 which limited to win/mac when it still regularly fails on Linux
and it made the test fail with the expectation IMAGE instead of IMAGE+TEXT
as well as occaisionally pass.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80960
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sun, 13 Mar 2011 10:07:36 +0000 (10:07 +0000)]
Added the following expectations:
fast/backgrounds/background-position-parsing.html new test in r80868
fast/css-generated-content/table-row-before-after.html new test in r80871
fast/table/dynamic-descendant-percentage-height.html new test in r80878
Updated test_expectation to cover a failure due to a missing layout test feature
and added an appropriate bug.
* platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.checksum: Added.
* platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.png: Added.
* platform/chromium-linux/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
* platform/chromium-linux/fast/css-generated-content/table-row-before-after-expected.png: Added.
* platform/chromium-linux/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
* platform/chromium-linux/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
* platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.checksum: Added.
* platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png: Added.
* platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
* platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.png: Added.
* platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
* platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
* platform/chromium-win/fast/backgrounds/background-position-parsing-expected.checksum: Added.
* platform/chromium-win/fast/backgrounds/background-position-parsing-expected.png: Added.
* platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt: Added.
* platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
* platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.png: Added.
* platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.txt: Added.
* platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
* platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
* platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80959
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sun, 13 Mar 2011 09:30:02 +0000 (09:30 +0000)]
Update test results due to r80755. All of these tests started failing
on that check in and were given new baselines in that check in.
* platform/chromium-mac/css1/text_properties/text_indent-expected.checksum: Added.
* platform/chromium-mac/css1/text_properties/text_indent-expected.png: Added.
* platform/chromium-mac/css1/units/length_units-expected.checksum: Added.
* platform/chromium-mac/css1/units/length_units-expected.png: Added.
* platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.png: Added.
* platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum: Added.
* platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.png: Added.
* platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
* platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.checksum: Added.
* platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.png: Added.
* platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
* platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
* platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum: Added.
* platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png: Added.
* platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.png: Added.
* platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.png: Added.
* platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Added.
* platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.png: Added.
* platform/chromium-mac/editing/selection/caret-ltr-2-expected.checksum:
* platform/chromium-mac/editing/selection/caret-ltr-2-expected.png:
* platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.checksum:
* platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png:
* platform/chromium-mac/editing/selection/caret-ltr-expected.checksum:
* platform/chromium-mac/editing/selection/caret-ltr-expected.png:
* platform/chromium-mac/editing/selection/caret-ltr-right-expected.checksum:
* platform/chromium-mac/editing/selection/caret-ltr-right-expected.png:
* platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Added.
* platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Added.
* platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Added.
* platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Added.
* platform/chromium-mac/editing/selection/caret-rtl-expected.checksum: Added.
* platform/chromium-mac/editing/selection/caret-rtl-expected.png: Added.
* platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Added.
* platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Added.
* platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum:
* platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
* platform/chromium-mac/fast/css/ex-after-font-variant-expected.checksum: Added.
* platform/chromium-mac/fast/css/ex-after-font-variant-expected.png: Added.
* platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.checksum: Added.
* platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.png: Added.
* platform/chromium-mac/fast/forms/minWidthPercent-expected.checksum: Added.
* platform/chromium-mac/fast/forms/minWidthPercent-expected.png: Added.
* platform/chromium-mac/fast/overflow/overflow-rtl-expected.checksum: Added.
* platform/chromium-mac/fast/overflow/overflow-rtl-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80958
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 13 Mar 2011 07:34:38 +0000 (07:34 +0000)]
2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80895.
http://trac.webkit.org/changeset/80895
https://bugs.webkit.org/show_bug.cgi?id=56261
Causing crashes in several tests including
t1202-counters-16-c.html (see
http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80956%20(15528)/results.html)
(Requested by dave_levin on #webkit).
* rendering/CounterNode.cpp:
(WebCore::CounterNode::CounterNode):
(WebCore::CounterNode::create):
(WebCore::CounterNode::resetRenderer):
(WebCore::CounterNode::resetRenderers):
(WebCore::CounterNode::recount):
(WebCore::CounterNode::insertAfter):
(WebCore::CounterNode::removeChild):
(WebCore::showTreeAndMark):
* rendering/CounterNode.h:
(WebCore::CounterNode::renderer):
* rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):
(WebCore::RenderCounter::~RenderCounter):
(WebCore::RenderCounter::originalText):
(WebCore::RenderCounter::invalidate):
(WebCore::destroyCounterNodeWithoutMapRemoval):
(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::updateCounters):
(showCounterRendererTree):
* rendering/RenderCounter.h:
* rendering/RenderObjectChildList.cpp:
(WebCore::invalidateCountersInContainer):
(WebCore::RenderObjectChildList::invalidateCounters):
* rendering/RenderObjectChildList.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80957
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sun, 13 Mar 2011 04:19:09 +0000 (04:19 +0000)]
Add results for newly added test in r80883.
The differences appear to be very small in keep with the typical
font drawing differences.
* platform/chromium-linux/fast/multicol/scrolling-overflow-expected.checksum: Added.
* platform/chromium-linux/fast/multicol/scrolling-overflow-expected.png: Added.
* platform/chromium-mac/fast/multicol/scrolling-overflow-expected.checksum: Added.
* platform/chromium-mac/fast/multicol/scrolling-overflow-expected.png: Added.
* platform/chromium-win/fast/multicol/scrolling-overflow-expected.checksum: Added.
* platform/chromium-win/fast/multicol/scrolling-overflow-expected.png: Added.
* platform/chromium-win/fast/multicol/scrolling-overflow-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80956
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 13 Mar 2011 04:05:39 +0000 (04:05 +0000)]
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag): Fixed typo in a comment.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80955
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sun, 13 Mar 2011 04:03:33 +0000 (04:03 +0000)]
r80743 updated the main baseline due to a jsc change.
chromium isn't affected by the change.
* platform/chromium/fast/js/regexp-caching-expected.txt: Added.
chromium already had a specific baseline for this but it was in chromium-win,
so I moved this result to the more general chromium direction.
* platform/chromium-win/fast/js/regexp-caching-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80954
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sun, 13 Mar 2011 03:46:57 +0000 (03:46 +0000)]
Remove bad test_expectation updates.
I fixed both of these already:
http://trac.webkit.org/changeset/80911
http://trac.webkit.org/changeset/80904
so it is unclear why they were added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80953
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 13 Mar 2011 03:46:50 +0000 (03:46 +0000)]
2011-03-12 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
REGRESSION (r76474): IntegerArray hash hashes only 1/4 of the array
https://bugs.webkit.org/show_bug.cgi?id=56258
No tests because the wrong hashing is mostly harmless. The only symptom
we have seen is an occasional assertion in debug builds about the size
not being a multiple of two. But a worse hash is worse for performance too.
* platform/cf/BinaryPropertyList.cpp:
(WebCore::IntegerArrayHash::hash): Pass in the size in bytes rather
than the number of array entries.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80952
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Sun, 13 Mar 2011 03:36:23 +0000 (03:36 +0000)]
Not reviewed.
Fix the build with newer GCCs and remove some extra whitespae.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::uint8_t):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80951
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Sun, 13 Mar 2011 03:24:54 +0000 (03:24 +0000)]
Rubber-stamped by Oliver Hunt.
Removed unused ARMv5 code. The ARMv5 case now falls under the general
unaligned accessed case.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readLittleEndian):
(WebCore::CloneDeserializer::readString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80950
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Sun, 13 Mar 2011 03:18:37 +0000 (03:18 +0000)]
Reviewed by Oliver Hunt.
WebCore fails to build with Clang on ARM
https://bugs.webkit.org/show_bug.cgi?id=56257
Add an explicit instantiation of writeLittleEndian for uint8_t and move it to
namespace scope, since explicit specializations are not allowed at class scope.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::writeLittleEndian):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80949
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Sun, 13 Mar 2011 03:11:57 +0000 (03:11 +0000)]
2011-03-11 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Dragging image to desktop gives webloc instead of image file in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=56193
* WebCore.exp.in: Added some additional exports. Re-sorted.
2011-03-11 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Dragging image to desktop gives webloc instead of image file in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=56193
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::convertImageToBitmap): Added. Factored out from startDrag to
make the startDrag code clearer.
(WebKit::WebDragClient::startDrag): Streamlined code a bit.
(WebKit::cachedImage): Added. Helper for function below.
(WebKit::arrayForURLsWithTitles): Added. Helper for function below.
(WebKit::WebDragClient::declareAndWriteDragImage): Added code to handle file
promises and removed a log of uneeded code.
(-[WKPasteboardFilePromiseOwner copyDropDirectory]): Added.
(promisedDataClient): Added.
(-[WKPasteboardOwner clearImage]): Added.
(-[WKPasteboardOwner initWithImage:]): Added.
(-[WKPasteboardOwner dealloc]): Added.
(-[WKPasteboardOwner finalize]): Added.
(-[WKPasteboardOwner pasteboard:provideDataForType:]): Added.
(-[WKPasteboardOwner pasteboardChangedOwner:]): Added.
(matchesExtensionOrEquivalent): Added.
(-[WKPasteboardOwner namesOfPromisedFilesDroppedAtDestination:]): Added.
Much of the new code above came from the WebKit1 drag code.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::dragEnded): Added call to Mac-only platformDragEnded.
* WebProcess/WebPage/WebPage.h: Added Mac-only platformDragEnded and m_dragSource.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::setDragSource): Added.
(WebKit::WebPage::platformDragEnded): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80948
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 12 Mar 2011 22:32:15 +0000 (22:32 +0000)]
<rdar://problem/
8995822> Build DumpRenderTree perl support only for the architectures
DumpRenderTree is being built for.
Reviewed by Mark Rowe.
* DumpRenderTree/mac/PerlSupport/Makefile:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80947
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 12 Mar 2011 22:15:44 +0000 (22:15 +0000)]
Fix the 32-bit build.
Source/WebKit/mac:
* Carbon/CarbonWindowAdapter.mm:
(-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
(-[CarbonWindowAdapter _carbonWindowClass]): Ditto.
Source/WebKit2:
This involves hacking around some HIToolbox headers that do things of dubious correctness,
and fixing the usual CGRect vs NSRect issues.
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController enterFullScreen:]): NSRect is not CGRect.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80946
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 12 Mar 2011 21:42:48 +0000 (21:42 +0000)]
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::url):
Get the URL from the loader, not from the document.
Reviewed by Sam Weinig.
(WebKit::WebFrame::suggestedFilenameForResourceWithURL):
Return the correct suggested filename for the main resource.
(WebKit::WebFrame::mimeTypeForResourceWithURL):
Return the correct mime type for the main resource.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80945
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 12 Mar 2011 21:30:54 +0000 (21:30 +0000)]
Suggested by Mark Rowe.
* DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
as they were before r80915.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80944
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 12 Mar 2011 20:43:27 +0000 (20:43 +0000)]
2011-03-12 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Should be able to download a PDF to the Downloads folder
https://bugs.webkit.org/show_bug.cgi?id=56256
* UIProcess/API/C/WKPage.h:
Add WKPageSaveDataToFileInDownloadsFolderCallback to the UI client.
* UIProcess/API/mac/PDFViewController.h:
* UIProcess/API/mac/PDFViewController.mm:
(-[WKPDFView _applyPDFPreferences]):
(-[WKPDFView _updatePreferences:]):
Use new PDFViewController::page getter.
(-[WKPDFView PDFViewSavePDFToDownloadFolder:]):
Call PDFViewController::savePDFToDownloadsFolder.
(WebKit::releaseCFData):
(WebKit::PDFViewController::savePDFToDownloadsFolder):
Create a WebData that wraps the CFData, then pass it along to
WebPageProxy::saveDataToFileInDownloadsFolder.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::saveDataToFileInDownloadsFolder):
Call WebUIClient::saveDataToFileInDownloadsFolder.
(WebKit::WebUIClient::saveDataToFileInDownloadsFolder):
* UIProcess/WebUIClient.h:
Call the UI client callback function.
2011-03-12 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Should be able to download a PDF to the Downloads folder
https://bugs.webkit.org/show_bug.cgi?id=56256
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
Update for API changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80943
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 12 Mar 2011 19:34:46 +0000 (19:34 +0000)]
2011-03-12 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
WebData should be able to wrap already existing data
https://bugs.webkit.org/show_bug.cgi?id=56254
* Shared/WebData.h:
(WebKit::WebData::createWithoutCopying):
(WebKit::WebData::create):
(WebKit::WebData::~WebData):
(WebKit::WebData::bytes):
(WebKit::WebData::size):
(WebKit::WebData::WebData):
(WebKit::WebData::fastFreeBytes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80942
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Sat, 12 Mar 2011 18:14:01 +0000 (18:14 +0000)]
2011-03-12 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
WebKit2: Initialize the WebFullScreenManagerProxy with a WKView
https://bugs.webkit.org/show_bug.cgi?id=56250
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]): Call fullScreenManager()->setView(self).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80941
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Sat, 12 Mar 2011 16:44:07 +0000 (16:44 +0000)]
2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Update chromium expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80940
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Sat, 12 Mar 2011 16:07:54 +0000 (16:07 +0000)]
2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Update chromium test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80939
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Sat, 12 Mar 2011 15:54:17 +0000 (15:54 +0000)]
2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80919.
http://trac.webkit.org/changeset/80919
https://bugs.webkit.org/show_bug.cgi?id=56251
all windows bots failed to compile this change (Requested by
loislo on #webkit).
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/StructureStubInfo.cpp:
* interpreter/Register.h:
(JSC::Register::withInt):
(JSC::Register::withCallee):
(JSC::Register::operator=):
(JSC::Register::i):
(JSC::Register::activation):
(JSC::Register::function):
(JSC::Register::propertyNameIterator):
(JSC::Register::scopeChain):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITInlineMethods.h:
(JSC::JIT::emitPutToCallFrameHeader):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_load_varargs):
(JSC::JIT::emitSlow_op_load_varargs):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::payloadFor):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::returnJSValue):
(JSC::SpecializedThunkJIT::returnDouble):
(JSC::SpecializedThunkJIT::returnInt32):
(JSC::SpecializedThunkJIT::returnJSCell):
* runtime/ArgList.cpp:
* runtime/DateConversion.cpp:
* runtime/GCActivityCallbackCF.cpp:
* runtime/Identifier.cpp:
* runtime/JSActivation.h:
(JSC::asActivation):
* runtime/JSLock.cpp:
* runtime/JSNumberCell.cpp:
* runtime/JSObject.h:
* runtime/JSPropertyNameIterator.h:
* runtime/JSValue.h:
* runtime/JSZombie.cpp:
* runtime/MarkedBlock.cpp:
* runtime/MarkedSpace.cpp:
* runtime/PropertyNameArray.cpp:
* runtime/ScopeChain.h:
(JSC::ExecState::globalThisValue):
* wtf/DateMath.cpp:
2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80919.
http://trac.webkit.org/changeset/80919
https://bugs.webkit.org/show_bug.cgi?id=56251
all windows bots failed to compile this change (Requested by
loislo on #webkit).
* bridge/c/c_class.cpp:
* bridge/c/c_runtime.cpp:
* bridge/jni/JavaMethod.cpp:
* plugins/PluginViewNone.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80938
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 12 Mar 2011 15:47:30 +0000 (15:47 +0000)]
2011-03-12 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r80900.
* CMakeListsWinCE.txt: Removed IconDatabaseNone.cpp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80937
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Sat, 12 Mar 2011 15:38:49 +0000 (15:38 +0000)]
2011-03-12 Andras Becsi <abecsi@webkit.org>
Unreviewed typo fix.
No new tests needed.
* WebCore.pro: Fix typo in header name.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80936
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Sat, 12 Mar 2011 14:44:46 +0000 (14:44 +0000)]
2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Update chromium test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80935
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Sat, 12 Mar 2011 12:00:50 +0000 (12:00 +0000)]
2011-03-12 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: Inspect Element action regression fix.
* inspector/front-end/inspector.js:
(WebInspector.inspect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80934
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Sat, 12 Mar 2011 11:53:27 +0000 (11:53 +0000)]
2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. One line fix for inspector/dom-breakpoints.html
* inspector/front-end/BreakpointManager.js:
(WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Sat, 12 Mar 2011 11:26:16 +0000 (11:26 +0000)]
2011-03-12 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix.
Almost all inspector tests are crashing after r80928.
* inspector/front-end/inspector.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Sat, 12 Mar 2011 09:10:38 +0000 (09:10 +0000)]
2011-03-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: follow up to error reporting, fixing multiple regressions.
https://bugs.webkit.org/show_bug.cgi?id=56243
* inspector/elements/elements-panel-search.html:
2011-03-11 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: follow up to error reporting, fixing multiple regressions.
https://bugs.webkit.org/show_bug.cgi?id=56243
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::setPropertyValue):
* inspector/InjectedScript.h:
* inspector/Inspector.idl:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getChildNodes):
(WebCore::InspectorDOMAgent::getOuterHTML):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::setPropertyValue):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.setNodeName):
(WebInspector.DOMNode.prototype.setNodeValue):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMNode.prototype.getOuterHTML):
(WebInspector.DOMNode.prototype.setOuterHTML):
(WebInspector.DOMNode.prototype.removeNode):
(WebInspector.DOMNode.prototype.copyNode):
(WebInspector.DOMAgent.prototype.pushNodeToFrontend):
(WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
(WebInspector.EventListeners.getEventListenersForNode):
* inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorage.prototype.getEntries):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
* inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype.update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
(WebInspector.ElementsTreeElement.prototype.updateChildren):
():
* inspector/front-end/EventListenersSidebarPane.js:
(WebInspector.EventListenersSidebarPane.prototype.update.callback):
(WebInspector.EventListenersSidebarPane.prototype.update):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.applyExpression.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
* inspector/front-end/PropertiesSidebarPane.js:
(WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.evaluate):
* inspector/front-end/inspector.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80931
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Sat, 12 Mar 2011 08:24:53 +0000 (08:24 +0000)]
Unreviewed build fix.
Fix GTK+ builds by wrapping sections of full screen code in USE(ACCELERATED_COMPOSITING)
checks.
* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80930
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 12 Mar 2011 08:07:16 +0000 (08:07 +0000)]
2011-03-12 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed build fix.
[EFL] Fix build break because of several reason.
https://bugs.webkit.org/show_bug.cgi?id=56244
* CMakeLists.txt: Add missing files.
* platform/posix/FileSystemPOSIX.cpp: Add PLATFORM(EFL).
2011-03-12 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed build fix.
[EFL] Fix build break because of several reason.
https://bugs.webkit.org/show_bug.cgi?id=56244
* ewk/ewk_settings.cpp:
(ewk_settings_icon_database_path_set):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Sat, 12 Mar 2011 07:21:34 +0000 (07:21 +0000)]
2011-03-11 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move profiler related methods from inspector agent to profiler agent
https://bugs.webkit.org/show_bug.cgi?id=56204
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::restoreInspectorStateFromCookie):
(WebCore::InspectorAgent::setFrontend):
(WebCore::InspectorAgent::disconnectFrontend):
(WebCore::InspectorAgent::populateScriptObjects):
(WebCore::InspectorAgent::showProfilesPanel):
* inspector/InspectorAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::enableProfiler):
(WebCore::InspectorController::disableProfiler):
(WebCore::InspectorController::profilerEnabled):
(WebCore::InspectorController::startUserInitiatedProfiling):
(WebCore::InspectorController::stopUserInitiatedProfiling):
(WebCore::InspectorController::isRecordingUserInitiatedProfile):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::profilerEnabledImpl):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::create):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::enable):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::setFrontend):
(WebCore::InspectorProfilerAgent::clearFrontend):
(WebCore::InspectorProfilerAgent::restore):
(WebCore::InspectorProfilerAgent::restoreEnablement):
(WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
(WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
* inspector/InspectorProfilerAgent.h:
(WebCore::InspectorProfilerAgent::start):
(WebCore::InspectorProfilerAgent::stop):
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileType.prototype.buttonClicked):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._registerProfileType):
(WebInspector.ProfilesPanel.prototype._toggleProfiling):
* inspector/front-end/inspector.js:
(WebInspector._createPanels):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 12 Mar 2011 05:38:13 +0000 (05:38 +0000)]
2011-03-11 Anton D'Auria <adauria@apple.com>
Reviewed by Brady Eidson.
Adding StorageTracker tests to skip lists of platforms that don't support it.
https://bugs.webkit.org/show_bug.cgi?id=51878
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Sat, 12 Mar 2011 05:28:40 +0000 (05:28 +0000)]
2011-03-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
WebCore::Document should notify ChromeClient when the full screen renderer's backing changes.
https://bugs.webkit.org/show_bug.cgi?id=56226
* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement): Call setRootFullScreenLayer().
(WebCore::Document::webkitDidEnterFullScreenForElement): Ditto.
(WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
(WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
(WebCore::Document::setFullScreenRendererSize): Layout after setting the renderer's size.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Sat, 12 Mar 2011 05:16:36 +0000 (05:16 +0000)]
2011-03-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
Add full screen animation code to WebFullScreenManager.
https://bugs.webkit.org/show_bug.cgi?id=56220
* WebProcess/FullScreen/WebFullScreenManager.cpp: .
(WebKit::WebFullScreenManager::~WebFullScreenManager): Added.
(WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs.
(WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color.
(WebKit::WebFullScreenManager::didEnterFullScreen): Ditto.
(WebKit::WebFullScreenManager::willExitFullScreen): Ditto.
(WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
* WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a
concrete subclass.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added.
(-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations.
(-[WebFullScreenManagerAnimationListener animationDidStart:]): Added.
(-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added.
(-[WebFullScreenManagerAnimationListener invalidate]): Added.
(WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac.
(WebKit::WebFullScreenManagerMac::create): Added.
(WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added.
(WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added.
(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host.
(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D
which will animate the full screen renderer from its initial position to its final one.
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Sat, 12 Mar 2011 04:52:29 +0000 (04:52 +0000)]
2011-03-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
Add full screen animation code to WebFullScreenManager.
https://bugs.webkit.org/show_bug.cgi?id=56220
* WebProcess/FullScreen/WebFullScreenManager.cpp: .
(WebKit::WebFullScreenManager::~WebFullScreenManager): Added.
(WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs.
(WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color.
(WebKit::WebFullScreenManager::didEnterFullScreen): Ditto.
(WebKit::WebFullScreenManager::willExitFullScreen): Ditto.
(WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
* WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a
concrete subclass.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added.
(-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations.
(-[WebFullScreenManagerAnimationListener animationDidStart:]): Added.
(-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added.
(-[WebFullScreenManagerAnimationListener invalidate]): Added.
(WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac.
(WebKit::WebFullScreenManagerMac::create): Added.
(WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added.
(WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added.
(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host.
(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D
which will animate the full screen renderer from its initial position to its final one.
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Sat, 12 Mar 2011 04:19:39 +0000 (04:19 +0000)]
2011-03-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
Add full screen animation code to WebFullScreenManager.
https://bugs.webkit.org/show_bug.cgi?id=56220
* WebProcess/FullScreen/WebFullScreenManager.cpp: .
(WebKit::WebFullScreenManager::~WebFullScreenManager): Added.
(WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs.
(WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color.
(WebKit::WebFullScreenManager::didEnterFullScreen): Ditto.
(WebKit::WebFullScreenManager::willExitFullScreen): Ditto.
(WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
* WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a
concrete subclass.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added.
(-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations.
(-[WebFullScreenManagerAnimationListener animationDidStart:]): Added.
(-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added.
(-[WebFullScreenManagerAnimationListener invalidate]): Added.
(WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac.
(WebKit::WebFullScreenManagerMac::create): Added.
(WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added.
(WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added.
(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host.
(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D
which will animate the full screen renderer from its initial position to its final one.
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Sat, 12 Mar 2011 04:01:56 +0000 (04:01 +0000)]
2011-03-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
WebCore::Document should notify ChromeClient when the full screen renderer's backing changes.
https://bugs.webkit.org/show_bug.cgi?id=56226
* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement): Call setRootFullScreenLayer().
(WebCore::Document::webkitDidEnterFullScreenForElement): Ditto.
(WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
(WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
(WebCore::Document::setFullScreenRendererSize): Layout after setting the renderer's size.
2011-03-11 Jer Noble <jer.noble@apple.com>
Reviewed by Anders Carlsson.
Add full screen animation code to WebFullScreenManager.
https://bugs.webkit.org/show_bug.cgi?id=56220
* WebProcess/FullScreen/WebFullScreenManager.cpp: .
(WebKit::WebFullScreenManager::~WebFullScreenManager): Added.
(WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs.
(WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color.
(WebKit::WebFullScreenManager::didEnterFullScreen): Ditto.
(WebKit::WebFullScreenManager::willExitFullScreen): Ditto.
(WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
* WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a
concrete subclass.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added.
(-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations.
(-[WebFullScreenManagerAnimationListener animationDidStart:]): Added.
(-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added.
(-[WebFullScreenManagerAnimationListener invalidate]): Added.
(WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac.
(WebKit::WebFullScreenManagerMac::create): Added.
(WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added.
(WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added.
(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host.
(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D
which will animate the full screen renderer from its initial position to its final one.
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Sat, 12 Mar 2011 03:35:22 +0000 (03:35 +0000)]
Support encoding /decoding WebData in usermessages
https://bugs.webkit.org/show_bug.cgi?id=56158
Reviewed by Sam Weinig.
Added encoding/decoding for APIObject::TypeData
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Sat, 12 Mar 2011 03:32:33 +0000 (03:32 +0000)]
Add api for "remove" to WKMutableDictionary
https://bugs.webkit.org/show_bug.cgi?id=56157
Reviewed by Sam Weinig.
* Shared/API/c/WKMutableDictionary.cpp:
(WKDictionaryRemoveItem): Added; call remove on MutableDictionary impl.
* Shared/API/c/WKMutableDictionary.h:
* Shared/MutableDictionary.cpp:
(WebKit::MutableDictionary::remove): Added; call remove on the underlying hashmap.
* Shared/MutableDictionary.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 12 Mar 2011 03:12:05 +0000 (03:12 +0000)]
2011-03-11 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Ensure all values are correctly tagged in the registerfile
https://bugs.webkit.org/show_bug.cgi?id=56214
This patch makes sure that all JSCell pointers written to
the registerfile are correctly tagged as JSCells, and replaces
raw int usage with the immediate representation.
For performance, register pressure, and general saneness reasons
I've added abstractions for reading and writing the tag
and payload of integer registers directly for the JSVALUE64
encoding.
* interpreter/Register.h:
(JSC::Register::withInt):
(JSC::Register::withCallee):
(JSC::Register::operator=):
(JSC::Register::i):
(JSC::Register::activation):
(JSC::Register::function):
(JSC::Register::propertyNameIterator):
(JSC::Register::scopeChain):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITInlineMethods.h:
(JSC::JIT::emitPutToCallFrameHeader):
(JSC::JIT::emitPutCellToCallFrameHeader):
(JSC::JIT::emitPutIntToCallFrameHeader):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_load_varargs):
(JSC::JIT::emitSlow_op_load_varargs):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::intPayloadFor):
(JSC::JSInterfaceJIT::intTagFor):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::returnJSValue):
(JSC::SpecializedThunkJIT::returnDouble):
(JSC::SpecializedThunkJIT::returnInt32):
(JSC::SpecializedThunkJIT::returnJSCell):
2011-03-11 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Ensure all values are correctly tagged in the registerfile
https://bugs.webkit.org/show_bug.cgi?id=56214
Make sure everything builds still.
* bridge/c/c_class.cpp:
* bridge/c/c_runtime.cpp:
* bridge/jni/JavaMethod.cpp:
* plugins/PluginViewNone.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 12 Mar 2011 02:38:32 +0000 (02:38 +0000)]
Fix the 32-bit build.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Sat, 12 Mar 2011 02:24:18 +0000 (02:24 +0000)]
2011-03-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80899 and r80912.
http://trac.webkit.org/changeset/80899
http://trac.webkit.org/changeset/80912
https://bugs.webkit.org/show_bug.cgi?id=56236
Caused animation tests to crash on Snow Leopard WebKit2
(Requested by rniwa on #webkit).
* Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::create):
(WebKit::ShareableBitmap::createShareable):
(WebKit::ShareableBitmap::resize):
* Shared/ShareableBitmap.h:
(WebKit::ShareableBitmap::numBytesForSize):
(WebKit::ShareableBitmap::sizeInBytes):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::update):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::didUpdate):
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::~DrawingAreaImpl):
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::didUpdate):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/DrawingAreaImpl.h:
* WebProcess/WebPage/SharedMemoryCache.cpp: Removed.
* WebProcess/WebPage/SharedMemoryCache.h: Removed.
* win/WebKit2.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 12 Mar 2011 02:13:14 +0000 (02:13 +0000)]
<rdar://problem/
9124537> Crashes during layout tests due to overrelease of AVFoundation objects.
Rubber-stamped by Eric Carlsson.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setAsset):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 12 Mar 2011 02:13:09 +0000 (02:13 +0000)]
Adopt the LLVM Compiler for debug builds.
Rubber-stamped by Adam Roben and Sam Weinig.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sat, 12 Mar 2011 01:49:28 +0000 (01:49 +0000)]
Rollout the chromium deps roll as it adds a dependency on a header
that the bots building for WebKit don't seem to have.
Specifically gfx\gl\gl_context_egl.cc depends on d3dcompiler.h
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Sat, 12 Mar 2011 01:46:20 +0000 (01:46 +0000)]
2011-03-11 Chris Marrin <cmarrin@apple.com>
Unreviewed.
Fixes an error with the checkin for https://bugs.webkit.org/show_bug.cgi?id=52468
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Sat, 12 Mar 2011 01:45:41 +0000 (01:45 +0000)]
Windows build fix. Add SharedMemoryCache to the vcproj.
* win/WebKit2.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sat, 12 Mar 2011 01:41:04 +0000 (01:41 +0000)]
Fix prototype-inheritance-expected result due to two changes:
http://src.chromium.org/viewvc/chrome?view=rev&revision=77888 removed "google"
http://trac.webkit.org/changeset/80846 added WebKitAnimation/WebKitAnimationList
* platform/chromium/fast/dom/prototype-inheritance-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 12 Mar 2011 01:35:56 +0000 (01:35 +0000)]
Attempted Qt build fix for https://bugs.webkit.org/show_bug.cgi?id=56216
* loader/icon/IconDatabase.h: Make this guy public.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 12 Mar 2011 01:23:43 +0000 (01:23 +0000)]
Attempted Qt build fix for https://bugs.webkit.org/show_bug.cgi?id=56216
* loader/icon/IconDatabase.h:
(WebCore::IconDatabase::delayDatabaseCleanup): Maybe Qt has Icon Database disabled, so we need to define this here?
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 12 Mar 2011 01:21:30 +0000 (01:21 +0000)]
More Windows build fix for https://bugs.webkit.org/show_bug.cgi?id=56216
* WebCoreStatistics.cpp:
* WebIconDatabase.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dcheng@chromium.org [Sat, 12 Mar 2011 01:07:40 +0000 (01:07 +0000)]
2011-03-11 Daniel Cheng <dcheng@chromium.org>
Reviewed by Tony Chang.
[chromium] Correct return type of WebClipboard::readImage.
https://bugs.webkit.org/show_bug.cgi?id=56234
Update the return type to reflect that we are returning a blob of PNG
data, not a bitmap.
* public/WebClipboard.h:
(WebKit::WebClipboard::readImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Sat, 12 Mar 2011 01:05:44 +0000 (01:05 +0000)]
2011-03-11 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
Introduce project_dir variable and make paths a whole lot saner. Ok, a little bit saner.
https://bugs.webkit.org/show_bug.cgi?id=56231
* JavaScriptCore.gypi: Added project_dir variable.
* gyp/JavaScriptCore.gyp: Changed to use project_dir, rather than DEPTH/JavaScriptCore.
* gyp/generate-dtrace-header.sh: Changed to use project_dir.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 12 Mar 2011 00:45:12 +0000 (00:45 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=56216
Fix the Qt build following the same pattern of the patch.
../WebCore:
* loader/icon/IconDatabase.h:
* loader/icon/IconDatabaseBase.cpp:
(WebCore::IconDatabaseBase::databasePath): Added to the virtual base.
* loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::isOpen): Ditto.
../WebKit/qt:
Reviewed by attempt at build fix!
* Api/qwebsettings.cpp:
(QWebSettings::setIconDatabasePath): Call the static method via IconDatabase:: and not via iconDatabase()
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sat, 12 Mar 2011 00:39:09 +0000 (00:39 +0000)]
Source/WebKit/chromium: Update chromium deps to pick up the skia roll.
* DEPS:
LayoutTests: Update some baselines due to Skia update in Chromium.
Filed http://crbug.com/75820 about the odd look of the results (but
the odd look previously existed).
* platform/chromium-linux/svg/css/composite-shadow-text-expected.checksum:
* platform/chromium-linux/svg/css/composite-shadow-text-expected.png:
* platform/chromium-win/svg/css/composite-shadow-text-expected.checksum:
* platform/chromium-win/svg/css/composite-shadow-text-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80904
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 12 Mar 2011 00:34:00 +0000 (00:34 +0000)]
2011-03-11 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=56198
Fix conditional which had an int for one case and a pointer for another.
No new tests. Fix compilation on Solaris 10 with SunStudio 12 C++
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 12 Mar 2011 00:29:14 +0000 (00:29 +0000)]
Windows build fix.
* history/HistoryItem.cpp:
* loader/icon/IconDatabaseBase.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Sat, 12 Mar 2011 00:25:22 +0000 (00:25 +0000)]
2011-03-11 Alexey Proskuryakov <ap@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=56222
A window remains frozen if web process crashes during printing
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setComplexTextInputEnabled):
* UIProcess/WebPageProxy.h:
Moved setAutodisplay code into WKPrintingView.
* UIProcess/API/mac/WKPrintingView.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView printOperationWithPrintInfo:forFrame:]):
Keep a reference to the actual WKView, so that we can manipulate how it displays, even if
page goes away.
* UIProcess/API/mac/WKPrintingView.mm:
(-[WKPrintingView initWithFrameProxy:WebKit::view:]):
(-[WKPrintingView _setAutodisplay:]):
(-[WKPrintingView _suspendAutodisplay]):
(-[WKPrintingView _delayedResumeAutodisplayTimerFired]):
Move setAutodisplay here.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80901
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 12 Mar 2011 00:17:32 +0000 (00:17 +0000)]
<rdar://problem/
8648311> and https://bugs.webkit.org/show_bug.cgi?id=56216
Rework disabled IconDatabase builds while allowing for a pluggable icon database implementation.
../WebCore:
Reviewed by Sam Weinig.
Project file stuff:
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* WebCore.vcproj/WebCore.vcproj:
* loader/icon/IconDatabase.cpp:
* loader/icon/IconDatabase.h: Inherit from IconDatabaseBase.
* loader/icon/IconDatabaseBase.cpp: Added.
(WebCore::IconDatabaseBase::iconURLForPageURL):
(WebCore::iconDatabase):
(WebCore::setGlobalIconDatabase):
* loader/icon/IconDatabaseBase.h: Added.
(WebCore::IconDatabaseBase::IconDatabaseBase):
(WebCore::IconDatabaseBase::~IconDatabaseBase):
(WebCore::IconDatabaseBase::setEnabled):
(WebCore::IconDatabaseBase::isEnabled):
(WebCore::IconDatabaseBase::defaultIcon):
(WebCore::IconDatabaseBase::retainIconForPageURL):
(WebCore::IconDatabaseBase::releaseIconForPageURL):
(WebCore::IconDatabaseBase::iconForPageURL):
(WebCore::IconDatabaseBase::setIconURLForPageURL):
(WebCore::IconDatabaseBase::setIconDataForIconURL):
(WebCore::IconDatabaseBase::iconDataKnownForIconURL):
(WebCore::IconDatabaseBase::loadDecisionForIconURL):
(WebCore::IconDatabaseBase::pageURLMappingCount):
(WebCore::IconDatabaseBase::retainedPageURLCount):
(WebCore::IconDatabaseBase::iconRecordCount):
(WebCore::IconDatabaseBase::iconRecordCountWithData):
(WebCore::IconDatabaseBase::importIconURLForPageURL):
(WebCore::IconDatabaseBase::importIconDataForIconURL):
(WebCore::IconDatabaseBase::shouldStopThreadActivity):
(WebCore::IconDatabaseBase::open):
(WebCore::IconDatabaseBase::close):
(WebCore::IconDatabaseBase::removeAllIcons):
(WebCore::IconDatabaseBase::setPrivateBrowsingEnabled):
(WebCore::IconDatabaseBase::setClient):
* loader/icon/IconDatabaseNone.cpp: Removed.
../WebKit/mac:
Reviewed by Anders Carlsson
* Misc/WebIconDatabase.mm:
(+[WebIconDatabase _checkIntegrityBeforeOpening]): Call these static methods on IconDatabase::, not iconDatabase().
(-[WebIconDatabase _startUpIconDatabase]): Ditto.
(importToWebCoreFormat):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 12 Mar 2011 00:12:27 +0000 (00:12 +0000)]
2011-03-11 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add a shared memory cache to the web process
https://bugs.webkit.org/show_bug.cgi?id=56232
Add a very simple shared memory cache to the web process, so that we don't have to allocate and
free memory over and over when painting.
* Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::create):
(WebKit::ShareableBitmap::createShareable):
(WebKit::ShareableBitmap::resize):
* Shared/ShareableBitmap.h:
(WebKit::ShareableBitmap::numBytesNeededForBitmapSize):
(WebKit::ShareableBitmap::sizeInBytes):
Rename numBytesForSize to numBytesNeededForBitmapSize.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::update):
Always send back a DidUpdate message, even if we didn't use the update info.
This is needed so that the web process knows when the UI process is done with the shared memory inside
the update info struct.
* WebKit2.xcodeproj/project.pbxproj:
Add new files.
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::didUpdate):
* WebProcess/WebPage/DrawingArea.messages.in:
DidUpdate now takes a boolean.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::sharedMemoryCache):
Add shared memory cache.
(WebKit::DrawingAreaImpl::~DrawingAreaImpl):
Return the shared memory to the cache.
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
display now takes an extra boolean.
(WebKit::DrawingAreaImpl::didUpdate):
Return the shared memory to the cache.
(WebKit::DrawingAreaImpl::display):
If useSharedMemoryCache is true, get shared memory from the cache.
* WebProcess/WebPage/SharedMemoryCache.cpp: Added.
(WebKit::SharedMemoryCache::acquireSharedMemory):
If the memory we currently hold on to is big enough, return it.
(WebKit::SharedMemoryCache::releaseSharedMemory):
If we're already holding on to shared memory, evict it if the returned
shared memory object is bigger than the one we currently hold.
(WebKit::SharedMemoryCache::clearCacheTimerFired):
Null out the shared memory object.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Sat, 12 Mar 2011 00:07:08 +0000 (00:07 +0000)]
Attempt at a build-fix for https://bugs.webkit.org/show_bug.cgi?id=51878
* page/PageGroup.h: Declare this method, even if the definition will end up being empty.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
michaeln@google.com [Fri, 11 Mar 2011 23:57:05 +0000 (23:57 +0000)]
2011-03-11 Michael Nordman <michaeln@google.com>
Reviewed by Dmitry Titov.
Adding the '~' to the dtor (duh).
No new tests.
* storage/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::~SQLCallbackWrapper):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ericu@chromium.org [Fri, 11 Mar 2011 23:44:26 +0000 (23:44 +0000)]
2010-3-11 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Add tests for FileWriter
https://bugs.webkit.org/show_bug.cgi?id=44363
Fix small bugs in the utility functions and add setFileContents().
* fast/filesystem/resources/file-writer-utils.js:
Port the GC Blob test over to the new FileWriter utilities.
* fast/filesystem/file-writer-gc-blob-expected.txt:
* fast/filesystem/file-writer-gc-blob.html:
* fast/filesystem/resources/file-writer-gc-blob.js: Copied from LayoutTests/fast/filesystem/file-writer-gc-blob.html.
Add tests for progress events and overlapping writes [via seek].
* fast/filesystem/file-writer-events-expected.txt: Added.
* fast/filesystem/file-writer-events.html: Added.
* fast/filesystem/resources/file-writer-events.js: Added.
* fast/filesystem/file-writer-write-overlapped-expected.txt: Added.
* fast/filesystem/file-writer-write-overlapped.html: Added.
* fast/filesystem/resources/file-writer-write-overlapped.js: Added.
Worker versions of the above tests.
* fast/filesystem/workers/file-writer-events-expected.txt: Added.
* fast/filesystem/workers/file-writer-events.html: Added.
* fast/filesystem/workers/file-writer-gc-blob-expected.html: Added.
* fast/filesystem/workers/file-writer-gc-blob.html: Added.
* fast/filesystem/workers/file-writer-write-overlapped-expected.html: Added.
* fast/filesystem/workers/file-writer-write-overlapped.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carol.szabo@nokia.com [Fri, 11 Mar 2011 23:41:23 +0000 (23:41 +0000)]
2011-03-11 Carol Szabo <carol.szabo@nokia.com>
Reviewed by David Hyatt.
Introduced double linkage between a CounterNode and its display renderer.
use of freed pointer in WebCore::RenderCounter::originalText()
https://bugs.webkit.org/show_bug.cgi?id=56065
No new tests. This bug could only be reproduced manually by
refreshing the page during load at a critical point.
See bug attachment for testing.
* rendering/CounterNode.cpp:
Introduced new member "m_owner" to store the renderer that has the
style directives that produce the CounterNode.
Repurposed m_renderer to reffer to the RenderCounter that shows the
CounterNode.
(WebCore::CounterNode::CounterNode):
Updated member initialization.
(WebCore::CounterNode::create):
(WebCore::CounterNode::resetRenderer):
(WebCore::CounterNode::resetRenderers):
(WebCore::CounterNode::recount):
(WebCore::CounterNode::removeChild):
(WebCore::CounterNode::insertAfter):
No functional changes.
(WebCore::showTreeAndMark):
Added flushing to ensure that the output is complete.
* rendering/CounterNode.h:
(WebCore::CounterNode::owner):
Renamed from renderer()
(WebCore::CounterNode::renderer):
(WebCore::CounterNode::setRenderer):
Added new accessors for the display renderer.
* rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):
Fixed comments. No functional changes.
(WebCore::RenderCounter::~RenderCounter):
Made sure that the CounterNode that this renderers displays is
detached from this.
(WebCore::RenderCounter::originalText):
(WebCore::RenderCounter::invalidate):
Added code to update m_renderer on the displayed CounterNode.
(WebCore::destroyCounterNodeWithoutMapRemoval):
(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::updateCounters):
No change, just kept code in line with the changes above.
(showCounterRendererTree):
Added fflush to ensure complete display.
* rendering/RenderCounter.h:
* rendering/RenderObjectChildList.cpp:
* rendering/RenderObjectChildList.h:
Removed unneeded invalidateCounters related functions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Fri, 11 Mar 2011 23:39:14 +0000 (23:39 +0000)]
2011-03-11 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Add missing unit tests to TilingData.
https://bugs.webkit.org/show_bug.cgi?id=54143
* tests/TilingDataTest.cpp:
(WebCore::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 11 Mar 2011 23:34:26 +0000 (23:34 +0000)]
2011-03-11 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Introduce lookup-table based approach for applying CSS properties.
The aim is to be a starting point for refactoring
CSSStyleSelector::applyProperty() into more readable, maintainable code.
https://bugs.webkit.org/show_bug.cgi?id=54707
No new behavior / covered by existing tests.
* css/CSSStyleApplyProperty.cpp: Added.
(WebCore::ApplyPropertyNull):
Class that provides empty implementations of inherit, initial, value.
(WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
Class that calls the appropriate RenderStyle setters directly.
(WebCore::ApplyPropertyColorBase::ApplyPropertyColorBase):
Class for handling CSSProperty*Color.
(WebCore::ApplyPropertyColor::ApplyPropertyColor):
Class for handling CSSPropertyColor.
(WebCore::CSSStyleApplyProperty::sharedCSSStyleApplyProperty):
Singleton initializer.
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Constructor that bulds up the map from property id to apply-er objects.
* css/CSSStyleApplyProperty.h: Added.
(WebCore::CSSStyleApplyProperty::inherit):
Handle the inherit case for a given property.
(WebCore::CSSStyleApplyProperty::initial):
Handle the initial case for a given property.
(WebCore::CSSStyleApplyProperty::value):
Apply a value to a given property.
(WebCore::CSSStyleApplyProperty::implements):
Returns true if the provided property id is implemented.
(WebCore::CSSStyleApplyProperty::index):
Private function to determine the index of a property the property map.
(WebCore::CSSStyleApplyProperty::valid):
Function to determine that a given property id is valid.
(WebCore::CSSStyleApplyProperty::setPropertyValue):
(WebCore::CSSStyleApplyProperty::propertyValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
Get reference to the CSSStyleApplyProperty singleton.
(WebCore::CSSStyleSelector::applyProperty):
Now calls into CSSStyleApplyProperty for implemented property ids.
Deleted color-related methods from the property id switch.
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::style):
Made public to allow access from CSSStyleApplyProperty.
(WebCore::CSSStyleSelector::parentStyle):
Made public to allow access from CSSStyleApplyProperty.
* rendering/style/RenderStyle.h:
Made CSSStyleApplyProperty a friend class. Necessary because it needs
to access the private getters and setters on this clsass.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 11 Mar 2011 23:24:54 +0000 (23:24 +0000)]
Reviewed and landed by Brady Eidson.
Source/WebCore:
Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878
Created StorageTracker as a central point for tracking and deleting LocalStorage per origin.
StorageTracker maintains its own database of origin identifiers and backing db paths,
and this allows it to contain more relational data in the future, like variable quotas per origin.
On initialization, StorageTracker syncs its database with LocalStorage files on disk. It adds
an origin entry when StorageAreaSync performs a first sync for an origin.
All StorageTracker file operations are performed on one background thread with a task queue.
Tests: storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html
storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html
storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html
storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html
storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html
* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* page/PageGroup.cpp:
(WebCore::PageGroup::clearLocalStorageForAllOrigins):
(WebCore::PageGroup::clearLocalStorageForOrigin):
(WebCore::PageGroup::syncLocalStorage):
(WebCore::PageGroup::numberOfPageGroups):
* page/PageGroup.h:
* platform/chromium/FileSystemChromium.cpp:
(WebCore::listDirectory):
* platform/posix/FileSystemPOSIX.cpp:
(WebCore::listDirectory):
* storage/LocalStorageTask.cpp:
(WebCore::LocalStorageTask::LocalStorageTask):
(WebCore::LocalStorageTask::performTask):
* storage/LocalStorageTask.h:
(WebCore::LocalStorageTask::createOriginIdentifiersImport):
(WebCore::LocalStorageTask::createSetOriginDetails):
(WebCore::LocalStorageTask::createDeleteOrigin):
(WebCore::LocalStorageTask::createDeleteAllOrigins):
* storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::clearForOriginDeletion):
(WebCore::StorageAreaImpl::sync):
* storage/StorageAreaImpl.h:
* storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::scheduleCloseDatabase):
(WebCore::StorageAreaSync::openDatabase):
(WebCore::StorageAreaSync::sync):
(WebCore::StorageAreaSync::deleteEmptyDatabase):
(WebCore::StorageAreaSync::scheduleSync):
* storage/StorageAreaSync.h:
* storage/StorageNamespace.h:
* storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::clearOriginForDeletion):
(WebCore::StorageNamespaceImpl::clearAllOriginsForDeletion):
(WebCore::StorageNamespaceImpl::sync):
* storage/StorageNamespaceImpl.h:
* storage/StorageTracker.cpp: Added.
(WebCore::StorageTracker::initializeTracker):
(WebCore::StorageTracker::tracker):
(WebCore::StorageTracker::StorageTracker):
(WebCore::StorageTracker::setStorageDirectoryPath):
(WebCore::StorageTracker::trackerDatabasePath):
(WebCore::StorageTracker::openTrackerDatabase):
(WebCore::StorageTracker::importOriginIdentifiers):
(WebCore::StorageTracker::syncImportOriginIdentifiers):
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::scheduleTask):
(WebCore::StorageTracker::syncSetOriginDetails):
(WebCore::StorageTracker::origins):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::syncDeleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):
(WebCore::StorageTracker::syncDeleteOrigin):
(WebCore::StorageTracker::willDeleteAllOrigins):
(WebCore::StorageTracker::willDeleteOrigin):
(WebCore::StorageTracker::canDeleteOrigin):
(WebCore::StorageTracker::cancelDeletingOrigin):
(WebCore::StorageTracker::setClient):
(WebCore::StorageTracker::syncLocalStorage):
* storage/StorageTracker.h: Added.
* storage/StorageTrackerClient.h: Added.
(WebCore::StorageTrackerClient::~StorageTrackerClient):
Source/WebKit:
Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878
* WebKit.xcodeproj/project.pbxproj:
Source/WebKit/chromium:
Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878
* src/StorageNamespaceProxy.cpp:
(WebCore::StorageNamespaceProxy::clearOriginForDeletion):
(WebCore::StorageNamespaceProxy::clearAllOriginsForDeletion):
(WebCore::StorageNamespaceProxy::sync):
* src/StorageNamespaceProxy.h:
Source/WebKit/mac:
Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
https://bugs.webkit.org/show_bug.cgi?id=51878
Add WebKit1 API to view and delete local storage
* Storage/WebStorageManager.mm: Added.
(+[WebStorageManager sharedWebStorageManager]):
(-[WebStorageManager origins]):
(-[WebStorageManager deleteAllOrigins]):
(-[WebStorageManager deleteOrigin:]):
(-[WebStorageManager syncLocalStorage]):
(-[WebStorageManager syncFileSystemAndTrackerDatabase]):
(storageDirectoryPath):
(WebKitInitializeStorageIfNecessary):
* Storage/WebStorageManagerInternal.h: Added.
* Storage/WebStorageManagerPrivate.h: Added.
* Storage/WebStorageTrackerClient.h: Added.
* Storage/WebStorageTrackerClient.mm: Added.
(WebStorageTrackerClient::sharedWebStorageTrackerClient):
(WebStorageTrackerClient::WebStorageTrackerClient):
(WebStorageTrackerClient::~WebStorageTrackerClient):
(WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread):
(WebStorageTrackerClient::dispatchDidModifyOrigin):
* WebCoreSupport/WebSecurityOrigin.mm:
(-[WebSecurityOrigin protocol]):
(-[WebSecurityOrigin host]):
(-[WebSecurityOrigin databaseIdentifier]):
(-[WebSecurityOrigin domain]):
(-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
* WebCoreSupport/WebSecurityOriginPrivate.h:
* WebKit.exp:
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
Tools:
Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
https://bugs.webkit.org/show_bug.cgi?id=51878
Add WebKit1 API to view and delete local storage
Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/LayoutTestController.cpp:
(syncLocalStorageCallback):
(observeStorageTrackerNotificationsCallback):
(deleteAllLocalStorageCallback):
(deleteLocalStorageForOriginCallback):
(originsWithLocalStorageCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/StorageTrackerDelegate.h: Added.
* DumpRenderTree/StorageTrackerDelegate.mm: Added.
(-[StorageTrackerDelegate init]):
(-[StorageTrackerDelegate logNotifications:controller:]):
(-[StorageTrackerDelegate originModified:]):
(-[StorageTrackerDelegate dealloc]):
(-[StorageTrackerDelegate setControllerToNotifyDone:]):
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
(observeStorageTrackerNotifications):
(syncLocalStorage):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::syncLocalStorage):
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
(allocateGlobalControllers):
(releaseGlobalControllers):
* DumpRenderTree/mac/DumpRenderTreeMac.h:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::syncLocalStorage):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::syncLocalStorage):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::clearAllApplicationCaches):
(LayoutTestController::syncLocalStorage):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::clearAllDatabases):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::syncLocalStorage):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::clearAllDatabases):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
LayoutTests:
Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878
* platform/chromium/test_expectations.txt:
* storage/domstorage/localstorage/storagetracker: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare-expected.txt: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-2-create-expected.txt: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all-expected.txt: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-4-create-expected.txt: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one-expected.txt: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Fri, 11 Mar 2011 23:19:00 +0000 (23:19 +0000)]
http/tests/websocket/tests/url-with-credential.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows
https://bugs.webkit.org/show_bug.cgi?id=56185
url-parsing.html appears to be causing the crashes in later tests.
Skipping the url-parsing.html test and unskipping the url-with-credential.html test.
Unreviewed.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 11 Mar 2011 23:15:51 +0000 (23:15 +0000)]
2011-03-11 Dominic Mazzoni <dmazzoni@google.com>
Reviewed by Dimitri Glazkov.
Add an accessibilityIsIgnored method to WebAccessibilityObject.
https://bugs.webkit.org/show_bug.cgi?id=50969
* public/WebAccessibilityObject.h:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::accessibilityIsIgnored):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc