WebKit-https.git
12 years ago.: Add WebKit2 to the lists of modules to build.
weinig@apple.com [Wed, 28 Apr 2010 23:58:33 +0000 (23:58 +0000)]
.: Add WebKit2 to the lists of modules to build.

Reviewed by Mark Rowe.

* Makefile:

WebKit2: Only build on SnowLeopard and later when using the Makefile.

Reviewed by Mark Rowe.

* Makefile:

WebKitTools: Add MiniBrowser to the lists of modules to build and only build it on
SnowLeopard and later.

Reviewed by Mark Rowe.

* Makefile:
* MiniBrowser/Makefile:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd canAuthenticateAgainstProtectionSpace() to frame loader so that a protection...
mthole@apple.com [Wed, 28 Apr 2010 23:16:41 +0000 (23:16 +0000)]
Add canAuthenticateAgainstProtectionSpace() to frame loader so that a protection space
can be inspected before attempting to authenticate against it
https://bugs.webkit.org/show_bug.cgi?id=38271

Reviewed by David Kilzer.

JavaScriptCore:

* wtf/Platform.h: Add WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK define.

WebCore:

* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::canAuthenticateAgainstProtectionSpace): Added.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::canAuthenticateAgainstProtectionSpace): Added.
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace): Added.
* loader/ResourceLoader.h:
(WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace): Added.
* platform/network/ProtectionSpace.h:
(WebCore::):
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::canAuthenticateAgainstProtectionSpace): Added.
* platform/network/mac/AuthenticationMac.mm:
(WebCore::mac):
Add cases for case ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested and
ProtectionSpaceAuthenticationSchemeClientCertificateRequested.  Guarded with the
#if USE(PROTECTION_SPACE_AUTH_CALLBACK) as the new NSURLProtectionSpace constants don't
exist prior to Mac OS X 10.6.
(WebCore::core): Ditto.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace): Added.
(-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): Added.

WebKit/mac:

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace):
Added.  If the resource load delegate implements the callback, use its answer.  If it does
not, then only send authentication challenges for pre-10.6 protection spaces, which matches
CFNetwork's default behavior.
* WebView/WebDelegateImplementationCaching.h:
* WebView/WebDelegateImplementationCaching.mm:
(CallResourceLoadDelegateReturningBoolean): Added case for passing three objects.
* WebView/WebResourceLoadDelegatePrivate.h:
Added private SPI definition: webView:resource:canAuthenticateAgainstProtectionSpace:forDataSource:
* WebView/WebView.mm:
(-[WebView _cacheResourceLoadDelegateImplementations]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Abhishek Arya <inferno@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 22:48:23 +0000 (22:48 +0000)]
2010-04-28  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Seidel.

        Tests for a crash when an image drag-drop operation happens inside a continuously refreshing iframe.
        https://bugs.webkit.org/show_bug.cgi?id=37618

        * editing/pasteboard/drag-drop-iframe-refresh-crash-expected.txt: Added.
        * editing/pasteboard/drag-drop-iframe-refresh-crash.html: Added.
        * editing/resources/drag-drop.html: Added.
2010-04-28  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Seidel.

        Convert m_documentUnderMouse, m_dragInitiator to RefPtr.
        Eliminated unused m_dragInitiator accessor to prevent dereferencing.
        https://bugs.webkit.org/show_bug.cgi?id=37618

        Test: editing/pasteboard/drag-drop-iframe-refresh-crash.html

        * page/DragController.cpp:
        (WebCore::DragController::tryDocumentDrag):
        (WebCore::DragController::concludeEditDrag):
        * page/DragController.h:
        (WebCore::DragController::draggingImageURL):
        (WebCore::DragController::documentUnderMouse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, fixing a build problem introduced by the previous patch.
dumi@chromium.org [Wed, 28 Apr 2010 22:33:15 +0000 (22:33 +0000)]
Unreviewed, fixing a build problem introduced by the previous patch.

* storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::openDatabaseSync):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Adam Langley <agl@chromium.org>
agl@chromium.org [Wed, 28 Apr 2010 22:28:25 +0000 (22:28 +0000)]
2010-04-28  Adam Langley  <agl@chromium.org>

        Unreviewed, expectations update.

        These results are no longer specific to chromium-win. I believe that
        they should have been deleted in r58182, but I didn't notice the
        deletions, only the modified files.

        * platform/chromium-win/fast/canvas/canvas-empty-image-pattern-expected.checksum: Removed.
        * platform/chromium-win/fast/canvas/canvas-empty-image-pattern-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake running MiniBrowser.app without explicitly setting DYLD_FRAMEWORK_PATH.
weinig@apple.com [Wed, 28 Apr 2010 22:17:48 +0000 (22:17 +0000)]
Make running MiniBrowser.app without explicitly setting DYLD_FRAMEWORK_PATH.

Reviewed by Mark Rowe.

* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
* MiniBrowser/mac/make-launchable.sh: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdding some required classes for the sync WebSQLDatabases API.
dumi@chromium.org [Wed, 28 Apr 2010 22:17:23 +0000 (22:17 +0000)]
Adding some required classes for the sync WebSQLDatabases API.
https://bugs.webkit.org/show_bug.cgi?id=34994

Reviewed by Jeremy Orlow.

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* storage/DatabaseSync.cpp: Added.
(WebCore::DatabaseSync::databaseInfoTableName):
(WebCore::DatabaseSync::setIsAvailable):
(WebCore::DatabaseSync::isAvailable):
(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::DatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::version):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::transaction):
* storage/DatabaseSync.h: Added.
(WebCore::DatabaseSync::databaseDebugName):
* storage/SQLTransactionSync.cpp: Added.
(WebCore::SQLTransactionSync::create):
(WebCore::SQLTransactionSync::SQLTransactionSync):
(WebCore::SQLTransactionSync::~SQLTransactionSync):
(WebCore::SQLTransactionSync::executeSQL):
* storage/SQLTransactionSync.h: Added.
(WebCore::SQLTransactionSync::database):
(WebCore::SQLTransactionSync::isReadOnly):
* storage/SQLTransactionSyncCallback.h: Added.
(WebCore::SQLTransactionSyncCallback::~SQLTransactionSyncCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 İsmail Dönmez <ismail@namtrac.org>
eric@webkit.org [Wed, 28 Apr 2010 22:05:32 +0000 (22:05 +0000)]
2010-04-28  İsmail Dönmez  <ismail@namtrac.org>

        Reviewed by Simon Hausmann.

        Fix compilation with QT_NO_CURSOR defined.

        * platform/qt/QWebPageClient.h:
        (QWebPageClient::resetCursor):
        (QWebPageClient::setCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 28 Apr 2010 21:53:53 +0000 (21:53 +0000)]
2010-04-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by David Levin.

        fix linux expected result for fast/text/line-breaks.html
        https://bugs.webkit.org/show_bug.cgi?id=38283

        This is needed after r58426. See http://trac.webkit.org/changeset/57242
        for more details.

        * platform/chromium-linux/fast/text/line-breaks-expected.checksum:
        * platform/chromium-linux/fast/text/line-breaks-expected.png:
        * platform/chromium-linux/fast/text/line-breaks-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 28 Apr 2010 21:51:34 +0000 (21:51 +0000)]
2010-04-28  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        Audit all uses of subprocess in webkitpy
        https://bugs.webkit.org/show_bug.cgi?id=38284

        After further discussions with Jeffrey Yasskin
        about http://bugs.python.org/issue2320
        and related issues of using subprocess from
        multiple threads, I have learned that subprocess
        is known to be non-threadsafe through recent
        Python 2.7 builds.

        I'm attempting to lessen our exposure to these
        subprocess bugs by auditing each use of subprocess
        in webkitpy.  I did not find any unsafe calls
        in my audit, but I did remove numerous unneeded
        import subprocess lines.

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/net/bugzilla.py:
        * Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
        * Scripts/webkitpy/common/system/user.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Added.
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/gtk.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/qt.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/win.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Alexey Proskuryakov.
ap@apple.com [Wed, 28 Apr 2010 21:42:18 +0000 (21:42 +0000)]
    Reviewed by Alexey Proskuryakov.

        Added a check to make sure that resources from a different https origin are not cached.
        https://bugs.webkit.org/show_bug.cgi?id=33456

        Test: http/tests/appcache/different-https-origin-resource-main.html

        * loader/appcache/ManifestParser.cpp:
        (WebCore::parseManifest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 28 Apr 2010 21:23:19 +0000 (21:23 +0000)]
2010-04-28  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/7918719> ASSERT(isMainThread()) from Font::setShouldUseSmoothing()

        Ensure that the WebView +initialize method initializes threading, so that things are correctly
        initialized when the first call into the WebKit framework is via a WebView class method.

        * WebView/WebView.mm:
        (+[WebView initialize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoOnly set -allowable_client WebKit2 for engineering builds on SnowLeopard
weinig@apple.com [Wed, 28 Apr 2010 21:19:58 +0000 (21:19 +0000)]
Only set -allowable_client WebKit2 for engineering builds on SnowLeopard
and later.

Reviewed by Mark Rowe.

* Configurations/WebCore.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Evan Martin <evan@chromium.org>
evan@chromium.org [Wed, 28 Apr 2010 21:04:24 +0000 (21:04 +0000)]
2010-04-28  Evan Martin  <evan@chromium.org>

        Reviewed by Adam Roben.

        rebaseline for fast/text/international/bold-bengali
        https://bugs.webkit.org/show_bug.cgi?id=38281

        * platform/win/fast/text/international/bold-bengali-actual.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDon't use CFAbsoluteTimeGetCurrent on Mac OS X, since it's just a cover
darin@apple.com [Wed, 28 Apr 2010 21:02:13 +0000 (21:02 +0000)]
Don't use CFAbsoluteTimeGetCurrent on Mac OS X, since it's just a cover
for gettimeofday anyway.

Reviewed by Sam Weinig.

* wtf/CurrentTime.cpp:
(WTF::currentTime): Remove the CF version of this. Change the "other POSIX"
version to pass 0 for the time zone instead of ignoring a return value.
Also get rid of unneeded type casts, since operations involving both
integers and doubles are always evaluated as doubles in C without explicit
type casting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 28 Apr 2010 20:57:02 +0000 (20:57 +0000)]
2010-04-28  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        REGRESSION: Autoscroll does not work in Mail messages
        https://bugs.webkit.org/show_bug.cgi?id=38267
        rdar://problem/7559799

        The machinery to make autoscrolling work on Mac OS X when a WebView is embedded in another
        view had gotten broken in multiple ways. For some reason, a combination of bugs made it
        partly work until around r48064. This brings it back.

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::scrollRectIntoView): When converting coordinates, use the document view
        rather than the WebView itself. This logic may not be correct for the case where
        usesDocumentViews is NO, but that is currently an experimental mode and can be fixed later.
2010-04-28  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        REGRESSION: Autoscroll does not work in Mail messages
        https://bugs.webkit.org/show_bug.cgi?id=38267
        rdar://problem/7559799

        Still haven't figured out a good way to test this with DumpRenderTree
        or with Safari. Testing has to be done with Mail for now.

        The machinery to make autoscrolling work on Mac OS X when a WebView is embedded in another
        view had gotten broken in multiple ways. For some reason, a combination of bugs made it
        partly work until around r48064. This brings it back.

        There were three problems:

            1) Code in EventHandler decided there was nothing to scroll, so didn't start
               the autoscroll timer.
            2) The wrong rectangle was passed to Chrome::scrollRectIntoView.
            3) The Mac WebKit implementation of ChromeClient::scrollRectIntoView did incorrect
               coordinate conversion.

        I verified that none of these have any effect on regression tests, or behavior in
        web browsers, or behavior on platforms other than Mac.

        * page/EventHandler.cpp:
        (WebCore::canAutoscroll): Added. Returns true for boxes that can scroll directly
        and for the top level box of the top frame.
        (WebCore::EventHandler::handleMouseDraggedEvent): Use canAutoscroll.
        (WebCore::EventHandler::updateAutoscrollRenderer): Ditto.

        * page/FrameView.cpp:
        (WebCore::FrameView::scrollToAnchor): Fixed comment.

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::scrollRectIntoViewRecursively): Put ASSERT_NOT_REACHED into this
        now-unused function along with some comments about removing some obsolete code.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollRectToVisible): Removed call to scrollRectIntoViewRecursively
        since from the WebKit point of view this is the topmost scroll view anyway. Instead call
        setScrollPosition. Moved the code to call Chrome::scrollRectIntoView here since it needs
        to use a different rectangle anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] tst_QWebHistoryInterface::visitedLinks() fails
tonikitoo@webkit.org [Wed, 28 Apr 2010 20:50:23 +0000 (20:50 +0000)]
[Qt] tst_QWebHistoryInterface::visitedLinks() fails
https://bugs.webkit.org/show_bug.cgi?id=37323

Patch by Antonio Gomes  <tonikitoo@webkit.org>, Yi Shen <yi.4.shen@nokia.com> on 2010-04-28
Reviewed by NOBODY Simon Hausmann.

Patch fixes styleProperty method of QWebElement to make use of
CSSComputedStyleDeclaration::computedStyle 'allowVisitedStyle' parameter
and the corresponding failing QWebHistoryInterface::visitedLinks method.

* Api/qwebelement.cpp:
(QWebElement::styleProperty):
* tests/qwebhistoryinterface/tst_qwebhistoryinterface.cpp:
(tst_QWebHistoryInterface::visitedLinks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-21 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 28 Apr 2010 20:50:17 +0000 (20:50 +0000)]
2010-04-21  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adele Peterson.

        http://trac.webkit.org/changeset/57215 caused perf/memory regressions
        https://bugs.webkit.org/show_bug.cgi?id=37292

        #if out the canUseGlyphCache Changes from r57215 as they caused a
        8% perf regression on Chromium's international page load tests so that
        the perf regression can be fixed properly without being left in the tree.

        * platform/mac/fast/repaint/stacked-diacritics-expected.checksum:
        * platform/mac/fast/repaint/stacked-diacritics-expected.png:
2010-04-21  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adele Peterson.

        http://trac.webkit.org/changeset/57215 caused perf/memory regressions
        https://bugs.webkit.org/show_bug.cgi?id=37292

        #if out the canUseGlyphCache Changes from r57215 as they caused a
        8% perf regression on Chromium's international page load tests so that
        the perf regression can be fixed properly without being left in the tree.

        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::canUseGlyphCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 28 Apr 2010 20:35:17 +0000 (20:35 +0000)]
2010-04-28  Darin Fisher  <darin@chromium.org>

        Reviewed by David Levin.

        [Chromium] callOnMainThread should equate to MessageLoop::PostTask
        https://bugs.webkit.org/show_bug.cgi?id=38276

        * JavaScriptCore.gyp/JavaScriptCore.gyp:
        * wtf/MainThread.cpp:
        * wtf/chromium/ChromiumThreading.h:
        * wtf/chromium/MainThreadChromium.cpp:
        (WTF::initializeMainThread):
        (WTF::callOnMainThread):
        (WTF::callOnMainThreadAndWait):
        (WTF::setMainThreadCallbacksPaused):
        (WTF::isMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by David Kilzer.
ap@apple.com [Wed, 28 Apr 2010 20:30:16 +0000 (20:30 +0000)]
    Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=38278
        https://localhost:8443 doesn't work in WebKit tests

        We only had a VirtualHost for 127.0.0.1:8443. Changed that to *:8443.

        * http/conf/apache2-debian-httpd.conf:
        * http/conf/apache2-httpd.conf:
        * http/conf/fedora-httpd.conf:
        * http/conf/httpd.conf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix for <rdar://problem/7474349>
bdakin@apple.com [Wed, 28 Apr 2010 19:48:30 +0000 (19:48 +0000)]
Fix for <rdar://problem/7474349>

Reviewed by Darin Adler.

Add a synchronous display mechanism for WKCACFLayerRenderer.

WebCore:

* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::setRootContentsAndDisplay): This is
just like setRootContents(), but it calls paint() instead of
renderSoon().
* platform/graphics/win/WKCACFLayerRenderer.h:

WebKit/win:

* Interfaces/IWebViewPrivate.idl:
* Interfaces/WebKit.idl:
* WebView.cpp:
(WebView::WebView):
(WebView::updateRootLayerContents):
(WebView::nextDisplayIsSynchronous):
* WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Wed, 28 Apr 2010 19:42:43 +0000 (19:42 +0000)]
2010-04-27  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Fisher.

        Make WebThemeEngine::paint take a const ref of ExtraParams
        https://bugs.webkit.org/show_bug.cgi?id=38242

        * public/WebThemeEngine.h:
        (WebKit::WebThemeEngine::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoREGRESSION: fast/workers/wrapper-map-gc.html crashes on Snow Leopard Release Bot
dimich@chromium.org [Wed, 28 Apr 2010 19:39:54 +0000 (19:39 +0000)]
REGRESSION: fast/workers/wrapper-map-gc.html crashes on Snow Leopard Release Bot
https://bugs.webkit.org/show_bug.cgi?id=37554

Reviewed by Geoffrey Garen.

The flaky fast/workers/wrapper-map-gc.html will stop being flaky.

* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
check if JS execution was terminated, as in cases of Worker.terminate() or WorkerGlobalScope.close().
* bindings/js/JSWorkerContextBase.cpp:
(WebCore::toJS): ASSERT the value of workerContextWrapper, it should never be 0.
* bindings/js/WorkerScriptController.h:
(WebCore::WorkerScriptController::workerContextWrapper): remove returning 0 if JS execution was forbidden.
(WebCore::WorkerScriptController::isExecutionForbidden):
* bindings/v8/WorkerScriptController.h:
(WebCore::WorkerScriptController::isExecutionForbidden):

Add ScriptExecutionContext::isJSExecutionTerminated(), it is always 'false' for Document
and 'true' for WorkerContext when script is terminated.
* dom/ScriptExecutionContext.h:
* dom/Document.h:
(WebCore::Document::isJSExecutionTerminated):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::isJSExecutionTerminated):
* workers/WorkerContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Ilya Tikhonovsky <loislo@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 19:24:20 +0000 (19:24 +0000)]
2010-04-28  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: Multiple Main Resource Content Loaded marks appear in Resource panel.
        https://bugs.webkit.org/show_bug.cgi?id=38270

        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Ilya Tikhonovsky <loislo@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 19:15:03 +0000 (19:15 +0000)]
2010-04-28  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: Timeline: We can have precise urls in the EvaluateScript records.
        https://bugs.webkit.org/show_bug.cgi?id=38264

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 28 Apr 2010 18:35:37 +0000 (18:35 +0000)]
2010-04-28  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Failing test http/tests/misc/isindex-with-no-form.html
        https://bugs.webkit.org/show_bug.cgi?id=30815

        The test currently works, removing from Skipped.

        * platform/gtk/Skipped:

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Evan Martin <evan@chromium.org>
evan@chromium.org [Wed, 28 Apr 2010 18:25:44 +0000 (18:25 +0000)]
2010-04-28  Evan Martin  <evan@chromium.org>

        Reviewed by Darin Adler.

        fast/text/international/bold-bengali needs baselines
        https://bugs.webkit.org/show_bug.cgi?id=38273

        * platform/chromium-win/fast/text/international/bold-bengali-expected.checksum: Added.
        * platform/chromium-win/fast/text/international/bold-bengali-expected.png: Added.
        * platform/mac/fast/text/international/bold-bengali-expected.checksum: Added.
        * platform/mac/fast/text/international/bold-bengali-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Wed, 28 Apr 2010 17:54:22 +0000 (17:54 +0000)]
2010-04-28  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dimitri Glazkov

        Rebaseline Webkit Mac pixel results and chromium pixel results
        caused by http://trac.webkit.org/changeset/58191
        Webkit Mac pixel results failed with --tolerance=0
        https://bugs.webkit.org/show_bug.cgi?id=38104

        * platform/chromium-linux/editing/deleting/4845371-expected.checksum:
        * platform/chromium-linux/editing/deleting/4845371-expected.png: Removed.
        * platform/chromium-linux/editing/deleting/5126166-expected.checksum:
        * platform/chromium-linux/editing/deleting/5126166-expected.png:
        * platform/chromium-linux/editing/deleting/5483370-expected.checksum:
        * platform/chromium-linux/editing/deleting/5483370-expected.png:
        * platform/chromium-linux/editing/deleting/table-cells-expected.checksum:
        * platform/chromium-linux/editing/deleting/table-cells-expected.png: Removed.
        * platform/chromium-linux/editing/inserting/4875189-2-expected.checksum:
        * platform/chromium-linux/editing/inserting/4875189-2-expected.png:
        * platform/chromium-linux/editing/pasteboard/5387578-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/5387578-expected.png:
        * platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.png:
        * platform/chromium-linux/editing/pasteboard/paste-table-001-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/paste-table-001-expected.png: Removed.
        * platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.png: Removed.
        * platform/chromium-linux/editing/selection/move-past-trailing-space-expected.checksum:
        * platform/chromium-linux/editing/selection/move-past-trailing-space-expected.png: Removed.
        * platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.checksum:
        * platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.png: Removed.
        * platform/chromium-linux/fast/repaint/caret-outside-block-expected.checksum:
        * platform/chromium-linux/fast/repaint/caret-outside-block-expected.png: Removed.
        * platform/chromium-mac/editing/deleting/4845371-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/5126166-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/5483370-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/table-cells-expected.checksum: Added.
        * platform/chromium-mac/editing/inserting/4875189-2-expected.checksum: Added.
        * platform/chromium-mac/editing/pasteboard/5387578-expected.checksum: Added.
        * platform/chromium-mac/editing/pasteboard/paste-4039777-fix-expected.checksum: Added.
        * platform/chromium-mac/editing/pasteboard/paste-table-001-expected.checksum: Added.
        * platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/move-past-trailing-space-expected.checksum: Added.
        * platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/caret-outside-block-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/caret-outside-block-expected.png: Added.
        * platform/chromium-win/editing/deleting/4845371-expected.checksum:
        * platform/chromium-win/editing/deleting/4845371-expected.png:
        * platform/chromium-win/editing/deleting/5126166-expected.checksum:
        * platform/chromium-win/editing/deleting/5126166-expected.png:
        * platform/chromium-win/editing/deleting/5483370-expected.checksum:
        * platform/chromium-win/editing/deleting/5483370-expected.png:
        * platform/chromium-win/editing/deleting/table-cells-expected.checksum:
        * platform/chromium-win/editing/deleting/table-cells-expected.png:
        * platform/chromium-win/editing/inserting/4875189-2-expected.checksum:
        * platform/chromium-win/editing/inserting/4875189-2-expected.png:
        * platform/chromium-win/editing/pasteboard/5387578-expected.checksum:
        * platform/chromium-win/editing/pasteboard/5387578-expected.png:
        * platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.checksum:
        * platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.png:
        * platform/chromium-win/editing/pasteboard/paste-table-001-expected.checksum:
        * platform/chromium-win/editing/pasteboard/paste-table-001-expected.png:
        * platform/chromium-win/editing/pasteboard/paste-table-cells-expected.checksum:
        * platform/chromium-win/editing/pasteboard/paste-table-cells-expected.png:
        * platform/chromium-win/editing/selection/move-past-trailing-space-expected.checksum:
        * platform/chromium-win/editing/selection/move-past-trailing-space-expected.png:
        * platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.checksum:
        * platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.png:
        * platform/chromium-win/fast/repaint/caret-outside-block-expected.checksum:
        * platform/chromium-win/fast/repaint/caret-outside-block-expected.png:
        * platform/chromium/test_expectations.txt:
        * platform/mac/editing/deleting/4845371-expected.png:
        * platform/mac/editing/deleting/5126166-expected.png:
        * platform/mac/editing/deleting/5483370-expected.png:
        * platform/mac/editing/deleting/table-cells-expected.png:
        * platform/mac/editing/inserting/4875189-2-expected.png:
        * platform/mac/editing/pasteboard/5387578-expected.png:
        * platform/mac/editing/pasteboard/paste-4039777-fix-expected.png:
        * platform/mac/editing/pasteboard/paste-table-001-expected.png:
        * platform/mac/editing/pasteboard/paste-table-cells-expected.png:
        * platform/mac/editing/selection/move-past-trailing-space-expected.png:
        * platform/mac/fast/inline-block/14498-positionForCoordinates-expected.png:
        * platform/mac/fast/repaint/caret-outside-block-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Wed, 28 Apr 2010 17:53:39 +0000 (17:53 +0000)]
2010-04-28  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dimitri Glazkov

        Rebaseline Webkit Mac pixel results and chromium pixel results
        caused by http://trac.webkit.org/changeset/58191
        Webkit Mac pixel results failed with --tolerance=0

        * platform/chromium-linux/editing/deleting/4845371-expected.checksum:
        * platform/chromium-linux/editing/deleting/4845371-expected.png: Removed.
        * platform/chromium-linux/editing/deleting/5126166-expected.checksum:
        * platform/chromium-linux/editing/deleting/5126166-expected.png:
        * platform/chromium-linux/editing/deleting/5483370-expected.checksum:
        * platform/chromium-linux/editing/deleting/5483370-expected.png:
        * platform/chromium-linux/editing/deleting/table-cells-expected.checksum:
        * platform/chromium-linux/editing/deleting/table-cells-expected.png: Removed.
        * platform/chromium-linux/editing/inserting/4875189-2-expected.checksum:
        * platform/chromium-linux/editing/inserting/4875189-2-expected.png:
        * platform/chromium-linux/editing/pasteboard/5387578-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/5387578-expected.png:
        * platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.png:
        * platform/chromium-linux/editing/pasteboard/paste-table-001-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/paste-table-001-expected.png: Removed.
        * platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.png: Removed.
        * platform/chromium-linux/editing/selection/move-past-trailing-space-expected.checksum:
        * platform/chromium-linux/editing/selection/move-past-trailing-space-expected.png: Removed.
        * platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.checksum:
        * platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.png: Removed.
        * platform/chromium-linux/fast/repaint/caret-outside-block-expected.checksum:
        * platform/chromium-linux/fast/repaint/caret-outside-block-expected.png: Removed.
        * platform/chromium-mac/editing/deleting/4845371-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/5126166-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/5483370-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/table-cells-expected.checksum: Added.
        * platform/chromium-mac/editing/inserting/4875189-2-expected.checksum: Added.
        * platform/chromium-mac/editing/pasteboard/5387578-expected.checksum: Added.
        * platform/chromium-mac/editing/pasteboard/paste-4039777-fix-expected.checksum: Added.
        * platform/chromium-mac/editing/pasteboard/paste-table-001-expected.checksum: Added.
        * platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/move-past-trailing-space-expected.checksum: Added.
        * platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/caret-outside-block-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/caret-outside-block-expected.png: Added.
        * platform/chromium-win/editing/deleting/4845371-expected.checksum:
        * platform/chromium-win/editing/deleting/4845371-expected.png:
        * platform/chromium-win/editing/deleting/5126166-expected.checksum:
        * platform/chromium-win/editing/deleting/5126166-expected.png:
        * platform/chromium-win/editing/deleting/5483370-expected.checksum:
        * platform/chromium-win/editing/deleting/5483370-expected.png:
        * platform/chromium-win/editing/deleting/table-cells-expected.checksum:
        * platform/chromium-win/editing/deleting/table-cells-expected.png:
        * platform/chromium-win/editing/inserting/4875189-2-expected.checksum:
        * platform/chromium-win/editing/inserting/4875189-2-expected.png:
        * platform/chromium-win/editing/pasteboard/5387578-expected.checksum:
        * platform/chromium-win/editing/pasteboard/5387578-expected.png:
        * platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.checksum:
        * platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.png:
        * platform/chromium-win/editing/pasteboard/paste-table-001-expected.checksum:
        * platform/chromium-win/editing/pasteboard/paste-table-001-expected.png:
        * platform/chromium-win/editing/pasteboard/paste-table-cells-expected.checksum:
        * platform/chromium-win/editing/pasteboard/paste-table-cells-expected.png:
        * platform/chromium-win/editing/selection/move-past-trailing-space-expected.checksum:
        * platform/chromium-win/editing/selection/move-past-trailing-space-expected.png:
        * platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.checksum:
        * platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.png:
        * platform/chromium-win/fast/repaint/caret-outside-block-expected.checksum:
        * platform/chromium-win/fast/repaint/caret-outside-block-expected.png:
        * platform/chromium/test_expectations.txt:
        * platform/mac/editing/deleting/4845371-expected.png:
        * platform/mac/editing/deleting/5126166-expected.png:
        * platform/mac/editing/deleting/5483370-expected.png:
        * platform/mac/editing/deleting/table-cells-expected.png:
        * platform/mac/editing/inserting/4875189-2-expected.png:
        * platform/mac/editing/pasteboard/5387578-expected.png:
        * platform/mac/editing/pasteboard/paste-4039777-fix-expected.png:
        * platform/mac/editing/pasteboard/paste-table-001-expected.png:
        * platform/mac/editing/pasteboard/paste-table-cells-expected.png:
        * platform/mac/editing/selection/move-past-trailing-space-expected.png:
        * platform/mac/fast/inline-block/14498-positionForCoordinates-expected.png:
        * platform/mac/fast/repaint/caret-outside-block-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Andrey Kosyakov <caseq@chromium.org>
pfeldman@chromium.org [Wed, 28 Apr 2010 17:14:46 +0000 (17:14 +0000)]
2010-04-28  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Fixed passing breakpoints to V8.
        https://bugs.webkit.org/show_bug.cgi?id=38266

        * src/js/InspectorControllerImpl.js:
        (.devtools.InspectorBackendImpl.prototype.setBreakpoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 28 Apr 2010 17:10:01 +0000 (17:10 +0000)]
2010-04-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Linkify node and function in the event listeners panel.

        https://bugs.webkit.org/show_bug.cgi?id=38251

        * bindings/js/ScriptEventListener.cpp:
        (WebCore::eventListenerHandlerBody):
        (WebCore::eventListenerHandlerLocation):
        * bindings/js/ScriptEventListener.h:
        * bindings/v8/ScriptEventListener.cpp:
        (WebCore::eventListenerHandlerBody):
        (WebCore::eventListenerHandlerLocation):
        * bindings/v8/ScriptEventListener.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::buildObjectForEventListener):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.linkifyNodeReference):
        (WebInspector.ElementsPanel.prototype.linkifyNodeReference.preventDefault):
        * inspector/front-end/EventListenersSidebarPane.js:
        (WebInspector.EventListenersSidebarPane.prototype.update.callback):
        (WebInspector.EventListenersSidebarPane.prototype.update):
        ():
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
        * inspector/front-end/inspector.css:
        (.node-link):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIgnore a directory the Python tools creates.
darin@apple.com [Wed, 28 Apr 2010 16:56:34 +0000 (16:56 +0000)]
Ignore a directory the Python tools creates.

* Scripts/webkitpy/style: Modified property svn:ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Scripts/extract-localizable-strings: Fix minor mistake in
darin@apple.com [Wed, 28 Apr 2010 16:44:56 +0000 (16:44 +0000)]
* Scripts/extract-localizable-strings: Fix minor mistake in
argument checking.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR
jchaffraix@webkit.org [Wed, 28 Apr 2010 16:29:22 +0000 (16:29 +0000)]
[XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR
https://bugs.webkit.org/show_bug.cgi?id=37781
<rdar://problem/7905150>

Reviewed by Alexey Proskuryakov.

WebCore:

Tests: http/tests/xmlhttprequest/access-control-preflight-credential-async.html
       http/tests/xmlhttprequest/access-control-preflight-credential-sync.html

Rolling the patch in as I could not reproduce Qt results locally.

* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Now we remove the
credential from the request here to avoid forgetting to do so in the different code path.
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Just add the
"Origin" header.
(WebCore::DocumentThreadableLoader::loadRequest): Check here the the credential have
been removed so that we don't leak them. Also tweaked a comment to make it clear that
the URL check has issue when credential is involved.

LayoutTests:

Test that doing a cross-origin request with a preflight check does
not raise a NETWORK_ERR exception and does not send the credentials.

* http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Added.
* http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Added.
* http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Added.
* http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Added.
* http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Added.

* platform/mac-tiger/Skipped:
* platform/qt/Skipped:
Added those 2 tests to the Skipped lists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Wed, 28 Apr 2010 14:23:22 +0000 (14:23 +0000)]
2010-04-28  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] GraphicsLayer: preserves-3d and backface visibility
        https://bugs.webkit.org/show_bug.cgi?id=35312

        Implement preserves-3d by maintaining the 3D transformation heirarchy inside GraphicsLayerQt, and extrapolating
        the relative QTransform. When the extrapolation fails (un-invertible matrix) we ignore the transformation change.

        WebKitSite/blog-files/3d-transforms test now work with Qt.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::updateTransform):
        (WebCore::GraphicsLayerQtImpl::opaqueArea):
        (WebCore::GraphicsLayerQtImpl::boundingRect):
        (WebCore::GraphicsLayerQtImpl::paint):
        (WebCore::GraphicsLayerQtImpl::flushChanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Marcus Bulach <bulach@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 13:58:42 +0000 (13:58 +0000)]
2010-04-28  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        [chromium] Rebaseline svg-background-partial-redraw, node-iterator-prototype, and upstream test expectations for fast/text/international/bold-bengali.html
        https://bugs.webkit.org/show_bug.cgi?id=38259

        * platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.checksum: Added.
        * platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png: Added.
        * platform/chromium-mac/fast/images: Added.
        * platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.checksum: Added.
        * platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.png: Added.
        * platform/chromium-mac/traversal: Added.
        * platform/chromium-mac/traversal/node-iterator-prototype-expected.txt: Added.
        * platform/chromium-win/fast/images/svg-background-partial-redraw-expected.checksum: Added.
        * platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png: Added.
        * platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt: Added.
        * platform/chromium-win/traversal: Added.
        * platform/chromium-win/traversal/node-iterator-prototype-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Ilya Tikhonovsky <loislo@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 13:49:08 +0000 (13:49 +0000)]
2010-04-28  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: View frame selector for Timeline overview panel is redesigned a bit.
        Now it is possible to adjust view frame by resizer bars and by click-n-drag in overview pane.
        https://bugs.webkit.org/show_bug.cgi?id=38251

        * inspector/front-end/TimelineOverviewPane.js:
        (WebInspector.TimelineOverviewPane):
        (WebInspector.TimelineOverviewPane.prototype.reset):
        (WebInspector.TimelineOverviewPane.prototype._dragWindow):
        (WebInspector.TimelineOverviewPane.prototype._windowSelectorDragging):
        (WebInspector.TimelineOverviewPane.prototype._endWindowSelectorDragging):
        (WebInspector.TimelineOverviewPane.prototype._resizeWindowLeft):
        (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight):
        (WebInspector.TimelineOverviewPane.prototype._setWindowPosition):
        (WebInspector.TimelinePanel.WindowSelector):
        (WebInspector.TimelinePanel.WindowSelector.prototype._createSelectorElement):
        (WebInspector.TimelinePanel.WindowSelector.prototype._close):
        (WebInspector.TimelinePanel.WindowSelector.prototype._updatePosition):
        * inspector/front-end/inspector.css:
        (#timeline-overview-grid):
        (.timeline-window-selector):
        (#timeline-overview-window):
        (.timeline-overview-dividers-background):
        (.timeline-overview-window-rulers):
        (.timeline-window-resizer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Wed, 28 Apr 2010 12:58:19 +0000 (12:58 +0000)]
2010-04-28  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] QWebPage viewMode property
        https://bugs.webkit.org/show_bug.cgi?id=38119

        Replacing method qt_wrt_setViewMode by wrt_viewMode property.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::dynamicPropertyChangeEvent):
        (QWebPage::event):
        * Api/qwebpage_p.h:
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::wrt_viewModes):
2010-04-28  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] QWebPage viewMode property
        https://bugs.webkit.org/show_bug.cgi?id=38119

        Replacing method qt_wrt_setViewMode by wrt_viewMode property.

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setViewModeMediaFeature):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Marcus Bulach <bulach@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 11:58:45 +0000 (11:58 +0000)]
2010-04-28  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Reverts 58340 (https://bugs.webkit.org/show_bug.cgi?id=38158) due to regression on fast/text/international/khmer-selection.html
        https://bugs.webkit.org/show_bug.cgi?id=38254

        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::adjustTextRenderMode):
        (WebCore::TextRunWalker::getTextRun):
        (WebCore::TextRunWalker::getNormalizedTextRun):
        (WebCore::TextRunWalker::setGlyphXPositions):
        (WebCore::glyphIndexForXPositionInScriptRun):
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):
        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::setupPaint):
        * platform/graphics/chromium/HarfbuzzSkia.cpp:
        (WebCore::getOutlinePoint):
        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        (WebCore::GraphicsContext3D::getImageData):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::isCoordinateSkiaSafe):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::strokeRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Andrey Kosyakov <caseq@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 11:49:05 +0000 (11:49 +0000)]
2010-04-28  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Log error message to inspector console if a resource fails to load.
        Moved console-tests.js to http tests. Added support for sorting
        console messages, in case order may vary.
        https://bugs.webkit.org/show_bug.cgi?id=37215

        * http/tests/inspector/console-resource-errors-expected.txt: Added.
        * http/tests/inspector/console-resource-errors.html: Added.
        * http/tests/inspector/console-tests.js: Added.
        (dumpConsoleMessages.callback):
        (dumpConsoleMessages):
        (dumpConsoleMessagesWithClasses.callback):
        (dumpConsoleMessagesWithClasses):
        (frontend_dumpConsoleMessages):
        * inspector/console-clear.html:
        * inspector/console-dir.html:
        * inspector/console-dirxml.html:
        * inspector/console-format-collections-expected.txt:
        * inspector/console-format-collections.html:
        * inspector/console-format.html:
        * inspector/console-log-before-inspector-open.html:
        * inspector/console-tests.html:
        * inspector/console-tests.js: Removed.
        * platform/mac-tiger/http/tests/inspector: Added.
        * platform/mac-tiger/http/tests/inspector/console-resource-errors-expected.txt: Added.
2010-04-28  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Log error message to inspector console if a resource fails to load.
        Disable checking of mime-type consistency for failed resources.
        https://bugs.webkit.org/show_bug.cgi?id=37215

        Test: http/tests/inspector/console-resource-errors.html

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didFailLoading):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Yury Semikhatsky <yurys@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 11:39:03 +0000 (11:39 +0000)]
2010-04-28  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Support pause on exceptions in v8 implementation of ScriptDebugServer.

        https://bugs.webkit.org/show_bug.cgi?id=38205

        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::addListener):
        (WebCore::ScriptDebugServer::pauseOnExceptionsState):
        (WebCore::ScriptDebugServer::setPauseOnExceptionsState):
        (WebCore::ScriptDebugServer::currentCallFrame):
        (WebCore::ScriptDebugServer::handleV8DebugMessage):
        (WebCore::ScriptDebugServer::dispatchDidParseSource):
        * bindings/v8/ScriptDebugServer.h:
2010-04-28  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Support pause on exceptions in v8 implementation of ScriptDebugServer.

        https://bugs.webkit.org/show_bug.cgi?id=38205

        * src/js/DebuggerScript.js:
        (debuggerScriptConstructor.DebuggerScript.getScripts):
        (debuggerScriptConstructor.DebuggerScript.pauseOnExceptionsState):
        (debuggerScriptConstructor.DebuggerScript.setPauseOnExceptionsState):
        (debuggerScriptConstructor.DebuggerScript._v8ToWebkitLineNumber):
        (debuggerScriptConstructor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Chris Jerdonek <cjerdonek@webkit.org>
eric@webkit.org [Wed, 28 Apr 2010 11:19:41 +0000 (11:19 +0000)]
2010-04-28  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Shinichiro Hamaji.

        Adjusted check-webkit-style so that files with file type NONE
        are automatically skipped without warning.

        https://bugs.webkit.org/show_bug.cgi?id=38197

        This change simplifies configuring which files to skip.  It also
        addresses an issue whereby check-webkit-style was unintentionally
        checking .vcproj files for carriage returns.

        * Scripts/webkitpy/style/checker.py:
          - Moved the C++, Python, and text file extensions to new
            module-level configuration variables.
          - Removed .pyc from the _SKIPPED_FILES_WITHOUT_WARNING configuration
            variable.
          - Changed the numeric values of the FileType enum so that
            FileType.NONE evaluates to False.
          - For ProcessorDispatcher.should_skip_without_warning():
            - Changed the method to return True for FileType.NONE files.
            - Made ChangeLog files an exception to getting skipped.
          - Changed the StyleProcessor.process() method to raise an
            exception if given a file path that should not be processed.

        * Scripts/webkitpy/style/checker_unittest.py:
          - Updated the unit tests and added more test cases as necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Sheriff Bot <webkit.review.bot@gmail.com>
jorlow@chromium.org [Wed, 28 Apr 2010 10:57:20 +0000 (10:57 +0000)]
2010-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r58313.
        http://trac.webkit.org/changeset/58313
        https://bugs.webkit.org/show_bug.cgi?id=38253

        Regression evident in pixel tests: the search icon is always
        clipped at the bottom. (Requested by jorlow on #webkit).

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::controlClipRect):
        * rendering/RenderTextControl.h:
        (WebCore::RenderTextControl::hasControlClip):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::paint):
        * rendering/RenderTextControlSingleLine.h:
2010-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r58313.
        http://trac.webkit.org/changeset/58313
        https://bugs.webkit.org/show_bug.cgi?id=38253

        Regression evident in pixel tests: the search icon is always
        clipped at the bottom. (Requested by jorlow on #webkit).

        * fast/css/input-search-padding.html: Removed.
        * platform/mac/fast/css/input-search-padding-expected.checksum: Removed.
        * platform/mac/fast/css/input-search-padding-expected.png: Removed.
        * platform/mac/fast/css/input-search-padding-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemoved execute permissions from WebCore/inspector/InspectorFrontend.cpp
hausmann@webkit.org [Wed, 28 Apr 2010 10:32:46 +0000 (10:32 +0000)]
Removed execute permissions from WebCore/inspector/InspectorFrontend.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 28 Apr 2010 10:29:33 +0000 (10:29 +0000)]
2010-04-28  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed.  Disable printing/media-queries-print for now.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Eric Seidel <eric@webkit.org>
ukai@chromium.org [Wed, 28 Apr 2010 10:09:09 +0000 (10:09 +0000)]
2010-04-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Jeremy Orlow.

        webkitpy: ScriptError('Failed to run "[u\'taskkill.exe\', u\'/f\', u\'/im\', u\'httpd.exe\']" exit_code: 128',)
        https://bugs.webkit.org/show_bug.cgi?id=38248

        The previous code did not check the return code of taskkill.
        When I moved that callsite from using subprocess.call to
        Executive.run_command having a non-zero return code became an error.

        In this change I've centralized our killall handling in executive,
        and added tests for it to make sure it works.

        Currently kill_process and kill_all swallow exceptions in the cases
        where the process(es) to be killed do(es) not exist.

        * Scripts/webkitpy/common/system/executive.py:
        * Scripts/webkitpy/common/system/executive_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/gtk.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/qt.py:
        * Scripts/webkitpy/layout_tests/port/win.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 28 Apr 2010 09:58:03 +0000 (09:58 +0000)]
2010-04-28  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed.  Added missing expectation files missed in r58386.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        * platform/mac/printing/media-queries-print-expected.checksum: Added.
        * platform/mac/printing/media-queries-print-expected.png: Added.
        * platform/mac/printing/media-queries-print-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 28 Apr 2010 09:44:42 +0000 (09:44 +0000)]
2010-04-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Shinichiro Hamaji.

        wdiff_text throws ScriptError because wdiff returns non-zero when files differ
        https://bugs.webkit.org/show_bug.cgi?id=38246

        wdiff returns 0 when files are the same, 1 when they differ.
        run_command by default raises ScriptError if the return code is non-zero.
        Fixed this by adding a custom error handler which only raises if the
        return code is not 1.

        I broke up the huge wdiff_text() method into little pieces
        for easier unit testing.  There is only one functional change here
        and that is the addition of the custom error handler.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed build fix.
ukai@chromium.org [Wed, 28 Apr 2010 09:21:59 +0000 (09:21 +0000)]
Unreviewed build fix.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::dumpImage): format '%u' expects type 'unsigned int', but argument 2 has type 'size_t'.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::willSendRequest): too few arguments for format.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJSC's currentThreadStackBase is not reentrant on some platforms
hausmann@webkit.org [Wed, 28 Apr 2010 09:06:20 +0000 (09:06 +0000)]
JSC's currentThreadStackBase is not reentrant on some platforms
https://bugs.webkit.org/show_bug.cgi?id=37195

Patch by Simon Hausmann  <simon.hausmann@nokia.com>, Kent Hansen <kent.hansen@nokia.com> on 2010-04-28
Reviewed by Darin Adler.

This function needs to be reentrant to avoid memory corruption on platforms where
the implementation uses global variables.

This patch adds a mutex lock where necessary and makes the Symbian implementation
reentrant.

* runtime/Collector.cpp:
(JSC::currentThreadStackBaseMutex):
(JSC::currentThreadStackBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix compilation with gcc 3.4.
hausmann@webkit.org [Wed, 28 Apr 2010 08:55:07 +0000 (08:55 +0000)]
Fix compilation with gcc 3.4.

Patch by Thiago Macieira <thiago.macieira@nokia.com> on 2010-04-28
Reviewed by Simon Hausmann.

AtomicStringImpl.h:29: error: base `WebCore::StringImpl' with only
non-default constructor in class without a constructor

* wtf/text/AtomicStringImpl.h:
(WebCore::AtomicStringImpl::AtomicStringImpl): Provide a default constructor.
* wtf/text/StringImpl.h: Allow AtomicStringImpl to call a StringImpl constructor through a friend declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] WINS DEF file freeze
hausmann@webkit.org [Wed, 28 Apr 2010 08:31:59 +0000 (08:31 +0000)]
[Qt] WINS DEF file freeze

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-04-28
Reviewed by Simon Hausmann <simon.hausmann@nokia.com>

Updated WINSCW def file with added and removed symbols.

* symbian/bwins/QtWebKitu.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Fix detection of Qt 4.7's multimedia libraries
hausmann@webkit.org [Wed, 28 Apr 2010 08:29:03 +0000 (08:29 +0000)]
[Qt] Fix detection of Qt 4.7's multimedia libraries

Patch by Justin McPherson <justin.mcpherson@nokia.com> on 2010-04-28
Reviewed by Simon Hausmann.

QtMultimedia has been split into an additional media services library, which
we're using. mediaservices depends on multimedia.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 28 Apr 2010 07:49:12 +0000 (07:49 +0000)]
2010-04-28  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed attempt to fix the chromium build.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        * rendering/RenderTreeAsText.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-28 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Wed, 28 Apr 2010 07:47:12 +0000 (07:47 +0000)]
2010-04-28  Daniel Bates  <dbates@rim.com>

        Unreviewed, rebase expected result of failing test.

        Rebasing Qt expected result for selection-gap-overflow-scroll-2.html.
        Following the landing of bug #37686, this test started failing despite
        being unrelated to this bug. From looking at the diff of the result,
        which shows a 1 pixel shift in widths, and based on Csaba Osztrogonac's
        comment, we have decided to rebase this result.

        * platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebView drawing code may access null backing store dirty region
sfalken@apple.com [Wed, 28 Apr 2010 07:33:09 +0000 (07:33 +0000)]
WebView drawing code may access null backing store dirty region
https://bugs.webkit.org/show_bug.cgi?id=38245
<rdar://problem/7916101> REGRESSION (r58067): All loaded pages fail to display after running iBench HTML test (intermittent)

Reviewed by Maciej Stachowiak.

* WebView.cpp:
(WebView::updateBackingStore): Add null check for m_backingStoreDirtyRegion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 28 Apr 2010 07:30:16 +0000 (07:30 +0000)]
2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler and Eric Seidel.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        Now we can test media queries with the new function because the
        render tree has the color information of the box.

        Note that the pixel test is currently failing. We'll need another
        patch to enable printing mode for pixel tests.

        * platform/mac/Skipped:
        * platform/mac/printing/media-queries-print-expected.checksum: Added.
        * platform/mac/printing/media-queries-print-expected.png: Added.
        * platform/mac/printing/media-queries-print-expected.txt: Added.
        * printing/media-queries-print.html:
2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler and Eric Seidel.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        Added RenderAsTextPrintingMode as a behavior of externalRepresentation.

        Now ~PrintContext() calls end() automatically.

        * page/PrintContext.cpp:
        (WebCore::PrintContext::~PrintContext):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::externalRepresentation):
        * rendering/RenderTreeAsText.h:
        (WebCore::):
2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler and Eric Seidel.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        * Misc/WebCoreStatistics.h:
        * Misc/WebCoreStatistics.mm:
        (-[WebFrame renderTreeAsExternalRepresentationForPrinting:]):
2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler and Eric Seidel.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (setPrintingCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        (LayoutTestController::isPrinting):
        (LayoutTestController::setIsPrinting):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 28 Apr 2010 07:09:09 +0000 (07:09 +0000)]
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Eric Seidel.

        Enhance CSS parser for Paged Media (Iteration 4)
        Implement page property parsing as specified at http://dev.w3.org/csswg/css3-page/#using-named-pages.
        https://bugs.webkit.org/show_bug.cgi?id=35853

        * printing/page-rule-css-text-expected.txt:
        * printing/page-rule-css-text.html:
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Eric Seidel.

        Enhance CSS parser for Paged Media (Iteration 4)
        Implement page property parsing as specified at http://dev.w3.org/csswg/css3-page/#using-named-pages.
        https://bugs.webkit.org/show_bug.cgi?id=35853

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parsePage):
        * css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 28 Apr 2010 06:45:35 +0000 (06:45 +0000)]
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Dimitri Glazkov.

        Enhance CSS parser for Paged Media (Iteration 3)
        Implement size parameter parsing for Paged Media.
        https://bugs.webkit.org/show_bug.cgi?id=35851

        * printing/page-rule-css-text-expected.txt:
        * printing/page-rule-css-text.html:
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Dimitri Glazkov.

        Enhance CSS parser for Paged Media (Iteration 3)
        Implement size parameter parsing for Paged Media.
        https://bugs.webkit.org/show_bug.cgi?id=35851

        I believe size property hasn't been used so far because (1) it hasn't been properly parsed and
        (2) a comment in CSSComputedStyleDeclaration::getPropertyCSSValue says so.
        Changing the way of parsing it should not cause any regressions -- no existing tests fail because of this change.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseSize):
        (WebCore::CSSParser::parseSizeParameter):
        * css/CSSParser.h:
        (WebCore::CSSParser::):
        * css/CSSValueKeywords.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 28 Apr 2010 06:19:36 +0000 (06:19 +0000)]
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Eric Seidel.

        Enhance CSS parser for Paged Media (Iteration 2)
        Parse and hold paged media rules in CSSStyleSelector.

        fast/dom/script-tests/prototype-inheritance-2.js is rebaselined because it assumes @page is ignored.

        https://bugs.webkit.org/show_bug.cgi?id=35782

        * fast/dom/prototype-inheritance-2-expected.txt:
        * fast/dom/script-tests/prototype-inheritance-2.js:
        * printing/page-rule-css-text-expected.txt: Added.
        * printing/page-rule-css-text.html: Added.
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Eric Seidel.

        Enhance CSS parser for Paged Media (Iteration 2)
        Parse and hold paged media rules in CSSStyleSelector.

        https://bugs.webkit.org/show_bug.cgi?id=35782

        Test: printing/page-rule-css-text.html

        * css/CSSGrammar.y:
        * css/CSSPageRule.cpp:
        (WebCore::CSSPageRule::CSSPageRule):
        (WebCore::CSSPageRule::selectorText):
        * css/CSSPageRule.h:
        (WebCore::CSSPageRule::create):
        (WebCore::CSSPageRule::isPageRule):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::createPageRule):
        * css/CSSStyleRule.h:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSRuleSet::getPageRules):
        (WebCore::CSSRuleSet::CSSRuleSet):
        (WebCore::CSSRuleSet::~CSSRuleSet):
        (WebCore::CSSRuleSet::addPageRule):
        (WebCore::CSSRuleSet::addRulesFromSheet):
        * css/CSSStyleSelector.h:
        * css/StyleBase.h:
        (WebCore::StyleBase::isPageRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Jens Alfke <snej@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 06:00:03 +0000 (06:00 +0000)]
2010-04-27  Jens Alfke  <snej@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] Fix bug that prevents autosave of forms without action attribute
        https://bugs.webkit.org/show_bug.cgi?id=38014
        Change is in the Chromium WebKit API so it can't be tested with a JS-based layout test.
        It needs a native unit test, which would go in the Chromium repo, not WebKit.

        * src/WebPasswordFormData.cpp:
        (WebKit::WebPasswordFormData::WebPasswordFormData): Set correct URL if action is NULL

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Wed, 28 Apr 2010 05:42:51 +0000 (05:42 +0000)]
2010-04-27  Daniel Bates  <dbates@rim.com>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=37686

        Fixes an issue where the canvas method strokeRect will stroke a
        rectangle whose dimensions are 0 when lineWidth > 1.

        As per the definition of strokeRect in the HTML Canvas 2D Context
        spec. <http://www.w3.org/TR/2dcontext/#dom-context-2d-strokerect>,
        this method should have no effect when both the height and width
        are zero.

        Tests: fast/canvas/canvas-clearRect.html
               fast/canvas/canvas-fillRect.html

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::validateRectForCanvas): Return false if height, width == 0.
2010-04-27  Daniel Bates  <dbates@rim.com>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=37686

        Tests that strokeRect does not paint any artifacts when the
        specified rectangle has height, width = 0 and lineWidth > 1.

        Also tests that clearRect, fillRect, and rect are ignored when
        height, width = 0.

        * fast/canvas/canvas-clearRect-expected.txt: Added.
        * fast/canvas/canvas-clearRect.html: Added.
        * fast/canvas/canvas-fillRect-expected.txt: Added.
        * fast/canvas/canvas-fillRect.html: Added.
        * fast/canvas/canvas-modify-emptyPath-expected.txt:
        * fast/canvas/canvas-strokeRect-expected.txt: Updated results.
        * fast/canvas/script-tests/canvas-clearRect.js: Added.
        * fast/canvas/script-tests/canvas-fillRect.js: Added.
        * fast/canvas/script-tests/canvas-modify-emptyPath.js: Added test case.
        * fast/canvas/script-tests/canvas-strokeRect.js: Ditto. Also, added
        debug statements so as to distinguish the results for each test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Michael Nordman <michaeln@google.com>
eric@webkit.org [Wed, 28 Apr 2010 05:40:23 +0000 (05:40 +0000)]
2010-04-27  Michael Nordman  <michaeln@google.com>

        Reviewed by Dmitry Titov.

        [Chromium] Add two things to the webkit API to support appcaches in workers.
        1) WebURLRequest TargetTypes for worker and shared worker main resources.
        2) Factory method on class WebCommonWorkerClient to
           createApplicationCacheHost() for the associated worker.

        https://bugs.webkit.org/show_bug.cgi?id=38147

        * public/WebCommonWorkerClient.h: add the factory method
        * public/WebURLRequest.h: add the TargetTypes
        * src/WebWorkerBase.cpp: call the embedder's factory when needed
        (WebKit::WebWorkerBase::didCreateDataSource)
        (WebKit::WebWorkerBase::createApplicationCacheHost)
        * src/WebWorkerBase.h: ditto
        * src/WebWorkerClientImpl.h: add a stub impl of the factory method
        (WebKit::WebWorkerClientImpl::createApplicationCacheHost):
2010-04-27  Michael Nordman  <michaeln@google.com>

        Reviewed by Dmitry Titov.

        [Chromium] Add two things to the webkit API to support appcaches in workers.
        1) WebURLRequest TargetTypes for worker and shared worker main resources.
        2) Factory method on class WebCommonWorkerClient to
           createApplicationCacheHost() for the associated worker.

        https://bugs.webkit.org/show_bug.cgi?id=38147

        * DumpRenderTree/chromium/TestWebWorker.h add a stub impl of the factory method
        (TestWebWorker::createApplicationCacheHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Adam Barth <abarth@webkit.org>
eric@webkit.org [Wed, 28 Apr 2010 05:31:03 +0000 (05:31 +0000)]
2010-04-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove obsolete custom bindings file
        https://bugs.webkit.org/show_bug.cgi?id=38223

        We don't need these files anymore because they are empty.

        * Android.jscbindings.mk:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSAbstractWorkerCustom.cpp: Removed.
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSDocumentFragmentCustom.cpp: Removed.
        * bindings/js/JSEventSourceCustom.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Daniel Cheng <dcheng@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 05:21:33 +0000 (05:21 +0000)]
2010-04-27  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Jian Li.

        [Chromium] Filter out URLs with a file scheme from text/uri-list when dragging.
        https://bugs.webkit.org/show_bug.cgi?id=38227

        Unfortunately, the simple fix of not populating the drag data with file URLs doesn't work
        since the default drop handling uses the drag data URL to navigate to dropped files/URLs.
        For now, we hack around the problem in the Chromium platform, but the proper long term
        solution is to change DragController::performDrag to check dragData::asFilenames().

        No new tests.

        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::getData):
        (WebCore::ClipboardChromium::types):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 28 Apr 2010 04:53:19 +0000 (04:53 +0000)]
2010-04-27  Kent Tamura  <tkent@chromium.org>

        Reviewed by Shinichiro Hamaji.

        [DRT/Chromium] Enable Windows project generation
        https://bugs.webkit.org/show_bug.cgi?id=38103

        - Avoid platform.system(), which causes a crash with python.exe in
          depot_tools. Use sys.platform instead.
        - Process DumpRenderTree.gyp on all platforms.

        * gyp_webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Adam Barth <abarth@webkit.org>
eric@webkit.org [Wed, 28 Apr 2010 04:49:41 +0000 (04:49 +0000)]
2010-04-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        run-bindings-tests doesn't work in an SVN checkout
        https://bugs.webkit.org/show_bug.cgi?id=38225

        Previously detect_scm_system needed an absolute path for SVN.  Now we
        accept a relative path.

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 28 Apr 2010 04:20:55 +0000 (04:20 +0000)]
2010-04-27  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by the inimitable Dan Bernstein.

        SVG as background image renders incorrectly after zooming
        https://bugs.webkit.org/show_bug.cgi?id=38215

        When doing a partial redraw of an SVGImage used as a CSS background
        image, we're limited to drawing the entire Frame, clipped to the dirty rect.
        Because of this, we need to fix up the CTM so that the origin is at the
        top left of the unclipped image, rather than the top left of the
        portion being redrawn.

        Test: fast/images/svg-background-partial-redraw.html

        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 28 Apr 2010 03:42:15 +0000 (03:42 +0000)]
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by David Hyatt.

        Retry of: Enhance CSS parser for Paged Media (Iteration 1)

        In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
        The contents of the methods should be implemented by other changes.

        https://bugs.webkit.org/show_bug.cgi?id=35329

        * fast/css/parsing-page-rule-expected.txt: Copied from LayoutTests/editing/selection/5136696-expected.txt.
        * fast/css/parsing-page-rule.html: Added.
2010-04-27  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by David Hyatt.

        Retry of: Enhance CSS parser for Paged Media (Iteration 1)

        In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
        The contents of the methods should be implemented by other changes.

        https://bugs.webkit.org/show_bug.cgi?id=35329

        Test: fast/css/parsing-page-rule.html

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::clearProperties):
        (WebCore::CSSParser::createPageRule):
        (WebCore::CSSParser::createMarginAtRule):
        (WebCore::CSSParser::startDeclarationsForMarginBox):
        (WebCore::CSSParser::endDeclarationsForMarginBox):
        * css/CSSParser.h:
        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::pseudoId):
        (WebCore::nameToPseudoTypeMap):
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h:
        (WebCore::CSSSelector::):
        * css/tokenizer.flex:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out my changes as it rendered the Qt bot unreliable.
jchaffraix@webkit.org [Wed, 28 Apr 2010 03:37:30 +0000 (03:37 +0000)]
Unreviewed, rolling out my changes as it rendered the Qt bot unreliable.

WebCore:

* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::loadRequest):

LayoutTests:

* http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Removed.
* http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Removed.
* http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Removed.
* http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Removed.
* http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Removed.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed.
jchaffraix@webkit.org [Wed, 28 Apr 2010 03:08:17 +0000 (03:08 +0000)]
Unreviewed.

* platform/qt/Skipped: Add the 2 newly added test cases to the list
as they involve preflight requests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR
jchaffraix@webkit.org [Wed, 28 Apr 2010 02:44:39 +0000 (02:44 +0000)]
[XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR
https://bugs.webkit.org/show_bug.cgi?id=37781
<rdar://problem/7905150>

Reviewed by Alexey Proskuryakov.

WebCore:

Tests: http/tests/xmlhttprequest/access-control-preflight-credential-async.html
       http/tests/xmlhttprequest/access-control-preflight-credential-sync.html

* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Now we remove the
credential from the request here to avoid forgetting to do so in the different code path.
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Just add the
"Origin" header.
(WebCore::DocumentThreadableLoader::loadRequest): Check here the the credential have
been removed so that we don't leak them. Also tweaked a comment to make it clear that
the URL check has issue when credential is involved.

LayoutTests:

Test that doing a cross-origin request with a preflight check does
not raise a NETWORK_ERR exception and does not send the credentials.

* http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Added.
* http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Added.
* http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Added.
* http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Added.
* http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Jay Civelli <jcivelli@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 02:29:23 +0000 (02:29 +0000)]
2010-04-27  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Darin Fisher.

        Makes clicking a select element close its associated popup if
        it is open.
        https://bugs.webkit.org/show_bug.cgi?id=38105

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::mouseDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Jay Civelli <jcivelli@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 02:08:35 +0000 (02:08 +0000)]
2010-04-27  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Merged the WebView public method to close suggestion popups
        into a single method to close all popups (select and suggestions).
        That ensures select popups are closed when the browser window is moved
        or resized.
        https://bugs.webkit.org/show_bug.cgi?id=37837

        * public/WebView.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::hidePopups):
        (WebKit::WebViewImpl::hideSuggestionsPopup):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAlways build WebKit2 when building on SnowLeopard and later.
weinig@apple.com [Wed, 28 Apr 2010 01:45:21 +0000 (01:45 +0000)]
Always build WebKit2 when building on SnowLeopard and later.

Reviewed by Stephanie Lewis.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=38238
weinig@apple.com [Wed, 28 Apr 2010 01:28:34 +0000 (01:28 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=38238
Allow both WebKit and WebKit2 to link to the same WebCore.framework

Reviewed by Maciej Stachowiak.

WebCore:

* Configurations/WebCore.xcconfig: Use -allowable_client WebKit2 to add
WebKit2 to the list of frameworks that can link directly to WebCore. It
is not necessary for it to be an umbrella since we don't need to reexport
any symbols.

WebKit2:

* Configurations/WebKit2.xcconfig: Remove the OTHER_LDFLAGS. We don't
need to set WebCore as a sub_umbrella of WebKit2, since we are not
reexporting any of its symbols.

WebKitTools:

* Scripts/build-webkit: Remove the UMBRELLA_LDFLAGS override when building
WebCore for WebKit2, it is no longer necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Turn on AUTO_VACUUM = INCREMENTAL for all HTML5 databases.
dumi@chromium.org [Wed, 28 Apr 2010 01:24:12 +0000 (01:24 +0000)]
WebCore: Turn on AUTO_VACUUM = INCREMENTAL for all HTML5 databases.
https://bugs.webkit.org/show_bug.cgi?id=38191

Reviewed by David Levin.

Vacuum all databases when the number of free pages is at least 10%
of the number of total pages. Also, add a guard against a bug that
was fixed in SQLite only starting with version 3.6.16.

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::maximumSize):
(WebCore::SQLiteDatabase::freeSpaceSize):
(WebCore::SQLiteDatabase::totalSize):
(WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
(WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):
* platform/sql/SQLiteDatabase.h:
(WebCore::SQLiteDatabase::):
* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
(WebCore::SQLiteStatement::step):
* storage/Database.cpp:
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::incrementalVacuumIfNeeded):
* storage/Database.h:
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::postflightAndCommit):

LayoutTests: Adjusting the expected amount of space used by quota-tracking.html.
https://bugs.webkit.org/show_bug.cgi?id=38191

Reviewed by David Levin.

The expectations changed because of AUTO_VACUUM's overhead.

* platform/chromium/test_expectations.txt:
* storage/quota-tracking-expected.txt:
* storage/quota-tracking.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Wed, 28 Apr 2010 01:19:29 +0000 (01:19 +0000)]
2010-04-27  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Adler.

        Remove unnecessary header now that Chrome is updated
        https://bugs.webkit.org/show_bug.cgi?id=38211

        * public/win/WebThemeEngine.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 28 Apr 2010 01:15:29 +0000 (01:15 +0000)]
2010-04-27  James Robinson  <jamesr@chromium.org>

        Reviewed by David Levin.

        Fix a typo in chromium.py that causes NRWT to fail in --verbose
        mode in a Chromium checkout.
        https://bugs.webkit.org/show_bug.cgi?id=38234

        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Garret Kelly <gdk@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 01:09:40 +0000 (01:09 +0000)]
2010-04-27  Garret Kelly  <gdk@chromium.org>

        Reviewed by Darin Fisher.

        Turn all of the touch event handlers into RuntimeEnabledFeatures, and
        modify the createEvent methond on Document so that it won't create a
        TouchEvent if the feature is disabled.
        https://bugs.webkit.org/show_bug.cgi?id=37485

        * bindings/generic/RuntimeEnabledFeatures.cpp:
        * bindings/generic/RuntimeEnabledFeatures.h:
        (WebCore::RuntimeEnabledFeatures::touchEnabled):
        (WebCore::RuntimeEnabledFeatures::setTouchEnabled):
        (WebCore::RuntimeEnabledFeatures::ontouchstartEnabled):
        (WebCore::RuntimeEnabledFeatures::ontouchmoveEnabled):
        (WebCore::RuntimeEnabledFeatures::ontouchendEnabled):
        (WebCore::RuntimeEnabledFeatures::ontouchcancelEnabled):
        * dom/Document.cpp:
        (WebCore::Document::createEvent):
        * dom/Document.idl:
        * dom/Element.idl:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Jens Alfke <snej@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 00:55:06 +0000 (00:55 +0000)]
2010-04-27  Jens Alfke  <snej@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Add some notifications and an accessor to WebKit API
        https://bugs.webkit.org/show_bug.cgi?id=37625

        * dom/Node.cpp:
        (WebCore::Node::hasNonEmptyBoundingBox): New method.
        * dom/Node.h:
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::isKeyboardFocusable): Moved part of method into new Node method
2010-04-27  Jens Alfke  <snej@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Add some notifications and an accessor to WebKit API
        https://bugs.webkit.org/show_bug.cgi?id=37625

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::didFirstLayout):
        (WebKit::WebFrameClient::didFirstVisuallyNonEmptyLayout):
        * public/WebNode.h:
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchDidFirstLayout):
        (WebKit::FrameLoaderClientImpl::dispatchDidFirstVisuallyNonEmptyLayout):
        * src/WebElement.cpp:
        * src/WebNode.cpp:
        (WebKit::WebNode::hasNonEmptyBoundingBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Evan Martin <evan@chromium.org>
evan@chromium.org [Wed, 28 Apr 2010 00:41:17 +0000 (00:41 +0000)]
2010-04-27  Evan Martin  <evan@chromium.org>

        Reviewed by David Levin.

        [chromium] update test expectations for ancient linux bug
        https://bugs.webkit.org/show_bug.cgi?id=38229

        According to
        http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=plugins%2Fembed-attributes-setting.html
        this hasn't crashed in a long time, so the CRASH annotation is superfluous.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Jochen Eisinger <jochen@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 00:38:04 +0000 (00:38 +0000)]
2010-04-27  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Fix gyp build on Mac OS X with enable_svg=0.
        https://bugs.webkit.org/show_bug.cgi?id=38192

        * WebCore.gyp/WebCore.gyp: Only generate SVG symbols if enable_svg!=0.
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add missing unimplemented CSS properties to switch statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Darin Fisher <darin@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 00:28:28 +0000 (00:28 +0000)]
2010-04-27  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Remove deprecated form of didChangeLocationWithinPage
        https://bugs.webkit.org/show_bug.cgi?id=38178

        * public/WebFrameClient.h:
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
2010-04-27  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Remove deprecated form of didChangeLocationWithinPage
        https://bugs.webkit.org/show_bug.cgi?id=38178

        Switch over to implementing didNavigateWithinPage.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (TestWebViewDelegate::didNavigateWithinPage):
        (WebViewHost::didChangeLocationWithinPage):
        * DumpRenderTree/chromium/WebViewHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Tiger build.
slewis@apple.com [Tue, 27 Apr 2010 23:56:17 +0000 (23:56 +0000)]
Fix Tiger build.

* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::Carve):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Evan Martin <evan@chromium.org>
evan@chromium.org [Tue, 27 Apr 2010 23:42:07 +0000 (23:42 +0000)]
2010-04-27  Evan Martin  <evan@chromium.org>

        Unreviewed.

        Adding myself to commmitters list.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove more files I didn't intend to commit
slewis@apple.com [Tue, 27 Apr 2010 23:25:03 +0000 (23:25 +0000)]
Remove more files I didn't intend to commit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Tue, 27 Apr 2010 23:24:21 +0000 (23:24 +0000)]
2010-04-27  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Jian Li.

        [V8] Handle OR ('|') conditional in action_derivedsourcesallinone.py
        https://bugs.webkit.org/show_bug.cgi?id=38207

        No new tests.

        * WebCore.gyp/scripts/action_derivedsourcesallinone.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRevert Files I didn't intend to commit
slewis@apple.com [Tue, 27 Apr 2010 23:19:44 +0000 (23:19 +0000)]
Revert Files I didn't intend to commit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 François Sausset <sausset@gmail.com>
eric@webkit.org [Tue, 27 Apr 2010 23:13:03 +0000 (23:13 +0000)]
2010-04-27  François Sausset  <sausset@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        Additional MathML mroot & msqrt tests.
        https://bugs.webkit.org/show_bug.cgi?id=37044

        * mathml/presentation/roots.xhtml: Added.
        * platform/mac/mathml/presentation/roots-expected.checksum: Added.
        * platform/mac/mathml/presentation/roots-expected.png: Added.
        * platform/mac/mathml/presentation/roots-expected.txt: Added.
2010-04-27  François Sausset  <sausset@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        Implementation of the MathML mroot & msqrt elements.
        https://bugs.webkit.org/show_bug.cgi?id=37044

        Test: mathml/presentation/roots.xhtml

        * WebCore.xcodeproj/project.pbxproj:
        * css/mathml.css:
        (mroot):
        (mroot > * + *):
        (mroot > * + mrow, mroot > * + mfenced):
        * mathml/MathMLInlineContainerElement.cpp:
        (WebCore::MathMLInlineContainerElement::createRenderer):
        * mathml/RenderMathMLRoot.cpp: Added.
        (WebCore::RenderMathMLRoot::RenderMathMLRoot):
        (WebCore::RenderMathMLRoot::addChild):
        (WebCore::RenderMathMLRoot::paint):
        (WebCore::RenderMathMLRoot::layout):
        * mathml/RenderMathMLRoot.h: Added.
        * mathml/RenderMathMLSquareRoot.cpp: Added.
        (WebCore::RenderMathMLSquareRoot::RenderMathMLSquareRoot):
        (WebCore::RenderMathMLSquareRoot::paint):
        (WebCore::RenderMathMLSquareRoot::layout):
        * mathml/RenderMathMLSquareRoot.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Jeremy Orlow <jorlow@chromium.org>
eric@webkit.org [Tue, 27 Apr 2010 23:02:55 +0000 (23:02 +0000)]
2010-04-27  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Create new baseline for caret-rtl-2
        https://bugs.webkit.org/show_bug.cgi?id=38126

        http://trac.webkit.org/changeset/58191/ caused the caret-rtl-2 layout
        test to start failing under Chromium.  Since we're the only ones who
        run pixel tests, it's possible that the actual baseline needs to be updated
        and not just the chromium baseline...but I'm not sure.

        I'm tracking the overall progress of figuring this out here:
        https://bugs.webkit.org/show_bug.cgi?id=38109

        * platform/chromium-mac/editing/selection/caret-rtl-2-actual.checksum: Added.
        * platform/chromium-mac/editing/selection/caret-rtl-2-actual.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoI noticed an unused forwarding header.
darin@apple.com [Tue, 27 Apr 2010 22:56:54 +0000 (22:56 +0000)]
I noticed an unused forwarding header.

Reviewed by Maciej Stachowiak.

* ForwardingHeaders/runtime/PropertyMap.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=38154 FastMalloc calls madvise too often.
slewis@apple.com [Tue, 27 Apr 2010 22:55:22 +0000 (22:55 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=38154 FastMalloc calls madvise too often.
<rdar://problem/7834433> REGRESSSION: 1.5% PLT regression due to 56028 (return memory quicker).
To save on madvise calls when recommitting memory recommit the entire span and then carve it
instead of carving the span up and only committing the part that will be used immediately.

Reviewed by Geoff Garen.

* wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::New):
(WTF::TCMalloc_PageHeap::AllocLarge):
(WTF::TCMalloc_PageHeap::Carve):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 27 Apr 2010 22:51:27 +0000 (22:51 +0000)]
2010-04-27  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        Fix gcc 4.4.1 warnings on Linux in the chromium V8 bindings code.
        https://bugs.webkit.org/show_bug.cgi?id=38153

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::callFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Evan Martin <evan@chromium.org>
evan@chromium.org [Tue, 27 Apr 2010 22:48:31 +0000 (22:48 +0000)]
2010-04-27  Evan Martin  <evan@chromium.org>

        Unreviewed, making the bots happy.

        [chromium] bold bengali text not rendered properly on Linux
        https://bugs.webkit.org/show_bug.cgi?id=37904

        Check in a baseline for Mac pulled from the bots.

        * platform/mac/fast/text/international/bold-bengali-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 27 Apr 2010 22:04:42 +0000 (22:04 +0000)]
2010-04-27  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r58318.
        http://trac.webkit.org/changeset/58318
        https://bugs.webkit.org/show_bug.cgi?id=37215

        Broke test on Tiger.  Might just need updated results,
        unclear.

        * http/tests/inspector/console-resource-errors-expected.txt: Removed.
        * http/tests/inspector/console-resource-errors.html: Removed.
        * http/tests/inspector/console-tests.js: Removed.
        * inspector/console-clear.html:
        * inspector/console-dir.html:
        * inspector/console-dirxml.html:
        * inspector/console-format-collections-expected.txt:
        * inspector/console-format-collections.html:
        * inspector/console-format.html:
        * inspector/console-log-before-inspector-open.html:
        * inspector/console-tests.html:
        * inspector/console-tests.js: Added.
        (dumpConsoleMessages.callback):
        (dumpConsoleMessages):
        (dumpConsoleMessagesWithClasses.callback):
        (dumpConsoleMessagesWithClasses):
        (frontend_dumpConsoleMessages):
2010-04-27  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r58318.
        http://trac.webkit.org/changeset/58318
        https://bugs.webkit.org/show_bug.cgi?id=37215

        Broke test on Tiger.  Might just need updated results,
        unclear.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didFailLoading):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Evan Martin <evan@chromium.org>
evan@chromium.org [Tue, 27 Apr 2010 21:53:54 +0000 (21:53 +0000)]
2010-04-27  Evan Martin  <evan@chromium.org>

        Reviewed by David Levin.

        [chromium] bold bengali text not rendered properly on Linux
        https://bugs.webkit.org/show_bug.cgi?id=37904

        Add a layout test containing some bold Bengali text.

        * fast/text/international/bold-bengali.html: Added.
        * platform/chromium-linux/fast/text/international/bold-bengali-expected.checksum: Added.
        * platform/chromium-linux/fast/text/international/bold-bengali-expected.png: Added.
        * platform/chromium-linux/fast/text/international/bold-bengali-expected.txt: Added.
2010-04-27  Evan Martin  <evan@chromium.org>

        Reviewed by David Levin.

        [chromium] bold bengali text not rendered properly on Linux
        https://bugs.webkit.org/show_bug.cgi?id=37904

        We must let Skia do font fallback, rather than picking a font name
        then handing that to Skia.  For example, if we have Bengali text and
        choose FreeSans + fake bold, and then later reuse the name, Skia will
        helpfully use FreeSansBold (which doesn't cover Bengali).

        Test: fast/text/international/bold-bengali.html

        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::getFontDataForCharacters):
2010-04-27  Evan Martin  <evan@chromium.org>

        Reviewed by David Levin.

        [chromium] bold bengali text not rendered properly on Linux
        Roll forward Chrome DEPS so we get new Skia API.

        * DEPS: update Chrome to r45696.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 27 Apr 2010 21:52:20 +0000 (21:52 +0000)]
2010-04-27  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Adler.

        Fix warnings emitted by gcc 4.4.1 on linux in chromium-specific platform graphics files.
        https://bugs.webkit.org/show_bug.cgi?id=38158

        Most of the issues are signed/unsigned mismatches, but there are a few unusued variables
        and functions mixed in.

        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::adjustTextRenderMode):
        (WebCore::TextRunWalker::getTextRun):
        (WebCore::TextRunWalker::getNormalizedTextRun):
        (WebCore::TextRunWalker::setGlyphXPositions):
        (WebCore::glyphIndexForXPositionInScriptRun):
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):
        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::setupPaint):
        * platform/graphics/chromium/HarfbuzzSkia.cpp:
        (WebCore::getOutlinePoint):
        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        (WebCore::GraphicsContext3D::getImageData):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::isCoordinateSkiaSafe):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::strokeRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-04-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 27 Apr 2010 21:51:23 +0000 (21:51 +0000)]
2010-04-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Add test for NodeIterator prototype change behavior
        https://bugs.webkit.org/show_bug.cgi?id=38219

        In the process of remove the custom code from NodeIterator, we thought
        we fixed a subtle bug where iterating over nodes from another frame
        would get the wrong prototype chain.  This test documents that we
        didn't actually change the behavior and we still have the bug.

        * traversal/node-iterator-prototype-expected.txt: Added.
        * traversal/node-iterator-prototype.html: Added.
        * traversal/resources/node-iterator-prototype-frame.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/7911140> Hitting the "delete" key goes back twice
jhoneycutt@apple.com [Tue, 27 Apr 2010 21:35:45 +0000 (21:35 +0000)]
<rdar://problem/7911140> Hitting the "delete" key goes back twice

Reviewed by Maciej Stachowiak.

* WebView.cpp:
(WebView::keyDown):
Return true if we navigated back or forward from the key event to
prevent the event from being propagated further.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58337 268f45cc-cd09-0410-ab3c-d52691b4dbfc