15 years ago Windows build fix
aroben [Tue, 23 Oct 2007 00:33:27 +0000 (00:33 +0000)]
    Windows build fix

        Reviewed by NOBODY.

        * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
darin [Mon, 22 Oct 2007 23:36:36 +0000 (23:36 +0000)]

        Reviewed by Geoff.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15632
          js1_5/Array/array-001.js test failing

        One of the JavaScriptCore tests was failing; it failed because of
        my change to NumberImp::getUInt32. The incorrect code I copied was
        from JSImmediate::getUInt32, and was a pre-existing bug.

        This patch fixes correctness, but will surely slow down SunSpider.
        We may be able to code this tighter and get the speed back.

        * kjs/JSImmediate.h:
        (KJS::JSImmediate::getInt32): Renamed from toInt32 to more accurately
        reflect the fact that this function only returns true if the value is
        accurate (no fractional part, etc.). Changed code so that it returns
        false when the value has a fraction.
        (KJS::JSImmediate::getUInt32): Ditto.

        * kjs/internal.cpp:
        (KJS::NumberImp::getInt32): Changed code so that it returns false when
        the value has a fraction. Restores the old behavior.
        (KJS::NumberImp::getUInt32): Ditto.

        * kjs/value.h:
        (KJS::JSValue::getInt32): Updated for name change.
        (KJS::JSValue::getUInt32): Ditto.
        (KJS::JSValue::toInt32): Ditto.
        (KJS::JSValue::toUInt32): Ditto.


        Reviewed by Geoff.

        - tests for http://bugs.webkit.org/show_bug.cgi?id=15632

        Added tests for cases where you use something that looks like an array
        index, but it has a fractional part.

        * fast/js/kde/resources/Array.js: Added tests.
        * fast/js/kde/Array-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-22 Jon Honeycutt <jhoneycutt@apple.com>
honeycutt [Mon, 22 Oct 2007 23:29:21 +0000 (23:29 +0000)]
2007-10-22  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Anders.

        <rdar://5548217>: [NTS] Java 6 update 3 crashes Safari when loading a
        java page

        We purposefully do not destroy our Java VM when its reference count
        reaches 0, but we were unloading our JavaPlugin.dll when its reference
        count reached 0, which lost the reference to the VM. This led to our
        process trying to create a new VM the next time a page using Java was
        loaded, and the JNI spec states that a single process is not allowed to
        create more than one VM. The fix is to avoid unloading the Java plugin
        via our PluginQuirkDontUnloadPlugin.

        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady.
darin [Mon, 22 Oct 2007 22:18:24 +0000 (22:18 +0000)]
    Reviewed by Brady.

        - fix crash seen when running JavaScriptCore tests

        * kjs/array_instance.cpp: (KJS::ArrayInstance::mark):
        Copy and paste error: I accidentally had code here that was
        making a copy of the HashMap -- that's illegal inside a mark
        function and was unnecessary. The other callsite was modifying
        the map as it iterated it, but this function is not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd results for new layout tests for transforms.
hyatt [Mon, 22 Oct 2007 21:32:56 +0000 (21:32 +0000)]
Add results for new layout tests for transforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd two new layout tests for transforms.
hyatt [Mon, 22 Oct 2007 21:32:24 +0000 (21:32 +0000)]
Add two new layout tests for transforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for bug 15624, make transforms work properly with opacity.
hyatt [Mon, 22 Oct 2007 21:29:37 +0000 (21:29 +0000)]
    Fix for bug 15624, make transforms work properly with opacity.

        Make sure a unitless 0 is allowed as an angle argument to rotation/skew.

        Reviewed by Mitz Pettel


        * css/CSSParser.cpp:
        * rendering/RenderLayer.cpp:
        * rendering/RenderLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
mjs [Mon, 22 Oct 2007 21:26:52 +0000 (21:26 +0000)]
    Reviewed by Oliver.

        - Avoid moving floats into integer registers in jsNumber() for 3% speedup on SunSpider

        * kjs/JSImmediate.h:
        (KJS::JSImmediate::fromDouble): Avoid moving floats to integer
        registers since this is very slow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric Seidel.
darin [Mon, 22 Oct 2007 18:39:46 +0000 (18:39 +0000)]
    Reviewed by Eric Seidel.

        - http://bugs.webkit.org/show_bug.cgi?id=15617
          improve speed of integer conversions

        Makes SunSpider 6% faster.

        * kjs/JSImmediate.h: Added toInt32 and toUInt32, with separate versions for
        32-bit and 64-bit.
        * kjs/value.h:
        (KJS::JSValue::getUInt32): Call JSImmediate::toUInt32.

        * kjs/internal.h: Added getInt32.
        * kjs/internal.cpp:
        (KJS::NumberImp::getInt32): Added.
        (KJS::NumberImp::getUInt32): Replaced with more-optimal implementation
        stolen from JSValue.

        * kjs/value.h:
        (KJS::jsNumber): Marked ALWAYS_INLINE, because this wasn't getting
        (KJS::JSValue::getInt32): Added.
        (KJS::JSValue::getUInt32): Changed to call the new JSImmediate::toUInt32
        to avoid converting from float to double.
        (KJS::JSValue::toInt32): Made inline, separated out the slow case.
        (KJS::JSValue::toUInt32): Ditto.
        * kjs/value.cpp:
        (KJS::JSCell::getInt32): Added.
        (KJS::JSValue::toInt32SlowCase): Renamed from toInt32. Changed to use the
        new getInt32. Added a faster case for in-range numbers.
        (KJS::JSValue::toUInt32SlowCase): Ditto.
        (KJS::JSValue::toUInt16): Added a faster case for in-range numbers.

        * JavaScriptCore.exp: Updated for changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - Removed a leak that was fixed.
kmccullo [Mon, 22 Oct 2007 18:02:46 +0000 (18:02 +0000)]
    - Removed a leak that was fixed.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
kmccullo [Mon, 22 Oct 2007 17:48:15 +0000 (17:48 +0000)]
    Reviewed by Darin.

        - Changed the Client so that the DebuggerDocument now own the
        ServerConnection.  This simplifies ownership and cleanup.

        * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
        * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
        * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
        until after we have a server which we are attached to.
        * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
        out previously.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWindows build fix
aroben [Mon, 22 Oct 2007 17:43:49 +0000 (17:43 +0000)]
Windows build fix


        Windows build fix

        Reviewed by NOBODY.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Turn off
        warning about implicit conversion to bool.


        Windows build fix

        Reviewed by NOBODY.

        * WebCore.vcproj/WebCore.vcproj: Copy header files from platform/sql.
        * page/Page.cpp: Touched to force the header files to be copied.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Simon.
zimmermann [Mon, 22 Oct 2007 17:14:58 +0000 (17:14 +0000)]
Reviewed by Simon.

Move textPath related SVGChar data in it's own structure SVGCharOnPath.
Store a pointer to that datastructure inside SVGChar, instead of 4 floats & one bool.

Saves space for the common case. And allows me to add more data (another float) to support
glyph-orientation-* on textPath later on...

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWhen running build-testkjs make sure it's called through the perl interpreter, to...
hausmann [Mon, 22 Oct 2007 16:01:04 +0000 (16:01 +0000)]
When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-22 Alp Toker <alp@atoker.com>
alp [Mon, 22 Oct 2007 15:06:58 +0000 (15:06 +0000)]
2007-10-22  Alp Toker  <alp@atoker.com>

        Reviewed by Nikolas Zimmermann.

        Implement more GraphicsContextCairo stubs.

        Remove a hack "to work around no current point bug" that was breaking
        canvas tests.

        Fix warnings.

        * platform/graphics/cairo/CairoPath.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        * platform/graphics/cairo/PathCairo.cpp:
        * platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp:
        * platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWrap WEXITSTATUS with a little exitStatus() helper function that falls back to the...
hausmann [Mon, 22 Oct 2007 14:54:05 +0000 (14:54 +0000)]
Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix compilation from a clean build with the database feature disabled.
hausmann [Mon, 22 Oct 2007 14:53:57 +0000 (14:53 +0000)]
Fix compilation from a clean build with the database feature disabled.
JSCustomVersionChangeCallback.cpp doesn't actually need the SQL header file, just ScriptInterpreter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-22 Mark Rowe <mrowe@apple.com>
bdash [Mon, 22 Oct 2007 13:56:45 +0000 (13:56 +0000)]
2007-10-22  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * kjs/array_instance.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * fast/js/kde/resources/Array.js: Added tests to cover missing value behavior
darin [Mon, 22 Oct 2007 13:46:35 +0000 (13:46 +0000)]
    * fast/js/kde/resources/Array.js: Added tests to cover missing value behavior
        (not the same as undefined values in arrays). This matches the ECMA JavaScript
        specification, but doesn't exactly match Firefox, because Firefox incorrectly
        inserts undefined values rather than missing values in array literals with
        extra commas.
        * fast/js/kde/Array-expected.txt: Updated with results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
darin [Mon, 22 Oct 2007 13:35:17 +0000 (13:35 +0000)]

        Reviewed by Maciej.

        - http://bugs.webkit.org/show_bug.cgi?id=15606
          make cut-off for sparse vs. dense arrays smarter for speed with large arrays

        Makes the morph test in SunSpider 26% faster, and the overall
        benchmark 3% faster.

        This also fixes some small problems we had with the distinction
        between nonexistent and undefined values in arrays.

        * kjs/array_instance.h: Tweaked formatting and naming.
        * kjs/array_instance.cpp: Copied from kjs/array_object.cpp.
        (KJS::storageSize): Added. Computes the size of the storage given a vector length.
        (KJS::increasedVectorLength): Added. Implements the rule for resizing the vector.
        (KJS::isDenseEnoughForVector): Added.
        (KJS::ArrayInstance::ArrayInstance): Initialize the new fields.
        (KJS::ArrayInstance::~ArrayInstance): Since m_storage is now never 0, delete it.
        (KJS::ArrayInstance::getItem): Updated for name changes.
        (KJS::ArrayInstance::lengthGetter): Ditto.
        (KJS::ArrayInstance::inlineGetOwnPropertySlot): Added. Allows both versions of
        getOwnPropertySlot to share more code.
        (KJS::ArrayInstance::getOwnPropertySlot): Just refactored, no code change.
        (KJS::ArrayInstance::put): Added logic for extending the vector as long as the
        array is dense enough. Also keep m_numValuesInVector up to date.
        (KJS::ArrayInstance::deleteProperty): Added code to keep m_numValuesInVector
        up to date.
        (KJS::ArrayInstance::getPropertyNames): Fixed bug where this would omit names
        for array indices with undefined values.
        (KJS::ArrayInstance::increaseVectorLength): Renamed from resizeStorage. Also
        simplified to only handle getting larger.
        (KJS::ArrayInstance::setLength): Added code to update m_numValuesInVector, to
        zero out the unused part of the vector and to delete the map if it's no longer
        (KJS::ArrayInstance::mark): Tweaked formatting.
        (KJS::compareByStringForQSort): Ditto.
        (KJS::ArrayInstance::sort): Ditto.
        (KJS::compareWithCompareFunctionForQSort): Ditto.
        (KJS::ArrayInstance::compactForSorting): Fixed bug where this would turn
        undefined values into nonexistent values in some cases.

        * kjs/array_object.h: Removed MAX_ARRAY_INDEX.
        * kjs/array_object.cpp: Removed ArrayInstance. Moved to a separate file.

        * JavaScriptCore.pri: Added array_instance.cpp.
        * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
        * kjs/AllInOneFile.cpp: Ditto.


        * fast/js/kde/resources/Array.js: Added tests to cover missing value behavior
        (not the same as undefined values in arrays). This matches the ECMA JavaScript
        specification, but doesn't exactly match Firefox.
        * fast/js/kde/Array-expected.txt: Updated with results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
andrew [Mon, 22 Oct 2007 12:56:02 +0000 (12:56 +0000)]

        Reviewed by Mark Rowe.

        Fix for local database support after r26879
        Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set

        * Configurations/JavaScriptCore.xcconfig:


        Reviewed by Mark Rowe.

        Fix for local database support after r26879
        Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set

        * Configurations/WebCore.xcconfig:
        * WebCore.pro:
        * WebCore.vcproj/build-generated-files.sh:


        Reviewed by Mark Rowe.

        Fix for local database support after r26879
        Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set

        * Configurations/WebKit.xcconfig:


        Reviewed by Mark Rowe.

        Fix for local database support after r26879
        Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBuild fix for the non-qmake builds.
hausmann [Mon, 22 Oct 2007 11:39:34 +0000 (11:39 +0000)]
Build fix for the non-qmake builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoDisable the database feature in the qmake build for now.
hausmann [Mon, 22 Oct 2007 11:28:44 +0000 (11:28 +0000)]
Disable the database feature in the qmake build for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMake disabling the database feature (ENABLE_DATABASE=0) work by
hausmann [Mon, 22 Oct 2007 11:22:53 +0000 (11:22 +0000)]
Make disabling the database feature (ENABLE_DATABASE=0) work by
placing various #ifdefs into the code and making the compilation of
some files optional.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-22 Alp Toker <alp@atoker.com>
alp [Mon, 22 Oct 2007 10:41:36 +0000 (10:41 +0000)]
2007-10-22  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        [GTK] Text selection behaviour different in Debug and Release builds

        [GTK] Text editor caret does not blink

        Never allow control to reach the end of non-void functions.

        Return more sensible values, or in some cases, nulls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoImplement ResourceHandle::loadResourceSynchronously using ResourceHandle and a specia...
hausmann [Mon, 22 Oct 2007 09:35:10 +0000 (09:35 +0000)]
Implement ResourceHandle::loadResourceSynchronously using ResourceHandle and a special ResourceHandleClient. This approach has the possible danger of reentrancy.

Signed-off-by: Simon Hausmann <hausmann@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago- Do not build testkjs as an application bundle. This is
hausmann [Mon, 22 Oct 2007 09:33:10 +0000 (09:33 +0000)]
- Do not build testkjs as an application bundle. This is
needed for run-javascriptcore-tests on OSX.
- Also, based on r26633, allow to test the WebKit/Qt port on OSX.
- Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
as we do not have -rpath on OSX.

Signed-off-by: Simon Hausmann <hausmann@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
hausmann [Mon, 22 Oct 2007 09:24:29 +0000 (09:24 +0000)]
2007-10-15 Holger Hans Peter Freyther <zecke@selfish.org>

        Style fix. It is allowed to attempt to delete 0.

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
hausmann [Mon, 22 Oct 2007 09:24:23 +0000 (09:24 +0000)]
2007-10-15 Holger Hans Peter Freyther <zecke@selfish.org>

        Make it actually localizable....

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
hausmann [Mon, 22 Oct 2007 09:24:17 +0000 (09:24 +0000)]
2007-10-15 Holger Hans Peter Freyther <zecke@selfish.org>

        Adjust the code to obey the Coding Style.

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
hausmann [Mon, 22 Oct 2007 09:24:10 +0000 (09:24 +0000)]
2007-10-15 Holger Hans Peter Freyther <zecke@selfish.org>

        Return a non empty string in more functions.

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
hausmann [Mon, 22 Oct 2007 09:24:03 +0000 (09:24 +0000)]
2007-10-15 Holger Hans Peter Freyther <zecke@selfish.org>

        Shrink the TemporaryLinkStubs and move the
        Frame::setNeedsReapplyStyles stub to FrameQt.cpp

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-15 Holger Hans Peter Freyther <zecke@selfish.org>
hausmann [Mon, 22 Oct 2007 09:18:54 +0000 (09:18 +0000)]
2007-10-15 Holger Hans Peter Freyther <zecke@selfish.org>

        Implement the WebCore::fileSize function. The
        implementation assumes that QFileInfo will cache
        the result of the stat so that info.size() and
        info.exists() use the same stat result.

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-21 Alp Toker <alp@atoker.com>
alp [Mon, 22 Oct 2007 09:15:45 +0000 (09:15 +0000)]
2007-10-21  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Use the portable GLib time function.

        Use event timestamps rather than the current time where available.

        Rename SharedTimerLinux.cpp since it isn't Linux-specific.

        * WebCore.pro:
        * platform/gtk/MouseEventGtk.cpp:
        * platform/gtk/SystemTimeGtk.cpp: Added.
        * platform/gtk/SharedTimerGtk.cpp: Copied from platform/gtk/SharedTimerLinux.cpp.
        * platform/gtk/SharedTimerLinux.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix support for Signed-off-by detection in prepare-ChangeLog
hausmann [Mon, 22 Oct 2007 08:42:40 +0000 (08:42 +0000)]
Fix support for Signed-off-by detection in prepare-ChangeLog
--git-commit. The Signed-off-by tag does not appear in the header
but usually at the end.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for 15596, regression from my transform changes. Preserve null checks...
hyatt [Mon, 22 Oct 2007 07:31:01 +0000 (07:31 +0000)]
    Fix for 15596, regression from my transform changes.  Preserve null checks on the clip rects calls for parent(),
        since the method is called on orphaned layers.  This is not very well understood.

        Reviewed by eric

        * rendering/RenderLayer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-21 Mark Rowe <mrowe@apple.com>
bdash [Mon, 22 Oct 2007 06:26:41 +0000 (06:26 +0000)]
2007-10-21  Mark Rowe  <mrowe@apple.com>

        Reviewed by Alp.

        Bug 15575: [GTK] Implement threading using GThread

        * wtf/Platform.h: Do not enable pthreads for Gtk.

2007-10-21  Mark Rowe  <mrowe@apple.com>

        Reviewed by Alp.

        Bug 15575: [GTK] Implement threading using GThread

        * WebCore.pro: Remove ThreadingPthreads.cpp from the Gtk build and link against libgthreads.
        * loader/icon/IconDatabase.cpp: Initialize threading before the mutex is created to be compatible with gthreads.
        * platform/Threading.h:
        * platform/gtk/ThreadingGtk.cpp: Threading implementation in terms of GThread, based heavily on the pthreads implementation.
        * storage/Database.cpp:
        (WebCore::Database::Database): Initialize threading when Database is used so that it will be initialized even
        if the icon database is compiled out

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-21 Eric Seidel <eric@webkit.org>
eseidel [Mon, 22 Oct 2007 06:08:42 +0000 (06:08 +0000)]
2007-10-21  Eric Seidel  <eric@webkit.org>

        Reviewed by mjs.

        * sunspider: make --shark only sample from testkjs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-21 Mark Rowe <mrowe@apple.com>
bdash [Mon, 22 Oct 2007 05:44:14 +0000 (05:44 +0000)]
2007-10-21  Mark Rowe  <mrowe@apple.com>

        Reviewed by Mitz.

        Fix http://bugs.webkit.org/show_bug.cgi?id=15603
        Bug 15603: Regression(r26847): Crash when sorting an empty array from JavaScript

        * kjs/array_object.cpp:
        (KJS::freeStorage): Reinstate null-check that was removed in r26847.

2007-10-21  Mark Rowe  <mrowe@apple.com>

        Reviewed by Mitz.

        Test for http://bugs.webkit.org/show_bug.cgi?id=15603
        Bug 15603: Regression(r26847): Crash when sorting an empty array from JavaScript

        * fast/js/kde/Array-expected.txt:
        * fast/js/kde/resources/Array.js: Update to cover sorting an empty array.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-21 Mark Rowe <mrowe@apple.com>
bdash [Mon, 22 Oct 2007 03:16:22 +0000 (03:16 +0000)]
2007-10-21  Mark Rowe  <mrowe@apple.com>

        Reviewed by Eric.

        Fix run-javascriptcore-tests for Gtk.

        * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Eric.
mjs [Mon, 22 Oct 2007 03:13:16 +0000 (03:13 +0000)]
    Rubber stamped by Eric.

        - added crypto tests (already balanced)

        * tests/LIST:
        * tests/crypto-aes.js: Added.
        * tests/crypto-md5.js: Added.
        * tests/crypto-sha1.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-21 Mark Rowe <mrowe@apple.com>
bdash [Mon, 22 Oct 2007 02:26:38 +0000 (02:26 +0000)]
2007-10-21  Mark Rowe  <mrowe@apple.com>

        Build fix.

        * ksvg2/css/SVGCSSStyleSelector.cpp: Use fabsf when dealing with a float to prevent the
        implicit conversion warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-21 Alp Toker <alp@atoker.com>
alp [Mon, 22 Oct 2007 02:05:34 +0000 (02:05 +0000)]
2007-10-21  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Implement spelling and grammar mistake underlining with Pango/Cairo.

        This change does not add any actual support for spelling or grammar
        checking to any port.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
mjs [Sun, 21 Oct 2007 23:16:05 +0000 (23:16 +0000)]
    Reviewed by Adam.

        - rebalance new tests

        Scaled the new tests so they take 400-600ms on a reasonably normal user setup:

        Internet Explorer 7, Window XP, Dell Latitude D810 with a 2.13GHz Pentium M

        This balances them with the existing tests.

        * tests/access-binary-trees.js:
        * tests/access-nsieve.js:
        * tests/bitops-nsieve-bits.js:
        * tests/math-partial-sums.js:
        * tests/math-spectral-norm.js:
        * tests/string-fasta.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-21 Alp Toker <alp@atoker.com>
alp [Sun, 21 Oct 2007 22:44:54 +0000 (22:44 +0000)]
2007-10-21  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Cairo canvas fixes:

        Fix a refcounting issue leading to leaks and crashes on canvas

        Delegate memory management of canvas images to Cairo.

        Mark unhandled conditions with notImplemented() instead of silently
        ignoring them.

        * html/CanvasRenderingContext2D.cpp:
        * html/CanvasStyle.cpp:
        * html/CanvasStyle.h:
        * html/HTMLCanvasElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoNot reviewed.
zimmermann [Sun, 21 Oct 2007 21:17:31 +0000 (21:17 +0000)]
Not reviewed.
Forgot to land the new computed style results in fast/css - after the addition of glyph-orientation-*.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Eric.
zimmermann [Sun, 21 Oct 2007 20:35:24 +0000 (20:35 +0000)]
Reviewed by Eric.

Handle glyph-orientation-vertical / glyph-orientation-horizontal SVG CSS properties.

The SVG layouting code itself doesn't handle these properties yet,
it's just about recognizing them in the SVG CSS engine.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebKitSite:
ddkilzer [Sun, 21 Oct 2007 18:40:57 +0000 (18:40 +0000)]

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15592
          DOM Exception opening up client-side database example for the first time

        There was a race condition when creating the WebKitStickyNotes table for the
        first time in which the loaded() function (renamed to loadNotes()) could be
        called before the table was created.  Prevent this by only calling loadNotes()
        in an executeSql() callback after we know the table exists, or after we know
        the table has been created.

        * misc/DatabaseExample.html: Renamed loaded() function to loadNotes().
        Created a new loaded() function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fix Windows build
darin [Sun, 21 Oct 2007 18:37:23 +0000 (18:37 +0000)]
    - fix Windows build

        * kjs/array_instance.h: Removed unused ExecState parameter.
        * kjs/array_object.cpp:
        (KJS::ArrayInstance::put): Ditto.
        (KJS::ArrayInstance::setLength): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-21 Christian Dywan <christian@twotoasts.de>
alp [Sun, 21 Oct 2007 18:36:11 +0000 (18:36 +0000)]
2007-10-21  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Alp.

        Use glib's path separator on gtk

        * platform/gtk/FileSystemGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * kjs/array_object.cpp: (KJS::ArrayInstance::put):
darin [Sun, 21 Oct 2007 16:53:12 +0000 (16:53 +0000)]
    * kjs/array_object.cpp: (KJS::ArrayInstance::put):
        Add missing assignment that was causing regression test crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Sun, 21 Oct 2007 15:12:08 +0000 (15:12 +0000)]
    Reviewed by Maciej.

        - http://bugs.webkit.org/show_bug.cgi?id=15585
          speed up sparse arrays by using a custom map

        Speeds up SunSpider by 10%.

        * kjs/array_object.cpp:
        (allocateStorage): Leave room for an additional pointer.
        (reallocateStorage): Ditto.
        (freeStorage): Ditto.
        (ArrayInstance::~ArrayInstance): Delete the overflow map if present.
        (ArrayInstance::getItem): Read values from the overflow map if present.
        Removed the check of length, since it slows down the common case.
        (ArrayInstance::getOwnPropertySlot): Ditto. Also removed the fallback
        to the property map.
        (ArrayInstance::put): Write values into the overflow map as needed.
        Also create overflow map when needed.
        (ArrayInstance::deleteProperty): Remove values from the overflow map
        as appropriate.
        (ArrayInstance::getPropertyNames): Add a name for each identifier in
        the property map. This is extremely inefficient.
        (ArrayInstance::setLength): Remove any values in the overflow map
        that are past the new length, as we formerly did with the property map.
        (ArrayInstance::mark): Mark any values in the overflow map.
        (compareByStringForQSort): Removed unneeded undefined case, since
        compactForSorting guarantees we will have no undefined values.
        (compareWithCompareFunctionForQSort): Ditto.
        (ArrayInstance::compactForSorting): Copy all the values out of the
        overflow map and destroy it.

        * kjs/property_map.h: Removed now-unused getSparseArrayPropertyNames.
        * kjs/property_map.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz [Sun, 21 Oct 2007 07:10:55 +0000 (07:10 +0000)]

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15259
          <rdar://problem/5499902> REGRESSION: Text overflows when using word spacing and centering (affects myspace.com music videos page)

        Test: fast/text/word-space.html

        * rendering/RenderBlock.cpp:
        (WebCore::stripTrailingSpace): Added word-spacing to the width of the
        space being stripped out.
        * rendering/RenderText.cpp:
        (WebCore::RenderText::trimmedPrefWidths): Changed handling of
        leading space. Since Font::width includes leading space width but not
        leading word spacing, this method needs to either remove the width of a
        space character or add word spacing,
        depending on stripFrontSpaces.
        (WebCore::RenderText::calcPrefWidths): Corrected the check for adding
        trailing word spacing so that it would work in the case where the last
        space is ignored.
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::computeHorizontalPositionsForLine): Changed to
        actually add word spacing to the total width.


        Reviewed by Dave Hyatt.

        - test for http://bugs.webkit.org/show_bug.cgi?id=15259
          <rdar://problem/5499902> REGRESSION: Text overflows when using word spacing and centering (affects myspace.com music videos page)

        * fast/text/word-space.html: Added.
        * platform/mac/fast/css/word-space-extra-expected.txt: Updated result.
        * platform/mac/fast/text/word-space-expected.checksum: Added.
        * platform/mac/fast/text/word-space-expected.png: Added.
        * platform/mac/fast/text/word-space-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd new transforms directory along with an initial layout test.
hyatt [Sun, 21 Oct 2007 06:48:49 +0000 (06:48 +0000)]
Add new transforms directory along with an initial layout test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd new transforms directory along with an initial layout test.
hyatt [Sun, 21 Oct 2007 06:44:27 +0000 (06:44 +0000)]
Add new transforms directory along with an initial layout test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Land support for the transform CSS property. Basic painting now works proper...
hyatt [Sun, 21 Oct 2007 06:39:56 +0000 (06:39 +0000)]
    Land support for the transform CSS property.  Basic painting now works properly. There are many open issues
        that will have to be covered by individual bugs.

        Reviewed by olliej

        * css/CSSParser.cpp:
        * rendering/RenderLayer.cpp:
        * rendering/RenderLayer.h:
        * rendering/RenderObject.cpp:
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:
        * rendering/RenderTableRow.h:
        * rendering/RenderTreeAsText.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
thatcher [Sun, 21 Oct 2007 06:36:44 +0000 (06:36 +0000)]
    Reviewed by Adam.

        Add basic @font-face to the Web Inspector.

        * page/InspectorController.cpp:
        (WebCore::InspectorResource::type): Check for CachedResource::FontResource.
        * page/inspector/Resource.js: Add support for Font types and font preview in the icon.
        * page/inspector/ResourcePanel.js: Show a font preview for font resources.
        * page/inspector/inspector.css: Style for the font preview and font icon.
        * page/inspector/inspector.js: Add font mime types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark Rowe.
weinig [Sun, 21 Oct 2007 05:19:13 +0000 (05:19 +0000)]
    Reviewed by Mark Rowe.

            - http://bugs.webkit.org/show_bug.cgi?id=14393
              Column on the left side of the Web Inspector should have a smaller minimum width for resizing
            - http://bugs.webkit.org/show_bug.cgi?id=14394
              Left pane of the Web Inspector "shakes" when resizing it to maximum width

        * page/inspector/inspector.js: Change the constraint logic to only enforce a 100px min-width
          and window.innerWidth - 100 max-width for the sidebar.  The change also makes the viewbuttons
          move with the sidebar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz [Sun, 21 Oct 2007 04:00:28 +0000 (04:00 +0000)]

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15208
          display:table causes the collapsed text to show at a different position when expanded

        Test: fast/table/insert-before-anonymous-ancestors.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::addChild): Rolled out r11579. I think whatever
        that change was supposed to accomplish has since been done in other
        places in the code.


        Reviewed by Dave Hyatt.

        - test and updated results for http://bugs.webkit.org/show_bug.cgi?id=15208
          display:table causes the collapsed text to show at a different position when expanded

        * fast/table/form-in-table-before-misnested-text-crash-css-expected.txt:
        * fast/table/form-in-table-before-misnested-text-crash-expected.txt:
        * fast/table/insert-before-anonymous-ancestors.html: Added.
        * fast/table/section-in-table-before-misnested-text-crash-css-expected.txt:
        * fast/table/section-in-table-before-misnested-text-crash-expected.txt:
        * platform/mac/fast/table/insert-before-anonymous-ancestors-expected.checksum: Added.
        * platform/mac/fast/table/insert-before-anonymous-ancestors-expected.png: Added.
        * platform/mac/fast/table/insert-before-anonymous-ancestors-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-20 Eric Seidel <eric@webkit.org>
eseidel [Sun, 21 Oct 2007 03:06:33 +0000 (03:06 +0000)]
2007-10-20  Eric Seidel  <eric@webkit.org>

        Reviewed by aroben.

        * Scripts/find-extra-includes: fix path matching regex to not match ".patch"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-20 Eric Seidel <eric@webkit.org>
eseidel [Sun, 21 Oct 2007 02:43:49 +0000 (02:43 +0000)]
2007-10-20  Eric Seidel  <eric@webkit.org>

        Reviewed by darin.

        Add improved argument handling to run-sunspider, including
        --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
        Also re-factor code into subroutines

        * Scripts/build-dumprendertree: removed bogus comments
        * Scripts/build-testkjs: Added.
        * Scripts/run-javascriptcore-tests: use build-testkjs
        * Scripts/run-sunspider: improved argument handling, abstraction
        * Scripts/run-webkit-tests: improved abstraction

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-20 Mark Rowe <mrowe@apple.com>
bdash [Sun, 21 Oct 2007 02:41:03 +0000 (02:41 +0000)]
2007-10-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dave Hyatt.

        Fix http://bugs.webkit.org/show_bug.cgi?id=15584
        Bug 15584: REGRESSION(r26696): GtkLauncher segfaults on WebCore::WidthIterator::advance

        * platform/Font.cpp:
        (WebCore::Font::glyphDataForCharacter): If the fallback page exists but does not have a
        glyph for the character, fall back to the missing glyph data rather than returning an
        invalid GlyphData.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark.
mjs [Sat, 20 Oct 2007 23:01:19 +0000 (23:01 +0000)]
    Reviewed by Mark.

        - Add more new tests, mostly from the computer language shootout. Not normalized yet.

        * TODO:
        * tests/LIST:
        * tests/access-binary-trees.js: Added.
        * tests/access-nsieve.js: Added.
        * tests/bitops-nsieve-bits.js: Added.
        * tests/math-partial-sums.js: Added.
        * tests/math-spectral-norm.js: Added.
        * tests/string-fasta.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-20 Jasper Bryant-Greene <m@ni.ac.nz>
bdash [Sat, 20 Oct 2007 22:54:46 +0000 (22:54 +0000)]
2007-10-20  Jasper Bryant-Greene  <m@ni.ac.nz>

        Reviewed by Maciej.

        Changed the hard-coded scroll delta in WheelEventGtk from 120 to 0.25,
        as suggested by George Wright in #15108 (which this patch will

        This gives a more sane scrolling behaviour, rather than the
        jumping to the end or start of the document as occurred previously.

        * platform/gtk/WheelEventGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix reviewer in ChangeLog.
mjs [Sat, 20 Oct 2007 22:43:10 +0000 (22:43 +0000)]
Fix reviewer in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
mjs [Sat, 20 Oct 2007 22:42:45 +0000 (22:42 +0000)]
    Reviewed by Eric.

        * TODO: Updated to note areas that are now well-covered.

        - Change the tests and the driver to avoid leaving large object
        graphs hanging around, since that throws off the subsequent tests.

        * resources/sunspider-standalone-driver.js:
        * tests/3d-cube.js:
        * tests/3d-morph.js:
        * tests/3d-raytrace.js:
        * tests/bitops-bitwise-and.js:
        * tests/string-base64.js:
        * tests/string-tagcloud.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Sat, 20 Oct 2007 22:38:44 +0000 (22:38 +0000)]
    Reviewed by Maciej.

        - http://bugs.webkit.org/show_bug.cgi?id=15579
          stop churning identifier reference counts copying Completion objects

        * kjs/completion.h: Replace the Identifier with an Identifier*.
        * kjs/nodes.cpp:
        (ForInNode::execute): Update for change to Completion constructor.
        (ContinueNode::execute): Ditto.
        (BreakNode::execute): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-20 Alp Toker <alp@atoker.com>
alp [Sat, 20 Oct 2007 22:10:04 +0000 (22:10 +0000)]
2007-10-20  Alp Toker  <alp@atoker.com>

        Reviewed by Eric.

        Support text boundary detection.
        Move TextBoundariesWin.cpp to platform/ since it's portable and useful.
        Split out and implement some TemporaryLinkStubs.

        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * platform/TextBoundariesICU.cpp: Copied from WebCore/platform/win/TextBoundariesWin.cpp.
        * platform/gtk/Language.cpp: Added.
        * platform/gtk/TemporaryLinkStubs.cpp:
        * platform/gtk/TextBreakIteratorInternalICUGtk.cpp: Added.
        * platform/win/TextBoundariesWin.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-20 Mark Rowe <mrowe@apple.com>
bdash [Sat, 20 Oct 2007 21:00:53 +0000 (21:00 +0000)]
2007-10-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Tim Hatcher.

        Workaround for http://bugs.webkit.org/show_bug.cgi?id=15574
        Bug 15574: Web Inspector doesn't work with the new Database feature

        The executeSql callback is executed in the security domain of the web page that owns the database,
        while the inspector's window object is in the callback functions scope chain.  This is leading to a
        security violation when the callback attempts to access "document".  We can work around this by
        ensuring that "document" can be found in the scope chain before the window object.

        * page/inspector/DatabasePanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWindows build fix
pewtermoose [Sat, 20 Oct 2007 18:57:23 +0000 (18:57 +0000)]
Windows build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-20 Mark Rowe <mrowe@apple.com>
bdash [Sat, 20 Oct 2007 18:25:59 +0000 (18:25 +0000)]
2007-10-20  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Adam.

        Convert TIFFs to PNGs so that the demo page is fully-functional in the Gtk port.

        * misc/DatabaseExample.html:
        * misc/deleteButton.png: Added.
        * misc/deleteButton.tiff: Removed.
        * misc/deleteButtonPressed.png: Added.
        * misc/deleteButtonPressed.tiff: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Sat, 20 Oct 2007 17:30:30 +0000 (17:30 +0000)]
    Reviewed by Maciej.

        - http://bugs.webkit.org/show_bug.cgi?id=15567
          speed up hashing const char* by removing call to strlen

        This includes one other fix as well. Both were from a day where I did some
        profiling to find hot spots when running the page load test.

        * platform/StringImpl.cpp:
        (WebCore::StringImpl::computeHash): Compute the hash without calling strlen.
        Also change the argument names to not confusingly use m_ prefixes.
        (WebCore::StringImpl::createStrippingNull): Added a faster case for strings that
        don't have null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebKitTools:
darin [Sat, 20 Oct 2007 17:29:25 +0000 (17:29 +0000)]

        Reviewed by Tim Hatcher.

        - http://bugs.webkit.org/show_bug.cgi?id=15544
          <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
          not rely on Apple-specific key codes

        * DumpRenderTree/mac/EventSendingController.mm:
        (-[EventSendingController keyDown:withModifiers:]):
        Added named key "rightArrow". Later we could have a whole table of these.
        Also tweaked modifiers code a little.

        * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.


        Reviewed by Tim Hatcher.

        - http://bugs.webkit.org/show_bug.cgi?id=15544
          <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
          not rely on Apple-specific key codes

        * fast/events/arrow-navigation.html: Use "rightArrow" instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
darin [Sat, 20 Oct 2007 17:26:10 +0000 (17:26 +0000)]
    Reviewed by Eric.

        - http://bugs.webkit.org/show_bug.cgi?id=15566
          possible fix for leak seen in DumpRenderTree

        * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
        Delete the item if it's not put on the queue, since the caller has
        no way of knowing that. Would be better to have the parameter type
        be auto_ptr to express the fact that we take ownership.

        - unrelated change

        * Drosera/mac/main.m: Add missing include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-20 Mark Rowe <mrowe@apple.com>
bdash [Sat, 20 Oct 2007 13:54:48 +0000 (13:54 +0000)]
2007-10-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Alp.

        Gtk changes needed to enable HTML 5 client-side database storage.


        * wtf/Platform.h: Have Gtk use pthreads for now.


        * WebCore.pro: Have Gtk use ThreadingPthreads.cpp.
        * platform/pthreads/ThreadingPthreads.cpp: Include errno so that EDEADLK and EBUSY are available.


        * Api/webkitgtkglobal.cpp: Set a default database path based on the user data directory.
        This should become configurable by client applications in the future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-20 Mark Rowe <mrowe@apple.com>
bdash [Sat, 20 Oct 2007 13:01:18 +0000 (13:01 +0000)]
2007-10-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Alp.

        Implement callOnMainThread for Gtk+ via a one-shot zero-delay timer that will be dispatched
        from the main event loop.

        * WebCore.pro:
        * platform/gtk/TemporaryLinkStubs.cpp:
        * platform/gtk/ThreadingGtk.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-20 Mark Rowe <mrowe@apple.com>
bdash [Sat, 20 Oct 2007 13:00:56 +0000 (13:00 +0000)]
2007-10-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Eric.

        Don't allow control characters to be inserted into editable regions.

        * WebCoreSupport/EditorClientGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Eric.
zimmermann [Sat, 20 Oct 2007 12:55:49 +0000 (12:55 +0000)]
Reviewed by Eric.

Fix non-functional display="inline" / display="none" for SVG text.

Fixes: svg/W3C-SVG-1.1/animate-elem-39-t.svg (display="inline" support)
Fixes: svg/batik/text/textProperties2.svg (display="inline/none" support)
Fixes: svg/carto.net/tabgroup.svg (display="none" support, stray content before layouting)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-20 Mark Rowe <mrowe@apple.com>
bdash [Sat, 20 Oct 2007 11:17:13 +0000 (11:17 +0000)]
2007-10-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Alp.

        Replace #ifdef'd code with the appropriate use of a forwarding header.

        * ForwardingHeaders/kjs/array_instance.h: Added.
        * bindings/js/JSDatabaseCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Oliver.
zimmermann [Sat, 20 Oct 2007 10:37:17 +0000 (10:37 +0000)]
Reviewed by Oliver.

Add support for 'kerning' property in SVG text layout code.
Support all textLength/lengthAdjust modes on normal text & textPaths.

Support letter & word spacing on textPath.
Fix text selection when any spacing (letter/word/kerning) is involved.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=15571
Fixes: svg/batik/text/textOnPathSpaces.svg (spacing)
       svg/batik/text/textLayout.svg (kerning support)
       svg/text/text-spacing-01-b.svg (text selection)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix typo
aroben [Sat, 20 Oct 2007 10:37:12 +0000 (10:37 +0000)]
Fix typo

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Make the notes sticky!
aroben [Sat, 20 Oct 2007 10:30:45 +0000 (10:30 +0000)]
     Make the notes sticky!

         Reviewed by Mark.

         * misc/DatabaseExample.html:
         * misc/deleteButton.tiff: Added.
         * misc/deleteButtonPressed.tiff: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-20 Rodney Dawes <dobey@wayofthemonkey.com>
bdash [Sat, 20 Oct 2007 10:20:09 +0000 (10:20 +0000)]
2007-10-20  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewd by Darin.

        Fix conflict with X11 Window type in WebCore

        * WebCore/bindings/js/JSDocumentCustom.cpp:
        * WebCore/bindings/js/JSHTMLDocumentCustom.cpp:
        * WebCore/bindings/js/JSHTMLFrameSetElementCustom.cpp:
        * WebCore/bindings/js/kjs_dom.cpp:
        * WebCore/bindings/js/kjs_events.cpp:
        * WebCore/bindings/js/kjs_proxy.cpp:
        * WebCore/history/CachedPage.cpp:
        * WebCore/page/Chrome.cpp:
        * WebCore/page/Frame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix the Qt build.
hausmann [Sat, 20 Oct 2007 09:45:01 +0000 (09:45 +0000)]
Fix the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Nikolas.
mjs [Sat, 20 Oct 2007 08:51:48 +0000 (08:51 +0000)]
    Reviewed by Nikolas.

        - Rebalance test complexity.

        Scaled all the tests so they take 400-600ms on a reasonably normal user setup:

        Internet Explorer 7, Window XP, Dell Latitude D810 with a 2.13GHz Pentium M

        However, for some tests, IE7 was a huge outlier compared to other
        major browsers. For those tests, I used Firefox on the
        same OS and hardware as a normalization basis.

        * tests/3d-morph.js:
        * tests/3d-raytrace.js:
        * tests/bitops-3bit-bits-in-byte.js:
        * tests/bitops-bits-in-byte.js:
        * tests/bitops-bitwise-and.js:
        * tests/math-cordic.js:
        * tests/string-base64.js:
        * tests/string-tagcloud.js:
        * tests/string-unpack-code.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
mjs [Sat, 20 Oct 2007 08:11:55 +0000 (08:11 +0000)]
    Reviewed by Oliver.

        - Fix the browser-hosted driver to be compatible with Safari 2

        * hosted/sunspider-driver.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Hyatt.
mjs [Sat, 20 Oct 2007 08:05:36 +0000 (08:05 +0000)]
    Rubber stamped by Hyatt.

        - Add BSD license notice to cordic test, the original author said to do so.

        * tests/math-cordic.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej Stachowiak.
ggaren [Sat, 20 Oct 2007 07:11:53 +0000 (07:11 +0000)]
    Reviewed by Maciej Stachowiak.

        Fixed http://bugs.webkit.org/show_bug.cgi?id=15570
        Store gathered declaration nodes in the function body node.

        This means that you only have to gather the declaration nodes the first
        time the function executes. Performance gain of 2.10% on SunSpider,
        0.90% on command-line JS iBench.

        * kjs/nodes.cpp: Split declaration stack initialization code off into

        * kjs/nodes.h: Changed DeclarationStacks structure to hold references,
        since the actual Vectors are now stored either on the stack or in the
        function body node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-19 Alp Toker <alp@atoker.com>
alp [Sat, 20 Oct 2007 05:37:07 +0000 (05:37 +0000)]
2007-10-19  Alp Toker  <alp@atoker.com>

        Reviewed by Oliver.

        GTK+ build fix enabling the new local database storage feature.
        There is also a prospective Qt build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdded Bugzilla link to ChangeLog
ggaren [Sat, 20 Oct 2007 05:20:20 +0000 (05:20 +0000)]
Added Bugzilla link to ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler.
ggaren [Sat, 20 Oct 2007 05:18:23 +0000 (05:18 +0000)]
    Reviewed by Darin Adler.

        To improve encapsulation, moved processDeclarations call into
        FunctionBodyNode::execute. Also marked processDeclarations
        ALWAYS_INLINE, since it has only 1 caller now. This is a .71% speedup
        on command-line JS iBench.

        * kjs/function.cpp:
        * kjs/function.h:
        * kjs/interpreter.cpp:
        * kjs/nodes.cpp:
        * kjs/nodes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady Eidson.
andrew [Sat, 20 Oct 2007 04:08:30 +0000 (04:08 +0000)]
    Reviewed by Brady Eidson.

        Mac build fix.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoUpdating window properties to include new features from HTML5 database support
oliver [Sat, 20 Oct 2007 03:09:43 +0000 (03:09 +0000)]
Updating window properties to include new features from HTML5 database support


* fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark Rowe.
thatcher [Sat, 20 Oct 2007 02:20:01 +0000 (02:20 +0000)]
    Reviewed by Mark Rowe.

        Fix a couple of exceptions for first time users.

        * misc/DatabaseExample.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-10-19 Alp Toker <alp@atoker.com>
alp [Sat, 20 Oct 2007 01:48:21 +0000 (01:48 +0000)]
2007-10-19  Alp Toker  <alp@atoker.com>

        Reviewed by Oliver.

        Use platform colors for text selection.
        Update the cache when the GTK style is changed.

        * platform/gtk/RenderThemeGtk.cpp:
        * platform/gtk/RenderThemeGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
adele [Sat, 20 Oct 2007 01:18:27 +0000 (01:18 +0000)]

        Reviewed by Beth.

        Fix for: <rdar://problem/5518461> REGRESSION (2.0.4-3): Popup arrows are missing in small popups at homedepot.com

        Test: fast/forms/menulist-no-overflow.html

        * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle): Don't allow overflow on menu lists.


        Reviewed by Beth.

        Test for <rdar://problem/5518461> REGRESSION (2.0.4-3): Popup arrows are missing in small popups at homedepot.com

        * fast/forms/menulist-no-overflow.html: Added.
        * platform/mac/fast/forms/menulist-no-overflow-expected.checksum: Added.
        * platform/mac/fast/forms/menulist-no-overflow-expected.png: Added.
        * platform/mac/fast/forms/menulist-no-overflow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady.
andersca [Sat, 20 Oct 2007 01:06:26 +0000 (01:06 +0000)]
    Reviewed by Brady.

        Move some SQL-related classes to platform/sql.

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * loader/icon/SQLDatabase.cpp: Removed.
        * loader/icon/SQLDatabase.h: Removed.
        * loader/icon/SQLStatement.cpp: Removed.
        * loader/icon/SQLStatement.h: Removed.
        * loader/icon/SQLTransaction.cpp: Removed.
        * loader/icon/SQLTransaction.h: Removed.
        * platform/sql/SQLDatabase.cpp: Copied from loader/icon/SQLDatabase.cpp.
        * platform/sql/SQLDatabase.h: Copied from loader/icon/SQLDatabase.h.
        * platform/sql/SQLStatement.cpp: Copied from loader/icon/SQLStatement.cpp.
        * platform/sql/SQLStatement.h: Copied from loader/icon/SQLStatement.h.
        * platform/sql/SQLTransaction.cpp: Copied from loader/icon/SQLTransaction.cpp.
        * platform/sql/SQLTransaction.h: Copied from loader/icon/SQLTransaction.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady.
andersca [Sat, 20 Oct 2007 00:49:20 +0000 (00:49 +0000)]
    Reviewed by Brady.

        Make example actually work.

        * misc/DatabaseExample.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
andersca [Sat, 20 Oct 2007 00:45:33 +0000 (00:45 +0000)]

        Reviewed by Adam.

        Update to match the latest version of the spec. Now, executeSQL takes an array
        of SQL parameters instead of them being passed as arguments.

        * bindings/js/JSDatabaseCustom.cpp:
        * page/inspector/DatabasePanel.js:
        * storage/Database.idl:


        Reviewed by Adam.

        Update example.

        * misc/DatabaseExample.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
kmccullo [Sat, 20 Oct 2007 00:38:37 +0000 (00:38 +0000)]
    Reviewed by Adam.

        - This change should be identical but for some reason was not working
        on my machine.

        * Scripts/prepare-ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26798 268f45cc-cd09-0410-ab3c-d52691b4dbfc