WebKit-https.git
12 years ago2009-11-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 1 Dec 2009 07:25:13 +0000 (07:25 +0000)]
2009-11-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        check-webkit-style is slightly too verbose
        https://bugs.webkit.org/show_bug.cgi?id=32010

        check-webkit-style prints out a bunch of "done" lines that seem redundant,
        especially for the style-queue.

        * Scripts/modules/cpp_style.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Alejandro G. Castro <alex@igalia.com>
eric@webkit.org [Tue, 1 Dec 2009 06:41:14 +0000 (06:41 +0000)]
2009-11-30  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Moved the functions that are closing the result log of the
        tests to the last line of the runTest function, this avoids
        reporting crashes in the wrong test if there is a problem when
        reseting the state after the test.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (dump):
        (runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Tue, 1 Dec 2009 03:33:00 +0000 (03:33 +0000)]
2009-11-30  Fumitoshi Ukai  <ukai@chromium.org>

        Unreviewed Chromium build fix introduced by r51212

        Fix scriptStateFromNode and ScriptStateFromPage to take DOMWrapperWorld
        as the first argument.
        Move mainThreadNormalWorld() to ScriptState.{h,cpp}.
        Add debuggerWorld() and pluginWorld() in ScriptState.h.

        * bindings/v8/ScriptController.cpp:
        * bindings/v8/ScriptController.h:
        * bindings/v8/ScriptState.cpp:
        (WebCore::scriptStateFromNode):
        (WebCore::scriptStateFromPage):
        (WebCore::mainThreadNormalWorld):
        * bindings/v8/ScriptState.h:
        (WebCore::debuggerWorld):
        (WebCore::pluginWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=31286
weinig@apple.com [Tue, 1 Dec 2009 01:18:50 +0000 (01:18 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
fast/js/date-proto-generic-invocation breaks another test

Reviewed by Geoffrey Garen.

Don't cache JSClassRefs, a change to the prototype chain will
last between tests.

* DumpRenderTree/AccessibilityController.cpp:
(AccessibilityController::getJSClass):
* DumpRenderTree/GCController.cpp:
(GCController::getJSClass):
* DumpRenderTree/GCController.h:
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::getJSClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Can focus but not type into content editable block that contains only non...
enrica@apple.com [Tue, 1 Dec 2009 00:44:30 +0000 (00:44 +0000)]
WebCore: Can focus but not type into content editable block that contains only non-editable content.
<rdar://problem/5982901>
https://bugs.webkit.org/show_bug.cgi?id=31750

Reviewed by Darin Adler.

The goal is to change the way we choose a visible position
after hit detection, by preferring a visually equivalent editable
position if available. By doing this, it is possible to add content
to an editable block that initially contains only non editable elements.

Test: editing/selection/mixed-editability-10.html

* WebCore.base.exp: Changed to match the new signature of downstream
and upstream in the Position class.
* dom/Position.cpp:
(WebCore::Position::atEditingBoundary): Added.
(WebCore::Position::upstream): Modified to allow to cross the boundary
between editable and non editable content if required.
(WebCore::Position::downstream): Modified to allow to cross the boundary
between editable and non editable content if required.
(WebCore::Position::isCandidate): Modified to qualify as candidates positions
that are at the editability boundary.
(WebCore::Position::getInlineBoxAndOffset): Modified to retrieve the inline box
to be used in calculating the caret rectangle.
* dom/Position.h:
(WebCore::Position::):
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::atEditingBoundary): Added.
(WebCore::PositionIterator::isCandidate): Modified to qualify as candidates positions
that are at the editability boundary.
* dom/PositionIterator.h:
* editing/htmlediting.cpp:
(WebCore::firstEditablePositionAfterPositionInRoot): Modified to accept not only
descendants of the editable container, but the container itself.
(WebCore::lastEditablePositionBeforePositionInRoot): Modified to accept not only
descendants of the editable container, but the container itself.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createVisiblePosition): Added logic to prefer an editable position,
if available.
* rendering/RenderText.cpp:
(WebCore::RenderText::isAllCollapsibleWhitespace): Added.
* rendering/RenderText.h:

LayoutTests: Can focus but not type into content editable block that contains only non-editable content.
<rdar://problem/5982901>
https://bugs.webkit.org/show_bug.cgi?id=31750

Reviewed by Darin Adler.

* editing/selection/5825350-1-expected.txt:
* editing/selection/5825350-1.html: Modified to use caret rectangle.
* editing/selection/5825350-2-expected.txt:
* editing/selection/5825350-2.html: Modified to use caret rectangle.
* editing/selection/mixed-editability-10-expected.txt: Added.
* editing/selection/mixed-editability-10.html: Added.
* platform/mac/editing/deleting/5390681-2-expected.txt: Re-baselined
to account for the new possible caret position.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Yuzo Fujishima <yuzo@google.com>
eric@webkit.org [Tue, 1 Dec 2009 00:40:04 +0000 (00:40 +0000)]
2009-11-30  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Alexey Proskuryakov.

        Update pywebsocket to 0.4.2.1.
        This is to fix a bug that some messages are logged to stderr even when the log file is specified.
        https://bugs.webkit.org/show_bug.cgi?id=31976

        * pywebsocket/mod_pywebsocket/standalone.py:
        * pywebsocket/setup.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix, add header needed for wx build.
kevino@webkit.org [Tue, 1 Dec 2009 00:12:44 +0000 (00:12 +0000)]
wx build fix, add header needed for wx build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/7424387> WebCore binary missing symbols when built for x86_64 from...
mrowe@apple.com [Tue, 1 Dec 2009 00:08:39 +0000 (00:08 +0000)]
<rdar://problem/7424387> WebCore binary missing symbols when built for x86_64 from a machine that cannot run x86_64 binaries

Reviewed by David Kilzer.

The check for whether WTF_USE_PLUGIN_HOST_PROCESS is defined occurs under the native architecture of the build machine.
If that is 32-bit then WTF_USE_PLUGIN_HOST_PROCESS will not be defined.  We work around this by forcing the check to
be performed against the x86_64 architecture.

* DerivedSources.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Adam Barth <abarth@webkit.org>
eric@webkit.org [Tue, 1 Dec 2009 00:07:41 +0000 (00:07 +0000)]
2009-11-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Generate pass messages for style-queue
        https://bugs.webkit.org/show_bug.cgi?id=31995

        With this change, the style-queue posts "pass" messages to bugs as
        well.  Also, added more information to the state store w.r.t. passing
        and failing.

        * Scripts/modules/commands/queues.py:
        * Scripts/modules/patchcollection.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in
bdakin@apple.com [Mon, 30 Nov 2009 23:55:38 +0000 (23:55 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in
Safari caused by extreme column-gap and column-width values
-and corresponding-
<rdar://problem/7425433>

Reviewed by Oliver Hunt.

Prevent desiredColumnCount from being less than 1 since it is used
as a divisor.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::calcColumnWidth):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in
Safari caused by extreme column-gap and column-width values
-and corresponding-
<rdar://problem/7425433>

Reviewed by Oliver Hunt.

* fast/multicol/huge-column-gap-crash-expected.txt: Added.
* fast/multicol/huge-column-gap-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver Hunt.
ap@apple.com [Mon, 30 Nov 2009 23:48:50 +0000 (23:48 +0000)]
    Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=31659
        Connection must be closed in case of Web Socket handshake error

        The network connection was closed, but the close event wasn't dispatched.

        Tested by websocket/tests/handshake-error.html, which is un-skipped now.

        * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose):
        Call client didHandle() method. This looks strange in CFNetwork implementation, because
        it's the client that asked to close the stream, so it shouldn't need the callback. It makes
        more sense in cross-process implementation, because closing is async there.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Abhinav Mithal <abhinav.mithal@nokia.com>
eric@webkit.org [Mon, 30 Nov 2009 23:20:04 +0000 (23:20 +0000)]
2009-11-30  Abhinav Mithal  <abhinav.mithal@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt][Symbian] Report SymbianOS in user agent string for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=31961

        * Api/qwebpage.cpp:
        (QWebPage::userAgentForUrl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWindows Build fix. Reviewed by NOBODY.
barraclough@apple.com [Mon, 30 Nov 2009 22:10:30 +0000 (22:10 +0000)]
Windows Build fix.  Reviewed by NOBODY.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse the correct path to Info.plist to avoid creating an empty file at the top of...
mrowe@apple.com [Mon, 30 Nov 2009 22:02:14 +0000 (22:02 +0000)]
Use the correct path to Info.plist to avoid creating an empty file at the top of the WebKit directory.

* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBug 31859 - Make world selection for JSC IsolatedWorlds automagical.
barraclough@apple.com [Mon, 30 Nov 2009 21:48:23 +0000 (21:48 +0000)]
Bug 31859 - Make world selection for JSC IsolatedWorlds automagical.

Reviewed by Geoff Garen.

JavaScriptCore:

WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.

Remove the temporary duct tape of willExecute/didExecute virtual hooks on the JSGlobalData::ClientData - these are no longer necessary.

* API/JSBase.cpp:
(JSEvaluateScript):
* API/JSObjectRef.cpp:
(JSObjectCallAsFunction):
* JavaScriptCore.exp:
* runtime/JSGlobalData.cpp:
* runtime/JSGlobalData.h:

WebCore:

WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.

Remove the last uses of mainThreadCurrentWorld(), so the world is always obtained via
currentWorld().  Switch this to obtain the world from the ExecsState's lexical global
object instead.  Remove the call/construct/evaluate 'InWorld' methods, since these
are no longer necessary.

* WebCore.base.exp:
* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSCallbackData.h:
(WebCore::JSCallbackData::JSCallbackData):
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
* bindings/js/JSDOMBinding.cpp:
(WebCore::currentWorld):
(WebCore::mainThreadNormalWorld):
* bindings/js/JSDOMBinding.h:
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::updateDocument):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
(WebCore::JSEventListener::reportError):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::open):
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
* bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::construct):
(WebCore::JSQuarantinedObjectWrapper::call):
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::executeFunctionInContext):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::updateDocument):
* bindings/js/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):
* bindings/js/ScriptObjectQuarantine.cpp:
(WebCore::getQuarantinedScriptObject):
* bindings/js/ScriptState.cpp:
(WebCore::scriptStateFromNode):
(WebCore::scriptStateFromPage):
* bindings/js/ScriptState.h:
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
* bridge/NP_jsobject.cpp:
(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_Construct):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::call):
(JavaJSObject::eval):
* dom/NodeFilter.h:
(WebCore::NodeFilter::acceptNode):
* dom/NodeIterator.h:
(WebCore::NodeIterator::nextNode):
(WebCore::NodeIterator::previousNode):
* dom/TreeWalker.h:
(WebCore::TreeWalker::parentNode):
(WebCore::TreeWalker::firstChild):
(WebCore::TreeWalker::lastChild):
(WebCore::TreeWalker::previousSibling):
(WebCore::TreeWalker::nextSibling):
(WebCore::TreeWalker::previousNode):
(WebCore::TreeWalker::nextNode):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::windowScriptObjectAvailable):
(WebCore::InspectorController::didEvaluateForTestInFrontend):
* inspector/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::evaluate):

WebKit/mac:

WebCore presently has to explicitly specify the world before entering into JSC,
which is a little fragile (particularly since property access via a
getter/setter might invoke execution). Instead derive the current world from
the lexical global object.

Since WebCore no longer needs to explicitly specify the world on entry to JSC DebuggerCallFrame::evaluate can be called directly.

* WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame evaluateWebScript:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 30 Nov 2009 21:43:57 +0000 (21:43 +0000)]
2009-11-30  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        All HTML5 media element events should be regular events
        https://bugs.webkit.org/show_bug.cgi?id=30513

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::selectMediaResource):
        (WebCore::HTMLMediaElement::noneSupported):
        (WebCore::HTMLMediaElement::mediaEngineError):
        (WebCore::HTMLMediaElement::setNetworkState):
        (WebCore::HTMLMediaElement::userCancelledLoad):
            Call scheduleEvent instead of scheduleProgressEvent.
        (WebCore::HTMLMediaElement::progressEventTimerFired):
            Call scheduleEvent instead of scheduleProgressEvent. Call renderer->updateFromElement
            after scheduling a 'progress' event so the controller will update download
            progress indicator.
        * html/HTMLMediaElement.h:
            Remove scheduleProgressEvent prototype.

2009-11-30  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        All HTML5 media element events should be regular events
        https://bugs.webkit.org/show_bug.cgi?id=30513

        Remove progress event tests.

        * media/progress-event-at-least-one-expected.txt: Removed.
        * media/progress-event-at-least-one.html: Removed.
        * media/progress-event-expected.txt: Removed.
        * media/progress-event-total-expected.txt: Removed.
        * media/progress-event-total.html: Removed.
        * media/progress-event.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix double-free of BSTRs passed to WebNavigationData::createInstance
aroben@apple.com [Mon, 30 Nov 2009 21:41:03 +0000 (21:41 +0000)]
Fix double-free of BSTRs passed to WebNavigationData::createInstance

WebFrameLoaderClient::updateGlobalHistory was converting
WebCore::Strings to WebCore::BStrings, then passing them to
WebNavigationData::createInstance. But the latter function takes BSTR
parameters and adopts them into WebCore::BStrings. So the end result
was that two WebCore::BStrings would end up freeing each underlying
BSTR.

The fix is to only convert to WebCore::BString inside
WebNavigationData.

Fixes <http://webkit.org/b/31998> <rdar://problem/7383452> REGRESSION
(r49564): Crash in updateGlobalHistory when running Javascript iBench
test

I couldn't find a way to reproduce this in DumpRenderTree.

Reviewed by Steve Falkenburg.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::updateGlobalHistory): Pass WebCore::Strings to
WebNavigationData::createInstance.

* WebNavigationData.cpp:
(WebNavigationData::WebNavigationData):
(WebNavigationData::createInstance):
* WebNavigationData.h:
Changed to take const WebCore::String&s instead of BSTRs and to
convert the Strings to BStrings at this level.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIt was me who reviewed the patch, not Eric! Alas, some tools we use cause wrong revie...
ap@apple.com [Mon, 30 Nov 2009 21:38:19 +0000 (21:38 +0000)]
It was me who reviewed the patch, not Eric! Alas, some tools we use cause wrong reviewer information in Bugzilla.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Yuzo Fujishima <yuzo@google.com>
ap@apple.com [Mon, 30 Nov 2009 21:35:04 +0000 (21:35 +0000)]
2009-11-30  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Eric Seidel.

        In testing handshake-error case, web_socket_do_extra_handshake calls a non-existent method
        https://bugs.webkit.org/show_bug.cgi?id=31465

        * platform/mac/Skipped: websocket/tests/handshake-error.html now fails on Mac, added to
        Skipped list, and filed bug 31659 to investigate.

        * websocket/tests/handshake-error_wsh.py: Call write() on a correct object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove file git invisibly added
joepeck@webkit.org [Mon, 30 Nov 2009 21:27:23 +0000 (21:27 +0000)]
Remove file git invisibly added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Mon, 30 Nov 2009 21:19:42 +0000 (21:19 +0000)]
2009-11-30  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Wrong console output for Regexp escape sequence
        https://bugs.webkit.org/show_bug.cgi?id=31538

        Updated inspector/console-format.html

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.createDividerElement): style issues.
        (WebInspector.ConsoleView.createFilterElement): style issues.
        (WebInspector.ConsoleView): added _customFormatters table.
        (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): style isses.
        (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): style issues.
        (WebInspector.ConsoleView.prototype._format): simplified delegation to formatter logic.
        (WebInspector.ConsoleView.prototype._formatobject):
        (WebInspector.ConsoleView.prototype._formatnode):
        (WebInspector.ConsoleView.prototype._printArray):
        (WebInspector.ConsoleMessage.prototype._format): commented and broke down the algorithm into parts.
        (WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.append): handle substitution string formatting.
        (WebInspector.ConsoleMessage.prototype._formatIndividualValue): handling individual value formatting.
        (WebInspector.ConsoleCommandResult):
        * inspector/front-end/InjectedScript.js: simplified regex formatting.
        * inspector/front-end/inspector.js:
        (WebInspector.linkifyStringAsFragment): converted new RegExp to literal for performance benefits.
        * inspector/front-end/utilities.js:
        (Element.prototype.hasStyleClass): update inaccurate comment.
        (String.prototype.trimURL): converted new RegExp to literal for performance benefits.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Mon, 30 Nov 2009 20:42:19 +0000 (20:42 +0000)]
2009-11-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Remove obsolete PLATFORM(KDE) code
        https://bugs.webkit.org/show_bug.cgi?id=31958

        KDE is now using unpatched QtWebKit.

        * parser/Lexer.cpp: Remove obsolete KDE_USE_FINAL guard
        * wtf/Platform.h: Remove PLATFORM(KDE) definition and code
        section that is guarded with it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSkipping test that fails because of broken DND, and some tests
kov@webkit.org [Mon, 30 Nov 2009 19:55:42 +0000 (19:55 +0000)]
Skipping test that fails because of broken DND, and some tests
requiring new results.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Xan Lopez.
kov@webkit.org [Mon, 30 Nov 2009 19:27:53 +0000 (19:27 +0000)]
Rubber-stamped by Xan Lopez.

Make sure we distribute and install GObject Introspection files.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Erik Arvidsson <arv@chromium.org>
eric@webkit.org [Mon, 30 Nov 2009 18:59:36 +0000 (18:59 +0000)]
2009-11-30  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Adam Barth.

        Clean up V8 bindings for CSSStyleDeclaration and CSSVariableDeclaration
        https://bugs.webkit.org/show_bug.cgi?id=31895

        No new tests. This is already covered by:
                fast/dom/CSSStyleDeclaration/css-computed-style-item.html
                fast/dom/CSSStyleDeclaration/css-style-item.html

        * bindings/v8/V8Collection.h:
        (WebCore::collectionStringIndexedPropertyGetter):
        (WebCore::setCollectionStringIndexedGetter):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld should...
sfalken@apple.com [Mon, 30 Nov 2009 18:50:40 +0000 (18:50 +0000)]
WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld should fall back to didClearWindowObject
https://bugs.webkit.org/show_bug.cgi?id=31986

Reviewed by Adam Roben.

* WebFrame.cpp:
(WebFrame::dispatchDidClearWindowObjectInWorld): Fall back if E_NOTIMPL returned.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Simon Fraser.
kov@webkit.org [Mon, 30 Nov 2009 17:54:10 +0000 (17:54 +0000)]
Reviewed by Simon Fraser.

Check for WEBKIT_TESTFONTS environment variable in
run-webkit-tests, for GTK+, to have a more prominent error
message.

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Steve Block <steveblock@google.com>
eric@webkit.org [Mon, 30 Nov 2009 17:41:56 +0000 (17:41 +0000)]
2009-11-30  Steve Block  <steveblock@google.com>

        Reviewed by Eric Seidel.

        Adds include of wtf/StdLibExtras.h for DEFINE_STATIC_LOCAL in V8 ScriptController.
        https://bugs.webkit.org/show_bug.cgi?id=31932

        Build fix only, no new tests.

        * bindings/v8/ScriptController.cpp: Modified. Adds include of wtf/StdLibExtras.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Steve Block <steveblock@google.com>
eric@webkit.org [Mon, 30 Nov 2009 17:34:59 +0000 (17:34 +0000)]
2009-11-30  Steve Block  <steveblock@google.com>

        Reviewed by Eric Seidel.

        Adds PassOwnPtr include to ScriptExecutionContext.h.
        https://bugs.webkit.org/show_bug.cgi?id=31929

        Build fix only, no new tests.

        * dom/ScriptExecutionContext.h: Modified. Adds PassOwnPtr include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Dirk Schulze <krit@webkit.org>
eric@webkit.org [Mon, 30 Nov 2009 17:25:00 +0000 (17:25 +0000)]
2009-11-30  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Complex test of mask with every combination of maskUnits and maskContentUnits
        as well as different values for size and position of the mask and it's content.

        * platform/mac/svg/custom/mask-with-all-units-expected.checksum: Added.
        * platform/mac/svg/custom/mask-with-all-units-expected.png: Added.
        * platform/mac/svg/custom/mask-with-all-units-expected.txt: Added.
        * svg/custom/mask-with-all-units.svg: Added.
2009-11-30  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        REGRESSION (r49757): masking-mask-01-b.svg rendered incorrectly
        [https://bugs.webkit.org/show_bug.cgi?id=31980]

        It turns out, that we did not handle maskUnits="userSpaceOnUse"
        correctly. We just need to move the context of the maskImage
        if maskContentUnits="objectBoundingBox". The context gets scaled
        on this unit combination, so we have to substract the position of
        the targetRect. On userSpaceOnUse the position just depends on the
        position of the mask element.
        I added a test with some senseless and reasonable values for size
        and postion of the mask and it's contents. I also used every
        combination of maskUnits and maskContentUnits to be sure, that it
        is fixed this time.

        Test: svg/custom/mask-with-all-units.svg

        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::drawMaskerContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Steve Block <steveblock@google.com>
eric@webkit.org [Mon, 30 Nov 2009 17:17:42 +0000 (17:17 +0000)]
2009-11-30  Steve Block  <steveblock@google.com>

        Reviewed by Eric Seidel.

        Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.
        https://bugs.webkit.org/show_bug.cgi?id=31928

        Build fix only, no new tests.

        * page/DOMWindow.cpp: Modified. Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Mon, 30 Nov 2009 17:10:36 +0000 (17:10 +0000)]
2009-11-30  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        update-webkit --chromium forces gclient sync

        https://bugs.webkit.org/show_bug.cgi?id=31967

        * Scripts/update-webkit-chromium:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Steve Block <steveblock@google.com>
eric@webkit.org [Mon, 30 Nov 2009 17:03:32 +0000 (17:03 +0000)]
2009-11-30  Steve Block  <steveblock@google.com>

        Reviewed by Eric Seidel.

        Adds SHARED_WORKERS guards to V8 WorkerContextExecutionProxy.
        https://bugs.webkit.org/show_bug.cgi?id=31926

        Build fix only, no new tests.

        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
        (WebCore::WorkerContextExecutionProxy::convertToV8Object):
        (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Mon, 30 Nov 2009 16:56:24 +0000 (16:56 +0000)]
2009-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Chrome::contentsSizeChanged() is called when the content size has not changed
        https://bugs.webkit.org/show_bug.cgi?id=31978

        Do not trigger contentsSizeChaned() is the new size is the same as the old one.

        * page/FrameView.cpp:
        (WebCore::FrameView::setContentsSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Mon, 30 Nov 2009 16:49:20 +0000 (16:49 +0000)]
2009-11-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix minor waning in QtWebKit
        https://bugs.webkit.org/show_bug.cgi?id=31963

        * tests/qwebpage/tst_qwebpage.cpp:
        (ErrorPage::extension): Remove info wariable as it is
        not used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Mon, 30 Nov 2009 16:42:26 +0000 (16:42 +0000)]
2009-11-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix some compiler warnings seen on QtWebKit/Mac
        https://bugs.webkit.org/show_bug.cgi?id=31962

        No new tests as there is no functional change.

        * platform/network/ResourceHandle.h: Make destructor virtual as
        after r50772 ResourceHandle has virtual functions.

        * plugins/mac/PluginPackageMac.cpp:
        (WebCore::PluginPackage::fetchInfo): Fix typo WTF is a namespace
        not a label

        * plugins/mac/PluginViewMac.cpp:
        (WebCore::PluginView::setNPWindowIfNeeded): Add l to the format
        specifier

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoVersioning.
mrowe@apple.com [Mon, 30 Nov 2009 15:31:22 +0000 (15:31 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix. Make sure JSCore-1.0.gir is added to the distributed
kov@webkit.org [Mon, 30 Nov 2009 15:13:44 +0000 (15:13 +0000)]
Build fix. Make sure JSCore-1.0.gir is added to the distributed
tarball.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-30 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 30 Nov 2009 13:53:52 +0000 (13:53 +0000)]
2009-11-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Bump versions for 1.1.17 release.

        * configure.ac:

WebCore:

2009-11-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Add new headers to sources list.

        * GNUmakefile.am:

WebKit/gtk:

2009-11-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Prepare for 1.1.17 release.

        * NEWS:
        * docs/webkitgtk-docs.sgml:
        * docs/webkitgtk-sections.txt:
        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Mac Plugins : Get context menu to work in QGraphicsView
girish@forwardbias.in [Mon, 30 Nov 2009 12:08:20 +0000 (12:08 +0000)]
[Qt] Mac Plugins : Get context menu to work in QGraphicsView

Reviewed by Holger Freyther.

Flash expects the value in record.where to be the global position for
displaying the context menu.

https://bugs.webkit.org/show_bug.cgi?id=31979

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Fix compilation with win32-icc
hausmann@webkit.org [Mon, 30 Nov 2009 11:27:51 +0000 (11:27 +0000)]
[Qt] Fix compilation with win32-icc

Patch by Jan-Arve Sæther <jan-arve.saether@nokia.com> on 2009-11-30
Reviewed by Simon Hausmann.

.:

Include os-win32 for stdint.h since MS does not ship that in their PSDK.

* WebKit.pri:

JavaScriptCore:

The Intel compiler does not support the __has_trivial_constructor type
trait.  The Intel Compiler can report itself as _MSC_VER >= 1400. The
reason for that is that the Intel Compiler depends on the Microsoft
Platform SDK, and in order to try to be "fully" MS compatible it will
"pretend" to be the same MS compiler as was shipped with the MS PSDK.
(Thus, compiling with win32-icc with VC8 SDK will make the source code
"think" the compiler at hand supports this type trait).

* wtf/TypeTraits.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdds PLATFORM(CHROMIUM) guards around memory usage code in V8GCController.
steveblock@google.com [Mon, 30 Nov 2009 10:39:23 +0000 (10:39 +0000)]
Adds PLATFORM(CHROMIUM) guards around memory usage code in V8GCController.
https://bugs.webkit.org/show_bug.cgi?id=31925

Reviewed by Eric Seidel.

This code uses ChromiumBridge and Chromium-specific constant values not
appropriate for other platforms such as Android.

Build fix only, no new tests.

* bindings/v8/V8GCController.cpp: Modified. Adds PLATFORM(CHROMIUM) around Chromium-specific code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Put tests into skiplist because of missing features.
ossy@webkit.org [Mon, 30 Nov 2009 09:41:02 +0000 (09:41 +0000)]
[Qt] Put tests into skiplist because of missing features.

* platform/qt/Skipped:
- fast/dom/Window/window-postmessage-clone.html added
- inspector/elements-img-tooltip.html added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix.
bfulgham@webkit.org [Mon, 30 Nov 2009 04:50:00 +0000 (04:50 +0000)]
Build fix.

Correct draw signature used in ImageCairoWin.cpp.

* platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agopostMessage should serialize File objects
oliver@apple.com [Mon, 30 Nov 2009 04:15:40 +0000 (04:15 +0000)]
postMessage should serialize File objects
https://bugs.webkit.org/show_bug.cgi?id=31955

Reviewed by Sam Weinig.

Update SerializedScriptValue to include support for
File objects in the serialized object graph.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 30 Nov 2009 03:54:19 +0000 (03:54 +0000)]
2009-11-29  Eric Seidel  <eric@webkit.org>

        Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 30 Nov 2009 03:45:56 +0000 (03:45 +0000)]
2009-11-29  Simon Fraser  <simon.fraser@apple.com>

        Rubber-stamped by Eric Seidel.

        Fix up some compositing layout tests.

        * compositing/layers-inside-overflow-scroll.html:
        * compositing/self-painting-layers.html:
        Use the 'loadeddata' event, instead of 'load', to know when the video loads.

        * platform/mac/compositing/repaint/content-into-overflow-expected.checksum:
        * platform/mac/compositing/repaint/content-into-overflow-expected.png:
        * platform/mac/compositing/repaint/overflow-into-content-expected.checksum:
        * platform/mac/compositing/repaint/overflow-into-content-expected.png:
        * platform/mac/compositing/self-painting-layers-expected.checksum:
        * platform/mac/compositing/self-painting-layers-expected.png:
        Update with correct pixel results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 30 Nov 2009 03:26:30 +0000 (03:26 +0000)]
2009-11-29  Eric Seidel  <eric@webkit.org>

        No review, just adding missing svn property.

        Set svn:executable property on new scripts.
        These were added by commit-queue commits, but the executable
        property was lost due to a bug in svn-apply:
        https://bugs.webkit.org/show_bug.cgi?id=27204

        * Scripts/update-webkit-chromium: Added property svn:executable.
        * Scripts/validate-committer-lists: Added property svn:executable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 30 Nov 2009 03:21:55 +0000 (03:21 +0000)]
2009-11-29  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Optimize the hierarchy rebuilding of compositing layers
        https://bugs.webkit.org/show_bug.cgi?id=31879

        When updating the compositing layer hierarchy, instead of removing all
        child layers and then re-adding them one by one, build a vector of child
        layers, and set them in one go.

        * platform/graphics/GraphicsLayer.h:
        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::setChildren): New method that takes a Vector of child
        GraphicsLayers.

        * platform/graphics/mac/GraphicsLayerCA.h: Override setChildren().
        * platform/graphics/win/GraphicsLayerCACF.h: Ditto.
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::setChildren): Implement setChildren() to
        set the bit that notes that sublayers changed.
        * platform/graphics/win/GraphicsLayerCACF.cpp:
        (WebCore::GraphicsLayerCACF::setChildren): Implement setChildren() to
        udpate sublayers, with a note that this is not efficient.

        * rendering/RenderLayerCompositor.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateCompositingLayers):
        When updating compositing layers, use the faster updateLayerTreeGeometry() if
        we know that no layer hierarchy changes are needed, and, at the root, use
        the vector returned from rebuildCompositingLayerTree() to attach the root
        layer.
        (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Changed to
        collect child layers into Vectors of GraphicsLayers, which can be set as
        layer children in one go.
        (WebCore::RenderLayerCompositor::updateLayerTreeGeometry): Split out from
        rebuildCompositingLayerTree() for simplicity, and called when we just need to
        update layer geometry, without doing any reparenting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 30 Nov 2009 03:12:11 +0000 (03:12 +0000)]
2009-11-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Need a way to validate that committers.py includes all committers/reviewers
        https://bugs.webkit.org/show_bug.cgi?id=30970

        Add a script which knows how to compare our public committer/reviewer
        lists and show discrepancies between them.

        Validates mailing lists vs. committers.py:
        - committers.py committers missing from webkit-committers@lists
        - webkit-committers@lists members missing from committers.py
        - committers.py reviewers missing from webkit-reviewers@lists
        - webkit-reviewers@lists members missing from committers.py
        - webkit-reviewers@lists members missing from committers.py reviewer list

        Validates committers.py vs. trunk/ SVN history:
        - committers who have not committed in over a year
        - SVN committers missing from committers.py
        - committers.py members who have no record in SVN.

        All of these lists still show "false positives" until a few more committers.py updates are made, like:
        https://bugs.webkit.org/show_bug.cgi?id=31366

        * Scripts/validate-committer-lists: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 30 Nov 2009 03:10:36 +0000 (03:10 +0000)]
2009-11-29  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=31971

        Updated comment to reflect latest XSSAuditor bindings.

        No functionality was changed. So, no new tests.

        * page/XSSAuditor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 30 Nov 2009 02:45:52 +0000 (02:45 +0000)]
2009-11-29  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=31969

        Removes unnecessary #include files.

        No functionality was changed. So, no new tests.

        * css/CSSComputedStyleDeclaration.cpp: Removed include CachedImage.h, and
        Pair.h
        * css/CSSCursorImageValue.cpp: Removed include RenderStyle.h
        * css/CSSFontFaceSrcValue.cpp: Removed include Node.h
        * css/CSSFontSelector.cpp: Removed include NodeList.h
        * css/CSSGradientValue.cpp: Removed include GraphicsContext.h, ImageBuffer.h
        * css/CSSImageValue.cpp: Removed include RenderStyle.h
        * css/CSSImportRule.cpp: Removed include MediaList.h
        * css/CSSMutableStyleDeclaration.cpp: Removed include CSSProperty.h
        * css/CSSRule.cpp: Removed include CSSStyleSheet.h
        * css/CSSStyleSelector.cpp: Removed include CSSFontFace.h,
        CSSFontFaceSource.h, and CSSProperty.h
        * page/EventSource.h: Removed include EventListener.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 30 Nov 2009 01:32:38 +0000 (01:32 +0000)]
2009-11-29  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=31965

        Removed #include KeyframeList.h from CSSStyleSelector.h. Instead,
        forward declared it.

        As a side effect, we need to #include KeyframeList.h in
        RenderLayerBacking.cpp.

        No functionality was changed. So, no new tests.

        * css/CSSStyleSelector.cpp:
        * css/CSSStyleSelector.h: Removed #include KeyframeList.h
        * rendering/RenderLayerBacking.cpp: Added #include KeyframeList.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Shu Chang <Chang.Shu@nokia.com>
eric@webkit.org [Mon, 30 Nov 2009 01:02:43 +0000 (01:02 +0000)]
2009-11-29  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Eric Seidel.

        Test using Id as index of node list.
        https://bugs.webkit.org/show_bug.cgi?id=31428

        * fast/dom/Element/id-in-node-list-index01-expected.txt: Added.
        * fast/dom/Element/id-in-node-list-index01.html: Added.
2009-11-29  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Eric Seidel.

        Continue to search for matching node in the case where multiple nodes
        have the same id.
        https://bugs.webkit.org/show_bug.cgi?id=31428

        Test: fast/dom/Element/id-in-node-list-index01.html

        * dom/DynamicNodeList.cpp:
        (WebCore::DynamicNodeList::itemWithName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 30 Nov 2009 00:50:35 +0000 (00:50 +0000)]
2009-11-29  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=31966

        Removed #include RenderStyle.h from file KeyframeAnimation.h. Instead,
        forward declared it.

        No functionality was changed. So, no new tests.

        * page/animation/KeyframeAnimation.cpp:
        * page/animation/KeyframeAnimation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 30 Nov 2009 00:06:06 +0000 (00:06 +0000)]
2009-11-29  Daniel Bates  <dbates@webkit.org>

        Unreviewed, fix change log entry date.

        For some reason, bugzilla-tool did not update the date in the change
        log entry for my last commit (r51468). So, this commit fixes the date
        of that entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-28 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 29 Nov 2009 23:55:17 +0000 (23:55 +0000)]
2009-11-28  Daniel Bates  <dbates@webkit.org>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=31964

        Removed #include StringImpl, StyleImage. Instead, forward declared them.
        Also, we can substitute #include <wtf/PassRefPtr.h> for #include PlatformString.h,
        since it seems we only really used it to include PassRefPtr.h.

        No functionality was changed. So, no new tests.

        * rendering/style/ContentData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Sun, 29 Nov 2009 20:11:22 +0000 (20:11 +0000)]
2009-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] Mac build has JIT disabled
        https://bugs.webkit.org/show_bug.cgi?id=31828

        * wtf/Platform.h: Enable JIT for Qt Mac builds

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-29 Zoltan Horvath <zoltan@webkit.org>
eric@webkit.org [Sun, 29 Nov 2009 15:57:19 +0000 (15:57 +0000)]
2009-11-29  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Eric Seidel.

        Allow custom memory allocation control for classes of the rendering and storage directory in WebCore
        https://bugs.webkit.org/show_bug.cgi?id=31906

        Inherits the following classes from Noncopyable because these are instantiated
        by 'new' and no need to be copyable:

        class/struct name               - instantiated at: WebCore/'location'

        class SQLTransactionClient      - storage/DatabaseThread.cpp:45
        class SQLTransactionCoordinator - storage/DatabaseThread.cpp:46
        class OriginUsageRecord         - storage/OriginQuotaManager.cpp:66
        class DatabaseTracker           - storage/DatabaseTracker.cpp:62
        class ScrollbarTheme            - (its child class) rendering/RenderScrollbarTheme.cpp:35
        class RenderSelectionInfoBase   - (its child class) rendering/RenderView.cpp:310
        class RenderOverflow            - rendering/RenderBox.cpp:2846

        Inherits the following classes from FastAllocBase because these are instantiated by 'new':

        struct FillLayer                - css/CSSStyleSelector.cpp:197
        struct ShadowData               - rendering/style/ShadowData.cpp:35
        class CounterContent            - css/CSSStyleSelector.cpp:4111

        * platform/ScrollbarTheme.h:
        * rendering/RenderOverflow.h:
        * rendering/RenderSelectionInfo.h:
        * rendering/style/CounterContent.h:
        * rendering/style/FillLayer.h:
        * rendering/style/ShadowData.h:
        * storage/DatabaseTracker.h:
        * storage/OriginUsageRecord.h:
        * storage/SQLTransactionClient.h:
        * storage/SQLTransactionCoordinator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 29 Nov 2009 01:53:38 +0000 (01:53 +0000)]
2009-11-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
        https://bugs.webkit.org/show_bug.cgi?id=31950

        Now we cache the last status that we get back from QueueStatusServer.
        Eventually we'll have to do something more fancy if we want to support
        a "try again" button on QueueStatusServer, but we can cross that bridge
        when we come to it.

        * Scripts/modules/patchcollection.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 29 Nov 2009 01:50:48 +0000 (01:50 +0000)]
2009-11-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        StyleQueue scans ~100 bug pages every 5 minutes
        https://bugs.webkit.org/show_bug.cgi?id=31947

        Instead of getting the pending-review attachment ids by scanning each
        bug (which results in a network request), we should just get them all
        from webkit.org/pending-review in one shot.

        * Scripts/modules/bugzilla.py:
        * Scripts/modules/bugzilla_unittest.py:
        * Scripts/modules/commands/queries.py:
        * Scripts/modules/commands/queries_unittest.py:
        * Scripts/modules/commands/queues.py:
        * Scripts/modules/mock_bugzillatool.py:
        * Scripts/modules/patchcollection.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 29 Nov 2009 00:20:45 +0000 (00:20 +0000)]
2009-11-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] CC webkit-bot-watchers whenever the bots touch bugs
        https://bugs.webkit.org/show_bug.cgi?id=31952

        The mailing list is open for anyone to subscribe.

        * Scripts/modules/bugzilla.py:
        * Scripts/modules/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 29 Nov 2009 00:17:33 +0000 (00:17 +0000)]
2009-11-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] style-queue should report style errors to bugzilla
        https://bugs.webkit.org/show_bug.cgi?id=31945

        Currently, we're just logging the style errors locally.  With this
        patch we'll actually log the errors to bugzilla.  Note: I plan to run
        with the "local-only" logging during development.

        * Scripts/modules/commands/queues.py:
        * Scripts/modules/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Sat, 28 Nov 2009 21:48:18 +0000 (21:48 +0000)]
2009-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        Apply workaround for the limitation of VirtualFree with MEM_RELEASE to all ports running on Windows
        https://bugs.webkit.org/show_bug.cgi?id=31943

        * runtime/MarkStack.h:
        (JSC::MarkStack::MarkStackArray::shrinkAllocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 28 Nov 2009 18:27:29 +0000 (18:27 +0000)]
2009-11-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] style-queue shouldn't reject patches from the commit-queue
        https://bugs.webkit.org/show_bug.cgi?id=31944

        Currently the style-queue subprocess gets confused and thinks its the
        commit-queue.  If the patch has an error, it rejects it from the
        commit-queue.  Instead, we should have style-queue specific logic.
        This patch doesn't add that logic, but it gives us a callback we can
        use to add that logic.

        * Scripts/modules/buildsteps.py:
        * Scripts/modules/commands/queues.py:
        * Scripts/modules/landingsequence.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 28 Nov 2009 16:39:11 +0000 (16:39 +0000)]
2009-11-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Sify compose button alerts error
        https://bugs.webkit.org/show_bug.cgi?id=31394

        Test: http/tests/security/calling-versus-current.html

        We're supposed to use the calling context for security checks.  In JSC
        land, this is the lexicalGlobalObject.

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::canAccessPrivate):
2009-11-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Sify compose button alerts error
        https://bugs.webkit.org/show_bug.cgi?id=31394

        Test that we're using the calling security context in a simple case.

        * http/tests/security/calling-versus-current-expected.txt: Added.
        * http/tests/security/calling-versus-current.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-28 Simon Hausmann <simon.hausmann@nokia.com>
eric@webkit.org [Sat, 28 Nov 2009 14:27:42 +0000 (14:27 +0000)]
2009-11-28  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] SoftwareInputPanelRequest event sent when clicking in newly loaded page

        https://bugs.webkit.org/show_bug.cgi?id=31401

        Don't set the event unless there is a focused node we can use
        for editing afterwards.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::handleSoftwareInputPanel):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-28 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
zoltan@webkit.org [Sat, 28 Nov 2009 10:31:18 +0000 (10:31 +0000)]
2009-11-28  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>

        Reviewed by Gavin Barraclough.

        https://bugs.webkit.org/show_bug.cgi?id=31930

        Seems a typo. We don't need ~270k memory to determine the vptrs.

        * runtime/JSGlobalData.cpp:
        (JSC::VPtrSet::VPtrSet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Sat, 28 Nov 2009 07:39:12 +0000 (07:39 +0000)]
2009-11-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Add separate method for pause command to WebDevToolsAgent
        and WebDevToolsFrontendClient interfaces so that pause command
        can be processed on the IO thread.

        https://bugs.webkit.org/show_bug.cgi?id=31934

        * public/WebDevToolsAgent.h:
        * public/WebDevToolsFrontendClient.h:
        (WebKit::WebDevToolsFrontendClient::sendDebuggerCommandToAgent):
        (WebKit::WebDevToolsFrontendClient::sendDebuggerPauseScript):
        (WebKit::WebDevToolsFrontendClient::activateWindow):
        (WebKit::WebDevToolsFrontendClient::closeWindow):
        (WebKit::WebDevToolsFrontendClient::dockWindow):
        (WebKit::WebDevToolsFrontendClient::undockWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Sat, 28 Nov 2009 06:15:09 +0000 (06:15 +0000)]
2009-11-27  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed Chromium build fix introduced by r51428.

        [Chromium] Ignore line-height CSS property for PushButton
        https://bugs.webkit.org/show_bug.cgi?id=31712

        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::RenderThemeChromiumSkia::adjustButtonStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Sat, 28 Nov 2009 05:33:49 +0000 (05:33 +0000)]
2009-11-27  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed Chromium test fix by reverting r51413.

        [v8] Do not check the thread when accessing DOMDataStore
        https://bugs.webkit.org/show_bug.cgi?id=31877

        * bindings/v8/V8DOMMap.cpp:
        (WebCore::getDOMNodeMap):
        (WebCore::getDOMObjectMap):
        (WebCore::getActiveDOMObjectMap):
        (WebCore::getDOMSVGElementInstanceMap):
        (WebCore::getDOMSVGObjectWithContextMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sat, 28 Nov 2009 00:32:37 +0000 (00:32 +0000)]
2009-11-27  Daniel Bates  <dbates@webkit.org>

        Unreviewed, comment fix.

        Corrected misspelling of the word "implemented".

        * inspector/front-end/InjectedScriptAccess.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Shinichiro Hamaji <hamaji@chromium.org>
laszlo.1.gombos@nokia.com [Sat, 28 Nov 2009 00:18:01 +0000 (00:18 +0000)]
2009-11-27  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed.

        Move GOwnPtr* from wtf to wtf/gtk
        https://bugs.webkit.org/show_bug.cgi?id=31793

        Build fix for chromium after r51423.
        Exclude gtk directory from chromium build.

        * JavaScriptCore.gyp/JavaScriptCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber stamped by Eric Seidel.
abarth@webkit.org [Fri, 27 Nov 2009 23:46:16 +0000 (23:46 +0000)]
Rubber stamped by Eric Seidel.

Rename CommitQueueStatus to QueueStatusServer to allow for more queues.

* CommitQueueStatus: Removed.
* CommitQueueStatus/app.yaml: Removed.
* CommitQueueStatus/filters: Removed.
* CommitQueueStatus/filters/__init__.py: Removed.
* CommitQueueStatus/filters/webkit_extras.py: Removed.
* CommitQueueStatus/index.html: Removed.
* CommitQueueStatus/index.yaml: Removed.
* CommitQueueStatus/queue_status.py: Removed.
* CommitQueueStatus/stylesheets: Removed.
* CommitQueueStatus/stylesheets/main.css: Removed.
* CommitQueueStatus/update_status.html: Removed.
* QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 23:39:59 +0000 (23:39 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        style-queue should only process each patch once
        https://bugs.webkit.org/show_bug.cgi?id=31939

        Actually address reviewer comments!

        * Scripts/bugzilla-tool:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 23:36:20 +0000 (23:36 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] style-queue fails to apply a bunch of patches for no reason
        https://bugs.webkit.org/show_bug.cgi?id=31942

        By passing --non-interactive to check-style, we convince check-style
        to pass --force to svn-apply, which lets it apply more patches.

        * Scripts/modules/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 23:35:18 +0000 (23:35 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Support --status-host in style-queue
        https://bugs.webkit.org/show_bug.cgi?id=31941

        * Scripts/modules/commands/queues.py:
        * Scripts/modules/statusbot.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 23:34:44 +0000 (23:34 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        style-queue should only process each patch once
        https://bugs.webkit.org/show_bug.cgi?id=31939

        Before processing a patch, the try-queues now ask the web service
        whether they have already processed the patch.  This is an initial cut
        of this functionality.  I expect we're make it richer over time.

        * Scripts/bugzilla-tool:
        * Scripts/modules/commands/queues.py:
        * Scripts/modules/patchcollection.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 23:34:04 +0000 (23:34 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        PatchStatus does not return status
        https://bugs.webkit.org/show_bug.cgi?id=31938

        We need to parse attachment_id as an int.  Otherwise, we can't find
        anything in the datastore.

        * CommitQueueStatus/queue_status.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Fri, 27 Nov 2009 23:04:50 +0000 (23:04 +0000)]
2009-11-27  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=31940

        Makes the error messages more descriptive when we refuse to load an object/embed or
        refuse to load from the document base URL.

        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::canLoadObject): Changed console message to be more descriptive.
        (WebCore::XSSAuditor::canSetBaseElementURL): Ditto.
2009-11-27  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=31940

        Rebased results because of new error messages.

        * http/tests/security/xssAuditor/base-href-control-char-expected.txt:
        * http/tests/security/xssAuditor/base-href-expected.txt:
        * http/tests/security/xssAuditor/base-href-null-char-expected.txt:
        * http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
        * http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
        * http/tests/security/xssAuditor/embed-tag-expected.txt:
        * http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
        * http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
        * http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
        * http/tests/security/xssAuditor/object-embed-tag-expected.txt:
        * http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
        * http/tests/security/xssAuditor/object-src-inject-expected.txt:
        * http/tests/security/xssAuditor/object-tag-expected.txt:
        * http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
eric@webkit.org [Fri, 27 Nov 2009 18:49:01 +0000 (18:49 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Make commit-queue status not throw an exception where there is not
        status
        https://bugs.webkit.org/show_bug.cgi?id=31936

        We need to actually fetch the results of the query to see what's in the
        datastore.

        * CommitQueueStatus/queue_status.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 18:09:36 +0000 (18:09 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] unit test ApplyPatches and ApplyAttachment
        https://bugs.webkit.org/show_bug.cgi?id=31935

        * Scripts/modules/commands/download.py:
        * Scripts/modules/commands/download_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 17:37:46 +0000 (17:37 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Unit test download commands
        https://bugs.webkit.org/show_bug.cgi?id=31923

        Adds download_unittest and fixes a bug found while testing.

        * Scripts/modules/commands/commandtest.py:
        * Scripts/modules/commands/download.py:
            Fixed a bug where we'd throw an error because [].append returns
            None.
        * Scripts/modules/commands/download_unittest.py: Added.
        * Scripts/modules/mock_bugzillatool.py:
        * Scripts/run-webkit-unittests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Kenneth Russell <kbr@google.com>
eric@webkit.org [Fri, 27 Nov 2009 16:21:00 +0000 (16:21 +0000)]
2009-11-27  Kenneth Russell  <kbr@google.com>

        Reviewed by Eric Seidel.

        REGRESSION(51418): fast/canvas/webgl/gl-object-get-calls.html is failing on the Leopard commit bot
        https://bugs.webkit.org/show_bug.cgi?id=31919

        Temporarily disabled portion of test which is failing on some
        machines but not others. Root cause will be investigated under
        https://bugs.webkit.org/show_bug.cgi?id=31843 .

        * fast/canvas/webgl/gl-object-get-calls-expected.txt:
        * fast/canvas/webgl/script-tests/gl-object-get-calls.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 27 Nov 2009 13:07:06 +0000 (13:07 +0000)]
2009-11-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        This is a WebCore part of the fix that allows to view plugin
        resources loaded by plugins.

        https://bugs.webkit.org/show_bug.cgi?id=31832

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::willSendRequest):
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didReceiveContentLength):
        (WebCore::InspectorController::didFinishLoading):
        (WebCore::InspectorController::didFailLoading):
        * inspector/InspectorController.h:
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::addLength):
        * loader/ResourceLoadNotifier.cpp:
        (WebCore::ResourceLoadNotifier::didFailToLoad):
        (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
        (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
        (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
2009-11-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        WebCore part of the fix that allows to view plugin
        resources loaded by plugins. Methods that for resource
        loading notifications are exposed through WebDevToolsAgent
        interface to the glue code to allow Chromium's plugin
        implementation to notify InspectorController about resource
        loading in plugins.

        https://bugs.webkit.org/show_bug.cgi?id=31832

        * public/WebDevToolsAgent.h:
        * public/WebView.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::createUniqueIdentifierForRequest):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 27 Nov 2009 11:12:44 +0000 (11:12 +0000)]
2009-11-27  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Instead of generating negative identifiers for cached resources in
        InspectorController and extending identifier type from 'unsigned long' to 'long
        long' reuse progress tracker from the inspected page to generate those
        identifiers. It guarantees that InspectorResources have unique ids since
        all of them are generated by that progress tracker.

        Added a couple new overloaded methods to Script* objects that accept
        long and unsigned long arguments. These types of argumens have already
        been passed as long long.

        https://bugs.webkit.org/show_bug.cgi?id=31921

        * bindings/js/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::appendArgument):
        * bindings/js/ScriptFunctionCall.h:
        * bindings/js/ScriptObject.cpp:
        (WebCore::ScriptObject::set):
        * bindings/js/ScriptObject.h:
        * bindings/v8/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::appendArgument):
        * bindings/v8/ScriptFunctionCall.h:
        * bindings/v8/ScriptObject.cpp:
        (WebCore::ScriptObject::set):
        * bindings/v8/ScriptObject.h:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::dispatchOnInjectedScript):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::getTrackedResource):
        (WebCore::InspectorController::didLoadResourceFromMemoryCache): Use inspected page's ProgressTracker to generate unique identifiers for cached resources in InspectorController.
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::buildObjectForNode):
        (WebCore::InspectorDOMAgent::buildObjectForEventListener):
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::addResource):
        (WebCore::InspectorFrontend::updateResource):
        (WebCore::InspectorFrontend::removeResource):
        (WebCore::InspectorFrontend::updateFocusedNode):
        * inspector/InspectorFrontend.h:
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::InspectorResource):
        (WebCore::InspectorResource::createCached):
        * inspector/InspectorResource.h: Change InspectorResource identifier type from 'long long' to 'unsigned long'.
        (WebCore::InspectorResource::create):
        (WebCore::InspectorResource::identifier):
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createResourceSendRequestRecord):
        (WebCore::TimelineRecordFactory::createResourceReceiveResponseRecord):
        (WebCore::TimelineRecordFactory::createResourceFinishRecord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 08:45:15 +0000 (08:45 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Unreviewed "build" fix found while writing unit tests.

        * Scripts/modules/commands/download.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 08:04:38 +0000 (08:04 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Kill WebKitLandingScripts
        https://bugs.webkit.org/show_bug.cgi?id=31904

        Step 6: Kill the rest.

        * Scripts/modules/buildsteps.py:
        * Scripts/modules/commands/download.py:
        * Scripts/modules/commands/queries.py:
        * Scripts/modules/commands/upload.py:
        * Scripts/modules/landingsequence.py:
        * Scripts/modules/scm.py:
        * Scripts/modules/webkitlandingscripts.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 08:02:05 +0000 (08:02 +0000)]
2009-11-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Unit test upload commands
        https://bugs.webkit.org/show_bug.cgi?id=31903

        Adds unit tests for all but two of the upload commands.  The two
        remaining ones are more difficult.  I'll return to them later.  The
        goal of these tests is just to run the commands.  We can test more
        detailed behavior later.

        * Scripts/modules/commands/commandtest.py:
        * Scripts/modules/commands/upload.py:
        * Scripts/modules/commands/upload_unittest.py:
        * Scripts/modules/mock.py: Added.
        * Scripts/modules/mock_bugzillatool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 07:56:51 +0000 (07:56 +0000)]
2009-11-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Kill WebKitLandingScripts
        https://bugs.webkit.org/show_bug.cgi?id=31904

        Step 5: Kill run_and_throw_if_fail.

        * Scripts/modules/buildsteps.py:
        * Scripts/modules/processutils.py: Added.
        * Scripts/modules/webkitlandingscripts.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 07:56:24 +0000 (07:56 +0000)]
2009-11-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Kill WebKitLandingScripts
        https://bugs.webkit.org/show_bug.cgi?id=31904

        Step 4: Kill run_webkit_script.

        * Scripts/modules/buildsteps.py:
        * Scripts/modules/commands/download.py:
        * Scripts/modules/webkitlandingscripts.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 07:55:57 +0000 (07:55 +0000)]
2009-11-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Kill WebKitLandingScripts
        https://bugs.webkit.org/show_bug.cgi?id=31904

        Step 3: Kill build_webkit.

        * Scripts/modules/buildsteps.py:
        * Scripts/modules/landingsequence.py:
        * Scripts/modules/webkitlandingscripts.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 07:55:31 +0000 (07:55 +0000)]
2009-11-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Kill WebKitLandingScripts
        https://bugs.webkit.org/show_bug.cgi?id=31904

        Step 2: Kill ensure_builders_are_green.

        * Scripts/modules/buildsteps.py:
        * Scripts/modules/commands/download.py:
        * Scripts/modules/landingsequence.py:
        * Scripts/modules/webkitlandingscripts.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 Nov 2009 07:54:57 +0000 (07:54 +0000)]
2009-11-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Kill WebKitLandingScripts
        https://bugs.webkit.org/show_bug.cgi?id=31904

        Step 1: Kill prepare_clean_working_directory and run_webkit_tests.

        * Scripts/bugzilla-tool:
        * Scripts/modules/buildsteps.py: Added.
        * Scripts/modules/commands/download.py:
        * Scripts/modules/landingsequence.py:
        * Scripts/modules/webkitlandingscripts.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 27 Nov 2009 07:51:38 +0000 (07:51 +0000)]
2009-11-26  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed red bot fix.

        Skip tests introduced by the previous change as it seems to be failing.

        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 27 Nov 2009 06:11:25 +0000 (06:11 +0000)]
2009-11-26  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dan Bernstein.

        Assertion failure in RenderBlock::positionForPointWithInlineChildren when running fast/inline/relative-positioned-overflow.html
        https://bugs.webkit.org/show_bug.cgi?id=29966

        A test case where a user drags the mouse from an empty inline
        element to above texts.

        * editing/selection/last-empty-inline-expected.txt: Added.
        * editing/selection/last-empty-inline.html: Added.
        * platform/win/Skipped:
2009-11-26  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dan Bernstein.

        Assertion failure in RenderBlock::positionForPointWithInlineChildren when running fast/inline/relative-positioned-overflow.html
        https://bugs.webkit.org/show_bug.cgi?id=29966

        When an empty inline element is clicked, the root inline box has
        no leaf children. Use the renderer of a normal child instead.

        This change resolves Windows port's assertion failure in a layout test.
        Also, this fixes the behavior when a user drags the mouse from an
        empty inline element to above texts.

        Test: editing/selection/last-empty-inline.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::positionForPointWithInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Fri, 27 Nov 2009 05:59:55 +0000 (05:59 +0000)]
2009-11-26  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] Ignore line-height CSS property specified to push buttons on
        Windows and Linux.
        https://bugs.webkit.org/show_bug.cgi?id=31712

        LayoutTests/fast/forms/control-restrict-line-height.html checks that the
        following controls should ignore line-height CSS property.
         - <select>
         - <input type=button>
         - <input type=search>
        This change addresses the <input type=button> issue with Chromium/Windows
        and Chromium/Linux.

        * rendering/RenderThemeChromiumSkia.cpp: Implement adjustButtonStyle() to ignore line-height.
        * rendering/RenderThemeChromiumSkia.h: Declare adjustButtonStyle().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Kinuko Yasuda <kinuko@chromium.com>
eric@webkit.org [Fri, 27 Nov 2009 05:53:00 +0000 (05:53 +0000)]
2009-11-26  Kinuko Yasuda  <kinuko@chromium.com>

        Reviewed by Eric Seidel.

        Rewrite the test fast/parser/comment-in-textarea to use dumpAsText
        so that the expected results can be independent of platform differences.
        https://bugs.webkit.org/show_bug.cgi?id=31580

        * fast/parser/comment-in-textarea-expected.txt: Added.
        * fast/parser/comment-in-textarea.html:
        * fast/parser/script-tests/comment-in-textarea.js: Added.
        * platform/mac/fast/parser/comment-in-textarea-expected.checksum: Removed.
        * platform/mac/fast/parser/comment-in-textarea-expected.png: Removed.
        * platform/mac/fast/parser/comment-in-textarea-expected.txt: Removed.
        * platform/win/fast/parser/comment-in-textarea-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 Kinuko Yasuda <kinuko@chromium.com>
eric@webkit.org [Fri, 27 Nov 2009 05:46:06 +0000 (05:46 +0000)]
2009-11-26  Kinuko Yasuda  <kinuko@chromium.com>

        Reviewed by Eric Seidel.

        Remove the special charset meta tag in the clipboard so that
        copy-and-paste with interchange breaklines/spaces works correctly
        within WebKit.

        No new tests.  Layout tests that involve copy-and-paste with
        interchange breaklines (like editing/pasteboard/paste-line-endings-00?)
        should pass on Mac/Chromium with this fix.

        * platform/chromium/ClipboardChromium.cpp:
        * platform/chromium/PasteboardChromium.cpp:
        (WebCore::Pasteboard::documentFragment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-11-26 İsmail Dönmez <ismail@namtrac.org>
eric@webkit.org [Fri, 27 Nov 2009 05:33:58 +0000 (05:33 +0000)]
2009-11-26  İsmail Dönmez  <ismail@namtrac.org>

        Reviewed by Eric Seidel.

        Compile with QT_NO_WHEELEVENT defined.

        * platform/qt/WheelEventQt.cpp:
        (WebCore::PlatformWheelEvent::applyDelta):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51425 268f45cc-cd09-0410-ab3c-d52691b4dbfc