WebKit-https.git
9 years agoUnreviewed, rolling out r91082, r91087, and r91089.
commit-queue@webkit.org [Fri, 15 Jul 2011 19:46:47 +0000 (19:46 +0000)]
Unreviewed, rolling out r91082, r91087, and r91089.
http://trac.webkit.org/changeset/91082
http://trac.webkit.org/changeset/91087
http://trac.webkit.org/changeset/91089
https://bugs.webkit.org/show_bug.cgi?id=64616

gtk tests are failing a lot after this change. (Requested by
dave_levin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-15

* wtf/ThreadIdentifierDataPthreads.cpp:
(WTF::ThreadIdentifierData::identifier):
(WTF::ThreadIdentifierData::initialize):
(WTF::ThreadIdentifierData::initializeKeyOnceHelper):
(WTF::ThreadIdentifierData::initializeKeyOnce):
* wtf/ThreadIdentifierDataPthreads.h:
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[SKIA] Must make skia's GL context current before drawing in GraphicsContext::clearRect
commit-queue@webkit.org [Fri, 15 Jul 2011 19:44:23 +0000 (19:44 +0000)]
[SKIA] Must make skia's GL context current before drawing in GraphicsContext::clearRect
https://bugs.webkit.org/show_bug.cgi?id=64612

Patch by Brian Salomon <bsalomon@google.com> on 2011-07-15
Reviewed by Stephen White.

Tested by compositing/shadows/shadow-drawing.html

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::clearRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove expectation parsing code to TestExpectationParser.
dglazkov@chromium.org [Fri, 15 Jul 2011 19:33:50 +0000 (19:33 +0000)]
Move expectation parsing code to TestExpectationParser.
https://bugs.webkit.org/show_bug.cgi?id=64605

This is a somewhat mechanical move, with two interesting bits:

1) TestExpectationParser.parse methods renamed to tokenize, to better
reflect what they do

2) TestExpectationLine now carries all of its info, from tokens to parsed data,
and even the list of tests that it matches (a line may refer to more than one test).

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Moved parsing-related TestExpectaions methods
    to TestExpectationParser, added more members to TestExpectationLine to carry parsed info, renamed existing parse methods
    to "tokenize", changed callsites to use new code.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed unit tests to reflect renames.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwitch to use Python enumerate function to enumerate line numbers.
dglazkov@chromium.org [Fri, 15 Jul 2011 19:29:43 +0000 (19:29 +0000)]
Switch to use Python enumerate function to enumerate line numbers.
https://bugs.webkit.org/show_bug.cgi?id=64602

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use enumerate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAvoid rounded rect corner-drawing overhead if no corners are visible
commit-queue@webkit.org [Fri, 15 Jul 2011 19:27:30 +0000 (19:27 +0000)]
Avoid rounded rect corner-drawing overhead if no corners are visible
https://bugs.webkit.org/show_bug.cgi?id=64584

Patch by Ian Henderson <ianh@apple.com> on 2011-07-15
Reviewed by Simon Fraser.

No new tests, rendering is visually identical.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations): Pass PaintInfo into
paintBorder.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations): Ditto.
* rendering/RenderBoxModelObject.cpp:
(WebCore::unroundClippedCorners):
(WebCore::RenderBoxModelObject::paintBorder):
Any invisible corner may be replaced with a corner of radius zero, as
long as the stroke style is solid.  Change the GraphicsContext
parameter into a PaintInfo parameter so we can get the rect to be
drawn.
* rendering/RenderBoxModelObject.h:
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations): Pass PaintInfo into
paintBorder.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paintBoxDecorations): Ditto.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBoxDecorations): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother attempted build fix.
levin@chromium.org [Fri, 15 Jul 2011 19:23:32 +0000 (19:23 +0000)]
Another attempted build fix.

* wtf/ThreadIdentifierDataPthreads.cpp: Add include to pick
up the definition of PTHREAD_KEYS_MAX.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd UserAgentStyleSheetsData.cpp to WebCore.vcproj
jeffm@apple.com [Fri, 15 Jul 2011 19:16:05 +0000 (19:16 +0000)]
Add UserAgentStyleSheetsData.cpp to WebCore.vcproj
https://bugs.webkit.org/show_bug.cgi?id=64609

Add UserAgentStyleSheetsData.cpp to WebCore.vcproj for convenient access, but don't compile it.
This matches what we do with other generated DerivedSources.

Reviewed by Brian Weinstein.

No new tests, just adding a file.

* WebCore.vcproj/WebCore.vcproj: Add UserAgentStyleSheetsData.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium build fix.
levin@chromium.org [Fri, 15 Jul 2011 19:15:49 +0000 (19:15 +0000)]
Chromium build fix.

* wtf/ThreadIdentifierDataPthreads.cpp: Add include to pick
up the definition of PTHREAD_KEYS_MAX.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Yet more chromium test baselines.
senorblanco@chromium.org [Fri, 15 Jul 2011 19:14:08 +0000 (19:14 +0000)]
Unreviewed.  Yet more chromium test baselines.

Somehow I messed these up in my mass-rebaselining.

* platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFind indicator should take scale factor into account
andersca@apple.com [Fri, 15 Jul 2011 19:10:53 +0000 (19:10 +0000)]
Find indicator should take scale factor into account
https://bugs.webkit.org/show_bug.cgi?id=64611
<rdar://problem/9761020>

Reviewed by Sam Weinig.

* UIProcess/FindIndicator.cpp:
(WebKit::FindIndicator::create):
(WebKit::FindIndicator::FindIndicator):
Keep track of the scale factor of the find indicator bitmap.

(WebKit::FindIndicator::draw):
Pass the scale factor to ShareableBitmap::draw.

* UIProcess/FindIndicator.h:
Add scale factor member variable.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setFindIndicator):
This now takes the content image scale factor.

* UIProcess/WebPageProxy.messages.in:
Add the scale factor.

* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
Size the backing store correctly, and apply the scale factor to
the graphics context.

(WebKit::FindController::hideFindIndicator):
Pass the scale factor along.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPart of https://bugs.webkit.org/show_bug.cgi?id=63674
psolanki@apple.com [Fri, 15 Jul 2011 18:52:51 +0000 (18:52 +0000)]
Part of https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

No new tests because no change in functionality and option is not enabled on Mac.

* platform/network/cf/AuthenticationCF.h: Just use AuthenticationMac.h instead of having
Mac-specific declarations here.
* platform/network/cf/CredentialStorageCFNet.cpp:
* platform/network/mac/AuthenticationMac.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed; chromium test expectations update.
senorblanco@chromium.org [Fri, 15 Jul 2011 18:51:35 +0000 (18:51 +0000)]
Unreviewed; chromium test expectations update.

Remove some now-passing tests from chromium's text_expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocurrentThread is too slow!
levin@chromium.org [Fri, 15 Jul 2011 18:49:24 +0000 (18:49 +0000)]
currentThread is too slow!
https://bugs.webkit.org/show_bug.cgi?id=64577

Reviewed by Darin Adler and Dmitry Titov.

The problem is that currentThread results in a pthread_once call which always takes a lock.
With this change, currentThread is 10% faster than isMainThread in release mode and only
5% slower than isMainThread in debug.

* wtf/ThreadIdentifierDataPthreads.cpp:
(WTF::ThreadIdentifierData::initializeOnce): Remove the pthread once stuff
which is no longer needed because this is called from initializeThreading().
(WTF::ThreadIdentifierData::identifier): Remove the initializeKeyOnce call because
intialization of the pthread key should already be done.
(WTF::ThreadIdentifierData::initialize): Ditto.
* wtf/ThreadIdentifierDataPthreads.h:
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading): Acquire the pthread key here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPart of https://bugs.webkit.org/show_bug.cgi?id=63674
psolanki@apple.com [Fri, 15 Jul 2011 18:38:14 +0000 (18:38 +0000)]
Part of https://bugs.webkit.org/show_bug.cgi?id=63674
Get webkit to compile with USE(CFNETWORK) enabled on Mac

Reviewed by David Kilzer.

Get LoaderRunLoop to work on Mac when USE(CFNETWORK) is enabled. Although we could use the
main run loop, it's better to have a separate thread handling the loads so that it can work
in parallel to the main thread. This is similar to what NSURLConnection does for us
internally when we use the NS APIs.

No new tests because no change in functionality and option is not enabled on Mac.

* platform/network/cf/LoaderRunLoopCF.cpp:
(WebCore::runLoaderThread): Create an autorelease pool for objc code that might be called in
the run loop.
(WebCore::loaderRunLoop):
* platform/network/cf/LoaderRunLoopCF.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. New chromium test baselines after r91069.
senorblanco@chromium.org [Fri, 15 Jul 2011 18:34:37 +0000 (18:34 +0000)]
Unreviewed.  New chromium test baselines after r91069.

* platform/chromium-gpu-win/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-win-vista/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Removed.
* platform/chromium-win-vista/fast/block: Added.
* platform/chromium-win-vista/fast/block/positioning: Added.
* platform/chromium-win-vista/fast/block/positioning/auto: Added.
* platform/chromium-win-vista/fast/block/positioning/auto/vertical-lr: Added.
* platform/chromium-win-vista/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
* platform/chromium-win-vista/fast/block/positioning/auto/vertical-rl: Added.
* platform/chromium-win-vista/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
* platform/chromium-win-vista/fast/blockflow/english-lr-text-expected.png: Added.
* platform/chromium-win-vista/fast/blockflow/fallback-orientation-expected.png:
* platform/chromium-win-vista/fast/text/stroking-decorations-expected.png: Added.
* platform/chromium-win-vista/fast/text/stroking-expected.png: Added.
* platform/chromium-win-vista/platform/chromium/fast/text/text-stroke-with-border-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-I18N: Added.
* platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added.
* platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added.
* platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added.
* platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added.
* platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added.
* platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added.
* platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added.
* platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png: Removed.
* platform/chromium-win-vista/svg/custom/foreign-object-skew-expected.png: Removed.
* platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.png: Added.
* platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/chromium-win-vista/svg/zoom/text: Added.
* platform/chromium-win-vista/svg/zoom/text/zoom-foreignObject-expected.png: Added.
* platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
* platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
* platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
* platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
* platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
* platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
* platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
* platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
* platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.png:
* platform/chromium-win-xp/fast/blockflow/japanese-lr-text-expected.png: Added.
* platform/chromium-win-xp/fast/blockflow/japanese-rl-text-expected.png: Added.
* platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
* platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
* platform/chromium-win-xp/fast/blockflow/vertical-align-table-baseline-expected.png:
* platform/chromium-win-xp/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
* platform/chromium-win-xp/fast/dynamic: Added.
* platform/chromium-win-xp/fast/dynamic/text-combine-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/japanese-rl-selection-repaint-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
* platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-I18N: Added.
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added.
* platform/chromium-win-xp/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
* platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Removed.
* platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
* platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Removed.
* platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.png:
* platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
* platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
* platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
* platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
* platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
* platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
* platform/chromium-win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
* platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-win/fast/backgrounds/svg-as-background-5-expected.png:
* platform/chromium-win/fast/block/lineboxcontain/inline-box-vertical-expected.png:
* platform/chromium-win/fast/block/positioning/auto/vertical-lr/001-expected.png:
* platform/chromium-win/fast/block/positioning/auto/vertical-lr/002-expected.png:
* platform/chromium-win/fast/block/positioning/auto/vertical-lr/003-expected.png:
* platform/chromium-win/fast/block/positioning/auto/vertical-lr/004-expected.png:
* platform/chromium-win/fast/block/positioning/auto/vertical-rl/001-expected.png:
* platform/chromium-win/fast/block/positioning/auto/vertical-rl/002-expected.png:
* platform/chromium-win/fast/block/positioning/auto/vertical-rl/003-expected.png:
* platform/chromium-win/fast/block/positioning/auto/vertical-rl/004-expected.png:
* platform/chromium-win/fast/block/positioning/vertical-lr/001-expected.png:
* platform/chromium-win/fast/block/positioning/vertical-lr/002-expected.png:
* platform/chromium-win/fast/block/positioning/vertical-rl/001-expected.png:
* platform/chromium-win/fast/block/positioning/vertical-rl/002-expected.png:
* platform/chromium-win/fast/block/positioning/vertical-rl/fixed-positioning-expected.png:
* platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
* platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png:
* platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.png:
* platform/chromium-win/fast/blockflow/english-rl-text-expected.png:
* platform/chromium-win/fast/blockflow/japanese-rl-text-with-broken-font-expected.png:
* platform/chromium-win/fast/blockflow/vertical-align-table-baseline-expected.png:
* platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.png:
* platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.png:
* platform/chromium-win/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-win/fast/css/h1-in-section-elements-expected.png:
* platform/chromium-win/fast/dom/scroll-reveal-top-overflow-expected.png:
* platform/chromium-win/fast/forms/placeholder-position-expected.png:
* platform/chromium-win/fast/html/details-writing-mode-expected.png:
* platform/chromium-win/fast/lists/001-vertical-expected.png:
* platform/chromium-win/fast/lists/002-vertical-expected.png:
* platform/chromium-win/fast/lists/003-vertical-expected.png:
* platform/chromium-win/fast/lists/005-vertical-expected.png:
* platform/chromium-win/fast/lists/006-vertical-expected.png:
* platform/chromium-win/fast/lists/007-vertical-expected.png:
* platform/chromium-win/fast/lists/008-vertical-expected.png:
* platform/chromium-win/fast/lists/009-vertical-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
* platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.png:
* platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
* platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.png:
* platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.png:
* platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
* platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.png:
* platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.png:
* platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:
* platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
* platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.png:
* platform/chromium-win/fast/repaint/selection-rl-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-win/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.png:
* platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
* platform/chromium-win/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png:
* platform/chromium-win/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.png:
* platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
* platform/chromium-win/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png:
* platform/chromium-win/fast/ruby/overhang-vertical-expected.png: Removed.
* platform/chromium-win/fast/table/027-vertical-expected.png:
* platform/chromium-win/fast/table/028-vertical-expected.png:
* platform/chromium-win/fast/table/035-vertical-expected.png:
* platform/chromium-win/fast/table/038-vertical-expected.png:
* platform/chromium-win/fast/table/auto-with-percent-height-vertical-expected.png:
* platform/chromium-win/fast/table/border-collapsing/001-vertical-expected.png:
* platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.png:
* platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.png:
* platform/chromium-win/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png:
* platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png:
* platform/chromium-win/fast/table/rowspan-paint-order-vertical-expected.png:
* platform/chromium-win/fast/table/table-display-types-vertical-expected.png:
* platform/chromium-win/fast/transforms/shadows-expected.png:
* platform/chromium-win/fast/transforms/transform-on-inline-expected.png:
* platform/chromium-win/fast/transforms/transform-table-row-expected.png:
* platform/chromium-win/fast/transforms/transformed-document-element-expected.png:
* platform/chromium-win/media/audio-repaint-expected.png:
* platform/chromium-win/platform/chromium/fast/text/text-stroke-with-border-expected.png:
* platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
* platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
* platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
* platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
* platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
* platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
* platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
* platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
* platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
* platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
* platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
* platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-group-03-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/text-text-07-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/text-text-08-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
* platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/chromium-win/svg/batik/text/textDecoration-expected.png:
* platform/chromium-win/svg/batik/text/textFeatures-expected.png:
* platform/chromium-win/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
* platform/chromium-win/svg/batik/text/textLayout2-expected.png:
* platform/chromium-win/svg/batik/text/textOnPath-expected.png:
* platform/chromium-win/svg/batik/text/textOnPath2-expected.png:
* platform/chromium-win/svg/batik/text/textOnPath3-expected.png:
* platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.png:
* platform/chromium-win/svg/batik/text/textProperties-expected.png:
* platform/chromium-win/svg/batik/text/textStyles-expected.png:
* platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.png:
* platform/chromium-win/svg/carto.net/colourpicker-expected.png:
* platform/chromium-win/svg/carto.net/combobox-expected.png:
* platform/chromium-win/svg/carto.net/selectionlist-expected.png:
* platform/chromium-win/svg/carto.net/window-expected.png:
* platform/chromium-win/svg/css/group-with-shadow-expected.png:
* platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
* platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-win/svg/custom/focus-ring-expected.png:
* platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
* platform/chromium-win/svg/custom/js-late-gradient-creation-expected.png:
* platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png:
* platform/chromium-win/svg/custom/linking-a-03-b-all-expected.png:
* platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.png:
* platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
* platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-win/svg/custom/pointer-events-text-expected.png:
* platform/chromium-win/svg/custom/struct-use-09-b-expected.png:
* platform/chromium-win/svg/custom/text-dom-01-f-expected.png:
* platform/chromium-win/svg/custom/text-linking-expected.png:
* platform/chromium-win/svg/custom/text-repaint-including-stroke-expected.png:
* platform/chromium-win/svg/custom/text-rotated-gradient-expected.png:
* platform/chromium-win/svg/custom/text-rotation-expected.png:
* platform/chromium-win/svg/custom/use-detach-expected.png:
* platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-1-expected.png:
* platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-2-expected.png:
* platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-3-expected.png:
* platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-4-expected.png:
* platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.png:
* platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-6-expected.png:
* platform/chromium-win/svg/custom/use-on-non-svg-namespaced-element-expected.png:
* platform/chromium-win/svg/custom/use-on-text-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png:
* platform/chromium-win/svg/hixie/error/017-expected.png:
* platform/chromium-win/svg/text/selection-background-color-expected.png:
* platform/chromium-win/svg/text/selection-styles-expected.png:
* platform/chromium-win/svg/text/text-deco-01-b-expected.png:
* platform/chromium-win/svg/text/text-gradient-positioning-expected.png:
* platform/chromium-win/svg/text/text-path-01-b-expected.png:
* platform/chromium-win/svg/text/text-path-middle-align-expected.png:
* platform/chromium-win/svg/text/text-text-07-t-expected.png:
* platform/chromium-win/svg/text/text-text-08-b-expected.png:
* platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/chromium-win/transforms/2d/compound-transforms-vs-containers-expected.png:
* platform/chromium-win/transforms/2d/transform-origin-borderbox-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(91064): Upstream QtWebKit/N9 changes related tovisibleContentRect
kenneth@webkit.org [Fri, 15 Jul 2011 18:25:32 +0000 (18:25 +0000)]
REGRESSION(91064): Upstream QtWebKit/N9 changes related tovisibleContentRect

Reviewed by Antonio Gomes.

Only set setFixedVisibleContentRect when in resizesToContents mode.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fixes for WebKit2. Ensure that all generated sources are
mrobinson@webkit.org [Fri, 15 Jul 2011 18:11:24 +0000 (18:11 +0000)]
Build fixes for WebKit2. Ensure that all generated sources are
on nodist primaries, that they are on forward declared variables
so that BUILT_SOURCES is calculated properly and that zlib is
included during linking (for WOFF support).

.:

* GNUmakefile.am:
* Source/autotools/webkit.m4: Include test for zlib.

Source/WebKit/gtk:

* GNUmakefile.am:

Source/WebKit2:

* GNUmakefile.am:

Tools:

* WebKitTestRunner/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago--webkit-visual-word crash on mixed editability
xji@chromium.org [Fri, 15 Jul 2011 17:23:54 +0000 (17:23 +0000)]
--webkit-visual-word crash on mixed editability
https://bugs.webkit.org/show_bug.cgi?id=61978

--webkit-visual-word crashes (VisiblePosition.getInlineBoxAndOffset could return null box)
https://bugs.webkit.org/show_bug.cgi?id=62814

Reviewed by Ryosuke Niwa.

Source/WebCore:

Replace previousWordPosition/nextWordPosition with previousBoundary/nextBoundary which do
not honor editable bounary. Honor editable boundary as the last stage of leftWordPosition
and rightWordPosition.

Check previousBoundary/nextBoundary against NULL.  Have a static function to encapsulate the
usage of getInlineBoxAndOffset and check the visible position is not NULL before passing to
getInlineBoxAndOffset. Check the box returned from getInlineBoxAndOffset is not NULL before
accessing.

Test: editing/selection/move-by-word-visually-null-box.html

* editing/visible_units.cpp:
(WebCore::positionIsInBox):
(WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality):
(WebCore::lastWordBreakInBox):
(WebCore::positionIsVisuallyOrderedInBoxInBlockWithDifferentDirectionality):
(WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
(WebCore::positionIsInsideBox):
(WebCore::leftWordPositionAcrossBoundary):
(WebCore::rightWordPositionAcrossBoundary):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):

LayoutTests:

Add a standalone test for testing getInlineBoxAndOffset returning null box.

* editing/selection/move-by-word-visually-null-box-expected.txt: Added.
* editing/selection/move-by-word-visually-null-box.html: Added.
* editing/selection/move-by-word-visually-others-expected.txt:
* editing/selection/move-by-word-visually-others.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Mopping up some more expectations after r91069.
senorblanco@chromium.org [Fri, 15 Jul 2011 17:17:57 +0000 (17:17 +0000)]
Unreviewed.  Mopping up some more expectations after r91069.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unncessary creation of connectionProperties dictionary
psolanki@apple.com [Fri, 15 Jul 2011 17:12:10 +0000 (17:12 +0000)]
Remove unncessary creation of connectionProperties dictionary
https://bugs.webkit.org/show_bug.cgi?id=63958

Reviewed by Alexey Proskuryakov.

No new tests because no change in functionality.

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::loadResourceSynchronously):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Mark more tests failing as a result of r91069
enne@google.com [Fri, 15 Jul 2011 16:50:55 +0000 (16:50 +0000)]
[chromium] Mark more tests failing as a result of r91069
https://bugs.webkit.org/show_bug.cgi?id=64368

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStore error and warning information on TestExpectationLine.
dglazkov@chromium.org [Fri, 15 Jul 2011 15:58:00 +0000 (15:58 +0000)]
Store error and warning information on TestExpectationLine.
https://bugs.webkit.org/show_bug.cgi?id=64565

Keeping errors and warnings on the TestExpectationLine instance allows us to decouple storing errors
from various parsing and validation mechanisms and have more flexibility in reporting and understanding the origin of the errors.

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Added TestExpectationLine.warnings list to keep track of non-fatal errors,
    converted the code to add errors and warnings to corresponding TestExpectationLine instances, removed the code that used to store
    this info on TestExpectations. In the process, had to refactor ModifierMatcher a bit to take in a TestExpdectationLine instance.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed ModifierMatcher callsite.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPlumb the use of TestExpectationLine deeper, clean up.
dglazkov@chromium.org [Fri, 15 Jul 2011 15:55:26 +0000 (15:55 +0000)]
Plumb the use of TestExpectationLine deeper, clean up.
https://bugs.webkit.org/show_bug.cgi?id=64559

Instead of carrying various bits of TestExpectationLine, plumb it down to its consumers,
also cleaning up names and remove an unused TestExpectations._get_options_list member.

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove the notion of TestExpectationLine.valid, start storing parsing errors in expec...
dglazkov@chromium.org [Fri, 15 Jul 2011 15:51:37 +0000 (15:51 +0000)]
Remove the notion of TestExpectationLine.valid, start storing parsing errors in expectations themselves.
https://bugs.webkit.org/show_bug.cgi?id=64554

This moves us toward the world where errors are collected on the expectations, which allows us to
easily enumerate them, keep association with the point of origin, and freely pass TestExpectationLine instances around.

Also eliminate the validator idea, since validation is a context-dependent concept and has to be decoupled from initial
parsing.

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed TestExpectation.valid, validator,
    changed TestExpectationParser to collect errors in TestExpectationLine, refactored surrounding code.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to accommodate changes.
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Focusing on another node while editing CSS property does not update...
pfeldman@chromium.org [Fri, 15 Jul 2011 15:34:28 +0000 (15:34 +0000)]
Web Inspector: Focusing on another node while editing CSS property does not update styles
https://bugs.webkit.org/show_bug.cgi?id=64283

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/styles/styles-change-node-while-editing.html

* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSProperty.prototype.setText):
(WebInspector.CSSProperty.prototype.setText.callback):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._inlineStyleInvalidated):
(WebInspector.DOMDispatcher.prototype.inlineStyleInvalidated):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._attributesUpdated):
(WebInspector.ElementsPanel.prototype.updateStyles):
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane):
(WebInspector.MetricsSidebarPane.prototype.update):
(WebInspector.MetricsSidebarPane.prototype._innerUpdate.callback):
(WebInspector.MetricsSidebarPane.prototype._innerUpdate.inlineStyleCallback):
(WebInspector.MetricsSidebarPane.prototype._innerUpdate):
(WebInspector.MetricsSidebarPane.prototype._styleSheetChanged):
(WebInspector.MetricsSidebarPane.prototype._attributesUpdated):
(WebInspector.MetricsSidebarPane.prototype.startEditing):
(WebInspector.MetricsSidebarPane.prototype.editingEnded):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.stylesCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):
(WebInspector.StylesSidebarPane.prototype._styleSheetChanged):
(WebInspector.StylesSidebarPane.prototype._attributesUpdated):
(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._nodeStylesUpdatedForTest):
(WebInspector.StylesSidebarPane.prototype._toggleElementStatePane):
(WebInspector.StylesSidebarPane.prototype._createElementStatePane.clickListener):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.event):
(WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):
(WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert):

LayoutTests:

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.waitForStyles):
* inspector/styles/styles-change-node-while-editing-expected.txt: Added.
* inspector/styles/styles-change-node-while-editing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[skia] remove legacy draw-text-as-paths code, as skia now draws all text as text
commit-queue@webkit.org [Fri, 15 Jul 2011 15:27:30 +0000 (15:27 +0000)]
[skia] remove legacy draw-text-as-paths code, as skia now draws all text as text
https://bugs.webkit.org/show_bug.cgi?id=64368

Patch by Mike Reed <reed@google.com> on 2011-07-15
Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
* platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
(WebCore::FontPlatformData::RefCountedHFONT::~RefCountedHFONT):
* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::draw):
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::skiaDrawText):
(WebCore::setupPaintForFont):
(WebCore::paintSkiaText):
* platform/graphics/skia/SkiaFontWin.h:

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename TestFailureBugForm to FailingTestsBugForm
aroben@apple.com [Fri, 15 Jul 2011 15:10:17 +0000 (15:10 +0000)]
Rename TestFailureBugForm to FailingTestsBugForm

The new name will match better with a forthcoming FlakyTestBugForm class.

Fixes <http://webkit.org/b/64598> TestFailures page's TestFailureBugForm class has a bad
name

Reviewed by Daniel Bates.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm_unittests.js.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
Updated for renames.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Ditto, and
reordered <script>s to put files which others depend on for parsing first.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPixel difference in FEMorphology effect
commit-queue@webkit.org [Fri, 15 Jul 2011 14:38:13 +0000 (14:38 +0000)]
Pixel difference in FEMorphology effect
https://bugs.webkit.org/show_bug.cgi?id=63930

Source/WebCore:

Patch by Piroska AndrĂ¡s <Piroska.Andras@stud.u-szeged.hu> on 2011-07-15
Reviewed by Zoltan Herczeg.

Using short-circuit evaluation in the setFilterEffectAttribute function
was wrong. We should call both setRadius functions and evaluate the
changes separately.

* svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::setFilterEffectAttribute):

LayoutTests:

Patch by Gabor Loki <loki@webkit.org> on 2011-07-15
Reviewed by Zoltan Herczeg.

Layout test is updated to follow the bugfix.

* platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFullscreen content doesn't use fullscreen controller on Windows
jeffm@apple.com [Fri, 15 Jul 2011 14:02:17 +0000 (14:02 +0000)]
Fullscreen content doesn't use fullscreen controller on Windows
https://bugs.webkit.org/show_bug.cgi?id=64540
<rdar://problem/9510455>

Source/WebCore:

Reviewed by Darin Adler.

RenderThemeWin needs to override extraFullScreenStyleSheet() to return
the fullscreenQuickTime stylesheet.

Test added to fullscreen/video-controls-override.html.

* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::extraFullScreenStyleSheet): Added.
* rendering/RenderThemeWin.h: Override extraFullScreenStyleSheet().

LayoutTests:

Reviewed by Darin Adler.

Add another test to video-controls-override.html to verify that
we're using the correct fullscreen controller by checking the
height of the controller panel, which is taller than the non-fullscreen
version. Unfortunately, the fullscreen tests don't work on Windows
yet, but I verified this would have caught this issue by simulating
the bug on the Mac.

* fullscreen/video-controls-override-expected.txt: Add new test to check the height of the panel.

* fullscreen/video-controls-override.html: Add new test to check the height of the panel, and
log errors if window.internals or window.layoutTestController are undefined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-15 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 15 Jul 2011 13:10:48 +0000 (13:10 +0000)]
2011-07-15  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix build failure introduced in r91061.

        * page/Console.cpp:
        (WebCore::Console::markTimeline): Remove argument name from unused parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpstream QtWebKit/N9 changes related to visibleContentRect
kenneth@webkit.org [Fri, 15 Jul 2011 12:02:59 +0000 (12:02 +0000)]
Upstream QtWebKit/N9 changes related to visibleContentRect
https://bugs.webkit.org/show_bug.cgi?id=64589

Reviewed by Simon Hausmann.

Source/WebCore:

Rename setActualVisibleContentRect to setFixedVisibleContentRect
as that makes it more obvious that it is an override. It is also
consistent with the setFixedLayout which is often used in
conjunction with it.

Make visibleContentRect return the fixed value if set, and remove
all calls to actualVisibleContentRect.

Also updated the documentation.

This is similar to what we have on our QtWebKit/N9 branch and is
pretty well tested.

* platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRect):
If a fixed visibleContentRect is set, return that.
Remove the code returning the contents size when in
paintsEntireContents mode as that is wrong and already
ifdeffed out for EFL.
(WebCore::ScrollView::setScrollPosition):
Do not try to be smart and update the fixed visibleContentsRect
automatically, as the embedder might ignore the scroll request
for various reasons.
* platform/ScrollView.h:
(WebCore::ScrollView::setFixedVisibleContentRect):
(WebCore::ScrollView::fixedVisibleContentRect):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::setActualVisibleContentRect):
Change to use setFixedVisibleContentRect.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
Only set fixedVisibleContentRect for the mainframe.
* symbian/eabi/QtWebKitu.def:

Source/WebKit2:

Rename setActualVisibleContentRect to setFixedVisibleContentRect
as that makes it more obvious that it is an override. It is also
consistent with the setFixedLayout which is often used in
conjunction with it.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setFixedVisibleContentRect):
* UIProcess/WebPageProxy.h:
* UIProcess/qt/qtouchwebpageproxy.cpp:
(QTouchWebPageProxy::setVisibleArea):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Only set fixedVisibleContentRect for the mainframe.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setFixedVisibleContentRect):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Build plugin process by default when building WebKit2
carlosgc@webkit.org [Fri, 15 Jul 2011 11:09:38 +0000 (11:09 +0000)]
[GTK] Build plugin process by default when building WebKit2
https://bugs.webkit.org/show_bug.cgi?id=64592

Reviewed by Philippe Normand.

* configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed by Martin Robinson.
carlosgc@webkit.org [Fri, 15 Jul 2011 10:40:36 +0000 (10:40 +0000)]
Reviewed by Martin Robinson.

[GTK] Install a custom X error handler in plugin process
https://bugs.webkit.org/show_bug.cgi?id=63248

Some plugins, specially flash, can cause X errors that when
handled by the default X error handler (or the GDK one) abort the
process. Since we don't want to crash due to buggy plugins, we
install a custom error handler to show a warning when a X error
happens without aborting.

* PluginProcess/gtk/PluginProcessMainGtk.cpp:
(WebKit::webkitgtkXError):
(WebKit::PluginProcessMainGtk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Rename console.markTimeline() to console.timeStamp() for Firebug compa...
commit-queue@webkit.org [Fri, 15 Jul 2011 10:06:31 +0000 (10:06 +0000)]
Web Inspector: Rename console.markTimeline() to console.timeStamp() for Firebug compatibility.
https://bugs.webkit.org/show_bug.cgi?id=63317

Patch by Mike West <mkwst@chromium.org> on 2011-07-15
Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/timeline/timeline-time-stamp.html

* inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::consoleTimeStamp):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::consoleTimeStampImpl):
* inspector/InspectorInstrumentation.h:
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didTimeStamp):
* inspector/InspectorTimelineAgent.h:
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createTimeStampData):
* inspector/TimelineRecordFactory.h:
* inspector/front-end/TimelineAgent.js:
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype.update.markPercentagesForRecord):
(WebInspector.TimelineOverviewPane.prototype.update):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._createEventDivider):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
* page/Console.cpp:
(WebCore::Console::markTimeline):
(WebCore::Console::timeStamp):
* page/Console.h:
* page/Console.idl:

LayoutTests:

* inspector/timeline/resources/timeline-iframe-data.html:
* inspector/timeline/timeline-enum-stability-expected.txt:
* inspector/timeline/timeline-event-dispatch.html:
* inspector/timeline/timeline-mark-timeline-expected.txt:
* inspector/timeline/timeline-mark-timeline.html:
* inspector/timeline/timeline-script-tag-1-expected.txt:
* inspector/timeline/timeline-test.js:
(initialize_Timeline.InspectorTest.dumpTimelineRecord):
* inspector/timeline/timeline-time-stamp-expected.txt: Added.
* inspector/timeline/timeline-time-stamp.html: Copied from LayoutTests/inspector/timeline/timeline-mark-timeline.html.
* platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt:
* platform/chromium/inspector/timeline/timeline-time-stamp-expected.txt: Copied from LayoutTests/platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLocalStorage: Changed the value type of ItemTable from TEXT to BLOB
commit-queue@webkit.org [Fri, 15 Jul 2011 08:35:16 +0000 (08:35 +0000)]
LocalStorage: Changed the value type of ItemTable from TEXT to BLOB
to avoid string truncation.
This patch will also convert the exsisting ItemTable and perform
the DATA MIGRATION job.
https://bugs.webkit.org/show_bug.cgi?id=58762

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2011-07-15
Reviewed by Jeremy Orlow.

Tests: manual-tests/localstorage-value-truncation.html

* manual-tests/localstorage-value-truncation.html: Added.
Demostrate the testcase shown in bug 58762.
* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::isColumnDeclearedAsBlob):
Test if the pre-defined type of column is BLOB.
* platform/sql/SQLiteStatement.h:
* storage/StorageAreaSync.cpp:
Change the localStorage value type from Text to BLOB to avoid the
value string truncation at \x00.
(WebCore::StorageAreaSync::openDatabase):
Change the database structure, use BLOB to replace the TEXT type of
value segment in ItemTable.
(WebCore::StorageAreaSync::migrateItemTableIfNeeded):
Migrate the ItemTable if the pre-defined type of value is TEXT.
(WebCore::StorageAreaSync::performImport):
Use getColumnBlobAsString() to import the BLOB value.
(WebCore::StorageAreaSync::sync):
Use bindBlob() to bind value string to the SQLiteStatement for the
database execution.
* storage/StorageAreaSync.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNRWT stores the Chromium revision number in full_results.json
abarth@webkit.org [Fri, 15 Jul 2011 08:22:23 +0000 (08:22 +0000)]
NRWT stores the Chromium revision number in full_results.json
https://bugs.webkit.org/show_bug.cgi?id=64586

I have no earthly idea how to test this change.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/port/base.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClear the content of a search input form when 'Escape' is pressed.
commit-queue@webkit.org [Fri, 15 Jul 2011 08:10:54 +0000 (08:10 +0000)]
Clear the content of a search input form when 'Escape' is pressed.
https://bugs.webkit.org/show_bug.cgi?id=51897

Source/WebCore:

This change added handleKeydownEvent() to a search input form,
which clears the form and triggers a 'search' event when 'Escape' is pressed.

Patch by Kentaro Hara <haraken@google.com> on 2011-07-15
Reviewed by Kent Tamura.

Test: fast/forms/input-search-press-escape-key.html

* html/SearchInputType.cpp:
(WebCore::SearchInputType::handleKeydownEvent):
* html/SearchInputType.h:

LayoutTests:

The added test checks if the value in a search input form is cleared
and a 'search' event is triggered, when we press 'Escape' key.

Patch by Kentaro Hara <haraken@google.com> on 2011-07-15
Reviewed by Kent Tamura.

* fast/forms/input-search-press-escape-key-expected.txt: Added.
* fast/forms/input-search-press-escape-key.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove useRepaintBounds from RenderBlock::layoutRunsAndFloats to LineLayoutState
commit-queue@webkit.org [Fri, 15 Jul 2011 07:23:01 +0000 (07:23 +0000)]
Move useRepaintBounds from RenderBlock::layoutRunsAndFloats to LineLayoutState
https://bugs.webkit.org/show_bug.cgi?id=64360

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-07-15
Reviewed by Hajime Morita.

No new tests needed because the patch is just a refactor.

* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::usesRepaintBounds):
(WebCore::LineLayoutState::setRepaintRange):
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::determineStartPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExceptionCodePlaceholder should have its own ExceptionCodePlaceholder.cpp file
morrita@google.com [Fri, 15 Jul 2011 06:56:22 +0000 (06:56 +0000)]
ExceptionCodePlaceholder should have its own ExceptionCodePlaceholder.cpp file
https://bugs.webkit.org/show_bug.cgi?id=64503

Reviewed by Darin Adler.

No new tests. Just a file reorg.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/ExceptionCodePlaceholder.cpp: Added.
(WebCore::NoExceptionAssertionChecker::NoExceptionAssertionChecker):
(WebCore::NoExceptionAssertionChecker::~NoExceptionAssertionChecker):
* dom/ExceptionCodePlaceholder.h: Removed NoExceptionAssertionChecker::m_function, which is loonger used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] updated test expectations.
hayato@chromium.org [Fri, 15 Jul 2011 06:49:28 +0000 (06:49 +0000)]
[chromium] updated test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofix remaining style issues in the static-dashboards directory
ojan@chromium.org [Fri, 15 Jul 2011 06:38:32 +0000 (06:38 +0000)]
fix remaining style issues in the static-dashboards directory
https://bugs.webkit.org/show_bug.cgi?id=64561

Reviewed by Adam Barth.

* TestResultServer/static-dashboards/aggregate_results.html:
* TestResultServer/static-dashboards/builders.js:
* TestResultServer/static-dashboards/dashboard_base.js:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
* TestResultServer/static-dashboards/timeline_explorer.html:
* TestResultServer/static-dashboards/treemap.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove LegacyDefaultOptionalArguments flag from WebGL
commit-queue@webkit.org [Fri, 15 Jul 2011 06:33:24 +0000 (06:33 +0000)]
Remove LegacyDefaultOptionalArguments flag from WebGL
https://bugs.webkit.org/show_bug.cgi?id=64549

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-07-14
Reviewed by Kenneth Russell.

Source/WebCore:

* html/canvas/WebGLRenderingContext.idl:

LayoutTests:

* fast/canvas/webgl/bad-arguments-test-expected.txt:
* fast/canvas/webgl/bad-arguments-test.html:
* fast/canvas/webgl/context-lost-expected.txt:
* fast/canvas/webgl/context-lost.html:
* fast/canvas/webgl/null-object-behaviour-expected.txt:
* fast/canvas/webgl/null-object-behaviour.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebSocket: Introduce pywebsocket-0.6b2
yutak@chromium.org [Fri, 15 Jul 2011 06:26:26 +0000 (06:26 +0000)]
WebSocket: Introduce pywebsocket-0.6b2
https://bugs.webkit.org/show_bug.cgi?id=64534

Reviewed by Kent Tamura.

Source/WebCore:

pywebsocket now accepts "Sec-WebSocket-Version: 8" as required in hybi-10 specification.

No new functionality is added, thus no new tests. Existing WebSocket tests should keep passing.

* websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::clientHandshakeMessage):
(WebCore::WebSocketHandshake::clientHandshakeRequest):

Tools:

* Scripts/webkitpy/thirdparty/__init__.py:

LayoutTests:

Module "mod_pywebsocket.handshake.hybi06" has been renamed to "mod_pywebsocket.handshake.hybi".

* http/tests/websocket/tests/hybi/bad-handshake-crash_wsh.py:
* http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header_wsh.py:
* http/tests/websocket/tests/hybi/handshake-fail-by-maxlength_wsh.py:
* http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header_wsh.py:
* http/tests/websocket/tests/hybi/handshake-fail-by-no-cr_wsh.py:
* http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header_wsh.py:
* http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null_wsh.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPatch by Jaehun Lim <ljaehun.lim@samsung.com> on 2011-07-14
commit-queue@webkit.org [Fri, 15 Jul 2011 06:07:29 +0000 (06:07 +0000)]
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2011-07-14
Reviewed by Adam Barth.

[EFL] Remove IconDatabase initialization in _ewk_init_body()
https://bugs.webkit.org/show_bug.cgi?id=63491

Make IconDatabase feature optional by removing its initialization from _ewk_init_body().
Now IconDatabase must be fully managed by an application:
if it doesn't want to use it, there's nothing to do. Otherwise, just call
ewk_settings_icon_database_path_set() with the directory path.

* ewk/ewk_main.cpp:
(_ewk_init_body):
* ewk/ewk_settings.cpp:
(ewk_settings_icon_database_path_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIntroduce TestExpectationsModel, split out of TestExpectations.
dglazkov@chromium.org [Fri, 15 Jul 2011 05:58:44 +0000 (05:58 +0000)]
Introduce TestExpectationsModel, split out of TestExpectations.
https://bugs.webkit.org/show_bug.cgi?id=64531

This is a simple split-and-make-work refactoring, a first step among many.

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Moved all model-related members
    out of TestExpectations and into TestExpectationsModel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplaced isChecked() with shouldAppearChecked() in HTMLInputElement.cpp along with...
commit-queue@webkit.org [Fri, 15 Jul 2011 05:37:26 +0000 (05:37 +0000)]
Replaced isChecked() with shouldAppearChecked() in HTMLInputElement.cpp along with all the corresponding function calls.
https://bugs.webkit.org/show_bug.cgi?id=54476

Patch by SravanKumar S <sravan.ken@gmail.com> on 2011-07-14
Reviewed by Darin Adler.

No new tests, since existing fast/dom/HTMLInputElement/checked-pseudo-selector.html verifies the patch.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isChecked):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
* dom/CheckedRadioButtons.cpp:
(WebCore::CheckedRadioButtons::removeButton):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::shouldAppearChecked):
* html/HTMLInputElement.h: Removed virtual declaration from shouldAppearChecked().
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isChecked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<input form="x"> should not associate the input with any forms when there is no ...
bashi@chromium.org [Fri, 15 Jul 2011 04:36:29 +0000 (04:36 +0000)]
<input form="x"> should not associate the input with any forms when there is no  form with id="x"
https://bugs.webkit.org/show_bug.cgi?id=64509

Source/WebCore:

Don't set form owner when a form associated element has the form attribute but there is no such form element.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-07-14
Reviewed by Kent Tamura.

Test: fast/forms/form-attribute-nonexistence-form-id.html

* dom/Document.cpp:
(WebCore::Document::resetFormElementsOwner): Removed the argument which is no longer needed.
* dom/Document.h: Ditto.
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::insertedIntoTree): Resets m_form whenever the element has the form attribute.
(WebCore::FormAssociatedElement::resetFormOwner): Don't set m_form when there is no form element which has the given id.
(WebCore::FormAssociatedElement::formAttributeChanged): Removed the argument of resetFormOwner().
* html/FormAssociatedElement.h: Ditto.
* html/HTMLFormElement.cpp: Ditto.
(WebCore::HTMLFormElement::insertedIntoDocument):
(WebCore::HTMLFormElement::removedFromDocument):

LayoutTests:

Adds a test for checking input elements don't associate any form elements when they have the form attribute which points nonexistence form.
Fixes existing tests that contain unintended form attributes.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-07-14
Reviewed by Kent Tamura.

* fast/forms/form-attribute-nonexistence-form-id-expected.txt: Added.
* fast/forms/form-attribute-nonexistence-form-id.html: Added.
* fast/forms/script-tests/form-attribute.js: Fixed unintended form attributes.
* fast/forms/script-tests/form-collection-elements-order.js: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r90809): Setting a checkbox's checked property, doesn't render as checked...
tkent@chromium.org [Fri, 15 Jul 2011 04:31:28 +0000 (04:31 +0000)]
REGRESSION (r90809): Setting a checkbox's checked property, doesn't render as checked until app window loses focus
https://bugs.webkit.org/show_bug.cgi?id=64537

Reviewed by Darin Adler.

Source/WebCore:

We stopped to call updateCheckedRadioButtons() for checkboxes
since r90809, but we need to call RenderTheme::stateChanged(),
which was in updateCheckedRadioButtons(), for checkboxes.

Tests: fast/forms/checkbox-appearance-change-by-checked-expected.html
       fast/forms/checkbox-appearance-change-by-checked.html

* html/HTMLInputElement.cpp: Move the RenderTheme::stateChanged() call
from updateCheckedRadioButtons() to setChecked().
(WebCore::HTMLInputElement::updateCheckedRadioButtons):
(WebCore::HTMLInputElement::setChecked):

LayoutTests:

* fast/forms/checkbox-appearance-change-by-checked-expected.html: Added.
* fast/forms/checkbox-appearance-change-by-checked.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Updat test expectations for r90971.
tkent@chromium.org [Fri, 15 Jul 2011 03:50:21 +0000 (03:50 +0000)]
[Chromium] Updat test expectations for r90971.

* platform/chromium-linux/fast/forms/input-placeholder-text-indent-expected.png:
* platform/chromium-linux/fast/forms/placeholder-position-expected.png:
* platform/chromium-linux/fast/forms/placeholder-stripped-expected.png:
* platform/chromium-linux/fast/forms/search-styled-expected.png:
* platform/chromium-linux/fast/forms/search-styled-expected.txt:
* platform/chromium-linux/fast/forms/textarea-placeholder-wrapping-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/pseudo-cache-stale-expected.png:
* platform/chromium-mac-leopard/fast/forms/isindex-placeholder-expected.png:
* platform/chromium-mac-leopard/fast/forms/password-placeholder-text-security-expected.png: Removed.
* platform/chromium-mac-leopard/fast/forms/placeholder-position-expected.png:
* platform/chromium-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
* platform/chromium-mac-leopard/fast/forms/search-styled-expected.png:
* platform/chromium-mac/fast/forms/isindex-placeholder-expected.png: Removed.
* platform/chromium-mac/fast/forms/placeholder-position-expected.png: Added.
* platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
* platform/chromium-win/fast/css/pseudo-cache-stale-expected.txt:
* platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.png:
* platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.txt:
* platform/chromium-win/fast/forms/isindex-placeholder-expected.txt:
* platform/chromium-win/fast/forms/password-placeholder-expected.txt:
* platform/chromium-win/fast/forms/password-placeholder-text-security-expected.txt:
* platform/chromium-win/fast/forms/placeholder-position-expected.png:
* platform/chromium-win/fast/forms/placeholder-position-expected.txt:
* platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/chromium-win/fast/forms/placeholder-set-attribute-expected.txt:
* platform/chromium-win/fast/forms/placeholder-stripped-expected.png:
* platform/chromium-win/fast/forms/placeholder-stripped-expected.txt:
* platform/chromium-win/fast/forms/search-placeholder-value-changed-expected.txt:
* platform/chromium-win/fast/forms/search-styled-expected.txt:
* platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/chromium-win/fast/forms/textarea-placeholder-set-attribute-expected.txt:
* platform/chromium-win/fast/forms/textarea-placeholder-wrapping-expected.png: Added.
* platform/chromium-win/fast/forms/textarea-placeholder-wrapping-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove webkitpy off of loose mocks
eric@webkit.org [Fri, 15 Jul 2011 02:33:30 +0000 (02:33 +0000)]
Move webkitpy off of loose mocks
https://bugs.webkit.org/show_bug.cgi?id=64508

Unreviewed.  Fixing a test which fails under test-webkitpy --all (but not in a normal run).

* Scripts/webkitpy/common/checkout/scm/git.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe beforeload event allows tracking URI changes in a frame
abarth@webkit.org [Fri, 15 Jul 2011 02:16:09 +0000 (02:16 +0000)]
The beforeload event allows tracking URI changes in a frame
https://bugs.webkit.org/show_bug.cgi?id=64482

Reviewed by Nate Chapin.

Source/WebCore:

Tests: http/tests/security/beforeload-iframe-client-redirect.html
       http/tests/security/beforeload-iframe-server-redirect.html

Only dispatch the beforeload event for a frame if we haven't yet
committed our first real load.  The URL that we send to our parent will
be the same URL the parent seens in the src attribute.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadWithDocumentLoader):

LayoutTests:

Test whether the beforeload event is fired for various kinds of redirects.

* http/tests/security/beforeload-iframe-client-redirect-expected.txt: Added.
* http/tests/security/beforeload-iframe-client-redirect.html: Added.
* http/tests/security/beforeload-iframe-server-redirect-expected.txt: Added.
* http/tests/security/beforeload-iframe-server-redirect.html: Added.
* http/tests/security/resources/post-done.html: Added.
* http/tests/security/resources/client-redir.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLLVM Compiler build fix.
mitz@apple.com [Fri, 15 Jul 2011 02:10:53 +0000 (02:10 +0000)]
LLVM Compiler build fix.

* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyComputeLength::applyValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic should have a "rebaseline" button
abarth@webkit.org [Fri, 15 Jul 2011 02:06:28 +0000 (02:06 +0000)]
garden-o-matic should have a "rebaseline" button
https://bugs.webkit.org/show_bug.cgi?id=64446

Reviewed by Ojan Vafai.

This patch adds a basic Rebaseline button that copies the baselines
displayed in the results pane into the appropriate directory in your
working copy.

There are two main limitations:

1) There is no UI for actually committing the baselines.

2) The baselines are not optimized for redundancy (meaning you can have
   identical baselines in both chromium-mac and chromium-win).

* Scripts/webkitpy/tool/commands/rebaseline.py:
    - Turns out we need to create the directory for the baseline if it doesn't exist yet.
* Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js:
    - Add an programatic API to call the server.
* Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
    - Add the rebaseline button itself.
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
    - Change the CSS so that the Rebaseline and Close buttons can
      appear in the normal order in the DOM.
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
    - Bind the event and translate the parameters.
    - Hide/show the rebaseline button, as appropriate.
* Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
    - Add some helpful utility functions for manipulating failure types.
* Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG JIT does not optimize Branch as well as it could.
commit-queue@webkit.org [Fri, 15 Jul 2011 02:06:10 +0000 (02:06 +0000)]
DFG JIT does not optimize Branch as well as it could.
https://bugs.webkit.org/show_bug.cgi?id=64574

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-14
Reviewed by Gavin Barraclough.

This creates a common code path for emitting unfused branches, which does
no speculation, and only performs a slow call if absolutely necessary.

* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::emitBranch):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Mac] Use [NSCursor operationNotAllowedCursor] for CSS no-drop as well as CSS not...
darin@apple.com [Fri, 15 Jul 2011 01:51:45 +0000 (01:51 +0000)]
[Mac] Use [NSCursor operationNotAllowedCursor] for CSS no-drop as well as CSS not-allowed
https://bugs.webkit.org/show_bug.cgi?id=64570

Reviewed by Alexey Proskuryakov.

Mac OS X documentation and usage makes it clear that this cursor is usually used for no-drop,
and that it's also reasonable to use it for not-allowed.

* platform/mac/CursorMac.mm:
(WebCore::Cursor::ensurePlatformCursor): Use [NSCursor operationNotAllowedCursor] for
Cursor::NoDrop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGC allocation fast path has too many operations.
commit-queue@webkit.org [Fri, 15 Jul 2011 01:40:25 +0000 (01:40 +0000)]
GC allocation fast path has too many operations.
https://bugs.webkit.org/show_bug.cgi?id=64493

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-14
Reviewed by Darin Adler.

Changed the timing of the lazy sweep so that it occurs when we land on
a previously-unsweeped block, rather than whenever we land on an unsweeped
cell.  After the per-block lazy sweep occurs, the block is turned into a
singly linked list of free cells.  The allocation fast path is now just a
load-branch-store to remove a cell from the head of the list.

Additionally, this changes the way new blocks are allocated.  Previously,
they would be populated with dummy cells.  With this patch, they are
turned into a free list, which means that there will never be destructor
calls for allocations in fresh blocks.

These changes result in a 1.9% speed-up on V8, and a 0.6% speed-up on
SunSpider.  There are no observed statistically significant slow-downs
on any individual benchmark.

* JavaScriptCore.exp:
* heap/Heap.cpp:
(JSC::Heap::allocateSlowCase):
(JSC::Heap::collect):
(JSC::Heap::canonicalizeBlocks):
(JSC::Heap::resetAllocator):
* heap/Heap.h:
(JSC::Heap::forEachProtectedCell):
(JSC::Heap::forEachCell):
(JSC::Heap::forEachBlock):
(JSC::Heap::allocate):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::lazySweep):
(JSC::MarkedBlock::blessNewBlockForFastPath):
(JSC::MarkedBlock::blessNewBlockForSlowPath):
(JSC::MarkedBlock::canonicalizeBlock):
* heap/MarkedBlock.h:
* heap/NewSpace.cpp:
(JSC::NewSpace::addBlock):
(JSC::NewSpace::canonicalizeBlocks):
* heap/NewSpace.h:
(JSC::NewSpace::allocate):
(JSC::NewSpace::SizeClass::SizeClass):
(JSC::NewSpace::SizeClass::canonicalizeBlock):
* heap/OldSpace.cpp:
(JSC::OldSpace::addBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed by Dimitri Glazkov.
macpherson@chromium.org [Fri, 15 Jul 2011 01:28:54 +0000 (01:28 +0000)]
Reviewed by Dimitri Glazkov.

Introduce templated compute length class in CSSStyleApplyProperty, and use to handle several CSS properties.
https://bugs.webkit.org/show_bug.cgi?id=62957

No new tests / refactoring only.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLength):
Add computeLength function that returns unsigned short.
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyComputeLength::ApplyPropertyComputeLength):
Added class to handle computeLength based properties.
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
Initialize ApplyPropertyComputeLength for appropriate properties.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::useSVGZoomRules):
Make this a public member function instead of a private static function.
(WebCore::CSSStyleSelector::applyProperty):
Removed code now implemented in CSSStyleApplyProperty.
(WebCore::CSSStyleSelector::setFontSize):
Use new useSVGZoomRules function.
* css/CSSStyleSelector.h:
Add interface for useSVGZoomRules.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] updated test expectations.
scheib@chromium.org [Thu, 14 Jul 2011 23:48:51 +0000 (23:48 +0000)]
[chromium] updated test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] updated test expectations.
scheib@chromium.org [Thu, 14 Jul 2011 23:40:02 +0000 (23:40 +0000)]
[chromium] updated test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG JIT crashes on host constructor calls in debug mode.
scheib@chromium.org [Thu, 14 Jul 2011 23:38:15 +0000 (23:38 +0000)]
DFG JIT crashes on host constructor calls in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=64562

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-14
Reviewed by Gavin Barraclough.

This bug snuck past our tests, so this patchs adds a test to cover this
case.

* fast/js/array-constructor-host-call-expected.txt: Added.
* fast/js/array-constructor-host-call.html: Added.
* fast/js/script-tests/array-constructor-host-call.js: Added.
(constructArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/JavaScriptCore: DFG JIT crashes on host constructor calls in debug mode.
commit-queue@webkit.org [Thu, 14 Jul 2011 23:26:45 +0000 (23:26 +0000)]
Source/JavaScriptCore: DFG JIT crashes on host constructor calls in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=64562

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-14
Reviewed by Gavin Barraclough.

Fixed the relevant ASSERT.

* dfg/DFGOperations.cpp:

LayoutTests: DFG JIT crashes on host constructor calls in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=64562

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-14
Reviewed by Gavin Barraclough.

This bug snuck past our tests, so this patchs adds a test to cover this
case.

* fast/js/array-constructor-host-call-expected.txt: Added.
* fast/js/array-constructor-host-call.html: Added.
* fast/js/script-tests/array-constructor-host-call.js: Added.
(constructArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION: webkit-patch roll-chromium-deps is broken
rniwa@webkit.org [Thu, 14 Jul 2011 23:23:09 +0000 (23:23 +0000)]
REGRESSION: webkit-patch roll-chromium-deps is broken
https://bugs.webkit.org/show_bug.cgi?id=64568

Reviewed by Dirk Pranke

Use _filesystem.join.

* Scripts/webkitpy/common/checkout/checkout.py:
* Scripts/webkitpy/common/checkout/checkout_unittests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] updated test expectations.
scheib@chromium.org [Thu, 14 Jul 2011 23:22:21 +0000 (23:22 +0000)]
[chromium] updated test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRolled Chromium revision to 92606.
rniwa@webkit.org [Thu, 14 Jul 2011 23:00:07 +0000 (23:00 +0000)]
Rolled Chromium revision to 92606.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdding myself to the reviewers list; No review needed.
noam.rosenthal@nokia.com [Thu, 14 Jul 2011 21:52:15 +0000 (21:52 +0000)]
Adding myself to the reviewers list; No review needed.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't use Element.prototype.classList in TestFailures
aroben@apple.com [Thu, 14 Jul 2011 21:49:53 +0000 (21:49 +0000)]
Don't use Element.prototype.classList in TestFailures

Safari 5 doesn't support it.

Fixes <http://webkit.org/b/64550> Can't expand flaky tests on TestFailures page in Safari 5

Reviewed by Daniel Bates.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
(Element.prototype.hasStyleClass):
(Element.prototype.addStyleClass):
(Element.prototype.removeStyleClass):
(Element.prototype.toggleStyleClass):
Added these helper functions which simulate classList functionality.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js:
Added. Tests for the above.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._domForPossiblyFlakyTests): Changed to use
toggleStyleClass/hasStyleClass instead of classList.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
Added Utilities_unittests.js, and reordered the tested files to be in
roughly dependency order (i.e., the lowest-level files are imported
and tested first).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNRWT doesn't store the svn revision in full_results.json on chromium-win
commit-queue@webkit.org [Thu, 14 Jul 2011 21:21:24 +0000 (21:21 +0000)]
NRWT doesn't store the svn revision in full_results.json on chromium-win
https://bugs.webkit.org/show_bug.cgi?id=64492

Unreviewed.  Just fixing my test-webkitpy regression.

Fix the unit tests.  Unfortunately scm does not use a filesystem
object so we can't control the result of detect_scm_system.
When detect_scm_system would fail, we would log, which would
cause all passing_run integration tests to fail.

* Scripts/webkitpy/common/checkout/scm/scm.py:
* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION: Should not dispatch didFirstVisuallyNonEmptyLayout for the initial empty...
antti@apple.com [Thu, 14 Jul 2011 21:16:36 +0000 (21:16 +0000)]
REGRESSION: Should not dispatch didFirstVisuallyNonEmptyLayout for the initial empty document
https://bugs.webkit.org/show_bug.cgi?id=64557

Reviewed by Kenneth Rohde Christiansen.

Avoid sending didFirstVisuallyNonEmptyLayout for the initial empty document of the frame. The
clients may not expect it and it doesn't make much sense in any case.

* page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] updated test expectations.
scheib@chromium.org [Thu, 14 Jul 2011 20:49:17 +0000 (20:49 +0000)]
[chromium] updated test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCharacter reference parser for new XML parser
jpfau@apple.com [Thu, 14 Jul 2011 20:08:08 +0000 (20:08 +0000)]
Character reference parser for new XML parser
https://bugs.webkit.org/show_bug.cgi?id=64398

Reviewed by Adam Barth.

Refactored out the HTML entity parser and added a common template for parsing character references.

* WebCore.xcodeproj/project.pbxproj:
* html/parser/HTMLEntityParser.cpp:
(WebCore::consumeHTMLEntity):
* xml/parser/CharacterReferenceParserInlineMethods.h: Copied from Source/WebCore/html/parser/HTMLEntityParser.cpp.
(WebCore::isHexDigit):
(WebCore::unconsumeCharacters):
(WebCore::consumeCharacterReference):
* xml/parser/XMLCharacterReferenceParser.cpp: Added.
(WebCore::consumeXMLCharacterReference):
* xml/parser/XMLCharacterReferenceParser.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed by Pavel Feldman.
loislo@chromium.org [Thu, 14 Jul 2011 19:51:40 +0000 (19:51 +0000)]
Reviewed by Pavel Feldman.

Web Inspector: panel switching is too slow.
https://bugs.webkit.org/show_bug.cgi?id=60959

* inspector/front-end/inspector.css:
(.panel):
(.panel.visible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNRWT doesn't store the svn revision in full_results.json on chromium-win
commit-queue@webkit.org [Thu, 14 Jul 2011 19:32:00 +0000 (19:32 +0000)]
NRWT doesn't store the svn revision in full_results.json on chromium-win
https://bugs.webkit.org/show_bug.cgi?id=64492

Reviewed by Ojan Vafai.

This should fix the bug.  Unfortunately this code is currently
impossible to test since it's impossible to mock detect_scm_system at the
moment.  I started re-writing scm.detection.py to be mockable, but decided that
was best left for another day.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/port/base.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG speculative JIT contains a FIXME for rewinding speculative code generation that
commit-queue@webkit.org [Thu, 14 Jul 2011 19:31:23 +0000 (19:31 +0000)]
DFG speculative JIT contains a FIXME for rewinding speculative code generation that
has already been fixed.
https://bugs.webkit.org/show_bug.cgi?id=64022

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-14
Reviewed by Gavin Barraclough.

* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofix coding style of dashboard_base.js
ojan@chromium.org [Thu, 14 Jul 2011 19:24:24 +0000 (19:24 +0000)]
fix coding style of dashboard_base.js
https://bugs.webkit.org/show_bug.cgi?id=64545

Reviewed by Adam Roben.

The code changes to the files other than dashboard_base.js
are just fallout from renaming globals in dashboard_base.js.

* TestResultServer/static-dashboards/aggregate_results.html:
* TestResultServer/static-dashboards/builders.js:
* TestResultServer/static-dashboards/dashboard_base.js:
* TestResultServer/static-dashboards/flakiness_dashboard.html:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
* TestResultServer/static-dashboards/timeline_explorer.html:
* TestResultServer/static-dashboards/treemap.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] updated test expectations.
scheib@chromium.org [Thu, 14 Jul 2011 18:28:52 +0000 (18:28 +0000)]
[chromium] updated test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] updated test expectations.
scheib@chromium.org [Thu, 14 Jul 2011 18:23:59 +0000 (18:23 +0000)]
[chromium] updated test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Add OwnPtr specialization for Ecore_Pipe.
ryuan.choi@samsung.com [Thu, 14 Jul 2011 18:02:45 +0000 (18:02 +0000)]
[EFL] Add OwnPtr specialization for Ecore_Pipe.
https://bugs.webkit.org/show_bug.cgi?id=64515

Add an overload for deleteOwnedPtr(Ecore_Pipe*) on EFL port.

Reviewed by Xan Lopez.

* wtf/OwnPtrCommon.h:
* wtf/efl/OwnPtrEfl.cpp:
(WTF::deleteOwnedPtr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: remove more unused CSS from inspector.css
caseq@chromium.org [Thu, 14 Jul 2011 17:57:49 +0000 (17:57 +0000)]
Web Inspector: remove more unused CSS from inspector.css
https://bugs.webkit.org/show_bug.cgi?id=64529

Reviewed by Pavel Feldman.

* inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed by Anders Carlsson.
carlosgc@webkit.org [Thu, 14 Jul 2011 17:52:53 +0000 (17:52 +0000)]
Reviewed by Anders Carlsson.

[UNIX] Allow sending null handles in messages
https://bugs.webkit.org/show_bug.cgi?id=60621

Only valid file descriptors are now sent using sendmsg() control
messages, and instead of sending a list of attachment sizes we now
send a list of AttachmentInfo structs. AttachmentInfo contains
information about the attachments including the size for
MappedMemory attachmens and whether the attachment is null or not.

* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::AttachmentInfo::AttachmentInfo): New class containing
information about the attachments sent.
(CoreIPC::AttachmentInfo::setType): Set the attachment type.
(CoreIPC::AttachmentInfo::getType): Return the attachment type.
(CoreIPC::AttachmentInfo::setSize): Set the size for MappedMemory attachments.
(CoreIPC::AttachmentInfo::getSize): Get the size for MappedMemory attachments.
(CoreIPC::AttachmentInfo::setNull): Set attachment as null, it
contains an invalid file descriptor, so the receiver shouldn't
expect a file desriptor for this attachment.
(CoreIPC::AttachmentInfo::isNull): Return whether attachment is
null, it contains an invalid file descriptor.
(CoreIPC::Connection::processMessage):
(CoreIPC::Connection::sendOutgoingMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed by Martin Robinson.
carlosgc@webkit.org [Thu, 14 Jul 2011 17:49:47 +0000 (17:49 +0000)]
Reviewed by Martin Robinson.

[GTK] Implement Plugin Process
https://bugs.webkit.org/show_bug.cgi?id=60546

.:

* configure.ac: Always check for gtk2 when building the plugin
process.

Source/WebKit2:

* GNUmakefile.am: Add new files to compilation.
* PluginProcess/gtk/PluginProcessMainGtk.cpp: Added.
(WebKit::PluginProcessMainGtk):
* PluginProcess/gtk/PluginProcessMainGtk.h: Added.
* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess):
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::moduleMixesGtkSymbols):
* gtk/PluginMainGtk.cpp: Added.
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove subtreeHasChanged from RenderTextControl to HTMLTextFormControlElement
rniwa@webkit.org [Thu, 14 Jul 2011 17:45:04 +0000 (17:45 +0000)]
Move subtreeHasChanged from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=64476

Reviewed by Kent Tamura.

Moved subtreeHasChanged from RenderTextControl, RenderTextControlSingleLine, and
RenderTextControlMultiLine to HTMLTextFormControlElement, HTMLInputElement, and
HTMLTextAreaElement. Also moved m_searchEventTimer and related functions from
RenderTextSingleLine to SearchInputType.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::subtreeHasChanged): Moved from RenderTextControlSingleLine.
(WebCore::HTMLInputElement::onSearch): Calls stopSearchEventTimer.
* html/HTMLInputElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::subtreeHasChanged): Moved from RenderTextMultiLine.
* html/HTMLTextAreaElement.h:
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::defaultEventHandler): Calls subtreeHasChanged.
(WebCore::HTMLTextFormControlElement::subtreeHasChanged): Added; calls respondToChangeByUser.
* html/HTMLTextFormControlElement.h:
* html/SearchInputType.cpp:
(WebCore::SearchInputType::SearchInputType): Initializes m_searchEventTimer.
(WebCore::SearchInputType::startSearchEventTimer): Moved from RenderTextControlSingleLine.
(WebCore::SearchInputType::stopSearchEventTimer): Ditto.
(WebCore::SearchInputType::searchEventTimerFired): Ditto.
* html/SearchInputType.h:
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleBeforeTextInsertedEvent): Updated comment.
* rendering/RenderTextControl.cpp:
* rendering/RenderTextControl.h:
(WebCore::RenderTextControl::respondToChangeByUser): Renamed from subtreeHasChanged.
* rendering/RenderTextControlMultiLine.cpp:
* rendering/RenderTextControlMultiLine.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): No longer initializes
m_searchEventTimer.
* rendering/RenderTextControlSingleLine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed by Anders Carlsson.
carlosgc@webkit.org [Thu, 14 Jul 2011 17:44:29 +0000 (17:44 +0000)]
Reviewed by Anders Carlsson.

Implement plugin process for UNIX platform
https://bugs.webkit.org/show_bug.cgi?id=60629

* Platform/CoreIPC/Attachment.h:
* Platform/CoreIPC/unix/AttachmentUnix.cpp:
(CoreIPC::Attachment::Attachment): Add the ability to pass a
socket via Attachment.
* Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::Handle::encode): Remove assertions that
check that the Handle is not null. In
PluginProxy::geometryDidChange we pass a null Handle if we do not
need to allocate a new backing store.
(WebKit::SharedMemory::Handle::releaseToAttachment): Ditto.
* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::createWebProcessConnection): Use
Attachment. Set up the connection with socketpair.
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
(WebKit::PluginProcessProxy::didCreateWebProcessConnection):
* UIProcess/Plugins/PluginProcessProxy.h:
* UIProcess/Plugins/PluginProcessProxy.messages.in:
* UIProcess/WebProcessProxy.messages.in:
* WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
Use Attachment to pass the connection.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Implement support to center selection on a page for WebKit2.
adachan@apple.com [Thu, 14 Jul 2011 17:42:12 +0000 (17:42 +0000)]
    Implement support to center selection on a page for WebKit2.
        https://bugs.webkit.org/show_bug.cgi?id=64481

        Reviewed by Anders Carlsson.

        * UIProcess/API/C/WKPage.cpp:
        (WKPageCenterSelectionInVisibleArea): Added.  Call WebPageProxy::centerSelectionInVisibleArea().
        * UIProcess/API/C/WKPage.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::centerSelectionInVisibleArea): Send message to the WebProcess to center selection.
        * UIProcess/WebPageProxy.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::centerSelectionInVisibleArea): Get the FrameSelection from the main frame and call
        revealSelection() to center it.
        * WebProcess/WebPage/WebPage.h:
        * WebProcess/WebPage/WebPage.messages.in: Add the CenterSelectionInVisibleArea message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-14 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 14 Jul 2011 17:40:21 +0000 (17:40 +0000)]
2011-07-14  Carlos Garcia Campos  <cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build after r90953.

        * WebKitTestRunner/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG JIT unnecessarily boxes and unboxes values during silent spilling.
commit-queue@webkit.org [Thu, 14 Jul 2011 17:32:13 +0000 (17:32 +0000)]
DFG JIT unnecessarily boxes and unboxes values during silent spilling.
https://bugs.webkit.org/show_bug.cgi?id=64068

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-14
Reviewed by Gavin Barraclough.

Silent spilling and filling of registers is done during slow-path C
function calls.  The silent spill/fill logic does not affect register
allocation on paths that don't involve the C function call.

This changes the silent spilling code to spill in unboxed form.  The
silent fill will refill in whatever form the register was spilled in.
For example, the silent spill code may choose not to spill the register
because it was already spilled previously, which would imply that it
was spilled in boxed form.  The filling code detects this and either
unboxes, or not, depending on what is appropriate.

This change also results in a simplification of the silent spill/fill
API: silent spilling no longer needs to know about the set of registers
that cannot be trampled, since it never does boxing and hence does not
need a temporary register.

* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentSpillFPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::valueToNumber):
(JSC::DFG::NonSpeculativeJIT::valueToInt32):
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
(JSC::DFG::NonSpeculativeJIT::compare):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic results pane should be more discoverable
abarth@webkit.org [Thu, 14 Jul 2011 17:24:13 +0000 (17:24 +0000)]
garden-o-matic results pane should be more discoverable
https://bugs.webkit.org/show_bug.cgi?id=64513

Reviewed by Eric Seidel.

This patch causes us to trigger the results pane on mouse clicks
instead of mousein.  Also, handle the case of no results details more
elegantly.

* Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
    - Change the binding to "click".
* Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
    - Handle the "no results URLs" case explicitly instead of never
      calling the callback.
* Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
    - Show a message when there are no result details to show.
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove XML errors handling out from XMLDocumentParser (refactoring).
vsevik@chromium.org [Thu, 14 Jul 2011 17:15:04 +0000 (17:15 +0000)]
Move XML errors handling out from XMLDocumentParser (refactoring).
https://bugs.webkit.org/show_bug.cgi?id=64305

XML errors handling logic is moved out from XMLDocumentParser to allow using it for XSLT error handling as well.

Reviewed by Adam Barth.

No tests needed as there is no new functionality added.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* xml/XMLErrors.cpp: Added.
(WebCore::XMLErrors::XMLErrors):
(WebCore::XMLErrors::handleError):
(WebCore::XMLErrors::appendErrorMessage):
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):
* xml/XMLErrors.h: Added.
* xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::pushCurrentNode):
(WebCore::XMLDocumentParser::handleError):
(WebCore::XMLDocumentParser::insertErrorMessageBlock):
* xml/parser/XMLDocumentParser.h:
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::PendingCallbacks::appendErrorCallback):
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::error):
(WebCore::warningHandler):
(WebCore::fatalErrorHandler):
(WebCore::normalErrorHandler):
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::doWrite):
(WebCore::XMLDocumentParser::doEnd):
(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::parseStartElement):
(WebCore::XMLDocumentParser::parseDtd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic should badge TIMEOUT failures
abarth@webkit.org [Thu, 14 Jul 2011 17:09:53 +0000 (17:09 +0000)]
garden-o-matic should badge TIMEOUT failures
https://bugs.webkit.org/show_bug.cgi?id=64435

Reviewed by Eric Seidel.

* Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
(.regression .what a[draggable].TIMEOUT::before):
    - Add TIMEOUT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: InspectorResourceAgent should generate unique identifier and save...
vsevik@chromium.org [Thu, 14 Jul 2011 16:59:11 +0000 (16:59 +0000)]
Web Inspector: InspectorResourceAgent should generate unique identifier and save cachedResource for resources from memory cache.
https://bugs.webkit.org/show_bug.cgi?id=64356

Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
* inspector/InspectorResourceAgent.h:
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkDispatcher):
(WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._frameNavigated):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadedResourceFromMemoryCache):
* loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClear SVGElementInstance's children immediately upon detachment
commit-queue@webkit.org [Thu, 14 Jul 2011 16:57:44 +0000 (16:57 +0000)]
Clear SVGElementInstance's children immediately upon detachment
https://bugs.webkit.org/show_bug.cgi?id=63739
<rdar://problem/9705708>

Patch by Tim Horton <timothy_horton@apple.com> on 2011-07-14
Reviewed by Nikolas Zimmermann.

In addition to clearing the instance's children in the destructor,
clear them when the instance is detached from its <use>. This way,
we won't attempt to use them after we're detached but before the
destructor has been called.

Source/WebCore:

Test: svg/custom/use-crash-using-children-before-destroy.svg

* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::~SVGElementInstance):
(WebCore::SVGElementInstance::clearChildren):
* svg/SVGElementInstance.h:
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::detachInstance):

LayoutTests:

* svg/custom/use-crash-using-children-before-destroy-expected.txt: Added.
* svg/custom/use-crash-using-children-before-destroy.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename AutoFill -> Autofill and autoFill -> autofill
isherman@chromium.org [Thu, 14 Jul 2011 16:42:50 +0000 (16:42 +0000)]
Rename AutoFill -> Autofill and autoFill -> autofill
https://bugs.webkit.org/show_bug.cgi?id=64333
http://code.google.com/p/chromium/issues/detail?id=72758

Reviewed by Darin Fisher.

* WebKit.gyp:
* public/WebAutofillClient.h:
(WebKit::WebAutofillClient::didAcceptAutofillSuggestion):
(WebKit::WebAutofillClient::didSelectAutofillSuggestion):
(WebKit::WebAutofillClient::didClearAutofillSelection):
(WebKit::WebAutofillClient::removeAutocompleteSuggestion):
(WebKit::WebAutofillClient::textFieldDidBeginEditing):
(WebKit::WebAutofillClient::textFieldDidEndEditing):
(WebKit::WebAutofillClient::textFieldDidChange):
(WebKit::WebAutofillClient::textFieldDidReceiveKeyDown):
(WebKit::WebAutofillClient::~WebAutofillClient):
* public/WebNode.h:
* public/WebView.h:
* src/AutofillPopupMenuClient.cpp:
(WebKit::AutofillPopupMenuClient::AutofillPopupMenuClient):
(WebKit::AutofillPopupMenuClient::~AutofillPopupMenuClient):
(WebKit::AutofillPopupMenuClient::getSuggestionsCount):
(WebKit::AutofillPopupMenuClient::getSuggestion):
(WebKit::AutofillPopupMenuClient::getLabel):
(WebKit::AutofillPopupMenuClient::getIcon):
(WebKit::AutofillPopupMenuClient::removeSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::canRemoveSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::valueChanged):
(WebKit::AutofillPopupMenuClient::selectionChanged):
(WebKit::AutofillPopupMenuClient::selectionCleared):
(WebKit::AutofillPopupMenuClient::itemText):
(WebKit::AutofillPopupMenuClient::itemLabel):
(WebKit::AutofillPopupMenuClient::itemIcon):
(WebKit::AutofillPopupMenuClient::itemIsEnabled):
(WebKit::AutofillPopupMenuClient::itemStyle):
(WebKit::AutofillPopupMenuClient::menuStyle):
(WebKit::AutofillPopupMenuClient::clientPaddingLeft):
(WebKit::AutofillPopupMenuClient::clientPaddingRight):
(WebKit::AutofillPopupMenuClient::popupDidHide):
(WebKit::AutofillPopupMenuClient::itemIsSeparator):
(WebKit::AutofillPopupMenuClient::itemIsWarning):
(WebKit::AutofillPopupMenuClient::setTextFromItem):
(WebKit::AutofillPopupMenuClient::fontSelector):
(WebKit::AutofillPopupMenuClient::hostWindow):
(WebKit::AutofillPopupMenuClient::createScrollbar):
(WebKit::AutofillPopupMenuClient::initialize):
(WebKit::AutofillPopupMenuClient::setSuggestions):
(WebKit::AutofillPopupMenuClient::convertListIndexToInternalIndex):
(WebKit::AutofillPopupMenuClient::getWebView):
(WebKit::AutofillPopupMenuClient::textFieldStyle):
* src/AutofillPopupMenuClient.h:
(WebKit::AutofillPopupMenuClient::itemToolTip):
(WebKit::AutofillPopupMenuClient::itemAccessibilityText):
(WebKit::AutofillPopupMenuClient::clientInsetLeft):
(WebKit::AutofillPopupMenuClient::clientInsetRight):
(WebKit::AutofillPopupMenuClient::listSize):
(WebKit::AutofillPopupMenuClient::selectedIndex):
(WebKit::AutofillPopupMenuClient::itemIsLabel):
(WebKit::AutofillPopupMenuClient::itemIsSelected):
(WebKit::AutofillPopupMenuClient::shouldPopOver):
(WebKit::AutofillPopupMenuClient::valueShouldChangeOnHotTrack):
(WebKit::AutofillPopupMenuClient::getTextField):
(WebKit::AutofillPopupMenuClient::getSelectedIndex):
(WebKit::AutofillPopupMenuClient::setSelectedIndex):
* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::textFieldDidBeginEditing):
(WebKit::EditorClientImpl::textFieldDidEndEditing):
(WebKit::EditorClientImpl::textDidChangeInTextField):
(WebKit::EditorClientImpl::doAutofill):
(WebKit::EditorClientImpl::doTextFieldCommandFromEvent):
* src/WebInputElement.cpp:
(WebKit::WebInputElement::setAutofilled):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setAutofillClient):
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::mouseDown):
(WebKit::WebViewImpl::autocompleteHandleKeyEvent):
(WebKit::WebViewImpl::hideAutofillPopup):
(WebKit::WebViewImpl::setFocus):
(WebKit::WebViewImpl::applyAutofillSuggestions):
(WebKit::WebViewImpl::hidePopups):
(WebKit::WebViewImpl::refreshAutofillPopup):
* src/WebViewImpl.h:
(WebKit::WebViewImpl::autofillClient):
(WebKit::WebViewImpl::autofillPopupDidHide):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't skip custom cursors if an Image* is null,
japhet@chromium.org [Thu, 14 Jul 2011 16:29:55 +0000 (16:29 +0000)]
Don't skip custom cursors if an Image* is null,
since this can lead to a non-custom Cursor flickering
back in when the custom cursor hasn't finished loading yet.
https://bugs.webkit.org/show_bug.cgi?id=64321

Reviewed by Darin Fisher.

Manual test, since we're testing visual flickering.

* manual-tests/canvas-cursor.html: Added.
* page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor):
* platform/Cursor.cpp:
(WebCore::determineHotSpot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPatch by Young Han Lee <joybro@company100.net> on 2011-07-14
commit-queue@webkit.org [Thu, 14 Jul 2011 16:20:01 +0000 (16:20 +0000)]
Patch by Young Han Lee <joybro@company100.net> on 2011-07-14
Reviewed by Dirk Schulze.

REGRESSION (r89774): svg/W3C-SVG-1.1/animate-elem-82-t.svg hits assertion failure.
https://bugs.webkit.org/show_bug.cgi?id=63911

Some functions assumed calculateKeyTimesIndex() does not return the last index of
the keyTimes, but it would be right behavior for calculateKeyTimesIndex() when it
accepts 1 as the percent argument.

To avoid the assumption, and for more efficiency, this patch allows the functions
using calculateKeyTimesIndex() to return early when it accepts 1 as the percent argument.
These functions have always returned the last element of the corresponding vector
in that situation.

* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::calculatePercentFromKeyPoints):
(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Python exception blocking the commit-queue.
abarth@webkit.org [Thu, 14 Jul 2011 16:00:43 +0000 (16:00 +0000)]
Fix Python exception blocking the commit-queue.

* Scripts/webkitpy/common/checkout/scm/git.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt]Update layout test results for newer Qt 4.8.x
ossy@webkit.org [Thu, 14 Jul 2011 14:47:43 +0000 (14:47 +0000)]
[Qt]Update layout test results for newer Qt 4.8.x
https://bugs.webkit.org/show_bug.cgi?id=64527

[Qt]http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html fails with Qt 4.8
https://bugs.webkit.org/show_bug.cgi?id=60176

* platform/qt-4.8/[...]: Added.
* platform/qt-4.8/Skipped: Unskip http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Web Inspector: URL parameters should consistently use camel case names
yurys@chromium.org [Thu, 14 Jul 2011 14:39:56 +0000 (14:39 +0000)]
[Chromium] Web Inspector: URL parameters should consistently use camel case names
https://bugs.webkit.org/show_bug.cgi?id=64520

Reviewed by Pavel Feldman.

* src/js/DevTools.js:
(devtools.domContentLoaded): Now that Chromium side is updated we can remove the old parameter
handling code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-14 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 14 Jul 2011 14:04:34 +0000 (14:04 +0000)]
2011-07-14  Xan Lopez  <xlopez@igalia.com>

        [GTK] Skip one crashing test in GTK+/debug bots.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-14 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 14 Jul 2011 13:56:32 +0000 (13:56 +0000)]
2011-07-14  Xan Lopez  <xlopez@igalia.com>

        [GTK] Skip one crashing test in GTK+/debug bots.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-07-14 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Thu, 14 Jul 2011 13:36:29 +0000 (13:36 +0000)]
2011-07-14  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: remove more dead code
        https://bugs.webkit.org/show_bug.cgi?id=64524

        Reviewed by Yury Semikhatsky.

        * WebCore.gypi:
        * inspector/front-end/SummaryBar.js: Removed.
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt]svg/animations/svgtransform-animation-1.html asserts intermittently
ossy@webkit.org [Thu, 14 Jul 2011 13:36:12 +0000 (13:36 +0000)]
[Qt]svg/animations/svgtransform-animation-1.html asserts intermittently
https://bugs.webkit.org/show_bug.cgi?id=64526

* platform/qt/test_expectations.txt: Mark the test as flakey crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90995 268f45cc-cd09-0410-ab3c-d52691b4dbfc