WebKit-https.git
10 years ago2011-08-23 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 23 Aug 2011 09:32:42 +0000 (09:32 +0000)]
2011-08-23  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed build fix for compile error on Windows for r93560.

        * runtime/SamplingCounter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Prepare utilities.js for compilation.
pfeldman@chromium.org [Tue, 23 Aug 2011 09:23:31 +0000 (09:23 +0000)]
Web Inspector: Prepare utilities.js for compilation.
https://bugs.webkit.org/show_bug.cgi?id=66656

Removes "this" usage in functions, does not define getters for offsets.

Reviewed by Tony Gentilcore.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleMessage.prototype._format):
(WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.valueFormatter):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.appropriateSelectorFor):
(WebInspector.DOMNode.prototype.isAncestor):
(WebInspector.DOMNode.prototype.isDescendant):
(WebInspector.DOMNode.prototype.isWhitespace):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype._resizerDragging):
(WebInspector.DataGridNode.prototype.isEventWithinDisclosureTriangle):
* inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.get savedHeight):
(WebInspector.Drawer.prototype.onResize):
(WebInspector.Drawer.prototype._startStatusBarDragging):
(WebInspector.Drawer.prototype._statusBarDragging):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes.crumbsAreSmallerThanContainer):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.findTreeElement):
(WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
():
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject):
* inspector/front-end/ResourceTimingView.js:
(WebInspector.ResourceTimingView.createTimingTable):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.BaseStorageTreeElement.prototype.isEventWithinDisclosureTriangle):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._startSidebarResizeDrag):
* inspector/front-end/SoftContextMenu.js:
(.WebInspector.SoftContextMenu.prototype.show):
* inspector/front-end/Toolbar.js:
(WebInspector.ToolbarDropdown.prototype.show):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype._updateHoveredElement):
* inspector/front-end/inspector.js:
(Number.secondsToString):
(Number.bytesToString):
* inspector/front-end/treeoutline.js:
(TreeElement.prototype.isEventWithinDisclosureTriangle):
* inspector/front-end/utilities.js:
(setupPrototypeUtilities.Element.prototype.totalOffsetLeft):
(setupPrototypeUtilities.Element.prototype.totalOffsetTop):
(setupPrototypeUtilities.Element.prototype.offsetRelativeToWindow):
(setupPrototypeUtilities):
(setupPrototypeUtilities.):
():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening. Remove Windows style new lines from the test introduced in...
ossy@webkit.org [Tue, 23 Aug 2011 08:50:59 +0000 (08:50 +0000)]
Unreviewed gardening. Remove Windows style new lines from the test introduced in r93521.

* fast/loader/document-destruction-within-unload-expected.txt:
* fast/loader/document-destruction-within-unload.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WK2] Unreviewed gardening.
ossy@webkit.org [Tue, 23 Aug 2011 08:43:18 +0000 (08:43 +0000)]
[WK2] Unreviewed gardening.

* platform/wk2/Skipped: Skip fast/frames/focus-controller-crash-change-event.html, because eventSender.keyDown is unimplemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] REGRESSION after r93567.
reni@webkit.org [Tue, 23 Aug 2011 08:25:17 +0000 (08:25 +0000)]
[Qt] REGRESSION after r93567.
https://bugs.webkit.org/show_bug.cgi?id=66749

Three tests have assertion failed error in debug mode on x86-32 Linux Qt. They are skipped.
Unreviewed gardening.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplemented skia support for caching resizes of cropped images.
commit-queue@webkit.org [Tue, 23 Aug 2011 05:45:49 +0000 (05:45 +0000)]
Implemented skia support for caching resizes of cropped images.
https://bugs.webkit.org/show_bug.cgi?id=65587

Patch by John Bates <jbates@google.com> on 2011-08-22
Reviewed by Darin Fisher.

Previously, resizes of cropped images would not be cached. This causes various websites to have janky CSS animations in software compositing mode.

* platform/graphics/skia/ImageSkia.cpp:
(WebCore::drawResampledBitmap): Changed to use new APIs for subset caching.
(WebCore::Image::drawPattern): Added allowCaching parameter.
* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::NativeImageSkia):
(WebCore::NativeImageSkia::CachedImageInfo::CachedImageInfo):
(WebCore::NativeImageSkia::CachedImageInfo::isEqual):
(WebCore::NativeImageSkia::CachedImageInfo::set):
(WebCore::NativeImageSkia::hasResizedBitmap): Changed this method so that it does not modify caching data. Added a second version used for cropped image resizes.
(WebCore::NativeImageSkia::resizedBitmap): Added parameter to let caller specify whether caching is allowed.
(WebCore::NativeImageSkia::shouldCacheResampling): Added a second version used for cropped image resizes.
(WebCore::NativeImageSkia::shouldCacheResamplingInternal): Both shouldCacheResampling methods call down to this for the shared logic.
* platform/graphics/skia/NativeImageSkia.h: Added CachedImageInfo to uniquely identify the cached or requested image resize operation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released
tonyg@chromium.org [Tue, 23 Aug 2011 04:09:07 +0000 (04:09 +0000)]
[chromium] Fonts returned by FontCache::getFontDataForCharacters() are never released
https://bugs.webkit.org/show_bug.cgi?id=66673

Reviewed by James Robinson.

This was fixed for other ports in http://trac.webkit.org/changeset/88260.
However, it was missed in FontCacheLinux likely due to similar param in the nested call to getCachedFontPlatformData().

No new tests because no directly observable change in behavior.

* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getFontDataForCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r93565.
commit-queue@webkit.org [Tue, 23 Aug 2011 03:55:42 +0000 (03:55 +0000)]
Unreviewed, rolling out r93565.
http://trac.webkit.org/changeset/93565
https://bugs.webkit.org/show_bug.cgi?id=66745

Breaks layout tests (Requested by koz2 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-22

Source/WebCore:

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaLabeledByElements):
(WebCore::AccessibilityRenderObject::ariaLabeledByAttribute):
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::hasTextAlternative):
* accessibility/AccessibilityRenderObject.h:

LayoutTests:

* accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Removed.
* accessibility/aria-labelledby-overrides-aria-labeledby.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r93575.
commit-queue@webkit.org [Tue, 23 Aug 2011 02:53:26 +0000 (02:53 +0000)]
Unreviewed, rolling out r93575.
http://trac.webkit.org/changeset/93575
https://bugs.webkit.org/show_bug.cgi?id=66744

Does not compile on chromium canaries (Requested by jamesr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-22

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setStandardFontFamily):
(WebKit::WebSettingsImpl::setFixedFontFamily):
(WebKit::WebSettingsImpl::setSerifFontFamily):
(WebKit::WebSettingsImpl::setSansSerifFontFamily):
(WebKit::WebSettingsImpl::setCursiveFontFamily):
(WebKit::WebSettingsImpl::setFantasyFontFamily):
* src/WebSettingsImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Update WebSettings to support per-script font settings
commit-queue@webkit.org [Tue, 23 Aug 2011 02:15:22 +0000 (02:15 +0000)]
[chromium] Update WebSettings to support per-script font settings
https://bugs.webkit.org/show_bug.cgi?id=66220

Patch by Matt Falkenhagen <falken@chromium.org> on 2011-08-22
Reviewed by Tony Chang.

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setStandardFontFamily):
(WebKit::WebSettingsImpl::setFixedFontFamily):
(WebKit::WebSettingsImpl::setSerifFontFamily):
(WebKit::WebSettingsImpl::setSansSerifFontFamily):
(WebKit::WebSettingsImpl::setCursiveFontFamily):
(WebKit::WebSettingsImpl::setFantasyFontFamily):
* src/WebSettingsImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRange::setEnd(const Position&, ExceptionCode) calls setStart() instead of setEnd()
commit-queue@webkit.org [Tue, 23 Aug 2011 02:07:03 +0000 (02:07 +0000)]
Range::setEnd(const Position&, ExceptionCode) calls setStart() instead of setEnd()
https://bugs.webkit.org/show_bug.cgi?id=66638

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-22
Reviewed by Ryosuke Niwa.

Relevant layout test coming in a future patch (see https://bugs.webkit.org/show_bug.cgi?id=65900)

* dom/Range.cpp:
(WebCore::Range::setEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove PLATFORM(ANDROID)
abarth@webkit.org [Tue, 23 Aug 2011 02:05:48 +0000 (02:05 +0000)]
Remove PLATFORM(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66741

Reviewed by Darin Adler.

PLATFORM(CHROMIUM) && OS(ANDROID) is the new hotness.  These special
cases can be removed now that Android shares more code with Chromium.

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):
* bindings/v8/ScriptCachedFrameData.cpp:
* bindings/v8/ScriptCachedFrameData.h:
* bindings/v8/V8GCController.cpp:
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaInstance::invokeMethod):
* history/HistoryItem.cpp:
(WebCore::HistoryItem::~HistoryItem):
(WebCore::HistoryItem::setDocumentState):
(WebCore::HistoryItem::clearDocumentState):
(WebCore::HistoryItem::setIsTargetItem):
(WebCore::HistoryItem::addChildItem):
(WebCore::HistoryItem::setFormInfoFromRequest):
* history/HistoryItem.h:
* loader/cache/CachedFont.cpp:
* platform/DragImage.h:
* platform/PlatformTouchEvent.h:
* platform/PlatformTouchPoint.h:
(WebCore::PlatformTouchPoint::PlatformTouchPoint):
* platform/Widget.h:
* platform/network/NetworkStateNotifier.cpp:
* platform/network/NetworkStateNotifier.h:
* platform/network/NetworkingContext.h:
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleInternal.h:
* platform/network/ResourceRequestBase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Implement FrameLoaderClient::dispatchDidClearWindowObjectInWorld
commit-queue@webkit.org [Tue, 23 Aug 2011 02:02:35 +0000 (02:02 +0000)]
[EFL] Implement FrameLoaderClient::dispatchDidClearWindowObjectInWorld
https://bugs.webkit.org/show_bug.cgi?id=66685

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-08-22
Reviewed by Kent Tamura.

Implement dispatchDidClearWindowObjectInWorld, as it is needed by
DumpRenderTree to, among other things, properly install the event
sender in the window object.

This implementation works by emitting a "window,object,cleared" signal
with a private struct containing the required information (context,
window object and frame).

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
* WebCoreSupport/FrameLoaderClientEfl.h:
* ewk/ewk_private.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Remove compositing assertions about creating layers when painting
enne@google.com [Tue, 23 Aug 2011 01:35:48 +0000 (01:35 +0000)]
[chromium] Remove compositing assertions about creating layers when painting
https://bugs.webkit.org/show_bug.cgi?id=66731

Reviewed by James Robinson.

The trigger for this assertion would cause a real rendering issue, but
it is both intermittent and in the wrong place in the codebase to
catch the source of the problem.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::~LayerChromium):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
* platform/graphics/chromium/LayerRendererChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Mark some tests on Mac as flakily crashing.
pkasting@chromium.org [Tue, 23 Aug 2011 01:07:33 +0000 (01:07 +0000)]
[chromium] Mark some tests on Mac as flakily crashing.

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Mark some tests on Windows as flaky.
pkasting@chromium.org [Tue, 23 Aug 2011 00:49:58 +0000 (00:49 +0000)]
[chromium] Mark some tests on Windows as flaky.

Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago showModalDialog does not correctly return the defined returnValue in case...
ap@apple.com [Tue, 23 Aug 2011 00:43:32 +0000 (00:43 +0000)]
    showModalDialog does not correctly return the defined returnValue in case domain relaxing is used
        https://bugs.webkit.org/show_bug.cgi?id=53191
        <rdar://problem/8629478>

        Reviewed by Geoff Garen.

        Cannot test domain relaxing, we only have 127.0.0.1 and localhost.

        * bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot):
        Added a FIXME about a difference with Firefox.

        (WebCore::DialogHandler::DialogHandler):
        (WebCore::DialogHandler::dialogCreated):
        (WebCore::DialogHandler::returnValue):
        Changed to fetch returnValue from the global object that's in the frame when the dialog is
        dismissed. A dialog can navigate itself, and it also creates a new JSDOMWindow on first load
        if the origin doesn't match opener origin (which the case with domain relaxing).
        Re-added a security check for returnValue that got lost in r73829, so that we don't send the
        result across origins. This matches Firefox.

        * bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow): Added an assertion
        against a very confusing case that should no longer occur.

        * page/Frame.cpp: (WebCore::Frame::pageDestroyed): Don't clear the window shell, it doesn't
        seem necessary, but prevents DialogHandler from fetching the return value. Added a keepAlive
        call to avoid changing life support timer behavior in this patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] WebViewImpl should not reshape the 3D context
commit-queue@webkit.org [Tue, 23 Aug 2011 00:37:15 +0000 (00:37 +0000)]
[chromium] WebViewImpl should not reshape the 3D context
https://bugs.webkit.org/show_bug.cgi?id=66704

Patch by Iain Merrick <husky@google.com> on 2011-08-22
Reviewed by James Robinson.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::graphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPatch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-22
commit-queue@webkit.org [Tue, 23 Aug 2011 00:24:30 +0000 (00:24 +0000)]
Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-22
Reviewed by Chris Fleizach.

aria-labelledby should be used in preference to aria-labeledby
https://bugs.webkit.org/show_bug.cgi?id=62351

Source/WebCore:

Test: accessibility/aria-labelledby-overrides-aria-labeledby.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaLabelledByElements): Renamed from ariaLabeledByElements.
(WebCore::AccessibilityRenderObject::ariaLabelledByAttribute): Renamed from ariaLabeledByAttribute,
and re-ordered to prefer the standard spelling.
(WebCore::AccessibilityRenderObject::title):
(WebCore::AccessibilityRenderObject::hasTextAlternative):
* accessibility/AccessibilityRenderObject.h:

LayoutTests:

* accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Added.
* accessibility/aria-labelledby-overrides-aria-labeledby.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake GraphicsContext3D::isResourceSafe a function and, on Chromium, determine its...
nduca@chromium.org [Tue, 23 Aug 2011 00:14:13 +0000 (00:14 +0000)]
Make GraphicsContext3D::isResourceSafe a function and, on Chromium, determine its value lazily
https://bugs.webkit.org/show_bug.cgi?id=66708

Reviewed by Kenneth Russell.

Source/WebCore:

* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::texImage2DResourceSafe):
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/gtk/GraphicsContext3DGtk.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D):
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::isResourceSafe):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):

Source/WebKit/chromium:

* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::isResourceSafe):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::isResourceSafe):
* src/GraphicsContext3DInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoHack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
eric@webkit.org [Tue, 23 Aug 2011 00:05:10 +0000 (00:05 +0000)]
Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
I won't have ssh access to the bot again for a couple days, so
attempting to fix by changing this script.  If this doesn't
work we'll just live with the it hung for now.

Unreviewed.

* EWSTools/start-queue.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowebkit-patch rebaseline-expectations command should not rearrange the entire test_exp...
dglazkov@chromium.org [Mon, 22 Aug 2011 23:53:19 +0000 (23:53 +0000)]
webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
https://bugs.webkit.org/show_bug.cgi?id=66727

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
    in which case the serializer treats all expectations as unparsed.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoHTMLSourceTracker crashes when network packets break poorly
abarth@webkit.org [Mon, 22 Aug 2011 23:52:37 +0000 (23:52 +0000)]
HTMLSourceTracker crashes when network packets break poorly
https://bugs.webkit.org/show_bug.cgi?id=66728

Reviewed by Darin Adler.

Source/WebCore:

If there is a network packet boundary in the middle of an attribute
that begins with the letters "on", then the HTMLSourceTracker will get
confused and try to extract too many characters from future input.  If
the future input is small enough, that will walk off the end of the
input and crash.

Test: http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html

* html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::sourceForToken):

LayoutTests:

Test that we don't crash when we get a bad network packet boundary.

* http/tests/security/xssAuditor/crash-while-loading-tag-with-pause-expected.txt: Added.
* http/tests/security/xssAuditor/crash-while-loading-tag-with-pause.html: Added.
* http/tests/security/xssAuditor/resources/tag-with-pause.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSampling counter support is in the bytecode directory
fpizlo@apple.com [Mon, 22 Aug 2011 23:41:20 +0000 (23:41 +0000)]
Sampling counter support is in the bytecode directory
https://bugs.webkit.org/show_bug.cgi?id=66724

Reviewed by Darin Adler.

Moved SamplingCounter to a separate header in runtime/.

* GNUmakefile.list.am:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/SamplingTool.cpp:
* bytecode/SamplingTool.h:
* runtime/SamplingCounter.cpp: Added.
(JSC::AbstractSamplingCounter::dump):
* runtime/SamplingCounter.h: Added.
(JSC::AbstractSamplingCounter::count):
(JSC::AbstractSamplingCounter::addressOfCounter):
(JSC::AbstractSamplingCounter::init):
(JSC::SamplingCounter::SamplingCounter):
(JSC::GlobalSamplingCounter::name):
(JSC::DeletableSamplingCounter::DeletableSamplingCounter):
(JSC::DeletableSamplingCounter::~DeletableSamplingCounter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAttempt to clean up bidiNext usage
eric@webkit.org [Mon, 22 Aug 2011 23:34:31 +0000 (23:34 +0000)]
Attempt to clean up bidiNext usage
https://bugs.webkit.org/show_bug.cgi?id=66721

Reviewed by Ryosuke Niwa.

bidiNext and bidiFirst are horribly confusing.
Even worse is that bidiNext takes a bunch of mutually exclusive options.
It appears that there is a "return me every inline, even if its empty"
mode which is only used for simplified inline layout in RenderBlock.cpp.
To support that mode, there is a endOfInline pointer which keeps track
of if we just returned at the end of an inline to so we don't get stuck in
and empty inline (unable to distinguish the start from the finish).

The actual bidi/line-layout code uses bidiNext/bidiFirst in a "skip empty inlines"
mode.  (Since empty inlines do not participate in the Unicode Bidi Algorithm.)

This change renames bidiNext to bidiNextShared (still a horrible name) and moves
all callers to explicitly calling bidiNextSkippingEmptyInlines or bidiNextIncludingEmptyInlines.
It becomes obvious which code uses which.

In reviewing this code be aware that the previous bidiNext default was to "skip empty inlines" (skipInlines = true).
Thus any caller who didn't pass true/false should now be calling bidiNextSkippingEmptyInlines instead.

No functional change, thus no tests.

* rendering/InlineIterator.h:
(WebCore::bidiNextShared):
(WebCore::bidiNextSkippingEmptyInlines):
(WebCore::bidiNextIncludingEmptyInlines):
(WebCore::bidiFirstSkippingEmptyInlines):
(WebCore::bidiFirstIncludingEmptyInlines):
(WebCore::InlineWalker::InlineWalker):
(WebCore::InlineWalker::advance):
(WebCore::InlineIterator::increment):
(WebCore::InlineBidiResolver::appendRun):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::determineStartPosition):
(WebCore::shouldSkipWhitespaceAfterStartObject):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix usage of PassRefPtr in postMessage and structured clone code.
levin@chromium.org [Mon, 22 Aug 2011 23:30:10 +0000 (23:30 +0000)]
Fix usage of PassRefPtr in postMessage and structured clone code.
https://bugs.webkit.org/show_bug.cgi?id=66725

Reviewed by Darin Adler.

No new functionality exposed so no new tests.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::postMessage): Changed PassRefPtr to RefPtr and added release when handed off.
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::initMessageEvent): Ditto.
* bindings/js/JSMessagePortCustom.h:
(WebCore::handlePostMessage): Ditto.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create): Ditto.
* workers/SharedWorkerContext.cpp:
(WebCore::createConnectEvent): Added release() when a RefPtr is returned.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement cast between CSSPrimitiveValue and EBackfaceVisibility, use in CSSStyleSele...
macpherson@chromium.org [Mon, 22 Aug 2011 23:24:18 +0000 (23:24 +0000)]
Implement cast between CSSPrimitiveValue and EBackfaceVisibility, use in CSSStyleSelector::applyProperty.
https://bugs.webkit.org/show_bug.cgi?id=66648

Reviewed by Dan Bernstein.

No new tests / no functionality changed.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from EBackfaceVisibility.
(WebCore::CSSPrimitiveValue::operator EBackfaceVisibility):
Support cast from EBackfaceVisibility.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r93538.
pkasting@chromium.org [Mon, 22 Aug 2011 23:15:05 +0000 (23:15 +0000)]
Unreviewed, rolling out r93538.
http://trac.webkit.org/changeset/93538
https://bugs.webkit.org/show_bug.cgi?id=66143

Broke Leopard, SnowLeopard, and Chromium Mac bots

Source/WebCore:

* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::logicalRightOffsetForLine):
* rendering/RenderBlock.h:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.cpp:
* rendering/RenderRegion.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
* rendering/RenderView.h:
(WebCore::RenderView::pushLayoutState):

LayoutTests:

* fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
* fast/regions/webkit-flow-floats-inside-regions-bounds.html: Removed.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr-expected.txt: Removed.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html: Removed.
* fast/regions/webkit-flow-inlines-inside-regions-bounds.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDelay GC triggered NP object destruction to the next runloop cycle
oliver@apple.com [Mon, 22 Aug 2011 23:08:37 +0000 (23:08 +0000)]
Delay GC triggered NP object destruction to the next runloop cycle
https://bugs.webkit.org/show_bug.cgi?id=66717

Reviewed by Anders Carlsson.

Delay destruction of plugin objects caused by GC until the next
runloop cycle so that they can execute JS in their finalizers.
We do this using a zero delay timer coupled with a queue of
objects to be finalised.

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::releaseObject):
* WebProcess/Plugins/Netscape/JSNPObject.h:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::NPRuntimeObjectMap):
(WebKit::NPRuntimeObjectMap::invalidate):
(WebKit::NPRuntimeObjectMap::invalidateQueuedObjects):
(WebKit::NPRuntimeObjectMap::addToInvalidationQueue):
(WebKit::NPRuntimeObjectMap::finalize):
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
* WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:
(WebKit::trySafeReleaseNPObject):
* WebProcess/Plugins/Netscape/NPRuntimeUtilities.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove chromium-mac/plugins/keyboard-events-expected.txt to
tony@chromium.org [Mon, 22 Aug 2011 23:08:36 +0000 (23:08 +0000)]
Move chromium-mac/plugins/keyboard-events-expected.txt to
chromium-cg-mac/plugins/keyboard-events-expected.txt since the results
for chromium-mac are currently in chromium-cg-mac.  This result was
added in r93519 and put in the wrong place.

* platform/chromium-cg-mac/plugins/keyboard-events-expected.txt: Copied from LayoutTests/platform/chromium-mac/plugins/keyboard-events-expected.txt.
* platform/chromium-mac/plugins: Removed.
* platform/chromium-mac/plugins/keyboard-events-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Remove deprecated and unused bits of WebIDB* headers
adamk@chromium.org [Mon, 22 Aug 2011 22:44:31 +0000 (22:44 +0000)]
[chromium] Remove deprecated and unused bits of WebIDB* headers
https://bugs.webkit.org/show_bug.cgi?id=66711

Reviewed by Tony Chang.

The Chromium side of this patch was submitted as
http://crrev.com/97687.

* public/WebIDBCallbacks.h:
* public/WebIDBCursor.h:
(WebKit::WebIDBCursor::primaryKey):
(WebKit::WebIDBCursor::value):
(WebKit::WebIDBCursor::deleteFunction):
* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::transaction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate unit test expectations after r93530.
dglazkov@chromium.org [Mon, 22 Aug 2011 22:35:53 +0000 (22:35 +0000)]
Update unit test expectations after r93530.

* Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd CSS parsing of -webkit-flex-pack
tony@chromium.org [Mon, 22 Aug 2011 22:20:17 +0000 (22:20 +0000)]
Add CSS parsing of -webkit-flex-pack
https://bugs.webkit.org/show_bug.cgi?id=66701

Reviewed by Eric Seidel.

Source/WebCore:

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexPack):
* css/CSSPropertyNames.in:
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::flexPack):
(WebCore::InheritedFlags::setFlexPack):
(WebCore::InheritedFlags::initialFlexPack):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
* rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/script-tests/css-properties.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove code from PageClientImpl::doneWithKeyEvent to WKView
andersca@apple.com [Mon, 22 Aug 2011 22:08:33 +0000 (22:08 +0000)]
Move code from PageClientImpl::doneWithKeyEvent to WKView
https://bugs.webkit.org/show_bug.cgi?id=66722

Reviewed by Darin Adler.

* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::doneWithKeyEvent):
* UIProcess/API/mac/WKView.mm:
(-[WKView _doneWithKeyEvent:WebKit::eventWasHandled:]):
* UIProcess/API/mac/WKViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd editing/selection/caret-at-bidi-boundary.html back to the Qt's skipped list
rniwa@webkit.org [Mon, 22 Aug 2011 22:01:17 +0000 (22:01 +0000)]
Add editing/selection/caret-at-bidi-boundary.html back to the Qt's skipped list
because r93529 didn't fix it. The failure is still tracked by the bug 66514.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate the text input context when the plug-in focus changes and not when the complex...
andersca@apple.com [Mon, 22 Aug 2011 21:56:22 +0000 (21:56 +0000)]
Update the text input context when the plug-in focus changes and not when the complex text input state changes
https://bugs.webkit.org/show_bug.cgi?id=66716

Reviewed by Darin Adler.

* UIProcess/API/mac/WKView.mm:
(-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):
(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohandle child margin values when flexing
tony@chromium.org [Mon, 22 Aug 2011 21:49:06 +0000 (21:49 +0000)]
handle child margin values when flexing
https://bugs.webkit.org/show_bug.cgi?id=65887

Reviewed by David Hyatt.

Source/WebCore:

Test: css3/flexbox/002.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidth):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::RenderFlexibleBox::computePreferredSize): If the margin is
    auto, treat it as flex(1 0 0).
* rendering/RenderObject.cpp:
(WebCore::RenderObject::isFlexibleBoxIncludingDeprecated): Added.

LayoutTests:

* css3/flexbox/002-expected.txt: Added.
* css3/flexbox/002.html: Added.
* css3/flexbox/resources/flexbox.js:
(checkHorizontalBoxen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r92231): Apple campus proposal PDF doesn't display in Safari
msaboff@apple.com [Mon, 22 Aug 2011 21:46:58 +0000 (21:46 +0000)]
REGRESSION (r92231): Apple campus proposal PDF doesn't display in Safari
https://bugs.webkit.org/show_bug.cgi?id=66464

Changed ArgumentEncoder to use system malloc instead of fastMalloc.
FastMalloc uses madvise(MADV_FREE_REUSABLE) which is incompatible with
mach message Out Of Line (OOL) messages that use MACH_MSG_VIRTUAL_COPY.
The system malloc has no such limitation.
Changed sendOutgoingMessage to use MACH_MSG_VIRTUAL_COPY again as it
doesn't have size limitations that MACH_MSG_PHYSICAL_COPY.

Reviewed by Anders Carlsson.

* Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::~ArgumentEncoder):
(CoreIPC::ArgumentEncoder::grow):
* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::sendOutgoingMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
dglazkov@chromium.org [Mon, 22 Aug 2011 21:45:39 +0000 (21:45 +0000)]
[Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
https://bugs.webkit.org/show_bug.cgi?id=66705

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse -[NSApplication updateWindows] to update the current input context
andersca@apple.com [Mon, 22 Aug 2011 21:38:41 +0000 (21:38 +0000)]
Use -[NSApplication updateWindows] to update the current input context
https://bugs.webkit.org/show_bug.cgi?id=66715

Reviewed by Alexey Proskuryakov.

* UIProcess/API/mac/WKView.mm:
(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThe UI process should keep track of whether a plug-in has focus or not
andersca@apple.com [Mon, 22 Aug 2011 21:35:23 +0000 (21:35 +0000)]
The UI process should keep track of whether a plug-in has focus or not
https://bugs.webkit.org/show_bug.cgi?id=66712

Reviewed by Darin Adler.

This is in preparation for implementing the updated Cocoa text input model.

Pipe through whether a plug-in and its containing window has focus or not, from the
plug-in process and all the way to the UI process.

* PluginProcess/PluginControllerProxy.h:
* PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::pluginFocusOrWindowFocusChanged):
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::pluginFocusOrWindowFocusChanged):
* UIProcess/API/mac/WKView.mm:
(-[WKView _pluginFocusOrWindowFocusChanged:pluginComplexTextInputIdentifier:]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::pluginFocusOrWindowFocusChanged):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::windowFocusChanged):
(WebKit::NetscapePlugin::pluginFocusOrWindowFocusChanged):
* WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
(WebKit::PluginProxy::pluginFocusOrWindowFocusChanged):
* WebProcess/Plugins/PluginController.h:
* WebProcess/Plugins/PluginProxy.h:
* WebProcess/Plugins/PluginProxy.messages.in:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginFocusOrWindowFocusChanged):
* WebProcess/Plugins/PluginView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Make compositor context current before querying for extensions
nduca@chromium.org [Mon, 22 Aug 2011 21:23:23 +0000 (21:23 +0000)]
[chromium] Make compositor context current before querying for extensions
https://bugs.webkit.org/show_bug.cgi?id=66696

Reviewed by James Robinson.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Disable compositing tests for Leopard.
pkasting@chromium.org [Mon, 22 Aug 2011 21:13:35 +0000 (21:13 +0000)]
[chromium] Disable compositing tests for Leopard.

Reviewed by James Robinson.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebkit Mac10.6 Builder-Tester (Skia)(deps)(dbg) has compile failures
caryclark@google.com [Mon, 22 Aug 2011 21:07:03 +0000 (21:07 +0000)]
Webkit Mac10.6 Builder-Tester (Skia)(deps)(dbg) has compile failures
https://bugs.webkit.org/show_bug.cgi?id=66703

This error was detected by the debug build of the Chromium WebKit
Canary.

Reviewed by James Robinson.

No new tests. This change suppresses a compile-time warning
but does not affect the generated code.

* platform/graphics/mac/FontCustomPlatformData.h:
Replaced struct with class in a forward reference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate the current NSTextInputContext whenever the plug-in complex text input state...
andersca@apple.com [Mon, 22 Aug 2011 21:05:33 +0000 (21:05 +0000)]
Update the current NSTextInputContext whenever the plug-in complex text input state changes
https://bugs.webkit.org/show_bug.cgi?id=66709

Reviewed by Sam Weinig.

Call [NSTextInputContext currentInputContext] which will force AppKit to update the current input
context. Fixes a rare case when the out-of-line editing window wouldn't appear.

* UIProcess/API/mac/WKView.mm:
(-[WKView _setPluginComplexTextInputState:WebKit::pluginComplexTextInputIdentifier:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[CSSRegions] RenderFlowThread layout should use the attached region sizes
commit-queue@webkit.org [Mon, 22 Aug 2011 21:04:33 +0000 (21:04 +0000)]
[CSSRegions] RenderFlowThread layout should use the attached region sizes
https://bugs.webkit.org/show_bug.cgi?id=66143

Source/WebCore:

When RenderFlowThread is doing the layout it also sets the current RenderFlowThread on
the RenderView. RenderFlowThread cannot be nested inside a single RenderView, so there's no
need to put that on the LayoutState.

The right offset used to layout the inlines inside a RenderFlowThread
is now adjusted to fit inside the current region.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-22
Reviewed by David Hyatt.

Tests: fast/regions/webkit-flow-floats-inside-regions-bounds.html
       fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html
       fast/regions/webkit-flow-inlines-inside-regions-bounds.html

* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
(WebCore::RenderBlock::logicalRightOffsetForLine):
* rendering/RenderBlock.h:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::regionLogicalWidthForLine):
* rendering/RenderFlowThread.h:
(WebCore::RegionFittingDisabler::RegionFittingDisabler):
(WebCore::RegionFittingDisabler::~RegionFittingDisabler):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::layout):
* rendering/RenderRegion.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
* rendering/RenderView.h:
(WebCore::RenderView::hasRenderFlowThread):
(WebCore::RenderView::currentRenderFlowThread):
(WebCore::RenderView::setCurrentRenderFlowThread):
(WebCore::RenderView::pushLayoutState):

LayoutTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-22
Reviewed by David Hyatt.

* fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
* fast/regions/webkit-flow-floats-inside-regions-bounds.html: Added.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr-expected.txt: Added.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-lr.html: Added.
* fast/regions/webkit-flow-inlines-inside-regions-bounds.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove third_party/leveldb, because it's no longer used and doesn't exist downstream.
dglazkov@chromium.org [Mon, 22 Aug 2011 20:53:40 +0000 (20:53 +0000)]
Remove third_party/leveldb, because it's no longer used and doesn't exist downstream.

* DEPS: Done it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r89086): All worker xhr requests trigger preflight requests.
levin@chromium.org [Mon, 22 Aug 2011 20:45:20 +0000 (20:45 +0000)]
REGRESSION (r89086): All worker xhr requests trigger preflight requests.
https://bugs.webkit.org/show_bug.cgi?id=66340

Reviewed by Darin Adler.

Added tests which are similar to the non worker test with the same name.

* http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt: Added.
* http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple.html: Added.
* http/tests/xmlhttprequest/workers/resources/access-control-basic-get-fail-non-simple-test.js: Added.
* http/tests/xmlhttprequest/workers/resources/access-control-basic-get-fail-non-simple.js: Added.
* http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple-expected.txt: Added.
* http/tests/xmlhttprequest/workers/shared-worker-access-control-basic-get-fail-non-simple.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRoll Chromium DEPS to 97698.
dglazkov@chromium.org [Mon, 22 Aug 2011 20:39:11 +0000 (20:39 +0000)]
Roll Chromium DEPS to 97698.

* DEPS: Rolled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Rename chromium-gpu-mac to chromium-gpu-cg-mac
jamesr@google.com [Mon, 22 Aug 2011 20:38:52 +0000 (20:38 +0000)]
[chromium] Rename chromium-gpu-mac to chromium-gpu-cg-mac

* platform/chromium-gpu-cg-mac: Copied from LayoutTests/platform/chromium-gpu-mac.
* platform/chromium-gpu-mac: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r93517.
pkasting@chromium.org [Mon, 22 Aug 2011 20:23:58 +0000 (20:23 +0000)]
Unreviewed, rolling out r93517.
http://trac.webkit.org/changeset/93517
https://bugs.webkit.org/show_bug.cgi?id=63553

Breaks GTK Linux and Chromium Win

Source/WebCore:

* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):

LayoutTests:

* svg/animations/animate-end-attribute-expected.txt: Removed.
* svg/animations/animate-end-attribute.html: Removed.
* svg/animations/script-tests/animate-end-attribute.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFrameSelection::setNonDirectionalSelectionIfNeeded should not have a FrameSelection...
commit-queue@webkit.org [Mon, 22 Aug 2011 20:05:51 +0000 (20:05 +0000)]
FrameSelection::setNonDirectionalSelectionIfNeeded should not have a FrameSelection passed to it
https://bugs.webkit.org/show_bug.cgi?id=66636

Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-22
Reviewed by Darin Adler.

setNonDirectionalSelection was moved into FrameSelection in r93134 for
bug 60529, and still took a FrameSelection as an argument, which has been removed.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Update builder names for chromium gpu bots due to CG switchover
jamesr@google.com [Mon, 22 Aug 2011 19:35:50 +0000 (19:35 +0000)]
[chromium] Update builder names for chromium gpu bots due to CG switchover
https://bugs.webkit.org/show_bug.cgi?id=66693

Reviewed by Dirk Pranke.

Update the port and builder names for the chromium mac gpu bots to
account for the CG transition.

* Scripts/webkitpy/layout_tests/port/builders.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoediting/selection/caret-at-bidi-boundary.html timing out on Windows since it was...
rniwa@webkit.org [Mon, 22 Aug 2011 19:12:59 +0000 (19:12 +0000)]
editing/selection/caret-at-bidi-boundary.html timing out on Windows since it was added
https://bugs.webkit.org/show_bug.cgi?id=66551

Reviewed by Adam Roben.

Replaced leapForward by dummy clicks to make it work on Windows and other ports.

* editing/selection/caret-at-bidi-boundary.html:
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd CSS parsing of -webkit-flex-order
tony@chromium.org [Mon, 22 Aug 2011 19:08:36 +0000 (19:08 +0000)]
Add CSS parsing of -webkit-flex-order
https://bugs.webkit.org/show_bug.cgi?id=65384

Source/WebCore:

The property is an int described here:
http://dev.w3.org/csswg/css3-flexbox/#flex-order

Doesn't do anything yet, just hooking it up.

Reviewed by Ojan Vafai.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPropertyNames.in:
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::flexOrder):
(WebCore::InheritedFlags::setFlexOrder):
(WebCore::InheritedFlags::initialFlexOrder):
* rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
* rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

Reviewed by Ojan Vafai.

* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/css-properties.html:
* css3/flexbox/script-tests/css-properties.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agofix the GPU bot names on the layout test dashboard
dpranke@chromium.org [Mon, 22 Aug 2011 19:03:59 +0000 (19:03 +0000)]
fix the GPU bot names on the layout test dashboard
https://bugs.webkit.org/show_bug.cgi?id=66697

Reviewed by Dimitri Glazkov.

* TestResultServer/static-dashboards/builders.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Fix nullptr deref when switching composited tabs
enne@google.com [Mon, 22 Aug 2011 18:49:42 +0000 (18:49 +0000)]
[chromium] Fix nullptr deref when switching composited tabs
https://bugs.webkit.org/show_bug.cgi?id=66691

Reviewed by James Robinson.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::protectTileTextures):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Content and render surface textures not freed when compositor context...
commit-queue@webkit.org [Mon, 22 Aug 2011 18:18:59 +0000 (18:18 +0000)]
[chromium] Content and render surface textures not freed when compositor context destroyed
https://bugs.webkit.org/show_bug.cgi?id=66589

Patch by James Robinson <jamesr@chromium.org> on 2011-08-22
Reviewed by Kenneth Russell.

Explicitly delete all managed textures when destroying the compositor
context.  This regressed due to a combination of using share groups
(so destroying a context no longer implicitly releases all resources
in that context) and switching the TextureManager over to support
deferred texture destruction.

We sadly don't have a way to construct automated tests for resource
leaks currently.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::cleanupSharedObjects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic's relative time display should be updated regularly.
dglazkov@chromium.org [Mon, 22 Aug 2011 18:15:48 +0000 (18:15 +0000)]
garden-o-matic's relative time display should be updated regularly.
https://bugs.webkit.org/show_bug.cgi?id=66682

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Unload events can crash us when they blank out
japhet@chromium.org [Mon, 22 Aug 2011 18:12:45 +0000 (18:12 +0000)]
Source/WebCore: Unload events can crash us when they blank out
a parent frame.
https://bugs.webkit.org/show_bug.cgi?id=64741

Reviewed by Adam Barth.

Test: fast/loader/document-destruction-within-unload.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading): Prevent unload events
    from going into infinite recursion.
(WebCore::FrameLoader::setDocumentLoader): Ensure we don't
    let set m_documentLoader to a DocumentLoader with a null Frame*.
(WebCore::FrameLoader::detachChildren): Save off a vector of
    children to detach, rather than doing it inline.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=64741.

Reviewed by Adam Barth.

* fast/loader/document-destruction-within-unload-expected.txt: Added.
* fast/loader/document-destruction-within-unload.html: Added.
* fast/loader/resources/document-destruction-within-unload-iframe.html: Added.
* fast/loader/resources/document-destruction-within-unload.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Skip rtl-composited, as it causes other tests to crash.
enne@google.com [Mon, 22 Aug 2011 18:07:22 +0000 (18:07 +0000)]
[chromium] Skip rtl-composited, as it causes other tests to crash.

Unreviewed expectation change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] plugins/keyboard-events.html should pass on linux/mac
commit-queue@webkit.org [Mon, 22 Aug 2011 18:06:00 +0000 (18:06 +0000)]
[Chromium] plugins/keyboard-events.html should pass on linux/mac
https://bugs.webkit.org/show_bug.cgi?id=65964

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-22
Reviewed by Tony Chang.

Update the Chromium Linux test results following r88712.  Also rebaseline test results
for Chromium Mac.  Note the WebKit Mac and Win ports both report 0 for the line number
for all console.log() events.  The Chromium port reports the actual line number, hence
the need for separate test results for Chromium.  The test now runs, and passes on all
the Chromium ports, following r87855.  The test confirms user-plugin interactivity, so
we don't regress sites like youtube.com.  Refer to bug 34936.

* platform/chromium-linux/plugins/keyboard-events-expected.txt: Added.
* platform/chromium-mac/plugins/keyboard-events-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline for webkit bug 65295
commit-queue@webkit.org [Mon, 22 Aug 2011 18:03:49 +0000 (18:03 +0000)]
Rebaseline for webkit bug 65295
https://bugs.webkit.org/show_bug.cgi?id=66637

Patch by Ben Wells <benwells@chromium.org> on 2011-08-22
Reviewed by Kenneth Russell.

* fast/box-shadow/box-shadow-radius-expected.txt: Renamed from LayoutTests/platform/gtk/fast/box-shadow/box-shadow-radius-expected.txt.
* fast/layers/self-painting-outline-expected.txt: Renamed from LayoutTests/platform/gtk/fast/layers/self-painting-outline-expected.txt.
* platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
* platform/chromium-win/fast/layers/self-painting-outline-expected.png:
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/box-shadow/box-shadow-radius-expected.png: Renamed from LayoutTests/fast/box-shadow/box-shadow-radius-expected.png.
* platform/mac/fast/layers/self-painting-outline-expected.txt: Removed.
* platform/qt/fast/layers/self-painting-outline-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPatch by Young Han Lee <joybro@company100.net> on 2011-08-22
commit-queue@webkit.org [Mon, 22 Aug 2011 18:00:59 +0000 (18:00 +0000)]
Patch by Young Han Lee <joybro@company100.net> on 2011-08-22
Reviewed by Dirk Schulze.

SVG animation fill="freeze" doesn't set baseVal to current animVal if animation stops before reaching the end
https://bugs.webkit.org/show_bug.cgi?id=63553

calculateAnimationPercentAndRepeat() is returning 1, which means 100%, whenever
elapsed >= m_intervalEnd, but this is wrong because m_intervalEnd can be in the middle
of the animation duration. (e.g. begin="0s" end="2s" dur="3s")

This change makes the function return the animations's true progress instead of 100%
when the animation ends.

Source/WebCore:

Test: svg/animations/animate-end-attribute.html

* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):

LayoutTests:

* svg/animations/animate-end-attribute-expected.txt: Added.
* svg/animations/animate-end-attribute.html: Added.
* svg/animations/script-tests/animate-end-attribute.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build error when inspector is disabled.
gyuyoung.kim@samsung.com [Mon, 22 Aug 2011 17:49:52 +0000 (17:49 +0000)]
Fix build error when inspector is disabled.
https://bugs.webkit.org/show_bug.cgi?id=66644

Reviewed by Darin Adler.

* inspector/InspectorDatabaseResource.h: Add ENABLE(INSPECTOR) macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPass --makeargs of build-webkit to chromium linux builder
commit-queue@webkit.org [Mon, 22 Aug 2011 17:49:24 +0000 (17:49 +0000)]
Pass --makeargs of build-webkit to chromium linux builder
https://bugs.webkit.org/show_bug.cgi?id=66361

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-08-22
Reviewed by Tony Chang.

* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
(buildChromiumMakefile):
(buildChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash in FocusController::advanceFocusInDocumentOrder
inferno@chromium.org [Mon, 22 Aug 2011 17:33:59 +0000 (17:33 +0000)]
Crash in FocusController::advanceFocusInDocumentOrder
https://bugs.webkit.org/show_bug.cgi?id=66678

Source/WebCore:

RefPtr the focusable node to prevent getting deleted by mutation
event.

Reviewed by Dave Hyatt.

Test: fast/frames/focus-controller-crash-change-event.html

* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusInDocumentOrder):

LayoutTests:

Reviewed by Dave Hyatt.

* fast/frames/focus-controller-crash-change-event-expected.txt: Added.
* fast/frames/focus-controller-crash-change-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Some GTK+-specific font-face tests fail on the bots
mrobinson@webkit.org [Mon, 22 Aug 2011 17:07:55 +0000 (17:07 +0000)]
[GTK] Some GTK+-specific font-face tests fail on the bots
https://bugs.webkit.org/show_bug.cgi?id=65820

Fix the timing issues in this test.

Reviewed by Philippe Normand.

* platform/gtk/fonts/custom-font-missing-glyphs.html: Delay the test completion until
after document.readyState moves to "complete" and a short timeout.
* platform/gtk/fonts/font-face-with-complex-text.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: [Chromium] Crash when allocation of very large canvas fails
commit-queue@webkit.org [Mon, 22 Aug 2011 16:02:11 +0000 (16:02 +0000)]
Source/WebCore: [Chromium] Crash when allocation of very large canvas fails
https://bugs.webkit.org/show_bug.cgi?id=66563
Replacing the crash with a more graceful failure: canvas
will not render.

Patch by Justin Novosad <junov@chromium.org> on 2011-08-22
Reviewed by Stephen White.

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
Invoking TryCreateBitmapCanvas instead of CreateBitmapCanvas
This is the non-crashing version of the factory function.
It returns NULL if allocation fails.  Code for handling
NULL pointer was already in place.

Source/WebKit/chromium: [Chromium] Crash when allocation of very large canvas fails
https://bugs.webkit.org/show_bug.cgi?id=66563

Patch by Justin Novosad <junov@chromium.org> on 2011-08-22
Reviewed by Stephen White.

* DEPS:
Bumping up the chrome DEPS to pick up 97474, which is
required by this patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd myself to the contributor list.
commit-queue@webkit.org [Mon, 22 Aug 2011 15:52:12 +0000 (15:52 +0000)]
Add myself to the contributor list.
https://bugs.webkit.org/show_bug.cgi?id=66674

Patch by Peter Beverloo <peter@chromium.org> on 2011-08-22
Reviewed by Tony Gentilcore.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: bind registerDomainDispatcher to domain names.
loislo@chromium.org [Mon, 22 Aug 2011 15:36:28 +0000 (15:36 +0000)]
Web Inspector: bind registerDomainDispatcher to domain names.
https://bugs.webkit.org/show_bug.cgi?id=66670

jscompiler can't be used for validating domain events dispatchers because registerDomainDispatcher is too generic.
I'd like to introduce named versions per each domain.

Reviewed by Pavel Feldman.

* inspector/CodeGeneratorInspector.pm:
(GenerateInterface):
(generateBackendStubJS):
* inspector/front-end/ApplicationCacheItemsView.js:
* inspector/front-end/ConsoleView.js:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent):
* inspector/front-end/DOMStorage.js:
* inspector/front-end/Database.js:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher):
* inspector/front-end/ProfilesPanel.js:
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
* inspector/front-end/TimelineManager.js:
(WebInspector.TimelineDispatcher):
* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager):
* inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] ImageDiff does not consider --tolerance
kbalazs@webkit.org [Mon, 22 Aug 2011 15:17:13 +0000 (15:17 +0000)]
[Qt] ImageDiff does not consider --tolerance
https://bugs.webkit.org/show_bug.cgi?id=66299

Reviewed by Csaba Osztrogonác.

* DumpRenderTree/qt/ImageDiff.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[NRWT] Fix "Only unexpected results" option of results.html
ossy@webkit.org [Mon, 22 Aug 2011 13:43:30 +0000 (13:43 +0000)]
[NRWT] Fix "Only unexpected results" option of results.html
https://bugs.webkit.org/show_bug.cgi?id=66657

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-08-22
Reviewed by Csaba Osztrogonác.

* fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix generate-inspector-idl for Python3 after r93396
benjamin.poulain@nokia.com [Mon, 22 Aug 2011 13:26:47 +0000 (13:26 +0000)]
Fix generate-inspector-idl for Python3 after r93396
https://bugs.webkit.org/show_bug.cgi?id=66663

Reviewed by Andreas Kling.

In Python3, print is a function instead of a language keyword. Using parentheses
around the argument ensures the code works for both Python 2 and 3.

* inspector/generate-inspector-idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-08-22 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Mon, 22 Aug 2011 12:22:24 +0000 (12:22 +0000)]
2011-08-22  Vitaly Repeshko  <vitalyr@chromium.org>

        [chromium] Updating test expectations.

        Unreviewed.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] [WebSocket] Add a test to reproduce chromium bug on close before open.
commit-queue@webkit.org [Mon, 22 Aug 2011 12:06:38 +0000 (12:06 +0000)]
[Chromium] [WebSocket] Add a test to reproduce chromium bug on close before open.
https://bugs.webkit.org/show_bug.cgi?id=66649

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-22
Reviewed by Kent Tamura.

* http/tests/websocket/tests/hybi/close-before-open-expected.txt:
* http/tests/websocket/tests/hybi/close-before-open.html:
Add new URL to reproduce the problem.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate contributor list.
ossy@webkit.org [Mon, 22 Aug 2011 12:03:19 +0000 (12:03 +0000)]
Update contributor list.

Reviewed by Zoltan Herczeg.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChrome::setSelectedColorInColorChooser shouldn't be called when color chooser sets...
keishi@webkit.org [Mon, 22 Aug 2011 11:53:19 +0000 (11:53 +0000)]
Chrome::setSelectedColorInColorChooser shouldn't be called when color chooser sets a new color
https://bugs.webkit.org/show_bug.cgi?id=66658

Reviewed by Kent Tamura.

* html/ColorInputType.cpp:
(WebCore::ColorInputType::colorSelected): Call setValueFromRenderer instead of setValue.
* html/ColorInputType.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[ORWT] Fix --reset-results --add-platform-exceptions combo
ossy@webkit.org [Mon, 22 Aug 2011 10:05:48 +0000 (10:05 +0000)]
[ORWT] Fix --reset-results --add-platform-exceptions combo
https://bugs.webkit.org/show_bug.cgi?id=65464

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-08-22
Reviewed by Csaba Osztrogonác.

* Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: extract breakpoint management code to a separate class and add tests.
podivilov@chromium.org [Mon, 22 Aug 2011 09:17:00 +0000 (09:17 +0000)]
Web Inspector: extract breakpoint management code to a separate class and add tests.
https://bugs.webkit.org/show_bug.cgi?id=66224

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/breakpoint-manager.html

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/BreakpointManager.js: Added.
(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype.removeBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._deleteBreakpointFromUI):
(WebInspector.BreakpointManager.prototype._moveBreakpointInUI):
(WebInspector.BreakpointManager.prototype._breakpoints):
(WebInspector.BreakpointManager.prototype._breakpoint):
(WebInspector.BreakpointManager.prototype._forEachBreakpoint):
(WebInspector.BreakpointManager.prototype._setBreakpointInDebugger):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromDebugger):
(WebInspector.BreakpointManager.prototype._breakpointResolved):
(WebInspector.BreakpointManager.prototype.serializeBreakpoints):
(WebInspector.BreakpointManager.prototype.reset):
(WebInspector.BreakpointManager.prototype.debuggerReset):
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.serialize):
(WebInspector.Breakpoint.deserialize):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype.get rawSourceCode):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

LayoutTests:

* inspector/debugger/breakpoint-manager-expected.txt: Added.
* inspector/debugger/breakpoint-manager.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][ARM] Add bug report to flaky tests
zoltan@webkit.org [Mon, 22 Aug 2011 09:09:01 +0000 (09:09 +0000)]
[Qt][ARM] Add bug report to flaky tests

http/tests/cache/subresource-multiple-instances.html
https://bugs.webkit.org/show_bug.cgi?id=66652

http/tests/inspector/resource-tree/resource-tree-errors-reload.html
https://bugs.webkit.org/show_bug.cgi?id=66653

* platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][ARM] Skip flaky tests.
zoltan@webkit.org [Mon, 22 Aug 2011 08:05:59 +0000 (08:05 +0000)]
[Qt][ARM] Skip flaky tests.

* platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix 'make dist' for WebKitGTK+.
mrobinson@webkit.org [Mon, 22 Aug 2011 01:10:35 +0000 (01:10 +0000)]
Fix 'make dist' for WebKitGTK+.

Source/JavaScriptCore:

* GNUmakefile.list.am: Add a missing header to the sources list.

Source/WebCore:

* GNUmakefile.am: Add a missing file to the EXTRA_DIST list.
* GNUmakefile.list.am: Update the sources list to reflect reality.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate results for more tests affected by the addition of the
darin@apple.com [Sun, 21 Aug 2011 20:22:49 +0000 (20:22 +0000)]
Update results for more tests affected by the addition of the
HTMLSourceElement class.

* fast/dom/Window/window-properties-expected.txt:
* fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:
* platform/mac/fast/js/global-constructors-expected.txt:
* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
* platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:
* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fixes premature plugin unload bug
commit-queue@webkit.org [Sun, 21 Aug 2011 15:53:54 +0000 (15:53 +0000)]
[Qt] Fixes premature plugin unload bug
https://bugs.webkit.org/show_bug.cgi?id=66628

Patch by Lindsay Mathieson <lindsay.mathieson@gmail.com> on 2011-08-21
Reviewed by Benjamin Poulain.

The QtPlatformPlugin was allocated on the stack, so its destructor is unloading the
plugin at the end of the scope. This patch moves the local creation of QtPlatformPlugin
to class member (TextCheckerClientQt::m_platformPlugin), preventing premature unloading
of plugin.

* WebCoreSupport/TextCheckerClientQt.cpp:
(WebCore::TextCheckerClientQt::loadSpellChecker):
* WebCoreSupport/TextCheckerClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Fix and update doxygen documentation for ewk_view.
commit-queue@webkit.org [Sun, 21 Aug 2011 05:27:41 +0000 (05:27 +0000)]
[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-20
Reviewed by Kent Tamura.

* ewk/ewk_view.h:

Fixes description of method, parameters and returned value of API
related to settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore bytecompiler does not compute scope depth correctly
ddkilzer@apple.com [Sun, 21 Aug 2011 05:21:50 +0000 (05:21 +0000)]
JavaScriptCore bytecompiler does not compute scope depth correctly
in the case of constant declarations
https://bugs.webkit.org/show_bug.cgi?id=66572

Source/JavaScriptCore:

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-08-20
Reviewed by Oliver Hunt.

Changed the handling of const to add the dynamic scope depth.

* bytecompiler/NodesCodegen.cpp:
(JSC::ConstDeclNode::emitCodeSingle):

LayoutTests:

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-08-20
Reviewed by Oliver Hunt.

Added tests that reproduce the failure.

* fast/js/const-expected.txt:
* fast/js/resources/const.js:
(tryCatch1):
(tryCatch2):
(with1):
(with2):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Fix and update doxygen documentation for ewk_view.
commit-queue@webkit.org [Sun, 21 Aug 2011 05:14:07 +0000 (05:14 +0000)]
[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-20
Reviewed by Kent Tamura.

Fixes description of methods, parameters and returned value of API
related to cache of unused tiles, text searching and zoom matter.

* ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Fix and update doxygen documentation for ewk_view.
commit-queue@webkit.org [Sun, 21 Aug 2011 04:50:21 +0000 (04:50 +0000)]
[EFL] Fix and update doxygen documentation for ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66293

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-20
Reviewed by Kent Tamura.

Adds doxygen documentation for typedefs, defines and structures in ewk_view.h.
Moves includes and defines below a brief of file.

* ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Point build system and #include headers to v8-i18n library instead...
commit-queue@webkit.org [Sun, 21 Aug 2011 04:37:52 +0000 (04:37 +0000)]
Source/WebCore: Point build system and #include headers to v8-i18n library instead of v8 library.
We forked a new code.google.com/p/v8-i18n project from v8/extensions/experimental.
https://bugs.webkit.org/show_bug.cgi?id=66573

Patch by Nebojsa Ciric <cira@chromium.org> on 2011-08-20
Reviewed by Kent Tamura.

Covered by existing tests, and no code was changed.

* WebCore.gyp/WebCore.gyp:
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::createNewContext):

Source/WebKit/chromium: Add dependency on v8-i18n library. We used v8 repository before.
Chromium DEPS change was already submited (http://codereview.chromium.org/7583050).
https://bugs.webkit.org/show_bug.cgi?id=66573

Patch by Nebojsa Ciric <cira@chromium.org> on 2011-08-20
Reviewed by Kent Tamura.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic summary.html should have UI for examining failures
abarth@webkit.org [Sat, 20 Aug 2011 20:37:41 +0000 (20:37 +0000)]
garden-o-matic summary.html should have UI for examining failures
https://bugs.webkit.org/show_bug.cgi?id=66625

Reviewed by Dimitri Glazkov.

This patch introduces the notion of UI actions and converts our
existing manual <button> manipulation with this new abstraction.  The
patch also adds an Examine button to failure notifications.  In a
future patch, I'll add a controller that wires this button up to
something useful.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoinstanceof HTMLSourceElement Fails
commit-queue@webkit.org [Sat, 20 Aug 2011 18:40:16 +0000 (18:40 +0000)]
instanceof HTMLSourceElement Fails
https://bugs.webkit.org/show_bug.cgi?id=65013

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-08-20
Reviewed by Eric Carlson.

Source/WebCore:

Add HTMLSourceElement to DOMWindow.idl for consistency.  Constructors for
all elements should be available on DOMWindow.

 * bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::htmlSourceElementEnabled):
* bindings/generic/RuntimeEnabledFeatures.h:
* page/DOMWindow.idl:

LayoutTests:

Updated test results after adding HTMLSourceElement to the DOMWindow

* fast/dom/prototype-inheritance-2-expected.txt:
* fast/dom/prototype-inheritance-expected.txt:
* platform/chromium/fast/dom/prototype-inheritance-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-expected.txt:
* platform/qt-wk2/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-expected.txt:
* platform/win/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIf Range::insertNode is passed an empty document fragment, it creates a broken DOM...
darin@apple.com [Sat, 20 Aug 2011 18:11:55 +0000 (18:11 +0000)]
If Range::insertNode is passed an empty document fragment, it creates a broken DOM tree
https://bugs.webkit.org/show_bug.cgi?id=65015

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: fast/dom/Range/insertNode-empty-fragment-crash.html

* dom/Range.cpp: (WebCore::Range::insertNode): Don't adjust the range after insertion
if we didn't add anything. Otherwise the code will put a wrong "child before" value into
the range end boundary point.

LayoutTests:

* fast/dom/Range/insertNode-empty-fragment-crash-expected.txt: Added.
* fast/dom/Range/insertNode-empty-fragment-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic summary page should indiciate compile failures
abarth@webkit.org [Sat, 20 Aug 2011 15:54:24 +0000 (15:54 +0000)]
garden-o-matic summary page should indiciate compile failures
https://bugs.webkit.org/show_bug.cgi?id=66624

Reviewed by Dimitri Glazkov.

This patch creates a notification-based UI for build failures.  The new
UI displays the same information that used to be displayed in the
infobar.  There's lots of room for improvement in surfacing more
information, but this is a start.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoeventSender.keyDown is unimplemented (WKTR)
kbalazs@webkit.org [Sat, 20 Aug 2011 12:27:46 +0000 (12:27 +0000)]
eventSender.keyDown is unimplemented (WKTR)
https://bugs.webkit.org/show_bug.cgi?id=57515

Unreviewed gardening.

* platform/wk2/Skipped: Skip dependent test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] fast/parser/innerhtml-with-prefixed-elements.xhtml has incorrect result
kbalazs@webkit.org [Sat, 20 Aug 2011 12:15:25 +0000 (12:15 +0000)]
[Qt] fast/parser/innerhtml-with-prefixed-elements.xhtml has incorrect result
https://bugs.webkit.org/show_bug.cgi?id=66626

Unreviewed gardening.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOOB Read in WebCore::SVGAnimationElement
commit-queue@webkit.org [Sat, 20 Aug 2011 07:30:57 +0000 (07:30 +0000)]
OOB Read in WebCore::SVGAnimationElement
https://bugs.webkit.org/show_bug.cgi?id=65858

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-08-20
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Potential crash resulting from incorrect keySpline array lengths. This fix validates the length in startedActiveInterval.

Test: svg/animations/animate-calcMode-spline-crash-bad-array-length.xhtml

* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::parseMappedAttribute):
(WebCore::SVGAnimationElement::calculateKeyTimesIndex):

LayoutTests:

Added test case covering keySpline array length problem.

* svg/animations/animate-calcMode-spline-crash-bad-array-length-expected.txt: Added.
* svg/animations/animate-calcMode-spline-crash-bad-array-length.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r93415.
commit-queue@webkit.org [Sat, 20 Aug 2011 06:32:08 +0000 (06:32 +0000)]
Unreviewed, rolling out r93415.
http://trac.webkit.org/changeset/93415
https://bugs.webkit.org/show_bug.cgi?id=66623

Introduces failing test (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-19

Source/WebCore:

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/BreakpointManager.js: Removed.
* inspector/front-end/DebuggerModel.js:
* inspector/front-end/SourceFile.js:
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

LayoutTests:

* inspector/debugger/breakpoint-manager-expected.txt: Removed.
* inspector/debugger/breakpoint-manager.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium Windows and Linux rebaselines. These baselines were so wrong.
rniwa@webkit.org [Sat, 20 Aug 2011 06:19:11 +0000 (06:19 +0000)]
Chromium Windows and Linux rebaselines. These baselines were so wrong.

* platform/chromium-cg-mac/fast/css/computed-style-expected.txt: Removed.
* platform/chromium-win/fast/css/computed-style-expected.txt: Removed.
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
Replaced with LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt.
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
Replaced with LayoutTests/svg/css/getComputedStyle-basic-expected.txt.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip the test added by r93369 on GTK; the failure is tracked by the bug 66621.
rniwa@webkit.org [Sat, 20 Aug 2011 04:32:24 +0000 (04:32 +0000)]
Skip the test added by r93369 on GTK; the failure is tracked by the bug 66621.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93474 268f45cc-cd09-0410-ab3c-d52691b4dbfc