WebKit-https.git
16 years ago2006-01-03 Anders Carlsson <andersca@mac.com>
andersca [Tue, 3 Jan 2006 10:06:36 +0000 (10:06 +0000)]
2006-01-03  Anders Carlsson  <andersca@mac.com>

        Reviewed by Maciej.

        - Add test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5378
        createDocument fails with DOM Exception 5 when passed empty qname

        * dom/html/level2/core/createDocument08-expected.txt:
        * dom/xhtml/level2/core/createDocument08-expected.txt:
        These now fail.

        * fast/dom/createDocument-empty-expected.txt: Added.
        * fast/dom/createDocument-empty.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-03 Anders Carlsson <andersca@mac.com>
andersca [Tue, 3 Jan 2006 10:05:44 +0000 (10:05 +0000)]
2006-01-03  Anders Carlsson  <andersca@mac.com>

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5378
        createDocument fails with DOM Exception 5 when passed empty qname

        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMDOMImplementationProtoFunc::callAsFunction):
        When passing null to createDocument, pass a null DOMString, and not
        a DOMString containing the text "null".

        * khtml/xml/dom_docimpl.cpp:
        (DOMImplementationImpl::createDocument):
        Only validate the qualifiedName if it's not null or empty. Also, do not
        create the document element if the qualifiedName is null or empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6109
eseidel [Tue, 3 Jan 2006 09:19:17 +0000 (09:19 +0000)]
Bug #: 6109
Submitted by: eseidel
Reviewed by: darin
        No functionality changes, no tests possible.

        khtml/editing should use RefPtr instead of manual ref/deref
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6109

        Results in a slight performance gain < 1% on the PLT.

        * khtml/editing/SelectionController.cpp:
        (khtml::SelectionController::toRange):
        * khtml/editing/SelectionController.h:
        * khtml/editing/append_node_command.cpp:
        (khtml::AppendNodeCommand::AppendNodeCommand):
        (khtml::AppendNodeCommand::doApply):
        (khtml::AppendNodeCommand::doUnapply):
        * khtml/editing/append_node_command.h:
        (khtml::AppendNodeCommand::~AppendNodeCommand):
        (khtml::AppendNodeCommand::appendChild):
        (khtml::AppendNodeCommand::parentNode):
        * khtml/editing/apply_style_command.cpp:
        (khtml::StyleChange::init):
        (khtml::ApplyStyleCommand::removeInlineStyle):
        * khtml/editing/apply_style_command.h:
        * khtml/editing/composite_edit_command.cpp:
        (khtml::CompositeEditCommand::deleteInsignificantText):
        * khtml/editing/delete_from_text_node_command.cpp:
        (khtml::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand):
        * khtml/editing/delete_from_text_node_command.h:
        (khtml::DeleteFromTextNodeCommand::~DeleteFromTextNodeCommand):
        (khtml::DeleteFromTextNodeCommand::node):
        * khtml/editing/delete_selection_command.cpp:
        (khtml::DeleteSelectionCommand::initializePositionData):
        (khtml::DeleteSelectionCommand::saveTypingStyleState):
        (khtml::DeleteSelectionCommand::handleGeneralDelete):
        (khtml::DeleteSelectionCommand::calculateEndingPosition):
        (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
        (khtml::DeleteSelectionCommand::clearTransientState):
        * khtml/editing/delete_selection_command.h:
        * khtml/editing/edit_command.cpp:
        (khtml::EditCommand::EditCommand):
        (khtml::EditCommand::~EditCommand):
        (khtml::EditCommand::setTypingStyle):
        (khtml::EditCommand::styleAtPosition):
        * khtml/editing/edit_command.h:
        (khtml::EditCommand::document):
        (khtml::EditCommand::typingStyle):
        * khtml/editing/insert_into_text_node_command.cpp:
        (khtml::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
        * khtml/editing/insert_into_text_node_command.h:
        (khtml::InsertIntoTextNodeCommand::~InsertIntoTextNodeCommand):
        (khtml::InsertIntoTextNodeCommand::node):
        * khtml/editing/insert_node_before_command.cpp:
        (khtml::InsertNodeBeforeCommand::InsertNodeBeforeCommand):
        (khtml::InsertNodeBeforeCommand::doApply):
        (khtml::InsertNodeBeforeCommand::doUnapply):
        * khtml/editing/insert_node_before_command.h:
        (khtml::InsertNodeBeforeCommand::~InsertNodeBeforeCommand):
        (khtml::InsertNodeBeforeCommand::insertChild):
        (khtml::InsertNodeBeforeCommand::refChild):
        * khtml/editing/insert_paragraph_separator_command.cpp:
        (khtml::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand):
        (khtml::InsertParagraphSeparatorCommand::~InsertParagraphSeparatorCommand):
        (khtml::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion):
        (khtml::InsertParagraphSeparatorCommand::applyStyleAfterInsertion):
        * khtml/editing/insert_paragraph_separator_command.h:
        * khtml/editing/join_text_nodes_command.cpp:
        (khtml::JoinTextNodesCommand::JoinTextNodesCommand):
        (khtml::JoinTextNodesCommand::doApply):
        (khtml::JoinTextNodesCommand::doUnapply):
        * khtml/editing/join_text_nodes_command.h:
        (khtml::JoinTextNodesCommand::~JoinTextNodesCommand):
        (khtml::JoinTextNodesCommand::firstNode):
        (khtml::JoinTextNodesCommand::secondNode):
        * khtml/editing/jsediting.cpp:
        * khtml/editing/markup.cpp:
        (khtml::createMarkup):
        (khtml::createFragmentFromMarkup):
        (khtml::createFragmentFromText):
        (khtml::createFragmentFromNodeList):
        * khtml/editing/markup.h:
        * khtml/editing/merge_identical_elements_command.cpp:
        (khtml::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand):
        (khtml::MergeIdenticalElementsCommand::doApply):
        (khtml::MergeIdenticalElementsCommand::doUnapply):
        * khtml/editing/merge_identical_elements_command.h:
        (khtml::MergeIdenticalElementsCommand::~MergeIdenticalElementsCommand):
        * khtml/editing/move_selection_command.cpp:
        (khtml::MoveSelectionCommand::MoveSelectionCommand):
        (khtml::MoveSelectionCommand::~MoveSelectionCommand):
        (khtml::MoveSelectionCommand::doApply):
        * khtml/editing/move_selection_command.h:
        * khtml/editing/rebalance_whitespace_command.cpp:
        * khtml/editing/rebalance_whitespace_command.h:
        (khtml::RebalanceWhitespaceCommand::~RebalanceWhitespaceCommand):
        * khtml/editing/remove_css_property_command.cpp:
        (khtml::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand):
        * khtml/editing/remove_css_property_command.h:
        (khtml::RemoveCSSPropertyCommand::~RemoveCSSPropertyCommand):
        (khtml::RemoveCSSPropertyCommand::styleDeclaration):
        * khtml/editing/remove_node_attribute_command.cpp:
        (khtml::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand):
        * khtml/editing/remove_node_attribute_command.h:
        (khtml::RemoveNodeAttributeCommand::~RemoveNodeAttributeCommand):
        (khtml::RemoveNodeAttributeCommand::element):
        * khtml/editing/remove_node_command.cpp:
        (khtml::RemoveNodeCommand::RemoveNodeCommand):
        (khtml::RemoveNodeCommand::doApply):
        (khtml::RemoveNodeCommand::doUnapply):
        * khtml/editing/remove_node_command.h:
        (khtml::RemoveNodeCommand::~RemoveNodeCommand):
        (khtml::RemoveNodeCommand::node):
        * khtml/editing/remove_node_preserving_children_command.cpp:
        (khtml::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand):
        * khtml/editing/remove_node_preserving_children_command.h:
        (khtml::RemoveNodePreservingChildrenCommand::~RemoveNodePreservingChildrenCommand):
        (khtml::RemoveNodePreservingChildrenCommand::node):
        * khtml/editing/replace_selection_command.cpp:
        (khtml::ReplacementFragment::ReplacementFragment):
        (khtml::ReplacementFragment::~ReplacementFragment):
        (khtml::ReplacementFragment::enclosingBlock):
        (khtml::ReplacementFragment::removeNodePreservingChildren):
        (khtml::ReplacementFragment::removeNode):
        (khtml::ReplacementFragment::insertFragmentForTestRendering):
        (khtml::ReplacementFragment::restoreTestRenderingNodesToFragment):
        (khtml::ReplaceSelectionCommand::fixupNodeStyles):
        (khtml::computeAndStoreNodeDesiredStyle):
        (khtml::NodeDesiredStyle::NodeDesiredStyle):
        (khtml::ReplaceSelectionCommand::ReplaceSelectionCommand):
        (khtml::ReplaceSelectionCommand::~ReplaceSelectionCommand):
        (khtml::ReplaceSelectionCommand::doApply):
        (khtml::ReplaceSelectionCommand::completeHTMLReplacement):
        (khtml::ReplaceSelectionCommand::updateNodesInserted):
        * khtml/editing/replace_selection_command.h:
        (khtml::NodeDesiredStyle::node):
        (khtml::NodeDesiredStyle::style):
        (khtml::ReplacementFragment::root):
        * khtml/editing/set_node_attribute_command.cpp:
        (khtml::SetNodeAttributeCommand::SetNodeAttributeCommand):
        * khtml/editing/set_node_attribute_command.h:
        (khtml::SetNodeAttributeCommand::~SetNodeAttributeCommand):
        (khtml::SetNodeAttributeCommand::element):
        * khtml/editing/split_element_command.cpp:
        (khtml::SplitElementCommand::SplitElementCommand):
        (khtml::SplitElementCommand::doApply):
        (khtml::SplitElementCommand::doUnapply):
        * khtml/editing/split_element_command.h:
        (khtml::SplitElementCommand::~SplitElementCommand):
        * khtml/editing/split_text_node_command.cpp:
        (khtml::SplitTextNodeCommand::SplitTextNodeCommand):
        (khtml::SplitTextNodeCommand::doApply):
        (khtml::SplitTextNodeCommand::doUnapply):
        * khtml/editing/split_text_node_command.h:
        (khtml::SplitTextNodeCommand::~SplitTextNodeCommand):
        (khtml::SplitTextNodeCommand::node):
        * khtml/editing/split_text_node_containing_element.cpp:
        (khtml::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand):
        (khtml::SplitTextNodeContainingElementCommand::doApply):
        * khtml/editing/split_text_node_containing_element_command.h:
        (khtml::SplitTextNodeContainingElementCommand::~SplitTextNodeContainingElementCommand):
        * khtml/editing/visible_position.cpp:
        (khtml::makeRange):
        * khtml/editing/visible_position.h:
        * khtml/editing/visible_text.cpp:
        (khtml::TextIterator::range):
        (khtml::SimplifiedBackwardsTextIterator::range):
        (khtml::CharacterIterator::range):
        (khtml::findPlainText):
        * khtml/editing/visible_text.h:
        (khtml::WordAwareIterator::range):
        * khtml/editing/wrap_contents_in_dummy_span_command.cpp:
        (khtml::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand):
        (khtml::WrapContentsInDummySpanCommand::doApply):
        (khtml::WrapContentsInDummySpanCommand::doUnapply):
        * khtml/editing/wrap_contents_in_dummy_span_command.h:
        (khtml::WrapContentsInDummySpanCommand::~WrapContentsInDummySpanCommand):
        * kwq/DOMHTML.mm:
        (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
        (-[DOMHTMLDocument _createDocumentFragmentWithText:]):
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge documentFragmentWithMarkupString:baseURLString:]):
        (-[WebCoreBridge documentFragmentWithText:]):
        (-[WebCoreBridge documentFragmentWithNodesAsParagraphs:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-03 Anders Carlsson <andersca@mac.com>
andersca [Tue, 3 Jan 2006 08:23:38 +0000 (08:23 +0000)]
2006-01-03  Anders Carlsson  <andersca@mac.com>

        Reviewed by Darin.

        - Add tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=5177
        Javascript cloneNode(deep) does not clone form elements correctly

        * fast/dom/clone-node-form-elements-expected.txt: Added.
        * fast/dom/clone-node-form-elements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2006-01-03 Anders Carlsson <andersca@mac.com>
andersca [Tue, 3 Jan 2006 08:12:29 +0000 (08:12 +0000)]
2006-01-03  Anders Carlsson  <andersca@mac.com>

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5177
        Javascript cloneNode(deep) does not clone form elements correctly

        * khtml/html/html_elementimpl.cpp:
        (HTMLElementImpl::cloneNode):
        Call copyNonAttributeProperties on the new node.

        * khtml/html/html_formimpl.cpp:
        (DOM::HTMLInputElementImpl::copyNonAttributeProperties):
        * khtml/html/html_formimpl.h:
        Copy m_value, m_checked and m_indeterminate here.

        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::importNode):
        Call copyNonAttributeProperties on the new node.

        * khtml/xml/dom_elementimpl.cpp:
        (ElementImpl::cloneNode):
        Call copyNonAttributeProperties on the new node.

        * khtml/xml/dom_elementimpl.h:
        (DOM::ElementImpl::copyNonAttributeProperties):
        Add function declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
mjs [Tue, 3 Jan 2006 05:15:21 +0000 (05:15 +0000)]
    Reviewed by Eric.

- moved frame traversal logic from WebFrame to WebBridge
http://bugzilla.opendarwin.org/show_bug.cgi?id=6341

To do this, I had to invert the ownership so that WebBridge now
owns WebFrame instead of vice versa. As a result, WebView now owns
a WebBridge pointer and does not have a direct WebFrame pointer.

        * WebCoreSupport.subproj/WebBridge.h:
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge initWithFrameName:view:]): The initializer is now responsible for creating
the frame, so pass it what it needs to do that.
        (-[WebBridge dealloc]): The bridge now owns the frame, so release it.
        (-[WebBridge close]): ditto
        (-[WebBridge firstChild]): Moved from WebFrame
        (-[WebBridge lastChild]): ditto
        (-[WebBridge childCount]): ditto
        (-[WebBridge previousSibling]): ditto
        (-[WebBridge nextSibling]): ditto
        (-[WebBridge isDescendantOfFrame:]): ditto
        (-[WebBridge traverseNextFrameStayWithin:]): ditto
        (-[WebBridge appendChild:]): ditto
        (-[WebBridge removeChild:]): ditto
        * WebView.subproj/WebFrame.m:
        (-[WebFrame _removeChild::]): Call WebBridge version
        (-[WebFramePrivate dealloc]): ditto
        (-[WebFrame _firstChildFrame]): ditto
        (-[WebFrame _lastChildFrame]): ditto
        (-[WebFrame _childFrameCount]): ditto
        (-[WebFrame _previousSiblingFrame]): ditto
        (-[WebFrame _nextSiblingFrame]): ditto
        (-[WebFrame _traverseNextFrameStayWithin:]): ditto
        (-[WebFrame _appendChild:]): ditto
        (-[WebFrame _removeChild:]): ditto
        (-[WebFrame _isDescendantOfFrame:]): ditto,
        (-[WebFrame _detachFromParent]): reorder a bit to avoid losing our bridge
pointer before the bridge is due to release us, and don't release the
bridge any more since it now owns us
        (-[WebFrame _initWithName:webFrameView:webView:bridge:]): new initializer,
we no longer create the bridge, instead it is passed in
        (-[WebFrame initWithName:webFrameView:webView:]): Call the new designated
initializer, but this method is no longer viable and should be deprecated.
        * WebView.subproj/WebFrameInternal.h:

* WebView.subproj/WebView.m: WebView was changed to hold onto
the WebBridge for the main frame instead of the WebFrame.

        (-[WebViewPrivate dealloc]): update for the fact that we hold
a bridge now, not a frame.
        (-[WebView _close]): ditto
        (-[WebView _createFrameNamed:inParent:allowsScrolling:]): Create
a bridge, not a frame.
        (-[WebView _commonInitializationWithFrameName:groupName:]): ditto.
        (-[WebView setDefersCallbacks:]): get mainFrame via method
        (-[WebView mainFrame]): Update to get the main frame properly

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Rubber stamped by Eric.
mjs [Tue, 3 Jan 2006 03:48:59 +0000 (03:48 +0000)]
Rubber stamped by Eric.

        - remove the no longer used QIntDict

        * kwq/KWQIntDict.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
ap [Tue, 3 Jan 2006 02:07:14 +0000 (02:07 +0000)]
    Reviewed by Eric.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5609
          XSLT document() doesn't handle relative paths

        Test case: fast/xsl/xslt-relative-path.xml

        * khtml/xsl/xslt_processorimpl.cpp:
        (DOM::docLoaderFunc): Renamed from stylesheetLoadFunc. Use base URL when constructing URLs.
        (DOM::XSLTProcessorImpl::transformToString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
vicki [Tue, 3 Jan 2006 00:13:35 +0000 (00:13 +0000)]
    Reviewed by Maciej.

- fix for <rdar://problem/4389622> *Pan EU2* iframe swallows events for overlapping elements (part 2)

We originally added a call to passSubframeEventToSubframe here to fix the hand cursor updating problem
reported in <rdar://problem/4316201> REGRESSION: cursor and text in status bar is not updated when
mousing over links in a frame (5509). However, when we return early after passSubframeEventToSubframe,
we fail to fire onmouseout events.  Since the call to passSubframeEventToSubframe was originally added
to fix the hand cursor updating problem, remove the early return and make cursor updating conditional
on passSubframeEventToSubframe.

        * khtml/khtmlview.cpp:
        (KHTMLView::viewportMouseMoveEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
darin [Sat, 31 Dec 2005 00:14:29 +0000 (00:14 +0000)]
    Reviewed by Maciej.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=4557
          rename unusual strcmp and strcasecmp for DOMString family

        Added new functions named equal and equalIgnoringCase.

        * khtml/xml/dom_stringimpl.h: Changed the type of the length parameter to computeHash to unsigned
        to match the rest of the interface. Added equal and equalIgnoringCase functions. Added a
        version of the hash function that works on char* to CaseInsensitiveHash as preparation for an
        atomic string change.
        * khtml/xml/dom_stringimpl.cpp: Moved the QT_ALLOC_QCHAR_VEC and QT_DELETE_QCHAR_VEC macros
        here, and changed them into inline functions.
        (DOM::equal): Implemented.
        (DOM::equalIgnoringCase): Implemented.
        (DOM::DOMStringImpl::computeHash): Changed parameter type to unsigned to match other similar
        functions.

        * khtml/dom/dom_string.h: Removed unnecessary friend declarations. Changed operator
        overloads for == and != to call through inline to DOMStringImpl. Replaced strcasecmp
        with equalIgnoringCase, overloaded for one more combination of parameters. Removed strcmp.
        * khtml/dom/dom_string.cpp: Removed functions that are now implemented in DOMStringImpl*.

        * khtml/xml/dom_atomicstring.h: Removed a redundant const. Removed unnecessary
        friend declarations. Removed AtomicString::equal. Filled out a larger set of == and
        != operator implementations, mostly with inlines calling through to DOMStringImpl.
        Renamed equalsIgnoreCase to equalIgnoringCase and filled out a larger set as above.
        * khtml/xml/dom_atomicstring.cpp: Renamed AtomicString::equal to just ==.
        Removed some implementation of == and equalsIgnoreCase that are replaced by inlines.

        * khtml/html/html_listimpl.cpp:
        (DOM::HTMLOListElementImpl::parseMappedAttribute):
        (DOM::HTMLLIElementImpl::parseMappedAttribute):
        Use the "==" operator instead of strcmp.

        * khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector):
        Use equalIgnoringCase instead of equalsIgnoreCase.

        * khtml/rendering/render_form.cpp:
        (RenderSlider::updateFromElement): Fixed bug where a temporary DOMString was put into
        a const DOMString&. Changed some DOMString to AtomicString as appropriate, and also
        used equalIgnoringCase instead of strcasecmp.
        (RenderSlider::slotSliderValueChanged): More of the same.

        * khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv): Replaced use of strcasecmp
        with equalIgnoringCase. Added parentheses to fix incorrect operator precedence in one case
        (&& binds tighter than ||) which fixes a crash when using a http-equiv pragma when there
        is no part (not sure how to reproduce that).

        * khtml/khtml_part.cpp:
        (updateState):
        (KHTMLPart::selectionStartHasStyle):
        * khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocument::putValueProperty):
        * khtml/editing/apply_style_command.cpp:
        (khtml::StyleChange::checkForLegacyHTMLStyleChange):
        (khtml::StyleChange::currentlyHasStyle):
        (khtml::hasTextDecorationProperty):
        (khtml::ApplyStyleCommand::extractTextDecorationStyle):
        (khtml::ApplyStyleCommand::extractAndNegateTextDecorationStyle):
        * khtml/html/html_baseimpl.cpp:
        (HTMLBodyElementImpl::parseMappedAttribute):
        (HTMLFrameElementImpl::parseMappedAttribute):
        * khtml/html/html_blockimpl.cpp:
        (HTMLDivElementImpl::parseMappedAttribute):
        (HTMLHRElementImpl::parseMappedAttribute):
        (HTMLParagraphElementImpl::parseMappedAttribute):
        (HTMLMarqueeElementImpl::parseMappedAttribute):
        * khtml/html/html_elementimpl.cpp:
        (HTMLElementImpl::parseMappedAttribute):
        (HTMLElementImpl::addHTMLAlignment):
        (HTMLElementImpl::setContentEditable):
        * khtml/html/html_formimpl.cpp:
        (DOM::HTMLFormElementImpl::parseMappedAttribute):
        (DOM::HTMLButtonElementImpl::parseMappedAttribute):
        (DOM::HTMLInputElementImpl::setInputType):
        (DOM::HTMLInputElementImpl::parseMappedAttribute):
        (DOM::HTMLKeygenElementImpl::appendFormData):
        (DOM::HTMLTextAreaElementImpl::parseMappedAttribute):
        * khtml/html/html_imageimpl.cpp: (DOM::HTMLAreaElementImpl::parseMappedAttribute):
        * khtml/html/html_inlineimpl.cpp: (DOM::HTMLBRElementImpl::parseMappedAttribute):
        * khtml/html/html_tableimpl.cpp: (DOM::HTMLTablePartElementImpl::parseMappedAttribute):
        * khtml/html/htmlparser.cpp: (HTMLParser::handleError):
        Use equalIgnoringCase instead of strcasecmp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin, landed by ap.
ap [Fri, 30 Dec 2005 22:17:09 +0000 (22:17 +0000)]
    Reviewed by Darin, landed by ap.

        - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5461
          Text width measured incorrectly when text-align: justify

WebCore:
        * khtml/rendering/font.h:
        * khtml/rendering/font.cpp:
        (khtml::Font::selectionRectForText): Added.
        * khtml/rendering/render_text.cpp:
        (kthml::InlineTextBox::selectionRect): Use selectionRectForText. This
        works for justified text as well, and avoids intermediate rounding which
        resulted in selection rects narrower than AppKit's.
        (khtml::InlineTextBox::positionForOffset): Use selectionRectForText,
        which works for justified text as well.
        * kwq/KWQFontMetrics.h:
        * kwq/KWQFontMetrics.mm:
        (QFontMetrics::selectionRectForText): Added.
        * kwq/WebCoreTextRenderer.h:

WebKit:
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer selectionRectForRun:style:geometry:]): Added.
        (CG_drawHighlight): Use new function CG_selectionRect.
        (CG_selectionRect): New function to compute the selection rect.
        Eliminated rounding hackery that was required for keeping the highlight
        rect within the selection rect computed by
        InlineTextBox::selectionRect, since the latter uses this function now.
        The new selection rect is wider and matches AppKit more closely,
        although the right hand side is roundf()ed instead of cielf()ed for
        optimal caret positioning.
        (ATSU_drawHighlight): Use new function ATSU_selectionRect.
        (ATSU_selectionRect): New function to compute the selection rect.
        Much like CG_selectionRect.
LayoutTests:
        * fast/text/justified-text-rect-expected.checksum: Added.
        * fast/text/justified-text-rect-expected.png: Added.
        * fast/text/justified-text-rect-expected.txt: Added.
        * fast/text/justified-text-rect.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6289
ap [Fri, 30 Dec 2005 21:23:32 +0000 (21:23 +0000)]
    - Fix bugzilla.opendarwin.org/show_bug.cgi?id=6289
        REGRESSION: firstCharacterForRange(0, 0) returns a 0x0 rect

        * khtml/editing/visible_text.cpp:
        (khtml::TextIterator::rangeFromLocationAndLength):
        Only special-case (0, 0) ranges for empty documents.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoForgot to commit this
andersca [Fri, 30 Dec 2005 21:22:18 +0000 (21:22 +0000)]
Forgot to commit this

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6305
eseidel [Fri, 30 Dec 2005 21:16:19 +0000 (21:16 +0000)]
Bug #: 6305
Submitted by: eseidel
Reviewed by: ggaren
        Missing CSS Style sheets in one of the XHTML tests in WebCore
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6305

        * fast/parser/entities-in-xhtml.xhtml: removed <link> to css sheet

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoRemove conflict marker from ChangeLog
ggaren [Fri, 30 Dec 2005 20:43:09 +0000 (20:43 +0000)]
Remove conflict marker from ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
ggaren [Fri, 30 Dec 2005 20:42:15 +0000 (20:42 +0000)]
WebCore:

        Added test case for <rdar://problem/4268278> Submitting a form in onUnload event
        handler causes crash in -[WebDataSource(WebPrivate) _commitIfReady:]

        * manual-tests/onunload-form-submit-crash.html: Added.

WebKit:

        Reviewed by Eric.

        Manual testcase added:
        WebCore/manual-tests/onunload-form-submit-crash.html

        - Fixed <rdar://problem/4268278> Submitting a form in onUnload event
        handler causes crash in -[WebDataSource(WebPrivate) _commitIfReady:]

        The problem is that the form submission in the unload event kicks off
        a new load in the midst of the load that caused the unload event to
        fire in the first place, so the two loads stomp each other.

        The solution is to cancel the first load and let the unload handler's
        load win. (Firefox does the same.)

        * WebView.subproj/WebFrame.m:
        (-[WebFrame _transitionToCommitted:]): Moved call to -closeURL up
        the call stack to _continueLoadRequest. (See below.) This has the
        side-effect of always firing the unload event, even if the new
        datasource never becomes committed, which seems like a good thing.

        (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
        Call -closeURL here, instead of in _transitionToCommitted,  so that the
        unload handler can fire before we initialize any part of the load.

        Check provisionalDataSource for nil to discover if the unload event
        kicked off its own load.

        Cleared up some coments.

        (-[WebFrame _detachFromParent]):
        It turns out that if you close the window instead of just navigating
        to a new page, you get an alternate assertion failure/crash because
        the load kicked off by the unload event handler generates resource
        loader callbacks after the associated WebFrame/WebView has disappeared.

        The nifty solution here is just to reverse the order of calls to
        -stopLoading and -closeURL, thus guaranteeing that -stopLoading has the
        last word when you close a window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2005-12-30 Anders Carlsson <andersca@mac.com>
andersca [Fri, 30 Dec 2005 14:53:39 +0000 (14:53 +0000)]
2005-12-30  Anders Carlsson  <andersca@mac.com>

        Reviewed by Eric.

- Update tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6297
        XMLSerializer should use createMarkup

        * fast/dom/XMLSerializer.html:
        * fast/dom/XMLSerializer-expected.txt:
        Create a document fragment and serialize it.

        * fast/dom/dom-parse-serialize.html:
        * fast/dom/dom-parse-serialize-expected.txt:
        Add some entities to attributes and text nodes.

        * fast/xsl/xslt-processer-expected.txt:
        Update test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2005-12-30 Anders Carlsson <andersca@mac.com>
andersca [Fri, 30 Dec 2005 14:51:31 +0000 (14:51 +0000)]
2005-12-30  Anders Carlsson  <andersca@mac.com>

        Reviewed by Eric.

- Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6297
XMLSerializer should use createMarkup.

        * khtml/ecma/xmlserializer.cpp:
        (KJS::XMLSerializerProtoFunc::callAsFunction):
Use createMarkup instead of NodeImpl::toString.

        * khtml/editing/markup.cpp:
        (khtml::startMarkup):
escape attribute values and ignore document fragment nodes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago No review, just test result update.
mjs [Fri, 30 Dec 2005 09:57:22 +0000 (09:57 +0000)]
    No review, just test result update.

        * tests/mozilla/expected.html: Updated for newly passing test from recent fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6299
eseidel [Fri, 30 Dec 2005 09:48:56 +0000 (09:48 +0000)]
Bug #: 6299
Submitted by: eseidel
Reviewed by: mjs
        No functional changes, thus no layout test.

        Just removes debug NSLog() calls from ksvg2/kcanvas.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6299

        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (KCanvasFilterQuartz::prepareFilter):
        (KCanvasFilterQuartz::applyFilter):
        (KCanvasFilterQuartz::getCIFilterStack):
        (KCanvasFilterQuartz::imageForName):
        (KCanvasFEBlendQuartz::getCIFilter):
        (KCanvasFEColorMatrixQuartz::getCIFilter):
        (KCanvasFEGaussianBlurQuartz::getCIFilter):
        * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
        (KCanvasClipperQuartz::applyClip):
        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
        (KRenderingDeviceContextQuartz::mapFromVisual):
        (KRenderingDeviceContextQuartz::mapToVisual):
        (KRenderingDeviceQuartz::createResource):
        (KRenderingDeviceQuartz::createFilterEffect):
        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
        (drawShadingWithStyle):
        (KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
        (KRenderingPaintServerPatternQuartz::draw):
        * ksvg2/svg/svgpathparser.cpp:
        (SVGPathParser::parseSVG):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2005-12-30 Anders Carlsson <andersca@mac.com>
andersca [Fri, 30 Dec 2005 09:44:50 +0000 (09:44 +0000)]
2005-12-30  Anders Carlsson  <andersca@mac.com>

        Reviewed by Maciej.

- Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6298
Getter setter test is failing

        * kjs/object.cpp:
        (KJS::JSObject::put):
Rework the getter setter part. We now walk the prototype chain, checking for
getter/setter properties and only take the slow path if any are found.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: none
eseidel [Fri, 30 Dec 2005 09:27:21 +0000 (09:27 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: No review, just adding a couple missing results.
        One missing pixel test.
        One result which never was updated properly after rounded rect fix:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6157

        * svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
        * fast/parser/xhtml-alternate-entities-expected.checksum: Added.
        * fast/parser/xhtml-alternate-entities-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin, landed by Maciej.
mjs [Fri, 30 Dec 2005 08:51:24 +0000 (08:51 +0000)]
    Reviewed by Darin, landed by Maciej.

- land test case documenting wontfix status for certain overflow/table behavior
http://bugzilla.opendarwin.org/show_bug.cgi?id=3505

        * fast/overflow/overflow-auto-table-expected.checksum: Added.
        * fast/overflow/overflow-auto-table-expected.png: Added.
        * fast/overflow/overflow-auto-table-expected.txt: Added.
        * fast/overflow/overflow-auto-table.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: none
eseidel [Fri, 30 Dec 2005 08:49:02 +0000 (08:49 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: none, just updating stale results
        No review, updating stale results.
        I went over all the interesting ones with mjs and hyatt.

        * css2.1/t040304-c64-uri-00-a-g-expected.checksum:
        * css2.1/t040304-c64-uri-00-a-g-expected.png:
        * css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum:
        * css2.1/t0905-c414-flt-wrap-01-d-g-expected.png:
        * css2.1/t100801-c544-valgn-02-d-agi-expected.checksum:
        * css2.1/t100801-c544-valgn-02-d-agi-expected.png:
        * dom/xhtml/level2/html/HTMLBaseElement02-expected.checksum:
        * dom/xhtml/level2/html/HTMLBaseElement02-expected.png:
        * dom/xhtml/level2/html/frame-expected.checksum:
        * dom/xhtml/level2/html/frame-expected.png:
        * dom/xhtml/level2/html/iframe-expected.checksum:
        * dom/xhtml/level2/html/iframe-expected.png:
        * editing/selection/extend-by-word-002-expected.checksum:
        * editing/selection/extend-by-word-002-expected.png:
        * fast/css/imageTileOpacity-expected.checksum:
        * fast/css/imageTileOpacity-expected.png:
        * fast/forms/001-expected.checksum:
        * fast/forms/001-expected.png:
        * fast/frames/empty-frame-src-expected.checksum:
        * fast/frames/empty-frame-src-expected.png:
        * fast/frames/invalid-expected.checksum:
        * fast/frames/invalid-expected.png:
        * fast/frames/valid-expected.checksum:
        * fast/frames/valid-expected.png:
        * svg/custom/conditional-processing-outside-switch-expected.txt:
        * svg/custom/control-points-for-S-and-T-expected.txt:
        * svg/custom/fill-update-expected.txt:
        * svg/custom/junk-data-expected.txt:
        * svg/custom/missing-xlink-expected.txt:
        * svg/custom/path-bad-data-expected.txt:
        * svg/custom/path-update-expected.txt:
        * svg/custom/simpleCDF-expected.txt:
        * svg/custom/transform-ignore-after-invalid-expected.txt:
        * svg/custom/transform-invalid-expected.txt:
        * svg/custom/transform-with-ending-space-expected.txt:
        * svg/custom/use-forward-refs-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago No review.
mjs [Fri, 30 Dec 2005 08:18:47 +0000 (08:18 +0000)]
    No review.

- updated test results for Number.toString() fixes:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=6259>

        * fast/js/kde/Number-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed and committed by Maciej.
mjs [Fri, 30 Dec 2005 08:14:12 +0000 (08:14 +0000)]
    Reviewed and committed by Maciej.

- Handle negative, FP numbers with non-10 radix in toString
http://bugzilla.opendarwin.org/show_bug.cgi?id=6259

        (Merged from KJS, original work by Harri Porten)

        * kjs/number_object.cpp:
        (NumberProtoFunc::callAsFunction): rewrote Number.toString(radix) to work with
negative numbers, floating point and very large numbers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6155
eseidel [Fri, 30 Dec 2005 07:38:26 +0000 (07:38 +0000)]
Bug #: 6155
Submitted by: eseidel
Reviewed by: none, just updating pixel results
        Updating results, after landing color-matching change.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6155

        * svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
        * svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
        * svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
        * svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
        * svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
        * svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
        * svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
        * svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
        * svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
        * svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
        * svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
        * svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
        * svg/W3C-SVG-1.1/shapes-rect-01-t-expected.checksum:
        * svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
        * svg/W3C-SVG-1.1/struct-image-01-t-expected.checksum:
        * svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
        * svg/W3C-SVG-1.1/struct-image-04-t-expected.checksum:
        * svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
        * svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
        * svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
        * svg/custom/conditional-processing-outside-switch-expected.checksum:
        * svg/custom/conditional-processing-outside-switch-expected.png:
        * svg/custom/control-points-for-S-and-T-expected.checksum:
        * svg/custom/control-points-for-S-and-T-expected.png:
        * svg/custom/fill-update-expected.checksum:
        * svg/custom/fill-update-expected.png:
        * svg/custom/junk-data-expected.checksum:
        * svg/custom/junk-data-expected.png:
        * svg/custom/missing-xlink-expected.checksum:
        * svg/custom/missing-xlink-expected.png:
        * svg/custom/path-bad-data-expected.checksum:
        * svg/custom/path-bad-data-expected.png:
        * svg/custom/path-update-expected.checksum:
        * svg/custom/path-update-expected.png:
        * svg/custom/simpleCDF-expected.checksum:
        * svg/custom/simpleCDF-expected.png:
        * svg/custom/simpleCDF-expected.txt:
        * svg/custom/transform-ignore-after-invalid-expected.checksum:
        * svg/custom/transform-ignore-after-invalid-expected.png:
        * svg/custom/transform-ignore-after-invalid.svg:
        * svg/custom/transform-invalid-expected.checksum:
        * svg/custom/transform-invalid-expected.png:
        * svg/custom/transform-with-ending-space-expected.checksum:
        * svg/custom/transform-with-ending-space-expected.png:
        * svg/custom/use-forward-refs-expected.checksum:
        * svg/custom/use-forward-refs-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6157
eseidel [Fri, 30 Dec 2005 07:33:03 +0000 (07:33 +0000)]
Bug #: 6157
Submitted by: rob buis
Reviewed by: eseidel
        WebCore+SVG has some problems with rounded rectangles
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6157

        * svg/custom/rounded-rects-expected.checksum: Added.
        * svg/custom/rounded-rects-expected.png: Added.
        * svg/custom/rounded-rects-expected.txt: Added.
        * svg/custom/rounded-rects.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric, committed by Maciej.
mjs [Fri, 30 Dec 2005 07:05:54 +0000 (07:05 +0000)]
    Reviewed by Eric, committed by Maciej.

        - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6288
          HEAD build broken 12/29/2005

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (overrideLayoutOperation): Use previous character from the buffer
        instead of ch which may be uninitialized on the first iteration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: none
eseidel [Fri, 30 Dec 2005 07:04:10 +0000 (07:04 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: mjs
        Move WebView width/height logic into DumpRenderTree to support
        running the W3C SVG 1.1 tests along side other tests.  The W3C
        SVG 1.1 tests require a 480x360 view.

        * DumpRenderTree/DumpRenderTree.m:
        (main): don't accept width/height
        (dump): override width/height for SVG/W3C
        * Scripts/run-webkit-tests: don't pass width/height

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Fri, 30 Dec 2005 06:46:57 +0000 (06:46 +0000)]
LayoutTests:

        Reviewed and refined by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=3579
          In-place style-switching is leaving junk behind, messing up styles

        * fast/css/margin-top-bottom-dynamic-expected.checksum: Added.
        * fast/css/margin-top-bottom-dynamic-expected.png: Added.
        * fast/css/margin-top-bottom-dynamic-expected.txt: Added.
        * fast/css/margin-top-bottom-dynamic.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3579
          In-place style-switching is leaving junk behind, messing up styles

        * khtml/rendering/render_block.h: (khtml::RenderBlock::initMaxMarginValues):
        Set all margin values in all cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: none
eseidel [Fri, 30 Dec 2005 06:43:09 +0000 (06:43 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: No review, only removing dead code.
        * DumpKCanvasTree/DumpKCanvasTree.m: Removed.
        * DumpKCanvasTree/DumpKCanvasTree.xcodeproj/project.pbxproj: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6155
eseidel [Fri, 30 Dec 2005 06:38:53 +0000 (06:38 +0000)]
Bug #: 6155
Submitted by: eseidel
Reviewed by: darin
        DumpRenderTree should set a consistent color profile while running
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6155

        Creates consistent colormatched renderings on every test machine
        using the only way possible with Tiger APIs: by setting the
        system color profile on the test machine for the duration of the
        tests.  This will (unfortunately) cause colors to change while
        running DumpRenderTree.  This can also cause "permanent" color
        changes to occur if DRT is to crash (SIGSEGV, etc.) while running.
        This is far from ideal, but it's be best way we've found to deal
        with the issue for now.

        * DumpRenderTree/DumpRenderTree.m:
        (restoreColorSpace):
        (setDefaultColorProfileToRGB):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6290
eseidel [Fri, 30 Dec 2005 05:51:39 +0000 (05:51 +0000)]
Bug #: 6290
Submitted by: eseidel
Reviewed by: mjs
        XML documents with "html" in dtd name use XHTML entities when they shouldn't
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6290

        * fast/parser/xhtml-alternate-entities-expected.txt: Added.
        * fast/parser/xhtml-alternate-entities.xml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6290
eseidel [Fri, 30 Dec 2005 05:43:23 +0000 (05:43 +0000)]
Bug #: 6290
Submitted by: eseidel
Reviewed by: mjs
        XML documents with "html" in dtd name use XHTML entities when they shouldn't
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6290

        * khtml/xml/xml_tokenizer.cpp:
        (khtml::externalSubsetHandler): check for exact xhtml types

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6295
eseidel [Fri, 30 Dec 2005 05:40:07 +0000 (05:40 +0000)]
Bug #: 6295
Submitted by: eseidel
Reviewed by: mjs
        Close leak in CollectionInfo due to HashMap migration
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6295

        * khtml/html/html_miscimpl.cpp:
        (DOM::HTMLCollectionImpl::CollectionInfo::~CollectionInfo):
        * khtml/html/html_miscimpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6101
eseidel [Fri, 30 Dec 2005 05:33:17 +0000 (05:33 +0000)]
Bug #: 6101
Submitted by: eseidel
Reviewed by: mjs
        Leaks in XSLTProcessorImpl due to early exit in failure case
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6101

        * khtml/xsl/xslt_processorimpl.cpp:
        (DOM::xmlDocPtrFromNode): add "shouldDelete" argument
        (DOM::XSLTProcessorImpl::transformToString): delete new'd xmlDoc

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
mjs [Fri, 30 Dec 2005 05:11:47 +0000 (05:11 +0000)]
WebCore:

        Reviewed by Eric.

        - finished frame traversal cleanup
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6293

        * kwq/WebCoreBridge.h: Removed childFrames method from WebCoreBridge protocol
since it is not actually used.

WebKit:

        Reviewed by Eric.

        - finished frame traversal cleanup
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6293

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge childFrames]): Removed (this was unused)
        * WebView.subproj/WebFrame.m:
        (-[WebFrame _removeChild::]): Moved to FrameTraversal category.
        (-[WebFrame _childFrameCount]): New frame traversal method to avoid
getting the count from the array directly.
        (-[WebFrame _appendChild:]): Factored out the parts of addChild: that
seem directly relevant to adding a child.
        (-[WebFrame _removeChild:]): Moved to FrameTraversal category.
        (-[WebFrame _detachChildren]): Don't deallocate children array because
there's no particular need to.
        (-[WebFrame _setDataSource:]): make the assert use _childFrameCount
        (-[WebFrame _opened]):
        (-[WebFrame _checkLoadComplete]): Instead of checking all frames starting
from the main frame, check this frame and all ancestors. If a resource
for a frame completes, that con only possibly finish loading for that
frame and its ancestors, not any other frame in the tree.
(-[WebFrame _recursiveCheckLoadComplete]): Removed, no longer needed.
        (-[WebFrame _childFramesMatchItem:]): Get child frame count in the new
approved way.
        (-[WebFrame _internalChildFrames]): removed
(-[WebFrame _addChild:]): Use _appendChild: for most of the work.
        (-[WebFrame _generateFrameName]): Get child frame count in the new
approved way.
        (-[WebFrame _stopLoadingSubframes]): Use new frame traversal mechanisms,
upon further consideration there's no need to copy part of the frame tree here.
        (-[WebFrame findFrameNamed:]): Remove extra braces.
        (-[WebFrame childFrames]): Make a new array using the frame traversal methods.
        * WebView.subproj/WebFramePrivate.h: Remove some methods.
        * WebView.subproj/WebMainResourceLoader.m:
        (-[WebMainResourceLoader didReceiveResponse:]): Do _checkLoadComplete on the current
frame not the main frame (before there was no difference and now the new version is
what is desired).
        * WebView.subproj/WebView.m:
        (-[WebView _finishedLoadingResourceFromDataSource:]): Remove stray space
        (-[WebView _mainReceivedBytesSoFar:fromDataSource:complete:]): Remove stray spaces
and update FIXME comment.
        (-[WebView _receivedError:fromDataSource:]): Remove stray space

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6230
eseidel [Fri, 30 Dec 2005 04:11:49 +0000 (04:11 +0000)]
Bug #: 6230
Submitted by: eseidel
Reviewed by: build fix only.
        File accidentally omitted from previous commit.

        Remove QDict from khtml/html
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6230

        * khtml/ecma/kjs_html.cpp:
        (KJS::KJS::HTMLCollection::getNamedItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6230
eseidel [Fri, 30 Dec 2005 03:33:54 +0000 (03:33 +0000)]
Bug #: 6230
Submitted by: eseidel
Reviewed by: mjs
        Remove QDict from khtml/html
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6230
        Uses HashMap instead.

        * khtml/html/html_miscimpl.cpp:
        (DOM::HTMLCollectionImpl::CollectionInfo::CollectionInfo):
        (DOM::HTMLCollectionImpl::CollectionInfo::reset):
        (DOM::HTMLCollectionImpl::namedItem):
        (DOM::HTMLCollectionImpl::updateNameCache):
        (DOM::HTMLCollectionImpl::namedItems):
        (DOM::HTMLCollectionImpl::nextNamedItem):
        (DOM::HTMLFormCollectionImpl::nextNamedItemInternal):
        (DOM::HTMLFormCollectionImpl::updateNameCache):
        * khtml/html/html_miscimpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6228
eseidel [Fri, 30 Dec 2005 03:27:21 +0000 (03:27 +0000)]
Bug #: 6228
Submitted by: eseidel
Reviewed by: mjs
        DOMString/DOMStringImpl/AtomicString need enhancements before replacing QString
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6228
        Added find(), contains(), startsWith() and endsWith() to DOMString
        Uses the above functions throughout the code.
        Small performance boost.

        * khtml/css/css_base.cpp:
        (CSSSelector::print):
        * khtml/css/css_ruleimpl.cpp:
        (DOM::CSSImportRuleImpl::init):
        * khtml/css/css_valueimpl.cpp:
        (DOM::CSSStyleDeclarationImpl::setProperty):
        * khtml/css/cssparser.cpp:
        (CSSParser::parseValue):
        (CSSParser::parseDeclaration):
        (CSSParser::parseContent):
        * khtml/css/cssstyleselector.cpp:
        (khtml::CSSStyleSelector::CSSStyleSelector):
        (khtml::CSSStyleSelector::setEncodedURL):
        (khtml::parseUASheet):
        (khtml::cleanpath):
        (khtml::CSSStyleSelector::checkSelector):
        (khtml::CSSStyleSelector::checkOneSelector):
        (khtml::CSSRuleSet::addRulesFromSheet):
        (khtml::CSSStyleSelector::applyProperty):
        * khtml/dom/dom_string.cpp:
        * khtml/dom/dom_string.h:
        (DOM::DOMString::contains):
        (DOM::DOMString::find):
        (DOM::DOMString::startsWith):
        (DOM::DOMString::endsWith):
        * khtml/html/html_formimpl.cpp:
        (DOM::HTMLFormElementImpl::parseEnctype):
        * khtml/khtml_part.cpp:
        (KHTMLPart::requestFrame):
        (KHTMLPart::submitForm):
        * khtml/misc/decoder.cpp:
        (Decoder::decode):
        * khtml/xml/dom_atomicstring.h:
        (DOM::AtomicString::length):
        (DOM::AtomicString::operator []):
        (DOM::AtomicString::contains):
        (DOM::AtomicString::find):
        (DOM::AtomicString::startsWith):
        (DOM::AtomicString::endsWith):
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::processHttpEquiv):
        * khtml/xml/dom_stringimpl.cpp:
        (DOM::equal):
        (DOM::equalCaseInsensitive):
        (DOM::DOMStringImpl::find):
        (DOM::DOMStringImpl::endsWith):
        * khtml/xml/dom_stringimpl.h:
        (DOM::DOMStringImpl::startsWith):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6157
eseidel [Fri, 30 Dec 2005 03:23:52 +0000 (03:23 +0000)]
Bug #: 6157
Submitted by: rob buis
Reviewed by: eseidel
        WebCore+SVG has some problems with rounded rectangles
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6157

        * ksvg2/svg/SVGRectElementImpl.cpp:
        (SVGRectElementImpl::toPathData): fixed round rect calculations

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 4301
eseidel [Fri, 30 Dec 2005 02:42:46 +0000 (02:42 +0000)]
Bug #: 4301
Submitted by: mark rowe
Reviewed by: eseidel
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4301
        Support HTML entities on pages parsed as XHTML

        * fast/parser/entities-in-xhtml-expected.txt: Added.
        * fast/parser/entities-in-xhtml.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Updated test results for the last few JavaScriptCore patches
ggaren [Fri, 30 Dec 2005 00:43:11 +0000 (00:43 +0000)]
    Updated test results for the last few JavaScriptCore patches
        I checked in.

        * ChangeLog:
        * fast/js/array-float-delete-expected.txt: Added.
        * fast/js/kde/Date-expected.txt:
        * fast/js/kde/Number-expected.txt:
        * fast/js/kde/StringObject-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Fri, 30 Dec 2005 00:37:53 +0000 (00:37 +0000)]
    Reviewed by Darin.

- abstract frame traversal in WebFrame more
http://bugzilla.opendarwin.org/show_bug.cgi?id=6283

Rewrote most of the frame traversal code in WebFrame to use DOM-style
first/last/next/previous methods, to abstract access better in preparation
for moving it down.

As an added bonus, many formerly recursive methods are now iterative.

        * WebKit.xcodeproj/project.pbxproj: Use gnu99 dialect of C, so that
variables can be declared in for loop initializers.

- added new frame traversal methods, to avoid dealing with the children array
directly:

        * WebView.subproj/WebFrame.m:
        (-[WebFrame _firstChildFrame]): New method.
        (-[WebFrame _lastChildFrame]): New method.
        (-[WebFrame _previousSiblingFrame]): New method.
        (-[WebFrame _nextSiblingFrame]): New method.
        (-[WebFrame _traverseNextFrameStayWithin:]): Like traverseNextNode() in the DOM;
uses some of the previous.

- apply the new methods

        (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): Rewrite loop
to use new traversal methods.
        (-[WebFrame _immediateChildFrameNamed:]): ditto, also added FIXME
        (-[WebFrame _setName:]): Improved comment, removed gratuitous brace
        (-[WebFrame _isDescendantOfFrame:]): Rewrote to chase parent pointers instead
of looking in child arrays (duh)
        (-[WebFrame _detachChildren]): Rewrite loop to use new traversal methods,
still walk backwards for now.
        (-[WebFrame _closeOldDataSources]): Rewrite using new traversal methods.
        (-[WebFrame _childFramesMatchItem:]): ditto
        (-[WebFrame _defersCallbacksChanged]): ditto
        (-[WebFrame _viewWillMoveToHostWindow:]): ditto
        (-[WebFrame _viewDidMoveToHostWindow]): ditto
        (-[WebFrame _addChild:]): don't use childFrames method
        (-[WebFrame _removeChild:]): Clear out the sibling pointers after unlinking from the list,
not obvious if anything needs this but it seems like the right thing to do.
        (-[WebFrame _generateFrameName]): don't bother to nil-check children array, since
calling count on nil still gives 0.
        (-[WebFrame _saveDocumentAndScrollState]): Rewrite to use frame traversal methods
        (-[WebFrame _deepLastChildFrame]): renamed from _lastChildFrame, rewrite to use child
traversal methods.
        (-[WebFrame _nextFrameWithWrap:]): Use new frame traversal stuff (mostly just
a thin wrapper on _traverseNextFrameStayWithin:
        (-[WebFrame _previousFrameWithWrap:]): Use new traversal functions
        (-[WebFrame _numPendingOrLoadingRequests:]): Rewrite loop with new tracrsal functions
        (-[WebFrame _reloadForPluginChanges]): ditto
        (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): ditto
        (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): ditto
        (-[WebFrame _documentViews]): ditto
        (-[WebFrame _updateDrawsBackground]): ditto
        (-[WebFrame _unmarkAllMisspellings]): ditto
        (-[WebFrame _atMostOneFrameHasSelection]): ditto
        (-[WebFrame _findFrameWithSelection]): ditto
        (-[WebFrame _stopLoadingSubframes]): ditto
        (-[WebFrame _subframeIsLoading]): ditto
        (-[WebFrame _descendantFrameNamed:sourceFrame:]): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 4301
eseidel [Thu, 29 Dec 2005 23:49:04 +0000 (23:49 +0000)]
Bug #: 4301
Submitted by: mark rowe
Reviewed by: eseidel, ggaren, darin
        - http://bugzilla.opendarwin.org/show_bug.cgi?id=4301
        Support HTML entities on pages parsed as XHTML

        Added layout tests:
        * fast/parser/entities-in-xhtml.xhtml

        * khtml/xml/xml_tokenizer.cpp:
        (khtml::XMLTokenizer::setIsXHTMLDocument): Track whether the XML document is XHTML.
        (khtml::XMLTokenizer::isXHTMLDocument): Ditto.
        (khtml::externalSubsetHandler): Ditto.
        (khtml::XMLTokenizer::finish): Ditto.
        (khtml::getXHTMLEntity): Look up the HTML entity.
        (khtml::getEntityHandler): Look up the HTML entity if this is an XHTML document.
        * khtml/html/kentities.h: Added.
        * khtml/html/kentities.gperf: changed entity to Entity

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * WebView.subproj/WebFrameView.m: (-[WebFrameViewPrivate dealloc]):
darin [Thu, 29 Dec 2005 22:02:39 +0000 (22:02 +0000)]
    * WebView.subproj/WebFrameView.m: (-[WebFrameViewPrivate dealloc]):
        Removed unused "draggingTypes" instance variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Patch by Maks Orlovich, reviewed and landed by me.
ggaren [Thu, 29 Dec 2005 11:51:04 +0000 (11:51 +0000)]
    Patch by Maks Orlovich, reviewed and landed by me.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=6267
        Fix Number.prototype.toFixed/toExponential(undefined)

        * kjs/number_object.cpp:
        (NumberProtoFunc::callAsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Patch by Maks Orlovich, Reviewed and landed by me.
ggaren [Thu, 29 Dec 2005 11:45:32 +0000 (11:45 +0000)]
    Patch by Maks Orlovich, Reviewed and landed by me.

        - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6266
        Minor object naming updates (to match Mozilla, KJS)

        * kjs/number_object.cpp:
        * kjs/regexp_object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Patch by Maks Orlovich, reviewed by mjs.
ggaren [Thu, 29 Dec 2005 11:38:57 +0000 (11:38 +0000)]
    Patch by Maks Orlovich, reviewed by mjs.

        This has 2 very minor fixes, covered by KJS testsuite:
        1. Enumerates string indices in property list (with the same bug as array
           object has in corresponding code). This is a mozilla emulation thing.
        2. Permits properties with integer names in prototypes to be found

        * kjs/string_object.cpp:
        (StringInstance::getOwnPropertySlot):
        (StringInstanceImp::propList):
        * kjs/string_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoforgot to remove the redundant (float) cast, as specified by reviewer
ggaren [Thu, 29 Dec 2005 11:30:00 +0000 (11:30 +0000)]
forgot to remove the redundant (float) cast, as specified by reviewer

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
ggaren [Thu, 29 Dec 2005 11:27:07 +0000 (11:27 +0000)]
WebCore:

        Reviewed by darin

        - WebCore part of fix for
          http://bugzilla.opendarwin.org/show_bug.cgi?id=3922
          Variable word/letter spacing and full justification not supported for
          ATSUI-rendered text

        * khtml/rendering/font.h:
        (khtml::Font::checkSelectionPoint): Make sure the complete run, used for
        counting spaces and determining padding per space does not go beyond the
        text box.

WebKit:

        Reviewed by darin

        Test: fast/text/atsui-spacing-features.html

        - WebKit part of fix for
          http://bugzilla.opendarwin.org/show_bug.cgi?id=3922
          Variable word/letter spacing and full justification not supported for
          ATSUI-rendered text

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (overrideLayoutOperation): Add letter- and word-spacing and padding for
        justification.
        (createATSULayoutParameters): Compute padding per space.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by mjs.
ggaren [Thu, 29 Dec 2005 11:16:11 +0000 (11:16 +0000)]
    Reviewed by mjs.

        - Fixed <rdar://problem/4364705> run-javascriptcore-tests crashes in
        KJS::BlockNode::deref
        AKA
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6233
        Reproducible stack-overflow crash in ~RefPtr<T> due to RefPtr<T> use in
        linked lists

        This patch does four things:
        (1) Standardizes all our linked list nodes to use "next" as their next
        pointers.
        (2) Creates the ListRefPtr<T> class, a subclass of RefPtr<T> specialized
        to iteratively deref "next" pointers.
        (3) Standardizes our linked list nodes to use ListRefPtr<T> and
        implement the releaseNext() function used by ~ListRefPtr<T>().
        (4) Adds to RefPtr<T> the release() method used by releaseNext().

        - Modified existing mozilla test to ensure it would make deployment
        builds crash as well.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/nodes.cpp:
        (ElementNode::evaluate):
        (PropertyListNode::evaluate):
        (ArgumentListNode::evaluateList):
        (StatListNode::StatListNode):
        (StatListNode::execute):
        (StatListNode::processVarDecls):
        (VarDeclListNode::evaluate):
        (VarDeclListNode::processVarDecls):
        (VarStatementNode::execute):
        (VarStatementNode::processVarDecls):
        (BlockNode::BlockNode):
        (CaseClauseNode::evalStatements):
        (CaseClauseNode::processVarDecls):
        (ClauseListNode::processVarDecls):
        (CaseBlockNode::CaseBlockNode):
        (CaseBlockNode::evalBlock):
        (SourceElementsNode::SourceElementsNode):
        (SourceElementsNode::execute):
        (SourceElementsNode::processFuncDecl):
        (SourceElementsNode::processVarDecls):
        * kjs/nodes.h:
        (KJS::ElementNode::ElementNode):
        (KJS::ElementNode::releaseNext):
        (KJS::ArrayNode::ArrayNode):
        (KJS::PropertyListNode::PropertyListNode):
        (KJS::PropertyListNode::releaseNext):
        (KJS::ObjectLiteralNode::ObjectLiteralNode):
        (KJS::ArgumentListNode::ArgumentListNode):
        (KJS::ArgumentListNode::releaseNext):
        (KJS::ArgumentsNode::ArgumentsNode):
        (KJS::StatListNode::releaseNext):
        (KJS::VarDeclListNode::VarDeclListNode):
        (KJS::VarDeclListNode::releaseNext):
        (KJS::VarStatementNode::VarStatementNode):
        (KJS::ForNode::ForNode):
        (KJS::CaseClauseNode::CaseClauseNode):
        (KJS::ClauseListNode::ClauseListNode):
        (KJS::ClauseListNode::getClause):
        (KJS::ClauseListNode::getNext):
        (KJS::ClauseListNode::releaseNext):
        (KJS::ParameterNode::ParameterNode):
        (KJS::ParameterNode::releaseNext):
        (KJS::SourceElementsNode::releaseNext):
        * kjs/nodes2string.cpp:
        (ElementNode::streamTo):
        (PropertyListNode::streamTo):
        (ArgumentListNode::streamTo):
        (StatListNode::streamTo):
        (VarDeclListNode::streamTo):
        (VarStatementNode::streamTo):
        (CaseClauseNode::streamTo):
        (ClauseListNode::streamTo):
        (CaseBlockNode::streamTo):
        (SourceElementsNode::streamTo):
        * kxmlcore/ListRefPtr.h: Added.
        (KXMLCore::ListRefPtr::ListRefPtr):
        (KXMLCore::ListRefPtr::~ListRefPtr):
        (KXMLCore::ListRefPtr::operator=):
        * kxmlcore/RefPtr.h:
        (KXMLCore::RefPtr::release):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by mjs.
ggaren [Thu, 29 Dec 2005 11:02:07 +0000 (11:02 +0000)]
    Reviewed by mjs.

        - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4026
        Math.random() not seeded.

        Added call to sranddev() -- it executes the first time a process
        calls Math.random().

        * kjs/math_object.cpp:
        (MathFuncImp::callAsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by mjs.
ggaren [Thu, 29 Dec 2005 10:36:23 +0000 (10:36 +0000)]
    Reviewed by mjs.

        - Fixed <rdar://problem/4325722> crash in KJS::Bindings::dispatchJNICall
        due to liveconnect call from Java after Java PlugInView has been
        deallocated @ www.binarybet.com
        AKA
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5518

        We had code that checked for whether a call came from a live PlugIn,
        but the live PlugIn dictionary would only get cleared when the
        KWQKHTMLPart was destroyed. Since a single part can service multiple
        loads, the dictionary needs to clear after each one.

        No layout test because this bug is difficult to reproduce.

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::~KWQKHTMLPart):
        (1) Unrelated cleanup: Removed manual clearing of form values,
        replaced with call to clearRecordedFormValues().
        (2) Replaced PlugIn dictionary cleanup code and view deref call
        with call to setView(0), since much of this code was duplicated in
        setView, and the stuff that wasn't duplicated needed to be.

        (KWQKHTMLPart::setView):
        (1) Removed some unnecessary braces.
        (2) Added PlugIn dictionary cleanup code.
        (3) New behavior: clear _bindingRoot and _windowScriptObject after
        each view change. This is needed because after a call to
        clenaupPluginRootObjects(), both objects have stale references.
        (4) Changed a NULL to a 0.

        (KWQKHTMLPart::cleanupPluginRootObjects): Removed extra space.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by darin.
ggaren [Thu, 29 Dec 2005 10:11:23 +0000 (10:11 +0000)]
    Reviewed by darin.

        - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6265
        Name change regression: Java doesn't know what JavaJSObject is

        Changed strings passed to Java back to original "JSObject".

        * bindings/jni/jni_jsobject.cpp:
        (JavaJSObject::convertValueToJObject):
        (JavaJSObject::convertJObjectToValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoImprovements to the Visual Studio project files. Have dftables generating chartables...
hyatt [Thu, 29 Dec 2005 08:58:50 +0000 (08:58 +0000)]
Improvements to the Visual Studio project files.  Have dftables generating chartables.c and have set up separate intermediate/output/derivedsources dirs to match the Mac XCode structure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2005-12-28 Anders Carlsson <andersca@mac.com>
andersca [Thu, 29 Dec 2005 08:22:09 +0000 (08:22 +0000)]
2005-12-28  Anders Carlsson  <andersca@mac.com>

        Reviewed by Maciej.

        - Add test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6268
        Add undetectable document.all

        * fast/dom/undetectable-document-all-expected.txt: Added.
        * fast/dom/undetectable-document-all.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2005-12-28 Anders Carlsson <andersca@mac.com>
andersca [Thu, 29 Dec 2005 08:20:37 +0000 (08:20 +0000)]
2005-12-28  Anders Carlsson  <andersca@mac.com>

        Reviewed by Maciej.

        - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6268
        Add undetectable document.all

        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLDocument::getValueProperty):
        If "all" has been set to a new value, return the new value.

        (KJS::KJS::HTMLDocument::putValueProperty):
        Allow "all" to be set to a new value.

        (KJS::HTMLAllCollection::toPrimitive):
        Return jsNull() if the preferred type is NullType.

        (KJS::getAllHTMLCollection):
        * khtml/ecma/kjs_html.h:
        (KJS::HTMLAllCollection::HTMLAllCollection):
        Add HTMLAllCollection, a subclass of HTMLCollection which should
        be undetectable.

        (KJS::HTMLAllCollection::toBoolean):
        Return false.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2005-12-28 Anders Carlsson <andersca@mac.com>
andersca [Thu, 29 Dec 2005 08:18:40 +0000 (08:18 +0000)]
2005-12-28  Anders Carlsson  <andersca@mac.com>

        Reviewed by Maciej.

        - The JSC part of http://bugzilla.opendarwin.org/show_bug.cgi?id=6268
        Add undetectable document.all

        * kjs/operations.cpp:
        (KJS::equal):
        When comparing an object with null or undefined, call toPrimitive with
        NullType as the preferred type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric, landed by ap.
ap [Wed, 28 Dec 2005 19:02:01 +0000 (19:02 +0000)]
    Reviewed by Eric, landed by ap.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6214
          text-indent in RTL block does the opposite

        * fast/block/basic/text-indent-rtl-expected.checksum: Added.
        * fast/block/basic/text-indent-rtl-expected.png: Added.
        * fast/block/basic/text-indent-rtl-expected.txt: Added.
        * fast/block/basic/text-indent-rtl.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric, landed by ap.
ap [Wed, 28 Dec 2005 18:59:51 +0000 (18:59 +0000)]
    Reviewed by Eric, landed by ap.

        Test: fast/block/basic/text-indent-rtl.html

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6214
          text-indent in RTL block does the opposite

        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::rightRelOffset): Subtract the indent instead of adding it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin, landed by ap.
ap [Wed, 28 Dec 2005 18:48:39 +0000 (18:48 +0000)]
    Reviewed by Darin, landed by ap.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5812
          Generate load events for <script> elements

        * fast/dom/HTMLScriptElement/resources/script-load.js: Added.
        * fast/dom/HTMLScriptElement/script-load-events-expected.txt: Added.
        * fast/dom/HTMLScriptElement/script-load-events.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin, landed by ap.
ap [Wed, 28 Dec 2005 18:46:24 +0000 (18:46 +0000)]
    Reviewed by Darin, landed by ap.

        Test: fast/dom/HTMLScriptElement/script-load-events.html

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5812
          Generate load events for <script> elements

        * khtml/html/html_headimpl.cpp:
        (HTMLScriptElementImpl::parseMappedAttribute): Parse the onload and onerror attributes.
        (HTMLScriptElementImpl::closeRenderer): Call base class's implementation.
        (HTMLScriptElementImpl::notifyFinished): Dispatch load and error events.
        * khtml/html/htmlparser.h:
        * khtml/html/htmlparser.cpp:
        (HTMLParser::parseToken): Return the node that was inserted.
        * khtml/html/htmltokenizer.h: Added scriptNode, a RefPtr to the node corresponding
        to the current load request.
        * khtml/html/htmltokenizer.cpp:
        (HTMLTokenizer::scriptHandler): Reset scriptNode if a load request was not made.
        (HTMLTokenizer::parseTag): Set scriptNode to the node created from the script tag.
        (HTMLTokenizer::processToken): Return the node that was inserted.
        (HTMLTokenizer::notifyFinished): Reset scriptNode and dispatch load and error events.
        * khtml/misc/loader.h:
        (CachedScript::errorOccurred): Added.
        * khtml/misc/loader.cpp:
        (CachedScript::CachedScript):
        (CachedScript::error):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
ap [Wed, 28 Dec 2005 18:23:23 +0000 (18:23 +0000)]
    Reviewed by Maciej.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6246
          TextIterator::rangeFromLocationAndLength() returns nil range for an
          empty document

        * editing/input/range-for-empty-document-expected.txt: Added.
        * editing/input/range-for-empty-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
ap [Wed, 28 Dec 2005 18:21:50 +0000 (18:21 +0000)]
    Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6246
          TextIterator::rangeFromLocationAndLength() returns nil range for an
          empty document

        Test: editing/input/range-for-empty-document.html

        * khtml/editing/visible_text.cpp:
        (khtml::TextIterator::rangeFromLocationAndLength):
        Handle the case of an empty document and (0, 0) requested range.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed and landed by Geoff.
ggaren [Wed, 28 Dec 2005 18:18:34 +0000 (18:18 +0000)]
    Reviewed and landed by Geoff.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6269
        ToT memory corruption

        * khtml/rendering/render_text.cpp:
        (khtml::RenderText::setText):
        Remove deref().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Rubber stamped by Eric.
mjs [Wed, 28 Dec 2005 03:47:48 +0000 (03:47 +0000)]
    Rubber stamped by Eric.

- proper length for Array concat function is 1, not 0; also add test
for String concat.

        * fast/js/kde/function_length-expected.txt:
        * fast/js/kde/resources/function_length.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2005-12-27 Anders Carlsson <andersca@mac.com>
andersca [Tue, 27 Dec 2005 20:06:40 +0000 (20:06 +0000)]
2005-12-27  Anders Carlsson  <andersca@mac.com>

        Reviewed by Darin.

        - Update tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6250
        Implement Array.map and Array.filter

        * fast/js/array-every-expected.txt:
        * fast/js/array-every.html:
        * fast/js/array-foreach-expected.txt:
        * fast/js/array-foreach.html:
        Modify these tests since Array.every and Array.foreach now follow Mozilla
        and treat arrays as sparse, not visiting non-existing properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2005-12-27 Anders Carlsson <andersca@mac.com>
andersca [Tue, 27 Dec 2005 20:02:01 +0000 (20:02 +0000)]
2005-12-27  Anders Carlsson  <andersca@mac.com>

        Reviewed by Darin.

        * kjs/array_object.cpp:
        (ArrayProtoFunc::callAsFunction):
        Implement filter and map. Also, make the existing
        array iteration functions not invoke the callback for
        non-existing properties, just as Mozilla does now.

        * kjs/array_object.h:
        (KJS::ArrayProtoFunc::):
        Add filter and map.

        * tests/mozilla/expected.html:
        Update, two 1.6 tests now pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Hyatt, landed by Darin.
darin [Tue, 27 Dec 2005 19:13:40 +0000 (19:13 +0000)]
    Reviewed by Hyatt, landed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5699
          REGRESSION: incomplete repaint

        * khtml/rendering/render_object.cpp:
        (RenderObject::repaintAfterLayoutIfNeeded): Return false if only the
        size changed and not everything was repainted.
        * manual-tests/bugzilla-5699.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Tue, 27 Dec 2005 19:06:50 +0000 (19:06 +0000)]
LayoutTests:

        Reviewed by Maciej, landed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4844
        Render "simple" Hebrew using the CG codepath

        * fast/text/international/bidi-AN-after-L-expected.checksum: Updated.
        * fast/text/international/bidi-AN-after-L-expected.png: Updated.
        * fast/text/international/bidi-L2-run-reordering-expected.checksum: Updated.
        * fast/text/international/bidi-L2-run-reordering-expected.png: Updated.
        * fast/text/international/bidi-LDB-2-CSS-expected.checksum: Updated.
        * fast/text/international/bidi-LDB-2-CSS-expected.png: Updated.
        * fast/text/international/bidi-LDB-2-HTML-expected.checksum: Updated.
        * fast/text/international/bidi-LDB-2-HTML-expected.png: Updated.
        * fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Updated.
        * fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Updated.
        * fast/text/international/bidi-explicit-embedding-expected.checksum: Updated.
        * fast/text/international/bidi-explicit-embedding-expected.png: Updated.
        * fast/text/international/bidi-fallback-font-weight-expected.checksum: Updated.
        * fast/text/international/bidi-fallback-font-weight-expected.png: Updated.
        * fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Updated.
        * fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Updated.
        * fast/text/international/bidi-innertext-expected.checksum: Updated.
        * fast/text/international/bidi-innertext-expected.png: Updated.
        * fast/text/international/bidi-layout-across-linebreak-expected.checksum: Updated.
        * fast/text/international/bidi-layout-across-linebreak-expected.png: Updated.
        * fast/text/international/bidi-override-expected.checksum: Updated.
        * fast/text/international/bidi-override-expected.png: Updated.

WebKit:

        Reviewed by Maciej, landed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4844
        Render "simple" Hebrew using the CG codepath

        * WebCoreSupport.subproj/WebTextRenderer.m: (shouldUseATSU): Exclude Hebrew letters and maqaf.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Tue, 27 Dec 2005 18:39:34 +0000 (18:39 +0000)]
LayoutTests:

        Reviewed by Maciej, landed by Darin.

        - fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=4101>
        CSS Fibonacci spiral using 4 images doesn't render correctly

        * fast/replaced/absolute-image-sizing-expected.checksum: Added.
        * fast/replaced/absolute-image-sizing-expected.png: Added.
        * fast/replaced/absolute-image-sizing-expected.txt: Added.
        * fast/replaced/absolute-image-sizing.html: Added.

WebCore:

        Reviewed by Maciej, landed by Darin.

        - fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=4101>
        CSS Fibonacci spiral using 4 images doesn't render correctly

        Added layout tests:
        * fast/replaced/absolute-image-sizing.html

        * khtml/rendering/render_box.cpp:
        (RenderBox::calcAbsoluteHorizontalValues): Use calcReplacedWidth() instead of intrinsicWidth()
        for replaced elements.
        (RenderBox::calcAbsoluteVerticalValues): Same thing for height.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff and Eric.
darin [Tue, 27 Dec 2005 18:26:16 +0000 (18:26 +0000)]
    Reviewed by Geoff and Eric.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=6198
          use RefPtr a few places in RenderText and related classes

        * khtml/html/htmltokenizer.h: Use RefPtr for some data members in Token.
        Also removed use of bitfields in Token, since there's no need to optimize storage here.
        * khtml/html/htmlparser.cpp:
        (HTMLParser::parseToken): Update for use of RefPtr in Token.
        (HTMLParser::textCreateErrorCheck): Ditto.
        (HTMLParser::commentCreateErrorCheck): Ditto.
        (HTMLParser::handleIsindex): Ditto.
        * khtml/html/htmltokenizer.cpp:
        (khtml::Token::addAttribute): Ditto.
        (khtml::HTMLTokenizer::processToken): Ditto.

        * khtml/rendering/render_text.h: Reduce the number of includes, change
        SOFT_HYPHEN from a macro into a constant. Change originalString function
        to return a PassRefPtr instead of a RefPtr. Make str and m_generatedContentStr
        member be a RefPtr.
        * khtml/rendering/render_text.cpp:
        (khtml::RenderText::previousOffset): Update for use of RefPtr for str.
        (khtml::RenderText::nextOffset): Ditto.
        (khtml::RenderText::RenderText): Ditto.
        (khtml::RenderText::originalString): Change to return PassRefPtr, even though
        it's not necessary at this level (since it's a virtual function).
        (khtml::RenderText::posOfChar): Update for use of RefPtr for str.
        (khtml::RenderText::setText): Ditto.
        (khtml::RenderTextFragment::RenderTextFragment): Ditto.
        (khtml::RenderTextFragment::originalString): Change to return PassRefPtr.

        * khtml/html/html_inlineimpl.cpp: Re-sorted list of includes, added newly-needed ones.
        * kwq/KWQRenderTreeDebug.cpp: Added new include needed since QPtrVector is no longer
        included by render_text.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix suggested by Mitz.
darin [Tue, 27 Dec 2005 18:05:02 +0000 (18:05 +0000)]
    Fix suggested by Mitz.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6240
          REGRESSION: scrollbars in overflows don't work

        * khtml/xml/dom2_eventsimpl.cpp: (DOM::MouseRelatedEventImpl::computePositions):
        Remove the code to compute pageX/Y from clientX/Y, because clientX/Y are not passed
        in correctly (in fact, what's passed in is pageX/Y)! I accidentally included part
        of my fix for clientX/Y in the original patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - updated test results for new JS 1.6 tests
mjs [Tue, 27 Dec 2005 12:56:45 +0000 (12:56 +0000)]
    - updated test results for new JS 1.6 tests

        * tests/mozilla/expected.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2005-12-27 Anders Carlsson <andersca@mac.com>
andersca [Tue, 27 Dec 2005 12:29:57 +0000 (12:29 +0000)]
2005-12-27  Anders Carlsson  <andersca@mac.com>

        Reviewed by Maciej.

        Add Mozilla JS 1.6 tests.

        * tests/mozilla/js1_6/Array/browser.js: Added.
        * tests/mozilla/js1_6/Array/regress-290592.js: Added.
        * tests/mozilla/js1_6/Array/regress-304828.js: Added.
        * tests/mozilla/js1_6/Array/regress-305002.js: Added.
        * tests/mozilla/js1_6/Array/regress-310425-01.js: Added.
        * tests/mozilla/js1_6/Array/regress-310425-02.js: Added.
        * tests/mozilla/js1_6/Array/regress-320887.js: Added.
        * tests/mozilla/js1_6/Array/shell.js: Added.
        * tests/mozilla/js1_6/README: Added.
        * tests/mozilla/js1_6/Regress/browser.js: Added.
        * tests/mozilla/js1_6/Regress/regress-301574.js: Added.
        * tests/mozilla/js1_6/Regress/regress-309242.js: Added.
        * tests/mozilla/js1_6/Regress/regress-311157-01.js: Added.
        * tests/mozilla/js1_6/Regress/regress-311157-02.js: Added.
        * tests/mozilla/js1_6/Regress/regress-314887.js: Added.
        * tests/mozilla/js1_6/Regress/regress-320172.js: Added.
        * tests/mozilla/js1_6/Regress/shell.js: Added.
        * tests/mozilla/js1_6/String/browser.js: Added.
        * tests/mozilla/js1_6/String/regress-306591.js: Added.
        * tests/mozilla/js1_6/String/shell.js: Added.
        * tests/mozilla/js1_6/browser.js: Added.
        * tests/mozilla/js1_6/shell.js: Added.
        * tests/mozilla/js1_6/template.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago No review, just a test harness change.
mjs [Tue, 27 Dec 2005 12:24:33 +0000 (12:24 +0000)]
    No review, just a test harness change.

- avoid bombing out if a shouldBe test case unexpectedly throws an exception

        * fast/js/kde/resources/base.js:

- this lets some of the tests get a bit further, so new results:

        * fast/js/kde/Number-expected.txt:
        * fast/js/kde/RegExp-expected.txt:
        * fast/js/kde/exception_propagation-expected.txt:
        * fast/js/kde/parse-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
mjs [Tue, 27 Dec 2005 12:05:35 +0000 (12:05 +0000)]
LayoutTests:

        Reviewed, tweaked and landed by Maciej.

- test case for 4405: <button> not listed in form collections.
http://bugzilla.opendarwin.org/show_bug.cgi?id=4405

        * fast/forms/button-in-forms-collection-expected.txt: Added.
        * fast/forms/button-in-forms-collection.html: Added.

WebCore:

        Reviewed and landed by Maciej.

- fixed 4405: <button> not listed in form collections.
http://bugzilla.opendarwin.org/show_bug.cgi?id=4405

Test: fast/forms/button-in-forms-collection.html

        * khtml/html/html_formimpl.h:
        (DOM::HTMLButtonElementImpl::isEnumeratable): override to return true

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
mjs [Tue, 27 Dec 2005 11:07:49 +0000 (11:07 +0000)]
JavaScriptCore:

        Reviewed and landed by Maciej.

- fixed 6234: Can delete array index property incorrectly.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6234

        * kjs/array_object.cpp:
        (ArrayInstance::deleteProperty): use toArrayIndex instead of toUInt32 when
looking for array properties.

LayoutTests:

        Reviewed, tweaked and landed by Maciej.

- test case for 6234: Can delete array index property incorrectly.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6234

        * fast/js/array-float-delete.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2005-12-27 Anders Carlsson <andersca@mac.com>
andersca [Tue, 27 Dec 2005 10:35:55 +0000 (10:35 +0000)]
2005-12-27  Anders Carlsson  <andersca@mac.com>

        Reviewed by Maciej.

        * kjs/object.cpp:
        (KJS::JSObject::defineSetter):
        Remove duplicate call to putDirect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin and Geoff.
mjs [Tue, 27 Dec 2005 09:24:14 +0000 (09:24 +0000)]
    Reviewed by Darin and Geoff.

Changes by me and Anders.

- mostly fixed REGRESSION: 5-10% performance regression on JS iBench from getter/setter change
http://bugzilla.opendarwin.org/show_bug.cgi?id=6083

- also fixed some warnings reported by -Winline

        * JavaScriptCorePrefix.h: Move new and delete definitions higher so there
aren't conflicts with use in standard C++ headers
        * kjs/object.cpp:
        (KJS::throwSetterError): Moved this piece of put into a seprate function
to avoid the PIC branch.
        (KJS::JSObject::put): Use hasGetterSetterProperties to avoid expensive stuff
when not needed. Also use GetterSetter properties attribute.
        (KJS::JSObject::deleteProperty): Recompute whether any properties are getter/setter
properties any more, if this one was one.
        (KJS::JSObject::defineGetter): Let the PropertyMap know that it has getter/setter
properties now (and use the new attribute).
        (KJS::JSObject::defineSetter): Ditto.
        (KJS::JSObject::fillGetterPropertySlot): Out-of-line helper for getOwnPropertySlot,
to avoid global variable access in the hot code path.
        * kjs/object.h:
        (KJS::): Added GetterSetter attribute.
        (KJS::JSCell::isObject): Moved lower to be after inline methods it uses.
        (KJS::JSValue::isObject): ditto
        (KJS::JSObject::getOwnPropertySlot): try to avoid impact of getters and setters
as much as possible in the case where they are not being used
        * kjs/property_map.cpp:
        (KJS::PropertyMap::containsGettersOrSetters): New method to help with this
        * kjs/property_map.h:
        (KJS::PropertyMap::hasGetterSetterProperties): Ditto
        (KJS::PropertyMap::setHasGetterSetterProperties): Ditto
        (KJS::PropertyMap::PropertyMap): Added a crazy hack to store the
global "has getter/setter properties" flag in the property map
single entry, to avoid making objects any bigger.
        * kjs/value.h: Moved some things to object.h to make -Winline happier

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoCheck in the beginnings of a VC 2005 project for JSCore dll.
hyatt [Mon, 26 Dec 2005 23:33:31 +0000 (23:33 +0000)]
Check in the beginnings of a VC 2005 project for JSCore dll.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Rubber stamped by Geoff.
mjs [Mon, 26 Dec 2005 23:07:31 +0000 (23:07 +0000)]
    Rubber stamped by Geoff.

- land JavaScript tests from the kde version of kjs

        * fast/js/kde/Array-expected.txt: Added.
        * fast/js/kde/Array.html: Added.
        * fast/js/kde/Boolean-expected.txt: Added.
        * fast/js/kde/Boolean.html: Added.
        * fast/js/kde/Date-expected.txt: Added.
        * fast/js/kde/Date.html: Added.
        * fast/js/kde/Error-expected.txt: Added.
        * fast/js/kde/Error.html: Added.
        * fast/js/kde/GlobalObject-expected.txt: Added.
        * fast/js/kde/GlobalObject.html: Added.
        * fast/js/kde/Number-expected.txt: Added.
        * fast/js/kde/Number.html: Added.
        * fast/js/kde/Object-expected.txt: Added.
        * fast/js/kde/Object.html: Added.
        * fast/js/kde/Prototype-expected.txt: Added.
        * fast/js/kde/Prototype.html: Added.
        * fast/js/kde/RegExp-expected.txt: Added.
        * fast/js/kde/RegExp.html: Added.
        * fast/js/kde/StringObject-expected.txt: Added.
        * fast/js/kde/StringObject.html: Added.
        * fast/js/kde/assignments-expected.txt: Added.
        * fast/js/kde/assignments.html: Added.
        * fast/js/kde/cast-expected.txt: Added.
        * fast/js/kde/cast.html: Added.
        * fast/js/kde/comment-1-expected.txt: Added.
        * fast/js/kde/comment-1.html: Added.
        * fast/js/kde/comment-2-expected.txt: Added.
        * fast/js/kde/comment-2.html: Added.
        * fast/js/kde/completion-expected.txt: Added.
        * fast/js/kde/completion.html: Added.
        * fast/js/kde/conditional-expected.txt: Added.
        * fast/js/kde/conditional.html: Added.
        * fast/js/kde/const-expected.txt: Added.
        * fast/js/kde/const.html: Added.
        * fast/js/kde/constructor_length-expected.txt: Added.
        * fast/js/kde/constructor_length.html: Added.
        * fast/js/kde/crash-1-expected.txt: Added.
        * fast/js/kde/crash-1.html: Added.
        * fast/js/kde/crash-2-expected.txt: Added.
        * fast/js/kde/crash-2.html: Added.
        * fast/js/kde/delete-expected.txt: Added.
        * fast/js/kde/delete.html: Added.
        * fast/js/kde/empty-expected.txt: Added.
        * fast/js/kde/empty.html: Added.
        * fast/js/kde/encode_decode_uri-expected.txt: Added.
        * fast/js/kde/encode_decode_uri.html: Added.
        * fast/js/kde/eval-expected.txt: Added.
        * fast/js/kde/eval.html: Added.
        * fast/js/kde/evil-n-expected.txt: Added.
        * fast/js/kde/evil-n.html: Added.
        * fast/js/kde/exception_propagation-expected.txt: Added.
        * fast/js/kde/exception_propagation.html: Added.
        * fast/js/kde/exceptions-expected.txt: Added.
        * fast/js/kde/exceptions.html: Added.
        * fast/js/kde/function-expected.txt: Added.
        * fast/js/kde/function.html: Added.
        * fast/js/kde/function_arguments-expected.txt: Added.
        * fast/js/kde/function_arguments.html: Added.
        * fast/js/kde/function_constructor-expected.txt: Added.
        * fast/js/kde/function_constructor.html: Added.
        * fast/js/kde/function_length-expected.txt: Added.
        * fast/js/kde/function_length.html: Added.
        * fast/js/kde/garbage-n-expected.txt: Added.
        * fast/js/kde/garbage-n.html: Added.
        * fast/js/kde/inbuilt_function_proto-expected.txt: Added.
        * fast/js/kde/inbuilt_function_proto.html: Added.
        * fast/js/kde/inbuilt_function_tostring-expected.txt: Added.
        * fast/js/kde/inbuilt_function_tostring.html: Added.
        * fast/js/kde/iteration-expected.txt: Added.
        * fast/js/kde/iteration.html: Added.
        * fast/js/kde/j-comment-3-expected.txt: Added.
        * fast/js/kde/j-comment-3.html: Added.
        * fast/js/kde/j-comment-4-expected.txt: Added.
        * fast/js/kde/j-comment-4.html: Added.
        * fast/js/kde/literals-expected.txt: Added.
        * fast/js/kde/literals.html: Added.
        * fast/js/kde/math-expected.txt: Added.
        * fast/js/kde/math.html: Added.
        * fast/js/kde/md5-1-expected.txt: Added.
        * fast/js/kde/md5-1.html: Added.
        * fast/js/kde/md5-2-expected.txt: Added.
        * fast/js/kde/md5-2.html: Added.
        * fast/js/kde/object_prototype-expected.txt: Added.
        * fast/js/kde/object_prototype.html: Added.
        * fast/js/kde/object_prototype_tostring-expected.txt: Added.
        * fast/js/kde/object_prototype_tostring.html: Added.
        * fast/js/kde/operators-expected.txt: Added.
        * fast/js/kde/operators.html: Added.
        * fast/js/kde/parse-expected.txt: Added.
        * fast/js/kde/parse.html: Added.
        * fast/js/kde/prototype_length-expected.txt: Added.
        * fast/js/kde/prototype_length.html: Added.
        * fast/js/kde/prototype_proto-expected.txt: Added.
        * fast/js/kde/prototype_proto.html: Added.
        * fast/js/kde/resources/Array.js: Added.
        * fast/js/kde/resources/Boolean.js: Added.
        * fast/js/kde/resources/Date.js: Added.
        * fast/js/kde/resources/Error.js: Added.
        * fast/js/kde/resources/GlobalObject.js: Added.
        * fast/js/kde/resources/KNOWN_FAILURES: Added.
        * fast/js/kde/resources/Number.js: Added.
        * fast/js/kde/resources/Object.js: Added.
        * fast/js/kde/resources/Prototype.js: Added.
        * fast/js/kde/resources/README: Added.
        * fast/js/kde/resources/RegExp.js: Added.
        * fast/js/kde/resources/StringObject.js: Added.
        * fast/js/kde/resources/assignments.js: Added.
        * fast/js/kde/resources/base.js: Added.
        * fast/js/kde/resources/cast.js: Added.
        * fast/js/kde/resources/comment-1.js: Added.
        * fast/js/kde/resources/comment-2.js: Added.
        * fast/js/kde/resources/completion.js: Added.
        * fast/js/kde/resources/conditional.js: Added.
        * fast/js/kde/resources/const.js: Added.
        * fast/js/kde/resources/constructor_length.js: Added.
        * fast/js/kde/resources/crash-1.js: Added.
        * fast/js/kde/resources/crash-2.js: Added.
        * fast/js/kde/resources/delete.js: Added.
        * fast/js/kde/resources/empty.js: Added.
        * fast/js/kde/resources/encode_decode_uri.js: Added.
        * fast/js/kde/resources/eval.js: Added.
        * fast/js/kde/resources/evil-n.js: Added.
        * fast/js/kde/resources/exception_propagation.js: Added.
        * fast/js/kde/resources/exceptions.js: Added.
        * fast/js/kde/resources/function.js: Added.
        * fast/js/kde/resources/function_arguments.js: Added.
        * fast/js/kde/resources/function_constructor.js: Added.
        * fast/js/kde/resources/function_length.js: Added.
        * fast/js/kde/resources/garbage-n.js: Added.
        * fast/js/kde/resources/inbuilt_function_proto.js: Added.
        * fast/js/kde/resources/inbuilt_function_tostring.js: Added.
        * fast/js/kde/resources/iteration.js: Added.
        * fast/js/kde/resources/j-comment-3.js: Added.
        * fast/js/kde/resources/j-comment-4.js: Added.
        * fast/js/kde/resources/literals.js: Added.
        * fast/js/kde/resources/math.js: Added.
        * fast/js/kde/resources/md5-1.js: Added.
        * fast/js/kde/resources/md5-2.js: Added.
        * fast/js/kde/resources/object_prototype.js: Added.
        * fast/js/kde/resources/object_prototype_tostring.js: Added.
        * fast/js/kde/resources/operators.js: Added.
        * fast/js/kde/resources/parse.js: Added.
        * fast/js/kde/resources/prototype_length.js: Added.
        * fast/js/kde/resources/prototype_proto.js: Added.
        * fast/js/kde/resources/scope.js: Added.
        * fast/js/kde/resources/shell.js: Added.
        * fast/js/kde/resources/statements.js: Added.
        * fast/js/kde/resources/string-1-n.js: Added.
        * fast/js/kde/resources/string-2-n.js: Added.
        * fast/js/kde/resources/var_decl_init.js: Added.
        * fast/js/kde/scope-expected.txt: Added.
        * fast/js/kde/scope.html: Added.
        * fast/js/kde/statements-expected.txt: Added.
        * fast/js/kde/statements.html: Added.
        * fast/js/kde/string-1-n-expected.txt: Added.
        * fast/js/kde/string-1-n.html: Added.
        * fast/js/kde/string-2-n-expected.txt: Added.
        * fast/js/kde/string-2-n.html: Added.
        * fast/js/kde/var_decl_init-expected.txt: Added.
        * fast/js/kde/var_decl_init.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoUndo my accidental commit of Makefile.vc
hyatt [Mon, 26 Dec 2005 22:47:49 +0000 (22:47 +0000)]
Undo my accidental commit of Makefile.vc

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoMake sure assert.h is included by including it in config.h
hyatt [Mon, 26 Dec 2005 22:23:55 +0000 (22:23 +0000)]
Make sure assert.h is included by including it in config.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix win32 bustage. ifdef the swap function for std pairs.
hyatt [Mon, 26 Dec 2005 22:08:52 +0000 (22:08 +0000)]
Fix win32 bustage.  ifdef the swap function for std pairs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
mjs [Mon, 26 Dec 2005 21:46:27 +0000 (21:46 +0000)]
WebCore:

        Reviewed by Geoff.

        - Remove WebFrame's parent frame pointer, instead rely on WebCore's parent concept
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6241

        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge parent]): New method, relies on the KHTMLPart's
parent pointer.

WebKit:

        Reviewed by Geoff

        - Remove WebFrame's parent frame pointer, instead rely on WebCore's parent concept
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6241

        * WebCoreSupport.subproj/WebBridge.h:
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge canTargetLoadInFrame:]): Use bridge parent method instead of needlessly
asking for parent via WebFrame
        (-[WebBridge frameDetached]): Don't call _removeChild on the parent frame any more
because WebFame's _detachFromParent takes care of that now.
        * WebView.subproj/WebFrame.m:
        (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): Fix stray spaces
        (-[WebFrame _detachChildren]): Don't remove children as we loop any more, they
can remove themselves.
        (-[WebFrame _detachFromParent]): Remove self from parent; don't nil out bridge
until we are done with it.
        (-[WebFrame _transitionToCommitted:]): Remove some extra braces.
        (-[WebFrame _goToItem:withLoadType:]): Use parentFrame method in assert instead of parent
field directly.
        (-[WebFrame _addChild:]): Don't poke at parent frame pointer in _private
since it is not there any more.
        (-[WebFrame _removeChild:]): Remove extra braces and don't clear parent pointer
explicitly any more.
        (-[WebFrame _addFramePathToString:]): Get parentFrame from method, not field.
        (-[WebFrame _loadDataSource:withLoadType:formState:]): Remove extra braces.
        (-[WebFrame _nextFrameWithWrap:]): Get parent in the proper way and clean up the
coding style.
        (-[WebFrame _previousFrameWithWrap:]): Ditto.
        (-[WebFrame parentFrame]): Get parent from the bridge.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Hyatt.
mjs [Mon, 26 Dec 2005 08:06:14 +0000 (08:06 +0000)]
    Reviewed by Hyatt.

- fixed REGRESSION: world leak of WebDataSource
http://bugzilla.opendarwin.org/show_bug.cgi?id=6242

        * WebView.subproj/WebDataSource.m:
        (-[WebDataSource _stopLoading]): don't retain self until after
the possible early return.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoChangeLog fixup
ggaren [Sun, 25 Dec 2005 18:28:22 +0000 (18:28 +0000)]
ChangeLog fixup

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff.
mjs [Sun, 25 Dec 2005 11:05:04 +0000 (11:05 +0000)]
    Reviewed by Geoff.

- rearrange some code in WebDataSource so that more of the frame traversal logic
is in WebFrame, in preparation for moving it down to WebBridge.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6239

        * WebView.subproj/WebDataSource.m:
        (-[WebDataSource _archiveWithMarkupString:nodes:]): Assert that the
data source is committed, doesn't make sense to archive otherwise.
        (-[WebDataSource _subframeArchivesWithCurrentState:]): New helper method.
        (-[WebDataSource _archiveWithCurrentState:]): Assert that the data source
is committed. Use the helper.
        (-[WebDataSource _setWebView:]): Comment that we won't tell subframes that
defers callback changed.
        (-[WebDataSource _startLoading]): Remove stray space.
        (-[WebDataSource _stopLoading]): Only handle local _stopLoading business.
Cound on WebFrame to tell subframes to stop loading. Fold in _stopLoadingInternal
and remove _recursiveStopLoading.
        (-[WebDataSource _startLoading:]): Clean up an assert slightly.
        (-[WebDataSource _setTitle:]): Remove stray spaces.
        (-[WebDataSource _defersCallbacksChanged]): Don't call subframes. WebFrame
can do that.
        (-[WebDataSource isLoading]): Move checking of subframes down to WebFrame.
        (-[WebDataSource webArchive]): Return nil if the data source is not yet
committed. It makes no sense to archive a provisional data source since it
has no data yet.
        (-[WebDataSource addSubresource:]): Replace an assert with an early return,
ASSERT is not an appropriate way to flag problems with the argument of a public
method.
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebFrame.m:
        (-[WebFrame _setLoadType:]): Remove stray space.
        (-[WebFrame _checkLoadCompleteForThisFrame]): Stop loading subframes
manually and add a FIXME about confusingness of stopping loading here.
        (-[WebFrame _defersCallbacksChanged]): Tell our subframes.
        (-[WebFrame _addChild:]): Remove stray space.
        (-[WebFrame _stopLoadingSubframes]): New helper method.
        (-[WebFrame _subframeIsLoading]): New helper method, code moved
from WebDataSource.
        (-[WebFrame stopLoading]): Tell subframes to stop loading.
        (-[WebFrame reload]): Remove extra braces.
        * WebView.subproj/WebFrameInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric and Dave Hyatt.
mjs [Sun, 25 Dec 2005 09:22:35 +0000 (09:22 +0000)]
    Reviewed by Eric and Dave Hyatt.

- make even const PassRefPtrs give transfer of ownership semantics
http://bugzilla.opendarwin.org/show_bug.cgi?id=6238

This is a somewhat cheesy change. Having to use PassRefPtr_Ref creates ambiguities
in assignment and copy construction. And this makes life way easier and removes
the need for pass(). It is not really correct, but we pretty much never need a real
const PassRefPtr, and this takes care of things for PassRefPtr temporaries.

        * kjs/identifier.cpp:
        (KJS::Identifier::add): No more need for pass()
        * kjs/property_map.cpp:
        (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): No more need for pass()
        * kjs/ustring.cpp:
        (KJS::UString::Rep::create): Use adoptRef
        (KJS::UString::UString): No more need for pass
        (KJS::UString::append): No more need for pass
        (KJS::UString::substr): No more need for pass
        * kxmlcore/PassRefPtr.h: made m_ptr mutable (ugh)
        (KXMLCore::PassRefPtr::PassRefPtr): Take a const PassRefPtr reference
        (KXMLCore::PassRefPtr::release): Made this a const method (ugh)
        (KXMLCore::PassRefPtr::operator=): clean up appropriately
        (KXMLCore::adoptRef): Added this to use instead of PassRefPtr<T>::adopt, I think
it makes the behavior more clear and it is less verbose.
        (KXMLCore::static_pointer_cast): use adoptRef
        (KXMLCore::const_pointer_cast): use adoptRef
        * kxmlcore/RefPtr.h:
        (KXMLCore::RefPtr::RefPtr): take const PassRefPtr&
        (KXMLCore::PassRefPtr::operator=): take const PassRefPtr&

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: none
eseidel [Sun, 25 Dec 2005 08:11:18 +0000 (08:11 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: mjs
        Unbreak HashTableConstIterator++ by returning const_iterator

        * kxmlcore/HashTable.h:
        (KXMLCore::HashTableConstIterator::operator++): use const_iterator

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: none
eseidel [Sun, 25 Dec 2005 07:52:16 +0000 (07:52 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: mjs
        Un-break HashTable copy constructor.

        * kxmlcore/HashTable.h:
        (KXMLCore::::HashTable): use const_iterator instead

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6236
eseidel [Sun, 25 Dec 2005 05:11:42 +0000 (05:11 +0000)]
Bug #: 6236
Submitted by: mitz
Reviewed by: eseidel
        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6236
          REGRESSION: Crash in DOMString::replace() in ToT (12/24/05)

        * fast/forms/domstring-replace-crash-expected.txt: Added.
        * fast/forms/domstring-replace-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6326
eseidel [Sun, 25 Dec 2005 05:11:05 +0000 (05:11 +0000)]
Bug #: 6326
Submitted by: mitz
Reviewed by: eseidel
        Test: fast/forms/domstring-replace-crash.html

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6236
          REGRESSION: Crash in DOMString::replace() in ToT (12/24/05)

        * khtml/dom/dom_string.h:
        (DOMString::replace): Added check for null m_impl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
mjs [Sat, 24 Dec 2005 22:45:59 +0000 (22:45 +0000)]
    Reviewed by Eric.

        - replaced QPtrDict for Accessors structs with HashMap (also renamed some
stray getSetInfo methods)
http://bugzilla.opendarwin.org/show_bug.cgi?id=6223

        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLElement::accessors):
        (KJS::HTMLElement::getValueProperty):
        (KJS::HTMLElement::putValueProperty):
        * khtml/ecma/kjs_html.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
mjs [Sat, 24 Dec 2005 22:06:57 +0000 (22:06 +0000)]
    Reviewed by Eric.

- fixed "HashMap does not work with const pointer keys or values"
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6222

        * kxmlcore/HashMapPtrSpec.h:
        (KXMLCore::HashMap): In all methods, explicitly cast all pointers
to void * before passing to internal implementation. Use C-style
casts instead of new-style casts, because the real solution would
        require a combo of reinterpret_cast anc const_cast.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by eric.
ggaren [Sat, 24 Dec 2005 22:00:25 +0000 (22:00 +0000)]
    Reviewed by eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=6231

        - Fixed assertion failure in QString::mid caused by my last checkin.
        parseWindowFeatuers() sometimes called QString::mid() with a start
        index past the end of the string but a length of 0. There were two
        problems there. (1) parseWindowString() shouldn't have gotten past the
        end of the string. (2) QString had range truncating code that was
        borked. So I fixed both.

        * khtml/ecma/kjs_window.cpp:
        (KJS::parseWindowFeatures): One of the "past the end" tests was >
        instead of >=.
        * kwq/KWQString.mm:
        (QString::mid): Truncate length *before* deciding whether to return
        early. Also, compare start and data._length before computing
        data._length - start, because the error case we're trying to catch
        will almost certainly cause unsigned overflow.
        * manual-tests/window-open-features-parsing.html: Added trailing ','
        to uber-test to catch this failure, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
ap [Sat, 24 Dec 2005 10:02:23 +0000 (10:02 +0000)]
    Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6221
          REGRESSION: Password field is blank error for secure websites using
          password field (ToT, 12/24/05)

        * khtml/kwq/KWQSlot.mm:
        (KWQSlot::KWQSlot): Changed the parameter type of slotTextChanged to const DOMString &
        * khtml/rendering/render_form.h:
        * khtml/rendering/render_form.cpp:
        (RenderLineEdit::RenderLineEdit): ditto.
        (RenderLineEdit::slotTextChanged): ditto.
        (RenderFileButton::RenderFileButton): ditto.
        (RenderFileButton::slotTextChanged): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11755 268f45cc-cd09-0410-ab3c-d52691b4dbfc