WebKit-https.git
10 years ago2011-03-29 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 29 Mar 2011 18:01:10 +0000 (18:01 +0000)]
2011-03-29  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: extract InspectorPageAgent from InspectorAgent.
        https://bugs.webkit.org/show_bug.cgi?id=57327

        There are page related methods and inspector related methods in InspectorAgent.
        It would be nice to extract page specific methods for future usage the rest of methods in workers debugger.

        * GNUmakefile.am:
        * WebCore.gypi:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.json:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
        (WebCore::InspectorAgent::didClearWindowObjectInWorld):
        (WebCore::InspectorAgent::setFrontend):
        (WebCore::InspectorAgent::disconnectFrontend):
        (WebCore::InspectorAgent::didCommitLoad):
        (WebCore::InspectorAgent::domContentLoadedEventFired):
        * inspector/InspectorAgent.h:
        (WebCore::InspectorAgent::pageAgent):
        * inspector/InspectorPageAgent.cpp: Added.
        (WebCore::InspectorPageAgent::create):
        (WebCore::InspectorPageAgent::InspectorPageAgent):
        (WebCore::InspectorPageAgent::setFrontend):
        (WebCore::InspectorPageAgent::clearFrontend):
        (WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
        (WebCore::InspectorPageAgent::removeAllScriptsToEvaluateOnLoad):
        (WebCore::InspectorPageAgent::reloadPage):
        (WebCore::InspectorPageAgent::openInInspectedWindow):
        (WebCore::InspectorPageAgent::setUserAgentOverride):
        (WebCore::buildObjectForCookie):
        (WebCore::buildArrayForCookies):
        (WebCore::InspectorPageAgent::getCookies):
        (WebCore::InspectorPageAgent::deleteCookie):
        (WebCore::InspectorPageAgent::inspectedURLChanged):
        (WebCore::InspectorPageAgent::restore):
        (WebCore::InspectorPageAgent::didCommitLoad):
        (WebCore::InspectorPageAgent::domContentEventFired):
        (WebCore::InspectorPageAgent::loadEventFired):
        (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
        (WebCore::InspectorPageAgent::applyUserAgentOverride):
        * inspector/InspectorPageAgent.h: Added.
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::connectFrontend):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
        (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
        (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
        (WebCore::InspectorInstrumentation::loadEventFiredImpl):
        (WebCore::InspectorInstrumentation::didCommitLoadImpl):
        (WebCore::InspectorInstrumentation::retrievePageAgent):
        * inspector/InspectorInstrumentation.h:
        * inspector/InstrumentingAgents.h:
        (WebCore::InstrumentingAgents::InstrumentingAgents):
        (WebCore::InstrumentingAgents::inspectorPageAgent):
        (WebCore::InstrumentingAgents::setInspectorPageAgent):
        * inspector/front-end/AuditsPanel.js:
        (WebInspector.AuditsPanel.prototype._reloadResources):
        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView.prototype._deleteCookie):
        (WebInspector.Cookies.getCookiesAsync):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onReload):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.FrameResourceTreeElement.prototype.ondblclick):
        * inspector/front-end/WorkersSidebarPane.js:
        (WebInspector.WorkersSidebarPane.prototype.setInstrumentation):
        * inspector/front-end/inspector.js:
        (WebInspector.openResource):
        (WebInspector.documentKeyDown):

2011-03-29  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: extract InspectorPageAgent from InspectorAgent.
        https://bugs.webkit.org/show_bug.cgi?id=57327

        There are page related methods and inspector related methods in InspectorAgent.
        It would be nice to extract page specific methods for future usage the rest of methods in workers debugger.

        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.reloadPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=57276
hyatt@apple.com [Tue, 29 Mar 2011 17:56:09 +0000 (17:56 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57276

Reviewed by Darin Adler.

Add optimizations to make the vertical placement of boxes much faster. Whenever a box is added
to a line, compare it with the parent box. If we can determine that the child box has the exact
same height and baseline position as the parent box, then we keep a boolean flag set called
descendantsHaveSameLineHeightAndBaseline(). If the box is different for any reason then we clear the
flag up the line box parent chain.

When it comes time to do computeLogicalboxHeights, we can avoid recurring into the children of
a box whose descendants all have the same position. When we do placeBoxesInBlockDirection, we
can do a simplified recursion that just calls adjustBlockDirectionPosition to offset the boxes
without doing anything else.

Because of the quirks mode rule of only shrinking boxes with no immediate text children, we need
to track whether a box has text descendants now as well.  When we avoid doing the recursion
this flag tells us whether the collection of boxes should have an effect on the ascent and descent
of the line in quirks mode.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::hasTextDescendants):
(WebCore::InlineFlowBox::descendantsHaveSameLineHeightAndBaseline):
(WebCore::InlineFlowBox::clearDescendantsHaveSameLineHeightAndBaseline):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::createLineBoxes):
(WebCore::RenderBlock::constructLine):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 29 Mar 2011 17:54:38 +0000 (17:54 +0000)]
2011-03-29  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        [chromium] NRWT should be able to read checksums from png comments
        https://bugs.webkit.org/show_bug.cgi?id=57280

        * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
            from a file.
        * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
        * Scripts/webkitpy/common/system/filesystem_mock.py:
        * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
            if the -checksum.txt file doesn't exist, try looking in the png.
        * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
            2k for a png comment with the checksum
        * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 29 Mar 2011 17:50:25 +0000 (17:50 +0000)]
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing test on GTK.

        * platform/gtk/Skipped: Skip
        fast/loader/onload-willSendRequest-null-for-frame.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 29 Mar 2011 17:44:41 +0000 (17:44 +0000)]
2011-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove a bunch of duplicate code by adding some InlineIterator helper methods
        https://bugs.webkit.org/show_bug.cgi?id=57326

        Once I started adding these it became clear how much crazy duplicated code
        we had due to treating InlineIterator as a struct and accessing its
        members directly.  We can't quite make the members private yet since
        findNextLineBreak still splits out the members.  But this change
        makes the code much cleaner.

        * rendering/InlineIterator.h:
        (WebCore::InlineIterator::clear):
        (WebCore::InlineIterator::moveToStartOf):i
        (WebCore::InlineIterator::moveTo):
        (WebCore::InlineIterator::increment):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::tryHyphenating):
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 29 Mar 2011 17:35:59 +0000 (17:35 +0000)]
2011-03-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Reproducible crash running under libgmalloc, in -[WKView(Internal) removeTrackingRect:] --&gt; objc_assign_ivar_non_gc
        <rdar://problem/9193352>
        https://bugs.webkit.org/show_bug.cgi?id=57358

        -[WKView removeTrackingRect] can be called from below -[WKView dealloc] after we have
        destroyed _data. So, nil out _data after releasing it and nil check it appropriately.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView dealloc]):
        Nil out _data after releasing it.

        (-[WKView removeTrackingRect:]):
        Add early return for nil _data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 29 Mar 2011 17:33:21 +0000 (17:33 +0000)]
2011-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Clean up bidiNext by abstracting repeated code
        https://bugs.webkit.org/show_bug.cgi?id=57335

        I also added a comment to explain what bidiNext is actually doing.
        This whole area of code is confusing but need not be.

        * rendering/InlineIterator.h:
        (WebCore::embedCharFromDirection):
        (WebCore::notifyResolverEnteredObject):
        (WebCore::notifyResolverWillExitObject):
        (WebCore::bidiNext):
        (WebCore::bidiFirst):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Tue, 29 Mar 2011 17:31:24 +0000 (17:31 +0000)]
2011-03-29  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Support external CSS stylesheet freeflow text editing
        https://bugs.webkit.org/show_bug.cgi?id=54397

        In this implementation, Ctrl/Cmd-S commits the current changes into the model.

        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView.createResourceView):
        (WebInspector.CSSSourceFrameDelegateForResourcesPanel):
        (WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype.canEditScriptSource):
        (WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype.editScriptSource):
        (WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype.editScriptSource.handleInfos):
        (WebInspector.CSSSourceFrameDelegateForResourcesPanel.prototype._saveStyleSheet):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype._applyDiffMarkup):
        (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._createTextViewer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 29 Mar 2011 17:22:26 +0000 (17:22 +0000)]
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK baselines for fast/forms/listbox-bidi-align.html,
        added in r82200.

        * platform/gtk/fast/forms/listbox-bidi-align-expected.checksum: Added.
        * platform/gtk/fast/forms/listbox-bidi-align-expected.png: Added.
        * platform/gtk/fast/forms/listbox-bidi-align-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 29 Mar 2011 17:12:30 +0000 (17:12 +0000)]
2011-03-29  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        playbackRate should not be set to defaultPlaybackRate in play()
        https://bugs.webkit.org/show_bug.cgi?id=55943

        Test: media/video-playbackrate.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::playbackRate): No need to ask the media engine for the current
            rate, we already have the current value cached.
        (WebCore::HTMLMediaElement::playInternal): Don't reset the engine's playback rate to
            the default rate.
        (WebCore::HTMLMediaElement::togglePlayState): Do reset the engine's playback rate to
            the default rate before triggering playback.
        * manual-tests/media-default-playback-rate.html: Added.

2011-03-29  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        playbackRate should not be set to defaultPlaybackRate in play()
        https://bugs.webkit.org/show_bug.cgi?id=55943

        * media/event-attributes-expected.txt:
        * media/video-playbackrate-expected.txt: Added.
        * media/video-playbackrate.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 29 Mar 2011 17:12:14 +0000 (17:12 +0000)]
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Rubber-stamped by Gustavo Noronha Silva.

        [GTK] http/tests/uri/username-with-no-hostname.html fails
        https://bugs.webkit.org/show_bug.cgi?id=57325

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (willSendRequestCallback): URI host value check done case-insensitively.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 17:06:03 +0000 (17:06 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        I need to spend some more quality time with the rebaselining tool to
        figure out how to make it update these (or I can update them manually
        when I catch up).

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 16:53:10 +0000 (16:53 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        The text renders slightly differently on Snow Leopard.

        * platform/chromium-mac-snowleopard/fast/forms/listbox-bidi-align-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/fast/forms/listbox-bidi-align-expected.png: Added.
        * platform/chromium-mac-snowleopard/fast/text/drawBidiText-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/fast/text/drawBidiText-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Tue, 29 Mar 2011 16:42:56 +0000 (16:42 +0000)]
2011-03-29  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        Use per-configuration vsprops in JavaScriptCore to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
        https://bugs.webkit.org/show_bug.cgi?id=57350

        Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
        InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
        the IDE. To avoid this, add a separate vsprops file for each project configuration that
        contains the required inherited property sheets.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreDebug.vsprops: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreDebugAll.vsprops: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreDebugCairoCFLite.vsprops: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreRelease.vsprops: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleaseCairoCFLite.vsprops: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleaseLTCG.vsprops: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGO.vsprops: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGOOptimize.vsprops: Added.
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.vcproj/WTF/WTFDebug.vsprops: Added.
        * JavaScriptCore.vcproj/WTF/WTFDebugAll.vsprops: Added.
        * JavaScriptCore.vcproj/WTF/WTFDebugCairoCFLite.vsprops: Added.
        * JavaScriptCore.vcproj/WTF/WTFRelease.vsprops: Added.
        * JavaScriptCore.vcproj/WTF/WTFReleaseCairoCFLite.vsprops: Added.
        * JavaScriptCore.vcproj/WTF/WTFReleaseLTCG.vsprops: Added.
        * JavaScriptCore.vcproj/WTF/WTFReleasePGO.vsprops: Added.
        * JavaScriptCore.vcproj/jsc/jsc.vcproj:
        * JavaScriptCore.vcproj/jsc/jscDebug.vsprops: Added.
        * JavaScriptCore.vcproj/jsc/jscDebugAll.vsprops: Added.
        * JavaScriptCore.vcproj/jsc/jscDebugCairoCFLite.vsprops: Added.
        * JavaScriptCore.vcproj/jsc/jscRelease.vsprops: Added.
        * JavaScriptCore.vcproj/jsc/jscReleaseCairoCFLite.vsprops: Added.
        * JavaScriptCore.vcproj/jsc/jscReleaseLTCG.vsprops: Added.
        * JavaScriptCore.vcproj/jsc/jscReleasePGO.vsprops: Added.
        * JavaScriptCore.vcproj/testapi/testapi.vcproj:
        * JavaScriptCore.vcproj/testapi/testapiDebug.vsprops: Added.
        * JavaScriptCore.vcproj/testapi/testapiDebugAll.vsprops: Added.
        * JavaScriptCore.vcproj/testapi/testapiDebugCairoCFLite.vsprops: Added.
        * JavaScriptCore.vcproj/testapi/testapiRelease.vsprops: Added.
        * JavaScriptCore.vcproj/testapi/testapiReleaseCairoCFLite.vsprops: Added.
        * JavaScriptCore.vcproj/testapi/testapiReleaseLTCG.vsprops: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 29 Mar 2011 16:38:59 +0000 (16:38 +0000)]
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] http/tests/uri/username-with-no-hostname.html fails
        https://bugs.webkit.org/show_bug.cgi?id=57325

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (willSendRequestCallback): Check URI before submitting the request
        to WebCore.

        Reviewed by Martin Robinson.

        [GTK] http/tests/uri/username-with-no-hostname.html fails
        https://bugs.webkit.org/show_bug.cgi?id=57325

        * platform/gtk/Skipped: Unskip fixed test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 16:31:40 +0000 (16:31 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        This test is flaky on Mac too.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate the WebKitSystemInterface libraries for changes in the implementation.
jberlin@webkit.org [Tue, 29 Mar 2011 16:23:54 +0000 (16:23 +0000)]
Update the WebKitSystemInterface libraries for changes in the implementation.

* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 29 Mar 2011 16:21:04 +0000 (16:21 +0000)]
2011-03-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Remove specialization of EventDispatcher with inversion of control.
        https://bugs.webkit.org/show_bug.cgi?id=57285

        Since some events have extra logic around their dispatch, allow them
        to dispatch themselves and specialize the logic. This change only
        converts KeyboardEvent to this model.

        No functional change, covered by existing tests.

        * dom/Event.cpp:
        (WebCore::Event::dispatch): Added.
        * dom/Event.h: Updated decls.
        * dom/EventDispatcher.cpp:
        (WebCore::EventDispatcher::dispatchEvent): Changed to ask event to dispatch
            itself.
        * dom/EventDispatcher.h: Updated decls.
        * dom/KeyboardEvent.cpp:
        (WebCore::KeyboardEvent::dispatch): Added, moving code from EventDispatcher.
        * dom/KeyboardEvent.h: Updated decls.
        * dom/Node.cpp:
        (WebCore::Node::dispatchKeyEvent): Changed to use the new ways.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 29 Mar 2011 16:12:09 +0000 (16:12 +0000)]
2011-03-29  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: InspectorDOMAgent has unnecessary dependency from InspectorAgent.
        https://bugs.webkit.org/show_bug.cgi?id=57329

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::setFrontend):
        * inspector/InspectorAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::inspect):
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::InspectorDOMAgent):
        (WebCore::InspectorDOMAgent::setFrontend):
        (WebCore::InspectorDOMAgent::handleMousePress):
        (WebCore::InspectorDOMAgent::inspect):
        (WebCore::InspectorDOMAgent::focusNode):
        (WebCore::InspectorDOMAgent::highlight):
        (WebCore::InspectorDOMAgent::hideHighlight):
        * inspector/InspectorDOMAgent.h:
        (WebCore::InspectorDOMAgent::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 16:04:40 +0000 (16:04 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Add missing expectation (looks like a pass).

        * platform/chromium/svg: Added.
        * platform/chromium/svg/custom: Added.
        * platform/chromium/svg/custom/use-in-symbol-with-offset-expected.checksum: Added.
        * platform/chromium/svg/custom/use-in-symbol-with-offset-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 29 Mar 2011 16:02:31 +0000 (16:02 +0000)]
2011-03-29  Oliver Hunt  <oliver@apple.com>

        Reviewed by Eric Seidel.

        REGRESSION(r82173): Causes assertion and test failures in run-javascriptcore-tests on Windows (Requested by aroben on #webkit).
        https://bugs.webkit.org/show_bug.cgi?id=57333

        constructDate now takes the global object explicitly as it may be called
        by functions other than the constructor itself.

        * API/JSObjectRef.cpp:
        (JSObjectMakeDate):
        * runtime/DateConstructor.cpp:
        (JSC::constructDate):
        (JSC::constructWithDateConstructor):
        * runtime/DateConstructor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Tue, 29 Mar 2011 16:01:02 +0000 (16:01 +0000)]
2011-03-29  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed, skipping a test failing on GTK+ bots.

        [GTK] fast/text/justify-ideograph-leading-expansion.html fails on bots
        https://bugs.webkit.org/show_bug.cgi?id=57346

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowebkit2 does not pass tests that require the window to be focused.
jberlin@webkit.org [Tue, 29 Mar 2011 15:46:56 +0000 (15:46 +0000)]
webkit2 does not pass tests that require the window to be focused.
https://bugs.webkit.org/show_bug.cgi?id=56988

Unreviewed, update the WK2 expected results for pseudo-any.html after r82183.

* platform/mac-wk2/fast/css/pseudo-any-expected.txt:
* platform/win-wk2/fast/css/pseudo-any-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd another test that depends on EventSender to the mac-wk2 Skipped file.
jberlin@webkit.org [Tue, 29 Mar 2011 15:40:02 +0000 (15:40 +0000)]
Add another test that depends on EventSender to the mac-wk2 Skipped file.

* platform/mac-wk2/Skipped:
Add fast/events/mouse-relative-position.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Vsevolod Vlasov <vsevik@chromium.org>
pfeldman@chromium.org [Tue, 29 Mar 2011 15:33:31 +0000 (15:33 +0000)]
2011-03-29  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        [Chromium] Inspector does not always shows transferred size correctly (e.g. gzipped/chunked content)
        https://bugs.webkit.org/show_bug.cgi?id=56602

        Added new methods to interface while keeping the old ones to keep
        chromium working until it is also patched.

        * public/WebURLLoaderClient.h:
        (WebKit::WebURLLoaderClient::didReceiveData2):
        * src/AssociatedURLLoader.cpp:
        (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
        * src/ResourceHandle.cpp:
        (WebCore::ResourceHandleInternal::didReceiveData):
        (WebCore::ResourceHandleInternal::didReceiveData2):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 29 Mar 2011 15:30:41 +0000 (15:30 +0000)]
2011-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Rename InlineIterator::pos to m_pos to match modern style
        https://bugs.webkit.org/show_bug.cgi?id=57342

        Somehow I failed to upload this one earlier, no wonder later patches didn't apply.

        * rendering/InlineIterator.h:
        (WebCore::InlineIterator::InlineIterator):
        (WebCore::operator==):
        (WebCore::operator!=):
        (WebCore::InlineIterator::increment):
        (WebCore::InlineIterator::current):
        (WebCore::InlineBidiResolver::appendRun):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::checkMidpoints):
        (WebCore::RenderBlock::appendRunsForObject):
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::RenderBlock::matchedEndLine):
        (WebCore::tryHyphenating):
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows expected semi-failure results after r82189
aroben@apple.com [Tue, 29 Mar 2011 15:26:37 +0000 (15:26 +0000)]
Add Windows expected semi-failure results after r82189

The test is passing, but we're failing to print out an error message so we don't match the
expected results. Printing the error message is tracked by <http://webkit.org/b/57334>.

* platform/win/http/tests/uri/username-with-no-hostname-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 15:25:57 +0000 (15:25 +0000)]
2011-03-29  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Benjamin Poulain.

        https://bugs.webkit.org/show_bug.cgi?id=41953

        Fix compile error on Solaris 10/Sun Studio 12 CC emanating from MathExtras.h

        * wtf/MathExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 29 Mar 2011 15:22:37 +0000 (15:22 +0000)]
2011-03-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: document BrowserDebugger agent.
        https://bugs.webkit.org/show_bug.cgi?id=57331

        * inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Tue, 29 Mar 2011 15:09:55 +0000 (15:09 +0000)]
2011-03-29  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Fix handling of the CSSAgent.setStyleSheetText() results in CSSStyleModel.js
        https://bugs.webkit.org/show_bug.cgi?id=56310

        Instead of stylesheet ids, CSSAgent.getAllStyleSheets() now returns metainfo objects containing
        "styleSheetId", "sourceURL", "disabled", and "title" fields. The latter three are not returned
        by CSSAgent.getStyleSheet() anymore.

        Test: inspector/styles/get-set-stylesheet-text.html

        WebCore:
        * inspector/Inspector.json:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::getAllStyleSheets):
        * inspector/InspectorCSSAgent.h:
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
        (WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
        * inspector/InspectorStyleSheet.h:
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
        (WebInspector.CSSStyleModel.prototype._onRevert):
        (WebInspector.CSSStyleSheet):
        (WebInspector.CSSStyleSheet.prototype.setText):

        LayoutTests:
        * inspector/styles/get-set-stylesheet-text-expected.txt: Added.
        * inspector/styles/get-set-stylesheet-text.html: Added.
        * inspector/styles/resources/get-set-stylesheet-text.css: Added.
        (body):
        (/* comment before selector */body.main1/* comment after selector */):
        (body.main2):
        * inspector/styles/styles-add-blank-property.html: Tentatively fix flakiness by waiting for pending dispatches to finish
        * inspector/styles/styles-new-API.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Tue, 29 Mar 2011 15:07:13 +0000 (15:07 +0000)]
2011-03-29  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] DevTools shows two resources for each plugin resource loaded
        https://bugs.webkit.org/show_bug.cgi?id=57101

        Remove DevToolsAgent network callbacks as this information is now available through ResourceLoader

        * public/WebDevToolsAgent.h:
        * src/WebDevToolsAgentImpl.cpp:
        * src/WebDevToolsAgentImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Jeremy Moskovich <jeremy@chromium.org>
jeremy@chromium.org [Tue, 29 Mar 2011 14:41:01 +0000 (14:41 +0000)]
2011-03-29  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Eric Seidel.

        Implement text-align:match-parent as -webkit-match-parent.
        https://bugs.webkit.org/show_bug.cgi?id=50951

        Add tests to verify that the implementation works as expected.

        * fast/css/text-align-webkit-match-parent-expected.txt: Added.
        * fast/css/text-align-webkit-match-parent-parse-expected.txt: Added.
        * fast/css/text-align-webkit-match-parent-parse.html: Added.
        * fast/css/text-align-webkit-match-parent.html: Added.
2011-03-29  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Eric Seidel.

        Implement text-align:match-parent as -webkit-match-parent.
        https://bugs.webkit.org/show_bug.cgi?id=50951

        Add support to the CSS parser.

        Tests: fast/css/text-align-webkit-match-parent-parse.html
               fast/css/text-align-webkit-match-parent.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * css/CSSValueKeywords.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 29 Mar 2011 14:35:02 +0000 (14:35 +0000)]
2011-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Rename InlineIterator::nextBreakablePosition to m_nextBreakablePosition to match modern style
        https://bugs.webkit.org/show_bug.cgi?id=57323

        All of these m_nextBreakablePosition = -1 could probably be replaced with
        some new methods.  But I'll do that in a separate change.  Clearly
        m_nextBreakablePosition is just a cached value which should be cleared
        at the right times.  I suspect we may even fail to clear it sometimes when
        we should due to the current used of direct access instead of smarter functions.

        * rendering/InlineIterator.h:
        (WebCore::InlineIterator::InlineIterator):
        (WebCore::InlineIterator::increment):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::tryHyphenating):
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows results for new test added in r82200
aroben@apple.com [Tue, 29 Mar 2011 14:30:46 +0000 (14:30 +0000)]
Add Windows results for new test added in r82200

Windows differs from Mac due to a different scrollbar width within the listbox.

* platform/win/fast/forms/listbox-bidi-align-expected.checksum: Added.
* platform/win/fast/forms/listbox-bidi-align-expected.png: Added.
* platform/win/fast/forms/listbox-bidi-align-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Tue, 29 Mar 2011 14:14:12 +0000 (14:14 +0000)]
2011-03-29  Jeff Miller  <jeffm@apple.com>

        Reviewed by Jon Honeycutt.

        Add WebCore::copyCertificateToData() on Windows
        https://bugs.webkit.org/show_bug.cgi?id=57296

        Remove duplicate code that implemented this functionality in WebMutableURLRequest.cpp and use WebCore::copyCertificateToData() instead.

        * WebMutableURLRequest.cpp:
        (WebMutableURLRequest::setClientCertificate):  Use WebCore::copyCertificateToData().
2011-03-29  Jeff Miller  <jeffm@apple.com>

        Reviewed by Jon Honeycutt.

        Add WebCore::copyCertificateToData() on Windows
        https://bugs.webkit.org/show_bug.cgi?id=57296

        Create a new win directory in platform/cf and add CertificateCFWin.cpp and CertificateCFWin.h to it.

        * WebCore.vcproj/WebCore.vcproj: Added CertificateCFWin.cpp and CertificateCFWin.h.
        * WebCore.vcproj/copyForwardingHeaders.cmd: Copy all header files in \platform\cf\win\.
        * platform/cf/win: Added.
        * platform/cf/win/CertificateCFWin.cpp: Added.
        (WebCore::deallocCertContext): Added.
        (WebCore::createCertContextDeallocator): Added.
        (WebCore::copyCertificateToData): Added.
        * platform/cf/win/CertificateCFWin.h: Added.
2011-03-29  Jeff Miller  <jeffm@apple.com>

        Reviewed by Jon Honeycutt.

        Add WebCore::copyCertificateToData() on Windows
        https://bugs.webkit.org/show_bug.cgi?id=57296

        Remove duplicate code that implemented this functionality in WebCoreArgumentCodersWin.cpp and use WebCore::copyCertificateToData() instead.

        * Shared/win/WebCoreArgumentCodersWin.cpp:
        (CoreIPC::decodeResourceError): Use WebCore::copyCertificateToData().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Noel Gordon <noel.gordon@gmail.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 14:09:37 +0000 (14:09 +0000)]
2011-03-29  Noel Gordon  <noel.gordon@gmail.com>

        Reviewed by Ojan Vafai.

        [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
        https://bugs.webkit.org/show_bug.cgi?id=57303

        * DumpRenderTree/chromium/EventSender.cpp:
        (EventSender::doDragDrop):
        (EventSender::beginDragWithFiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 29 Mar 2011 14:06:50 +0000 (14:06 +0000)]
2011-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Rename InlineIterator::block to m_block to match modern style
        https://bugs.webkit.org/show_bug.cgi?id=57321

        I could have made m_block private, since it's only accessed in
        one place outside of InlineIterator (for an ASSERT).  But I chose
        not to do so in this change.

        * rendering/InlineIterator.h:
        (WebCore::InlineIterator::InlineIterator):
        (WebCore::InlineIterator::increment):
        (WebCore::InlineBidiResolver::appendRun):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
zoltan@webkit.org [Tue, 29 Mar 2011 13:36:33 +0000 (13:36 +0000)]
[Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=57314

Reviewed by Andreas Kling.

Provide possibility to print loaded urls to the standard output.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::printURL):
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::handleUserOptions):
* MiniBrowser/qt/MiniBrowserApplication.h:
(WindowOptions::WindowOptions):
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::initializeView):
(LauncherWindow::printURL):
(LauncherWindow::cloneWindow):
* QtTestBrowser/launcherwindow.h:
(WindowOptions::WindowOptions):
* QtTestBrowser/main.cpp:
(LauncherApplication::handleUserOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Tue, 29 Mar 2011 13:33:00 +0000 (13:33 +0000)]
2011-03-29  Alexis Menard  <alexis.menard@openbossa.org>

        Unreviewed build fix for build-webkit -minimal.

        Breakage introduced by http://trac.webkit.org/changeset/82238.
        The minimal option has no support for shortcuts.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleInputMethodKeydown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Leo Yang <leo.yang@torchmobile.com.cn>
commit-queue@webkit.org [Tue, 29 Mar 2011 13:28:09 +0000 (13:28 +0000)]
2011-03-29  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        Incorrect offset of svg <use> element which is in <symbol> element
        https://bugs.webkit.org/show_bug.cgi?id=57318

        Test case to verify offset of svg <use> element in <symbol> element
        is set correctly.

        * platform/qt/svg/custom/use-in-symbol-with-offset-expected.checksum: Added.
        * platform/qt/svg/custom/use-in-symbol-with-offset-expected.png: Added.
        * svg/custom/use-in-symbol-with-offset-expected.txt: Added.
        * svg/custom/use-in-symbol-with-offset.svg: Added.
2011-03-29  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        Incorrect offset of svg <use> element which is in <symbol> element
        https://bugs.webkit.org/show_bug.cgi?id=57318

        When webkit expanded a svg <symbol> element in the shadow tree it
        would clone the children of the <symbol>. The children may contain
        SVGShadowTreeContainerElement which was expanded from svg <use>
        element. But the clone operation would clone a
        SVGShadowTreeContainerElement as a svg <g> element. This resulted
        that updateContainerOffset wouldn't update offset for those elements
        which were expand from <use> elements.

        This patch implements cloneElementWithoutAttributesAndChildren for
        SVGShadowTreeContainerElement to make the container clone itself
        correctly.

        Test: svg/custom/use-in-symbol-with-offset.svg

        * rendering/svg/SVGShadowTreeElements.cpp:
        (WebCore::SVGShadowTreeContainerElement::cloneElementWithoutAttributesAndChildren):
        * rendering/svg/SVGShadowTreeElements.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 29 Mar 2011 13:18:11 +0000 (13:18 +0000)]
2011-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Rename InlineIterator::obj to m_obj to match modern style
        https://bugs.webkit.org/show_bug.cgi?id=57319

        I started this rename after confusion in InlineBidiResolver::appendRun.
        (Which uses an "obj" local in InlineIterator.h.  It's not actually
        masking m_obj because it's a separate class, but I didn't realize
        that at the time because it's in InlineIterator.h which is itself confusing!)

        * rendering/InlineIterator.h:
        (WebCore::InlineIterator::InlineIterator):
        (WebCore::operator==):
        (WebCore::operator!=):
        (WebCore::InlineIterator::increment):
        (WebCore::InlineIterator::atEnd):
        (WebCore::InlineIterator::current):
        (WebCore::InlineIterator::direction):
        (WebCore::InlineBidiResolver::appendRun):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::checkMidpoints):
        (WebCore::RenderBlock::appendRunsForObject):
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::RenderBlock::matchedEndLine):
        (WebCore::skipNonBreakingSpace):
        (WebCore::RenderBlock::requiresLineBox):
        (WebCore::RenderBlock::skipTrailingWhitespace):
        (WebCore::RenderBlock::skipLeadingWhitespace):
        (WebCore::tryHyphenating):
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Remove modular references after support for the flag was removed.
ossy@webkit.org [Tue, 29 Mar 2011 13:18:05 +0000 (13:18 +0000)]
[Qt] Remove modular references after support for the flag was removed.
https://bugs.webkit.org/show_bug.cgi?id=57018

Rubber-stamped by Andreas Kling.

Symbian buildfix after r82232.

* Source/WebKit.pri: Readd uitools option.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 29 Mar 2011 13:05:07 +0000 (13:05 +0000)]
2011-03-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: document Timeline domain, make timeline event types of type string.
        https://bugs.webkit.org/show_bug.cgi?id=57299

        * inspector/timeline/timeline-enum-stability-expected.txt:
        * inspector/timeline/timeline-event-dispatch-expected.txt:
        * inspector/timeline/timeline-layout-expected.txt:
        * inspector/timeline/timeline-mark-timeline-expected.txt:
        * inspector/timeline/timeline-network-resource-expected.txt:
        * inspector/timeline/timeline-paint-expected.txt:
        * inspector/timeline/timeline-parse-html-expected.txt:
        * inspector/timeline/timeline-recalculate-styles-expected.txt:
        * inspector/timeline/timeline-script-tag-1-expected.txt:
        * inspector/timeline/timeline-script-tag-2-expected.txt:
        * inspector/timeline/timeline-test.js:
        (initialize_Timeline.InspectorTest.startTimeline):
        * platform/chromium/inspector/timeline/timeline-event-dispatch-expected.txt:
        * platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt:
        * platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:
        * platform/chromium/inspector/timeline/timeline-paint-expected.txt:
        * platform/chromium/inspector/timeline/timeline-parse-html-expected.txt:
2011-03-29  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: document Timeline domain, make timeline event types of type string.
        https://bugs.webkit.org/show_bug.cgi?id=57299

        * inspector/Inspector.json:
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::pushGCEventRecords):
        (WebCore::InspectorTimelineAgent::start):
        (WebCore::InspectorTimelineAgent::stop):
        (WebCore::InspectorTimelineAgent::willCallFunction):
        (WebCore::InspectorTimelineAgent::didCallFunction):
        (WebCore::InspectorTimelineAgent::willDispatchEvent):
        (WebCore::InspectorTimelineAgent::didDispatchEvent):
        (WebCore::InspectorTimelineAgent::willLayout):
        (WebCore::InspectorTimelineAgent::didLayout):
        (WebCore::InspectorTimelineAgent::willRecalculateStyle):
        (WebCore::InspectorTimelineAgent::didRecalculateStyle):
        (WebCore::InspectorTimelineAgent::willPaint):
        (WebCore::InspectorTimelineAgent::didPaint):
        (WebCore::InspectorTimelineAgent::willWriteHTML):
        (WebCore::InspectorTimelineAgent::didWriteHTML):
        (WebCore::InspectorTimelineAgent::didInstallTimer):
        (WebCore::InspectorTimelineAgent::didRemoveTimer):
        (WebCore::InspectorTimelineAgent::willFireTimer):
        (WebCore::InspectorTimelineAgent::didFireTimer):
        (WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
        (WebCore::InspectorTimelineAgent::didChangeXHRReadyState):
        (WebCore::InspectorTimelineAgent::willLoadXHR):
        (WebCore::InspectorTimelineAgent::didLoadXHR):
        (WebCore::InspectorTimelineAgent::willEvaluateScript):
        (WebCore::InspectorTimelineAgent::didEvaluateScript):
        (WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
        (WebCore::InspectorTimelineAgent::willSendResourceRequest):
        (WebCore::InspectorTimelineAgent::willReceiveResourceData):
        (WebCore::InspectorTimelineAgent::didReceiveResourceData):
        (WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
        (WebCore::InspectorTimelineAgent::didReceiveResourceResponse):
        (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
        (WebCore::InspectorTimelineAgent::didMarkTimeline):
        (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
        (WebCore::InspectorTimelineAgent::didMarkLoadEvent):
        (WebCore::InspectorTimelineAgent::addRecordToTimeline):
        (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
        (WebCore::InspectorTimelineAgent::pushCurrentRecord):
        * inspector/InspectorTimelineAgent.h:
        (WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
        * inspector/front-end/TimelineAgent.js:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype.get _recordStyles):
        (WebInspector.TimelinePanel.prototype._createEventDivider):
        (WebInspector.TimelinePanel.prototype._findParentRecord):
        (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
        (WebInspector.TimelineDispatcher.prototype.started):
        (WebInspector.TimelineDispatcher.prototype.stopped):
        (WebInspector.TimelineDispatcher.prototype.eventRecorded):
        (WebInspector.TimelinePanel.FormattedRecord):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Janne Koskinen <janne.p.koskinen@digia.com>
alexis.menard@openbossa.org [Tue, 29 Mar 2011 13:04:25 +0000 (13:04 +0000)]
2011-03-29  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
        https://bugs.webkit.org/show_bug.cgi?id=33179

        Fixed newline generation from Qt::Key_Enter when editting text area using InputMethods.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleInputMethodKeydown):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Tue, 29 Mar 2011 12:58:15 +0000 (12:58 +0000)]
2011-03-29  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Fixing live edits tests on chromium.
        https://bugs.webkit.org/show_bug.cgi?id=57316

        * inspector/debugger/live-edit.html:
2011-03-29  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Fixing live edits tests on chromium.
        https://bugs.webkit.org/show_bug.cgi?id=57316

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource):
        (WebInspector.SourceFrame.prototype._handleSave):
        (WebInspector.SourceFrameDelegate.prototype.editScriptSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 29 Mar 2011 12:55:02 +0000 (12:55 +0000)]
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip crashing svg test on GTK.

        * platform/gtk/Skipped: Skip svg/text/text-deco-01-b.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 29 Mar 2011 12:29:56 +0000 (12:29 +0000)]
2011-03-29  Andreas Kling  <kling@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Fix documentation for QWebPage::repaintRequested()

        This signal is always emitted when the page is dirtied, so remove
        reference to old behavior where we would only emit the signal for
        headless QWebPages.

        * Api/qwebpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 29 Mar 2011 12:28:34 +0000 (12:28 +0000)]
2011-03-29  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: fix call frames positions in formatted scripts.
        https://bugs.webkit.org/show_bug.cgi?id=57036

        * inspector/debugger/debugger-eval-while-paused.html:
2011-03-29  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: fix call frames positions in formatted scripts.
        https://bugs.webkit.org/show_bug.cgi?id=57036

        Introduce PresentationCallFrame class that encapsulates source mapping details from UI components.

        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane.prototype.update.didGetSourceLocation):
        (WebInspector.CallStackSidebarPane.prototype.update):
        (WebInspector.CallStackSidebarPane.prototype.set selectedCallFrame):
        (WebInspector.CallStackSidebarPane.prototype._placardSelected):
        (WebInspector.CallStackSidebarPane.prototype._contextMenu):
        (WebInspector.CallStackSidebarPane.prototype._copyStackTrace):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype._didEditScriptSource):
        (WebInspector.DebuggerModel.prototype.get debuggerPausedDetails):
        (WebInspector.DebuggerModel.prototype._pausedScript):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
        (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
        (WebInspector.DebuggerPresentationModel.prototype._debuggerResumed):
        (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
        (WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame):
        (WebInspector.DebuggerPresentationModel.prototype._reset):
        (WebInspector.PresenationCallFrame): Call frame wrapper for UI.
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
        (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
        (WebInspector.ScriptsPanel.prototype._debuggerPaused):
        (WebInspector.ScriptsPanel.prototype._debuggerResumed):
        (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
        (WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation):
        (WebInspector.ScriptsPanel.prototype._callFrameSelected):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):
        * inspector/front-end/SourceFile.js:
        (WebInspector.SourceFile.prototype.get content):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._createTextViewer):
        (WebInspector.SourceFrame.prototype.setExecutionLine):
        (WebInspector.SourceFrame.prototype.clearExecutionLine):
        (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
        (WebInspector.SourceFrame.prototype._showPopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Tue, 29 Mar 2011 12:10:05 +0000 (12:10 +0000)]
2011-03-29  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        Fix for execCommand("Delete") with an empty selection.
        https://bugs.webkit.org/show_bug.cgi?id=56652

        Add test for deleting an empty selection from an empty container.

        * editing/execCommand/delete-empty-container-expected.txt: Added.
        * editing/execCommand/delete-empty-container.html: Added.
2011-03-29  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        Fix for execCommand("Delete") with an empty selection.
        https://bugs.webkit.org/show_bug.cgi?id=56652

        Test: editing/execCommand/delete-empty-container.html

        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::makeEditableRootEmpty): Add check for root element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Kristian Amlie <kristian.amlie@nokia.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 12:01:25 +0000 (12:01 +0000)]
2011-03-29  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Andreas Kling.

        Removed modular references after support for the flag was removed.

        Support was removed because the Qt Modularization project decided we
        don't need it. It's better to base decisions on the available
        information, as demonstrated in the patch by checking
        QT.phonon.includes.

        In addition, remove the reference to uitools. It has been moved to
        QtKernel now, and therefore is always available.

        [Qt] Remove modular references after support for the flag was removed.
        https://bugs.webkit.org/show_bug.cgi?id=57018

        * Source/WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Teach build-jsc how to build JavaScriptCore on Qt
ossy@webkit.org [Tue, 29 Mar 2011 12:00:43 +0000 (12:00 +0000)]
[Qt] Teach build-jsc how to build JavaScriptCore on Qt
https://bugs.webkit.org/show_bug.cgi?id=56918

Patch by Gabor Loki <loki@webkit.org> on 2011-03-29
Rubber-stamped by Csaba Osztrogon√°c.

* Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Tue, 29 Mar 2011 11:44:25 +0000 (11:44 +0000)]
2011-03-29  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Refactor HeapSnapshot-related code to
        make sure we don't return big amounts of data to forms.
        https://bugs.webkit.org/show_bug.cgi?id=57227

        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
        (WebInspector.HeapSnapshotGenericObjectNode.prototype.get _countPercent):
        (WebInspector.HeapSnapshotObjectNode):
        (WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
        (WebInspector.HeapSnapshotInstanceNode):
        (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
        (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
        (WebInspector.HeapSnapshotConstructorNode.prototype.get _countPercent):
        (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
        (WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
        (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
        (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.setDataSource):
        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshotNode.prototype.get dominatorIndex):
        (WebInspector.HeapSnapshotNode.prototype.get retainers):
        (WebInspector.HeapSnapshot):
        (WebInspector.HeapSnapshot.prototype.get _allNodes):
        (WebInspector.HeapSnapshot.prototype.get nodeCount):
        (WebInspector.HeapSnapshot.prototype.get rootNodeIndex):
        (WebInspector.HeapSnapshot.prototype.hasId):
        (WebInspector.HeapSnapshot.prototype.get nodeIds):
        (WebInspector.HeapSnapshot.prototype._retainersForNode):
        (WebInspector.HeapSnapshot.prototype._buildRetainers):
        (WebInspector.HeapSnapshot.prototype._buildAggregates):
        (WebInspector.HeapSnapshot.prototype._buildAggregatesIndexes):
        (WebInspector.HeapSnapshot.prototype._buildIdsList):
        (WebInspector.HeapSnapshot.prototype._buildNodeIndex):
        (WebInspector.HeapSnapshotFilteredOrderedIterator):
        (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.next):
        (WebInspector.HeapSnapshotEdgesProvider):
        (WebInspector.HeapSnapshotNodesProvider):

2011-03-29  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Refactor HeapSnapshot-related code to
        make sure we don't return big amounts of data to forms.
        https://bugs.webkit.org/show_bug.cgi?id=57227

        * inspector/profiler/heap-snapshot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Tue, 29 Mar 2011 11:34:20 +0000 (11:34 +0000)]
2011-03-29  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Fix detailed heap snapshots UI.
        https://bugs.webkit.org/show_bug.cgi?id=57235

        Fix two problems:
          1. Text color of grid cells under selection needs to be white, otherwise it's unreadable for some colors;
          2. Long strings need to be truncated in grid, their contents can be shown on hover.

        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.DetailedHeapshotView.prototype._getHoverAnchor):
        (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
        * inspector/front-end/heapProfiler.css:
        (.detailed-heapshot-view .console-formatted-string):
        (.detailed-heapshot-view .data-grid tr.selected *):
        (.detailed-heapshot-view .data-grid:focus tr.selected *):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Teach build-jsc how to build JavaScriptCore on Qt
loki@webkit.org [Tue, 29 Mar 2011 11:24:52 +0000 (11:24 +0000)]
[Qt] Teach build-jsc how to build JavaScriptCore on Qt
https://bugs.webkit.org/show_bug.cgi?id=56918

Reviewed by Csaba Osztrogon√°c.

* Scripts/build-jsc:
* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Tue, 29 Mar 2011 11:20:19 +0000 (11:20 +0000)]
2011-03-29  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Highlight visible lines first
        https://bugs.webkit.org/show_bug.cgi?id=57013

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleChunkNumber):
        (WebInspector.TextEditorChunkedPanel.prototype._findVisibleChunks):
        (WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber.compareLineRowOffsetTops):
        (WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber):
        (WebInspector.TextEditorMainPanel.prototype._paintScheduledLines):
        (WebInspector.TextEditorMainPanel.prototype._paintLines):
        (WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
        (WebInspector.TextEditorMainPanel.prototype._paintLine):
        (WebInspector.TextEditorMainChunk.prototype.set expanded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 29 Mar 2011 11:13:29 +0000 (11:13 +0000)]
2011-03-29  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, updating Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Tue, 29 Mar 2011 11:02:33 +0000 (11:02 +0000)]
2011-03-29  Emil A Eklund  <eae@chromium.org>

        Reviewed by Dimitri Glazkov.

        Relative mouse coordinates recalculated for target
        https://bugs.webkit.org/show_bug.cgi?id=57130

        Add mouse event performance test.

        * fast/events/mouse-relative-position-expected.txt: Added.
        * fast/events/mouse-relative-position.html: Added.
        * perf/mouse-event-expected.txt: Added.
        * perf/mouse-event.html: Added.
2011-03-29  Emil A Eklund  <eae@chromium.org>

        Reviewed by Dimitri Glazkov.

        Relative mouse coordinates recalculated for each target
        https://bugs.webkit.org/show_bug.cgi?id=57130

        Calculate relative coordinates lazily for mouse events instead of doing
        it for each target. Speeds up dispatching of mouse events in deep dom
        structures significantly, O(n^2) to O(n).

        Also fixes https://bugs.webkit.org/show_bug.cgi?id=34973

        Tests: fast/events/mouse-relative-position.html
               perf/mouse-event.html

        * dom/Event.cpp:
        (WebCore::Event::setTarget):
        * dom/MouseRelatedEvent.cpp:
        (WebCore::MouseRelatedEvent::MouseRelatedEvent):
        (WebCore::MouseRelatedEvent::initCoordinates):
        (WebCore::pageZoomFactor):
        (WebCore::MouseRelatedEvent::receivedTarget):
        (WebCore::MouseRelatedEvent::computeRelativePosition):
        (WebCore::MouseRelatedEvent::layerX):
        (WebCore::MouseRelatedEvent::layerY):
        (WebCore::MouseRelatedEvent::offsetX):
        (WebCore::MouseRelatedEvent::offsetY):
        * dom/MouseRelatedEvent.h:
        * dom/UIEvent.cpp:
        (WebCore::UIEvent::layerX):
        (WebCore::UIEvent::layerY):
        * dom/UIEvent.h:
2011-03-29  Emil A Eklund  <eae@chromium.org>

        Reviewed by Dimitri Glazkov.

        Relative mouse coordinates recalculated for each target
        https://bugs.webkit.org/show_bug.cgi?id=57130

        * public/WebDOMMouseEvent.h:
        * src/WebDOMMouseEvent.cpp:
        (WebKit::WebDOMMouseEvent::layerX):
        (WebKit::WebDOMMouseEvent::layerY):
        (WebKit::WebDOMMouseEvent::offsetX):
        (WebKit::WebDOMMouseEvent::offsetY):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 29 Mar 2011 10:43:00 +0000 (10:43 +0000)]
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing http/tests/uri test on GTK.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 29 Mar 2011 10:38:11 +0000 (10:38 +0000)]
2011-03-29  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, rolling out r82195.
        http://trac.webkit.org/changeset/82195
        https://bugs.webkit.org/show_bug.cgi?id=56602

        Broke Chromium Clang builds.

        * public/WebDevToolsAgent.h:
        * public/WebURLLoaderClient.h:
        * src/AssociatedURLLoader.cpp:
        (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
        * src/ResourceHandle.cpp:
        (WebCore::ResourceHandleInternal::didReceiveData):
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::didReceiveData):
        * src/WebDevToolsAgentImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Tue, 29 Mar 2011 10:31:46 +0000 (10:31 +0000)]
2011-03-29  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        getComputedStyle counterIncrement crash @ WebCore::counterToCSSValue
        https://bugs.webkit.org/show_bug.cgi?id=57266

        Add test for getComputedStyle(...).counterIncrement without a counter.

        * fast/css/getComputedStyle/counterIncrement-without-counter-expected.txt: Added.
        * fast/css/getComputedStyle/counterIncrement-without-counter.html: Added.
2011-03-29  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        getComputedStyle counterIncrement crash @ WebCore::counterToCSSValue
        https://bugs.webkit.org/show_bug.cgi?id=57266

        Add null check to counterToCSSValue.

        Test: fast/css/getComputedStyle/counterIncrement-without-counter.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::counterToCSSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 29 Mar 2011 09:34:18 +0000 (09:34 +0000)]
2011-03-29  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed. Another build fix. The last fix was incorrect.

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::supportsFullscreenForNode):
        (WebKit::ChromeClientImpl::supportsFullScreenForElement):
        * src/ChromeClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Tue, 29 Mar 2011 09:24:17 +0000 (09:24 +0000)]
2011-03-29  Balazs Kelemen  <kbalazs@webkit.org>

        Unreviewed build fix (64 bit gcc).

        GCC does not accept uint64_t formatted as %lli.

        * UIProcess/WebIconDatabase.cpp:
        (WebKit::WebIconDatabase::getLoadDecisionForIconURL): Add explicit cast to long long.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 29 Mar 2011 09:18:50 +0000 (09:18 +0000)]
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, disable an assert in testwebview due to
        https://bugs.webkit.org/show_bug.cgi?id=57315

        * tests/testwebview.c:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 29 Mar 2011 09:08:53 +0000 (09:08 +0000)]
2011-03-29  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed. Build fix for Chromium Clang bot.

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::supportsFullscreenForNode):
        * src/ChromeClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Gavin Peters <gavinp@chromium.org>
commit-queue@webkit.org [Tue, 29 Mar 2011 09:06:26 +0000 (09:06 +0000)]
2011-03-29  Gavin Peters  <gavinp@chromium.org>

        Reviewed by Tony Gentilcore.

        Implement onerror events for <link rel=prefetch>
        https://bugs.webkit.org/show_bug.cgi?id=57182

        * fast/dom/HTMLLinkElement/prefetch-onerror-expected.txt: Added.
        * fast/dom/HTMLLinkElement/prefetch-onerror.html: Added.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-03-29  Gavin Peters  <gavinp@chromium.org>

        Reviewed by Tony Gentilcore.

        Implement onerror events for <link rel=prefetch>
        https://bugs.webkit.org/show_bug.cgi?id=57182

        These events are equired on link elements, see
        http://dev.w3.org/html5/spec/Overview.html#the-link-element

        After a discussion in WebKit-dev about the direction of prefetch in the loader, and about a path
        to adding the Link header, we decided to look at making onerror, onload and onbeforeload events
        more uniformly supported.  See the thread at
        https://lists.webkit.org/pipermail/webkit-dev/2011-February/016034.html .

        It turned out that part of adding onerror for link prefetch was to make the top CachedResource less
        abstract.  It was pure virtual until prefetch became the first consumer to use an unspecialised
        implementation, and this CL continues that by adding a default checkNotify method to it.  As it
        happens there were already two subclasses using what amounted to the generic checkNotify, so I
        also removed those, buying us some code cleanup with the change.

        Test: fast/dom/HTMLLinkElement/prefetch-onerror.html

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::parseMappedAttribute):
        (WebCore::HTMLLinkElement::onloadTimerFired):
        (WebCore::HTMLLinkElement::notifyFinished):
        * loader/cache/CachedImage.cpp:
        * loader/cache/CachedImage.h:
        * loader/cache/CachedResource.cpp:
        (WebCore::CachedResource::checkNotify):
        (WebCore::CachedResource::data):
        (WebCore::CachedResource::error):
        * loader/cache/CachedResource.h:
        * loader/cache/CachedScript.cpp:
        * loader/cache/CachedScript.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttp/tests/uri/username-with-no-hostname.html fails after r82151
ossy@webkit.org [Tue, 29 Mar 2011 08:58:12 +0000 (08:58 +0000)]
http/tests/uri/username-with-no-hostname.html fails after r82151
https://bugs.webkit.org/show_bug.cgi?id=57306

* platform/qt/Skipped: Add http/tests/uri/username-with-no-hostname.html until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 29 Mar 2011 08:55:16 +0000 (08:55 +0000)]
2011-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Add support for parsing unicode-bidi: -webkit-isolate
        https://bugs.webkit.org/show_bug.cgi?id=57181

        * css3/unicode-bidi-insolate-parse-expected.txt: Added.
        * css3/unicode-bidi-insolate-parse.html: Added.
2011-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Add support for parsing unicode-bidi: -webkit-isolate
        https://bugs.webkit.org/show_bug.cgi?id=57181

        Test: css3/unicode-bidi-insolate-parse.html

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
        * css/CSSValueKeywords.in:
        * rendering/style/RenderStyleConstants.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 29 Mar 2011 08:42:43 +0000 (08:42 +0000)]
2011-03-29  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r82193.

        * platform/wince/FileSystemWinCE.cpp:
        (WebCore::openTemporaryFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 29 Mar 2011 08:40:37 +0000 (08:40 +0000)]
2011-03-29  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK rebaseline for r82144.

        * platform/gtk/fast/block/positioning/052-expected.checksum:
        * platform/gtk/fast/block/positioning/052-expected.png:
        * platform/gtk/fast/block/positioning/052-expected.txt:
        * platform/gtk/fast/forms/input-appearance-preventDefault-expected.checksum:
        * platform/gtk/fast/forms/input-appearance-preventDefault-expected.png:
        * platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 08:37:33 +0000 (08:37 +0000)]
2011-03-29  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=57231
        Add conditional for SUNCC supporting alignment macros

        Compile fix for Solaris 10/Sun Studio 12 CC

        * wtf/Vector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 08:32:48 +0000 (08:32 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Add GPU expectations for compositing tests (these appear to all be passes).

        * platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.checksum:
        * platform/chromium-gpu-mac/compositing/geometry/clipped-video-controller-expected.png:
        * platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.checksum:
        * platform/chromium-gpu-mac/compositing/geometry/video-fixed-scrolling-expected.png:
        * platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.checksum:
        * platform/chromium-gpu-mac/compositing/geometry/video-opacity-overlay-expected.png:
        * platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.checksum:
        * platform/chromium-gpu-mac/compositing/layers-inside-overflow-scroll-expected.png:
        * platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.checksum:
        * platform/chromium-gpu-mac/compositing/overflow/overflow-compositing-descendant-expected.png:
        * platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.checksum:
        * platform/chromium-gpu-mac/compositing/overflow/scroll-ancestor-update-expected.png:
        * platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.checksum:
        * platform/chromium-gpu-mac/compositing/reflections/load-video-in-reflection-expected.png:
        * platform/chromium-gpu-mac/compositing/self-painting-layers-expected.checksum:
        * platform/chromium-gpu-mac/compositing/self-painting-layers-expected.png:
        * platform/chromium-gpu-mac/media/video-display-toggle-expected.checksum:
        * platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
        * platform/chromium-gpu-mac/media/video-no-audio-expected.checksum:
        * platform/chromium-gpu-mac/media/video-no-audio-expected.png:
        * platform/chromium-gpu-mac/media/video-volume-slider-expected.checksum:
        * platform/chromium-gpu-mac/media/video-volume-slider-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 08:21:34 +0000 (08:21 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Update IMAGE results to show test progression (yay!).

        * platform/chromium-linux/fast/text/drawBidiText-expected.checksum:
        * platform/chromium-linux/fast/text/drawBidiText-expected.png:
        * platform/chromium-mac/fast/text/drawBidiText-expected.checksum: Added.
        * platform/chromium-mac/fast/text/drawBidiText-expected.png: Added.
        * platform/chromium-win-xp/fast/text/drawBidiText-expected.checksum: Added.
        * platform/chromium-win-xp/fast/text/drawBidiText-expected.png: Added.
        * platform/chromium-win/fast/text/drawBidiText-expected.checksum:
        * platform/chromium-win/fast/text/drawBidiText-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 08:14:19 +0000 (08:14 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Add Windows baselines.

        * platform/chromium-win/fast/forms/listbox-bidi-align-expected.checksum: Added.
        * platform/chromium-win/fast/forms/listbox-bidi-align-expected.png: Added.
        * platform/chromium-win/fast/forms/listbox-bidi-align-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 29 Mar 2011 08:10:01 +0000 (08:10 +0000)]
2011-03-29  Adam Barth  <abarth@webkit.org>

        Add platform-specific baselines for listbox-bidi-align.

        * platform/chromium-linux/fast/forms/listbox-bidi-align-expected.checksum: Added.
        * platform/chromium-linux/fast/forms/listbox-bidi-align-expected.png: Added.
        * platform/chromium-linux/fast/forms/listbox-bidi-align-expected.txt: Added.
        * platform/chromium-mac/fast/forms/listbox-bidi-align-expected.checksum: Added.
        * platform/chromium-mac/fast/forms/listbox-bidi-align-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 07:59:16 +0000 (07:59 +0000)]
2011-03-29  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=57256

        Fix crash on misaligned reads on Solaris 10/Sparc

        * wtf/text/AtomicString.cpp:
        (WTF::equal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 29 Mar 2011 07:37:30 +0000 (07:37 +0000)]
2011-03-28  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        WKPageGetSourceForFrame and WKPageGetContentsAsString should throw an error in case of a race with page loading
        https://bugs.webkit.org/show_bug.cgi?id=57305
        <rdar://problem/8738060>, <rdar://problem/8780168>

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::close): Clear m_loadDependentStringCallbackIDs
        (WebKit::WebPageProxy::getSourceForFrame): track the callback as load dependent
        (WebKit::WebPageProxy::getContentsAsString): ditto
        (WebKit::WebPageProxy::clearLoadDependentCallbacks): Invalidate all load dependent callbacks
        (WebKit::WebPageProxy::didCommitLoadForFrame): Call clearLoadDependentCallbacks
        (WebKit::WebPageProxy::didFailLoadForFrame): ditto
        (WebKit::WebPageProxy::stringCallback): Remove callback from load dependent set if appropriate
        (WebKit::WebPageProxy::processDidCrash): Clear m_loadDependentStringCallbackIDs
        * UIProcess/WebPageProxy.h: Add m_loadDependentStringCallbackIDs hash set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Tue, 29 Mar 2011 07:30:52 +0000 (07:30 +0000)]
2011-03-29  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Remove unnecessary ewk_view_viewport_attributes_set() invocation
        https://bugs.webkit.org/show_bug.cgi?id=57222

        WebCore sends viewport signal whenever viewport is changed by Page::updateViewportArguments().
        Thus, we don't need to call ewk_view_viewport_attributes_set() with dummy viewport data
        anymore.

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Tue, 29 Mar 2011 07:20:19 +0000 (07:20 +0000)]
2011-03-29  Adam Klein  <adamk@chromium.org>

        Reviewed by Darin Adler.

        removeAllInDirectory() layout test helper method can call successCallback twice
        https://bugs.webkit.org/show_bug.cgi?id=57136

        Fixed to only call successCallback once, thereby avoiding
        flakiness in tests which use this function
        (see http://crbug.com/77442).

        * fast/filesystem/resources/fs-test-util.js:
        (removeAllInDirectory):
        * http/tests/filesystem/resources/fs-test-util.js:
        (removeAllInDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-29 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 29 Mar 2011 07:14:10 +0000 (07:14 +0000)]
2011-03-29  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, add Chromium test expectation for http/tests/uri/username-with-no-hostname.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 06:59:19 +0000 (06:59 +0000)]
2011-03-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82198.
        http://trac.webkit.org/changeset/82198
        https://bugs.webkit.org/show_bug.cgi?id=57304

        Broke Chromium Win build. (Requested by dave_levin on
        #webkit).

        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::headerAvailable):
        (WebCore::PNGImageDecoder::rowAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 29 Mar 2011 06:45:16 +0000 (06:45 +0000)]
2011-03-28  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, fix Chromium test results and expectations.

        * platform/chromium-mac-leopard/fast/block/positioning/047-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/positioning/047-expected.png: Added.
        * platform/chromium-mac/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Ofri Wolfus <ofri@google.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 06:42:30 +0000 (06:42 +0000)]
2011-03-28  Ofri Wolfus  <ofri@google.com>

        Reviewed by Eric Seidel.

        RTL: Select elements with a size attribute are always left aligned.
        https://bugs.webkit.org/show_bug.cgi?id=50928

        Added support for alignment in RenderListBox.

        * fast/forms/listbox-bidi-align.html: Added.
        * platform/mac/fast/forms/listbox-bidi-align-expected.checksum: Added.
        * platform/mac/fast/forms/listbox-bidi-align-expected.png: Added.
        * platform/mac/fast/forms/listbox-bidi-align-expected.txt: Added.
        * platform/mac/fast/text/drawBidiText-expected.checksum: Updated.
        * platform/mac/fast/text/drawBidiText-expected.png: Updated.
2011-03-28  Ofri Wolfus  <ofri@google.com>

        Reviewed by Eric Seidel.

        RTL: Select elements with a size attribute are always left aligned.
        https://bugs.webkit.org/show_bug.cgi?id=50928

        Added support for alignment in RenderListBox.

        Test: fast/forms/listbox-bidi-align.html

        * rendering/RenderListBox.cpp:
        (WebCore::itemOffsetForAlignment):
        (WebCore::RenderListBox::paintItemForeground): Add support for alignment and directionality.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Tue, 29 Mar 2011 06:32:36 +0000 (06:32 +0000)]
2011-03-28  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Benjamin Poulain.

        [Qt] Change TextureMapperVideoLayer to TextureMapperMediaLayer
        https://bugs.webkit.org/show_bug.cgi?id=57142

        TextureMapperMediaLayer is a better name here because both video and plugins use this layer.
        Remove ENABLE(VIDEO) guard.

        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        * platform/graphics/qt/MediaPlayerPrivateQt.h:
        * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
        (WebCore::GraphicsLayerTextureMapper::setContentsToMedia):
        * platform/graphics/texmap/TextureMapperNode.h:
        * platform/graphics/texmap/TextureMapperPlatformLayer.h:
        (WebCore::TextureMapperMediaLayer::layerType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Thomas Klausner <tk@giga.or.at>
commit-queue@webkit.org [Tue, 29 Mar 2011 06:20:08 +0000 (06:20 +0000)]
2011-03-28  Thomas Klausner  <tk@giga.or.at>

        Reviewed by David Levin.

        png-1.5 fixes
        https://bugs.webkit.org/show_bug.cgi?id=54406

        Fix compilation with png-1.5: struct members were hidden, and
        a new API to terminate data processing was added (especially for
        WebKit).

        Compilation fixes, so no new tests.

        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::headerAvailable):
        (WebCore::PNGImageDecoder::rowAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Tue, 29 Mar 2011 06:18:18 +0000 (06:18 +0000)]
2011-03-28  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Adam Barth.

        Replace fprintf(stderr, ...) with LOG_ERROR
        https://bugs.webkit.org/show_bug.cgi?id=57216

        LOG_ERROR is a better choice here.

        * bridge/jni/v8/JavaClassV8.cpp:
        (JavaClass::JavaClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Andrew Foster <andrewf@chromium.org>
commit-queue@webkit.org [Tue, 29 Mar 2011 05:56:08 +0000 (05:56 +0000)]
2011-03-28  Andrew Foster  <andrewf@chromium.org>

        Reviewed by Ojan Vafai.

        webkit-patch should be more intelligent about whether a bug applies to a patch
        Create a new function, parse_bug_id_from_changelog() which determines
        that a bug is related to a patch by parsing the output generated from
        prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
        the description of a patch.
        https://bugs.webkit.org/show_bug.cgi?id=56989

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/changelog.py:
        * Scripts/webkitpy/common/net/bugzilla/__init__.py:
        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
        * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
        * Scripts/webkitpy/style/checkers/changelog.py:
        * Scripts/webkitpy/tool/commands/upload.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Tue, 29 Mar 2011 05:53:57 +0000 (05:53 +0000)]
2011-03-28  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        [Chromium] Inspector does not always shows transferred size correctly (e.g. gzipped/chunked content)
        https://bugs.webkit.org/show_bug.cgi?id=56602

        Added new methods to interface while keeping the old ones to keep
        chromium working until it is also patched.

        * public/WebDevToolsAgent.h:
        * public/WebURLLoaderClient.h:
        (WebKit::WebURLLoaderClient::didReceiveData):
        * src/AssociatedURLLoader.cpp:
        (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
        * src/ResourceHandle.cpp:
        (WebCore::ResourceHandleInternal::didReceiveData):
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::didReceiveData):
        * src/WebDevToolsAgentImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Steve Block <steveblock@google.com>
steveblock@google.com [Tue, 29 Mar 2011 05:41:07 +0000 (05:41 +0000)]
2011-03-28  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Add a new JavaValue to type to represent a Java value in the Java bridge
        https://bugs.webkit.org/show_bug.cgi?id=57022

        This change introduces a new JavaValue type and uses it in place of jvalue
        in the conversions to and from JavaNPObject used in the V8 Java bridge.

        Refactoring only, no new tests.

        * WebCore.gypi:
        * bridge/jni/JNIUtility.cpp:
        (JSC::Bindings::javaTypeFromClassName):
        (JSC::Bindings::signatureFromJavaType):
        (JSC::Bindings::getJNIField):
        (JSC::Bindings::callJNIMethod):
        * bridge/jni/JavaType.h:
        * bridge/jni/v8/JNIUtilityPrivate.cpp:
        (JSC::Bindings::convertNPVariantToJavaValue):
        (JSC::Bindings::convertJavaValueToNPVariant):
        (JSC::Bindings::jvalueToJavaValue):
        (JSC::Bindings::javaValueToJvalue):
        * bridge/jni/v8/JNIUtilityPrivate.h:
        * bridge/jni/v8/JavaNPObjectV8.cpp:
        (JSC::Bindings::JavaNPObjectInvoke):
        (JSC::Bindings::JavaNPObjectGetProperty):
        * bridge/jni/v8/JavaValueV8.h: Added.
        (JSC::Bindings::JavaValue::JavaValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 29 Mar 2011 05:29:03 +0000 (05:29 +0000)]
2011-03-28  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Use String instead of CString as return value of openTemporaryFile
        https://bugs.webkit.org/show_bug.cgi?id=55332

        We usually store all paths as UTF-16. Do this for temporary files too.

        * WebCore.exp.in
        * platform/FileSystem.h:
        * platform/android/FileSystemAndroid.cpp:
        * platform/brew/FileSystemBrew.cpp:
        * platform/efl/FileSystemEfl.cpp:
        * platform/gtk/FileSystemGtk.cpp:
        * platform/haiku/FileSystemHaiku.cpp:
        * platform/mac/FileSystemMac.mm:
        * platform/qt/FileSystemQt.cpp:
        * platform/win/FileSystemWin.cpp:
        * platform/wince/FileSystemWinCE.cpp:
        * platform/wx/FileSystemWx.cpp:
        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::destroyStream):
        * plugins/PluginStream.h:
2011-03-28  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Use String instead of CString as return value of openTemporaryFile
        https://bugs.webkit.org/show_bug.cgi?id=55332

        * Shared/WebMemorySampler.cpp:
        (WebKit::WebMemorySampler::initializeTempLogFile):
        * WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
        (WebKit::NetscapePluginStream::stop):
        * WebProcess/Plugins/Netscape/NetscapePluginStream.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 29 Mar 2011 05:28:10 +0000 (05:28 +0000)]
2011-03-28  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WIN] Remove unused DOMCreateInstance files
        https://bugs.webkit.org/show_bug.cgi?id=57193

        * DOMCreateInstance.cpp: Removed.
        * DOMCreateInstance.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Jeff Johnson <opendarwin@lapcatsoftware.com>
commit-queue@webkit.org [Tue, 29 Mar 2011 05:08:40 +0000 (05:08 +0000)]
2011-03-28  Jeff Johnson  <opendarwin@lapcatsoftware.com>

        Reviewed by Pavel Feldman.

        Web Inspector: empty, non-functional window
        https://bugs.webkit.org/show_bug.cgi?id=56354

        Check whether DOM local storage is enabled
        before attempting to access window.localStorage.

        No new tests.

        * inspector/front-end/Settings.js:
        (WebInspector.Settings.prototype.findSettingForAllProjects):
        (WebInspector.Settings.prototype._get):
        (WebInspector.Settings.prototype._set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 29 Mar 2011 04:57:49 +0000 (04:57 +0000)]
2011-03-28  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed. Clean up Chromium test expectations for plugins/embed-prefers-plugins-for-images.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix test results that were accidentally committed with a wrong
mjs@apple.com [Tue, 29 Mar 2011 04:47:44 +0000 (04:47 +0000)]
Fix test results that were accidentally committed with a wrong
result due to a temporary wrong code change.

* http/tests/uri/username-with-no-hostname-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoplugins/embed-prefers-plugins-for-images.html fails on non-Apple platforms.
aestes@apple.com [Tue, 29 Mar 2011 04:36:28 +0000 (04:36 +0000)]
plugins/embed-prefers-plugins-for-images.html fails on non-Apple platforms.
https://bugs.webkit.org/show_bug.cgi?id=57137

* platform/chromium/test_expectations.txt: Skip the test.
* platform/gtk/Skipped: Ditto.
* platform/qt/Skipped: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake embed-prefers-plugins-for-images.html pass on all Apple platforms.
aestes@apple.com [Tue, 29 Mar 2011 03:47:53 +0000 (03:47 +0000)]
Make embed-prefers-plugins-for-images.html pass on all Apple platforms.
https://bugs.webkit.org/show_bug.cgi?id=57137

* platform/mac-leopard/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
* platform/mac-snowleopard/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
* platform/mac-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
* platform/win/Skipped:
* plugins/embed-prefers-plugins-for-images-expected.txt:
* plugins/embed-prefers-plugins-for-images.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert accidentally commited change.
mjs@apple.com [Tue, 29 Mar 2011 03:04:51 +0000 (03:04 +0000)]
Revert accidentally commited change.

* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=57286 Alternative fix for:
bdakin@apple.com [Tue, 29 Mar 2011 02:39:33 +0000 (02:39 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=57286 Alternative fix for:
Horizontal scroller stops appearing after going Forward
-and corresponding-
<rdar://problem/9026946>

Reviewed by Darin Adler.

This patch rolls out revision 79053 and fixes the same bug in a  better way.

New function resetScrollbarsAndClearContentsSize() calls resetScrollbars() and then
sets the contents size to 0. This is called when a document is going into the page
cache.
* dom/Document.cpp:
(WebCore::Document::setInPageCache):
(WebCore::FrameView::resetScrollbarsAndClearContentsSize):

Roll-out of 79053.
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::layout):
* page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 29 Mar 2011 02:36:16 +0000 (02:36 +0000)]
2011-03-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Antti Koivisto.

        fix style sharing with :any and sibling selectors
        https://bugs.webkit.org/show_bug.cgi?id=57211

        Also tests sibling selector style sharing in general since
        no existing tests seem to cover that codepath.

        * fast/css/sibling-selectors-expected.txt: Added.
        * fast/css/sibling-selectors.html: Added.
2011-03-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Antti Koivisto.

        fix style sharing with :any and sibling selectors
        https://bugs.webkit.org/show_bug.cgi?id=57211

        Test: fast/css/sibling-selectors.html

        * css/CSSStyleSelector.cpp:
        (WebCore::collectFeaturesFromList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 29 Mar 2011 02:30:37 +0000 (02:30 +0000)]
2011-03-27  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Antti Koivisto.

        fix :-webkit-any(:last-child)
        https://bugs.webkit.org/show_bug.cgi?id=57207

        * fast/css/pseudo-any.html:
2011-03-27  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Antti Koivisto.

        fix :-webkit-any(:last-child)
        https://bugs.webkit.org/show_bug.cgi?id=57207

        We were passing the wrong arguments to checkSelector. Also, we were not
        passing through the encounteredLink bool.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
        * css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCheck in failing results for embed-prefers-plugins-for-images-expected.txt in Mac...
aestes@apple.com [Tue, 29 Mar 2011 01:45:03 +0000 (01:45 +0000)]
Check in failing results for embed-prefers-plugins-for-images-expected.txt in Mac WK2 mode.
https://bugs.webkit.org/show_bug.cgi?id=57137

* platform/mac-wk2/plugins: Added.
* platform/mac-wk2/plugins/embed-prefers-plugins-for-images-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82182 268f45cc-cd09-0410-ab3c-d52691b4dbfc