WebKit-https.git
9 years agoBuild fix. Forgot to merge args.
rniwa@webkit.org [Thu, 25 Apr 2013 19:50:03 +0000 (19:50 +0000)]
Build fix. Forgot to merge args.

* Scripts/webkitpy/tool/bot/irc_command.py:
(Hi.execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitbot should recognize its own nickname in greetings.
rniwa@webkit.org [Thu, 25 Apr 2013 19:44:20 +0000 (19:44 +0000)]
webkitbot should recognize its own nickname in greetings.
https://bugs.webkit.org/show_bug.cgi?id=115196

Reviewed by Andreas Kling.

Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.

* Scripts/webkitpy/tool/bot/irc_command.py:
(Hi.execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoScriptExecutionContext log exception should include a column number
joepeck@webkit.org [Thu, 25 Apr 2013 19:31:50 +0000 (19:31 +0000)]
ScriptExecutionContext log exception should include a column number
https://bugs.webkit.org/show_bug.cgi?id=114315

Reviewed by Oliver Hunt.

Source/WebCore:

Test: inspector/console/console-exception-stack-traces.html

* bindings/js/ScriptCallStackFactory.h:
* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackFromException):
Generate a ScriptCallStack from an exception. Use the vm.exceptionStack
if available, and fallback to the exception object where needed.

* bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
Always include a non-empty call stack with exceptions.
Where not provided, fallback to the exception object.

* dom/Document.h:
* dom/Document.cpp:
(WebCore::Document::logExceptionToConsole):
* dom/ScriptExecutionContext.h:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::PendingException::PendingException):
(ScriptExecutionContext::PendingException):
(WebCore::ScriptExecutionContext::reportException):
* workers/DefaultSharedWorkerRepository.cpp:
* workers/SharedWorkerContext.cpp:
(WebCore::SharedWorkerContext::logExceptionToConsole):
* workers/SharedWorkerContext.h:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::logExceptionToConsole):
* workers/WorkerContext.h:
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerExceptionTask::performTask):
Plumb columnNumber through as needed.

LayoutTests:

* inspector/console/console-exception-stack-traces-expected.txt: Added.
* inspector/console/console-exception-stack-traces.html: Added.
Verifies that exceptions have stack traces and match a console.trace stack.

* http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Removed.
* http/tests/inspector-enabled/console-exception-while-no-inspector.html: Removed.
We now save exception backtraces even if the inspector is not open.

* fast/dom/javascript-url-exception-isolation-expected.txt
* fast/events/remove-target-with-shadow-in-drag-expected.txt
* fast/events/set-attribute-listener-window-onerror-crash-expected.txt
* inspector-protocol/media-query-listener-exception-expected.txt:
* inspector/console/console-uncaught-exception-expected.txt:
* inspector/console/console-uncaught-exception-in-eval-expected.txt:
Update results that now include backtraces or different data. Most better, some worse.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake checkSyntax take a VM instead of an ExecState
oliver@apple.com [Thu, 25 Apr 2013 18:59:50 +0000 (18:59 +0000)]
Make checkSyntax take a VM instead of an ExecState

RS=Tim

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build files so WebGLDebugXXX extensions can be used if enabled.
gman@chromium.org [Thu, 25 Apr 2013 18:50:46 +0000 (18:50 +0000)]
Fix build files so WebGLDebugXXX extensions can be used if enabled.
https://bugs.webkit.org/show_bug.cgi?id=113976

Reviewed by Dean Jackson.

No new tests as no new functionality.

* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSWebGLRenderingContextCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago32 Bit: Crash due to RegExpTest nodes not setting result type to Boolean
msaboff@apple.com [Thu, 25 Apr 2013 18:35:04 +0000 (18:35 +0000)]
32 Bit: Crash due to RegExpTest nodes not setting result type to Boolean
https://bugs.webkit.org/show_bug.cgi?id=115188

Reviewed by Geoffrey Garen.

Changed the RegExpTest node to set the AbstractValue to boolean, since that
what it is.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocloneChildNodes looks for deleteButtonController in each level of recursion
rniwa@webkit.org [Thu, 25 Apr 2013 18:33:22 +0000 (18:33 +0000)]
cloneChildNodes looks for deleteButtonController in each level of recursion
https://bugs.webkit.org/show_bug.cgi?id=115146

Reviewed by Andreas Kling.

Obtain the delete button controller upfront, and shallow copy descendents of each child
so that we don't look for the delete button controller inside cloneNode called on each child.

Performance Tests: DOM/CloneNodes.html

* dom/ContainerNode.cpp:
(WebCore::cloneChildNodesAvoidingDeleteButon): Extracted.
(WebCore::ContainerNode::cloneChildNodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHTMLOptionsCollection's namedItem and name getter should return the first item
rniwa@webkit.org [Thu, 25 Apr 2013 18:32:06 +0000 (18:32 +0000)]
HTMLOptionsCollection's namedItem and name getter should return the first item
https://bugs.webkit.org/show_bug.cgi?id=115150

Reviewed by Andreas Kling.

Source/WebCore:

Following the resolution in http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2012-December/038355.html,
the spefication has been updated to only return the first item when there are multiple items of the same name
in HTMLOptionsCollection; this new behavior matches that of Firefox and Opera (Presto).

Implement this new behavior to remove the custom binding code and use the fast path in namedItem and name
getter of HTMLOptionsCollection. (Obtaining all items for a given name is expensive!).

Tests: fast/dom/HTMLSelectElement/named-options.html
       fast/dom/html-collections-named-getter.html

* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore): Removed the custom bindings for name getter and namedItem.
* html/HTMLOptionsCollection.idl:

LayoutTests:

Changed the expectations of the tests.

* fast/dom/HTMLSelectElement/named-options-expected.txt:
* fast/dom/HTMLSelectElement/script-tests/named-options.js:
* fast/dom/html-collections-named-getter-expected.txt:
* fast/dom/html-collections-named-getter.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: ConsoleMessage should include line and column number where possible
joepeck@webkit.org [Thu, 25 Apr 2013 18:31:05 +0000 (18:31 +0000)]
Web Inspector: ConsoleMessage should include line and column number where possible
https://bugs.webkit.org/show_bug.cgi?id=114929

Source/WebCore:

  - adds "m_column" to WebCore::ConsoleMessage
  - adds "column" to Console.ConsoleMessage in the inspector protocol
  - set the column number for console.* functions (Console.cpp)
  - set the column number for XSLT errors (XSLTProcessor)
  - plumb columnNumber everywhere else it is needed, set it to 0 and file
    bugs for all cases missing columnNumber that could provide it.

Reviewed by Timothy Hatcher.

Test: inspector/console/console-url-line-column.html
      inspector/console/console-messages-stack-traces.html

* inspector/ConsoleMessage.h:
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::ConsoleMessage::autogenerateMetadata):
(WebCore::ConsoleMessage::addToFrontend):
(WebCore::ConsoleMessage::isEqual):
Add m_column and set it where appropriate.

* inspector/Inspector.json:
Add column property to Console.ConsoleMessage.

* page/Console.cpp:
(WebCore::internalAddMessage):
(WebCore::Console::profile):
Set columnNumber like lineNumber from the last stack frame.
(WebCore::Console::groupEnd):
Line and column are unused in this message type, set both to 0.

* xml/XSLTProcessorLibxslt.cpp:
(WebCore::XSLTProcessor::parseErrorFunc):
* xml/XSLTProcessorQt.cpp:
(WebCore::XSLTMessageHandler::handleMessage):
Add real column numbers, the XSLT handlers already had it available.

* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
* css/CSSParser.cpp:
(WebCore::CSSParser::logError):
* dom/ScriptExecutionContext.h:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::addConsoleMessage):
* dom/Document.cpp:
(WebCore::Document::logExceptionToConsole):
(WebCore::Document::addMessage):
* dom/Document.h:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::addMessageToConsole):
(WebCore::InspectorConsoleAgent::stopTiming):
(WebCore::InspectorConsoleAgent::didFinishXHRLoading):
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::addMessageToConsole):
(WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
(WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
(WebCore::InspectorInstrumentation::addProfileImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::addProfile):
(WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
(WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
(WebCore::InspectorProfilerAgent::start):
(WebCore::InspectorProfilerAgent::stop):
* inspector/InspectorProfilerAgent.h:
(InspectorProfilerAgent):
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::addMessageToConsole):
* page/ChromeClient.h:
(WebCore::ChromeClient::addMessageToConsole):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::logToConsole):
* page/PageConsole.cpp:
(WebCore::PageConsole::addMessage):
* page/PageConsole.h:
* workers/DefaultSharedWorkerRepository.cpp:
(SharedWorkerProxy):
(WebCore::postExceptionTask):
(WebCore::SharedWorkerProxy::postExceptionToWorkerObject):
(WebCore::postConsoleMessageTask):
(WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
* workers/SharedWorkerContext.cpp:
(WebCore::SharedWorkerContext::logExceptionToConsole):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::logExceptionToConsole):
(WebCore::WorkerContext::addConsoleMessage):
(WebCore::WorkerContext::addMessage):
(WebCore::WorkerContext::addMessageToWorkerConsole):
* workers/WorkerContext.h:
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerExceptionTask::create):
(WebCore::WorkerExceptionTask::WorkerExceptionTask):
(WebCore::WorkerExceptionTask::performTask):
(WorkerExceptionTask):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::postConsoleMessageTask):
(WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
* workers/WorkerMessagingProxy.h:
(WorkerMessagingProxy):
* workers/WorkerReportingProxy.h:
(WorkerReportingProxy):
Plumb columnNumber through where appropriate. File bugs where missing.

Source/WebKit/blackberry:

Reviewed by Timothy Hatcher.

* Api/DumpRenderTreeClient.h:
* Api/WebPageClient.h:
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::addMessageToConsole):
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):

Source/WebKit/efl:

Reviewed by Timothy Hatcher.

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::addMessageToConsole):
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):

Source/WebKit/gtk:

Reviewed by Timothy Hatcher.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::addMessageToConsole):
* WebCoreSupport/ChromeClientGtk.h:
(ChromeClient):

Source/WebKit/mac:

Reviewed by Timothy Hatcher.

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::addMessageToConsole):

Source/WebKit/qt:

Reviewed by Timothy Hatcher.

* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::addMessageToConsole):
* WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

Reviewed by Timothy Hatcher.

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::addMessageToConsole):
* WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

Reviewed by Timothy Hatcher.

* WebCoreSupport/ChromeClientWinCE.cpp:
(WebKit::ChromeClientWinCE::addMessageToConsole):
* WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit2:

Reviewed by Timothy Hatcher.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::addMessageToConsole):
* WebProcess/WebCoreSupport/WebChromeClient.h:

LayoutTests:

Update a test that was outputting the url and line number of console
method calls, to output the column number as well. Added a test that
verifies that console API messages have stack traces if appropriate.

Reviewed by Timothy Hatcher.

* inspector/console/console-url-and-line-expected.txt: Removed.
* inspector/console/console-url-line-column-expected.txt: Added.
* inspector/console/console-url-line-column.html: Renamed from LayoutTests/inspector/console/console-url-and-line.html.
* inspector/console/console-messages-stack-traces-expected.txt: Added.
* inspector/console/console-messages-stack-traces.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Get rid of return in void method
commit-queue@webkit.org [Thu, 25 Apr 2013 18:29:07 +0000 (18:29 +0000)]
[BlackBerry] Get rid of return in void method
https://bugs.webkit.org/show_bug.cgi?id=115186

Patch by Konrad Piascik <kpiascik@blackberry.com> on 2013-04-25
Reviewed by Rob Buis.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setForcedTextEncoding):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Animated opacity does not trigger accelerated compositing
allan.jensen@digia.com [Thu, 25 Apr 2013 18:19:05 +0000 (18:19 +0000)]
[Qt] Animated opacity does not trigger accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=115107

Reviewed by Simon Fraser.

Source/WebCore:

Add extra option to also trigger compositing on animated opacity.

* page/ChromeClient.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):

Source/WebKit/qt:

We should trigger compositing on animated opacity as it is always faster on Qt.

* WebCoreSupport/ChromeClientQt.cpp:
VideoTrigger removed because we have already disabled AC for video in qwebsettings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Adding myself to the reviwers list.
achicu@adobe.com [Thu, 25 Apr 2013 18:09:10 +0000 (18:09 +0000)]
Unreviewed. Adding myself to the reviwers list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThread safety issues in WKCustomProtocol.
beidson@apple.com [Thu, 25 Apr 2013 17:59:07 +0000 (17:59 +0000)]
Thread safety issues in WKCustomProtocol.
<rdar://problem/13247304> and https://bugs.webkit.org/show_bug.cgi?id=115185

Reviewed by Alexey Proskuryakov.

* Shared/Network/CustomProtocols/CustomProtocolManager.h:

* Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
(WebKit::CustomProtocolManager::addCustomProtocol): Protect m_customProtocolMap with its mutex.
(WebKit::CustomProtocolManager::removeCustomProtocol): Ditto.
(WebKit::CustomProtocolManager::didFailWithError):
(WebKit::CustomProtocolManager::didLoadData):
(WebKit::CustomProtocolManager::didReceiveResponse):
(WebKit::CustomProtocolManager::didFinishLoading):
(WebKit::CustomProtocolManager::protocolForID): Protect m_customProtocolMap with its mutex, and return
  a RetainPtr instead of a raw pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSec-WebSocket-Extensions header field must not appear more than once in an HTTP response.
commit-queue@webkit.org [Thu, 25 Apr 2013 17:48:58 +0000 (17:48 +0000)]
Sec-WebSocket-Extensions header field must not appear more than once in an HTTP response.
https://bugs.webkit.org/show_bug.cgi?id=115128

Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-04-25
Reviewed by Alexey Proskuryakov.

Source/WebCore:

According to WebSocket specification Sec-WebSocket-Extensions header field
must not appear more than once in an HTTP response. It is ok if it appears
more than once in client request. Also add a check for invalid UTF-8
characters when parsing Sec-WebSocket-Extensions quoted string.

Test: http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header.html

* Modules/websockets/WebSocketExtensionParser.cpp:
(WebCore::WebSocketExtensionParser::consumeQuotedString): Return false if there is
invalid character in the quoted string being parsed.
* Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::readHTTPHeaders): Check if Sec-WebSocket-Extensions
appears more than once in header response. Abort handshake if it does.

LayoutTests:

* http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header-expected.txt: Added.
* http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header.html: Added.
* http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header_wsh.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFurther build fixes: correct two more misnames of WebProcessShim.dyld.
jer.noble@apple.com [Thu, 25 Apr 2013 17:31:05 +0000 (17:31 +0000)]
Further build fixes: correct two more misnames of WebProcessShim.dyld.

* WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
(WebKit::WebContentProcessMainDelegate::doPreInitializationWork):
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake gobject-introspection warnings non-fatal
mrobinson@webkit.org [Thu, 25 Apr 2013 17:12:30 +0000 (17:12 +0000)]
Make gobject-introspection warnings non-fatal
https://bugs.webkit.org/show_bug.cgi?id=115184

Reviewed by Carlos Garcia Campos.

* GNUmakefile.am: Make it so that gobject-introspection errors do not fail the buld
until we get to a point where gobject-introspection gives consistent warnings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Add WebKitWebViewGroup to WebKit2 GTK+ API
carlosgc@webkit.org [Thu, 25 Apr 2013 16:46:55 +0000 (16:46 +0000)]
[GTK] Add WebKitWebViewGroup to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=111265

Reviewed by Anders Carlsson.

In the current API the settings are always shared by all web
views, because they are always created on the default page
group. This makes impossible to have different settings on
different web views. Expose the page group in the API,
so that users can create web views on a group different than the
default one to have their own settings.

* GNUmakefile.list.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitSettings.cpp:
(webkitSettingsGetPreferences): Helper private method to get the
WebPreferences wrapped by a WebKitSettings object.
* UIProcess/API/gtk/WebKitSettingsPrivate.h:
* UIProcess/API/gtk/WebKitWebContext.cpp:
(_WebKitWebContextPrivate): Add a default WebKitWebViewGroup.
(webkitWebContextCreatePageForWebView): Create the WebPageProxy
with the WebPageGroup of the given WebKitWebViewGroup.
(webkitWebContextGetDefaultWebViewGroup): Helper private method to
get the default WebKitWebViewGroup.
* UIProcess/API/gtk/WebKitWebContextPrivate.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(_WebKitWebViewPrivate): Add a WebKitWebViewGroup in case the view
is created with a group.
(webkitWebViewUpdateSettings): Keep a reference of the group
settings to be able to disconnect the signals when the settings
object is replaced in the view group and connect to the signals
for the custom settings.
(webkitWebViewSettingsChanged): Disconnect the signals for the
previous settings and set the new settings.
(webkitWebViewDisconnectSettingsChangedSignalHandler): Disconnect
notify::settings signal of WebKitWebViewGroup.
(webkitWebViewConstructed): Pass the current WebKitWebViewGroup to
webkitWebContextCreatePageForWebView().
(webkitWebViewSetProperty): Add setter for group property.
(webkitWebViewGetProperty): Add getter for group property.
(webkitWebViewDispose): Call
webkitWebViewDisconnectSettingsChangedSignalHandler().
(webkit_web_view_class_init): Add WebKitWebView:group property.
(webkitWebViewHandleAuthenticationChallenge): Use
webkit_web_view_get_settings().
(webkit_web_view_new_with_group): Create a new web view with the
given WebKitWebViewGroup.
(webkit_web_view_get_group): Return the current WebKitWebViewGroup
or the default one if the view was not created with
webkit_web_view_new_with_group().
(webkit_web_view_set_settings): Set the settings of the current
WebKitWebViewGroup.
(webkit_web_view_get_settings): Get the settings of the current
WebKitWebViewGroup.
(webkit_web_view_set_zoom_level): Use
webkit_web_view_get_settings().
(webkit_web_view_get_zoom_level): Ditto.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/WebKitWebViewGroup.cpp: Added.
(_WebKitWebViewGroupPrivate):
(webkitWebViewGroupSetProperty):
(webkitWebViewGroupGetProperty):
(webkitWebViewGroupConstructed):
(webkit_web_view_group_class_init):
(webkitWebViewGroupAttachSettingsToPageGroup): Set the
WebPreferences of the current WebKitSettings to the WebPageGroup.
(webkitWebViewGroupCreate): Create a new WebKitWebViewGroup for
the given WebPageGroup.
(webkitWebViewGroupGetPageGroup): Helper private method to get the
WebPageGroup wrapped by the WebKitWebViewGroup.
(webkit_web_view_group_new): Create a new WebKitWebViewGroup.
(webkit_web_view_group_get_name): Return the name of a
WebKitWebViewGroup.
(webkit_web_view_group_get_settings): Get the settings of a
WebKitWebViewGroup.
(webkit_web_view_group_set_settings): Set new settings of a
WebKitWebViewGroup.
* UIProcess/API/gtk/WebKitWebViewGroup.h: Added.
(_WebKitWebViewGroup):
(_WebKitWebViewGroupClass):
* UIProcess/API/gtk/WebKitWebViewGroupPrivate.h: Added.
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add
WebKitWebViewGroup section.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/docs/webkit2gtk.types: Add
webkit_web_view_group_get_type.
* UIProcess/API/gtk/tests/GNUmakefile.am: Add new files to
compilation.
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewSettings): We can't watch settings in the default view
group anymore, because they are not released with the web view but
with the web context that is freed after the Test destructor.
* UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp: Added.
(testWebViewGroupDefault):
(testWebViewGroupNewGroup):
(testWebViewNewWithGroup):
(testWebViewGroupSettings):
(beforeAll):
(afterAll):
* UIProcess/API/gtk/webkit2.h: Include WebKitWebViewGroup.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Windows] Compile fix.
commit-queue@webkit.org [Thu, 25 Apr 2013 16:39:56 +0000 (16:39 +0000)]
[Windows] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=115170

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-04-25
Reviewed by Filip Pizlo.

Forward declare function, instead of including intrin.h.

* wtf/Atomics.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r148758): Remove WTFLogAlways call from IconLoader.
rakuco@webkit.org [Thu, 25 Apr 2013 16:32:51 +0000 (16:32 +0000)]
REGRESSION(r148758): Remove WTFLogAlways call from IconLoader.
https://bugs.webkit.org/show_bug.cgi?id=115182

Reviewed by Dan Bernstein.

The call added in r148758 was apparently a leftover from some debugging
session, and it makes the Interactive/window-resize.html performance
test randomly fail on Qt and EFL due to WTFLogAlways writing to stderr.

* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::notifyFinished):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r137994): Random crashes occur with SH4 JSC.
commit-queue@webkit.org [Thu, 25 Apr 2013 16:18:43 +0000 (16:18 +0000)]
REGRESSION(r137994): Random crashes occur with SH4 JSC.
https://bugs.webkit.org/show_bug.cgi?id=115167.

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-04-25
Reviewed by Oliver Hunt.

Since r137994, uncommited pages could be inside the area of memory in
parameter of the cacheFlush function. That's why we have to flush each
page separately to avoid a fail of the whole flush, if an uncommited page
is in the area.

This patch is very similar to changeset 145194 made for ARMv7 architecture,
see https://bugs.webkit.org/show_bug.cgi?id=111441 for further information.

* assembler/SH4Assembler.h:
(JSC::SH4Assembler::cacheFlush):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for Web IDL callback interfaces to the bindings generator
ch.dumez@sisa.samsung.com [Thu, 25 Apr 2013 15:55:12 +0000 (15:55 +0000)]
Add support for Web IDL callback interfaces to the bindings generator
https://bugs.webkit.org/show_bug.cgi?id=115179

Reviewed by Kentaro Hara.

Add support in the bindings generator for Web IDL callback interfaces:
http://dev.w3.org/2006/webapi/WebIDL/#dfn-callback-interface

Drop support for the WebKit-specific [Callback] extended attributes
on Web IDL interfaces and update existing IDL files to use proper
callback interfaces instead.

No new tests, no behavior change.

* Modules/filesystem/EntriesCallback.idl:
* Modules/filesystem/EntryCallback.idl:
* Modules/filesystem/ErrorCallback.idl:
* Modules/filesystem/FileCallback.idl:
* Modules/filesystem/FileSystemCallback.idl:
* Modules/filesystem/FileWriterCallback.idl:
* Modules/filesystem/MetadataCallback.idl:
* Modules/geolocation/PositionCallback.idl:
* Modules/geolocation/PositionErrorCallback.idl:
* Modules/mediastream/NavigatorUserMediaErrorCallback.idl:
* Modules/mediastream/NavigatorUserMediaSuccessCallback.idl:
* Modules/mediastream/RTCErrorCallback.idl:
* Modules/mediastream/RTCSessionDescriptionCallback.idl:
* Modules/mediastream/RTCStatsCallback.idl:
* Modules/notifications/NotificationPermissionCallback.idl:
* Modules/quota/StorageErrorCallback.idl:
* Modules/quota/StorageQuotaCallback.idl:
* Modules/quota/StorageUsageCallback.idl:
* Modules/webaudio/AudioBufferCallback.idl:
* Modules/webdatabase/DatabaseCallback.idl:
* Modules/webdatabase/SQLStatementCallback.idl:
* Modules/webdatabase/SQLStatementErrorCallback.idl:
* Modules/webdatabase/SQLTransactionCallback.idl:
* Modules/webdatabase/SQLTransactionErrorCallback.idl:
* Modules/webdatabase/SQLTransactionSyncCallback.idl:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateInterface):
* bindings/scripts/IDLParser.pm:
(parseCallbackRestOrInterface):
* bindings/scripts/test/TestCallback.idl:
* dom/RequestAnimationFrameCallback.idl:
* dom/StringCallback.idl:
* html/VoidCallback.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse std::move in AtomicString
mikhail.pozdnyakov@intel.com [Thu, 25 Apr 2013 15:17:57 +0000 (15:17 +0000)]
Use std::move in AtomicString
https://bugs.webkit.org/show_bug.cgi?id=115102

Reviewed by Anders Carlsson.

Use std::move in AtomicString instead of direct casting to rvalue references.

* wtf/text/AtomicString.h:
(AtomicString):
(WTF::AtomicString::AtomicString):
(WTF::AtomicString::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GStreamer] Add audio/speex MIME type as supported
commit-queue@webkit.org [Thu, 25 Apr 2013 14:52:27 +0000 (14:52 +0000)]
[GStreamer] Add audio/speex MIME type as supported
https://bugs.webkit.org/show_bug.cgi?id=115032

Patch by Adrian Perez de Castro <aperez@igalia.com> on 2013-04-25
Reviewed by Philippe Normand.

Source/WebCore:

GStreamer has support for the Speex codec (http://www.speex.org).
Speex streams may be embedded in a Ogg container, or standalone.
The case of the Ogg container is already covered by the "*/ogg"
MIME types declared as supported by the GStreamer media playing
code, but for standalone streams to work, "audio/speex" has to
be added.

With this, and the needed GStreamer plugin installed, the GTK+
launcher is able to correctly play Speex streams served with
"Content-type: audio/speex".

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

LayoutTests:

Speex (http://www.speex.org) streams can be embedded into Ogg
Ogg containers, so add a check for it in the test case.

* media/media-can-play-ogg-expected.txt:
* media/media-can-play-ogg.html:
* platform/blackberry/media/media-can-play-ogg-expected.txt:
* platform/mac/media/media-can-play-ogg-expected.txt:
* platform/qt-linux/media/media-can-play-ogg-expected.txt:
* platform/win/media/media-can-play-ogg-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd FINAL decorators to the InlineBox class hierarchy.
akling@apple.com [Thu, 25 Apr 2013 14:33:54 +0000 (14:33 +0000)]
Add FINAL decorators to the InlineBox class hierarchy.
<http://webkit.org/b/115177>

Reviewed by Antti Koivisto.

From Blink r148628 by <cevans@chromium.org>:

FINAL is a macro in wtf/Compiler.h that does the correct thing if the compiler does not support "final")
The approach used is as simple as possible whilst being thorough.
So, leaf classes have FINAL applied to the whole class whereas intermediary classes have FINAL applied to relevant methods.

FINAL allows a compiler to devirtualize call sites and turn them into direct calls. As you might expect, this is perf positive:
(clang on Linux):
- line_layout.html goes from 120 runs/s -> 123 runs/2, +2.5%
- html5-full-render.html goes from 3176ms -> 3162ms, +0.4%

I have confidence that the former result is statistically significant (as the numbers are very very stable) but not the latter.

* rendering/EllipsisBox.h:
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.h:
* rendering/RootInlineBox.h:
* rendering/TrailingFloatsRootInlineBox.h:
* rendering/svg/SVGInlineFlowBox.h:
* rendering/svg/SVGInlineTextBox.h:
* rendering/svg/SVGRootInlineBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Tools/gtk/install-dependencies added ragel dependency
commit-queue@webkit.org [Thu, 25 Apr 2013 14:19:40 +0000 (14:19 +0000)]
[GTK] Tools/gtk/install-dependencies added ragel dependency
https://bugs.webkit.org/show_bug.cgi?id=115163

Patch by Xavier Castano <xcastanho@igalia.com> on 2013-04-25
Reviewed by Xan Lopez.

The install-dependencies script was missing a dependency on ragel
which is expected when building HarfBuzz.

* gtk/install-dependencies: Added a dependency on ragel for both
apt and yum.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Remove pango from optional jhbuild dependencies
commit-queue@webkit.org [Thu, 25 Apr 2013 14:05:51 +0000 (14:05 +0000)]
[GTK] Remove pango from optional jhbuild dependencies
https://bugs.webkit.org/show_bug.cgi?id=115162

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-04-25
Reviewed by Martin Robinson.

Pango is not needed since revision r148293 that lowers the pango
dependency to 1.30, which is available in most distributions.

* gtk/jhbuild-optional.modules: Removes description of pango module.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix: Fix the name of DyldInterpose.h in
jer.noble@apple.com [Thu, 25 Apr 2013 13:46:17 +0000 (13:46 +0000)]
Unreviewed build fix: Fix the name of DyldInterpose.h in
SecItemShimLibrary.mm, fix the name of WebProcessShim.dyld in
WebContentServiceEntryPoint.mm, and stop linking against libWTF.a
directly (which means removing ASSERTs from
CookieStorageShimLibrary.cpp).

* Shared/mac/CookieStorageShimLibrary.cpp:
(WebKit::shimCFHTTPCookieStorageCopyRequestHeaderFieldsForURL):
(WebKit::WebKitCookieStorageShimInitialize):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(WebContentServiceInitializer):
* WebProcess/mac/SecItemShimLibrary.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS parser: Add error recovery while parsing @-webkit-keyframes key values.
akling@apple.com [Thu, 25 Apr 2013 13:43:33 +0000 (13:43 +0000)]
CSS parser: Add error recovery while parsing @-webkit-keyframes key values.
<http://webkit.org/b/115175>

Source/WebCore:

From Blink r148714 by <apavlov@chromium.org>:

If not a percentage, "from", or "to" value is used in a key list, the rule is erroneous,
and due to the absense of recovery, the parser skips the following, valid CSS rule.

On a related note, keyframes, whose selectors contain invalid keys, should be discarded
altogether, according to <http://www.w3.org/TR/css3-animations/#keyframes>

Tests: animations/keyframes-invalid-keys.html
       fast/css/webkit-keyframes-errors.html

* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParser::rewriteSpecifiers):

LayoutTests:

From Blink r148714 by <apavlov@chromium.org>.

* animations/keyframes-invalid-keys-expected.txt: Added.
* animations/keyframes-invalid-keys.html: Added.
* fast/css/webkit-keyframes-errors-expected.html: Added.
* fast/css/webkit-keyframes-errors.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r147797): Animations slideshows of images on www.thesuperficial.com are...
antti@apple.com [Thu, 25 Apr 2013 13:23:47 +0000 (13:23 +0000)]
REGRESSION (r147797): Animations slideshows of images on thesuperficial.com are slow
https://bugs.webkit.org/show_bug.cgi?id=115172

Reviewed by Andreas Kling.

On this page ads dynamically loaded to subframes on slideshow navigation switch us to state where we throttle layer flushes.

Fix by ignoring any subframe-originated loads when determining throttling.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadProgressingStatusChanged):
* loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::isMainLoadProgressing):

    Rename, ignore subframe originated loads. Subframe loads that are initiated during the main load still count.

* loader/ProgressTracker.h:
(ProgressTracker):
* page/FrameView.cpp:
(WebCore::FrameView::updateLayerFlushThrottlingInAllFrames):
* page/FrameView.h:
(FrameView):
* rendering/RenderLayerBacking.cpp:
(WebCore::computeTileCoverage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Skip some failing tests after r148996.
kadam@inf.u-szeged.hu [Thu, 25 Apr 2013 13:10:15 +0000 (13:10 +0000)]
[Qt] Unreviewed gardening. Skip some failing tests after r148996.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove Chromium-specific cases from FeatureList.pm
commit-queue@webkit.org [Thu, 25 Apr 2013 13:04:05 +0000 (13:04 +0000)]
Remove Chromium-specific cases from FeatureList.pm
https://bugs.webkit.org/show_bug.cgi?id=115169

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-25
Reviewed by Andreas Kling.

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSVG: Fix viewBox animations on shapes with non-scaling-stroke.
akling@apple.com [Thu, 25 Apr 2013 12:56:20 +0000 (12:56 +0000)]
SVG: Fix viewBox animations on shapes with non-scaling-stroke.
<http://webkit.org/b/115173>

Source/WebCore:

From Blink r149058 by <pdr@chromium.org>:

Previously hasAttribute() to determine if a viewBox was set in the transform
code for non-scaling-strokes. hasAttribute() should not be used in this case,
as it will return false if the attribute is not set but the value is animating.

This patch switches to checking if the viewBox is empty instead of checking for
the presence of the attribute.

Test: svg/stroke/animated-non-scaling-stroke.html

* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::localCoordinateSpaceTransform):
* svg/SVGSVGElement.h:
(WebCore::SVGSVGElement::hasEmptyViewBox):

LayoutTests:

From Blink r149058 by <pdr@chromium.org>.

* svg/stroke/animated-non-scaling-stroke-expected.html: Added.
* svg/stroke/animated-non-scaling-stroke.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove isPluginElement hack in Document::setFocusedNode()
akling@apple.com [Thu, 25 Apr 2013 12:32:49 +0000 (12:32 +0000)]
Remove isPluginElement hack in Document::setFocusedNode()
<http://webkit.org/b/115171>

From Blink r148800 by <tkent@chromium.org>:

This hack is no longer necessary because r147591 made isFocusable for plugin
elements work correctly.

* dom/Document.cpp:
(WebCore::Document::setFocusedNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Unskip now passing tests.
kadam@inf.u-szeged.hu [Thu, 25 Apr 2013 12:13:33 +0000 (12:13 +0000)]
[Qt] Unreviewed gardening. Unskip now passing tests.

* platform/qt-5.0-wk1/TestExpectations:
* platform/qt-5.0-wk2/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Organize expected files after r149095.
kadam@inf.u-szeged.hu [Thu, 25 Apr 2013 10:49:09 +0000 (10:49 +0000)]
[Qt] Unreviewed gardening. Organize expected files after r149095.

* platform/qt-5.0-wk1/editing/deleting/delete-by-word-002-expected.txt: Copied from LayoutTests/platform/qt/editing/deleting/delete-by-word-002-expected.txt.
* platform/qt-5.0-wk1/editing/deleting/delete-cell-contents-expected.txt: Copied from LayoutTests/platform/qt/editing/deleting/delete-cell-contents-expected.txt.
* platform/qt-5.0-wk1/editing/execCommand/button-expected.txt: Copied from LayoutTests/platform/qt/editing/execCommand/button-expected.txt.
* platform/qt-5.0-wk1/editing/execCommand/createLink-expected.txt: Copied from LayoutTests/platform/qt/editing/execCommand/createLink-expected.txt.
* platform/qt-5.0-wk1/editing/execCommand/indent-pre-expected.txt: Copied from LayoutTests/platform/qt/editing/execCommand/indent-pre-expected.txt.
* platform/qt-5.0-wk1/editing/execCommand/unlink-expected.txt: Copied from LayoutTests/platform/qt/editing/execCommand/unlink-expected.txt.
* platform/qt-5.0-wk1/editing/input/emacs-ctrl-o-expected.txt: Copied from LayoutTests/platform/qt/editing/input/emacs-ctrl-o-expected.txt.
* platform/qt-5.0-wk1/editing/inserting/insert-before-link-1-expected.txt: Copied from LayoutTests/platform/qt/editing/inserting/insert-before-link-1-expected.txt.
* platform/qt-5.0-wk1/editing/pasteboard/display-block-on-spans-expected.txt: Copied from LayoutTests/platform/qt/editing/pasteboard/display-block-on-spans-expected.txt.
* platform/qt-5.0-wk1/editing/pasteboard/emacs-cntl-y-001-expected.txt: Copied from LayoutTests/platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.txt.
* platform/qt-5.0-wk1/editing/pasteboard/merge-end-list-2-expected.txt: Copied from LayoutTests/platform/qt/editing/pasteboard/merge-end-list-2-expected.txt.
* platform/qt-5.0-wk1/editing/pasteboard/merge-end-table-2-expected.txt: Copied from LayoutTests/platform/qt/editing/pasteboard/merge-end-table-2-expected.txt.
* platform/qt-5.0-wk1/editing/pasteboard/page-zoom-expected.txt: Copied from LayoutTests/platform/qt/editing/pasteboard/page-zoom-expected.txt.
* platform/qt-5.0-wk1/editing/selection/extend-selection-word-expected.txt: Copied from LayoutTests/platform/qt/editing/selection/extend-selection-word-expected.txt.
* platform/qt-5.0-wk1/editing/style/apply-through-end-of-document-expected.txt: Copied from LayoutTests/platform/qt/editing/style/apply-through-end-of-document-expected.txt.
* platform/qt-5.0-wk1/editing/style/remove-underline-across-paragraph-expected.txt: Copied from LayoutTests/platform/qt/editing/style/remove-underline-across-paragraph-expected.txt.
* platform/qt-5.0-wk1/editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Copied from LayoutTests/platform/qt/editing/style/remove-underline-across-paragraph-in-bold-expected.txt.
* platform/qt-5.0-wk1/editing/style/remove-underline-expected.txt: Copied from LayoutTests/platform/qt/editing/style/remove-underline-expected.txt.
* platform/qt-5.0-wk1/editing/style/remove-underline-from-stylesheet-expected.txt: Copied from LayoutTests/platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt.
* platform/qt-5.0-wk1/editing/style/remove-underline-in-bold-expected.txt: Copied from LayoutTests/platform/qt/editing/style/remove-underline-in-bold-expected.txt.
* platform/qt-5.0-wk1/editing/style/unbold-in-bold-expected.txt: Copied from LayoutTests/platform/qt/editing/style/unbold-in-bold-expected.txt.
* platform/qt-5.0-wk1/editing/undo/replace-text-in-node-preserving-markers-crash-expected.txt: Copied from LayoutTests/platform/qt/editing/undo/replace-text-in-node-preserving-markers-crash-expected.txt.
* platform/qt/editing/deleting/delete-by-word-002-expected.txt:
* platform/qt/editing/deleting/delete-cell-contents-expected.txt:
* platform/qt/editing/execCommand/button-expected.txt:
* platform/qt/editing/execCommand/createLink-expected.txt:
* platform/qt/editing/execCommand/indent-pre-expected.txt:
* platform/qt/editing/execCommand/unlink-expected.txt:
* platform/qt/editing/input/emacs-ctrl-o-expected.txt:
* platform/qt/editing/inserting/insert-before-link-1-expected.txt:
* platform/qt/editing/pasteboard/display-block-on-spans-expected.txt:
* platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.txt:
* platform/qt/editing/pasteboard/merge-end-list-2-expected.txt:
* platform/qt/editing/pasteboard/merge-end-table-2-expected.txt:
* platform/qt/editing/pasteboard/page-zoom-expected.txt:
* platform/qt/editing/selection/extend-selection-word-expected.txt:
* platform/qt/editing/style/apply-through-end-of-document-expected.txt:
* platform/qt/editing/style/remove-underline-across-paragraph-expected.txt:
* platform/qt/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
* platform/qt/editing/style/remove-underline-expected.txt:
* platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt:
* platform/qt/editing/style/remove-underline-in-bold-expected.txt:
* platform/qt/editing/style/unbold-in-bold-expected.txt:
* platform/qt/editing/undo/replace-text-in-node-preserving-markers-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEventSource: Synchronous loader callback not handled properly
commit-queue@webkit.org [Thu, 25 Apr 2013 09:51:36 +0000 (09:51 +0000)]
EventSource: Synchronous loader callback not handled properly
https://bugs.webkit.org/show_bug.cgi?id=115104

Source/WebCore:

When attempting a cross-origin request towards a non-HTTP URL, an early verification
of the protocol scheme will cause didFailAccessControlCheck to be called synchronously
before the loader has even finished being created. This special case was not handled
properly, since we tried to cancel a non-existing loader, which resulted in a crash.
In addition to checking whether a request is in flight before trying to cancel it,
this change also schedules the initial creation of the loader to happen asynchronously
when an EventSource is constructed, so that a script can register for the error event
before it is dispatched (as a result of passing a non-HTTP URL to the constructor).

Patch by Per-Erik Brodin <per-erik.brodin@ericsson.com> on 2013-04-25
Reviewed by Alexey Proskuryakov.

Test: http/tests/eventsource/eventsource-cors-non-http.html

* page/EventSource.cpp:
(WebCore::EventSource::EventSource):
(WebCore::EventSource::create):
(WebCore::EventSource::scheduleInitialConnect):
(WebCore):
(WebCore::EventSource::scheduleReconnect):
(WebCore::EventSource::connectTimerFired):
(WebCore::EventSource::close):
(WebCore::EventSource::abortConnectionAttempt):
* page/EventSource.h:
(EventSource):

LayoutTests:

Patch by Per-Erik Brodin <per-erik.brodin@ericsson.com> on 2013-04-25
Reviewed by Alexey Proskuryakov.

* http/tests/eventsource/eventsource-cors-non-http-expected.txt: Added.
* http/tests/eventsource/eventsource-cors-non-http.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed WinCE build fix after r148888.
paroga@webkit.org [Thu, 25 Apr 2013 09:43:31 +0000 (09:43 +0000)]
Unreviewed WinCE build fix after r148888.

* wtf/Atomics.h: WinCE version of intrin.h is called cmnintrin.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed WinCE build fix after r148545.
paroga@webkit.org [Thu, 25 Apr 2013 09:42:50 +0000 (09:42 +0000)]
Unreviewed WinCE build fix after r148545.

* page/wince/FrameWinCE.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Added platform specific expected files after r148987.
kadam@inf.u-szeged.hu [Thu, 25 Apr 2013 08:01:53 +0000 (08:01 +0000)]
[Qt] Unreviewed gardening. Added platform specific expected files after r148987.

* platform/qt/editing/deleting/delete-by-word-002-expected.txt: Added.
* platform/qt/editing/deleting/delete-cell-contents-expected.txt: Added.
* platform/qt/editing/execCommand/button-expected.txt: Added.
* platform/qt/editing/execCommand/createLink-expected.txt: Added.
* platform/qt/editing/execCommand/indent-pre-expected.txt: Added.
* platform/qt/editing/execCommand/unlink-expected.txt: Added.
* platform/qt/editing/input/emacs-ctrl-o-expected.png:
* platform/qt/editing/input/emacs-ctrl-o-expected.txt:
* platform/qt/editing/inserting/insert-before-link-1-expected.txt: Added.
* platform/qt/editing/pasteboard/display-block-on-spans-expected.txt: Added.
* platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.png:
* platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.txt:
* platform/qt/editing/pasteboard/merge-end-list-2-expected.txt: Added.
* platform/qt/editing/pasteboard/merge-end-table-2-expected.txt: Added.
* platform/qt/editing/pasteboard/page-zoom-expected.txt: Added.
* platform/qt/editing/selection/extend-selection-word-expected.txt: Added.
* platform/qt/editing/selection/selection-extend-should-not-move-across-caret-on-mac-expected.txt: Added.
* platform/qt/editing/style/apply-through-end-of-document-expected.txt: Added.
* platform/qt/editing/style/make-text-writing-direction-inline-win-expected.txt: Added.
* platform/qt/editing/style/remove-underline-across-paragraph-expected.txt: Added.
* platform/qt/editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Added.
* platform/qt/editing/style/remove-underline-expected.txt: Added.
* platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt: Added.
* platform/qt/editing/style/remove-underline-in-bold-expected.txt: Added.
* platform/qt/editing/style/unbold-in-bold-expected.png:
* platform/qt/editing/style/unbold-in-bold-expected.txt:
* platform/qt/editing/undo/replace-text-in-node-preserving-markers-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r149032.
rniwa@webkit.org [Thu, 25 Apr 2013 07:50:58 +0000 (07:50 +0000)]
Unreviewed, rolling out r149032.
http://trac.webkit.org/changeset/149032
https://bugs.webkit.org/show_bug.cgi?id=115151

EFL WK1 API test has been broken after r149032 (Requested by
gyuyoung on #webkit).

* tests/test_ewk_setting.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBack references don't work in pattern attribute
tkent@chromium.org [Thu, 25 Apr 2013 06:42:03 +0000 (06:42 +0000)]
Back references don't work in pattern attribute
https://bugs.webkit.org/show_bug.cgi?id=105875

Reviewed by Geoffrey Garen.

Source/WebCore:

This imports a part of Blink r148951.

Tests: Update fast/forms/ValidityState-patternMismatch.html

* html/BaseTextInputType.cpp:
(WebCore::BaseTextInputType::patternMismatch):
Don't use capturing parentheses. They affected back references in
pattern attribute values.

LayoutTests:

* fast/forms/ValidityState-patternMismatch-expected.txt:
* fast/forms/ValidityState-patternMismatch.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove checking chromium from run-webkit-tests
commit-queue@webkit.org [Thu, 25 Apr 2013 05:41:07 +0000 (05:41 +0000)]
Remove checking chromium from run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=115139

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-24
Reviewed by Benjamin Poulain.

* Scripts/run-webkit-tests:
(useNewRunWebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPDFPlugin: Cursor should become an i-beam when over selectable text
timothy_horton@apple.com [Thu, 25 Apr 2013 05:30:36 +0000 (05:30 +0000)]
PDFPlugin: Cursor should become an i-beam when over selectable text
https://bugs.webkit.org/show_bug.cgi?id=115018
<rdar://problem/12645012>

Reviewed by Alexey Proskuryakov.

* WebProcess/Plugins/PDF/PDFPlugin.h:
Add updateCursor(), the UpdateCursorMode and HitTestResult enums, and
storage for the last PDF hit test result.
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::updateCursor):
Hit test the PDF. If there is a word under the cursor, use the I-beam cursor,
otherwise, use the default pointer cursor. This approximates PDFKit's behavior,
though does not match it precisely in the case of annotations.
Only send the cursor update to the UIProcess if it is a change, or if
we're explicitly asked to update.
(WebKit::PDFPlugin::handleMouseEvent):
If we're processing a mouse moved event, update the cursor if needed.
(WebKit::PDFPlugin::handleMouseEnterEvent):
If the cursor just moved over the PDFPlugin, force-update the cursor,
even if it matches the previously-set cursor (because something else
likely updated the cursor while it was not over the PDFPlugin).

* WebCore.exp.in: Export the I-beam and arrow cursors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRoll out AppleWin re-baselines from r149088.
roger_fong@apple.com [Thu, 25 Apr 2013 04:56:09 +0000 (04:56 +0000)]
Roll out AppleWin re-baselines from r149088.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd watchdog timer polling for the DFG.
mark.lam@apple.com [Thu, 25 Apr 2013 02:59:51 +0000 (02:59 +0000)]
Add watchdog timer polling for the DFG.
https://bugs.webkit.org/show_bug.cgi?id=115134.

Reviewed by Geoffrey Garen.

The strategy is to add a speculation check to the DFG generated code to
test if the watchdog timer has fired or not. If the watchdog timer has
fired, the generated code will do an OSR exit to the baseline JIT, and
let it handle servicing the watchdog timer.

If the watchdog is not enabled, this speculation check will not be
emitted.

* API/tests/testapi.c:
(currentCPUTime_callAsFunction):
(extendTerminateCallback):
(main):
- removed try/catch statements so that we can test the watchdog on the DFG.
- added JS bindings to a native currentCPUTime() function so that the timeout
  tests can be more accurate.
- also shortened the time values so that the tests can complete sooner.

* bytecode/ExitKind.h:
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNodeType.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/Watchdog.cpp:
(JSC::Watchdog::setTimeLimit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed optimize-baselines for mac and win.
roger_fong@apple.com [Thu, 25 Apr 2013 02:44:19 +0000 (02:44 +0000)]
Unreviewed optimize-baselines for mac and win.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPixel tests in SVG are all broken in WK2
simon.fraser@apple.com [Thu, 25 Apr 2013 02:09:22 +0000 (02:09 +0000)]
Pixel tests in SVG are all broken in WK2
https://bugs.webkit.org/show_bug.cgi?id=114218

Reviewed by Darin Adler.

Window snapshots in WebKitTestRunner on Mac are window-sized
(800x600), which is wrong for the W3C SVG tests that require a
480x360 snapshot.

Fix by resizing the window, as well as the web view in
PlatformWebView::resizeTo() so that window snapshots are correctly
sized.

Also do some drive-by cleanup of the window size constants in both
DRT and WTR to remove magic numbers, and make the code more similar.

* DumpRenderTree/TestRunner.cpp:
(TestRunner::setShouldPaintBrokenImage):
* DumpRenderTree/TestRunner.h:
* DumpRenderTree/efl/DumpRenderTree.cpp:
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(webInspectorShowWindow):
* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
(sizeWebViewForCurrentTest):
* DumpRenderTree/mac/DumpRenderTreeMac.h:
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createPagedBitmapContext):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(DumpRenderTree::DumpRenderTree):
(DumpRenderTree::open):
* DumpRenderTree/qt/TestRunnerQt.cpp:
* DumpRenderTree/qt/TestRunnerQt.h:
* DumpRenderTree/win/DumpRenderTree.cpp:
(sizeWebViewForCurrentTest):
* DumpRenderTree/wx/DumpRenderTreeWx.cpp:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::sizeWebViewForCurrentTest):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::resizeTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPage Overlays shouldn't waste time flushing layers if we're not going to use it
timothy_horton@apple.com [Thu, 25 Apr 2013 01:32:47 +0000 (01:32 +0000)]
Page Overlays shouldn't waste time flushing layers if we're not going to use it
https://bugs.webkit.org/show_bug.cgi?id=115145

Reviewed by Simon Fraser.

Don't flush the page overlay layer when it's installed - it starts out
with paintContents=false, so we don't really need a CALayer yet. We'll
flush later if need be.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGarbage at the top of http://www.technologyreview.com after scrolling
simon.fraser@apple.com [Thu, 25 Apr 2013 01:27:20 +0000 (01:27 +0000)]
Garbage at the top of technologyreview.com after scrolling
https://bugs.webkit.org/show_bug.cgi?id=114825

Source/WebCore:

Reviewed by Tim Horton.

Garbage pixels are caused by GraphicsLayerCA setting a layer to be opaque,
but then not painting anything into it. On this page, the element is
toggled to be visibility:hidden on scrolling, but RenderLayer::backgroundIsKnownToBeOpaqueInRect()
failed to consider that as something that can cause backgrounds not to be opaque.

For the bug to happen, some subtle interactions with r142012 come into play
for the layer to remain visible, hence the slightly complex testcase.

Test: compositing/contents-opaque/visibility-hidden.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

Reviewed by Tim Horton.

Test that sets visibility:hidden on an element with some complex
configuration of layer children, and dumps the layer tree to check
that the contents are not marked as opaque.

* compositing/contents-opaque/visibility-hidden-expected.txt: Added.
* compositing/contents-opaque/visibility-hidden.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDump layer opaqueness in the Compositing log output
simon.fraser@apple.com [Thu, 25 Apr 2013 01:27:13 +0000 (01:27 +0000)]
Dump layer opaqueness in the Compositing log output
https://bugs.webkit.org/show_bug.cgi?id=115132

Reviewed by Tim Horton.

It's useful to see whether we consider layers to be opaque in the Compositing
log channel output, so dump it.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpecial thunks for math functions should work on ARMv7
fpizlo@apple.com [Thu, 25 Apr 2013 01:26:35 +0000 (01:26 +0000)]
Special thunks for math functions should work on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=115144

Reviewed by Gavin Barraclough and Oliver Hunt.

The only hard bit here was ensuring that we implemented the very special
"cheap C call" convention on ARMv7.

* assembler/AbstractMacroAssembler.h:
(JSC::isARMv7s):
(JSC):
(JSC::isX86):
* dfg/DFGCommon.h:
* jit/SpecializedThunkJIT.h:
(SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::callDoubleToDoublePreservingReturn):
* jit/ThunkGenerators.cpp:
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd efl to JSInspectorFrontendHost::port()
commit-queue@webkit.org [Thu, 25 Apr 2013 00:51:29 +0000 (00:51 +0000)]
Add efl to JSInspectorFrontendHost::port()
https://bugs.webkit.org/show_bug.cgi?id=115137

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-24
Reviewed by Timothy Hatcher.

No new tests, because there is no change in behavior.

* bindings/js/JSInspectorFrontendHostCustom.cpp:
(WebCore::JSInspectorFrontendHost::port):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFunction parameter quotePair can be passed by reference
kangil.han@samsung.com [Thu, 25 Apr 2013 00:44:13 +0000 (00:44 +0000)]
Function parameter quotePair can be passed by reference
https://bugs.webkit.org/show_bug.cgi?id=115089

Reviewed by Alexey Proskuryakov.

Minor performance patch.

* rendering/style/QuotesData.cpp:
(WebCore::QuotesData::addPair):
* rendering/style/QuotesData.h:
(QuotesData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplementors of CachedResource subclasses should be forced to decide if encoded data...
beidson@apple.com [Thu, 25 Apr 2013 00:17:16 +0000 (00:17 +0000)]
Implementors of CachedResource subclasses should be forced to decide if encoded data can be replaced.
https://bugs.webkit.org/show_bug.cgi?id=115140

Reviewed by Beth Dakin.

No new tests (No behavior change).

This makes mayTryReplaceEncodedData() return false in CachedResource, but overrides to true
in all CachedResource subclasses besides CachedFont (which already has an implementation).

* loader/cache/CachedCSSStyleSheet.h:
* loader/cache/CachedImage.h:
* loader/cache/CachedRawResource.h:
* loader/cache/CachedResource.h:
* loader/cache/CachedSVGDocument.h:
* loader/cache/CachedScript.h:
* loader/cache/CachedShader.h:
* loader/cache/CachedTextTrack.h:
* loader/cache/CachedXSLStyleSheet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMisc bugfix and cleaning in sh4 base JIT.
commit-queue@webkit.org [Thu, 25 Apr 2013 00:10:15 +0000 (00:10 +0000)]
Misc bugfix and cleaning in sh4 base JIT.
https://bugs.webkit.org/show_bug.cgi?id=115022.

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-04-24
Reviewed by Oliver Hunt.

Remove unused add32() and sub32() with scratchreg parameter to avoid
confusion as this function prototype means another behaviour.
Remove unused "void push(Address)" function which seems quite buggy.

* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::and32): Cosmetic change.
(JSC::MacroAssemblerSH4::lshift32): Cosmetic change.
(JSC::MacroAssemblerSH4::or32): Cosmetic change.
(JSC::MacroAssemblerSH4::xor32): Cosmetic change.
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::load32): Cosmetic change.
(JSC::MacroAssemblerSH4::load8Signed): Fix invalid offset upper limit
when using r0 register and cosmetic changes.
(JSC::MacroAssemblerSH4::load8): Reuse load8Signed to avoid duplication.
(JSC::MacroAssemblerSH4::load16): Fix invalid offset upper limit when
using r0 register, fix missing offset shift and cosmetic changes.
(JSC::MacroAssemblerSH4::store32): Cosmetic change.
(JSC::MacroAssemblerSH4::branchAdd32): Store result value before branch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFurther unreviewed build fix; CFNetwork.framework is the one which Lion
jer.noble@apple.com [Wed, 24 Apr 2013 23:46:06 +0000 (23:46 +0000)]
Further unreviewed build fix; CFNetwork.framework is the one which Lion
refuses to link against.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix; link against CoreServices.framework instead of against
jer.noble@apple.com [Wed, 24 Apr 2013 23:32:32 +0000 (23:32 +0000)]
Unreviewed build fix; link against CoreServices.framework instead of against
CoreFoundation.framework directly, to make the linker happy on Lion.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix invalid test names in jsc-test-list
ddkilzer@apple.com [Wed, 24 Apr 2013 23:31:55 +0000 (23:31 +0000)]
Fix invalid test names in jsc-test-list
<http://webkit.org/b/115136>

Reviewed by Geoffrey Garen.

This shell script finds all the invalid tests listed in
LayoutTests/fast/js/jsc-test-list:

    $ for F in `cat LayoutTests/fast/js/jsc-test-list`; do if [ ! -f LayoutTests/$F.html ]; then echo $F; fi; done
    fast/js/dfg-double-addition-simplify-to-int.html
    fast/js/dfg-mul-big-integers-with-small-integer-and-bitor
    fast/js/dfg-mul-big-integers-with-small-integer-and-detect-overflow
    fast/js/dfg-mul-big-integers-with-small-integer
    fast/js/dfg-value-to-int32-with-side-effects

* fast/js/jsc-test-list: Fix invalid test names by removing
*.html suffix or stray "s" characters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWWDC session videos don’t play at developer.apple.com
jer.noble@apple.com [Wed, 24 Apr 2013 23:20:44 +0000 (23:20 +0000)]
WWDC session videos don’t play at developer.apple.com
https://bugs.webkit.org/show_bug.cgi?id=114858

Reviewed by Eric Carlson. Rubber stamped by Brady Eidson.

AVFoundation uses CFNetwork to store and retrieve cookies from the global store.
However, in the case where network access happens in the NetworkProcess, session
cookies are stored in-memory, and are not accessable in the WebProcess. Until such
a time as AVFoundation can provide an API which would allow us to provide cookies
for a specific request, we will interpose the CFNetwork method which they use to
retrieve the cookie string from the cookie store for their pending request.

Duplicate the previous SecItemShim target to a new, WebProcessShim target. This
target includes the SecItemShim functionality, but will add a new shim for cookie
retrieval:
* Shared/mac/CookieStorageShimLibrary.h: Added
(CookieStorageShimCallbacks):
* Shared/mac/CookieStorageShimLibrary.cpp: Added.
(WebKit::ShimProtector::ShimProtector): A simple stack-based counter class.
(WebKit::ShimProtector::~ShimProtector):
(WebKit::ShimProtector::count):
(WebKit::shimCFHTTPCookieStorageCopyRequestHeaderFieldsForURL): Interpose
    the CFNetwork call, and pass to the registered callback.
(WebKit::WebKitCookieStorageShimInitialize): Register the callbacks.

Add a helper singleton class which will talk to the shim through the
registered callbacks:
* Shared/mac/CookieStorageShim.h: Added
(WebKit::CookieStorageShim::CookieStorageShim):
* Shared/mac/CookieStorageShim.cpp: Added.
(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL): Pass the request
    over to the NetworkProcess.
(WebKit::CookieStorageShim::shared): Simple singleton.
(WebKit::CookieStorageShim::initialize): Call the library initializer.

Initialize the shim only when the WebProcess is delegating network loading
to the NetworkProcess:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):

Rename the WebProcess's shim from SecItemShim -> WebProcessShim:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::addDYLDEnvironmentAdditions):
* WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
(WebKit::WebContentProcessMainDelegate::doPreInitializationWork):
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(WebContentServiceInitializer):

As the DYLD_INTERPOSE macro is used in multiple files now, put it in its
own header:
* Shared/mac/DyldInterpose.h: Added.
* PluginProcess/mac/PluginProcessShim.mm:
* WebProcess/mac/SecItemShimLibrary.mm:

Add new files to the project:
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Fix build error after r148963.
bw80.lee@samsung.com [Wed, 24 Apr 2013 22:50:14 +0000 (22:50 +0000)]
[EFL] Fix build error after r148963.
https://bugs.webkit.org/show_bug.cgi?id=115126

Reviewed by Laszlo Gombos.

Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h

Source/WebKit2:

* PlatformEfl.cmake:

Tools:

* TestWebKitAPI/PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WIN] Remove pthread from Visual Studio files in JavaScriptCore
paroga@webkit.org [Wed, 24 Apr 2013 22:42:54 +0000 (22:42 +0000)]
[WIN] Remove pthread from Visual Studio files in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=114864

Reviewed by Brent Fulgham.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorCommon.vsprops:
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
* JavaScriptCore.vcproj/testRegExp/testRegExpCommon.vsprops:
* JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
* JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props:
* JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractorCommon.props:
* JavaScriptCore.vcxproj/jsc/jscCommon.props:
* JavaScriptCore.vcxproj/testRegExp/testRegExpCommon.props:
* JavaScriptCore.vcxproj/testapi/testapiCommon.props:
* JavaScriptCore.vcxproj/testapi/testapiCommonCFLite.props:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG should keep the operand to create_this alive if it's emitting code for create_this
fpizlo@apple.com [Wed, 24 Apr 2013 22:39:33 +0000 (22:39 +0000)]
DFG should keep the operand to create_this alive if it's emitting code for create_this
https://bugs.webkit.org/show_bug.cgi?id=115133

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

The DFG must model bytecode liveness, or else OSR exit is going to have a really bad time.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):

LayoutTests:

Reviewed by Mark Hahnenberg.

This test crashes prior to my change.

* fast/js/dfg-allocation-profile-watch-point-exit-expected.txt: Added.
* fast/js/dfg-allocation-profile-watch-point-exit.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-allocation-profile-watch-point-exit.js: Added.
(Foo):
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOnce a custom font is cached to disk, it starts failing to render until the page...
beidson@apple.com [Wed, 24 Apr 2013 22:35:47 +0000 (22:35 +0000)]
Once a custom font is cached to disk, it starts failing to render until the page is refreshed.
<rdar://problem/13622998> and https://bugs.webkit.org/show_bug.cgi?id=115131

Reviewed by Alexey Proskuryakov.

No new tests (Not a tested config, nor are disk cache issues currently testable).

* loader/cache/CachedResource.h:
(WebCore::CachedResource:: mayTryReplaceEncodedData): Allow subclasses to refuse encoded data replacement.

* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::tryReplaceEncodedData): Only try if shouldTryReplaceEncodedData() is true.

* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::CachedFont):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::mayTryReplaceEncodedData): Return false if the custom font data has ever been created.
* loader/cache/CachedFont.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago fast/js/global-constructors.html was deleted in r149001, removing it from
ap@apple.com [Wed, 24 Apr 2013 22:05:13 +0000 (22:05 +0000)]
    fast/js/global-constructors.html was deleted in r149001, removing it from
        TextExpectations too.

        * platform/mac/TestExpectations:
        * platform/qt-arm/TestExpectations:
        * platform/win/TestExpectations:
        * platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHave VS2010 WebKit solution look in WebKit_Libraries/lib32 for dependencies.
roger_fong@apple.com [Wed, 24 Apr 2013 21:43:53 +0000 (21:43 +0000)]
Have VS2010 WebKit solution look in WebKit_Libraries/lib32 for dependencies.

* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPostBuild.cmd:
* JavaScriptCore.vcxproj/JavaScriptCorePreLink.cmd:
* JavaScriptCore.vcxproj/jsc/jscPostBuild.cmd:
* JavaScriptCore.vcxproj/jsc/jscPreLink.cmd:
* JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj.filters:
* JavaScriptCore.vcxproj/testRegExp/testRegExpPostBuild.cmd:
* JavaScriptCore.vcxproj/testRegExp/testRegExpPreLink.cmd:
* JavaScriptCore.vcxproj/testapi/testapiPreLink.cmd:
* WTF.vcxproj/build-generated-files.sh:
* win/tools/vsprops/common.props:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVertical overlay scrollbar in iframes fades in and out rapidly when you scroll in
bdakin@apple.com [Wed, 24 Apr 2013 21:37:34 +0000 (21:37 +0000)]
Vertical overlay scrollbar in iframes fades in and out rapidly when you scroll in
a circle
https://bugs.webkit.org/show_bug.cgi?id=115124
-and corresponding-
<rdar://problem/13168957>

Reviewed by Anders Carlsson.

With http://trac.webkit.org/changeset/119834 we started calling
ScrollbarPainterController's contentAreaScrolled/contentAreaScrolledInDirection
API on a zero-delay timer instead of calling it right away. This prevented some
crashes that we saw whenever this was called during a layout. However, that delay,
combined with the particulars of contentAreaScrolledInDirection cause this bug
where sometimes the scrollbars in an iframe will fade out very noticeably when
scrolling in a circle.

This change makes it so we will only use the zero-delay timer if the
ScrollableArea is not currently handling a wheel event. If it IS handling a wheel
event, then we will send the notifications to AppKit right away. I confirmed that
this change did not reintroduce the old crashes.

Keep track of whether we are currently handling a wheel event with the new member
variable m_isHandlingWheelEvent.
* page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleWheelEvent):
* page/EventHandler.h:
(WebCore::EventHandler::isHandlingWheelEvent):
(EventHandler):

To prevent layering violations, the ScrollableArea sub-classes will have to access
this information from the EventHandler.
* page/FrameView.cpp:
(WebCore::FrameView::isHandlingWheelEvent):
* page/FrameView.h:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::isHandlingWheelEvent):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::isHandlingWheelEvent):
* rendering/RenderLayer.h:
(RenderLayer):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::isHandlingWheelEvent):
* rendering/RenderListBox.h:

sendContentAreaScrolledSoon() can be private. Also add new function
sendContentAreaScrolled().
* platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):

If the ScrollableArea is handling a wheel event, call
sendContentAreaScrolled(), otherwise call sendContentAreaScrolledSoon()
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolled):

Re-factored to use sendContentAreaScrolled()
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a merge error in r149007 (was missing a null check added in r148777).
rniwa@webkit.org [Wed, 24 Apr 2013 21:35:41 +0000 (21:35 +0000)]
Fix a merge error in r149007 (was missing a null check added in r148777).

* rendering/LogicalSelectionOffsetCaches.h:
(WebCore::containingBlockForAbsolutePosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash when trying to determine the length of an invalid message
andersca@apple.com [Wed, 24 Apr 2013 21:33:43 +0000 (21:33 +0000)]
Crash when trying to determine the length of an invalid message
https://bugs.webkit.org/show_bug.cgi?id=115127
<rdar://problem/13700736>

Reviewed by Beth Dakin.

Use message instead of incomingMessage since incomingMessage will always be null.

* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::processIncomingMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBattery API won't return updated battery status until client calls didChangeBatteryStatus
commit-queue@webkit.org [Wed, 24 Apr 2013 20:38:38 +0000 (20:38 +0000)]
Battery API won't return updated battery status until client calls didChangeBatteryStatus
https://bugs.webkit.org/show_bug.cgi?id=114891

Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-04-24
Reviewed by Rob Buis.

The BatteryStatus object in BatteryManager won't get updated until BatteryClient calls
didChangeBatteryStatus in BatteryController. Any attempts to call webkitBattery.charged()
or other get functions will always return the default values until the next battery status
change object gets passed to the controller.

We need to update the manager when we attach it to the controller, and update all
existing managers when the controller receives it's first battery status object.

* Modules/battery/BatteryController.cpp:
(WebCore::BatteryController::addListener):
(WebCore::BatteryController::updateBatteryStatus):
* Modules/battery/BatteryManager.cpp:
(WebCore::BatteryManager::didChangeBatteryStatus):
(WebCore::BatteryManager::updateBatteryStatus):
(WebCore):
* Modules/battery/BatteryManager.h:
(BatteryManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClean up unused code in ViewportArguments.h
zhajiang@rim.com [Wed, 24 Apr 2013 20:11:03 +0000 (20:11 +0000)]
Clean up unused code in ViewportArguments.h
https://bugs.webkit.org/show_bug.cgi?id=115121

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-04-24.
Reviewed by Benjamin Poulain.

The target-densityDPI emulation implementation has been removed by
r147893, so clean up the remaining code as well.

* dom/ViewportArguments.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoElementData should use 'unsigned' attribute indices.
akling@apple.com [Wed, 24 Apr 2013 20:03:12 +0000 (20:03 +0000)]
ElementData should use 'unsigned' attribute indices.
<http://webkit.org/b/115103>

Reviewed by Antti Koivisto.

Switch to using 'unsigned' for attribute indices. This gives consistent behavior
on 32/64-bit, and the underlying storage is already limited by Vector's 32-bit capacity.

Added an ElementData::attributeNotFound constant (-1) since we can't use WTF::notFound.

* dom/Element.cpp:
(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::setAttribute):
(WebCore::Element::setSynchronizedLazyAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::UniqueElementData::removeAttribute):
(WebCore::ElementData::getAttributeItemIndexSlowCase):
* dom/Element.h:
(ElementData):
(UniqueElementData):
(Element):
(WebCore::Element::getAttributeItemIndex):
(WebCore::Element::attributeCount):
(WebCore::ElementData::length):
(WebCore::ElementData::getAttributeItem):
(WebCore::ElementData::getAttributeItemIndex):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):
(WebCore::NamedNodeMap::length):
* dom/NamedNodeMap.h:
(NamedNodeMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoElementData::attributeItem() should bounds-check the index.
akling@apple.com [Wed, 24 Apr 2013 20:00:44 +0000 (20:00 +0000)]
ElementData::attributeItem() should bounds-check the index.
<http://webkit.org/b/115076>

Reviewed by Antti Koivisto.

Switch the ASSERT_WITH_SECURITY_IMPLICATION to a RELEASE_ASSERT.

* dom/Element.h:
(WebCore::ElementData::attributeItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSetting an inline style property to "" shouldn't cause style recalc unless the proper...
akling@apple.com [Wed, 24 Apr 2013 19:59:18 +0000 (19:59 +0000)]
Setting an inline style property to "" shouldn't cause style recalc unless the property was present.
<http://webkit.org/b/115122>

Reviewed by Antti Koivisto.

StylePropertySet::setProperty() handles empty strings by removing the property entirely.
If there was no property to remove, it shouldn't claim that it changed something, as that
will cause the CSSOM wrapper to mark the element for style recalc.

A common idiom that triggers this is excessive use of { element.style.display = ''; }

* css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::setProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMoving word boundaries backwards fails when there is a text node starting with an...
rniwa@webkit.org [Wed, 24 Apr 2013 19:50:50 +0000 (19:50 +0000)]
Moving word boundaries backwards fails when there is a text node starting with an apostrophe
https://bugs.webkit.org/show_bug.cgi?id=115070

Reviewed by Alexey Proskuryakov.

Source/WebCore:

The bug was caused by previousBoundary erroneously assuming that we don't need any more context if a word
boundary is found at the beginning of a string. For example, when "I'll" is split into two text nodes,
"I" and "'ll", there is a word boundary between "'" and "ll" in "'ll" so we need to examine the whole "I'll".

Fixed the bug by obtaining more context when the character starts exactly at offset 1 in a text node to
work around this bug. In the long term, we probably need to provide Foundation of the entire context since in
languages like Hebrew and some of European languages, there could be many accents and combining characters
between split into multiple text nodes as one variant is seen in the newly added test case.

Test: editing/selection/previous-word-boundary-across-text-nodes.html

* editing/VisibleUnits.cpp:
(WebCore::previousBoundary):

LayoutTests:

Added a test case for moving bacwkards with a word granurality across multiple text nodes.
Some test cases still fail since this patch only implements a work around.

* editing/selection/previous-word-boundary-across-text-nodes-expected.txt: Added.
* editing/selection/previous-word-boundary-across-text-nodes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDo not use static string in DiagnosticLoggingKeys
benjamin@webkit.org [Wed, 24 Apr 2013 19:46:44 +0000 (19:46 +0000)]
Do not use static string in DiagnosticLoggingKeys
https://bugs.webkit.org/show_bug.cgi?id=115093

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-24
Reviewed by Andreas Kling.

The code is not hot enough to justify keeping the memory around.
This removes 3kb from the binary on x86_64.

* page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
(WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):
(WebCore::DiagnosticLoggingKeys::pageContainsMediaEngineKey):
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOneMediaEngineKey):
(WebCore::DiagnosticLoggingKeys::passKey):
(WebCore::DiagnosticLoggingKeys::failKey):
(WebCore::DiagnosticLoggingKeys::noopKey):
* page/DiagnosticLoggingKeys.h:
(DiagnosticLoggingKeys):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove wxWebKit #ifdefs from WebCore/platform/graphics
benjamin@webkit.org [Wed, 24 Apr 2013 19:38:08 +0000 (19:38 +0000)]
Remove wxWebKit #ifdefs from WebCore/platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=115081

Reviewed by Geoffrey Garen.

* platform/graphics/BitmapImage.h:
(BitmapImage):
* platform/graphics/Color.h:
(Color):
* platform/graphics/FloatRect.h:
(FloatRect):
* platform/graphics/FloatSize.h:
(FloatSize):
* platform/graphics/FontPlatformData.h:
* platform/graphics/GlyphBuffer.h:
(WebCore):
(WebCore::GlyphBuffer::glyphAt):
(WebCore::GlyphBuffer::add):
* platform/graphics/Gradient.h:
* platform/graphics/GraphicsContext.h:
(GraphicsContext):
* platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
* platform/graphics/ImageBufferData.h:
* platform/graphics/IntPoint.h:
(IntPoint):
* platform/graphics/IntRect.h:
* platform/graphics/IntSize.h:
(IntSize):
* platform/graphics/NativeImagePtr.h:
(WebCore):
* platform/graphics/Path.h:
* platform/graphics/Pattern.h:
* platform/graphics/SimpleFontData.h:
(SimpleFontData):
(WebCore::SimpleFontData::widthForGlyph):
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::collectComplexTextRuns):
* platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
* platform/graphics/transforms/AffineTransform.h:
(AffineTransform):
* platform/graphics/transforms/TransformationMatrix.h:
(TransformationMatrix):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove wxWebKit #ifdefs from WebCore/plugins
benjamin@webkit.org [Wed, 24 Apr 2013 19:36:17 +0000 (19:36 +0000)]
Remove wxWebKit #ifdefs from WebCore/plugins
https://bugs.webkit.org/show_bug.cgi?id=115080

Reviewed by Geoffrey Garen.

* plugins/PluginView.h:
(PluginView):
* plugins/mac/PluginViewMac.mm:
(WebCore::nativeWindowFor):
(WebCore::cgHandleFor):
(WebCore::topLevelOffsetFor):
(WebCore::PluginView::platformStart):
* plugins/win/PluginViewWin.cpp:
(windowHandleForPageClient):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::snapshot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove wxWebKit #ifdefs from WebCore/page
benjamin@webkit.org [Wed, 24 Apr 2013 19:35:31 +0000 (19:35 +0000)]
Remove wxWebKit #ifdefs from WebCore/page
https://bugs.webkit.org/show_bug.cgi?id=115079

Reviewed by Geoffrey Garen.

* page/FrameView.cpp:
(WebCore::FrameView::wheelEvent):
* page/Settings.cpp:
(WebCore):
* page/Settings.h:
(Settings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse post-branch store for RefCountedBase::derefBase
benjamin@webkit.org [Wed, 24 Apr 2013 19:34:50 +0000 (19:34 +0000)]
Use post-branch store for RefCountedBase::derefBase
https://bugs.webkit.org/show_bug.cgi?id=115078

Reviewed by Andreas Kling.

* wtf/RefCounted.h:
(WTF::RefCountedBase::derefBase): This makes the assembly easier to follow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Use stamp files for generate-forwarding-headers makefile rules
carlosgc@webkit.org [Wed, 24 Apr 2013 18:34:04 +0000 (18:34 +0000)]
[GTK] Use stamp files for generate-forwarding-headers makefile rules
https://bugs.webkit.org/show_bug.cgi?id=115118

Reviewed by Martin Robinson.

Source/WebKit2:

Use a stamp file for the WebKit2 forwarding generator rule. Also
fix the rule dependencies that pointed to a non existent variable.

* GNUmakefile.am:

Tools:

Use a stamp file for the TestWebKitAPI and WebKitTestRunner
forwarding generator rules and don't call it for soup since there
aren't soup directories in TestWebKitAPI and WebKitTestRunner.

* TestWebKitAPI/GNUmakefile.am:
* WebKitTestRunner/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAX: WAI-ARIA landmarks no longer speak type of landmark on iOS
cfleizach@apple.com [Wed, 24 Apr 2013 18:33:12 +0000 (18:33 +0000)]
AX: WAI-ARIA landmarks no longer speak type of landmark on iOS
https://bugs.webkit.org/show_bug.cgi?id=114547

Reviewed by David Kilzer.

Source/WebCore:

We want iOS to speak the landmark type.
I've moved the landmark role description to the base Mac class and exposed
these localized strings to iOS (the ones used to return landmark descriptions).

I've also updated the accessibilityLabel to account for landmark type, but also
handle multiple label sources more gracefully by appending commas, which changed a few
tests in minor ways.

Test: platform/iphone-simulator/accessibility/landmark-type.html

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityLabel]):
* accessibility/mac/WebAccessibilityObjectWrapperBase.h:
* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase ariaLandmarkRoleDescription]):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper roleDescription]):
* platform/LocalizedStrings.cpp:
(WebCore):
(WebCore::AXButtonActionVerb):
(WebCore::AXRadioButtonActionVerb):
(WebCore::AXTextFieldActionVerb):
(WebCore::AXCheckedCheckBoxActionVerb):
(WebCore::AXUncheckedCheckBoxActionVerb):
(WebCore::AXLinkActionVerb):
(WebCore::AXMenuListPopupActionVerb):
(WebCore::AXMenuListActionVerb):
* platform/LocalizedStrings.h:
(WebCore):

LayoutTests:

* platform/iphone-simulator/accessibility/landmark-type-expected.txt: Added.
* platform/iphone-simulator/accessibility/landmark-type.html: Added.
* platform/iphone-simulator/accessibility/link-with-images-text-expected.txt:
* platform/iphone-simulator/accessibility/link-with-images-text.html:
     Minor change to accomodate trimming of white space.
* platform/iphone-simulator/accessibility/math-expected.txt:
* platform/iphone-simulator/accessibility/math.html:
     Math objects now include "math" as the landmark type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago32-bit build fix.
ggaren@apple.com [Wed, 24 Apr 2013 18:16:22 +0000 (18:16 +0000)]
32-bit build fix.

Unreviewed.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBooleanBranch): Explicitly
truncate to 32-bit to avoid compiler warnings. It's safe to truncate
because the payload of a boolean is the low bits on both 64-bit and 32-bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK][WK2] Implement LayerTreeHostGtk::pageBackgroundTransparencyChanged
zandobersek@gmail.com [Wed, 24 Apr 2013 18:06:53 +0000 (18:06 +0000)]
[GTK][WK2] Implement LayerTreeHostGtk::pageBackgroundTransparencyChanged
https://bugs.webkit.org/show_bug.cgi?id=115094

Reviewed by Tim Horton.

The method was introduced in r149004 (and a stub implementation for the GTK port added in r149017).
Implement the method for the GTK port in the same manner it is implemented under the Mac port,
calling setContentsOpaque on the non-composited content layer.

* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::pageBackgroundTransparencyChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Update build dependencies
commit-queue@webkit.org [Wed, 24 Apr 2013 17:50:29 +0000 (17:50 +0000)]
[GTK] Update build dependencies
https://bugs.webkit.org/show_bug.cgi?id=115111

Patch by Simon Pena <simon.pena@samsung.com> on 2013-04-24
Reviewed by Martin Robinson.

The install-dependencies script was missing a dependency on EGL,
which is expected when building Cairo.

* gtk/install-dependencies: Added a dependency on libegl1-mesa
for both apt and yum.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS attribute selectors cause unnecessary style recalc when setting attribute to...
akling@apple.com [Wed, 24 Apr 2013 17:43:14 +0000 (17:43 +0000)]
CSS attribute selectors cause unnecessary style recalc when setting attribute to same value.
<http://webkit.org/b/115116>
<rdar://problem/13727709>

Reviewed by Simon Fraser.

The logic that dirties the style if there's a relevant attribute selector in the document
shouldn't run if the attribute is being overwritten with an identical value.
Move this into willModifyAttribute() instead, since we need access to both the old and the new value.

This reduces unnecessary style recalculation in Mac App Store content.

* dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore::Element::willModifyAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove the Chromium-specific helper from run_webkit_tests.py
commit-queue@webkit.org [Wed, 24 Apr 2013 17:07:01 +0000 (17:07 +0000)]
Remove the Chromium-specific helper from run_webkit_tests.py
https://bugs.webkit.org/show_bug.cgi?id=114996

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-24
Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
commit-queue@webkit.org [Wed, 24 Apr 2013 16:12:04 +0000 (16:12 +0000)]
[EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
https://bugs.webkit.org/show_bug.cgi?id=114850

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-04-24
Reviewed by Andreas Kling.

Revision r148312 fixed WebPageProxy cleanup and also changed the process
termination semantics when requested by the user so that a client is not
notified of a crash anymore, since there was no crash anyway.

That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
relied on being notified of a crash after calling WKPageTerminate(). As
a result of not being notified of such non-existent crash, the test would
timeout right after making the terminate call.

This patch adds an InjectedBundle to be used for simulating a crash, by
calling abort() upon receiving a "Crash" message, and thus we are able to
keep testing the crash callback.

This patch also re-enables the WKViewClientWebProcessCallbacks test, which
had been disabled in revisions r148858 and r148855, since it was failing.

* TestWebKitAPI/PlatformEfl.cmake:
* TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
(TestWebKitAPI):
(WKViewClientWebProcessCallbacksTest):
(TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
(TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2013-04-24 Simon Cooper <scooper@apple.com>
ap@apple.com [Wed, 24 Apr 2013 16:08:32 +0000 (16:08 +0000)]
2013-04-24  Simon Cooper  <scooper@apple.com>

        <rdar://problem/13614117> Refine the Flash Player profile
        https://bugs.webkit.org/show_bug.cgi?id=115016

        Reviewed by Alexey Proskuryakov.

        Add some refinements to the Flash Player profile. Make a non-/ home
        directory work. Fixes that allow file uploading via user selected files.

        * Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Do not clear focus on a node when tapping on form controls
commit-queue@webkit.org [Wed, 24 Apr 2013 15:59:54 +0000 (15:59 +0000)]
[BlackBerry] Do not clear focus on a node when tapping on form controls
https://bugs.webkit.org/show_bug.cgi?id=115055

Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-04-24
Reviewed by Rob Buis.

Internally reviewed by Genevieve Mak.

PR316069
To allow for rich text editors to apply styles on an input field
or highlighted text, we must maintain focus on the current element
when tapping on form elements. Moving the code that clears this
context to trigger off TouchHold instead of TouchPress.

* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::doFatFingers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Fixes the San Angeles demo on khronos.org
commit-queue@webkit.org [Wed, 24 Apr 2013 15:49:12 +0000 (15:49 +0000)]
[BlackBerry] Fixes the San Angeles demo on khronos.org
https://bugs.webkit.org/show_bug.cgi?id=115106

Patch by Jonathan Feldstein <jfeldstein@blackberry.com> on 2013-04-24
Reviewed by Rob Buis
Internally Reviewed by Jeremy Nicholl and Arvid Nilsson

Fixes a bug in which the currently bound vertex array object's vertex array
state was being modified as opposed to the default vertex array state.

* platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:
(EGLImageLayerWebKitThread::blitToFrontBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFilled out more cases of branch folding in the DFG
ggaren@apple.com [Wed, 24 Apr 2013 15:48:55 +0000 (15:48 +0000)]
Filled out more cases of branch folding in the DFG
https://bugs.webkit.org/show_bug.cgi?id=115088

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

No change on the benchmarks we track, but a 3X speedup on a
microbenchmark that uses these techniques.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock): (!/=)= and (!/=)== can constant
fold all types, not just numbers, because true constants have no
side effects when type-converted at runtime.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateBoolean): Added support for fixing up
boolean uses, like we do for other types like number.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBooleanBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileBooleanCompare): Peephole fuse
boolean compare and/or compare-branch, now that we have the types for
them.

* dfg/DFGSpeculativeJIT.h: Updated declarations.

LayoutTests:

* fast/js/regress/script-tests/branch-fold.js:
(g): Added some boolean and constant-folded cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFold RenderThemeMacShared into RenderThemeMac
thakis@chromium.org [Wed, 24 Apr 2013 15:44:57 +0000 (15:44 +0000)]
Fold RenderThemeMacShared into RenderThemeMac
https://bugs.webkit.org/show_bug.cgi?id=115086

Reviewed by Anders Carlsson.

No intended functionality change.

* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderThemeMac.h:
(RenderThemeMac):
(WebCore::RenderThemeMac::supportsControlTints):
(WebCore::RenderThemeMac::scrollbarControlSizeForPart):
(WebCore::RenderThemeMac::supportsSelectionForegroundColors):
(WebCore::RenderThemeMac::supportsClosedCaptioning):
(WebCore::RenderThemeMac::updateActiveState):
* rendering/RenderThemeMac.mm:
(-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
(-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]):
(-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]):
(WebCore::RenderThemeMac::RenderThemeMac):
(WebCore::RenderThemeMac::~RenderThemeMac):
(WebCore::RenderThemeMac::platformActiveSelectionBackgroundColor):
(WebCore):
(WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeMac::platformFocusRingColor):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::toFontWeight):
(WebCore::RenderThemeMac::systemFont):
(WebCore::convertNSColorToColor):
(WebCore::menuBackgroundColor):
(WebCore::RenderThemeMac::platformColorsDidChange):
(WebCore::RenderThemeMac::systemColor):
(WebCore::RenderThemeMac::usesTestModeFocusRingColor):
(WebCore::RenderThemeMac::isControlStyled):
(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::RenderThemeMac::inflateRect):
(WebCore::RenderThemeMac::convertToPaintingRect):
(WebCore::RenderThemeMac::updateCheckedState):
(WebCore::RenderThemeMac::updateEnabledState):
(WebCore::RenderThemeMac::updateFocusedState):
(WebCore::RenderThemeMac::updatePressedState):
(WebCore::RenderThemeMac::controlSupportsTints):
(WebCore::RenderThemeMac::controlSizeForFont):
(WebCore::RenderThemeMac::setControlSize):
(WebCore::RenderThemeMac::sizeForFont):
(WebCore::RenderThemeMac::sizeForSystemFont):
(WebCore::RenderThemeMac::setSizeFromFont):
(WebCore::RenderThemeMac::setFontFromControlSize):
(WebCore::RenderThemeMac::controlSizeForSystemFont):
(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::adjustTextFieldStyle):
(WebCore::RenderThemeMac::paintCapsLockIndicator):
(WebCore::RenderThemeMac::paintTextArea):
(WebCore::RenderThemeMac::adjustTextAreaStyle):
(WebCore::RenderThemeMac::popupButtonMargins):
(WebCore::RenderThemeMac::popupButtonSizes):
(WebCore::RenderThemeMac::popupButtonPadding):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::meterSizeForBounds):
(WebCore::RenderThemeMac::paintMeter):
(WebCore::RenderThemeMac::supportsMeter):
(WebCore::RenderThemeMac::levelIndicatorStyleFor):
(WebCore::RenderThemeMac::levelIndicatorFor):
(WebCore::RenderThemeMac::progressBarSizes):
(WebCore::RenderThemeMac::progressBarMargins):
(WebCore::RenderThemeMac::minimumProgressBarHeight):
(WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar):
(WebCore::RenderThemeMac::animationDurationForProgressBar):
(WebCore::RenderThemeMac::adjustProgressBarStyle):
(WebCore::RenderThemeMac::paintProgressBar):
(WebCore::TopGradientInterpolate):
(WebCore::BottomGradientInterpolate):
(WebCore::MainGradientInterpolate):
(WebCore::TrackGradientInterpolate):
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintMenuListButton):
(WebCore::menuListButtonSizes):
(WebCore::RenderThemeMac::adjustMenuListStyle):
(WebCore::RenderThemeMac::popupInternalPaddingLeft):
(WebCore::RenderThemeMac::popupInternalPaddingRight):
(WebCore::RenderThemeMac::popupInternalPaddingTop):
(WebCore::RenderThemeMac::popupInternalPaddingBottom):
(WebCore::RenderThemeMac::adjustMenuListButtonStyle):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::menuListSizes):
(WebCore::RenderThemeMac::minimumMenuListSize):
(WebCore::RenderThemeMac::adjustSliderTrackStyle):
(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore::RenderThemeMac::adjustSliderThumbStyle):
(WebCore::RenderThemeMac::paintSliderThumb):
(WebCore::RenderThemeMac::paintSearchField):
(WebCore::RenderThemeMac::setSearchCellState):
(WebCore::RenderThemeMac::searchFieldSizes):
(WebCore::RenderThemeMac::setSearchFieldSize):
(WebCore::RenderThemeMac::adjustSearchFieldStyle):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::cancelButtonSizes):
(WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeMac::resultsButtonSizes):
(WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeMac::paintSearchFieldDecoration):
(WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):
(WebCore::RenderThemeMac::sliderTickSize):
(WebCore::RenderThemeMac::sliderTickOffsetFromTrackCenter):
(WebCore::RenderThemeMac::adjustSliderThumbSize):
(WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
(WebCore::RenderThemeMac::popupButton):
(WebCore::RenderThemeMac::search):
(WebCore::RenderThemeMac::searchMenuTemplate):
(WebCore::RenderThemeMac::sliderThumbHorizontal):
(WebCore::RenderThemeMac::sliderThumbVertical):
(WebCore::RenderThemeMac::textField):
(WebCore::RenderThemeMac::fileListNameForWidth):
* rendering/RenderThemeMacShared.h: Removed.
* rendering/RenderThemeMacShared.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK][AC] Visible rect doesn't update after resizing a window.
commit-queue@webkit.org [Wed, 24 Apr 2013 15:36:26 +0000 (15:36 +0000)]
[GTK][AC] Visible rect doesn't update after resizing a window.
https://bugs.webkit.org/show_bug.cgi?id=115096

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-04-24
Reviewed by Gustavo Noronha Silva.

Once we set actor's a clip rect, we should update the rect when resizing the actor.

No new tests since no new functionality.

* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::setSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK][AC] Fix unexpected clear of ClutterContent.
commit-queue@webkit.org [Wed, 24 Apr 2013 15:34:35 +0000 (15:34 +0000)]
[GTK][AC] Fix unexpected clear of ClutterContent.
https://bugs.webkit.org/show_bug.cgi?id=115099

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-04-24
Reviewed by Gustavo Noronha Silva.

adoptGRef doesn't increase a reference count. So if a actor has a valid ClutterContent,
it would be cleared unexpectedly by smart pointer when escaping a function.

No new tests, no functionality changed.

* platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorUpdateTexture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWild build fix attempt.
akling@apple.com [Wed, 24 Apr 2013 15:30:54 +0000 (15:30 +0000)]
Wild build fix attempt.

* WebCoreSupport/WebChromeClient.h:
(WebChromeClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WebKit2] Add CoordinatedGraphics to the list of platforms in generate-forwarding...
commit-queue@webkit.org [Wed, 24 Apr 2013 15:26:24 +0000 (15:26 +0000)]
[WebKit2] Add CoordinatedGraphics to the list of platforms in generate-forwarding-headers.pl
https://bugs.webkit.org/show_bug.cgi?id=115098

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-24
Reviewed by Martin Robinson.

r148963 introduced a new WKView.h header in a directory not listed
as a platform prefix in generate-forwarding-headers.pl.

* Scripts/generate-forwarding-headers.pl: Replace unused chromium
plaform prefix with CoordinatedGraphics that is used now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAssertion failure (crash in release) attempting to delete database storage in WK1...
jberlin@webkit.org [Wed, 24 Apr 2013 15:15:50 +0000 (15:15 +0000)]
Assertion failure (crash in release) attempting to delete database storage in WK1 without
creating a WebView first
https://bugs.webkit.org/show_bug.cgi?id=115065

Reviewed by Brady Eidson.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:
Remove WebDatabaseManagerInternal.h.

Source/WebKit/mac:

Make sure the WebPlatformStrategies is initialized before using the WebDatabaseManager.

* Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager init]):
Move the logic from WebKitInitializeDatabasesIfNecessary here, and add a call to
WebPlatformStrategies::initializeIfNecessary.

* Storage/WebDatabaseManagerInternal.h: Removed.

* WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
Change "initialize" to "initalizeIfNecessary".
* WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::initializeIfNecessary):
Only call setPlatformStrategies once.

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Updated for the name change from initialize to initializeIfNecessary.
Instead of calling WebKitInitializeDatabasesIfNecessary, call [WebDatabaseManager
sharedWebDatabaseManager].
(+[WebView _setLoadResourcesSerially:]):
Updated for the name change from initialize to initializeIfNecessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDOMFileSystemBase: fix multiple definitions in the BlackBerry port
commit-queue@webkit.org [Wed, 24 Apr 2013 14:27:13 +0000 (14:27 +0000)]
DOMFileSystemBase: fix multiple definitions in the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=114950

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-24
Reviewed by Xan Lopez.

The following  methods are already defined in DOMFileSystemBlackBerry.cpp:

crackFileSystemURL()
createFileSystemURL()
isValidType()
supportsToURL()

* Modules/filesystem/DOMFileSystemBase.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Add support for JPEG image quality during encoding.
commit-queue@webkit.org [Wed, 24 Apr 2013 14:10:47 +0000 (14:10 +0000)]
[BlackBerry] Add support for JPEG image quality during encoding.
https://bugs.webkit.org/show_bug.cgi?id=105773

Patch by George Staikos <gstaikos@rim.com> on 2013-04-24
Reviewed by Xan Lopez.

PR 271611
Internally reviewed by Liam Quinn.

Pass the quality flag into the encoder, with a default of 65

Covered by existing tests.

* platform/image-encoders/JPEGImageEncoder.cpp:
(WebCore::compressRGBABigEndianToJPEG):
* platform/image-encoders/JPEGImageEncoder.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Add unit test cases for ewk_settings APIs
commit-queue@webkit.org [Wed, 24 Apr 2013 13:54:27 +0000 (13:54 +0000)]
[EFL] Add unit test cases for ewk_settings APIs
https://bugs.webkit.org/show_bug.cgi?id=114897

Patch by Jose Lejin PJ <jose.lejin@gmail.com> on 2013-04-24
Reviewed by Gyuyoung Kim.

Added unit tests for ewk_settings APIs.

* tests/test_ewk_setting.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149032 268f45cc-cd09-0410-ab3c-d52691b4dbfc