15 years agoWebCore:
mitz@apple.com [Wed, 28 Nov 2007 22:04:44 +0000 (22:04 +0000)]

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5612459> CrashTracer: [REGRESSION] 61 crashes in Safari at com.apple.WebCore: WebCore::AutoTableLayout::layout + 2046

        Test: fast/table/empty-auto-column-zero-divide.html

        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::layout): When distributing the remaining
        width among columns, skip those whose effective (rather than
        specified) width is auto and contain only empty cells.


        Reviewed by Dave Hyatt.

        - test for <rdar://problem/5612459> CrashTracer: [REGRESSION] 61 crashes in Safari at com.apple.WebCore: WebCore::AutoTableLayout::layout + 2046

        * fast/table/empty-auto-column-zero-divide-expected.txt: Added.
        * fast/table/empty-auto-column-zero-divide.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
adele@apple.com [Wed, 28 Nov 2007 22:03:40 +0000 (22:03 +0000)]
    Reviewed by Darin.

        Fix for <rdar://problem/5524216> CrashTracer: [USER] 496 crashes in Safari at com.apple.WebCore: WebCore::Frame::eventHandler const + 6

        The CrashTracer shows a variety of crashes in different methods (including keyDown and keyUp). This change adds nil checks for the frame in
        WebHTMLView to prevent future problems in other methods as well.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
        (-[WebHTMLView keyDown:]):
        (-[WebHTMLView keyUp:]):
        (-[WebHTMLView flagsChanged:]):
        (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
        (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
        (-[WebHTMLView checkSpelling:]):
        (-[WebHTMLView showGuessPanel:]):
        (-[WebHTMLView indent:]):
        (-[WebHTMLView outdent:]):
        (-[WebHTMLView paste:]):
        (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
        (-[WebHTMLView insertText:]):
        (-[WebHTMLView selectionTextRects]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
andersca@apple.com [Wed, 28 Nov 2007 21:17:59 +0000 (21:17 +0000)]
    Reviewed by Adam.

        Implement the last bits of the WebDatabaseManager API.

        * Interfaces/IWebDatabaseManager.idl:
        * WebDatabaseManager.cpp:
        * WebDatabaseManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Get Drosera working again for real.
andersca@apple.com [Wed, 28 Nov 2007 20:12:17 +0000 (20:12 +0000)]
    Get Drosera working again for real.

        * COMEnumVariant.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-28 Peter Kasting <zerodpx@gmail.com>
alp@webkit.org [Wed, 28 Nov 2007 19:57:31 +0000 (19:57 +0000)]
2007-11-28  Peter Kasting  <zerodpx@gmail.com>

        Reviewed by Alp Toker.

        GIF decoder needs to set hasAlpha() correctly on subsequent frames.

        This also removes the workaround for this problem in

        * platform/graphics/cairo/ImageSourceCairo.cpp:
        * platform/image-decoders/gif/GIFImageDecoder.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-28 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Wed, 28 Nov 2007 19:37:33 +0000 (19:37 +0000)]
2007-11-28  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Dan.

        <rdar://problem/5507360> plugins/return-error-from-new-stream-callback-
        in-full-frame-plugin.html is crashing

        Alice fixed this in r28046

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej and Adam.
kmccullough@apple.com [Wed, 28 Nov 2007 17:46:51 +0000 (17:46 +0000)]
    Reviewed by Maciej and Adam.

        - Added Drosera to the WebKit project.

        * WebKit.vcproj/WebKit.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler and Adam Roben.
mitz@apple.com [Wed, 28 Nov 2007 16:47:39 +0000 (16:47 +0000)]
    Reviewed by Darin Adler and Adam Roben.

        - <rdar://problem/5057218> Reenable "recent searches" search field menu when menu is fully implemented

        * platform/win/SearchPopupMenuWin.cpp:
        (WebCore::SearchPopupMenu::enabled): Changed to return true.
        (WebCore::autosaveKey): Added. Returns a preferences key for the
        autosave name by prefixing it with "com.apple.WebKit.searchField:".
        (WebCore::SearchPopupMenu::saveRecentSearches): Implemented.
        (WebCore::SearchPopupMenu::loadRecentSearches): Implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRoll out r28106 and r28108. These introduced a frequent assertion failure on page...
mrowe@apple.com [Wed, 28 Nov 2007 13:12:03 +0000 (13:12 +0000)]
Roll out r28106 and r28108.  These introduced a frequent assertion failure on page load and broke all non-Mac builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-28 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 28 Nov 2007 12:47:37 +0000 (12:47 +0000)]
2007-11-28  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        [GTK] Background of loading images is always black

        frameHasAlphaAtIndex() exists only to allow optimization for cases we
        are certain the image can be blitted rather than composited.

        Thus we need to be conservative, returning false only when we are
        absolutely certain there is no need for composited copying, and true

        CG doesn't even bother with this optimization at all and always
        returns true.

        Patch includes a workaround for
          GIF ImageDecoder hasAlpha() return value incorrect

        * platform/graphics/cairo/ImageSourceCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
mjs@apple.com [Wed, 28 Nov 2007 11:03:10 +0000 (11:03 +0000)]

        Add files missing from previous commit.

        * kjs/MarkStack.h: Added.


        add files missing from previous commit.

        * fast/js/gc-breadth-2-expected.txt: Added.
        * fast/js/gc-breadth-2.html: Added.
        * fast/js/gc-breadth-expected.txt: Added.
        * fast/js/gc-breadth.html: Added.
        * fast/js/gc-depth-expected.txt: Added.
        * fast/js/gc-depth.html: Added.
        * fast/js/resources/gc-breadth-2.js: Added.
        * fast/js/resources/gc-breadth.js: Added.
        * fast/js/resources/gc-depth.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-26 Rodney Dawes <dobey@wayofthemonkey.com>
mrowe@apple.com [Wed, 28 Nov 2007 10:42:20 +0000 (10:42 +0000)]
2007-11-26  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Mark Rowe.

        Set CONFIG option for the window system GTK+ is using

        * WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
mjs@apple.com [Wed, 28 Nov 2007 10:08:09 +0000 (10:08 +0000)]

        Reviewed by Darin and Geoff.

        - Fixed "Stack overflow crash in JavaScript garbage collector mark pass"

        Implement mark stack. This version is not suitable for prime time because it makes a
        huge allocation on every collect, and potentially makes marking of detached subtrees
        slow. But it is an 0.4% SunSpider speedup even without much tweaking.

        The basic approach is to replace mark() methods with
        markChildren(MarkStack&) methods. Reachable references are pushed
        onto a mark stack (which encapsulates ignoring already-marked

        Objects are no longer responsible for actually setting their own
        mark bits, the collector does that. This means that for objects on
        the number heap we don't have to call markChildren() at all since
        we know there aren't any.

        The mark phase of collect pushes roots onto the mark stack
        and drains it as often as possible.

        To make this approach viable requires a constant-size mark stack
        and a slow fallback approach for when the stack size is exceeded,
        plus optimizations to make the required stack small in common
        cases. This should be doable.

        * JavaScriptCore.exp: Export new symbols.
        * JavaScriptCore.xcodeproj/project.pbxproj: Add new file.
        * kjs/collector.cpp:
        (KJS::drainMarkStack): Helper for all of the below.
        (KJS::Collector::markStackObjectsConservatively): Use mark stack.
        (KJS::Collector::markCurrentThreadConservatively): ditto
        (KJS::Collector::markOtherThreadConservatively): ditto
        (KJS::Collector::markProtectedObjects): ditto
        (KJS::Collector::markMainThreadOnlyObjects): ditto
        (KJS::Collector::collect): ditto
        * kjs/collector.h:
        (KJS::Collector::cellMayHaveRefs): Helper for MarkStack.

        * kjs/MarkStack.h: Added. The actual mark stack implementation.

        Changed mark() methods to markChildren() methods:

        * kjs/ExecState.cpp:
        * kjs/ExecState.h:
        * kjs/JSWrapperObject.cpp:
        * kjs/JSWrapperObject.h:
        * kjs/array_instance.cpp:
        * kjs/array_instance.h:
        * kjs/bool_object.cpp:
        * kjs/bool_object.h:
        * kjs/error_object.cpp:
        * kjs/error_object.h:
        * kjs/function.cpp:
        * kjs/function.h:
        * kjs/internal.cpp:
        * kjs/interpreter.cpp:
        * kjs/interpreter.h:
        * kjs/list.cpp:
        * kjs/list.h:
        * kjs/object.cpp:
        * kjs/object.h:
        * kjs/property_map.cpp:
        * kjs/property_map.h:
        * kjs/scope_chain.h:
        * kjs/string_object.cpp:
        * kjs/string_object.h:


        Reviewed by Darin and Geoff.

        Fixups for JavaScriptCore mark stack.

        * JSObject.cpp:
        * JSObject.h:
        * JSValueWrapper.cpp:
        * JSValueWrapper.h:
        * UserObjectImp.cpp:
        * UserObjectImp.h:


        Reviewed by Darin and Geoff.

        Implement mark stack. This version is not suitable for prime time because it makes a
        huge allocation on every collect, and potentially makes marking of detached subtrees
        slow. But it is a .2% - .4% speedup even without much tweaking.

        I replaced mark() methods with markChildren() as usual. One
        optimization that is lost is avoiding walking detached DOM
        subtrees more than once to mark them; since marking is not
        recursive there's no obvious way to bracket operation on the tree
        any more.

        * bindings/js/JSDocumentCustom.cpp:
        * bindings/js/JSNodeCustom.cpp:
        * bindings/js/JSNodeFilterCondition.cpp:
        * bindings/js/JSNodeFilterCondition.h:
        * bindings/js/JSNodeFilterCustom.cpp:
        * bindings/js/JSNodeIteratorCustom.cpp:
        * bindings/js/JSTreeWalkerCustom.cpp:
        * bindings/js/JSXMLHttpRequest.cpp:
        * bindings/js/JSXMLHttpRequest.h:
        * bindings/js/kjs_binding.cpp:
        * bindings/js/kjs_binding.h:
        * bindings/js/kjs_events.cpp:
        * bindings/js/kjs_events.h:
        * bindings/js/kjs_window.cpp:
        * bindings/js/kjs_window.h:
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Node.cpp:
        * dom/Node.h:
        * dom/NodeFilter.h:
        * dom/NodeFilterCondition.h:


        Not reviewed.

        - Test cases for "Stack overflow crash in JavaScript garbage collector mark pass"

        I have fixed this with the mark stack work.

        * fast/js/gc-breadth-2-expected.txt: Added.
        * fast/js/gc-breadth-2.html: Added.
        * fast/js/gc-breadth-expected.txt: Added.
        * fast/js/gc-breadth.html: Added.
        * fast/js/gc-depth-expected.txt: Added.
        * fast/js/gc-depth.html: Added.
        * fast/js/resources/gc-breadth-2.js: Added.
        * fast/js/resources/gc-breadth.js: Added.
        * fast/js/resources/gc-depth.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoNot reviewer for this patch.
mjs@apple.com [Wed, 28 Nov 2007 09:24:30 +0000 (09:24 +0000)]
Not reviewer for this patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej Stachowiak.
mitz@apple.com [Wed, 28 Nov 2007 09:04:15 +0000 (09:04 +0000)]
    Reviewed by Maciej Stachowiak.

        - fix <rdar://problem/5596160> fast/events/objc-event-api.html fails when run alone (or first)

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView setDataSource:]): This method calls addMouseMovedObserver
        because addMouseMovedObserver returns early if the dataSource
        is not nil. But if the dataSource is already set (which happens when
        a WebHTMLView is being reused) then addMouseMovedObserver must not
        be called again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-27 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 28 Nov 2007 08:27:10 +0000 (08:27 +0000)]
2007-11-27  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Install the JavaScriptCore headers as part of the GTK+ port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
bdakin@apple.com [Wed, 28 Nov 2007 06:31:28 +0000 (06:31 +0000)]

        Reviewed by Oliver.

        Fix for <rdar://problem/5616052> SVGs with width or height of 100%
        hang when used as a background-image (16164)

        * platform/graphics/svg/SVGImage.cpp:
        (WebCore::SVGImage::size): Use valueAsPercentage() for percents
        instead of valueInSpecifiedUnits(). valueInSpecifiedUnits()
        returns, for example, 50 for 50%, so multiplying percentages by the
        default size of 300 x 150 led to ridiculously huge dimensions for
        SVG images, and the subsequent hang.


        Reviewed by Oliver.

        Test for <rdar://problem/5616052> SVGs with width or height of 100%
        hang when used as a background-image (16164)

        * fast/images/resources/width-100-percent.svg: Added.
        * fast/images/svg-width-100p-as-background.html: Added.
        * platform/mac/fast/images/svg-width-100p-as-background-expected.checksum: Added.
        * platform/mac/fast/images/svg-width-100p-as-background-expected.png: Added.
        * platform/mac/fast/images/svg-width-100p-as-background-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Not reviewed.
mjs@apple.com [Wed, 28 Nov 2007 05:54:53 +0000 (05:54 +0000)]
    Not reviewed.

        Fix DumpRenderTree ObjC bug comparing strings.

        * DumpRenderTree/mac/ObjCController.m:
        (-[ObjCController identityIsEqual::]): Compare strings with string
        equality instead of identiy equality.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-27 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 28 Nov 2007 05:48:22 +0000 (05:48 +0000)]
2007-11-27  Alp Toker  <alp@atoker.com>

        Prospective MSVC build fix.

        Roll back dllexport/dllimport support for now.

        * API/JSBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-27 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Wed, 28 Nov 2007 04:50:45 +0000 (04:50 +0000)]
2007-11-27  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam.

        Return bool from registerWebViewWindowClass, as nothing uses the ATOM.
        Set haveRegisteredWindowClass to true

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-27 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Wed, 28 Nov 2007 04:47:48 +0000 (04:47 +0000)]
2007-11-27  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam.

        Set haveRegisteredWindowClass when we register the window class.

        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-27 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 28 Nov 2007 04:31:51 +0000 (04:31 +0000)]
2007-11-27  Alp Toker  <alp@atoker.com>

        Reviewed by Maciej.

        [gtk] GTK JavaScriptCore needs to export symbols for JSC API and WTF

        Introduce JS_EXPORT to mark symbols to be exported as public API.

        Export all public symbols in the JavaScriptCore C API.

        This matches conventions for exporting symbols set by the CF and CG

        * API/JSBase.h:
        * API/JSContextRef.h:
        * API/JSObjectRef.h:
        * API/JSStringRef.h:
        * API/JSStringRefBSTR.h:
        * API/JSStringRefCF.h:
        * API/JSValueRef.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Speculative fix to get Drosera working.
andersca@apple.com [Wed, 28 Nov 2007 02:47:12 +0000 (02:47 +0000)]
    Speculative fix to get Drosera working.

        * COMEnumVariant.h:
        Update the number of elements fetched correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady.
andersca@apple.com [Wed, 28 Nov 2007 01:34:54 +0000 (01:34 +0000)]
    Reviewed by Brady.

        * Storage/WebDatabaseManager.mm:
        * Storage/WebDatabaseManagerPrivate.h:
        * Storage/WebDatabaseTrackerClient.mm:
        * Storage/WebSecurityOrigin.mm:
        (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
        * Storage/WebSecurityOriginInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam.
timothy@apple.com [Wed, 28 Nov 2007 01:22:21 +0000 (01:22 +0000)]
    Reviewed by Sam.

        Reset the authorAndUserStylesEnabled preference
        back to YES for each test. Fixes the broken tests.

        * DumpRenderTree/mac/DumpRenderTree.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam Weinig.
timothy@apple.com [Wed, 28 Nov 2007 01:12:22 +0000 (01:12 +0000)]
    Reviewed by Sam Weinig.

        Bug 16165: Dragging the inspector toolbar should move the window

        * page/inspector/DocumentPanel.js: Call the new drag functions, and cleanup code.
        * page/inspector/inspector.css: Only make the toolbar transparent in detached mode.
        * page/inspector/inspector.js: Call the new drag functions, and cleanup code. Add
          toolbar drag functions that move the window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
andersca@apple.com [Wed, 28 Nov 2007 01:12:14 +0000 (01:12 +0000)]
    Reviewed by Adam.

        Some COM cleanup.

        * CFDictionaryPropertyBag.cpp:
        * CFDictionaryPropertyBag.h:
        * WebBackForwardList.cpp:
        * WebDownload.cpp:
        * WebFrame.cpp:
        * WebURLAuthenticationChallenge.cpp:
        * WebURLAuthenticationChallenge.h:
        * WebURLAuthenticationChallengeSender.cpp:
        * WebURLAuthenticationChallengeSender.h:
        * WebURLResponse.cpp:
        * WebURLResponse.h:
        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
kmccullough@apple.com [Wed, 28 Nov 2007 00:35:08 +0000 (00:35 +0000)]
    Reviewed by Adam.

        - Drosera now displays the console window, although it cannot currently
        process JavaScript.

        * Drosera/win/DebuggerClient.cpp: Shows the console window.
        (registerConsoleClass): Implemented.
        (consoleWndProc): Implemented.
        (DebuggerClient::onSize): Implemented.
        (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
        new window.
        * Drosera/win/DebuggerClient.h: Added needed method and members for
        creating and maintaining a new window.
        * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
        lines of code to more appropriate places.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add COMEnumVariant.h to the project.
andersca@apple.com [Wed, 28 Nov 2007 00:12:12 +0000 (00:12 +0000)]
    Add COMEnumVariant.h to the project.

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
andersca@apple.com [Wed, 28 Nov 2007 00:11:32 +0000 (00:11 +0000)]
    Reviewed by Adam.

        Return E_INVALIDARG if the databaseName BSTR is null;

        * WebDatabaseManager.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
andersca@apple.com [Tue, 27 Nov 2007 23:57:43 +0000 (23:57 +0000)]
    Reviewed by Adam.

        Implement the rest of the WebDatabaseManager API.

        * COMEnumVariant.h:
        * Interfaces/IWebDatabaseManager.idl:
        * WebDatabaseManager.cpp:
        * WebDatabaseManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLand results for my last test change,
timothy@apple.com [Tue, 27 Nov 2007 23:34:40 +0000 (23:34 +0000)]
Land results for my last test change,

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago <rdar://problem/5616098> The BSTR returned by WebHistoryItem::alternateTitle
adachan@apple.com [Tue, 27 Nov 2007 23:32:36 +0000 (23:32 +0000)]
    <rdar://problem/5616098> The BSTR returned by WebHistoryItem::alternateTitle
        was not allocated correctly.

        Reviewed by Anders.

        * WebHistoryItem.cpp:
        * WebHistoryItem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
antti@apple.com [Tue, 27 Nov 2007 23:30:30 +0000 (23:30 +0000)]
    Reviewed by Mitz.

        Small changes to make RenderSlider a bit more generic so it can be used in video controls.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::defaultEventHandler): Fix coordinates with forwarded events.
        * rendering/RenderSlider.cpp:
        (WebCore::HTMLSliderThumbElement::defaultEventHandler): Fix coordinates with forwarded events.
        (WebCore::RenderSlider::createThumbStyle): Copy thumb left and top from the orginal style so position does not reset.
        (WebCore::RenderSlider::mouseEventIsInThumb): Make this work with forwarded events.
        * rendering/RenderSlider.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
antti@apple.com [Tue, 27 Nov 2007 23:27:13 +0000 (23:27 +0000)]
    Reviewed by Darin.

        - Don't use hasPseudoId() optimization for pseudo styles used in shadow trees. These styles
          generally exist when asked for so the optimization does not do much. This reverses the continuing
          growth of the _pseudoBits bitfield in RenderStyle.
        - Add some pseudo elements for media controls

        * css/CSSSelector.cpp:
        * css/CSSSelector.h:
        * css/CSSStyleSelector.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
timothy@apple.com [Tue, 27 Nov 2007 23:05:49 +0000 (23:05 +0000)]

        Reviewed by Kevin McCullough.

        Bug 16161: window.moveBy(0, 0) moves the window by -22px vertically

        Removed the "Adjust the window rect to be in the coordinate space of
        the screen rect" step which was always adding (0,22) to the window
        position (on the main screen). Instead, account for screen X and Y
        in the bottom and right constrain step.

        Added more test cases to: fast/dom/Window/window-resize.html

        * bindings/js/kjs_window.cpp:


        Reviewed by Kevin McCullough.

        Bug 16161: window.moveBy(0, 0) moves the window by -22px vertically

        Added test cases for moveBy(0, 0), moveBy(0, 1) and  moveBy(1, 0).

        * fast/dom/Window/window-resize.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix.
andersca@apple.com [Tue, 27 Nov 2007 23:00:26 +0000 (23:00 +0000)]
    Build fix.

        * JSUtils.cpp:
        * JSValueWrapper.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin, landed by Anders.
andersca@apple.com [Tue, 27 Nov 2007 22:30:41 +0000 (22:30 +0000)]
    Reviewed by Darin, landed by Anders.

        Fixed: <rdar://problem/4610818> CrashTracer: 1533 crashes in Safari at com.macromedia.Flash Player.plugin: native_ShockwaveFlash_TCallLabel + 271131

        The problem was that some Leopard users were still inadvertently using the old Flash 8 plug-in, even though Leopard
        shipped with Flash 9. To avoid loading an older version of a plug-in when a newer version is installed, the plug-in
        database will compare bundle versions and always load the latest version.

        * Plugins/WebBasePluginPackage.h:
        * Plugins/WebBasePluginPackage.m:
        (-[WebBasePluginPackage versionNumber]): New method. CFBundleGetVersionNumber doesn't work with all possible versioning schemes,
        but we think for now it's good enough for us.
        * Plugins/WebPluginDatabase.m:
        (considerCandidate): Added a C utility function which compares the current plug-in against a candidate plug-in's version number.
        If both plug-ins have the same bundle ID and the candiate is newer, the current plug-in becomes the candidate.
        (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): Calls the new considerCandidate() function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
andersca@apple.com [Tue, 27 Nov 2007 22:27:43 +0000 (22:27 +0000)]
    Reviewed by Adam.

        Use COMEnumVariant in WebScriptCallFrame and WebScriptScope.

        * WebScriptCallFrame.cpp:
        * WebScriptScope.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
andersca@apple.com [Tue, 27 Nov 2007 22:21:24 +0000 (22:21 +0000)]
    Reviewed by Adam.

        Make PropertyNameArray and ScopeChain COMEnumVariant friendly.

        * kjs/PropertyNameArray.cpp:
        Implement PropertyNameArray::swap.

        * kjs/PropertyNameArray.h:
        Add ValueType typedef. Replace PropertyNameArrayIterator with

        * kjs/nodes.cpp:
        * kjs/scope_chain.cpp:
        Update for changes to PropertyNameArray.

        * kjs/scope_chain.h:
        Add const_iterator and ValueType typedef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
andersca@apple.com [Tue, 27 Nov 2007 21:48:33 +0000 (21:48 +0000)]
    Reviewed by Adam.

        Use the correct include paths.

        * COMEnumVariant.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
andersca@apple.com [Tue, 27 Nov 2007 21:43:18 +0000 (21:43 +0000)]
    Reviewed by Darin.

        Add COMEnumVariant, a templatized class with implements IEnumVARIANT and lets
        you enumerate over a C++ container, be it WTF or STL.

        * COMEnumVariant.h: Added.

        * WebDatabaseManager.cpp:
        Implement these using COMEnumVariant.

        * WebSecurityOrigin.cpp:
        * WebSecurityOrigin.h:
        Add a UUID for the implementation so that other parts of WebKit can access
        the WebCore::SecurityOriginData object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
andersca@apple.com [Tue, 27 Nov 2007 21:27:59 +0000 (21:27 +0000)]
    Reviewed by Darin.

        Add a ValueType typedef.

        * wtf/Vector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
timothy@apple.com [Tue, 27 Nov 2007 21:23:22 +0000 (21:23 +0000)]
    Reviewed by Adam Roben.

        * page/inspector/inspector.css: Make the text in the Network
        panel legend more readable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
timothy@apple.com [Tue, 27 Nov 2007 20:51:51 +0000 (20:51 +0000)]
    Reviewed by Adam Roben.

        Don't call setNeedsReapplyStylesInAllFrames if the
        authorAndUserStylesEnabled setting didn't change.

        * page/Settings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-27 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 27 Nov 2007 18:53:54 +0000 (18:53 +0000)]
2007-11-27  Alp Toker  <alp@atoker.com>

        Fix potential broken build due to a missing DEPENDPATH.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fixed 5614525, caused by a recent bug in WKGetExtensionsForMIMEType
sullivan@apple.com [Tue, 27 Nov 2007 18:48:20 +0000 (18:48 +0000)]
    Fixed 5614525, caused by a recent bug in WKGetExtensionsForMIMEType
        that affects Safari.

        reviewed by Kevin Decker

        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
timothy@apple.com [Tue, 27 Nov 2007 17:15:19 +0000 (17:15 +0000)]

        Reviewed by Dave Hyatt.

        <rdar://problem/5569233> Add the ability to disable author and user CSS styles

        * WebCore.base.exp: Add the Settings::setAuthorAndUserStylesEnabled symbol.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector): Add a new matchAuthorAndUserStyles parameter.
        (WebCore::CSSStyleSelector::styleForElement): Check m_matchAuthorAndUserStyles before
        matching user and author rules.
        (WebCore::CSSStyleSelector::pseudoStyleForElement): Ditto.
        (WebCore::CSSStyleSelector::styleRulesForElement): Ditto.
        * css/CSSStyleSelector.h: Add m_matchAuthorAndUserStyles and new constructor parameter.
        * dom/Document.cpp:
        (WebCore::Document::Document): Pass Settings::authorAndUserStylesEnabled to the CSSStyleSelector.
        (WebCore::Document::recalcStyleSelector): Skip collecting the author stylesheets if
        Settings::authorAndUserStylesEnabled is false, and pass that to the CSSStyleSelector.
        * page/Settings.cpp:
        (WebCore::Settings::Settings): Initialize m_authorAndUserStylesEnabled to true.
        (WebCore::Settings::setAuthorAndUserStylesEnabled): Recalc style in all the frames
        when the setting changes.
        * page/Settings.h: Add m_authorAndUserStylesEnabled.
        (WebCore::Settings::authorAndUserStylesEnabled): Return m_authorAndUserStylesEnabled.


        Reviewed by Dave Hyatt.

        <rdar://problem/5569233> Add the ability to disable author and user CSS styles

        * WebView/WebPreferenceKeysPrivate.h: Define WebKitRespectStandardStyleKeyEquivalentsPreferenceKey.
        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]): Default WebKitRespectStandardStyleKeyEquivalentsPreferenceKey to YES.
        (-[WebPreferences authorAndUserStylesEnabled]): Return the setting's BOOL value.
        (-[WebPreferences setAuthorAndUserStylesEnabled:]): Set the setting's BOOL value.
        * WebView/WebPreferencesPrivate.h: Add authorAndUserStylesEnabled and setAuthorAndUserStylesEnabled:.
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings::authorAndUserStylesEnabled.


        Reviewed by Dave Hyatt.

        <rdar://problem/5569233> Add the ability to disable author and user CSS styles

        Add support for disabling author and user styles for testing.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/LayoutTestController.cpp:
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:


        Reviewed by Dave Hyatt.

        Test for: <rdar://problem/5569233> Add the ability to disable author and user CSS styles

        * fast/css/disabled-author-styles.html: Added.
        * platform/mac/fast/css/disabled-author-styles-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-27 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 27 Nov 2007 08:15:36 +0000 (08:15 +0000)]
2007-11-27  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Based on changes by Mike Emmel.

        CURL HTTP backend local file fixes:

        Set a MIME type for local files based on the file extension.

        Remove any HTTP query part sent to a local file.

        * platform/network/curl/ResourceHandleManager.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
beidson@apple.com [Tue, 27 Nov 2007 03:28:31 +0000 (03:28 +0000)]

        Reviewed by Mark Rowe

        Allow setting the default storage quota per database origin

        * WebCore.base.exp:

        * page/Settings.cpp:
        * page/Settings.h:

        * storage/DatabaseTracker.cpp:
        * storage/DatabaseTracker.h:


        Reviewed by Mark Rowe

        Provide API for setting the default storage quota per database origin

        * Misc/WebNSDictionaryExtras.h:
        * Misc/WebNSDictionaryExtras.m:
        (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Helper for UINT64 preferences

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.m:
        (-[WebPreferences _unsignedLongLongValueForKey:]): Helper for UINT64 prefs
        (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto
        (-[WebPreferences defaultDatabaseQuota]):
        (-[WebPreferences setDefaultDatabaseQuota:]):
        * WebView/WebPreferencesPrivate.h:

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]): Set the WebCore Settings version of the default storage pref

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-26 Peter Kasting <zerodpx@gmail.com>
alp@webkit.org [Tue, 27 Nov 2007 03:01:23 +0000 (03:01 +0000)]
2007-11-26  Peter Kasting  <zerodpx@gmail.com>

        Reviewed by Alp Toker.

        GIF decoding should respect frames' specified disposal methods.

        * platform/image-decoders/ImageDecoder.h:
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        * platform/image-decoders/gif/GIFImageDecoder.h:
        * platform/image-decoders/gif/GIFImageReader.cpp:
        * platform/image-decoders/gif/GIFImageReader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Make WebKitGraphics able to handle grayscale colors
aroben@apple.com [Tue, 27 Nov 2007 02:20:03 +0000 (02:20 +0000)]
 Make WebKitGraphics able to handle grayscale colors


         Add a Color(CGColorRef) constructor

         Reviewed by Darin.

         * platform/graphics/Color.h:
         * platform/graphics/cg/ColorCG.cpp:
         (WebCore::Color::Color): Added.


         Take advantage of the new Color constructor that takes a CGColorRef

         This lets us handle grayscale colors (which only have 2 components).

         Reviewed by Darin.

         * WebKitGraphics.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
adele@apple.com [Tue, 27 Nov 2007 02:15:10 +0000 (02:15 +0000)]
    Reviewed by Darin.

        Update to last change.  Moved addPendingSheet call to within nil check for m_cachedSheet.

        * page/Frame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-26 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 27 Nov 2007 02:08:11 +0000 (02:08 +0000)]
2007-11-26  Alp Toker  <alp@atoker.com>

        Reviewed by Adam Roben.

        Implement the window-object-cleared signal

        This implementation provides the JSGlobalContextRef and JSObjectRef
        directly rather than using an intermediate JS wrapper object, similar
        to the approach taken by the Win port.

        * Api/webkitgtk-marshal.list:
        * Api/webkitgtkframe.h:
        * Api/webkitgtkpage.cpp:
        * Api/webkitgtkpage.h:
        * WebCoreSupport/FrameLoaderClientGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
adele@apple.com [Tue, 27 Nov 2007 02:07:17 +0000 (02:07 +0000)]
    Reviewed by Darin.

        Fix for <rdar://problem/5591583> CrashTracer: [USER] 157 in Mail crashes at -[WebCoreFrameBridge reapplyStylesForDeviceType:]

        * page/Frame.cpp: Add nil checks since every other caller of requestCSSStyleSheet checks for nil.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoGCC 4.2 build fix.
mrowe@apple.com [Tue, 27 Nov 2007 02:05:03 +0000 (02:05 +0000)]
GCC 4.2 build fix.

* xml/XSLTUnicodeSort.cpp: Add another WTF_ATTRIBUTE_PRINTF.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
weinig@apple.com [Tue, 27 Nov 2007 01:52:43 +0000 (01:52 +0000)]

        Reviewed and touched up by Sam Weinig.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=16073

        Test: http/tests/security/xss-DENIED-invalid-domain-change.html

        * dom/Document.cpp:
        (WebCore::Document::setDomain): Don't set the securityOrigin policy unless
        the set succeeds.  Adds some early returns as well.


        Reviewed by Sam Weinig.

        Tests for http://bugs.webkit.org/show_bug.cgi?id=16073

        * http/tests/security/resources/iframe-invalid-domain-change.html: Added.
        * http/tests/security/xss-DENIED-invalid-domain-change-expected.txt: Added.
        * http/tests/security/xss-DENIED-invalid-domain-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
darin@apple.com [Tue, 27 Nov 2007 01:35:05 +0000 (01:35 +0000)]
    Reviewed by Adele.

        - some middle-mouse-button-related fixes

        These don't affect Safari since it maps the middle mouse button to the command key,
        but that might not always be the case for future versions.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView otherMouseDown:]): Pass through middle mouse down events to WebCore.
        (-[WebHTMLView otherMouseDragged:]): Ditto, for drag events.
        (-[WebHTMLView otherMouseUp:]): Ditto, for up events.

        * WebView/WebPolicyDelegate.h: Fixed inaccurate documentation of WebActionButtonKey.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix.
sfalken@apple.com [Tue, 27 Nov 2007 01:25:14 +0000 (01:25 +0000)]
    Build fix.

        * WebKit.vcproj/WebKit.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
sfalken@apple.com [Tue, 27 Nov 2007 01:08:58 +0000 (01:08 +0000)]

        Build fix.

        * WebCore.vcproj/WebCore.make:
        * WebCore.vcproj/migrate-idls.sh:


        Build fix.

        * WebKit.vcproj/build-generated-files.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
darin@apple.com [Tue, 27 Nov 2007 00:50:36 +0000 (00:50 +0000)]

        Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16096
          REGRESSION (r26653-r26699): Plaxo.com addressbook does not load in webkit nightlies

        Test: fast/js/regexp-overflow.html

        * pcre/pcre_compile.cpp: (calculateCompiledPatternLengthAndFlags):
        Removed a stray "ptr++" that I added by accident when merging the
        changes between PCRE 6.4 and 6.5.


        Reviewed by Mitz.

        - test for http://bugs.webkit.org/show_bug.cgi?id=16096
          REGRESSION (r26653-r26699): Plaxo.com addressbook does not load in webkit nightlies

        * fast/js/regexp-overflow-expected.txt: Added.
        * fast/js/regexp-overflow.html: Added.
        * fast/js/resources/regexp-overflow.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix potential null-dereference.
weinig@apple.com [Tue, 27 Nov 2007 00:28:24 +0000 (00:28 +0000)]
    Fix potential null-dereference.

        Reviewed by Adam Roben.

        * page/FrameTree.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
weinig@apple.com [Tue, 27 Nov 2007 00:15:21 +0000 (00:15 +0000)]

        Reviewed by Darin.

        Fix for <rdar://problem/5592988>
        - Enforce tighter restrictions on what frames in other domains
          can be navigated.

        Tests: http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html

        * bindings/js/kjs_window.cpp:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::shouldAllowNavigation): Move and update logic from canTarget().
        * loader/FrameLoader.h:
        * page/FrameTree.cpp:
        (WebCore::FrameTree::isDescendantOf): Make this O(1) in the case when both frames are not
        in the same page.


        Reviewed by Darin.

        Tests for <rdar://problem/5592988>

        - Update and add tests for new tighter restrictions on what frames in other domains
          can be navigated.

        * http/tests/security/cross-frame-access-location-expected.txt:
        * http/tests/security/frameNavigation: Added.
        * http/tests/security/frameNavigation/resources: Added.
        * http/tests/security/frameNavigation/resources/iframe-that-performs-parent-navigation.html: Added.
        * http/tests/security/frameNavigation/resources/iframe-with-inner-frame-on-foreign-domain.html: Added.
        * http/tests/security/frameNavigation/resources/navigation-changed-iframe.html: Added.
        * http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change-expected.txt: Added.
        * http/tests/security/frameNavigation/xss-ALLOWED-parent-navigation-change.html: Added.
        * http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change-expected.txt: Added.
        * http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
sfalken@apple.com [Mon, 26 Nov 2007 23:53:25 +0000 (23:53 +0000)]

        Build fix.

        * WebCore.vcproj/migrate-idls.sh:


        Build fix.

        * WebKit.vcproj/build-generated-files.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixed typo
ggaren@apple.com [Mon, 26 Nov 2007 23:50:18 +0000 (23:50 +0000)]
Fixed typo

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin McCullough.
ggaren@apple.com [Mon, 26 Nov 2007 23:48:14 +0000 (23:48 +0000)]
    Reviewed by Kevin McCullough.

        Fixed <rdar://problem/5597937> REGRESSION (r27126): Drosera does not
        show variables (can't enumerate ActivationImp properties)

        Implemented a custome ActivationImp::getPropertyNames, since
        ActivationImp now uses a custom property storage mechanism for local

        * kjs/function.cpp:
        * kjs/function.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
andersca@apple.com [Mon, 26 Nov 2007 23:45:46 +0000 (23:45 +0000)]
    Reviewed by Adam.

        Add an implementation of IWebSecurityOrigin and a partially stubbed out
        implementation of IWebDatabaseManager.

        * ForEachCoClass.h:
        * Interfaces/IWebDatabaseManager.idl:
        * Interfaces/WebKit.idl:
        * WebDatabaseManager.cpp:
        * WebDatabaseManager.h:
        * WebKit.vcproj/WebKit.vcproj:
        * WebKitClassFactory.cpp:
        * WebSecurityOrigin.cpp: Added.
        * WebSecurityOrigin.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - Tiger build fix.
mitz@apple.com [Mon, 26 Nov 2007 23:34:07 +0000 (23:34 +0000)]
    - Tiger build fix.

        * DumpRenderTree/mac/Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebKit/win:
kmccullough@apple.com [Mon, 26 Nov 2007 23:03:08 +0000 (23:03 +0000)]

        Reviewed by Maciej.

        - Implemented displaying variables for Drosera on Win.

        * Interfaces/IWebScriptCallFrame.idl: Added a local function to be
        able to access the WebScriptCallFrame.
        * Interfaces/IWebScriptScope.idl: Implemented.
        * Interfaces/WebKit.idl: Added WebScriptScope to the tlb.
        * WebKit.vcproj/Interfaces.vcproj:
        * WebScriptCallFrame.cpp: Implemented the helper and accessor methods.
        (EnumScopes::Next): Fixed a bug where we did not release correctly and
        would accidentally destroy scopes.
        (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString): Implemented
        * WebScriptCallFrame.h: Implemented the helper and accessor methods.
        * WebScriptScope.cpp: Implmented.
        (EnumVariables::EnumVariables): Created an IEnumVariant over the
        variables to be able to pass a DCOM acceptable structure back to
        (WebScriptScope::createInstance): Implemented.
        (WebScriptScope::variableNames): Implemented.
        * WebScriptScope.h: Implmeneted.


        Reviewed by Maciej.

        - Implemented displaying variables for Drosera on Win.

        * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
        that retrieve variables to not hold onto the return value since it's
        not returned.  Also changed to use the new signatures of the retrieval
        * Drosera/win/Drosera.cpp: Removed a needless TODO.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady.
andersca@apple.com [Mon, 26 Nov 2007 22:15:43 +0000 (22:15 +0000)]
    Reviewed by Brady.

        Add IWebDatabaseManager and IWebSecurityOrigin interfaces.

        * Interfaces/IWebDatabaseManager.idl: Added.
        * Interfaces/IWebSecurityOrigin.idl: Added.
        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/WebKitGUID.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Mon, 26 Nov 2007 21:19:00 +0000 (21:19 +0000)]

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5609337> Making a float shorter does not remove it from the floating object list of a nested block it intruded into

        Test: fast/dynamic/float-withdrawal-2.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlockChildren): When a float may have
        been withdrawn from a child, mark all descendants if necessary and not
        just the child.


        Reviewed by Dave Hyatt.

        - test for <rdar://problem/5609337> Making a float shorter does not remove it from the floating object list of a nested block it intruded into

        * fast/dynamic/float-withdrawal-2.html: Added.
        * platform/mac/fast/dynamic/float-withdrawal-2-expected.checksum: Added.
        * platform/mac/fast/dynamic/float-withdrawal-2-expected.png: Added.
        * platform/mac/fast/dynamic/float-withdrawal-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Cleanup names of painting and repainting functions.
weinig@apple.com [Mon, 26 Nov 2007 21:16:04 +0000 (21:16 +0000)]
    Cleanup names of painting and repainting functions.

        Reviewed by Adam Roben.

        * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
        (drawSelectionRect): was drawSelectionRectIntoContext.
        * DumpRenderTree/cg/PixelDumpSupportCG.h:
        * DumpRenderTree/mac/PixelDumpSupportMac.mm:
        (paintWebView): was drawWebViewIntoContext.
        (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Jon Honeycutt.
alice.liu@apple.com [Mon, 26 Nov 2007 19:51:57 +0000 (19:51 +0000)]
    Reviewed by Jon Honeycutt.

        Fall back to the default Policy Delegate in these functions,
        as is already done in dispatchDecidePolicyForNavigationAction

        * WebFrame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Dan Bernstein.
mitz@apple.com [Mon, 26 Nov 2007 19:47:19 +0000 (19:47 +0000)]
    Reviewed by Dan Bernstein.

        - Leopard build fix

        * DumpRenderTree/mac/Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady.
andersca@apple.com [Mon, 26 Nov 2007 19:35:14 +0000 (19:35 +0000)]
    Reviewed by Brady.

        Get rid of the WebSecurityOriginPrivate object and store
        the WebCore::SecurityOriginData pointer in the _private field of
        the WebSecurityOrigin object instead.

        * Storage/WebDatabaseManager.mm:
        (-[WebDatabaseManager databasesWithOrigin:]):
        (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
        (-[WebDatabaseManager deleteDatabasesWithOrigin:]):
        (-[WebDatabaseManager deleteDatabase:withOrigin:]):
        * Storage/WebSecurityOrigin.mm:
        (-[WebSecurityOrigin initWithProtocol:domain:port:]):
        (-[WebSecurityOrigin protocol]):
        (-[WebSecurityOrigin domain]):
        (-[WebSecurityOrigin port]):
        (-[WebSecurityOrigin usage]):
        (-[WebSecurityOrigin quota]):
        (-[WebSecurityOrigin setQuota:]):
        (-[WebSecurityOrigin dealloc]):
        (-[WebSecurityOrigin finalize]):
        (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
        (-[WebSecurityOrigin _core]):
        * Storage/WebSecurityOriginInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix.
sfalken@apple.com [Mon, 26 Nov 2007 19:34:45 +0000 (19:34 +0000)]
    Build fix.

        * WebCore.vcproj/MigrateIDLAndScripts: Copied from WebCore.vcproj/MigrateIDLAndScripts.make.
        * WebCore.vcproj/MigrateIDLAndScripts.make: Removed.
        * WebCore.vcproj/migrate-idls.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
weinig@apple.com [Mon, 26 Nov 2007 19:19:06 +0000 (19:19 +0000)]
    Fix for bugs.webkit.org/show_bug.cgi?id=16136
        Use shared PixelDumpSupport for Mac DRT

        Reviewed by Adam Roben.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
        * DumpRenderTree/cg/ImageDiffCG.cpp:
        * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
        * DumpRenderTree/cg/PixelDumpSupportCG.h:
        * DumpRenderTree/mac/Configurations/Base.xcconfig:
        * DumpRenderTree/mac/DumpRenderTree.mm:
        * DumpRenderTree/mac/ImageDiff.m: Removed.
        * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
        * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
        * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
        * DumpRenderTree/win/PixelDumpSupport.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders (and typo lovingly found by Adam)
beidson@apple.com [Mon, 26 Nov 2007 19:17:52 +0000 (19:17 +0000)]
    Reviewed by Anders (and typo lovingly found by Adam)

        Change Databases to be stored in a per-origin directory hierarchy - this will make
        storage quotas much easier to enforce

        * platform/SecurityOriginData.cpp:
        (WebCore::SecurityOriginData::SecurityOriginData): Parse string based on '_' instead of ':'
        (WebCore::SecurityOriginData::stringIdentifier): Change to use '_' as a separator instead of ':'.
          '_' still works due to not being allowed in domain names, but also is a valid filename character '
          on all filesystems we care about

        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::fullPathForDatabase): Create a per-origin directory hierarchy to categorize
          databases by origin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-26 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 26 Nov 2007 18:40:53 +0000 (18:40 +0000)]
2007-11-26  Alp Toker  <alp@atoker.com>

        GTK+/Qt/Wx build fix for breakage introduced in r28039.

        * ForwardingHeaders/JavaScriptCore/JSRetainPtr.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
timothy@apple.com [Mon, 26 Nov 2007 17:17:50 +0000 (17:17 +0000)]

        Reviewed by Adam Roben.

        Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title

        On Leopard the toolbar background will be transparent, to allow the
        window background to show through the transparent WebView. The
        search results divs needed to move inside the "main" div, so they
        would be clipped and not show where the toolbar is.

        * page/InspectorController.cpp:
        (WebCore::platform): Return a string for which platform we are.
        Define the platform function on the JavaScript class.
        * page/inspector/Panel.js: Add panels to the panels div.
        * page/inspector/inspector.css: On the Leopard platform make
        the toolbar background transparent so the window background shows.
        * page/inspector/inspector.html: Add a panels div and move search
        result divs inside the main div.
        * page/inspector/inspector.js: Tweak the resize code to acount for
        the search results divs moving inside the main div.


        Reviewed by Adam Roben.

        Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title

        Create the Web Inspector window with the textured style. Set the content border
        thickness for the top of the window or the height of the toolbar. Also make the
        window's bottom corners square, since a normal textured window normally has
        rounded bottom corners.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController window]):


        Reviewed by Adam Roben.

        Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title

        Add a new function to make bottom window corners square for textured windows.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceTiger.a:
        * libWebKitSystemInterfaceLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix a leak pointed out by Alexey
aroben@apple.com [Mon, 26 Nov 2007 07:29:36 +0000 (07:29 +0000)]
    Fix a leak pointed out by Alexey

        * WebView.cpp:
        (getUpdateRects): Use a Vector<unsigned char>, since OwnPtr doesn't
        know to call delete[].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Bug 16052: prepare-ChangeLog doesn't report deleted files
ddkilzer@apple.com [Mon, 26 Nov 2007 07:06:30 +0000 (07:06 +0000)]
    Bug 16052: prepare-ChangeLog doesn't report deleted files

        Reviewed by Sam.

        * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix Bug 16138: Reduce code duplication in WebView.cpp
aroben@apple.com [Mon, 26 Nov 2007 07:02:46 +0000 (07:02 +0000)]
    Fix Bug 16138: Reduce code duplication in WebView.cpp


        Reviewed by Sam.

        * WebView.cpp:
        (getUpdateRects): Factored code out of updateBackingStore and paint
        into this new helper function.
        (WebView::updateBackingStore): Use getUpdateRects.
        (WebView::paint): Ditto.
        (WebView::paintIntoBackingStore): Changed to take a const IntRect&.
        (WebView::paintIntoWindow): Ditto.
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Bug 15864: Replace merge-changelog with resolve-ChangeLogs
ddkilzer@apple.com [Mon, 26 Nov 2007 06:00:00 +0000 (06:00 +0000)]
    Bug 15864: Replace merge-changelog with resolve-ChangeLogs

        Reviewed by Adam.

        Roll functionality of merge-changelog into resolve-ChangeLogs
        script.  The script now checks for ChangeLog.rej and
        ChangeLog.orig files first.  If it finds them, it uses the
        ChangeLog.rej file as a patch (in old contextual diff format) to
        apply with --fuzz=3.

        * Scripts/merge-changelog: Removed.
        * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * platform/win/Skipped: Add a known failure.
aroben@apple.com [Mon, 26 Nov 2007 05:26:47 +0000 (05:26 +0000)]
    * platform/win/Skipped: Add a known failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * platform/win/Skipped: Remove an unnecessary entry.
aroben@apple.com [Mon, 26 Nov 2007 05:25:31 +0000 (05:25 +0000)]
    * platform/win/Skipped: Remove an unnecessary entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the...
weinig@apple.com [Mon, 26 Nov 2007 04:16:20 +0000 (04:16 +0000)]
    Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.

        Reviewed by Mark Rowe.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/mac/Configurations/Base.xcconfig:
        * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
        * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
        * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Convert DumpRenderTree to ues .xcconfig files.
weinig@apple.com [Mon, 26 Nov 2007 03:52:12 +0000 (03:52 +0000)]
    Convert DumpRenderTree to ues .xcconfig files.

        Reviewed by Mark Rowe.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/mac/Configurations: Added.
        * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
        * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
        * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add ForwardingHeaders to wtf for DumpRenderTree.
weinig@apple.com [Mon, 26 Nov 2007 02:54:45 +0000 (02:54 +0000)]
    Add ForwardingHeaders to wtf for DumpRenderTree.

        Reviewed by Mark Rowe.

        * DumpRenderTree/DumpRenderTree.h:
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/ForwardingHeaders: Added.
        * DumpRenderTree/ForwardingHeaders/wtf: Added.
        * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
        * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
        * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
        * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
        * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
        * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
        * DumpRenderTree/LayoutTestController.cpp:
        * DumpRenderTree/WorkQueue.cpp:
        * DumpRenderTree/mac/DumpRenderTree.mm:
        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        * DumpRenderTree/mac/JavaScriptThreading.cpp:
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        * DumpRenderTree/mac/ObjCController.m:
        * DumpRenderTree/mac/UIDelegate.mm:
        * DumpRenderTree/mac/WorkQueueItemMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-25 Rodney Dawes <dobey@wayofthemonkey.com>
mrowe@apple.com [Mon, 26 Nov 2007 02:37:31 +0000 (02:37 +0000)]
2007-11-25  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Maciej Stachowiak.

        Remove the unneeded CFNETWORK #ifdefs.

        * loader/NetscapePlugInStreamLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-24 Laszlo Gombos <laszlo.gombos@gmail.com>
mrowe@apple.com [Mon, 26 Nov 2007 02:12:37 +0000 (02:12 +0000)]
2007-11-24  Laszlo Gombos  <laszlo.gombos@gmail.com>

        Reviewed by Sam Weinig.

        Add printf format attribute to several functions. Use the the new WTF_ATTRIBUTE_PRINTF define.

        * dom/XMLTokenizer.cpp:
        * dom/XMLTokenizer.h:
        * platform/DeprecatedString.h:
        * platform/PlatformString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-24 Laszlo Gombos <laszlo.gombos@gmail.com>
mrowe@apple.com [Mon, 26 Nov 2007 02:12:04 +0000 (02:12 +0000)]
2007-11-24  Laszlo Gombos  <laszlo.gombos@gmail.com>

        Reviewed by Maciej Stachowiak.

        Fix minor compiler warning (GCC 4.1.3)

        * pcre/pcre_internal.h:
        * pcre/pcre_ucp_searchfuncs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix some test failures caused by r28019
aroben@apple.com [Mon, 26 Nov 2007 01:53:33 +0000 (01:53 +0000)]
     Fix some test failures caused by r28019

         Now that stdout is in binary mode, we need to always use printf
         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
         the output.

         Reviewed by Sam.

         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
mitz@apple.com [Mon, 26 Nov 2007 01:06:27 +0000 (01:06 +0000)]
    Reviewed by Adam Roben.

        - fix off-center error images

        Covered by many pixel tests with missing images

        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paint): Account for the 1 pixel outline when
        positioning the error image.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Set the font smoothing preference in DRT
aroben@apple.com [Mon, 26 Nov 2007 00:13:40 +0000 (00:13 +0000)]
     Set the font smoothing preference in DRT

         This makes the pixel results on Windows closer to the Mac results.

         Reviewed by Mitz.

         * DumpRenderTree/win/DumpRenderTree.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix Bug 16133: Implement pixel test support on Windows
aroben@apple.com [Mon, 26 Nov 2007 00:03:42 +0000 (00:03 +0000)]
 Fix Bug 16133: Implement pixel test support on Windows


         Add ImageDiff.vcproj to WebKit.sln

         Reviewed by Sam.

         * WebKit.vcproj/WebKit.sln:


         Port ImageDiff to CG and C++

         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133

         Reviewed by Sam.

         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
         * DumpRenderTree/win/ImageDiff.vcproj: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix image diff link generation on Windows
aroben@apple.com [Mon, 26 Nov 2007 00:03:18 +0000 (00:03 +0000)]
     Fix image diff link generation on Windows

         Reviewed by Sam.

         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
         to toURL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Implement pixel dumping in Windows DRT
aroben@apple.com [Mon, 26 Nov 2007 00:02:55 +0000 (00:02 +0000)]
    Implement pixel dumping in Windows DRT

        Part of http://bugs.webkit.org/show_bug.cgi?id=16133

        Reviewed by Sam.

        * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
        (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
        Content-Length header.
        * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (dump): Do a pixel dump if requested.
        (main): Parse pixel test options.
        * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
        the cg/ subdirectory to the include path.
        * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
        available in a header or import library, so we have to go through this
        LoadLibrary/GetProcAddress dance to use them.
        * DumpRenderTree/win/MD5.h: Added.
        * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
        moved up to the top level to share it with Mac eventually.
        * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
        (getBitmapContextFromWebView): Forces the WebView to paint using a
        WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Clean up Windows DRT's option parsing a little bit
aroben@apple.com [Mon, 26 Nov 2007 00:02:29 +0000 (00:02 +0000)]
     Clean up Windows DRT's option parsing a little bit

         Reviewed by Sam.

         * DumpRenderTree/win/DumpRenderTree.cpp:
         (main): Put non-option arguments into a Vector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Make Windows DRT stop changing LF into CRLF
aroben@apple.com [Mon, 26 Nov 2007 00:01:44 +0000 (00:01 +0000)]
     Make Windows DRT stop changing LF into CRLF

         Reviewed by Sam.

         * DumpRenderTree/win/DumpRenderTree.cpp:
         (main): Put stdout in binary mode.
         * Scripts/run-webkit-tests: Remove the CRLF hack.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28019 268f45cc-cd09-0410-ab3c-d52691b4dbfc