18 years agoTests:
sullivan [Wed, 28 Jan 2004 02:25:17 +0000 (02:25 +0000)]

        * Blot/Blot.xcode/project.pbxproj:
        added blot-api.txt


        WebKit part of fixes for:
        <rdar://problem/3123975>: ER: please list the source URL in the header
        or footer when printing the contents of a page
        <rdar://problem/3184091>: Safari - Configurable printing header/footer
        <rdar://problem/3306826>: Please allow printing the date (as well as URL)
        in the header or footer

        Reviewed by Dave.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView _headerHeight]):
        new method, gets result from WebView's UI delegate or returns 0
        (-[WebHTMLView _footerHeight]):
        new method, gets result from WebView's UI delegate or returns 0
        (-[WebHTMLView _drawHeaderInRect:]):
        new method, gives WebView's UI delegate a chance to draw header
        (-[WebHTMLView _drawFooterInRect:]):
        new method, gives WebView's UI delegate a chance to draw footer
        (-[WebHTMLView _adjustPrintingMarginsForHeaderAndFooter]):
        new method, adds header and footer heights into page margins so
        AppKit printing code will compute and use the right area
        (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
        now calls _adjustPrintingMarginsForHeaderAndFooter if starting to print
        (-[WebHTMLView drawPageBorderWithSize:]):
        new method, computes rects for header and footer and calls new drawing methods

        * WebView.subproj/WebUIDelegatePrivate.h:
        add header and footer-related delegate methods


        WebBrowser part of fixes for:
        <rdar://problem/3123975>: ER: please list the source URL in the header
        or footer when printing the contents of a page
        <rdar://problem/3184091>: Safari - Configurable printing header/footer
        <rdar://problem/3306826>: Please allow printing the date (as well as URL)
        in the header or footer

        Reviewed by Dave.

        * BrowserWebController.m:
        moved webViewPrint: from here to new file

        * BrowserWebViewPrinting.m: Added.
        (-[BrowserWebView webViewPrint:]):
        moved this here from BrowserWebController.m
        new function, returns the font used in header and footer
        new function, returns the preference value
        (-[BrowserWebView webViewHeaderHeight:]):
        new method, bases the header height on the font height, with some pleasant whitespace
        (-[BrowserWebView webViewFooterHeight:]):
        new method, bases the footer's height on the font height, with some pleasant whitespace
        (-[BrowserWebView drawLeftString:rightString:inRect:atBaseline:withFont:]):
        new method, used to draw a long truncated string on the left and short
        nontruncated string on the right
        (-[BrowserWebView webView:drawHeaderInRect:forPage:of:]):
        new method, draws title on left and date/time on right
        (-[BrowserWebView webView:drawFooterInRect:forPage:of:]):
        new method, draws URL on left and page x of n on right

        * PreferenceKeys.h:
        new preference key PrintHeaderAndFooterPreferenceKey

        * Defaults.plist:
        default value of PrintHeaderAndFooterPreferenceKey is true

        * English.lproj/PrintingAccessoryView.nib:
        added checkbox for "Print Headers and Footers"

        * PrintingAccessoryViewController.h:
        * PrintingAccessoryViewController.m:
        (-[PrintingAccessoryViewController togglePrintHeadersAndFooters:]):
        new method, toggles the preference
        (-[PrintingAccessoryViewController accessoryView]):
        now updates the setting of the Print Headers and Footers checkbox

        * English.lproj/Localizable.strings:
        updated for these changes

        * WebBrowser.pbproj/project.pbxproj:
        updated to add new file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebCore:
cblu [Wed, 28 Jan 2004 01:50:35 +0000 (01:50 +0000)]

<rdar://problem/3541812>: Implement Paste menu item
<rdar://problem/3541814>: Implement Delete menu item
<rdar://problem/3541811>: Implement Cut menu item

        Reviewed by dave.

        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::deleteSelection): new
        (DocumentImpl::pasteHTMLString): new
        * khtml/xml/dom_docimpl.h:
        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge isEditable]): new
        (-[WebCoreBridge pasteHTMLString:]): new
        (-[WebCoreBridge deleteSelection]): new
        (-[WebCoreBridge haveSelection]): new


<rdar://problem/3541812>: Implement Paste menu item
<rdar://problem/3541814>: Implement Delete menu item
<rdar://problem/3541811>: Implement Cut menu item

        Reviewed by dave.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView _haveSelection]): new, renamed from hasSelection, calls haveSelection on the bridge, quicker than generating string rep of selection
        (-[WebHTMLView _canDelete]): new
        (-[WebHTMLView _canPaste]): new
        (-[WebHTMLView takeFindStringFromSelection:]): call renamed _haveSelection
        (-[WebHTMLView cut:]): new
        (-[WebHTMLView delete:]): new
        (-[WebHTMLView paste:]): new
        (-[WebHTMLView validateUserInterfaceItem:]): updated for new methods
        (-[WebHTMLView validRequestorForSendType:returnType:]): call renamed _haveSelection
        * WebView.subproj/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoFixed typo in previous ChangeLog.
cblu [Tue, 27 Jan 2004 23:45:10 +0000 (23:45 +0000)]
Fixed typo in previous ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed build breakage.
cblu [Tue, 27 Jan 2004 23:44:32 +0000 (23:44 +0000)]
    Fixed build breakage.

        Reviewed by darin.

        * WebKit.pbproj/project.pbxproj: Use full patch instead of -L to get at WebKitSecurity.a

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoFix some tabs (Darin made me do it).
cblu [Tue, 27 Jan 2004 23:39:25 +0000 (23:39 +0000)]
Fix some tabs (Darin made me do it).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed: <rdar://problem/3536624>: Webkit 1.2 links against SecurityNssAsn1.framework
cblu [Tue, 27 Jan 2004 23:38:03 +0000 (23:38 +0000)]
Fixed: <rdar://problem/3536624>: Webkit 1.2 links against SecurityNssAsn1.framework

        Reviewed by Darin.

        * WebCoreSupport.subproj/WebKeyGeneration.h: Set DISABLE_WEB_KEY_GENERATION on Merlot for now.
Then don't include anything if that's set.
        * WebCoreSupport.subproj/WebKeyGeneration.cpp: Don't compile anything if DISABLE_WEB_KEY_GENERATION
is set.
        * WebCoreSupport.subproj/WebKeyGenerator.m:
        (-[WebKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]):
Always return nil if DISABLE_WEB_KEY_GENERATION is set.
        (-[WebKeyGenerator addCertificatesToKeychainFromData:]): Always return failure if

        * WebKit.pbproj/project.pbxproj: Added shell build step to make library with security
libraries in it. On Merlot, makes empty library. Also added library to link options.
        * WebKitSecurityDummy.c: Added. Used to make empty version of library for build on Merlot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Add a new AtomicString type (that is really just a KJS::Identifier). Define a Name...
hyatt [Tue, 27 Jan 2004 19:08:34 +0000 (19:08 +0000)]
Add a new AtomicString type (that is really just a KJS::Identifier).  Define a Name class that will eventually
be used for element and attribute names.

Atomize the CSS selector's "value" field, used to hold class names, identifier names, attribute values, and
pseudo-element names.

        Reviewed by rjw

        * ForwardingHeaders/kjs/identifier.h: Added.
        * WebCore.pbproj/project.pbxproj:
        * khtml/css/css_base.cpp:
        * khtml/css/css_base.h:
        * khtml/css/cssparser.cpp:
        * khtml/css/cssparser.h:
        * khtml/css/cssstyleselector.cpp:
        * khtml/css/parser.cpp:
        * khtml/css/parser.y:
        * khtml/html/html_elementimpl.cpp:
        * khtml/html/html_elementimpl.h:
        * khtml/html/html_objectimpl.cpp:
        * khtml/html/htmltokenizer.h:
        * khtml/xml/dom_elementimpl.cpp:
        * khtml/xml/dom_elementimpl.h:
        * khtml/xml/dom_nameimpl.cpp: Added.
        * khtml/xml/dom_nameimpl.h: Added.
        * khtml/xml/dom_nodeimpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Ken.
darin [Tue, 27 Jan 2004 16:33:19 +0000 (16:33 +0000)]
    Reviewed by Ken.

        - fixed <rdar://problem/3526056>: W3C says that DEL key identifier should be U+00007F, we give ForwardDelete instead

        * kwq/KWQEvent.mm: (keyIdentifierForKeyEvent): Correct the key identifiers for the Delete, Insert,
        Menu, Scroll Lock, and Select keys, as well as some obscure F25 and higher keys. Also add some
        explicit constants for the keys defined in NSEvent.h that we map to a key identifier using the
        vendor-area Unicode values (which are probably not appropriate).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Make a change suggested by kocienda to add a remove() method to InlineBoxes.
hyatt [Tue, 27 Jan 2004 10:01:55 +0000 (10:01 +0000)]
Make a change suggested by kocienda to add a remove() method to InlineBoxes.

        Reviewed by kocienda

        * khtml/rendering/render_box.cpp:
        * khtml/rendering/render_line.cpp:
        * khtml/rendering/render_line.h:
        * khtml/rendering/render_text.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Maciej.
darin [Tue, 27 Jan 2004 06:27:36 +0000 (06:27 +0000)]
    Reviewed by Maciej.

        - follow-on to the text-align change I did earlier today

        * khtml/css/html4.css: Set input and textarea so they do not inherit text-align
        from their parent by doing "text-align: -khtml-auto". This fixes google.com among others.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Maciej.
darin [Tue, 27 Jan 2004 05:55:58 +0000 (05:55 +0000)]
    Reviewed by Maciej.

        - fixed <rdar://problem/3539414>: pop-up windows appear very narrow because of bogus width (carad.com/ebaymotors)

        * khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Check the "OK" result from toFloat in
        window.open, and omit any parameters that can't be parsed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Maciej.
darin [Tue, 27 Jan 2004 05:35:36 +0000 (05:35 +0000)]
    Reviewed by Maciej.

        - fixed <rdar://problem/3537371>: REGRESSION (100-125): optgroup labels are no longer indented as they were before

        * khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement):
        Move code that adds spaces after code that strips whitespace. Also simplify
        the code a bit by using DOMString::string().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Dave.
darin [Tue, 27 Jan 2004 01:47:26 +0000 (01:47 +0000)]
    Reviewed by Dave.

        - fixed <rdar://problem/3539286>: text with a transparent background color pastes as black on black

        * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Don't put color in the mutable
        string if it's entirely transparent.
        * kwq/KWQColor.mm: (QColor::getNSColor): Fix bug where we would return nil for RGBA of 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Maciej.
darin [Tue, 27 Jan 2004 01:37:56 +0000 (01:37 +0000)]
    Reviewed by Maciej.

        - fixed <rdar://problem/3529120>: text-align style property not respected on input fields

        * khtml/rendering/render_form.h: Added textAlignment function.
        * khtml/rendering/render_form.cpp:
        (RenderFormElement::textAlignment): Added. Converts style alignment to Qt alignment.
        (RenderLineEdit::setStyle): Call textAlignment intead of using direction from style.
        (RenderTextArea::setStyle): Call textAlignment intead of using direction from style.

        * kwq/KWQLineEdit.h: Added KWQNSTextAlignmentForAlignmentFlags function.
        * kwq/KWQLineEdit.mm:
        (QLineEdit::setAlignment): Use KWQNSTextAlignmentForAlignmentFlags instead of code
        that handles only left and right alignment.
        (KWQNSTextAlignmentForAlignmentFlags): Added. Converts Qt alignment to NS alignment.
        * kwq/KWQTextEdit.mm: (QTextEdit::setAlignment): Use KWQNSTextAlignmentForAlignmentFlags
        instead of code that handles only left and right alignment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Dave.
darin [Tue, 27 Jan 2004 01:29:46 +0000 (01:29 +0000)]
    Reviewed by Dave.

        - fixed <rdar://problem/3477707>: background image with apostrophe in name missing at http://www.nbc.com

        * khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute): Use addCSSImageProperty
        instead of addCSSProperty, obviating the need for the "url()" syntax (and fixing quoting issues).

        * khtml/html/html_tableimpl.cpp:
        (HTMLTableElementImpl::parseAttribute): Ditto.
        (HTMLTablePartElementImpl::parseAttribute): Ditto.

        * khtml/html/html_elementimpl.h: Added addCSSStringProperty and addCSSImageProperty.
        * khtml/html/html_elementimpl.cpp:
        (HTMLElementImpl::addCSSStringProperty): Added. Calls setStringProperty. Not used yet.
        (HTMLElementImpl::addCSSImageProperty): Added. Calls setImageProperty.

        * khtml/css/css_valueimpl.h: Added setStringProperty and setImageProperty.
        * khtml/css/css_valueimpl.cpp:
        (CSSStyleDeclarationImpl::setStringProperty): Added. Sets a property without parsing.
        (CSSStyleDeclarationImpl::setImageProperty): Added. Sets a property without parsing.
        You'd think we'd be able to just use setStringProperty, but that's not how the image
        properties work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Dave.
darin [Tue, 27 Jan 2004 01:29:19 +0000 (01:29 +0000)]
    Reviewed by Dave.

        - fixed <rdar://problem/3538433>: HomePage: table background URL with a single quote in it does not work

        * khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute): Use addCSSImageProperty
        instead of addCSSProperty, obviating the need for the "url()" syntax (and fixing quoting issues).

        * khtml/html/html_tableimpl.cpp:
        (HTMLTableElementImpl::parseAttribute): Ditto.
        (HTMLTablePartElementImpl::parseAttribute): Ditto.

        * khtml/html/html_elementimpl.h: Added addCSSStringProperty and addCSSImageProperty.
        * khtml/html/html_elementimpl.cpp:
        (HTMLElementImpl::addCSSStringProperty): Added. Calls setStringProperty. Not used yet.
        (HTMLElementImpl::addCSSImageProperty): Added. Calls setImageProperty.

        * khtml/css/css_valueimpl.h: Added setStringProperty and setImageProperty.
        * khtml/css/css_valueimpl.cpp:
        (CSSStyleDeclarationImpl::setStringProperty): Added. Sets a property without parsing.
        (CSSStyleDeclarationImpl::setImageProperty): Added. Sets a property without parsing.
        You'd think we'd be able to just use setStringProperty, but that's not how the image
        properties work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoTools:
darin [Tue, 27 Jan 2004 00:11:41 +0000 (00:11 +0000)]

        * CommitLogEditor/Makefile.am: Switch from pbxbuild to xcodebuild.
        * HotSpotFinder/Makefile.am: Switch from pbxbuild to xcodebuild.


        * Makefile.am: Switch from pbxbuild to xcodebuild.


        * Makefile.am: Switch from pbxbuild to xcodebuild.
        * ObjcUnit/Makefile.am: Switch from pbxbuild to xcodebuild.
        * TestPlugin/Makefile.am: Switch from pbxbuild to xcodebuild.
        * WebFoundation-CacheLoader/Makefile.am: Switch from pbxbuild to xcodebuild.


        * Makefile.am: Switch from pbxbuild to xcodebuild.


        * Makefile.am: Switch from pbxbuild to xcodebuild.


        * Makefile.am: Switch from pbxbuild to xcodebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoNamespace tests.
hyatt [Mon, 26 Jan 2004 22:42:01 +0000 (22:42 +0000)]
Namespace tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
darin [Mon, 26 Jan 2004 22:35:54 +0000 (22:35 +0000)]
    Reviewed by John.

        - fixed <rdar://problem/3521379>: image dimensions uses lowercase x instead of multiplication sign

        * WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation title]):
        Change string to use multiplication sign instead of x.
        * English.lproj/Localizable.strings: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Add CSS3 @namespace support. The whole way namespaces, element, and attribute names...
hyatt [Mon, 26 Jan 2004 22:33:19 +0000 (22:33 +0000)]
Add CSS3 @namespace support.  The whole way namespaces, element, and attribute names are being handled
right now is temporary.  This code gives us a baseline of functionality (for regression testing) that we
can use when we implement namespaces "the right way."

        Reviewed by darin

        * WebCore.pbproj/project.pbxproj:
        * khtml/css/css_base.cpp:
        * khtml/css/css_base.h:
        * khtml/css/css_stylesheetimpl.cpp:
        * khtml/css/css_stylesheetimpl.h:
        * khtml/css/cssparser.cpp:
        * khtml/css/cssparser.h:
        * khtml/css/cssstyleselector.cpp:
        * khtml/css/html4.css:
        * khtml/css/parser.cpp:
        * khtml/css/parser.y:
        * khtml/xml/dom_docimpl.cpp:
        * khtml/xml/dom_elementimpl.cpp:
        * khtml/xml/dom_nodeimpl.cpp:
        * khtml/xml/dom_nodeimpl.h:
        * khtml/xml/dom_xmlimpl.cpp:
        * khtml/xml/xml_namespace_table.cpp: Added.
        * khtml/xml/xml_namespace_table.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Dave.
darin [Mon, 26 Jan 2004 22:31:12 +0000 (22:31 +0000)]
    Reviewed by Dave.

        - fixed <rdar://problem/3532519>: <select> menus show label property instead of tag contents (ups.com time and cost site)

        * khtml/html/html_formimpl.cpp: (HTMLOptionElementImpl::text): Ignore the label property as
        a quirk. Neither WinIE nor Mozilla implement the label property, so neither shall we (except
        on strict pages, where we just go crazy and do everything "right").

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Hyatt
kocienda [Mon, 26 Jan 2004 22:20:58 +0000 (22:20 +0000)]
    Reviewed by Hyatt

        * khtml/rendering/render_line.h:
        (khtml::InlineBox::isFirstLineStyle): Helper to return whether
the line box has the first line style bit set.
        * khtml/rendering/render_text.cpp:
        (RenderText::caretPos): Noe correctly accounts for white space
which can precede an inline text box.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Remove incremental repainting ifdef.
hyatt [Mon, 26 Jan 2004 21:56:41 +0000 (21:56 +0000)]
Remove incremental repainting ifdef.

        * khtml/khtmlview.h:
        * khtml/rendering/bidi.cpp:
        * khtml/rendering/render_block.cpp:
        * khtml/rendering/render_block.h:
        * khtml/rendering/render_box.cpp:
        * khtml/rendering/render_box.h:
        * khtml/rendering/render_container.cpp:
        * khtml/rendering/render_flexbox.cpp:
        * khtml/rendering/render_flow.cpp:
        * khtml/rendering/render_image.cpp:
        * khtml/rendering/render_layer.cpp:
        * khtml/rendering/render_layer.h:
        * khtml/rendering/render_object.cpp:
        * khtml/rendering/render_object.h:
        * khtml/rendering/render_table.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Preserve the integrity of the line box tree when elements get removed. Change Rende...
hyatt [Mon, 26 Jan 2004 19:24:20 +0000 (19:24 +0000)]
Preserve the integrity of the line box tree when elements get removed.  Change RenderText over to using
the same data structures as inlines and blocks for maintaining its list of line boxes.

        Reviewed by kocienda

        * khtml/khtml_part.cpp:
        * khtml/khtml_selection.cpp:
        * khtml/rendering/bidi.cpp:
        * khtml/rendering/render_block.cpp:
        * khtml/rendering/render_box.cpp:
        * khtml/rendering/render_box.h:
        * khtml/rendering/render_container.cpp:
        * khtml/rendering/render_flow.cpp:
        * khtml/rendering/render_line.cpp:
        * khtml/rendering/render_line.h:
        * khtml/rendering/render_object.cpp:
        * khtml/rendering/render_object.h:
        * khtml/rendering/render_text.cpp:
        * khtml/rendering/render_text.h:
        * kwq/KWQAccObject.mm:
        (-[KWQAccObject accessibilityIsIgnored]):
        * kwq/KWQDef.h:
        * kwq/KWQKHTMLPart.mm:
        * kwq/KWQRenderTreeDebug.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Polish the error message from the xml tokenizer.
hyatt [Sat, 24 Jan 2004 19:13:58 +0000 (19:13 +0000)]
Polish the error message from the xml tokenizer.

        * khtml/xml/xml_tokenizer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebCore:
kocienda [Sat, 24 Jan 2004 00:59:23 +0000 (00:59 +0000)]

        Reviewed by Richard

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::setShowsFirstResponder): Now adjusts caret visibility


        Reviewed by Richard

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView updateShowsFirstResponder]): Renamed from updateFocusRing:
        since it is now used to kill caret blink timer.
        (-[WebHTMLView windowDidBecomeKey:]): Now calls new updateShowsFirstResponder
        (-[WebHTMLView windowDidResignKey:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Stub out @namespace support. Implement the callbacks into the stylesheet that will...
hyatt [Fri, 23 Jan 2004 19:34:47 +0000 (19:34 +0000)]
Stub out @namespace support.  Implement the callbacks into the stylesheet that will enable us to
store namespace information for simple selectors.

Basically with this patch we no longer bomb when we encounter namespaced stylesheets, but we don't handle
them properly yet either.

        Reviewed by kocienda

        * khtml/css/css_stylesheetimpl.cpp:
        * khtml/css/css_stylesheetimpl.h:
        * khtml/css/cssparser.cpp:
        * khtml/css/cssparser.h:
        * khtml/css/parser.cpp:
        * khtml/css/parser.h:
        * khtml/css/parser.y:
        * khtml/css/tokenizer.cpp:
        * khtml/css/tokenizer.flex:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Hyatt
kocienda [Fri, 23 Jan 2004 18:55:46 +0000 (18:55 +0000)]
    Reviewed by Hyatt

Merged HTML editing progress to TOT from the branch
I have been maintaining.

        * khtml/dom/dom_position.cpp: Added.
        * khtml/dom/dom_position.h: Added.
        * khtml/editing/htmlediting.cpp: Added.
        * khtml/editing/htmlediting.h: Added.
        * khtml/khtml_selection.cpp: Added.
        * khtml/khtml_selection.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix a bug I accidentally introduced in static positioned elements. Add more margin...
hyatt [Fri, 23 Jan 2004 02:34:56 +0000 (02:34 +0000)]
Fix a bug I accidentally introduced in static positioned elements.  Add more margin collapsing tests.

        * ChangeLog:
        * khtml/rendering/render_block.cpp:
        * layout-tests/fast/block/margin-collapse/044-expected.txt: Added.
        * layout-tests/fast/block/margin-collapse/044.html: Added.
        * layout-tests/fast/block/margin-collapse/045-expected.txt: Added.
        * layout-tests/fast/block/margin-collapse/045.html: Added.
        * layout-tests/fast/block/margin-collapse/062-expected.txt: Added.
        * layout-tests/fast/block/margin-collapse/062.html: Added.
        * layout-tests/fast/block/margin-collapse/063-expected.txt: Added.
        * layout-tests/fast/block/margin-collapse/063.html: Added.
        * layout-tests/fast/block/positioning/007-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago (1) Implement better XML error handling.
hyatt [Fri, 23 Jan 2004 01:53:13 +0000 (01:53 +0000)]
(1) Implement better XML error handling.
(2) Fix a minor z-index bug with the 'initial' value.
(3) Initial landing of XBL support.  Code is all ifnef KHTML_NO_XBL so that it can be turned off easily if
XBL never comes to fruition.

        Reviewed by darin

        * ForwardingHeaders/xbl/xbl_binding_manager.h: Added.
        * ForwardingHeaders/xbl/xbl_docimpl.h: Added.
        * WebCore.pbproj/project.pbxproj:
        * khtml/css/cssparser.cpp:
        * khtml/css/cssproperties.c:
        * khtml/css/cssproperties.h:
        * khtml/css/cssproperties.in:
        * khtml/css/cssstyleselector.cpp:
        * khtml/dom/dom_element.cpp:
        * khtml/misc/loader.cpp:
        * khtml/misc/loader.h:
        * khtml/misc/loader_client.h:
        * khtml/rendering/render_style.cpp:
        * khtml/rendering/render_style.h:
        * khtml/xbl/xbl_binding.cpp: Added.
        * khtml/xbl/xbl_binding.h: Added.
        * khtml/xbl/xbl_binding_manager.cpp: Added.
        * khtml/xbl/xbl_binding_manager.h: Added.
        * khtml/xbl/xbl_docimpl.cpp: Added.
        * khtml/xbl/xbl_docimpl.h: Added.
        * khtml/xbl/xbl_protobinding.cpp: Added.
        * khtml/xbl/xbl_protobinding.h: Added.
        * khtml/xbl/xbl_protohandler.cpp: Added.
        * khtml/xbl/xbl_protohandler.h: Added.
        * khtml/xbl/xbl_protoimplementation.cpp: Added.
        * khtml/xbl/xbl_protoimplementation.h: Added.
        * khtml/xbl/xbl_tokenizer.cpp: Added.
        * khtml/xbl/xbl_tokenizer.h: Added.
        * khtml/xml/dom_docimpl.cpp:
        * khtml/xml/dom_docimpl.h:
        * khtml/xml/dom_elementimpl.cpp:
        * khtml/xml/dom_elementimpl.h:
        * khtml/xml/dom_nodeimpl.cpp:
        * khtml/xml/xml_tokenizer.cpp:
        * khtml/xml/xml_tokenizer.h:
        * kwq/KWQXmlSimpleReader.h:
        * kwq/KWQXmlSimpleReader.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Added stubs for ObjC language binding to JavaScript.
rjw [Fri, 23 Jan 2004 01:14:23 +0000 (01:14 +0000)]
Added stubs for ObjC language binding to JavaScript.

        * JavaScriptCore.pbproj/project.pbxproj:
        * bindings/jni/jni_runtime.h:
        * bindings/objc/objc_runtime.h: Added.
        * bindings/runtime.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebCore:
cblu [Fri, 23 Jan 2004 01:10:02 +0000 (01:10 +0000)]

Fixed: <rdar://problem/3537542>: support for copying HTML

        Reviewed by dave.

        * khtml/xml/dom2_rangeimpl.cpp:
        (RangeImpl::toHTML): implemented
        * khtml/xml/dom_nodeimpl.cpp:
        (NodeImpl::recursive_toHTMLWithRange): new
        * khtml/xml/dom_nodeimpl.h:
        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge selectedHTML]): new
        (-[WebCoreBridge reconstructedSource]): new


Fixed: <rdar://problem/3537542>: support for copying HTML

        Reviewed by dave.

        * WebView.subproj/WebHTMLRepresentation.h:
        * WebView.subproj/WebHTMLRepresentation.m:
        (-[WebHTMLRepresentation reconstructedSource]): for BLOT's eventual use
        * WebView.subproj/WebHTMLView.m:
        (+[WebHTMLView _pasteboardTypes]): provide NSHTMLPboardType
        (-[WebHTMLView _writeSelectionToPasteboard:]): add HTML to the pasteboard

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Simplified JavaString by using UString as backing store. This
rjw [Fri, 23 Jan 2004 00:42:34 +0000 (00:42 +0000)]
Simplified JavaString by using UString as backing store.  This
revealed a bug in CString's assignment operator which I fixed.

Removed some dead code.

        Reviewed by John.

        * bindings/jni/jni_runtime.h:
        * bindings/runtime_object.cpp:
        * bindings/runtime_object.h:
        * kjs/ustring.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoForgot to export this as a private header.
rjw [Thu, 22 Jan 2004 22:59:00 +0000 (22:59 +0000)]
Forgot to export this as a private header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoMoved jni_jsobject.* to the jni directory.
rjw [Thu, 22 Jan 2004 22:29:46 +0000 (22:29 +0000)]
Moved jni_jsobject.* to the jni directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoTests:
sullivan [Thu, 22 Jan 2004 19:42:28 +0000 (19:42 +0000)]

        * Blot/blot-tasks.txt
        Added tasks for supporting preference panels


        Reviewed by Chris.

        * English.lproj/StringsNotToBeLocalized.txt:
        brought this file back up to date


        - fixed <rdar://problem/3522522>: Tooltip typo: "word of phrase" instead of "word or phrase"
        - removed hack that we added at the last minute to get the copyright string correct

        Reviewed by Chris.

        * BrowserApplication.m:
        (-[BrowserApplication orderFrontStandardAboutPanel:]):
        removed AppKit-string-snarfing hack; now we use a normal localizable string
        for the copyright string in the About box.

        * BrowserWindowController.m:
        (-[BrowserWindowController setUpSearchField]):
        fixed typo that was previously fixed only in the English localization

        * English.lproj/Localizable.strings:
        * English.lproj/StringsNotToBeLocalized.txt:
        brought these two files up to date

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago - fixed 3536624: Webkit 1.2 links against SecurityNssAsn1.framework
darin [Thu, 22 Jan 2004 16:45:01 +0000 (16:45 +0000)]
    - fixed 3536624: Webkit 1.2 links against SecurityNssAsn1.framework

        * WebKit.pbproj/project.pbxproj: Remove SecurityNssAsn1.framework from the list we link against.
        It's still included in the list for places to find headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoAdding even more margin collapsing tests... courtesy of Hixie.
hyatt [Thu, 22 Jan 2004 09:18:36 +0000 (09:18 +0000)]
Adding even more margin collapsing tests... courtesy of Hixie.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoFix build bustage.
hyatt [Thu, 22 Jan 2004 03:10:43 +0000 (03:10 +0000)]
Fix build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoFix build bustage with libxml include path.
hyatt [Thu, 22 Jan 2004 02:59:50 +0000 (02:59 +0000)]
Fix build bustage with libxml include path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoAdd margin collapsing tests.
hyatt [Thu, 22 Jan 2004 02:52:51 +0000 (02:52 +0000)]
Add margin collapsing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for two margin collapsing edge cases.
hyatt [Thu, 22 Jan 2004 02:49:58 +0000 (02:49 +0000)]
Fix for two margin collapsing edge cases.

        Reviewed by darin

        * khtml/rendering/render_block.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Switch from expat to libxml and implement namespace support in the simplereader.
hyatt [Thu, 22 Jan 2004 02:45:09 +0000 (02:45 +0000)]
Switch from expat to libxml and implement namespace support in the simplereader.

        Reviewed by darin

        * ChangeLog:
        * expat/Changes: Removed.
        * expat/MANIFEST: Removed.
        * expat/README: Removed.
        * expat/expat_config.h: Removed.
        * expat/lib/ascii.h: Removed.
        * expat/lib/asciitab.h: Removed.
        * expat/lib/expat.h: Removed.
        * expat/lib/iasciitab.h: Removed.
        * expat/lib/internal.h: Removed.
        * expat/lib/latin1tab.h: Removed.
        * expat/lib/nametab.h: Removed.
        * expat/lib/utf8tab.h: Removed.
        * expat/lib/xmlparse.c: Removed.
        * expat/lib/xmlrole.c: Removed.
        * expat/lib/xmlrole.h: Removed.
        * expat/lib/xmltok.c: Removed.
        * expat/lib/xmltok.h: Removed.
        * expat/lib/xmltok_impl.c: Removed.
        * expat/lib/xmltok_impl.h: Removed.
        * expat/lib/xmltok_ns.c: Removed.
        * kwq/KWQXmlAttributes.h:
        * kwq/KWQXmlAttributes.mm:
        * kwq/KWQXmlSimpleReader.h:
        * kwq/KWQXmlSimpleReader.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Add some methods to dicts and stacks that exist in Qt.
hyatt [Thu, 22 Jan 2004 02:30:52 +0000 (02:30 +0000)]
Add some methods to dicts and stacks that exist in Qt.

        Reviewed by darin

        * kwq/KWQDict.h:
        * kwq/KWQPtrDict.h:
        * kwq/KWQPtrStack.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agochange version number to from '125' to '126u'
vicki [Wed, 21 Jan 2004 22:25:34 +0000 (22:25 +0000)]
change version number to from '125' to '126u'

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoSafari-125 stamp
vicki [Wed, 21 Jan 2004 22:13:48 +0000 (22:13 +0000)]
Safari-125 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John, Ken, Dave.
mjs [Tue, 20 Jan 2004 00:58:24 +0000 (00:58 +0000)]
    Reviewed by John, Ken, Dave.

<rdar://problem/3533319>: Safari allows upload of arbitrary local files w/o user's knowledge or permission

* khtml/html/html_formimpl.cpp:
        (HTMLInputElementImpl::value): Don't fall back to the value
attribute for file inputs, since that way malicious HTML could
force the user to upload files unexpectedly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3532569, bugzilla patch viewer doesn't work. My previous fix for 3531983...
hyatt [Mon, 19 Jan 2004 02:10:15 +0000 (02:10 +0000)]
Fix for 3532569, bugzilla patch viewer doesn't work.  My previous fix for 3531983 caused moves to happen
when they should not have, due to childX and childY not being implemented at all on KWQScrollView.

        Reviewed by darin

        * kwq/KWQScrollView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoset version number to '125u'. The tree is open for Safari-125.
vicki [Sat, 17 Jan 2004 02:45:16 +0000 (02:45 +0000)]
set version number to '125u'.  The tree is open for Safari-125.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoSafari-124 stamp
vicki [Sat, 17 Jan 2004 02:26:46 +0000 (02:26 +0000)]
Safari-124 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3531983, fixed positioning not working for widgets. Make sure to move widge...
hyatt [Fri, 16 Jan 2004 23:42:06 +0000 (23:42 +0000)]
Fix for 3531983, fixed positioning not working for widgets.  Make sure to move widgets at paint time
if necessary.

        Reviewed by darin

        * khtml/rendering/render_replaced.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoJavaScriptCore:
rjw [Fri, 16 Jan 2004 23:23:04 +0000 (23:23 +0000)]
Fixed 3525853.  We weren't handling mapping to overloaded Java
methods very well.  Even though this is undefined the other
browsers support it.  Also fixed a bug with returning arrays
from Java functions.

        Reviewed by John.

        * bindings/jni/jni_class.cpp:
        * bindings/jni/jni_class.h:
        * bindings/jni/jni_instance.cpp:
        * bindings/jni/jni_instance.h:
        * bindings/jni/jni_runtime.cpp:
        * bindings/jni/jni_runtime.h:
        * bindings/jni_jsobject.cpp:
        * bindings/runtime.cpp:
        * bindings/runtime.h:
        * bindings/runtime_method.cpp:
        * bindings/runtime_method.h:
        * bindings/runtime_object.cpp:

        Extending test to cover issues in 3525853.

        Reviewed by John.

        * ChangeLog:
        * LiveConnect/Blink/Blink.java:
        * LiveConnect/Blink/Blink.pbproj/project.pbxproj:
        * LiveConnect/Blink/test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3531229. Another place that needs the Push/PopLocalFrame
rjw [Fri, 16 Jan 2004 18:59:26 +0000 (18:59 +0000)]
Fixed 3531229.  Another place that needs the  Push/PopLocalFrame
protection implemented for 3530401.

        Reviewed by John.

        * bindings/runtime_method.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3530401. JNI doesn't cleanup local refs created on the
rjw [Fri, 16 Jan 2004 01:58:05 +0000 (01:58 +0000)]
Fixed 3530401.  JNI doesn't cleanup local refs created on the
main thread.   IMO this is a bad bug in our JMI implementation.

To work-around the problem I explicitly delete all local refs.
Further, I've added Push/PopLocalFrame calls to catch any refs
that I may have missed.  This will guarantee that we don't leak
any Java references.

        Reviewed by John.

        * bindings/jni/jni_class.cpp:
        * bindings/jni/jni_instance.cpp:
        * bindings/jni/jni_instance.h:
        * bindings/jni/jni_runtime.cpp:
        * bindings/jni_jsobject.cpp:
        * bindings/runtime.h:
        * bindings/runtime_object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3530734, many java applets don't show up. Go ahead and just use the width...
hyatt [Fri, 16 Jan 2004 00:53:08 +0000 (00:53 +0000)]
Fix for 3530734, many java applets don't show up.  Go ahead and just use the width/height from the style
system as the initial size when the width/height are fixed.

        Reviewed by rjw

        * khtml/rendering/render_applet.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoI previously checked the fix for 3529426, but the fix was commented out. Oops.
rjw [Thu, 15 Jan 2004 23:44:57 +0000 (23:44 +0000)]
I previously checked the fix for 3529426, but the fix was commented out.  Oops.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3529426. Exclude pages that contain Java applets from
rjw [Thu, 15 Jan 2004 21:18:53 +0000 (21:18 +0000)]
Fixed 3529426.  Exclude pages that contain Java applets from
the page cache.  The means applets get the normal stop/destroy
messages that they expect when a user leaves a page.

        Reviewed by John.

        * kwq/KWQKHTMLPart.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoJavaScriptCore:
vicki [Thu, 15 Jan 2004 19:06:30 +0000 (19:06 +0000)]

        Reviewed by Darin.

        * JavaScriptCore.pbproj/project.pbxproj: Update copyright date to 2004.


        Reviewed by Darin.

        * WebCore.pbproj/project.pbxproj: Update copyright date to 2004.


        Reviewed by Darin.

        * WebKit.pbproj/project.pbxproj: Update copyright date to 2004.
        * English.lproj/InfoPlist.strings: Update copyright date to 2004.


        Reviewed by Darin.

        * WebBrowser.pbproj/project.pbxproj: Update copyright date to 2004.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Ken.
darin [Thu, 15 Jan 2004 16:26:23 +0000 (16:26 +0000)]
    Reviewed by Ken.

        - fixed 3529943: REGRESSION (119-120): nil-deref in KHTMLPart::javaEnabled when hitting back button

        * khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance):
        Add missing nil check that the other call to javaEnabled has.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago- change version numbers to "124u", since I spun WebBrowser-123 for the Info.plist...
vicki [Thu, 15 Jan 2004 01:41:18 +0000 (01:41 +0000)]
- change version numbers to "124u", since I spun WebBrowser-123 for the Info.plist change in rdar://problem/3529511

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3529466. With recent changes to Java plugin we must no
rjw [Thu, 15 Jan 2004 01:10:08 +0000 (01:10 +0000)]
Fixed 3529466.  With recent changes to Java plugin we must no
longer call DeleteLocalRef().  Not a problem, it was an optimization anyway.

        Reviewed by John.

        * bindings/jni/jni_instance.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago- change version number to "123u". The tree is open for Safari-123
vicki [Thu, 15 Jan 2004 01:04:20 +0000 (01:04 +0000)]
- change version number to "123u".  The tree is open for Safari-123

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoSafari-122 stamp (we'll have to change the release marker in WebBrowser after john...
vicki [Thu, 15 Jan 2004 00:47:51 +0000 (00:47 +0000)]
Safari-122 stamp (we'll have to change the release marker in WebBrowser after john's check in)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3527819, marquee makes page layout too wide. Make sure marquees have a...
hyatt [Thu, 15 Jan 2004 00:16:06 +0000 (00:16 +0000)]
Fix for 3527819, marquee makes page layout too wide.  Make sure marquees have a minimum width of 0.

        Reviewed by john

        * khtml/rendering/render_block.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3529010.
rjw [Wed, 14 Jan 2004 21:00:21 +0000 (21:00 +0000)]
Fixed 3529010.

Finalize may be called on an JSObject after we've already remove all our references.  The assert in this case is firing because we've received a finalize call from Java for an instance that we no longer know about.  The fix is to check in finalize that we're getting a call on an instance that we still care about.

        Reviewed by John.

        * bindings/jni_jsobject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3528324.
rjw [Wed, 14 Jan 2004 04:57:29 +0000 (04:57 +0000)]
Fixed 3528324.

The run loop that is used to execute JavaScript (in practice, always the main run loop) is held in a class variable.  It is set and retained once and should not be released.  Unfortunately is it being released when the 'root' object on a LiveConnect applet is released.  This has the symptom of eventually causing an deallocation of the main run loop!  Usually after about 5 instantiations/destructions of a LiveConnect applet.  The CFRelease of the run loop was removed.

        Reviewed by Hyatt.

        * bindings/jni_jsobject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3527707, crash on w3c css page. Make sure height isn't allowed to be negati...
hyatt [Wed, 14 Jan 2004 02:32:21 +0000 (02:32 +0000)]
Fix for 3527707, crash on w3c css page.  Make sure height isn't allowed to be negative when computing
positioned elements' heights.  Also bulletproof the crash in case there are other negative height code

        Reviewed by john

        * khtml/rendering/render_block.cpp:
        * khtml/rendering/render_box.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Darin.
mjs [Wed, 14 Jan 2004 01:12:45 +0000 (01:12 +0000)]
    Reviewed by Darin.

<rdar://problem/3527853>: REGRESSION (119-120): Peoplesoft menus do not work

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::scrollToAnchor): Right before calling checkCompleted(), set
m_bComplete to false, so it can get set right back to true if we're actually done
loading and fire all the right signals.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3526710, applets need to have the correct initial size after a layout has...
hyatt [Tue, 13 Jan 2004 19:36:56 +0000 (19:36 +0000)]
Fix for 3526710, applets need to have the correct initial size after a layout has been done, since our
Java applets can't yet resize.

        Reviewed by john

        * khtml/rendering/render_applet.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agochanged version number from '121' to '122u'
vicki [Mon, 12 Jan 2004 00:42:18 +0000 (00:42 +0000)]
changed version number from '121' to '122u'

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoSafari-121 stamp
vicki [Mon, 12 Jan 2004 00:27:56 +0000 (00:27 +0000)]
Safari-121 stamp

(Ordinarily this checkin would show the version number change to project.pbxproj files, but I accidentally changed the version number to '121' instead of '121u' when I opened the tree after Safari-120.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago - fixed Dave's check-in so it compiles; I assume he forgot to land one source...
darin [Sun, 11 Jan 2004 20:09:38 +0000 (20:09 +0000)]
    - fixed Dave's check-in so it compiles; I assume he forgot to land one source file

        * khtml/khtmlview.h: Add RenderPart to the friends of KHTMLView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for frame repainting bugs (3510669, 3515442). This is a narrower fix than the...
hyatt [Sun, 11 Jan 2004 19:06:35 +0000 (19:06 +0000)]
Fix for frame repainting bugs (35106693515442).  This is a narrower fix than the previous attempt.

        Reviewed by darin

        * khtml/rendering/render_frames.cpp:
        * khtml/rendering/render_frames.h:
        * khtml/rendering/render_replaced.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
darin [Sun, 11 Jan 2004 00:08:32 +0000 (00:08 +0000)]
    Reviewed by John.

        - fixed 3524906: REGRESSION (114-115): page with plug-in content never stops loading (travelking.com.tw)

        Put the plug-in streams clients into their own separate set. Now a plug-in client is not considered part
        of "loading", but it does participate in the callback deferral mechanism, which was the real goal of the
        change I made that introduced this regression. Also remove the plug-in client in one case I had missed
        before (cancel).

        * WebView.subproj/WebDataSourcePrivate.h: Added a new set of plugInStreamClients.
        * WebView.subproj/WebDataSource.m:
        (-[WebDataSourcePrivate dealloc]): Release the set.
        (-[WebDataSource _addPlugInStreamClient:]): Added. Adds to the set.
        (-[WebDataSource _removePlugInStreamClient:]): Added. Removes from the set.
        (-[WebDataSource _defersCallbacksChanged]): Added code to loop through plugInStreamClients too.

        * Plugins.subproj/WebNetscapePluginStream.m:
        (-[WebNetscapePluginStream start]): Use _add/removePlugInStreamClient instead of _add/removeSubresourceClient.
        (-[WebNetscapePluginConnectionDelegate connectionDidFinishLoading:]): Ditto.
        (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): Ditto.
        (-[WebNetscapePluginConnectionDelegate cancelWithError:]): Override to call _removePlugInStreamClient and
        then call super.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
darin [Sat, 10 Jan 2004 20:10:03 +0000 (20:10 +0000)]
    Reviewed by John.

        - fixed 3525468: REGRESSION (114-115): HOMEPAGE: after hitting textarea limit, backspace key is ignored

        * kwq/KWQEvent.mm:
        (keyIdentifierForKeyEvent): Treat 7F as 08; matches other browsers.
        (QKeyEvent::QKeyEvent): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago - rolled out most of Dave's change for 3510669 and 3515442; it is not working yet
darin [Sat, 10 Jan 2004 00:44:54 +0000 (00:44 +0000)]
    - rolled out most of Dave's change for 3510669 and 3515442; it is not working yet

        * WebView.subproj/WebHTMLViewPrivate.h:
        * WebView.subproj/WebHTMLView.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Chris.
mjs [Fri, 9 Jan 2004 23:31:02 +0000 (23:31 +0000)]
    Reviewed by Chris.

<rdar://problem/3514446>: cert downloaded from BofA or MIT is rejected (ACL issue on private key?)

* WebCoreSupport.subproj/WebKeyGeneration.cpp:
        (createPair): Cut & paste hunk of code from Security framework.
        (Safari_SecKeyCreatePair): Ditto.
        (signedPublicKeyAndChallengeString): Instead of creating a normal ACL,
use our hacked version of the SecKeyCreatePair call that doesn't put in
any kind of ACL. This works around a SecureTransport bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's use of a...
hyatt [Fri, 9 Jan 2004 22:47:11 +0000 (22:47 +0000)]
Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's use of a separate needsLayout boolean.

        Reviewed by darin

        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge setNeedsLayout]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's resizing...
hyatt [Fri, 9 Jan 2004 22:43:31 +0000 (22:43 +0000)]
Fixes for 3510669 and 3515442, blank frame problems caused by WebKit's resizing not scheduling actual
layouts via WebCore.

        Reviewed by darin

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView _web_layoutIfNeededRecursive:testDirtyRect:]):
        (-[WebHTMLView initWithFrame:]):
        (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
        (-[WebHTMLView setNeedsLayout:]):
        * WebView.subproj/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Chris.
darin [Fri, 9 Jan 2004 20:11:49 +0000 (20:11 +0000)]
    Reviewed by Chris.

        - fixed 3510805: "PoolCleaner" in Carbon WebKit leads to overrelease and crash using color picker in BBEdit

        * Carbon.subproj/CarbonUtils.m: (PoolCleaner): Only do the autorelease
        pool stuff in the default run loop mode. If we're in another run loop
        mode that means we are in some Cocoa code that sets up its own autorelease
        pool; it's important that we don't release ours in that case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3524118, floats don't repaint when moved.
hyatt [Fri, 9 Jan 2004 01:49:24 +0000 (01:49 +0000)]
Fix for 3524118, floats don't repaint when moved.

        Reviewed by darin

         * khtml/rendering/render_block.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
mjs [Thu, 8 Jan 2004 23:47:22 +0000 (23:47 +0000)]
    Reviewed by John.

<rdar://problem/3522298>: Error on MIT's x509 certificate site

        * WebCoreSupport.subproj/WebKeyGeneration.cpp:
        (addCertificatesToKeychainFromData): Sign the freshly minted public key
using RSA/MD5 instead of RSA/SHA-1, because MIT only supports MD5.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3524430. This was a regression introduced when we added '-' and '?' to the...
rjw [Thu, 8 Jan 2004 23:36:45 +0000 (23:36 +0000)]
Fixed 3524430.  This was a regression introduced when we added '-' and '?' to the word boundary detection.

Also backed out workaround for 3521759 as it's no longer needed with correct argument passing to ATSUPositionToOffset.

        Reviewed by Hyatt.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3519003, crash in mail because <dir> and <menu> don't allow the same childre...
hyatt [Thu, 8 Jan 2004 23:35:58 +0000 (23:35 +0000)]
Fix for 3519003, crash in mail because <dir> and <menu> don't allow the same children as <ul> and <ol>.

        Reviewed by darin

        * khtml/html/dtd.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed: <rdar://problem/3522900>: REGRESSION (100-117): Java plug-in description...
cblu [Thu, 8 Jan 2004 23:07:53 +0000 (23:07 +0000)]
Fixed: <rdar://problem/3522900>: REGRESSION (100-117): Java plug-in description is garbled when displaying Plug-ins.html

        Reviewed by darin.

        * Misc.subproj/WebKitNSStringExtras.h:
        * Misc.subproj/WebKitNSStringExtras.m:
        (+[NSString _web_encodingForResource:]): new method, returns the encoding for a resource handle given its file system path
        * Plugins.subproj/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage stringForStringListID:andIndex:]): call _web_encodingForResource when creating the NSString

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago - fixed <rdar://problem/3524359>: REGRESSSION (119-120):
sullivan [Thu, 8 Jan 2004 22:23:27 +0000 (22:23 +0000)]
    - fixed <rdar://problem/3524359>: REGRESSSION (119-120):
        Double click to select text in form broken

        Reviewed by Dave and Darin.

        * khtml/khtmlview.cpp:
        Don't blur the focused node if that's the one you clicked on.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebCore:
rjw [Thu, 8 Jan 2004 00:45:31 +0000 (00:45 +0000)]
Fixed 3517550.  Named array lookup of applet failed, i.e.:
var appletobj = document.applets['myapplet']

        Reviewed by Chris.

        * khtml/ecma/kjs_html.cpp:

        Added lookup test for all three variants of applet access:
        named, indexed array, and named array.

        * LiveConnect/Blink/Blink.java:
        * LiveConnect/Blink/Blink.pbproj/project.pbxproj:
        * LiveConnect/Blink/test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agook, back to 121u now. tree is still closed.
vicki [Wed, 7 Jan 2004 18:58:19 +0000 (18:58 +0000)]
ok, back to 121u now.  tree is still closed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agosilly me. i forgot to actually tag before updating the version number to 121u.
vicki [Wed, 7 Jan 2004 18:51:28 +0000 (18:51 +0000)]
silly me.  i forgot to actually tag before updating the version number to 121u.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoset version number to 121u -- the tree is still closed
vicki [Wed, 7 Jan 2004 18:35:37 +0000 (18:35 +0000)]
set version number to 121u -- the tree is still closed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoSafari-120 stamp
vicki [Wed, 7 Jan 2004 18:32:54 +0000 (18:32 +0000)]
Safari-120 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Possible fix for table bugs 3510005 and 3492945, repainting glitches that occurred...
hyatt [Wed, 7 Jan 2004 01:15:20 +0000 (01:15 +0000)]
Possible fix for table bugs 3510005 and 3492945, repainting glitches that occurred when table cells moved.

Fix for 33522497, empty AXElements appear in AXBrowser.

        Reviewed by darin

        * khtml/rendering/render_table.cpp:
        * khtml/rendering/render_table.h:

        * kwq/KWQAccObject.mm:
        (-[KWQAccObject accessibilityIsIgnored]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago - fixed <rdar://problem/3484465>: REGRESSION (118): button click does
sullivan [Tue, 6 Jan 2004 23:39:26 +0000 (23:39 +0000)]
    - fixed <rdar://problem/3484465>: REGRESSION (118): button click does
        not take focus away from <textarea>; breaks Outlook Web Access

        Reviewed by Dave.

        * khtml/khtmlview.cpp:
        Removed nodeimpl == nil test that was preventing button/link clicks
        from blurring previously-focused text field.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3513660. Make ATSU layout and draw with integer glyph boundaries. This fix...
rjw [Tue, 6 Jan 2004 23:09:01 +0000 (23:09 +0000)]
Fixed 3513660.  Make ATSU layout and draw with integer glyph boundaries.  This fix should be removed if/when we convert WebCore to use floats for measuring/positioning (3521781).

        Reviewed by John.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _createATSUTextLayoutForRun:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoI meant kMax not kMin here.
hyatt [Tue, 6 Jan 2004 21:59:14 +0000 (21:59 +0000)]
I meant kMax not kMin here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3521814. Finalize messages weren't being dispatched!
rjw [Tue, 6 Jan 2004 21:55:38 +0000 (21:55 +0000)]
Fixed 3521814.  Finalize messages weren't being dispatched!

        Reviewed by John.

        * bindings/jni_jsobject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3520636, infinite loop in page breaking code when printing.
hyatt [Tue, 6 Jan 2004 20:52:18 +0000 (20:52 +0000)]
Fix for 3520636, infinite loop in page breaking code when printing.

        Reviewed by darin

        * khtml/rendering/render_text.cpp:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge computePageRectsWithPrintWidth:printHeight:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3521466, generated image content should not try to calcWidth/height when...
hyatt [Mon, 5 Jan 2004 23:24:20 +0000 (23:24 +0000)]
Fix for 3521466, generated image content should not try to calcWidth/height when it isn't yet rooted in
the rendering tree.

        Reviewed by john

        * khtml/rendering/render_image.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3514454. Work-around added for 3521759.
rjw [Mon, 5 Jan 2004 22:52:28 +0000 (22:52 +0000)]
Fix for 3514454.  Work-around added for 3521759.

Filed 3521781 to cover deeper problem.

        Reviewed by Kocienda.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]):
        (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Added cache of JNI method IDs to minimize allocations. This mitigates the problem
rjw [Mon, 5 Jan 2004 17:44:58 +0000 (17:44 +0000)]
Added cache of JNI method IDs to minimize allocations.  This mitigates the problem
described by 3515579.

Also cleanup up logging of Java exceptions.

        Reviewed by John.

        * bindings/jni/jni_class.cpp:
        * bindings/jni/jni_instance.cpp:
        * bindings/jni/jni_instance.h:
        * bindings/jni/jni_runtime.cpp:
        * bindings/jni/jni_runtime.h:
        * bindings/jni/jni_utility.cpp:
        * bindings/jni/jni_utility.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5855 268f45cc-cd09-0410-ab3c-d52691b4dbfc