16 years ago Reviewed by justin
justing [Wed, 21 Dec 2005 02:06:18 +0000 (02:06 +0000)]
    Reviewed by justin

        New layout tests for:
        -[WebHTMLView firstRectForCharacterRange:] is using _selectedRange instead of the given range if no marked text

        * editing/input/firstrectforcharacterrange-plain-expected.txt: Added.
        * editing/input/firstrectforcharacterrange-plain.html: Added.
        * editing/input/firstrectforcharacterrange-styled-expected.txt: Added.
        * editing/input/firstrectforcharacterrange-styled.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by justin
justing [Wed, 21 Dec 2005 02:05:12 +0000 (02:05 +0000)]
    Reviewed by justin

        -[WebHTMLView firstRectForCharacterRange:] is using _selectedRange instead of the given range if no marked text

        Added layout tests:
        * editing/input/firstrectforcharacterrange-styled
        * editing/input/firstrectforcharacterrange-plain

        * khtml/editing/visible_text.cpp:
        Return null if the range isn't found, instead of a startless/endless
        range.  Set the end if the requested location+length is out of bounds.
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge convertToDOMRange:]): Handle larged unsigned values
        before calling rangeWithLocationAndLength, which expects signed ints.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by justin
justing [Wed, 21 Dec 2005 02:04:38 +0000 (02:04 +0000)]
    Reviewed by justin

        -[WebHTMLView firstRectForCharacterRange:] is using _selectedRange instead of the given range if no marked text

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView firstRectForCharacterRange:]):
        Handle some large unsigned values the way NSTextView does.
        Actually use the range passed in instead of _selectedRange,
        use of _selectedRange was a workaround that is no longer necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin Adler.
sullivan [Wed, 21 Dec 2005 01:16:47 +0000 (01:16 +0000)]
    Reviewed by Darin Adler.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6146
          (REGRESSION: Bold font used for Google search result pages is too thick)

        This is a problem with a particular font that was installed by Microsoft Office X. Though the
        font and/or lower levels of font-handling code in the system are buggy, this bad symptom will
        occur for users of Safari and other WebKit clients who happen to have one of these bad fonts.
        This adds a workaround to avoid the problem.

        * WebCoreSupport.subproj/WebTextRendererFactory.m:
        (-[WebTextRendererFactory fontWithFamilies:traits:size:]):
        When we're going to synthesize bold or italic, yet the font we looked up was apparently a
        match for the traits, try to look up a font that without the to-be-synthesized traits.
        This way, instead of applying synthetic bold over Arial Bold, we'll apply synthetic
        bold over Arial Regular, which is uglier than just using Arial Bold, but far less ugly
        than using Arial Bold with synthetic bold too.

 2005-12-16  Justin Garcia  <justin.garcia@apple.com>

         <rdar://problem/4103393> Frequent Safari crash on lexisnexus.com (khtml::Selection::xPosForVerticalArrowNavigation)
         <rdar://problem/4330451> CrashTracer: [REGRESSION] 2235 crashes in Safari at com.apple.WebCore: khtml::Selection::xPosForVerticalArrowNavigation const  436

         Reviewed by darin

         WebCore will crash when a selection that starts or ends in a node
         that has been removed from the document is modify()d.  This can occur:
         (1) in non-editable regions (4103393 and 4330451), (2) in editable
         regions (4383146) as the result of arbitrary DOM operations, and (3) in
         Mail (4099739) as the result of an editing operation that sets a
         bad ending selection.

         Crashes of type (1) can occur when the user uses the arrow keys
         to interact with a web app, or when the user tries to use
         command-shift-arrow to switch tabs (this is a depricated
         combo that will work if no one else responds to it). The easiest
         way to fix these crashes is to disallow editing'ish selection changes
         like moveDown:, selectWord:, pageDown:, etc, when the selection
         is in a non-editable region.

         Crashes of type (2) will require a more complicated fix (but occur
         much less often than type (1)).  Crashes of type (3) must be
         fixed by tracking down the editing operation that sets bad selections.

         Added a layout-test:
         * editing/selection/selection-actions.html

         * WebView.subproj/WebHTMLView.m:
         (-[WebHTMLView _canAlterCurrentSelection]):
         (-[WebHTMLView _alterCurrentSelection:direction:granularity:]):
         (-[WebHTMLView _alterCurrentSelection:verticalDistance:]):
         (-[WebHTMLView _expandSelectionToGranularity:]):
         * WebView.subproj/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
adele [Wed, 21 Dec 2005 00:48:54 +0000 (00:48 +0000)]
    Reviewed by Darin.

        Fix for <rdar://problem/4387630> REGRESSION: <select> element's onClick event doesn't fire @ bugweb.apple.com

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::passSubframeEventToSubframe): only pass mouse down for khtmlviews.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by darin
justing [Wed, 21 Dec 2005 00:23:52 +0000 (00:23 +0000)]
    Reviewed by darin

        Layout test for:
        <rdar://problem/4103393> Frequent Safari crash on lexisnexus.com (khtml::Selection::xPosForVerticalArrowNavigation)
         <rdar://problem/4330451> CrashTracer: [REGRESSION] 2235 crashes in Safari at com.apple.WebCore: khtml::Selection::xPosForVerticalArrowNavigation const  436

        * editing/selection/selection-actions-expected.checksum: Added.
        * editing/selection/selection-actions-expected.png: Added.
        * editing/selection/selection-actions-expected.txt: Added.
        * editing/selection/selection-actions.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago 2005-12-16 Justin Garcia <justin.garcia@apple.com>
justing [Wed, 21 Dec 2005 00:23:08 +0000 (00:23 +0000)]
 2005-12-16  Justin Garcia  <justin.garcia@apple.com>

         <rdar://problem/4103393> Frequent Safari crash on lexisnexus.com (khtml::Selection::xPosForVerticalArrowNavigation)
         <rdar://problem/4330451> CrashTracer: [REGRESSION] 2235 crashes in Safari at com.apple.WebCore: khtml::Selection::xPosForVerticalArrowNavigation const  436

         Reviewed by darin

         WebCore will crash when a selection that starts or ends in a node
         that has been removed from the document is modify()d.  This can occur:
         (1) in non-editable regions (4103393 and 4330451), (2) in editable
         regions (4383146) as the result of arbitrary DOM operations, and (3) in
         Mail (4099739) as the result of an editing operation that sets a
         bad ending selection.

         Crashes of type (1) can occur when the user uses the arrow keys
         to interact with a web app, or when the user tries to use
         command-shift-arrow to switch tabs (this is a depricated
         combo that will work if no one else responds to it). The easiest
         way to fix these crashes is to disallow editing'ish selection changes
         like moveDown:, selectWord:, pageDown:, etc, when the selection
         is in a non-editable region.

         Crashes of type (2) will require a more complicated fix (but occur
         much less often than type (1)).  Crashes of type (3) must be
         fixed by tracking down the editing operation that sets bad selections.

         Added a layout-test:
         * editing/selection/selection-actions.html

         * WebView.subproj/WebHTMLView.m:
         (-[WebHTMLView _canAlterCurrentSelection]):
         (-[WebHTMLView _alterCurrentSelection:direction:granularity:]):
         (-[WebHTMLView _alterCurrentSelection:verticalDistance:]):
         (-[WebHTMLView _expandSelectionToGranularity:]):
         * WebView.subproj/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by: eric, thatcher
justing [Wed, 21 Dec 2005 00:00:21 +0000 (00:00 +0000)]
Reviewed by: eric, thatcher

        <rdar://problem/4172984> KWQExceptions needs to use @try/@catch instead of relying on NSException.h internals

        Needed to undef try/catch because of 4333439.  Moved the
        declarations of variables that are returned from within a @try
        block outside the @try block (because of "might be clobbered by
        a longjmp or vfork" warnings).  Moved some return statements
        inside the @try block to fix volatilization errors with gcc4.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by eric, thatcher
justing [Tue, 20 Dec 2005 23:05:44 +0000 (23:05 +0000)]
    Reviewed by eric, thatcher

        <rdar://problem/4172984> KWQExceptions needs to use @try/@catch instead of relying on NSException.h internals

        Needed to undef try/catch because of 4333439.  Moved the
        declarations of variables that are returned from within a @try
        block outside the @try block (because of "might be clobbered by
        a longjmp or vfork" warnings).  Moved some return statements
        inside the @try block to fix volatilization errors with gcc4.

        * WebCore.xcodeproj/project.pbxproj:
        * WebCorePrefix.h:
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        * kwq/KWQExceptions.h:
        * kwq/KWQExceptions.mm:
        * kwq/KWQFileButton.mm:
        * kwq/KWQKCursor.mm:
        (+[NSCursor _WebCore_cursorWithName:hotSpot:_WebCore_cursorWithName:hotSpot:]):
        * kwq/KWQKHTMLPart.mm:
        * kwq/KWQKHTMLPartBrowserExtension.mm:
        * kwq/KWQLineEdit.mm:
        * kwq/KWQListBox.mm:
        * kwq/KWQLoader.mm:
        * kwq/KWQWidget.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago <rdar://problem/4294417> Cannot un-italicize some text after triple clicking it
harrison [Tue, 20 Dec 2005 22:31:44 +0000 (22:31 +0000)]
    <rdar://problem/4294417> Cannot un-italicize some text after triple clicking it

        Reviewed by Justin.

        * khtml/editing/apply_style_command.cpp:
        Removed check for tab span because ApplyStyleCommand::removeCSSStyle() already makes the same check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by mitz
justing [Tue, 20 Dec 2005 21:36:40 +0000 (21:36 +0000)]
    Reviewed by mitz

        Fixed more uninitialized variable warnings, and
        removed an extra semicolon.

        * WebCoreSupport.subproj/WebTextRenderer.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago <rdar://problem/4387270> editing/deleting/delete-3800834-fix failing
justing [Tue, 20 Dec 2005 21:18:28 +0000 (21:18 +0000)]
    <rdar://problem/4387270> editing/deleting/delete-3800834-fix failing
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=6160> REGRESSION: Crash when running editing/deleting/delete-3800834-fix.html
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=6161> REGRESSION: crash when pressing tab in editable WebHTMLView

        Reviewed by darin

        Some callers call setAttribute on a floating element.  So, using
        a RefPtr for the element inside addAttribute can destroy

        * khtml/xml/dom_elementimpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix bug numbers in last two entries.
mjs [Tue, 20 Dec 2005 20:48:55 +0000 (20:48 +0000)]
Fix bug numbers in last two entries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoAdded bugzilla link.
mjs [Tue, 20 Dec 2005 20:42:41 +0000 (20:42 +0000)]
Added bugzilla link.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Tue, 20 Dec 2005 20:41:55 +0000 (20:41 +0000)]
    Reviewed by Darin.

- push more of frame lookup and management from WebView to
WebFrame, this is in preparation for shifting this to WebCore

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge closeWindowSoon]): Adjust for change to WebFrameNamespaces
        (-[WebBridge runModal]): ditto
        * WebView.subproj/WebControllerSets.h:
        * WebView.subproj/WebControllerSets.m:
        (+[WebFrameNamespaces addFrame:toNamespace:]): This now operates in terms
of WebFrames (expected to be the main frame) not WebViews.
        (+[WebFrameNamespaces framesInNamespace:]): Ditto.
        * WebView.subproj/WebFrame.m:
        (-[WebFrame _setFrameNamespace:]): Set self, not WebView.
        (-[WebFrame _shouldAllowAccessFrom:]): Moved this code above use
to avoid prototyping the method.
        (-[WebFrame _descendantFrameNamed:sourceFrame:]): Ditto.
        (-[WebFrame _frameInAnyWindowNamed:sourceFrame:]): Copied logic
over from WebView.
        (-[WebFrame findFrameNamed:]): Do it all here, don't call WebView.
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebView.m:
        * WebView.subproj/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Tue, 20 Dec 2005 20:40:43 +0000 (20:40 +0000)]
    Reviewed by Darin.

        - fixed leak in createAttributeMap

        * khtml/xml/dom_elementimpl.cpp:
        (StyledElementImpl::createAttributeMap): the new attribute map
is going in a RefPtr, don't also ref it manually.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoRemove accidentally committed change (which I am about to recommit, so no ChangeLog
mjs [Tue, 20 Dec 2005 20:27:15 +0000 (20:27 +0000)]
Remove accidentally committed change (which I am about to recommit, so no ChangeLog
comment for the revert).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Tue, 20 Dec 2005 20:18:54 +0000 (20:18 +0000)]
    Reviewed by Darin.

- made ALWAYS_INLINE declare things inline as well as __attribute__((always_inline))

        * kxmlcore/AlwaysInline.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
mjs [Tue, 20 Dec 2005 20:12:50 +0000 (20:12 +0000)]

        Reviewed by Darin.

- fixed a leak in the assignment operator from PassRefPtr to RefPtr

        * kxmlcore/RefPtr.h:

- fix problem with PassRefPtr that darin spotted - it lacked a copy constructor
and therefore was using the default one, which can lead to excess derefs

I fixed this by adding a copy constructor from non-const
reference, and by adding a template pass() function that you have
to use when raw pointer or RefPtr are passed where PassRefPtr is

        * kjs/identifier.cpp:
        (KJS::Identifier::add): Changed to have PassRefPtr return type and
pass() the results.
        * kjs/identifier.h:
        * kjs/property_map.cpp:
        (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): Use pass()
where required.
        * kjs/ustring.cpp:
        (KJS::UString::UString): Use pass() as needed.
        (KJS::UString::append): ditto
        (KJS::UString::substr): ditto
        * kjs/ustring.h:
        (KJS::UString::UString): Use initializer instead of assignment
        * kxmlcore/PassRefPtr.h:
        (KXMLCore::PassRefPtr::PassRefPtr): Added copy constructor
        (KXMLCore::pass): new template function to make it convenient to pass
a PassRefPtr


        Reviewed by Darin.

        - change an assignment to a contructor declaration to build with PassRefPtr
leak fix changes

        * ksvg2/svg/SVGTransformableImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by adele.
ggaren [Tue, 20 Dec 2005 18:47:15 +0000 (18:47 +0000)]
    Reviewed by adele.

        Fixed build failure due to missing 'b's in my last checkin.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge isStatusbarVisible]): changed 'B' to 'b'
        (-[WebBridge setStatusbarVisible:]): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
ggaren [Tue, 20 Dec 2005 18:34:31 +0000 (18:34 +0000)]

        Reviewed by Maciej.

        Fixed <rdar://problem/4370397> Missing return statement in

        JSMethodNameToObjcMethodName had a check for a name being too long, but
        the check was missing a return statement.

        A lot of this code was confusing and some of it was wrong, so I fixed
        it up, added some asserts to catch this type of bug in the future,
        changed some comments, and renamed some variables.

        The two advantages of the new algorithm are (1) It makes writing past
        the end of the buffer virtually impossible because the test on the main
        loop is "while (not past end of buffer)" and (2) It's twice as fast
        because it doesn't call strlen. (There's no need to call strlen when
        we're walking the string ourselves.)

        methodsNamed also supports arbitrary-length method names now. Just in
        case the AppKit folks start getting REALLY verbose...

        * bindings/objc/objc_class.mm:
        * bindings/objc/objc_utility.h:
        * bindings/objc/objc_utility.mm:


        Layout test for <rdar://problem/4370397> Missing return statement in

        * fast/js/objc-big-method-name-expected.txt: Added.
        * fast/js/objc-big-method-name.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin, committed by Adele.
adele [Tue, 20 Dec 2005 18:29:13 +0000 (18:29 +0000)]
    Reviewed by Darin, committed by Adele.

        - fix deployment builds broken by the ATSUI multiple renderers patch

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (createATSULayoutParameters): Assign initial values, which will never be used,
        to substituteRenderer and firstSmallCap, to avoid uninitialized variable warnings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
ggaren [Tue, 20 Dec 2005 17:06:04 +0000 (17:06 +0000)]

        Reviewed by John.

        Fixed <rdar://problem/4310363> JavaScript window.open: Height is 1
        pixel short, and related bugs.

        There were a few bugs here.
        (1) Our code took size arguments and applied them to the window's
            content rect. That's incorrect. The Rhino book says the arguments
            should apply to the WebView. Other things that occupy the content
            rect include the tab bar, the status bar, and the 1 pixel border
            between brushed metal and document. All of these used to impinge
            on the web page's display area.

            The fix is to calculate sizing based on the WebView instead of
            the content rect. This means that the webViewContentRect and
            setContentRect delegate methods are obsolete and no longer called
            by any of our code. (setContentRect was never called in the
            first place.)

        (2) None of our sizing accounted for scaled resolutions.

            The fix is to ask the WebView to scale all coordintes for us.

        (3) Our code assumed that all window accoutrements were on by default.
            Safari works that way, but other WebKit clients might not.

            The fix is always to explicitly set an on/off state.

        (a) To facilitate scaling, I added a new bridge method, webView, to
        access the webView.

        (b) For internal consistency, I changed ___Bars to ___bars in bridge
        methods, and ___bars to ___Bars in WinArgs data members. (Interestingly,
        the different classes in our code are evenly divided on which format to

        Added manual test:
        * manual-tests/window-open-features.html: Added.
        * manual-tests/resources/200x200.png: Added.
        * manual-tests/resources/popup200x200.html: Added.

        * khtml/ecma/kjs_window.cpp:
        (KJS::showModalDialog): see (b)
        (KJS::WindowFunc::callAsFunction): see (b)
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::statusbarVisible): see (b)
        * kwq/KWQKHTMLPartBrowserExtension.mm:
        At the top of this method, I just did some formatting cleanup and
        moved the 'referrer' variable closer to where it's used.
        The changes in the middle of the method are (3), the bottom, (2).
        * kwq/KWQKPartsBrowserExtension.h:
        (KParts::WindowArgs::WindowArgs): see (b)
        * kwq/WebCoreBridge.h: see (a)


        Reviewed by John.

        Part of fix for <rdar://problem/4310363> JavaScript window.open: Height
        is 1 pixel short, and related bugs. See WebCore ChageLog.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge webView]): Added method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoSubmitted by: eseidel
eseidel [Tue, 20 Dec 2005 10:08:04 +0000 (10:08 +0000)]
Submitted by: eseidel
Reviewed by: mjs
        Development-only build fix.

        * WebView.subproj/WebFrame.m:
        (-[WebFramePrivate dealloc]): fixed typo

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Not reviewed.
mjs [Tue, 20 Dec 2005 09:59:11 +0000 (09:59 +0000)]
    Not reviewed.

- revert accidental commit of this file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6156
eseidel [Tue, 20 Dec 2005 09:30:24 +0000 (09:30 +0000)]
Bug #: 6156
Submitted by: eseidel
Reviewed by: mjs
        Leaks when running SVG tests
        No additional tests necessary, leaks already caught by other tests.

        * kcanvas/KCanvasFilters.cpp:
        (KCanvasFEDiffuseLighting::setLightSource): takes ownership
        (KCanvasFESpecularLighting::setLightSource): takes ownership
        * kcanvas/KCanvasFilters.h:
        (KCanvasFEDiffuseLighting::KCanvasFEDiffuseLighting): added
        (KCanvasFEDiffuseLighting::~KCanvasFEDiffuseLighting): added
        (KCanvasFEDiffuseLighting::lightSource): fixed spacing
        (KCanvasFESpecularLighting::KCanvasFESpecularLighting): added
        (KCanvasFESpecularLighting::~KCanvasFESpecularLighting): added
        (KCanvasFESpecularLighting::lightSource): fixed spacing
        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
        (KRenderingDeviceQuartz::stringForPath): added missing CFRelease

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 5931
eseidel [Tue, 20 Dec 2005 09:16:45 +0000 (09:16 +0000)]
Bug #: 5931
Submitted by: eseidel
Reviewed by: darin
        Remove additional bit-rotted DEBUG* ifdefs from WebCore.
        No tests possible, only removing dead code.

        * khtml/css/css_stylesheetimpl.cpp:
        * khtml/html/html_formimpl.cpp:
        * khtml/html/htmlparser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6107
eseidel [Tue, 20 Dec 2005 08:49:51 +0000 (08:49 +0000)]
Bug #: 6107
Submitted by: eseidel
Reviewed by: darin
        Move Decoder onto Shared<T> and clients onto RefPtr.
        No test cases possible, no functional changes.

        * khtml/ecma/XSLTProcessor.cpp:
        * khtml/ecma/xmlhttprequest.cpp:
        * khtml/ecma/xmlhttprequest.h:
        * khtml/khtml_part.cpp:
        * khtml/khtmlpart_p.h:
        * khtml/misc/decoder.cpp:
        * khtml/misc/decoder.h:
        * khtml/misc/loader.h:
        * khtml/xml/dom_docimpl.cpp:
        * khtml/xml/dom_docimpl.h:
        * khtml/xsl/xslt_processorimpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
mjs [Tue, 20 Dec 2005 08:32:56 +0000 (08:32 +0000)]
    Reviewed by Eric.

- Move handling of frame namespaces down to WebFrame.
- Put some internal class declarations in the implementation file.

        * WebView.subproj/WebControllerSets.m:
        (+[WebFrameNamespaces addWebView:toFrameNamespace:]):
        (+[WebFrameNamespaces webViewsInFrameNamespace:]):
        * WebView.subproj/WebFrame.m:
        (-[WebFramePrivate dealloc]):
        (-[WebFrame _setFrameNamespace:]):
        (-[WebFrame _frameNamespace]):
        * WebView.subproj/WebFrameInternal.h:
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebView.m:
        (-[WebView _close]):
        (-[WebView _findFrameNamed:sourceFrame:]):
        (-[WebView setGroupName:]):
        (-[WebView groupName]):
        * WebView.subproj/WebViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
adele [Mon, 19 Dec 2005 22:16:29 +0000 (22:16 +0000)]

        Reviewed by Darin, committed by Adele.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6139
          ATSUI code path should implement small caps, synthetic bold and oblique and correct metrics for fallback fonts

        * fast/text/atsui-multiple-renderers-expected.checksum: Added.
        * fast/text/atsui-multiple-renderers-expected.png: Added.
        * fast/text/atsui-multiple-renderers-expected.txt: Added.
        * fast/text/atsui-multiple-renderers.html: Added.

        * css1/text_properties/text-transCapitalize-expected.checksum:
        * css1/text_properties/text-transCapitalize-expected.png:
        * fast/text/international/bidi-AN-after-L-expected.checksum:
        * fast/text/international/bidi-AN-after-L-expected.png:
        * fast/text/international/bidi-AN-after-L-expected.txt:
        * fast/text/international/bidi-L2-run-reordering-expected.checksum:
        * fast/text/international/bidi-L2-run-reordering-expected.png:
        * fast/text/international/bidi-L2-run-reordering-expected.txt:
        * fast/text/international/bidi-LDB-2-CSS-expected.checksum:
        * fast/text/international/bidi-LDB-2-CSS-expected.png:
        * fast/text/international/bidi-LDB-2-CSS-expected.txt:
        * fast/text/international/bidi-LDB-2-HTML-expected.checksum:
        * fast/text/international/bidi-LDB-2-HTML-expected.png:
        * fast/text/international/bidi-LDB-2-HTML-expected.txt:
        * fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
        * fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
        * fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
        * fast/text/international/bidi-european-terminators-expected.checksum:
        * fast/text/international/bidi-european-terminators-expected.png:
        * fast/text/international/bidi-european-terminators-expected.txt:
        * fast/text/international/bidi-fallback-font-weight-expected.checksum:
        * fast/text/international/bidi-fallback-font-weight-expected.png:
        * fast/text/international/bidi-fallback-font-weight-expected.txt:
        * fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
        * fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
        * fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
        * fast/text/international/bidi-innertext-expected.checksum:
        * fast/text/international/bidi-innertext-expected.png:
        * fast/text/international/bidi-innertext-expected.txt:
        * fast/text/international/bidi-override-expected.checksum:
        * fast/text/international/bidi-override-expected.png:
        * fast/text/international/bidi-override-expected.txt:


        Reviewed by Darin, committed by Adele.

        Test: fast/text/atsui-multiple-renderers.html

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6139
          ATSUI code path should implement small caps, synthetic bold and oblique and correct metrics for fallback fonts

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (overrideLayoutOperation): Fetch renderer info from the renderers array;
        add synthetic bold offset; render only synthetic bold in the synthetic bold pass.
        (drawGlyphs): Replaced 14 with new SYNTHETIC_OBLIQUE_ANGLE define.
        (initializeATSUStyle): Apply a skewing transform for synthetic oblique.
        (createATSUTextLayout): Merged into createATSUTextLayout.
        (createATSULayoutParameters): Merged in createATSUTextLayout; allocate
        and fill a renderers array and a character buffer for small caps and mirroring;
        (applyMirroringToRun): Merged into createATSULayoutParameters.
        (ATSU_drawHighlight): Deleted mirroring code.
        (ATSU_draw): Deleted mirroring code; added second pass for synthetic bold.
        (ATSU_pointToOffset): Deleted mirroring code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: none
eseidel [Mon, 19 Dec 2005 21:03:53 +0000 (21:03 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: darin
        * Scripts/run-webkit-tests: stop /etc/catalog warnings

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
adele [Mon, 19 Dec 2005 20:54:15 +0000 (20:54 +0000)]

        Reviewed by Darin, committed by Adele.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6137
          Disable kerning and some ligatures in the ATSUI code path

        * fast/text/atsui-kerning-and-ligatures-expected.checksum: Added.
        * fast/text/atsui-kerning-and-ligatures-expected.png: Added.
        * fast/text/atsui-kerning-and-ligatures-expected.txt: Added.
        * fast/text/atsui-kerning-and-ligatures.html: Added.


        Reviewed by Darin, committed by Adele.

        Test: fast/text/atsui-kerning-and-ligatures.html

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6137
          Disable kerning and some ligatures in the ATSUI code path

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (initializeATSUStyle): Disable kerning; disable ligatures unless the font
        does not contain 'a', in which case it is assumed to never be rendered
        by the CG code path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Originally done by both George Staikos and Alexey Proskuryakov.
darin [Mon, 19 Dec 2005 20:48:23 +0000 (20:48 +0000)]
    Originally done by both George Staikos and Alexey Proskuryakov.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5706
          Sharedptr dependency can be removed

        Our coding guidelines say "use 0 instead of NULL" and both RefPtr and
        PassRefPtr were using NULL, which required including a header that
        defines NULL.

        * kxmlcore/PassRefPtr.h:
        (KXMLCore::PassRefPtr::PassRefPtr): Use 0 instead of NULL.
        (KXMLCore::PassRefPtr::operator!): Use ! instead of == NULL.
        * kxmlcore/RefPtr.h:
        (KXMLCore::RefPtr::RefPtr): Use 0 instead of NULL.
        (KXMLCore::RefPtr::operator!): Use ! instead of == NULL.
        Also did some reformatting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
darin [Mon, 19 Dec 2005 20:41:47 +0000 (20:41 +0000)]
    Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6143
          DOM::ElementImpl should use a RefPtr for the attribute map

        * khtml/xml/dom_elementimpl.cpp:
        (ElementImpl::ElementImpl): Remove code to initialize the pointer; not needed since
        RefPtr gets initialized to 0.
        (ElementImpl::~ElementImpl): Remove code to deref the pointer; RefPtr handles that.
        (ElementImpl::attributes): Add get() call to get raw pointer.
        (ElementImpl::setAttributeMap): Remove code to deref the old map and set the new map.
        But added code to clear the element pointer from the old map (missing in the old
        version). Also added a FIXME.
        (ElementImpl::createAttributeMap): Remove ref(); RefPtr handles that.
        (NamedAttrMapImpl::addAttribute): Use a RefPtr to guarantee the element does not go
        away in the middle of dispatching DOM events.
        (StyledElementImpl::attributeChanged): Clean up code by using the inline function
        mappedAttributes() instead of doing type casts.
        (StyledElementImpl::parseMappedAttribute): Ditto.
        (StyledElementImpl::getClassList): Ditto.

        * khtml/xml/dom_elementimpl.h: Make ElementImpl::namedAttrMap be a RefPtr instead
        of raw pointer. Added an overload of StyledElementImpl::mappedAttributes for both
        const and non-const.

        * khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::addChild): Use a RefPtr to ref/deref
        the child so that it doesn't leak.

        * khtml/html/htmlparser.h: Changed isindex to use a RefPtr.
        * khtml/html/htmlparser.cpp:
        (HTMLParser::~HTMLParser): Removed now-unneeded ref.
        (HTMLParser::isindexCreateErrorCheck): Remove now-unneeded deref/ref.
        (HTMLParser::handleIsindex): Put isindex element into a RefPtr. This prevents a
        crash that was otherwise happening during layout tests (caused indirectly by
        the changes above).
        (HTMLParser::startBody): Added call to get().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric Seidel.
darin [Mon, 19 Dec 2005 19:56:25 +0000 (19:56 +0000)]
    Reviewed by Eric Seidel.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4990
          WebKit needs to use a local pasteboard during testing

        * DumpRenderTree/DumpRenderTree.m:
        (main): Call poseAs to substitute our NSPasteboard class for the default one.
        Create a local pasteboard (really a global one with a unique name) and release
        it when exiting from the function so we don't leave it in the pasteboard server.
        (dumpRenderTree): Added an autorelease pool around one small bit of code that
        ddn't have one. Fixed a leak in an unlikely error case.
        (+[DumpRenderTreePasteboard generalPasteboard]): Override the default version
        of this method to return our local pasteboard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
darin [Mon, 19 Dec 2005 19:53:12 +0000 (19:53 +0000)]

        Reviewed by Geoff Garen and Eric Seidel.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4923
          stop using <ostream> in WebCore, eliminating the <cmath> troubles it causes

        * kjs/simple_number.h: Removed many unnecessary includes, including
        the <cmath> one to work around GCC library header bugs. We may have to
        add some includes elsewhere for platforms other than OS X, since our
        prefix header takes care of some things.

        * kxmlcore/AlwaysInline.h: Added. Now clients that don't include
        simple_number.h can still get the ALWAYS_INLINE macro.
        * JavaScriptCore.xcodeproj/project.pbxproj: Added AlwaysInline.h.

        * bindings/NP_jsobject.h: Removed a lot of unnecessary includes
        and removed C-specific stuff from this C++-only header.
        * bindings/jni/jni_jsobject.h: Removed a lot of unnecessary includes
        and did some reformatting.
        * bindings/objc/objc_runtime.h:  Removed an unnecessary include.
        * bindings/runtime.h: Removed some unneeded includes. Reformatted.
        * bindings/runtime.cpp: Updated to compile with header changes,
        including a lot of reformatting.
        * bindings/runtime_object.h: Removed an unnecessary include.


        Reviewed by Geoff Garen and Eric Seidel.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4923
          stop using <ostream> in WebCore, eliminating the <cmath> troubles it causes

        * ForwardingHeaders/kxmlcore/AlwaysInline.h: Added.
        * WebCorePrefix.h: Removed the use of <ostream>.

        * kwq/KWQDef.h: Removed now-unused Q_INT64, Q_INT16, Q_UINT16, qRound, and _KWQ_IOSTREAM_.

        * kwq/KWQKHTMLPart.h: Removed some unneeded headers and added forward-declarations of classes
        instead. Corrected some incorrect member function declarations.
        * kwq/KWQKHTMLPart.mm: Added a now-needed header.

        * khtml/ecma/kjs_window.cpp: Removed the <cmath> workaround.
        * khtml/rendering/bidi.cpp: Added include of AlwaysInline.h and removed a
        lot of unnecessary includes.
        * khtml/rendering/render_canvasimage.cpp: Removed the <cmath> workaround.
        * khtml/rendering/render_image.cpp: Removed the <cmath> workaround.
        * khtml/rendering/render_text.cpp: Added include of AlwaysInline.h and removed a
        lot of unnecessary includes.

        * ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty):
        * ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::calculateColor):
        * ksvg2/svg/SVGAnimateTransformElementImpl.cpp: (SVGAnimateTransformElementImpl::handleTimerEvent):
        * ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::closeRenderer):
        * ksvg2/svg/SVGLinearGradientElementImpl.cpp: (SVGLinearGradientElementImpl::buildGradient):
        * ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::notifyAttributeChange):
        * ksvg2/svg/SVGRadialGradientElementImpl.cpp: (SVGRadialGradientElementImpl::buildGradient):
        Replaced use of qRound with use of lroundf or lround as appropriate.

        * kwq/KWQCString.h:
        * kwq/KWQCString.mm:
        * kwq/KWQDateTime.h:
        * kwq/KWQDateTime.mm:
        * kwq/KWQMap.h:
        * kwq/KWQMemArray.h:
        * kwq/KWQPoint.mm:
        * kwq/KWQPointArray.h:
        * kwq/KWQPtrList.h:
        * kwq/KWQPtrStack.h:
        * kwq/KWQPtrVector.h:
        * kwq/KWQRect.h:
        * kwq/KWQRect.mm:
        * kwq/KWQSize.h:
        * kwq/KWQSize.mm:
        * kwq/KWQValueList.h:
        Removed _KWQ_IOSTREAM_ code that was used at one time for unit tests, but is now unneeded,
        and requires <ostream>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff Garen and John Sullivan.
darin [Mon, 19 Dec 2005 19:50:45 +0000 (19:50 +0000)]
    Reviewed by Geoff Garen and John Sullivan.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4312
          XMLHttpRequest headers that have two CRLF sequences lead to Obj-C exception

        * kwq/KWQLoader.mm:
        (+[NSDictionary _webcore_dictionaryWithHeaderString:_webcore_dictionaryWithHeaderString:]):
        Check length of string before calling characterAtIndex:0 since it will fail for an empty string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #:
bdakin [Mon, 19 Dec 2005 19:41:39 +0000 (19:41 +0000)]
Bug #:
Submitted by:
Reviewed by:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
adele [Mon, 19 Dec 2005 19:37:58 +0000 (19:37 +0000)]

        Reviewed by Darin, committed by Adele.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6132
          Incorrect selection highlighting for ATSUI text when selected range is "CG-safe"

        * fast/text/should-use-atsui-expected.checksum: Added.
        * fast/text/should-use-atsui-expected.png: Added.
        * fast/text/should-use-atsui-expected.txt: Added.
        * fast/text/should-use-atsui.html: Added.


        Reviewed by Darin, committed by Adele.

        Test: fast/text/should-use-atsui.html

        - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6132
          Incorrect selection highlighting for ATSUI text when selected range is "CG-safe"

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (shouldUseATSU): Always start scanning from 0 since drawing and
        highlighting also measure everything up to run->from.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin, committed by Adele.
adele [Mon, 19 Dec 2005 19:17:32 +0000 (19:17 +0000)]
    Reviewed by Darin, committed by Adele.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5744
          XMLHttpRequest does not apply page encoding after assigning via innerHtml

        * khtml/ecma/xmlhttprequest.cpp:
        (getMIMEType): A helper function to get MIME type from a Content-Type string.
        (getCharset): A helper function to get charset from a Content-Type string.
        (KJS::XMLHttpRequest::getValueProperty): Factored out responseIsXML().
        (KJS::XMLHttpRequest::getResponseHeader): Return QString instead of JSValue
          (to get rid of unnecessary JSLocks).
        (KJS::XMLHttpRequest::responseIsXML): A new method that analyses Content-Type.
        (KJS::XMLHttpRequest::slotData): Use a correct charset for responses, see bug for details.
        (KJS::XMLHttpRequestProtoFunc::callAsFunction): Update for getResponseHeader() changes
        * khtml/ecma/xmlhttprequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago== Rolled over to ChangeLog-2005-12-19 ==
thatcher [Mon, 19 Dec 2005 19:16:44 +0000 (19:16 +0000)]
== Rolled over to ChangeLog-2005-12-19 ==

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff and Adele
mjs [Mon, 19 Dec 2005 10:38:07 +0000 (10:38 +0000)]
    Reviewed by Geoff and Adele

- replaced custom Identifier hashtable with HashSet

        * kjs/identifier.cpp:
        * kjs/identifier.h:
        * kjs/internal.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
mjs [Mon, 19 Dec 2005 10:32:11 +0000 (10:32 +0000)]

        Rubber stamped by Eric.

        - removed unused SPI headers

        * WebCore.xcodeproj/project.pbxproj:
        * kwq/DOM-compat.h: Removed.


        Rubber stamped by Eric.

- remove some unused SPI headers.

        * DOM.subproj/WebDOMDocument.h: Removed.
        * DOM.subproj/WebDOMElement.h: Removed.
        * DOM.subproj/WebDOMNode.h: Removed.
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
darin [Mon, 19 Dec 2005 00:27:29 +0000 (00:27 +0000)]

        Reviewed, tweaked, and landed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5227
          Array indexOf() extension for JavaScript 1.5 Core

        * kjs/array_object.h:
        * kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Added implementation of indexOf.


        Reviewed, tweaked, and landed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5227
          Array indexOf() extension for JavaScript 1.5 Core

        * fast/js/array-indexof-expected.txt: Added.
        * fast/js/array-indexof.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff.
darin [Sun, 18 Dec 2005 23:41:48 +0000 (23:41 +0000)]
    Reviewed by Geoff.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6144
          REGRESSION: DOMStringImpl leak in code to make DOMString from NSString

        * kwq/DOMInternal.mm: (DOMString::DOMString): Remove now-unneeded ref.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff.
darin [Sun, 18 Dec 2005 23:40:13 +0000 (23:40 +0000)]
    Reviewed by Geoff.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5680
          containsOnlyWhitespace does not need to be a virtual function

        * khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): Cast
        pointer to a TextImpl before calling containsOnlyWhitespace; the code already
        checked isTextNode.
        * khtml/rendering/render_line.cpp: (khtml::shouldDrawDecoration): Expanded an
        if statement into a few separate ones for slight additional clarity. Added a
        check of isTextNode and cast pointer to a TextImpl.

        * khtml/xml/dom_nodeimpl.h: Remove containsOnlyWhitespace function.
        * khtml/xml/dom_textimpl.h: Remove virtual keyword from containsOnlyWhitespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Sun, 18 Dec 2005 22:55:35 +0000 (22:55 +0000)]

        Reviewed by Hyatt, landed by Darin.

        Test for: http://bugzilla.opendarwin.org/show_bug.cgi?id=5980
        Bidi properties of an inline container whose first child is an
        inline container are ignored

        * fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Added.
        * fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Added.
        * fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: Added.
        * fast/text/international/bidi-ignored-for-first-child-inline.html: Added.


        Reviewed by Hyatt, landed by Darin.

        Test: fast/text/international/bidi-ignored-for-first-child-inline.html

        Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=5980
        Bidi properties of an inline container whose first child is an
        inline container are ignored

        * khtml/rendering/bidi.cpp:
        Adjust embedding at inline containers' boundaries instead of inside.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Sun, 18 Dec 2005 22:37:26 +0000 (22:37 +0000)]

        Reviewed and landed by Darin.

        - test of a particular character set name that is not in the WebCore table
          but is in the ICU table (see bugzilla 5932)

        * fast/encoding/charset-cp1251-expected.txt: Added.
        * fast/encoding/charset-cp1251.html: Added.


        Reviewed and landed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5932
          Wrong encoding used for http://www.miel.ru

        * kwq/KWQCharsets.mm: (KWQCFStringEncodingFromIANACharsetName):
        Fall back on ICU encoding names if we don't find the name in the WebCore
        encoding names table.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Sun, 18 Dec 2005 22:23:29 +0000 (22:23 +0000)]

        Reviewed and landed by Darin.

        - XSLT document encoding tests

        * fast/xsl/xslt-doc-enc-expected.txt: Added.
        * fast/xsl/xslt-doc-enc.xml: Added.
        * fast/xsl/xslt-doc-enc.xsl: Added.
        * fast/xsl/xslt-doc-noenc-expected.txt: Added.
        * fast/xsl/xslt-doc-noenc.xml: Added.
        * fast/xsl/xslt-doc-noenc.xsl: Added.


        Reviewed and landed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5927
          Result of XSLT transformation has no charset defined

        * khtml/xml/dom_docimpl.cpp: (DocumentImpl::applyXSLTransform):
        Get encoding from transform and pass in to XSLTProcessor.

        * khtml/xsl/xslt_processorimpl.h:
        * khtml/xsl/xslt_processorimpl.cpp:
        (DOM::XSLTProcessorImpl::createDocumentFromSource): Added encoding parameter.
        Create a Decoder and use it to decode the source document (default encoding UTF-8).
        (DOM::XSLTProcessorImpl::transformToString): Add an encoding result. Set it to the
        encoding from the libxml2 document object.
        (DOM::XSLTProcessorImpl::transformToDocument): Get encoding from transform and pass
        in to XSLTProcessor.
        (DOM::XSLTProcessorImpl::transformToFragment): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric, landed by Darin.
darin [Sun, 18 Dec 2005 22:13:20 +0000 (22:13 +0000)]
    Reviewed by Eric, landed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5631
          KWQKHTMLPart::attributedString ignores many tags

        * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):
        Fix incorrectly nested else.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix date
andersca [Sun, 18 Dec 2005 13:28:33 +0000 (13:28 +0000)]
Fix date

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2005-12-18 Anders Carlsson <andersca@mac.com>
andersca [Sun, 18 Dec 2005 13:27:35 +0000 (13:27 +0000)]
2005-12-18  Anders Carlsson  <andersca@mac.com>

        Reviewed by Darin.

        Test case for http://bugzilla.opendarwin.org/show_bug.cgi?id=4000
        Object.prototype is missing isPrototypeOf

        * fast/js/test-isPrototypeOf-expected.txt: Added.
        * fast/js/test-isPrototypeOf.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2005-12-18 Anders Carlsson <andersca@mac.com>
andersca [Sun, 18 Dec 2005 13:27:00 +0000 (13:27 +0000)]
2005-12-18  Anders Carlsson  <andersca@mac.com>

        Reviewed by Darin and Geoffrey.

        - fix for <http://bugzilla.opendarwin.org/show_bug.cgi?id=4000>
        Object.prototype is missing isPrototypeOf

        * kjs/object_object.cpp:
        Add isPrototypeOf to object prototype.

        Implement isPrototypeOf

        * kjs/object_object.h:
        Add id for isPrototypeOf.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoupdaated changelog to remove previous suggestion that darin was a nobody
ggaren [Sun, 18 Dec 2005 09:20:20 +0000 (09:20 +0000)]
updaated changelog to remove previous suggestion that darin was a nobody

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed and landed by Darin.
darin [Sun, 18 Dec 2005 05:01:35 +0000 (05:01 +0000)]
    Reviewed and landed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5768
          pages with frames that are all "fixed" get no layout and are blank (like www.farnell.nl)

        * khtml/rendering/render_frames.cpp: (RenderFrameSet::layout):
        * manual-tests/bugzilla-5768.html: Added. Can't seem to get it to work (fail) as an automated test.
        * manual-tests/resources/frame1.html: Added.
        * manual-tests/resources/frame2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6119
ggaren [Sun, 18 Dec 2005 03:09:41 +0000 (03:09 +0000)]
    Layout test for bugzilla.opendarwin.org/show_bug.cgi?id=6119
        split() function ignores case insensitive modifier.

        * fast/js/string-split-ignore-case-expected.txt: Added.
        * fast/js/string-split-ignore-case.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by NOBODY (OOPS!).
ggaren [Sun, 18 Dec 2005 03:09:31 +0000 (03:09 +0000)]
    Reviewed by NOBODY (OOPS!).

        Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6119
        split() function ignores case insensitive modifier.

        RegExpImp: The C++ object you get when JavaScript executes
                   "new RegExp()".
        RegExp:    A C++ wrapper object that performs regular expression
                   matching on behalf of a RegExpImp.

        Instead of unnecessarily constructing a RegExp which (wrongly) lacks
        any modifiers, String.split() now uses the RegExp built in to the
        RegExpImp passed to it, which has the right modifiers already.

        I also cleaned up other bits of the string code to standardized how
        we handle RegExpImp arguments.

        * ChangeLog:
        * kjs/string_object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2005-12-17 Anders Carlsson <andersca@mac.com>
andersca [Sat, 17 Dec 2005 20:12:35 +0000 (20:12 +0000)]
2005-12-17  Anders Carlsson  <andersca@mac.com>

        Reviewed by Darin.

        - Fix <http://bugzilla.opendarwin.org/show_bug.cgi?id=6120>
        Random crashes when running the test suite

        * khtml/css/css_ruleimpl.h:
        Make m_lstMedia a smart pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago2005-12-17 Anders Carlsson <andersca@mac.com>
andersca [Sat, 17 Dec 2005 20:09:46 +0000 (20:09 +0000)]
2005-12-17  Anders Carlsson  <andersca@mac.com>

        Reviewed by Eric.

        * khtml/css/css_ruleimpl.h:
        Make m_lstMedia a smart pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Sat, 17 Dec 2005 18:10:36 +0000 (18:10 +0000)]

        Reviewed and landed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5479
          Can't select text with RTL override rendered by ATSUI

        * fast/text/atsui-rtl-override-selection-expected.checksum: Added.
        * fast/text/atsui-rtl-override-selection-expected.png: Added.
        * fast/text/atsui-rtl-override-selection-expected.txt: Added.
        * fast/text/atsui-rtl-override-selection.html: Added.


        Reviewed and landed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5479
          Can't select text with RTL override rendered by ATSUI

        * khtml/rendering/font.h: Remove reversed parameter from checkSelectionPoint, replacing
        it with a text direction parameter.
        * khtml/rendering/render_text.cpp: (InlineTextBox::offsetForPosition): Ditto.
        * kwq/KWQFontMetrics.h: Add a directional override parameter to checkSelectionPoint.
        * kwq/KWQFontMetrics.mm: (QFontMetrics::checkSelectionPoint): Pass the directional override
        through to the text renderer. Don't pass the reversed flag redundantly -- use the rtl flag
        in the style instead.
        * kwq/WebCoreTextRenderer.h: Remove reversed parameter from pointToOffset.


        Reviewed and landed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5479
          Can't select text with RTL override rendered by ATSUI

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (overrideLayoutOperation): Update since the layout only includes from -> to now.
        (-[WebTextRenderer pointToOffset:style:position:includePartialGlyphs:]): Remove
        reversed parameter.
        (CG_floatWidthForRun): Add code to handle RTL case.
        (addDirectionalOverride): Put the override around the entire run.
        (ATSU_drawHighlight): Rearrange and reuse ATSU_floatWidthForRun for more of the work.
        Also round.
        (ATSU_pointToOffset): Remove reversed parameter and run swapping.
        (CG_pointToOffset): Remove reversed parameter, using rtl flag in style instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix the calls to strftime on the non-apple code path to take const tm* and not just tm
hyatt [Fri, 16 Dec 2005 23:01:33 +0000 (23:01 +0000)]
Fix the calls to strftime on the non-apple code path to take const tm* and not just tm

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFix the calls to strftime on the non-apple code path to take const tm* and not just tm
hyatt [Fri, 16 Dec 2005 22:56:41 +0000 (22:56 +0000)]
Fix the calls to strftime on the non-apple code path to take const tm* and not just tm

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoAdd assert.h include to ustring.cpp
hyatt [Fri, 16 Dec 2005 22:48:19 +0000 (22:48 +0000)]
Add assert.h include to ustring.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoifdef out the getpid call on windows.
hyatt [Fri, 16 Dec 2005 22:45:35 +0000 (22:45 +0000)]
ifdef out the getpid call on windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Remove unused RefPtr constructors that can create an ambiguity in ustring on some...
hyatt [Fri, 16 Dec 2005 22:27:26 +0000 (22:27 +0000)]
Remove unused RefPtr constructors that can create an ambiguity in ustring on some platforms.

        Reviewed by mjs

        * kxmlcore/RefPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6106
eseidel [Fri, 16 Dec 2005 22:26:12 +0000 (22:26 +0000)]
Bug #: 6106
Submitted by: eseidel
Reviewed by: darin
        DOMString should hold its impl in a RefPtr
        I also cleaned up spacing in dom_string.cpp
        No tests needed (no functionality changes).

        * khtml/dom/dom_string.cpp:
        (DOM::DOMString::operator += ):
        (DOM::DOMString::operator []):
        * khtml/dom/dom_string.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6110
eseidel [Fri, 16 Dec 2005 21:43:48 +0000 (21:43 +0000)]
Bug #: 6110
Submitted by: eseidel
Reviewed by: darin
        No test cases needed (no functionality changes).

        * khtml/xsl/xsl_stylesheetimpl.cpp:
        * khtml/xsl/xsl_stylesheetimpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
adele [Fri, 16 Dec 2005 21:30:35 +0000 (21:30 +0000)]
    Reviewed by Maciej.

        Fix for <rdar://problem/4381546> Safari crash at www.dallascowboys.com in KWQListIteratorImpl::current()

        * khtml/khtml_part.cpp:
        (KHTMLPart::slotFinishedParsing): ref the part before calling checkCompleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim O.
vicki [Fri, 16 Dec 2005 21:21:27 +0000 (21:21 +0000)]
    Reviewed by Tim O.

- fix <rdar://problem/4380428> window.onbeforeunload works on IE but not on Safari

        * khtml/ecma/kjs_window.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoDon't include bits/cpp_type_traits on win32
hyatt [Fri, 16 Dec 2005 20:33:21 +0000 (20:33 +0000)]
Don't include bits/cpp_type_traits on win32

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
ggaren [Fri, 16 Dec 2005 18:35:19 +0000 (18:35 +0000)]
    Reviewed by Eric.

        Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6112
        REGRESSION: navigator.plugins empty.

        Layout test added:
        * fast/js/Plug-ins-expected.checksum: Added.
        * fast/js/Plug-ins-expected.png: Added.
        * fast/js/Plug-ins-expected.txt: Added.
        * fast/js/Plug-ins.html: Added.

        * khtml/ecma/kjs_navigator.cpp:
        (KJS::PluginBase::PluginBase): Changed initialization of KConfig from
        empty string to pluginsinfo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6112
ggaren [Fri, 16 Dec 2005 18:34:56 +0000 (18:34 +0000)]
    Layout test for bugzilla.opendarwin.org/show_bug.cgi?id=6112
        REGRESSION: navigator.plugins empty.

        * fast/js/Plug-ins-expected.checksum: Added.
        * fast/js/Plug-ins-expected.png: Added.
        * fast/js/Plug-ins-expected.txt: Added.
        * fast/js/Plug-ins.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed and landed by Darin.
darin [Fri, 16 Dec 2005 18:20:24 +0000 (18:20 +0000)]
    Reviewed and landed by Darin.

        Test for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6014
        Bidi algorithm: incorrect resolved levels for neutrals between R and
        ET ON L

        * fast/text/international/bidi-european-terminators-expected.checksum: Added.
        * fast/text/international/bidi-european-terminators-expected.png: Added.
        * fast/text/international/bidi-european-terminators-expected.txt: Added.
        * fast/text/international/bidi-european-terminators.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed and landed by Darin.
darin [Fri, 16 Dec 2005 18:18:50 +0000 (18:18 +0000)]
    Reviewed and landed by Darin.

        Test: fast/text/international/bidi-european-terminators.html

        Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6014
        Bidi algorithm: incorrect resolved levels for neutrals between R and
        ET ON L

        * khtml/rendering/bidi.cpp:
        Keep track of the last position before the current run of ETs directly
        using a new BidiState member, lastBeforeET.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - Added layout tests Evan Gross contributed about converting to attributed...
darin [Fri, 16 Dec 2005 16:51:40 +0000 (16:51 +0000)]
    - Added layout tests Evan Gross contributed about converting to attributed string.
          The results here currently seem wrong, but are what I get with TOT.

        * fast/text/attributed-substring-from-range-expected.txt: Added.
        * fast/text/attributed-substring-from-range-lines-expected.txt: Added.
        * fast/text/attributed-substring-from-range-lines.html: Added.
        * fast/text/attributed-substring-from-range.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed and landed by Darin.
darin [Fri, 16 Dec 2005 16:51:10 +0000 (16:51 +0000)]
    Reviewed and landed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4680
          WebHTMLView (WebNSTextInputSupport) - attributedSubstringFromRange "not yet implemented"

        * WebView.subproj/WebHTMLView.m: (-[WebHTMLView attributedSubstringFromRange:]):
        Implement by calling the same RTF conversion used when copying to the pasteboard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Fri, 16 Dec 2005 16:40:20 +0000 (16:40 +0000)]

        Reviewed and landed by Darin.

        Updated tests that include RTL or "bidi override" runs since DumpRenderTree now
        dumps those runs.

        * fast/block/basic/016-expected.txt:
        * fast/block/float/026-expected.txt:
        * fast/block/float/028-expected.txt:
        * fast/block/positioning/auto/006-expected.txt:
        * fast/dom/HTMLElement/bdo-expected.txt:
        * fast/text/international/bidi-AN-after-L-expected.txt:
        * fast/text/international/bidi-CS-after-AN-expected.txt:
        * fast/text/international/bidi-L2-run-reordering-expected.txt:
        * fast/text/international/bidi-LDB-2-CSS-expected.txt:
        * fast/text/international/bidi-LDB-2-HTML-expected.txt:
        * fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
        * fast/text/international/bidi-explicit-embedding-expected.txt:
        * fast/text/international/bidi-fallback-font-weight-expected.txt:
        * fast/text/international/bidi-innertext-expected.txt:
        * fast/text/international/bidi-layout-across-linebreak-expected.txt:
        * fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
        * fast/text/international/bidi-override-expected.txt:


        Reviewed and landed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5486
          DumpRenderTree should print the RTL and directional override flags for text runs

        * kwq/KWQRenderTreeDebug.cpp: (writeTextRun): Dump the additional flags.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed and landed by Darin.
darin [Fri, 16 Dec 2005 16:18:45 +0000 (16:18 +0000)]
    Reviewed and landed by Darin.

        Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6043
        Incorrect selection highlighting in pre-formatted text with tabs

        * khtml/rendering/render_text.cpp: Correct parameters in calls to RenderText::width().
        * manual-tests/pre-tab-selection-rect.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
darin [Fri, 16 Dec 2005 16:13:12 +0000 (16:13 +0000)]

        Reviewed and landed by Darin.

        Test for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6069
        Assertion failure in RenderBlock::addChildToFlow during replaceChild

        * fast/js/replace-child-siblings-expected.txt: Added.
        * fast/js/replace-child-siblings.html: Added.


        Reviewed and landed by Darin.

        Test: fast/js/replace-child-siblings.html

        Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6069
        Assertion failure in RenderBlock::addChildToFlow during replaceChild

        * khtml/xml/dom_nodeimpl.cpp:
        (DOM::ContainerNodeImpl::replaceChild): If the new child was right
        before or right after the old child, then it just stays.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed and landed by Darin.
darin [Fri, 16 Dec 2005 16:11:52 +0000 (16:11 +0000)]
    Reviewed and landed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6090
          REGRESSION: Assertion failure when choosing Copy from a WebImageView's contextual menu

        * WebView.subproj/WebImageView.m:
        (-[WebImageView elementAtPoint:]): Use WebCoreElementImageRendererKey
        for the image renderer and WebElementImageKey for the image.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
darin [Fri, 16 Dec 2005 08:08:23 +0000 (08:08 +0000)]

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5688
          speed up JavaScript parsing by not creating a UString just to parse

        * kjs/internal.h:
        * kjs/internal.cpp: (KJS::InterpreterImp::evaluate): Change to take a character pointer
        and length rather than a UString.

        * kjs/interpreter.h:
        * kjs/interpreter.cpp: (Interpreter::evaluate): Ditto.

        * kjs/protect.h: Remove uneeded "convert to bool" operator since we already have a
        "convert to raw pointer" operator in this class.


        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5688
          speed up JavaScript parsing by not creating a UString just to parse

        * khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getListener): Use listenerObj instead of
        * khtml/ecma/kjs_html.cpp: (KJS::Image::getValueProperty): Ditto.
        * khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): Ditto.
        * khtml/ecma/kjs_window.h:
        * khtml/ecma/kjs_window.cpp:
        (KJS::Window::getListener): Ditto.
        (KJS::Window::getJSLazyEventListener): Take code as a DOMString, not QString.

        * khtml/ecma/kjs_events.cpp:
        (KJS::jsStringOrUndefined): Renamed function and moved it to the top of the file.
        (KJS::JSAbstractEventListener::handleEvent): Cleaned up function, removed double
        logging, and fixed code path to not use UString::ascii().
        (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): Updated since type
        of the window object is now Window.
        (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): Ditto.
        (KJS::JSUnprotectedEventListener::windowObj): Ditto.
        (KJS::JSEventListener::JSEventListener): Ditto.
        (KJS::JSEventListener::~JSEventListener): Ditto.
        (KJS::JSEventListener::windowObj): Ditto.
        (KJS::JSLazyEventListener::JSLazyEventListener): Ditto. Also changed code to be
        a DOMString instead of a QString.
        (KJS::JSLazyEventListener::handleEvent): Removed function because the base class
        handleEvent already calls listenerObj which takes care of parseCode -- no need to
        do an additional parseCode here.
        (KJS::JSLazyEventListener::parseCode): Rearrange and clean up a bit. Code is now
        a DOMString instead of a QString.
        (KJS::Clipboard::Clipboard): Remove explicit ref since we now use a RefPtr for
        the clipboard object.
        (KJS::Clipboard::getValueProperty): Update to call jsStringOrUndefined.

        * khtml/ecma/kjs_events.h: Reformatted the file. Changed windowObj functions to
        return Window* instead of ObjectImp*. Removed listenerObjImp function. Removed
        destructors from many classes that don't need them. Used a RefPtr for the
        ClipboardImpl in a Clipboard object.

        * khtml/ecma/kjs_proxy.h:
        * khtml/ecma/kjs_proxy.cpp:
        (KJSProxyImpl::evaluate): Take filename and code as DOMString instead of QString.
        (KJSProxyImpl::createHTMLEventHandler): Take URL and code as DOMString.

        * khtml/xml/dom_docimpl.h:
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::createHTMLEventListener): Take a DOMString rather than a QString for the
        JavaScript code.
        (DocumentImpl::setHTMLWindowEventListener): Added an overload that takes an attribute
        pointer. Calls through after extracting the code from the attribute value.

        * khtml/html/html_elementimpl.h:
        * khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setHTMLEventListener): New
        version of function that takes an attribute pointer; calls through to the base class
        after extracting the code from the attribute value.

        * khtml/html/html_baseimpl.cpp:
        (HTMLBodyElementImpl::parseMappedAttribute): Change to use new setHTMLWindowEventListener
        and setHTMLEventListener that takes an attribute pointer.
        (HTMLFrameElementImpl::parseMappedAttribute): Ditto.
        (HTMLFrameSetElementImpl::parseMappedAttribute): Ditto.
        * khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Ditto.
        * khtml/html/html_formimpl.cpp:
        (DOM::HTMLFormElementImpl::parseMappedAttribute): Ditto.
        (DOM::HTMLButtonElementImpl::parseMappedAttribute): Ditto.
        (DOM::HTMLInputElementImpl::parseMappedAttribute): Ditto.
        (DOM::HTMLLabelElementImpl::parseMappedAttribute): Ditto.
        (DOM::HTMLSelectElementImpl::parseMappedAttribute): Ditto.
        (DOM::HTMLTextAreaElementImpl::parseMappedAttribute): Ditto.
        * khtml/html/html_imageimpl.cpp:
        (DOM::HTMLImageElementImpl::parseMappedAttribute): Ditto.
        * khtml/html/html_objectimpl.cpp:
        (DOM::HTMLObjectElementImpl::parseMappedAttribute): Ditto.

        * khtml/html/html_headimpl.h:
        * khtml/html/html_headimpl.cpp:
        (HTMLScriptElementImpl::notifyFinished): Don't convert URL to QString since we now take
        a DOMString.
        (HTMLScriptElementImpl::evaluateScript): Change to take script as a DOMString.

        * khtml/khtml_part.h:
        * khtml/khtml_part.cpp: (KHTMLPart::createHTMLEventListener): Take a DOMString rather than
        a QString for the JavaScript code.

        * kwq/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]): Change
        code path so it doesn't convert an NSString to UTF-8 to get it into the JavaScript
        machinery. Use QString::fromNSString instead for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - fix crash caused by my last check-in
darin [Fri, 16 Dec 2005 07:51:12 +0000 (07:51 +0000)]
    - fix crash caused by my last check-in

        * khtml/ecma/domparser.cpp: (KJS::DOMParserProtoFunc::callAsFunction):
        Use RefPtr to ref/deref the tokenizer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::exitText):
darin [Fri, 16 Dec 2005 07:28:02 +0000 (07:28 +0000)]
    * khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::exitText):
        Add missing null check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fixed <rdar://problem/4381444> Remove GMail-specific work-around
ggaren [Fri, 16 Dec 2005 06:39:57 +0000 (06:39 +0000)]
    Fixed <rdar://problem/4381444> Remove GMail-specific work-around
        previously added.

        Reviewed by Darin.

        No test case because this patch just turns on already-tested behavior
        for GMail.

        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLElement::textAreaGetter): Removed code that hid the
        selectionEnd property from sites on the GMail domain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Eric.
darin [Fri, 16 Dec 2005 06:33:36 +0000 (06:33 +0000)]
    Reviewed by Eric.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6092
          REGRESSION: dom/xhtml/level2/html//HTMLInputElement01.xhtml crashes

        * khtml/xml/xml_tokenizer.cpp:
        (khtml::XMLTokenizer::XMLTokenizer): Initialize the new m_currentNodeIsReferenced
        field to false for the document case, and true for the non-0 fragment case. Also
        don't reference the document in the document tokenizer case to avoid a circular
        reference -- HTML parser already does both of these things.
        (khtml::XMLTokenizer::~XMLTokenizer): Call setCurrentNode(0) to release the current
        node in case the tokenizer is being destroyed without finishing parsing. Only call
        deref on the document inthe fragment-parsing case.
        (khtml::XMLTokenizer::setCurrentNode): Added. Reference the current node only if
        it's not the document. Just as with the HTML parser, use a boolean to track whether
        the current node needs a deref or not.
        (khtml::XMLTokenizer::startElementNs): Use a RefPtr to keep the newly created element
        alive at least until setCurrentNode is called. Remove the bogus explicit delete of
        of the node after calling addChild, since reference counting takes care of it.
        Stop parsing if we fail to create an element.
        (khtml::XMLTokenizer::endElementNs): Use setCurrentNode and use a local variable
        to avoid reference count thrash.
        (khtml::XMLTokenizer::characters): Changed to only support text nodes. CDATA no
        longer calls this function.
        (khtml::XMLTokenizer::enterText): Use setCurrentNode, and remove bogus delete call.
        (khtml::XMLTokenizer::exitText): Add checks for stopped parser and for whether
        the current node is a text node so this can be called unconditionally.
        (khtml::XMLTokenizer::cdataBlock): Use setCurrentNode and move the call before the
        call to attach to make sure the node is already ref'd when attach is called.
        (khtml::XMLTokenizer::finish): Call setCurrentNode(0) to release the nodes we've
        been parsing.
        (khtml::XMLTokenizer::executeScripts): Fixed incorrect cast to TextImpl to cast to
        the base class CharacterDataImpl instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: none
eseidel [Fri, 16 Dec 2005 02:30:14 +0000 (02:30 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: tim hatcher
Made SVG on by default!
        Also removed last two KHTML_NO_CPLUSPLUS_DOM #ifs and turned off.
        Removed APPLE_COMPILE_HACK, fixing or replacing with #if 0 for now.

        * WebCore.xcodeproj/project.pbxproj: Made SVG default!
        * ksvg2/KSVGSettings.cpp: Removed.
        * ksvg2/css/SVGCSSStyleSelector.cpp: fixed copyright.
        * ksvg2/svg/SVGCursorElementImpl.cpp:
        (SVGCursorElementImpl::notifyFinished): fixed
        * ksvg2/svg/SVGElementImpl.cpp:
        (SVGElementImpl::parseMappedAttribute): removed dead code.
        * ksvg2/svg/SVGImageElementImpl.cpp:
        (SVGImageElementImpl::createRenderer): #if 0
        (SVGImageElementImpl::notifyFinished): #if 0
        * ksvg2/svg/SVGSVGElementImpl.cpp:
        (SVGSVGElementImpl::pixelUnitToMillimeterX): #if 0
        (SVGSVGElementImpl::pixelUnitToMillimeterY): #if 0
        * kwq/DOM.mm: removed KHTML_NO_CPLUSPLUS_DOM
        * kwq/KWQKHTMLPart.mm: removed KHTML_NO_CPLUSPLUS_DOM

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: none
eseidel [Fri, 16 Dec 2005 02:21:27 +0000 (02:21 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: tim h
        * Scripts/build-webkit: --svg is now default!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: none
eseidel [Fri, 16 Dec 2005 02:16:30 +0000 (02:16 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: mjs
        Don't run svg test automatically if +SVG is built (yet).

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #:
eseidel [Fri, 16 Dec 2005 00:08:32 +0000 (00:08 +0000)]
Bug #:
Submitted by: eseidel
Reviewed by: none
Fix build break.  (Files missed in previous commit.)

        * khtml/css/csshelper.cpp:
        * khtml/ecma/kjs_navigator.cpp:
        * khtml/rendering/render_canvasimage.cpp:
        * khtml/rendering/render_image.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
adele [Thu, 15 Dec 2005 23:40:37 +0000 (23:40 +0000)]

        Test for <rdar://problem/4258232> Crash in HTMLOptionElementImpl::index when option element has no corresponding select - http://www.mattkruse.com/javascript/datadumper/

        * fast/forms/option-index-expected.checksum: Added.
        * fast/forms/option-index-expected.png: Added.
        * fast/forms/option-index-expected.txt: Added.
        * fast/forms/option-index.html: Added.


        Reviewed by John.

        - Fix for <rdar://problem/4258232> Crash in HTMLOptionElementImpl::index when option element has no corresponding select - http://www.mattkruse.com/javascript/datadumper/

        Test: fast/forms/option-index.html

        * khtml/html/html_formimpl.cpp:
        (DOM::HTMLOptionElementImpl::index): nil check for select element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6091
eseidel [Thu, 15 Dec 2005 22:31:55 +0000 (22:31 +0000)]
Bug #: 6091
Submitted by: eseidel
Reviewed by: darin
        Remove more legacy code from khtml/kwq

        No tests needed, no functionality changes.

        * ForwardingHeaders/kapplication.h: Removed.
        * ForwardingHeaders/kcompletionbox.h: Removed.
        * ForwardingHeaders/kdatastream.h: Removed.
        * ForwardingHeaders/kfiledialog.h: Removed.
        * ForwardingHeaders/kfileitem.h: Removed.
        * ForwardingHeaders/khtml_iface.h: Removed.
        * ForwardingHeaders/khtml_pagecache.h: Removed.
        * ForwardingHeaders/khtml_printsettings.h: Removed.
        * ForwardingHeaders/khtml_run.h: Removed.
        * ForwardingHeaders/kiconloader.h: Removed.
        * ForwardingHeaders/kio/kprotocolmanager.h: Removed.
        * ForwardingHeaders/kio/netaccess.h: Removed.
        * ForwardingHeaders/kmessagebox.h: Removed.
        * ForwardingHeaders/kmimetype.h: Removed.
        * ForwardingHeaders/kmultipledrag.h: Removed.
        * ForwardingHeaders/kparts/partmanager.h: Removed.
        * ForwardingHeaders/kprinter.h: Removed.
        * ForwardingHeaders/kprotocolmanager.h: Removed.
        * ForwardingHeaders/ksimpleconfig.h: Removed.
        * ForwardingHeaders/ksslcertchain.h: Removed.
        * ForwardingHeaders/ksslinfodlg.h: Removed.
        * ForwardingHeaders/kstdaction.h: Removed.
        * ForwardingHeaders/ktempfile.h: Removed.
        * ForwardingHeaders/ktrader.h: Removed.
        * ForwardingHeaders/kurldrag.h: Removed.
        * ForwardingHeaders/kxmlguifactory.h: Removed.
        * ForwardingHeaders/netaccess.h: Removed.
        * ForwardingHeaders/private/qucomextra_p.h: Removed.
        * ForwardingHeaders/qasyncimageio.h: Removed.
        * ForwardingHeaders/qbitmap.h: Removed.
        * ForwardingHeaders/qclipboard.h: Removed.
        * ForwardingHeaders/qdir.h: Removed.
        * ForwardingHeaders/qdrawutil.h: Removed.
        * ForwardingHeaders/qfontdatabase.h: Removed.
        * ForwardingHeaders/qfontinfo.h: Removed.
        * ForwardingHeaders/qglobal.h: Removed.
        * ForwardingHeaders/qhbox.h: Removed.
        * ForwardingHeaders/qinputdialog.h: Removed.
        * ForwardingHeaders/qintcache.h: Removed.
        * ForwardingHeaders/qmetaobject.h: Removed.
        * ForwardingHeaders/qmovie.h: Removed.
        * ForwardingHeaders/qobjectlist.h: Removed.
        * ForwardingHeaders/qtooltip.h: Removed.
        * ForwardingHeaders/scheduler.h: Removed.
        * WebCore.xcodeproj/project.pbxproj:
        * khtml/css/cssstyleselector.cpp:
        * khtml/ecma/kjs_proxy.cpp:
        * khtml/ecma/kjs_window.cpp:
        * khtml/ecma/kjs_window.moc: Removed.
        * khtml/html/html_documentimpl.cpp:
        * khtml/html/html_documentimpl.moc: Removed.
        * khtml/html/html_formimpl.cpp:
        * khtml/html/html_formimpl.h:
        * khtml/html/html_objectimpl.cpp:
        * khtml/html/html_objectimpl.h:
        * khtml/html/htmltokenizer.moc: Removed.
        * khtml/khtml_part.cpp:
        * khtml/khtml_part.h:
        * khtml/khtml_part.moc: Removed.
        * khtml/khtmlpart_p.h:
        * khtml/khtmlview.cpp:
        * khtml/khtmlview.h:
        * khtml/khtmlview.moc: Removed.
        * khtml/misc/loader.cpp:
        * khtml/misc/loader.h:
        * khtml/misc/loader.moc: Removed.
        * khtml/rendering/render_form.cpp:
        * khtml/rendering/render_form.h:
        * khtml/rendering/render_form.moc: Removed.
        * khtml/rendering/render_frames.cpp:
        * khtml/rendering/render_frames.moc: Removed.
        * khtml/rendering/render_layer.cpp:
        * khtml/rendering/render_replaced.cpp:
        * khtml/rendering/render_replaced.moc: Removed.
        * khtml/xml/dom_docimpl.cpp:
        * khtml/xml/dom_docimpl.moc: Removed.
        * khtml/xml/xml_tokenizer.cpp:
        * khtml/xml/xml_tokenizer.moc: Removed.
        * ksvg2/svg/SVGImageElementImpl.cpp:
        * kwq/KWQApplication.h:
        * kwq/KWQComboBox.h:
        * kwq/KWQKApplication.h: Removed.
        * kwq/KWQKHTMLPageCache.h: Removed.
        * kwq/KWQKHTMLPart.mm:
        * kwq/KWQKHTMLPartBrowserExtension.h:
        * kwq/KWQKHistoryProvider.mm:
        * kwq/KWQKJavaAppletContext.h:
        * kwq/KWQKPartsHistoryProvider.h:
        * kwq/KWQKPartsPartManager.h: Removed.
        * kwq/KWQMovie.h: Removed.
        * kwq/KWQMovie.mm: Removed.
        * kwq/KWQObject.h:
        * kwq/KWQScrollView.h:
        * kwq/KWQScrollView.mm:
        * kwq/KWQWidget.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Thu, 15 Dec 2005 22:17:58 +0000 (22:17 +0000)]
    Reviewed by Darin.

- remove _frameForView: method from WebView and replace with a direct pointer on the WebFrameView in the WebFrame

        * Misc.subproj/WebNSViewExtras.m:
        * WebView.subproj/WebFrame.m:
        (-[WebFrame _detachFromParent]):
        (-[WebFrame _loadDataSource:withLoadType:formState:]):
        (-[WebFrame initWithName:webFrameView:webView:]):
        * WebView.subproj/WebFrameView.m:
        (-[WebFrameView _setWebFrame:]):
        (-[WebFrameView webFrame]):
        * WebView.subproj/WebFrameViewInternal.h:
        * WebView.subproj/WebView.m:
        * WebView.subproj/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6094
eseidel [Thu, 15 Dec 2005 21:39:57 +0000 (21:39 +0000)]
Bug #: 6094
Submitted by: eseidel
Reviewed by: darin
        khtml/css should use RefPtr instead of manual ref() deref()

        No functionality changes, thus no tests.

        * khtml/css/css_computedstyle.cpp:
        * khtml/css/css_ruleimpl.cpp:
        * khtml/css/css_ruleimpl.h:
        * khtml/css/css_stylesheetimpl.cpp:
        * khtml/css/css_stylesheetimpl.h:
        * khtml/css/css_valueimpl.cpp:
        * khtml/css/css_valueimpl.h:
        * khtml/css/cssparser.cpp:
        * khtml/css/cssstyleselector.cpp:
        * khtml/xsl/xslt_processorimpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoLayoutTests:
adele [Thu, 15 Dec 2005 21:06:50 +0000 (21:06 +0000)]

        Test for <rdar://problem/4381360>, http://bugzilla.opendarwin.org/show_bug.cgi?id=6100
        REGRESSION: Focus ring on contenteditable div outlines text in overflow area instead of div (6100)

        * fast/overflow/overflow-focus-ring-expected.checksum: Added.
        * fast/overflow/overflow-focus-ring-expected.png: Added.
        * fast/overflow/overflow-focus-ring-expected.txt: Added.
        * fast/overflow/overflow-focus-ring.html: Added.


        Reviewed by Darin and Hyatt.

        Fixed <rdar://problem/4381360> REGRESSION: Focus ring on contenteditable div outlines text in overflow area instead of div (6100)

        Test: fast/overflow/overflow-focus-ring.html

        * khtml/rendering/render_flow.cpp:
        (RenderFlow::addFocusRingRects): For overflow, we don't need to compute the rects for the children.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Tim Hatcher.
darin [Thu, 15 Dec 2005 20:20:01 +0000 (20:20 +0000)]
    Reviewed by Tim Hatcher.

        - removed unnecessary conversion between AtomicString and QString

        * khtml/html/html_headimpl.cpp:
        (HTMLScriptElementImpl::parseMappedAttribute): Remove extra conversions.
        (HTMLScriptElementImpl::insertedIntoDocument): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #:
hyatt [Thu, 15 Dec 2005 19:37:21 +0000 (19:37 +0000)]
Bug #:
Submitted by:
Reviewed by:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * Scripts/run-webkit-tests: Don't run tests in directories named "svg" if SVG
darin [Thu, 15 Dec 2005 17:42:19 +0000 (17:42 +0000)]
    * Scripts/run-webkit-tests: Don't run tests in directories named "svg" if SVG
        support is not compiled in. Report the 10 slowest tests if "--slowest" is
        passed on the command line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - updated test result -- this test now succeeds due to some recent change
darin [Thu, 15 Dec 2005 17:14:22 +0000 (17:14 +0000)]
    - updated test result -- this test now succeeds due to some recent change

        * dom/xhtml/level2/html/HTMLTextAreaElement12-expected.txt: Regenerated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by NOBODY (OOPS!).
adele [Thu, 15 Dec 2005 04:29:52 +0000 (04:29 +0000)]
    Reviewed by NOBODY (OOPS!).

        - fixed <rdar://problem/4375502> 10.4.4 REGRESSION: Clicking on anchor tag in email causes unwanted horizontal scroll

        When scrolling views, we were failing to take the current scroll position into account when calculating the new scroll position.

        * kwq/KWQScrollView.h: Added scrollPointRecursively.
        * kwq/KWQScrollView.mm:
        (QScrollView::scrollXOffset): Calculates the x-coordinate scroll offset for a view.
        (QScrollView::scrollYOffset): Calculates the y-coordinate scroll offset for a view.
        (QScrollView::scrollPointRecursively): This function walks up the view hierarchy to scroll to a point.
        I moved this from setContentsPos so that function would only have an effect on the current view.
        (QScrollView::setContentsPos): return to old behavior where this function calls scrollPoint on a view and doesn't recurse.

        * khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollRectToVisible):
        Uses new QScrollView functions scrollXOffset and scrollYOffset to correctly calculate how a view should scroll.
        Also determines whether or not QScrollView should try to scroll recursively (which happens when scrollRectToVisible is done calling itself recursively).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 6078
eseidel [Wed, 14 Dec 2005 23:32:02 +0000 (23:32 +0000)]
Bug #: 6078
Submitted by: eseidel
Reviewed by: darin
        SVG test cases changed (now the svg.css is loaded properly).
        No other functionality changes, just code removal.

        * ForwardingHeaders/klibloader.h: Removed.
        * WebCore.xcodeproj/project.pbxproj:
        * khtml/css/csshelper.cpp:
        * khtml/css/cssstyleselector.cpp:
        * khtml/css/cssstyleselector.h:
        * khtml/ecma/kjs_dom.h:
        * khtml/ecma/kjs_events.cpp:
        * khtml/ecma/kjs_events.h:
        * khtml/ecma/kjs_html.cpp:
        * khtml/ecma/kjs_navigator.cpp:
        * khtml/ecma/kjs_proxy.cpp:
        * khtml/ecma/kjs_proxy.h:
        * khtml/ecma/kjs_traversal.cpp:
        * khtml/ecma/kjs_window.cpp:
        * khtml/ecma/kjs_window.h:
        * khtml/html/html_canvasimpl.cpp:
        * khtml/html/html_documentimpl.cpp:
        * khtml/html/html_formimpl.cpp:
        * khtml/html/html_headimpl.cpp:
        * khtml/html/html_imageimpl.cpp:
        * khtml/html/html_tableimpl.cpp:
        * khtml/html/htmltokenizer.cpp:
        * khtml/khtml_part.cpp:
        * khtml/khtml_part.h:
        * khtml/khtmlpart_p.h:
        * khtml/misc/decoder.cpp:
        * khtml/misc/loader.cpp:
        * khtml/rendering/render_flow.cpp:
        * khtml/rendering/render_frames.cpp:
        * khtml/rendering/render_inline.cpp:
        * khtml/rendering/render_line.cpp:
        * khtml/rendering/render_table.cpp:
        * khtml/rendering/table_layout.cpp:
        * khtml/xml/dom_docimpl.cpp:
        * khtml/xml/dom_nodeimpl.cpp:
        * ksvg2/svg/SVGTestsImpl.cpp:
        * kwq/DOMInternal.mm:
        (-[WebScriptObject _initializeScriptDOMNodeImp]):
        * kwq/KWQKGlobal.h:
        * kwq/KWQKHTMLFactory.h:
        * kwq/KWQKHTMLFactory.mm:
        * kwq/KWQKHTMLPart.mm:
        * kwq/KWQKHTMLSettings.h:
        * kwq/KWQKInstance.h: Removed.
        * kwq/KWQKLibrary.h: Removed.
        * kwq/KWQKPartsFactory.h: Removed.
        * kwq/KWQKPartsPart.h:
        * kwq/KWQKStandardDirs.h:
        * kwq/KWQKStandardDirs.mm:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge executionContextForView:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@11588 268f45cc-cd09-0410-ab3c-d52691b4dbfc