WebKit-https.git
10 years agoMade show-pretty-diff work when the input path contains spaces.
mitz@apple.com [Sun, 6 Nov 2011 17:22:14 +0000 (17:22 +0000)]
Made show-pretty-diff work when the input path contains spaces.

Reviewed by Anders Carlsson.

* Scripts/show-pretty-diff:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoValue profiling should just use two buckets
fpizlo@apple.com [Sun, 6 Nov 2011 11:54:59 +0000 (11:54 +0000)]
Value profiling should just use two buckets
https://bugs.webkit.org/show_bug.cgi?id=71619

Reviewed by Gavin Barraclough.

Added one more configuration options (like Heuristics::minimumOptimizationDelay),
improved debugging in JIT optimization support, changed the number of buckets
in the value profile from 9 to 2, and wrote a more optimal value profiling path
in the old JIT to take advantage of this. It's still possible to play around with
larger numbers of buckets, and we should probably keep this for a little while
until we convince ourselves that using just two buckets is the right call.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shouldOptimizeNow):
* bytecode/ValueProfile.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
* runtime/Heuristics.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJSC should be able to sample itself in a more flexible way than just sampling flags
fpizlo@apple.com [Sun, 6 Nov 2011 11:39:12 +0000 (11:39 +0000)]
JSC should be able to sample itself in a more flexible way than just sampling flags
https://bugs.webkit.org/show_bug.cgi?id=71522

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Added a construct that looks like SamplingRegion samplingRegion("name").

* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/SamplingTool.cpp:
(JSC::SamplingRegion::Locker::Locker):
(JSC::SamplingRegion::Locker::~Locker):
(JSC::SamplingRegion::sample):
(JSC::SamplingRegion::dump):
(JSC::SamplingRegion::dumpInternal):
(JSC::SamplingThread::threadStartFunc):
* bytecode/SamplingTool.h:
(JSC::SamplingRegion::SamplingRegion):
(JSC::SamplingRegion::~SamplingRegion):
(JSC::SamplingRegion::exchangeCurrent):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* heap/Heap.cpp:
(JSC::Heap::markRoots):
(JSC::Heap::collect):
* heap/VTableSpectrum.cpp:
(JSC::VTableSpectrum::countVPtr):
(JSC::VTableSpectrum::dump):
* heap/VTableSpectrum.h:
* jsc.cpp:
(main):
(runWithScripts):
* parser/Parser.h:
(JSC::parse):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* wtf/Atomics.h:
(WTF::weakCompareAndSwap):
* wtf/Platform.h:
* wtf/Spectrum.h: Added.
(WTF::Spectrum::Spectrum):
(WTF::Spectrum::add):
(WTF::Spectrum::get):
(WTF::Spectrum::begin):
(WTF::Spectrum::end):
(WTF::Spectrum::KeyAndCount::KeyAndCount):
(WTF::Spectrum::KeyAndCount::operator<):
(WTF::Spectrum::buildList):
* wtf/wtf.pri:

Source/JavaScriptGlue:

Reviewed by Gavin Barraclough.

* ForwardingHeaders/wtf/Spectrum.h: Added.

Source/WebCore:

Reviewed by Gavin Barraclough.

No new tests, since no functionality changed.

* ForwardingHeaders/wtf/Spectrum.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening.
hausmann@webkit.org [Sun, 6 Nov 2011 11:04:17 +0000 (11:04 +0000)]
[Qt] Unreviewed gardening.

Skip paged wheel events for Qt, as we don't support them yet.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Unindent edited text by pressing Shift + Tab
commit-queue@webkit.org [Sun, 6 Nov 2011 07:23:18 +0000 (07:23 +0000)]
Web Inspector: Unindent edited text by pressing Shift + Tab
https://bugs.webkit.org/show_bug.cgi?id=70181

Indent and unindent text in all selected lines.

Patch by Nikita Vasilyev <me@elv1s.ru> on 2011-11-06
Reviewed by Pavel Feldman.

* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype.unindentLines.get var):
(WebInspector.TextEditorMainPanel.prototype.unindentLines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip a newly failing test and reclassify some missing DRT features.
mrobinson@webkit.org [Sun, 6 Nov 2011 06:10:16 +0000 (06:10 +0000)]
Skip a newly failing test and reclassify some missing DRT features.

* platform/gtk/Skipped: Update skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove ContextShadow
mrobinson@webkit.org [Sun, 6 Nov 2011 05:33:06 +0000 (05:33 +0000)]
Remove ContextShadow
https://bugs.webkit.org/show_bug.cgi?id=71617

Reviewed by Ariya Hidayat.

No new tests. This patch does not change behavior.

Completely remove ContextShadow. It's unused, unmaintained, and
replaced by ShadowBlur.

* WebCore.gypi: Remove references to deleted files.
* WebCore.vcproj/WebCore.vcproj: Remove references to deleted files.
* platform/graphics/ContextShadow.cpp: Removed.
* platform/graphics/ContextShadow.h: Removed.
* platform/gtk/WidgetRenderingContext.cpp: Remove now-inaccurate TODO.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDragging a file onto <input type="file"> should give distinct visual feedback
jonlee@apple.com [Sun, 6 Nov 2011 04:27:39 +0000 (04:27 +0000)]
Dragging a file onto <input type="file"> should give distinct visual feedback
https://bugs.webkit.org/show_bug.cgi?id=13897
<rdar://problem/5232483>

Reviewed by Dan Bernstein.

When hovering over a file input element, we set the button's state to active
to differentiate dragging one file over the input element (which populates that
element) versus over the document (which would load the file into the view).

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::canReceiveDroppedFiles):
(WebCore::HTMLInputElement::setCanReceiveDroppedFiles): If set, the element
is updated, which sets the active state on the button control.
* html/HTMLInputElement.h: Add a boolean member representing whether the file
input can receive dropped files.
* page/DragController.cpp:
(WebCore::DragController::DragController): Update/set the file input that
can receive dropped files.
(WebCore::DragController::dragExited):
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):
* page/DragController.h:
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::updateFromElement): Sets the button active
state if the input can receive dropped files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Use the security origin instead of the URL when checking notification...
dcheng@chromium.org [Sun, 6 Nov 2011 04:14:58 +0000 (04:14 +0000)]
[chromium] Use the security origin instead of the URL when checking notification permissions
https://bugs.webkit.org/show_bug.cgi?id=71590

Reviewed by Adam Barth.

Source/WebKit/chromium:

* public/WebNotificationPresenter.h:
* src/NotificationPresenterImpl.cpp:
(WebKit::NotificationPresenterImpl::checkPermission):

Tools:

* DumpRenderTree/chromium/NotificationPresenter.cpp:
(NotificationPresenter::checkPermission):
* DumpRenderTree/chromium/NotificationPresenter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImprove pending resource hash table code, including fixing a memory leak
darin@apple.com [Sun, 6 Nov 2011 02:26:43 +0000 (02:26 +0000)]
Improve pending resource hash table code, including fixing a memory leak
https://bugs.webkit.org/show_bug.cgi?id=71616

Reviewed by Adam Roben.

Memory leak fix and refactoring covered by existing tests.

* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::addPendingResource): Replace the combination
of contains, get, and add with just add, removing an extra unneeded hash table
lookup each time this function is called.
(WebCore::SVGDocumentExtensions::isElementInPendingResources): Added a comment
about the performance of this function. Removed unnecessary check for an empty
map; the code already efficiently exits doing nothing without the check.
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources): Removed
unnecessary check for an empty map; the code already efficiently does nothing
without the check. Use removePendingResource rather than calling remove to
avoid leaking the SVGPendingElements set.
(WebCore::SVGDocumentExtensions::removePendingResource): Replace the
combination of get and remove with a call to take, removing an extra
unneeded hash table lookup each time this function is called

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a small leak in Mac version of LayoutTestController
darin@apple.com [Sun, 6 Nov 2011 01:07:26 +0000 (01:07 +0000)]
Fix a small leak in Mac version of LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=71615

Reviewed by Mark Rowe.

* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
(LayoutTestController::localStorageDiskUsageForOrigin): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnskip some tests on GTK+ that seem to be passing.
mrobinson@webkit.org [Sun, 6 Nov 2011 00:56:35 +0000 (00:56 +0000)]
Unskip some tests on GTK+ that seem to be passing.

* platform/gtk/Skipped: Unskip tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Actually use the user_data arguments to gio async functions
commit-queue@webkit.org [Sun, 6 Nov 2011 00:50:36 +0000 (00:50 +0000)]
[GTK] Actually use the user_data arguments to gio async functions
instead of using g_object_set_data() to basically reinvent them.
https://bugs.webkit.org/show_bug.cgi?id=71614

Patch by Dan Winship <danw@gnome.org> on 2011-11-05
Reviewed by Martin Robinson.

No new tests; behavior is unchanged

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::cleanupSoupRequestOperation):
(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::closeCallback):
(WebCore::readCallback):
(WebCore::startNonHTTPRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Don't unnecessarily 0-initialize read buffers.
commit-queue@webkit.org [Sun, 6 Nov 2011 00:39:30 +0000 (00:39 +0000)]
[GTK] Don't unnecessarily 0-initialize read buffers.
https://bugs.webkit.org/show_bug.cgi?id=71612

Patch by Dan Winship <danw@gnome.org> on 2011-11-05
Reviewed by Martin Robinson.

No new tests; behavior is unchanged

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sendRequestCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Remove a bit of dead code
commit-queue@webkit.org [Sun, 6 Nov 2011 00:37:12 +0000 (00:37 +0000)]
[GTK] Remove a bit of dead code
https://bugs.webkit.org/show_bug.cgi?id=71613

Patch by Dan Winship <danw@gnome.org> on 2011-11-05
Reviewed by Martin Robinson.

No new tests; behavior is unchanged

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::readCallback): the caller that needed the convertToUTF16
code was removed in r77408, but the code was accidentally left
behind.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Frame flattening tests are super-flaky after switching to backing store-based...
mrobinson@webkit.org [Sun, 6 Nov 2011 00:34:51 +0000 (00:34 +0000)]
[GTK] Frame flattening tests are super-flaky after switching to backing store-based painting
https://bugs.webkit.org/show_bug.cgi?id=71576

Reviewed by Antonio Gomes.

Instead of waiting until <body onload> to toggle the frame flattening
setting. Toggle is as soon as possible. This fixes an issue where
layouts that happen before the onload event lead to flaky results.

* fast/frames/flattening/frameset-flattening-advanced.html:
* fast/frames/flattening/frameset-flattening-grid.html:
* fast/frames/flattening/frameset-flattening-simple.html:
* fast/frames/flattening/frameset-flattening-subframe-resize.html:
* fast/frames/flattening/frameset-flattening-subframesets.html:
* fast/frames/flattening/iframe-flattening-crash.html:
* fast/frames/flattening/iframe-flattening-fixed-height.html:
* fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
* fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html:
* fast/frames/flattening/iframe-flattening-fixed-width-and-height.html:
* fast/frames/flattening/iframe-flattening-fixed-width.html:
* fast/frames/flattening/iframe-flattening-nested.html:
* fast/frames/flattening/iframe-flattening-offscreen.html:
* fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html:
* fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html:
* fast/frames/flattening/iframe-flattening-out-of-view.html:
* fast/frames/flattening/iframe-flattening-selection-crash.html:
* fast/frames/flattening/iframe-flattening-simple.html:
* platform/gtk/Skipped: Unskip tests which are no longer flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Frame flattening tests are super-flaky after switching to backing store-based...
mrobinson@webkit.org [Sat, 5 Nov 2011 23:45:57 +0000 (23:45 +0000)]
[GTK] Frame flattening tests are super-flaky after switching to backing store-based painting
https://bugs.webkit.org/show_bug.cgi?id=71576

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-11-05
Reviewed by Martin Robinson.

Skip frame flattening tests. These became flaky after backing store for
painting was introduced for the GTK port in r98827.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefactor sandbox flag calculation to make implementing CSP sandbox directive easier
abarth@webkit.org [Sat, 5 Nov 2011 21:55:59 +0000 (21:55 +0000)]
Refactor sandbox flag calculation to make implementing CSP sandbox directive easier
https://bugs.webkit.org/show_bug.cgi?id=71603

Reviewed by Sam Weinig.

This patch changes the way we compute sandbox bits.  Instead of caching
the result on Frame, we always compute the sandbox bits for a new
document fresh from the inputs to the process (the sandbox attribute
and the forced sandbox flags).

This patch is just refactoring.  It shouldn't have an observable
effects.  This patch makes it easier to implement CSP's sandbox
directive in a subsequent patch.

* dom/Document.cpp:
(WebCore::Document::initSecurityContext):
* html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::setSandboxFlags):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::init):
(WebCore::FrameLoader::effectiveSandboxFlags):
(WebCore::createWindow):
* loader/FrameLoader.h:
(WebCore::FrameLoader::forceSandboxFlags):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix windows build.
weinig@apple.com [Sat, 5 Nov 2011 20:37:05 +0000 (20:37 +0000)]
Fix windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReduce the number of putWithAttributes
weinig@apple.com [Sat, 5 Nov 2011 20:29:01 +0000 (20:29 +0000)]
Reduce the number of putWithAttributes
https://bugs.webkit.org/show_bug.cgi?id=71597

Reviewed by Adam Roben.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Remove exports of removed functions.

* runtime/JSActivation.cpp:
(JSC::JSActivation::putWithAttributes):
Calling the overload without the extra parameters does the same thing.

* runtime/JSObject.cpp:
(JSC::JSObject::putWithAttributes):
* runtime/JSObject.h:
Remove four unused JSObject::putWithAttributes overloads and make one of the remaining
two overloads not virtual, since no one overrides it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnskip a test on GTK+ that doesn't seem to be failing on the bots
mrobinson@webkit.org [Sat, 5 Nov 2011 18:16:51 +0000 (18:16 +0000)]
Unskip a test on GTK+ that doesn't seem to be failing on the bots
or locally.

* platform/gtk/Skipped: Unskip a test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSSStyleDeclaration: Devirtualize isMutableStyleDeclaration().
andreas.kling@nokia.com [Sat, 5 Nov 2011 16:28:28 +0000 (16:28 +0000)]
CSSStyleDeclaration: Devirtualize isMutableStyleDeclaration().
https://bugs.webkit.org/show_bug.cgi?id=71609

Reviewed by Anders Carlsson.

Add a bool member to CSSStyleDeclaration that determines whether
it's a CSSMutableDeclaration.

* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
* css/CSSMutableStyleDeclaration.h:
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
* css/CSSStyleDeclaration.h:
(WebCore::CSSStyleDeclaration::isMutableStyleDeclaration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Simplify InspectorCSSAgent::inlineStyleElement().
andreas.kling@nokia.com [Sat, 5 Nov 2011 16:25:23 +0000 (16:25 +0000)]
Web Inspector: Simplify InspectorCSSAgent::inlineStyleElement().
https://bugs.webkit.org/show_bug.cgi?id=71608

Reviewed by Pavel Feldman.

Use CSSMutableStyleDeclaration::isInlineStyleDeclaration() instead
of doing the same checks manually.

* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::inlineStyleElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReviewed by Andreas Kling.
hausmann@webkit.org [Sat, 5 Nov 2011 14:50:35 +0000 (14:50 +0000)]
Reviewed by Andreas Kling.

Removed duplicated npruntime_internal.h from bindings/v8
in favour of the one from bridge/, which has a few more

https://bugs.webkit.org/show_bug.cgi?id=45617

* bindings/v8/npruntime_internal.h: Removed.
* Target.pri: Removed strange occurence here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove empty and unused dom/PositionCreationFunctions.h header file
hausmann@webkit.org [Sat, 5 Nov 2011 12:15:44 +0000 (12:15 +0000)]
Remove empty and unused dom/PositionCreationFunctions.h header file
https://bugs.webkit.org/show_bug.cgi?id=71552

Reviewed by Kenneth Rohde Christiansen.

The file is empty (0 bytes) and not used anywhere. It was added in
2009 in r48234 but hasn't been touched since then.

* WebCore.gypi:
* dom/PositionCreationFunctions.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix assert after running tests in dumpAsText folders. See
abarth@webkit.org [Sat, 5 Nov 2011 07:00:37 +0000 (07:00 +0000)]
Fix assert after running tests in dumpAsText folders.  See
https://bugs.webkit.org/show_bug.cgi?id=71599 for discussion.  This
patch reverts part of a slightly over-agressive refactoring in
http://trac.webkit.org/changeset/99347.

* dom/Document.cpp:
(WebCore::Document::setIsViewSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate a timing out gpu test.
tony@chromium.org [Sat, 5 Nov 2011 05:50:33 +0000 (05:50 +0000)]
Update a timing out gpu test.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCanvas drawImage(canvas) with SourceIn, DestinationIn, SourceOut, DestinationAtop...
commit-queue@webkit.org [Sat, 5 Nov 2011 01:59:54 +0000 (01:59 +0000)]
Canvas drawImage(canvas) with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
https://bugs.webkit.org/show_bug.cgi?id=71537

Patch by Ben Wells <benwells@chromium.org> on 2011-11-04
Reviewed by Stephen White.

Source/WebCore:

drawImage(canvas) now uses the same approach as drawImage(image) to fix these errors.

Test: fast/canvas/canvas-composite-canvas.html

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::drawImageToContext):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
* html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

* fast/canvas/canvas-composite-canvas-expected.txt: Added.
* fast/canvas/canvas-composite-canvas.html: Added.
* fast/canvas/canvas-composite-image.html:
* fast/canvas/resources/canvas-composite-image-common.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScript URLs execute in sandboxed iframes
abarth@webkit.org [Sat, 5 Nov 2011 01:32:07 +0000 (01:32 +0000)]
JavaScript URLs execute in sandboxed iframes
https://bugs.webkit.org/show_bug.cgi?id=71599

Reviewed by Eric Seidel.

Source/WebCore:

This patch fixes the intentional regression I introduced earlier today
by moving the sandbox bits from SecurityOrigin to Document. In the
process, I renamed SecurityOrigin::createEmpty to
SecurityOrigin::createUnique to better align with HTML5 terminology.

* WebCore.exp.in:
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
* dom/Document.cpp:
(WebCore::Document::setIsViewSource):
(WebCore::Document::initSecurityContext):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::ScriptExecutionContext):
* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::sandboxFlags):
(WebCore::ScriptExecutionContext::enforceSandboxFlags):
(WebCore::ScriptExecutionContext::isSandboxed):
* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::canEmbedJava):
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
* loader/FrameLoader.cpp:
(WebCore::isDocumentSandboxed):
(WebCore::FrameLoader::addHTTPOriginIfNeeded):
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNewWindowPolicy):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestPlugin):
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::create):
(WebCore::SecurityOrigin::createUnique):
* page/SecurityOrigin.h:

LayoutTests:

Update results to show progression.

* fast/frames/sandboxed-iframe-scripting-expected.txt:
* fast/frames/sandboxed-iframe-scripting.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPotential Unused Param Build Issue
commit-queue@webkit.org [Sat, 5 Nov 2011 01:26:31 +0000 (01:26 +0000)]
Potential Unused Param Build Issue
https://bugs.webkit.org/show_bug.cgi?id=71598

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2011-11-04
Reviewed by Kent Tamura.

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpgrade to the latest Mechanize
eric@webkit.org [Sat, 5 Nov 2011 00:58:27 +0000 (00:58 +0000)]
Upgrade to the latest Mechanize
https://bugs.webkit.org/show_bug.cgi?id=71594

Reviewed by Adam Barth.

I noticed our mechanize was somewhat out of date when removing Python 2.5 support.
Mechanize is no longer two separate libraries, so importing it is much simpler.

* Scripts/webkitpy/thirdparty/__init__.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash in ScrollAnimator.cpp
commit-queue@webkit.org [Sat, 5 Nov 2011 00:51:23 +0000 (00:51 +0000)]
Crash in ScrollAnimator.cpp
https://bugs.webkit.org/show_bug.cgi?id=69865

The code in ScrollAnimator assumes that horizontal per-page mouse
wheel events cannot happen, which is not true. This patch adds layout
tests for all paging wheel event situations and fixes the broken
horizontal case.

Source/WebCore:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-04
Reviewed by Anders Carlsson

Tests: fast/events/platform-wheelevent-paging-x-in-non-scrolling-div.html
       fast/events/platform-wheelevent-paging-x-in-non-scrolling-page.html
       fast/events/platform-wheelevent-paging-x-in-scrolling-div.html
       fast/events/platform-wheelevent-paging-x-in-scrolling-page.html
       fast/events/platform-wheelevent-paging-xy-in-scrolling-div.html
       fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html
       fast/events/platform-wheelevent-paging-y-in-non-scrolling-div.html
       fast/events/platform-wheelevent-paging-y-in-non-scrolling-page.html
       fast/events/platform-wheelevent-paging-y-in-scrolling-div.html
       fast/events/platform-wheelevent-paging-y-in-scrolling-page.html

* platform/PlatformWheelEvent.h: Modify the comment to reflect the new
reality.
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent): Modified the code to handle the
horizontal per-page wheel event case.

Tools:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-04
Reviewed by Anders Carlsson

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::handleMouseWheel): Added the ability to specify that a
mouse wheel event should be paging.

LayoutTests:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-04
Reviewed by Anders Carlsson

* fast/events/platform-wheelevent-paging-x-in-non-scrolling-div-expected.txt: Added.
* fast/events/platform-wheelevent-paging-x-in-non-scrolling-div.html: Added.
* fast/events/platform-wheelevent-paging-x-in-non-scrolling-page-expected.txt: Added.
* fast/events/platform-wheelevent-paging-x-in-non-scrolling-page.html: Added.
* fast/events/platform-wheelevent-paging-x-in-scrolling-div-expected.txt: Added.
* fast/events/platform-wheelevent-paging-x-in-scrolling-div.html: Added.
* fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt: Added.
* fast/events/platform-wheelevent-paging-x-in-scrolling-page.html: Added.
* fast/events/platform-wheelevent-paging-xy-in-scrolling-div-expected.txt: Added.
* fast/events/platform-wheelevent-paging-xy-in-scrolling-div.html: Added.
* fast/events/platform-wheelevent-paging-xy-in-scrolling-page-expected.txt: Added.
* fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html: Added.
* fast/events/platform-wheelevent-paging-y-in-non-scrolling-div-expected.txt: Added.
* fast/events/platform-wheelevent-paging-y-in-non-scrolling-div.html: Added.
* fast/events/platform-wheelevent-paging-y-in-non-scrolling-page-expected.txt: Added.
* fast/events/platform-wheelevent-paging-y-in-non-scrolling-page.html: Added.
* fast/events/platform-wheelevent-paging-y-in-scrolling-div-expected.txt: Added.
* fast/events/platform-wheelevent-paging-y-in-scrolling-div.html: Added.
* fast/events/platform-wheelevent-paging-y-in-scrolling-page-expected.txt: Added.
* fast/events/platform-wheelevent-paging-y-in-scrolling-page.html: Added.
* platform/chromium-mac/fast/events/platform-wheelevent-paging-x-in-scrolling-page-expected.txt: Added.
* platform/chromium-mac/fast/events/platform-wheelevent-paging-xy-in-scrolling-page-expected.txt: Added.
* platform/chromium-mac/fast/events/platform-wheelevent-paging-y-in-scrolling-page-expected.txt: Added.
* platform/mac/Skipped: Added skip for the new tests, as the platform
does not support it.
* platform/win/Skipped: Added skip for the new tests, as the platform
does not support it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[MutationObservers] Refactor MutationObserverRegistration into its own class that is
commit-queue@webkit.org [Sat, 5 Nov 2011 00:44:46 +0000 (00:44 +0000)]
[MutationObservers] Refactor MutationObserverRegistration into its own class that is
referenced by registration points

https://bugs.webkit.org/show_bug.cgi?id=71577

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-04
Reviewed by Ojan Vafai.

MutationObserverRegistration is now owned by the node which is observed. If transient
registrations are created, they hold a reference to this object.

The ownership relationship between Node, MutationObserverRegistration &
WebKitMutationObserver now goes like this: WebKitMutationObserver is RefCounted -
and only script and MutationObserverRegistration take references to it. Exactly
one MutationObserverRegistration can exist for any given tuple of
<Node, WebKitMutationObserver>. This represents an observer observing at a given
Node. Further observation by the same observer has the effect of *resetting*
the existing observation. The Node owns the MutationObserverRegistration.
Transient registrations are only pointers to the registration. The registration
keeps a RefPtr to its registration node and all of its transient registration nodes
as long as *any* transient registrations exist. This ensures the registration
and all registration nodes stay alive at least until the end of the microtask.

No tests required - refactor only.

* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/CharacterData.cpp:
(WebCore::enqueueCharacterDataMutationRecord):
* dom/ChildListMutationScope.cpp:
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):
* dom/Element.cpp:
(WebCore::enqueueAttributesMutationRecord):
* dom/MutationObserverRegistration.cpp: Added.
(WebCore::MutationObserverRegistration::create):
(WebCore::MutationObserverRegistration::MutationObserverRegistration):
(WebCore::MutationObserverRegistration::~MutationObserverRegistration):
(WebCore::MutationObserverRegistration::resetObservation):
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
(WebCore::MutationObserverRegistration::clearTransientRegistrations):
(WebCore::MutationObserverRegistration::unregister):
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):
* dom/MutationObserverRegistration.h: Copied from Source/WebCore/dom/WebKitMutationObserver.h.
(WebCore::MutationObserverRegistration::observer):
(WebCore::MutationObserverRegistration::deliveryOptions):
* dom/Node.cpp:
(WebCore::Node::clearRareData):
(WebCore::Node::mutationObserverRegistry):
(WebCore::Node::transientMutationObserverRegistry):
(WebCore::addObserverToDeliverySet):
(WebCore::Node::collectMatchingObserversForMutation):
(WebCore::Node::getRegisteredMutationObserversOfType):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::unregisterMutationObserver):
(WebCore::Node::registerTransientMutationObserver):
(WebCore::Node::unregisterTransientMutationObserver):
(WebCore::Node::notifyMutationObserversNodeWillDetach):
* dom/Node.h:
* dom/NodeRareData.h:
(WebCore::NodeRareData::mutationObserverRegistry):
(WebCore::NodeRareData::ensureMutationObserverRegistry):
(WebCore::NodeRareData::transientMutationObserverRegistry):
(WebCore::NodeRareData::ensureTransientMutationObserverRegistry):
* dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::~WebKitMutationObserver):
(WebCore::WebKitMutationObserver::observe):
(WebCore::WebKitMutationObserver::disconnect):
(WebCore::WebKitMutationObserver::observationStarted):
(WebCore::WebKitMutationObserver::observationEnded):
(WebCore::WebKitMutationObserver::deliver):
* dom/WebKitMutationObserver.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Add methods to compute magnitude and phase response for biquads
commit-queue@webkit.org [Sat, 5 Nov 2011 00:34:25 +0000 (00:34 +0000)]
   Add methods to compute magnitude and phase response for biquads
       https://bugs.webkit.org/show_bug.cgi?id=71055

       Reviewed by Kenneth Russell.

Patch by Raymond Toy <rtoy@google.com> on 2011-11-04

* platform/audio/Biquad.cpp:
(WebCore::Biquad::getFrequencyResponse):
Computes the magnitude and phase (radians) response for the given
biquad at the specified set of (normalized) frequencies.
* platform/audio/Biquad.h:
Declare getFrequencyResponse.
* webaudio/BiquadDSPKernel.cpp:
(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):
Factor out the code that updates filter coefficients.  Allow the
caller to specify whether the smoothed values are used or not and
whether we do the update even if the coefficients are not dirty.
(WebCore::BiquadDSPKernel::process):
Use updateCoefficientsIfNecessary to update.
(WebCore::BiquadDSPKernel::getFrequencyResponse):
Implmentation of getFrequencyResponse.
* webaudio/BiquadDSPKernel.h:
Declare getFrequencyResponse.
* webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::getFrequencyResponse):
Implementation of getFrequencyResponse
* webaudio/BiquadFilterNode.h:
Declare getFrequencyResponse.
* webaudio/BiquadFilterNode.idl:
Define interface to getFrequencyResponse.
* webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::checkForDirtyCoefficients):
Factor out code for checking for dirty coefficients.
(WebCore::BiquadProcessor::process):
Use checkForDirtyCoefficients.
(WebCore::BiquadProcessor::getFrequencyResponse):
Implementation of getFrequencyResponse
* webaudio/BiquadProcessor.h:
Declare getFrequencyResponse.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBaselines for new test introduced in r99043
commit-queue@webkit.org [Sat, 5 Nov 2011 00:29:03 +0000 (00:29 +0000)]
Baselines for new test introduced in r99043
https://bugs.webkit.org/show_bug.cgi?id=71528

Patch by Ben Wells <benwells@chromium.org> on 2011-11-04
Reviewed by Kenneth Russell.

* platform/chromium-cg-mac-snowleopard/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
* platform/chromium-gpu-mac/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
* platform/chromium-gpu-win/fast/canvas/canvas-composite-fill-repaint-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/fast/canvas/canvas-composite-fill-repaint-expected.png.
* platform/chromium-mac-snowleopard/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
* platform/chromium-win/fast/canvas/canvas-composite-fill-repaint-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/canvas/canvas-composite-fill-repaint-expected.png.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove deprecated free functions in port.factory
eric@webkit.org [Sat, 5 Nov 2011 00:27:37 +0000 (00:27 +0000)]
Remove deprecated free functions in port.factory
https://bugs.webkit.org/show_bug.cgi?id=71494

Unreviewed.  Fix exception when running new-run-webkit-httpd.

* Scripts/new-run-webkit-httpd:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Mac] ResourceRequest's nsURLRequest() does not differentiate null and empty URLs...
commit-queue@webkit.org [Sat, 5 Nov 2011 00:02:45 +0000 (00:02 +0000)]
[Mac] ResourceRequest's nsURLRequest() does not differentiate null and empty URLs with CFNetwork
https://bugs.webkit.org/show_bug.cgi?id=71539

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-11-04
Reviewed by David Kilzer.

In order to have CFURL and NSURL to be consistent when both are used on Mac,
KURL::createCFURL() is changed to support empty URL values.

* platform/cf/KURLCFNet.cpp:
(WebCore::createCFURLFromBuffer):
(WebCore::KURL::createCFURL):
* platform/mac/KURLMac.mm:
(WebCore::KURL::operator NSURL *):
(WebCore::KURL::createCFURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agosqrtDouble and andnotDouble should be declared noreturn
psolanki@apple.com [Fri, 4 Nov 2011 23:51:23 +0000 (23:51 +0000)]
sqrtDouble and andnotDouble should be declared noreturn
https://bugs.webkit.org/show_bug.cgi?id=71592

Reviewed by Sam Weinig.

* assembler/MacroAssemblerARMv7.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSS Aspect Ratio Property Parsing Stage
fsamuel@chromium.org [Fri, 4 Nov 2011 23:07:20 +0000 (23:07 +0000)]
CSS Aspect Ratio Property Parsing Stage
https://bugs.webkit.org/show_bug.cgi?id=70707

Reviewed by Ojan Vafai.

Source/WebCore:

Added parsing support for -webkit-aspect-ratio CSS property.
The spec can be found here: http://www.xanthir.com/blog/b4810

Test: fast/css/aspect-ratio-parsing-tests.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSAspectRatioValue.cpp: Added.
(WebCore::CSSAspectRatioValue::~CSSAspectRatioValue):
(WebCore::CSSAspectRatioValue::cssText):
* css/CSSAspectRatioValue.h: Added.
(WebCore::CSSAspectRatioValue::create):
(WebCore::CSSAspectRatioValue::numeratorValue):
(WebCore::CSSAspectRatioValue::denominatorValue):
(WebCore::CSSAspectRatioValue::CSSAspectRatioValue):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSMutableStyleDeclaration.cpp:
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseAspectRatio):
* css/CSSParser.h:
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

* fast/css/aspect-ratio-parsing-tests-expected.txt: Added.
* fast/css/aspect-ratio-parsing-tests.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove Leopard-specific code from build.webkit.org
aroben@apple.com [Fri, 4 Nov 2011 22:52:26 +0000 (22:52 +0000)]
Remove Leopard-specific code from build.webkit.org

We don't have any Leopard bots anymore.

Fixes <http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code

Reviewed by Mark Rowe.

* BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer
and StopATSServer steps.
(unitTestsSupported): Removed check for mac-leopard.
(TestFactory.__init__): Removed Leopard-specific steps.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDelete FrameLoader::isSandboxed
abarth@webkit.org [Fri, 4 Nov 2011 22:50:54 +0000 (22:50 +0000)]
Delete FrameLoader::isSandboxed
https://bugs.webkit.org/show_bug.cgi?id=71591

Reviewed by Eric Seidel.

Source/WebCore:

We should always use document->securityOrigin()->isSandboxed because
that picks up the sandbox bits that are frozen on the document rather
than the ones that could change on the Frame.

This patch starts preparing us to implement the CSP sandbox directive,
which will cause use to have document sandbox bits without any attribute.

* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
    - This call site was the only functional site left where these two
      could be different. This patch causes one progression and one
      regression. The progression is that we now correctly freeze the
      allow-scripts bit when a document is created, but the regression
      is we now allow the execution of JavaScript URLs, as noted in
      fast/frames/sandboxed-iframe-scripting.html. That's even more of
      an edge case, so I think it's a win overall.
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
    - I don't think this part of the change is testable. There's no
      time to execute script between when the bits get copied off the
      Frame and when they're checked, so there's no time to change them.
* loader/FrameLoader.cpp:
    - Update FIXME comment that is now fixed.
* loader/FrameLoader.h:
    - Remove wrong API.

LayoutTests:

This patch updates this test to check a few more cases and notes a bug
in our current implementation.

* fast/frames/resources/sandboxed-iframe-script-dynamic.html:
* fast/frames/sandboxed-iframe-scripting-expected.txt:
* fast/frames/sandboxed-iframe-scripting.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWhen CSP blocks mixed content, we shouldn't also warn about mixed content
abarth@webkit.org [Fri, 4 Nov 2011 22:32:13 +0000 (22:32 +0000)]
When CSP blocks mixed content, we shouldn't also warn about mixed content
https://bugs.webkit.org/show_bug.cgi?id=71588

Reviewed by Eric Seidel.

Source/WebCore:

Getting both warnings confused some early adopters.  They thought the
insecure loads were happening even though they blocked them with CSP.
This patch restricts the mixed content warnings to show only when the
load isn't already blocked by CSP or by the embedder.

Test: http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning.html

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):

LayoutTests:

These tests check what kinds of warnings we generate when blocking insecure scripts with CSP.

* http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning.html: Added.
* http/tests/security/contentSecurityPolicy/resources/alert-fail.js: Added.
* http/tests/security/contentSecurityPolicy/resources/mixed-content-with-csp.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAllow ScriptExecutionContext::addMessage to be called from background threads.
commit-queue@webkit.org [Fri, 4 Nov 2011 22:24:17 +0000 (22:24 +0000)]
Allow ScriptExecutionContext::addMessage to be called from background threads.
https://bugs.webkit.org/show_bug.cgi?id=71575

Patch by Michael Nordman <michaeln@google.coom> on 2011-11-04
Reviewed by Nate Chapin.

No new tests.

* dom/Document.cpp:
(WebCore::Document::addMessage):
* dom/ScriptExecutionContext.cpp:
* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::create):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::performTask):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::addMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Re-named the original scissorRect to clipRect
commit-queue@webkit.org [Fri, 4 Nov 2011 22:16:25 +0000 (22:16 +0000)]
[chromium] Re-named the original scissorRect to clipRect
https://bugs.webkit.org/show_bug.cgi?id=71580

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-11-04
Reviewed by James Robinson.

Source/WebCore:

Existing tests are updated appropriately; and no new behavior is
introduced by this patch.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setUsesLayerClipping):
(WebCore::LayerChromium::usesLayerClipping):
(WebCore::LayerChromium::clipRect):
(WebCore::LayerChromium::setClipRect):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::clipRect):
(WebCore::RenderSurfaceChromium::setClipRect):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::setUsesLayerClipping):
(WebCore::CCLayerImpl::usesLayerClipping):
(WebCore::CCLayerImpl::clipRect):
(WebCore::CCLayerImpl::setClipRect):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::layerShouldBeSkipped):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::draw):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore::CCRenderSurface::setClipRect):
(WebCore::CCRenderSurface::clipRect):

Source/WebKit/chromium:

* tests/CCLayerImplTest.cpp:
(WebCore::TEST):
* tests/CCLayerTreeHostCommonTest.cpp:
(WebCore::TEST):
* tests/LayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agonew-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
eric@webkit.org [Fri, 4 Nov 2011 22:09:06 +0000 (22:09 +0000)]
new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
https://bugs.webkit.org/show_bug.cgi?id=71549

Reviewed by Adam Barth.

Several members of Host didn't really belong there
and were instead specific to WebKitPatch, so I've moved
them up onto that class.

* Scripts/webkitpy/common/host.py:
* Scripts/webkitpy/common/host_mock.py:
* Scripts/webkitpy/tool/main.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/runtests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic: bring back party time!
tony@chromium.org [Fri, 4 Nov 2011 22:01:07 +0000 (22:01 +0000)]
garden-o-matic: bring back party time!
https://bugs.webkit.org/show_bug.cgi?id=71582

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd the ability to transfer ArrayBuffer and "neuter" it.
dslomov@google.com [Fri, 4 Nov 2011 21:43:56 +0000 (21:43 +0000)]
Add the ability to transfer ArrayBuffer and "neuter" it.
https://bugs.webkit.org/show_bug.cgi?id=71535

Reviewed by David Levin.

* html/canvas/ArrayBuffer.cpp:
(WebCore::ArrayBuffer::create):
(WebCore::ArrayBuffer::ArrayBuffer):
(WebCore::ArrayBuffer::data):
(WebCore::ArrayBuffer::byteLength):
(WebCore::ArrayBuffer::transfer):
(WebCore::ArrayBufferContents::~ArrayBufferContents):
(WebCore::ArrayBufferContents::tryAllocate):
(WebCore::ArrayBuffer::addView):
(WebCore::ArrayBuffer::removeView):
* html/canvas/ArrayBuffer.h:
(WebCore::ArrayBufferContents::ArrayBufferContents):
(WebCore::ArrayBufferContents::data):
(WebCore::ArrayBufferContents::sizeInBytes):
(WebCore::ArrayBufferContents::release):
(WebCore::ArrayBuffer::~ArrayBuffer):
* html/canvas/ArrayBufferView.cpp:
(WebCore::ArrayBufferView::ArrayBufferView):
(WebCore::ArrayBufferView::~ArrayBufferView):
(WebCore::ArrayBufferView::neuter):
* html/canvas/ArrayBufferView.h:
* html/canvas/DataView.cpp:
(WebCore::DataView::neuter):
(WebCore::DataView::neuterBinding):
* html/canvas/DataView.h:
* html/canvas/TypedArrayBase.h:
(WebCore::TypedArrayBase::neuter):
(WebCore::TypedArrayBase::neuterBinding):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r99315.
commit-queue@webkit.org [Fri, 4 Nov 2011 21:42:27 +0000 (21:42 +0000)]
Unreviewed, rolling out r99315.
http://trac.webkit.org/changeset/99315
https://bugs.webkit.org/show_bug.cgi?id=71589

baselines still broken after running rebaseline script
(Requested by enne on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-04

* platform/chromium-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/compositing/scaling/tiled-layer-recursion-expected.png.
* platform/chromium-gpu-cg-mac/compositing/geometry/fixed-position-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/fixed-position-expected.png.
* platform/chromium-gpu-cg-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.png.
* platform/chromium-gpu-cg-mac/compositing/geometry/vertical-scroll-composited-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.png.
* platform/chromium-gpu-cg-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.png.
* platform/chromium-gpu-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png: Copied from LayoutTests/platform/chromium-gpu/compositing/scaling/tiled-layer-recursion-expected.png.
* platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/geometry/fixed-position-expected.png.
* platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.png.
* platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.png.
* platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.png.
* platform/chromium-gpu-mac/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-gpu/compositing/scaling/tiled-layer-recursion-expected.png.
* platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
* platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, GTK rebaseline after r99285.
philn@webkit.org [Fri, 4 Nov 2011 21:39:08 +0000 (21:39 +0000)]
Unreviewed, GTK rebaseline after r99285.

* platform/gtk/Skipped:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a test for how CSP interacts with about:blank iframes
abarth@webkit.org [Fri, 4 Nov 2011 21:32:03 +0000 (21:32 +0000)]
Add a test for how CSP interacts with about:blank iframes
https://bugs.webkit.org/show_bug.cgi?id=71578

Reviewed by Dimitri Glazkov.

This issue came up in the discussion on
http://code.google.com/p/chromium/issues/detail?id=103038.  This patch
just adds a test to make sure we don't regress.

* http/tests/security/contentSecurityPolicy/frame-src-about-blank-allowed-by-scheme-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/frame-src-about-blank-allowed-by-scheme.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agostop running perf LayoutTests in debug builds
tony@chromium.org [Fri, 4 Nov 2011 21:27:20 +0000 (21:27 +0000)]
stop running perf LayoutTests in debug builds
https://bugs.webkit.org/show_bug.cgi?id=71513

Reviewed by Ojan Vafai.

This allows us to get rid of SLOW on some perf tests.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Implement canvas.toDataURL("image/webp")
noel.gordon@gmail.com [Fri, 4 Nov 2011 21:14:24 +0000 (21:14 +0000)]
[Chromium] Implement canvas.toDataURL("image/webp")
https://bugs.webkit.org/show_bug.cgi?id=70172

Reviewed by Adam Barth.

Source/WebCore:

Add a webp image encoder for the chromium skia ports, add it to the canvas
element toDataURL() flow with support for an optional quality [0.0-1.0].
Use a webp compression method (3) that provides good speed and compression
performance for this image format, and works well for various input image
types: line-art, screen-shots, and photographic images.

Test: fast/canvas/canvas-toDataURL-webp.html

* WebCore.gypi:
* platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageToDataURL):
* platform/image-encoders/skia/WEBPImageEncoder.cpp: Added.
(WebCore::writeOutput):
(WebCore::importPicture):
(WebCore::importPictureBGRA):
(WebCore::importPictureRGBA):
(WebCore::encodePixels):
(WebCore::WEBPImageEncoder::encode):
* platform/image-encoders/skia/WEBPImageEncoder.h: Added.

LayoutTests:

* fast/canvas/canvas-toDataURL-webp-expected.txt: Added.
* fast/canvas/canvas-toDataURL-webp.html: Added.
* platform/chromium/test_expectations.txt: skip test on MAC CPU-CG (CoreGraphics)
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] DRT: Fix the order of the items in the dumped history list.
commit-queue@webkit.org [Fri, 4 Nov 2011 21:04:14 +0000 (21:04 +0000)]
[EFL] DRT: Fix the order of the items in the dumped history list.
https://bugs.webkit.org/show_bug.cgi?id=71562

It did not make much sense to hold the history list in a map, as we do not need
the keys. And the printed items must be sorted by target, which is more easily
done with a vector.

Should make tests such as http/tests/navigation/error404-frames.html pass.

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-04
Reviewed by Antonio Gomes.

Source/WebKit/efl:

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::childHistoryItems):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

* DumpRenderTree/efl/DumpHistoryItem.cpp:
(compareHistoryItemsByTarget):
(dumpHistoryItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Remove ENABLE_SQLITE from qmake files
paroga@webkit.org [Fri, 4 Nov 2011 21:00:11 +0000 (21:00 +0000)]
[Qt] Remove ENABLE_SQLITE from qmake files
https://bugs.webkit.org/show_bug.cgi?id=71546

Reviewed by Simon Hausmann.

Source/WebCore:

ENABLE_SQLITE is required to build WebCore, so remove conditions.

* Target.pri:

Tools:

* qmake/mkspecs/features/features.prf:
* qmake/mkspecs/features/webcore.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLayout Test storage/indexeddb/exception-in-event-aborts.html is failing
arv@chromium.org [Fri, 4 Nov 2011 20:58:00 +0000 (20:58 +0000)]
Layout Test storage/indexeddb/exception-in-event-aborts.html is failing
https://bugs.webkit.org/show_bug.cgi?id=71536

Unreviewed. Updated test and expectations.

* storage/indexeddb/exception-in-event-aborts-expected.txt:
* storage/indexeddb/exception-in-event-aborts.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Unreviewed expectation rebaseline from r99286.
enne@google.com [Fri, 4 Nov 2011 20:55:37 +0000 (20:55 +0000)]
[chromium] Unreviewed expectation rebaseline from r99286.

* platform/chromium-cg-mac-snowleopard/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png.
* platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png: Removed.
* platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
* platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png: Removed.
* platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png: Removed.
* platform/chromium-gpu-mac/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
* platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.txt: Removed.
* platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.txt: Removed.
* platform/chromium-gpu/compositing/geometry/fixed-position-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/geometry/fixed-position-expected.png.
* platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/geometry/horizontal-scroll-composited-expected.png.
* platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/geometry/vertical-scroll-composited-expected.png.
* platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png.
* platform/chromium-gpu/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowatchlist for WebIDL shouldn't trigger on Internals.idl
abarth@webkit.org [Fri, 4 Nov 2011 20:48:52 +0000 (20:48 +0000)]
watchlist for WebIDL shouldn't trigger on Internals.idl
https://bugs.webkit.org/show_bug.cgi?id=70657

Reviewed by David Levin.

Internals.idl isn't part of the Web-facing IDL in the project.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] comment out duplicate suppressions for compositing/zoom-animator-scale...
tony@chromium.org [Fri, 4 Nov 2011 20:43:14 +0000 (20:43 +0000)]
[chromium] comment out duplicate suppressions for compositing/zoom-animator-scale-test2.html
https://bugs.webkit.org/show_bug.cgi?id=71587

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDe-virtualize JSObject::hasInstance
mhahnenberg@apple.com [Fri, 4 Nov 2011 20:37:32 +0000 (20:37 +0000)]
De-virtualize JSObject::hasInstance
https://bugs.webkit.org/show_bug.cgi?id=71430

Reviewed by Darin Adler.

Added hasInstance to the MethodTable, changed all the virtual
implementations of hasInstance to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::hasInstance):
* API/JSValueRef.cpp:
(JSValueIsInstanceOfConstructor):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ClassInfo.h:
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::hasInstance):
* runtime/JSBoundFunction.h:
* runtime/JSCell.cpp:
(JSC::JSCell::hasInstance):
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::hasInstance):
* runtime/JSObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[V8] Null out V8NPObject::rootObject when the owning
japhet@chromium.org [Fri, 4 Nov 2011 20:24:38 +0000 (20:24 +0000)]
[V8] Null out V8NPObject::rootObject when the owning
Frame goes away.
https://bugs.webkit.org/show_bug.cgi?id=71569

Reviewed by Adam Barth.

No new tests, this has only been successfully triggered
using ppapi flash.

* bindings/v8/V8Helpers.cpp:
(WebCore::toV8Context):
* bindings/v8/npruntime.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSend the submissions character encoding in hidden _charset_ field.
commit-queue@webkit.org [Fri, 4 Nov 2011 19:53:21 +0000 (19:53 +0000)]
Send the submissions character encoding in hidden _charset_ field.
https://bugs.webkit.org/show_bug.cgi?id=19079

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-11-04
Reviewed by Darin Adler.

Source/WebCore:

Spec reference http://dev.w3.org/html5/spec/Overview.html#attr-fe-name-charset
If _charset_ used as the name of a hidden control it should send character encoding
as value while submissions.

Tests: http/tests/misc/char-encoding-in-hidden-charset-field-default.html
       http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5.html
       http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP.html
       http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP.html
       http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS.html
       http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset.html
       http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method.html
       http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field.html
       http/tests/misc/char-encoding-in-text-charset-field-with-value.html
       http/tests/misc/char-encoding-without-charset-field.html

* html/HiddenInputType.cpp:
(WebCore::HiddenInputType::isHiddenType):
(WebCore::HiddenInputType::appendFormData): For _charset_ send value as respective encodingType.
* html/HiddenInputType.h: Override appendFormData for hidden control types.

LayoutTests:

Spec reference http://dev.w3.org/html5/spec/Overview.html#attr-fe-name-charset
If _charset_ used as the name of a hidden control it should send character encoding
as value while submissions.
Added test cases to check this behavior.

* http/tests/misc/char-encoding-in-hidden-charset-field-default-expected.txt: Added.
* http/tests/misc/char-encoding-in-hidden-charset-field-default.html: Added. For Default Encoding.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5-expected.txt: Added.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5.html: Added. For Big5 Encoding.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP-expected.txt: Added.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP.html: Added. For EUC-JP Encoding.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP-expected.txt: Added.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP.html: Added. For ISO-2022-JP Encoding.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS-expected.txt: Added.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS.html: Added. For Shift_JIS Encoding.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset-expected.txt: Added.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset.html: Added. For two input fields.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method-expected.txt: Added.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method.html: Added. For GET method.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field-expected.txt: Added.
* http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field.html: Added. For one input fields.
* http/tests/misc/char-encoding-in-text-charset-field-with-value-expected.txt: Added.
* http/tests/misc/char-encoding-in-text-charset-field-with-value.html: Added. If input type is text.
* http/tests/misc/char-encoding-without-charset-field-expected.txt: Added.
* http/tests/misc/char-encoding-without-charset-field.html: Added. If no hidden input field.
* http/tests/misc/resources/char-encoding-in-hidden-charset-field.php: Added. Server side script for test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-11-04 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 4 Nov 2011 19:29:09 +0000 (19:29 +0000)]
2011-11-04  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: marked inspector/debugger/script-formatter.html
        as skipped for now - sorting it out.

        * platform/mac/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Use Chromium's copy of libWebKitSystemInterfaceLeopard.a
commit-queue@webkit.org [Fri, 4 Nov 2011 19:12:19 +0000 (19:12 +0000)]
[chromium] Use Chromium's copy of libWebKitSystemInterfaceLeopard.a
https://bugs.webkit.org/show_bug.cgi?id=71563

Patch by Robert Sesek <rsesek@chromium.org> on 2011-11-04
Reviewed by Adam Barth.

Source/WebCore:

Use libWebKitSystemInterfaceLeopard.a that's in the Chromium port,
rather in WebKitLibraries/.

* WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

Roll Chromium DEPS r108107:108476 to pull in
libWebKitSystemInterfaceLeopard.a.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRenderLayer::styleChanged invalidates the GraphicsLayer needlessly
jchaffraix@webkit.org [Fri, 4 Nov 2011 18:52:53 +0000 (18:52 +0000)]
RenderLayer::styleChanged invalidates the GraphicsLayer needlessly
https://bugs.webkit.org/show_bug.cgi?id=71517

Reviewed by Simon Fraser.

Unused code removal covered by existing tests.

The current code is invalidating the whole RenderLayerBacking as part of
a style change. However this is redundant with the repainting logic which
would invalidate only the necessary bits.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::styleChanged):
Remove the invalidation code as it duplicates and defeats the repaint logic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCorrect parsing of incomplete @-webkit-region rules.
mihnea@adobe.com [Fri, 4 Nov 2011 18:38:20 +0000 (18:38 +0000)]
Correct parsing of incomplete @-webkit-region rules.
https://bugs.webkit.org/show_bug.cgi?id=71514

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/regions/parse-incomplete-region-rule.html

Make sure to set the region rule to 0 on the fail branch.
* css/CSSGrammar.y:

LayoutTests:

* fast/regions/parse-incomplete-region-rule-expected.txt: Added.
* fast/regions/parse-incomplete-region-rule.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReduce refcount churn in ChildListMutationScope
adamk@chromium.org [Fri, 4 Nov 2011 18:34:00 +0000 (18:34 +0000)]
Reduce refcount churn in ChildListMutationScope
https://bugs.webkit.org/show_bug.cgi?id=71527

Reviewed by Ryosuke Niwa.

Only the ChildListMutationAccumulator needs to hold a reference to the
target node, and the added/removed children only need be ref'd if a
ChildListMutationAccumulator exists (i.e., if there are interested
observers).

* dom/ChildListMutationScope.cpp:
(WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::enqueueMutationRecord):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::childAdded):
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::willRemoveChild):
(WebCore::ChildListMutationScope::ChildListMutationScope):
(WebCore::ChildListMutationScope::~ChildListMutationScope):
(WebCore::ChildListMutationScope::childAdded):
(WebCore::ChildListMutationScope::willRemoveChild):
* dom/ChildListMutationScope.h:
* dom/ContainerNode.cpp:
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening.
hausmann@webkit.org [Fri, 4 Nov 2011 18:28:31 +0000 (18:28 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Forgot to skip this test also in r99296.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCorrect usage of LayoutUnits in RenderImage and SVGImage
leviw@chromium.org [Fri, 4 Nov 2011 18:27:35 +0000 (18:27 +0000)]
Correct usage of LayoutUnits in RenderImage and SVGImage
https://bugs.webkit.org/show_bug.cgi?id=71525

Reviewed by Darin Adler.

Correcting incorrect usage of LayoutUnits for image sizes that should be integers and fixing overloaded functions that
should be using LayoutUnits.

No new tests -- no change in behavior.

* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::nodeAtPoint):
(WebCore::RenderImage::computeReplacedLogicalWidth):
* rendering/RenderImage.h:
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImageChromeClient::invalidateContentsAndWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix WKTR crash when running NPN_ConvertPoint test.
andersca@apple.com [Fri, 4 Nov 2011 18:20:11 +0000 (18:20 +0000)]
Fix WKTR crash when running NPN_ConvertPoint test.

Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.

* DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
(ConvertPoint::NPP_SetWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement allow-popups for iframe@sandbox
abarth@webkit.org [Fri, 4 Nov 2011 18:14:58 +0000 (18:14 +0000)]
Implement allow-popups for iframe@sandbox
https://bugs.webkit.org/show_bug.cgi?id=66505

Reviewed by Darin Adler.

Source/WebCore:

Enable allow-popups sandbox bit.  My previous patch attempted to
forward the sandbox bits during setOpener, but that interacted poorly
with out (internal) sandboxing of the initial document.  This patch
forwards the bits during createWindow, which is more targeted to the
case when a sandbox frame actually creates a new window.

* loader/FrameLoader.cpp:
(WebCore::createWindow):
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNewWindowPolicy):

LayoutTests:

Update test results to show that we now pass.

* http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt:
* http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html:
* http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html:
* http/tests/security/popup-allowed-by-sandbox-when-allowed-expected.txt:
* http/tests/security/popup-allowed-by-sandbox-when-allowed.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNPN_ConvertPoint plug-in test should be called from NPP_SetWindow
andersca@apple.com [Fri, 4 Nov 2011 18:12:58 +0000 (18:12 +0000)]
NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
https://bugs.webkit.org/show_bug.cgi?id=71570

Reviewed by Simon Fraser.

Tools:

* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPP_SetWindow):
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
Remove the NPP parameter from NPP_SetWindow.

* DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:
(NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
Remove the NPP parameter from NPP_SetWindow.

* DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
(PassDifferentNPPStruct::NPP_SetWindow):
Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.

* DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
(ConvertPoint::NPP_SetWindow):
Run the test from NPP_SetWindow and call notifyDone() when done.

* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_SetWindow):
Remove unnecessary parameter.

LayoutTests:

Add a call to layoutTestController.waitUntilDone(); the plug-in will call notifyDone() when it's done.
* platform/mac/plugins/convert-point.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove initMediaStreamEvent method
commit-queue@webkit.org [Fri, 4 Nov 2011 18:11:47 +0000 (18:11 +0000)]
Remove initMediaStreamEvent method
https://bugs.webkit.org/show_bug.cgi?id=71344

This method has been removed from the spec draft.
http://www.whatwg.org/specs/web-apps/current-work/multipage/video-conferencing-and-peer-to-peer-communication.html#mediastreamevent

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-11-04
Reviewed by Adam Barth.

No new tests. Removed method.

* mediastream/MediaStreamEvent.cpp:
* mediastream/MediaStreamEvent.h:
* mediastream/MediaStreamEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAnonymous CORS fetch for WebGL texture fails when there is no appropriate server...
abarth@webkit.org [Fri, 4 Nov 2011 18:09:36 +0000 (18:09 +0000)]
Anonymous CORS fetch for WebGL texture fails when there is no appropriate server response even for the same origin requests
https://bugs.webkit.org/show_bug.cgi?id=71053

Reviewed by Darin Adler.

Source/WebCore:

The crossorigin attribute should behave like XMLHttpRequest:
same-origin images pass without and CORS headers, but CORS checks are
performed for cross-origin loads.  This patch better aligns our
behavior with Firefox, as discussed in the bug.

Test: http/tests/security/img-crossorigin-loads-same-origin.html

* loader/ImageLoader.cpp:
(WebCore::ImageLoader::notifyFinished):

LayoutTests:

Test that we succeed in loading a same-origin image without the help of
CORS even if the image has the crossorigin attribute.

* http/tests/security/img-crossorigin-loads-same-origin-expected.txt: Added.
* http/tests/security/img-crossorigin-loads-same-origin.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoHTMLKeygenElement: Fix "keytype" handling in appendFormData.
commit-queue@webkit.org [Fri, 4 Nov 2011 17:55:14 +0000 (17:55 +0000)]
HTMLKeygenElement: Fix "keytype" handling in appendFormData.
https://bugs.webkit.org/show_bug.cgi?id=70617

This fixes a bug introduced by http://trac.webkit.org/changeset/97658
which causes all HTML Keygen elements with a keytype optional attribute
to be considered as unsupported.

A regression test is included.

Patch by Gaurav Shah <gauravsh@chromium.org> on 2011-11-04
Reviewed by Darin Adler.

Source/WebCore:

Test: http/tests/misc/submit-post-keygen.html

* html/HTMLKeygenElement.cpp:

LayoutTests:

* http/tests/misc/resources/check-keygen-post.php: Added.
* http/tests/misc/submit-post-keygen-expected.txt: Added.
* http/tests/misc/submit-post-keygen.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Temporarily skip failing tests after the build system refactoring.
hausmann@webkit.org [Fri, 4 Nov 2011 17:51:11 +0000 (17:51 +0000)]
[Qt] Temporarily skip failing tests after the build system refactoring.

Rubber-stamped by Ossy.

Bug #71571 tracks the failure so we can look into it next week.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Implement checkerboarding for missing layer tiles
enne@google.com [Fri, 4 Nov 2011 17:45:28 +0000 (17:45 +0000)]
[chromium] Implement checkerboarding for missing layer tiles
https://bugs.webkit.org/show_bug.cgi?id=69585

Reviewed by James Robinson.

Source/WebCore:

For tiles that have no texture or haven't even been created yet,
draw using the background color of the layer.

The only background color set is currently the non-composited content,
and all other layers use transparent black by default.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::setBackgroundColor):
* platform/graphics/chromium/NonCompositedContentHost.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::setBackgroundColor):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::backgroundColor):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::drawTiles):

Source/WebKit/chromium:

To pipe the background color of the document to the non-composited
host, set it during paint. This may be more frequent than necessary,
but it'll catch all style changes.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::nonCompositedContentHost):
(WebKit::WebViewImplContentPainter::paint):
* src/WebViewImpl.h:
* tests/CCLayerImplTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix run-qtwebkit-tests execution on the build bot(s).
hausmann@webkit.org [Fri, 4 Nov 2011 17:41:15 +0000 (17:41 +0000)]
[Qt] Fix run-qtwebkit-tests execution on the build bot(s).

Rubber-stamped by Tor Arne Vestbø.

* BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests
changed slightly after the refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Remove most exit time destructors
thakis@chromium.org [Fri, 4 Nov 2011 17:37:25 +0000 (17:37 +0000)]
[chromium] Remove most exit time destructors
https://bugs.webkit.org/show_bug.cgi?id=71524

Do this by using the DEFINE_STATIC_LOCAL macro, which allocates things on the heaps and then leaks them.

Reviewed by Dimitri Glazkov.

No behavior change, so no new tests.

* platform/chromium/CursorChromium.cpp:
(WebCore::pointerCursor):
(WebCore::crossCursor):
(WebCore::handCursor):
(WebCore::iBeamCursor):
(WebCore::waitCursor):
(WebCore::helpCursor):
(WebCore::eastResizeCursor):
(WebCore::northResizeCursor):
(WebCore::northEastResizeCursor):
(WebCore::northWestResizeCursor):
(WebCore::southResizeCursor):
(WebCore::southEastResizeCursor):
(WebCore::southWestResizeCursor):
(WebCore::westResizeCursor):
(WebCore::northSouthResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::columnResizeCursor):
(WebCore::rowResizeCursor):
(WebCore::middlePanningCursor):
(WebCore::eastPanningCursor):
(WebCore::northPanningCursor):
(WebCore::northEastPanningCursor):
(WebCore::northWestPanningCursor):
(WebCore::southPanningCursor):
(WebCore::southEastPanningCursor):
(WebCore::southWestPanningCursor):
(WebCore::westPanningCursor):
(WebCore::moveCursor):
(WebCore::verticalTextCursor):
(WebCore::cellCursor):
(WebCore::contextMenuCursor):
(WebCore::aliasCursor):
(WebCore::progressCursor):
(WebCore::noDropCursor):
(WebCore::copyCursor):
(WebCore::noneCursor):
(WebCore::notAllowedCursor):
(WebCore::zoomInCursor):
(WebCore::zoomOutCursor):
(WebCore::grabCursor):
(WebCore::grabbingCursor):
* platform/chromium/LanguageChromium.cpp:
(WebCore::platformDefaultLanguage):
* platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore::dummyHashSet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Unreviewed expectations update.
enne@google.com [Fri, 4 Nov 2011 17:29:25 +0000 (17:29 +0000)]
[chromium] Unreviewed expectations update.

Temporarily mark a few tests as failing from r99286 due to tiny
differences on scrollbars. Can be rebaselined once all bots cycle.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Expose deviceScaleFactor to WebKit API
fsamuel@chromium.org [Fri, 4 Nov 2011 17:10:03 +0000 (17:10 +0000)]
[Chromium] Expose deviceScaleFactor to WebKit API
https://bugs.webkit.org/show_bug.cgi?id=70614

Reviewed by Darin Fisher.

This exposes the device scale factor to the Chromium-WebKit API.
This scale factor is the ratio between the current device's DPI
and the target device's DPI.

For details on how this can be accessed from CSS and javascript, please
see here:

http://developer.android.com/guide/webapps/targeting.html#DensityCSS

* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::deviceScaleFactor):
(WebKit::WebViewImpl::setDeviceScaleFactor):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
vestbo@webkit.org [Fri, 4 Nov 2011 17:06:06 +0000 (17:06 +0000)]
[Qt] Don't warn about disabling WebKit2 when qmake does recursive includes

Reviewed by Simon Hausmann.

* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd NetscapePlugin::convertFromRootView
andersca@apple.com [Fri, 4 Nov 2011 17:04:15 +0000 (17:04 +0000)]
Add NetscapePlugin::convertFromRootView
https://bugs.webkit.org/show_bug.cgi?id=71526

Reviewed by Sam Weinig.

Source/WebCore:

Export some symbols that WebKit2 needs.

* WebCore.exp.in:

Source/WebKit2:

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::convertFromRootView):
New function that converts a point from root view coordinates to plug-in coordinates.
Returns false if the conversion can't be done.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::fillInCocoaEventFromMouseEvent):
(WebKit::initializeMouseEvent):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
Use convertFromRootView instead of subtracting m_frameRectInWindowCoordinates.location() from the
event position (which is in root view coordinates).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix svn properties on layout test result files I checked in.
tony@chromium.org [Fri, 4 Nov 2011 17:00:15 +0000 (17:00 +0000)]
Fix svn properties on layout test result files I checked in.

* platform/chromium-linux/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added property svn:mime-type.
* platform/chromium-win/printing/setPrinting-expected.txt: Added property svn:eol-style.
* platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added property svn:mime-type.
* platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added property svn:eol-style.
* platform/mac/printing/setPrinting-expected.txt: Added property svn:eol-style.
* platform/mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added property svn:eol-style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Don't error out on wrong Qt version when qmake does recursive includes
vestbo@webkit.org [Fri, 4 Nov 2011 16:55:42 +0000 (16:55 +0000)]
[Qt] Don't error out on wrong Qt version when qmake does recursive includes

Reviewed by Simmon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Fix incorrect visibility/scissor rect for threaded compositing
enne@google.com [Fri, 4 Nov 2011 16:41:19 +0000 (16:41 +0000)]
[chromium] Fix incorrect visibility/scissor rect for threaded compositing
https://bugs.webkit.org/show_bug.cgi?id=70962

Reviewed by James Robinson.

Source/WebCore:

In order to properly scroll independent of layout on the compositor
thread, we have to apply the scroll to the right layer. Previously,
the NonCompositedContentHost was the root of the graphics layer tree
with all other layers underneath it. However, applying a scroll to
that layer would also scroll the clip layer for the main frame
underneath it, causing visibility issues.

This patch moves the NonCompositedHost to be a child of the
RenderLayerCompositor's scroll layer. This was exposed on
RenderLayerCompositor, because there's no other way to get to this
layer in a way that doesn't make assumptions about the structure of
the layers on a frame.

This also removes the hacks in calculateVisibleLayerRect and
tilingTransform for scroll position.

Partially tested by existing compositor tests. Manually tested
threaded compositing scrolling.

* platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::setScrollLayer):
(WebCore::NonCompositedContentHost::setViewport):
(WebCore::NonCompositedContentHost::scrollLayer):
* platform/graphics/chromium/NonCompositedContentHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::create):
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::applyScrollDeltas):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::setRootLayer):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::findScrollLayer):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::scrollRootLayer):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::tilingTransform):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::scrollLayer):
* rendering/RenderLayerCompositor.h:

Source/WebKit/chromium:

* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHost::MockLayerTreeHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Disable VIDEO_TRACK for now
philn@webkit.org [Fri, 4 Nov 2011 16:09:24 +0000 (16:09 +0000)]
[GTK] Disable VIDEO_TRACK for now
https://bugs.webkit.org/show_bug.cgi?id=71547

Reviewed by Gustavo Noronha Silva.

.:

* configure.ac: VIDEO_TRACK is still a moving target, it's best to
disable it for now.

LayoutTests:

Skip media/track tests and rebaseline involved fast/dom test results.

* platform/gtk/Skipped:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Fri, 4 Nov 2011 15:48:51 +0000 (15:48 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Disable inspector tests temporarily because of a bug near build system refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening: 8th chunk of baselines for Chromium-Skia
caryclark@google.com [Fri, 4 Nov 2011 15:31:12 +0000 (15:31 +0000)]
Unreviewed gardening: 8th chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 602 of 608 files for brevity.]

* platform/chromium-mac-leopard/css3/bdi-element-expected.png: Added.
* platform/chromium-mac-leopard/css3/bdi-element-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
...
* platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png: Added.
* platform/chromium-mac-leopard/transforms/svg-vs-css-expected.png: Added.
* platform/chromium-mac-leopard/transitions/move-after-transition-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Disable STDIN check before cleaning build dir
vestbo@webkit.org [Fri, 4 Nov 2011 15:29:40 +0000 (15:29 +0000)]
[Qt] Disable STDIN check before cleaning build dir

It didn't work on the bots.

Reviewed by Ossy.

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Don't build all of webkit when running build-jsc
vestbo@webkit.org [Fri, 4 Nov 2011 15:20:50 +0000 (15:20 +0000)]
[Qt] Don't build all of webkit when running build-jsc

In case the whole webkit project was built, but we then subsequently
want to build only JSC, we need to run make in the proper subdirectory.

This also means the incremental target needs to be added to all
makefiles.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Look for STDIN instead of STDOUT when asking to clean the build dir
vestbo@webkit.org [Fri, 4 Nov 2011 15:20:32 +0000 (15:20 +0000)]
[Qt] Look for STDIN instead of STDOUT when asking to clean the build dir

Reviewed by Ossy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix run-javascriptcore-tests for Qt when it's executed by the bot.
hausmann@webkit.org [Fri, 4 Nov 2011 14:54:05 +0000 (14:54 +0000)]
Fix run-javascriptcore-tests for Qt when it's executed by the bot.

Reviewed by Tor Arne Vestbø.

* Scripts/webkitdirs.pm:
(jscProductDir): jsc path changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Error out early if trying to build against Qt < 4.8
vestbo@webkit.org [Fri, 4 Nov 2011 14:03:20 +0000 (14:03 +0000)]
[Qt] Error out early if trying to build against Qt < 4.8

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix run-launcher for Qt and Gtk.
hausmann@webkit.org [Fri, 4 Nov 2011 13:47:23 +0000 (13:47 +0000)]
Fix run-launcher for Qt and Gtk.

Rubber-stamped by Tor Arne Vestbø.

* Scripts/webkitdirs.pm:
(isWK2): Re-add isWK2(), as it's used in run-launcher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
vestbo@webkit.org [Fri, 4 Nov 2011 13:39:40 +0000 (13:39 +0000)]
[Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Use web view title as window title in MiniBrowser
carlosgc@webkit.org [Fri, 4 Nov 2011 13:37:12 +0000 (13:37 +0000)]
[GTK] Use web view title as window title in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=71544

Reviewed by Philippe Normand.

* MiniBrowser/gtk/BrowserWindow.c:
(webViewURIChanged): Removed extra space.
(webViewTitleChanged): Set window title using
webkit_web_view_get_title().
(browser_window_init): Set initial default window title.
(browserWindowConstructed): Connect to WebView notify::title
signal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Refactor and clean up the qmake build system
vestbo@webkit.org [Fri, 4 Nov 2011 13:19:58 +0000 (13:19 +0000)]
[Qt] Refactor and clean up the qmake build system

The qmake build system has accumulated a bit of cruft and redundancy
over time. There's also a fairly tight coupling between how to build
the various targets, and _what_ to build, making it harder to add new
rules or sources. This patch aims to elevate these issues somewhat.

This is a short-list of the changes:

  * The rules for how to build targets are now mostly contained as
    prf-files in Tools/qmake/mkspecs/features. Using mkspecs also
    allows us to do pre- and post-processing of each project file,
    which helps to clean up the actual project files.

  * Derived sources are no longer generated as a separate make-step
    but is part of each target's project file as a subdir. Makefile
    rules are used to ensure that we run make on the derived sources
    before running qmake on the actual target makefile. This makes
    it easier to keep a proper dependency between derived sources
    and the target.

  * We use GNU make and the compiler to generate dependencies on
    UNIX-based systems running Qt 5. This allows us to lessen the
    need to run qmake, which should reduce compile time.

  * WebKit2 is now build by default if building with Qt 5. It can
    be disabled by passing --no-webkit2 to build-webkit.

The result of these changes are hopefully a cleaner and easier
build system to modify, and faster build times due to no longer
running qmake on every single build. It's also a first step
towards possibly generating the list of sources using another
build system.

https://bugs.webkit.org/show_bug.cgi?id=71222

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Support programmatic scrolling with the QTouchWebView
kenneth@webkit.org [Fri, 4 Nov 2011 12:28:18 +0000 (12:28 +0000)]
[Qt] Support programmatic scrolling with the QTouchWebView

Reviewed by Simon Hausmann.

As more code can be shared between the programmatic scrolling and the
method for ensuring that the contents are within valid bounds, this
patch includes a bit of refactoring as well.

* UIProcess/API/qt/qdesktopwebview_p.h:
(QDesktopWebViewPrivate::scrollPositionRequested):
* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::scrollPositionRequested):
* UIProcess/API/qt/qtouchwebview_p.h:
* UIProcess/qt/QtTouchViewInterface.cpp:
(WebKit::QtTouchViewInterface::scrollPositionRequested):
* UIProcess/qt/QtTouchViewInterface.h:
* UIProcess/qt/QtViewInterface.h:
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::event):
(WebKit::boundPosition):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::setConstraints):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
(WebKit::QtViewportInteractionEngine::contentViewportChanged):
* UIProcess/qt/QtViewportInteractionEngine.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::pageDidRequestScroll):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] MediaStream API: Fixing wrong path for PeerConnectionHandler.h in WebCore.gyp
commit-queue@webkit.org [Fri, 4 Nov 2011 11:23:18 +0000 (11:23 +0000)]
[chromium] MediaStream API: Fixing wrong path for PeerConnectionHandler.h in WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=71548

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-04
Reviewed by Tony Gentilcore.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove deprecated free functions in port.factory
eric@webkit.org [Fri, 4 Nov 2011 09:20:06 +0000 (09:20 +0000)]
Remove deprecated free functions in port.factory
https://bugs.webkit.org/show_bug.cgi?id=71494

Unreviewed.  Fixing exception seen when running test-webkitpy.

Sorry, I previously had deleted the relevant rebaseline-chromium-webkit-tests
unittest, since that script is nearly ready to be deleted.  But I added
it back at the last second and failed to run the tests. :(
This fixes the exception the bots were seeing.

* Scripts/webkitpy/style/checkers/test_expectations.py:
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99271 268f45cc-cd09-0410-ab3c-d52691b4dbfc