WebKit-https.git
9 years ago[BlackBerry] speed up text selection for large selections
commit-queue@webkit.org [Mon, 19 Mar 2012 22:17:27 +0000 (22:17 +0000)]
[BlackBerry] speed up text selection for large selections
https://bugs.webkit.org/show_bug.cgi?id=81536

When selecting large disjoint areas of text the cost
of calculating the IntRectRegion union becomes very
expensive. Simply placing all of the text quads into
the IntRectRegion is faster despite the larger memory
footprint and the additional calculations at render
time.

Patch by Tyler Abbott <tabbott@rim.com> on 2012-03-19
Reviewed by Rob Buis.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::getConsolidatedRegionOfTextQuadsForSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix WTF header include discipline in Chromium WebKit
eric@webkit.org [Mon, 19 Mar 2012 22:16:48 +0000 (22:16 +0000)]
Fix WTF header include discipline in Chromium WebKit
https://bugs.webkit.org/show_bug.cgi?id=81281

Reviewed by James Robinson.

Source/JavaScriptCore:

* JavaScriptCore.gyp/JavaScriptCore.gyp:
* wtf/unicode/icu/CollatorICU.cpp:

Source/WebCore:

I also fixed some bad include dicipline for other ports
as well.  Those changes are not yet necessary for those ports
to keep building, but soon should be as those authors
remove all the extra WTF includes from WebCore and other non-WTF projects.

* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
* bindings/scripts/test/CPP/WebDOMFloat64Array.cpp:
* bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
* bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:
* bindings/scripts/test/ObjC/DOMFloat64Array.mm:
* bindings/v8/NPV8Object.cpp:
* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/SerializedScriptValue.h:
* bindings/v8/V8Binding.cpp:
* bindings/v8/V8Binding.h:
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8Utilities.cpp:
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
* bindings/v8/custom/V8AudioContextCustom.cpp:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
* bindings/v8/custom/V8Float32ArrayCustom.cpp:
* bindings/v8/custom/V8Float64ArrayCustom.cpp:
* bindings/v8/custom/V8Int16ArrayCustom.cpp:
* bindings/v8/custom/V8Int32ArrayCustom.cpp:
* bindings/v8/custom/V8Int8ArrayCustom.cpp:
* bindings/v8/custom/V8MessagePortCustom.cpp:
* bindings/v8/custom/V8Uint16ArrayCustom.cpp:
* bindings/v8/custom/V8Uint32ArrayCustom.cpp:
* bindings/v8/custom/V8Uint8ArrayCustom.cpp:
* bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
* bindings/v8/custom/V8WorkerCustom.cpp:
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
* bridge/qt/qt_runtime.cpp:
* editing/gtk/FrameSelectionGtk.cpp:
* loader/archive/mhtml/MHTMLArchive.cpp:
* platform/ScrollAnimatorNone.cpp:
* platform/blackberry/CookieMap.h:
* platform/blackberry/CookieParser.h:
* platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:
* platform/chromium/DragImageChromiumSkia.cpp:
* platform/chromium/PlatformCursor.h:
* platform/chromium/PlatformSupport.h:
* platform/chromium/PopupMenuPrivate.h:
* platform/chromium/TraceEvent.h:
* platform/chromium/WidgetChromium.cpp:
* platform/efl/RefPtrEfl.h:
* platform/graphics/cairo/RefPtrCairo.h:
* platform/graphics/chromium/RateLimiter.h:
* platform/graphics/chromium/TiledLayerChromium.cpp:
* platform/graphics/efl/IconEfl.cpp:
* platform/graphics/gstreamer/GStreamerGWorld.h:
* platform/graphics/gtk/IconGtk.cpp:
* platform/graphics/skia/PlatformContextSkia.h:
* platform/graphics/texmap/TextureMapperBackingStore.h:
* platform/graphics/texmap/TextureMapperLayer.cpp:
* platform/graphics/wx/TransformationMatrixWx.cpp:
* platform/gtk/PlatformMouseEventGtk.cpp:
* platform/leveldb/LevelDBSlice.h:
* platform/mediastream/MediaStreamCenter.cpp:
* platform/network/soup/SocketStreamHandleSoup.cpp:
* platform/network/win/ResourceHandleWin.cpp:
* platform/qt/RenderThemeQtMobile.cpp:
* platform/wx/MouseEventWx.cpp:
* platform/wx/wxcode/win/fontprops.cpp:

Source/WebKit/chromium:

* src/CompositionUnderlineBuilder.h:
* src/CompositionUnderlineVectorBuilder.h:
* src/FrameLoaderClientImpl.cpp:
* src/WebArrayBuffer.cpp:
* src/WebArrayBufferView.cpp:
* src/WebBindings.cpp:
* src/WebColorName.cpp:
* src/WebGeolocationClientMock.cpp:
* src/WebPageSerializer.cpp:
* src/WebSocketImpl.cpp:
* src/WebViewImpl.cpp:
* tests/FrameTestHelpers.cpp:

Tools:

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Add new layout test for text match marker
commit-queue@webkit.org [Mon, 19 Mar 2012 22:03:19 +0000 (22:03 +0000)]
[BlackBerry] Add new layout test for text match marker
https://bugs.webkit.org/show_bug.cgi?id=81531

Tools:

Make the LayoutTestControllerBlackBerry::findString to test the
BlackBerry port implementation.

Patch by Andy Chen <andchen@rim.com> on 2012-03-19
Reviewed by Rob Buis.

* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::findString):

LayoutTests:

Patch by Andy Chen <andchen@rim.com> on 2012-03-19
Reviewed by Rob Buis.

Add a new layout test for text match marker for BlackBerry port

* platform/blackberry/editing/text-iterator/findString-markers-expected.txt: Added.
* platform/blackberry/editing/text-iterator/findString-markers.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agor109204 updated the chromium expected results for
jberlin@webkit.org [Mon, 19 Mar 2012 21:54:37 +0000 (21:54 +0000)]
r109204 updated the chromium expected results for
inspector/timeline/timeline-animation-frame.html and timeline-paint.html, but did not update
the cross-platform results.

Update the cross-platform results.

* inspector/timeline/timeline-animation-frame-expected.txt:
* inspector/timeline/timeline-paint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG NodeUse should be called Edge and NodeReferenceBlob should be called AdjacencyList
fpizlo@apple.com [Mon, 19 Mar 2012 21:44:23 +0000 (21:44 +0000)]
DFG NodeUse should be called Edge and NodeReferenceBlob should be called AdjacencyList
https://bugs.webkit.org/show_bug.cgi?id=81556

Rubber stamped by Gavin Barraclough.

* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGAbstractState.h:
(JSC::DFG::AbstractState::forNode):
* dfg/DFGAdjacencyList.h: Copied from Source/JavaScriptCore/dfg/DFGNodeReferenceBlob.h.
(JSC::DFG::AdjacencyList::AdjacencyList):
(JSC::DFG::AdjacencyList::child):
(JSC::DFG::AdjacencyList::setChild):
(JSC::DFG::AdjacencyList::child1):
(JSC::DFG::AdjacencyList::child2):
(JSC::DFG::AdjacencyList::child3):
(JSC::DFG::AdjacencyList::setChild1):
(JSC::DFG::AdjacencyList::setChild2):
(JSC::DFG::AdjacencyList::setChild3):
(JSC::DFG::AdjacencyList::child1Unchecked):
(JSC::DFG::AdjacencyList::initialize):
(AdjacencyList):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::processPhiStack):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::canonicalize):
(JSC::DFG::CSEPhase::performSubstitution):
* dfg/DFGEdge.h: Copied from Source/JavaScriptCore/dfg/DFGNodeUse.h.
(DFG):
(JSC::DFG::Edge::Edge):
(JSC::DFG::Edge::operator==):
(JSC::DFG::Edge::operator!=):
(Edge):
(JSC::DFG::operator==):
(JSC::DFG::operator!=):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::operator[]):
(JSC::DFG::Graph::at):
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):
(Graph):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::getPrediction):
* dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child1Unchecked):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(Node):
* dfg/DFGNodeFlags.cpp:
(JSC::DFG::arithNodeFlagsAsString):
* dfg/DFGNodeFlags.h:
(DFG):
(JSC::DFG::nodeUsedAsNumber):
* dfg/DFGNodeReferenceBlob.h: Removed.
* dfg/DFGNodeUse.h: Removed.
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultArithFlags):
(JSC::DFG::PredictionPropagationPhase::vote):
(JSC::DFG::PredictionPropagationPhase::fixupNode):
* dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::use):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::at):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::use):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Invalidate/update evicted tiles during commit
commit-queue@webkit.org [Mon, 19 Mar 2012 21:37:00 +0000 (21:37 +0000)]
[chromium] Invalidate/update evicted tiles during commit
https://bugs.webkit.org/show_bug.cgi?id=81529

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

Source/WebCore:

A previous change caused a regression where evicted (invalid) tiles
were no longer marked as dirty and updated. The regress was caused
in https://bugs.webkit.org/show_bug.cgi?id=81175 and is fixed here.

Unit test: TiledLayerChromiumTest.pushDeletedTiles

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::copyAndClearDirty):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):

Source/WebKit/chromium:

* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove PLATFORM(TORCHMOBILE) ifdef from MainResourceLoader.cpp
abarth@webkit.org [Mon, 19 Mar 2012 21:35:16 +0000 (21:35 +0000)]
Remove PLATFORM(TORCHMOBILE) ifdef from MainResourceLoader.cpp
https://bugs.webkit.org/show_bug.cgi?id=81549

Reviewed by Eric Seidel.

This appears to be the only PLATFORM(TORCHMOBILE) ifdef in WebCore.  I
don't believe this ifdef is needed anymore.

* loader/MainResourceLoader.cpp:
(WebCore::shouldLoadAsEmptyDocument):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoObject.freeze broken on latest Nightly
barraclough@apple.com [Mon, 19 Mar 2012 21:34:25 +0000 (21:34 +0000)]
Object.freeze broken on latest Nightly
https://bugs.webkit.org/show_bug.cgi?id=80577

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* runtime/Arguments.cpp:
(JSC::Arguments::defineOwnProperty):
    - defineOwnProperty was checking for correct behaviour, provided that length/callee hadn't
    been overrridden. instead, just reify length/callee & rely on JSObject::defineOwnProperty.
* runtime/JSFunction.cpp:
(JSC::JSFunction::defineOwnProperty):
    - for arguments/caller/length properties, defineOwnProperty was incorrectly asserting that
    the object must be extensible; this is incorrect since these properties should already exist
    on the object. In addition, it was asserting that the arguments/caller values must match the
    corresponding magic data properties, but for strict mode function this is incorrect. Instead,
    just reify the arguments/caller accessor & defer to JSObject::defineOwnProperty.

LayoutTests:

* fast/js/preventExtensions-expected.txt:
* fast/js/script-tests/preventExtensions.js:
(shouldBeTrue):
(shouldBeFalse.shouldBeFalse.preventExtensionsFreezeIsFrozen):
    - Added test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r111207.
commit-queue@webkit.org [Mon, 19 Mar 2012 21:30:47 +0000 (21:30 +0000)]
Unreviewed, rolling out r111207.
http://trac.webkit.org/changeset/111207
https://bugs.webkit.org/show_bug.cgi?id=81561

Causing chromium unit test failure (Requested by reveman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-19

Source/Platform:

* chromium/public/WebGraphicsContext3D.h:

Source/WebCore:

* platform/graphics/chromium/Extensions3DChromium.h:
(Extensions3DChromium):

Source/WebKit/chromium:

* src/Extensions3DChromium.cpp:
* src/GraphicsContext3DChromium.cpp:
(WebCore):
* src/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
* tests/FakeWebGraphicsContext3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] MediaStream API (JSEP): Introducing WebMediaHints and WebIceOptions
tommyw@google.com [Mon, 19 Mar 2012 21:27:06 +0000 (21:27 +0000)]
[chromium] MediaStream API (JSEP): Introducing WebMediaHints and WebIceOptions
https://bugs.webkit.org/show_bug.cgi?id=81341

Reviewed by Darin Fisher.

Simple WebKit representations of the WebCore/platform versions.

* WebKit.gyp:
* public/platform/WebICEOptions.h: Added.
(WebCore):
(WebKit):
(WebICEOptions):
(WebKit::WebICEOptions::WebICEOptions):
(WebKit::WebICEOptions::~WebICEOptions):
(WebKit::WebICEOptions::operator=):
(WebKit::WebICEOptions::isNull):
* public/platform/WebMediaHints.h: Added.
(WebCore):
(WebKit):
(WebMediaHints):
(WebKit::WebMediaHints::WebMediaHints):
(WebKit::WebMediaHints::~WebMediaHints):
(WebKit::WebMediaHints::operator=):
(WebKit::WebMediaHints::isNull):
* src/WebICEOptions.cpp: Added.
(WebKit):
(WebKit::WebICEOptions::WebICEOptions):
(WebKit::WebICEOptions::assign):
(WebKit::WebICEOptions::reset):
(WebKit::WebICEOptions::candidateTypeToUse):
* src/WebMediaHints.cpp: Added.
(WebKit):
(WebKit::WebMediaHints::WebMediaHints):
(WebKit::WebMediaHints::assign):
(WebKit::WebMediaHints::reset):
(WebKit::WebMediaHints::audio):
(WebKit::WebMediaHints::video):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNPRuntime support for out-of-process plug-ins.
jberlin@webkit.org [Mon, 19 Mar 2012 21:26:19 +0000 (21:26 +0000)]
NPRuntime support for out-of-process plug-ins.
https://bugs.webkit.org/show_bug.cgi?id=48346

This issue was marked as fixed on 2011-01-11, but the tests that required that support were
never taken off the WK2 Skipped list.

Update the WK2 Skipped list to not skip the passing tests, and move the ones that still fail
to a separate section of the list.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unnecessary CALayer overrides from WebTileCacheLayer
andersca@apple.com [Mon, 19 Mar 2012 21:24:50 +0000 (21:24 +0000)]
Remove unnecessary CALayer overrides from WebTileCacheLayer
https://bugs.webkit.org/show_bug.cgi?id=81562

Reviewed by Dan Bernstein.

* platform/graphics/ca/mac/TileCache.h:
(TileCache):
* platform/graphics/ca/mac/WebTileCacheLayer.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLLInt get_by_pname slow path incorrectly assumes that the operands are not constants
fpizlo@apple.com [Mon, 19 Mar 2012 21:18:18 +0000 (21:18 +0000)]
LLInt get_by_pname slow path incorrectly assumes that the operands are not constants
https://bugs.webkit.org/show_bug.cgi?id=81559

Reviewed by Michael Saboff.

* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCorrect usage of LayoutUnits in page code in preparation for turning on subpixel...
eae@chromium.org [Mon, 19 Mar 2012 21:05:07 +0000 (21:05 +0000)]
Correct usage of LayoutUnits in page code in preparation for turning on subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=81538

Reviewed by Eric Seidel.

Fix usage of LayoutUnits and conversions between types in page code.

No new tests.

* page/DOMWindow.cpp:
(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):
Explicitly cast long to int. InspectorInstrumentation requires a long and
FractionalLayoutUnit has no constructor that takes long.

* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEventForKey):
Pixel snap overflow rect as selection rects are integer based.

* page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath):
Pixel snap repaint rects when computing update rect as all scrolling is
done on integer bounds.

* page/GestureTapHighlighter.cpp:
Change rects vector to IntRect as addFocusRingRects operates on IntRects.

* page/Page.cpp:
(WebCore::Page::addRelevantRepaintedObject):
(WebCore::Page::addRelevantUnpaintedObject):
Change paint methods to take a LayoutRect paint rect.

* page/SpatialNavigation.cpp:
(WebCore::distanceDataForNode):
Change distance calculation to use floats instead of converting to float
at the end.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't show WONTFIX tests in garden-o-matic
ojan@chromium.org [Mon, 19 Mar 2012 21:00:38 +0000 (21:00 +0000)]
Don't show WONTFIX tests in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=81554

Reviewed by Dimitri Glazkov.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=81553
hyatt@apple.com [Mon, 19 Mar 2012 20:59:10 +0000 (20:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=81553

[New Multicolumn] Stub out classes to represent sets of column region boxes.

RenderRegionSet is an abstract class representing a set of contiguous anonymous
same-size regions.

RenderMultiColumnSet derives from RenderRegionSet and represents a set of contiguous
columns. It will also handle unique column behavior like column rule painting.

Eventually there will be a RenderPageSet derived class for printing/pages, but
that will come later after I finish rebuilding multi-column layout.

Reviewed by Dan Bernstein.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderMultiColumnSet.cpp: Added.
(WebCore):
(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::renderName):
* rendering/RenderMultiColumnSet.h: Added.
(WebCore):
(RenderMultiColumnSet):
* rendering/RenderRegionSet.cpp: Added.
(WebCore):
(WebCore::RenderRegionSet::RenderRegionSet):
* rendering/RenderRegionSet.h: Added.
(WebCore):
(RenderRegionSet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd playback state for AudioBufferSourceNode and add number of active nodes
commit-queue@webkit.org [Mon, 19 Mar 2012 20:54:50 +0000 (20:54 +0000)]
Add playback state for AudioBufferSourceNode and add number of active nodes
https://bugs.webkit.org/show_bug.cgi?id=79701

Source/WebCore:

Add a playback state to AudioBufferSourceNode so that the user can
tell if the node is scheduled, playing, or finished.

For an AudioContext, add a count of the number of
AudioBufferSourceNode's that are active (playing audio).

Deleted m_isPlaying and m_hasFinished. For the record, m_isPlaying
is the same as a playbackState of SCHEDULED_STATE or PLAYING_STATE.
m_hasFinished is equivalent to a playbackState of FINISHED_STATE.

Patch by Raymond Toy <rtoy@google.com> on 2012-03-19
Reviewed by Chris Rogers.

Test: webaudio/audiobuffersource-playbackState.html

* webaudio/AudioBufferSourceNode.cpp:
(WebCore):
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
initialize playbackState, remove m_isPlaying, m_hasFinished.
(WebCore::AudioBufferSourceNode::process): Update playbackState
(WebCore::AudioBufferSourceNode::finish): Update playbackState
(WebCore::AudioBufferSourceNode::noteOn): Update playbackState
(WebCore::AudioBufferSourceNode::noteGrainOn): Update playbackState
(WebCore::AudioBufferSourceNode::noteOff): Use playbackState
* webaudio/AudioBufferSourceNode.h:
(AudioBufferSourceNode): Define states, remove m_isPlaying, m_hasFinished.
(WebCore::AudioBufferSourceNode::playbackState): Added.
* webaudio/AudioBufferSourceNode.idl: Define constants for the
playback state, add attribute playbackState.
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::activeSourceCount): Added.
(WebCore::AudioContext::incrementActiveSourceCount): Added.
(WebCore::AudioContext::decrementActiveSourceCount): Added.
* webaudio/AudioContext.h:
(AudioContext):
* webaudio/AudioContext.idl: Add attribute activeSourceCount.

LayoutTests:

Patch by Raymond Toy <rtoy@google.com> on 2012-03-19
Reviewed by Chris Rogers.

* webaudio/audiobuffersource-playbackState-expected.txt: Added.
* webaudio/audiobuffersource-playbackState.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r109014.
commit-queue@webkit.org [Mon, 19 Mar 2012 20:43:13 +0000 (20:43 +0000)]
Unreviewed, rolling out r109014.
http://trac.webkit.org/changeset/109014
https://bugs.webkit.org/show_bug.cgi?id=81551

Causing crashes (Requested by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-19

Source/WebCore:

* rendering/style/RenderStyle.h:

LayoutTests:

* css3/flexbox/inline-flexbox-expected.html: Removed.
* css3/flexbox/inline-flexbox.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Make WebFrameLoaderClient::createFrame more like WebKit1 version.
ap@apple.com [Mon, 19 Mar 2012 20:41:59 +0000 (20:41 +0000)]
    Make WebFrameLoaderClient::createFrame more like WebKit1 version.
        https://bugs.webkit.org/show_bug.cgi?id=81550

        Covered by existing tests.

        Reviewed by Jessie Berlin.

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Implement OSAllocator::commit/decommit in the correct way
commit-queue@webkit.org [Mon, 19 Mar 2012 20:39:15 +0000 (20:39 +0000)]
[BlackBerry] Implement OSAllocator::commit/decommit in the correct way
https://bugs.webkit.org/show_bug.cgi?id=77013

We should use mmap(PROT_NONE, MAP_LAZY) instead of posix_madvise() to
implement memory decommitting for QNX.

Patch by Yong Li <yoli@rim.com> on 2012-03-19
Reviewed by Rob Buis.

* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoplatform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKi...
cfleizach@apple.com [Mon, 19 Mar 2012 20:29:41 +0000 (20:29 +0000)]
platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81530

Reviewed by Jessie Berlin.

Tools:

Add rowAtIndex to WebKitTestRunner.

* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::rowAtIndex):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR):
(WTR::AccessibilityUIElement::rowAtIndex):

LayoutTests:

* platform/mac-wk2/platform/mac/accessibility/selected-rows-table-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoediting/input/reveal-edit-on-input-vertically.html and
jberlin@webkit.org [Mon, 19 Mar 2012 20:28:39 +0000 (20:28 +0000)]
editing/input/reveal-edit-on-input-vertically.html and
editing/input/reveal-contenteditable-on-input-vertically.html timing out on Lion Intel Debug
WebKit2 testers

Add those tests to the WK2 Skipped list.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, remove headers that no longer exist or moved in WebCore.gypi.
tony@chromium.org [Mon, 19 Mar 2012 20:26:06 +0000 (20:26 +0000)]
Unreviewed, remove headers that no longer exist or moved in WebCore.gypi.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSSRegions]Implement NamedFlow::contentNodes attribute
mihnea@adobe.com [Mon, 19 Mar 2012 20:24:14 +0000 (20:24 +0000)]
[CSSRegions]Implement NamedFlow::contentNodes attribute
https://bugs.webkit.org/show_bug.cgi?id=80134

Reviewed by David Hyatt.

The named flow content nodes collection contains those nodes with webkitFlowInto property set to 'flow'.
In the list, the nodes are placed in document order. Nodes with display:none are also part of the list.
The list of nodes is returned as a static node list.

Source/WebCore:

Test: fast/regions/webkit-named-flow-content-nodes.html

* dom/Document.cpp:
(WebCore::Document::webkitGetFlowByName):
* dom/Document.h:
* dom/Element.cpp:
(WebCore::Element::detach):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::contentNodes):
(WebCore):
(WebCore::WebKitNamedFlow::registerContentNode):
* dom/WebKitNamedFlow.h:
(WebCore):
(WebKitNamedFlow):
(WebCore::WebKitNamedFlow::unregisterContentNode):
* dom/WebKitNamedFlow.idl:

LayoutTests:

* fast/regions/webkit-named-flow-content-nodes-expected.txt: Added.
* fast/regions/webkit-named-flow-content-nodes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange garden-o-matic All Failures tab to Expected Failures
ojan@chromium.org [Mon, 19 Mar 2012 20:23:12 +0000 (20:23 +0000)]
Change garden-o-matic All Failures tab to Expected Failures
https://bugs.webkit.org/show_bug.cgi?id=81540

Reviewed by Dimitri Glazkov.

Also, fix some broken unittests that had just gotten stale.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvolverNode should not incur processing latency
commit-queue@webkit.org [Mon, 19 Mar 2012 20:19:46 +0000 (20:19 +0000)]
ConvolverNode should not incur processing latency
https://bugs.webkit.org/show_bug.cgi?id=75564

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-03-19
Reviewed by Chris Rogers.

Source/WebCore:

Add the DirectConvolver instead of FFTConvolver for the processing of the leading portion of impulse response.

* WebCore.gypi:
* platform/audio/DirectConvolver.cpp: Added.
(WebCore):
(WebCore::DirectConvolver::DirectConvolver):
(WebCore::DirectConvolver::process):
(WebCore::DirectConvolver::reset):
* platform/audio/DirectConvolver.h: Added.
(WebCore):
(DirectConvolver):
(WebCore::DirectConvolver::convolveSize):
* platform/audio/ReverbConvolver.cpp:
(WebCore::ReverbConvolver::ReverbConvolver):
* platform/audio/ReverbConvolver.h:
* platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::ReverbConvolverStage):
(WebCore::ReverbConvolverStage::process):
(WebCore::ReverbConvolverStage::reset):
* platform/audio/ReverbConvolverStage.h:
(WebCore):
(ReverbConvolverStage):

LayoutTests:

No need to check the initial silent part because the latency issue of ConvolverNode is fixed.

* webaudio/convolution-mono-mono-expected.txt:
* webaudio/resources/convolution-testing.js:
(checkTriangularPulse):
(checkTail1):
(checkConvolvedResult.return.var):
(checkConvolvedResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Find in page highlights get out of place when scrolling
andersca@apple.com [Mon, 19 Mar 2012 20:13:40 +0000 (20:13 +0000)]
Source/WebCore: Find in page highlights get out of place when scrolling
https://bugs.webkit.org/show_bug.cgi?id=81543

Reviewed by Sam Weinig.

Remove a now unused function from GraphicsLayer.

* platform/graphics/GraphicsLayer.h:
(GraphicsLayer):
* platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):

Source/WebKit2: Find in page highlights get out of place when scrolling
https://bugs.webkit.org/show_bug.cgi?id=81543
<rdar://problem/10932590>

Reviewed by Sam Weinig.

When we have a page overlay layer, always force a full repaint of it whenever the page changes.
If this turns out to be a real performance problem (measurements suggest that it isn't), we could once
again try to figure out when a full page repaint is needed. Doing so could probably be more expensive than
simply repainting the page, given that a page overlay consists of a bunch of rect-fills mostly.

Also turn on accelerated drawing for the page overlay layer, since that cut CPU usage in half when scrolling
on a page that had a find overlay visible.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Test cleanup - don't create transactions w/in transaction callback
jsbell@chromium.org [Mon, 19 Mar 2012 20:12:24 +0000 (20:12 +0000)]
IndexedDB: Test cleanup - don't create transactions w/in transaction callback
https://bugs.webkit.org/show_bug.cgi?id=81532

The spec precludes creating transactions within a synchronous transaction callback;
for the current implementation, that's only the success callback for a setVersion()
call. This isn't enforced yet - see http://webkit.org/b/80547

Reviewed by Tony Chang.

* storage/indexeddb/create-and-remove-object-store.html: Split out oncomplete handler.
* storage/indexeddb/create-object-store-options.html: Split out oncomplete handler.
* storage/indexeddb/factory-deletedatabase.html: Listen on complete event.
* storage/indexeddb/mozilla/autoincrement-indexes.html: Split out oncomplete handler.
* storage/indexeddb/mozilla/clear.html: Listen on complete event.
* storage/indexeddb/mozilla/indexes.html: Split out oncomplete handler.
* storage/indexeddb/mozilla/readonly-transactions.html: Split out oncomplete handler.
* storage/indexeddb/mozilla/readwrite-transactions.html: Split out oncomplete handler.
* storage/indexeddb/noblobs.html: Pass function reference, don't call function.
* storage/indexeddb/objectstore-clear.html: Split out oncomplete handler.
* storage/indexeddb/objectstore-removeobjectstore.html: Listen on complete event.
* storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html: Split out oncomplete handler.
* storage/indexeddb/transaction-abort-with-js-recursion.html: Split out oncomplete handler.
* storage/indexeddb/transaction-crash-on-abort.html: Split out oncomplete handler.
* storage/indexeddb/two-version-changes.html: Split out oncomplete handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Marking fast/text/international/font-fallback-to-common-script.html as...
leviw@chromium.org [Mon, 19 Mar 2012 20:09:55 +0000 (20:09 +0000)]
[Chromium] Marking fast/text/international/font-fallback-to-common-script.html as flaky for image
tests on all flavors of Chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed - revent a couple of files accidentally committed.
barraclough@apple.com [Mon, 19 Mar 2012 19:59:03 +0000 (19:59 +0000)]
Unreviewed - revent a couple of files accidentally committed.

* runtime/Arguments.cpp:
(JSC::Arguments::defineOwnProperty):
* runtime/JSFunction.cpp:
(JSC::JSFunction::defineOwnProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMarking css3/images/cross-fade-invalidation.html as flaky for image tests on Chromium...
leviw@chromium.org [Mon, 19 Mar 2012 19:58:44 +0000 (19:58 +0000)]
Marking css3/images/cross-fade-invalidation.html as flaky for image tests on Chromium Snowleopard.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agor98413 updated the platform/mac-wk2/plugins/contents-scale-factor test without updati...
jberlin@webkit.org [Mon, 19 Mar 2012 19:49:52 +0000 (19:49 +0000)]
r98413 updated the platform/mac-wk2/plugins/contents-scale-factor test without updating the
expected results.

Update the expected results.

* platform/mac-wk2/plugins/contents-scale-factor-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] DRT crashes at shutdown.
commit-queue@webkit.org [Mon, 19 Mar 2012 19:46:09 +0000 (19:46 +0000)]
[chromium] DRT crashes at shutdown.
https://bugs.webkit.org/show_bug.cgi?id=81504

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-03-19
Reviewed by James Robinson.

WebCompositor must be destroyed after WebView is properly destroyed,
or some compositor objects like CCLayerTreeHost may not be destroyed.
However, it is really hard to make the destruction order correct
explicitly in ~TestShell. So move it out to DumpRenderTree.

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::~TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWhen Find overlay first appears and the page scrolls, the scrolling happens through...
andersca@apple.com [Mon, 19 Mar 2012 19:43:35 +0000 (19:43 +0000)]
When Find overlay first appears and the page scrolls, the scrolling happens through a fade
https://bugs.webkit.org/show_bug.cgi?id=81539
<rdar://problem/11031093>

Reviewed by Dan Bernstein.

Disable implicit animations when adding the page overlay layer to its superlayer.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] fast/events/touch/gesture/pad-gesture-fling.html fails on release builds
leviw@chromium.org [Mon, 19 Mar 2012 19:41:17 +0000 (19:41 +0000)]
[chromium] fast/events/touch/gesture/pad-gesture-fling.html fails on release builds
https://bugs.webkit.org/show_bug.cgi?id=81537

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-19

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=81534
hyatt@apple.com [Mon, 19 Mar 2012 19:28:39 +0000 (19:28 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=81534

[New Multicolumn] Make the multi-column block re-layout its children when the column width/count change.
Cache the count/width on the multi-column block for easy access.

Reviewed by Antti Koivisto.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::recomputeLogicalWidth):
(WebCore::RenderBlock::layoutBlock):
* rendering/RenderBlock.h:
Virtualize the code that recomputes the logical width for a block and sets relayoutChildren to true,
so that column code can subclass the method to also check for changes in the column width/count.

* rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::computeColumnCountAndWidth):
The column count/width determination algorithm in one method on the RenderMultiColumnBlock. It's a copy
of the code from RenderBlock (which will be going away eventually).

(WebCore::RenderMultiColumnBlock::recomputeLogicalWidth):
* rendering/RenderMultiColumnBlock.h:
(RenderMultiColumnBlock):
Subclassed method to also check for changes in the column width to set relayoutChildren to true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Updating WebGraphicsContext3D MemoryAllocation callback to accept a struct...
commit-queue@webkit.org [Mon, 19 Mar 2012 19:19:12 +0000 (19:19 +0000)]
[chromium] Updating WebGraphicsContext3D MemoryAllocation callback to accept a struct with have backbuffer suggestion.
https://bugs.webkit.org/show_bug.cgi?id=81279

Patch by Michal Mocny <mmocny@google.com> on 2012-03-19
Reviewed by James Robinson.

Source/Platform:

Adding a suggestHaveBackbuffer hint to the WebGraphicsContext3D memory allocation callback.

* chromium/public/WebGraphicsContext3D.h:
(WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::WebGraphicsMemoryAllocationChangedCallbackCHROMIUM::onMemoryAllocationChanged):
* chromium/public/WebGraphicsMemoryAllocation.h: Added.
(WebKit):
(WebGraphicsMemoryAllocation):
(WebKit::WebGraphicsMemoryAllocation::WebGraphicsMemoryAllocation):

Source/WebCore:

* platform/graphics/chromium/Extensions3DChromium.h:
(GpuMemoryAllocationCHROMIUM):
(WebCore::Extensions3DChromium::GpuMemoryAllocationCHROMIUM::GpuMemoryAllocationCHROMIUM):
(GpuMemoryAllocationChangedCallbackCHROMIUM):

Source/WebKit/chromium:

* src/GraphicsContext3DChromium.cpp:
(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoadd dpranke to webkitpy watchlist
dpranke@chromium.org [Mon, 19 Mar 2012 19:14:03 +0000 (19:14 +0000)]
add dpranke to webkitpy watchlist
https://bugs.webkit.org/show_bug.cgi?id=81433

Reviewed by Benjamin Poulain.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoflex-item-align: stretch should only grow, never shrink
tony@chromium.org [Mon, 19 Mar 2012 19:11:14 +0000 (19:11 +0000)]
flex-item-align: stretch should only grow, never shrink
https://bugs.webkit.org/show_bug.cgi?id=80882

Reviewed by Ojan Vafai.

Source/WebCore:

New test cases in css3/flexbox/flex-align-stretch.html.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::alignChildren): Move stretch code into a separate function.
(WebCore::RenderFlexibleBox::alignChildStretch): Add an early return if our height is shrinking.
(WebCore):
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):

LayoutTests:

* css3/flexbox/child-overflow-expected.html:
* css3/flexbox/child-overflow.html: For cases that overflow the height, we now just overflow rather than reducing the height.
* css3/flexbox/flex-align-stretch-expected.txt:
* css3/flexbox/flex-align-stretch.html: New test cases.
* platform/chromium/test_expectations.txt: Mark as failing on Windows
because of mock scrollbar rendering bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agotest-webkitpy is failing on SL/Python 2.6.1
dpranke@chromium.org [Mon, 19 Mar 2012 19:08:01 +0000 (19:08 +0000)]
test-webkitpy is failing on SL/Python 2.6.1
https://bugs.webkit.org/show_bug.cgi?id=81533

Reviewed by Ojan Vafai.

It appears that itertools.combinations() is buggy in 2.6.1; this
backports the implementation from 2.7.

* Scripts/webkitpy/layout_tests/models/test_configuration.py:
(TestConfigurationConverter.collapse_macros):
(TestConfigurationConverter):
(TestConfigurationConverter.combinations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Implement snippets evaluation.
vsevik@chromium.org [Mon, 19 Mar 2012 19:02:27 +0000 (19:02 +0000)]
Web Inspector: Implement snippets evaluation.
https://bugs.webkit.org/show_bug.cgi?id=81334

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.evaluateUsingTextPrompt):
(WebInspector.ConsoleView.prototype._enterKeyPressed):
* inspector/front-end/ScriptMapping.js:
(WebInspector.MainScriptMapping):
* inspector/front-end/SnippetsModel.js:
* inspector/front-end/externs.js:
(WebInspector.evaluateInConsole):
* inspector/front-end/inspector.js:
(WebInspector.evaluateInConsole):

LayoutTests:

* inspector/debugger/snippets-model-expected.txt:
* inspector/debugger/snippets-model.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: LayoutTests don't need explicit console div
jsbell@chromium.org [Mon, 19 Mar 2012 18:39:19 +0000 (18:39 +0000)]
IndexedDB: LayoutTests don't need explicit console div
https://bugs.webkit.org/show_bug.cgi?id=81370

Remove unneeded div and p tags (added by js-test-pre.js) and
unnecessary jsTestIsAsync = true (set by shared.js).

Reviewed by Tony Chang.

* storage/indexeddb/basics-shared-workers.html:
* storage/indexeddb/basics-workers.html:
* storage/indexeddb/basics.html:
* storage/indexeddb/constants.html:
* storage/indexeddb/create-and-remove-object-store.html:
* storage/indexeddb/create-object-store-options.html:
* storage/indexeddb/createObjectStore-name-argument-required.html:
* storage/indexeddb/createObjectStore-null-name.html:
* storage/indexeddb/cursor-continue.html:
* storage/indexeddb/cursor-delete.html:
* storage/indexeddb/cursor-inconsistency.html:
* storage/indexeddb/cursor-index-delete.html:
* storage/indexeddb/cursor-key-order.html:
* storage/indexeddb/cursor-primary-key-order.html:
* storage/indexeddb/cursor-reverse-bug.html:
* storage/indexeddb/cursor-skip-deleted.html:
* storage/indexeddb/cursor-update-value-argument-required.html:
* storage/indexeddb/cursor-update.html:
* storage/indexeddb/data-corruption.html:
* storage/indexeddb/database-basics.html:
* storage/indexeddb/database-name-undefined.html:
* storage/indexeddb/database-odd-names.html:
* storage/indexeddb/database-quota.html:
* storage/indexeddb/delete-closed-database-object.html:
* storage/indexeddb/delete-range.html:
* storage/indexeddb/deleteIndex.html:
* storage/indexeddb/deleteObjectStore-name-argument-required.html:
* storage/indexeddb/deleteObjectStore-null-name.html:
* storage/indexeddb/duplicates.html:
* storage/indexeddb/error-causes-abort-by-default.html:
* storage/indexeddb/exception-in-event-aborts-expected.txt:
* storage/indexeddb/exception-in-event-aborts.html:
* storage/indexeddb/factory-basics.html:
* storage/indexeddb/factory-cmp.html:
* storage/indexeddb/factory-deletedatabase-interactions.html:
* storage/indexeddb/factory-deletedatabase.html:
* storage/indexeddb/index-basics-workers.html:
* storage/indexeddb/index-basics.html:
* storage/indexeddb/index-count.html:
* storage/indexeddb/index-cursor.html:
* storage/indexeddb/index-get-key-argument-required.html:
* storage/indexeddb/index-multientry.html:
* storage/indexeddb/index-population.html:
* storage/indexeddb/index-unique.html:
* storage/indexeddb/invalid-keys.html:
* storage/indexeddb/key-generator.html:
* storage/indexeddb/key-sort-order-across-types.html:
* storage/indexeddb/key-sort-order-date.html:
* storage/indexeddb/key-type-array.html:
* storage/indexeddb/key-type-infinity.html:
* storage/indexeddb/keypath-basics.html:
* storage/indexeddb/keypath-edges.html:
* storage/indexeddb/keypath-fetch-key.html:
* storage/indexeddb/keyrange-required-arguments.html:
* storage/indexeddb/keyrange.html:
* storage/indexeddb/list-ordering-expected.txt:
* storage/indexeddb/list-ordering.html:
* storage/indexeddb/mozilla/add-twice-failure.html:
* storage/indexeddb/mozilla/autoincrement-indexes.html:
* storage/indexeddb/mozilla/bad-keypath.html:
* storage/indexeddb/mozilla/clear.html:
* storage/indexeddb/mozilla/create-index-unique.html:
* storage/indexeddb/mozilla/create-index-with-integer-keys.html:
* storage/indexeddb/mozilla/create-objectstore-basics.html:
* storage/indexeddb/mozilla/create-objectstore-null-name.html:
* storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html:
* storage/indexeddb/mozilla/cursor-mutation.html:
* storage/indexeddb/mozilla/cursor-update-updates-indexes.html:
* storage/indexeddb/mozilla/cursors.html:
* storage/indexeddb/mozilla/delete-result.html:
* storage/indexeddb/mozilla/event-source.html:
* storage/indexeddb/mozilla/global-data.html:
* storage/indexeddb/mozilla/indexes.html:
* storage/indexeddb/mozilla/key-requirements-delete-null-key.html:
* storage/indexeddb/mozilla/key-requirements-inline-and-passed.html:
* storage/indexeddb/mozilla/key-requirements-put-no-key.html:
* storage/indexeddb/mozilla/key-requirements-put-null-key.html:
* storage/indexeddb/mozilla/key-requirements.html:
* storage/indexeddb/mozilla/object-cursors.html:
* storage/indexeddb/mozilla/object-identity.html:
* storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html:
* storage/indexeddb/mozilla/object-store-remove-values.html:
* storage/indexeddb/mozilla/objectstorenames.html:
* storage/indexeddb/mozilla/odd-result-order.html:
* storage/indexeddb/mozilla/open-database-null-name.html:
* storage/indexeddb/mozilla/put-get-values.html:
* storage/indexeddb/mozilla/readonly-transactions.html:
* storage/indexeddb/mozilla/readwrite-transactions.html:
* storage/indexeddb/mozilla/readyState.html:
* storage/indexeddb/mozilla/remove-index.html:
* storage/indexeddb/mozilla/remove-objectstore.html:
* storage/indexeddb/mozilla/versionchange-abort.html:
* storage/indexeddb/mozilla/versionchange.html:
* storage/indexeddb/mutating-cursor.html:
* storage/indexeddb/noblobs-expected.txt:
* storage/indexeddb/noblobs.html:
* storage/indexeddb/objectStore-required-arguments.html:
* storage/indexeddb/objectstore-autoincrement.html:
* storage/indexeddb/objectstore-basics-workers.html:
* storage/indexeddb/objectstore-basics.html:
* storage/indexeddb/objectstore-clear.html:
* storage/indexeddb/objectstore-count.html:
* storage/indexeddb/objectstore-cursor.html:
* storage/indexeddb/objectstore-removeobjectstore.html:
* storage/indexeddb/odd-strings.html:
* storage/indexeddb/open-close-version.html:
* storage/indexeddb/open-cursor.html:
* storage/indexeddb/open-during-transaction.html:
* storage/indexeddb/prefetch-bugfix-108071.html:
* storage/indexeddb/queued-commands.html:
* storage/indexeddb/readonly-properties.html:
* storage/indexeddb/readonly.html:
* storage/indexeddb/request-event-propagation.html:
* storage/indexeddb/setVersion-null.html:
* storage/indexeddb/setVersion-undefined.html:
* storage/indexeddb/set_version_blocked.html:
* storage/indexeddb/set_version_queue.html:
* storage/indexeddb/structured-clone-expected.txt:
* storage/indexeddb/structured-clone.html:
* storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
* storage/indexeddb/transaction-abort-with-js-recursion.html:
* storage/indexeddb/transaction-abort-workers.html:
* storage/indexeddb/transaction-abort.html:
* storage/indexeddb/transaction-after-close.html:
* storage/indexeddb/transaction-and-objectstore-calls.html:
* storage/indexeddb/transaction-basics.html:
* storage/indexeddb/transaction-crash-on-abort.html:
* storage/indexeddb/transaction-event-propagation.html:
* storage/indexeddb/transaction-read-only.html:
* storage/indexeddb/transaction-rollback.html:
* storage/indexeddb/transaction-storeNames-required.html:
* storage/indexeddb/two-version-changes.html:
* storage/indexeddb/value-undefined.html:
* storage/indexeddb/values-odd-types.html:
* storage/indexeddb/version-change-abort-expected.txt:
* storage/indexeddb/version-change-abort.html:
* storage/indexeddb/version-change-exclusive.html:
* storage/indexeddb/versionchangerequest-activedomobject.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoplatform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKi...
jberlin@webkit.org [Mon, 19 Mar 2012 18:36:35 +0000 (18:36 +0000)]
platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81530

Add expected failing results for mac-wk2 to get the bots green.

* platform/mac-wk2/platform/mac/accessibility/selected-rows-table-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Use BlackBerry::Platform::DeviceInfo to generate UserAgent
commit-queue@webkit.org [Mon, 19 Mar 2012 18:36:25 +0000 (18:36 +0000)]
[BlackBerry] Use BlackBerry::Platform::DeviceInfo to generate UserAgent
https://bugs.webkit.org/show_bug.cgi?id=81269

Generate the UserAgent lazily, using it as the default for the
WebSettings object. BlackBerry::Platform::DeviceInfo is used
to ensure the information is accurate to the specific device.

Remove the !isEmpty() assert when fetching the UA from the
WebSettings object, as it will now always be properly initialized.

Add a static initializer block to ensure defaultUserAgent() is
thread-safe from that moment onward.

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-03-19
Reviewed by Rob Buis.

* Api/WebPage.cpp:
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):
* Api/WebPage_p.h:
(WebPagePrivate):
* Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::setUserAgentString):
* Api/WebSettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMediaStream API (JSEP): Introducing PeerConnection00Handler
tommyw@google.com [Mon, 19 Mar 2012 18:33:20 +0000 (18:33 +0000)]
MediaStream API (JSEP): Introducing PeerConnection00Handler
https://bugs.webkit.org/show_bug.cgi?id=81333

Reviewed by Adam Barth.

In preparation of the last WebCore patch that will introduce PeerConnection00 here's its platform representation.

Not possible to test until the entire JSEP feature is commited.

* GNUmakefile.list.am:
* WebCore.gypi:
* platform/mediastream/PeerConnection00Handler.cpp: Added.
(WebCore):
(WebCore::PeerConnection00Handler::create):
(WebCore::PeerConnection00Handler::PeerConnection00Handler):
(WebCore::PeerConnection00Handler::~PeerConnection00Handler):
(WebCore::PeerConnection00Handler::createOffer):
(WebCore::PeerConnection00Handler::createAnswer):
(WebCore::PeerConnection00Handler::setLocalDescription):
(WebCore::PeerConnection00Handler::setRemoteDescription):
(WebCore::PeerConnection00Handler::localDescription):
(WebCore::PeerConnection00Handler::remoteDescription):
(WebCore::PeerConnection00Handler::startIce):
(WebCore::PeerConnection00Handler::processIceMessage):
(WebCore::PeerConnection00Handler::addStream):
(WebCore::PeerConnection00Handler::removeStream):
(WebCore::PeerConnection00Handler::stop):
* platform/mediastream/PeerConnection00Handler.h: Added.
(WebCore):
(PeerConnection00Handler):
* platform/mediastream/PeerConnection00HandlerClient.h: Added.
(WebCore):
(PeerConnection00HandlerClient):
(WebCore::PeerConnection00HandlerClient::~PeerConnection00HandlerClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] GL_EXT_occlusion_query_boolean and GL_CHROMIUM_command_buffer_query support.
commit-queue@webkit.org [Mon, 19 Mar 2012 18:27:42 +0000 (18:27 +0000)]
[Chromium] GL_EXT_occlusion_query_boolean and GL_CHROMIUM_command_buffer_query support.
https://bugs.webkit.org/show_bug.cgi?id=80988

Patch by David Reveman <reveman@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

Source/Platform:

Add EXT_occlusion_query API to WebGraphicsContext3D.

* chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):

Source/WebCore:

Expose EXT_occlusion_query API to WebKit compositor. Add
GL_EXT_occlusion_query_boolean and GL_CHROMIUM_command_buffer_query
enums.

* platform/graphics/chromium/Extensions3DChromium.h:
(Extensions3DChromium):

Source/WebKit/chromium:

Expose EXT_occlusion_query API to WebKit compositor.

* src/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::createQueryEXT):
(WebCore):
(WebCore::Extensions3DChromium::deleteQueryEXT):
(WebCore::Extensions3DChromium::isQueryEXT):
(WebCore::Extensions3DChromium::beginQueryEXT):
(WebCore::Extensions3DChromium::endQueryEXT):
(WebCore::Extensions3DChromium::getQueryivEXT):
(WebCore::Extensions3DChromium::getQueryObjectuivEXT):
* src/GraphicsContext3DChromium.cpp:
(WebCore):
* src/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
* tests/FakeWebGraphicsContext3D.h:
(WebKit::FakeWebGraphicsContext3D::createQueryEXT):
(WebKit::FakeWebGraphicsContext3D::deleteQueryEXT):
(WebKit::FakeWebGraphicsContext3D::isQueryEXT):
(WebKit::FakeWebGraphicsContext3D::beginQueryEXT):
(WebKit::FakeWebGraphicsContext3D::endQueryEXT):
(WebKit::FakeWebGraphicsContext3D::getQueryivEXT):
(WebKit::FakeWebGraphicsContext3D::getQueryObjectuivEXT):
(FakeWebGraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Input fields with id of e-mail and url should be styled as such.
mifenton@rim.com [Mon, 19 Mar 2012 18:16:48 +0000 (18:16 +0000)]
[BlackBerry] Input fields with id of e-mail and url should be styled as such.
https://bugs.webkit.org/show_bug.cgi?id=81364

Reviewed by Rob Buis.

Be less aggressive on matching url, and update as suggested by Rob.

* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::matchesReservedStringUrl):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::inputStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS3 calc: make mask images work with mixed percent/absolute
mikelawther@chromium.org [Mon, 19 Mar 2012 18:02:37 +0000 (18:02 +0000)]
CSS3 calc: make mask images work with mixed percent/absolute
https://bugs.webkit.org/show_bug.cgi?id=81477

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/calc/simple-composited-mask-expected.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

* css3/calc/simple-composited-mask-expected.html: Renamed from LayoutTests/css3/calc/simple-composited-mask-expected-mismatch.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOptimize the cleanup sequence in the start-queue.sh script
abarth@webkit.org [Mon, 19 Mar 2012 17:52:18 +0000 (17:52 +0000)]
Optimize the cleanup sequence in the start-queue.sh script
https://github.com/abarth/webkit/pull/1

Patch by David Michael Barr <davidbarr@google.com> on 2012-03-19
Reviewed by Adam Barth.

Updating the working copy is an expensive operation
for a repository the size of WebKit.
Attempt to reset only to the target revision.

* EWSTools/start-queue.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStyle cleanup in Modules/filesystem/
commit-queue@webkit.org [Mon, 19 Mar 2012 17:46:06 +0000 (17:46 +0000)]
Style cleanup in Modules/filesystem/
https://bugs.webkit.org/show_bug.cgi?id=81520

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-19
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* Modules/filesystem/AsyncFileWriter.h:
(WebCore::AsyncFileWriter::~AsyncFileWriter):
* Modules/filesystem/AsyncFileWriterClient.h:
(WebCore::AsyncFileWriterClient::~AsyncFileWriterClient):
* Modules/filesystem/DOMFilePath.cpp:
(WebCore::DOMFilePath::getDirectory):
* Modules/filesystem/DOMFilePath.h:
(DOMFilePath):
* Modules/filesystem/DOMFileSystemBase.h:
(DOMFileSystemBase):
* Modules/filesystem/DirectoryEntry.h:
* Modules/filesystem/DirectoryEntrySync.h:
* Modules/filesystem/EntryArray.h:
(EntryArray):
* Modules/filesystem/FileEntry.h:
(FileEntry):
* Modules/filesystem/FileSystemCallbacks.h:
(FileSystemCallbacksBase):
* Modules/filesystem/FileWriter.cpp:
(WebCore::FileWriter::abort):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash when closing an inspected web page with tiled drawing enabled
andersca@apple.com [Mon, 19 Mar 2012 17:37:18 +0000 (17:37 +0000)]
Crash when closing an inspected web page with tiled drawing enabled
https://bugs.webkit.org/show_bug.cgi?id=81524
<rdar://problem/11062396>

Reviewed by Sam Weinig.

Guard against the WebPage's underlying WebCore Page being null, which can happen
when the inspector highlight overlay is uninstalled by the inspector when the inspected
page goes away.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago FAILED: m_loadState == LoadStateProvisional on http/tests/multipart/load...
ap@apple.com [Mon, 19 Mar 2012 17:37:01 +0000 (17:37 +0000)]
    FAILED: m_loadState == LoadStateProvisional on http/tests/multipart/load-last-non-html-frame.php
        https://bugs.webkit.org/show_bug.cgi?id=81365

        * platform/wk2/Skipped: Skipped the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS3 calc: background positioning works with mixed percent/absolute expressions
mikelawther@chromium.org [Mon, 19 Mar 2012 17:34:18 +0000 (17:34 +0000)]
CSS3 calc: background positioning works with mixed percent/absolute expressions
https://bugs.webkit.org/show_bug.cgi?id=81478

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/calc/background-position-parsing-expected.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

* css3/calc/background-position-parsing-expected.html: Renamed from LayoutTests/css3/calc/background-position-parsing-expected-mismatch.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMerge _q_commitScaleChange and _q_commitPositionChange
kenneth@webkit.org [Mon, 19 Mar 2012 17:10:17 +0000 (17:10 +0000)]
Merge _q_commitScaleChange and _q_commitPositionChange
https://bugs.webkit.org/show_bug.cgi?id=81511

Reviewed by Simon Hausmann.

Both methods were used for notifying WebCore of the new
viewport and re-tiling. The methods are merge into
_q_contentViewportChanged.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_contentViewportChanged):
(QQuickWebViewFlickablePrivate::_q_resume):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate::_q_contentViewportChanged):
(QQuickWebViewFlickablePrivate):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::flickableMovingPositionUpdate):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd NodeRenderStyle.h to TouchAdjustment.cpp
ahf@0x90.dk [Mon, 19 Mar 2012 17:09:53 +0000 (17:09 +0000)]
Add NodeRenderStyle.h to TouchAdjustment.cpp

Unreviewed build fix after r111185.

* page/TouchAdjustment.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother Windows build fix after r111129.
jberlin@webkit.org [Mon, 19 Mar 2012 16:57:29 +0000 (16:57 +0000)]
Another Windows build fix after r111129.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unit test fix, save the sharedQuadState while the quads hold a pointer...
commit-queue@webkit.org [Mon, 19 Mar 2012 16:53:25 +0000 (16:53 +0000)]
[chromium] Unit test fix, save the sharedQuadState while the quads hold a pointer to it
https://bugs.webkit.org/show_bug.cgi?id=81476

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

* tests/CCQuadCullerTest.cpp:
(WebCore::appendQuads):
(WebCore):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCross-platform processor core counter: fix build on FreeBSD.
kubo@profusion.mobi [Mon, 19 Mar 2012 16:48:35 +0000 (16:48 +0000)]
Cross-platform processor core counter: fix build on FreeBSD.
https://bugs.webkit.org/show_bug.cgi?id=81482

Reviewed by Zoltan Herczeg.

The documentation of sysctl(3) shows that <sys/types.h> should be
included before <sys/sysctl.h> (sys/types.h tends to be the first
included header in general).

This should fix the build on FreeBSD and other systems where
sysctl.h really depends on types defined in types.h.

* wtf/NumberOfCores.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Add PlatformMediaEngineClassName for blackberry in platform/graphics...
leo.yang@torchmobile.com.cn [Mon, 19 Mar 2012 16:46:02 +0000 (16:46 +0000)]
[BlackBerry] Add PlatformMediaEngineClassName for blackberry in platform/graphics/MediaPlayer.cpp
https://bugs.webkit.org/show_bug.cgi?id=81489

Reviewed by Rob Buis.

* platform/graphics/MediaPlayer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdjust architecture type of the EFL build bot.
kubo@profusion.mobi [Mon, 19 Mar 2012 16:43:26 +0000 (16:43 +0000)]
Adjust architecture type of the EFL build bot.
https://bugs.webkit.org/show_bug.cgi?id=81452

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2012-03-19
Reviewed by Tony Chang.

* BuildSlaveSupport/build.webkit.org-config/config.json: The
buildslave is a 64-bit machine, therefore describe it as being
x86_64, not i386.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSet the svn:ignore property on the Xcode project.
mitz@apple.com [Mon, 19 Mar 2012 16:37:36 +0000 (16:37 +0000)]
Set the svn:ignore property on the Xcode project.

* WTF.xcodeproj: Added property svn:ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream the BlackBerry change to platform/PlatformKeyboardEvent.h
leo.yang@torchmobile.com.cn [Mon, 19 Mar 2012 16:23:16 +0000 (16:23 +0000)]
[BlackBerry] Upstream the BlackBerry change to platform/PlatformKeyboardEvent.h
https://bugs.webkit.org/show_bug.cgi?id=81312

Reviewed by Rob Buis.

* platform/PlatformKeyboardEvent.h:
(Platform):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
(PlatformKeyboardEvent):
(WebCore::PlatformKeyboardEvent::unmodifiedCharacter):
Add BlackBerry specific constructor and member fields.
* platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
Change the parameter type to const reference type to adapt to the declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] printLoadedUrls prints "Object" instead of the actual URL. https://bugs.webkit...
ahf@0x90.dk [Mon, 19 Mar 2012 16:22:37 +0000 (16:22 +0000)]
[Qt] printLoadedUrls prints "Object" instead of the actual URL. https://bugs.webkit.org/show_bug.cgi?id=81514

Reviewed by Simon Hausmann.

* MiniBrowser/qt/qml/BrowserWindow.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaselining fixed-position-scroll now that more bots have come in.
leviw@chromium.org [Mon, 19 Mar 2012 16:21:22 +0000 (16:21 +0000)]
[chromium] Rebaselining fixed-position-scroll now that more bots have come in.

* platform/chromium-mac-snowleopard/compositing/layer-creation: Removed.
* platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.png: Removed.
* platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.txt: Removed.
* platform/chromium-mac/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
* platform/chromium-win/compositing/layer-creation/fixed-position-scroll-expected.txt: Removed.
* platform/chromium/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix after r111129.
jberlin@webkit.org [Mon, 19 Mar 2012 16:18:56 +0000 (16:18 +0000)]
Windows build fix after r111129.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
kubo@profusion.mobi [Mon, 19 Mar 2012 16:07:19 +0000 (16:07 +0000)]
[EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
https://bugs.webkit.org/show_bug.cgi?id=81491

Reviewed by Philippe Normand.

For the find_path(), find_library() etc CMake calls to find the
dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly
set, otherwise CMake cannot know the dependencies exist and will only
look in the standard directories.

* efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with
the jhbuild Root directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Add XDG env vars to jhbuildrc
kubo@profusion.mobi [Mon, 19 Mar 2012 16:05:17 +0000 (16:05 +0000)]
[EFL] Add XDG env vars to jhbuildrc
https://bugs.webkit.org/show_bug.cgi?id=81510

Needed to ensure correct glib behaviour in jhbuild environment.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-19
Reviewed by Philippe Normand.

* efl/jhbuildrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSelect best target for tap gesture.
commit-queue@webkit.org [Mon, 19 Mar 2012 15:33:26 +0000 (15:33 +0000)]
Select best target for tap gesture.
https://bugs.webkit.org/show_bug.cgi?id=78801

Source/WebCore:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.
IntRect changes reviewed by Dave Hyatt.

The new API is available through EventHandler::bestClickableNodeForTouchPoint, but
implementation details have been placed in page/TouchAdjustment.

The default hit detection is performed by measuring the distance to the center
lines of the absolute rects of the hit nodes. Absolute rects are used instead
of bounding rects to make hit-detecting against links over line breaks. Distance
to center line is used to make it easier to hit small links next to large links.
For line-rects the distance to the center-line is a better expression of the distance
to a rectangles center than the distance to the center-point.

Tests: touchadjustment/event-triggered-widgets.html
       touchadjustment/html-label.html
       touchadjustment/nested-touch.html
       touchadjustment/touch-inlines.html

* Target.pri:
* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureTap):
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
* page/EventHandler.h:
* page/TouchAdjustment.cpp: Added.
(WebCore::TouchAdjustment::QuadForHitTest::QuadForHitTest):
(WebCore::TouchAdjustment::QuadForHitTest::node):
(WebCore::TouchAdjustment::QuadForHitTest::quad):
(WebCore::TouchAdjustment::QuadForHitTest::boundingBox):
(WebCore::TouchAdjustment::nodeRespondsToTapGesture):
(WebCore::TouchAdjustment::appendAbsoluteQuadsForNodeToHitTestList):
(WebCore::TouchAdjustment::compileQuadsForHitTesting):
(WebCore::TouchAdjustment::distanceSquaredToQuadCenterLine):
(WebCore::TouchAdjustment::findNodeWithLowestMetric):
(WebCore::findBestClickableCandidate):
* page/TouchAdjustment.h: Added.
* platform/graphics/FloatQuad.h:
(WebCore::FloatQuad::center):
* platform/graphics/IntPoint.h:
(WebCore::IntPoint::distanceSquaredToPoint):
* platform/graphics/IntRect.cpp:
(WebCore::distanceToInterval):
(WebCore::IntRect::differenceToPoint):
(WebCore::IntRect::differenceFromCenterLineToPoint):
* platform/graphics/IntRect.h:
(WebCore::IntRect::distanceSquaredToPoint):
(WebCore::IntRect::distanceSquaredFromCenterLineToPoint):
* platform/graphics/IntSize.h:
(WebCore::IntSize::diagonalLengthSquared):
* testing/Internals.cpp:
(WebCore::Internals::touchPositionAdjustedToBestClickableNode):
(WebCore::Internals::touchNodeAdjustedToBestClickableNode):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit2:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.

Send radius to handlePotentialSingleTapEvent so it can do the same hit
detection the tap gesture later does.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handlePotentialActivation):
* UIProcess/WebPageProxy.h:
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handlePotentialSingleTapEvent):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::highlightPotentialActivation):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

Tools:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.

Add TOUCH_ADJUSTMENT to enabled features.

* qmake/mkspecs/features/features.prf:

LayoutTests:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.

Test of touch adjustments. Tests several both normal and tricky cases.

* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/win/Skipped:
* touchadjustment/event-triggered-widgets-expected.txt: Added.
* touchadjustment/event-triggered-widgets.html: Added.
* touchadjustment/html-label-expected.txt: Added.
* touchadjustment/html-label.html: Added.
* touchadjustment/nested-touch-expected.txt: Added.
* touchadjustment/nested-touch.html: Added.
* touchadjustment/touch-inlines-expected.txt: Added.
* touchadjustment/touch-inlines.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd ENABLED(FILE_SYSTEM) to DOMFilePath.h
commit-queue@webkit.org [Mon, 19 Mar 2012 15:11:16 +0000 (15:11 +0000)]
Add ENABLED(FILE_SYSTEM) to DOMFilePath.h
https://bugs.webkit.org/show_bug.cgi?id=81393

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-19
Reviewed by Kentaro Hara.

No new tests, all existing tests pass.

* Modules/filesystem/DOMFilePath.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Mon, 19 Mar 2012 14:54:33 +0000 (14:54 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-19

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] synthesize wheel events for fling on main thread
commit-queue@webkit.org [Mon, 19 Mar 2012 14:51:06 +0000 (14:51 +0000)]
[chromium] synthesize wheel events for fling on main thread
https://bugs.webkit.org/show_bug.cgi?id=81458

Source/WebKit/chromium:

Support track pad fling by generating a sequence of wheel events.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-19
Reviewed by James Robinson.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::scrollBy): Call-back from PlatformGestureCurve to dispatch wheel event.
(WebKit):
(WebKit::WebViewImpl::gestureEvent): Handle GestureFlingStart and GestureFlingCancel.
(WebKit::WebViewImpl::updateAnimations): Requests a PlatformGestureCurve to animate forward.
(WebKit::WebViewImpl::didCommitLoad): Halt flings on navigations.
* src/WebViewImpl.h:
(WebCore):
(WebViewImpl):

Tools:

Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-19
Reviewed by James Robinson.

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::gestureFlingCancel):
(EventSender::gestureFlingStart):
* DumpRenderTree/chromium/EventSender.h:
(EventSender):

LayoutTests:

Show that the GestureFlingStart and GestureFlingEnd events are handled and
connect up with WebViewImpl

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-19
Reviewed by James Robinson.

* fast/events/touch/gesture/pad-gesture-cancel-expected.txt: Added.
* fast/events/touch/gesture/pad-gesture-cancel.html: Added.
* fast/events/touch/gesture/pad-gesture-cancel.js: Added.
(recordWheelEvent):
(if):
* fast/events/touch/gesture/pad-gesture-fling-expected.txt: Added.
* fast/events/touch/gesture/pad-gesture-fling.html: Added.
* fast/events/touch/gesture/pad-gesture-fling.js: Added.
(recordWheelEvent):
(if):
* platform/chromium/fast/events/touch/gesture/pad-gesture-cancel-expected.txt: Added.
* platform/chromium/fast/events/touch/gesture/pad-gesture-fling-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed. Add new platform specific expectation after r110667.
kkristof@inf.u-szeged.hu [Mon, 19 Mar 2012 14:47:07 +0000 (14:47 +0000)]
[Qt] Unreviewed. Add new platform specific expectation after r110667.

* platform/qt-4.8/fast/dom/Window/window-properties-expected.png: Added.
* platform/qt-4.8/fast/dom/Window/window-properties-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Remove obsolete optimization in WebPageCompositorPrivate
commit-queue@webkit.org [Mon, 19 Mar 2012 14:45:28 +0000 (14:45 +0000)]
[BlackBerry] Remove obsolete optimization in WebPageCompositorPrivate
https://bugs.webkit.org/show_bug.cgi?id=81115

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-03-19
Reviewed by Benjamin Poulain.

The compositor tried to avoid rendering the same stuff twice, using a
mechanism that didn't work properly and has been redundant since we
introduced deferred blits. Remove this code.

Reviewed internally by Robin Cao.

* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::commit):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
* Api/WebPageCompositor_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add command line option to set the user agent in the MiniBrowser https://bugs...
ahf@0x90.dk [Mon, 19 Mar 2012 14:42:42 +0000 (14:42 +0000)]
[Qt] Add command line option to set the user agent in the MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=81508

Reviewed by Simon Hausmann.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::webViewExperimental):
* MiniBrowser/qt/BrowserWindow.h:
(BrowserWindow):
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(printHelp):
(MiniBrowserApplication::handleUserOptions):
* MiniBrowser/qt/MiniBrowserApplication.h:
(WindowOptions::WindowOptions):
(WindowOptions::setUserAgent):
(WindowOptions::userAgent):
(WindowOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add experimental API for dynamically changing the UA string
ahf@0x90.dk [Mon, 19 Mar 2012 14:42:17 +0000 (14:42 +0000)]
[Qt] Add experimental API for dynamically changing the UA string

Reviewed by Simon Hausmann.

This patch adds a new property named userAgent to the
QQuickWebViewExperimental type which allows us to dynamically change
the user agent string from the QML API.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewExperimental::userAgent):
(QQuickWebViewExperimental::setUserAgent):
* UIProcess/API/qt/qquickwebview_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Remove dead user agent code from the MiniBrowser.
ahf@0x90.dk [Mon, 19 Mar 2012 14:41:52 +0000 (14:41 +0000)]
[Qt] Remove dead user agent code from the MiniBrowser.

Reviewed by Simon Hausmann.

* MiniBrowser/qt/BrowserWindow.cpp:
* MiniBrowser/qt/BrowserWindow.h:
(BrowserWindow):
* MiniBrowser/qt/MiniBrowser.qrc:
* MiniBrowser/qt/useragentlist.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoinspector highlight of SVG root element with viewbox does not match dimensions of...
commit-queue@webkit.org [Mon, 19 Mar 2012 14:38:20 +0000 (14:38 +0000)]
inspector highlight of SVG root element with viewbox does not match dimensions of element
https://bugs.webkit.org/show_bug.cgi?id=78037

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-03-19
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Functions such as RenderBox::absoluteQuads and DOMNodeHighlighter::getOrDrawNodeHighlight
eventually call RenderSVGRoot::mapLocalToContainer, passing along local CSS box coordinates.

However, before this patch, RenderSVGRoot::mapLocalToContainer expected local SVG viewport
coordinates. This caused the inspector highlight to be incorrectly sized and positioned.

Now, RenderSVGRoot::mapLocalToContainer expects local CSS box coordinates, like other HTML
renderers.

Test: inspector/elements/highlight-svg-root.html

* dom/Element.cpp:
(WebCore::Element::getBoundingClientRect):
    Now, the SVG root element can use the code path for elements with CSS boxes to calculate
    its bounding client rect.

* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::mapLocalToContainer):
    RenderSVGRoot::mapLocalToContainer no longer needs to apply the
    localToBorderBoxTransform to convert from local SVG viewport coordinates to local CSS
    box coordinates. Now, it receives local CSS box coordinates.

* rendering/svg/RenderSVGRoot.h:
(WebCore::RenderSVGRoot::localToBorderBoxTransform):
    RenderSVGRoot::localToBorderBoxTransform has been exposed for child elements in the SVG
    namespace to use when mapping from local SVG viewport coordinates to local CSS box
    coordinates.

(RenderSVGRoot):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::mapLocalToContainer):
    Elements in the SVG namespace should now apply the localToBorderBoxTransform at the
    SVG/HTML boundary (aka RenderSVGRoot) when mapping their coordinates up the render tree.

* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::localCoordinateSpaceTransform):
    Same as above. This method is eventually used in the SVGLocatable::getScreenCTM
    calculation.

LayoutTests:

* inspector/elements/highlight-svg-root-expected.txt: Added.
* inspector/elements/highlight-svg-root.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agojhbuild: Call jhbuild's autogen.sh via bash.
kubo@profusion.mobi [Mon, 19 Mar 2012 14:35:02 +0000 (14:35 +0000)]
jhbuild: Call jhbuild's autogen.sh via bash.
https://bugs.webkit.org/show_bug.cgi?id=81485

Reviewed by Philippe Normand.

jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
this is usually true only on Linux systems, and even then bash for
some reason might not be available in that location. It is safer to
call bash directly and pass autogen.sh to it instead.

* jhbuild/jhbuild-wrapper:
(install_jhbuild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Prefix run-launcher with run-with-jhbuild
commit-queue@webkit.org [Mon, 19 Mar 2012 14:30:30 +0000 (14:30 +0000)]
[GTK] Prefix run-launcher with run-with-jhbuild
https://bugs.webkit.org/show_bug.cgi?id=81503

Patch by Philippe Normand <pnormand@igalia.com> on 2012-03-19
Reviewed by Hajime Morita.

* Scripts/run-launcher:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Adding slow to full-screen-restrictions.html on WIN.
keishi@webkit.org [Mon, 19 Mar 2012 10:47:47 +0000 (10:47 +0000)]
[chromium] Adding slow to full-screen-restrictions.html on WIN.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Prefix run-launcher with run-with-jhbuild
commit-queue@webkit.org [Mon, 19 Mar 2012 10:47:31 +0000 (10:47 +0000)]
[EFL] Prefix run-launcher with run-with-jhbuild
https://bugs.webkit.org/show_bug.cgi?id=80026

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-19
Reviewed by Hajime Morita.

* Scripts/run-launcher:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a copy constructor to CollapsedBorderValue
hbono@chromium.org [Mon, 19 Mar 2012 10:34:29 +0000 (10:34 +0000)]
Add a copy constructor to CollapsedBorderValue
https://bugs.webkit.org/show_bug.cgi?id=81502

Reviewed by Hajime Morita.

Due to the lack of this copy constructor, GCC (x86) creates a broken copy
constructor and it causes a build break on Google Chrome.

* rendering/style/CollapsedBorderValue.h:
(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(CollapsedBorderValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Gardening.
ossy@webkit.org [Mon, 19 Mar 2012 09:56:48 +0000 (09:56 +0000)]
[Qt] Gardening.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-03-19
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped: Skip a new failing test, remove a non-existent test, order entries.
* platform/qt/fast/events/resize-events-expected.png: Added.
* platform/qt/fast/events/resize-events-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline due to r111139
keishi@webkit.org [Mon, 19 Mar 2012 09:48:25 +0000 (09:48 +0000)]
[chromium] Rebaseline due to r111139

* platform/chromium-linux-x86/fast/table/max-width-integer-overflow-expected.png: Added.
* platform/chromium-linux-x86/fast/table/max-width-integer-overflow-expected.txt: Added.
* platform/chromium-linux/fast/table/max-width-integer-overflow-expected.png: Added.
* platform/chromium-linux/fast/table/max-width-integer-overflow-expected.txt: Added.
* platform/chromium-win-xp/fast/table/max-width-integer-overflow-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline due to r111156
keishi@webkit.org [Mon, 19 Mar 2012 09:10:25 +0000 (09:10 +0000)]
[chromium] Rebaseline due to r111156

* platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening. Adding missing cr-snowleopard layer creation expectations.
leviw@chromium.org [Mon, 19 Mar 2012 08:59:52 +0000 (08:59 +0000)]
Unreviewed gardening. Adding missing cr-snowleopard layer creation expectations.

* platform/chromium-mac-snowleopard/compositing/layer-creation: Added.
* platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r110759 and r108185.
philn@webkit.org [Mon, 19 Mar 2012 08:49:10 +0000 (08:49 +0000)]
Unreviewed, GTK rebaseline after r110759 and r108185.

* platform/gtk/editing/inserting/before-after-input-element-expected.txt:
* platform/gtk/editing/pasteboard/4806874-expected.txt:
* platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
* platform/gtk/editing/pasteboard/input-field-1-expected.txt:
* platform/gtk/editing/selection/3690703-2-expected.txt:
* platform/gtk/editing/selection/3690703-expected.txt:
* platform/gtk/editing/selection/3690719-expected.txt:
* platform/gtk/editing/selection/4895428-3-expected.txt:
* platform/gtk/editing/selection/4975120-expected.txt:
* platform/gtk/editing/selection/drag-select-1-expected.txt:
* platform/gtk/editing/selection/expanding-selections-expected.txt:
* platform/gtk/editing/selection/leave-requested-block-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-2-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-3-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
* platform/gtk/fast/block/float/032-expected.txt:
* platform/gtk/fast/block/float/033-expected.txt: Added.
* platform/gtk/fast/block/float/avoidance-rtl-expected.txt: Added.
* platform/gtk/fast/block/float/float-not-removed-from-next-sibling3-expected.txt:
* platform/gtk/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt:
* platform/gtk/fast/block/float/in-margin-expected.txt:
* platform/gtk/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
* platform/gtk/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
* platform/gtk/fast/block/lineboxcontain/block-font-expected.txt:
* platform/gtk/fast/block/lineboxcontain/block-glyphs-expected.txt:
* platform/gtk/fast/block/lineboxcontain/font-expected.txt:
* platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.txt:
* platform/gtk/fast/block/margin-collapse/103-expected.txt:
* platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.txt:
* platform/gtk/fast/clip/017-expected.txt:
* platform/gtk/fast/css/input-search-padding-expected.txt:
* platform/gtk/fast/css/invalidation-errors-2-expected.txt:
* platform/gtk/fast/css/invalidation-errors-expected.txt:
* platform/gtk/fast/css/line-height-expected.txt:
* platform/gtk/fast/css/nested-layers-with-hover-expected.txt:
* platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/gtk/fast/css/text-overflow-input-expected.txt:
* platform/gtk/fast/dom/isindex-001-expected.txt:
* platform/gtk/fast/dom/isindex-002-expected.txt:
* platform/gtk/fast/dynamic/subtree-boundary-percent-height-expected.txt:
* platform/gtk/fast/dynamic/subtree-no-common-root-static-y-expected.txt:
* platform/gtk/fast/dynamic/subtree-table-cell-height-expected.txt:
* platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
* platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
* platform/gtk/fast/events/autoscroll-expected.txt:
* platform/gtk/fast/events/context-no-deselect-expected.txt:
* platform/gtk/fast/events/mouse-relative-position-expected.txt: Added.
* platform/gtk/fast/forms/basic-inputs-expected.txt:
* platform/gtk/fast/forms/box-shadow-override-expected.txt:
* platform/gtk/fast/forms/encoding-test-expected.txt:
* platform/gtk/fast/forms/fieldset-align-expected.txt:
* platform/gtk/fast/forms/floating-textfield-relayout-expected.txt:
* platform/gtk/fast/forms/form-element-geometry-expected.txt:
* platform/gtk/fast/forms/input-align-expected.txt:
* platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt:
* platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.txt:
* platform/gtk/fast/forms/input-appearance-disabled-expected.txt:
* platform/gtk/fast/forms/input-appearance-focus-expected.txt:
* platform/gtk/fast/forms/input-appearance-height-expected.txt:
* platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
* platform/gtk/fast/forms/input-appearance-selection-expected.txt:
* platform/gtk/fast/forms/input-appearance-visibility-expected.txt:
* platform/gtk/fast/forms/input-appearance-width-expected.txt:
* platform/gtk/fast/forms/input-baseline-expected.txt:
* platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
* platform/gtk/fast/forms/input-field-text-truncated-expected.txt:
* platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
* platform/gtk/fast/forms/input-readonly-empty-expected.txt:
* platform/gtk/fast/forms/input-spaces-expected.txt:
* platform/gtk/fast/forms/input-table-expected.txt:
* platform/gtk/fast/forms/input-text-click-inside-expected.txt:
* platform/gtk/fast/forms/input-text-click-outside-expected.txt:
* platform/gtk/fast/forms/input-text-option-delete-expected.txt:
* platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
* platform/gtk/fast/forms/input-value-expected.txt:
* platform/gtk/fast/forms/input-width-expected.txt:
* platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.txt:
* platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
* platform/gtk/fast/forms/placeholder-position-expected.txt:
* platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/gtk/fast/forms/search-rtl-expected.txt:
* platform/gtk/fast/forms/search-styled-expected.txt:
* platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
* platform/gtk/fast/forms/searchfield-heights-expected.txt:
* platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
* platform/gtk/fast/forms/text-style-color-expected.txt:
* platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
* platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
* platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
* platform/gtk/fast/html/details-no-summary4-expected.txt:
* platform/gtk/fast/html/details-open-javascript-expected.txt:
* platform/gtk/fast/html/details-open2-expected.txt:
* platform/gtk/fast/html/details-open4-expected.txt:
* platform/gtk/fast/inline/continuation-outlines-with-layers-2-expected.txt:
* platform/gtk/fast/inline/continuation-outlines-with-layers-expected.txt:
* platform/gtk/fast/invalid/residual-style-expected.txt:
* platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
* platform/gtk/fast/layers/remove-layer-with-nested-stacking-expected.txt:
* platform/gtk/fast/layers/self-painting-outline-expected.txt: Added.
* platform/gtk/fast/lists/dynamic-marker-crash-expected.txt:
* platform/gtk/fast/multicol/layers-split-across-columns-expected.txt:
* platform/gtk/fast/overflow/004-expected.txt:
* platform/gtk/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
* platform/gtk/fast/overflow/line-clamp-expected.txt:
* platform/gtk/fast/overflow/overflow-focus-ring-expected.txt:
* platform/gtk/fast/repaint/iframe-scroll-repaint-expected.txt:
* platform/gtk/fast/repaint/inline-relative-positioned-expected.txt:
* platform/gtk/fast/repaint/layer-outline-expected.txt:
* platform/gtk/fast/repaint/layer-outline-horizontal-expected.txt:
* platform/gtk/fast/repaint/lines-with-layout-delta-expected.txt:
* platform/gtk/fast/repaint/opacity-change-on-overflow-float-expected.txt:
* platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
* platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
* platform/gtk/fast/repaint/repaint-resized-overflow-expected.txt:
* platform/gtk/fast/repaint/search-field-cancel-expected.txt:
* platform/gtk/fast/repaint/subtree-layoutstate-transform-expected.txt:
* platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Added.
* platform/gtk/fast/repaint/subtree-root-clip-3-expected.txt: Added.
* platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Added.
* platform/gtk/fast/repaint/subtree-root-skipped-expected.txt:
* platform/gtk/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
* platform/gtk/fast/replaced/replaced-breaking-expected.txt:
* platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
* platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
* platform/gtk/fast/replaced/width100percent-textfield-expected.txt:
* platform/gtk/fast/table/003-expected.txt:
* platform/gtk/fast/table/029-expected.txt:
* platform/gtk/fast/table/colspanMinWidth-expected.txt:
* platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/gtk/fast/table/overflowHidden-expected.txt:
* platform/gtk/fast/table/spanOverlapRepaint-expected.txt:
* platform/gtk/fast/table/text-field-baseline-expected.txt:
* platform/gtk/fast/text/selection-painted-separately-expected.txt:
* platform/gtk/fast/text/selection-rect-rounding-expected.txt:
* platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
* platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
* platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt:
* platform/gtk/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/gtk/svg/hixie/mixed/003-expected.txt:
* platform/gtk/tables/mozilla/bugs/45621-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug12384-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug154780-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug24200-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46368-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug51037-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug55545-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug99948-expected.txt:
* platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
* platform/gtk/tables/mozilla/other/move_row-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening. Fixing expectations due to new Mac Lion baselines.
leviw@chromium.org [Mon, 19 Mar 2012 08:36:06 +0000 (08:36 +0000)]
Unreviewed gardening. Fixing expectations due to new Mac Lion baselines.

* platform/chromium-linux-x86/css2.1/20110323: Removed.
* platform/chromium-linux/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.
* platform/chromium-mac/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.
* platform/chromium-win/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
* platform/chromium-win/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
* platform/mac-snowleopard/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK gardening
philn@webkit.org [Mon, 19 Mar 2012 08:24:01 +0000 (08:24 +0000)]
Unreviewed, GTK gardening

* platform/gtk/Skipped: Move the 2 http tests skipped in r111161
to the showModal section.
* platform/gtk/test_expectations.txt: Unskip tests needing rebaseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening: updating max-width-integer-overflow test expectations post...
leviw@chromium.org [Mon, 19 Mar 2012 08:21:41 +0000 (08:21 +0000)]
Unreviewed gardening: updating max-width-integer-overflow test expectations post 111156, which
eliminated code dealing with 28-bit lengths.

* platform/chromium-win-vista/fast/table: Added.
* platform/chromium-win-vista/fast/table/max-width-integer-overflow-expected.txt: Added.
* platform/chromium-win-xp/fast/table/max-width-integer-overflow-expected.txt: Added.
* platform/chromium-win/fast/table/max-width-integer-overflow-expected.png: Added.
* platform/chromium-win/fast/table/max-width-integer-overflow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSCallbackFunction::toStringCallback/valueOfCallback do not handle 0 return value...
barraclough@apple.com [Mon, 19 Mar 2012 08:12:05 +0000 (08:12 +0000)]
JSCallbackFunction::toStringCallback/valueOfCallback do not handle 0 return value from convertToType
https://bugs.webkit.org/show_bug.cgi?id=81468 <rdar://problem/11034745>

Reviewed by Oliver Hunt.

The API specifies that convertToType may opt not to handle a conversion:
    "@result The objects's converted value, or NULL if the object was not converted."
In which case, it would propagate first up the JSClass hierarchy, calling its superclass's
conversion functions, and failing that call the JSObject::defaultValue function.

Unfortunately this behaviour was removed in bug#69677/bug#69858, and instead we now rely on
the toStringCallback/valueOfCallback function introduced in bug#69156. Even after a fix in
bug#73368, these will return the result from the first convertToType they find, regardless
of whether this result is null, and if no convertToType method is found in the api class
hierarchy (possible if toStringCallback/valueOfCallback was accessed off the prototype
chain), they will also return a null pointer. This is unsafe.

It would be easy to make the approach based around toStringCallback/valueOfCallback continue
to walk the api class hierarchy, but making the fallback to defaultValue would be problematic
(since defaultValue calls toStringCallback/valueOfCallback, this would infinitely recurse).
Making the fallback work with toString/valueOf methods attached to api objects is probably
not the right thing to do – instead, we should just implement the defaultValue trap for api
objects.

In addition, this bug highlights that fact that JSCallbackFunction::call will allow a hard
null to be returned from C to JavaScript - this is not okay. Handle with an exception.

* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::call):
    - Should be null checking the return value.
(JSC):
    - Remove toStringCallback/valueOfCallback.
* API/JSCallbackFunction.h:
(JSCallbackFunction):
    - Remove toStringCallback/valueOfCallback.
* API/JSCallbackObject.h:
(JSCallbackObject):
    - Add defaultValue mthods to JSCallbackObject.
* API/JSCallbackObjectFunctions.h:
(JSC::::defaultValue):
    - Add defaultValue mthods to JSCallbackObject.
* API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
    - Remove toStringCallback/valueOfCallback.
* API/tests/testapi.js:
    - Revert this test, now we no longer artificially introduce a toString method onto the api object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r111156 and skip 2 new http tests.
philn@webkit.org [Mon, 19 Mar 2012 08:01:24 +0000 (08:01 +0000)]
Unreviewed, GTK rebaseline after r111156 and skip 2 new http tests.

* platform/gtk/Skipped:
* platform/gtk/fast/table/max-width-integer-overflow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix build that was broken by r111137
keishi@webkit.org [Mon, 19 Mar 2012 07:11:31 +0000 (07:11 +0000)]
[chromium] Fix build that was broken by r111137

Fixed was ambiguous because of MacTypes.h

* tests/CCLayerTreeHostCommonTest.cpp:
(WebCore::addTransformAnimationToLayer):
* tests/CCOcclusionTrackerTest.cpp:
(WebCore::addTransformAnimationToLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed new baselines of various tests for Mac.
timothy_horton@apple.com [Mon, 19 Mar 2012 07:01:21 +0000 (07:01 +0000)]
Unreviewed new baselines of various tests for Mac.

* compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added (http://trac.webkit.org/changeset/105879).
* platform/mac/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added (http://trac.webkit.org/changeset/105879).
* platform/mac/css2.1/20110323/border-collapse-offset-002-expected.png: Added (had reftest result, switched to image+text in http://trac.webkit.org/changeset/103877).
* platform/mac/css2.1/20110323/border-collapse-offset-002-expected.txt: Added (had reftest result, switched to image+text in http://trac.webkit.org/changeset/103877).
* platform/mac/css2.1/20110323/outline-color-applies-to-008-expected.png: Added (had reftest result, switched to image+text in http://trac.webkit.org/changeset/105023).
* platform/mac/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added (had reftest result, switched to image+text in http://trac.webkit.org/changeset/105023).
* platform/mac/fast/block/float/float-not-removed-from-next-sibling3-expected.png: Added (platform result removed in http://trac.webkit.org/changeset/110179).
* platform/mac/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added (platform result removed in http://trac.webkit.org/changeset/110179).
* platform/mac/fast/css/font-face-synthetic-bold-italic-expected.png: Added (http://trac.webkit.org/changeset/107516).
* platform/mac/fast/css/font-face-synthetic-bold-italic-expected.txt: Added (http://trac.webkit.org/changeset/107516).
* platform/mac/fast/css/font-face-weight-matching-expected.png: Added (http://trac.webkit.org/changeset/107516).
* platform/mac/fast/css/font-face-weight-matching-expected.txt: Added (http://trac.webkit.org/changeset/107516).
* platform/mac/fast/css/non-empty-span-expected.png: Added (http://trac.webkit.org/changeset/108111).
* platform/mac/fast/css/non-empty-span-expected.txt: Added (http://trac.webkit.org/changeset/108111).
* platform/mac/fast/dom/52776-expected.txt: Added (incorrectly moved to mac-future in http://trac.webkit.org/changeset/110189, then deleted by me).
* platform/mac/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added (http://trac.webkit.org/changeset/109612).
* platform/mac/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added (http://trac.webkit.org/changeset/109612).
* platform/mac/fast/forms/select-overflow-scroll-expected.png: Added (http://trac.webkit.org/changeset/107072).
* platform/mac/fast/forms/select-overflow-scroll-expected.txt: Added (http://trac.webkit.org/changeset/107072).
* platform/mac/fast/forms/select-overflow-scroll-inherited-expected.png: Added (http://trac.webkit.org/changeset/107072).
* platform/mac/fast/forms/select-overflow-scroll-inherited-expected.txt: Added (http://trac.webkit.org/changeset/107072).
* platform/mac/fast/repaint/transform-rotate-and-remove-expected.png: Added (http://trac.webkit.org/changeset/109867).
* platform/mac/fast/repaint/transform-rotate-and-remove-expected.txt: Added (http://trac.webkit.org/changeset/109867).
* platform/mac/test_expectations.txt:
* transforms/3d/general/background-visibility-layers-expected.png: Renamed from LayoutTests/transforms/3d/general/background-visibility-layers-actual.png.
* transforms/3d/general/background-visibility-layers-expected.txt: Renamed from LayoutTests/transforms/3d/general/background-visibility-layers-actual.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed. Disable -Werror on x86 until proper fix.
ossy@webkit.org [Mon, 19 Mar 2012 06:59:28 +0000 (06:59 +0000)]
[Qt] Unreviewed. Disable -Werror on x86 until proper fix.
https://bugs.webkit.org/show_bug.cgi?id=81498

* qmake/mkspecs/features/unix/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFallback to common script when per-script font setting is the empty string
commit-queue@webkit.org [Mon, 19 Mar 2012 06:58:19 +0000 (06:58 +0000)]
Fallback to common script when per-script font setting is the empty string
https://bugs.webkit.org/show_bug.cgi?id=81329

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-03-18
Reviewed by Kent Tamura.

Source/WebCore:

Tests: fast/text/international/font-fallback-to-common-script.html

* page/Settings.cpp:
(WebCore::setGenericFontFamilyForScript): Remove the setting when the per-script font family is the empty string.

LayoutTests:

* fast/text/international/font-fallback-to-common-script-expected.html: Added.
* fast/text/international/font-fallback-to-common-script.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove remnants of code that assume Lengths are 28 bit integers.
macpherson@chromium.org [Mon, 19 Mar 2012 06:37:54 +0000 (06:37 +0000)]
Remove remnants of code that assume Lengths are 28 bit integers.
https://bugs.webkit.org/show_bug.cgi?id=67976

Reviewed by Eric Seidel.

Source/WebCore:

Test: LayoutTests/fast/table/max-width-integer-overflow-expected.html

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLength):
Bound by INT_MAX and INT_MIN instead of 28 bit bounds.
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyBorderRadius::applyValue):
Use PrimitiveValue::computeLength function directly.
* platform/Length.h:
Remove 28 bit integer limit constants.
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
Use std::numeric_limits.

LayoutTests:

* platform/mac/fast/table/max-width-integer-overflow-expected.png:
* platform/mac/fast/table/max-width-integer-overflow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShould remove RuntimeEnabledFeatures::multipleShadowSubtreesEnabled
shinyak@chromium.org [Mon, 19 Mar 2012 06:16:44 +0000 (06:16 +0000)]
Should remove RuntimeEnabledFeatures::multipleShadowSubtreesEnabled
https://bugs.webkit.org/show_bug.cgi?id=79307

Reviewed by Dimitri Glazkov.

Source/WebCore:

Since RuntimeEnabledFeatures::multipleShadowSubtreesEnabled was introduced for
temporal unstability of multiple shadow roots. We should remove it now, and
enable it by default.

Test: fast/dom/shadow/shadow-root-js-api.html should cover this change.
The other shadow related tests should also covers this change.

* WebCore.exp.in:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
* dom/ShadowTree.cpp:
(WebCore::ShadowTree::addShadowRoot):
* testing/Internals.cpp:
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests:

Removed multipleShadowSubtresEnabled from tests.

* fast/dom/shadow/get-element-by-id-in-shadow-root.html:
* fast/dom/shadow/multiple-shadowroot-adopt.html:
* fast/dom/shadow/multiple-shadowroot-rendering.html:
* fast/dom/shadow/multiple-shadowroot.html:
* fast/dom/shadow/shadow-element-rendering-multiple.html:
* fast/dom/shadow/shadow-element-rendering-single.html:
* fast/dom/shadow/shadow-root-js-api-expected.txt:
* fast/dom/shadow/shadow-root-js-api.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Mark js-late-gradient-creation.svg as flaky
keishi@webkit.org [Mon, 19 Mar 2012 06:07:42 +0000 (06:07 +0000)]
[chromium] Mark js-late-gradient-creation.svg as flaky

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix test that was broken by r111128
keishi@webkit.org [Mon, 19 Mar 2012 05:23:11 +0000 (05:23 +0000)]
[chromium] Fix test that was broken by r111128

* tests/ScrollAnimatorNoneTest.cpp:
(TEST): ScrollByPixel no longer animates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111153 268f45cc-cd09-0410-ab3c-d52691b4dbfc