WebKit-https.git
11 years agoThis broke windows.
barraclough@apple.com [Mon, 19 Apr 2010 23:26:29 +0000 (23:26 +0000)]
This broke windows.

Reviewed by NOBODY (rolling out r57829).

JavaScriptCore:

* API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):
* API/JSContextRef.cpp:
* Android.mk:
* Android.v8.wtf.mk:
* GNUmakefile.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
* runtime/Identifier.cpp:
(JSC::Identifier::remove):
(JSC::Identifier::checkCurrentIdentifierTable):
(JSC::createIdentifierTableSpecificCallback):
(JSC::createIdentifierTableSpecific):
* runtime/Identifier.h:
(JSC::ThreadIdentifierTableData::ThreadIdentifierTableData):
(JSC::defaultIdentifierTable):
(JSC::setDefaultIdentifierTable):
(JSC::currentIdentifierTable):
(JSC::setCurrentIdentifierTable):
(JSC::resetCurrentIdentifierTable):
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::create):
* wtf/WTFThreadData.cpp: Removed.
* wtf/WTFThreadData.h: Removed.

JavaScriptGlue:

* ForwardingHeaders/wtf/WTFThreadData.h: Removed.
* JSUtils.cpp:
(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):

WebCore:

* ForwardingHeaders/wtf/WTFThreadData.h: Removed.
* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):
* platform/ThreadGlobalData.h:
(WebCore::ThreadGlobalData::atomicStringTable):
* platform/text/AtomicString.cpp:
(WebCore::stringTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix.
mrowe@apple.com [Mon, 19 Apr 2010 23:24:00 +0000 (23:24 +0000)]
Build fix.

* platform/graphics/mac/GraphicsContext3DMac.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed and landed by Anders Carlsson.
andersca@apple.com [Mon, 19 Apr 2010 23:10:11 +0000 (23:10 +0000)]
Reviewed and landed by Anders Carlsson.

Patch by Douglas Gregor <dgregor@apple.com> on 2010-04-19
* runtime/UStringImpl.h:
Fix class/struct declaration mismatches.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 19 Apr 2010 23:05:44 +0000 (23:05 +0000)]
2010-04-19  Dirk Pranke <dpranke@chromium.org>

        Reviewed by Adam Barth.

        From a patch by Tor Arne Vestbo  <tor.arne.vestbo@nokia.com>

        new-run-webkit-tests: make the retry step more explicit
        https://bugs.webkit.org/show_bug.cgi?id=37606

        It might be confusing to see the test and percent counters
        reset without any notice of what's going on, so we make the
        message that a retry-run is started explicit.

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd support for opening a new window (File->New Window) to
weinig@apple.com [Mon, 19 Apr 2010 22:59:27 +0000 (22:59 +0000)]
Add support for opening a new window (File->New Window) to
Windows MiniBrowser. Accelerator doesn't work.

Reviewed by Anders Carlsson.

* MiniBrowser/win/BrowserView.cpp:
(createNewPage): Use BrowserView::create.
* MiniBrowser/win/BrowserWindow.cpp:
(BrowserWindow::onCommand): Respond to ID_FILE_NEW_WINDOW
by creating a new window.
* MiniBrowser/win/BrowserWindow.h:
(BrowserWindow::create): Added. Don't allow creating
BrowserWindows on the stack by making constructor
private and exposing the create function.
* MiniBrowser/win/MiniBrowser.cpp:
(MiniBrowser::createNewWindow): Move new window creation
logic here.
* MiniBrowser/win/MiniBrowser.h:
* MiniBrowser/win/MiniBrowser.rc:
* MiniBrowser/win/main.cpp:
(_tWinMain): Use the new MiniBrowser::createNewWindow().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com [Mon, 19 Apr 2010 22:27:16 +0000 (22:27 +0000)]
2010-04-19  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        AX: aria-haspopup needs to be exposed
        https://bugs.webkit.org/show_bug.cgi?id=37808

        Test: platform/mac/accessibility/element-haspopup.html

        * accessibility/AccessibilityObject.h:
        (WebCore::AccessibilityObject::ariaHasPopup):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::ariaHasPopup):
        (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
        * accessibility/AccessibilityRenderObject.h:
        * accessibility/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
2010-04-19  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        AX: aria-haspopup needs to be exposed
        https://bugs.webkit.org/show_bug.cgi?id=37808

        * platform/mac/accessibility/element-haspopup-expected.txt: Added.
        * platform/mac/accessibility/element-haspopup.html: Added.
2010-04-19  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        AX: aria-haspopup needs to be exposed
        https://bugs.webkit.org/show_bug.cgi?id=37808

        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::hasPopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 19 Apr 2010 22:09:33 +0000 (22:09 +0000)]
2010-04-19  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Submit a better workaround for r57806 than the one in r57831 - log
        an error and exit if you try to run new-run-webkit-tests with --use-drt
        on Windows.

        https://bugs.webkit.org/show_bug.cgi?id=37822

        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed.
jesus@webkit.org [Mon, 19 Apr 2010 22:03:54 +0000 (22:03 +0000)]
Unreviewed.

Just adding myself as a committer.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 19 Apr 2010 21:59:41 +0000 (21:59 +0000)]
2010-04-19  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Add slightly better logging to the websocket python wrapper script,
        including a --verbose flag for debug output.

        https://bugs.webkit.org/show_bug.cgi?id=37233

        * Scripts/webkitpy/layout_tests/port/websocket_server.py:
        * Scripts/new-run-webkit-websocketserver:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix a crash when rendering <select> elements with WebKit2.
andersca@apple.com [Mon, 19 Apr 2010 21:57:04 +0000 (21:57 +0000)]
Fix a crash when rendering <select> elements with WebKit2.

Reviewed by Sam Weinig.

* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuList):
Set the current NSGraphicsContext before calling out to AppKit, otherwise the current graphics context
could point to a CGContext whose memory has been freed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 19 Apr 2010 21:56:59 +0000 (21:56 +0000)]
2010-04-19  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        new-run-webkit-tests: add a way (--print-unexpected-results) to
        (re-)print out the tests that produced unexpected results in the
        last run. Also add a way (--retry-unexpected-results) to
        automatically re-test them.

        https://bugs.webkit.org/show_bug.cgi?id=37783

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 19 Apr 2010 21:48:49 +0000 (21:48 +0000)]
2010-04-19  James Robinson  <jamesr@chromium.org>

        Unreviewed, move chromium baselines for fast/url around.

        The desired behavior is that chromium-win use one set of baselines and
        chromium-mac/chromium-linux use another, however to do we have to
        duplicate the mac+linux results into chromium-mac and chromium-linux.

        * platform/chromium-linux/fast/url/file-expected.txt: Added.
        * platform/chromium-linux/fast/url/relative-unix-expected.txt: Added.
        * platform/chromium-linux/fast/url/relative-win-expected.txt: Added.
        * platform/chromium-mac/fast/url/file-expected.txt: Added.
        * platform/chromium-mac/fast/url/relative-unix-expected.txt: Added.
        * platform/chromium-mac/fast/url/relative-win-expected.txt: Added.
        * platform/chromium/fast/url/file-expected.txt: Removed.
        * platform/chromium/fast/url/relative-unix-expected.txt: Removed.
        * platform/chromium/fast/url/relative-win-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 19 Apr 2010 21:41:04 +0000 (21:41 +0000)]
2010-04-19  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Restructure the logging in new-run-webkit-tests so that many of log
        messages that were logged to the MeteredStream also get logged in
        --verbose mode.

        https://bugs.webkit.org/show_bug.cgi?id=37780

        * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 19 Apr 2010 21:39:37 +0000 (21:39 +0000)]
2010-04-19  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        new-run-webkit-tests: add 'summary' and 'unexpected-results' options
        to the --log flag. Also add a 'progress' flag to enable the regular
        progress bar (as opposed to 'detailed-progress', which enables the
        dots). Also add a 'nothing' flag to allow you to be explicit that
        you don't want any logging on the command line.

        The default is
        '--log detailed-progress,summary,unexpected,unexpected-results'

        (The default logging is unchanged by this patch, this just makes things
        properly configurable).

        Note that 'nothing' doesn't work properly yet; I need a couple other
        patches to land to avoid rewriting things several different ways.

        https://bugs.webkit.org/show_bug.cgi?id=37785

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoManipulating document fragment members while adding it to tree may result in loss...
dglazkov@chromium.org [Mon, 19 Apr 2010 21:15:33 +0000 (21:15 +0000)]
Manipulating document fragment members while adding it to tree may result in loss of tree integrity.
https://bugs.webkit.org/show_bug.cgi?id=36031

Reviewed by Darin Adler.

WebCore:

Changes the logic of appending/inserting document fragment to first stashing all of its children
to a vector, then processing the vector. This avoids ghastliness that would be caused by mutation
events mucking with the document fragment while it's being appended/inserted.

Test: fast/dom/Node/fragment-mutation.html

* dom/ContainerNode.cpp:
(WebCore::targetNodes): Added method to populate a vector of nodes (targets) to be used in
    inserting/appending operation.
(WebCore::ContainerNode::insertBefore): Changed to use vector-based iteration.
(WebCore::ContainerNode::appendChild): Ditto.
* dom/Node.cpp:
(WebCore::Node::checkReplaceChild): Cleaned up comments.
(WebCore::Node::checkAddChild): Ditto.

LayoutTests:

These tests study various side-effects of DOM mutation events fired during appending/inserting
document fragments.

* fast/dom/Node/fragment-mutation-expected.txt: Added.
* fast/dom/Node/fragment-mutation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 19 Apr 2010 21:10:12 +0000 (21:10 +0000)]
2010-04-19  James Robinson  <jamesr@chromium.org>

        Unreviewed - yet more rebaselines and expectation updates.

        * platform/chromium-win/fast/url/file-expected.txt: Added.
        * platform/chromium-win/fast/url/relative-unix-expected.txt: Added.
        * platform/chromium-win/fast/url/relative-win-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChecked in these tests I wrote becuase Balazs Kelemen wanted to use them.
ggaren@apple.com [Mon, 19 Apr 2010 21:07:43 +0000 (21:07 +0000)]
Checked in these tests I wrote becuase Balazs Kelemen wanted to use them.

Reviewed by Beth Dakin.

* tests/perf: Added.
* tests/perf/bench-allocate-nonretained.js: Added.
* tests/perf/bench-allocate-retained.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake the URL change on committed load.
kenneth@webkit.org [Mon, 19 Apr 2010 20:56:33 +0000 (20:56 +0000)]
Make the URL change on committed load.

Reviewed by Simon Hausmann.

* QtLauncher/mainwindow.cpp:
(MainWindow::buildUI):
(MainWindow::setAddressUrl):
* QtLauncher/mainwindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
barraclough@apple.com [Mon, 19 Apr 2010 20:51:48 +0000 (20:51 +0000)]
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Reviewed by NOBODY (windows build fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 19 Apr 2010 20:50:17 +0000 (20:50 +0000)]
2010-04-19  James Robinson  <jamesr@chromium.org>

        Unreviewed. More chromium rebaselines+expectation updates.

        * platform/chromium-linux/fast/css/getComputedStyle: Added.
        * platform/chromium-linux/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Added.
        * platform/chromium-mac/media/video-src-change-expected.txt:
        * platform/chromium-mac/media/video-src-invalid-remove-expected.txt: Removed.
        * platform/chromium-win/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Added.
        * platform/chromium-win/media/video-src-change-expected.txt:
        * platform/chromium-win/media/video-src-invalid-remove-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 19 Apr 2010 20:35:39 +0000 (20:35 +0000)]
2010-04-19  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Fix a typo in the rebaselining tool that causes us to use "debug"
        instead of "Debug" in a directory path, which fails on platforms with
        case-sensitive filesystems.

        https://bugs.webkit.org/show_bug.cgi?id=37819

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 19 Apr 2010 20:20:19 +0000 (20:20 +0000)]
2010-04-19  James Robinson  <jamesr@chromium.org>

        Unreviewed build fix.

        Update chromium expectations

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 19 Apr 2010 20:17:28 +0000 (20:17 +0000)]
2010-04-19  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.

        Fix breakage of chromium-win canary bots caused by r57806. That patch
        introduced the option of using Chrome's new port of DumpRenderTree,
        but unfortunately that port relies on the webkit.py class
        implementation which uses non-blocking I/O that isn't available on
        Windows. This patch turns off that option and doesn't import the
        class if we're running on Windows.

        https://bugs.webkit.org/show_bug.cgi?id=37817

        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 19 Apr 2010 20:12:17 +0000 (20:12 +0000)]
2010-04-19  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        Fix regression introduced in r57820.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::loadNextSourceChild): Create a new MediaPlayer instead of
        just setting a URL on the one used for the previous <source> element. This restores
        the behavior prior to the changes for https://bugs.webkit.org/show_bug.cgi?id=37728.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=37745
barraclough@apple.com [Mon, 19 Apr 2010 20:05:53 +0000 (20:05 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=37745
Move string uniquing tables to (new) WTFThreadData class.

Reviewed by Sam Weinig.

Remove AtomicString's dependency on ThreadGlobalData so that we can move
WebCore's string classes up to WTF.

JavaScriptCore:

WTFThreadData.cpp/.h are based on ThreadGlobalData from WebCore.
Moved JSC & WebCore's string uniquing tables to this class.

This patch introduces a temporary layering violation in providing forward
declarations of classes from JSC and WTF; this will be resolved as we move
more string code up to WTF.

* API/APIShims.h:
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::~APICallbackShim):
* API/JSContextRef.cpp:
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
* runtime/Identifier.cpp:
(JSC::Identifier::remove):
(JSC::Identifier::checkCurrentIdentifierTable):
* runtime/Identifier.h:
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::create):
* wtf/WTFThreadData.cpp: Copied from WebCore/platform/ThreadGlobalData.cpp.
(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):
* wtf/WTFThreadData.h: Copied from WebCore/platform/ThreadGlobalData.h.
(WTF::WTFThreadData::atomicStringTable):
(WTF::WTFThreadData::initializeIdentifierTable):
(WTF::WTFThreadData::currentIdentifierTable):
(WTF::WTFThreadData::setCurrentIdentifierTable):
(WTF::WTFThreadData::resetCurrentIdentifierTable):
(WTF::wtfThreadData):

JavaScriptGlue:

* ForwardingHeaders/wtf/WTFThreadData.h: Added.
* JSUtils.cpp: Update
(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPIEntry::~JSGlueAPIEntry):
(JSGlueAPICallback::JSGlueAPICallback):
(JSGlueAPICallback::~JSGlueAPICallback):

WebCore:

* ForwardingHeaders/wtf/WTFThreadData.h: Added.
* platform/ThreadGlobalData.cpp: Remove m_atomicStringTable, all wtfThreadData() to ensure threadsafely initialized.
(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):
* platform/ThreadGlobalData.h: Remove m_atomicStringTable.
(WebCore::ThreadGlobalData::eventNames):
* platform/text/AtomicString.cpp:
(WebCore::AtomicStringTable::create):
(WebCore::AtomicStringTable::table):
(WebCore::AtomicStringTable::destroy):
(WebCore::stringTable): Access the AtomicStringTable on wtfThreadData() rather then threadGlobalData().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 19 Apr 2010 19:36:33 +0000 (19:36 +0000)]
2010-04-19  James Robinson  <jamesr@chromium.org>

        Reviewed by abarth.

        Fix a typo

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 19 Apr 2010 19:29:38 +0000 (19:29 +0000)]
2010-04-19  James Robinson  <jamesr@chromium.org>

        Unreviewed build fix for Chromium

        Add baselines for new platform-specific tests.

        * platform/chromium/fast/url: Added.
        * platform/chromium/fast/url/file-expected.txt: Added.
        * platform/chromium/fast/url/relative-expected.txt: Added.
        * platform/chromium/fast/url/relative-unix-expected.txt: Added.
        * platform/chromium/fast/url/relative-win-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix: wrap Settings::setLocalStorageQuota() and Settings::setSessionStorageQuota()
adachan@apple.com [Mon, 19 Apr 2010 19:13:34 +0000 (19:13 +0000)]
Build fix: wrap Settings::setLocalStorageQuota() and Settings::setSessionStorageQuota()
in #if ENABLE(DOM_STORAGE).

* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix run-webkit-tests when there are spaces in the path
aroben@apple.com [Mon, 19 Apr 2010 19:13:31 +0000 (19:13 +0000)]
Fix run-webkit-tests when there are spaces in the path

Fixes <http://webkit.org/b/37809>

Reviewed by Adam Barth.

* Scripts/run-webkit-tests: Use an "indirect object" to specify the
path to the harness to exec(). According to perldoc, this usage will
prohibit perl from parsing the arguments to exec() via the shell,
which would incorrectly split paths with spaces in them, etc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTouch WebKit.idl to force a rebuild of Interfaces.vcproj
dglazkov@chromium.org [Mon, 19 Apr 2010 19:01:47 +0000 (19:01 +0000)]
Touch WebKit.idl to force a rebuild of Interfaces.vcproj

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Added notification when the favicons for a page are changed
dglazkov@chromium.org [Mon, 19 Apr 2010 18:49:48 +0000 (18:49 +0000)]
WebCore: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=33812

Test: fast/dom/icon-url-property.html

* dom/Document.cpp:
(WebCore::Document::setIconURL):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setIconURL):
* loader/DocumentLoader.h:
(WebCore::DocumentLoader::iconURL):
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::setIconURL):
(WebCore::FrameLoader::didChangeIcons):
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:

WebKit/chromium: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=33812

* public/WebFrameClient.h:
(WebKit::WebFrameClient::didChangeIcons):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
* src/FrameLoaderClientImpl.h:

WebKit/gtk: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=33812

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidChangeIcons):
* WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=33812

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidChangeIcons):

WebKit/qt: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=33812

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
(WebCore::FrameLoaderClientQt::didChangeTitle):
* WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win: Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().

Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=33812

* Interfaces/IWebFrameLoadDelegatePrivate2.idl:
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidChangeIcons):
* WebCoreSupport/WebFrameLoaderClient.h:
* WebFrame.cpp:
(WebFrame::didChangeIcons):
* WebFrame.h:

WebKitTools: Add test support for icon changes.

Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=33812

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(dumpIconChangesCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::dumpIconChanges):
(LayoutTestController::setDumpIconChanges):
* DumpRenderTree/win/FrameLoadDelegate.cpp:
(FrameLoadDelegate::didChangeIcons):
* DumpRenderTree/win/FrameLoadDelegate.h:
* WinLauncher/WinLauncher.h:
(WinLauncherWebHost::didChangeIcons):

LayoutTests: Add test for icon change notifications.

Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=33812

* fast/dom/icon-url-property-expected.txt: Added.
* fast/dom/icon-url-property.html: Added.
* Skipped on all platforms but Win

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: https://bugs.webkit.org/show_bug.cgi?id=37717
adachan@apple.com [Mon, 19 Apr 2010 18:37:38 +0000 (18:37 +0000)]
WebCore: https://bugs.webkit.org/show_bug.cgi?id=37717
Allow clients concerned with memory consumption to set a quota on session storage
since the memory used won't be released until the Page is destroyed.
The default is noQuota, which matches the current behavior.

Reviewed by Jeremy Orlow.

* WebCore.base.exp: Export Settings::setSessionStorageQuota().
* page/Page.cpp:
(WebCore::Page::sessionStorage):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setSessionStorageQuota):
* page/Settings.h:
(WebCore::Settings::sessionStorageQuota):
* storage/StorageNamespace.cpp:
(WebCore::StorageNamespace::sessionStorageNamespace):
* storage/StorageNamespace.h:
* storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::sessionStorageNamespace):
* storage/StorageNamespaceImpl.h:

WebKit/chromium: https://bugs.webkit.org/show_bug.cgi?id=37717
Changes needed now that StorageNamespaceImpl::sessionStorageNamespace() and
StorageNamespace::sessionStorageNamespace() take in a quota parameter.

Reviewed by Jeremy Orlow.

* src/StorageNamespaceProxy.cpp:
(WebCore::StorageNamespace::sessionStorageNamespace):
* src/WebStorageNamespaceImpl.cpp:
(WebKit::WebStorageNamespace::createSessionStorageNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Build fix for WinCE.
hausmann@webkit.org [Mon, 19 Apr 2010 18:34:06 +0000 (18:34 +0000)]
[Qt] Build fix for WinCE.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-04-19
Reviewed by Simon Hausmann.

Moved the include of the non-existing errno.h header file inside
platform guard macros.

* jit/ExecutableAllocatorFixedVMPool.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 19 Apr 2010 18:28:39 +0000 (18:28 +0000)]
2010-04-19  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        Setting media element 'src' attribute should trigger immediate load
        https://bugs.webkit.org/show_bug.cgi?id=37728

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::attributeChanged): Schedule load every time 'src' attribute
        changes unless it is missing.
        (WebCore::HTMLMediaElement::prepareForLoad): Include steps 3 to 6 from loadInternal.
        (WebCore::HTMLMediaElement::loadInternal): Steps 3 to 6 are now in prepareForLoad.
        (WebCore::HTMLMediaElement::loadResource): MediaPlayer is now allocated in prepareForLoad
        so the previously loading file, if any, is cancelled there.

2010-04-19  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        Setting media element 'src' attribute should trigger immediate load
        https://bugs.webkit.org/show_bug.cgi?id=37728

        * media/event-attributes-expected.txt: Updated results.
        * media/event-attributes.html: Do not need to call load().
        * media/video-source-add-src-expected.txt: Removed.
        * media/video-source-add-src.html: Removed.
        * media/video-src-change-expected.txt: Updated results.
        * media/video-src-change.html: Update test to match current behavior.
        * media/video-src-invalid-remove-expected.txt: Updated results.
        * media/video-src-invalid-remove.html: Update test to match current behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Fix compilation against namespaced Qt.
hausmann@webkit.org [Mon, 19 Apr 2010 18:07:01 +0000 (18:07 +0000)]
[Qt] Fix compilation against namespaced Qt.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2010-04-19
Reviewed by Simon Hausmann.

WebCore:

* platform/graphics/GraphicsLayer.h:
* platform/graphics/Tile.h:
* platform/graphics/qt/MediaPlayerPrivateQt.h:
* platform/network/qt/NetworkStateNotifierPrivate.h:

WebKit/qt:

* WebCoreSupport/ChromeClientQt.h:
* WebCoreSupport/QtFallbackWebPopup.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Balazs Kelemen <kb@inf.u-szeged.hu>
eric@webkit.org [Mon, 19 Apr 2010 18:00:58 +0000 (18:00 +0000)]
2010-04-19  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Destroy SharedTimerQt before destruction of QCoreApplication.

        To avoid unsafe situations caused by running WebCore code (through firing timers) when destruction of QCoreApplication
        has been started, we should explicitly destroy the SharedTimerQt instance on application exit.
        We can achieve that through installing a self-destroying slot for the QCoreApplication::aboutToQuit() signal
        into the SharedTimerQt instance.

        https://bugs.webkit.org/show_bug.cgi?id=36832

        No functional change so no new tests.

        * platform/qt/SharedTimerQt.cpp:
        (WebCore::SharedTimerQt::SharedTimerQt):
        (WebCore::SharedTimerQt::destroy):
        (WebCore::SharedTimerQt::inst):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake the fix for <rdar://problem/7873647> from r57759 more robust.
mitz@apple.com [Mon, 19 Apr 2010 17:48:04 +0000 (17:48 +0000)]
Make the fix for <rdar://problem/7873647> from r57759 more robust.

Reviewed by Darin Adler.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateHoverActiveState): Use RefPtrs for the Nodes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 19 Apr 2010 17:43:23 +0000 (17:43 +0000)]
2010-04-19  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Roben.

        WinLauncher.h should use LF line-endings and use native line-endings style.
        https://bugs.webkit.org/show_bug.cgi?id=37807

        * WinLauncher/WinLauncher.h: Added property svn:eol-style, converted to LF line-endings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Diego Escalante Urrelo <descalante@igalia.com>
eric@webkit.org [Mon, 19 Apr 2010 17:38:11 +0000 (17:38 +0000)]
2010-04-19  Diego Escalante Urrelo  <descalante@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Evaluate and create tests for all the AtkRole's implemented by
        WebKitGtk
        https://bugs.webkit.org/show_bug.cgi?id=34449

        Add and enable the build of testatkroles to test ATK non form roles.

        * GNUmakefile.am:
2010-04-19  Diego Escalante Urrelo  <descalante@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Evaluate and create tests for all the AtkRole's implemented by
        WebKitGtk
        https://bugs.webkit.org/show_bug.cgi?id=34449

        Add testatkroles to test ATK non form roles.

        * tests/testatkroles.c: Added.
        (finish_loading):
        (atk_roles_fixture_setup):
        (atk_roles_fixture_teardown):
        (get_child_and_test_role):
        (test_webkit_atk_get_role_document_frame):
        (test_webkit_atk_get_role_heading):
        (test_webkit_atk_get_role_image):
        (test_webkit_atk_get_role_link):
        (test_webkit_atk_get_role_list_and_item):
        (test_webkit_atk_get_role_paragraph):
        (test_webkit_atk_get_role_section):
        (test_webkit_atk_get_role_table):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFinish exposing extremal shrink factors WebHTMLView uses when shrinking pages to...
mitz@apple.com [Mon, 19 Apr 2010 17:21:27 +0000 (17:21 +0000)]
Finish exposing extremal shrink factors WebHTMLView uses when shrinking pages to fit in the
printing width as SPI.

Reviewed by Sam Weinig.

* WebKit.exp: Export _WebHTMLViewPrintingMinimumShrinkFactor and _WebHTMLViewPrintingMaximumShrinkFactor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 19 Apr 2010 17:11:53 +0000 (17:11 +0000)]
2010-04-19  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Chromium build fix.

        * bindings/v8/JavaScriptCallFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 19 Apr 2010 17:01:39 +0000 (17:01 +0000)]
2010-04-19  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: implement JavaScriptCallFrame that works for v8.
        Implementing this binding for v8 allows to make evaluations on
        call frames and protects access to the debugger context from
        inspected context.

        https://bugs.webkit.org/show_bug.cgi?id=37755

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        (WebCore::JSJavaScriptCallFrame::scopeType):
        * bindings/v8/JavaScriptCallFrame.cpp: Added.
        (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
        (WebCore::JavaScriptCallFrame::~JavaScriptCallFrame):
        (WebCore::JavaScriptCallFrame::caller):
        (WebCore::JavaScriptCallFrame::sourceID):
        (WebCore::JavaScriptCallFrame::line):
        (WebCore::JavaScriptCallFrame::functionName):
        (WebCore::JavaScriptCallFrame::scopeChain):
        (WebCore::JavaScriptCallFrame::scopeType):
        (WebCore::JavaScriptCallFrame::thisObject):
        (WebCore::JavaScriptCallFrame::evaluate):
        * bindings/v8/JavaScriptCallFrame.h: Added.
        (WebCore::JavaScriptCallFrame::create):
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::currentCallFrame):
        * bindings/v8/ScriptDebugServer.h:
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
        * bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp: Added.
        (WebCore::V8JavaScriptCallFrame::evaluateCallback):
        (WebCore::V8JavaScriptCallFrame::scopeChainAccessorGetter):
        (WebCore::V8JavaScriptCallFrame::scopeTypeCallback):
        (WebCore::V8JavaScriptCallFrame::thisObjectAccessorGetter):
        (WebCore::V8JavaScriptCallFrame::typeAccessorGetter):
        * inspector/JavaScriptCallFrame.idl:
        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Unskip a bunch of now passing tests, add expected files and pixel results.
ossy@webkit.org [Mon, 19 Apr 2010 16:41:05 +0000 (16:41 +0000)]
[Qt] Unskip a bunch of now passing tests, add expected files and pixel results.
Additionally fix some minor pixel differences.

Rubber-stamped by Simon Hausmann.

Compared to Mac png files and Mac expected files.

* platform/qt/Skipped:
* platform/qt/fast/frames/frame-navigation-expected.checksum: Added.
* platform/qt/fast/frames/frame-navigation-expected.png: Added.
* platform/qt/fast/frames/frame-navigation-expected.txt: Updated.
* platform/qt/fast/overflow/line-clamp-expected.checksum: Added.
* platform/qt/fast/overflow/line-clamp-expected.png: Added.
* platform/qt/fast/overflow/line-clamp-expected.txt: Added.
* platform/qt/fast/reflections/opacity-reflection-transform-expected.checksum: Added.
* platform/qt/fast/reflections/opacity-reflection-transform-expected.png: Added.
* platform/qt/fast/reflections/opacity-reflection-transform-expected.txt: Added.
* platform/qt/fast/repaint/fixed-tranformed-expected.checksum: Added.
* platform/qt/fast/repaint/fixed-tranformed-expected.png: Added.
* platform/qt/fast/repaint/fixed-tranformed-expected.txt: Added.
* platform/qt/fast/repaint/repaint-during-scroll-expected.checksum: Added.
* platform/qt/fast/repaint/repaint-during-scroll-expected.png: Added.
* platform/qt/fast/repaint/repaint-during-scroll-expected.txt: Added.
* platform/qt/http/tests/local/file-url-sent-as-referer-expected.checksum: Added.
* platform/qt/http/tests/local/file-url-sent-as-referer-expected.png: Added.
* platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt: Updated.
* platform/qt/http/tests/misc/error404-expected.checksum: Added.
* platform/qt/http/tests/misc/error404-expected.png: Added.
* platform/qt/http/tests/misc/error404-expected.txt: Added.
* platform/qt/http/tests/misc/frame-access-during-load-expected.checksum: Added.
* platform/qt/http/tests/misc/frame-access-during-load-expected.png: Added.
* platform/qt/http/tests/misc/frame-access-during-load-expected.txt: Added.
* platform/qt/http/tests/misc/generated-content-inside-table-expected.checksum: Added.
* platform/qt/http/tests/misc/generated-content-inside-table-expected.png: Added.
* platform/qt/http/tests/misc/generated-content-inside-table-expected.txt: Added.
* platform/qt/http/tests/misc/iframe404-expected.checksum: Added.
* platform/qt/http/tests/misc/iframe404-expected.png: Added.
* platform/qt/http/tests/misc/iframe404-expected.txt: Added.
* platform/qt/http/tests/misc/location-replace-crossdomain-expected.checksum: Added.
* platform/qt/http/tests/misc/location-replace-crossdomain-expected.png: Added.
* platform/qt/http/tests/misc/location-replace-crossdomain-expected.txt: Added.
* platform/qt/http/tests/uri/css-href-expected.checksum: Added.
* platform/qt/http/tests/uri/css-href-expected.png: Added.
* platform/qt/http/tests/uri/css-href-expected.txt: Updated.
* platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
* platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
* platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Added.
* platform/qt/svg/text/foreignObject-text-clipping-bug-expected.checksum: Added.
* platform/qt/svg/text/foreignObject-text-clipping-bug-expected.png: Added.
* platform/qt/svg/text/foreignObject-text-clipping-bug-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber Stamped by Adam Roben
jberlin@webkit.org [Mon, 19 Apr 2010 15:05:25 +0000 (15:05 +0000)]
Rubber Stamped by Adam Roben

Chromium Release Build Fix.

* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
In the case where the DATALIST is not enabled, fall through to NOPSEUDO instead of omitting PseudoInputListButton entirely from the switch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFirst steps towards fixing bug 24021 - pseudo-element styles not accessible / retriev...
jberlin@webkit.org [Mon, 19 Apr 2010 13:28:27 +0000 (13:28 +0000)]
First steps towards fixing bug 24021 - pseudo-element styles not accessible / retrievable via DOM methods.
https://bugs.webkit.org/show_bug.cgi?id=24021

Reviewed by Dave Hyatt.

WebCore:

Allows access to the computed styles for the pseudo-elements through the second argument to getComputedStyle.
This approach does not provide the correct values for 'length' properties and does not work for the ':selection' pseudo-element and will instead return results similiar to those returned by Firefox. This approach also requires waiting until at least one iteration of a hardware accelerated composited animation to return the correct values for the "opacity" and "transform" properties of a pseudo-element associated with the element being animated.
Those values need to be retrieved from the renderer for the pseudo-element as opposed to the cached RenderStyle for the element on which the pseudo-element is defined, which is further complicated by the fact that not all elements have renderers.

Test: fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html

* WebCore.base.exp:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::CSSComputedStyleDeclaration):
Parse the and store the pseudo-element specifier from the string provided by the user.
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
Get the computed style for the pseudo-element if it has been specified.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Get the computed style for the pseudo-element if it has been specified, with a FIXME noting that the values returned for the "opacity" and "transform" properties of a pseudo-element associated with an element being animated and using hardware accelerated compositing will not be correct until after the first iteration of the animation.
(WebCore::CSSComputedStyleDeclaration::length):
Get the computed style for the pseudo-element if it has been specified.
(WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
Ditto.
* css/CSSComputedStyleDeclaration.h:
(WebCore::computedStyle):
Take into consideration the pseudo-element.

* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
Return the PseudoId that corresponds to the given PseudoType. If there is no corresponding PseudoId, returns NOPSEUDO.
(WebCore::nameToPseudoTypeMap):
Create and return the mapping between string names and PseudoTypes.
(WebCore::CSSSelector::parsePseudoType):
Parse and the given string into a PseudoType.
(WebCore::CSSSelector::extractPseudoType):
Refactored to use parsePseudoType.
* css/CSSSelector.h:

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
Refactored to use pseudoId.

* dom/Element.cpp:
(WebCore::Element::computedStyle):
If the pseudo-element is specified, then return the cached RenderStyle for that PseudoId. Added a FIXME to find the actual renders of the pseudo-elements instead of just the cached RenderStyle of the RenderStyle for the associated element.
* dom/Element.h:
(WebCore::Element::virtualComputedStyle):
Because Element::computedStyle is used so often, don't make it virtual. Instead, provide a virtualComputedStyle method in the Node.h class andmake computedStyle non-virtual. That way the Element version and the Node version of computedStyle will have the same name and look the same at the call site, but the Element version will be more efficient.

* dom/Node.h:
(WebCore::Node::computedStyle):
Ditto.
* dom/Node.cpp:
(WebCore::Node::virtualComputedStyle):
Get the computed style for the pseudo-element if it has been specified.

* page/DOMWindow.cpp:
(WebCore::DOMWindow::getComputedStyle):
Ditto.

LayoutTests:

* fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] lacks clipToImageBuffer()
ossy@webkit.org [Mon, 19 Apr 2010 11:54:04 +0000 (11:54 +0000)]
[Qt] lacks clipToImageBuffer()
https://bugs.webkit.org/show_bug.cgi?id=24289

Skip svg/clip-path tests introduced in r52511,
and move clip related tests here.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 19 Apr 2010 09:05:53 +0000 (09:05 +0000)]
2010-04-19  Kent Tamura  <tkent@chromium.org>

        Reviewed by Shinichiro Hamaji.

        [DRT/Chromium] Fix a test initialization problem
        https://bugs.webkit.org/show_bug.cgi?id=37791

        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (runTest): Call resetTestController() before runFileTest(). Some
          controllers initialize their fields in reset() and not in their
          constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-19 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 19 Apr 2010 08:40:46 +0000 (08:40 +0000)]
2010-04-19  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt
        https://bugs.webkit.org/show_bug.cgi?id=37793

        We need to use WebKitDriver instead of ChromiumDriver for Chromium
        DRT because its interface is different from test_shell.

        Chromium DRT has no UI.  So we can't use it to show test results.

        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 19 Apr 2010 06:36:31 +0000 (06:36 +0000)]
2010-04-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Roben.

        Make failure-reason more forgiving
        https://bugs.webkit.org/show_bug.cgi?id=37525

        Removed search_limit, which wasn't very useful anyway.
        Added a log about the long load time loading from the builders.
        Prompt the user for what revision to start walking from (makes it easy to restart upon failure).

        * Scripts/webkitpy/common/net/buildbot.py:
        * Scripts/webkitpy/tool/commands/queries.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-18 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Mon, 19 Apr 2010 05:13:27 +0000 (05:13 +0000)]
2010-04-18  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Laszlo Gombos.

        [WINCE] Don't define WTF_CPU_MIDDLE_ENDIAN=1
        https://bugs.webkit.org/show_bug.cgi?id=37434

        Windows CE supports little-endian format only, so don't define
        WTF_CPU_MIDDLE_ENDIAN=1.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCreated a class for check-webkit-style that encapsulates iterating
cjerdonek@webkit.org [Mon, 19 Apr 2010 04:26:52 +0000 (04:26 +0000)]
Created a class for check-webkit-style that encapsulates iterating
over text files and reading them.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=37754

This revision is an intermediate step towards separating our
style-checking code from the logic of iterating over files and
reading them.

* Scripts/webkitpy/common/system/logtesting.py:
  - Added a logMessages() method to the LoggingTestCase class.
    This method provides unit tests with access to the raw list
    of log messages in case the tester needs to do something more
    than simply assert the list of existing messages.

* Scripts/webkitpy/style/checker.py:
  - Added a ProcessorBase class that processors of lists of lines
    should eventually inherit from.
  - Also added a FIXME to use the ProcessorBase class and the
    TextFileReader class added below.

* Scripts/webkitpy/style/filereader.py: Added.
  - Created a TextFileReader class that encapsulates reading
    and iterating over text files.

* Scripts/webkitpy/style/filereader_unittest.py: Added.
  - Added a TextFileReaderTest class to unit-test the
    new TextFileReader class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-18 Simon Hausmann <simon.hausmann@nokia.com>
eric@webkit.org [Mon, 19 Apr 2010 04:22:45 +0000 (04:22 +0000)]
2010-04-18  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Fix JavaScriptCore's include path for WinCE builds

        https://bugs.webkit.org/show_bug.cgi?id=36751

        * JavaScriptCore.pri:
2010-04-18  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Fix JavaScriptCore's include path for WinCE builds

        https://bugs.webkit.org/show_bug.cgi?id=36751

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-18 Michael Forney <michael@mforney.org>
eric@webkit.org [Mon, 19 Apr 2010 04:08:31 +0000 (04:08 +0000)]
2010-04-18  Michael Forney  <michael@mforney.org>

        Reviewed by Laszlo Gombos.

        https://bugs.webkit.org/show_bug.cgi?id=37762

        Fixes the sandbox option in configure.

        * configure.ac: Fix cut and paste error in the sandbox option causing
        --{enable,disable}-sandbox to be ineffective, and it to be controlled
        by the ruby flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-15 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 19 Apr 2010 03:26:56 +0000 (03:26 +0000)]
2010-04-15  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        [chromium] new-run-webkit-tests should be able to use chromium DRT
        https://bugs.webkit.org/show_bug.cgi?id=37645

        Make sure that the lack of a chromium checkout doesn't cause the script to
        fail.

        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Fix up a few paths
            to be relative to an upstream output dir.
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --use-drt flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 18 Apr 2010 21:25:33 +0000 (21:25 +0000)]
2010-04-18  Eric Seidel  <eric@webkit.org>

        Unreviewed, fixing the Qt bot.

        Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
        https://bugs.webkit.org/show_bug.cgi?id=37632

        * Scripts/run-webkit-tests:
         - Exit non-zero of launching the harness fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 18 Apr 2010 20:58:47 +0000 (20:58 +0000)]
2010-04-18  Eric Seidel  <eric@webkit.org>

        Unreviewed, fixing the Qt bot.

        Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
        https://bugs.webkit.org/show_bug.cgi?id=37632

        * Scripts/run-webkit-tests:
         - Fix the wrapper to work for users who do not
           have WebKitTools/Scripts in their path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 18 Apr 2010 20:56:49 +0000 (20:56 +0000)]
2010-04-18  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Update a label of the diagram to better match the
        description in the text of the blog post.

        * blog-files/loader-diagram.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-14 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 18 Apr 2010 20:34:17 +0000 (20:34 +0000)]
2010-04-14  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add a layer of indirection when calling run-webkit-tests to
        allow testing new-run-webkit-tests on various platforms.
        https://bugs.webkit.org/show_bug.cgi?id=37632

        This will let us test and fix bugs in new-run-webkit-tests
        without needing to restart the buildbot master between tests.

        Currently this change leaves run-webkit-tests as-is, but once
        its landed we will easily be able to turn on/off
        new-run-webkit-tests for various ports/configurations.

        I will send a note out to webkit-dev about how we will
        be using this launcher script to test on the bots.

        * Scripts/old-run-webkit-tests: Copied from WebKitTools/Scripts/run-webkit-tests.
        * Scripts/run-webkit-tests:
         - A new script which decides whether to run new- or old-
           run-webkit-tests based on the platform.
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
         - Add some dummy argument handling for arguments which
           old-run-webkit-tests supports but new-run-webkit-tests
           does not yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 18 Apr 2010 17:43:50 +0000 (17:43 +0000)]
2010-04-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
        https://bugs.webkit.org/show_bug.cgi?id=33295

        The Gtk builders have been green every time I've looked
        at them in the last 5 days or so.  It would appear webkit
        is now keeping them green and we should update the core
        builder list to match reality.

        * Scripts/webkitpy/common/net/buildbot.py:
        * Scripts/webkitpy/common/net/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Add support for LayoutTestController commands
robert@webkit.org [Sun, 18 Apr 2010 11:01:58 +0000 (11:01 +0000)]
[Qt] Add support for LayoutTestController commands

2010-04-18  Robert Hogan  <robert@webkit.org>

        Unreviewed fix to pixel differences in unskipped layout tests.

        [Qt] Add support for LayoutTestController commands

        Fix up minor pixel differences on unskipped tests from r57793.

        https://bugs.webkit.org/show_bug.cgi?id=35844

        * platform/qt/editing/deleting/smart-delete-003-expected.txt:
        * platform/qt/editing/deleting/smart-delete-004-expected.txt:
        * platform/qt/editing/selection/5195166-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/5195166-1-expected.txt.
        * platform/qt/editing/selection/5195166-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Add support for LayoutTestController commands
robert@webkit.org [Sun, 18 Apr 2010 10:36:12 +0000 (10:36 +0000)]
[Qt] Add support for LayoutTestController commands
2010-04-18  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Add support for LayoutTestController commands:
                   setSmartInsertDeleteEnabled
                   setSelectTrailingWhitespaceEnabled
                   execCommand
                   isCommandEnabled

        https://bugs.webkit.org/show_bug.cgi?id=35844

        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate):
        * Api/qwebpage_p.h:
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::setSmartInsertDeleteEnabled):
        (DumpRenderTreeSupportQt::setSelectTrailingWhitespaceEnabled):
        (DumpRenderTreeSupportQt::executeCoreCommandByName):
        (DumpRenderTreeSupportQt::isCommandEnabled):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::smartInsertDeleteEnabled):
        (WebCore::EditorClientQt::toggleSmartInsertDelete):
        (WebCore::EditorClientQt::isSelectTrailingWhitespaceEnabled):
        * WebCoreSupport/EditorClientQt.h:

2010-04-18  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Add support for LayoutTestController commands:
                   setSmartInsertDeleteEnabled
                   setSelectTrailingWhitespaceEnabled
                   execCommand
                   isCommandEnabled

        Unskip tests:
        editing/deleting/smart-editing-disabled.html
        editing/execCommand/19089.html
        editing/execCommand/delete-image-in-anchor.html
        editing/execCommand/enabling-and-selection-2.html
        editing/selection/doubleclick-whitespace-crash.html
        editing/selection/doubleclick-whitespace-img-crash.html
        editing/selection/doubleclick-whitespace.html
        editing/selection/select-line.html
        editing/deleting/5300379.html
        editing/deleting/smart-delete-003.html
        editing/deleting/smart-delete-004.html
        editing/selection/5195166-1.html
        editing/selection/5195166-2.html

        https://bugs.webkit.org/show_bug.cgi?id=35844

        * platform/qt/Skipped:
        * platform/qt/editing/deleting/5300379-expected.txt: Update platform-specific results.
        * platform/qt/editing/deleting/smart-delete-003-expected.txt: Update platform-specific results.
        * platform/qt/editing/deleting/smart-delete-004-expected.txt: Update platform-specific results.
        * platform/qt/editing/selection/5195166-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/5195166-1-expected.txt.
        * platform/qt/editing/selection/5195166-2-expected.txt: Update platform-specific results.

2010-04-18  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Add support for LayoutTestController commands:
                   setSmartInsertDeleteEnabled
                   setSelectTrailingWhitespaceEnabled
                   execCommand
                   isCommandEnabled

        https://bugs.webkit.org/show_bug.cgi?id=35844

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::resetSettings):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setSmartInsertDeleteEnabled):
        (LayoutTestController::setSelectTrailingWhitespaceEnabled):
        (LayoutTestController::execCommand):
        (LayoutTestController::isCommandEnabled):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-18 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Sun, 18 Apr 2010 10:25:54 +0000 (10:25 +0000)]
2010-04-18  Antonio Gomes  <tonikitoo@webkit.org>

        [Qt] Unreviewed fix: remove svg/custom/clip-path-display-none-child.svg from Skipped (non-existent test)

        It was removed by r57511.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 18 Apr 2010 06:27:01 +0000 (06:27 +0000)]
2010-04-17  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Added loader diagram for upcoming blog post.

        * blog-files/loader-diagram.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Adam Barth.
ap@apple.com [Sun, 18 Apr 2010 06:03:46 +0000 (06:03 +0000)]
    Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=37720
        <rdar://problem/7873752> HTMLFrameSetElement-window-eventListener-attributes.html sometimes
        crashes on SnowLeopard Release

        Tests:
        * fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html:
        * fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html:

        * bindings/scripts/CodeGeneratorJS.pm: Use global object as a wrapper for window event
        listeners set via document.body. The body wrapper can go away if nothing else references it.

        * html/HTMLBodyElement.idl: Override listeners that exist on Element with custom implementations,
        because we need to use window object as a wrapper, not the element. Marked all window event
        listeners as such for code generator.

        * html/HTMLFrameSetElement.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Juan C. Montemayor <jmonte03@cs.tufts.edu>
joepeck@webkit.org [Sun, 18 Apr 2010 05:00:26 +0000 (05:00 +0000)]
2010-04-17  Juan C. Montemayor  <jmonte03@cs.tufts.edu>

        Reviewed by Joseph Pecoraro.

        Databases pane doesn't recognize table creation/deletion
        https://bugs.webkit.org/show_bug.cgi?id=20219

        * inspector/front-end/DatabaseQueryView.js:
        (WebInspector.DatabaseQueryView.prototype._queryFinished):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Adam Barth <abarth@webkit.org>
eric@webkit.org [Sun, 18 Apr 2010 00:42:05 +0000 (00:42 +0000)]
2010-04-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove steps_references and commands_references
        https://bugs.webkit.org/show_bug.cgi?id=37758

        We tried using the mumble_references convention to manage our
        dependencies, but it doesn't seem to be providing much value for the
        steps and commands module because these modules are small pieces of the
        larger tool module.  In this patch, I've removed the references file
        for these modules.

        I've left the style_references file for the style module because that
        module seems better isolated from the rest of webkitpy and the
        style_references file appears to be providing some value.

        * Scripts/webkitpy/tool/commands/commandtest.py:
        * Scripts/webkitpy/tool/commands/download_unittest.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
        * Scripts/webkitpy/tool/commands/queries_unittest.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/commands/queuestest.py:
        * Scripts/webkitpy/tool/commands/upload.py:
        * Scripts/webkitpy/tool/commands/upload_unittest.py:
        * Scripts/webkitpy/tool/commands_references.py: Removed.
        * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
        * Scripts/webkitpy/tool/steps/steps_unittest.py:
        * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
        * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
        * Scripts/webkitpy/tool/steps_references.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Sat, 17 Apr 2010 20:43:30 +0000 (20:43 +0000)]
2010-04-17  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Adam Barth.

        Auto-generate V8 bindings for canvas.* overloads
        https://bugs.webkit.org/show_bug.cgi?id=37453

        * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Deleted custom code that is now auto-generated.
        * bindings/scripts/CodeGeneratorV8.pm: Not generating custom signatures for overloaded methods and accepting Object as a string input.
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::drawImage): Added missing 9-arguments overloads for drawImage.
        * html/canvas/CanvasRenderingContext2D.h:
        * html/canvas/CanvasRenderingContext2D.idl: Overloaded methods defined (V8 only).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Adam Barth <abarth@webkit.org>
eric@webkit.org [Sat, 17 Apr 2010 20:10:36 +0000 (20:10 +0000)]
2010-04-17  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Test file: URL canonicalization
        https://bugs.webkit.org/show_bug.cgi?id=37700

        Re-land http://trac.webkit.org/changeset/57719, hopefully not breaking
        the Windows bot this time.

        * fast/url/file-expected.txt: Added.
        * fast/url/file.html: Added.
        * fast/url/mailto.html:
        * fast/url/script-tests/file.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Adam Barth <abarth@webkit.org>
eric@webkit.org [Sat, 17 Apr 2010 20:00:39 +0000 (20:00 +0000)]
2010-04-17  Adam Barth  <abarth@webkit.org>

        Unreviewed, but I took Jeremy Orlow's suggestions on an earlier
        iteration of this patch.

        Add URL parsing tests for relative URL resolution
        https://bugs.webkit.org/show_bug.cgi?id=37644

        I've split the platform specific parts of this test into separate
        files.  On KURL-based ports these should have the same results on every
        platform.  We can decide whether to have platform-specific behavior at
        a later time.

        * fast/url/relative-expected.txt: Added.
        * fast/url/relative-unix-expected.txt: Added.
        * fast/url/relative-unix.html: Added.
        * fast/url/relative-win-expected.txt: Added.
        * fast/url/relative-win.html: Added.
        * fast/url/relative.html: Added.
        * fast/url/script-tests/relative-unix.js: Added.
        * fast/url/script-tests/relative-win.js: Added.
        * fast/url/script-tests/relative.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Yury Semikhatsky <yurys@chromium.org>
eric@webkit.org [Sat, 17 Apr 2010 18:42:07 +0000 (18:42 +0000)]
2010-04-17  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: move JavaScriptCallFrame.{h,cpp} to WebCore/bindings/js

        https://bugs.webkit.org/show_bug.cgi?id=37740

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JavaScriptCallFrame.cpp: Renamed from WebCore/inspector/JavaScriptCallFrame.cpp.
        (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
        (WebCore::JavaScriptCallFrame::caller):
        (WebCore::JavaScriptCallFrame::scopeChain):
        (WebCore::JavaScriptCallFrame::dynamicGlobalObject):
        (WebCore::JavaScriptCallFrame::functionName):
        (WebCore::JavaScriptCallFrame::type):
        (WebCore::JavaScriptCallFrame::thisObject):
        (WebCore::JavaScriptCallFrame::evaluate):
        * bindings/js/JavaScriptCallFrame.h: Renamed from WebCore/inspector/JavaScriptCallFrame.h.
        (WebCore::JavaScriptCallFrame::create):
        (WebCore::JavaScriptCallFrame::invalidate):
        (WebCore::JavaScriptCallFrame::isValid):
        (WebCore::JavaScriptCallFrame::sourceID):
        (WebCore::JavaScriptCallFrame::line):
        (WebCore::JavaScriptCallFrame::update):
        * inspector/InjectedScriptHost.h:
        * inspector/InspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Sat, 17 Apr 2010 16:00:23 +0000 (16:00 +0000)]
2010-04-17  Alejandro G. Castro  <alex@igalia.com>

        Rubber-stamped by Xan Lopez.

        Skipping media/audio-constructor-preload.html
        https://bugs.webkit.org/show_bug.cgi?id=37753

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Sat, 17 Apr 2010 15:49:19 +0000 (15:49 +0000)]
2010-04-17  Alejandro G. Castro  <alex@igalia.com>

        Rubber-stamped by Xan Lopez.

        Skipping inspector/timeline-paint.html
        https://bugs.webkit.org/show_bug.cgi?id=37752

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Sat, 17 Apr 2010 15:16:15 +0000 (15:16 +0000)]
2010-04-17  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        We have to initialize the timer attribute after destroying it, not
        doing it was causing crashes in some situations.

        * webkit/webkitdownload.cpp:
        (webkit_download_finalize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Vangelis Kokkevis <vangelis@chromium.org>
eric@webkit.org [Sat, 17 Apr 2010 14:55:28 +0000 (14:55 +0000)]
2010-04-17  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Dimitri Glazkov.

        Adding definition of GLES2Context class.
        https://bugs.webkit.org/show_bug.cgi?id=37541

        No new functionality implemented yet, no tests.

        * WebCore.gypi: Added GLES2Context.h
        * platform/chromium/GLES2Context.h: Added.
2010-04-17  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Dimitri Glazkov.

        Adding the implementation of GLES2Context class which provides WebCore access to a GL ES context.
        https://bugs.webkit.org/show_bug.cgi?id=37541

        * WebKit.gyp:
        * public/WebGLES2Context.h: Added.
        (WebKit::WebGLES2Context::~WebGLES2Context):
        * src/GLES2Context.cpp: Added.
        (WebCore::GLES2ContextInternal::GLES2ContextInternal):
        (WebCore::GLES2ContextInternal::~GLES2ContextInternal):
        (WebCore::GLES2ContextInternal::getWebGLES2Context):
        (WebCore::GLES2ContextInternal::initialize):
        (WebCore::GLES2Context::create):
        (WebCore::GLES2Context::~GLES2Context):
        (WebCore::GLES2Context::initialize):
        (WebCore::GLES2Context::makeCurrent):
        (WebCore::GLES2Context::destroy):
        (WebCore::GLES2Context::swapBuffers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCrash while handling SVG font in the wrong namespace imported with @font-face
jchaffraix@webkit.org [Sat, 17 Apr 2010 13:37:55 +0000 (13:37 +0000)]
Crash while handling SVG font in the wrong namespace imported with @font-face
https://bugs.webkit.org/show_bug.cgi?id=18862

Reviewed by Darin Adler.

WebCore:

Test: fast/invalid/invalidSVGFont.html

* loader/CachedFont.cpp:
(WebCore::CachedFont::getSVGFontById): Make sure we really get an SVGFontElement by using
getElementsByNameNS: the element factory chooses which element to create based on both
localName and namespace.

LayoutTests:

Test that load an SVG document not in the SVG namespace with @font-face does not
lead to a crash.

* fast/invalid/invalidSVGFont-expected.txt: Added.
* fast/invalid/invalidSVGFont.html: Added.
* fast/invalid/resources/svgFontWrongNamespace.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 17 Apr 2010 08:13:20 +0000 (08:13 +0000)]
2010-04-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        WebKit needs a Chromium Mac EWS Builder
        https://bugs.webkit.org/show_bug.cgi?id=37742

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 17 Apr 2010 08:02:44 +0000 (08:02 +0000)]
2010-04-17  Adam Barth  <abarth@webkit.org>

        Fix expected results for unit test broken by
        http://trac.webkit.org/changeset/57772

        * Scripts/webkitpy/common/net/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, rolling out r57770.
ossy@webkit.org [Sat, 17 Apr 2010 06:14:13 +0000 (06:14 +0000)]
Unreviewed, rolling out r57770.
http://trac.webkit.org/changeset/57770
https://bugs.webkit.org/show_bug.cgi?id=37746

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-04-16
8 test cases crashed (Requested by Ossy on #webkit).

WebCore:

* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::AnimationQtBase::AnimationQtBase):
(WebCore::TransformAnimationQt::~TransformAnimationQt):
(WebCore::TransformAnimationQt::applyFrame):
(WebCore::OpacityAnimationQt::applyFrame):
(WebCore::GraphicsLayerQt::addAnimation):

LayoutTests:

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Sat, 17 Apr 2010 04:40:14 +0000 (04:40 +0000)]
2010-04-16  Daniel Bates  <dbates@rim.com>

        Reviewed by Adam Treat.

        https://bugs.webkit.org/show_bug.cgi?id=36312

        Adds support for the viewport meta tag. The code is largely derived in whole
        or in part from the WebCore-528.15 source published as part of the iPhone 3.1.3
        source code <http://www.opensource.apple.com/source/WebCore/WebCore-528.15/>.

        * Android.mk: Added file ViewportArguments.cpp.
        * GNUmakefile.am: Added files ViewportArguments.cpp and ViewportArguments.h.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * dom/Document.cpp:
        (WebCore::isSeparator): Added.
        (WebCore::Document::processArguments): Added.
        (WebCore::Document::processViewport): Added.
        * dom/Document.h:
        * dom/ViewportArguments.cpp: Added.
        (WebCore::setViewportFeature):
        (WebCore::viewportErrorMessageTemplate):
        (WebCore::viewportErrorMessageLevel):
        (WebCore::reportViewportWarning):
        * dom/ViewportArguments.h: Added.
        (WebCore::):
        (WebCore::ViewportArguments::):
        (WebCore::ViewportArguments::ViewportArguments):
        (WebCore::ViewportArguments::hasCustomArgument):
        * html/HTMLMetaElement.cpp:
        (WebCore::HTMLMetaElement::process): Modified to call Document::processViewport.
        * page/ChromeClient.h:
        (WebCore::ChromeClient::didReceiveViewportArguments): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove the need for a .defs file! Define WK_EXPORT.
weinig@apple.com [Sat, 17 Apr 2010 03:23:57 +0000 (03:23 +0000)]
Remove the need for a .defs file! Define WK_EXPORT.

Reviewed by Jon "The Belly" Honeycutt.

* UIProcess/API/C/WKBase.h:
* WebProcess/win/WebProcessMain.h:
* win/WebKit2.def: Removed.
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTeach windows MiniBrowser how to work with window.open()
weinig@apple.com [Sat, 17 Apr 2010 03:06:42 +0000 (03:06 +0000)]
Teach windows MiniBrowser how to work with window.open()
and targeted links.

Reviewed by Adam Roben.

WebKit2:

Export WKPageSetPageUIClient.

* win/WebKit2.def:

WebKitTools:

* MiniBrowser/win/BrowserView.cpp:
(createNewPage): Create a new BrowserWindow and return its page.
(showPage): Show the page.
(closePage): Empty implementation.
(runJavaScriptAlert): Empty implementation.
(BrowserView::create): Register a UIClient.
* MiniBrowser/win/BrowserView.h:
(BrowserView::webView): Added.
Change create to take a BrowserWindow instead of an HWND.

* MiniBrowser/win/BrowserWindow.cpp:
(BrowserWindow::wndProc): Respond to WM_NCDESTROY.
(BrowserWindow::goToURL): Added. Forwards to BrowserView.
(BrowserWindow::onCreate): Don't always go to the default
url. Let the caller do this.
(BrowserWindow::onNCDestroy): Delete the window.
* MiniBrowser/win/BrowserWindow.h:
(BrowserWindow::view): Added.
(BrowserWindow::window): Added.

* MiniBrowser/win/main.cpp:
(_tWinMain):
Go to the default URL for the initial page. Allocate the initial
window on the heap for correctness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd the Windows Debug (Test) builder to the list of core builders
aroben@apple.com [Sat, 17 Apr 2010 02:53:59 +0000 (02:53 +0000)]
Add the Windows Debug (Test) builder to the list of core builders

It's been green for a few days now, and all the known Windows
flakiness is Release-only.

Rubber-stamped by Mark Rowe.

* Scripts/webkitpy/common/net/buildbot.py:
(BuildBot.core_builder_name_regexps): Added a regular expression to
match the "Windows Debug (Test)" builder.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoGet rid of the UNUSED_PARAM macro in GraphicsContext3D.cpp.
dumi@chromium.org [Sat, 17 Apr 2010 02:30:14 +0000 (02:30 +0000)]
Get rid of the UNUSED_PARAM macro in GraphicsContext3D.cpp.
https://bugs.webkit.org/show_bug.cgi?id=37733

Reviewed by Eric Seidel.

* src/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 No'am Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Sat, 17 Apr 2010 02:04:50 +0000 (02:04 +0000)]
2010-04-16  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Antti Koivisto.

        [Qt] GraphicsLayer: support fill-modes
        https://bugs.webkit.org/show_bug.cgi?id=36216

        Remove LayoutTests/animations/fill-mode-transform.html from the skip list

        * platform/qt/Skipped:
2010-04-16  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Antti Koivisto.

        [Qt] GraphicsLayer: support fill-modes
        https://bugs.webkit.org/show_bug.cgi?id=36216
        Implement the CSS-animation "fill mode" concept in GraphicsLayerQt. The concept
        enables a key-frame animation to go to the animation's starting point before the delay,
        and/or to stay at the animation's ending point after its ended, without reverting to the default
        value.
        We do that by manually setting the value to keyframe-0 before the delay if fill-mode is backwards/both,
        and manually modifying the default value to the animated value as we animate, with fill-mode forwards/both.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::AnimationQtBase::AnimationQtBase):
        (WebCore::TransformAnimationQt::~TransformAnimationQt):
        (WebCore::TransformAnimationQt::applyFrame):
        (WebCore::GraphicsLayerQt::addAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* bindings/js/JSDesktopNotificationsCustom.cpp:
barraclough@apple.com [Sat, 17 Apr 2010 00:24:42 +0000 (00:24 +0000)]
* bindings/js/JSDesktopNotificationsCustom.cpp:
(WebCore::JSNotification::addEventListener):
(WebCore::JSNotification::removeEventListener):

Reviewed by NOBODY (arm build fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChanging the return type of WebSecurityOrigin::createFromDatabaseIdentifier().
dumi@chromium.org [Sat, 17 Apr 2010 00:20:51 +0000 (00:20 +0000)]
Changing the return type of WebSecurityOrigin::createFromDatabaseIdentifier().
https://bugs.webkit.org/show_bug.cgi?id=34466

Reviewed by Jeremy Orlow.

Changing the return type of
WebSecurityOrigin::createFromDatabaseIdentifier() from
WebSecurityOrigin* to WebSecurityOrigin, to make it more
consistent with the other WebSecurityOrigin methods.

* public/WebSecurityOrigin.h:
* src/WebDatabase.cpp:
(WebKit::WebDatabase::closeDatabaseImmediately):
* src/WebSecurityOrigin.cpp:
(WebKit::WebSecurityOrigin::createFromDatabaseIdentifier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: [v8] In Workers, script errors right after close() are not delivered to...
dimich@chromium.org [Sat, 17 Apr 2010 00:12:30 +0000 (00:12 +0000)]
WebCore: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror.
https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

Existing worker-close.html will now work in Chromium.

* bindings/v8/V8Utilities.cpp:
(WebCore::getScriptExecutionContext): Stop using proxy() to just retrieve WorkerContext which should be always available.
* bindings/v8/WorkerContextExecutionProxy.h: removed workerContext() accessor which moved to WorkerScriptController.
* bindings/v8/WorkerScriptController.h:
(WebCore::WorkerScriptController::workerContext): Added, to be able to pull WorkerContext out from the controller.

WebKit/chromium: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror
https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::createWorkerContextProxy): Don't need to pull V8 proxy to retrieve current WorkerContext.

LayoutTests: [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror
https://bugs.webkit.org/show_bug.cgi?id=37691

Reviewed by Yury Semikhatsky.

Moved the expected result into platform-independent chromium subdirectory, since
the only chromium-specific difference is the way v8 formats an error message.
Also updated the expected result to match the passing now test.

* platform/chromium-win/fast/workers/worker-close-expected.txt: Removed.
* platform/chromium/fast/workers/worker-close-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=37735
barraclough@apple.com [Sat, 17 Apr 2010 00:10:39 +0000 (00:10 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=37735
Remove JSC specific code from WebCore::AtomicString

Reviewed by Sam Weinig.

Add generic constructor/add/find methods that take a UChar* & length, along
with a known existing hash for the string.
This removes the remaining JSC specific code from platform/text.

* bindings/js/JSAbstractWorkerCustom.cpp:
(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):
* bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
* bindings/js/JSDOMBinding.cpp:
(WebCore::ustringToAtomicString):
(WebCore::identifierToAtomicString):
(WebCore::findAtomicString):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::childFrameGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener):
* bindings/js/JSElementCustom.cpp:
(WebCore::JSElement::setAttribute):
(WebCore::JSElement::setAttributeNS):
* bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):
* bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::JSHTMLAllCollection::canGetItemsForName):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::JSHTMLCollection::canGetItemsForName):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::canGetItemsForName):
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::canGetItemsForName):
(WebCore::JSHTMLFormElement::nameGetter):
* bindings/js/JSHTMLFrameSetElementCustom.cpp:
(WebCore::JSHTMLFrameSetElement::canGetItemsForName):
(WebCore::JSHTMLFrameSetElement::nameGetter):
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::initMessageEvent):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
* bindings/js/JSMimeTypeArrayCustom.cpp:
(WebCore::JSMimeTypeArray::canGetItemsForName):
(WebCore::JSMimeTypeArray::nameGetter):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
* bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeList::canGetItemsForName):
(WebCore::JSNodeList::nameGetter):
* bindings/js/JSPluginArrayCustom.cpp:
(WebCore::JSPluginArray::canGetItemsForName):
(WebCore::JSPluginArray::nameGetter):
* bindings/js/JSPluginCustom.cpp:
(WebCore::JSPlugin::canGetItemsForName):
(WebCore::JSPlugin::nameGetter):
* bindings/js/JSPopStateEventCustom.cpp:
(WebCore::JSPopStateEvent::initPopStateEvent):
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::setRequestHeader):
(WebCore::JSXMLHttpRequest::getResponseHeader):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener):
* platform/text/AtomicString.cpp:
(WebCore::AtomicString::add):
(WebCore::AtomicString::find):
* platform/text/AtomicString.h:
(WebCore::AtomicString::AtomicString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix typo from r55729
aroben@apple.com [Fri, 16 Apr 2010 23:58:22 +0000 (23:58 +0000)]
Fix typo from r55729

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix window.open() and targeted links.
weinig@apple.com [Fri, 16 Apr 2010 23:51:54 +0000 (23:51 +0000)]
Fix window.open() and targeted links.

Reviewed by Anders Carlsson.

WebKit2:

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveSyncMessage): Pass in the new pageID
instead of 0.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::createWebPage): Allow for the page to have already
been created, as is the case with programmatic window opening from within
WebCore (e.g. window.open() or <a target="_blank">).

WebKitTools:

* MiniBrowser/mac/BrowserWindowController.m:
(_createNewPage): Use the correct initializer to and load the window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Fixing chromium build.
ajwong@chromium.org [Fri, 16 Apr 2010 23:45:20 +0000 (23:45 +0000)]
Not reviewed. Fixing chromium build.

[chromium] Upstream test_expectations.txt changes from chromium.
Mark letter_spacing.html as consistently failing for mac.
Fixing a syntax error in the test_expectations.txt file.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Fixing chromiumg build.
ajwong@chromium.org [Fri, 16 Apr 2010 23:31:24 +0000 (23:31 +0000)]
Not reviewed. Fixing chromiumg build.

[chromium] filterRes.svg is consistently failing now. Marking as such.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDon't optimize debug builds.
weinig@apple.com [Fri, 16 Apr 2010 23:23:01 +0000 (23:23 +0000)]
Don't optimize debug builds.

Reviewed by Mark Rowe.

* WebKit2.xcodeproj/project.pbxproj: Define GCC_OPTIMIZATION_LEVEL correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Fri, 16 Apr 2010 23:13:30 +0000 (23:13 +0000)]
2010-04-16  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        WebSocket crash when it receives bad header.
        https://bugs.webkit.org/show_bug.cgi?id=37682

        * websocket/tests/bad-handshake-crash-expected.txt: Added.
        * websocket/tests/bad-handshake-crash.html: Added.
        * websocket/tests/bad-handshake-crash_wsh.py: Added.
        * websocket/tests/script-tests/bad-handshake-crash.js: Added.
2010-04-16  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        WebSocket crash when it receives bad header.
        https://bugs.webkit.org/show_bug.cgi?id=37682

        If name or value is not valid UTF-8, nameStr or valueStr would be
        null string, so crashed in headers->add(nameStr, valueStr).
        Check both nameStr and valueStr are not null string.
        Otherwise handshake will fail.

        Test: websocket/tests/bad-handshake-crash.html

        * websockets/WebSocketHandshake.cpp:
        (WebCore::WebSocketHandshake::readHTTPHeaders): check nameStr and valueStr are not null string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/7873647> Crash when updating hover state
mitz@apple.com [Fri, 16 Apr 2010 23:10:19 +0000 (23:10 +0000)]
<rdar://problem/7873647> Crash when updating hover state

Reviewed by Simon Fraser.

WebCore:

Test: fast/dynamic/hover-style-recalc-crash.html

Updating the hover state of an element caused the document to need style
recalc, and then updating the hover state of a link caused style recalc,
which changed the render tree while updateHoverActiveState() was iterating
over it, leading to a crash.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateHoverActiveState): Collect the nodes to be
updated into vectors, then update their active and hover states.

LayoutTests:

* fast/dynamic/hover-style-recalc-crash-expected.txt: Added.
* fast/dynamic/hover-style-recalc-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Build fix.
ajwong@chromium.org [Fri, 16 Apr 2010 23:07:32 +0000 (23:07 +0000)]
Not reviewed. Build fix.

[chromium] Compile fix. Missing include header, and missing type conversion.

* src/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3DInternal::beginPaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix build.
andersca@apple.com [Fri, 16 Apr 2010 22:42:29 +0000 (22:42 +0000)]
Fix build.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScriptInMainFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
barraclough@apple.com [Fri, 16 Apr 2010 22:31:40 +0000 (22:31 +0000)]
Bug 37730 - Remove JSC::UString dependencies from WebCore::StringImpl
(Following on from bug #37675).

Reviewed by Oliver Hunt.

Make the argument ordering for UStringImpl's constructor & create
methods match, when passed a shared buffer.

* JavaScriptCore.exp:
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::create):
* runtime/UStringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-04-16 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Fri, 16 Apr 2010 22:29:47 +0000 (22:29 +0000)]
2010-04-16  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed, fixing Chromium test_expectations.txt due to removed tests in r57292.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake Safari correctly allocate 5MB of DB storage to all new
dumi@chromium.org [Fri, 16 Apr 2010 22:11:10 +0000 (22:11 +0000)]
Make Safari correctly allocate 5MB of DB storage to all new
origins.
https://bugs.webkit.org/show_bug.cgi?id=36671

Reviewed by Alexey Proskuryakov.

Eric fixed the same problem in
DatabaseTracker::fullPathForDatabaseNoLock() in r57128, but forgot
to fix it in DatabaseTracker::detailsForNameAndOrigin() too.

* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::detailsForNameAndOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57754 268f45cc-cd09-0410-ab3c-d52691b4dbfc