WebKit-https.git
11 years ago2010-05-06 John Gregg <johnnyg@google.com>
johnnyg@google.com [Thu, 6 May 2010 18:47:34 +0000 (18:47 +0000)]
2010-05-06  John Gregg  <johnnyg@google.com>

        Unreviewed.  Updating test expectations.

        [chromium] enabling notifications tests after test_shell change.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 6 May 2010 18:46:22 +0000 (18:46 +0000)]
2010-05-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Rework where we get page step and line step from, so we do not
        depend on scrollbars existing. Caught by API test I forgot to run.

        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::setGtkAdjustments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 6 May 2010 17:47:55 +0000 (17:47 +0000)]
2010-05-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [GTK] Adjustment resetting uses wrong values, and misses page_size and steps
        https://bugs.webkit.org/show_bug.cgi?id=38657

        Fix resetting adjustment values. In the page cache case, we were
        confusing page_size and upper, leading to stray scrollbars
        sometimes.

        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::setGtkAdjustments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 6 May 2010 17:42:30 +0000 (17:42 +0000)]
2010-05-06  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        editing/selection/shift-click.html fails on GTK and QT
        https://bugs.webkit.org/show_bug.cgi?id=38656

        r58892 added this test. It's the first test for shift+click behavior,
        so it exposed bugs in GTK/QT. Skipping to green the bots.

        * platform/gtk/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Thu, 6 May 2010 17:37:56 +0000 (17:37 +0000)]
2010-05-06  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        WebFrame::paintDocumentRectToContext paints content at the wrong location
        https://bugs.webkit.org/show_bug.cgi?id=38651

        * WebFrame.cpp:
        (WebFrame::paintDocumentRectToContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 6 May 2010 17:12:28 +0000 (17:12 +0000)]
2010-05-06  Darin Adler  <darin@apple.com>

        Reviewed by Beth Dakin.

        Page::setCanStartMedia does not properly handle the case where a media listener is removed
        https://bugs.webkit.org/show_bug.cgi?id=38602

        We can't find any real case where this causes a crash at this time, but
        we want to harden the code anyway. Thus there are no new regression tests.

        * page/Page.cpp:
        (WebCore::Page::removeMediaCanStartListener): Removed incorrect assertion.
        (WebCore::Page::setCanStartMedia): Change algorithm so we notify listeners
        one at a time and don't notify any listener that has already been removed
        from the set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Evan Martin <evan@chromium.org>
evan@chromium.org [Thu, 6 May 2010 17:05:30 +0000 (17:05 +0000)]
2010-05-06  Evan Martin  <evan@chromium.org>

        Unreviewed.  Updating test expectations.

        [chromium] new baselines for r58886
        https://bugs.webkit.org/show_bug.cgi?id=38652

        * platform/chromium-linux/fast/lists/w3-css3-list-styles-numeric-expected.txt:
        * platform/chromium-linux/fast/text/international/danda-space-expected.checksum:
        * platform/chromium-linux/fast/text/international/danda-space-expected.png:
        * platform/chromium-linux/fast/text/international/danda-space-expected.txt:
        * platform/chromium-linux/fast/text/international/thai-baht-space-expected.checksum:
        * platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
        * platform/chromium-linux/fast/text/international/thai-baht-space-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 6 May 2010 16:58:12 +0000 (16:58 +0000)]
2010-05-05  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Darin Adler.

        shift+click on an existing selection doesn't work right
        https://bugs.webkit.org/show_bug.cgi?id=36542

        NSTextView behavior is to move the end of the selection
        closest to the shift-click. Win/Linux behavior is to always
        move the focus end of the selection.

        * editing/selection/script-tests/shift-click.js: Added.
        (shiftClick):
        (assertSelectionString):
        * editing/selection/shift-click-expected.txt: Added.
        * editing/selection/shift-click.html: Added.
        * platform/win/editing/selection/shift-click-expected.txt: Added.
2010-05-05  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Darin Adler.

        shift+click on an existing selection doesn't work right
        https://bugs.webkit.org/show_bug.cgi?id=36542

        NSTextView behavior is to move the end of the selection
        closest to the shift-click. Win/Linux behavior is to always
        move the focus end of the selection.

        Test: editing/selection/shift-click.html

        * page/EventHandler.cpp:
        (WebCore::textDistance):
        (WebCore::EventHandler::handleMousePressEventSingleClick):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 6 May 2010 16:53:33 +0000 (16:53 +0000)]
2010-05-06  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: implement panels history traversal on Cmd+Left/Right.

        https://bugs.webkit.org/show_bug.cgi?id=38649

        * inspector/front-end/inspector.js:
        (WebInspector.set currentPanel):
        (WebInspector.loaded):
        (WebInspector.documentKeyDown):
        (WebInspector.PanelHistory):
        (WebInspector.PanelHistory.prototype.canGoBack):
        (WebInspector.PanelHistory.prototype.goBack):
        (WebInspector.PanelHistory.prototype.canGoForward):
        (WebInspector.PanelHistory.prototype.goForward):
        (WebInspector.PanelHistory.prototype.setPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 6 May 2010 16:49:47 +0000 (16:49 +0000)]
2010-05-06  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Chromium Dev Tools: Large toolbar icons flash when dev
        tools is opened in docked mode.

        https://bugs.webkit.org/show_bug.cgi?id=38631

        * src/js/DevTools.js:
        (devtools.domContentLoaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Jochen Eisinger <jochen@chromium.org>
eric@webkit.org [Thu, 6 May 2010 16:46:32 +0000 (16:46 +0000)]
2010-05-06  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Dimitri Glazkov.

        Make ImageDiff depend on WebKit. When compiled from within Chromium, WTF is not a standalone dynamic library but depends on WebKit.
        https://bugs.webkit.org/show_bug.cgi?id=38632

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Thu, 6 May 2010 16:43:03 +0000 (16:43 +0000)]
2010-05-05  Antonio Gomes  <tonikitoo@webkit.org>

        Rubber-stamped by Kenneth Christiansen.

        Spatial Navigation: use data url in layout tests
        https://bugs.webkit.org/show_bug.cgi?id=38584

        In order to make Spatial Navigation layout tests more readable, patch
        changes the use or src=resources/iframeXXX.html by inlined sources via
        data uri schema.

        It is a polishment.

        * fast/events/spatial-navigation/resources/iframe.html: Removed.
        * fast/events/spatial-navigation/resources/iframe2.html: Removed.
        * fast/events/spatial-navigation/resources/iframe3.html: Removed.
        * fast/events/spatial-navigation/resources/iframe4.html: Removed.
        * fast/events/spatial-navigation/snav-iframe-no-focusable-content.html:
        * fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html:
        * fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Thu, 6 May 2010 16:42:17 +0000 (16:42 +0000)]
2010-05-06  Antonio Gomes  <tonikitoo@webkit.org>

        [Gtk] Skipped fast/events/spatial-navigation/snav-iframe-flattening-simple.html

        DRT does not support frame flattening testing.
        https://bugs.webkit.org/show_bug.cgi?id=38650

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-03 Evan Martin <evan@chromium.org>
evan@chromium.org [Thu, 6 May 2010 16:34:45 +0000 (16:34 +0000)]
2010-05-03  Evan Martin  <evan@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] use glyphDataForCharacter so we hit the glyphdata cache
        https://bugs.webkit.org/show_bug.cgi?id=38500

        Calling fontDataForCharacters() while rendering text is expensive.
        Examining the relevant Mac code in WebKit revealed that calling the
        similarly-named glyphDataForCharacters() results in caching the font
        data on a per-glyph basis.

        Since we now choose a font based on the first character in a run, we
        need to be careful that all the glyphs within the run use the same font.
        This is also similar to the WebKit Mac code.  We need to remove all of
        the script run bits eventually and this is a step in that direction.

        Tests: fast/text/international/danda-space.html spacing changes slightly
        (now matches Firefox better) and fast/text/international/thai-baht-space.html
        now picks the correct (serif) font for the digits.

        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::TextRunWalker::nextScriptRun):
        (WebCore::TextRunWalker::setupFontForScriptRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Martin Robinson <mrobinson@webkit.org>
mrobinson@webkit.org [Thu, 6 May 2010 16:32:42 +0000 (16:32 +0000)]
2010-05-06  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Enable DOM clipboard and drag-and-drop access
        https://bugs.webkit.org/show_bug.cgi?id=30623

        Convert dragging portion of drag-and-drop to use DataObjectGtk.

        * wtf/gobject/GRefPtr.h: Add forward declarations for GObject functions.
2010-05-06  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Enable DOM clipboard and drag-and-drop access
        https://bugs.webkit.org/show_bug.cgi?id=30623

        Convert dragging portion of drag-and-drop to use DataObjectGtk.

        No new tests, because functionality has not changed.

        * page/gtk/EventHandlerGtk.cpp:
        (WebCore::EventHandler::createDraggingClipboard): Pass the DataObjectGtk as a parameter here.
        * platform/gtk/ClipboardGtk.h:
        (WebCore::ClipboardGtk::create): Take the DataObject as a parameter instead of creating it here.
        (WebCore::ClipboardGtk::helper): Added.
        (WebCore::ClipboardGtk::dataObject): Added.
        * platform/gtk/PasteboardHelper.h: Make targetListForDataObject a public method.
2010-05-06  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Enable DOM clipboard and drag-and-drop access
        https://bugs.webkit.org/show_bug.cgi?id=30623

        Convert dragging portion of drag-and-drop to use DataObjectGtk.

        * WebCoreSupport/DragClientGtk.cpp:
        (WebKit::DragClient::willPerformDragDestinationAction): Remove the notImplemented. It is implemented, it's just a no-op.
        (WebKit::DragClient::startDrag): Start the drag context via the ClipboardGtk and PasteboardHelper now.
        * WebCoreSupport/DragClientGtk.h: Small style fix.
        * webkit/webkitprivate.h: Add a HashMap of contexts and DataObjects here to to represent all current drag operations.
        * webkit/webkitwebview.cpp:
        (webkit_web_view_dispose): Clear all data objects during disposal.
        (webkit_web_view_drag_end): When a drag is over, just remove it from the map.
        (webkit_web_view_drag_data_get): To get the drag data, just grab it from the DataObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 6 May 2010 16:30:49 +0000 (16:30 +0000)]
2010-05-06  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Do not show content tab for resources
        not supporting content preview.

        https://bugs.webkit.org/show_bug.cgi?id=38635

        * English.lproj/localizedStrings.js:
        * inspector/front-end/FontView.js:
        (WebInspector.FontView.prototype.hasContentTab):
        * inspector/front-end/ImageView.js:
        (WebInspector.ImageView.prototype.hasContentTab):
        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView):
        (WebInspector.ResourceView.prototype._selectTab):
        (WebInspector.ResourceView.prototype.hasContentTab):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype.hasContentTab):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Thu, 6 May 2010 16:23:42 +0000 (16:23 +0000)]
2010-05-05  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Kenneth Christiansen.

        Spatial Navigation: Add LayoutTest with frame flattening feature on.
        https://bugs.webkit.org/show_bug.cgi?id=38585

        * fast/events/spatial-navigation/snav-iframe-flattening-simple-expected.txt: Added.
        * fast/events/spatial-navigation/snav-iframe-flattening-simple.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Thu, 6 May 2010 16:17:08 +0000 (16:17 +0000)]
2010-05-06  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Kenneth Christiansen.

        Spatial Navigation: adapt the logic of {deep}findFocusableNodeInDirection to do traversal starting from Node* not Document*
        https://bugs.webkit.org/show_bug.cgi?id=37803

        Instead of receiving a Document pointer as incoming parameter, patch modifies
        findFocusableNodeInDirection and deepFindFocusableNodeInDirection methods to
        receive a Node pointer as start for content traversal.
        This way we can make good use of deepFindFocusableNodeInDirection to traverse
        other scrollable container like scrollable div's, and not only frames or iframes.

        Patch also makes use of 'while' instead of 'for' to loop control, that gives move
        flexibility to the incremental step: e.g. if a scrollable div was processed, the incremental
        step in the loop does not have to do node->traverseNextNode() but node->traverseNextSibling().

        No behavior change. It is a preparation for supporting scrollable containers in Spatial
        Navigation.

        * page/FocusController.cpp:
        (WebCore::FocusController::advanceFocusDirectionally):
        (WebCore::FocusController::findFocusableNodeInDirection):
        (WebCore::FocusController::deepFindFocusableNodeInDirection):
        * page/FocusController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed WinCE buildfix after r58842.
ossy@webkit.org [Thu, 6 May 2010 16:04:41 +0000 (16:04 +0000)]
Unreviewed WinCE buildfix after r58842.
Preprocessor doesn't understand "true", changed to "1"

* platform/graphics/MediaPlayer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Thu, 6 May 2010 15:31:11 +0000 (15:31 +0000)]
2010-05-06  Mikhail Naganov  <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Temporarily disable 'console.profiles' until we can distinguish
functions from different frames

https://bugs.webkit.org/show_bug.cgi?id=38638

* bindings/v8/custom/V8ConsoleCustom.cpp:
(WebCore::V8Console::profilesAccessorGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Thu, 6 May 2010 15:13:52 +0000 (15:13 +0000)]
2010-05-06  Vitaly Repeshko  <vitalyr@chromium.org>

        [chromium] Unreviewed. Updating expectations.

        * platform/chromium-linux/fast/url/segments-expected.txt: Added.
        * platform/chromium-linux/fast/url/segments-from-data-url-expected.txt: Added.
        * platform/chromium-mac/fast/url/segments-expected.txt: Added.
        * platform/chromium-mac/fast/url/segments-from-data-url-expected.txt: Added.
        * platform/chromium-win/fast/url/segments-expected.txt: Added.
        * platform/chromium-win/fast/url/segments-from-data-url-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Steve Block <steveblock@google.com>
eric@webkit.org [Thu, 6 May 2010 14:09:49 +0000 (14:09 +0000)]
2010-05-06  Steve Block  <steveblock@google.com>

        Reviewed by Eric Seidel.

        MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
        https://bugs.webkit.org/show_bug.cgi?id=38544

        * wtf/Platform.h:
2010-05-06  Steve Block  <steveblock@google.com>

        Reviewed by Eric Seidel.

        MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
        https://bugs.webkit.org/show_bug.cgi?id=38544

        No new tests, build fix only.

        * DerivedSources.make:
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::ScriptController):
        * bindings/js/ScriptController.h:
        * bindings/js/ScriptControllerMac.mm:
        (WebCore::ScriptController::createScriptInstanceForWidget):
        * bridge/jni/JNIBridge.cpp:
        * bridge/jni/JNIBridge.h:
        * bridge/jni/JNIUtility.cpp:
        * bridge/jni/JNIUtility.h:
        * bridge/jni/jni_jsobject.h:
        * bridge/jni/jni_jsobject.mm:
        * bridge/jni/jni_objc.mm:
        * bridge/jni/jsc/JNIBridgeJSC.cpp:
        * bridge/jni/jsc/JNIBridgeJSC.h:
        * bridge/jni/jsc/JNIUtilityPrivate.cpp:
        * bridge/jni/jsc/JNIUtilityPrivate.h:
        * bridge/jni/jsc/JavaClassJSC.cpp:
        * bridge/jni/jsc/JavaClassJSC.h:
        * bridge/jni/jsc/JavaInstanceJSC.cpp:
        * bridge/jni/jsc/JavaInstanceJSC.h:
        * loader/FrameLoaderClient.h:
2010-05-06  Steve Block  <steveblock@google.com>

        Reviewed by Eric Seidel.

        MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE
        https://bugs.webkit.org/show_bug.cgi?id=38544

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Andreas Kling <andreas.kling@nokia.com>
eric@webkit.org [Thu, 6 May 2010 13:12:04 +0000 (13:12 +0000)]
2010-05-06  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Patch to fix compilation warnings for QGraphicsWebView
        https://bugs.webkit.org/show_bug.cgi?id=37428

        Patch by Alexis Menard <alexis.menard@nokia.com>

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebView::itemChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Simon Hausmann <simon.hausmann@nokia.com>
eric@webkit.org [Thu, 6 May 2010 13:00:54 +0000 (13:00 +0000)]
2010-05-06  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Replace public inspector url with private property for QtLauncher
        https://bugs.webkit.org/show_bug.cgi?id=35340

        Replace the public API with a private dynamic property until this feature
        is ready.

        * Api/qwebsettings.cpp:
        * Api/qwebsettings.h:
        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientQt::openInspectorFrontend):
        * symbian/bwins/QtWebKitu.def:
        * symbian/eabi/QtWebKitu.def:
2010-05-06  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Replace public inspector url with private property for QtLauncher
        https://bugs.webkit.org/show_bug.cgi?id=35340

        Replace the public API with a private dynamic property until this feature
        is ready.

        * QtLauncher/main.cpp:
        (LauncherWindow::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Thu, 6 May 2010 09:44:20 +0000 (09:44 +0000)]
2010-05-05  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        Fixed the gobject introspection compilation with the new DOM
        bindings, we needed to add DOM objects.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 6 May 2010 09:31:08 +0000 (09:31 +0000)]
2010-05-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        [WTFURL] Add a class to represent the segments of a URL
        https://bugs.webkit.org/show_bug.cgi?id=38566

        When paired with a string, this class represents a parsed URL.

        * wtf/url/src/URLSegments.cpp: Added.
        (WTF::URLSegments::length):
        (WTF::URLSegments::charactersBefore):
        * wtf/url/src/URLSegments.h: Added.
        (WTF::URLSegments::):
        (WTF::URLSegments::URLSegments):
        * wtf/url/wtfurl.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 6 May 2010 09:19:59 +0000 (09:19 +0000)]
2010-05-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        drop support for sessionStorage in sandbox iframes
        https://bugs.webkit.org/show_bug.cgi?id=38151

        Update test expectation.  This test was originally created to show that
        we complied with the letter of the spec, but our behavior is insecure.
        In the future, we might revert this change and implement a separate
        storage area for each unique origin.

        * fast/frames/resources/sandboxed-iframe-storage-disallowed.html:
        * fast/frames/sandboxed-iframe-storage-expected.txt:
2010-05-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        drop support for sessionStorage in sandbox iframes
        https://bugs.webkit.org/show_bug.cgi?id=38151

        This patch causes us to throw a security exception when a sandboxed
        iframe attempts to access sessionStorage, matching our behavior for
        localStorage.  The letter of the spec asks us to create a separate
        storage area for each unique origin.  We might want to do that in a
        future patch, but throwing a security error seems like a safe move now.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::sessionStorage):
        (WebCore::DOMWindow::localStorage):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        * page/SecurityOrigin.h:
        (WebCore::SecurityOrigin::canAccessSessionStorage):
        * storage/StorageEventDispatcher.cpp:
        (WebCore::StorageEventDispatcher::dispatch):
2010-05-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        drop support for sessionStorage in sandbox iframes
        https://bugs.webkit.org/show_bug.cgi?id=38151

        Update client of sessionStorage to handle exceptions.

        * src/StorageAreaProxy.cpp:
        (WebCore::StorageAreaProxy::storageEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Allow forms submitting to target="_blank" to open popups if the submission
aestes@apple.com [Thu, 6 May 2010 08:51:41 +0000 (08:51 +0000)]
WebCore: Allow forms submitting to target="_blank" to open popups if the submission
originated from a user gesture.

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=37335
<rdar://problem/7884980>

Test: fast/events/popup-allowed-from-gesture-initiated-form-submit.html

* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::processingUserGesture): If no DOM event is
being processed, consult UserGestureIndicator to determine return value.
* bindings/js/ScriptController.h: Moved the logic of processingUserGestureEvent()
into processingUserGesture().

LayoutTests: Add a test to ensure popups are allowed when the user submits a form with target="_blank".

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=37335
<rdar://problem/7884980>

* fast/events/popup-allowed-from-gesture-initiated-form-submit-expected.txt: Added.
* fast/events/popup-allowed-from-gesture-initiated-form-submit.html: Added.
* fast/events/resources/popup-allowed-from-gesture-initiated-form-submit-target.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 6 May 2010 08:10:15 +0000 (08:10 +0000)]
2010-05-06  Xan Lopez  <xlopez@igalia.com>

        Rubber-stamped by Eric Seidel.

        [GTK] Refactor GenerateProperties in CodeGenerationGObject.pm
        https://bugs.webkit.org/show_bug.cgi?id=38577

        Thinko caught while refactoring, $custom variable was not
        initialized.

        * bindings/scripts/CodeGeneratorGObject.pm:
        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
        (webkit_dom_test_obj_set_property):
        (webkit_dom_test_obj_get_property):
        (webkit_dom_test_obj_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 6 May 2010 08:09:52 +0000 (08:09 +0000)]
2010-05-06  Xan Lopez  <xlopez@igalia.com>

        Rubber-stamped by Eric Seidel.

        [GTK] Refactor GenerateProperties in CodeGenerationGObject.pm
        https://bugs.webkit.org/show_bug.cgi?id=38577

        Refactor GenerateProperty out of GenerateProperties. This is in
        preparation for EventListeren attributes, which won't generate
        normal GObject properties.

        * bindings/scripts/CodeGeneratorGObject.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-06 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Thu, 6 May 2010 08:01:23 +0000 (08:01 +0000)]
2010-05-06  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: follow up to linkify event listeners.

        https://bugs.webkit.org/show_bug.cgi?id=38257

        * bindings/js/ScriptEventListener.cpp:
        (WebCore::eventListenerHandlerLocation):
        * bindings/v8/ScriptEventListener.cpp:
        (WebCore::eventListenerHandlerLocation):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.linkifyNodeReference):
        * inspector/front-end/EventListenersSidebarPane.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Joseph Pecoraro <joepeck@webkit.org>
eric@webkit.org [Thu, 6 May 2010 07:05:08 +0000 (07:05 +0000)]
2010-05-05  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: build-webkit --inspector-frontend Should Exclude *.re2js
        https://bugs.webkit.org/show_bug.cgi?id=38449

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Charles Wei <charles.wei@torchmobile.com.cn>
eric@webkit.org [Thu, 6 May 2010 06:54:21 +0000 (06:54 +0000)]
2010-05-05  Charles Wei  <charles.wei@torchmobile.com.cn>

        Reviewed by George Staikos

        https://bugs.webkit.org/show_bug.cgi?id=37848
        Add test cases for -wap-input-format and -wap-input-required of WCSS

        * fast/wcss/wap-input-format-expected.txt: Added.
        * fast/wcss/wap-input-format.xhtml: Added.
        * fast/wcss/wap-input-required-expected.txt: Added.
        * fast/wcss/wap-input-required.xhtml: Added.
2010-05-05  Charles Wei  <charles.wei@torchmobile.com.cn>

        Reviewed by George Staikos

        https://bugs.webkit.org/show_bug.cgi?id=37848
        This patch adds WCSS -wap-input-format and -wap-input-required support to WebKit

        Tests: fast/wcss/wap-input-format.xhtml
               fast/wcss/wap-input-required.xhtml

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseWCSSInputProperty):
        * css/CSSParser.h:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * css/WCSSPropertyNames.in:
        * dom/InputElement.cpp:
        (WebCore::InputElement::sanitizeValue):
        (WebCore::InputElement::handleBeforeTextInsertedEvent):
        (WebCore::InputElementData::InputElementData):
        (WebCore::formatCodes):
        (WebCore::cursorPositionToMaskIndex):
        (WebCore::InputElement::isConformToInputMask):
        (WebCore::InputElement::validateInputMask):
        * dom/InputElement.h:
        (WebCore::InputElementData::inputFormatMask):
        (WebCore::InputElementData::setInputFormatMask):
        (WebCore::InputElementData::maxInputCharsAllowed):
        (WebCore::InputElementData::setMaxInputCharsAllowed):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setWapInputFormat):
        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::data):
        * wml/WMLInputElement.h:
        (WebCore::WMLInputElement::data):
2010-05-05  Charles Wei  <charles.wei@torchmobile.com.cn>

        Reviewed by George Staikos

        This patch adds WCSS -wap-input-format and -wap-input-required support to WebKit
        Make the test cases in fast/wcss optionional only when  WCSS is enabled.

        https://bugs.webkit.org/show_bug.cgi?id=37848

        * Scripts/old-run-webkit-tests:
        * Scripts/webkitperl/features.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Thu, 6 May 2010 06:23:38 +0000 (06:23 +0000)]
2010-05-05  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        [GTK] Markup of copied non ASCII characters is broken
        https://bugs.webkit.org/show_bug.cgi?id=37918

        This test was fixed by http://trac.webkit.org/changeset/58468

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFixed a crash when closing Top Sites after r58847.
mitz@apple.com [Thu, 6 May 2010 06:06:47 +0000 (06:06 +0000)]
Fixed a crash when closing Top Sites after r58847.

Reviewed by Mark Rowe.

* WebView/WebFrameView.mm:
(-[WebFrameView webFrame]): Null-check _private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 6 May 2010 06:02:58 +0000 (06:02 +0000)]
2010-05-05  MORITA Hajime  <morrita@google.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=38150
        Refactoring: webkitEditableContentChangedEvent should be handled by the owner of appropriate the renderer.

        Moved a part of code chunk in HTMLFormControlElementWithState::defaultEventHandler()
        which accesses the renderer from foreign node,
        to TextControlInnerTextElement::defaultEventHandler() which owns the renderer.

        No new tests. No behavioral change.

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElementWithState::defaultEventHandler):
        * html/HTMLFormControlElement.h:
        * html/HTMLInputElement.h:
        * html/HTMLTextAreaElement.h:
        * rendering/TextControlInnerElements.cpp:
        (WebCore::TextControlInnerTextElement::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Enable Sputnik tests.
ossy@webkit.org [Thu, 6 May 2010 05:47:14 +0000 (05:47 +0000)]
[Qt] Enable Sputnik tests.
https://bugs.webkit.org/show_bug.cgi?id=38457

Rubber-stamped by Alexey Proskuryakov.

* platform/qt/Skipped: Only skip tests that fail.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 6 May 2010 05:40:21 +0000 (05:40 +0000)]
2010-05-05  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        [DRT/Chromium] Remove InitWebCoreSystemInterface() call
        https://bugs.webkit.org/show_bug.cgi?id=38624

        Chromium r45167 <http://src.chromium.org/viewvc/chrome?view=rev&revision=45167>
        added InitWebCoreSystemInterface() to webkit/support/platform_support_mac.mm.
        So we don't need to call it from DumpRenderTree.cpp anymore.

        * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (main): Remove InitWebCoreSystemInterface().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Steven Lai <steven_lai@asia.apple.com>
eric@webkit.org [Thu, 6 May 2010 05:34:00 +0000 (05:34 +0000)]
2010-05-05  Steven Lai  <steven_lai@asia.apple.com>

        Reviewed by Alexey Proskuryakov.

        Remove platform specific test result
        Don't print the formatted string of the z-index in the test case
        since there's a risk that the output on different c stdlib implementations/platforms/locale could be different
        https://bugs.webkit.org/show_bug.cgi?id=38617.

        * fast/dom/clone-node-z-index-expected.txt:
        * fast/dom/clone-node-z-index.html:
        * platform/win/fast/dom/clone-node-z-index-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 6 May 2010 05:23:00 +0000 (05:23 +0000)]
2010-05-05  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Add a test of URL segmentation from a data URL base
        https://bugs.webkit.org/show_bug.cgi?id=38606

        As requested by Alexey.  These tests find some interesting behavior in
        both KURL and GURL.  We'll need to go through them in more detail later
        to understand what the right behavior is.

        * fast/url/script-tests/segments-from-data-url.js: Added.
        * fast/url/segments-from-data-url-expected.txt: Added.
        * fast/url/segments-from-data-url.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 6 May 2010 05:11:55 +0000 (05:11 +0000)]
2010-05-05  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Add a test of URL segmentation
        https://bugs.webkit.org/show_bug.cgi?id=38600

        These tests are based on URLParser.Standard from
        http://code.google.com/p/google-url/source/browse/trunk/src/url_parse_unittest.cc

        * fast/url/resources/utilities.js:
        (canonicalize):
            - I changed this to use deterministic IDs because (theoretically)
              the old way was flaky in case the IDs collided.
        (segments):
            - Here we're using HTMLAnchorElement's attributes to infer the
              internal segmentation.  Unforunately, there don't seem to be
              accessors for usernames and passwords of URLs.
        * fast/url/script-tests/segments.js: Added.
            - I'm not 100% sure all the test cases here represent the intent of
              the original test author.  The tricky bit is we don't have a good
              way to test absolute URL parsing from the web platform, which
              means a bunch of these become tests of how we handle relative
              URLs.  However, I'm not one to turn down more test cases.
        * fast/url/script-tests/trivial-segments.js: Added.
            - This is more of a test of the testing harness to make sure its
              working properly when running on other browsers.
        * fast/url/segments-expected.txt: Added.
        * fast/url/trivial-segments-expected.txt: Added.
            - As usual, these have their "PASS" expectations set to the
              Chromium behavior but have their -expected.txt set to the normal
              WebKit behavior, letting us track differences between the two.
        * fast/url/segments.html: Added.
        * fast/url/trivial-segments.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Tony Gentilcore <tonyg@chromium.org>
eric@webkit.org [Thu, 6 May 2010 04:50:33 +0000 (04:50 +0000)]
2010-05-05  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Adding comment with link to RefPtr documentation.
        https://bugs.webkit.org/show_bug.cgi?id=38601

        * wtf/RefPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Joseph Pecoraro <joepeck@webkit.org>
eric@webkit.org [Thu, 6 May 2010 04:28:52 +0000 (04:28 +0000)]
2010-05-05  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Line Numbers should be Aligned with the Source Code Line
        https://bugs.webkit.org/show_bug.cgi?id=38593

        If there is a message bubble, such as an error message, in a source view
        the line number should be in line with the source code line, not centered
        between the source and bubble.

        * inspector/front-end/textViewer.css:
        (.webkit-line-number): added vertical-align: top

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFixed test crashes after r58847.
mitz@apple.com [Thu, 6 May 2010 03:16:52 +0000 (03:16 +0000)]
Fixed test crashes after r58847.

Rubber-stamped by Mark Rowe.

* WebView/WebHTMLView.mm:
(setNeedsDisplayInRect): Null-check the frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 6 May 2010 01:51:03 +0000 (01:51 +0000)]
2010-05-05  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the decelerated compositing build.
mitz@apple.com [Thu, 6 May 2010 01:36:21 +0000 (01:36 +0000)]
Fix the decelerated compositing build.

* page/FrameView.cpp:
(WebCore::FrameView::isEnclosedInCompositingLayer):
* page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 6 May 2010 01:33:32 +0000 (01:33 +0000)]
2010-05-05  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        new-run-webkit-tests: clean up newline handling in printing

        The new printing module seems to handle newlines somewhat
        inconsistently, especially in --verbose mode. This change cleans up
        the code to make things more consistent and adds a bunch of unit tests.

        https://bugs.webkit.org/show_bug.cgi?id=38616

        * Scripts/webkitpy/common/array_stream.py: Added.
        * Scripts/webkitpy/common/array_stream_unittest.py: Added.
        * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
        * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py: Added.
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 6 May 2010 01:12:08 +0000 (01:12 +0000)]
2010-05-05  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        Ban the single letter 'l' as an identifier name
        http://trac.webkit.org/changeset/58844

        Add a lint rule to ban the single letter 'l' as an identifier name
        since it is very easy to confuse with the numeral '1', especially
        in code like WebCore/css/CSSHelper.cpp.

        See http://trac.webkit.org/changeset/58844 as an example of a bug
        caused by confusing short variable names.

        * Scripts/webkitpy/style/checkers/cpp.py:
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 38604 - workers-gc2 crashing on Qt
barraclough@apple.com [Thu, 6 May 2010 01:08:53 +0000 (01:08 +0000)]
Bug 38604 - workers-gc2 crashing on Qt

Reviewed by Darin Adler.

This appears to be due to a couple of issues.
(1) When the atomic string table is deleted it does not clear the 'inTable' bit
on AtomicStrings - it implicitly assumes that all AtomicStrings have already
been deleted at this point (otherwise they will crash in their destructor when
they try to remove themselves from the atomic string table).
(2) We don't fix the ordering in which WTF::WTFThreadData and
WebCore::ThreadGlobalData are destructed.

We should make sure that ThreadGlobalData is cleaned up before worker threads
terminate and WTF::WTFThreadData is destroyed, and we should clear the inTable
bit of members on atomic string table destruction.

JavaScriptCore:

WTF changes (fix issue 1, above) - ensure inTable property is cleared when the
atomic string table is destroyed (also, rename InTable to IsAtomic, to make it
clear which table we are refering to!)

* wtf/text/AtomicString.cpp:
(WebCore::AtomicStringTable::destroy):
(WebCore::CStringTranslator::translate):
(WebCore::UCharBufferTranslator::translate):
(WebCore::HashAndCharactersTranslator::translate):
(WebCore::AtomicString::add):
* wtf/text/StringImpl.cpp:
(WebCore::StringImpl::~StringImpl):
* wtf/text/StringImpl.h:
(WebCore::StringImpl::isAtomic):
(WebCore::StringImpl::setIsAtomic):
* wtf/text/StringImplBase.h:

WebCore:

WTF changes (fix issue 2, above) - clean up the thread data on worker termination.

* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::~ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):
* platform/ThreadGlobalData.h:
* workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd Windows-specific results for clone-node-z-index.html. The difference in results...
bweinstein@apple.com [Thu, 6 May 2010 01:05:58 +0000 (01:05 +0000)]
Add Windows-specific results for clone-node-z-index.html. The difference in results is harmless (the number is the same),
but the difference is being tracked by https://bugs.webkit.org/show_bug.cgi?id=38617.

Rubber-stamped by Mark Rowe.

* platform/win/fast/dom/clone-node-z-index-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/7932072> Iframes in composited layers don’t repaint correctly (affect...
mitz@apple.com [Thu, 6 May 2010 00:37:03 +0000 (00:37 +0000)]
<rdar://problem/7932072> Iframes in composited layers don’t repaint correctly (affects Yahoo! Mail with Flash Player 10.1)
https://bugs.webkit.org/show_bug.cgi?id=38427

Reviewed by Simon Fraser.

WebCore:

Test: compositing/iframes/iframe-in-composited-layer.html

* WebCore.base.exp: Export FrameView::isEnclosedInCompositingLayer().
* page/FrameView.cpp:
(WebCore::FrameView::isEnclosedInCompositingLayer): Added this predicate.
* page/FrameView.h:

WebKit:

* WebKit.xcodeproj/project.pbxproj: Renamed WebClipView.m to WebClipView.mm and changed it to
Objective-C++.

WebKit/mac:

* WebView/WebClipView.m: Renamed to WebClipView.mm.
* WebView/WebClipView.mm:
(-[WebClipView visibleRect]): Added this override, which for instances used for WebFrameViews in
composited layers, returns the clip view’s entire bounds. This prevents drawing from being clipped to
AppKit’s idea of what part of the view would be visible if it was drawn as part of the view hierarchy.
Since it is drawn into a compositing layer, that’s irrelevant, and we should not be clipping.
* WebView/WebHTMLView.mm:
(setCursor): Style tweak.
(setNeedsDisplayInRect): Added. Replaces the default implementation of -[NSView setNeedsDisplayInRect:],
so that if the receiver is a descendant of a WebFrameView that draws into a composited layer, the invalidation
is routed back through the WebCore FrameView, which propagates it to the layer.
(+[WebHTMLViewPrivate initialize]): Swizzle the setNeedsDisplayInRect: override in.
(-[WebHTMLView visibleRect]): Removed whitespace.
* WebView/WebView.mm:
(layerSyncRunLoopObserverCallBack): If we bailed out on syncing, due to pending layout, do an eager layout
in preparation for the displaying of compositing layers.

LayoutTests:

* compositing/iframes/iframe-in-composited-layer.html: Added.
* platform/mac/compositing/iframes/iframe-in-composited-layer-expected.checksum: Added.
* platform/mac/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
* platform/mac/compositing/iframes/iframe-in-composited-layer-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/7942606> Output appears in Console when exiting Safari with multiple...
sullivan@apple.com [Thu, 6 May 2010 00:20:15 +0000 (00:20 +0000)]
<rdar://problem/7942606> Output appears in Console when exiting Safari with multiple windows opened

Reviewed by Mark Rowe.

* WebView/WebView.mm:
(+[WebView closeAllWebViews]):
Make copy of allWebViewsSet to avoid mutating it while iterating through it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Thu, 6 May 2010 00:02:27 +0000 (00:02 +0000)]
2010-05-05  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Got composited iframes showing up on Mac again
        https://bugs.webkit.org/show_bug.cgi?id=38565

        This was broken by http://trac.webkit.org/changeset/58798. That
        change connected iframes through the parent document to the root
        of the layer tree. That is correct for Windows, but not for Mac.
        So the places where the linkage is made were wrapped in
        shouldPropagateCompositingToIFrameParent() calls, which is
        always false for Mac.

        Test: compositing/iframes/composited-iframe-alignment.html

        * rendering/RenderLayerCompositor.cpp:Avoid doing composited iframe linkage on Mac
        (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
        (WebCore::RenderLayerCompositor::didMoveOnscreen):
        (WebCore::RenderLayerCompositor::willMoveOffscreen):
        (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@apple.com [Wed, 5 May 2010 23:24:39 +0000 (23:24 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=38260
        <rdar://problem/7917548> Fix whitespace removing in deprecatedParseURL().

        Broken all the way since r4 (yes, that's a revision number).

        Test: http/tests/security/xss-DENIED-javascript-with-spaces.html

        * css/CSSHelper.cpp: (WebCore::deprecatedParseURL): Fixed loop conditions for remaining length.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMany AXUnknown showing up in the hierarchy
cfleizach@apple.com [Wed, 5 May 2010 23:12:57 +0000 (23:12 +0000)]
Many AXUnknown showing up in the hierarchy
https://bugs.webkit.org/show_bug.cgi?id=38607

Reviewed by Beth Dakin.

WebCore:

The RenderTableSection should not be an accessible element.

Test: platform/mac/accessibility/parent-of-table-row-is-table.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

LayoutTests:

* platform/mac-leopard/Skipped:
* platform/mac-tiger/Skipped:
* platform/mac/accessibility/parent-of-table-row-is-table-expected.txt: Added.
* platform/mac/accessibility/parent-of-table-row-is-table.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt]Disable Qt Multimedia backend for HTML 5 Audio and Video elements
ossy@webkit.org [Wed, 5 May 2010 22:59:00 +0000 (22:59 +0000)]
[Qt]Disable Qt Multimedia backend for HTML 5 Audio and Video elements
Fall back to the Phonon backend until the release situation has been cleared up.

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=38612

Buildfix for QT_VERSION >= 0x040700 after r58810.

* platform/graphics/MediaPlayer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoXMLHttpRequestUpload events do not fire when sending a raw file or FormData object.
jianli@chromium.org [Wed, 5 May 2010 22:42:11 +0000 (22:42 +0000)]
XMLHttpRequestUpload events do not fire when sending a raw file or FormData object.
https://bugs.webkit.org/show_bug.cgi?id=37771

Reviewed by David Levin.

WebCore:

Test: http/tests/local/formdata/upload-events.html

* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):

LayoutTests:

Add a layout test to test upload events firing.

* http/tests/local/formdata/resources/send-form-data-common.js:
(dumpResponse):
(sendFormData):
(testSendingFormData):
* http/tests/local/formdata/script-tests/send-form-data-with-sliced-file.js:
* http/tests/local/formdata/script-tests/send-form-data.js:
* http/tests/local/formdata/script-tests/upload-events.js: Added.
* http/tests/local/formdata/upload-events-expected.txt: Added.
* http/tests/local/formdata/upload-events.html: Added.
* platform/gtk/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in gtk platform.
* platform/qt/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in qt platform.
* platform/win/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in win platform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Qt port should use its own QUuid class to create UUID string.
ossy@webkit.org [Wed, 5 May 2010 22:28:17 +0000 (22:28 +0000)]
[Qt] Qt port should use its own QUuid class to create UUID string.
https://bugs.webkit.org/show_bug.cgi?id=38581

Reviewed by Simon Hausmann.

* platform/UUID.cpp:
(WebCore::createCanonicalUUIDString): Added PLATFORM(QT) case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 5 May 2010 21:51:22 +0000 (21:51 +0000)]
2010-05-05  Darin Fisher  <darin@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] clear out deprecated methods that are no longer used
        https://bugs.webkit.org/show_bug.cgi?id=38610

        * public/WebFormElement.h:
        * public/WebInputElement.h:
        * public/WebKitClient.h:
        * public/WebView.h:
        * public/WebViewClient.h:
        (WebKit::WebViewClient::createPopupMenu):
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::popupOpened):
        * src/WebFormElement.cpp:
        * src/WebInputElement.cpp:
        (WebKit::WebInputElement::setSelectionRange):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::hideSuggestionsPopup):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 5 May 2010 20:16:37 +0000 (20:16 +0000)]
2010-05-05  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations fix.

        Update expectations with tests that are now passing (possibly flaky?).

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 5 May 2010 20:06:26 +0000 (20:06 +0000)]
2010-05-05  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations fix.

        Mark svg/custom/mask-changes.svg and http/tests/loading/bad-scheme-subframe.html as failing on Chromium Linux until they can be triaged.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Roll out r58830 for breaking tests.
ap@apple.com [Wed, 5 May 2010 19:19:01 +0000 (19:19 +0000)]
    Roll out r58830 for breaking tests.

        Was: https://bugs.webkit.org/show_bug.cgi?id=38546
        Node.focus() fails to move focus from subframe properly

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImplement FileReader class.
jianli@chromium.org [Wed, 5 May 2010 18:52:19 +0000 (18:52 +0000)]
Implement FileReader class.
https://bugs.webkit.org/show_bug.cgi?id=38157

Reviewed by Adam Barth.

This patch only contains the implementation of FileReader class as defined
in the File API spec: http://www.w3.org/TR/file-upload/#dfn-filereader.

New test will be added when a IDL is exposed and the FILE_READER is turned
on.

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/EventNames.h:
* dom/EventTarget.cpp:
(WebCore::EventTarget::toFileReader):
* dom/EventTarget.h:
* html/FileError.h:
(WebCore::FileError::FileError):
* html/FileReader.cpp: Added.
* html/FileReader.h: Added.
* html/FileStream.cpp:
(WebCore::FileStream::FileStream):
(WebCore::FileStream::openForRead):
(WebCore::FileStream::close):
(WebCore::FileStream::read):
* html/FileStream.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Wed, 5 May 2010 18:35:39 +0000 (18:35 +0000)]
2010-05-05  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Maciej Stachowiak.

        REGRESSION(r57969) Image decoder is repeatedly destroyed/created in CoreGraphics-based Windows WebKit
        https://bugs.webkit.org/show_bug.cgi?id=38595

        * platform/graphics/cg/ImageSourceCG.cpp:
        (WebCore::ImageSource::setData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Adele Peterson.
ap@apple.com [Wed, 5 May 2010 18:26:02 +0000 (18:26 +0000)]
    Reviewed by Adele Peterson.

        https://bugs.webkit.org/show_bug.cgi?id=38546
        Node.focus() fails to move focus from subframe properly

        Test: fast/frames/take-focus-from-iframe.html

        * html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setFocus): Don't clear
        focus if this frame doesn't have it. This can happen if page's and HTMLFrameElement's ideas
        of focused frame get out of sync temporarily.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Adele Peterson.
ap@apple.com [Wed, 5 May 2010 18:17:52 +0000 (18:17 +0000)]
    Reviewed by Adele Peterson.

        https://bugs.webkit.org/show_bug.cgi?id=26824
        <rdar://problem/7018610> EventHandler can operate on a wrong frame if focus changes during
        keyboard event dispatch.

        EventHandler object is tied to a frame, so it's wrong for it to continue processing a keyboard
        event if focused frame changes between keydown and keypress.

        * manual-tests/focus-change-between-key-events.html: Added.

        * page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Bail out early if focused frame
        changes while dispatching keydown. Also made similar changes for Windows to maintain matching
        behavior, even though EventHandler was re-entered anyway due to WM_KEYDOWN and WM_CHAR being
        separate events.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Hans Wennborg <hans@chromium.org>
eric@webkit.org [Wed, 5 May 2010 18:14:25 +0000 (18:14 +0000)]
2010-05-05  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        [chromium] Add quota parameter to  WebStorageNamespace::createSessionStorageNamespace
        https://bugs.webkit.org/show_bug.cgi?id=38589

        * public/WebStorageNamespace.h:
        (WebKit::WebStorageNamespace::createSessionStorageNamespace):
        * src/WebStorageNamespaceImpl.cpp:
        (WebKit::WebStorageNamespace::createSessionStorageNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 5 May 2010 17:53:39 +0000 (17:53 +0000)]
2010-05-05  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Adam Barth.

        Commit and Review policy should encourage unofficial reviews
        https://bugs.webkit.org/show_bug.cgi?id=38517

        * coding/commit-review-policy.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Steve Block <steveblock@google.com>
eric@webkit.org [Wed, 5 May 2010 17:20:14 +0000 (17:20 +0000)]
2010-05-05  Steve Block  <steveblock@google.com>

        Reviewed by Adam Barth.

        MediaError.h is missing PassRefPtr.h include
        https://bugs.webkit.org/show_bug.cgi?id=38575

        No new tests, build fix only.

        * html/MediaError.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Wed, 5 May 2010 17:06:36 +0000 (17:06 +0000)]
2010-05-05  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Audits panel: Resource counters get reset when switching panels while reloading page
        https://bugs.webkit.org/show_bug.cgi?id=38579

        * inspector/front-end/AuditLauncherView.js:
        (WebInspector.AuditLauncherView.prototype.updateResourceTrackingState):
        (WebInspector.AuditLauncherView.prototype._updateResourceProgress):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 5 May 2010 17:03:40 +0000 (17:03 +0000)]
2010-05-05  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make Array.join specialised for actual arrays
        https://bugs.webkit.org/show_bug.cgi?id=38592

        Bring Array.join in line with the other array methods by specialising for
        this === an array.

        * runtime/ArrayPrototype.cpp:
        (JSC::arrayProtoFuncJoin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Wed, 5 May 2010 16:48:42 +0000 (16:48 +0000)]
2010-05-05  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: Doubleclick on line number should not trigger source editing.

        https://bugs.webkit.org/show_bug.cgi?id=38588

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype._handleDoubleClick):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Martin Robinson <mrobinson@webkit.org>
mrobinson@webkit.org [Wed, 5 May 2010 16:30:50 +0000 (16:30 +0000)]
2010-05-05  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Gustavo Noronha.

        [GTK] Enable DOM clipboard and drag-and-drop access
        https://bugs.webkit.org/show_bug.cgi?id=30623

        Add support in the PasteboardHelper for images, in preparation for drag-and-drop data.

        No new tests as functionality has not changed.

        * platform/gtk/PasteboardHelper.cpp:
        (WebCore::PasteboardHelper::fillSelectionData): Add support for images here.
        (WebCore::PasteboardHelper::targetListForDataObject): Add support for images here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Stuart Morgan <stuartmorgan@chromium.org>
eric@webkit.org [Wed, 5 May 2010 16:22:05 +0000 (16:22 +0000)]
2010-05-05  Stuart Morgan  <stuartmorgan@chromium.org>

        Reviewed by Darin Fisher.

        Add a "focused" parameter to Widget::setFocus, and updates Document
        so that Widget is informed of focus loss as well as focus gain.
        Changes all existing setFocus implementations so that they ignore
        the 'false' case, so no behavior is changed until individual
        platforms are updated to handle the new case (if they want to).

        https://bugs.webkit.org/show_bug.cgi?id=37961

        * dom/Document.cpp:
        (WebCore::Document::setFocusedNode):
        * platform/Widget.h:
        * platform/android/WidgetAndroid.cpp:
        (WebCore::Widget::setFocus):
        * platform/chromium/WidgetChromium.cpp:
        (WebCore::Widget::setFocus):
        * platform/efl/WidgetEfl.cpp:
        (WebCore::Widget::setFocus):
        * platform/gtk/WidgetGtk.cpp:
        (WebCore::Widget::setFocus):
        * platform/haiku/WidgetHaiku.cpp:
        (WebCore::Widget::setFocus):
        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::setFocus):
        * platform/qt/WidgetQt.cpp:
        (WebCore::Widget::setFocus):
        * platform/win/WidgetWin.cpp:
        (WebCore::Widget::setFocus):
        * platform/wx/WidgetWx.cpp:
        (WebCore::Widget::setFocus):
        * plugins/PluginView.h:
        * plugins/PluginViewNone.cpp:
        (WebCore::PluginView::setFocus):
        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::setFocus):
        * plugins/mac/PluginViewMac.cpp:
        (WebCore::PluginView::setFocus):
        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::setFocus):
        * plugins/symbian/PluginViewSymbian.cpp:
        (WebCore::PluginView::setFocus):
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::setFocus):
2010-05-05  Stuart Morgan  <stuartmorgan@chromium.org>

        Reviewed by Darin Fisher.

        Update the plugin container's setFocus implementation to pass the new
        boolean argument to the next layer.

        https://bugs.webkit.org/show_bug.cgi?id=37961

        * src/WebPluginContainerImpl.cpp:
        (WebKit::WebPluginContainerImpl::setFocus):
        * src/WebPluginContainerImpl.h:
2010-05-05  Stuart Morgan  <stuartmorgan@chromium.org>

        Reviewed by Darin Fisher.

        Update setFocus for the new boolean argument; no behavioral change.

        https://bugs.webkit.org/show_bug.cgi?id=37961

        * WebCoreSupport/EmbeddedWidget.cpp:
        (EmbeddedWidget::setFocus):
        * WebCoreSupport/EmbeddedWidget.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Jeremy Moskovich <jeremy@chromium.org>
jeremy@chromium.org [Wed, 5 May 2010 16:01:29 +0000 (16:01 +0000)]
2010-05-05  Jeremy Moskovich  <jeremy@chromium.org>

        Unreviewed, updated baselines.

        skia r561 broke a bunch of chromium image baselines.
        Update test_expectations to include remaining failures.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Jeremy Moskovich <jeremy@chromium.org>
jeremy@chromium.org [Wed, 5 May 2010 15:18:53 +0000 (15:18 +0000)]
2010-05-05  Jeremy Moskovich  <jeremy@chromium.org>

        Unreviewed, updated baselines.

        skia r561 broke a bunch of chromium image baselines.
        Rebase a few tests that were missed by previous passes.

        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
        * platform/chromium-linux/svg/custom/mask-changes-expected.checksum: Added.
        * platform/chromium-linux/svg/custom/mask-changes-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Steve Block <steveblock@google.com>
eric@webkit.org [Wed, 5 May 2010 15:08:22 +0000 (15:08 +0000)]
2010-05-05  Steve Block  <steveblock@google.com>

        Reviewed by Pavel Feldman.

        Move V8 ScriptDebugServer::topStackFrame() to ScriptCallStack
        https://bugs.webkit.org/show_bug.cgi?id=38531

        ScriptCallStack::create() uses ScriptDebugServer::topStackFrame(), but ScriptDebugServer
        is guarded with ENABLE(JAVASCRIPT_DEBUGGER). This prevents ScriptCallStack from being
        built on platforms that do not define ENABLE(JAVASCRIPT_DEBUGGER).

        No new tests, build fix only.

        * bindings/v8/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::callLocation):
        (WebCore::ScriptCallStack::createUtilityContext): Helper for topStackFrame, moved from ScriptDebugServer
        (WebCore::ScriptCallStack::topStackFrame): Moved from ScriptDebugServer
        * bindings/v8/ScriptCallStack.h:
        (WebCore::ScriptCallStack::utilityContext): Helper for topStackFrame, moved from ScriptDebugServer
        * bindings/v8/ScriptDebugServer.cpp:
        * bindings/v8/ScriptDebugServer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Jeremy Moskovich <jeremy@chromium.org>
jeremy@chromium.org [Wed, 5 May 2010 14:42:18 +0000 (14:42 +0000)]
2010-05-05  Jeremy Moskovich  <jeremy@chromium.org>

        Unreviewed, updated baselines - 6th and final batch.

        skia r561 broke a bunch of chromium image baselines.
        <long list of new image baselines redacted>

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Jeremy Moskovich <jeremy@chromium.org>
jeremy@chromium.org [Wed, 5 May 2010 14:18:24 +0000 (14:18 +0000)]
2010-05-05  Jeremy Moskovich  <jeremy@chromium.org>

        Unreviewed, updated baselines - 5th batch.

        skia r561 broke a bunch of chromium image baselines.
        <long list of new image baselines redacted>

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Jeremy Moskovich <jeremy@chromium.org>
jeremy@chromium.org [Wed, 5 May 2010 13:52:56 +0000 (13:52 +0000)]
2010-05-05  Jeremy Moskovich  <jeremy@chromium.org>

        Unreviewed, updated baselines - 4th batch.

        skia r561 broke a bunch of chromium image baselines.
        <long list of new image baselines redacted>

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Jeremy Moskovich <jeremy@chromium.org>
jeremy@chromium.org [Wed, 5 May 2010 13:31:12 +0000 (13:31 +0000)]
2010-05-05  Jeremy Moskovich  <jeremy@chromium.org>

        Unreviewed, updated baselines - 3rd batch.

        skia r561 broke a bunch of chromium image baselines.
        <long list of new image baselines redacted>

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] REGRESSION(r56869): WinCE build is broken
ossy@webkit.org [Wed, 5 May 2010 12:57:48 +0000 (12:57 +0000)]
[Qt] REGRESSION(r56869): WinCE build is broken
https://bugs.webkit.org/show_bug.cgi?id=36929

Rubber-stamped by Simon Hausmann.

* WebCore.pro: LIBS += -lOle32 added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, updated baselines - 2nd batch.
jeremy@chromium.org [Wed, 5 May 2010 12:36:18 +0000 (12:36 +0000)]
Unreviewed, updated baselines - 2nd batch.

skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, updated baselines - 1st batch.
jeremy@chromium.org [Wed, 5 May 2010 11:54:32 +0000 (11:54 +0000)]
Unreviewed, updated baselines - 1st batch.

skia r561 broke a bunch of chromium image baselines.
<long list of new image baselines redacted>

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Disable Qt Multimedia backend for HTML 5 Audio and Video elements
hausmann@webkit.org [Wed, 5 May 2010 11:30:56 +0000 (11:30 +0000)]
[Qt] Disable Qt Multimedia backend for HTML 5 Audio and Video elements

Reviewed by Tor Arne Vestbø.

Fall back to the Phonon backend until the release situation has been cleared up.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 5 May 2010 11:30:07 +0000 (11:30 +0000)]
2010-05-05  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Clickable links to resources should be used as 'details' part for the all suitable kinds of records.
        https://bugs.webkit.org/show_bug.cgi?id=38542

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
        (WebInspector.TimelineRecordListRow):
        (WebInspector.TimelineRecordListRow.prototype.update):
        (WebInspector.TimelinePanel.FormattedRecord):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
        (WebInspector.TimelinePanel.PopupContentHelper):
        (WebInspector.TimelinePanel.PopupContentHelper.prototype._createCell):
        (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendTextRow):
        (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendElementRow):
        (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 5 May 2010 09:33:29 +0000 (09:33 +0000)]
2010-05-05  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Add missing files generated by "run-bindings-test", after the DOMTestCallback.idl addition.

        * bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: Added.
        (WebKit::kit):
        (webkit_dom_test_callback_callback_with_class1param):
        (webkit_dom_test_callback_callback_with_class2param):
        (webkit_dom_test_callback_callback_with_non_bool_return_type):
        (WebKit::wrapTestCallback):
        (WebKit::core):
        (webkit_dom_test_callback_finalize):
        (webkit_dom_test_callback_set_property):
        (webkit_dom_test_callback_get_property):
        (webkit_dom_test_callback_class_init):
        (webkit_dom_test_callback_init):
        * bindings/scripts/test/GObject/WebKitDOMTestCallback.h: Added.
        * bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h: Added.
        * bindings/scripts/test/ObjC/DOMTestCallback.h: Added.
        * bindings/scripts/test/ObjC/DOMTestCallback.mm: Added.
        (-[DOMTestCallback dealloc]):
        (-[DOMTestCallback finalize]):
        (-[DOMTestCallback callbackWithClass1Param:]):
        (-[DOMTestCallback callbackWithClass2Param:strArg:]):
        (-[DOMTestCallback callbackWithNonBoolReturnType:]):
        (-[DOMTestCallback customCallback:class6Param:]):
        (core):
        (kit):
        * bindings/scripts/test/ObjC/DOMTestCallbackInternal.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Unreviewed, expectations change.
jeremy@chromium.org [Wed, 5 May 2010 08:00:37 +0000 (08:00 +0000)]
 Unreviewed, expectations change.

 recommit r58747 - Preparing for chromium skia roll incorporating changes up to r561.
 Add expected failures so bots don't turn red while rolling.

 https://bugs.webkit.org/show_bug.cgi?id=38512

 * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 5 May 2010 07:57:43 +0000 (07:57 +0000)]
2010-05-05  Xan Lopez  <xlopez@igalia.com>

        Skip flakey workers test.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Joseph Pecoraro <joepeck@webkit.org>
eric@webkit.org [Wed, 5 May 2010 07:57:07 +0000 (07:57 +0000)]
2010-05-05  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: FontView needs Cleanup
        https://bugs.webkit.org/show_bug.cgi?id=38567

        FontView was missing some of the newer practices for initialization
        that other Resource Views had. Also its width calculations could
        result in a single character wrapping. This is general cleanup.

        * inspector/front-end/FontView.js:
        (WebInspector.FontView): move initialization into contentTabSelected
        (WebInspector.FontView.prototype.contentTabSelected): handle initialization like other Resource Views
        (WebInspector.FontView.prototype.updateFontPreviewSize): use a narrower width to prevent text from widowing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-05 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 5 May 2010 07:31:40 +0000 (07:31 +0000)]
2010-05-05  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG hit testing is *way* too slow
        https://bugs.webkit.org/show_bug.cgi?id=19312

        Use the cached stroke and fill boundaries in RenderPath as a heuristik to
        speed up SVG's hit testing.

        No new tests added.

        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::fillContains):
        (WebCore::RenderPath::strokeContains):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 5 May 2010 06:06:27 +0000 (06:06 +0000)]
2010-05-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Shinichiro Hamaji.

        PrettyPatch.pretty_diff("") should not hang
        https://bugs.webkit.org/show_bug.cgi?id=38552

        Also found a bug in PrettyPatch.pretty_diff where it would
        hang when passed "" as input.

        I suspect there may be bugs in prettify.rb (or our use there-of)
        where it can hang, which would then cause the testing thread to hang.

        * Scripts/webkitpy/common/prettypatch.py:
         - Don't hang when passed ""
        * Scripts/webkitpy/common/prettypatch_unittest.py:
         - Test that we don't hang when passed ""
        * Scripts/webkitpy/layout_tests/port/base.py:
         - Add a FIXME that we should share code with prettypatch.rb

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 5 May 2010 05:09:42 +0000 (05:09 +0000)]
2010-05-04  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Improve check for drawing into the window that was added in r58623
        https://bugs.webkit.org/show_bug.cgi?id=38562

        Rather than assuming that any non-bitmap context is the window's context,
        compare the current graphics context with -[NSWindow graphicsContext] to
        determine that we're drawing into the window.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawRect:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAuto-generate all Database callbacks.
dumi@chromium.org [Wed, 5 May 2010 03:24:15 +0000 (03:24 +0000)]
Auto-generate all Database callbacks.
https://bugs.webkit.org/show_bug.cgi?id=38503

Reviewed by Adam Barth.

* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSCustomSQLStatementCallback.cpp: Removed.
* bindings/js/JSCustomSQLStatementCallback.h: Removed.
* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
(WebCore::JSSQLStatementErrorCallback::handleEvent):
* bindings/js/JSCustomSQLStatementErrorCallback.h: Removed.
* bindings/js/JSCustomSQLTransactionCallback.cpp: Removed.
* bindings/js/JSCustomSQLTransactionCallback.h: Removed.
* bindings/js/JSCustomSQLTransactionErrorCallback.cpp: Removed.
* bindings/js/JSCustomSQLTransactionErrorCallback.h: Removed.
* bindings/js/JSDatabaseCallback.cpp: Removed.
* bindings/js/JSDatabaseCallback.h: Removed.
* bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::changeVersion):
(WebCore::createTransaction):
* bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/test/JS/JSTestCallback.cpp:
* bindings/v8/custom/V8CustomSQLStatementCallback.cpp: Removed.
* bindings/v8/custom/V8CustomSQLStatementCallback.h: Removed.
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8SQLStatementErrorCallback::handleEvent):
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.h: Removed.
* bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: Removed.
* bindings/v8/custom/V8CustomSQLTransactionCallback.h: Removed.
* bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: Removed.
* bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Removed.
* bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
* bindings/v8/custom/V8DatabaseCallback.h: Removed.
* bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::V8Database::changeVersionCallback):
(WebCore::createTransaction):
* bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
* storage/DatabaseCallback.h:
* storage/DatabaseCallback.idl: Added.
* storage/SQLStatement.cpp:
(WebCore::SQLStatement::performCallback):
* storage/SQLStatementCallback.h:
* storage/SQLStatementCallback.idl: Added.
* storage/SQLStatementErrorCallback.idl: Added.
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverTransactionCallback):
* storage/SQLTransactionCallback.h:
* storage/SQLTransactionCallback.idl: Added.
* storage/SQLTransactionErrorCallback.h:
* storage/SQLTransactionErrorCallback.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoresults for new test checked in with http://trac.webkit.org/changeset/58797
cmarrin@apple.com [Wed, 5 May 2010 03:06:05 +0000 (03:06 +0000)]
results for new test checked in with trac.webkit.org/changeset/58797

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-04 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 5 May 2010 02:43:00 +0000 (02:43 +0000)]
2010-05-04  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations fix.

        Re-add the two expectations lines that got mistakenly deleted in
        r58798.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-04 Chris Marrin <cmarrin@apple.com>
dpranke@chromium.org [Wed, 5 May 2010 02:05:04 +0000 (02:05 +0000)]
2010-05-04  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Made composited iframes work on Windows
        https://bugs.webkit.org/show_bug.cgi?id=32446

        I've added one new test (composited-parent-iframe.html) which
        shows both the parent iframe and the iframe contents document
        with compositing. It also shows correct behavior with clipping,
        borders, margins, padding and shadows. It also sets the iframe
        size as a percent of the page to show correct resizing behavior.
        The existing composited-iframe.html has been changed similarly
        but without the page resizing. The existing preserve-3d-switching.html
        test needed new results because of changes to the layer dumper.

        * compositing/geometry/preserve-3d-switching-expected.txt:
        * compositing/iframes/composited-iframe.html:
        * compositing/iframes/composited-parent-iframe.html: Added.
        * compositing/iframes/resources/composited-subframe.html:
        * platform/win/compositing/iframes/composited-iframe-expected.txt:
        * platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
cmarrin@apple.com [Wed, 5 May 2010 01:50:03 +0000 (01:50 +0000)]
    Reviewed by Simon Fraser.

        Made composited iframes work on Windows
        https://bugs.webkit.org/show_bug.cgi?id=32446

        This completes the work in http://trac.webkit.org/changeset/57919
        to create compositing layers in the parent document when an iframe has
        a compositing layer. The parent document has a layer for the iframe
        element and builds a layer tree to the page root. The layer tree for the
        iframe document is then parented to the iframe element's GraphicsLayer.

        The RenderLayerCompositor for the iframe document (which owns the
        root of the layer tree) now has a clippingLayer which is the
        parent of the layer tree root so it can be clipped to the parent
        iframe's bounds, taking into account borders, padding, etc. in
        the parent iframe element.

        I also got rid of a no longer used function: RenderLayerCompositor::parentInRootLayer

        Test: compositing/iframes/composited-parent-iframe.html

        * rendering/RenderLayerBacking.cpp:Make calls to RenderLayerCompositor to set the clipping bounds for iframe content
        * rendering/RenderLayerCompositor.cpp:Hook the iframe content to the parent iframe element
        * rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Not reviewed.
ap@apple.com [Wed, 5 May 2010 01:24:17 +0000 (01:24 +0000)]
    Not reviewed.

        Updated test results - the test still passes.

        * http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the sticky-notes demo.
dumi@chromium.org [Wed, 5 May 2010 01:22:17 +0000 (01:22 +0000)]
Fix the sticky-notes demo.
https://bugs.webkit.org/show_bug.cgi?id=38550

Reviewed by Darin Adler.

1. Exceptions thrown by openDatabase() should be treated as
failures.
2. Do not allow users to create new notes when openDatabase()
failed.

* demos/sticky-notes/index.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58795 268f45cc-cd09-0410-ab3c-d52691b4dbfc