WebKit-https.git
10 years ago[wx] Unreviewed build fixes after recent trunk changes.
kevino@webkit.org [Fri, 6 May 2011 00:12:05 +0000 (00:12 +0000)]
[wx] Unreviewed build fixes after recent trunk changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: WebCore part of <rdar://problem/9155590> Broken animation in iAd...
mitz@apple.com [Fri, 6 May 2011 00:09:17 +0000 (00:09 +0000)]
Source/WebCore: WebCore part of <rdar://problem/9155590> Broken animation in iAd producer

Reviewed by Simon Fraser.

* WebCore.exp.in: Export wkExecutableWasLinkedOnOrBeforeSnowLeopard.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes): Account for the binary-compatiblity
check in Core Animation.
* platform/mac/WebCoreSystemInterface.h: Added wkExecutableWasLinkedOnOrBeforeSnowLeopard.
* platform/mac/WebCoreSystemInterface.mm: Ditto.

Source/WebKit/mac: WebKit part of <rdar://problem/9155590> Broken animation in iAd producer

Reviewed by Simon Fraser.

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Initialize wkExecutableWasLinkedOnOrBeforeSnowLeopard.

Source/WebKit2: WebKit2 part of <rdar://problem/9155590> Broken animation in iAd producer

Reviewed by Simon Fraser.

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Initialize wkExecutableWasLinkedOnOrBeforeSnowLeopard.

WebKitLibraries: WebKitSystemInterface part of <rdar://problem/9155590> Broken animation in iAd producer

Reviewed by Simon Fraser.

* WebKitSystemInterface.h: Added WKExecutableWasLinkedOnOrBeforeSnowLeopard().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 5 May 2011 23:56:19 +0000 (23:56 +0000)]
2011-05-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        WebKit2 (Mac): Background tabs/windows can force themselves to the front
        <rdar://problem/9386346>
        https://bugs.webkit.org/show_bug.cgi?id=60315

        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::setFocus):
        It is incorrect for us to call Chrome::focus() here, which could bring a window/tab
        to the front. Calling focusNSView() was only necessary because in WebKit we must inform
        the platform widget that the focus has changed. WebKit2 Mac now matches other ports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Thu, 5 May 2011 23:54:06 +0000 (23:54 +0000)]
2011-05-05  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Seidel.

        Rebaseline various media tests after absolute positioning change. This rebaseline also
        fixes outstanding minor pixel diffs.

        [chromium] Rebaseline various media tests after controls absolute positioning changes
        https://bugs.webkit.org/show_bug.cgi?id=60230

        * platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
        * platform/chromium-gpu-linux/media/video-no-audio-expected.png:
        * platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
        * platform/chromium-gpu-mac/media/video-no-audio-expected.png:
        * platform/chromium-gpu-win/media/video-display-toggle-expected.png:
        * platform/chromium-gpu-win/media/video-no-audio-expected.png:
        * platform/chromium-linux/media/audio-controls-rendering-expected.png:
        * platform/chromium-linux/media/media-document-audio-repaint-expected.png:
        * platform/chromium-linux/media/video-controls-rendering-expected.png:
        * platform/chromium-linux/media/video-display-toggle-expected.png:
        * platform/chromium-linux/media/video-empty-source-expected.png:
        * platform/chromium-linux/media/video-no-audio-expected.png:
        * platform/chromium-linux/media/video-volume-slider-expected.png:
        * platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
        * platform/chromium-mac-leopard/media/audio-controls-rendering-expected.txt: Removed.
        * platform/chromium-mac-leopard/media/controls-after-reload-expected.txt: Removed.
        * platform/chromium-mac-leopard/media/controls-strict-expected.txt: Removed.
        * platform/chromium-mac-leopard/media/controls-styling-expected.txt: Removed.
        * platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
        * platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
        * platform/chromium-mac-leopard/media/video-display-toggle-expected.png:
        * platform/chromium-mac-leopard/media/video-empty-source-expected.png:
        * platform/chromium-mac-leopard/media/video-empty-source-expected.txt: Removed.
        * platform/chromium-mac-leopard/media/video-no-audio-expected.png:
        * platform/chromium-mac-leopard/media/video-no-audio-expected.txt: Removed.
        * platform/chromium-mac-leopard/media/video-volume-slider-expected.png:
        * platform/chromium-mac-leopard/media/video-volume-slider-expected.txt: Removed.
        * platform/chromium-mac/media/audio-controls-rendering-expected.png:
        * platform/chromium-mac/media/audio-controls-rendering-expected.txt:
        * platform/chromium-mac/media/controls-after-reload-expected.txt:
        * platform/chromium-mac/media/controls-strict-expected.txt:
        * platform/chromium-mac/media/controls-styling-expected.txt:
        * platform/chromium-mac/media/controls-without-preload-expected.txt:
        * platform/chromium-mac/media/media-document-audio-repaint-expected.png:
        * platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
        * platform/chromium-mac/media/video-controls-rendering-expected.png:
        * platform/chromium-mac/media/video-controls-rendering-expected.txt:
        * platform/chromium-mac/media/video-display-toggle-expected.png:
        * platform/chromium-mac/media/video-display-toggle-expected.txt:
        * platform/chromium-mac/media/video-empty-source-expected.png:
        * platform/chromium-mac/media/video-empty-source-expected.txt:
        * platform/chromium-mac/media/video-no-audio-expected.png:
        * platform/chromium-mac/media/video-no-audio-expected.txt:
        * platform/chromium-mac/media/video-volume-slider-expected.png:
        * platform/chromium-mac/media/video-volume-slider-expected.txt:
        * platform/chromium-win/media/audio-controls-rendering-expected.png:
        * platform/chromium-win/media/audio-controls-rendering-expected.txt:
        * platform/chromium-win/media/controls-after-reload-expected.txt:
        * platform/chromium-win/media/controls-strict-expected.txt:
        * platform/chromium-win/media/controls-styling-expected.txt:
        * platform/chromium-win/media/controls-without-preload-expected.txt:
        * platform/chromium-win/media/media-document-audio-repaint-expected.png:
        * platform/chromium-win/media/media-document-audio-repaint-expected.txt:
        * platform/chromium-win/media/video-controls-rendering-expected.png:
        * platform/chromium-win/media/video-controls-rendering-expected.txt:
        * platform/chromium-win/media/video-display-toggle-expected.png:
        * platform/chromium-win/media/video-display-toggle-expected.txt:
        * platform/chromium-win/media/video-empty-source-expected.png:
        * platform/chromium-win/media/video-empty-source-expected.txt:
        * platform/chromium-win/media/video-no-audio-expected.png:
        * platform/chromium-win/media/video-no-audio-expected.txt:
        * platform/chromium-win/media/video-volume-slider-expected.png:
        * platform/chromium-win/media/video-volume-slider-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Andy Estes <aestes@apple.com>
aestes@apple.com [Thu, 5 May 2011 23:34:19 +0000 (23:34 +0000)]
2011-05-05  Andy Estes  <aestes@apple.com>

        Reviewed by Daniel Bates.

        update-webkit should handle Internal using a different VCS than OpenSource.
        https://bugs.webkit.org/show_bug.cgi?id=60310

        isGit() and isSVN() cache their results, so Internal will always be
        updated using the VCS commands used for OpenSource. If Internal uses a
        different VCS, this will fail. Fix this by calling isGitDirectory() and
        isSVNDirectory() instead, which do not cache their results.

        * Scripts/update-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Thu, 5 May 2011 23:07:57 +0000 (23:07 +0000)]
2011-05-05  Jer Noble  <jer.noble@apple.com>

        Reviewed by Tony Chang.

        full-screen-stacking-context-expected.txt should be under platform/mac
        https://bugs.webkit.org/show_bug.cgi?id=60236

        Make the text output of full screen pixel tests platform agnostic.

        * fullscreen/full-screen-stacking-context-expected.txt:
        * fullscreen/full-screen-test.js:
        * fullscreen/full-screen-zIndex-expected.txt:
        * platform/chromium-linux/fullscreen/full-screen-zIndex-expected.txt: Removed.
        * platform/chromium-win/fullscreen/full-screen-zIndex-expected.txt: Removed.
        * platform/gtk/fullscreen/full-screen-zIndex-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 5 May 2011 22:42:32 +0000 (22:42 +0000)]
2011-05-05  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        nrwt: revamp integration tests incl. tests for servers
        https://bugs.webkit.org/show_bug.cgi?id=59985

        This change adds the ability to run "integration tests" that
        depend on (and affect) the local environment on your machine.
        These tests can be run manually by invoking python on the
        test file in question and passing the '-i' flag, but are
        not run automatically as part of test-webkitpy.

        Integration tests are identified by being methods named as
        "integration_test_*" instead of "test_*", and we use a
        custom TestLoader instead of the default one provided by
        unittest.

        This change also adds a protected "_default_to_apache" method
        to the port object so we can do the right thing when starting
        and stopping web servers with less mechanism.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Justin Novosad <junov@chromium.org>
commit-queue@webkit.org [Thu, 5 May 2011 22:39:16 +0000 (22:39 +0000)]
2011-05-05  Justin Novosad  <junov@chromium.org>

        Reviewed by Kenneth Russell.

        [Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
        https://bugs.webkit.org/show_bug.cgi?id=60173

        * platform/chromium/test_expectations.txt:
        Adding expected failures for the the switch to Ganesh
2011-05-05  Justin Novosad  <junov@chromium.org>

        Reviewed by Kenneth Russell.

        [Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
        https://bugs.webkit.org/show_bug.cgi?id=60173

        * page/Page.cpp:
        (WebCore::Page::sharedGraphicsContext3D):
        Flipping the switch to make Skia the default for the accelerated 2d canvas

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Thu, 5 May 2011 22:38:09 +0000 (22:38 +0000)]
2011-05-05  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        ASSERT(m_state == ParsingState) fires @ www.canalplus.fr
        https://bugs.webkit.org/show_bug.cgi?id=60101

        * fast/parser/close-while-stopping-expected.txt: Added.
        * fast/parser/close-while-stopping.html: Added.
2011-05-05  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        ASSERT(m_state == ParsingState) fires @ www.canalplus.fr
        https://bugs.webkit.org/show_bug.cgi?id=60101

        Test: fast/parser/close-while-stopping.html

        * dom/Document.cpp:
        (WebCore::Document::close): According to http://www.whatwg.org/specs/web-apps/current-work/#dom-document-close,
        the close() steps should be aborted if there is no script-created parser
        associated with the document. Our parser lives throughout
        http://www.whatwg.org/specs/web-apps/current-work/#the-end, but it seems
        the spec doesn't consider the parser active any more. So to properly
        respect this, we need to check that the parser is still parsing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Evan Martin <evan@chromium.org>
evan@chromium.org [Thu, 5 May 2011 22:23:22 +0000 (22:23 +0000)]
2011-05-03  Evan Martin  <evan@chromium.org>

        Reviewed by Ojan Vafai.

        REGRESSION: backspace should not go back on Linux
        https://bugs.webkit.org/show_bug.cgi?id=59731

        Add a test that verifies that pressing backspace goes back on Mac
        and Windows but does not go back on Linux.

        * fast/events/backspace-navigates-back-expected.txt: Added.
        * fast/events/backspace-navigates-back.html: Added.
2011-04-28  Evan Martin  <evan@chromium.org>

        Reviewed by Ojan Vafai.

        REGRESSION: backspace should not go back on Linux
        https://bugs.webkit.org/show_bug.cgi?id=59731

        Add a new EditingBehavior, shouldNavigateBackOnBackspace, which is false on
        Linux, and test for it in the default backspace handler.

        * editing/EditingBehavior.h:
        (WebCore::EditingBehavior::shouldNavigateBackOnBackspace):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::defaultBackspaceEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Thu, 5 May 2011 22:14:29 +0000 (22:14 +0000)]
2011-05-05  Alpha Lam  <hclam@chromium.org>

        Build fix. Not reviewed.

        Add test expectations.

        * platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling-expected.png: Added.
        * platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling2-expected.png: Added.
        * platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling3-expected.png: Added.
        * platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.
        * platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling-expected.png: Added.
        * platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling2-expected.png: Added.
        * platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling3-expected.png: Added.
        * platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Igor Oliveira <igor.oliveira@openbossa.org>
commit-queue@webkit.org [Thu, 5 May 2011 22:10:02 +0000 (22:10 +0000)]
2011-05-05  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Kenneth Russell.

        Framebuffer object is being created twice
        https://bugs.webkit.org/show_bug.cgi?id=60207

        Does not create more than one opengl framebuffer

        * platform/graphics/gpu/mac/DrawingBufferMac.mm:
        (WebCore::DrawingBuffer::DrawingBuffer):
        * platform/graphics/gpu/qt/DrawingBufferQt.cpp:
        (WebCore::DrawingBuffer::DrawingBuffer):
        * platform/graphics/gtk/DrawingBufferGtk.cpp:
        (WebCore::DrawingBuffer::DrawingBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 5 May 2011 22:09:02 +0000 (22:09 +0000)]
2011-05-05  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Beth Dakin.

        Every RenderLayer registers itself as a ScrollableArea
        https://bugs.webkit.org/show_bug.cgi?id=59650

        Rather than registering every RenderLayer as a ScrollableArea
        on layer creation, only register RenderLayers which are overflow-
        scrollable. Use the m_scrollableAreaPage pointer to keep track
        of whether we've registered to avoid excess work.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::RenderLayer):
        (WebCore::RenderLayer::scrollsOverflow):
        (WebCore::RenderLayer::styleChanged):
        * rendering/RenderLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate pixel results for draws-gradient.html to have an alpha channel
aroben@apple.com [Thu, 5 May 2011 22:06:26 +0000 (22:06 +0000)]
Update pixel results for draws-gradient.html to have an alpha channel

These pixel results were generated in r71418, when DRT was changed not to use an alpha
channel for pixel results. DRT was changed back to using an alpha channel in r71516, but
these pixel results were never updated. Now that DRT ensures that the alpha channel is
filled with constant opacity, we can safely update these pixel results without negatively
affecting their appearance. (The draws-gradient plugin uses ::GradientFill, which fills the
alpha channel with 0, so the plugin would have shown up as fully transparent in the pixel
results if DRT didn't modify the alpha channel.)

Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
generated due to alpha channel weirdness

Reviewed by Sam Weinig.

LayoutTests:

* platform/win/platform/win/plugins/draws-gradient-expected.png: Regenerated. Looks the same
as before, but with an alpha channel.

Tools:

Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows

DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
alpha channel will even get filled with zeros (like when ::GradientFill is used). To
safeguard against this, we fill the alpha channel with constant full opacity after the
WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
results need an alpha channel, too.)

* DumpRenderTree/win/PixelDumpSupportWin.cpp:
(makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
constant full opacity.
(createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
in a CGContext or cairo_surface.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd support for layoutTestController.dumpAsText(true) to WebKitTestRunner
aroben@apple.com [Thu, 5 May 2011 22:05:36 +0000 (22:05 +0000)]
Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner

Passing true tells the test harness to dump pixels even though we're not dumping a render
tree.

Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
WebKitTestRunner doesn't result in pixel results being generated

Reviewed by Sam Weinig.

* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels
argument to dumpAsText.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dump): Updated for dumpAsText change.

* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.

* WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.

* WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows
developers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Keith Kyzivat <keith.kyzivat@nokia.com>
commit-queue@webkit.org [Thu, 5 May 2011 22:04:21 +0000 (22:04 +0000)]
2011-05-05  Keith Kyzivat  <keith.kyzivat@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] [WK2] Add method to disable plugins under WK2
        https://bugs.webkit.org/show_bug.cgi?id=57796

        * config.h: Allow PLUGIN_ARCHITECTURE_UNSUPPORTED to be defined on build command line

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Thu, 5 May 2011 21:59:17 +0000 (21:59 +0000)]
2011-05-05  Jer Noble  <jer.noble@apple.com>

        Reviewed by Steve Falkenburg.

        Workaround iTunes' incorrect registry entry for .m4a extensions.
        https://bugs.webkit.org/show_bug.cgi?id=60229

        No new tests, as a test already exits for .m4a support (LayoutTests/media/audio-mpeg4-supported.html).
        The test failed to catch this regression because the build bots haven't installed iTunes.

        Add a hard-coded MIME type mapping for 'm4a' -> 'audio/x-m4a'.

        * platform/win/MIMETypeRegistryWin.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Thu, 5 May 2011 21:57:01 +0000 (21:57 +0000)]
2011-05-05  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Minor rebaselines for gtk after my r85876.

        * platform/gtk/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
        * platform/gtk/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
        * platform/gtk/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
        * platform/gtk/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 5 May 2011 21:49:55 +0000 (21:49 +0000)]
2011-05-05  Tony Chang  <tony@chromium.org>

        Remove google-chrome-linux results.  We're switching the official
        builders from hardy to lucid and want to clear the old hardy based
        results.

        * platform/google-chrome-linux32/css1: Removed.
        * platform/google-chrome-linux32/css2.1: Removed.
        * platform/google-chrome-linux32/editing: Removed.
        * platform/google-chrome-linux32/fast: Removed.
        * platform/google-chrome-linux32/plugins: Removed.
        * platform/google-chrome-linux32/svg: Removed.
        * platform/google-chrome-linux32/tables: Removed.
        * platform/google-chrome-linux32/transforms: Removed.
        * platform/google-chrome-linux64/fast: Removed.
        * platform/google-chrome-linux64/svg: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
lforschler@apple.com [Thu, 5 May 2011 21:49:16 +0000 (21:49 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Thu, 5 May 2011 21:42:59 +0000 (21:42 +0000)]
2011-05-05  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Minor rebaselines for qt after my r85876.

        * platform/qt/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
        * platform/qt/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
        * platform/qt/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
        * platform/qt/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 5 May 2011 21:41:06 +0000 (21:41 +0000)]
2011-05-05  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        Modify the chromium expectations so that you no longer need to
        specify both the operating system and the version. I.e., you
        don't need "MAC LEOPARD", just "LEOPARD".

        * platform/chromium/test_expectations.txt:
2011-05-05  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: merge os, version fields in test config
        https://bugs.webkit.org/show_bug.cgi?id=60004

        This change removes the 'o/s' field from the TestConfiguration
        object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
        the expectations file to macros that expand to the version names
        for each platform.

        This means that you can once again put any subset of the
        operating system versions on a single line, e.g.:
          BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL

        This change will break any existing test_expectations.txt
        file that uses the "OS-VERSION" macros, which are no longer
        needed. It turns out they were never needed, as just VERSION
        by itself was sufficient. The test_expectations.txt file should
        be updated accordingly prior to landing this change.

        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
        * Scripts/webkitpy/layout_tests/port/base.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 5 May 2011 21:26:32 +0000 (21:26 +0000)]
2011-05-05  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        [chromium] switch from Lucida to free fonts for Hindi and Thai
        https://bugs.webkit.org/show_bug.cgi?id=60287

        Rebase tests that have Thai or Hindi glyphs.  We have different
        results for x86_64 (lucid) and x86 (hardy) because the fonts have
        changed.  Since it's only a handful of tests, seems ok to have
        separate baselines (also, hardy is going away real soon now).

        * platform/chromium-linux-x86_64/fast/text/atsui-multiple-renderers-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.png.
        * platform/chromium-linux-x86_64/fast/text/atsui-multiple-renderers-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.txt.
        * platform/chromium-linux-x86_64/fast/text/capitalize-boundaries-expected.png: Added.
        * platform/chromium-linux-x86_64/fast/text/capitalize-boundaries-expected.txt: Added.
        * platform/chromium-linux-x86_64/fast/text/complex-text-opacity-expected.png: Added.
        * platform/chromium-linux-x86_64/fast/text/complex-text-opacity-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/complex-text-opacity-expected.txt.
        * platform/chromium-linux-x86_64/fast/text/international/danda-space-expected.png:
        * platform/chromium-linux-x86_64/fast/text/international/danda-space-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/international/danda-space-expected.txt.
        * platform/chromium-linux-x86_64/fast/text/international/hindi-spacing-expected.png: Added.
        * platform/chromium-linux-x86_64/fast/text/international/hindi-spacing-expected.txt: Added.
        * platform/chromium-linux-x86_64/fast/text/international/thai-baht-space-expected.png: Added.
        * platform/chromium-linux-x86_64/fast/text/international/thai-baht-space-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/international/thai-baht-space-expected.txt.
        * platform/chromium-linux-x86_64/fast/text/international/thai-line-breaks-expected.png: Added.
        * platform/chromium-linux-x86_64/fast/text/international/thai-line-breaks-expected.txt: Added.
        * platform/chromium-linux-x86_64/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt.
        * platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.png:
        * platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.txt:
        * platform/chromium-linux/fast/text/complex-text-opacity-expected.png:
        * platform/chromium-linux/fast/text/complex-text-opacity-expected.txt:
        * platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt:
        * platform/chromium-linux/fast/text/international/danda-space-expected.png:
        * platform/chromium-linux/fast/text/international/danda-space-expected.txt:
        * platform/chromium-linux/fast/text/international/hindi-spacing-expected.png:
        * platform/chromium-linux/fast/text/international/hindi-spacing-expected.txt:
        * platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
        * platform/chromium-linux/fast/text/international/thai-baht-space-expected.txt:
        * platform/chromium-linux/fast/text/international/thai-line-breaks-expected.png:
        * platform/chromium-linux/fast/text/international/thai-line-breaks-expected.txt:
2011-05-05  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        [chromium] switch from Lucida to free fonts for Hindi and Thai
        https://bugs.webkit.org/show_bug.cgi?id=60287

        The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
        packages on Lucid. There are actually multiple Thai fonts in the
        package, so I just picked one.

        * DumpRenderTree/chromium/TestShellGtk.cpp:
        (setupFontconfig):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 5 May 2011 21:14:58 +0000 (21:14 +0000)]
2011-05-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        When an underlay surface is active, paint normal web contents in a transparency layer
        https://bugs.webkit.org/show_bug.cgi?id=60296

        In order for the page contents to correctly blend with the underlay, the page contents
        needs to be painted in a transparency layer.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::drawRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 5 May 2011 21:13:51 +0000 (21:13 +0000)]
2011-05-05  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        [chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
        https://bugs.webkit.org/show_bug.cgi?id=60290

        It used to be that google-chrome-32 was hardy32, google-chrome-64 was
        hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was
        lucid64.  Because of that, google-chrome-64 used to skip the
        chromium-linux-x86_64 results since they were more incorrect.

        Now that we're switching to lucid for google-chrome, we want
        google-chrome-64 to fall back to chromium-linux-x86_64.

        * Scripts/webkitpy/layout_tests/port/google_chrome.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Thu, 5 May 2011 21:07:52 +0000 (21:07 +0000)]
2011-05-05  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        When style changes for a RenderBlock and we lose our ability to intrude into
        floats in the next siblings block (e.g a position change), make sure to mark
        our childs with floats for layout and iterate through our next sibling block
        chain to see which ones contain the float that also exists in our floating
        objects list and clear those using markAllDescendantsWithFloatsForLayout.
        https://bugs.webkit.org/show_bug.cgi?id=56299

        Tests: fast/block/float/float-not-removed-from-next-sibling-crash.html
               fast/block/float/float-not-removed-from-next-sibling.html
               fast/block/float/float-not-removed-from-next-sibling2.html
               fast/block/float/float-not-removed-from-next-sibling3.html
               fast/block/float/float-not-removed-from-next-sibling4.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::styleWillChange):
        (WebCore::RenderBlock::styleDidChange):
        (WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
        * rendering/RenderBlock.h:
2011-05-04  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Tests that we do not crash when trying to add overflow from a float not in the
        descendant list and whose renderer is already removed.
        https://bugs.webkit.org/show_bug.cgi?id=56299

        * fast/block/float/float-not-removed-from-next-sibling-crash-expected.txt: Added.
        * fast/block/float/float-not-removed-from-next-sibling-crash.html: Added.
        * fast/block/float/float-not-removed-from-next-sibling.html: Added. Black
        text boxes should be inside the silver float. Failing test will have float
        added to the text div block which will push the text downward.
        * fast/block/float/float-not-removed-from-next-sibling-expected.png: Added.
        * fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
        * fast/block/float/float-not-removed-from-next-sibling2.html: Added. Black
        text boxes should be inside the silver float. Failing test will have float
        added to the text div block which will push the text downward.
        * fast/block/float/float-not-removed-from-next-sibling2-expected.png: Added.
        * fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
        * fast/block/float/float-not-removed-from-next-sibling3.html: Added. Distance
        between the silver float and black text boxes should be less than height of
        silver float. Failing test will have float overflow added to the text div
        block which will cause large space between silver float and and black text boxes.
        * fast/block/float/float-not-removed-from-next-sibling3-expected.png: Added.
        * fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
        * fast/block/float/float-not-removed-from-next-sibling4.html: Added. Distance
        between the silver float and black text boxes should be less than height of
        silver float. Failing test will have float overflow added to the text div
        block which will cause large space between silver float and and black text boxes.
        * fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.
        * fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 5 May 2011 20:55:18 +0000 (20:55 +0000)]
2011-05-05  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: merge TestExpectations, TestExpectationsFile classes
        https://bugs.webkit.org/show_bug.cgi?id=60002

        * Scripts/webkitpy/layout_tests/layout_package/manager.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
        * Scripts/webkitpy/style/checkers/test_expectations.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: WebKit2: Docking Web Inspector doesn't respect maximum inspector...
bweinstein@apple.com [Thu, 5 May 2011 20:31:10 +0000 (20:31 +0000)]
Source/WebCore: WebKit2: Docking Web Inspector doesn't respect maximum inspector size
https://bugs.webkit.org/show_bug.cgi?id=60294
<rdar://problem/9388518>

Reviewed by Timothy Hatcher.

Make a needed function public and export it.

* WebCore.exp.in: Export constrainedAttaechedWindowHeight.
* inspector/InspectorFrontendClientLocal.h: Make constrainedAttaechedWindowHeight public.

Source/WebKit2: WebKit2: Docking Web Inspector doesn't respect maximum inspector size
https://bugs.webkit.org/show_bug.cgi?id=60294
<rdar://problem/9388518>

Reviewed by Timothy Hatcher.

Before we place the inspector and the inspected views, make sure that we have constrained the height
of the docked inspector. Putting the code here covers both when the inspector is initially attached
and when a window with the docked inspector is resized.

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Constrain the height before laying out the views.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::onWebViewWindowPosChangingEvent): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Thu, 5 May 2011 20:30:13 +0000 (20:30 +0000)]
2011-05-05  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Nate Chapin.

        [Navigation Timing] navigationStart should always be available
        https://bugs.webkit.org/show_bug.cgi?id=59448

        * http/tests/misc/resources/webtiming-cross-origin-and-back2.html:
        * http/tests/misc/resources/webtiming-cross-origin-redirect.html:
        * http/tests/misc/webtiming-origins-expected.txt:
2011-05-05  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Nate Chapin.

        [Navigation Timing] navigationStart should always be available
        https://bugs.webkit.org/show_bug.cgi?id=59448

        * page/PerformanceTiming.cpp:
        (WebCore::PerformanceTiming::navigationStart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 5 May 2011 20:21:38 +0000 (20:21 +0000)]
2011-05-05  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adam Roben.

        Block callbacks delivered during destruction
        https://bugs.webkit.org/show_bug.cgi?id=60291
        <rdar://problem/9382942>

        No new tests, tested by existing tests.

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
        (WebCore::MediaPlayerPrivateAVFoundation::~MediaPlayerPrivateAVFoundation): Call
            setIgnoreLoadStateChanges(true) to cancel all callbacks.
        (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Return immediately if
            m_ignoreLoadStateChanges is true.
        (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): loadStateChanged -> updateStates.
            Don't call updateStates after calling loadedTimeRangesChanged, it already does it.
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 5 May 2011 20:18:40 +0000 (20:18 +0000)]
2011-05-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue should reject patches which fail ewses
        https://bugs.webkit.org/show_bug.cgi?id=47534

        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Prasanth Ullattil <prasanth.ullattil@nokia.com>
commit-queue@webkit.org [Thu, 5 May 2011 20:13:54 +0000 (20:13 +0000)]
2011-05-05  Prasanth Ullattil  <prasanth.ullattil@nokia.com>

        Reviewed by Simon Hausmann.

        Install correct header files for webkit.

        Since WebKit is no longer inside Qt, we can remove the detection for
        that.

        [Qt] Install targets are not working correctly for modularized Qt and QtWebkit
        https://bugs.webkit.org/show_bug.cgi?id=57621

        * Source/sync.profile:
2011-05-05  Prasanth Ullattil  <prasanth.ullattil@nokia.com>

        Reviewed by Simon Hausmann.

        Install correct header files for webkit.

        Since WebKit is no longer inside Qt, we can remove the detection for
        that.

        [Qt] Install targets are not working correctly for modularized Qt and QtWebkit
        https://bugs.webkit.org/show_bug.cgi?id=57621

        * QtWebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9354979> REGRESSION (r83070-r83126): Conversation takes 10 seconds...
hyatt@apple.com [Thu, 5 May 2011 20:04:01 +0000 (20:04 +0000)]
<rdar://problem/9354979> REGRESSION (r83070-r83126): Conversation takes 10 seconds to load and makes mail unresponsive

Reviewed by Darin Adler.

Culled inlines were triggering some pathological line box tree groveling that isn't even necessary.
Removed the ancient code (that used to be in RenderFlow), since it made no sense in the RenderBlock case
(it was running for inline blocks, which was definitely not even the intent) or in the RenderInline case
(the object being removed has no effect on any lines).

Also tweaked culledInlineFirstLineBox and culledInlineLastLineBox to avoid bailing if the first replaced object that
is encountered has a null inlineBoxWrapper().  Just a slight speed optimization to avoid an extra null check.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::destroy):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::destroy):
(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Bharathwaaj Srinivasan <bharathwaaj.s@gmail.com>
commit-queue@webkit.org [Thu, 5 May 2011 19:21:39 +0000 (19:21 +0000)]
2011-05-05  Bharathwaaj Srinivasan  <bharathwaaj.s@gmail.com>

        Reviewed by Holger Freyther.

        Fix build-webkit --minimal.
        https://bugs.webkit.org/show_bug.cgi?id=60257

        No new tests. This is just a build fix.

        * bindings/js/JSDOMBinding.cpp:
2011-05-05  Bharathwaaj Srinivasan  <bharathwaaj.s@gmail.com>

        Reviewed by Holger Freyther.

        Fix build-webkit --minimal.
        https://bugs.webkit.org/show_bug.cgi?id=60257

        * webkit/webkitglobals.cpp:
        (webkitInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Thu, 5 May 2011 19:05:02 +0000 (19:05 +0000)]
2011-05-05  Chang Shu  <cshu@webkit.org>

        Reviewed by Andreas Kling.

        [Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
        https://bugs.webkit.org/show_bug.cgi?id=59638

        Unskip passed tests.

        * platform/qt-wk2/Skipped:
2011-05-05  Chang Shu  <cshu@webkit.org>

        Reviewed by Andreas Kling.

        [Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
        https://bugs.webkit.org/show_bug.cgi?id=59638

        Added private constructors for class QGraphicsWKView and QWKPage to support
        WKPageGroupRef.

        * UIProcess/API/qt/qgraphicswkview.cpp:
        (QGraphicsWKView::QGraphicsWKView):
        (QGraphicsWKView::~QGraphicsWKView):
        (QGraphicsWKView::init):
        * UIProcess/API/qt/qgraphicswkview.h:
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::QWKPagePrivate):
        (QWKPage::QWKPage):
        (QWKPage::~QWKPage):
        (QWKPage::init):
        * UIProcess/API/qt/qwkpage.h:
        * UIProcess/API/qt/qwkpage_p.h:
2011-05-05  Chang Shu  <cshu@webkit.org>

        Reviewed by Andreas Kling.

        [Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
        https://bugs.webkit.org/show_bug.cgi?id=59638

        1. Call QGraphicsWKView constructor with pageGroupRef.
        2. Disable setFontFamily calls as it breaks Qt test fonts.

        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::resetStateToConsistentValues):
        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
        (WTR::WebView::WebView):
        (WTR::PlatformWebView::PlatformWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 5 May 2011 18:22:24 +0000 (18:22 +0000)]
2011-05-05  Adam Barth  <abarth@webkit.org>

        Roll Chromium DEPS.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 5 May 2011 18:17:23 +0000 (18:17 +0000)]
2011-05-05  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adam Roben.

        The preload attribute of the video tag is not completely implemented
        https://bugs.webkit.org/show_bug.cgi?id=43673
        <rdar://problem/9369746>

        This change implements "preload=metadata" for the AVFoundation backend.
        Tested manually with manual-tests/media-elements/video-preload.html.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_havePreparedToPlay.
        (WebCore::HTMLMediaElement::prepareForLoad): Ditto.
        (WebCore::HTMLMediaElement::prepareToPlay): New, tell player to prepare to play.
        (WebCore::HTMLMediaElement::seek): Call prepareToPlay when preload is less than 'auto'
            because we need to have media data loaded to seek.
        (WebCore::HTMLMediaElement::updatePlayState): Call prepareToPlay.
        * html/HTMLMediaElement.h:

        * manual-tests/media-elements/video-preload.html: Make changing urls work.

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
        (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):  Remove
            m_videoFrameHasDrawn and m_delayingLoad as they are no longer used.
        (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): Removed.
        (WebCore::MediaPlayerPrivateAVFoundation::load): Don't initialize m_videoFrameHasDrawn.
            Move all preload logic to setPreload, call it from here.
        (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Move all preload logic to
            setPreload, call it.
        (WebCore::MediaPlayerPrivateAVFoundation::duration): Don't cache duration = 0, it is
            unlikely to be correct and isn't worth caching. Use invalidTime() function.
        (WebCore::MediaPlayerPrivateAVFoundation::seeking): Use invalidTime() function.
        (WebCore::MediaPlayerPrivateAVFoundation::setNaturalSize): Add logging.
        (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Update for name change AVAssetStatus
            to AssetStatus. Always create a AVPlayerItem for live streams because they can't be inspected
            without one. Set networkState to 'idle' when the playback buffer is full because that is
            a signal that AVFoundation won't do any more IO. Set readyState to 'HAVE_CURRENT_DATA'
            when the first frame is available.
        (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Call tracksChanged so we cache
            width, height, hasVideo, etc.
        (WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Use invalidTime() function.
        (WebCore::MediaPlayerPrivateAVFoundation::timeChanged): Ditto.
        (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Ditto.
        (WebCore::MediaPlayerPrivateAVFoundation::repaint): Don't set m_videoFrameHasDrawn, it is done
            in derived classes.
        (WebCore::MediaPlayerPrivateAVFoundation::setPreload): Centralize all logic about when to create
            AVAsset and AVPlayerItem here.
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize
            m_videoFrameHasDrawn.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): New, renamed from
            videoLayerIsReadyToDisplay. Return true if we have a layer with frames available or
            if we have painted a frame to the context.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): New, create the AVAsset
            if necessary.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForCacheResource): Ditto.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Restructure logic.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): New, create AVPlayerItem.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): Correct logging.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): Return "buffer full" when
            the buffer is full.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Get the duration from the
            AVAsset when we haven't allocated the AVPlayerItem yet so that we can return duration
            when we only have metadata.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Update for name change.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Set m_videoFrameHasDrawn.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Get attributes from AVAsset
            when when we haven't allocated the AVPlayerItem yet so that we can report attributes
            when we only have metadata.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): Guard against being called before
            we have allocated the AVPlayerItem.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 5 May 2011 18:14:43 +0000 (18:14 +0000)]
2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Rename SelectionController to FrameSelection
        https://bugs.webkit.org/show_bug.cgi?id=60234

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::selectWordAroundCaret):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::textInputType):
        (WebKit::WebViewImpl::caretOrSelectionBounds):
        (WebKit::WebViewImpl::caretOrSelectionRange):
        (WebKit::WebViewImpl::clearFocusedNode):
2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Rename SelectionController to FrameSelection
        https://bugs.webkit.org/show_bug.cgi?id=60234

        * Api/qwebframe.cpp:
2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Rename SelectionController to FrameSelection
        https://bugs.webkit.org/show_bug.cgi?id=60234

        * webkit/webkitwebview.cpp:
        (getLocationForKeyboardGeneratedContextMenu):
2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Rename SelectionController to FrameSelection
        https://bugs.webkit.org/show_bug.cgi?id=60234

        * WebView.cpp:
2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Rename SelectionController to FrameSelection
        https://bugs.webkit.org/show_bug.cgi?id=60234

        * WebDOMSelection.cpp:
        * WebDOMSelection.h:
        * WebKitSupport/EditorClientWx.cpp:
        * WebView.cpp:
2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Rename SelectionController to FrameSelection
        https://bugs.webkit.org/show_bug.cgi?id=60234

        * WebView/WebFrame.mm:
        (-[WebFrame _rangeByAlteringCurrentSelection:FrameSelection::direction:granularity:]):
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLView.mm:
        * WebView/WebTextCompletionController.mm:
        (-[WebTextCompletionController doCompletion]):
        * WebView/WebView.mm:
2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Rename SelectionController to FrameSelection
        https://bugs.webkit.org/show_bug.cgi?id=60234

        * WebCoreSupport/EditorClientHaiku.cpp:
        (WebCore::EditorClientHaiku::handleKeyboardEvent):
2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Rename SelectionController to FrameSelection
        https://bugs.webkit.org/show_bug.cgi?id=60234

        * WebCoreSupport/EditorClientWinCE.cpp:
        (WebKit::EditorClientWinCE::handleEditingKeyboardEvent):
2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Rename SelectionController to FrameSelection
        https://bugs.webkit.org/show_bug.cgi?id=60234

        * WebCoreSupport/EditorClientEfl.cpp:
        (WebCore::EditorClientEfl::handleEditingKeyboardEvent):
2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Rename SelectionController to FrameSelection
        https://bugs.webkit.org/show_bug.cgi?id=60234

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * accessibility/AccessibilityObject.cpp:
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
        * accessibility/mac/AccessibilityObjectWrapper.mm:
        * bindings/objc/ExceptionHandlers.h:
        * css/CSSStyleSelector.cpp:
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::cloneChildNodes):
        * dom/Document.cpp:
        * dom/InputElement.cpp:
        * editing/DeleteButtonController.cpp:
        * editing/EditCommand.cpp:
        * editing/EditingAllInOne.cpp:
        * editing/EditingStyle.cpp:
        * editing/Editor.cpp:
        (WebCore::Editor::canCopy):
        (WebCore::Editor::canDelete):
        (WebCore::Editor::markMisspellingsAfterTypingToWord):
        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
        (WebCore::Editor::changeSelectionAfterCommand):
        (WebCore::Editor::respondToChangedSelection):
        * editing/Editor.h:
        * editing/EditorCommand.cpp:
        (WebCore::executeDeleteToMark):
        (WebCore::executeMoveBackward):
        (WebCore::executeMoveBackwardAndModifySelection):
        (WebCore::executeMoveDown):
        (WebCore::executeMoveDownAndModifySelection):
        (WebCore::executeMoveForward):
        (WebCore::executeMoveForwardAndModifySelection):
        (WebCore::executeMoveLeft):
        (WebCore::executeMoveLeftAndModifySelection):
        (WebCore::executeMovePageDown):
        (WebCore::executeMovePageDownAndModifySelection):
        (WebCore::executeMovePageUp):
        (WebCore::executeMovePageUpAndModifySelection):
        (WebCore::executeMoveRight):
        (WebCore::executeMoveRightAndModifySelection):
        (WebCore::executeMoveToBeginningOfDocument):
        (WebCore::executeMoveToBeginningOfDocumentAndModifySelection):
        (WebCore::executeMoveToBeginningOfLine):
        (WebCore::executeMoveToBeginningOfLineAndModifySelection):
        (WebCore::executeMoveToBeginningOfParagraph):
        (WebCore::executeMoveToBeginningOfParagraphAndModifySelection):
        (WebCore::executeMoveToBeginningOfSentence):
        (WebCore::executeMoveToBeginningOfSentenceAndModifySelection):
        (WebCore::executeMoveToEndOfDocument):
        (WebCore::executeMoveToEndOfDocumentAndModifySelection):
        (WebCore::executeMoveToEndOfSentence):
        (WebCore::executeMoveToEndOfSentenceAndModifySelection):
        (WebCore::executeMoveToEndOfLine):
        (WebCore::executeMoveToEndOfLineAndModifySelection):
        (WebCore::executeMoveToEndOfParagraph):
        (WebCore::executeMoveToEndOfParagraphAndModifySelection):
        (WebCore::executeMoveParagraphBackwardAndModifySelection):
        (WebCore::executeMoveParagraphForwardAndModifySelection):
        (WebCore::executeMoveUp):
        (WebCore::executeMoveUpAndModifySelection):
        (WebCore::executeMoveWordBackward):
        (WebCore::executeMoveWordBackwardAndModifySelection):
        (WebCore::executeMoveWordForward):
        (WebCore::executeMoveWordForwardAndModifySelection):
        (WebCore::executeMoveWordLeft):
        (WebCore::executeMoveWordLeftAndModifySelection):
        (WebCore::executeMoveWordRight):
        (WebCore::executeMoveWordRightAndModifySelection):
        (WebCore::executeMoveToLeftEndOfLine):
        (WebCore::executeMoveToLeftEndOfLineAndModifySelection):
        (WebCore::executeMoveToRightEndOfLine):
        (WebCore::executeMoveToRightEndOfLineAndModifySelection):
        * editing/FrameSelection.cpp: Copied from Source/WebCore/editing/SelectionController.cpp.
        (WebCore::FrameSelection::FrameSelection):
        (WebCore::FrameSelection::moveTo):
        (WebCore::FrameSelection::setSelection):
        (WebCore::FrameSelection::nodeWillBeRemoved):
        (WebCore::FrameSelection::respondToNodeModification):
        (WebCore::FrameSelection::textWillBeReplaced):
        (WebCore::FrameSelection::setIsDirectional):
        (WebCore::FrameSelection::directionOfEnclosingBlock):
        (WebCore::FrameSelection::willBeModified):
        (WebCore::FrameSelection::positionForPlatform):
        (WebCore::FrameSelection::startForPlatform):
        (WebCore::FrameSelection::endForPlatform):
        (WebCore::FrameSelection::modifyExtendingRight):
        (WebCore::FrameSelection::modifyExtendingForward):
        (WebCore::FrameSelection::modifyMovingRight):
        (WebCore::FrameSelection::modifyMovingForward):
        (WebCore::FrameSelection::modifyExtendingLeft):
        (WebCore::FrameSelection::modifyExtendingBackward):
        (WebCore::FrameSelection::modifyMovingLeft):
        (WebCore::FrameSelection::modifyMovingBackward):
        (WebCore::FrameSelection::modify):
        (WebCore::FrameSelection::xPosForVerticalArrowNavigation):
        (WebCore::FrameSelection::clear):
        (WebCore::FrameSelection::setStart):
        (WebCore::FrameSelection::setEnd):
        (WebCore::FrameSelection::setBase):
        (WebCore::FrameSelection::setExtent):
        (WebCore::FrameSelection::setCaretRectNeedsUpdate):
        (WebCore::FrameSelection::updateCaretRect):
        (WebCore::FrameSelection::caretRenderer):
        (WebCore::FrameSelection::localCaretRect):
        (WebCore::FrameSelection::absoluteBoundsForLocalRect):
        (WebCore::FrameSelection::absoluteCaretBounds):
        (WebCore::FrameSelection::caretRepaintRect):
        (WebCore::FrameSelection::recomputeCaretRect):
        (WebCore::FrameSelection::shouldRepaintCaret):
        (WebCore::FrameSelection::invalidateCaretRect):
        (WebCore::FrameSelection::paintCaret):
        (WebCore::FrameSelection::debugRenderer):
        (WebCore::FrameSelection::contains):
        (WebCore::FrameSelection::selectFrameElementInParentIfFullySelected):
        (WebCore::FrameSelection::selectAll):
        (WebCore::FrameSelection::setSelectedRange):
        (WebCore::FrameSelection::isInPasswordField):
        (WebCore::FrameSelection::caretRendersInsideNode):
        (WebCore::FrameSelection::focusedOrActiveStateChanged):
        (WebCore::FrameSelection::pageActivationChanged):
        (WebCore::FrameSelection::updateSecureKeyboardEntryIfActive):
        (WebCore::FrameSelection::setUseSecureKeyboardEntry):
        (WebCore::FrameSelection::setFocused):
        (WebCore::FrameSelection::isFocusedAndActive):
        (WebCore::FrameSelection::updateAppearance):
        (WebCore::FrameSelection::setCaretVisible):
        (WebCore::FrameSelection::clearCaretRectIfNeeded):
        (WebCore::FrameSelection::caretBlinkTimerFired):
        (WebCore::FrameSelection::notifyRendererOfSelectionChange):
        (WebCore::FrameSelection::setFocusedNodeIfNeeded):
        (WebCore::FrameSelection::paintDragCaret):
        (WebCore::FrameSelection::copyTypingStyle):
        (WebCore::FrameSelection::shouldDeleteSelection):
        (WebCore::FrameSelection::bounds):
        (WebCore::FrameSelection::getClippedVisibleTextRectangles):
        (WebCore::FrameSelection::currentForm):
        (WebCore::FrameSelection::revealSelection):
        (WebCore::FrameSelection::setSelectionFromNone):
        (WebCore::FrameSelection::shouldChangeSelection):
        (WebCore::FrameSelection::formatForDebugger):
        (WebCore::FrameSelection::showTreeForThis):
        (showTree):
        * editing/FrameSelection.h: Copied from Source/WebCore/editing/SelectionController.h.
        (WebCore::FrameSelection::typingStyle):
        (WebCore::FrameSelection::clearTypingStyle):
        (WebCore::FrameSelection::setTypingStyle):
        (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
        * editing/ModifySelectionListLevel.cpp:
        * editing/RemoveFormatCommand.cpp:
        * editing/ReplaceSelectionCommand.cpp:
        * editing/SelectionController.cpp: Removed.
        * editing/SelectionController.h: Removed.
        * editing/SetSelectionCommand.cpp:
        (WebCore::SetSelectionCommand::SetSelectionCommand):
        (WebCore::SetSelectionCommand::doApply):
        (WebCore::SetSelectionCommand::doUnapply):
        * editing/SetSelectionCommand.h:
        (WebCore::SetSelectionCommand::create):
        * editing/SpellingCorrectionCommand.cpp:
        (WebCore::SpellingCorrectionCommand::doApply):
        * editing/SpellingCorrectionController.cpp:
        (WebCore::SpellingCorrectionController::respondToUnappliedSpellCorrection):
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        * editing/chromium/FrameSelectionChromium.cpp: Copied from Source/WebCore/editing/chromium/SelectionControllerChromium.cpp.
        (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
        * editing/chromium/SelectionControllerChromium.cpp: Removed.
        * editing/gtk/FrameSelectionGtk.cpp: Copied from Source/WebCore/editing/gtk/SelectionControllerGtk.cpp.
        (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
        * editing/gtk/SelectionControllerGtk.cpp: Removed.
        * editing/mac/EditorMac.mm:
        (WebCore::Editor::canCopyExcludingStandaloneImages):
        * editing/mac/FrameSelectionMac.mm: Copied from Source/WebCore/editing/mac/SelectionControllerMac.mm.
        (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
        * editing/mac/SelectionControllerMac.mm: Removed.
        * editing/qt/EditorQt.cpp:
        * loader/archive/cf/LegacyWebArchive.cpp:
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::populate):
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::type):
        (WebCore::DOMSelection::modify):
        (WebCore::DOMSelection::addRange):
        (WebCore::DOMSelection::deleteFromDocument):
        (WebCore::DOMSelection::containsNode):
        * page/DragController.cpp:
        (WebCore::DragController::dragIsMove):
        * page/DragController.h:
        * page/EventHandler.cpp:
        (WebCore::setSelectionIfNeeded):
        (WebCore::setNonDirectionalSelectionIfNeeded):
        (WebCore::EventHandler::sendContextMenuEventForKey):
        (WebCore::EventHandler::handleKeyboardSelectionMovement):
        * page/EventHandler.h:
        * page/FocusController.cpp:
        (WebCore::clearSelectionIfNeeded):
        * page/Frame.cpp:
        (WebCore::Frame::Frame):
        * page/Frame.h:
        (WebCore::Frame::selection):
        * page/Page.cpp:
        (WebCore::Page::Page):
        * page/Page.h:
        (WebCore::Page::dragCaretController):
        * page/chromium/DragControllerChromium.cpp:
        * page/chromium/EventHandlerChromium.cpp:
        * page/win/DragControllerWin.cpp:
        * page/win/EventHandlerWin.cpp:
        * rendering/HitTestResult.cpp:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::destroy):
        (WebCore::RenderBlock::paintCaret):
        * rendering/RenderImage.cpp:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::destroy):
        * rendering/RenderLayer.cpp:
        * rendering/RenderListBox.cpp:
        * rendering/RenderObjectChildList.cpp:
        (WebCore::RenderObjectChildList::removeChildNode):
        * rendering/RenderTextControl.cpp:
        * rendering/RenderTextControlSingleLine.cpp:
        * rendering/RenderTheme.cpp:
        * rendering/RenderTreeAsText.cpp:
        * svg/SVGSVGElement.cpp:
        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGTextContentElement::selectSubString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WinCairo] Unreviewed build fix.
bfulgham@webkit.org [Thu, 5 May 2011 18:01:00 +0000 (18:01 +0000)]
[WinCairo] Unreviewed build fix.

* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::cachedResponseDataForURL): Stub out
implementation for cURL networking case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WinCairo] unreviewed build correction.
bfulgham@webkit.org [Thu, 5 May 2011 17:54:15 +0000 (17:54 +0000)]
[WinCairo] unreviewed build correction.

* platform/network/curl/ResourceRequest.h:
Stub out the new pipelined http logic for cURL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 5 May 2011 17:49:53 +0000 (17:49 +0000)]
2011-05-05  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by David Kilzer.

        Add --only-webkit option to build-webkit
        https://bugs.webkit.org/show_bug.cgi?id=60245

        * Scripts/build-webkit: If --only-webkit was specified
        just build the WebKit project, and not its dependencies.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Thu, 5 May 2011 16:57:50 +0000 (16:57 +0000)]
2011-05-05  Jeff Miller  <jeffm@apple.com>

        Reviewed by Darin Adler.

        Add didNotHandleWheelEvent callback to WKPageUIClient
        https://bugs.webkit.org/show_bug.cgi?id=60203

        * MiniBrowser/gtk/BrowserWindow.c:
        (browserWindowUIClientInit): Stub out didNotHandleWheelEvent callback.
        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController awakeFromNib]): Stub out didNotHandleWheelEvent callback.
        * MiniBrowser/win/BrowserView.cpp:
        (BrowserView::create): Stub out didNotHandleWheelEvent callback.
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::createOtherPage): Stub out didNotHandleWheelEvent callback.
        (WTR::TestController::initialize): Stub out didNotHandleWheelEvent callback.
2011-05-05  Jeff Miller  <jeffm@apple.com>

        Reviewed by Darin Adler.

        Add didNotHandleWheelEvent callback to WKPageUIClient
        https://bugs.webkit.org/show_bug.cgi?id=60203

        Remove Windows-specific WebPageProxy::wheelEventNotHandled() member function and use
        didNotHandleWheelEvent callback in WKPageUIClient instead.  It turns out that just
        resending the wheel event to the parent window doesn't provide the client with enough context
        to know that WebKit has already attempted to handle the event.

        * UIProcess/API/C/WKPage.h: Added WKPageDidNotHandleWheelEventCallback typedef and didNotHandleWheelEvent to WKPageUIClient.

        * UIProcess/API/gtk/PageClientImpl.cpp:
        (WebKit::PageClientImpl::didNotHandleWheelEvent): Added, but not implemented.
        * UIProcess/API/gtk/PageClientImpl.h: Added didNotHandleWheelEvent().
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::QWKPage):Stubbed out didNotHandleWheelEvent callback.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didReceiveEvent): Call didNotHandleWheelEvent in WKPageUIClient if wheel event is not handled.
        * UIProcess/WebPageProxy.h: Removed wheelEventNotHandled().

        * UIProcess/WebUIClient.cpp:
        (WebKit::WebUIClient::implementsDidNotHandleWheelEvent): Added.
        (WebKit::WebUIClient::didNotHandleWheelEvent): Added.
        * UIProcess/WebUIClient.h: Added implementsDidNotHandleWheelEvent() and didNotHandleWheelEvent().

        * UIProcess/win/WebPageProxyWin.cpp: Removed wheelEventNotHandled().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 5 May 2011 16:40:14 +0000 (16:40 +0000)]
2011-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Return correct GTK version for NPNVToolkit
        https://bugs.webkit.org/show_bug.cgi?id=60275

        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        (WebKit::NPN_GetValue): Return always 2 for NPNVToolkit in GTK
        platform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 5 May 2011 16:38:33 +0000 (16:38 +0000)]
2011-05-05  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: searching for node does not result in bringToFront call.
        https://bugs.webkit.org/show_bug.cgi?id=60222

        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.updateFocusedNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 5 May 2011 16:07:23 +0000 (16:07 +0000)]
2011-05-05  Adam Barth  <abarth@webkit.org>

        Remove a couple stray mentions of WML that I missed before.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 5 May 2011 16:01:55 +0000 (16:01 +0000)]
2011-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Make native events code more consistent
        https://bugs.webkit.org/show_bug.cgi?id=60258

        Make all other native events code follow the current keyboard
        events approach: use a GOwnPtr for the native event, and use
        const GdkEvent* in the API. We need to implement the copy
        constructors for native events to copy the gdk events with
        gdk_event_copy().

        * Shared/NativeWebMouseEvent.h:
        (WebKit::NativeWebMouseEvent::nativeEvent):
        * Shared/NativeWebWheelEvent.h:
        (WebKit::NativeWebWheelEvent::nativeEvent):
        * Shared/gtk/NativeWebKeyboardEventGtk.cpp:
        (WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent):
        * Shared/gtk/NativeWebMouseEventGtk.cpp:
        (WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
        * Shared/gtk/NativeWebWheelEventGtk.cpp:
        (WebKit::NativeWebWheelEvent::NativeWebWheelEvent):
        * Shared/gtk/WebEventFactory.cpp:
        (WebKit::buttonForEvent):
        (WebKit::WebEventFactory::createWebMouseEvent):
        (WebKit::WebEventFactory::createWebWheelEvent):
        (WebKit::WebEventFactory::createWebKeyboardEvent):
        * Shared/gtk/WebEventFactory.h:
        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (webkitWebViewBaseScrollEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Thu, 5 May 2011 15:44:42 +0000 (15:44 +0000)]
2011-05-05  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Benjamin Poulain.

        [Qt] Make QtWebKit build when using gcc 4.6.0
        https://bugs.webkit.org/show_bug.cgi?id=60265

        If QtWebKit is compiled with gcc 4.6.0 and the build is not done
        with c++0x support we need to deactivate warnings about compatibility.
        Some WebKit types have names which conflicts with upcoming c++0x
        types. If QtWebKit is built with c++0x support, WebKit has code to
        fallback to the standard type rather than the WebKit implementation.
        For example nullptr will be the one of the std if build options turns on
        c++0x support.

        * Source/WebKit.pri:
2011-05-05  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Benjamin Poulain.

        [Qt] Make QtWebKit build when using gcc 4.6.0
        https://bugs.webkit.org/show_bug.cgi?id=60265

        If QtWebKit is compiled with gcc 4.6.0 or later we don't want to deactivate
        the c++0x support because it works.

        * JavaScriptCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 5 May 2011 15:40:18 +0000 (15:40 +0000)]
2011-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Module::load() should return true when g_module_open() returns a valid pointer
        https://bugs.webkit.org/show_bug.cgi?id=60261

        * Platform/gtk/ModuleGtk.cpp:
        (WebKit::Module::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Thu, 5 May 2011 15:20:07 +0000 (15:20 +0000)]
2011-05-05  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Implement the fast font path for Qt.
        https://bugs.webkit.org/show_bug.cgi?id=51106

        Use the new QRawFont and QGlyphs APIs in Qt 4.8 to implement the fast paths for
        rendering and measurement of simple text.

        Since this is still unreleased API, it's guarded by HAVE(QRAWFONT) until the new
        classes are fully integrated into the Qt 4.8 release branch.

        * WebCore.pro: Add HAVE_QRAWFONT define (for Qt >= 4.8) and new files to build.

        * platform/graphics/Font.cpp:
        (WebCore::Font::drawText): Disable fast font path for stroked text, and when
        painting text with a shadow. (Qt-only)
        (WebCore::Font::codePath): Try to use fast font path in more cases.

        * platform/graphics/qt/FontCacheQt.cpp:
        (WebCore::rawFontForCharacters): Helper function, returns a suitable QRawFont
        to use for rendering a given string. Goes through QTextLayout to find the best
        font based on the original QFont query.
        (WebCore::FontCache::getFontDataForCharacters): Implemented using helper above.

        * platform/graphics/qt/FontPlatformData.h:
        (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::rawFont):
        * platform/graphics/qt/FontPlatformDataQt.cpp:
        (WebCore::FontPlatformData::FontPlatformData): Add a QRawFont member to FontPlatformData.

        * platform/graphics/qt/FontQt.cpp:
        (WebCore::fillPenForContext):
        (WebCore::strokePenForContext):
        (WebCore::drawTextCommon): Factored QPen creation out of drawTextCommon
        to share code between complex and simple font rendering paths.
        (WebCore::Font::drawGlyphs): Implemented using QPainter::drawGlyphs().

        * platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
        (WebCore::GlyphPage::fill): Implemented using QRawFont::glyphIndexesForString().

        * platform/graphics/qt/SimpleFontDataQt.cpp:
        (WebCore::SimpleFontData::determinePitch): Return false when using QRawFont since we
        have no way of knowing the pitch.
        (WebCore::SimpleFontData::containsCharacters): Implemented using QRawFont::supportsCharacter().
        (WebCore::SimpleFontData::platformWidthForGlyph): Implemented using QRawFont::advancesForGlyphIndexes().
        (WebCore::SimpleFontData::scaledFontData): Added, based on other ports.
        (WebCore::SimpleFontData::smallCapsFontData): Ditto.
        (WebCore::SimpleFontData::emphasisMarkFontData): Ditto.
        (WebCore::SimpleFontData::platformBoundsForGlyph): Stub.
        (WebCore::SimpleFontData::platformInit): Use QRawFont APIs to retrieve font metrics.
        (WebCore::SimpleFontData::platformCharWidthInit): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Thu, 5 May 2011 14:15:38 +0000 (14:15 +0000)]
2011-05-05  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Skip inspector/console/console-shadow-dom-access.html (crashes in debug)
        https://bugs.webkit.org/show_bug.cgi?id=60266

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Thu, 5 May 2011 14:14:09 +0000 (14:14 +0000)]
2011-05-05  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
        https://bugs.webkit.org/show_bug.cgi?id=60224

        We should use nullptr rather than 0. nullptr will be added in the new C++ standard
        but WebKit already has a nullptr class if there is no c++0x support.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::addUserStyleSheet):
2011-05-05  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
        https://bugs.webkit.org/show_bug.cgi?id=60224

        We should use nullptr rather than 0. nullptr will be added in the new C++ standard
        but WebKit already has a nullptr class if there is no c++0x support.

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::adjustProgressBarStyle):
        (WebCore::RenderThemeQt::adjustSliderTrackStyle):
        (WebCore::RenderThemeQt::adjustSliderThumbStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Thu, 5 May 2011 13:20:24 +0000 (13:20 +0000)]
2011-05-05  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: rename BrowserDebugger to DOMDebugger.

        https://bugs.webkit.org/show_bug.cgi?id=60256
        InspectorBrowserDebuggerAgent => InspectorDOMDebuggerAgent
        browserDebugger => domDebugger

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::inspectedPageDestroyed):
        (WebCore::InspectorAgent::disconnectFrontend):
        * inspector/InspectorAgent.h:
        (WebCore::InspectorAgent::DOMDebuggerAgent):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::connectFrontend):
        * inspector/InspectorDOMDebuggerAgent.cpp: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.cpp.
        (WebCore::InspectorDOMDebuggerAgent::create):
        (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
        (WebCore::InspectorDOMDebuggerAgent::~InspectorDOMDebuggerAgent):
        (WebCore::InspectorDOMDebuggerAgent::debuggerWasEnabled):
        (WebCore::InspectorDOMDebuggerAgent::debuggerWasDisabled):
        (WebCore::InspectorDOMDebuggerAgent::disable):
        (WebCore::InspectorDOMDebuggerAgent::clearFrontend):
        (WebCore::InspectorDOMDebuggerAgent::discardBindings):
        (WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint):
        (WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint):
        (WebCore::InspectorDOMDebuggerAgent::didInsertDOMNode):
        (WebCore::InspectorDOMDebuggerAgent::didRemoveDOMNode):
        (WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
        (WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):
        (WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
        (WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
        (WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
        (WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):
        (WebCore::InspectorDOMDebuggerAgent::hasBreakpoint):
        (WebCore::InspectorDOMDebuggerAgent::updateSubtreeBreakpoints):
        (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
        (WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
        (WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint):
        (WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
        (WebCore::InspectorDOMDebuggerAgent::clear):
        * inspector/InspectorDOMDebuggerAgent.h: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h.
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
        (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
        (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
        * inspector/InstrumentingAgents.h:
        (WebCore::InstrumentingAgents::InstrumentingAgents):
        (WebCore::InstrumentingAgents::inspectorDOMDebuggerAgent):
        (WebCore::InstrumentingAgents::setInspectorDOMDebuggerAgent):
        * inspector/WorkerInspectorController.cpp:
        (WebCore::WorkerInspectorController::connectFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Thu, 5 May 2011 12:14:17 +0000 (12:14 +0000)]
2011-05-04  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add test for shadow DOM access in the console API
        https://bugs.webkit.org/show_bug.cgi?id=60192

        * http/tests/inspector/elements-test.js:
        (initialize_ElementTest.InspectorTest.findNode.processChildren):
        (initialize_ElementTest.InspectorTest.nodeWithId):
        (initialize_ElementTest.InspectorTest.selectNode):
        * inspector/console/console-shadow-dom-access-expected.txt: Added.
        * inspector/console/console-shadow-dom-access.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 5 May 2011 10:58:38 +0000 (10:58 +0000)]
2011-05-05  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK baselines for new tests.

        * platform/gtk/editing/inserting/typing-at-end-of-line-expected.png: Added.
        * platform/gtk/editing/inserting/typing-at-end-of-line-expected.txt: Added.
        * platform/gtk/editing/selection/select-across-readonly-input-1-expected.png: Added.
        * platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt: Added.
        * platform/gtk/editing/selection/select-across-readonly-input-2-expected.png: Added.
        * platform/gtk/editing/selection/select-across-readonly-input-2-expected.txt: Added.
        * platform/gtk/editing/selection/select-across-readonly-input-3-expected.png: Added.
        * platform/gtk/editing/selection/select-across-readonly-input-3-expected.txt: Added.
        * platform/gtk/editing/selection/select-across-readonly-input-4-expected.png: Added.
        * platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt: Added.
        * platform/gtk/editing/selection/select-across-readonly-input-5-expected.png: Added.
        * platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt: Added.
        * platform/gtk/fast/forms/input-placeholder-text-indent-expected.png: Added.
        * platform/gtk/fast/forms/input-placeholder-text-indent-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 5 May 2011 10:41:36 +0000 (10:41 +0000)]
2011-05-04  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: show only Console and Scripts panels in worker inspector front-end
        https://bugs.webkit.org/show_bug.cgi?id=60159

        * inspector/front-end/WorkerManager.js:
        (WebInspector.WorkerManager.isWorkerFrontend):
        * inspector/front-end/inspector.js: show only Scripts and Console panels in the worker inspector front-end.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 5 May 2011 09:17:40 +0000 (09:17 +0000)]
2011-05-05  MORITA Hajime  <morrita@google.com>

        Unreviewed, marking flaky tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 5 May 2011 08:44:12 +0000 (08:44 +0000)]
2011-05-05  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r85817.
        http://trac.webkit.org/changeset/85817

        It looks these lines are mis-skipped.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Thu, 5 May 2011 08:36:27 +0000 (08:36 +0000)]
2011-05-03  Hans Wennborg  <hans@chromium.org>

        Reviewed by Steve Block.

        IndexedDB: Unit tests for LevelDB key coding functions
        https://bugs.webkit.org/show_bug.cgi?id=59692

        Fix some embarrassing bugs uncovered by unit tests.

        No new functionality, but this is now covered by unit tests in the Chromium WebKit port.

        * storage/IDBLevelDBCoding.cpp:
        (WebCore::IDBLevelDBCoding::decodeInt):
        (WebCore::IDBLevelDBCoding::decodeVarInt):
2011-05-03  Hans Wennborg  <hans@chromium.org>

        Reviewed by Steve Block.

        IndexedDB: Unit tests for LevelDB key coding functions
        https://bugs.webkit.org/show_bug.cgi?id=59692

        Add unit tests for the basic key coding functions used by the LevelDB back-end.

        * WebKit.gypi:
        * tests/IDBLevelDBCodingTest.cpp: Added.
        (IDBLevelDBCoding::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 5 May 2011 08:25:33 +0000 (08:25 +0000)]
2011-05-05  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK baselines for new fullscreen test.

        * platform/gtk/fullscreen/full-screen-stacking-context-expected.png: Added.
        * platform/gtk/fullscreen/full-screen-stacking-context-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 5 May 2011 08:12:29 +0000 (08:12 +0000)]
2011-05-05  MORITA Hajime <morrita@google.com>

        Unreviewed, fixed a syntax error on expectations file.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 5 May 2011 07:57:33 +0000 (07:57 +0000)]
2011-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix WebKit2 GTK build after r85808.

        * Shared/NativeWebWheelEvent.h:
        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (webkitWebViewBaseScrollEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 5 May 2011 07:25:26 +0000 (07:25 +0000)]
2011-05-05  MORITA Hajime  <morrita@google.com>

        Unreviewed expectations update for MAC GPU flakiness.
        - video-zoom-controls.html: Added IMAGE
        - media/controls-without-preload.html, media/controls-styling.html, media/controls-strict.html, media/controls-after-reload.html
          Added TEXT
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-05 Young Han Lee <joybro@company100.net>
commit-queue@webkit.org [Thu, 5 May 2011 07:00:38 +0000 (07:00 +0000)]
2011-05-05  Young Han Lee  <joybro@company100.net>

        Reviewed by Csaba Osztrogon√°c.

        [Texmap][Qt] Enable strict OwnPtr for Qt with texmap enabled.
        https://bugs.webkit.org/show_bug.cgi?id=60251

        No new tests. Build fix.

        * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
        (WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 5 May 2011 06:48:08 +0000 (06:48 +0000)]
2011-05-04  MORITA Hajime  <morrita@google.com>

        Unreviewed expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Thu, 5 May 2011 06:41:40 +0000 (06:41 +0000)]
2011-05-04  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Adam Barth.

        Adding a utility class to read a SharedBuffer line by line.
        https://bugs.webkit.org/show_bug.cgi?id=59946

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/SharedBufferCRLFLineReader.cpp: Added.
        * platform/SharedBufferCRLFLineReader.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 5 May 2011 06:32:46 +0000 (06:32 +0000)]
2011-05-04  MORITA Hajime <morrita@google.com>

        r85835 skipped too much. narrowed skipped target.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 5 May 2011 06:29:16 +0000 (06:29 +0000)]
2011-05-04  MORITA Hajime  <morrita@google.com>

        Unreviewed marking failing gpu tests:
        - controls-without-preload.html, controls-after-reload.html, controls-strict.html, controls-styling.html

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 5 May 2011 05:57:51 +0000 (05:57 +0000)]
2011-05-04  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r85788.
        http://trac.webkit.org/changeset/85788
        https://bugs.webkit.org/show_bug.cgi?id=60250

        svg/text/text-block-child-crash.xhtml asserts (Requested by
        Ossy on #webkit).

        * svg/custom/display-table-caption-foreignObject-expected.txt: Removed.
        * svg/custom/display-table-caption-foreignObject.svg: Removed.
        * svg/custom/display-table-caption-inherit-foreignObject-expected.txt: Removed.
        * svg/custom/display-table-caption-inherit-foreignObject.xhtml: Removed.
        * svg/custom/display-table-caption-inherit-text-expected.txt: Removed.
        * svg/custom/display-table-caption-inherit-text.xhtml: Removed.
        * svg/custom/display-table-caption-text-expected.txt: Removed.
        * svg/custom/display-table-caption-text.svg: Removed.
2011-05-04  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r85788.
        http://trac.webkit.org/changeset/85788
        https://bugs.webkit.org/show_bug.cgi?id=60250

        svg/text/text-block-child-crash.xhtml asserts (Requested by
        Ossy on #webkit).

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 5 May 2011 05:43:40 +0000 (05:43 +0000)]
2011-05-04  MORITA Hajime  <morrita@google.com>

        Unreviewed unit test skip (startPostAndWaitOnCondition)
        which fails on Windows 7. See bug 60248 for tracking.

        * tests/CCThreadTest.cpp:
        (WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 5 May 2011 05:04:04 +0000 (05:04 +0000)]
2011-05-04  Ryosuke Niwa  <rniwa@webkit.org>

        GTK build fix attempt after r85823

        * WebCoreSupport/ChromeClientGtk.h:
        (WebKit::ChromeClient::webView):
        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::imContextCommitted):
        (WebKit::imContextPreeditChanged):
        * webkit/webkitwebview.cpp:
        (WebKit::kit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 5 May 2011 04:54:22 +0000 (04:54 +0000)]
2011-05-04  Ryosuke Niwa  <rniwa@webkit.org>

        Windows build fix attempt after r85823

        * WebCoreSupport/WebChromeClient.h:
        (WebChromeClient::webView):
        * WebView.cpp:
        (kit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 5 May 2011 04:43:22 +0000 (04:43 +0000)]
2011-05-04  MORITA Hajime <morrita@google.com>

        Marking at r85822 was not enough. Re-marked it.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 5 May 2011 04:35:06 +0000 (04:35 +0000)]
2011-05-04  MORITA Hajime  <morrita@google.com>

        Unreviewed flaky marking to full-screen-stacking-context.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 5 May 2011 03:55:42 +0000 (03:55 +0000)]
2011-05-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add more missing imports from scm refactor
        https://bugs.webkit.org/show_bug.cgi?id=60239

        * Scripts/webkitpy/common/checkout/scm/git.py:
        * Scripts/webkitpy/common/checkout/scm/svn.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 5 May 2011 03:07:02 +0000 (03:07 +0000)]
2011-05-04  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Make more member functions in EventHandler private
        https://bugs.webkit.org/show_bug.cgi?id=60200

        Reduced the number of public member functions in EventHandler.

        * WebCore.exp.in:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleAutoscroll):
        (WebCore::EventHandler::autoscrollTimerFired):
        (WebCore::EventHandler::stopAutoscrollTimer):
        (WebCore::EventHandler::handleMousePressEvent):
        (WebCore::EventHandler::handleMouseMoveEvent):
        (WebCore::EventHandler::keyEvent):
        (WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):
        * page/EventHandler.h:
        (WebCore::EventHandler::mouseDownMayStartSelect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 James Robinson <jamesr@chromium.org>
commit-queue@webkit.org [Thu, 5 May 2011 03:03:24 +0000 (03:03 +0000)]
2011-05-04  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] REGRESSION(85136): Composited content vanishes when transform-style changes from preserve-3d to flat
        https://bugs.webkit.org/show_bug.cgi?id=60202

        Adds a regression test for composited content changing from transform-style: preserve-3d to flat.

        * compositing/repaint/transform-style-change-expected.png: Added.
        * compositing/repaint/transform-style-change-expected.txt: Added.
        * compositing/repaint/transform-style-change.html: Added.
2011-05-04  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] REGRESSION(85136): Composited content vanishes when transform-style changes from preserve-3d to flat
        https://bugs.webkit.org/show_bug.cgi?id=60202

        In r85136 I accidentally transposed two lines in GraphicsLayerChromium when adding a null check.  This switches
        the order back and adds a regression test.

        Test: compositing/repaint/transform-style-change.html

        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
        (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 5 May 2011 02:42:30 +0000 (02:42 +0000)]
2011-05-04  MORITA Hajime <morrita@google.com>

        Unreviewed expectations update.

        * platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.txt: Added.
        * platform/chromium-win/fullscreen/full-screen-stacking-context-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Cris Neckar <cdn@chromium.org>
cdn@chromium.org [Thu, 5 May 2011 02:36:17 +0000 (02:36 +0000)]
2011-05-04  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Tests whether a style media specifier inside an svg image will crash.
        https://bugs.webkit.org/show_bug.cgi?id=49902

        * fast/media/media-svg-crash-expected.txt: Added.
        * fast/media/media-svg-crash.html: Added.
2011-05-04  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Expose WebView directly through ChromeClient.
        https://bugs.webkit.org/show_bug.cgi?id=49902

        Test: fast/media/media-svg-crash.html

        * loader/EmptyClients.h:
        (WebCore::EmptyChromeClient::webView):
        * page/ChromeClient.h:
        * page/brew/ChromeClientBrew.h:
        (WebCore::ChromeClientBrew::webView):
2011-05-04  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Expose WebView directly through ChromeClient.
        https://bugs.webkit.org/show_bug.cgi?id=49902

        * src/AutoFillPopupMenuClient.cpp:
        (WebKit::AutoFillPopupMenuClient::getWebView):
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::webView):
        * src/ChromeClientImpl.h:
        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::initialize):
        * src/PlatformBridge.cpp:
        (WebCore::toWebWidgetClient):
        * src/StorageNamespaceProxy.cpp:
        (WebCore::StorageNamespace::sessionStorageNamespace):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::fromPage):
2011-05-04  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Expose WebView directly through ChromeClient.
        https://bugs.webkit.org/show_bug.cgi?id=49902

        * WebCoreSupport/ChromeClientEfl.h:
        (WebCore::ChromeClientEfl::webView):
2011-05-04  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Expose WebView directly through ChromeClient.
        https://bugs.webkit.org/show_bug.cgi?id=49902

        * WebCoreSupport/ChromeClientGtk.h:
        (WebKit::ChromeClient::webView):
2011-05-04  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Expose WebView directly through ChromeClient.
        https://bugs.webkit.org/show_bug.cgi?id=49902

        * WebCoreSupport/ChromeClientHaiku.h:
        (WebCore::ChromeClientHaiku::webView):
2011-05-04  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Expose WebView directly through ChromeClient.
        https://bugs.webkit.org/show_bug.cgi?id=49902

        * WebCoreSupport/WebChromeClient.h:
        (WebChromeClient::webView):
        * WebView/WebFrame.mm:
        (kit):
2011-05-04  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Expose WebView directly through ChromeClient.
        https://bugs.webkit.org/show_bug.cgi?id=49902

        * WebCoreSupport/ChromeClientQt.h:
        (WebCore::ChromeClientQt::webView):
2011-05-04  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Expose WebView directly through ChromeClient.
        https://bugs.webkit.org/show_bug.cgi?id=49902

        * WebCoreSupport/WebChromeClient.h:
        (WebChromeClient::webView):
2011-05-04  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Expose WebView directly through ChromeClient.
        https://bugs.webkit.org/show_bug.cgi?id=49902

        * WebCoreSupport/ChromeClientWinCE.h:
        (WebKit::ChromeClientWinCE::webView):
2011-05-04  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Expose WebView directly through ChromeClient.
        https://bugs.webkit.org/show_bug.cgi?id=49902

        * WebKitSupport/ChromeClientWx.h:
        (WebCore::ChromeClientWx::webView):
2011-05-04  Cris Neckar  <cdn@chromium.org>

        Reviewed by Adam Barth.

        Expose WebView directly through ChromeClient.
        https://bugs.webkit.org/show_bug.cgi?id=49902

        * WebProcess/WebCoreSupport/WebChromeClient.h:
        (WebKit::WebChromeClient::webView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 5 May 2011 02:32:18 +0000 (02:32 +0000)]
2011-05-04  MORITA Hajime  <morrita@google.com>

        Unreviewed skipping text-block-child-crash.xhtml

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 5 May 2011 02:24:04 +0000 (02:24 +0000)]
2011-05-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        sheriff-bot is having more exception trouble
        https://bugs.webkit.org/show_bug.cgi?id=60233

        A webpage-forced build was causing SB to throw an exception.
        We've long had this bug, but we just didn't notice it until now.

        In debugging this I found we fetch an absurd amount of data now
        that we use buildbot's json (instead of xmlrpc), so I added
        the filter=1 parameter to reduce it a little.  That required
        me to handle the case where filter=1 would strip
        result=0 in some cases (it's unclear why it does that).

        * Scripts/webkitpy/common/net/buildbot/buildbot.py:
        * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 5 May 2011 02:08:52 +0000 (02:08 +0000)]
2011-05-04  Ojan Vafai  <ojan@chromium.org>

        Commit failing result. It's not clear to me why this test is failing.
        There's nothing platform specific about it, it doesn't depend on the
        system environment and it's not failing on the chromium win7 bot.

        Committing this for now to green the tree.

        * platform/win-7sp0/fast/harness/results-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 5 May 2011 02:07:54 +0000 (02:07 +0000)]
2011-05-04  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fix warnings in webkit.m4 with autoconf 2.68
        https://bugs.webkit.org/show_bug.cgi?id=60189

        Use AC_LANG_SOURCE when passing source code to AC_COMPILE_IFELSE
        to remove warnings.

        * Source/autotools/webkit.m4: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 5 May 2011 01:16:49 +0000 (01:16 +0000)]
2011-05-04  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Darin Adler.

        Unable to Paste After Deleting Text from Input due to -webkit-user-select
        https://bugs.webkit.org/show_bug.cgi?id=60219

        * editing/pasteboard/paste-placeholder-input-expected.txt: Added.
        * editing/pasteboard/paste-placeholder-input.html: Added.

2011-05-04  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Darin Adler.

        Unable to Paste After Deleting Text from Input due to -webkit-user-select
        https://bugs.webkit.org/show_bug.cgi?id=60219

        When deleting all the text inside the input a placeholder <br>
        element was inserted for the selection point. However, when
        pasting, the test run computes the -webkit-user-select for the
        <br> element, instead of what would be the text inside the
        <input> and incorrectly disallows selection and prevented
        the paste.

        Test: editing/pasteboard/paste-placeholder-input.html

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::insertFragmentForTestRendering): skip
        <br> elements above us as those are likely placeholder elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 5 May 2011 00:49:25 +0000 (00:49 +0000)]
2011-05-04  MORITA Hajime  <morrita@google.com>

        Unreviewed marking flaky tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Cris Neckar <cdn@chromium.org>
cdn@chromium.org [Thu, 5 May 2011 00:43:35 +0000 (00:43 +0000)]
2011-05-04  Cris Neckar  <cdn@chromium.org>

        Unreviewed, Adding Cris Neckar as a committer

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>
commit-queue@webkit.org [Thu, 5 May 2011 00:43:01 +0000 (00:43 +0000)]
2011-05-04  Fridrich Strba  <fridrich.strba@bluewin.ch>

        Reviewed by Martin Robinson.

        Windows build of WebKit GTK needs to be able to find SystemInfo.h
        https://bugs.webkit.org/show_bug.cgi?id=60221

        * GNUmakefile.am: add Source/WebCore/platform/win to the paths searched
        for headers, since Source/WebCore/platform/win/SystemInfo.h
        header is needed by Source/WebKit/gtk/webkit/webkitwebsettings.cpp
        on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Thu, 5 May 2011 00:42:19 +0000 (00:42 +0000)]
2011-05-04  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Adding a new layout test for perpendicular layers.
        https://bugs.webkit.org/show_bug.cgi?id=59255

        * platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
        * platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Added.
        * platform/chromium/compositing/perpendicular-layer-sorting.html: Added.
        * platform/chromium/test_expectations.txt:
2011-05-04  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Improve sorting of layers in hierarchies that preserve-3d
        by testing for overlapping regions between layer pairs and doing a
        topological sort to determine the right order.
        https://bugs.webkit.org/show_bug.cgi?id=59255

        Test: platform/chromium/compositing/perpendicular-layer-sorting.html

        * WebCore.gypi:
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/cc/CCLayerImpl.h:
        (WebCore::CCLayerImpl::clearRenderSurface):
        * platform/graphics/chromium/cc/CCLayerSorter.cpp: Added.
        (WebCore::perpProduct):
        (WebCore::innerProduct):
        (WebCore::pointInColinearEdge):
        (WebCore::edgeEdgeTest):
        (WebCore::CCLayerSorter::LayerIntersector::LayerIntersector):
        (WebCore::CCLayerSorter::LayerIntersector::go):
        (WebCore::CCLayerSorter::LayerIntersector::edgeTriangleTest):
        (WebCore::CCLayerSorter::LayerIntersector::triangleTriangleTest):
        (WebCore::CCLayerSorter::LayerIntersector::checkZDiff):
        (WebCore::CCLayerSorter::LayerIntersector::layerZFromProjectedPoint):
        (WebCore::CCLayerSorter::CCLayerSorter):
        (WebCore::CCLayerSorter::checkOverlap):
        (WebCore::CCLayerSorter::createGraphNodes):
        (WebCore::CCLayerSorter::createGraphEdges):
        (WebCore::CCLayerSorter::removeEdgeFromList):
        (WebCore::CCLayerSorter::sort):
        * platform/graphics/chromium/cc/CCLayerSorter.h: Added.
        (WebCore::CCLayerSorter::GraphNode::GraphNode):
        (WebCore::CCLayerSorter::GraphEdge::GraphEdge):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>
commit-queue@webkit.org [Thu, 5 May 2011 00:23:54 +0000 (00:23 +0000)]
2011-05-04  Fridrich Strba  <fridrich.strba@bluewin.ch>

        Reviewed by Geoffrey Garen.

        Port MachineStackMarker.cpp to Windows x64
        https://bugs.webkit.org/show_bug.cgi?id=60216

        * heap/MachineStackMarker.cpp:
        (JSC::getPlatformThreadRegisters): the CONTEXT struct is usable also
        on 64-bit Windows.
        (JSC::otherThreadStackPointer): return the Rsp register on Windows x64.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>
commit-queue@webkit.org [Thu, 5 May 2011 00:09:53 +0000 (00:09 +0000)]
2011-05-04  Fridrich Strba  <fridrich.strba@bluewin.ch>

        Reviewed by Martin Robinson.

        Link libjavascriptcoregtk on Windows with winmm.dll
        https://bugs.webkit.org/show_bug.cgi?id=60215

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-03 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Thu, 5 May 2011 00:07:33 +0000 (00:07 +0000)]
2011-05-03  Jer Noble  <jer.noble@apple.com>

        Reviewed by Antti Koivisto.

        Safari: Video at apple.com cannot play at full screen mode with layout distortion
        https://bugs.webkit.org/show_bug.cgi?id=60140

        * fullscreen/full-screen-stacking-context-expected.txt: Added.
        * fullscreen/full-screen-stacking-context.html: Added.
        * platform/mac/fullscreen/full-screen-stacking-context-expected.png: Added.
2011-05-03  Jer Noble  <jer.noble@apple.com>

        Reviewed by Antti Koivisto.

        Safari: Video at apple.com cannot play at full screen mode with layout distortion
        https://bugs.webkit.org/show_bug.cgi?id=60140

        Because a fullscreen element may be in a stacking context with a lower z-index than
        a sibling stacking context, those higher contexts would sometimes "pop" through the
        full screen renderer. To facilitate eliminating all the stacking contexts aside from
        the full screen renderer, added a new pseudo-class specific to video or audio full
        screen elements. Then, added a new UA rule which resets the z-index and opacities of
        all elements under said pseudo-class to auto and 1 respectively. To facilitate quick
        identity checking of HTMLMediaElements, added isMediaElement() virtual function to
        Element and HTMLMediaElement.

        Test: fullscreen/full-screen-stacking-context.html

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::pseudoId): Support PseudoFullScreenMediaDocument.
        (WebCore::nameToPseudoTypeMap): Support fullScreenMediaDocument.
        (WebCore::CSSSelector::extractPseudoType): Support PseudoFullScreenMediaDocument.
        * css/CSSSelector.h: Add PseudoFullScreenMediaDocument.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Support PseudoFullScreenMediaDocument.
        * css/fullscreen.css:
        (:root:-webkit-full-screen-document:not(:-webkit-full-screen)): Corrected these names,
            which were missing the -webkit prefix.
        (:root:-webkit-full-screen-media-document *:not(-webkit-full-screen)): Added.
        * dom/Element.h:
        (WebCore::Element::isMediaElement): Added, returns false.
        * html/HTMLMediaElement.h:
        (WebCore::HTMLMediaElement::isMediaElement): Added, returns true.
        * rendering/style/RenderStyleConstants.h: Added FULL_SCREEN_MEDIA_DOCUMENT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Thu, 5 May 2011 00:01:11 +0000 (00:01 +0000)]
2011-05-04  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Split findNextLineBreak into a LineBreaker class
        https://bugs.webkit.org/show_bug.cgi?id=60209

        Breaking findNextLineBreak into a new class inside RenderBlock. Currently it's tracking
        nearly no state, but subsequent patches will move some of the local variables used throughout
        the nextLineBreak function into member variables to simplify breaking off helper functions from
        the bloated function.

        No new tests since this is just moving code around.

        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::LineBreaker::LineBreaker):
        (WebCore::RenderBlock::LineBreaker::lineWasHyphenated): Accessor.
        (WebCore::RenderBlock::LineBreaker::positionedObjects): Ditto.
        (WebCore::RenderBlock::LineBreaker::clear): Ditto.
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::layoutRunsAndFloats):
        (WebCore::RenderBlock::LineBreaker::skipTrailingWhitespace):
        (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
        (WebCore::RenderBlock::LineBreaker::reset):
        (WebCore::RenderBlock::LineBreaker::nextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 4 May 2011 23:56:38 +0000 (23:56 +0000)]
2011-05-04  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        [results.html] Hide the entire table if all failures are expected
        https://bugs.webkit.org/show_bug.cgi?id=60225

        If in a port that uses expected results and all failures are expected,
        hide the table as well as the rows when hiding expected failures.

        * fast/harness/resources/results-test.js:
        * fast/harness/results-expected.txt:
        * fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Wed, 4 May 2011 23:49:36 +0000 (23:49 +0000)]
2011-05-04  Jeff Miller  <jeffm@apple.com>

        Reviewed by Darin Adler.

        Send unhandled wheel events to parent window on Windows
        https://bugs.webkit.org/show_bug.cgi?id=60220

        Keep track of wheel events using NativeWebWheelEvent instead of WebWheelEvent in WebPageProxy
        so we can send the native event to the parent window if WebKit doesn't handle it.

        * UIProcess/API/mac/WKView.mm: Use NativeWebWheelEvent instead of WebWheelEvent.

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::wheelEvent): Use NativeWebWheelEvent instead of WebWheelEvent.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::WebPageProxy): Removed initialization of obsolete m_processingWheelEvent member variable.
        (WebKit::coalesceWheelEvents): Use NativeWebWheelEvent instead of WebWheelEvent and add a note that this won't work if we ever enable MERGE_WHEEL_EVENTS.
        (WebKit::WebPageProxy::handleWheelEvent): Use NativeWebWheelEvent instead of WebWheelEvent, keep track of the current event in m_currentlyProcessedWheelEvent.
        (WebKit::WebPageProxy::didReceiveEvent): Call wheelEventNotHandled() on Windows if wheel event is not handled.
        (WebKit::WebPageProxy::processDidCrash): Clear out m_currentlyProcessedWheelEvent.
        * UIProcess/WebPageProxy.h: Change handleWheelEvent() to take a NativeWebWheelEvent, added wheelEventNotHandled() on Windows, remove m_processingWheelEvent, add m_currentlyProcessedWheelEvent.

        * UIProcess/win/WebPageProxyWin.cpp:
        (WebKit::WebPageProxy::wheelEventNotHandled): Added.

        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::onWheelEvent): Use NativeWebWheelEvent instead of WebWheelEvent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Wed, 4 May 2011 23:46:19 +0000 (23:46 +0000)]
2011-05-04  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Port Mozilla's IndexedDB tests: odd result order
        https://bugs.webkit.org/show_bug.cgi?id=60193

        This test uses setTimeout to check that the result property of
        asynchronous requests persists into the setTimeout callback.

        * storage/indexeddb/mozilla/odd-result-order-expected.txt: Added.
        * storage/indexeddb/mozilla/odd-result-order.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 4 May 2011 23:42:02 +0000 (23:42 +0000)]
2011-05-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Add bundle API for making a page paint as the background of another page
        https://bugs.webkit.org/show_bug.cgi?id=60227

        * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
        (WKBundlePageSetUnderlayPage):
        Call WebPage::setUnderlayPage.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::close):
        Null out the underlay page.

        (WebKit::WebPage::layoutIfNeeded):
        Layout the underlay page if necessary.

        (WebKit::WebPage::drawRect):
        Draw the underlay page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Wed, 4 May 2011 23:36:17 +0000 (23:36 +0000)]
2011-05-04  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Test expectations.

        * platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Tomasz Morawski <t.morawski@samsung.com>
commit-queue@webkit.org [Wed, 4 May 2011 23:34:06 +0000 (23:34 +0000)]
2011-05-04  Tomasz Morawski  <t.morawski@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Added error check for _ewk_init_body result.
        https://bugs.webkit.org/show_bug.cgi?id=60149

        The ewk_init function should be failed when _ewk_init_body function
        return false.

        * ewk/ewk_main.cpp:
        (ewk_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Siddharth Mathur <siddharth.mathur@nokia.com>
commit-queue@webkit.org [Wed, 4 May 2011 23:26:32 +0000 (23:26 +0000)]
2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
        https://bugs.webkit.org/show_bug.cgi?id=59462

        * WebProcess.pro: Add Symbian OS capabilities to web process executable. Also enable
        data paging flag and prevent application's icon from showing up in the application grid.
2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
        https://bugs.webkit.org/show_bug.cgi?id=59462

        * MiniBrowser/qt/MiniBrowser.pro: Add Symbian OS capabilities to executable. Also enable data paging.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 4 May 2011 23:22:04 +0000 (23:22 +0000)]
2011-05-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        The testing EWS bots should upload layout-test-results.zip to bugs after failures
        https://bugs.webkit.org/show_bug.cgi?id=60223

        This required sharing a bit of code between the commit-queue
        (which already knew how to do this) and the new EWS testing bots.

        In the process I also cleaned up EWS testing a little and
        removed some dead code from the commit-queue.

        * Scripts/webkitpy/common/config/committervalidator.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>
commit-queue@webkit.org [Wed, 4 May 2011 22:55:51 +0000 (22:55 +0000)]
2011-05-04  Fridrich Strba  <fridrich.strba@bluewin.ch>

        Reviewed by Adam Barth.

        Add COMPILER(MINGW) to the compilers using the Microsoft C Runtime's vsnprintf.
        The vsnprintf is part of Microsoft C runtime used also by MinGW (GCC) toolchain.
        https://bugs.webkit.org/show_bug.cgi?id=58579

        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::XMLDocumentParser::error):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85800 268f45cc-cd09-0410-ab3c-d52691b4dbfc