14 years ago2008-07-02 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Thu, 3 Jul 2008 00:04:19 +0000 (00:04 +0000)]
2008-07-02  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Darin.

        Bug 19776: Number.toExponential() is incorrect for numbers between 0.1 and 1

        Perform the sign check for the exponent on the actual exponent value,
        which is 1 less than the value of decimalPoint, instead of on the value
        of decimalPoint itself.


        * kjs/NumberPrototype.cpp:


        * fast/js/number-toExponential-expected.txt:
        * fast/js/resources/number-toExponential.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-07-02 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 2 Jul 2008 22:50:17 +0000 (22:50 +0000)]
2008-07-02  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Darin.

        <rdar://problem/5951532> JSProfiler: Implement Bottom-Up view (19228)
        - Subclass TreeProfile as I prepare for a HeavyProfile to be comming

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * profiler/Profile.cpp: By default we create a TreeProfile.
        * profiler/Profile.h: Changes to the Profile class to make it amenable
        to be inherited from.
        * profiler/TreeProfile.cpp: Added.
        * profiler/TreeProfile.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try to fix the Windows build
mitz@apple.com [Wed, 2 Jul 2008 22:37:54 +0000 (22:37 +0000)]
    - try to fix the Windows build

        * WebScriptCallFrame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben.
mitz@apple.com [Wed, 2 Jul 2008 22:05:22 +0000 (22:05 +0000)]
    Reviewed by Adam Roben.

        - Windows build fix

        Renamed the ERROR token in the XPath grammar to XPATH_ERROR, because
        the ERROR macro is defined in <wingdi.h>.

        * xml/XPathGrammar.y:
        * xml/XPathParser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-07-02 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 2 Jul 2008 17:40:29 +0000 (17:40 +0000)]
2008-07-02  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Dan.

        Broke CallIdentifier out into its own file. I did this because it's
        going to grow a lot soon and I wanted this to be a separate patch.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * profiler/CallIdentifier.h: Added.
        (KJS::CallIdentifier::operator const char* ):
        * profiler/ProfileNode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Inspired and reviewed by Mark Rowe.
ap@webkit.org [Wed, 2 Jul 2008 12:00:11 +0000 (12:00 +0000)]
    Inspired and reviewed by Mark Rowe.

        Change non-API includes from JavaScriptCore/ to kjs/ and wtf/ to match prevalent style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the Gtk build
hausmann@webkit.org [Wed, 2 Jul 2008 11:42:15 +0000 (11:42 +0000)]
Fix the Gtk build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fixes
vestbo@webkit.org [Wed, 2 Jul 2008 11:28:43 +0000 (11:28 +0000)]
Build fixes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix https://bugs.webkit.org/show_bug.cgi?id=19850
mrowe@apple.com [Wed, 2 Jul 2008 11:18:29 +0000 (11:18 +0000)]
Fix https://bugs.webkit.org/show_bug.cgi?id=19850
Bug 19850: REGRESSION (r34887): SVGEllipseElement-dom-cx-attr.html and SVGEllipseElement-svgdom-cx-prop.html are failing

Rubber-stamped by Oliver Hunt.

Update the coordinates used when clicking to initiate the test so that the test does not fail on Tiger.

* svg/dynamic-updates/resources/SVGEllipseElement-dom-cx-attr.js:
* svg/dynamic-updates/resources/SVGEllipseElement-svgdom-cx-prop.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-07-02 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Wed, 2 Jul 2008 10:08:22 +0000 (10:08 +0000)]
2008-07-02  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Add a test for a situation mentioned in:

        Bug 19523: delete does not work in javascript

        * fast/js/delete-multiple-global-blocks-expected.txt: Added.
        * fast/js/delete-multiple-global-blocks.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
ap@webkit.org [Wed, 2 Jul 2008 09:23:35 +0000 (09:23 +0000)]
    Build fix.

        * plugins/PluginView.cpp:
        * plugins/win/PluginViewWin.cpp:
        Pass false to JSLock and JSLock::DropAllLocks constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Another non-AllInOne build fix.
ap@webkit.org [Wed, 2 Jul 2008 07:57:56 +0000 (07:57 +0000)]
    Another non-AllInOne build fix.

        * kjs/JSGlobalObject.cpp: Include JSLock.h here, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago<rdar://problem/5974306> CanvasRenderingContext2D becomes invalid when source canvas...
oliver@apple.com [Wed, 2 Jul 2008 07:35:27 +0000 (07:35 +0000)]
<rdar://problem/5974306> CanvasRenderingContext2D becomes invalid when source canvas element is collected

Reviewed by Geoff Garen.

In order to fix this we now make the rendering context and the canvas element
share the same reference count, ensuring that references to the rendering
context will force the canvas element to remain live as well.

Test: fast/canvas/canvas-longlived-context.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Non-AllInOne build fix.
ap@webkit.org [Wed, 2 Jul 2008 07:33:38 +0000 (07:33 +0000)]
    Non-AllInOne build fix.

        * kjs/interpreter.cpp: Include JSLock.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap@webkit.org [Wed, 2 Jul 2008 07:00:53 +0000 (07:00 +0000)]
    Reviewed by Darin.

        Disable JSLock for per-thread contexts.

        No change on SunSpider.

        * kjs/JSGlobalData.h:
        * kjs/JSGlobalData.cpp:
        Added isSharedInstance as a better way to tell whether the instance is shared (legacy).

        * kjs/JSLock.cpp:
        * kjs/JSLock.h:
        Made JSLock and JSLock::DropAllLocks constructors take a parameter to decide whether to
        actually lock a mutex, or only to increment recursion count. We cannot turn it into no-op
        if we want to keep existing assertions working.
        Made recursion count per-thread, now that locks may not lock.

        * API/JSBase.cpp:
        (JSEvaluateScript): Take JSLock after casting JSContextRef to ExecState* (which doesn't need
        locking in any case), so that a decision whether to actually lock can be made.
        (JSCheckScriptSyntax): Ditto.
        (JSGarbageCollect): Only lock while collecting the shared heap, not the per-thread one.

        * API/JSObjectRef.cpp:
        (JSClassCreate): Don't lock, as there is no reason to.
        (JSClassRetain): Ditto.
        (JSClassRelease): Ditto.
        (JSPropertyNameArrayRetain): Ditto.
        (JSPropertyNameArrayRelease): Only lock while deleting the array, as that may touch
        identifier table.
        (JSPropertyNameAccumulatorAddName): Adding a string also involves an identifier table
        lookup, and possibly modification.

        * API/JSStringRef.cpp:
        * API/JSStringRefCF.cpp:
        JSStringRef operations other than releasing do not need locking.

        * VM/Machine.cpp: Don't include unused JSLock.h.

        * kjs/CollectorHeapIntrospector.cpp: (KJS::CollectorHeapIntrospector::statistics):
        Don't take the lock for real, as heap introspection pauses the process anyway. It seems that
        the existing code could cause deadlocks.

        * kjs/Shell.cpp:
        The test tool uses a per-thread context, so no real locking is required.

        * kjs/collector.h:
        (KJS::Heap::setGCProtectNeedsLocking): Optionally protect m_protectedValues access with a
        per-heap mutex. This is only needed for WebCore Database code, which violates the "no data
        migration between threads" by using ProtectedPtr on a background thread.
        (KJS::Heap::isShared): Keep a shared flag here, as well.

        * kjs/protect.h:
        ProtectedPtr is ony used from WebCore, so it doesn't need to take JSLock. An assertion in
        Heap::protect/unprotect guards agains possible future unlocked uses of ProtectedPtr in JSC.

        * kjs/collector.cpp:
        (KJS::Heap::Heap): Initialize m_isShared.
        (KJS::Heap::~Heap): No need to lock for real during destruction, but must keep assertions
        in sweep() working.
        (KJS::destroyRegisteredThread): Registered thread list is only accessed for shared heap,
        so locking is always needed here.
        (KJS::Heap::registerThread): Ditto.
        (KJS::Heap::markStackObjectsConservatively): Use m_isShared instead of comparing to a shared
        instance for a small speedup.
        (KJS::Heap::setGCProtectNeedsLocking): Create m_protectedValuesMutex. There is currently no
        way to undo this - and ideally, Database code will be fixed to lo longer require this quirk.
        (KJS::Heap::protect): Take m_protectedValuesMutex (if it exists) while accessing
        (KJS::Heap::unprotect): Ditto.
        (KJS::Heap::markProtectedObjects): Ditto.
        (KJS::Heap::protectedGlobalObjectCount): Ditto.
        (KJS::Heap::protectedObjectCount): Ditto.
        (KJS::Heap::protectedObjectTypeCounts): Ditto.

        * kjs/ustring.cpp:
        * kjs/ustring.h:
        Don't include JSLock.h, which is no longer used here. As a result, an explicit include had
        to be added to many files in JavaScriptGlue, WebCore and WebKit.

        * kjs/JSGlobalObject.cpp:
        * API/JSCallbackConstructor.cpp:
        * API/JSCallbackFunction.cpp:
        * API/JSCallbackObjectFunctions.h:
        * API/JSContextRef.cpp:
        * API/JSValueRef.cpp:
        * JavaScriptCore.exp:
        * kjs/PropertyNameArray.h:
        * kjs/interpreter.cpp:
        Pass a parameter to JSLock/JSLock::DropAllLocks to decide whether the lock needs to be taken.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap@webkit.org [Wed, 2 Jul 2008 06:35:03 +0000 (06:35 +0000)]
    Reviewed by Darin.

        Failed assertion in JavaScriptCore/VM/SegmentedVector.h:82

        Creating a global object with a custom prototype resets it twice (wasteful!).
        So, addStaticGlobals() was called twice, but JSGlobalObject::reset() didn't reset
        the register array.

        * kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset): Call setRegisterArray(0, 0).

        * kjs/JSVariableObject.h: Changed registerArray to OwnArrayPtr. Also, added private copy
        constructor and operator= to ensure that no one attempts to copy this object (for whatever
        reason, I couldn't make Noncopyable work).

        * kjs/JSGlobalObject.h: (KJS::JSGlobalObject::addStaticGlobals): Allocate registerArray
        with new[].

        * kjs/JSVariableObject.cpp:
        (KJS::JSVariableObject::copyRegisterArray): Allocate registerArray with new[].
        (KJS::JSVariableObject::setRegisterArray): Avoid hitting an assertion in OwnArrayPtr when
        "changing" the value from 0 to 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-07-01 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 2 Jul 2008 05:39:23 +0000 (05:39 +0000)]
2008-07-01  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed and/or reordered exception checks in array-style a[n] access.

        SunSpider says 1.4% faster.

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute): No need to check for exceptions before
        calling toString, toNumber and/or get. If the call ends up being observable
        through toString, valueOf, or a getter, we short-circuit it there, instead.
        In the op_del_by_val case, I removed the incorrect comment without actually
        removing the code, since I didn't want to tempt the GCC fates!

        * kjs/JSObject.cpp:
        (KJS::callDefaultValueFunction): Added exception check to prevent
        toString and valueOf functions from observing execution after an exception
        has been thrown. This removes some of the burden of exception checking
        from the machine.

        (KJS::JSObject::defaultValue): Removed redundant exception check here.

        * kjs/PropertySlot.cpp:
        (KJS::PropertySlot::functionGetter): Added exception check to prevent
        getter functions from observing execution after an exception has been
        thrown. This removes some of the burden of exception checking from the

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver Hunt.
mitz@apple.com [Wed, 2 Jul 2008 04:28:11 +0000 (04:28 +0000)]
    Reviewed by Oliver Hunt.

        - fix a CSSParserValueList leak seen on the build bot

        * css/CSSParser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-07-01 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 2 Jul 2008 04:21:43 +0000 (04:21 +0000)]
2008-07-01  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Optimized a[n] get and put for cases where n is an immediate unsigned

        SunSpider says 3.5% faster.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-07-01 Alex Mathews <possessedpenguinbob@gmail.com>
oliver@apple.com [Wed, 2 Jul 2008 03:27:42 +0000 (03:27 +0000)]
2008-07-01  Alex Mathews  <possessedpenguinbob@gmail.com>

Reviewed by Oliver Hunt.

Prep for more Filter class name changes. Added the first few files for
the new Filter architecture to come.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate the path to the configuration file.
mrowe@apple.com [Wed, 2 Jul 2008 02:12:59 +0000 (02:12 +0000)]
Update the path to the configuration file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-07-01 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Wed, 2 Jul 2008 01:08:30 +0000 (01:08 +0000)]
2008-07-01  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Darin.

        Bug 19844: JavaScript Switch statement modifies "this"

        Use a temporary when generating code for switch clauses to avoid
        overwriting 'this' or a local variable.


        * kjs/nodes.cpp:


        * fast/js/codegen-temporaries-expected.txt:
        * fast/js/resources/codegen-temporaries.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Bump version numbers.
sfalken@apple.com [Wed, 2 Jul 2008 00:11:45 +0000 (00:11 +0000)]
    Bump version numbers.

        Reviewed by Mark Rowe.

        * win/tools/scripts/PRODUCTVERSION:
        * win/tools/scripts/VERSION:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoGtk+ build fix.
christian@webkit.org [Wed, 2 Jul 2008 00:08:03 +0000 (00:08 +0000)]
Gtk+ build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
kmccullough@apple.com [Tue, 1 Jul 2008 23:46:05 +0000 (23:46 +0000)]

2008-07-01  Kevin McCullough  <kmccullough@apple.com>

        Build fix.

        * JavaScriptCore.xcodeproj/project.pbxproj:


2008-07-01  Kevin McCullough  <kmccullough@apple.com>

        Build fix.

        * WebView/WebView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca@apple.com [Tue, 1 Jul 2008 23:44:00 +0000 (23:44 +0000)]

2008-07-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Add PluginMainThreadScheduler.{cpp|h} to build.

        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * plugins/PluginMainThreadScheduler.cpp:


2008-07-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Use the PluginMainThreadScheduler, and implement NPN_PluginThreadAsyncCall.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView _createPlugin]):
        Register the plug-in instance.

        (-[WebBaseNetscapePluginView _destroyPlugin]):
        Unegister the plug-in instance.

        * Plugins/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage load]):
        Set NPN_PluginThreadAsyncCall.

        * Plugins/npapi.mm:
        Implement this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Tue, 1 Jul 2008 22:34:44 +0000 (22:34 +0000)]

        Reviewed by Darin Adler.

        - move the method to set the base writing direction from Frame to Editor

        * WebCore.base.exp: Updated.
        * editing/Editor.cpp:
        (WebCore::Editor::setBaseWritingDirection): Changed the parameter to a
        WritingDirection enum value and added the special behavior when the
        focused node is a text field or a text area.
        * editing/Editor.h:
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected): Changed back
        to call the Editor method.
        * page/Frame.cpp: Removed setSelectionBaseWritingDirection().
        * page/Frame.h:


        Reviewed by Darin Adler.

        - WebKit part of moving the method to set the base writing direction from Frame to Editor

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView toggleBaseWritingDirection:]): Changed back to call the
        Editor method.
        (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
        (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-07-01 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 1 Jul 2008 22:21:12 +0000 (22:21 +0000)]
2008-07-01  Darin Adler  <darin@apple.com>

        Reviewed by Oliver.

        - slight tweak of the setHash fix

        * bindings/js/JSLocationCustom.cpp:
        (WebCore::JSLocation::setHash): Use oldRef instead of recomputing url.ref().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
mitz@apple.com [Tue, 1 Jul 2008 22:19:01 +0000 (22:19 +0000)]

        Reviewed by Anders Carlsson.

        - Mac release build fix

        * JavaScriptCore.exp:


        Reviewed by Anders Carlsson.

        - Mac release build fix

        * page/Console.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Tue, 1 Jul 2008 21:20:04 +0000 (21:20 +0000)]
    Reviewed by Anders Carlsson.

        - fix <rdar://problem/6045896> REGRESSION: Leak in WebCore::StringImpl::create

        * css/CSSPrimitiveValue.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-07-01 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 1 Jul 2008 21:11:32 +0000 (21:11 +0000)]
2008-07-01  Sam Weinig  <sam@webkit.org>

        Try and fix mac builds.

        * JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-07-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 1 Jul 2008 21:06:30 +0000 (21:06 +0000)]
2008-07-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Jon.

        Don't add the Mozilla user agent quirk for Flash 10.

        * plugins/win/PluginPackageWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Move data: URL parsing code in HTMLObjectElement to KURL
ddkilzer@apple.com [Tue, 1 Jul 2008 20:06:29 +0000 (20:06 +0000)]
    Move data: URL parsing code in HTMLObjectElement to KURL

        Reviewed by Ada and Darin.

        No test cases added since there is no change in behavior.

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::isImageType): Extracted data: URL
        parsing code into WebCore::mimeTypeFromDataURL() in KURL.cpp.
        * platform/KURL.cpp:
        (WebCore::mimeTypeFromDataURL): Added.
        * platform/KURL.h:
        (WebCore::mimeTypeFromDataURL): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Dave Hyatt.
mitz@apple.com [Tue, 1 Jul 2008 19:08:15 +0000 (19:08 +0000)]
    Reviewed by Dave Hyatt.

        - fix <rdar://problem/6045890> REGRESSION: Leak in WebCore::CSSParser::createFloatingValueList()

        * css/CSSParser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-07-01 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Tue, 1 Jul 2008 19:05:23 +0000 (19:05 +0000)]
2008-07-01  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Brady Eidson.

        Bug 19822: REGRESSION (r30243): setting location.hash to "#" causes a reload

        Change JSLocation::setHash() to not schedule navigation in the case
        where the old fragment is the null String and the new fragment is an
        empty String.


        * bindings/js/JSLocationCustom.cpp:


        * http/tests/loading/location-hash-reload-cycle-expected.txt: Added.
        * http/tests/loading/location-hash-reload-cycle.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 1 Jul 2008 18:31:22 +0000 (18:31 +0000)]
2008-06-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Add PluginMainThreadScheduler, a singleton which is responsible for scheduling plug-in
        callbacks on the main thread. Use this to implement NPN_PluginThreadAsyncCall on Windows.

        * WebCore.vcproj/WebCore.vcproj:
        Add PluginMainThreadScheduler.{cpp|h}

        * plugins/PluginMainThreadScheduler.cpp: Added.
        * plugins/PluginMainThreadScheduler.h: Added.

        * plugins/PluginView.cpp:
        Register with the thread scheduler.

        * plugins/npapi.cpp:
        Call the thread scheduler.

        * plugins/win/PluginPackageWin.cpp:
        Initialize the NPN_PluginThreadAsyncCall callback.

        * plugins/win/PluginViewWin.cpp:
        Unregister with the scheduler. This makes sure that we won't try to deliver callbacks
        after the plug-in has been destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRoll out r34913, as it broke the Windows build due to bad casting
aroben@apple.com [Tue, 1 Jul 2008 18:02:55 +0000 (18:02 +0000)]
Roll out r34913, as it broke the Windows build due to bad casting


        Roll out r34913, as it broke the Windows build due to bad casting

        r34913 introduced code that assigned pointers-to-member from a derived
        class into a base class pointer-to-member type (e.g., assigned a void
        (SVGUseElement::*)() into a void (SVGElement::*)()). This is bad
        because it could allow us to call SVGUseElement member functions on a
        different SVGElement-derived class. MSVC rightly flagged this as an

        Rubberstamped by Anders Carlsson.


        Roll out r34913, as it broke the Windows build due to bad casting

        Rubberstamped by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-07-01 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 1 Jul 2008 17:56:47 +0000 (17:56 +0000)]
2008-07-01  Darin Adler  <darin@apple.com>

        - fix build

        * bindings/scripts/CodeGeneratorJS.pm: Fix warnings that indicate this was
        not working propertly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
mitz@apple.com [Tue, 1 Jul 2008 17:46:35 +0000 (17:46 +0000)]
    Reviewed by Darin Adler.

        - fix <rdar://problem/6045893> REGRESSION: Leak in WebCore::HTMLCanvasElement::createPlatformImage() const

        * html/CanvasRenderingContext2D.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-07-01 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 1 Jul 2008 17:39:46 +0000 (17:39 +0000)]
2008-07-01  Sam Weinig  <sam@webkit.org>

        Fix non-AllInOne builds.

        * kjs/DateMath.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
weinig@apple.com [Tue, 1 Jul 2008 17:32:44 +0000 (17:32 +0000)]

2008-07-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Split JSCell and JSNumberCell class declarations out of JSValue.h

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * VM/JSPropertyNameIterator.h:
        * kjs/AllInOneFile.cpp:
        * kjs/JSCell.cpp: Copied from JavaScriptCore/kjs/JSValue.cpp.
        * kjs/JSCell.h: Copied from JavaScriptCore/kjs/JSValue.h.
        * kjs/JSNumberCell.cpp:
        * kjs/JSNumberCell.h: Copied from JavaScriptCore/kjs/JSValue.h.
        * kjs/JSObject.h:
        * kjs/JSString.cpp:
        * kjs/JSString.h:
        * kjs/JSValue.cpp:
        * kjs/JSValue.h:


2008-07-01  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Split JSCell and JSNumberCell class declarations out of JSValue.h

        * ForwardingHeaders/kjs/JSNumberCell.h: Added.
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/c/c_instance.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago<rdar://problem/6041580> REGRESSION: AX: AXSize of radio buttons is 0,0
cfleizach@apple.com [Tue, 1 Jul 2008 17:27:37 +0000 (17:27 +0000)]
<rdar://problem/6041580> REGRESSION: AX: AXSize of radio buttons is 0,0

Fixed incorrect AXSize of radio buttons and checkboxes when they don't have labels

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-07-01 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 1 Jul 2008 16:42:31 +0000 (16:42 +0000)]
2008-07-01  Anders Carlsson  <andersca@apple.com>

        Build fixes.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * kjs/JSGlobalObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Antti Koivisto.
mitz@apple.com [Tue, 1 Jul 2008 14:40:49 +0000 (14:40 +0000)]
    Reviewed by Antti Koivisto.

        - fix SVG pointer-events layout test failures

        * css/SVGCSSParser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-07-01 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Tue, 1 Jul 2008 14:29:52 +0000 (14:29 +0000)]
2008-07-01  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Don't show the tooltip instantly in the QtLauncher.

        Let the QWebView handle tooltips by itself, so we get
        the expected delay as everywhere else.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Antti.
zimmermann@webkit.org [Tue, 1 Jul 2008 12:21:28 +0000 (12:21 +0000)]
Reviewed by Antti.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=19841
Fix two small problems in the gradient & pattern code.

Added 12 new layout tests: svg/dynamic-updates/SVGLinearGradientElement*.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-07-01 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Tue, 1 Jul 2008 12:15:54 +0000 (12:15 +0000)]
2008-07-01  Simon Hausmann  <hausmann@webkit.org>

        Fix the build, include SVGTransformList.h instead of

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Antti.
ap@webkit.org [Tue, 1 Jul 2008 12:01:38 +0000 (12:01 +0000)]
    Reviewed by Antti.

        <rdar://problem/6033080> REGRESSION: Some CH characters display as garbage on webpage for
        the first time.

        Test: fast/encoding/preload-encoding.html

        * html/PreloadScanner.cpp:
        (WebCore::PreloadScanner::tokenize): Reset charset when entering a tag, not just when
        starting a load.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Antti & Eric.
zimmermann@webkit.org [Tue, 1 Jul 2008 11:33:57 +0000 (11:33 +0000)]
Reviewed by Antti & Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=17779 (SVG 1.1 Errata demands "SVG JavaScript Liveness" support)
SVG Errata states: "All SVG DOM objects that directly correspond to an
attribute, e.g. the SVGAnimatedLength 'ry' in an SVGRectElement, are live. This
means that any changes made to the attribute are immediately reflected in the
corresponding SVG DOM object." (see linked URL on bug report)

Until now only XML -> SVG DOM changes took affect, aka. changing the 'rx' attribute of a <rect>
element resuted in changes when accessing 'rx' through SVG DOM (rx.baseVal.value).

Add a new synchronization layer to handle SVG DOM -> XML changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoClass name changes for SVG Light Effect files.
oliver@apple.com [Tue, 1 Jul 2008 11:10:45 +0000 (11:10 +0000)]
Class name changes for SVG Light Effect files.

Reviewed by Nikolas Zimmermann.

The class names that changed :

SVGLightSource -> LightSource
SVGDistantLightSource -> DistantLightSource
SVGPointLightSource -> PointLightSource
SVGSpotLightSource -> SpotLightSource

Every other file that is changed is just propagating the class name changes to
dependent files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-07-01 Alp Toker <alp@nuanti.com>
alp@webkit.org [Tue, 1 Jul 2008 08:39:30 +0000 (08:39 +0000)]
2008-07-01  Alp Toker  <alp@nuanti.com>

        Rubber-stamped by Holger.

        autotools cleanup: move some GTK+-specific sources from libwebcore to

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver Hunt.
mitz@apple.com [Tue, 1 Jul 2008 08:19:03 +0000 (08:19 +0000)]
    Reviewed by Oliver Hunt.

        - fix the non-SVG build

        * css/CSSValueKeywords.in: Added 'all'.
        * css/SVGCSSValueKeywords.in: Removed 'all'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-07-01 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 1 Jul 2008 07:09:23 +0000 (07:09 +0000)]
2008-07-01  Geoffrey Garen  <ggaren@apple.com>

        Build fix: forgot to check in this file.

        * WebView/WebScriptDebugger.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fixes, include OwnPtr.h and DateInstance.h
hausmann@webkit.org [Tue, 1 Jul 2008 07:07:06 +0000 (07:07 +0000)]
Build fixes, include OwnPtr.h and DateInstance.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-30 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 1 Jul 2008 07:01:51 +0000 (07:01 +0000)]
2008-06-30  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Fixed a global object leak caused by the switch to one register file.

        Don't unconditionally mark the register file, since that logically
        makes all global variables GC roots, even when their global object is
        no longer reachable.

        Instead, make the global object associated with the register file
        responsible for marking the register file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-30 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 1 Jul 2008 05:45:21 +0000 (05:45 +0000)]
2008-06-30  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed the "registerBase" abstraction. Since the register file never
        reallocates, we can keep direct pointers into it, instead of
        <registerBase, offset> tuples.

        SunSpider says 0.8% faster.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adele@apple.com [Tue, 1 Jul 2008 02:49:31 +0000 (02:49 +0000)]

2008-06-30  Adele Peterson  <adele@apple.com>

        Reviewed by Oliver.

        Fix for <rdar://problem/5882050> clicking in hidden close box area of empty searchfield causes mousedown to stop firing

        Test: fast/forms/search-hidden-cancel-button.html

        * html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
          Don't start capturing mouse events if the cancel button isn't visible.  This was causing the button to start but never stop capturing mouse events.


2008-06-30  Adele Peterson  <adele@apple.com>

        Reviewed by Oliver.

        Test for <rdar://problem/5882050> clicking in hidden close box area of empty searchfield causes mousedown to stop firing

        * fast/forms/search-hidden-cancel-button-expected.txt: Added.
        * fast/forms/search-hidden-cancel-button.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix build by adding all (hopefully) the missing includes.
oliver@apple.com [Tue, 1 Jul 2008 02:21:51 +0000 (02:21 +0000)]
Fix build by adding all (hopefully) the missing includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-30 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Tue, 1 Jul 2008 01:56:16 +0000 (01:56 +0000)]
2008-06-30  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Bug 19830: REGRESSION (r34883): Google Reader doesn't show up feed list on sidebar

        Ensure that we do not eliminate a write to a local register when doing
        peephole optimizations.


        * VM/CodeGenerator.cpp:


        * fast/js/codegen-peephole-locals-expected.txt: Added.
        * fast/js/codegen-peephole-locals.html: Added.
        * fast/js/resources/codegen-peephole-locals.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFixing * placement
adele@apple.com [Tue, 1 Jul 2008 01:18:32 +0000 (01:18 +0000)]
Fixing * placement

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
weinig@apple.com [Tue, 1 Jul 2008 01:11:22 +0000 (01:11 +0000)]

2008-06-30  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Darin Alder.

        Split InternalFunction into its own header file.

        * API/JSCallbackFunction.h:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/ArrayConstructor.h:
        * kjs/BooleanConstructor.h:
        * kjs/DateConstructor.h:
        * kjs/ErrorConstructor.h:
        * kjs/FunctionConstructor.h:
        * kjs/FunctionPrototype.h:
        * kjs/InternalFunction.h: Copied from kjs/JSFunction.h.
        * kjs/JSFunction.h:
        * kjs/NativeErrorConstructor.h:
        * kjs/NumberConstructor.h:
        * kjs/ObjectConstructor.h:
        * kjs/RegExpConstructor.h:
        * kjs/StringConstructor.h:
        * profiler/Profiler.cpp:


2008-06-30  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Darin Adler.

        Split InternalFunction into its own header file.

        * ForwardingHeaders/kjs/InternalFunction.h: Added.
        * bridge/runtime_method.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adele@apple.com [Tue, 1 Jul 2008 00:47:01 +0000 (00:47 +0000)]

2008-06-30  Adele Peterson  <adele@apple.com>

        Reviewed by Anders.

        Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas

        Test: editing/selection/select-all-textarea.html

        * dom/Node.cpp:
        (WebCore::Node::shadowAncestorNode): Break out code to find the root of the shadow tree into a new helper function.
        (WebCore::Node::shadowTreeRootNode): Added helper function.
        * dom/Node.h:
        * dom/Range.cpp: (WebCore::Range::shadowTreeRootNode): Added helper function.
        * dom/Range.h:
        * editing/Selection.cpp: (WebCore::Selection::shadowTreeRootNode): ditto.
        * editing/Selection.h:
        * editing/SelectionController.h: (WebCore::SelectionController::shadowTreeRootNode): ditto.
        * editing/SelectionController.cpp: (WebCore::SelectionController::selectAll):
        If the selection is in a shadow tree, only select the contents of that shadow tree, not the whole document.
        * page/Frame.cpp:
        (WebCore::Frame::findString): Use the new shadowTreeRootNode helper functions.
        (WebCore::Frame::markAllMatchesForText): ditto.


2008-06-30  Adele Peterson  <adele@apple.com>

        Reviewed by Anders.

        Test for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas

        * editing/selection/select-all-textarea-expected.txt: Added.
        * editing/selection/select-all-textarea.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago<rdar://problem/4180780> Add attribute to get all the radio buttons in a set
cfleizach@apple.com [Mon, 30 Jun 2008 23:05:44 +0000 (23:05 +0000)]
<rdar://problem/4180780> Add attribute to get all the radio buttons in a set

Adds ability for radio buttons to return an array of the other radio buttons in its radio group.
Updates DumpRenderTree to support the linked ui elements attribute

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-30 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 30 Jun 2008 22:52:55 +0000 (22:52 +0000)]
2008-06-30  Sam Weinig  <sam@webkit.org>

        Reviewed by Kevin McCullough.

        Remove empty files Instruction.cpp, LabelID.cpp, Register.cpp and RegisterID.cpp.

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * VM/Instruction.cpp: Removed.
        * VM/LabelID.cpp: Removed.
        * VM/Register.cpp: Removed.
        * VM/RegisterID.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-30 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 30 Jun 2008 22:43:07 +0000 (22:43 +0000)]
2008-06-30  Sam Weinig  <sam@webkit.org>

        Rubber-stamped (reluctantly) by Kevin McCullough.

        Rename date_object.h/cpp to DateInstance.h/cpp

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * kjs/AllInOneFile.cpp:
        * kjs/DateConstructor.cpp:
        * kjs/DateInstance.cpp: Copied from kjs/date_object.cpp.
        * kjs/DateInstance.h: Copied from kjs/date_object.h.
        * kjs/DatePrototype.cpp:
        * kjs/DatePrototype.h:
        * kjs/date_object.cpp: Removed.
        * kjs/date_object.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Mon, 30 Jun 2008 22:10:08 +0000 (22:10 +0000)]

        Reviewed by Adele Peterson.

        - WebCore part of <rdar://problem/3881497> Writing direction context menu item has no effect on text typed in Safari

        * WebCore.base.exp: Removed Editor::setBaseWritingDirection() and added
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected): Changed to
        call Frame::setSelectionBaseWritingDirection().
        * page/Frame.cpp:
        (WebCore::Frame::setSelectionBaseWritingDirection): Added. If the
        focused node is a text field or text area, changes its 'dir' attribute.
        This is what IE does when the user changes the writing direction in a
        text control. Otherwise, calls down to Editor::setBaseWritingDirection().
        * page/Frame.h:


        Reviewed by Adele Peterson.

        - WebKit/mac part of <rdar://problem/3881497> Writing direction context menu item has no effect on text typed in Safari

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call
        WebCore::Frame::setSelectionBaseWritingDirection() instead of
        (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
        (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Improve HTMLObjectElement data encapsulation
ddkilzer@apple.com [Mon, 30 Jun 2008 21:12:55 +0000 (21:12 +0000)]
    Improve HTMLObjectElement data encapsulation

        Reviewed by Dave Hyatt.

        HTMLObjectElement has some public member variables that should be
        private with accessor methods.

        No test cases added since there is no change in behavior.

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::HTMLObjectElement): Reorder
        initialization of member variables to match defined order in header.
        * html/HTMLObjectElement.h:
        (WebCore::HTMLObjectElement::classId): Added.
        (WebCore::HTMLObjectElement::url): Added.
        (WebCore::HTMLObjectElement::serviceType): Added.
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget): Use new accessor methods
        in HTMLObjectElement now that its member variables are private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Mon, 30 Jun 2008 21:09:14 +0000 (21:09 +0000)]
    Reviewed by Anders Carlsson.

        - remove unused member variable

        * page/Page.h: Removed Page::m_focusedNode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-30 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 30 Jun 2008 20:52:03 +0000 (20:52 +0000)]
2008-06-30  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Darin Adler.

        Remove internal.cpp and move its contents to there own .cpp files.

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * kjs/AllInOneFile.cpp:
        * kjs/GetterSetter.cpp: Copied from kjs/internal.cpp.
        * kjs/InternalFunction.cpp: Copied from kjs/internal.cpp.
        * kjs/JSNumberCell.cpp: Copied from kjs/internal.cpp.
        * kjs/JSString.cpp: Copied from kjs/internal.cpp.
        * kjs/JSString.h:
        * kjs/LabelStack.cpp: Copied from kjs/internal.cpp.
        * kjs/NumberConstructor.cpp:
        * kjs/NumberObject.cpp:
        * kjs/internal.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 30 Jun 2008 17:00:41 +0000 (17:00 +0000)]
2008-06-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Crash when loading manifest from application cache fails

        There is no need to set any handles to 0 after calling cacheUpdateFailed(), since
        that is done inside the function. Furthermore, after calling cacheUpdateFailed() the cache
        group could be deleted causing us to access freed memory and then crashing.

        * loader/appcache/ApplicationCacheGroup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix <rdar://5954749> Assertion failure due to HashTable's use of operator&
aroben@apple.com [Mon, 30 Jun 2008 15:58:27 +0000 (15:58 +0000)]
Fix <rdar://5954749> Assertion failure due to HashTable's use of operator&


        Fix <rdar://5954749> Assertion failure due to HashTable's use of

        HashTable was passing &value to constructDeletedValue, which in
        classes like WebCore::COMPtr would cause an assertion. We now pass
        value by reference instead of by address so that the HashTraits
        implementations have more flexibility in constructing the deleted

        Reviewed by Ada Chan.

        * VM/CodeGenerator.h: Updated for changes to HashTraits.
        * wtf/HashTable.h:
        (WTF::::deleteBucket): Changed to pass bucket by reference instead of
        by address.
        (WTF::::checkKey): Ditto.
        * wtf/HashTraits.h:
        (WTF::): Updated HashTraits for HashTable change.


        Fix <rdar://5954749> Assertion failure due to HashTable's use of

        Reviewed by Ada Chan.

        * bindings/js/JSSVGPODTypeWrapper.h:
        * dom/Document.h:
        * dom/StyledElement.cpp:
        * platform/graphics/FontCache.cpp:
        * platform/graphics/IntSizeHash.h:
        * platform/text/StringHash.h:
        * platform/win/COMPtr.h:
        * svg/SVGAnimatedTemplate.h:
        Updated all custom HashTraits for HashTable changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoVersioning.
mrowe@apple.com [Mon, 30 Jun 2008 15:10:17 +0000 (15:10 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-30 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 30 Jun 2008 11:37:43 +0000 (11:37 +0000)]
2008-06-30  Simon Hausmann  <hausmann@webkit.org>

        Rubber-stamped by Niko.

        Removed the obsolete and unmaintained WebKitPart. The integration of
        QtWebKit into KDE is now done in the webkitkde component inside KDE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Antti.
zimmermann@webkit.org [Mon, 30 Jun 2008 11:28:54 +0000 (11:28 +0000)]
Reviewed by Antti.

Fix all existing tests in svg/dynamic-updates to actually reflect repainting changes, by
removing the timing dependency. Instead model them like frame-getSVGDocument.html by
not including the <script src="js-test-post.js"> element within the TEMPLATE.html but
by dynamically injecting it, if the test actually finished.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Cameron Zwarich.
ap@webkit.org [Mon, 30 Jun 2008 11:21:43 +0000 (11:21 +0000)]
    Reviewed by Cameron Zwarich.

        Make RegisterFile really unmap memory on destruction.

        This fixes run-webkit-tests --threaded, which ran out of address space in a few seconds.

        * VM/RegisterFile.cpp: (KJS::RegisterFile::~RegisterFile): Unmap all the memory, not just
        1/4 of it.

        * kjs/JSGlobalObject.h: Don't include RegisterFile.h, so that changes to it don't make
        half of WebCore rebuild.

        * VM/Machine.h: Don't forward declare RegisterFile, as RegisterFile.h is included already.

        * VM/RegisterFile.h: (KJS::RegisterFile::RegisterFile): Assert that the allocation succeeded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-30 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 30 Jun 2008 09:38:46 +0000 (09:38 +0000)]
2008-06-30  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Rubber-stamped by Oliver.

        Correct the documentation for op_put_by_index.

        * VM/Machine.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-30 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 30 Jun 2008 08:09:28 +0000 (08:09 +0000)]
2008-06-30  Simon Hausmann  <hausmann@webkit.org>

        Fix the Qt build.

        Added missing includes and changed getItem array calls to use get()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 30 Jun 2008 06:17:01 +0000 (06:17 +0000)]
2008-06-29  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Bug 19821: Merge the instruction pair (less, jfalse)

        This is a 2.4% win on SunSpider. I needed to add an ALWAYS_INLINE
        intrinisc to CodeGenerator::rewindBinaryOp() to avoid a massive
        regression in regexp-dna.

        * VM/CodeBlock.cpp:
        * VM/CodeGenerator.cpp:
        * VM/Machine.cpp:
        * VM/Opcode.cpp:
        * VM/Opcode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-29 David Smith <catfish.man@gmail.com>
dsmith@webkit.org [Mon, 30 Jun 2008 02:07:37 +0000 (02:07 +0000)]
2008-06-29  David Smith  <catfish.man@gmail.com>

        Rubberstamped by Sam Weinig.

        Change a redundant node->isElement() check to an ASSERT for a 1.3% speedup on getElementsByTagName.

        * dom/TagNodeList.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
mitz@apple.com [Mon, 30 Jun 2008 01:41:41 +0000 (01:41 +0000)]
    Reviewed by Darin Adler.

        - fix SVG layout test regressions

        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::addFontFaceRule): Made this function work
        again with primitive values, because the @font-face rules SVG fonts
        create still use a single primitive value rather than a value list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-29 Dan Bernstein <mitz@apple.com>
mitz@apple.com [Mon, 30 Jun 2008 00:58:11 +0000 (00:58 +0000)]
2008-06-29  Dan Bernstein  <mitz@apple.com>

        - add a missing file from the last check-in

        * fast/css/resources/font-face-descriptor-multiple-values-parsing.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Mon, 30 Jun 2008 00:31:32 +0000 (00:31 +0000)]

        Reviewed by Sam Weinig.

        - fix <rdar://problem/5734440> Specifying a font-weight for @font-face not working

        Tests: fast/css/font-face-descriptor-multiple-values-parsing.html

        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::addFontFaceRule): Changed to work with value
        lists for the descriptor properties.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser): Initialize m_hasFontFaceOnlyValues.
        (WebCore::CSSParser::parseValue): Added a call to
        deleteFontFaceOnlyValues() if necessary.
        (WebCore::CSSParser::parseDeclaration): Ditto.
        (WebCore::CSSParser::clearProperties): Added code to reset
        m_hasFontFaceOnlyValues to false.
        (WebCore::CSSParser::parseFontStyle): Added. If there is a single
        valid identifier other than 'all', creates a CSSPrimitiveValue and
        assigns it to the property. If 'all' is the only value, or if there are
        multiple valid identifiers that are not 'all', creates a CSSValueList
        and assigns it to the property, and sets m_hasFontFaceOnlyValues to
        (WebCore::CSSParser::parseFontVariant): Ditto.
        (WebCore::CSSParser::parseFontWeight): Ditto.
        (WebCore::CSSParser::createStyleRule): Added a call to
        (WebCore::CSSParser::createFontFaceRule): Added code to change
        font descriptor properties that had only one value, and therefore were
        assigned a CSSPrimitiveValue, into CSSValueLists containing that value.
        (WebCore::CSSParser::deleteFontFaceOnlyValues): Added. Retroactively
        invalidates font descriptor properties that had values that are only
        allowed in @font-face. Those are identified by having CSSValueLists
        rather than CSSPrimitiveValues as their values.
        * css/CSSParser.h: Added m_hasFontFaceOnlyValues, a flag that says that
        font descriptor property values that are only valid in @font-face were
        encountered. This is used when the style declaration is created (and we
        finally know if it is @font-face or not) to delete invalid properties
        if needed.


        Reviewed by Sam Weinig.

        - tests for <rdar://problem/5734440> Specifying a font-weight for @font-face not working

        * fast/css/font-face-descriptor-multiple-values-parsing-expected.txt: Added.
        * fast/css/font-face-descriptor-multiple-values-parsing.html: Added.
        * fast/css/font-face-descriptor-multiple-values.html: Added.
        * platform/mac/fast/css/font-face-descriptor-multiple-values-expected.checksum: Added.
        * platform/mac/fast/css/font-face-descriptor-multiple-values-expected.png: Added.
        * platform/mac/fast/css/font-face-descriptor-multiple-values-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-29 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 29 Jun 2008 22:22:32 +0000 (22:22 +0000)]
2008-06-29  Sam Weinig  <sam@webkit.org>

        Fix non-AllInOne builds.

        * kjs/JSObject.cpp:
        * kjs/JSValue.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-29 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 29 Jun 2008 22:18:38 +0000 (22:18 +0000)]
2008-06-29  Sam Weinig  <sam@webkit.org>

        Build fix for Qt.

        * kjs/DateMath.cpp:
        * kjs/DatePrototype.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-29 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 29 Jun 2008 22:14:57 +0000 (22:14 +0000)]
2008-06-29  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Cameron Zwarich.

        Splits ErrorConstructor, ErrorPrototype,  NativeErrorConstructor and
        NativeErrorPrototype out of error_object.h/cpp and renames it ErrorInstance.

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * kjs/AllInOneFile.cpp:
        * kjs/ArrayConstructor.cpp:
        * kjs/ArrayPrototype.cpp:
        * kjs/BooleanPrototype.cpp:
        * kjs/DatePrototype.cpp:
        * kjs/ErrorConstructor.cpp: Copied from kjs/error_object.cpp.
        * kjs/ErrorConstructor.h: Copied from kjs/error_object.h.
        * kjs/ErrorInstance.cpp: Copied from kjs/error_object.cpp.
        * kjs/ErrorInstance.h: Copied from kjs/error_object.h.
        * kjs/ErrorPrototype.cpp: Copied from kjs/error_object.cpp.
        * kjs/ErrorPrototype.h: Copied from kjs/error_object.h.
        * kjs/JSGlobalObject.cpp:
        * kjs/JSObject.cpp:
        * kjs/JSValue.cpp:
        * kjs/NativeErrorConstructor.cpp: Copied from kjs/error_object.cpp.
        * kjs/NativeErrorConstructor.h: Copied from kjs/error_object.h.
        * kjs/NativeErrorPrototype.cpp: Copied from kjs/error_object.cpp.
        * kjs/NativeErrorPrototype.h: Copied from kjs/error_object.h.
        * kjs/NumberPrototype.cpp:
        * kjs/RegExpConstructor.cpp:
        * kjs/RegExpObject.cpp:
        * kjs/RegExpPrototype.cpp:
        * kjs/StringPrototype.cpp:
        * kjs/error_object.cpp: Removed.
        * kjs/error_object.h: Removed.
        * kjs/internal.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-29 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 29 Jun 2008 20:25:04 +0000 (20:25 +0000)]
2008-06-29  Sam Weinig  <sam@webkit.org>

        Fix Tiger build.

        * DumpRenderTree/mac/EventSendingController.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-29 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 29 Jun 2008 20:21:04 +0000 (20:21 +0000)]
2008-06-29  Sam Weinig  <sam@webkit.org>

        Fix non-AllInOne build.

        * kjs/DateConstructor.cpp:
        * kjs/DateMath.cpp:
        * kjs/JSObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-29 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 29 Jun 2008 19:53:42 +0000 (19:53 +0000)]
2008-06-29  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Oliver Hunt.

        Splits DateConstructor and DatePrototype out of date_object.h/cpp
        Moves shared Date code into DateMath.

        * DerivedSources.make:
        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * kjs/AllInOneFile.cpp:
        * kjs/DateConstructor.cpp: Copied from kjs/date_object.cpp.
        * kjs/DateConstructor.h: Copied from kjs/date_object.h.
        * kjs/DateMath.cpp:
        * kjs/DateMath.h:
        * kjs/DatePrototype.cpp: Copied from kjs/date_object.cpp.
        * kjs/DatePrototype.h: Copied from kjs/date_object.h.
        * kjs/JSGlobalObject.cpp:
        * kjs/JSObject.cpp:
        * kjs/date_object.cpp:
        * kjs/date_object.h:
        * kjs/internal.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by darin.
eric@webkit.org [Sun, 29 Jun 2008 19:24:59 +0000 (19:24 +0000)]
    Reviewed by darin.

        Add multi-button mouseevent support to DRT

        It's now possible to specify the mouse button with:
        eventSender.mouseDown(1); eventSender.mouseUp(1); etc.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/mac/EventSendingController.h:
        * DumpRenderTree/mac/EventSendingController.mm:
        (+[EventSendingController isSelectorExcludedFromWebScript:]):
        (+[EventSendingController webScriptNameForSelector:]):
        (-[EventSendingController updateClickCountForButton:]):
        (-[EventSendingController mouseDown:]):
        (-[EventSendingController mouseUp:]):
        (-[EventSendingController mouseMoveToX:Y:]):
        (-[EventSendingController contextClick]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-29 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 29 Jun 2008 08:19:00 +0000 (08:19 +0000)]
2008-06-29  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Rubber-stamped by Cameron Zwarich

        Fix Gtk non-AllInOne build

        * GNUmakefile.am: include JSVariableObject.cpp
        * kjs/RegExpConstructor.cpp: include RegExpObject.h
        * kjs/RegExpObject.h: forward declare RegExpPrototype

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-28 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 Jun 2008 05:56:53 +0000 (05:56 +0000)]
2008-06-28  Darin Adler  <darin@apple.com>

        - fix build

        * WebView/WebView.mm:
        (aeDescFromJSValue): Use get instead of getItem, which no longer exists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin@apple.com [Sun, 29 Jun 2008 05:38:37 +0000 (05:38 +0000)]

2008-06-28  Darin Adler  <darin@apple.com>

        Reviewed by Sam and Cameron.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19805
          Array.concat turns missing array elements into "undefined"

        Test: fast/js/array-holes.html

        * JavaScriptCore.exp: No longer export JSArray::getItem.

        * kjs/ArrayPrototype.cpp:
        (KJS::arrayProtoFuncConcat): Changed to use getProperty instead of
        JSArray::getItem -- need to handle properties from the prototype chain
        instead of ignoring them.

        * kjs/JSArray.cpp: Removed getItem.
        * kjs/JSArray.h: Ditto.


2008-06-28  Darin Adler  <darin@apple.com>

        Reviewed by Sam and Cameron.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19805
          Array.concat turns missing array elements into "undefined"

        * bridge/jni/jni_utility.cpp:
        Use get instead of getItem, since we always want to consider values from the
        prototypes when looking at JavaScript arrays.


2008-06-28  Darin Adler  <darin@apple.com>

        Reviewed by Sam and Cameron.

        - test for https://bugs.webkit.org/show_bug.cgi?id=19805
          Array.concat turns missing array elements into "undefined"

        * fast/js/array-holes-expected.txt: Added.
        * fast/js/array-holes.html: Added.
        * fast/js/resources/array-holes.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-28 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 Jun 2008 03:56:04 +0000 (03:56 +0000)]
2008-06-28  Darin Adler  <darin@apple.com>

        Reviewed by Cameron.

        - https://bugs.webkit.org/show_bug.cgi?id=19804
          optimize access to arrays without "holes"

        SunSpider says 1.8% faster.

        * kjs/JSArray.cpp:
        (KJS::JSArray::JSArray): Initialize m_fastAccessCutoff when creating
        arrays. Also updated for new location of m_vectorLength.
        (KJS::JSArray::getItem): Updated for new location of m_vectorLength.
        (KJS::JSArray::getSlowCase): Added. Broke out the non-hot parts of
        getOwnPropertySlot to make the hot part faster.
        (KJS::JSArray::getOwnPropertySlot): Added a new faster case for
        indices lower than m_fastAccessCutoff. We can do theese with no
        additional checks or branches.
        (KJS::JSArray::put): Added a new faster case for indices lower than
        m_fastAccessCutoff. We can do theese with no additional checks or
        branches. Moved the maxArrayIndex handling out of this function.
        Added code to set m_fastAccessCutoff when the very last hole in
        an array is filled; this is how the cutoff gets set for most arrays.
        (KJS::JSArray::putSlowCase): Moved the rest of the put function logic
        in here, to make the hot part of the put function faster.
        (KJS::JSArray::deleteProperty): Added code to lower m_fastAccessCutoff
        when a delete makes a new hole in the array.
        (KJS::JSArray::getPropertyNames): Updated for new location of
        (KJS::JSArray::increaseVectorLength): Ditto.
        (KJS::JSArray::setLength): Added code to lower m_fastAccessCutoff
        when setLength makes the array smaller.
        (KJS::JSArray::mark): Updated for new location of m_vectorLength.
        (KJS::JSArray::sort): Ditto. Set m_fastAccessCutoff after moving
        all the holes to the end of the array.
        (KJS::JSArray::compactForSorting): Ditto.
        (KJS::JSArray::checkConsistency): Added consistency checks fro
        m_fastAccessCutoff and updated for the new location of m_vectorLength.

        * kjs/JSArray.h: Added declarations for slow case functions.
        Replaced m_vectorLength with m_fastAccessCutoff.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sun, 29 Jun 2008 02:33:36 +0000 (02:33 +0000)]
2008-06-28  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Sam.

        When executing a native call, check for an exception before writing the
        return value.


        * VM/Machine.cpp:


        * fast/js/exception-sequencing-expected.txt:
        * fast/js/exception-sequencing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-28 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Sun, 29 Jun 2008 02:21:44 +0000 (02:21 +0000)]
2008-06-28  Mark Rowe  <mrowe@apple.com>

        Build fix.  Flag headers as private or public as is appropriate.
        These settings were accidentally removed during some project file cleanup.

        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
mitz@apple.com [Sun, 29 Jun 2008 00:44:18 +0000 (00:44 +0000)]
    Reviewed by Darin Adler.

        - allow document markers to touch or overlap if they are not of the same type

        Cannot be tested in DumpRenderTree

        * dom/Document.cpp:
        * rendering/InlineTextBox.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-28 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 29 Jun 2008 00:09:26 +0000 (00:09 +0000)]
2008-06-28  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Darin Adler.

        Splits RegExpConstructor and RegExpPrototype out of RegExpObject.h/cpp

        * DerivedSources.make:
        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * VM/Machine.cpp:
        * kjs/AllInOneFile.cpp:
        * kjs/JSGlobalObject.cpp:
        * kjs/RegExpConstructor.cpp: Copied from kjs/RegExpObject.cpp.
        * kjs/RegExpConstructor.h: Copied from kjs/RegExpObject.h.
        * kjs/RegExpObject.cpp:
        * kjs/RegExpObject.h:
        * kjs/RegExpPrototype.cpp: Copied from kjs/RegExpObject.cpp.
        * kjs/RegExpPrototype.h: Copied from kjs/RegExpObject.h.
        * kjs/StringPrototype.cpp:
        * kjs/internal.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-28 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 28 Jun 2008 23:44:15 +0000 (23:44 +0000)]
2008-06-28  Sam Weinig  <sam@webkit.org>

        Fix non-AllInOne builds.

        * kjs/StringConstructor.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
weinig@apple.com [Sat, 28 Jun 2008 23:30:55 +0000 (23:30 +0000)]

2008-06-28  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Darin Adler.

        Rename string_object.h/cpp to StringObject.h/cpp and split out StringObjectThatMasqueradesAsUndefined,
        StringConstructor and StringPrototype.

        * DerivedSources.make:
        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * kjs/AllInOneFile.cpp:
        * kjs/JSGlobalObject.cpp:
        * kjs/StringConstructor.cpp: Copied from JavaScriptCore/kjs/string_object.cpp.
        * kjs/StringConstructor.h: Copied from JavaScriptCore/kjs/string_object.h.
        * kjs/StringObject.cpp: Copied from JavaScriptCore/kjs/string_object.cpp.
        * kjs/StringObject.h: Copied from JavaScriptCore/kjs/string_object.h.
        * kjs/StringObjectThatMasqueradesAsUndefined.h: Copied from JavaScriptCore/kjs/string_object.h.
        * kjs/StringPrototype.cpp: Copied from JavaScriptCore/kjs/string_object.cpp.
        * kjs/StringPrototype.h: Copied from JavaScriptCore/kjs/string_object.h.
        * kjs/internal.cpp:
        * kjs/string_object.cpp: Removed.
        * kjs/string_object.h: Removed.


2008-06-28  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Darin Adler.

        Update includes after remaming string_object.h to StringObject.h and
        splitting out StringObjectThatMasqueradesAsUndefined, StringConstructor
        and StringPrototype.

        * ForwardingHeaders/kjs/StringObject.h: Copied from WebCore/ForwardingHeaders/kjs/string_object.h.
        * ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h: Added.
        * ForwardingHeaders/kjs/StringPrototype.h: Added.
        * ForwardingHeaders/kjs/string_object.h: Removed.
        * bindings/js/JSCSSStyleDeclarationCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-06-28 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 28 Jun 2008 22:57:54 +0000 (22:57 +0000)]
2008-06-28  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix: JSVariableObject is now part of AllInOne

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34860 268f45cc-cd09-0410-ab3c-d52691b4dbfc