WebKit-https.git
9 years agoMade Table tests for Bug 70678 Platform Independent
fsamuel@chromium.org [Tue, 25 Oct 2011 23:42:57 +0000 (23:42 +0000)]
Made Table tests for Bug 70678 Platform Independent
https://bugs.webkit.org/show_bug.cgi?id=70850

Reviewed by Adam Barth.

* fast/table/table-anonymous-cell-bug-expected.png: Added.
* fast/table/table-anonymous-cell-bug-expected.txt:
* fast/table/table-anonymous-cell-bug.html:
* fast/table/table-anonymous-row-bug-expected.png: Added.
* fast/table/table-anonymous-row-bug-expected.txt:
* fast/table/table-anonymous-row-bug.html:
* fast/table/table-anonymous-section-bug-expected.png: Added.
* fast/table/table-anonymous-section-bug-expected.txt:
* fast/table/table-anonymous-section-bug.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAttempt to fix the Windows build. Windows mashes all these files into
abarth@webkit.org [Tue, 25 Oct 2011 23:39:28 +0000 (23:39 +0000)]
Attempt to fix the Windows build.  Windows mashes all these files into
one, which doesn't respect the compilation unit rules of C++.

* bindings/js/JSEventCustom.cpp:
* bindings/js/JSEventTarget.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd WKBrowsingContextLoadDelegateTest test for a failed load
weinig@apple.com [Tue, 25 Oct 2011 23:19:00 +0000 (23:19 +0000)]
Add WKBrowsingContextLoadDelegateTest test for a failed load
https://bugs.webkit.org/show_bug.cgi?id=70859

Reviewed by Anders Carlsson.

* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
(TEST_F): Add TEST_F(WKBrowsingContextLoadDelegateTest, SimpleLoadFail).

(-[SimpleLoadFailDelegate browsingContextControllerDidFailProvisionalLoad:withError:]):
Test that we are getting the correct NSError code and domain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMoving to the start of line should not place the caret outside of the table
rniwa@webkit.org [Tue, 25 Oct 2011 23:17:59 +0000 (23:17 +0000)]
Moving to the start of line should not place the caret outside of the table
https://bugs.webkit.org/show_bug.cgi?id=70757

Reviewed by Chang Shu.

Source/WebCore:

The bug was caused by positionAvoidingFirstPositionInTable. Get rid of the function.

Test: editing/selection/table-lineboundary.html

* editing/visible_units.cpp:
(WebCore::startPositionForLine):

LayoutTests:

Added a test to move the caret to lineboundaries in the first and the last table cell.
The caret should remain inside a table cell.

* editing/selection/table-lineboundary-expected.txt: Added.
* editing/selection/table-lineboundary.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJS Test Harness: Make successfullyParsed optional
arv@chromium.org [Tue, 25 Oct 2011 23:10:43 +0000 (23:10 +0000)]
JS Test Harness: Make successfullyParsed optional
https://bugs.webkit.org/show_bug.cgi?id=70784

Reviewed by Ojan Vafai.

Tools:

* Scripts/make-new-script-test:
(writeTestFile): Update the template for script tests.

LayoutTests:

This makes "successfullyParsed = true" optional in favor of tracking syntax errors
using window.onerror.

* fast/*: Remove successfullyParsed.
* fast/dom/Window/new-window-opener.html: Cleanup.
* fast/dom/Window/resources/window-appendages-cleared-results.html:
* fast/dom/Window/webkitConvertPoint.html: Ditto.
* fast/dom/Window/webkitConvertPointUpdateLayout.html: Ditto.
* fast/js/kde/evil-n.html: This is now a normal test since it is not supposed to fail.
* fast/js/kde/garbage-n-expected.txt:
* fast/js/kde/garbage-n.html: Use shouldHaveHadError instead of js-test-post-n.js
* fast/js/kde/string-1-n.html: Ditto.
* fast/js/kde/string-2-n.html: Ditto.
* fast/js/resources/js-test-post-async.js: Ensure we didn't get an error.
* fast/js/resources/js-test-post-function.js: Ditto.
* fast/js/resources/js-test-post-n.js: Removed.
* fast/js/resources/js-test-pre.js: Added shouldHaveHadError function that can be used to assert that the
                                    error message is what was expected.
                                    Ensure we didn't get an error in finistJSTest.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=70852
bdakin@apple.com [Tue, 25 Oct 2011 23:10:12 +0000 (23:10 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=70852
Setting up a HiDPI base-level GraphicsContext should be more straightforward for
WebKit2

Reviewed by Dan Bernstein.

Source/WebCore:

This patch removes the old cg-only GraphicsContext::setBaseCTM() api, and adds
platform-independent GraphicsContext::applyDeviceScaleFactor().
* WebCore.exp.in:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):
(WebCore::GraphicsContext::applyDeviceScaleFactor):
* platform/graphics/GraphicsContext.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):

Since this patch removes GraphicsContext::setBaseCTM(), this code has been
reverted to do what it used to do before that was added; it just calls into
WebCoreSystemInterface directly.
* platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):

Source/WebKit2:

When we need a base-level HiDPI GraphicsContext, call into new GraphicsContext api
GraphicsContext::applyDeviceScaleFactor() rather than manually scaling and
adjusting the base CTM.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::scaledSnapshotInDocumentCoordinates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSeparate out function linking & exception check data structures.
barraclough@apple.com [Tue, 25 Oct 2011 23:06:13 +0000 (23:06 +0000)]
Separate out function linking & exception check data structures.
https://bugs.webkit.org/show_bug.cgi?id=70858

Reviewed by Oliver Hunt.

This will make it easier to refactor the callOperation methods to spilt the value
representation specific handling from the cpu/calling-convention implementation.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::appendCallWithExceptionCheck):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(JSC::DFG::CallLinkRecord::CallLinkRecord):
(JSC::DFG::CallExceptionRecord::CallExceptionRecord):
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::notifyCall):
(JSC::DFG::JITCompiler::appendCall):
(JSC::DFG::JITCompiler::addExceptionCheck):
(JSC::DFG::JITCompiler::addFastExceptionCheck):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore gardening.
jchaffraix@webkit.org [Tue, 25 Oct 2011 23:02:53 +0000 (23:02 +0000)]
More gardening.

* platform/chromium/test_expectations.txt: Missed some cases where
video-porter.html times out. Also added zoom-animator-scale-test2.html
that has been timing out for several days.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Plug-ins have to use JavaScript to find out the current device scale...
andersca@apple.com [Tue, 25 Oct 2011 23:00:37 +0000 (23:00 +0000)]
Source/WebCore: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225

Reviewed by Darin Adler.

Test: platform/mac-wk2/plugins/contents-scale-factor.html

Add NPNVcontentsScaleFactor, as per https://wiki.mozilla.org/NPAPI:ContentsScaleFactor.

* plugins/npapi.h:

Source/WebKit2: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
<rdar://problem/10048258>

Reviewed by Darin Adler.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
Initialize m_contentsScaleFactor.

* PluginProcess/PluginControllerProxy.h:
Add contentsScaleFactor member function and m_contentsScaleFactor member variable.

* PluginProcess/PluginCreationParameters.cpp:
(WebKit::PluginCreationParameters::PluginCreationParameters):
(WebKit::PluginCreationParameters::encode):
(WebKit::PluginCreationParameters::decode):
* PluginProcess/PluginCreationParameters.h:
Add contentsScaleFactor to the creation parameters.

* PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::contentsScaleFactor):
Return the cached m_contentsScaleFactor.

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Handle getting the scale factor by calling NetscapePlugin::contentsScaleFactor.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::contentsScaleFactor):
Ask the plug-in controller for the contents scale factor.

* WebProcess/Plugins/PluginController.h:
Add contentsScaleFactor pure virtual member function.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::initialize):
Set contentsScaleFactor in the creation parameters.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::contentsScaleFactor):
Get the device scale factor from the page.

* WebProcess/Plugins/PluginView.h:
Add contentsScaleFactor().

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setDeviceScaleFactor):
Bail if the scale factor didn't change.

Tools: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
<rdar://problem/10048258>

Reviewed by Darin Adler.

Add a plug-in test for getting the contents scale factor.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp: Added.
(ContentsScaleFactor::ContentsScaleFactor):
(ContentsScaleFactor::contentsScaleFactor):
(ContentsScaleFactor::ScriptableObject::hasProperty):
(ContentsScaleFactor::ScriptableObject::getProperty):
(ContentsScaleFactor::ScriptableObject::pluginTest):
(ContentsScaleFactor::NPP_GetValue):

LayoutTests: Plug-ins have to use JavaScript to find out the current device scale factor
https://bugs.webkit.org/show_bug.cgi?id=67225
<rdar://problem/10048258>

Reviewed by Darin Adler.

Add tests.

* platform/mac-wk2/plugins/contents-scale-factor-expected.txt: Added.
* platform/mac-wk2/plugins/contents-scale-factor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoForward declare MutationObserverEntry as a struct to fix clang build
adamk@chromium.org [Tue, 25 Oct 2011 22:55:50 +0000 (22:55 +0000)]
Forward declare MutationObserverEntry as a struct to fix clang build
https://bugs.webkit.org/show_bug.cgi?id=70853

Reviewed by Ryosuke Niwa.

Node.h forward declared MutationObserverEntry as a class, and clang
complains if the two declarations don't match.

* dom/Node.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCaret can be positioned or repainted incorrectly in flipped-blocks multi-column blocks
mitz@apple.com [Tue, 25 Oct 2011 22:45:48 +0000 (22:45 +0000)]
Caret can be positioned or repainted incorrectly in flipped-blocks multi-column blocks
https://bugs.webkit.org/show_bug.cgi?id=70851

Reviewed by Dave Hyatt.

* manual-tests/caret-in-columns-flipped.html: Added.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustForColumns): Removed flipped-blocks writing mode considerations
from this function, since not all callers were expecting it to account for flippedness. This makes
it similar to adjustRectForColumns() in not adjusting for flippedness.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::offsetFromContainer): In the columns case, account for flipped-blocks modes
by first mapping the point and the offset to non-flipped, non-columns space, then adjusting for
columns, then flipping.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFlesh out WKBrowsingContextLoadDelegate a bit
weinig@apple.com [Tue, 25 Oct 2011 22:35:52 +0000 (22:35 +0000)]
Flesh out WKBrowsingContextLoadDelegate a bit
https://bugs.webkit.org/show_bug.cgi?id=70846

Source/WebKit2:

Add didReceiveServerRedirectForProvisionalLoad, didFailProvisionalLoad
and didFailLoad.

Reviewed by Anders Carlsson.

Test: WKBrowsingContextLoadDelegateTest

* UIProcess/API/mac/WKBrowsingContextController.mm:
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didFailLoadWithErrorForFrame):
(setUpPageLoaderClient):
* UIProcess/API/mac/WKBrowsingContextLoadDelegate.h:

Tools:

Reviewed by Anders Carlsson.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2ObjC: Added.
* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: Added.
(WKBrowsingContextLoadDelegateTest::WKBrowsingContextLoadDelegateTest):
(WKBrowsingContextLoadDelegateTest::SetUp):
(WKBrowsingContextLoadDelegateTest::TearDown):
(-[SimpleLoadDelegate browsingContextControllerDidFinishLoad:]):
(TEST_F):
Add basic testing for WKBrowsingContextLoadDelegate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTiered compilation may introduce dangling pointers in constant buffers
fpizlo@apple.com [Tue, 25 Oct 2011 21:56:31 +0000 (21:56 +0000)]
Tiered compilation may introduce dangling pointers in constant buffers
https://bugs.webkit.org/show_bug.cgi?id=70854

Reviewed by Oliver Hunt.

Tiered compilation now copies constant buffers, which fixes the regression in
https://bugs.webkit.org/show_bug.cgi?id=70246. No new tests because this
regression relies on a subtle interleaving of optimized compilation and garbage
collection, and cannot be reproduced in a simple test.

This also adds some new debug support, which was used to fix this bug and is
likely to be useful in the future.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::copyDataFrom):
(JSC::CodeBlock::usesOpcode):
* bytecode/CodeBlock.h:
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore unreviewed gardening.
jchaffraix@webkit.org [Tue, 25 Oct 2011 21:44:05 +0000 (21:44 +0000)]
More unreviewed gardening.

* platform/chromium/test_expectations.txt: Mark another test
as crashing. Moved 2 tests together as they hit the same ASSERT
on the bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agomake-script-test-wrappers should not look outside fast/js
ap@apple.com [Tue, 25 Oct 2011 21:16:39 +0000 (21:16 +0000)]
make-script-test-wrappers should not look outside fast/js
https://bugs.webkit.org/show_bug.cgi?id=66357

Reviewed by Maciej Stachowiak.

* Scripts/make-script-test-wrappers: Don't look for template files everywhere, only support
fast/js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAssertion failure when zooming a PDF in an iframe
andersca@apple.com [Tue, 25 Oct 2011 21:11:00 +0000 (21:11 +0000)]
Assertion failure when zooming a PDF in an iframe
https://bugs.webkit.org/show_bug.cgi?id=70849

Reviewed by Alexey Proskuryakov.

If the plug-in doesn't want window relative coordinates, we shouldn't give the plug-in window relative coordinates.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::viewGeometryDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix teardown in Web*LayerImpl, and add tests for Web*Layer
commit-queue@webkit.org [Tue, 25 Oct 2011 21:10:12 +0000 (21:10 +0000)]
Fix teardown in Web*LayerImpl, and add tests for Web*Layer
https://bugs.webkit.org/show_bug.cgi?id=70431

Patch by Antoine Labour <piman@chromium.org> on 2011-10-25
Reviewed by James Robinson.

* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
* src/WebExternalTextureLayerImpl.cpp:
(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
* src/WebLayerImpl.cpp:
(WebKit::WebLayerImpl::~WebLayerImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLayerRendererChromium::setVisible called needlessly without a visibility change
commit-queue@webkit.org [Tue, 25 Oct 2011 20:59:15 +0000 (20:59 +0000)]
LayerRendererChromium::setVisible called needlessly without a visibility change
https://bugs.webkit.org/show_bug.cgi?id=70766

Patch by Michal Mocny <mmocny@google.com> on 2011-10-25
Reviewed by Kenneth Russell.

Check that visibility has actually changed before calling LayerRendererChromium::setVisible

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setVisible):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a --make option to update-webkit to engage the Makefile-based build system
abarth@webkit.org [Tue, 25 Oct 2011 20:54:27 +0000 (20:54 +0000)]
Add a --make option to update-webkit to engage the Makefile-based build system
https://bugs.webkit.org/show_bug.cgi?id=70847

Reviewed by Dimitri Glazkov.

I can never remember what crazy environment variables I'm supposed to
set to tell GYP what to do.

* Scripts/update-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(97821): HistoryController::itemsAreClones crashes a lot
andersca@apple.com [Tue, 25 Oct 2011 20:46:14 +0000 (20:46 +0000)]
REGRESSION(97821): HistoryController::itemsAreClones crashes a lot
https://bugs.webkit.org/show_bug.cgi?id=70827
<rdar://problem/10342925>

Reviewed by Adam Barth.

Check that m_currentItem is non-null before passing it to itemsAreClones. While I wasn't
able to make a test case that would reproduce this crash, we do check m_currentItem for null
everywhere else, and the crash log indicates that this would fix the crash.

* loader/HistoryController.cpp:
(WebCore::HistoryController::recursiveUpdateForCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEventTarget.h shouldn't need to know about every feature and ifdef
abarth@webkit.org [Tue, 25 Oct 2011 20:44:03 +0000 (20:44 +0000)]
EventTarget.h shouldn't need to know about every feature and ifdef
https://bugs.webkit.org/show_bug.cgi?id=70659

Reviewed by Darin Adler.

Source/WebCore:

This patch follows the approach of Event.h and introduces an
interfaceName virtual function that returns the name of the DOM
interface for the concrete type of the object.  This function lets us
remove a large number of fake dynamic casts.

* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_makenames.py:
    - Teach action_makenames how to handle the new "in" file.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
    - Use the new autogenerated macro to remove a large amount of
      feature-specific code.
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::initScript):
* bindings/objc/DOM.mm:
(kit):
    - The SVGElementInstance branch was never taken previously because
      SVGElementInstance::toNode returns a non-NULL value. This code
      was introduced in http://trac.webkit.org/changeset/42618 and
      doesn't appear to have ever worked as the author intended.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
    - Use the new autogenerated macro to remove a large amount of
      feature-specific code.
* dom/EventNames.cpp:
(WebCore::EventNames::EventNames):
* dom/EventNames.h:
* dom/EventTarget.cpp:
* dom/EventTarget.h:
* dom/EventTargetFactory.in: Added.
    - Add a new "in" file that lists all the EventTargets.
* dom/LocalMediaStream.cpp:
(WebCore::LocalMediaStream::interfaceName):
* dom/LocalMediaStream.h:
* dom/MediaStream.cpp:
(WebCore::MediaStream::interfaceName):
* dom/MediaStream.h:
* dom/MessagePort.cpp:
(WebCore::MessagePort::interfaceName):
* dom/MessagePort.h:
* dom/Node.cpp:
(WebCore::Node::toNode):
(WebCore::Node::interfaceName):
* dom/Node.h:
* dom/make_event_factory.pl:
    - Generalize make_event_factory.pl to be able to generate
      interfaces for different namespaces.
* fileapi/FileReader.cpp:
(WebCore::FileReader::interfaceName):
* fileapi/FileReader.h:
* fileapi/FileWriter.cpp:
(WebCore::FileWriter::interfaceName):
* fileapi/FileWriter.h:
* loader/appcache/DOMApplicationCache.cpp:
(WebCore::DOMApplicationCache::interfaceName):
* loader/appcache/DOMApplicationCache.h:
* notifications/Notification.cpp:
(WebCore::Notification::interfaceName):
* notifications/Notification.h:
(WebCore::Notification::scriptExecutionContext):
* p2p/PeerConnection.cpp:
(WebCore::PeerConnection::interfaceName):
* p2p/PeerConnection.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::interfaceName):
(WebCore::DOMWindow::toDOMWindow):
* page/DOMWindow.h:
* page/EventSource.cpp:
(WebCore::EventSource::interfaceName):
* page/EventSource.h:
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::interfaceName):
* storage/IDBDatabase.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::interfaceName):
* storage/IDBRequest.h:
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::interfaceName):
* storage/IDBTransaction.h:
* storage/IDBVersionChangeRequest.cpp:
(WebCore::IDBVersionChangeRequest::interfaceName):
* storage/IDBVersionChangeRequest.h:
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::interfaceName):
* svg/SVGElementInstance.h:
(WebCore::SVGElementInstance::toNode):
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::interfaceName):
(WebCore::AudioContext::scriptExecutionContext):
* webaudio/AudioContext.h:
* webaudio/JavaScriptAudioNode.cpp:
(WebCore::JavaScriptAudioNode::interfaceName):
* webaudio/JavaScriptAudioNode.h:
* websockets/WebSocket.cpp:
(WebCore::WebSocket::interfaceName):
* websockets/WebSocket.h:
* workers/DedicatedWorkerContext.cpp:
(WebCore::DedicatedWorkerContext::interfaceName):
* workers/DedicatedWorkerContext.h:
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerConnectTask::performTask):
* workers/SharedWorker.cpp:
(WebCore::SharedWorker::interfaceName):
* workers/SharedWorker.h:
* workers/SharedWorkerContext.cpp:
(WebCore::SharedWorkerContext::interfaceName):
* workers/SharedWorkerContext.h:
* workers/Worker.cpp:
(WebCore::Worker::interfaceName):
* workers/Worker.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::interfaceName):
* xml/XMLHttpRequest.h:
* xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::interfaceName):
* xml/XMLHttpRequestUpload.h:

Source/WebKit/chromium:

This cast isn't needed because dispatchEvent is a virtual function.

* src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::connectTask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] DRT: Force layout when sending events.
commit-queue@webkit.org [Tue, 25 Oct 2011 20:42:19 +0000 (20:42 +0000)]
[EFL] DRT: Force layout when sending events.
https://bugs.webkit.org/show_bug.cgi?id=70357

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-25
Reviewed by Antonio Gomes.

Some tests such as editing/input/page-up-down-scrolls.html rely on the
scrollbars being properly set up during the onload events.
Document::implicitClose(), however, dispatches the onload events before
calling FrameView::layout(), so these tests usually fail.

We now do the same as the GTK+ and Chromium ports and manually force the
layout when dispatching events.

* DumpRenderTree/efl/EventSender.cpp:
(sendMouseEvent):
(keyDownCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake loadFileURL:restrictToFilesWithin: work, albeit, without the correct
weinig@apple.com [Tue, 25 Oct 2011 20:38:25 +0000 (20:38 +0000)]
Make loadFileURL:restrictToFilesWithin: work, albeit, without the correct
restrictions for now.

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix several minor problems in idls.
podivilov@chromium.org [Tue, 25 Oct 2011 20:36:54 +0000 (20:36 +0000)]
Fix several minor problems in idls.
https://bugs.webkit.org/show_bug.cgi?id=70811

Reviewed by Adam Barth.

This patch does not have any effect on generated bindings.

* dom/DataTransferItems.idl:
* page/History.idl:
* storage/IDBIndex.idl:
* xml/XMLHttpRequest.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] WebGraphicsContext3D setVisibilityCHROMIUM extension changed to pure virtual.
commit-queue@webkit.org [Tue, 25 Oct 2011 20:30:24 +0000 (20:30 +0000)]
[chromium] WebGraphicsContext3D setVisibilityCHROMIUM extension changed to pure virtual.
https://bugs.webkit.org/show_bug.cgi?id=70818

Patch by Michal Mocny <mmocny@google.com> on 2011-10-25
Reviewed by Kenneth Russell.

* public/WebGraphicsContext3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixing Windows build after r98367
mhahnenberg@apple.com [Tue, 25 Oct 2011 20:23:56 +0000 (20:23 +0000)]
Fixing Windows build after r98367

Unreviewed build fix

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Unreviewed. Add CSS1 pixel baselines.
leandro@webkit.org [Tue, 25 Oct 2011 20:22:58 +0000 (20:22 +0000)]
[EFL] Unreviewed. Add CSS1 pixel baselines.

* platform/efl/css1: [...]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake it possible to create and dispatch a message event through chromium API
commit-queue@webkit.org [Tue, 25 Oct 2011 20:01:34 +0000 (20:01 +0000)]
Make it possible to create and dispatch a message event through chromium API

Removed messageChannels parameter, since it's hard to get right and I don't need it. Changed message_data->messageData. Reordered includes.

https://bugs.webkit.org/show_bug.cgi?id=69962

Patch by Dave Michael <dmichael@chromium.org> on 2011-10-25
Reviewed by David Levin.

* WebKit.gyp:
* public/WebDOMEvent.h:
* public/WebDOMMessageEvent.h: Added.
* public/WebDocument.h:
* public/WebNode.h:
* src/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::hasPendingActivity):
* src/WebDOMEvent.cpp:
(WebKit::WebDOMEvent::operator WTF::PassRefPtr<WebCore::Event>):
* src/WebDOMMessageEvent.cpp: Added.
(WebKit::WebDOMMessageEvent::initMessageEvent):
* src/WebDocument.cpp:
(WebKit::WebDocument::createEvent):
* src/WebNode.cpp:
(WebKit::WebNode::dispatchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Make DocumentThreadableLoader a CachedResourceClient.
japhet@chromium.org [Tue, 25 Oct 2011 19:50:25 +0000 (19:50 +0000)]
Source/WebCore: Make DocumentThreadableLoader a CachedResourceClient.
This will allow us to cache ThreadableLoaderClients as
appropriate in a later patch.
https://bugs.webkit.org/show_bug.cgi?id=61225

Reviewed by Antti Koivisto.

No new tests, no functionality change intended.

* WebCore.gypi:
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::notifyFinished): CachedResourceClients don't send separate callbacks
    for didFail() and didFinishLoading(), so we need to differentiate here.
(WebCore::DocumentThreadableLoader::loadRequest): Call CachedResourceLoader::requestRawResource()
    instead of ResourceLoadScheduler::scheduleSubresourceLoad().
* loader/DocumentThreadableLoader.h:
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::data): Handle the complexity of some ThreadableLoaderClients setting
    DoNotBufferData in ResoureLoaderOptions. If the DataBufferingPolicy is BufferData, then the
    'data' input parameter will contain all data received so far, and we need to determine the
    incremental data to forward to the clients. If the policy is DoNotBufferData, 'data' is just
    the incremental data.
* loader/cache/CachedRawResource.h:
* loader/cache/CachedResource.cpp:
* loader/cache/CachedResource.h:
(WebCore::CachedResource::preloadResult):
(WebCore::CachedResource::didSendData):
(WebCore::CachedResource::didDownloadData):
(WebCore::CachedResource::setLoadFinishTime):
(WebCore::CachedResource::loadFinishTime):
* loader/cache/CachedResourceClient.h: Add several new callbacks needed by DocumentThreadableLoader.
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::didReceiveResponse): CachedResource::setResponse() can now cancel
    the request, so protect appropriately.
* loader/cache/CachedResourceRequest.h:
* loader/chromium/CachedRawResourceChromium.cpp: Added (plumb didDownloadData() to DocumentThreadableLoader).
* loader/chromium/CachedResourceRequestChromium.cpp: Added (plumb didDownloadData() to DocumentThreadableLoader).
* loader/chromium/DocumentThreadableLoaderChromium.cpp:
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::notifyResponse): Protect before setting response, since it might kill us.

LayoutTests: Test update for https://bugs.webkit.org/show_bug.cgi?id=61225.
Due to changes in the implementation of DocumentThreadableLoader (and
therefore XHR), this test will have empty (rather than null) content
if we go over the length limit.

Reviewed by Antti Koivisto.

* http/tests/inspector/network/network-content-replacement-xhr-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGet rid of optional parameters in the middle in IDLs.
abarth@webkit.org [Tue, 25 Oct 2011 19:48:28 +0000 (19:48 +0000)]
Get rid of optional parameters in the middle in IDLs.
https://bugs.webkit.org/show_bug.cgi?id=70816

Patch by Pavel Podivilov <podivilov@chromium.org> on 2011-10-25
Reviewed by Adam Barth.

Optional parameters in the middle are prohibited by WebIDL spec.

Source/WebCore:

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateArgumentsCountCheck):
(GenerateImplementation):
* html/canvas/CanvasRenderingContext2D.idl:
* page/DOMWindow.idl:

LayoutTests:

* fast/canvas/canvas-putImageData-expected.txt:
* fast/canvas/canvas-putImageData.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Add function to get geometry of focused element
commit-queue@webkit.org [Tue, 25 Oct 2011 19:45:27 +0000 (19:45 +0000)]
[EFL] Add function to get geometry of focused element
https://bugs.webkit.org/show_bug.cgi?id=70728

Patch by Ivan Briano <ivan@profusion.mobi> on 2011-10-25
Reviewed by Antonio Gomes.

Added function to ewk_frame to get the geometry of the focused
element within the frame object.

* ewk/ewk_frame.cpp:
(ewk_frame_focused_element_geometry_get): Retrieves the geometry of
the focused element within the given frame object.
* ewk/ewk_frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agobuild-webkit --clean should only clean build directory for CMake-based ports
dbates@webkit.org [Tue, 25 Oct 2011 19:37:13 +0000 (19:37 +0000)]
build-webkit --clean should only clean build directory for CMake-based ports
https://bugs.webkit.org/show_bug.cgi?id=70834

Reviewed by Antonio Gomes.

Currently build-webkit --clean both cleans the build directory and builds WebKit for
CMake-based ports. Instead, build-webkit --clean should only clean up the build directory
as per its description in the usage message of build-webkit.

* Scripts/webkitdirs.pm:
(buildCMakeProjectOrExit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Add necessary information for callback instropection
commit-queue@webkit.org [Tue, 25 Oct 2011 19:32:31 +0000 (19:32 +0000)]
[EFL] Add necessary information for callback instropection
https://bugs.webkit.org/show_bug.cgi?id=70735

Patch by Ivan Briano <ivan@profusion.mobi> on 2011-10-25
Reviewed by Antonio Gomes.

Provide the information about smart callbacks emitted by the ewk_view
object, so that these can be easily forwarded by other objects or used
by bindings in other languages without having to keep track of all of
them manually.

* ewk/ewk_view.cpp:
(ewk_view_base_smart_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
jchaffraix@webkit.org [Tue, 25 Oct 2011 19:31:35 +0000 (19:31 +0000)]
Unreviewed gardening.

* platform/chromium/test_expectations.txt: Marking a test as timing
out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoManage the CSS property array length correctly
cevans@google.com [Tue, 25 Oct 2011 19:28:15 +0000 (19:28 +0000)]
Manage the CSS property array length correctly
https://bugs.webkit.org/show_bug.cgi?id=70783

Reviewed by Adam Barth.

* css/CSSParser.cpp:
(WebCore::CSSParser::addProperty): don't allow max length to get out of sync with the buffer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoavoid unnecessary layouts of flex items during the flex pass
tony@chromium.org [Tue, 25 Oct 2011 19:26:04 +0000 (19:26 +0000)]
avoid unnecessary layouts of flex items during the flex pass
https://bugs.webkit.org/show_bug.cgi?id=70557

Reviewed by Ojan Vafai.

If the preferred size of a flex item is provided, we don't need to
layout the flex item when computing the preferred size.  This allows
us to only call layout on each flex item once in the common case.

No new tests, covered by existing tests.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::flowAwareLogicalWidthLengthForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
* rendering/RenderFlexibleBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in WebCore::RenderTableSection::addChild due to assert failure
fsamuel@chromium.org [Tue, 25 Oct 2011 19:10:58 +0000 (19:10 +0000)]
Crash in WebCore::RenderTableSection::addChild due to assert failure
https://bugs.webkit.org/show_bug.cgi?id=70678

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/table-anonymous-cell-bug.html
       fast/table/table-anonymous-row-bug.html
       fast/table/table-anonymous-section-bug.html

If the child being added is not a Section/Row/Cell, and the previous sibling is not anonymous,
we need to create a new anonymous Section/Row/Cell respectively, instead of failing an
assert.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild):

LayoutTests:

If the child being added is not a Section/Row/Cell, and the previous sibling is not anonymous,
we need to create a new anonymous Section/Row/Cell respectively, instead of failing an
assert.

* fast/table/table-anonymous-cell-bug-expected.txt: Added.
* fast/table/table-anonymous-cell-bug.html: Added.
* fast/table/table-anonymous-row-bug-expected.txt: Added.
* fast/table/table-anonymous-row-bug.html: Added.
* fast/table/table-anonymous-section-bug-expected.txt: Added.
* fast/table/table-anonymous-section-bug.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPDF SUBFRAMES: Incomplete repaint after pinch to zoom
andersca@apple.com [Tue, 25 Oct 2011 19:01:51 +0000 (19:01 +0000)]
PDF SUBFRAMES: Incomplete repaint after pinch to zoom
https://bugs.webkit.org/show_bug.cgi?id=70821
<rdar://problem/10312733>

Reviewed by Simon Fraser.

Add a new pure virtual member function, Plugin::wantsWindowRelativeCoordinates.
If a plug-in subclass returns true, we'll keep giving the plug-in coordinates that
are relative to the containing window. If a plug-in subclass returns false, we'll give it
coordinates in a much more sane coordinate system, with the origin at the top left corner of the plug-in.

Change BuiltinPDFView to return false so that it'll work correctly with pinch to zoom.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::wantsWindowRelativeCoordinates):
Make wantsWindowRelativeCoordinates return true.

* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::paint):
Remove translation since the graphics context is already set up in the right way.

(WebKit::BuiltInPDFView::paintContent):
No need to offset by the plug-in view location anymore.

(WebKit::BuiltInPDFView::paintControls):
Account for the scrollbars being children of the parent scroll view here.

(WebKit::BuiltInPDFView::wantsWindowRelativeCoordinates):
Return false.

(WebKit::BuiltInPDFView::convertFromContainingViewToScrollbar):
Implement this so that scrollbar hit testing works correctly.

* WebProcess/Plugins/Plugin.h:
Add wantsWindowRelativeCoordinates.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::wantsWindowRelativeCoordinates):
Return true for now.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::renderer):
Add simple getter.

(WebKit::PluginView::paint):
Handle the case when the plug-in doesn't want window relative coordinates.

(WebKit::PluginView::transformsAffectFrameRect):
Return true here.

(WebKit::PluginView::viewGeometryDidChange):
No need to adjust the bounds to account for the scale factor now, since the frame rect will always be the
same regardless of the transform.

(WebKit::PluginView::clipRectInWindowCoordinates):
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd missing DFG file entries to the make lists for GTK and Qt ports
commit-queue@webkit.org [Tue, 25 Oct 2011 18:59:42 +0000 (18:59 +0000)]
Add missing DFG file entries to the make lists for GTK and Qt ports
https://bugs.webkit.org/show_bug.cgi?id=70806

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-25
Reviewed by Darin Adler.

* GNUmakefile.list.am:
* JavaScriptCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd getOwnPropertySlot to MethodTable
mhahnenberg@apple.com [Tue, 25 Oct 2011 18:51:49 +0000 (18:51 +0000)]
Add getOwnPropertySlot to MethodTable
https://bugs.webkit.org/show_bug.cgi?id=69807

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* JavaScriptCore.exp:
* runtime/ClassInfo.h: Added both versions of getOwnPropertySlot to the MethodTable.
* runtime/JSCell.h: Changed getOwnPropertySlot to be protected so other classes can
reference it in their MethodTables.

Source/WebCore:

No new tests.

* bridge/runtime_method.h: Changed getOwnPropertySlot to be protected so
subclasses can reference it in their MethodTables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd new uri tokenizer tests
zherczeg@webkit.org [Tue, 25 Oct 2011 18:24:04 +0000 (18:24 +0000)]
Add new uri tokenizer tests
https://bugs.webkit.org/show_bug.cgi?id=70807

Reviewed by Darin Adler.

Test more cases!

* fast/css/uri-token-parsing-expected.txt:
* fast/css/uri-token-parsing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed to support marking of multiple nested codeblocks when compiling
oliver@apple.com [Tue, 25 Oct 2011 18:17:37 +0000 (18:17 +0000)]
Need to support marking of multiple nested codeblocks when compiling
https://bugs.webkit.org/show_bug.cgi?id=70832

Reviewed by Gavin Barraclough.

When inlining a function we end up with multiple codeblocks being
compiled at the same time, so we need to support a list of live
codeblocks.

* heap/Heap.cpp:
(JSC::Heap::markRoots):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::startedCompiling):
(JSC::JSGlobalData::finishedCompiling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
jchaffraix@webkit.org [Tue, 25 Oct 2011 18:10:38 +0000 (18:10 +0000)]
Unreviewed gardening.

The old rebaseline looked wrong and did not match the other baselines. This is now corrected.

* platform/chromium-cg-mac-leopard/fast/backgrounds/background-leakage-transforms-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
jchaffraix@webkit.org [Tue, 25 Oct 2011 18:06:51 +0000 (18:06 +0000)]
Unreviewed gardening.

Partial rebaselining of fast/css/focus-ring-multiline-writingmode-vertical.html as it looks like it progressed
on some platforms.

* platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
* platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
* platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
* platform/chromium-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Removed.
* platform/chromium/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago"Open with" item missing from PDF context menu in some cases
sullivan@apple.com [Tue, 25 Oct 2011 17:54:35 +0000 (17:54 +0000)]
"Open with" item missing from PDF context menu in some cases
https://bugs.webkit.org/show_bug.cgi?id=70828
<rdar://problem/10034302>

Reviewed by Anders Carlsson.

* UIProcess/API/mac/PDFViewController.mm:
(insertOpenWithDefaultPDFMenuItem):
New helper function, extracted from -menuForEvent:. Identical to original code except
that it inserts the item at a specified index, rather than always at the end.
(-[WKPDFView menuForEvent:]):
Now keeps track of whether the Open With item has been inserted while iterating through
the PDFKit-supplied menu items looking for a "Copy" item. If a "Copy" item is not found,
inserts the Open With item at the top of the context menu.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r88580): Cursor fails to change to pointer on embedded Google maps popups
simon.fraser@apple.com [Tue, 25 Oct 2011 17:54:11 +0000 (17:54 +0000)]
REGRESSION (r88580): Cursor fails to change to pointer on embedded Google maps popups
https://bugs.webkit.org/show_bug.cgi?id=62797

Source/WebCore:

Reviewed by Chris Marrin.

When hit testing through transformed layers, RenderLayer would simply use
the composited bounds of the layer as the localHitTestRect for hit testing sublayers.
However, this broke hit testing on pages that have a composited, non-transformed layer
which falls outside the bounds of its parent, composited-transformed layer, like Google
Maps.

Fix by mapping the hitTestRect through transforms. However this is tricky, because
mapping a rect into the coordinate system of a layer can result in invalid rectangles
when point projection results in a negative w component. Fix TransformationMatrix::projectPoint()
to detect this case and replace X and Y with large values, and add boundsOfProjectedQuad(), which
maps rectangles with possibly-infinite location or bounds into rects which are representable
in an IntRect.

Tests: transforms/3d/hit-testing/composited-hit-test.html
       transforms/3d/hit-testing/rotated-hit-test-with-child.html
       transforms/3d/hit-testing/rotated-hit-test2.html

* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::projectPoint):
(WebCore::TransformationMatrix::projectQuad):
(WebCore::clampEdgeValue):
(WebCore::TransformationMatrix::boundsOfProjectedQuad):
* platform/graphics/transforms/TransformationMatrix.h:
* rendering/HitTestingTransformState.cpp:
(WebCore::HitTestingTransformState::boundsOfMappedQuad):
* rendering/HitTestingTransformState.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayer):

LayoutTests:

Reviewed by Chris Marrin.

New tests for hit testing through various configurations of 3D transforms.

* platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.png: Removed.
* platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.txt: Removed.
* transforms/3d/hit-testing/composited-hit-test-expected.txt: Added.
* transforms/3d/hit-testing/composited-hit-test.html: Added.
* transforms/3d/hit-testing/resources/hit-test-utils.js: Added.
* transforms/3d/hit-testing/rotated-hit-test-expected.txt: Added.
* transforms/3d/hit-testing/rotated-hit-test-with-child-expected.txt: Added.
* transforms/3d/hit-testing/rotated-hit-test-with-child.html: Added.
* transforms/3d/hit-testing/rotated-hit-test.html:
* transforms/3d/hit-testing/rotated-hit-test2-expected.txt: Added.
* transforms/3d/hit-testing/rotated-hit-test2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Batch up texture uploads so that they can be updated incrementally
enne@google.com [Tue, 25 Oct 2011 17:44:31 +0000 (17:44 +0000)]
[chromium] Batch up texture uploads so that they can be updated incrementally
https://bugs.webkit.org/show_bug.cgi?id=70454

Reviewed by James Robinson.

Because texture uploads can sometimes take more than a frame to
complete, collect all the uploads that need to occur in a
CCTextureUpdater so that we can easily incrementally upload some of
them, interleaving input and drawing so that the compositor thread
continues to appear responsive during a commit.

This change doesn't actually interleave the commits, it just pushes
the infrastructure for doing so up to the CCProxy level so that a
future scheduler can make this decision.

VideoLayerChromium is the only layer type to not use this system. It
needs to be converted to use a texture updater first and it is less of
a priority than the tiled layers.

* WebCore.gypi:
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::updateCompositorResources):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateCompositorResources):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateCompositorResources):
* platform/graphics/chromium/VideoLayerChromium.h:
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):
* platform/graphics/chromium/WebGLLayerChromium.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCTextureUpdater.cpp: Added.
(WebCore::CCTextureUpdater::CCTextureUpdater):
(WebCore::CCTextureUpdater::~CCTextureUpdater):
(WebCore::CCTextureUpdater::append):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):
* platform/graphics/chromium/cc/CCTextureUpdater.h: Added.
(WebCore::CCTextureUpdater::allocator):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::commitOnImplThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocompositing/video tests time out on Lion
jer.noble@apple.com [Tue, 25 Oct 2011 17:42:18 +0000 (17:42 +0000)]
compositing/video tests time out on Lion
https://bugs.webkit.org/show_bug.cgi?id=70448

Reviewed by Simon Fraser.

Source/WebCore:

AVFoundation will not begin loading or decoding media until a consumer for that media is present.
For video-only media, this means that an AVPlayerLayer must be created and attached to the
AVPlayer before the load state will ever reach "canPlayThrough". Once the metadata for a media
is loaded, create a AVPlayerLayer if the media has a video track.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::updateStates):

LayoutTests:

* compositing/video/video-poster.html: Seek, instead of play, to trigger
    creation of a layer
* http/tests/media/video-load-twice.html: Use waitForEventOnce so that
    canPlayThrough listener is triggered only once.
* media/video-test.js: Add a new function, waitForEventOnce.
(waitForEventOnce):
(waitForEvent._eventCallback):
(waitForEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMerge endOfLine with logicalEndOfLine and startOfLine with logicalStartOfLine
rniwa@webkit.org [Tue, 25 Oct 2011 17:22:50 +0000 (17:22 +0000)]
Merge endOfLine with logicalEndOfLine and startOfLine with logicalStartOfLine
https://bugs.webkit.org/show_bug.cgi?id=70755

Reviewed by Chang Shu.

Merged endOfLine with logicalEndOfLine, and startOfLine with logicalStartOfLine
to reduce the code duplication.

* editing/visible_units.cpp:
(WebCore::startPositionForLine):
(WebCore::startOfLine):
(WebCore::logicalStartOfLine):
(WebCore::endPositionForLine):
(WebCore::inSameLogicalLine):
(WebCore::endOfLine):
(WebCore::logicalEndOfLine):
* editing/visible_units.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRe-enable touch tests (from 66577)
commit-queue@webkit.org [Tue, 25 Oct 2011 17:22:37 +0000 (17:22 +0000)]
Re-enable touch tests (from 66577)
https://bugs.webkit.org/show_bug.cgi?id=70351

Patch by Gene Girard <girard@chromium.org> on 2011-10-25
Reviewed by Adam Barth.

* tests/InnerGestureRecognizerTest.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
nduca@chromium.org [Tue, 25 Oct 2011 17:18:38 +0000 (17:18 +0000)]
Unreviewed. Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening: fifth chunk of baselines for Chromium-Skia
caryclark@google.com [Tue, 25 Oct 2011 17:17:46 +0000 (17:17 +0000)]
Unreviewed gardening: fifth chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 736 of 742 files for brevity.]

* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-4-expected.png: Added.
...
* platform/chromium-mac-leopard/transitions: Added.
* platform/chromium-mac-leopard/transitions/default-timing-function-expected.png: Added.
* platform/chromium-mac-leopard/transitions/svg-text-shadow-transition-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable running of track layout tests for Chromium
annacc@chromium.org [Tue, 25 Oct 2011 17:04:05 +0000 (17:04 +0000)]
Enable running of track layout tests for Chromium
https://bugs.webkit.org/show_bug.cgi?id=70803

Reviewed by Adam Barth.

Make DumpRenderTree/TestShell always run with track enabled
(equivalent of --enable-video-track).

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Microdata: itemtype attribute should be space-separated list to allow...
commit-queue@webkit.org [Tue, 25 Oct 2011 16:53:52 +0000 (16:53 +0000)]
Source/WebCore: Microdata: itemtype attribute should be space-separated list to allow multiple types.
https://bugs.webkit.org/show_bug.cgi?id=70501

Patch by Arko Saha <arko@motorola.com> on 2011-10-25
Reviewed by Ryosuke Niwa.

Tests: fast/dom/MicroData/getitems-multiple-itemtypes.html
       fast/dom/MicroData/itemtype-add-remove-tokens.html
       fast/dom/MicroData/itemtype-attribute-test.html

* dom/MicroDataItemList.cpp:
(WebCore::MicroDataItemList::nodeMatches):
* html/DOMSettableTokenList.h:
(WebCore::DOMSettableTokenList::tokens):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
(WebCore::HTMLElement::setItemValueText):
(WebCore::HTMLElement::itemType):
(WebCore::HTMLElement::setItemType):
* html/HTMLElement.h:
* html/HTMLElement.idl:

LayoutTests: Microdata: itemtype attribute should be space-separated list to allow multiple types
https://bugs.webkit.org/show_bug.cgi?id=70501

Patch by Arko Saha <arko@motorola.com> on 2011-10-25
Reviewed by Ryosuke Niwa.

* fast/dom/MicroData/006.html:
* fast/dom/MicroData/007.html:
* fast/dom/MicroData/getitems-multiple-itemtypes-expected.txt: Added.
* fast/dom/MicroData/getitems-multiple-itemtypes.html: Added.
* fast/dom/MicroData/itemtype-add-remove-tokens-expected.txt: Added.
* fast/dom/MicroData/itemtype-add-remove-tokens.html: Added.
* fast/dom/MicroData/itemtype-attribute-test-expected.txt: Added.
* fast/dom/MicroData/itemtype-attribute-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] GtkAdjustment watcher updates adjustments too lazily
commit-queue@webkit.org [Tue, 25 Oct 2011 16:52:50 +0000 (16:52 +0000)]
[GTK] GtkAdjustment watcher updates adjustments too lazily
https://bugs.webkit.org/show_bug.cgi?id=70180

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-10-25
Reviewed by Gustavo Noronha Silva.

Increase the priority of the GtkAdjustments update in GtkAdjustmentWatcher. This
means that adjustments will more quickly represent the state of the WebKitWebView
when it scrolls. This fixes out-of-sync scrollbars and some visual artifacts.

* WebCoreSupport/GtkAdjustmentWatcher.cpp:
(WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater): Use a timeout
with the default priority.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2]Main window never gets focus using TAB key in WebKit2 GTK+.
commit-queue@webkit.org [Tue, 25 Oct 2011 16:40:29 +0000 (16:40 +0000)]
[WK2]Main window never gets focus using TAB key in WebKit2 GTK+.
https://bugs.webkit.org/show_bug.cgi?id=70603

Patch by Vamshikrishna Yellenki <vamshi@motorola.com> on 2011-10-25
Reviewed by Gustavo Noronha Silva.

* MiniBrowser/gtk/BrowserWindow.c:
(focus):
(unFocus):
(browserWindowUIClientInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10337033> DOMRangeOfString:relativeTo:options has problems with ...
mitz@apple.com [Tue, 25 Oct 2011 16:39:23 +0000 (16:39 +0000)]
<rdar://problem/10337033> DOMRangeOfString:relativeTo:options has problems with -webkit-user-select: none

Reviewed by Adam Roben.

Source/WebCore:

Test: added to TestWebKitAPI/Tests/mac/DOMRangeOfString.mm

* page/Page.cpp:
(WebCore::Page::rangeOfString): This function was incorrectly adding the StartInSelection option to
the initial search.

Tools:

* TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening: fourth chunk of baselines for Chromium-Skia
caryclark@google.com [Tue, 25 Oct 2011 16:26:15 +0000 (16:26 +0000)]
Unreviewed gardening: fourth chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 728 of 734 files for brevity.]

* platform/chromium-mac-leopard/fast/lists/ordered-list-with-no-ol-tag-expected.png: Added.
* platform/chromium-mac-leopard/fast/lists/scrolled-marker-paint-expected.png: Added.
* platform/chromium-mac-leopard/fast/media: Added.
...
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tref-01-b-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: redesign workers sidebar pane
yurys@chromium.org [Tue, 25 Oct 2011 15:35:50 +0000 (15:35 +0000)]
Web Inspector: redesign workers sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=70815

Source/WebCore:

Changed workers sidebar pane design.

Now there is a link to worker inspector for each dedicated worker created
by inspected page. The sidebar display a link to a page with list of all
shared workers if there one is supported by the WebKit port. Also there
is a checkbox that allows pause all new workers on first statements.

Reviewed by Pavel Feldman.

* inspector/front-end/Settings.js:
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.prototype.openWorkerInspector):
(WebInspector.WorkerManager.prototype._workerInspectorClosing):
* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkerListSidebarPane):
(WebInspector.WorkerListSidebarPane.prototype._workerRemoved):
(WebInspector.WorkerListSidebarPane.prototype._workersCleared):
(WebInspector.WorkerListSidebarPane.prototype._addWorker):
(WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
(WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):
(WebInspector.WorkerListSidebarPane.prototype._createSharedWorkersLink.link.onclick):
(WebInspector.WorkerListSidebarPane.prototype._createSharedWorkersLink):
* inspector/front-end/elementsPanel.css:
* inspector/front-end/inspectorCommon.css:
(.sidebar-separator):
(.sidebar-label):
* inspector/front-end/scriptsPanel.css:
(.dedicated-worker-item):
(#shared-workers-list):
(#pause-workers-checkbox > input):

Source/WebKit/chromium:

Reviewed by Pavel Feldman.

* src/js/DevTools.js: Expose link to shared workers inspection page to WebCore.
():

LayoutTests:

Update tests in accord with change of class name from
styles-sidebar-pane to sidebar-pane.

Reviewed by Pavel Feldman.

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: [chromium/mac] Fix an ODR violation.
thakis@chromium.org [Tue, 25 Oct 2011 15:21:15 +0000 (15:21 +0000)]
Source/WebCore: [chromium/mac] Fix an ODR violation.
https://bugs.webkit.org/show_bug.cgi?id=70753

Reviewed by Anders Carlsson.

Both ScrollAnimatorNone and ScrollAnimatorMac define ScrollAnimator::create() on OS X.
Remove the unused one.

* WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium: [chromium] Try to fix mac build after r98294
https://bugs.webkit.org/show_bug.cgi?id=70753

Remove test for ScrollAnimatorNone on mac.

Unreviewed, build fix.

* WebKit.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Debugger fails when there is an invalid watch expression.
vsevik@chromium.org [Tue, 25 Oct 2011 15:06:00 +0000 (15:06 +0000)]
Web Inspector: Debugger fails when there is an invalid watch expression.
https://bugs.webkit.org/show_bug.cgi?id=70718

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/debugger/watch-expressions-panel-switch.html

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):

LayoutTests:

* inspector/debugger/error-in-watch-expressions.html:
* inspector/debugger/watch-expressions-panel-switch-expected.txt: Added.
* inspector/debugger/watch-expressions-panel-switch.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: fix empty line handling in source maps.
podivilov@chromium.org [Tue, 25 Oct 2011 14:26:59 +0000 (14:26 +0000)]
Web Inspector: fix empty line handling in source maps.
https://bugs.webkit.org/show_bug.cgi?id=70726

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):

LayoutTests:

* inspector/debugger/compiler-source-mapping-expected.txt:
* inspector/debugger/compiler-source-mapping.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCheck for empty string in parseArcFlag
jschuh@chromium.org [Tue, 25 Oct 2011 14:24:59 +0000 (14:24 +0000)]
Check for empty string in parseArcFlag
https://bugs.webkit.org/show_bug.cgi?id=70763

Reviewed by Dirk Schulze.

Source/WebCore:

Test: svg/path-invalid.html

* svg/SVGParserUtilities.cpp:
(WebCore::parseArcFlag):

LayoutTests:

* svg/path-arc-invalid-expected.txt: Added.
* svg/path-arc-invalid.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: keep old source mapping when new one could not be loaded.
podivilov@chromium.org [Tue, 25 Oct 2011 14:22:44 +0000 (14:22 +0000)]
Web Inspector: keep old source mapping when new one could not be loaded.
https://bugs.webkit.org/show_bug.cgi?id=70729

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didLoadSourceMapping):

LayoutTests:

* inspector/debugger/raw-source-code-expected.txt:
* inspector/debugger/raw-source-code.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDouble number step=.5 should be considered valid in <input type="number" step=".5">
commit-queue@webkit.org [Tue, 25 Oct 2011 14:04:45 +0000 (14:04 +0000)]
Double number step=.5 should be considered valid in <input type="number" step=".5">
https://bugs.webkit.org/show_bug.cgi?id=70320

Patch by Sachin Puranik <sachin.puranik@motorola.com> on 2011-10-25
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/input-step-as-double.html

* html/parser/HTMLParserIdioms.cpp:
(WebCore::parseToDoubleForNumberType): Changed the function to consider
step as valid even if it starts with "."

LayoutTests:

* fast/forms/ValidityState-typeMismatch-number-expected.txt: Change in result of layout test.
* fast/forms/input-step-as-double-expected.txt: Added, expected output for new test case.
* fast/forms/input-step-as-double.html: Added, testcase to make sure that all ports
consider .5 as a valid double value for step attribute of input element.
* fast/forms/input-valueasnumber-number-expected.txt: Change in result of layout test.
* fast/forms/range/input-valueasnumber-range-expected.txt: Change in result of layout test.
* fast/forms/range/input-valueasnumber-range.html: Consider .2 as valid real number now.
* fast/forms/script-tests/ValidityState-typeMismatch-number.js: Consider
.2 as valid real number now.
* fast/forms/script-tests/input-valueasnumber-number.js: Consider .2 as valid real number now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Chromium] Audits panel context menu for links not working properly
apavlov@chromium.org [Tue, 25 Oct 2011 13:57:54 +0000 (13:57 +0000)]
Web Inspector: [Chromium] Audits panel context menu for links not working properly
https://bugs.webkit.org/show_bug.cgi?id=70813

Reviewed by Pavel Feldman.

* inspector/front-end/AuditResultView.js:
(WebInspector.AuditResultView):
(WebInspector.AuditResultView.prototype._contextMenuEventFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWIN: editing tests fail under NRWT because editing delegate callbacks aren't stripped
eric@webkit.org [Tue, 25 Oct 2011 13:49:33 +0000 (13:49 +0000)]
WIN: editing tests fail under NRWT because editing delegate callbacks aren't stripped
https://bugs.webkit.org/show_bug.cgi?id=64471

Reviewed by Adam Roben.

Speculative fix.

* Scripts/webkitpy/layout_tests/port/win.py:
* Scripts/webkitpy/layout_tests/port/win_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Resources panel: display the current search match index in the toolbar.
vsevik@chromium.org [Tue, 25 Oct 2011 13:49:24 +0000 (13:49 +0000)]
Web Inspector: Resources panel: display the current search match index in the toolbar.
https://bugs.webkit.org/show_bug.cgi?id=66050

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/search/resources-search-match-index.html

* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.performSearch.callback):
(WebInspector.ResourcesPanel.prototype.performSearch):
(WebInspector.ResourcesPanel.prototype._showSearchResult.callback):
(WebInspector.ResourcesPanel.prototype._showSearchResult):
(WebInspector.BaseStorageTreeElement.prototype.get searchMatchesCount):
(WebInspector.ResourcesSearchController):
(WebInspector.ResourcesSearchController.prototype.nextSearchResult):
(WebInspector.ResourcesSearchController.prototype.previousSearchResult):
(WebInspector.ResourcesSearchController.prototype._searchResult):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.next):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.previous):
(WebInspector.SearchResultsTreeElementsTraverser.prototype.matchIndex):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._elementSearchMatchesCount):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traverseNext):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traversePrevious):
* inspector/front-end/treeoutline.js:

LayoutTests:

* http/tests/inspector/search/resources-search-match-index-expected.txt: Added.
* http/tests/inspector/search/resources-search-match-index.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoinspector/cookie-parser.html is a flaky crash
ossy@webkit.org [Tue, 25 Oct 2011 13:45:47 +0000 (13:45 +0000)]
inspector/cookie-parser.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=62662

* platform/qt/Skipped: Skip one more test because of this bug: inspector/evaluate-in-page.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] QDesktopWebView and QTouchWebView should be declared in the meta type system.
commit-queue@webkit.org [Tue, 25 Oct 2011 13:38:28 +0000 (13:38 +0000)]
[Qt][WK2] QDesktopWebView and QTouchWebView should be declared in the meta type system.
https://bugs.webkit.org/show_bug.cgi?id=70693

This change allows us to use the template based features of the meta type system
such as using the WebView classes as types for QVariant.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-25
Reviewed by Simon Hausmann.

* UIProcess/API/qt/qdesktopwebview.h:
* UIProcess/API/qt/qtouchwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: JS exception in JavaScriptSourceFrame.onShowPopover/showObjectPopover()
caseq@chromium.org [Tue, 25 Oct 2011 12:59:07 +0000 (12:59 +0000)]
Web Inspector: JS exception in JavaScriptSourceFrame.onShowPopover/showObjectPopover()
https://bugs.webkit.org/show_bug.cgi?id=70812

Reviewed by Pavel Feldman.

Check if highlighted element is present while displaying object popover.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.onShowPopover.showObjectPopover):
(WebInspector.JavaScriptSourceFrame.prototype.onShowPopover):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Remove redundant setPageIsVisible() API
commit-queue@webkit.org [Tue, 25 Oct 2011 11:01:51 +0000 (11:01 +0000)]
[Qt][WK2] Remove redundant setPageIsVisible() API
https://bugs.webkit.org/show_bug.cgi?id=70520

Use DrawingAreaProxy::visibilityDidChange() instead of DrawingAreaProxy::setPageIsVisible()
Remove DrawingAreaProxy::setPageIsVisible(), not used anymore.
This change disables the ability of suspending and resuming painting for TiledDrawingAreaProxy.
However, TiledDrawingAreaProxy is about to be deprecated by using DrawingAreaProxyImpl
as the UI process drawing area proxy for tiled based rendering.

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-10-25
Reviewed by Simon Hausmann.

* UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::QTouchWebPage):
(QTouchWebPagePrivate::setPage):
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebView::QTouchWebView):
(QTouchWebView::touchEvent):
(QTouchWebView::onVisibleChanged):
* UIProcess/API/qt/qtouchwebview.h:
* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
(WebKit::TiledDrawingAreaProxy::deviceScaleFactorDidChange):
* UIProcess/TiledDrawingAreaProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
* UIProcess/qt/QtWebPageProxy.cpp:
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Route Console::time and Console::timeEnd to trace_event
nduca@chromium.org [Tue, 25 Oct 2011 09:54:27 +0000 (09:54 +0000)]
[chromium] Route Console::time and Console::timeEnd to trace_event
https://bugs.webkit.org/show_bug.cgi?id=70620

Reviewed by Pavel Feldman.

* page/Console.cpp:
(WebCore::Console::time):
(WebCore::Console::timeEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Remove from Skipped list. Test passes: fast/transforms/scrollIntoView-transforme...
ossy@webkit.org [Tue, 25 Oct 2011 09:39:35 +0000 (09:39 +0000)]
[Qt] Remove from Skipped list. Test passes: fast/transforms/scrollIntoView-transformed.html
https://bugs.webkit.org/show_bug.cgi?id=58559

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-10-25
Reviewed by Simon Hausmann.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Removing test from Skipped list. Test passes: html5lib/runner.html
ossy@webkit.org [Tue, 25 Oct 2011 09:35:48 +0000 (09:35 +0000)]
[Qt] Removing test from Skipped list. Test passes: html5lib/runner.html
https://bugs.webkit.org/show_bug.cgi?id=53030

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2011-10-25
Reviewed by Simon Hausmann.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Extensions API] allow extensions to specify script to be injected...
caseq@chromium.org [Tue, 25 Oct 2011 09:25:37 +0000 (09:25 +0000)]
Web Inspector: [Extensions API] allow extensions to specify script to be injected on reload
https://bugs.webkit.org/show_bug.cgi?id=70600

Reviewed by Pavel Feldman.

- change webInspector.inspectedPage.reload() to accept multiple options in an object
- add an ability to inject a script upon a page reload
- return script id in addScriptToEvaluateOnLoad()
- provide removeScriptToEvaluateOnLoad()
- store scripts to evaluate on load in inspector state cookie

Source/WebCore:

Test: inspector/extensions/extensions-reload.html

* inspector/Inspector.json:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeAllScriptsToEvaluateOnLoad):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::frameNavigated):
* inspector/InspectorPageAgent.h:
* inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.InspectedWindow.prototype.reload):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onReload):
* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkersSidebarPane.prototype.setInstrumentation.callback):
(WebInspector.WorkersSidebarPane.prototype.setInstrumentation):

LayoutTests:

* inspector/extensions/extensions-reload-expected.txt: Added.
* inspector/extensions/extensions-reload.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Add go_to_back_forward_list_item() to WebKit2 GTK+ API
carlosgc@webkit.org [Tue, 25 Oct 2011 08:37:35 +0000 (08:37 +0000)]
[GTK] Add go_to_back_forward_list_item() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69825

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitBackForwardListItem.cpp:
(webkitBackForwardListItemGetWKItem):
* UIProcess/API/gtk/WebKitBackForwardListPrivate.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_go_to_back_forward_list_item):
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/tests/TestBackForwardList.cpp:
(testBackForwardListNavigation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: print expired message count before remaining messages.
pfeldman@chromium.org [Tue, 25 Oct 2011 08:24:14 +0000 (08:24 +0000)]
Web Inspector: print expired message count before remaining messages.
https://bugs.webkit.org/show_bug.cgi?id=70736

Reviewed by Yury Semikhatsky.

* inspector/Inspector-0.1.json:
* inspector/Inspector.json:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::restore):
* inspector/InspectorConsoleAgent.h:
* inspector/front-end/ConsoleModel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2]Critical warning while building WebKit2 GTK+
commit-queue@webkit.org [Tue, 25 Oct 2011 08:19:54 +0000 (08:19 +0000)]
[WK2]Critical warning while building WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=70591

Patch by Vamshikrishna Yellenki <vamshi@motorola.com> on 2011-10-25
Reviewed by Martin Robinson.

* WebProcess/WebPage/WebPage.cpp: Included DataObjectGtk.h to avoid warnings for GTK

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r98309.
commit-queue@webkit.org [Tue, 25 Oct 2011 07:06:07 +0000 (07:06 +0000)]
Unreviewed, rolling out r98309.
http://trac.webkit.org/changeset/98309
https://bugs.webkit.org/show_bug.cgi?id=70801

Test fails on mac (Requested by benwells on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-25

Source/WebCore:

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::shouldDisplayTransparencyElsewhere):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):
* html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

* fast/canvas/canvas-composite-image-expected.txt: Removed.
* fast/canvas/canvas-composite-image.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening, add missing result after r98309.
ossy@webkit.org [Tue, 25 Oct 2011 06:59:32 +0000 (06:59 +0000)]
[Qt] Unreviewed gardening, add missing result after r98309.

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-10-24

* platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
* platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
* platform/qt/svg/filters/feColorMatrix-default-type-expected.png: Added.
* platform/qt/svg/filters/feColorMatrix-default-type-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r97865): broke plugins/resize-from-plugin.html on GTK
mrobinson@webkit.org [Tue, 25 Oct 2011 06:51:35 +0000 (06:51 +0000)]
REGRESSION (r97865): broke plugins/resize-from-plugin.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=70481

Update test results to reflect that the plugin clipping rectangle
is now correct.

* platform/gtk/Skipped: Unskip the test.
* platform/gtk/plugins/resize-from-plugin-expected.txt: Update results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG JIT 32_64 - fillInteger should accept DataFormatJSInteger
commit-queue@webkit.org [Tue, 25 Oct 2011 05:43:15 +0000 (05:43 +0000)]
DFG JIT 32_64 - fillInteger should accept DataFormatJSInteger
https://bugs.webkit.org/show_bug.cgi?id=70798

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-24
Reviewed by Filip Pizlo.

When filling an integer for a known integer node (not speculated), it
should accept DataFormatJSInteger as well.

* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium build fix: #include window.h for HANDLE.
ggaren@apple.com [Tue, 25 Oct 2011 04:57:36 +0000 (04:57 +0000)]
Chromium build fix: #include window.h for HANDLE.

* platform/graphics/opentype/OpenTypeUtilities.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInclude ThreadSafeRefCounted.h since the class declared in this header file
rniwa@webkit.org [Tue, 25 Oct 2011 04:49:18 +0000 (04:49 +0000)]
Include ThreadSafeRefCounted.h since the class declared in this header file
inherits from ThreadSafeRefCounted.

* storage/IDBIndexBackendInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix: removed some cases of threadsafeCopy() that I missed in
ggaren@apple.com [Tue, 25 Oct 2011 04:33:38 +0000 (04:33 +0000)]
Build fix: removed some cases of threadsafeCopy() that I missed in
my previous patch.

Source/JavaScriptCore:

* JavaScriptCore.order:

Source/WebKit/win:

* WebDatabaseManager.cpp:
(DidModifyOriginData::dispatchToMainThread):
* WebDownloadCFNet.cpp:
(WebDownload::initToResumeWithBundle):
* WebIconDatabase.cpp:
(WebIconDatabase::didImportIconURLForPageURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Fix a typo.
rniwa@webkit.org [Tue, 25 Oct 2011 04:26:38 +0000 (04:26 +0000)]
Source/WebCore: Fix a typo.

* bindings/v8/JavaScriptCallFrame.h:

Source/WebKit/win: threadsafeCopy has been renamed to isolatedCopy.

* WebDatabaseManager.cpp:
(DidModifyOriginData::dispatchToMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoved SharedUChar and tightened language around its previous uses
ggaren@apple.com [Tue, 25 Oct 2011 03:54:15 +0000 (03:54 +0000)]
Removed SharedUChar and tightened language around its previous uses
https://bugs.webkit.org/show_bug.cgi?id=70698

Reviewed by David Levin.

Source/JavaScriptCore:

- Removed SharedUChar because most of its functionality has moved into
other abstraction layers, and we want remaining clients to choose their
abstractions explicitly instead of relying on StringImpl to provide this
behavior implicitly, since we think they can sometimes make more efficient
choices.

- Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because
the former names could give the impression that the resulting object was
thread-safe, but actually it's just an isolated copy, which is not
thread-safe by itself, but can be used to implement a thread-safe
algorithm through isolation.

* wtf/CrossThreadRefCounted.h: Removed.

* JavaScriptCore.exp: Export!

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::~StringImpl): Removed the stuff mentioned above.

* wtf/text/StringImpl.h:
(WTF::StringImpl::length): Ditto.

(WTF::StringImpl::isolatedCopy): Inlined this, since it's now trivial.

* wtf/text/WTFString.cpp:
(WTF::String::isolatedCopy):
* wtf/text/WTFString.h: Updated for StringImpl changes.

* API/OpaqueJSString.h:
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.order:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/OwnFastMallocPtr.h:
* wtf/RefCounted.h:
* wtf/SizeLimits.cpp:
* wtf/ThreadSafeRefCounted.h:
* wtf/wtf.pri:
* yarr/YarrPattern.h: Updated these files to accomodate removal of
CrossThreadRefCounted.h.

Source/WebCore:

- Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because
the former names gave the dangerous misimpression that the resulting object
was thread-safe, which is not true.

- Updated a bunch of files for header dependency changes, now that
CrossThreadRefCounted is gone.

* ForwardingHeaders/wtf/CrossThreadRefCounted.h: Removed.
* WebCore.exp.in:
* bindings/js/ScriptHeapSnapshot.h:
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::release):
(WebCore::SerializedScriptValue::SerializedScriptValue):
* css/CSSPropertySourceData.h:
* css/CSSValue.h:
* css/StyleMedia.h:
* css/WebKitCSSMatrix.h:
* dom/QualifiedName.h:
* fileapi/LocalFileSystem.h:
(WebCore::LocalFileSystem::SystemBasePath::operator String):
* history/CachedFrame.h:
* history/CachedPage.h:
* history/HistoryItem.h:
* html/canvas/CanvasStyle.h:
* inspector/InspectorResourceAgent.h:
* loader/FormState.h:
* loader/TextResourceDecoder.h:
* loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::open):
(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::synchronousIconURLForPageURL):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::setIconURLForPageURL):
(WebCore::IconDatabase::databasePath):
(WebCore::IconDatabase::defaultDatabaseFilename):
(WebCore::ImportedIconURLForPageURLWorkItem::ImportedIconURLForPageURLWorkItem):
(WebCore::ImportedIconDataForPageURLWorkItem::ImportedIconDataForPageURLWorkItem):
* page/ContentSecurityPolicy.h:
* page/Coordinates.h:
(WebCore::Coordinates::isolatedCopy):
* page/Geoposition.h:
(WebCore::Geoposition::isolatedCopy):
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::isolatedCopy):
* page/SecurityOrigin.h:
* page/animation/AnimationBase.h:
* platform/CrossThreadCopier.cpp:
(WebCore::::copy):
* platform/FileChooser.h:
* platform/KURL.cpp:
(WebCore::KURL::copy):
* platform/cf/SchedulePair.h:
* platform/network/BlobData.cpp:
(WebCore::BlobDataItem::detachFromCurrentThread):
(WebCore::BlobData::detachFromCurrentThread):
* platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::copyData):
* platform/network/MIMEHeader.h:
* platform/network/ResourceErrorBase.cpp:
(WebCore::ResourceErrorBase::copy):
* platform/network/ResourceLoadInfo.h:
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::copyData):
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::copyData):
* platform/sql/SQLValue.cpp:
(WebCore::SQLValue::SQLValue):
(WebCore::SQLValue::string):
* rendering/style/QuotesData.h:
* storage/AbstractDatabase.cpp:
(WebCore::updateGuidVersionMap):
(WebCore::AbstractDatabase::AbstractDatabase):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::stringIdentifier):
(WebCore::AbstractDatabase::displayName):
(WebCore::AbstractDatabase::fileName):
(WebCore::AbstractDatabase::setExpectedVersion):
(WebCore::AbstractDatabase::getCachedVersion):
* storage/ChangeVersionWrapper.cpp:
(WebCore::ChangeVersionWrapper::ChangeVersionWrapper):
* storage/Database.cpp:
(WebCore::Database::Database):
(WebCore::Database::tableNames):
* storage/DatabaseDetails.h:
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::setDatabaseDirectoryPath):
(WebCore::DatabaseTracker::databaseDirectoryPath):
(WebCore::DatabaseTracker::trackerDatabasePath):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::originPath):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::recordCreatingDatabase):
(WebCore::DatabaseTracker::recordDeletingDatabase):
(WebCore::DatabaseTracker::recordDeletingOrigin):
(WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged):
* storage/OriginQuotaManager.cpp:
(WebCore::OriginQuotaManager::trackOrigin):
(WebCore::OriginQuotaManager::addDatabase):
* storage/SQLError.h:
(WebCore::SQLError::message):
(WebCore::SQLError::SQLError):
* storage/SQLResultSetRowList.h:
* storage/SQLStatement.cpp:
(WebCore::SQLStatement::SQLStatement):
* storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::StorageAreaSync):
(WebCore::StorageAreaSync::syncTimerFired):
* storage/StorageAreaSync.h:
* storage/StorageMap.cpp:
(WebCore::StorageMap::importItem):
* storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::StorageNamespaceImpl):
* storage/StorageSyncManager.cpp:
(WebCore::StorageSyncManager::StorageSyncManager):
* storage/StorageTracker.cpp:
(WebCore::StorageTracker::StorageTracker):
(WebCore::StorageTracker::syncImportOriginIdentifiers):
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::willDeleteAllOrigins):
* svg/SVGPathSeg.h:
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::url):
(WebCore::SharedWorkerProxy::name):
(WebCore::SharedWorkerProxy::SharedWorkerProxy):
(WebCore::DefaultSharedWorkerRepository::getProxy):
* workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::SharedWorkerThread):
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerExceptionTask::WorkerExceptionTask):
(WebCore::PostMessageToPageInspectorTask::PostMessageToPageInspectorTask):
* workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::Task):
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):

Source/WebKit/chromium:

- Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because
the former names gave the dangerous misimpression that the resulting object
was thread-safe, which is not true.

* src/WorkerFileSystemCallbacksBridge.cpp:

Source/WebKit/mac:

- Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because
the former names gave the dangerous misimpression that the resulting object
was thread-safe, which is not true.

* Storage/WebDatabaseTrackerClient.mm:
(DidModifyOriginData::dispatchToMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix bug summary when rolling Chromium DEPS to LKGR.
mnaganov@chromium.org [Tue, 25 Oct 2011 03:36:24 +0000 (03:36 +0000)]
Fix bug summary when rolling Chromium DEPS to LKGR.
https://bugs.webkit.org/show_bug.cgi?id=69917

Reviewed by Adam Barth.

* Scripts/webkitpy/tool/bot/irc_command.py:
* Scripts/webkitpy/tool/bot/sheriff.py:
* Scripts/webkitpy/tool/commands/roll.py:
* Scripts/webkitpy/tool/commands/roll_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove empty directory.
abarth@webkit.org [Tue, 25 Oct 2011 03:17:25 +0000 (03:17 +0000)]
Remove empty directory.

* p2p: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Refactor painting/updating/drawing code.
commit-queue@webkit.org [Tue, 25 Oct 2011 02:54:22 +0000 (02:54 +0000)]
[chromium] Refactor painting/updating/drawing code.
https://bugs.webkit.org/show_bug.cgi?id=70057

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-10-24
Reviewed by James Robinson.

This refactoring separates the "early exits" from the actual loop
that draws layers. As part of this, it was also appropriate to
clean up the way that masks and replicas are dealt with when
painting and updating. The purpose of all this is to make things
easier to test, and for a scissoring optimization that needs to
know exatly what gets drawn. Existing layout tests were able to
verify the refactoring did not change behavior.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::layerShouldBeAppended):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
jchaffraix@webkit.org [Tue, 25 Oct 2011 02:53:31 +0000 (02:53 +0000)]
Unreviewed gardening.

Add a new baseline for snow-leopard.

* platform/chromium-mac-snowleopard/svg/filters: Added.
* platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-default-type-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSimplify url accessors on WKBrowsingContextController
weinig@apple.com [Tue, 25 Oct 2011 02:47:22 +0000 (02:47 +0000)]
Simplify url accessors on WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=70797

Reviewed by Anders Carlsson.

* UIProcess/API/C/WKPage.cpp:
(WKPageCopyActiveURL):
(WKPageCopyProvisionalURL):
(WKPageCopyCommittedURL):
* UIProcess/API/C/WKPage.h:
Add accessors to C SPI.

* UIProcess/API/mac/WKBrowsingContextController.h:
Remove unreachableURL accessor for now. It may make a glorious return when we have
error page support.

* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController activeURL]):
(-[WKBrowsingContextController provisionalURL]):
(-[WKBrowsingContextController committedURL]):
Implement these in terms of the new C SPI.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::activeURL):
Add computation of the "active" URL, which is the URL one would show
in an address field. It is the pending URL when there is one, the provisional
URL when there is one, and otherwise the committed/final URL.

(WebKit::WebPageProxy::provisionalURL):
(WebKit::WebPageProxy::committedURL):
Add access to the main frame URL.
* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(80893): HTML5 spec takes 2s longer to load due to time spent in CSSStyleSe...
macpherson@chromium.org [Tue, 25 Oct 2011 02:38:26 +0000 (02:38 +0000)]
REGRESSION(80893): HTML5 spec takes 2s longer to load due to time spent in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=68944

Reviewed by Antti Koivisto.

No new tests / Covered by existing tests.

Removes all virtual dispatch from CSSStyleApplyProperty by converting to use static function pointers for dispatch.
Uses class templates instead of function templates to allow default parameters and also to share parameter declarations across static functions.
All constructor parameters become template parameters. This improves the level of compiler optimization that can be achieved.
Overall this achieved a ~2% overall speedup on run-safari PerformanceTests/Parser/html5-full-render.html,
and profiling showed a reduction in the time spent inside CSSStyleSelector::applyProperty().

* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyExpanding::createHandler):
(WebCore::ApplyPropertyDefaultBase::setValue):
(WebCore::ApplyPropertyDefaultBase::value):
(WebCore::ApplyPropertyDefaultBase::initial):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefaultBase::createHandler):
(WebCore::ApplyPropertyDefault::setValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyDefault::createHandler):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyStyleImage::createHandler):
(WebCore::ApplyPropertyAuto::setValue):
(WebCore::ApplyPropertyAuto::value):
(WebCore::ApplyPropertyAuto::hasAuto):
(WebCore::ApplyPropertyAuto::setAuto):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyAuto::createHandler):
(WebCore::defaultInitialColor):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::createHandler):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyDirection::createHandler):
(WebCore::ApplyPropertyLength::setValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyLength::createHandler):
(WebCore::ApplyPropertyString::setValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyString::createHandler):
(WebCore::ApplyPropertyBorderRadius::setValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyBorderRadius::createHandler):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyFillLayer::createHandler):
(WebCore::ApplyPropertyComputeLength::setValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyComputeLength::createHandler):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFont::createHandler):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontWeight::createHandler):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCounter::createHandler):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyCursor::createHandler):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::createHandler):
(WebCore::ApplyPropertyAnimation::setValue):
(WebCore::ApplyPropertyAnimation::value):
(WebCore::ApplyPropertyAnimation::test):
(WebCore::ApplyPropertyAnimation::clear):
(WebCore::ApplyPropertyAnimation::initial):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::accessAnimations):
(WebCore::ApplyPropertyAnimation::animations):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyAnimation::createHandler):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyOutlineStyle::createHandler):
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleApplyProperty.h:
(WebCore::PropertyHandler::PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):
(WebCore::PropertyHandler::isValid):
(WebCore::PropertyHandler::inheritFunction):
(WebCore::PropertyHandler::initialFunction):
(WebCore::PropertyHandler::applyFunction):
(WebCore::CSSStyleApplyProperty::propertyHandler):
(WebCore::CSSStyleApplyProperty::setPropertyHandler):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::invalidColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCanvas drawImage with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy...
commit-queue@webkit.org [Tue, 25 Oct 2011 02:28:48 +0000 (02:28 +0000)]
Canvas drawImage with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
https://bugs.webkit.org/show_bug.cgi?id=66920

Patch by Ben Wells <benwells@chromium.org> on 2011-10-24
Reviewed by James Robinson.

Source/WebCore:

Test: fast/canvas/canvas-composite-image.html

Use the same method as fills to handle composited drawImage calls that will affect the whole
canvas. To do this code used when doing fills has been factored into seperate functions and
used by drawImage. Some functions used to do these types of operations have also been renamed.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::isFullCanvasCompositeMode):
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::calculateCompositingBufferRect):
(WebCore::CanvasRenderingContext2D::createCompositingBuffer):
(WebCore::CanvasRenderingContext2D::compositeBuffer):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):
* html/canvas/CanvasRenderingContext2D.h:

LayoutTests:

* fast/canvas/canvas-composite-image-expected.txt: Added.
* fast/canvas/canvas-composite-image.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGTK and Windows rebaselines after r98199.
rniwa@webkit.org [Tue, 25 Oct 2011 02:15:18 +0000 (02:15 +0000)]
GTK and Windows rebaselines after r98199.

* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/win/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r98294 and r98306.
jchaffraix@webkit.org [Tue, 25 Oct 2011 01:24:05 +0000 (01:24 +0000)]
Unreviewed, rolling out r98294 and r98306.
http://trac.webkit.org/changeset/98294
http://trac.webkit.org/changeset/98306
https://bugs.webkit.org/show_bug.cgi?id=70790

the first patch broke chromium-mac and the second gclient
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-24

Source/WebCore:

* WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

* WebKit.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Try to fix mac build after r98294
jchaffraix@webkit.org [Tue, 25 Oct 2011 00:44:27 +0000 (00:44 +0000)]
[chromium] Try to fix mac build after r98294
https://bugs.webkit.org/show_bug.cgi?id=70785

Remove test for ScrollAnimatorNone on mac.

Unreviewed, build fix.

Patch by Nico Weber <thakis@chromium.org> on 2011-10-24

* WebKit.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix after r98300.
rniwa@webkit.org [Tue, 25 Oct 2011 00:44:17 +0000 (00:44 +0000)]
Build fix after r98300.

* WebCore.gypi:
* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIt should be possible for Widget subclasses to control whether transforms affect...
andersca@apple.com [Tue, 25 Oct 2011 00:33:10 +0000 (00:33 +0000)]
It should be possible for Widget subclasses to control whether transforms affect the frame rect
https://bugs.webkit.org/show_bug.cgi?id=70787

Reviewed by Sam Weinig.

Currently RenderWidget sets the frame rect of it's hosted widget to the bounding box of the transformed
content box rect (unless the Widget is a frame view). It should be possible for Widget subclasses to override
this behavior and have the frame rect set to the absolute content box without any transforms applied.

* platform/Widget.h:
(WebCore::Widget::transformsAffectFrameRect):
Add new member function.

* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::updateWidgetGeometry):
Move shared code from setWidget and updateWidgetPosition out into a new function. If transformsAffectFrameRect returns
false, just set the frame rect to the absolute content box.

(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):
Call updateWidgetGeometry.

* rendering/RenderWidget.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98304 268f45cc-cd09-0410-ab3c-d52691b4dbfc