WebKit-https.git
10 years ago2011-02-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 28 Feb 2011 21:07:24 +0000 (21:07 +0000)]
2011-02-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        Use more xcconfig files in JavaScriptGlue gyp build
        https://bugs.webkit.org/show_bug.cgi?id=55395

        Technically this patch breaks the build because the generated project
        can't find the Info.plist file or the list of exported symbols.  I'll
        fix that in a follow-up patch.

        * gyp/JavaScriptGlue.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 28 Feb 2011 21:05:22 +0000 (21:05 +0000)]
2011-02-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Make ScopeChainNode GC allocated
        https://bugs.webkit.org/show_bug.cgi?id=55283

        Simplify lifetime and other issues with the scopechain
        by making it gc allocated.  This allows us to simplify
        function exit and unwinding, as well as making the
        current iterative refcounting go away.

        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::createActivation):
        * bytecode/StructureStubInfo.cpp:
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::generate):
        (JSC::BytecodeGenerator::BytecodeGenerator):
        (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
        (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
        * bytecompiler/BytecodeGenerator.h:
        * debugger/Debugger.cpp:
        (JSC::Recompiler::operator()):
        * debugger/DebuggerCallFrame.h:
        (JSC::DebuggerCallFrame::scopeChain):
        * interpreter/CachedCall.h:
        (JSC::CachedCall::CachedCall):
        * interpreter/CallFrame.h:
        * interpreter/Interpreter.cpp:
        (JSC::depth):
        (JSC::Interpreter::unwindCallFrame):
        (JSC::Interpreter::throwException):
        (JSC::Interpreter::execute):
        (JSC::Interpreter::executeCall):
        (JSC::Interpreter::executeConstruct):
        (JSC::Interpreter::privateExecute):
        * jit/JITCall.cpp:
        (JSC::JIT::compileOpCallInitializeCallFrame):
        (JSC::JIT::compileOpCall):
        * jit/JITCall32_64.cpp:
        (JSC::JIT::compileOpCallInitializeCallFrame):
        (JSC::JIT::emit_op_ret):
        (JSC::JIT::emit_op_ret_object_or_this):
        (JSC::JIT::compileOpCall):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_end):
        (JSC::JIT::emit_op_ret):
        (JSC::JIT::emit_op_ret_object_or_this):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::emit_op_end):
        * jit/JITStubs.cpp:
        (JSC::DEFINE_STUB_FUNCTION):
        * jit/JITStubs.h:
        * runtime/ArgList.cpp:
        * runtime/Completion.cpp:
        (JSC::evaluate):
        * runtime/Completion.h:
        * runtime/DateConversion.cpp:
        * runtime/Executable.cpp:
        (JSC::EvalExecutable::compileInternal):
        (JSC::ProgramExecutable::compileInternal):
        (JSC::FunctionExecutable::compileForCallInternal):
        (JSC::FunctionExecutable::compileForConstructInternal):
        * runtime/FunctionConstructor.cpp:
        (JSC::constructFunction):
        * runtime/GCActivityCallbackCF.cpp:
        * runtime/Identifier.cpp:
        * runtime/JSCell.h:
        * runtime/JSChunk.cpp: Added.
        * runtime/JSChunk.h: Added.
        * runtime/JSFunction.cpp:
        (JSC::JSFunction::JSFunction):
        (JSC::JSFunction::markChildren):
        (JSC::JSFunction::getCallData):
        (JSC::JSFunction::getOwnPropertySlot):
        (JSC::JSFunction::getConstructData):
        * runtime/JSFunction.h:
        (JSC::JSFunction::scope):
        (JSC::JSFunction::setScope):
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        * runtime/JSGlobalData.h:
        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::init):
        (JSC::JSGlobalObject::markChildren):
        * runtime/JSGlobalObject.h:
        (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
        (JSC::JSGlobalObject::globalScopeChain):
        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::globalFuncEval):
        * runtime/JSLock.cpp:
        * runtime/JSNumberCell.cpp:
        * runtime/JSZombie.cpp:
        * runtime/MarkedBlock.cpp:
        * runtime/MarkedSpace.cpp:
        * runtime/PropertyNameArray.cpp:
        * runtime/ScopeChain.cpp:
        (JSC::ScopeChainNode::print):
        (JSC::ScopeChainNode::localDepth):
        (JSC::ScopeChainNode::markChildren):
        * runtime/ScopeChain.h:
        (JSC::ScopeChainNode::ScopeChainNode):
        (JSC::ScopeChainNode::createStructure):
        (JSC::ScopeChainNode::push):
        (JSC::ScopeChainNode::pop):
        (JSC::ScopeChainIterator::ScopeChainIterator):
        (JSC::ScopeChainIterator::operator*):
        (JSC::ScopeChainIterator::operator->):
        (JSC::ScopeChainIterator::operator++):
        (JSC::ScopeChainNode::begin):
        (JSC::ScopeChainNode::end):
        (JSC::ExecState::globalData):
        (JSC::ExecState::lexicalGlobalObject):
        (JSC::ExecState::globalThisValue):
        * runtime/ScopeChainMark.h:
        * wtf/DateMath.cpp:
2011-02-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Make ScopeChainNode GC allocated
        https://bugs.webkit.org/show_bug.cgi?id=55283

        Update WebCore to deal with the absence of the ScopeChain
        class.

        * ForwardingHeaders/runtime/ScopeChain.h: Added.
        * bindings/js/JSHTMLElementCustom.cpp:
        (WebCore::JSHTMLElement::pushEventHandlerScope):
        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        (WebCore::JSJavaScriptCallFrame::scopeChain):
        (WebCore::JSJavaScriptCallFrame::scopeType):
        * bindings/js/JSLazyEventListener.cpp:
        (WebCore::JSLazyEventListener::initializeJSFunction):
        * bindings/js/JSMainThreadExecState.h:
        (WebCore::JSMainThreadExecState::evaluate):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::pushEventHandlerScope):
        * bindings/js/JavaScriptCallFrame.cpp:
        (WebCore::JavaScriptCallFrame::scopeChain):
        * bindings/js/JavaScriptCallFrame.h:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/c/c_class.cpp:
        * bridge/c/c_runtime.cpp:
        * bridge/jni/JNIBridge.cpp:
        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtConnectionObject::execute):
        * plugins/PluginViewNone.cpp:
2011-02-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Make ScopeChainNode GC allocated
        https://bugs.webkit.org/show_bug.cgi?id=55283

        More updates for the absence of the ScopeChain class

        * WebView/WebScriptDebugDelegate.mm:
        (-[WebScriptCallFrame scopeChain]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Mon, 28 Feb 2011 20:51:44 +0000 (20:51 +0000)]
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Adele Peterson.

        REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
        https://bugs.webkit.org/show_bug.cgi?id=55323

        Added test case to make sure no focus ring is drawn on selected items.

        * fast/forms/select-listbox-multiple-no-focusring.html: Added.
        * platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.checksum: Added.
        * platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.png: Added.
        * platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Added.
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Adele Peterson.

        REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
        https://bugs.webkit.org/show_bug.cgi?id=55323

        Draw focus ring on selected items only if spatial navigation is enabled.

        Test: fast/forms/select-listbox-multiple-no-focusring.html

        * rendering/RenderBlock.h:
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::addFocusRingRects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Mon, 28 Feb 2011 20:29:51 +0000 (20:29 +0000)]
2011-02-28  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Anders Carlsson.

        We can cancel the plugin load and fail with error before m_manualStream
        got a chance to initialize in PluginView::didReceiveResponse. This can
        happen when we run pending document onload events during plugin load that
        remove the frame from underneath. So, change the assert into a null check.
        https://bugs.webkit.org/show_bug.cgi?id=55307

        * plugins/PluginView.cpp:
        (WebCore::PluginView::didFail):
2011-02-28  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Anders Carlsson.

        Unskip crashing test fast/frames/iframe-plugin-load-remove-document-crash.html.
        https://bugs.webkit.org/show_bug.cgi?id=55307

        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
commit-queue@webkit.org [Mon, 28 Feb 2011 20:25:04 +0000 (20:25 +0000)]
2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Alexey Proskuryakov.

        Build fix for Intel ICC Compiler.
        https://bugs.webkit.org/show_bug.cgi?id=55221

        The virtual inheritance seems to confuse ICC.
        Anything that links with webkit has an undefined reference otherwise.

        * svg/SVGTransformable.cpp:
        (WebCore::SVGTransformable::~SVGTransformable):
        * svg/SVGTransformable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Mon, 28 Feb 2011 20:18:14 +0000 (20:18 +0000)]
2011-02-28  Adam Klein  <adamk@chromium.org>

        Reviewed by James Robinson.

        [chromium] Remove "PASS TEXT" expectation for fast/filesystem/op-get-entry.html
        https://bugs.webkit.org/show_bug.cgi?id=55262

        Test now passes as Chromium has rolled past r76098.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt]tst_QDeclarativeWebView - 8 test cases fail
ossy@webkit.org [Mon, 28 Feb 2011 20:12:40 +0000 (20:12 +0000)]
[Qt]tst_QDeclarativeWebView - 8 test cases fail
https://bugs.webkit.org/show_bug.cgi?id=55214

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-02-28
Reviewed by Andreas Kling.

Fix the API tests for the QML WebView element. The default size of the element should be the size of the QGraphicsWebView
if no preferred width or height are provided (see http://trac.webkit.org/changeset/79672).
I also refactored the tests so we don't use the network but instead a local html file.
QML doesn't support qrc loading so I had to workaround by using a property that I update afterwards.

* tests/qdeclarativewebview/resources/sample.html: Added.
* tests/qdeclarativewebview/resources/webviewtest.qml:
* tests/qdeclarativewebview/resources/webviewtestdefault.qml:
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
(tst_QDeclarativeWebView::preferredWidthTest):
(tst_QDeclarativeWebView::preferredHeightTest):
(tst_QDeclarativeWebView::preferredWidthDefaultTest):
(tst_QDeclarativeWebView::preferredHeightDefaultTest):
* tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 28 Feb 2011 20:03:47 +0000 (20:03 +0000)]
2011-02-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        PDFViewController should hold a reference to the PDF data
        https://bugs.webkit.org/show_bug.cgi?id=55394

        * UIProcess/API/mac/PDFViewController.h:
        * UIProcess/API/mac/PDFViewController.mm:
        (WebKit::PDFViewController::setPDFDocumentData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Dimitri Glazkov <dglazkov@chromium.org>
abarth@webkit.org [Mon, 28 Feb 2011 19:50:24 +0000 (19:50 +0000)]
2011-02-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        Add necessary build steps to JavaScriptGlue GYP project.
        https://bugs.webkit.org/show_bug.cgi?id=55196

        * gyp/JavaScriptGlue.gyp: Added pre- and post- build steps.
        * gyp/JavaScriptGlue.gypi: Added Info.plist.
        * gyp/remove-headers-if-needed.sh: Added.
        * gyp/run-if-exists.sh: Added.
        * gyp/update-info-plist.sh: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Mon, 28 Feb 2011 19:44:13 +0000 (19:44 +0000)]
2011-02-28  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] Resource size is incorrectly reported to WebCore
        https://bugs.webkit.org/show_bug.cgi?id=53228

        * platform/gtk/Skipped: unskipped http/tests/inspector/network-size.html
2011-02-28  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] Resource size is incorrectly reported to WebCore
        https://bugs.webkit.org/show_bug.cgi?id=53228

        When calling didReceiveData we are sending an invalid value for
        lengthReceived. Sometimes we were even passing a boolean value instead of the
        expected integer. We should pass the size of the received data instead of the
        total amount of data received.

        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::gotChunkCallback):
        (WebCore::sendRequestCallback):
        (WebCore::readCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Mon, 28 Feb 2011 19:42:28 +0000 (19:42 +0000)]
2011-02-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Dan Bernstein.

        Cleanup the include guard form an Objective-C files
        https://bugs.webkit.org/show_bug.cgi?id=55379

        Normally Objective-C files do not need include guard.
        r76916 introduced an include guard in EmptyProtocolDefinitions.h.
        The guard is no longer needed after r76991.

        No new tests as there is no new functionality.

        * platform/mac/EmptyProtocolDefinitions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Podivilov <podivilov@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 19:29:59 +0000 (19:29 +0000)]
2011-02-28  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION] no resources in scripts panel because debugger is enabled too early.
        https://bugs.webkit.org/show_bug.cgi?id=55389

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::populateScriptObjects):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::setFrontend):
        (WebCore::InspectorDebuggerAgent::enableDebuggerAfterShown):
        * inspector/InspectorDebuggerAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSize of text in popup menu doesn't match size of text in <select> itself in WebKit2
weinig@apple.com [Mon, 28 Feb 2011 19:19:02 +0000 (19:19 +0000)]
Size of text in popup menu doesn't match size of text in <select> itself in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48234

Reviewed by Darin Adler.

* Shared/TextInfo.cpp: Removed.
* Shared/TextInfo.h: Removed.
Replace this with the more appropriately DictionaryPopupInfo.

* Shared/DictionaryPopupInfo.cpp: Copied from Source/WebKit2/Shared/TextInfo.cpp.
(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
* Shared/DictionaryPopupInfo.h: Copied from Source/WebKit2/Shared/TextInfo.h.
(WebKit::DictionaryPopupInfo::DictionaryPopupInfo):
Replace individual font related fields with FontInfo.

* Shared/FontInfo.cpp: Added.
(WebKit::FontInfo::FontInfo):
(WebKit::FontInfo::encode):
(WebKit::FontInfo::decode):
* Shared/FontInfo.h: Added.
Add class to encapsulate passing a font description over the wire.

* Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):
* Shared/PlatformPopupMenuData.h:
Add FontInfo as extra data for the Mac.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup):
* UIProcess/PageClient.h:
Add scaleFactor and use it to construct a font at the right size.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebPopupMenuProxy.h:
* UIProcess/mac/WebPopupMenuProxyMac.h:
(WebKit::WebPopupMenuProxyMac::create):
* UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::WebPopupMenuProxyMac):
(WebKit::WebPopupMenuProxyMac::populate):
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
* UIProcess/qt/WebPopupMenuProxyQt.cpp:
(WebKit::WebPopupMenuProxyQt::showPopupMenu):
* UIProcess/qt/WebPopupMenuProxyQt.h:
* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::showPopupMenu):
* UIProcess/win/WebPopupMenuProxyWin.h:
* WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:
(WebKit::WebPopupMenu::setUpPlatformData):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation):
Pass scale factor through and rename TextInfo -> DictionaryPopupInfo.

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Mon, 28 Feb 2011 19:08:42 +0000 (19:08 +0000)]
Unreviewed.

[Qt] Add Qt specific expected results for passing fast tests.

* platform/qt/Skipped: Unskip passing tests.
* platform/qt/fast/transforms [...] : Added.
* platform/qt/fast/tokenizer [...] : Added.
* platform/qt/fast/replaced [...] : Added.
* platform/qt/fast/runin [...] : Added.
* platform/qt/fast/selectors [...] : Added.
* platform/qt/fast/table [...] : Added.
* ChangeLog : Remove duplicated ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
commit-queue@webkit.org [Mon, 28 Feb 2011 19:08:22 +0000 (19:08 +0000)]
2011-02-28  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Add clipped version of QWebElement::render method.
        Allows faster rendering of web element part.
        https://bugs.webkit.org/show_bug.cgi?id=50311

        * Api/qwebelement.cpp:
        (QWebElement::render):
        * Api/qwebelement.h:
        * tests/qwebelement/tst_qwebelement.cpp:
        (tst_QWebElement::render):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Mon, 28 Feb 2011 18:58:46 +0000 (18:58 +0000)]
2011-02-28  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations change.

        Skip over fast/overflow/horizontal-scroll-after-back.html added by
        r79844, since it's page cache-specific.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
pfeldman@chromium.org [Mon, 28 Feb 2011 18:30:18 +0000 (18:30 +0000)]
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79877.
        http://trac.webkit.org/changeset/79877
        https://bugs.webkit.org/show_bug.cgi?id=55388

        Breaks chromium build (Requested by antonm_ on #webkit).

        * WebCore.gypi:
        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerChromium::updateContentsIfDirty):
        (WebCore::ContentLayerChromium::resizeUploadBufferForImage):
        (WebCore::ContentLayerChromium::resizeUploadBuffer):
        (WebCore::SkBitmapConditionalAutoLockerPixels::SkBitmapConditionalAutoLockerPixels):
        (WebCore::SkBitmapConditionalAutoLockerPixels::~SkBitmapConditionalAutoLockerPixels):
        (WebCore::SkBitmapConditionalAutoLockerPixels::lockPixels):
        (WebCore::ContentLayerChromium::updateTextureIfNeeded):
        (WebCore::ContentLayerChromium::draw):
        * platform/graphics/chromium/ContentLayerChromium.h:
        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::updateContentsIfDirty):
        * platform/graphics/chromium/ImageLayerChromium.h:
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::contentRectToTileIndices):
        (WebCore::LayerTilerChromium::update):
        * platform/graphics/chromium/LayerTilerChromium.h:
        * platform/graphics/chromium/PlatformCanvas.cpp: Removed.
        * platform/graphics/chromium/PlatformCanvas.h: Removed.
        * platform/graphics/chromium/PlatformImage.cpp: Removed.
        * platform/graphics/chromium/PlatformImage.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Mon, 28 Feb 2011 18:29:40 +0000 (18:29 +0000)]
2011-02-28  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations change.

        Rebaseline fast/forms/listbox-hit-test-zoomed.html after r79762.
        Also make a new other expectations more specific.

        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/forms/listbox-hit-test-zoomed-expected.checksum:
        * platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 28 Feb 2011 18:23:06 +0000 (18:23 +0000)]
2011-02-28  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add live edit test.
        https://bugs.webkit.org/show_bug.cgi?id=55360

        * http/tests/inspector/debugger-test.js:
        (initialize_DebuggerTest):
        * inspector/debugger/debug-inlined-scripts.html:
        * inspector/debugger/live-edit-expected.txt: Added.
        * inspector/debugger/live-edit.html: Added.
        * inspector/debugger/resources/edit-me.js: Added.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-02-28  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add live edit test.
        https://bugs.webkit.org/show_bug.cgi?id=55360

        Test: inspector/debugger/live-edit.html

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._doubleClick):
        (WebInspector.SourceFrame.prototype._didEditLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 18:16:13 +0000 (18:16 +0000)]
2011-02-28  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. More follow ups to XML Viewer tests commit.

        * http/tests/xmlviewer/dumpAsText/frames.html:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 18:11:21 +0000 (18:11 +0000)]
2011-02-28  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Follow up to r79858, removing optimistic assertion that fails on debug bot.

        * inspector/InspectorBrowserDebuggerAgent.cpp:
        (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Adrienne Walker <enne@google.com>
enne@google.com [Mon, 28 Feb 2011 18:03:29 +0000 (18:03 +0000)]
2011-02-25  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Abstract "pixels with a graphics context" into its own class
        https://bugs.webkit.org/show_bug.cgi?id=55259

        This creates new PlatformCanvas/PlatformImage classes which wrap
        all of the #ifdef Skia/Cg warts from the compositor.  All classes
        (LayerTilerChromium, ContentLayerChromium, and ImageLayerChromium) are
        modified to use these abstractions.

        Tests: LayoutTests/compositing

        * WebCore.gypi:
        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerChromium::updateContentsIfDirty):
        (WebCore::ContentLayerChromium::resizeUploadBuffer):
        (WebCore::ContentLayerChromium::updateTextureIfNeeded):
        (WebCore::ContentLayerChromium::updateTexture):
        (WebCore::ContentLayerChromium::draw):
        * platform/graphics/chromium/ContentLayerChromium.h:
        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::updateContentsIfDirty):
        (WebCore::ImageLayerChromium::updateTextureIfNeeded):
        * platform/graphics/chromium/ImageLayerChromium.h:
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::contentRectToTileIndices):
        (WebCore::LayerTilerChromium::update):
        (WebCore::LayerTilerChromium::updateFromPixels):
        * platform/graphics/chromium/LayerTilerChromium.h:
        * platform/graphics/chromium/PlatformCanvas.cpp: Added.
        (WebCore::PlatformCanvas::PlatformCanvas):
        (WebCore::PlatformCanvas::~PlatformCanvas):
        (WebCore::PlatformCanvas::resize):
        (WebCore::PlatformCanvas::AutoLocker::AutoLocker):
        (WebCore::PlatformCanvas::AutoLocker::~AutoLocker):
        (WebCore::PlatformCanvas::Painter::Painter):
        (WebCore::PlatformCanvas::Painter::~Painter):
        * platform/graphics/chromium/PlatformCanvas.h: Added.
        (WebCore::PlatformCanvas::AutoLocker::pixels):
        (WebCore::PlatformCanvas::Painter::context):
        (WebCore::PlatformCanvas::size):
        * platform/graphics/chromium/PlatformImage.cpp: Copied from Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp.
        (WebCore::PlatformImage::PlatformImage):
        (WebCore::PlatformImage::updateFromImage):
        * platform/graphics/chromium/PlatformImage.h: Added.
        (WebCore::PlatformImage::pixels):
        (WebCore::PlatformImage::size):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
pfeldman@chromium.org [Mon, 28 Feb 2011 17:54:42 +0000 (17:54 +0000)]
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79784.
        http://trac.webkit.org/changeset/79784
        https://bugs.webkit.org/show_bug.cgi?id=55386

        This change causes lots of assertion failures in Debug builds
        (Requested by aroben on #webkit).

        * transitions/matched-transform-functions.html:
        * transitions/retargetted-transition.html:
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79784.
        http://trac.webkit.org/changeset/79784
        https://bugs.webkit.org/show_bug.cgi?id=55386

        This change causes lots of assertion failures in Debug builds
        (Requested by aroben on #webkit).

        * css/CSSStyleSelector.cpp:
        (WebCore::convertToLength):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::createTransformOperations):
        * platform/Length.h:
        (WebCore::Length::Length):
        (WebCore::Length::operator==):
        (WebCore::Length::operator!=):
        (WebCore::Length::rawValue):
        (WebCore::Length::type):
        (WebCore::Length::quirk):
        (WebCore::Length::setValue):
        (WebCore::Length::setRawValue):
        (WebCore::Length::calcFloatValue):
        (WebCore::Length::isZero):
        (WebCore::Length::blend):
        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::recalcColumn):
        (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
        * rendering/FixedTableLayout.cpp:
        (WebCore::FixedTableLayout::calcWidthArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 28 Feb 2011 17:51:03 +0000 (17:51 +0000)]
2011-02-28  Andreas Kling  <kling@webkit.org>

        Reviewed by Darin Adler.

        Use Frame::ownerElement() directly where appropriate.
        https://bugs.webkit.org/show_bug.cgi?id=55385

        Don't take the roundabout way through frame->document->ownerElement
        which just checks that the document->frame is non-null.

        No new test, refactoring only.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadWithDocumentLoader):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchLoadEvent):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::scrollRecursively):
        (WebCore::EventHandler::logicalScrollRecursively):
        * page/FrameView.cpp:
        (WebCore::FrameView::init):
        (WebCore::FrameView::layout):
        (WebCore::FrameView::repaintContentRectangle):
        (WebCore::FrameView::windowClipRect):
        (WebCore::FrameView::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 17:43:11 +0000 (17:43 +0000)]
2011-02-28  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: follow up to r79861, moved utf-16-no-bom to its new home, fixed flaky frames.html.

        * fast/encoding/dumpAsText/utf-16-no-bom.xml: Renamed from LayoutTests/fast/encoding/utf-16-no-bom.xml.
        * http/tests/xmlviewer/dumpAsText/frames.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 28 Feb 2011 17:29:51 +0000 (17:29 +0000)]
2011-02-28  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION] source frame is recreated for each inlined script in document.
        https://bugs.webkit.org/show_bug.cgi?id=55377

        * inspector/debugger/scripts-panel-expected.txt:
        * inspector/debugger/scripts-panel.html:
2011-02-28  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION] source frame is recreated for each inlined script in document.
        https://bugs.webkit.org/show_bug.cgi?id=55377

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
        (WebInspector.ScriptsPanel.prototype._sourceFrameForSourceName):
        (WebInspector.ScriptsPanel.prototype._createSourceFrame):
        (WebInspector.ScriptsPanel.prototype._recreateSourceFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Mon, 28 Feb 2011 17:22:45 +0000 (17:22 +0000)]
Unreviewed.

[Qt] Remove non-existent tests from Skipped list after r79861.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Mon, 28 Feb 2011 17:20:22 +0000 (17:20 +0000)]
2011-02-28  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed build fix for !ENABLE(SVG_ANIMATION) after r79569.

        * svg/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ossy@webkit.org [Mon, 28 Feb 2011 17:16:08 +0000 (17:16 +0000)]
Unreviewed.

[Qt] Add Qt specific expected results for passing fast/css tests.

* platform/qt/Skipped:
* platform/qt/fast/css [...] : Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOne more rename as a followup to r79868
aroben@apple.com [Mon, 28 Feb 2011 16:55:46 +0000 (16:55 +0000)]
One more rename as a followup to r79868

Rubber-stamped by Anders Carlsson.

* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
Rename stateDidChange to backingStoreStateDidChange.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename DrawingArea[Proxy]Impl's "state ID" concept to "backing store state ID"
aroben@apple.com [Mon, 28 Feb 2011 16:53:03 +0000 (16:53 +0000)]
Rename DrawingArea[Proxy]Impl's "state ID" concept to "backing store state ID"

Rubber-stamped (and suggested) by Anders Carlsson.

* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxy.messages.in:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
* WebProcess/WebPage/DrawingAreaImpl.h:
Perform the rename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDecouple state changes from sending of UpdateState messages in DrawingAreaProxyImpl
aroben@apple.com [Mon, 28 Feb 2011 16:35:32 +0000 (16:35 +0000)]
Decouple state changes from sending of UpdateState messages in DrawingAreaProxyImpl

The new DrawingAreaProxyImpl::stateDidChange function should be called whenever
DrawingAreaProxyImpl's state changes in a way that will require allocating a new backing
store. (Currently, this is just when the size changes.) This function will sometimes (but
not always, as when we're waiting for a DidUpdateState message) send an UpdateState message
to the web process. This means it's now possible for the state IDs sent in consecutive
UpdateState messages to increase by more than one, but that's OK.

This should cause no change in behavior.

Fixes <http://webkit.org/b/55382> DrawingAreaProxyImpl's state ID should be updated whenever
its state changes, not just when we send an UpdateState message

Reviewed by Anders Carlsson.

* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Updated for rename.
(WebKit::DrawingAreaProxyImpl::sizeDidChange): Changed to call stateDidChange.
(WebKit::DrawingAreaProxyImpl::didUpdateState): Updated for rename, and changed to call
sendUpdateState whenever our state has changed for any reason since the last UpdateState
message was sent.
(WebKit::DrawingAreaProxyImpl::stateDidChange): Added. Increments m_nextStateID and calls
through to sendUpdateState.
(WebKit::DrawingAreaProxyImpl::sendUpdateState): Updated for rename, moved incrementing of
the state ID we send to the web process from here to stateDidChange, and added an assertion.

* UIProcess/DrawingAreaProxyImpl.h: Renamed m_requestedStateID to m_nextStateID, and updated
the comment explaining its meaning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Renata Hodovan <reni@webkit.org>
reni@webkit.org [Mon, 28 Feb 2011 16:16:39 +0000 (16:16 +0000)]
2011-02-28  Renata Hodovan  <reni@webkit.org>

        Reviewed by Andreas Kling.

        Optimize parameter transmissions in FEConvolveMatrix.
        https://bugs.webkit.org/show_bug.cgi?id=55381

        Parameter transmission via reference is more efficient than with copy. So they are substituted.

        No new tests are needed since this is a refactoring.

        * platform/graphics/filters/FEConvolveMatrix.cpp:
        (WebCore::FEConvolveMatrix::setKernelSize):
        (WebCore::FEConvolveMatrix::setTargetOffset):
        (WebCore::FEConvolveMatrix::setKernelUnitLength):
        * platform/graphics/filters/FEConvolveMatrix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip a sometimes-crashing test on Windows
aroben@apple.com [Mon, 28 Feb 2011 16:05:42 +0000 (16:05 +0000)]
Skip a sometimes-crashing test on Windows

The failure is tracked by <http://webkit.org/b/55375>.

* platform/win/Skipped: Added http/tests/websocket/tests/reload-crash.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 28 Feb 2011 15:50:29 +0000 (15:50 +0000)]
2011-02-28  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Fix Chromium tests failures due to r79858.

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::inspectedPageDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPass the right dirty rect to Plugin::paint
aroben@apple.com [Mon, 28 Feb 2011 15:31:47 +0000 (15:31 +0000)]
Pass the right dirty rect to Plugin::paint

A typo in r79040 broke this. Much of this patch is just support for testing the fix.

Fixes <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
Large portions of pages with plugins paint black

Reviewed by Anders Carlsson.

Source/WebKit2:

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::paint): Pass the dirty rect we calculated earlier to Plugin::paint,
rather than just passing along the dirty rect that was passed into this function. This is
the bug fix.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageForceRepaint):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
Added new SPI. Just calls through to WebPage::forceRepaintWithoutCallback.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::forceRepaintWithoutCallback): Moved code to force a repaint here...
(WebKit::WebPage::forceRepaint): ...from here.

* WebProcess/WebPage/WebPage.h: Added forceRepaintWithoutCallback.

Tools:

Add a test for the paint rect passed via WM_PAINT to windowless plugins

* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPP_HandleEvent):
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
Added NPP_HandleEvent. Just returns 0 at this level.

* DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added.
(WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class.
(WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless.
(WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via
WM_PAINT has the expected coordinates.

* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything
else.

* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS
resort things.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint.
This is roughly equivalent to the call to -[WebView displayIfNeeded] in -[FrameLoadDelegate
webView:didFinishLoadForFrame:] in DumpRenderTree.

* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::PlatformWebView): Tell the WKView it's in a window so that plugins
can start running.

LayoutTests:

Add a test for the paint rect passed via WM_PAINT to windowless plugins

* platform/win-wk2/platform/win/plugins/windowless-paint-rect-coordinates-expected.txt: Added.
* platform/win/plugins/windowless-paint-rect-coordinates-expected.txt: Added. WebKit1
doesn't pass a paint rect via WM_PAINT, so we have different results there.
* platform/win/plugins/windowless-paint-rect-coordinates.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTell MiniBrowser's WKViews that they're in a window
aroben@apple.com [Mon, 28 Feb 2011 15:30:33 +0000 (15:30 +0000)]
Tell MiniBrowser's WKViews that they're in a window

Fixes <http://webkit.org/b/55364> Plugins don't work in MiniBrowser on Windows

Reviewed by Anders Carlsson.

* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create): Call WKViewSetIsInWindow after creating the view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Vsevolod Vlasov <vsevik@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 15:26:44 +0000 (15:26 +0000)]
2011-02-28  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        XML without style should render as syntax-highlighted source.
        https://bugs.webkit.org/show_bug.cgi?id=13807

        Added tests for XML tree view mode. Testing both logic for entering
        XML tree view mode and rendering itself.
        Tests are disabled for QT since this logic is not yet implemented, see
        https://bugs.webkit.org/show_bug.cgi?id=55302

        * fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt: Copied from LayoutTests/fast/css/xml-stylesheet-pi-not-in-prolog.xml.
        * fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog.xml: Renamed from LayoutTests/fast/css/xml-stylesheet-pi-not-in-prolog.xml.
        * fast/encoding/dumpAsText/utf-16-no-bom-expected.txt: Added.
        * fast/encoding/dumpAsText/utf-16-no-bom.xml: Renamed from LayoutTests/fast/encoding/utf-16-no-bom.xml.
        * http/tests/xmlviewer/dumpAsText/css-stylesheet-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/css-stylesheet.xml: Added.
        * http/tests/xmlviewer/dumpAsText/frames-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/frames.html: Added.
        * http/tests/xmlviewer/dumpAsText/mathml-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/mathml.xml: Added.
        * http/tests/xmlviewer/dumpAsText/resources/css-stylesheet.css: Added.
        (assertion):
        * http/tests/xmlviewer/dumpAsText/resources/frames-helper.xml: Added.
        * http/tests/xmlviewer/dumpAsText/resources/xsl.xml: Added.
        * http/tests/xmlviewer/dumpAsText/svg-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/svg.xml: Added.
        * http/tests/xmlviewer/dumpAsText/wml-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/wml.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xhtml-tag-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xhtml-tag.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xlink-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xlink.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xsl-stylesheet-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xul-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xul.xml: Added.
        * platform/chromium-linux/fast/css/xml-stylesheet-pi-not-in-prolog-expected.checksum: Removed.
        * platform/chromium-linux/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
        * platform/chromium-linux/fast/encoding/utf-16-no-bom-expected.checksum: Removed.
        * platform/chromium-linux/fast/encoding/utf-16-no-bom-expected.png: Removed.
        * platform/chromium-linux/svg/hixie/error/004-expected.checksum: Removed.
        * platform/chromium-linux/svg/hixie/error/004-expected.png: Removed.
        * platform/chromium-linux/svg/hixie/error/005-expected.checksum: Removed.
        * platform/chromium-linux/svg/hixie/error/005-expected.png: Removed.
        * platform/chromium-win/fast/css/xml-stylesheet-pi-not-in-prolog-expected.checksum: Removed.
        * platform/chromium-win/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
        * platform/chromium-win/fast/css/xml-stylesheet-pi-not-in-prolog-expected.txt: Removed.
        * platform/chromium-win/fast/encoding/utf-16-no-bom-expected.checksum: Removed.
        * platform/chromium-win/fast/encoding/utf-16-no-bom-expected.png: Removed.
        * platform/chromium-win/fast/encoding/utf-16-no-bom-expected.txt: Removed.
        * platform/chromium-win/svg/hixie/error/004-expected.checksum: Removed.
        * platform/chromium-win/svg/hixie/error/004-expected.png: Removed.
        * platform/chromium-win/svg/hixie/error/004-expected.txt: Removed.
        * platform/chromium-win/svg/hixie/error/005-expected.checksum: Removed.
        * platform/chromium-win/svg/hixie/error/005-expected.png: Removed.
        * platform/chromium-win/svg/hixie/error/005-expected.txt: Removed.
        * platform/chromium/http/tests/xmlviewer/dumpAsText/mathml-expected.txt: Added.
        * platform/gtk/fast/css/xml-stylesheet-pi-not-in-prolog-expected.checksum: Removed.
        * platform/gtk/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
        * platform/gtk/fast/css/xml-stylesheet-pi-not-in-prolog-expected.txt: Removed.
        * platform/gtk/fast/encoding/utf-16-no-bom-expected.checksum: Removed.
        * platform/gtk/fast/encoding/utf-16-no-bom-expected.png: Removed.
        * platform/gtk/fast/encoding/utf-16-no-bom-expected.txt: Removed.
        * platform/gtk/svg/hixie/error/004-expected.checksum: Removed.
        * platform/gtk/svg/hixie/error/004-expected.png: Removed.
        * platform/gtk/svg/hixie/error/004-expected.txt: Removed.
        * platform/gtk/svg/hixie/error/005-expected.checksum: Removed.
        * platform/gtk/svg/hixie/error/005-expected.png: Removed.
        * platform/gtk/svg/hixie/error/005-expected.txt: Removed.
        * platform/mac-leopard/fast/css/xml-stylesheet-pi-not-in-prolog-expected.checksum: Removed.
        * platform/mac-leopard/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
        * platform/mac-leopard/fast/encoding/utf-16-no-bom-expected.checksum: Removed.
        * platform/mac-leopard/fast/encoding/utf-16-no-bom-expected.png: Removed.
        * platform/mac-leopard/svg/hixie/error/004-expected.checksum: Removed.
        * platform/mac-leopard/svg/hixie/error/004-expected.png: Removed.
        * platform/mac-leopard/svg/hixie/error/005-expected.checksum: Removed.
        * platform/mac-leopard/svg/hixie/error/005-expected.png: Removed.
        * platform/mac/fast/css/xml-stylesheet-pi-not-in-prolog-expected.checksum: Removed.
        * platform/mac/fast/css/xml-stylesheet-pi-not-in-prolog-expected.png: Removed.
        * platform/mac/fast/css/xml-stylesheet-pi-not-in-prolog-expected.txt: Removed.
        * platform/mac/fast/encoding/utf-16-no-bom-expected.checksum: Removed.
        * platform/mac/fast/encoding/utf-16-no-bom-expected.png: Removed.
        * platform/mac/fast/encoding/utf-16-no-bom-expected.txt: Removed.
        * platform/mac/svg/hixie/error/004-expected.checksum: Removed.
        * platform/mac/svg/hixie/error/004-expected.png: Removed.
        * platform/mac/svg/hixie/error/004-expected.txt: Removed.
        * platform/mac/svg/hixie/error/005-expected.checksum: Removed.
        * platform/mac/svg/hixie/error/005-expected.png: Removed.
        * platform/mac/svg/hixie/error/005-expected.txt: Removed.
        * platform/qt/Skipped:
        * platform/qt/fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt: Added.
        * platform/qt/fast/css/xml-stylesheet-pi-not-in-prolog-expected.txt: Removed.
        * platform/qt/fast/encoding/dumpAsText/utf-16-no-bom-expected.txt: Added.
        * platform/qt/fast/encoding/utf-16-no-bom-expected.txt: Removed.
        * platform/qt/svg/hixie/error/004-expected.txt: Removed.
        * platform/qt/svg/hixie/error/005-expected.txt: Removed.
        * platform/qt/svg/hixie/error/dumpAsText/004-expected.txt: Added.
        * platform/qt/svg/hixie/error/dumpAsText/005-expected.txt: Added.
        * svg/hixie/error/dumpAsText/004-expected.txt: Added.
        * svg/hixie/error/dumpAsText/004.xml: Renamed from LayoutTests/svg/hixie/error/004.xml.
        * svg/hixie/error/dumpAsText/005-expected.txt: Added.
        * svg/hixie/error/dumpAsText/005.xml: Renamed from LayoutTests/svg/hixie/error/005.xml.
2011-02-28  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        XML without style should render as syntax-highlighted source.
        https://bugs.webkit.org/show_bug.cgi?id=13807

        XML tree view mode implemented. If XML does not have any style
        information, it is rendered as highlighted source with collapsable
        elements.

        Tests: fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog.xml
               fast/encoding/dumpAsText/utf-16-no-bom.xml
               http/tests/xmlviewer/dumpAsText/css-stylesheet.xml
               http/tests/xmlviewer/dumpAsText/frames.html
               http/tests/xmlviewer/dumpAsText/mathml.xml
               http/tests/xmlviewer/dumpAsText/svg.xml
               http/tests/xmlviewer/dumpAsText/wml.xml
               http/tests/xmlviewer/dumpAsText/xhtml-tag.xml
               http/tests/xmlviewer/dumpAsText/xlink.xml
               http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml
               http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml
               http/tests/xmlviewer/dumpAsText/xmlviewer.xml
               http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml
               http/tests/xmlviewer/dumpAsText/xul.xml
               svg/hixie/error/dumpAsText/004.xml
               svg/hixie/error/dumpAsText/005.xml

        * CMakeLists.txt:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::matchUARules):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::createElement):
        * dom/Document.h:
        (WebCore::Document::usesViewSourceStyles):
        (WebCore::Document::setUsesViewSourceStyles):
        (WebCore::Document::sawElementsInKnownNamespaces):
        * dom/XMLDocumentParser.h:
        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::XMLDocumentParser::XMLDocumentParser):
        (WebCore::XMLDocumentParser::processingInstruction):
        (WebCore::XMLDocumentParser::initializeParserContext):
        (WebCore::XMLDocumentParser::doEnd):
        * dom/XMLDocumentParserQt.cpp:
        (WebCore::XMLDocumentParser::XMLDocumentParser):
        (WebCore::XMLDocumentParser::initializeParserContext):
        (WebCore::XMLDocumentParser::parseProcessingInstruction):
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
        * xml/XMLTreeViewer.cpp: Added.
        (WebCore::XMLTreeViewer::XMLTreeViewer):
        (WebCore::XMLTreeViewer::hasNoStyleInformation):
        (WebCore::XMLTreeViewer::transformDocumentToTreeView):
        * xml/XMLTreeViewer.h: Added.
        (WebCore::XMLTreeViewer::~XMLTreeViewer):
        * xml/XMLViewer.xsl: Added.
        * xml/XSLStyleSheet.h:
        (WebCore::XSLStyleSheet::createForXMLTreeViewer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNvel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 15:14:18 +0000 (15:14 +0000)]
Nvel Feldman  <pfeldman@chromium.org>

        Not reviewed: skipping new inspector network tests on win.

        * platform/win/Skipped:ot reviewed: skipping new inspector network tests on win.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
commit-queue@webkit.org [Mon, 28 Feb 2011 14:55:44 +0000 (14:55 +0000)]
2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Csaba Osztrogonác.

        The new QML tests require QML_IMPORT_PATH variable to be set in order to
        load the proper plugin.

        * Scripts/run-qtwebkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 28 Feb 2011 14:49:33 +0000 (14:49 +0000)]
2011-02-28  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: debugger agents should have same livetime as InspectorAgent
        https://bugs.webkit.org/show_bug.cgi?id=55369

        * inspector/report-protocol-errors-expected.txt:
        * inspector/report-protocol-errors.html:
2011-02-28  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: debugger agents should have same livetime as InspectorAgent
        https://bugs.webkit.org/show_bug.cgi?id=55369

        DOM and JS debugger agents are now created in InspectorAgent's constructor and owned
        by the agent. Debugger state is cleared on frontend disconnect.

        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
        (WebCore::InspectorAgent::setFrontend):
        (WebCore::InspectorAgent::disconnectFrontend):
        (WebCore::InspectorAgent::populateScriptObjects):
        (WebCore::InspectorAgent::didCommitLoad):
        (WebCore::InspectorAgent::showScriptsPanel):
        * inspector/InspectorAgent.h:
        * inspector/InspectorBrowserDebuggerAgent.cpp:
        (WebCore::InspectorBrowserDebuggerAgent::create):
        (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
        (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
        (WebCore::InspectorBrowserDebuggerAgent::debuggerWasEnabled):
        (WebCore::InspectorBrowserDebuggerAgent::debuggerWasDisabled):
        (WebCore::InspectorBrowserDebuggerAgent::disable):
        (WebCore::InspectorBrowserDebuggerAgent::setFrontend):
        (WebCore::InspectorBrowserDebuggerAgent::clearFrontend):
        (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints):
        (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
        (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
        (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
        (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
        (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
        (WebCore::InspectorBrowserDebuggerAgent::clear):
        * inspector/InspectorBrowserDebuggerAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::debuggerEnabled):
        (WebCore::InspectorController::showAndEnableDebugger):
        (WebCore::InspectorController::disableDebugger):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::create):
        (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::startUserInitiatedDebugging):
        (WebCore::InspectorDebuggerAgent::enable):
        (WebCore::InspectorDebuggerAgent::disable):
        (WebCore::InspectorDebuggerAgent::enabled):
        (WebCore::InspectorDebuggerAgent::restore):
        (WebCore::InspectorDebuggerAgent::setFrontend):
        (WebCore::InspectorDebuggerAgent::clearFrontend):
        (WebCore::InspectorDebuggerAgent::setJavaScriptBreakpoint):
        (WebCore::InspectorDebuggerAgent::removeJavaScriptBreakpoint):
        (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
        (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
        (WebCore::InspectorDebuggerAgent::currentCallFrames):
        (WebCore::InspectorDebuggerAgent::didParseSource):
        (WebCore::InspectorDebuggerAgent::clear):
        * inspector/InspectorDebuggerAgent.h:
        (WebCore::InspectorDebuggerAgent::enable):
        (WebCore::InspectorDebuggerAgent::disable):
        (WebCore::InspectorDebuggerAgent::Listener::~Listener):
        (WebCore::InspectorDebuggerAgent::setListener):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
        (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
        (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype.enableDebugger):
        (WebInspector.DebuggerModel.prototype.disableDebugger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 14:25:05 +0000 (14:25 +0000)]
2011-02-28  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: updated inspector test harness and chromium expectations.

        * http/tests/inspector/network/network-size-expected.txt:
        * http/tests/inspector/network/network-timing.html:
        * http/tests/inspector/network/resources/resource.php:
        * platform/chromium/http/tests/inspector/network/network-size-expected.txt: Copied from LayoutTests/http/tests/inspector/network/network-size-expected.txt.
        * platform/gtk/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Renata Hodovan <reni@webkit.org>
reni@webkit.org [Mon, 28 Feb 2011 14:03:06 +0000 (14:03 +0000)]
2011-02-28  Renata Hodovan  <reni@webkit.org>

        Reviewed by Andreas Kling.

        FECompositeElement changes doesn't require relayout.
        https://bugs.webkit.org/show_bug.cgi?id=55367

        When the FECompositeElement receives an update message but the given value remains the same we don't need
        to relayout the filter.

        No new tests are needed because this modification is covered by the dynamic update tests of FEComposite.

        * platform/graphics/filters/FEComposite.cpp:
        (WebCore::FEComposite::setOperation):
        (WebCore::FEComposite::setK1):
        (WebCore::FEComposite::setK2):
        (WebCore::FEComposite::setK3):
        (WebCore::FEComposite::setK4):
        * platform/graphics/filters/FEComposite.h:
        * svg/SVGFECompositeElement.cpp:
        (WebCore::SVGFECompositeElement::setFilterEffectAttribute):
        (WebCore::SVGFECompositeElement::svgAttributeChanged):
        * svg/SVGFECompositeElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 28 Feb 2011 13:46:06 +0000 (13:46 +0000)]
2011-02-28  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        FrameLoader: Reorder early-returns in checkCompleted()
        https://bugs.webkit.org/show_bug.cgi?id=55366

        Check allChildrenAreComplete() last, since it's the most expensive.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::checkCompleted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 28 Feb 2011 13:24:25 +0000 (13:24 +0000)]
2011-02-28  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Range::processContents needs cleanup
        https://bugs.webkit.org/show_bug.cgi?id=51006

        Refactored Range::processContents.  Extracted childOfCommonRootBeforeOffset from processContents
        which is used to find processStart and processEnd respectively.  In the case of processStart,
        we use the next sibling of the node returned by childOfCommonRootBeforeOffset when m_start is not
        the common root because copying m_start's ancestors will result in processing too much contents.

        Also extracted processNodes and deleteCharacterData from processContents and processContentsBetweenOffsets.

        In addition, lengthOfContentsInNode was modified to return the correct length instead of
        numeric_limits<unsigned>::max() because the convention that processContentsBetweenOffsets automatically
        corrects the length when endOffset is numeric_limits<unsigned>::max() seemed more confusing than
        having two switch statements that need to be consistent.

        Historically, lengthOfContentsInNode was introduced in r78413 as a build fix because unsigned const
        LengthOfContentsInNode added in r78409 violated WebKit C++ rules and caused build failures on Mac and
        other ports.

        * dom/Range.cpp:
        (WebCore::childOfCommonRootBeforeOffset): Extracted from processContents.
        (WebCore::lengthOfContentsInNode): Added.
        (WebCore::Range::processContents): Calls childOfCommonRootBeforeOffset, lengthOfContentsInNode,
        and processNodes.
        (WebCore::deleteCharacterData): Added.
        (WebCore::Range::processContentsBetweenOffsets): Calls deleteCharacterData and processNodes.
        (WebCore::Range::processNodes): Extracted from processContents and processContentsBetweenOffsets.
        (WebCore::Range::processAncestorsAndTheirSiblings):
        * dom/Range.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 11:47:46 +0000 (11:47 +0000)]
2011-02-28  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Test harness change follow up.
        Consider missing localized string a warning, not an error in the front-end.

        * inspector/front-end/inspector.js:
        (WebInspector.UIString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Steve Block <steveblock@google.com>
steveblock@google.com [Mon, 28 Feb 2011 11:40:22 +0000 (11:40 +0000)]
2011-02-28  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        getJNIEnv() passes wrong type to AttachCurrentThread() for JNIEnv argument on Android
        https://bugs.webkit.org/show_bug.cgi?id=55218

        AttachCurrentThread() in Android's JVM takes a JINEnv**
        argument.

        No new tests, build fix only.

        * bridge/jni/JNIUtility.cpp:
        (JSC::Bindings::getJNIEnv):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Renata Hodovan <reni@webkit.org>
reni@webkit.org [Mon, 28 Feb 2011 11:31:11 +0000 (11:31 +0000)]
2011-02-28  Renata Hodovan  <reni@webkit.org>

        Reviewed by Andreas Kling.

        FETurbulenceElement changes doesn't require relayout
        https://bugs.webkit.org/show_bug.cgi?id=55141

        When the FETurbulenceElement receives an update message but the given value remains the same we don't need
        to relayout the filter.
        Besides fix a typo in FETurbulence and change the paramterer type of FETurbulence::setNumOctaves from bool
        to int according to the spec.

        No new tests are needed because this modification is covered by the dynamic update tests of FETurbulence.

        * platform/graphics/filters/FETurbulence.cpp:
        (WebCore::FETurbulence::FETurbulence):
        (WebCore::FETurbulence::create):
        (WebCore::FETurbulence::type):
        (WebCore::FETurbulence::setType):
        (WebCore::FETurbulence::setBaseFrequencyY):
        (WebCore::FETurbulence::setBaseFrequencyX):
        (WebCore::FETurbulence::setSeed):
        (WebCore::FETurbulence::setNumOctaves):
        (WebCore::FETurbulence::setStitchTiles):
        (WebCore::operator<<):
        * platform/graphics/filters/FETurbulence.h:
        * svg/SVGFETurbulenceElement.cpp:
        (WebCore::SVGFETurbulenceElement::setFilterEffectAttribute):
        (WebCore::SVGFETurbulenceElement::svgAttributeChanged):
        (WebCore::SVGFETurbulenceElement::build):
        * svg/SVGFETurbulenceElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 11:23:55 +0000 (11:23 +0000)]
2011-02-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: InspectorAgent calls offsetWidth in the middle of painting
        https://bugs.webkit.org/show_bug.cgi?id=54597

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::drawElementTitle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 11:21:20 +0000 (11:21 +0000)]
2011-02-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add first network test, improve harness.
        https://bugs.webkit.org/show_bug.cgi?id=55306

        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.assertGreaterOrEqual):
        * http/tests/inspector/network/network-size-expected.txt: Added.
        * http/tests/inspector/network/network-size.html: Added.
        * http/tests/inspector/network/network-timing-expected.txt: Added.
        * http/tests/inspector/network/network-timing.html: Added.
        * http/tests/inspector/network/resources/resource.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Kristian Amlie <kristian.amlie@nokia.com>
commit-queue@webkit.org [Mon, 28 Feb 2011 11:06:46 +0000 (11:06 +0000)]
2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Andreas Kling.

        Added full webkit module profile and a syncqt profile.

        This is for modularized Qt.

        [Qt] WebKit patches required to work with a modularized version of Qt
        https://bugs.webkit.org/show_bug.cgi?id=53916

        * Source/sync.profile: Added.
2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Andreas Kling.

        Added full webkit module profile and a syncqt profile.

        This is for modularized Qt.

        [Qt] WebKit patches required to work with a modularized version of Qt
        https://bugs.webkit.org/show_bug.cgi?id=53916

        * qt_webkit_version.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Joone Hur <joone.hur@collabora.co.uk>
joone.hur@collabora.co.uk [Mon, 28 Feb 2011 10:49:56 +0000 (10:49 +0000)]
2011-02-28  Joone Hur  <joone.hur@collabora.co.uk>

        Unreviewed, fix spelling mistake.

        hardware-accelated => hardware-accelerated.

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Kristian Amlie <kristian.amlie@nokia.com>
commit-queue@webkit.org [Mon, 28 Feb 2011 10:04:21 +0000 (10:04 +0000)]
2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Andreas Kling.

        Made sure that the build-webkit --qmake argument is always respected.

        Previously, it would be respected during the build, but not during
        the early feature detection. The build would also fail if qmake was
        not in your path, even if you specified --qmake with a valid qmake
        binary.

        [Qt] WebKit patches required to work with a modularized version of Qt
        https://bugs.webkit.org/show_bug.cgi?id=53916

        * Scripts/build-webkit:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Mon, 28 Feb 2011 08:45:22 +0000 (08:45 +0000)]
2011-02-28  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Kent Tamura.

        Bug 55355 - TextIterator should not be a friend of RenderTextControl
        https://bugs.webkit.org/show_bug.cgi?id=55355

        Remove need for 'friend' clause by making innerTextElement() public.

        No new tests. (simple refactoring)

        * rendering/RenderTextControl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-27 Aparna Nandyal <aparna.nand@wipro.com>
commit-queue@webkit.org [Mon, 28 Feb 2011 07:30:10 +0000 (07:30 +0000)]
2011-02-27  Aparna Nandyal  <aparna.nand@wipro.com>

        Reviewed by Antonio Gomes.

        [Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
        https://bugs.webkit.org/show_bug.cgi?id=53917

        The bug got fixed by other changes. Adding test case to avoid
        regressions in the future.

        * fast/overflow/horizontal-scroll-after-back-expected.txt: Added.
        * fast/overflow/horizontal-scroll-after-back.html: Added.
2011-02-27  Aparna Nandyal  <aparna.nand@wipro.com>

        Reviewed by Antonio Gomes.

        [Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
        https://bugs.webkit.org/show_bug.cgi?id=53917

        Adding test case to check the scenario to avoid regressions in the
        future.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-27 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 07:28:49 +0000 (07:28 +0000)]
2011-02-27  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Darin Fisher.

        Pass frame history state in the context menu parameters.
        https://bugs.webkit.org/show_bug.cgi?id=55232

        * public/WebContextMenuData.h:
        * src/ContextMenuClientImpl.cpp:
        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-27 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Mon, 28 Feb 2011 06:53:41 +0000 (06:53 +0000)]
2011-02-27  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecWinCE
        https://bugs.webkit.org/show_bug.cgi?id=55317

        This functions are obsolete, since r78499 added TextCodecUTF8.
        Also remove the "fast path" for UTF-8 data, because we now have a separate TextCodec.

        * platform/text/TextEncodingRegistry.cpp:
        (WebCore::buildBaseTextCodecMaps):
        * platform/text/wince/TextCodecWinCE.cpp:
        * platform/text/wince/TextCodecWinCE.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-27 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 28 Feb 2011 05:49:30 +0000 (05:49 +0000)]
2011-02-27  Ojan Vafai  <ojan@chromium.org>

        Fix failing tests from http://trac.webkit.org/changeset/79837.

        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        This was just a mistake that would break if someone tried printing with this configuration.
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        Method signature changed. Didn't notice that this method was being calling in a unittest.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-24 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Mon, 28 Feb 2011 05:18:57 +0000 (05:18 +0000)]
2011-02-24  Hayato Ito  <hayato@chromium.org>

        Reviewed by Eric Seidel.

        [NRWT] Remove test_types/* classes.

        This is the last patch in the series of efforts which tried to remove test_types classes.
        A single_test_runner module will take over responsibilities of test_type classes.

        From this patch, we won't display statistics per test_type even if a '--verbose' option is given.

        https://bugs.webkit.org/show_bug.cgi?id=55123

        * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
        * Scripts/webkitpy/layout_tests/test_types/__init__.py: Removed.
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
        * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
        * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoForce dictionary popup to use overlay type
weinig@apple.com [Mon, 28 Feb 2011 04:35:21 +0000 (04:35 +0000)]
Force dictionary popup to use overlay type
<rdar://problem/9052483>
https://bugs.webkit.org/show_bug.cgi?id=55337

Reviewed by Dan Bernstein.

* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup): As this is only
used for the hot key version of the dictionary popup, force the overlay
style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Mon, 28 Feb 2011 04:00:37 +0000 (04:00 +0000)]
2011-02-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kent Tamura.

        [EFL] Restore parameters of efl header files.
        https://bugs.webkit.org/show_bug.cgi?id=55292

        Restore parameters in efl header files.

        * ewk/ewk_frame.h:
        * ewk/ewk_tiled_backing_store.h:
        * ewk/ewk_tiled_matrix.h:
        * ewk/ewk_tiled_model.h:
        * ewk/ewk_view.cpp:
        (ewk_view_pre_render_relative_radius):
        * ewk/ewk_view.h:
        * ewk/ewk_window_features.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 28 Feb 2011 03:55:14 +0000 (03:55 +0000)]
2011-02-25  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        Change results.json format to the one used by unexpected_results.json
        https://bugs.webkit.org/show_bug.cgi?id=52267

        Also add runtimes in milliseconds to the JSON and make the output format more compact.
        Named the file full_results.json to avoid conflicting with the results.json
        file the test-results server currently serves up.

        * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 28 Feb 2011 03:39:20 +0000 (03:39 +0000)]
2011-02-25  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] fix expand links on git diffs
        https://bugs.webkit.org/show_bug.cgi?id=55208

        In git diffs, we don't have a "revision" span at the end
        of each FileDiff.
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 28 Feb 2011 03:11:44 +0000 (03:11 +0000)]
2011-02-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement WTF::randomNumber in terms of WTF::cryptographicallyRandomNumber when possible
        https://bugs.webkit.org/show_bug.cgi?id=55326

        Currently, randomNumber does a bunch of platform-specific work that to
        get a cryptographic randomness when available.  Instead, we should use
        cryptographicallyRandomNumber, which abstracts this work.
        Unfortunately, we can't remove all of the WTF::randomNumber
        implementation because not every port has access to cryptographically
        random numbers.

        * wtf/RandomNumber.cpp:
        (WTF::randomNumber):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Mon, 28 Feb 2011 01:33:53 +0000 (01:33 +0000)]
2011-02-27  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Sam Weinig.

        Use OwnPtr to handle the memory of RenderBlock::m_floatingObjects and RenderBlock::m_positionedObjects
        https://bugs.webkit.org/show_bug.cgi?id=55327

        Refactor RenderBlock to use OwnPtr for m_floatingObjects and m_positionedObjects so we do not have
        to release the memory manually.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::~RenderBlock):
        (WebCore::RenderBlock::selectionGaps):
        (WebCore::RenderBlock::insertPositionedObject):
        (WebCore::RenderBlock::insertFloatingObject):
        (WebCore::RenderBlock::addOverhangingFloats):
        (WebCore::RenderBlock::addIntrudingFloats):
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::positionedObjects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFollowup fix to r79827
aroben@apple.com [Sun, 27 Feb 2011 23:28:56 +0000 (23:28 +0000)]
Followup fix to r79827

* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
lastPathComponent. This matches what we did here before r79827, and matches Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] [WK2] QGraphicsWKView::showContextMenu() should be public
benjamin.poulain@nokia.com [Sun, 27 Feb 2011 23:18:51 +0000 (23:18 +0000)]
[Qt] [WK2] QGraphicsWKView::showContextMenu() should be public
https://bugs.webkit.org/show_bug.cgi?id=55330

Reviewed by Kenneth Rohde Christiansen.

Move QGraphicsWKView::showContextMenu() to the public API. Add documentation
on its use.

* UIProcess/API/qt/qgraphicswkview.cpp:
* UIProcess/API/qt/qgraphicswkview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake bisect-builds print a trac link for the regression range
mitz@apple.com [Sun, 27 Feb 2011 22:14:45 +0000 (22:14 +0000)]
Make bisect-builds print a trac link for the regression range
https://bugs.webkit.org/show_bug.cgi?id=55331

Reviewed by Adam Roben.

* Scripts/bisect-builds:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate
aroben@apple.com [Sun, 27 Feb 2011 21:51:08 +0000 (21:51 +0000)]
Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate

Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled

Reviewed by Anders Carlsson.

* DumpRenderTree/win/EditingDelegate.cpp:
(indexOfFirstWordCharacter):
(wordLength):
Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows expected failure results for fast/events/pageshow-pagehide-on-back-cached...
aroben@apple.com [Sun, 27 Feb 2011 21:29:42 +0000 (21:29 +0000)]
Add Windows expected failure results for fast/events/pageshow-pagehide-on-back-cached.html

<http://webkit.org/b/55329> tracks the failure.

* platform/win/fast/events/pageshow-pagehide-on-back-cached-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows expected failure results for fast/images/support-broken-image-delegate...
aroben@apple.com [Sun, 27 Feb 2011 21:29:12 +0000 (21:29 +0000)]
Add Windows expected failure results for fast/images/support-broken-image-delegate.html

<http://webkit.org/b/55324> tracks the failure.

* platform/win/fast/images/support-broken-image-delegate-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake ResourceLoadDelegate print URLs relative to the main resource on Windows
aroben@apple.com [Sun, 27 Feb 2011 21:16:50 +0000 (21:16 +0000)]
Make ResourceLoadDelegate print URLs relative to the main resource on Windows

This matches Mac. (In fact, the code was ported from Mac!)

Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
match Mac

Reviewed by Anders Carlsson.

* DumpRenderTree/win/DumpRenderTree.cpp:
(substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
(urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
_drt_descriptionSuitableForTestResult].
(cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.

* DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.

* DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to
DumpRenderTree.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Sun, 27 Feb 2011 19:38:50 +0000 (19:38 +0000)]
2011-02-27  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject()
        https://bugs.webkit.org/show_bug.cgi?id=55322

        Documentation update, add a reference to the QtWebKit bridge page.

        * Api/qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEliminate DeprecatedPtrList
benjamin.poulain@nokia.com [Sun, 27 Feb 2011 18:59:01 +0000 (18:59 +0000)]
Eliminate DeprecatedPtrList
https://bugs.webkit.org/show_bug.cgi?id=17425

Reviewed by Andreas Kling.

Remove the implementation of DeprecatedPtrList and all its references
from the build systems.

* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.order:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/DeprecatedPtrList.h: Removed.
* platform/DeprecatedPtrListImpl.cpp: Removed.
* platform/DeprecatedPtrListImpl.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove Windows-specific html5lib results
aroben@apple.com [Sun, 27 Feb 2011 18:25:45 +0000 (18:25 +0000)]
Remove Windows-specific html5lib results

I suspect these haven't been needed since r77781.

* platform/win/html5lib/runner-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange the order of Chang Shu's email addresses so the first one is their Bugzilla...
aroben@apple.com [Sun, 27 Feb 2011 18:15:41 +0000 (18:15 +0000)]
Change the order of Chang Shu's email addresses so the first one is their Bugzilla username

This makes Bugzilla autocompletion work correctly.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-27 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Sun, 27 Feb 2011 18:05:12 +0000 (18:05 +0000)]
2011-02-27  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, fixed GTK compilation after r79806.

        * UIProcess/gtk/WebView.cpp:
        (WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
        * UIProcess/gtk/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip fast/frames/iframe-plugin-load-remove-document-crash.html on Windows
aroben@apple.com [Sun, 27 Feb 2011 18:04:40 +0000 (18:04 +0000)]
Skip fast/frames/iframe-plugin-load-remove-document-crash.html on Windows

It's been crashing since it was added in r79808. <http://webkit.org/b/55307> tracks the
failure.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-27 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 27 Feb 2011 17:59:33 +0000 (17:59 +0000)]
2011-02-27  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] fast/loader/user-stylesheet-fast-path.html fails
        https://bugs.webkit.org/show_bug.cgi?id=50911

        * platform/qt/Skipped:  Unskip test which is now passing.
2011-02-27  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] fast/loader/user-stylesheet-fast-path.html fails
        https://bugs.webkit.org/show_bug.cgi?id=50911

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setUserStyleSheetLocation):
        Use QUrl::fromEncoded since the passed string is already encoded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEnsure $testResultsDirectory is an absolute path before setting up Windows crash...
aroben@apple.com [Sun, 27 Feb 2011 17:29:35 +0000 (17:29 +0000)]
Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving

Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
is different from old-run-webkit-test's. Because of this, the path to the crash log file
(which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
details.

Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
--results-directory path is used (like on the test slaves)

Reviewed by Dan Bernstein.

* Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've
made $testResultsDirectory an absolute path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-27 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sun, 27 Feb 2011 15:56:01 +0000 (15:56 +0000)]
2011-02-27  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Use WTF ref counting for FontPlatformDataPrivate
        https://bugs.webkit.org/show_bug.cgi?id=55303

        Make FontPlatformDataPrivate a RefCounted<FPDP>.
        Incidentally fixes an uninitialized member bug in FontPlatformData().

        * platform/graphics/qt/FontPlatformData.h:
        (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::isHashTableDeletedValue):
        (WebCore::FontPlatformData::font):
        (WebCore::FontPlatformData::size):
        (WebCore::FontPlatformData::family):
        (WebCore::FontPlatformData::bold):
        (WebCore::FontPlatformData::italic):
        (WebCore::FontPlatformData::smallCaps):
        (WebCore::FontPlatformData::pixelSize):
        * platform/graphics/qt/FontPlatformDataQt.cpp:
        (WebCore::toQFontWeight):
        (WebCore::FontPlatformData::operator==):
        (WebCore::FontPlatformData::hash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEliminate DeprecatedPtrList from RenderBlock
benjamin.poulain@nokia.com [Sun, 27 Feb 2011 15:51:19 +0000 (15:51 +0000)]
Eliminate DeprecatedPtrList from RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=54972

Patch by Benjamin Poulain <ikipou@gmail.com> on 2011-02-27
Reviewed by Darin Adler.

Source/JavaScriptCore:

Add methods find() and contains() using an adaptor to ListHashSet.
Those method are like the one of HashSet, they allow to find objects
based on a different key than the one used to define the set.

Add convenience methods for direct access to the head and tail of the list.
Those methods are providing similar API/behavior as Vector.

* wtf/ListHashSet.h:
(WTF::::first):
(WTF::::last):
(WTF::::removeLast):
(WTF::ListHashSetTranslatorAdapter::hash):
(WTF::ListHashSetTranslatorAdapter::equal):
(WTF::::find):
(WTF::::contains):

Source/WebCore:

Refactor RenderBlock to get rid of the DeprecatedPtrList.
The floating objects are stored in a ListHashSet.

Refactoring covered by existing test.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::positionNewFloatOnLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::containsFloat):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObjectHashFunctions::hash):
(WebCore::RenderBlock::FloatingObjectHashFunctions::equal):
(WebCore::RenderBlock::FloatingObjectHashTranslator::hash):
(WebCore::RenderBlock::FloatingObjectHashTranslator::equal):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::matchedEndLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 27 Feb 2011 06:53:21 +0000 (06:53 +0000)]
2011-02-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        <input value="type=submit"> throws a warning (“HTML parse error”)
        https://bugs.webkit.org/show_bug.cgi?id=55120

        This patch removes parse error messages from the HTML parser.  These
        messages are displayed at the wrong times, aren't tested, and aren't
        helpful.  We'll try again with some more informative messages and
        better testing.

        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::parseError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 27 Feb 2011 03:38:36 +0000 (03:38 +0000)]
2011-02-26  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecBrew
        https://bugs.webkit.org/show_bug.cgi?id=55309

        This functions are obsolete, since r78499 added TextCodecUTF8.

        * platform/text/TextEncodingRegistry.cpp:
        (WebCore::buildBaseTextCodecMaps):
        * platform/text/brew/TextCodecBrew.cpp:
        * platform/text/brew/TextCodecBrew.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Dihan Wickremasuriya <dihan.wickremasuriya@nokia.com>
commit-queue@webkit.org [Sun, 27 Feb 2011 03:28:47 +0000 (03:28 +0000)]
2011-02-26  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] [Symbian] Disable dependency to a specific version of a Qt package for
        non-production builds.
        https://bugs.webkit.org/show_bug.cgi?id=55313

        * Source/WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Dominic Mazzoni <dmazzoni@google.com>
commit-queue@webkit.org [Sun, 27 Feb 2011 02:45:54 +0000 (02:45 +0000)]
2011-02-26  Dominic Mazzoni  <dmazzoni@google.com>

        Reviewed by Adam Barth.

        m_dumpAccessibilityNotifications should be initialized.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        * DumpRenderTree/chromium/AccessibilityController.cpp:
        (AccessibilityController::AccessibilityController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sat, 26 Feb 2011 23:03:47 +0000 (23:03 +0000)]
2011-02-26  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        Add support for DragonFly BSD
        https://bugs.webkit.org/show_bug.cgi?id=54407

        DragonFly BSD is based on FreeBSD, so handle it like FreeBSD.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Sat, 26 Feb 2011 22:55:37 +0000 (22:55 +0000)]
2011-02-26  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Skip the test on QT, GTK until we can figure out the plugin load problem.
        https://bugs.webkit.org/show_bug.cgi?id=55307

        * platform/gtk/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Sat, 26 Feb 2011 22:40:36 +0000 (22:40 +0000)]
2011-02-26  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        Delay firing of mutation events while setting attribute values
        https://bugs.webkit.org/show_bug.cgi?id=55199

        * fast/dom/attribute-change-on-mutate-expected.txt: Added.
        * fast/dom/attribute-change-on-mutate.html: Added.
2011-02-26  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        Delay firing of mutation events while setting attribute values
        https://bugs.webkit.org/show_bug.cgi?id=55199

        Test: fast/dom/attribute-change-on-mutate.html

        * dom/Attr.cpp:
        (WebCore::Attr::setValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Sat, 26 Feb 2011 22:38:44 +0000 (22:38 +0000)]
2011-02-26  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Notify HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed
        https://bugs.webkit.org/show_bug.cgi?id=55252

        Need to invoke a callback function to notify the HTMLMediaElement
        when MediaPlayerPrivateQt's playback state gets changed.

        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): Set a flag to ignore the playback state change for pre-roll
        (WebCore::MediaPlayerPrivateQt::commitLoad): Call playbackStateChanged() to notify HTMLMediaElement
        (WebCore::MediaPlayerPrivateQt::stateChanged):
        * platform/graphics/qt/MediaPlayerPrivateQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Sat, 26 Feb 2011 21:26:04 +0000 (21:26 +0000)]
2011-02-25  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Adam Barth.

        Tests that removing a document during a plugin load does not result
        in crash.
        https://bugs.webkit.org/show_bug.cgi?id=55289

        * fast/frames/iframe-plugin-load-remove-document-crash-expected.txt: Added.
        * fast/frames/iframe-plugin-load-remove-document-crash.html: Added.
2011-02-25  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Adam Barth.

        When plugin document parser finishes parsing, it runs the raw
        document's parser finish functions which call the pending document
        onload events that removes the frame from underneath. So, we protect
        frame (and hence frameloader) in DocumentLoader::commitLoad.
        https://bugs.webkit.org/show_bug.cgi?id=55289

        Test: fast/frames/iframe-plugin-load-remove-document-crash.html

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::commitLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 26 Feb 2011 21:02:05 +0000 (21:02 +0000)]
2011-02-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Asynchronous response to FramePolicyListener is not finishing the load
        https://bugs.webkit.org/show_bug.cgi?id=55305
        <rdar://problem/9044356>

        Always initialize the receivedPolicyAction reply parameter.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::decidePolicyForNavigationAction):
        (WebKit::WebPageProxy::decidePolicyForMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 26 Feb 2011 20:44:53 +0000 (20:44 +0000)]
2011-02-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        DidFinishLoadingDataForCustomRepresentation should pass along the suggested filename
        https://bugs.webkit.org/show_bug.cgi?id=55304

        * UIProcess/API/mac/PDFViewController.h:
        * UIProcess/API/mac/PDFViewController.mm:
        (WebKit::PDFViewController::setPDFDocumentData):
        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
        * UIProcess/API/mac/WKView.mm:
        (-[WKView _didFinishLoadingDataForCustomRepresentationWithSuggestedFilename:dataReference:CoreIPC::]):
        * UIProcess/API/mac/WKViewInternal.h:
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::didFinishLoadingDataForCustomRepresentation):
        * UIProcess/API/qt/qwkpage_p.h:
        * UIProcess/PageClient.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didFinishLoadingDataForCustomRepresentation):
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPageProxy.messages.in:
        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
        * UIProcess/win/WebView.h:
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::finishedLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sat, 26 Feb 2011 20:14:47 +0000 (20:14 +0000)]
2011-02-26  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: rolling out 79799 and 79804 for breaking xml tests on mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sat, 26 Feb 2011 19:58:04 +0000 (19:58 +0000)]
2011-02-26  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: follow up to r79799. Fixing WinCE+Efl, mute new tests on Qt.
        https://bugs.webkit.org/show_bug.cgi?id=55302

        * CMakeLists.txt:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 26 Feb 2011 19:10:39 +0000 (19:10 +0000)]
2011-02-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver Hunt.

        DrawingArea should not be reference counted
        https://bugs.webkit.org/show_bug.cgi?id=55284

        * Shared/DrawingAreaInfo.h:
        * Shared/WebPageCreationParameters.cpp:
        (WebKit::WebPageCreationParameters::encode):
        (WebKit::WebPageCreationParameters::decode):
        * Shared/WebPageCreationParameters.h:
        * UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
        (WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):
        (WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible):
        (WebKit::ChunkedUpdateDrawingAreaProxy::update):
        (WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
        * UIProcess/ChunkedUpdateDrawingAreaProxy.h:
        * UIProcess/DrawingAreaProxy.cpp:
        (WebKit::DrawingAreaProxy::DrawingAreaProxy):
        * UIProcess/DrawingAreaProxy.h:
        (WebKit::DrawingAreaProxy::type):
        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
        * UIProcess/DrawingAreaProxyImpl.h:
        * UIProcess/TiledDrawingAreaProxy.cpp:
        (WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
        * UIProcess/TiledDrawingAreaProxy.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didReceiveSyncMessage):
        (WebKit::WebPageProxy::creationParameters):
        * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
        * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
        (WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea):
        (WebKit::ChunkedUpdateDrawingArea::display):
        (WebKit::ChunkedUpdateDrawingArea::setSize):
        (WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
        * WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
        * WebProcess/WebPage/DrawingArea.cpp:
        (WebKit::DrawingArea::create):
        (WebKit::DrawingArea::DrawingArea):
        * WebProcess/WebPage/DrawingArea.h:
        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::create):
        (WebKit::DrawingAreaImpl::DrawingAreaImpl):
        * WebProcess/WebPage/DrawingAreaImpl.h:
        * WebProcess/WebPage/TiledDrawingArea.cpp:
        (WebKit::TiledDrawingArea::TiledDrawingArea):
        * WebProcess/WebPage/TiledDrawingArea.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::drawRect):
        * WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Lukasz Slachciak <l.slachciak@samsung.com>
commit-queue@webkit.org [Sat, 26 Feb 2011 19:08:30 +0000 (19:08 +0000)]
2011-02-26  Lukasz Slachciak  <l.slachciak@samsung.com>

        Reviewed by Xan Lopez.

        [GTK] Implemented API to set/get web application cache directory path database.

        * GNUmakefile.am: Add webkitapplicationcache.h file.
        * webkit/webkit.h: Add webkitapplicationcache.h file.
        * webkit/webkitapplicationcache.cpp: definition of API setting and getting
        web application cache directory path database.
        (webkit_application_cache_get_database_directory_path):
        (webkit_application_cache_set_database_directory_path):
        * webkit/webkitapplicationcache.h: Added new API file for setting and getting
        web application cache directory path database.
        * webkit/webkitglobals.cpp:
        (webkitInit): use webkit_application_cache_set_database_directory_path
        to set default web application cache directory path database.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Sat, 26 Feb 2011 19:06:03 +0000 (19:06 +0000)]
2011-02-26  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        Add failing expectation for fast/images/support-broken-image-delegate.html

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-26 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Sat, 26 Feb 2011 19:00:09 +0000 (19:00 +0000)]
2011-02-26  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed update of the Chromium html5lib expectations after r79765
        (diff matches the base expectations change).

        * platform/chromium/html5lib/runner-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-25 Vsevolod Vlasov <vsevik@chromium.org>
pfeldman@chromium.org [Sat, 26 Feb 2011 18:54:02 +0000 (18:54 +0000)]
2011-02-25  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        XML without style should render as syntax-highlighted source.
        https://bugs.webkit.org/show_bug.cgi?id=13807

        Added tests for XML tree view mode. Testing both logic for entering
        XML tree view mode and rendering itself.

        * http/tests/xmlviewer/dumpAsText/css-stylesheet-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/css-stylesheet.xml: Added.
        * http/tests/xmlviewer/dumpAsText/frames-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/frames.html: Added.
        * http/tests/xmlviewer/dumpAsText/mathml-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/mathml.xml: Added.
        * http/tests/xmlviewer/dumpAsText/resources/css-stylesheet.css: Added.
        (assertion):
        * http/tests/xmlviewer/dumpAsText/resources/frames-helper.xml: Added.
        * http/tests/xmlviewer/dumpAsText/resources/xsl.xml: Added.
        * http/tests/xmlviewer/dumpAsText/svg-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/svg.xml: Added.
        * http/tests/xmlviewer/dumpAsText/wml-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/wml.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xhtml-tag-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xhtml-tag.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xlink-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xlink.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xsl-stylesheet-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xul-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xul.xml: Added.
        * platform/chromium/http/tests/xmlviewer/dumpAsText/mathml-expected.txt: Added.
2011-02-25  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        XML without style should render as syntax-highlighted source.
        https://bugs.webkit.org/show_bug.cgi?id=13807

        XML tree view mode implemented. If XML does not have any style
        information, it is rendered as highlighted source with collapsable
        elements.

        Tests: http/tests/xmlviewer/dumpAsText/css-stylesheet.xml
               http/tests/xmlviewer/dumpAsText/frames.html
               http/tests/xmlviewer/dumpAsText/mathml.xml
               http/tests/xmlviewer/dumpAsText/svg.xml
               http/tests/xmlviewer/dumpAsText/wml.xml
               http/tests/xmlviewer/dumpAsText/xhtml-tag.xml
               http/tests/xmlviewer/dumpAsText/xlink.xml
               http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml
               http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml
               http/tests/xmlviewer/dumpAsText/xmlviewer.xml
               http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml
               http/tests/xmlviewer/dumpAsText/xul.xml

        * CMakeLists.txt:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::matchUARules):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::createElement):
        * dom/Document.h:
        (WebCore::Document::usesViewSourceStyles):
        (WebCore::Document::setUsesViewSourceStyles):
        (WebCore::Document::sawElementsInKnownNamespaces):
        * dom/XMLDocumentParser.h:
        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::XMLDocumentParser::XMLDocumentParser):
        (WebCore::XMLDocumentParser::processingInstruction):
        (WebCore::XMLDocumentParser::initializeParserContext):
        (WebCore::XMLDocumentParser::doEnd):
        * dom/XMLDocumentParserQt.cpp:
        (WebCore::XMLDocumentParser::XMLDocumentParser):
        (WebCore::XMLDocumentParser::initializeParserContext):
        (WebCore::XMLDocumentParser::parseProcessingInstruction):
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
        * xml/XMLTreeViewer.cpp: Added.
        (WebCore::XMLTreeViewer::XMLTreeViewer):
        (WebCore::XMLTreeViewer::hasNoStyleInformation):
        (WebCore::XMLTreeViewer::transformDocumentToTreeView):
        * xml/XMLTreeViewer.h: Added.
        (WebCore::XMLTreeViewer::~XMLTreeViewer):
        * xml/XMLViewer.xsl: Added.
        * xml/XSLStyleSheet.h:
        (WebCore::XSLStyleSheet::createFromString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79799 268f45cc-cd09-0410-ab3c-d52691b4dbfc