ap [Sat, 24 Jun 2006 16:02:10 +0000 (16:02 +0000)]
2006-06-24 Mitz Pettel <opendarwin.org@mitzpettel.com>
Reviewed by Darin, landed by ap.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9547
Resize corner does not track the mouse accurately
Test: fast/css/resize-corner-tracking.html
* page/FrameView.cpp:
(WebCore::FrameView::handleMousePressEvent): Store the offset from the layer's
resizing corner where dragging has started.
(WebCore::FrameView::handleMouseMoveEvent): Pass the stored offset to the
layer's resize method.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize): Added an offset parameter, which is added to
the mouse location.
For objects that may have intrinsic margins applied to them,
added code to lift the margins into the object's style in order to keep them
constant.
Changed to take the content size as the base size if the box-sizing property
is content-box.
(WebCore::RenderLayer::offsetFromResizeCorner): Added. Returns the offset of the
given point from the corner that tracks the mouse when resizing.
* rendering/RenderLayer.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 24 Jun 2006 15:52:01 +0000 (15:52 +0000)]
Reviewed by Darin, landed by ap.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9316
REGRESSION: text field width shrinks on first keystroke
Test: fast/forms/floating-textfield-relayout.html
* page/FrameView.cpp:
(WebCore::FrameView::layoutRoot): Added. During subtree relayout, returns
the subtree root. Otherwise returns 0.
(WebCore::FrameView::layoutPending): Made const.
* page/FrameView.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calcWidth): Added early return if this is the root
of a subtree being laid out.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 24 Jun 2006 15:37:54 +0000 (15:37 +0000)]
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9564
A bunch of fixes to run-webkit-httpd
- Add an -all-interfaces (-a) flag to bind to all interfaces, not just
127.0.0.1. Useful for testing with WinIE running on another machine;
- don't call checkFrameworks() - we do not need a built WebKit here;
- changed tabs to spaces;
- disable HTTP keepalive (since Apache doesn't spawn sub-processes in
interactive mode, they were a hassle when testing with several browsers, as one
had to wait for connection to expire);
- remove httpd.pid when done, so that Apache doesn't complain next time.
* Scripts/run-webkit-httpd:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15012
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sat, 24 Jun 2006 15:09:21 +0000 (15:09 +0000)]
LayoutTests:
Reviewed by Hyatt. Patch by Mitz.
- updated test results for http://bugzilla.opendarwin.org/show_bug.cgi?id=9531
Pages that need only a horizontal scroll bar get a vertical one as well
* css1/classification/white_space-expected.checksum:
* css1/classification/white_space-expected.png:
* css1/classification/white_space-expected.txt:
* editing/selection/select-all-004-expected.checksum:
* editing/selection/select-all-004-expected.png:
* editing/selection/select-all-004-expected.txt:
* editing/selection/unrendered-001-expected.checksum:
* editing/selection/unrendered-001-expected.png:
* editing/selection/unrendered-001-expected.txt:
* editing/selection/unrendered-002-expected.checksum:
* editing/selection/unrendered-002-expected.png:
* editing/selection/unrendered-002-expected.txt:
* editing/selection/unrendered-003-expected.checksum:
* editing/selection/unrendered-003-expected.png:
* editing/selection/unrendered-003-expected.txt:
* editing/selection/unrendered-004-expected.checksum:
* editing/selection/unrendered-004-expected.png:
* editing/selection/unrendered-004-expected.txt:
* editing/selection/unrendered-005-expected.checksum:
* editing/selection/unrendered-005-expected.png:
* editing/selection/unrendered-005-expected.txt:
* fast/block/float/019-expected.checksum:
* fast/block/float/019-expected.png:
* fast/block/float/019-expected.txt:
* fast/block/margin-collapse/104-expected.checksum:
* fast/block/margin-collapse/104-expected.png:
* fast/block/margin-collapse/104-expected.txt:
* fast/block/positioning/relative-overflow-block-expected.checksum:
* fast/block/positioning/relative-overflow-block-expected.txt:
* fast/block/positioning/relative-overflow-replaced-expected.checksum:
* fast/block/positioning/relative-overflow-replaced-expected.txt:
* fast/block/positioning/relative-overflow-replaced-float-expected.checksum:
* fast/block/positioning/relative-overflow-replaced-float-expected.txt:
* fast/lists/li-br-expected.checksum:
* fast/lists/li-br-expected.png:
* fast/lists/li-br-expected.txt:
* fast/media/mq-relative-constraints-02-expected.checksum:
* fast/media/mq-relative-constraints-02-expected.png:
* fast/media/mq-relative-constraints-02-expected.txt:
* fast/media/mq-relative-constraints-03-expected.checksum:
* fast/media/mq-relative-constraints-03-expected.png:
* fast/media/mq-relative-constraints-03-expected.txt:
* fast/media/mq-relative-constraints-04-expected.checksum:
* fast/media/mq-relative-constraints-04-expected.png:
* fast/media/mq-relative-constraints-04-expected.txt:
* fast/media/mq-relative-constraints-05-expected.checksum:
* fast/media/mq-relative-constraints-05-expected.png:
* fast/media/mq-relative-constraints-05-expected.txt:
* fast/media/mq-relative-constraints-06-expected.checksum:
* fast/media/mq-relative-constraints-06-expected.png:
* fast/media/mq-relative-constraints-06-expected.txt:
* fast/media/mq-relative-constraints-07-expected.checksum:
* fast/media/mq-relative-constraints-07-expected.png:
* fast/media/mq-relative-constraints-07-expected.txt:
* fast/media/mq-relative-constraints-09-expected.checksum:
* fast/media/mq-relative-constraints-09-expected.png:
* fast/media/mq-relative-constraints-09-expected.txt:
* fast/media/mq-width-absolute-01-expected.checksum:
* fast/media/mq-width-absolute-01-expected.png:
* fast/media/mq-width-absolute-01-expected.txt:
* fast/media/mq-width-absolute-02-expected.checksum:
* fast/media/mq-width-absolute-02-expected.png:
* fast/media/mq-width-absolute-02-expected.txt:
* fast/media/mq-width-absolute-03-expected.checksum:
* fast/media/mq-width-absolute-03-expected.png:
* fast/media/mq-width-absolute-03-expected.txt:
* fast/media/mq-width-absolute-04-expected.checksum:
* fast/media/mq-width-absolute-04-expected.png:
* fast/media/mq-width-absolute-04-expected.txt:
* fast/table/wide-colspan-expected.checksum:
* fast/table/wide-colspan-expected.png:
* fast/table/wide-colspan-expected.txt:
* fast/table/wide-column-expected.checksum:
* fast/table/wide-column-expected.png:
* fast/table/wide-column-expected.txt:
* tables/mozilla/bugs/bug131020-expected.checksum:
* tables/mozilla/bugs/bug131020-expected.png:
* tables/mozilla/bugs/bug131020-expected.txt:
* tables/mozilla/bugs/bug23151-expected.checksum:
* tables/mozilla/bugs/bug23151-expected.png:
* tables/mozilla/bugs/bug23151-expected.txt:
* tables/mozilla/bugs/bug29314-expected.checksum:
* tables/mozilla/bugs/bug29314-expected.png:
* tables/mozilla/bugs/bug29314-expected.txt:
* tables/mozilla/bugs/bug43039-expected.checksum:
* tables/mozilla/bugs/bug43039-expected.png:
* tables/mozilla/bugs/bug43039-expected.txt:
* tables/mozilla/bugs/bug43854-1-expected.checksum:
* tables/mozilla/bugs/bug43854-1-expected.png:
* tables/mozilla/bugs/bug43854-1-expected.txt:
* tables/mozilla/bugs/bug625-expected.checksum:
* tables/mozilla/bugs/bug625-expected.png:
* tables/mozilla/bugs/bug625-expected.txt:
* tables/mozilla/bugs/bug92143-expected.checksum:
* tables/mozilla/bugs/bug92143-expected.png:
* tables/mozilla/bugs/bug92143-expected.txt:
* tables/mozilla/bugs/bug96334-expected.checksum:
* tables/mozilla/bugs/bug96334-expected.png:
* tables/mozilla/bugs/bug96334-expected.txt:
* tables/mozilla/core/misc-expected.checksum:
* tables/mozilla/core/misc-expected.png:
* tables/mozilla/core/misc-expected.txt:
* tables/mozilla/core/nested1-expected.checksum:
* tables/mozilla/core/nested1-expected.png:
* tables/mozilla/core/nested1-expected.txt:
* tables/mozilla_expected_failures/bugs/bug220653-expected.checksum:
* tables/mozilla_expected_failures/bugs/bug220653-expected.png:
* tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
* tables/mozilla_expected_failures/bugs/bug67915-2-expected.checksum:
* tables/mozilla_expected_failures/bugs/bug67915-2-expected.png:
* tables/mozilla_expected_failures/bugs/bug67915-2-expected.txt:
WebCore:
Reviewed by Hyatt. Patch by Mitz.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9531
Pages that need only a horizontal scroll bar get a vertical one as well
The change affects many existing tests.
* page/FrameView.cpp:
(WebCore::FrameView::layout): Mark the body renderer as needing layout if
the view's height has changed and the body stretches to the view's height.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calcHeight):
* rendering/RenderBox.h:
(WebCore::RenderBox::stretchesToViewHeight): Added. Moved the logic for when
the HTML block needs to stretch to the view's height from calcHeight() here.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15011
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 24 Jun 2006 15:00:16 +0000 (15:00 +0000)]
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7461
Always encode the path part of an URI as UTF-8
Test: http/tests/uri/utf8-path.html
* platform/KURL.cpp:
(encodeRelativeString): Always set pathEncoding to UTF-8.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15010
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 24 Jun 2006 14:43:23 +0000 (14:43 +0000)]
2006-06-24 Graham Dennis <Graham.Dennis@gmail.com>
Reviewed by Darin, landed by ap.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9467
TreeWalker/NodeIterator do not restrict the traversal
Test: traversal/stay-within-root.html
* dom/Node.cpp:
(WebCore::Node::traversePreviousNode):
* dom/Node.h:
Add a stayWithin argument to traversePreviousNode just like the other
traversal functions
* dom/NodeIterator.cpp:
(WebCore::NodeIterator::findNextNode):
(WebCore::NodeIterator::findPreviousNode):
Ensure that when moving forward or backward that the root node is not
exited
* dom/TreeWalker.cpp:
(WebCore::TreeWalker::previousNode):
(WebCore::TreeWalker::nextNode):
Ditto
(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15009
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 24 Jun 2006 13:50:29 +0000 (13:50 +0000)]
svn-commit.tmp
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15008
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 24 Jun 2006 13:01:40 +0000 (13:01 +0000)]
2006-06-24 Mitz Pettel <opendarwin.org@mitzpettel.com>
Reviewed and landed by ap.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9563
Remove unused layoutSuppressed field and inLayout() method
No test added because there is no change in functionality.
* page/FrameView.cpp:
(WebCore::FrameViewPrivate::reset):
(WebCore::FrameView::layout):
* page/FrameView.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::layout):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15007
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 24 Jun 2006 12:53:57 +0000 (12:53 +0000)]
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8177
Javascript search incredibly slow
No change in functionality, thus no test.
Use info sharing for named collections, too. Moved shared HTMLCollection infos from HTMLDocument
to Document. Renamed collection types to use the preferred WebKit style. Replaced direct
HTMLCollection creation with using accessors from Document in a few places.
* bindings/objc/DOMHTML.mm:
(-[DOMHTMLElement children]):
(-[DOMHTMLDocument images]):
(-[DOMHTMLDocument applets]):
(-[DOMHTMLDocument links]):
(-[DOMHTMLDocument forms]):
(-[DOMHTMLDocument anchors]):
(-[DOMHTMLMapElement areas]):
(-[DOMHTMLTableSectionElement rows]):
(-[DOMHTMLTableElement rows]):
(-[DOMHTMLTableElement tBodies]):
(-[DOMHTMLTableRowElement cells]):
* dom/Document.cpp:
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
(WebCore::Document::nameCollectionInfo):
* dom/Document.h:
(WebCore::Document::collectionInfo):
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::traverseNextItem):
(WebCore::HTMLCollection::checkForNameMatch):
(WebCore::HTMLCollection::updateNameCache):
* html/HTMLCollection.h:
(WebCore::HTMLCollection::):
* html/HTMLDocument.h:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::children):
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::areas):
* html/HTMLNameCollection.h:
* html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::HTMLNameCollection):
(WebCore::HTMLNameCollection::traverseNextItem):
* html/HTMLFormCollection.cpp:
* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::HTMLOptionsCollection):
* html/HTMLSelectElement.h:
(WebCore::HTMLSelectElement::collectionInfo):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::rows):
(WebCore::HTMLTableElement::tBodies):
* html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::cells):
* html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::rows):
* kwq/WebCoreAXObject.mm:
(-[WebCoreAXObject accessibilityAttributeValue:]):
* page/Frame.cpp:
(WebCore::Frame::gotoAnchor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15006
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 24 Jun 2006 11:50:43 +0000 (11:50 +0000)]
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9418
WebKit will not build when Space exists in path
Enclose search paths in quotes; create symlinks to avoid passing paths with spaces to make.
* JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* WebCore/WebCore.xcodeproj/project.pbxproj:
* WebKit/WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15005
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Sat, 24 Jun 2006 05:19:14 +0000 (05:19 +0000)]
LayoutTests:
Reviewed by Tim Hatcher.
<rdar://problem/
4560947> Leopard REGRESSION: Dragging to TileGame Widget is broken
* fast/events/ondragenter-expected.checksum: Added.
* fast/events/ondragenter-expected.png: Added.
* fast/events/ondragenter-expected.txt: Added.
* fast/events/ondragenter.html: Added.
WebCore:
Reviewed by Tim Hatcher.
<rdar://problem/
4560947> Leopard REGRESSION: Dragging to TileGame Widget is broken
* page/FrameView.cpp:
(WebCore::FrameView::updateDragAndDrop):
Use the passed mouse event, instead of the "current" event. There is no such thing as
a "drag event". Asking for the current event during a drag returns a weird system-
internal event with an invalid mouse location.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15004
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 24 Jun 2006 05:07:08 +0000 (05:07 +0000)]
Reviewed by Eric.
Manual test added: cursor.html
Bug 9560: should support new CSS3 cursor types to get more resizing directions
http://bugzilla.opendarwin.org/show_bug.cgi?id=9560
Adds support for ew-resize, ns-resize, nesw-resize, nwse-resize,
col-resize and row-resize CSS3 cursor values.
Also converted some of the cursor images to grayscale tiffs,
some were RGB but had no color data.
* Resources/eastResizeCursor.tiff:
* Resources/eastWestResizeCursor.tiff: Added.
* Resources/helpCursor.tiff:
* Resources/moveCursor.tiff:
* Resources/northEastResizeCursor.tiff:
* Resources/northEastSouthWestResizeCursor.tiff: Added.
* Resources/northResizeCursor.tiff:
* Resources/northSouthResizeCursor.tiff: Added.
* Resources/northWestResizeCursor.tiff:
* Resources/northWestSouthEastResizeCursor.tiff: Added.
* Resources/southEastResizeCursor.tiff:
* Resources/southResizeCursor.tiff:
* Resources/southWestResizeCursor.tiff:
* Resources/textAreaResizeCorner.tiff:
* Resources/waitCursor.tiff:
* Resources/westResizeCursor.tiff:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSValueKeywords.in:
* css/cssparser.cpp:
(WebCore::CSSParser::parseValue):
* manual-tests/cursor.html: Added.
* page/FrameView.cpp:
(WebCore::selectCursor):
* platform/Cursor.h:
* platform/mac/CursorMac.mm:
(WebCore::northSouthResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::columnResizeCursor):
(WebCore::rowResizeCursor):
* platform/win/CursorWin.cpp:
(WebCore::northSouthResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::columnResizeCursor):
(WebCore::rowResizeCursor):
* rendering/render_style.h: cursor needs 5 bits now
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15003
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 24 Jun 2006 01:09:03 +0000 (01:09 +0000)]
Reviewed by Darin.
Adding more operator[] overloads for long and short types.
* wtf/Vector.h:
(WTF::Vector::operator[]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15002
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kdecker [Sat, 24 Jun 2006 00:58:34 +0000 (00:58 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15001
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Fri, 23 Jun 2006 23:56:57 +0000 (23:56 +0000)]
Reviewed by John Sullivan.
* Plugins/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView sendEvent:]):
Fixed a bug I found in the CoreGraphics drawing model that was preventing certain types of
events from being dispatched to the plugin, unless the plugin was being updated. The check
for portState was only required to call -setWindowIfNecessary, not required for the entire
event dispatch.
Also, don't paint the green debug rect unless this is a QuickDraw plugin. Otherwise the
current QD port is not set, and the green rect fills the entire screen. Pretty awesome
looking, but not intended behavior.
(-[WebBaseNetscapePluginView setWindowIfNecessary]):
Improved the logging here to include the NPWindow's width and height.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15000
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 23 Jun 2006 23:34:17 +0000 (23:34 +0000)]
Reviewed by Tim O.
Adds back SPI that Mail is still depending on.
* WebView/WebDataSource.m:
(-[WebDataSource _addSubframeArchives:]):
* WebView/WebDataSourcePrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14999
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Fri, 23 Jun 2006 23:12:00 +0000 (23:12 +0000)]
Reviewed by Tim Omernick
- fixed <rdar://problem/
4597685> stale rects for document markers can be left behind in certain cases
* dom/Document.h:
* dom/Document.cpp:
(WebCore::Document::setRenderedRectForMarker):
changed parameter from IntRect to const IntRect& at Darin's request
(WebCore::Document::invalidateRenderedRectsForMarkersInRect):
new method, tests whether the rendered rect for each marker intersects the
passed rect. If so, sets the rendered rect back to the placeholder rect that
means that the rect for this marker isn't known.
* page/Frame.cpp:
(WebCore::Frame::paint):
call invalidateRenderedRectsForMarkersInRect on the rect we're about to paint.
This ensures that old stale rects won't be preserved if the associated marker
has moved such that it is out of the painted area.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14998
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 23 Jun 2006 22:38:42 +0000 (22:38 +0000)]
Added bug number.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14997
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 23 Jun 2006 22:36:12 +0000 (22:36 +0000)]
LayoutTests:
Reviewed by levi
* editing/deleting/merge-into-empty-block-1-expected.checksum: Added.
* editing/deleting/merge-into-empty-block-1-expected.png: Added.
* editing/deleting/merge-into-empty-block-1-expected.txt: Added.
* editing/deleting/merge-into-empty-block-1.html: Added.
* editing/deleting/merge-into-empty-block-2-expected.checksum: Added.
* editing/deleting/merge-into-empty-block-2-expected.png: Added.
* editing/deleting/merge-into-empty-block-2-expected.txt: Added.
* editing/deleting/merge-into-empty-block-2.html: Added.
WebCore:
Reviewed by levi
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::mergeParagraphs):
Add a rule for when to merge into empty blocks.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14996
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 23 Jun 2006 22:08:03 +0000 (22:08 +0000)]
Reviewed by Adele.
- Added JSConstructorMake to match JSFunctionMake, along with test code.
* API/JSObjectRef.cpp:
(JSConstructorMake):
* API/JSObjectRef.h:
* API/testapi.c:
(myConstructor_callAsConstructor):
(main):
* API/testapi.js:
* ChangeLog:
* JavaScriptCore.xcodeproj/project.pbxproj: Moved testapi.c to the testapi
target -- this was an oversight in my earlier check-in.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14995
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 23 Jun 2006 21:36:14 +0000 (21:36 +0000)]
Versoning
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14993
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 23 Jun 2006 21:27:59 +0000 (21:27 +0000)]
Reviewed by Tim Hatcher.
<rdar://problem/
4223619> Safari crashed in -[NSFont __isSystemFont]
CFRetain and CFRelease NSFont's when FontPlatformData has a reference.
We only do this when GC is enabled for performance reasons.
No tests possible.
* platform/mac/FontPlatformData.h:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14992
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 23 Jun 2006 21:19:59 +0000 (21:19 +0000)]
LayoutTests:
Reviewed by levi
<http://bugzilla.opendarwin.org/show_bug.cgi?id=8074>
Caret before/after block tables is too small
<rdar://problem/
4598331>
right arrow out of a table shows cursor in a weird place
Demonstrates 9557:
* editing/input/range-for-empty-document-expected.txt:
Added:
* editing/selection/table-caret-1-expected.checksum: Added.
* editing/selection/table-caret-1-expected.png: Added.
* editing/selection/table-caret-1-expected.txt: Added.
* editing/selection/table-caret-1.html: Added.
* editing/selection/table-caret-2-expected.checksum: Added.
* editing/selection/table-caret-2-expected.png: Added.
* editing/selection/table-caret-2-expected.txt: Added.
* editing/selection/table-caret-2.html: Added.
* editing/selection/table-caret-3-expected.checksum: Added.
* editing/selection/table-caret-3-expected.png: Added.
* editing/selection/table-caret-3-expected.txt: Added.
* editing/selection/table-caret-3.html: Added.
WebCore:
Reviewed by levi
<http://bugzilla.opendarwin.org/show_bug.cgi?id=8074>
Caret before/after block tables is too small
<rdar://problem/
4598331>
right arrow out of a table shows cursor in a weird place
* rendering/RenderBox.cpp:
(WebCore::RenderBox::caretRect): Don't propagate to children,
VisiblePositions inside containers don't refer to children.
Don't use the font height for tables.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14991
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 23 Jun 2006 20:04:14 +0000 (20:04 +0000)]
Reviewed by Geoff.
script debugger should only attach to JavaScriptCore when there are listeners
http://bugzilla.opendarwin.org/show_bug.cgi?id=9552
Attaches the debugger to all WebFrames when the first listener
is added. Detaches when the last listener is removed.
Also detach when the script debug delegate is set to nil.
* DefaultDelegates/WebScriptDebugServer.m:
(+[WebScriptDebugServer listenerCount]):
(-[WebScriptDebugServer dealloc]):
(-[WebScriptDebugServer attachScriptDebuggerToAllWebViews]):
(-[WebScriptDebugServer detachScriptDebuggerFromAllWebViews]):
(-[WebScriptDebugServer listenerConnectionDidDie:]):
(-[WebScriptDebugServer addListener:]):
(-[WebScriptDebugServer removeListener:]):
* DefaultDelegates/WebScriptDebugServerPrivate.h:
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge windowObjectCleared]):
* WebView/WebFrame.m:
(-[WebFrame _attachScriptDebugger]):
(-[WebFrame _detachScriptDebugger]):
* WebView/WebFramePrivate.h:
* WebView/WebScriptDebugDelegate.m:
(-[WebScriptCallFrame parsedSource:fromURL:sourceId:]):
(-[WebScriptCallFrame enteredFrame:sourceId:line:]):
(-[WebScriptCallFrame hitStatement:sourceId:line:]):
(-[WebScriptCallFrame leavingFrame:sourceId:line:]):
* WebView/WebView.m:
(-[WebView _attachScriptDebuggerToAllFrames]):
(-[WebView _detachScriptDebuggerFromAllFrames]):
(-[WebView setScriptDebugDelegate:]):
* WebView/WebViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14990
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Fri, 23 Jun 2006 17:51:39 +0000 (17:51 +0000)]
Reviewed by Kevin.
Added 64-bit String::number() functions
* platform/PlatformString.h:
* platform/String.cpp:
(WebCore::String::number):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14989
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 23 Jun 2006 17:37:32 +0000 (17:37 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14988
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Fri, 23 Jun 2006 16:16:08 +0000 (16:16 +0000)]
Reviewed by Tim Omernick
- added support for UIDelegate to be notified of scrolling in any WebHTMLView
- cleaned up recently-added UIDelegate code
* WebView/WebUIDelegatePrivate.h:
declared webView:didScrollDocumentInFrameView: method
* DefaultDelegates/WebDefaultUIDelegate.m:
(-[NSApplication webView:didDrawRect:]):
provide default (empty) implementation of this recently-added method, so the
DelegateForwarder mechanism will work for it
(-[NSApplication webView:didScrollDocumentInFrameView:]):
same thing for the new method
* WebView/WebHTMLView.m:
(-[WebHTMLView _frameOrBoundsChanged]):
use _UIDelegateForwarder mechanism to notify delegate that scrolling occurred
(-[NSArray drawSingleRect:]):
use _UIDelegateForwarder mechanism instead of checking respondsToSelector stuff
here (that's packaged up nicely by the forwarder mechanism)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14987
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Fri, 23 Jun 2006 04:43:23 +0000 (04:43 +0000)]
Build fix.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9539
Another case error preventing build
* API/JSObjectRef.cpp: Changed "identifier.h" to "Identifier.h"
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14986
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Fri, 23 Jun 2006 04:37:59 +0000 (04:37 +0000)]
Reviewed by darin and ggaren.
- see http://bugzilla.opendarwin.org/show_bug.cgi?id=9539
Another case error preventing build
WebKitTools:
* Scripts/webkitdirs.pm: Building WebKit now requires Xcode 2.3.
WebKitSite:
* building/build.html: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14985
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 23 Jun 2006 04:18:05 +0000 (04:18 +0000)]
Reviewed by Eric.
Adds a native toolbar to Drosera to be a good citizen.
Adds a Debug menu with key-commands for Continue, Pause and Step Into.
Fixes a dragging bug from an earlier fix to the divider code.
Fixes some poor indenting in debugger.js.
* Drosera/DebuggerDocument.h:
* Drosera/DebuggerDocument.m:
(-[DebuggerDocument stepInto]):
(-[DebuggerDocument pause:]):
(-[DebuggerDocument resume:]):
(-[DebuggerDocument stepInto:]):
(-[DebuggerDocument windowDidLoad]):
(-[DebuggerDocument toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]):
(-[DebuggerDocument toolbarDefaultItemIdentifiers:]):
(-[DebuggerDocument toolbarAllowedItemIdentifiers:]):
(-[DebuggerDocument validateUserInterfaceItem:]):
* Drosera/English.lproj/MainMenu.nib/classes.nib:
* Drosera/English.lproj/MainMenu.nib/info.nib:
* Drosera/English.lproj/MainMenu.nib/keyedobjects.nib:
* Drosera/debugger.css:
* Drosera/debugger.html:
* Drosera/debugger.js:
* Drosera/viewer.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14984
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Fri, 23 Jun 2006 04:07:18 +0000 (04:07 +0000)]
LayoutTests:
Reviewed by Hyatt. Patch by Mitz.
- test and updated results for http://bugzilla.opendarwin.org/show_bug.cgi?id=9497
REGRESSION: Incomplete repainting when scrolling thumbnails on Flickr
* fast/repaint/clipped-relative-expected.checksum: Added.
* fast/repaint/clipped-relative-expected.png: Added.
* fast/repaint/clipped-relative-expected.txt: Added.
* fast/repaint/clipped-relative.html: Added.
* fast/repaint/containing-block-position-change-expected.checksum: Updated.
* fast/repaint/containing-block-position-change-expected.png: Updated.
WebCore:
Reviewed by Hyatt. Patch by Mitz.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9497
REGRESSION: Incomplete repainting when scrolling thumbnails on Flickr
Test: fast/repaint/clipped-relative.html
* page/FrameView.cpp:
(WebCore::FrameView::layout):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removePositionedObjects): Removed call to computeRepaintRects().
Previously, it was needed to update the cached rects before RenderBox::setStyle()
called updateLayerPositions().
* rendering/RenderBox.cpp:
(WebCore::RenderBox::setStyle): Changed to call updateLayerPositions() for a newly-
created layer only if it does not need layout. Otherwise, updateLayerPositions() will
be called after layout. This saves a repaint in some cases.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::checkForRepaintOnResize): Renamed computeRepaintRects() to
this and deleted the code that cached the absolute position and repaint rects.
(WebCore::RenderLayer::updateLayerPositions): Added code to cache the absolute
position and repaint rects right after updating the layer's position.
* rendering/RenderLayer.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14983
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 23 Jun 2006 02:25:19 +0000 (02:25 +0000)]
Adding an image that wasn't added to the project earlier.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14982
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Fri, 23 Jun 2006 02:00:47 +0000 (02:00 +0000)]
Reviewed by Maciej.
Fix for <rdar://problem/
4599015> REGRESSION: Hand on clock widget
don't appear at all
This regression was caused by <rdar://problem/
4567520> HIDPI: pixel
cracks in weather widget at 1.83 scaling
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage): Do the contains
check before rounding to integral device pixels.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14981
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 22 Jun 2006 23:12:20 +0000 (23:12 +0000)]
WebCore:
2006-06-22 Anders Carlsson <acarlsson@apple.com>
Reviewed by John.
<rdar://problem/
4529334> REGRESSION: Can't configure RadarInMotion widget for U.S. locations on Leopard (Javascript errors)
* dom/Document.cpp:
(WebCore::Document::completeURL):
Check if both the URL and base URL are empty instead of using URL() which returns "about:blank" if the URL is empty.
LayoutTests:
2006-06-22 Anders Carlsson <acarlsson@apple.com>
Reviewed by John.
<rdar://problem/
4529334> REGRESSION: Can't configure RadarInMotion widget for U.S. locations on Leopard (Javascript errors)
* dom/Document.cpp:
(WebCore::Document::completeURL):
Check if both the URL and base URL are empty instead of using URL() which returns "about:blank" if the URL is empty.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14980
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Thu, 22 Jun 2006 21:31:50 +0000 (21:31 +0000)]
Reviewed by NOBODY (build fix)
* WebView/WebFrameLoader.m:
Import WebMainResourceLoader instead of using @class so that we can call WebMainResourceLoader
methods.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14979
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 22 Jun 2006 21:10:51 +0000 (21:10 +0000)]
Versioning
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14978
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Thu, 22 Jun 2006 19:01:39 +0000 (19:01 +0000)]
Reviewed by NOBODY (build fix)
* WebView/WebFrameLoader.m:
Import JavaScriptCore/Assertions.h instead of WebKit/WebAssertions.h (which no longer exists)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14977
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 22 Jun 2006 18:48:23 +0000 (18:48 +0000)]
Reviewed by Adele.
- start moving loading logic to new WebFrameLoader class; move management of WebLoaders there
* Misc/WebIconLoader.h:
* Misc/WebIconLoader.m:
(-[WebIconLoader didFinishLoading]):
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebDataSource.m:
(-[WebDataSourcePrivate dealloc]):
(-[WebDataSource _updateLoading]):
(-[WebDataSource _loadIcon]):
(-[WebDataSource _setPrimaryLoadComplete:]):
(-[WebDataSource _stopLoading]):
(-[WebDataSource _startLoading]):
(-[WebDataSource _addSubresourceLoader:]):
(-[WebDataSource _removeSubresourceLoader:]):
(-[WebDataSource _addPlugInStreamLoader:]):
(-[WebDataSource _removePlugInStreamLoader:]):
(-[WebDataSource _iconLoaderReceivedPageIcon:]):
(-[WebDataSource _defersCallbacksChanged]):
(-[WebDataSource _stopLoadingWithError:]):
(-[WebDataSource _setupForReplaceByMIMEType:]):
(-[WebDataSource initWithRequest:]):
(-[WebDataSource dealloc]):
(-[WebDataSource finalize]):
(-[WebDataSource data]):
(-[WebDataSource isLoading]):
* WebView/WebFrameLoader.h: Added.
* WebView/WebFrameLoader.m: Added.
(-[WebFrameLoader initWithDataSource:]):
(-[WebFrameLoader dealloc]):
(-[WebFrameLoader hasIconLoader]):
(-[WebFrameLoader loadIconWithRequest:]):
(-[WebFrameLoader stopLoadingIcon]):
(-[WebFrameLoader addPlugInStreamLoader:]):
(-[WebFrameLoader removePlugInStreamLoader:]):
(-[WebFrameLoader setDefersCallbacks:]):
(-[WebFrameLoader stopLoadingPlugIns]):
(-[WebFrameLoader isLoadingMainResource]):
(-[WebFrameLoader isLoadingSubresources]):
(-[WebFrameLoader isLoading]):
(-[WebFrameLoader stopLoadingSubresources]):
(-[WebFrameLoader addSubresourceLoader:]):
(-[WebFrameLoader removeSubresourceLoader:]):
(-[WebFrameLoader mainResourceData]):
(-[WebFrameLoader releaseMainResourceLoader]):
(-[WebFrameLoader cancelMainResourceLoad]):
(-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
(-[WebFrameLoader stopLoadingWithError:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 22 Jun 2006 18:34:15 +0000 (18:34 +0000)]
WebCore:
2006-06-22 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
<rdar://problem/
4499675> Package Tracker widget always crashes in WebCore::Frame::jScriptEnabled() const + 0
* html/HTMLParser.cpp:
(WebCore::HTMLParser::noscriptCreateErrorCheck):
(WebCore::HTMLParser::canvasCreateErrorCheck):
(WebCore::HTMLParser::isInline):
Add null-checks for document->frame() since it can be 0 for documents created using createHTMLDocument.
LayoutTests:
2006-06-22 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
<rdar://problem/
4499675> Package Tracker widget always crashes in WebCore::Frame::jScriptEnabled() const + 0
* fast/dom/noscript-canvas-in-created-html-document-expected.txt: Added.
* fast/dom/noscript-canvas-in-created-html-document.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14975
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kdecker [Thu, 22 Jun 2006 17:48:14 +0000 (17:48 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14974
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 22 Jun 2006 17:46:25 +0000 (17:46 +0000)]
WebCore:
2006-06-22 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
<rdar://problem/
4524840> Entities contained in DOCTYPE referenced DTD in XSLT source document are unknown
* dom/xml_tokenizer.cpp:
(WebCore::shouldAllowExternalLoad):
Use correct path for the catalog.
(WebCore::errorFunc):
Add error function to keep parser errors from going to the console.
(WebCore::XMLTokenizer::write):
Remove if (0 &&)
(WebCore::XMLTokenizer::end):
Pass DocLoader to xmlDocPtrForString.
(WebCore::xmlDocPtrForString):
* dom/xml_tokenizer.h:
Add DocLoader argument to xmlDocPtrForString so external DTDs and entities can be loaded.
* xml/XSLTProcessor.cpp:
(WebCore::xmlDocPtrFromNode):
Pass DocLoader to xmlDocPtrForString
LayoutTests:
2006-06-22 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
<rdar://problem/
4524840> Entities contained in DOCTYPE referenced DTD in XSLT source document are unknown
* fast/xsl/dtd-in-source-document-expected.txt: Added.
* fast/xsl/dtd-in-source-document.xml: Added.
* fast/xsl/resources/dtd-in-source-document.dtd: Added.
* fast/xsl/resources/dtd-in-source-document.xsl: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14973
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 22 Jun 2006 17:34:54 +0000 (17:34 +0000)]
Reviewed by Kevin Decker.
Code clean up. Adds the stackframe and makes only the body
of the tables scrollable keeping the header visible.
Shows the current function stack when paused or stepping.
* Drosera/DebuggerApplication.m:
(-[DebuggerApplication awakeFromNib]):
(-[DebuggerApplication numberOfRowsInTableView:]):
(-[DebuggerApplication tableView:objectValueForTableColumn:row:]):
* Drosera/DebuggerDocument.h:
* Drosera/DebuggerDocument.m:
(-[DebuggerDocument dealloc]):
(-[DebuggerDocument currentFrame]):
(-[DebuggerDocument currentFrameFunctionName]):
(-[DebuggerDocument currentFunctionStack]):
(-[DebuggerDocument log:]):
(-[DebuggerDocument windowWillClose:]):
(-[DebuggerDocument webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
(-[DebuggerDocument webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
* Drosera/Drosera.xcodeproj/project.pbxproj:
* Drosera/debugger.css:
* Drosera/debugger.html:
* Drosera/debugger.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14972
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 22 Jun 2006 17:18:39 +0000 (17:18 +0000)]
Reviewed by Anders.
Teach run-webkit-httpd to properly look for webkitdirs.pm.
* Scripts/run-webkit-httpd:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14971
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kdecker [Thu, 22 Jun 2006 15:01:31 +0000 (15:01 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14970
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Thu, 22 Jun 2006 10:38:20 +0000 (10:38 +0000)]
JavaScriptCore:
Build fix.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9539
Another case error preventing build
* API/APICast.h: Changed "UString.h" to "ustring.h".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14969
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 22 Jun 2006 00:58:30 +0000 (00:58 +0000)]
Back out -webkit-overlay and just rename it back to overlay.
Reviewed by darin
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSValueKeywords.in:
* css/cssparser.cpp:
(WebCore::CSSParser::parseValue):
* css/cssstyleselector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14968
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 22 Jun 2006 00:20:29 +0000 (00:20 +0000)]
LayoutTests:
Reviewed by levi
* editing/deleting/table-cells-expected.checksum: Added.
* editing/deleting/table-cells-expected.png: Added.
* editing/deleting/table-cells-expected.txt: Added.
* editing/deleting/table-cells.html: Added.
* editing/inserting/paragraph-separator-in-table-1-expected.checksum: Added.
* editing/inserting/paragraph-separator-in-table-1-expected.png: Added.
* editing/inserting/paragraph-separator-in-table-1-expected.txt: Added.
* editing/inserting/paragraph-separator-in-table-1.html: Added.
* editing/inserting/paragraph-separator-in-table-2-expected.checksum: Added.
* editing/inserting/paragraph-separator-in-table-2-expected.png: Added.
* editing/inserting/paragraph-separator-in-table-2-expected.txt: Added.
* editing/inserting/paragraph-separator-in-table-2.html: Added.
WebCore:
Reviewed by levi
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::initializePositionData): Fix a bug in the code
to stop merges across table cells.
(WebCore::DeleteSelectionCommand::mergeParagraphs): Move the code to stop merges
across table cells to initializePositionData so that its changes to
m_mergeBlocksAfterDelete can take effect on the endingPosition.
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply): Turn into an InsertLineBreak
instead of splitting/cloning a table cell.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14962
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 21 Jun 2006 23:50:38 +0000 (23:50 +0000)]
Add overflow-x and overflow-y tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14959
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Wed, 21 Jun 2006 23:38:10 +0000 (23:38 +0000)]
Reviewed by John.
Fix for <rdar://problem/
3914965> Misspelled text underline doesn't
look right at non-standard scale factors
* platform/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawLineForMisspelling): We need to call
into our previously-created SPI for pattern-drawing so that the
phase is right at all scale factors.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14957
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 21 Jun 2006 23:15:42 +0000 (23:15 +0000)]
Switching to Stabs debugging format for Production builds.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14956
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 21 Jun 2006 23:13:22 +0000 (23:13 +0000)]
Reviewed by Maciej
The WebCoreIconDatabaseBridge was getting messages sent to it after it had been closed, resulting in a crash
on an ASSERT(). After closing the databaseBridge, we simply set it to nil so this can't happen.
anymore.
* Misc/WebIconDatabase.m:
(-[WebIconDatabase _applicationWillTerminate:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14955
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 21 Jun 2006 23:10:02 +0000 (23:10 +0000)]
Fixed release build, fixed accidental infinite recursion due to
last minute global replace gone awry.
* API/APICast.h:
(toRef):
* API/testapi.c:
(assertEqualsAsBoolean):
(assertEqualsAsNumber):
(assertEqualsAsUTF8String):
(assertEqualsAsCharactersPtr):
* JavaScriptCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14954
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 21 Jun 2006 22:45:00 +0000 (22:45 +0000)]
Fix for 7362, implement the CSS3 overflow-x and overflow-y properties.
Reviewed by adele
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSPropertyNames.in:
* css/cssparser.cpp:
(WebCore::CSSParser::parseValue):
* css/cssstyleselector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
(WebCore::CSSStyleSelector::applyProperty):
* page/FrameView.cpp:
(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::layout):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::determineHorizontalPosition):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::rightOffset):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::calcMinMaxWidth):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::setStyle):
(WebCore::RenderBox::contentWidth):
(WebCore::RenderBox::contentHeight):
(WebCore::RenderBox::sizesToIntrinsicWidth):
(WebCore::RenderBox::calcHeight):
(WebCore::RenderBox::calcPercentageHeight):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::shouldAutoscroll):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
(WebCore::RenderLayer::styleChanged):
* rendering/RenderLayer.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::clientWidth):
(WebCore::RenderObject::clientHeight):
* rendering/RenderObject.h:
(WebCore::RenderObject::hasAutoVerticalScrollbar):
(WebCore::RenderObject::hasAutoHorizontalScrollbar):
(WebCore::RenderObject::scrollsOverflow):
(WebCore::RenderObject::scrollsOverflowX):
(WebCore::RenderObject::scrollsOverflowY):
(WebCore::RenderObject::includeVerticalScrollbarSize):
(WebCore::RenderObject::includeHorizontalScrollbarSize):
* rendering/RenderTextArea.cpp:
(WebCore::RenderTextArea::setStyle):
* rendering/RenderTextField.cpp:
(WebCore::RenderTextField::createDivStyle):
(WebCore::RenderTextField::calcHeight):
(WebCore::RenderTextField::calcMinMaxWidth):
* rendering/bidi.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/render_style.cpp:
(WebCore::RenderStyle::diff):
* rendering/render_style.h:
(WebCore::):
(WebCore::RenderStyle::NonInheritedFlags::operator==):
(WebCore::RenderStyle::setBitDefaults):
(WebCore::RenderStyle::overflowX):
(WebCore::RenderStyle::overflowY):
(WebCore::RenderStyle::setOverflowX):
(WebCore::RenderStyle::setOverflowY):
(WebCore::RenderStyle::initialOverflowX):
(WebCore::RenderStyle::initialOverflowY):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14953
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 21 Jun 2006 21:22:50 +0000 (21:22 +0000)]
LayoutTests:
Reviewed by levi
<rdar://problem/
4590366>
REGRESSION: Selection incorrectly paints gaps on TOT
Added:
* editing/selection/line-wrap-1-expected.checksum: Added.
* editing/selection/line-wrap-1-expected.png: Added.
* editing/selection/line-wrap-1-expected.txt: Added.
* editing/selection/line-wrap-1.html: Added.
* editing/selection/line-wrap-2-expected.checksum: Added.
* editing/selection/line-wrap-2-expected.png: Added.
* editing/selection/line-wrap-2-expected.txt: Added.
* editing/selection/line-wrap-2.html: Added.
Fixes:
* editing/execCommand/findString-expected.checksum:
* editing/execCommand/findString-expected.png:
* editing/execCommand/findString-expected.txt:
* editing/inserting/editing-empty-divs-expected.checksum:
* editing/inserting/editing-empty-divs-expected.png:
* editing/inserting/editing-empty-divs-expected.txt:
* editing/inserting/insert-
3659587-fix-expected.txt:
* editing/inserting/insert-tab-002-expected.txt:
* editing/inserting/insert-text-with-newlines-expected.txt:
* editing/inserting/typing-001-expected.txt:
* editing/inserting/typing-003-expected.txt:
* editing/inserting/typing-around-br-001-expected.txt:
* editing/style/remove-underline-across-paragraph-expected.txt:
* editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
* editing/style/remove-underline-after-paragraph-expected.txt:
* editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
* editing/style/remove-underline-expected.txt:
* editing/style/remove-underline-from-stylesheet-expected.txt:
* editing/style/remove-underline-in-bold-expected.txt:
* editing/style/typing-style-002-expected.txt:
* editing/style/typing-style-003-expected.txt:
* editing/style/unbold-in-bold-expected.txt:
* editing/style/underline-expected.txt:
Disabled (9337):
* editing/input/attributed-substring-from-range-lines.html
WebCore:
Reviewed by levi
<rdar://problem/
4590366>
REGRESSION: Selection incorrectly paints gaps on TOT
* dom/Document.cpp:
(WebCore::Document::updateSelection): Use the leftmost candidate for the end of the
selection and the rightmost candidate for the start of the selection.
* dom/Position.cpp:
(WebCore::Position::upstream): Cross line wraps so that we can use upstream/downstream
to get to candidates before/after linewraps.
(WebCore::Position::downstream):
(WebCore::Position::inRenderedContent):
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
(WebCore::DeleteSelectionCommand::mergeParagraphs):
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
Ensure that the leftmost candidate is used. We should sample the style from that one.
When the block to insert is after a br, a br should be inserted even in strict mode.
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::input):
Insert at the leftmost candidate, get rid of a use of trailingWhitespacePosition.
Don't apply a style if its unnecessary.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply): "pos" can be invalidated, don't use it.
* editing/VisiblePosition.cpp:
Renamed initDeepPosition and made it return the canonical position.
(WebCore::VisiblePosition::init):
(WebCore::VisiblePosition::canonicalPosition):
* editing/VisiblePosition.h:
(WebCore::VisiblePosition::characterBefore): Added.
* editing/visible_units.cpp:
(WebCore::startOfParagraph):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionState): When a selection ends at a line wrap, it shouldn't extend
onto the next line.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14952
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 21 Jun 2006 21:09:19 +0000 (21:09 +0000)]
JavaScriptCore:
Reviewed by Anders.
- First cut at C API to JavaScript. Includes a unit test, 'testapi.c',
and the outline of a test app, 'minidom.c'.
Includes one change to JSC internals: Rename propList to getPropertyList and have it
take its target property list by reference so that subclasses can
add properties to the list before calling through to their superclasses.
Also, I just ran prepare-ChangeLog in about 10 seconds, and I would like
to give a shout-out to that.
* API/APICast.h: Added.
(toJS):
(toRef):
* API/JSBase.h: Added.
* API/JSCallbackObject.cpp: Added.
(KJS::):
(KJS::JSCallbackObject::JSCallbackObject):
(KJS::JSCallbackObject::~JSCallbackObject):
(KJS::JSCallbackObject::className):
(KJS::JSCallbackObject::getOwnPropertySlot):
(KJS::JSCallbackObject::put):
(KJS::JSCallbackObject::deleteProperty):
(KJS::JSCallbackObject::implementsConstruct):
(KJS::JSCallbackObject::construct):
(KJS::JSCallbackObject::implementsCall):
(KJS::JSCallbackObject::callAsFunction):
(KJS::JSCallbackObject::getPropertyList):
(KJS::JSCallbackObject::toBoolean):
(KJS::JSCallbackObject::toNumber):
(KJS::JSCallbackObject::toString):
(KJS::JSCallbackObject::setPrivate):
(KJS::JSCallbackObject::getPrivate):
(KJS::JSCallbackObject::cachedValueGetter):
(KJS::JSCallbackObject::callbackGetter):
* API/JSCallbackObject.h: Added.
(KJS::JSCallbackObject::classInfo):
* API/JSCharBufferRef.cpp: Added.
(JSStringMake):
(JSCharBufferCreate):
(JSCharBufferCreateUTF8):
(JSCharBufferRetain):
(JSCharBufferRelease):
(JSValueCopyStringValue):
(JSCharBufferGetLength):
(JSCharBufferGetCharactersPtr):
(JSCharBufferGetCharacters):
(JSCharBufferGetMaxLengthUTF8):
(JSCharBufferGetCharactersUTF8):
(JSCharBufferIsEqual):
(JSCharBufferIsEqualUTF8):
(JSCharBufferCreateWithCFString):
(CFStringCreateWithJSCharBuffer):
* API/JSCharBufferRef.h: Added.
* API/JSContextRef.cpp: Added.
(JSContextCreate):
(JSContextDestroy):
(JSContextGetGlobalObject):
(JSEvaluate):
(JSCheckSyntax):
(JSContextHasException):
(JSContextGetException):
(JSContextClearException):
(JSContextSetException):
* API/JSContextRef.h: Added.
* API/JSObjectRef.cpp: Added.
(JSValueToObject):
(JSObjectMake):
(JSFunctionMake):
(JSObjectGetDescription):
(JSObjectGetPrototype):
(JSObjectSetPrototype):
(JSObjectHasProperty):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectDeleteProperty):
(JSObjectGetPrivate):
(JSObjectSetPrivate):
(JSObjectIsFunction):
(JSObjectCallAsFunction):
(JSObjectIsConstructor):
(JSObjectCallAsConstructor):
(__JSPropertyListEnumerator::__JSPropertyListEnumerator):
(JSObjectCreatePropertyEnumerator):
(JSPropertyEnumeratorGetNext):
(JSPropertyEnumeratorRetain):
(JSPropertyEnumeratorRelease):
(JSPropertyListAdd):
* API/JSObjectRef.h: Added.
* API/JSValueRef.cpp: Added.
(JSValueGetType):
(JSValueIsUndefined):
(JSValueIsNull):
(JSValueIsBoolean):
(JSValueIsNumber):
(JSValueIsString):
(JSValueIsObject):
(JSValueIsEqual):
(JSValueIsStrictEqual):
(JSUndefinedMake):
(JSNullMake):
(JSBooleanMake):
(JSNumberMake):
(JSValueToBoolean):
(JSValueToNumber):
(JSGCProtect):
(JSGCUnprotect):
(JSGCCollect):
* API/JSValueRef.h: Added.
* API/JavaScriptCore.h: Added.
* API/minidom.c: Added.
(main):
* API/minidom.html: Added.
* API/minidom.js: Added.
* API/testapi.c: Added.
(assertEqualsAsBoolean):
(assertEqualsAsNumber):
(assertEqualsAsUTF8String):
(assertEqualsAsCharactersPtr):
(assertEqualsAsCharacters):
(MyObject_initialize):
(MyObject_copyDescription):
(MyObject_hasProperty):
(MyObject_getProperty):
(MyObject_setProperty):
(MyObject_deleteProperty):
(MyObject_getPropertyList):
(MyObject_callAsFunction):
(MyObject_callAsConstructor):
(MyObject_convertToType):
(MyObject_finalize):
(print_callAsFunction):
(main):
(createStringWithContentsOfFile):
* API/testapi.js: Added.
* ChangeLog:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bindings/npruntime_impl.h:
* kjs/array_instance.h:
* kjs/array_object.cpp:
(ArrayInstance::getPropertyList):
* kjs/interpreter.cpp:
(KJS::Interpreter::evaluate):
* kjs/nodes.cpp:
(ForInNode::execute):
* kjs/object.cpp:
(KJS::JSObject::put):
(KJS::JSObject::canPut):
(KJS::JSObject::deleteProperty):
(KJS::JSObject::propertyIsEnumerable):
(KJS::JSObject::getPropertyAttributes):
(KJS::JSObject::getPropertyList):
* kjs/object.h:
* kjs/property_map.cpp:
(KJS::PropertyMap::get):
* kjs/property_map.h:
* kjs/scope_chain.cpp:
(KJS::ScopeChain::print):
* kjs/string_object.cpp:
(StringInstance::getPropertyList):
* kjs/string_object.h:
* kjs/ustring.h:
(KJS::UString::Rep::ref):
JavaScriptGlue:
Reviewed by Anders.
- Required for JS API: Rename propList to getPropertyList and have it
take its target property list by reference so that subclasses can
add properties to the list before calling through to their superclasses.
* JSUtils.cpp:
(KJSValueToCFTypeInternal):
* JSValueWrapper.cpp:
(JSValueWrapper::JSObjectCopyPropertyNames):
* UserObjectImp.cpp:
(UserObjectImp::getPropertyList):
* UserObjectImp.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14951
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Wed, 21 Jun 2006 20:46:22 +0000 (20:46 +0000)]
Fixing ChangeLog.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14950
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Wed, 21 Jun 2006 20:44:23 +0000 (20:44 +0000)]
Reviewed and committed by Beth.
Fix for <rdar://problem/
4595337> Resizing a containing block
strictly vertically does not cause contained height:100% element to
also be resized.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChildren): Also layout if the
child's min or max height is a percent.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14949
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 21 Jun 2006 20:35:12 +0000 (20:35 +0000)]
WebCore:
2006-06-21 Anders Carlsson <acarlsson@apple.com>
Reviewed by Geoff.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6058
XMLTokenizer runs all <script> tags at once instead of as they're encountered
* dom/xml_tokenizer.cpp:
(WebCore::XMLTokenizer::XMLTokenizer):
Initialize new members.
(WebCore::XMLTokenizer::endElementNs):
If we've encountered a script tag, execute the script here. If the script
tag refers to an external resource, pause the parser while loading it.
(WebCore::XMLTokenizer::end):
Move code from finish() to here
(WebCore::XMLTokenizer::finish):
Only call end() if the parser isn't paused.
(WebCore::XMLTokenizer::notifyFinished):
Evaluate the script here and resume the parser.
(WebCore::XMLTokenizer::resumeParsing):
If finish() was called, call end() after writing all data.
LayoutTests:
2006-06-21 Anders Carlsson <acarlsson@apple.com>
Reviewed by Geoff.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6058
XMLTokenizer runs all <script> tags at once instead of as they're encountered
* dom/svg/level3/xpath/svgunit.js:
The XPath tests depend on the document being loaded before running the tests.
Add a "load" event listener and run the test in the handler.
* fast/canvas/quadraticCurveTo.xml:
Add onload handler and run tests there.
* fast/innerHTML/004-expected.txt:
* fast/innerHTML/004.xhtml:
Add load event listener and run test there.
* fast/parser/external-entities-expected.txt:
This now dumps as text because the script is ran before the parse error is encountered.
* fast/parser/resources/xhtml-scripts.js: Added.
* fast/parser/xhtml-scripts-expected.txt: Added.
* fast/parser/xhtml-scripts.xhtml: Added.
Add new tests.
* svg/custom/text-hit-test.svg:
Run test in onload handler.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14948
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Wed, 21 Jun 2006 19:29:40 +0000 (19:29 +0000)]
Reviewed by Geoff Garen.
<rdar://problem/
4564131> WebPluginDatabase setAdditionalWebPlugInPaths needs to be per WebView
Added some WebView SPI so that individual WebViews may have different plugin search paths. There are some
limitations with the approach taken here:
- JavaScript may only access the global plugin DB.
- When this SPI is in use, certain WebView methods may not give accurate results, such as +canShowMIMEType:.
- This only works for plugins referenced using the <object> or <embed> tags; plugins that reside in non-standard
file system locations may not be loaded directly into frames.
None of these issues are important to the client that needs this SPI. Rather than re-architect our entire
plugin database, I think it is better to simply accept these limitations for now.
* Plugins/WebPluginDatabase.h:
Added "plugInPaths" ivar, so different plugin databases can have different search paths.
* Plugins/WebPluginDatabase.m:
(+[WebPluginDatabase installedPlugins]):
Give the global plugin database the default plugin search paths.
(+[WebPluginDatabase setAdditionalWebPlugInPaths:]):
Removed static global; this method now sets the plugin paths on the global plugin database.
(-[WebPluginDatabase setPlugInPaths:]):
Setter method for plugin paths.
(-[WebPluginDatabase close]):
New method; called when the plugin database is no longer needed (when its WebView is being destroyed).
(-[WebPluginDatabase init]):
Don't refresh in -init, so that callers can set the DB's plugin path array before it refreshes.
(-[WebPluginDatabase dealloc]):
Moved here from near the bottom of the file. Release new ivar.
(-[WebPluginDatabase refresh]):
Use the plugInPaths ivar instead of calling pluginLocations().
Notify plugin packages when they are added to and removed from a plugin database. A plugin package will
unload itself when it is removed from all of its plugin databases.
The only really tricky thing here is that the global MIME <-> view class registrations are only modified
by the shared plugin DB.
(+[WebPluginDatabase _defaultPlugInPaths]):
Refactored from the old pluginLocations() function; returns the default set of plugin search paths.
* Plugins/WebBasePluginPackage.h:
* Plugins/WebBasePluginPackage.m:
(-[WebBasePluginPackage dealloc]):
Assert that this package has been removed from all of its containing plugin databases.
(-[WebBasePluginPackage finalize]):
ditto
(-[WebBasePluginPackage wasAddedToPluginDatabase:]):
Add plugin database to set.
(-[WebBasePluginPackage wasRemovedFromPluginDatabase:]):
Remove plugin database from set. If it was the last DB, then unload the plugin package.
* WebView/WebViewInternal.h:
Added instance methods to find the view class or plugin package, given a MIME type or file extension.
* WebView/WebViewPrivate.h:
Added SPI to set plugin search paths per WebView.
* WebView/WebView.m:
(-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
New method; tries the global MIME <-> view map first; failing that, it checks the WebView's plugin DB.
(-[WebView _close]):
Close the plugin DB.
(-[WebView _setAdditionalWebPlugInPaths:]):
Create the plugin DB if necessary, and set its plugin paths.
(-[WebView _pluginForMIMEType:]):
Checks global plugin DB, falls back on WebView DB.
(-[WebView _pluginForExtension:]):
ditto
(-[WebView _isMIMETypeRegisteredAsPlugin:]):
ditto
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
Use new WebView instance methods to look for plugins.
(-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]):
ditto
(-[WebFrameBridge determineObjectFromMIMEType:URL:]):
ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14947
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 21 Jun 2006 17:47:37 +0000 (17:47 +0000)]
2006-06-21 Steve Falkenburg <sfalken@apple.com>
Fix build break
* platform/win/TemporaryLinkStubs.cpp:
(FrameWin::shouldInterruptJavaScript):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14946
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Wed, 21 Jun 2006 16:21:19 +0000 (16:21 +0000)]
Reviewed by Anders.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9516
Would like a script to run a httpd server with the same configuration as run-webkit-tests http
* Scripts/run-webkit-httpd: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14945
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 21 Jun 2006 15:27:57 +0000 (15:27 +0000)]
2006-06-21 Joost de Valk <jdevalk@opendarwin.org>
Reviewed and landed by Anders.
* blog/wp-content/themes/webkit/sidebar.php:
Add link to Wiki in the navigation menu here too.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14944
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 21 Jun 2006 13:50:46 +0000 (13:50 +0000)]
2006-06-21 Joost de Valk <jdevalk@opendarwin.org>
Reviewed and landed by Anders.
* nav.inc: Add link to Wiki in the navigation menu.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14943
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 21 Jun 2006 13:24:51 +0000 (13:24 +0000)]
2006-06-21 Anders Carlsson <acarlsson@apple.com>
Move FrameWin::shouldInterruptJavaScript to TemporaryLinkStubs.cpp
* bridge/win/FrameWin.cpp:
* platform/win/TemporaryLinkStubs.cpp:
(FrameWin::shouldInterruptJavaScript):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14942
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 21 Jun 2006 08:40:32 +0000 (08:40 +0000)]
Reviewed by Maciej.
Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=9523
More Win32 build bustage.
* WebCore.vcproj/WebCore/WebCore.vcproj:
* bridge/win/FrameWin.cpp:
(WebCore::FrameWin::shouldInterruptJavaScript):
* bridge/win/FrameWin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14941
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 21 Jun 2006 07:45:15 +0000 (07:45 +0000)]
Reviewed by Eric.
Builds Drosera and a launcher to include with the nightly.
* BuildSlaveSupport/build-launcher-app:
* BuildSlaveSupport/build-launcher-dmg:
* Drosera/Drosera.xcodeproj/project.pbxproj:
* Drosera/Info.plist:
* Drosera/LauncherInfo.plist: Added.
* Drosera/launcher.m: Added.
(displayErrorAndQuit):
(checkMacOSXVersion):
(myExecve):
(main):
* Scripts/build-drosera
* WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
* WebKitLauncher/main.m:
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14940
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 21 Jun 2006 07:27:58 +0000 (07:27 +0000)]
No review - updated results for earlier patch.
- updated SVG test results where my recent fix affected bounding boxes
I think the new results are more accurate bounding boxes and in
any case there is no actual difference in rendered output.
* svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
* svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
* svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
* svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
* svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
* svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
* svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
* svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
* svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
* svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
* svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
* svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
* svg/custom/foreign-object-skew-expected.txt:
* svg/custom/image-with-transform-clip-filter-expected.txt:
* svg/custom/text-image-opacity-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14939
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 21 Jun 2006 07:27:24 +0000 (07:27 +0000)]
Updated results for: bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14938
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 21 Jun 2006 07:26:17 +0000 (07:26 +0000)]
Updated results for: bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14937
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 21 Jun 2006 07:23:47 +0000 (07:23 +0000)]
Reviewed by Anders.
Updated results for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>
Changes include some size differences since the new textareas have 4 pixels less horizontal padding,
and the renderer name for textareas has changed from RenderTextArea to RenderTextField.
* dom/html/level2/html/HTMLTextAreaElement14-expected.txt:
* dom/html/level2/html/HTMLTextAreaElement15-expected.txt:
* dom/xhtml/level2/html/HTMLTextAreaElement14-expected.txt:
* dom/xhtml/level2/html/HTMLTextAreaElement15-expected.txt:
* fast/block/margin-collapse/103-expected.checksum:
* fast/block/margin-collapse/103-expected.png:
* fast/block/margin-collapse/103-expected.txt:
* fast/dynamic/008-expected.checksum:
* fast/dynamic/008-expected.png:
* fast/dynamic/008-expected.txt:
* fast/forms/001-expected.checksum:
* fast/forms/002-expected.checksum:
* fast/forms/003-expected.checksum:
* fast/forms/004-expected.checksum:
* fast/forms/005-expected.checksum:
* fast/forms/006-expected.checksum:
* fast/forms/007-expected.checksum:
* fast/forms/8250-expected.checksum:
* fast/forms/blankbuttons-expected.checksum:
* fast/forms/button-cannot-be-nested-expected.checksum:
* fast/forms/button-default-title-expected.checksum:
* fast/forms/button-inner-block-reuse-expected.checksum:
* fast/forms/button-positioned-expected.checksum:
* fast/forms/button-sizes-expected.checksum:
* fast/forms/button-table-styles-expected.checksum:
* fast/forms/button-white-space-expected.checksum:
* fast/forms/checkbox-radio-onchange-expected.checksum:
* fast/forms/cursor-position-expected.txt:
* fast/forms/double-focus-expected.txt:
* fast/forms/file-input-disabled-expected.checksum:
* fast/forms/form-element-geometry-expected.checksum:
* fast/forms/form-element-geometry-expected.png:
* fast/forms/form-element-geometry-expected.txt:
* fast/forms/form-hides-table-expected.checksum:
* fast/forms/formmove-expected.checksum:
* fast/forms/formmove2-expected.checksum:
* fast/forms/formmove3-expected.checksum:
* fast/forms/indeterminate-expected.checksum:
* fast/forms/input-appearance-bkcolor-expected.checksum:
* fast/forms/input-appearance-default-bkcolor-expected.checksum:
* fast/forms/input-appearance-disabled-expected.checksum:
* fast/forms/input-appearance-focus-expected.checksum:
* fast/forms/input-appearance-minWidth-expected.checksum:
* fast/forms/input-appearance-preventDefault-expected.checksum:
* fast/forms/input-appearance-readonly-expected.checksum:
* fast/forms/input-appearance-selection-expected.checksum:
* fast/forms/input-appearance-visibility-expected.checksum:
* fast/forms/input-appearance-width-expected.checksum:
* fast/forms/input-baseline-expected.checksum:
* fast/forms/input-disabled-color-expected.checksum:
* fast/forms/input-double-click-selection-gap-bug-expected.checksum:
* fast/forms/input-maxlength-2-expected.checksum:
* fast/forms/input-no-renderer-expected.checksum:
* fast/forms/input-paste-undo-expected.checksum:
* fast/forms/input-readonly-dimmed-expected.checksum:
* fast/forms/input-readonly-empty-expected.checksum:
* fast/forms/input-spaces-expected.checksum:
* fast/forms/input-table-expected.checksum:
* fast/forms/input-text-click-inside-expected.checksum:
* fast/forms/input-text-click-outside-expected.checksum:
* fast/forms/input-text-double-click-expected.checksum:
* fast/forms/input-text-drag-down-expected.checksum:
* fast/forms/input-text-maxlength-expected.checksum:
* fast/forms/input-text-option-delete-expected.checksum:
* fast/forms/input-text-paste-maxlength-expected.checksum:
* fast/forms/input-text-scroll-left-on-blur-expected.checksum:
* fast/forms/input-text-self-emptying-click-expected.checksum:
* fast/forms/input-value-expected.checksum:
* fast/forms/input-width-expected.checksum:
* fast/forms/minWidthPercent-expected.checksum:
* fast/forms/negativeLineHeight-expected.checksum:
* fast/forms/negativeLineHeight-expected.png:
* fast/forms/negativeLineHeight-expected.txt:
* fast/forms/option-index-expected.checksum:
* fast/forms/option-script-expected.checksum:
* fast/forms/option-strip-whitespace-expected.checksum:
* fast/forms/plaintext-mode-2-expected.checksum:
* fast/forms/radio-attr-order-expected.checksum:
* fast/forms/radio_checked-expected.checksum:
* fast/forms/radio_checked_dynamic-expected.checksum:
* fast/forms/selection-functions-expected.txt:
* fast/forms/tabbing-input-iframe-expected.checksum:
* fast/forms/textAreaLineHeight-expected.checksum:
* fast/forms/textAreaLineHeight-expected.png:
* fast/forms/textAreaLineHeight-expected.txt:
* fast/forms/textarea-crlf-expected.txt:
* fast/forms/textarea-setinnerhtml-expected.checksum:
* fast/forms/textarea-setinnerhtml-expected.png:
* fast/forms/textarea-setinnerhtml-expected.txt:
* fast/forms/textarea-setvalue-submit-expected.txt:
* fast/forms/visual-hebrew-text-field-expected.checksum:
* fast/replaced/width100percent-expected.checksum:
* fast/replaced/width100percent-expected.png:
* fast/replaced/width100percent-expected.txt:
* fast/table/003-expected.checksum:
* fast/table/003-expected.png:
* fast/table/003-expected.txt:
* tables/mozilla/bugs/bug194024-expected.checksum:
* tables/mozilla/bugs/bug194024-expected.png:
* tables/mozilla/bugs/bug194024-expected.txt:
* tables/mozilla/bugs/bug30559-expected.checksum:
* tables/mozilla/bugs/bug30559-expected.png:
* tables/mozilla/bugs/bug30559-expected.txt:
* tables/mozilla/bugs/bug30692-expected.checksum:
* tables/mozilla/bugs/bug30692-expected.png:
* tables/mozilla/bugs/bug30692-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14936
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 21 Jun 2006 07:23:06 +0000 (07:23 +0000)]
Reviewed by Anders.
Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
Switch to use new text field implementation for <textarea>
* css/html4.css:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::selectionStart):
(WebCore::HTMLTextAreaElement::selectionEnd):
(WebCore::HTMLTextAreaElement::setSelectionStart):
(WebCore::HTMLTextAreaElement::setSelectionEnd):
(WebCore::HTMLTextAreaElement::select):
(WebCore::HTMLTextAreaElement::setSelectionRange):
(WebCore::HTMLTextAreaElement::createRenderer):
(WebCore::HTMLTextAreaElement::appendFormData):
(WebCore::HTMLTextAreaElement::isKeyboardFocusable):
(WebCore::HTMLTextAreaElement::isMouseFocusable):
(WebCore::HTMLTextAreaElement::focus):
(WebCore::HTMLTextAreaElement::defaultEventHandler):
(WebCore::HTMLTextAreaElement::updateValue):
(WebCore::HTMLTextAreaElement::setValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14935
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 21 Jun 2006 01:42:48 +0000 (01:42 +0000)]
Reviewed by Maciej
Fixed capitalization mistake that I made, someone else fixed, then I accidentally made it go back to the old way
* icon/SQLStatement.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14934
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 21 Jun 2006 01:29:57 +0000 (01:29 +0000)]
WebCore:
Reviewed by Maciej.
More changes/additions setting the stage for the major IconDatabase hookup.
* WebCore.xcodeproj/project.pbxproj: Added SQLTransaction.cpp
* bridge/mac/WebCoreIconDatabaseBridge.h: Added call-throughs and translations to pass WebKit DB to WebCore DB
* bridge/mac/WebCoreIconDatabaseBridge.mm:
(+[WebCoreIconDatabaseBridge sharedBridgeInstance]):
(-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
(-[WebCoreIconDatabaseBridge iconForURL:withSize:]):
(-[WebCoreIconDatabaseBridge iconURLForURL:]):
(-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
(-[WebCoreIconDatabaseBridge retainIconForURL:]):
(-[WebCoreIconDatabaseBridge releaseIconForURL:]):
(-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
(-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
(-[WebCoreIconDatabaseBridge _setIconURL:forURL:]):
(-[WebCoreIconDatabaseBridge _hasIconForIconURL:]):
* bridge/mac/WebCorePageBridge.mm: Added WebCore's IconDatabase logging channel to the user-prefs check
(initializeLoggingChannelsIfNecessary):
* icon/IconDatabase.cpp: Added stubs and basic SQL usage to create the sqlite DB and respond to WebKit calls
(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::open):
(WebCore::IconDatabase::close):
(WebCore::IconDatabase::isValidDatabase):
(WebCore::IconDatabase::recreateDatabase):
(WebCore::IconDatabase::setPrivateBrowsingEnabled):
(WebCore::IconDatabase::iconForURL):
(WebCore::IconDatabase::iconURLForURL):
(WebCore::IconDatabase::defaultIcon):
(WebCore::IconDatabase::retainIconForURL):
(WebCore::IconDatabase::releaseIconForURL):
(WebCore::IconDatabase::setIconForIconURL):
(WebCore::IconDatabase::setHaveNoIconForIconURL):
(WebCore::IconDatabase::setIconURLForPageURL):
(WebCore::IconDatabase::hasIconForIconURL):
* icon/IconDatabase.h: WebIcon will be an internal class used in IconDatabase but is not complete yet
(WebCore::WebIcon::getExpiration):
(WebCore::WebIcon::getTouch):
* icon/SQLDatabase.cpp: Added more SQLite convenience methods
(SQLDatabase::setFullsync):
(SQLDatabase::setBusyTimeout):
(SQLDatabase::setBusyHandler):
* icon/SQLDatabase.h:
* icon/SQLStatement.cpp:
(WebCore::SQLStatement::returnsAtLeastOneResult):
* icon/SQLTransaction.cpp: Added basic commit/rollback support with this simple class
(SQLTransaction::SQLTransaction):
(SQLTransaction::~SQLTransaction):
(SQLTransaction::begin):
(SQLTransaction::commit):
(SQLTransaction::rollback):
WebKit:
Reviewed by Maciej
Added calls through to the WebCoreIconDatabaseBridge for all the major WebIconDatabase API. For now these calls
are wrapped with #ifdef's and are for debugging only.
* Misc/WebIconDatabase.h:
* Misc/WebIconDatabase.m:
(-[NSMutableDictionary _scaleIcon:toSize:]):
(-[NSMutableDictionary init]):
(-[NSMutableDictionary iconForURL:withSize:cache:]):
(-[NSMutableDictionary iconURLForURL:]):
(-[NSMutableDictionary retainIconForURL:]):
(-[NSMutableDictionary releaseIconForURL:]):
(-[WebIconDatabase _setHaveNoIconForIconURL:]):
(-[WebIconDatabase _setIconURL:forURL:]):
(-[WebIconDatabase _hasIconForIconURL:]):
* Misc/WebIconLoader.m:
(-[WebIconLoader didFinishLoading]):
* Misc/WebKitLogging.h: Added a logging channel for WebIconDatabase debugging
* Misc/WebKitLogging.m:
(WebKitInitializeLoggingChannelsIfNecessary):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 21 Jun 2006 00:20:00 +0000 (00:20 +0000)]
Reviewed by Geoff.
Make sure we clear the exception before returning so
that future calls will not fail because of an earlier
exception state. Assert on entry that the WebScriptObject
is working with an ExecState that dose not have an exception.
Document that evaluateWebScript and callWebScriptMethod return
WebUndefined when an exception is thrown.
* bindings/objc/WebScriptObject.h:
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject valueForKey:]):
(-[WebScriptObject removeWebScriptKey:]):
(-[WebScriptObject webScriptValueAtIndex:]):
(-[WebScriptObject setWebScriptValueAtIndex:value:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 21 Jun 2006 00:10:31 +0000 (00:10 +0000)]
LayoutTests:
Reviewed by Maciej.
Tests for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=8724
REGRESSION: onSelect handler doesn't work for text fields
http://bugzilla.opendarwin.org/show_bug.cgi?id=7676
REGRESSION: Selection methods on new text fields don't work if text field is hidden
http://bugzilla.opendarwin.org/show_bug.cgi?id=8867
REGRESSION: selectionStart/End return 0 for input element once it no longer has focus
* fast/forms/double-focus-expected.txt:
* fast/forms/input-selection-hidden-expected.txt: Added.
* fast/forms/input-selection-hidden.html: Added.
* fast/forms/input-selection-restore-expected.txt: Added.
* fast/forms/input-selection-restore.html: Added.
* fast/forms/input-text-paste-maxlength-expected.txt:
* fast/forms/onselect-textarea-expected.txt: Added.
* fast/forms/onselect-textarea.html: Added.
* fast/forms/onselect-textfield-expected.txt: Added.
* fast/forms/onselect-textfield.html: Added.
* fast/forms/selection-functions-expected.txt:
WebCore:
Reviewed by Maciej.
Fixes for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=8724
REGRESSION: onSelect handler doesn't work for text fields
http://bugzilla.opendarwin.org/show_bug.cgi?id=7676
REGRESSION: Selection methods on new text fields don't work if text field is hidden
http://bugzilla.opendarwin.org/show_bug.cgi?id=8867
REGRESSION: selectionStart/End return 0 for input element once it no longer has focus
Implemented onSelect for new text fields and textareas. Also fixed selection restore
behavior to better match other browsers and Safari 2.0 behavior.
Tests:
* fast/forms/input-selection-restore.html
* fast/forms/input-selection-hidden.html
* fast/forms/onselect-textarea.html
* fast/forms/onselect-textfield.html
* html/HTMLInputElement.h: (WebCore::HTMLInputElement::cacheSelection): Added.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::init): Initializes cached selection.
(WebCore::HTMLInputElement::selectionStart): If this element doesn't have focus, return the cached selection value.
(WebCore::HTMLInputElement::selectionEnd): ditto.
(WebCore::HTMLInputElement::setValue): Restore a caret at the starting point of the old selection. Matches Safari 2.0 behavior.
* html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::cacheSelection): Added.
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Initializes cached selection.
(WebCore::HTMLTextAreaElement::selectionStart): If this element doesn't have focus, return the cached selection value.
(WebCore::HTMLTextAreaElement::selectionEnd): ditto.
(WebCore::HTMLTextAreaElement::focus): If this is the first focus, set a caret at the end of the text. Otherwise,
restore the cached selection. This matches other browsers' behavior.
(WebCore::HTMLTextAreaElement::setValue): Restore a caret at the starting point of the old selection. Matches Safari 2.0 behavior.
* page/Frame.h: Added notifyRendererOfSelectionChange method.
* page/Frame.cpp:
(WebCore::Frame::notifyRendererOfSelectionChange): Added. Calls selectionChanged for text fields and textareas. Forwards a userTriggered
argument so selectionChanged knows whether or not to fire onSelect.
(WebCore::Frame::setSelection): Calls notifyRendererOfSelectionChange(false). This gets called for all selection changes, so the renderer
can always update its cached selection values.
(WebCore::Frame::handleMouseReleaseEvent): Calls notifyRendererOfSelectionChange(true) so onSelect will get fired when the user is done
making a selection with the mouse.
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]): Calls notifyRendererOfSelectionChange(true) so onSelect gets
fired when the user makes a selection with the keyboard.
(-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]): ditto.
* rendering/RenderTextField.h: Add userTriggered parameter to selectionChanged.
* rendering/RenderTextField.cpp:
(WebCore::RenderTextField::setSelectionRange): For visibility:hidden, cache the selection and
return early since we won't be able to actually set the selection.
(WebCore::RenderTextField::selectionChanged): Caches the selection.
If the selection is a range, and its triggered by user action, then fire the onSelect event.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14931
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 20 Jun 2006 22:11:12 +0000 (22:11 +0000)]
2006-06-21 Anders Carlsson <acarlsson@apple.com>
* bridge/win/FrameWin.cpp:
(WebCore::shouldInterruptJavaScript):
* bridge/win/FrameWin.h:
Try fixing the Windows build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14930
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 20 Jun 2006 22:07:28 +0000 (22:07 +0000)]
RS by Tim Hatcher.
Renamed RenderSelect to DeprecatedRenderSelect to prepare for new popup menu and list menu implementations.
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLOptionElement.h:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::recalcStyle):
(WebCore::HTMLSelectElement::createRenderer):
(WebCore::HTMLSelectElement::setRecalcListItems):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::notifyOptionSelected):
* html/HTMLSelectElement.h:
* rendering/DeprecatedRenderSelect.cpp: Added.
(WebCore::DeprecatedRenderSelect::DeprecatedRenderSelect):
(WebCore::DeprecatedRenderSelect::setWidgetWritingDirection):
(WebCore::DeprecatedRenderSelect::setStyle):
(WebCore::DeprecatedRenderSelect::updateFromElement):
(WebCore::DeprecatedRenderSelect::baselinePosition):
(WebCore::DeprecatedRenderSelect::calcMinMaxWidth):
(WebCore::DeprecatedRenderSelect::layout):
(WebCore::DeprecatedRenderSelect::valueChanged):
(WebCore::DeprecatedRenderSelect::selectionChanged):
(WebCore::DeprecatedRenderSelect::setOptionsChanged):
(WebCore::DeprecatedRenderSelect::createListBox):
(WebCore::DeprecatedRenderSelect::updateSelection):
* rendering/DeprecatedRenderSelect.h: Added.
(WebCore::DeprecatedRenderSelect::renderName):
* rendering/RenderSelect.cpp: Removed.
* rendering/RenderSelect.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 20 Jun 2006 22:01:13 +0000 (22:01 +0000)]
Commit for real this time - Not just the ChangeLog and some white-space
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 20 Jun 2006 21:34:35 +0000 (21:34 +0000)]
2006-06-20 Anders Carlsson <acarlsson@apple.com>
Reviewed by Geoff.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9509
Would like a way to pause/resume XML parsing
* dom/xml_tokenizer.cpp:
(WebCore::PendingCallbacks::PendingCallbacks):
(WebCore::PendingCallbacks::appendStartElementNSCallback):
(WebCore::PendingCallbacks::appendEndElementNSCallback):
(WebCore::PendingCallbacks::appendCharactersCallback):
(WebCore::PendingCallbacks::appendProcessingInstructionCallback):
(WebCore::PendingCallbacks::appendCDATABlockCallback):
(WebCore::PendingCallbacks::appendCommentCallback):
(WebCore::PendingCallbacks::appendInternalSubsetCallback):
(WebCore::PendingCallbacks::appendErrorCallback):
(WebCore::PendingCallbacks::callAndRemoveFirstCallback):
(WebCore::PendingCallbacks::isEmpty):
(WebCore::PendingCallbacks::PendingCallback::~PendingCallback):
(WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback):
(WebCore::PendingCallbacks::PendingStartElementNSCallback::call):
(WebCore::PendingCallbacks::PendingEndElementNSCallback::call):
(WebCore::PendingCallbacks::PendingCharactersCallback::~PendingCharactersCallback):
(WebCore::PendingCallbacks::PendingCharactersCallback::call):
(WebCore::PendingCallbacks::PendingProcessingInstructionCallback::~PendingProcessingInstructionCallback):
(WebCore::PendingCallbacks::PendingProcessingInstructionCallback::call):
(WebCore::PendingCallbacks::PendingCDATABlockCallback::~PendingCDATABlockCallback):
(WebCore::PendingCallbacks::PendingCDATABlockCallback::call):
(WebCore::PendingCallbacks::PendingCommentCallback::~PendingCommentCallback):
(WebCore::PendingCallbacks::PendingCommentCallback::call):
(WebCore::PendingCallbacks::PendingInternalSubsetCallback::~PendingInternalSubsetCallback):
(WebCore::PendingCallbacks::PendingInternalSubsetCallback::call):
(WebCore::PendingCallbacks::):
New classes which manage a list of pending SAX callbacks that have not yet
been sent to the tokenizer.
(WebCore::XMLTokenizer::XMLTokenizer):
Initialize new member variables.
(WebCore::XMLTokenizer::~XMLTokenizer):
Delete PendingCallbacks object.
(WebCore::XMLTokenizer::write):
If the parser is paused, queue the data to be written.
(WebCore::XMLTokenizer::startElementNs):
(WebCore::XMLTokenizer::endElementNs):
(WebCore::XMLTokenizer::characters):
(WebCore::XMLTokenizer::error):
(WebCore::XMLTokenizer::processingInstruction):
(WebCore::XMLTokenizer::cdataBlock):
(WebCore::XMLTokenizer::comment):
(WebCore::XMLTokenizer::internalSubset):
If the parser has been paused, queue the callbacks instead.
(WebCore::XMLTokenizer::handleError):
New function, called by both ::error and :PendingCallbacks::callAndRemoveFirstCallback
(WebCore::XMLTokenizer::finish):
(WebCore::XMLTokenizer::pauseParsing):
Set m_parserPaused to true.
(WebCore::XMLTokenizer::resumeParsing):
Call the pending callbacks and then parse the pending source.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 20 Jun 2006 21:24:04 +0000 (21:24 +0000)]
Don't send the custom highlighter callback when painting is disabled.
Reviewed by harrison
* WebCore.xcodeproj/project.pbxproj:
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 20 Jun 2006 21:04:08 +0000 (21:04 +0000)]
Reviewed by Tim Hatcher.
* WebView/WebMainResourceLoader.m: Added missing header to fix build on Leopard.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 20 Jun 2006 19:44:08 +0000 (19:44 +0000)]
WebCore:
2006-06-20 Anders Carlsson <acarlsson@apple.com>
Reviewed by John.
<rdar://problem/
4592244> REGRESSION (417.9.3 - 420+): (some?) plain text files have all lines concatenated into one line
* loader/TextDocument.cpp:
(WebCore::TextTokenizer::checkBuffer):
(WebCore::TextTokenizer::TextTokenizer):
(WebCore::TextTokenizer::write):
(WebCore::TextTokenizer::finish):
Add a text buffer which is used for translation of CR and CRLF to plain LF,
like the HTML tokenizer does.
LayoutTests:
2006-06-20 Anders Carlsson <acarlsson@apple.com>
Reviewed by John.
<rdar://problem/
4592244> REGRESSION (417.9.3 - 420+): (some?) plain text files have all lines concatenated into one line
* fast/text/plain-text-line-breaks-expected.checksum: Added.
* fast/text/plain-text-line-breaks-expected.png: Added.
* fast/text/plain-text-line-breaks-expected.txt: Added.
* fast/text/plain-text-line-breaks.html: Added.
* fast/text/resources/line-breaks-cr.txt: Added.
* fast/text/resources/line-breaks-crlf.txt: Added.
* fast/text/resources/line-breaks-lf.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 20 Jun 2006 19:12:19 +0000 (19:12 +0000)]
Reviewed by Darin.
Adds a JavaScript debugger, called Drosera. Named after
a genus of bug eating plants.
* Drosera/DebuggerApplication.h: Added.
* Drosera/DebuggerApplication.m: Added.
(-[DebuggerApplication applicationDidFinishLaunching:]):
(-[DebuggerApplication serverLoaded:]):
(-[DebuggerApplication serverUnloaded:]):
(-[DebuggerApplication awakeFromNib]):
(-[DebuggerApplication showAttachPanel:]):
(-[DebuggerApplication attach:]):
(-[DebuggerApplication numberOfRowsInTableView:]):
(-[DebuggerApplication tableView:objectValueForTableColumn:row:]):
(-[DebuggerApplication tableView:willDisplayCell:forTableColumn:row:]):
(-[DebuggerApplication tableViewSelectionDidChange:]):
* Drosera/DebuggerDocument.h: Added.
* Drosera/DebuggerDocument.m: Added.
(+[WebScriptCallFrame isSelectorExcludedFromWebScript:]):
(+[WebScriptCallFrame isKeyExcludedFromWebScript:]):
(+[DebuggerDocument isSelectorExcludedFromWebScript:]):
(+[DebuggerDocument isKeyExcludedFromWebScript:]):
(-[DebuggerDocument initWithServerName:]):
(-[DebuggerDocument windowWillClose:]):
(-[DebuggerDocument dealloc]):
(-[DebuggerDocument isPaused]):
(-[DebuggerDocument pause]):
(-[DebuggerDocument resume]):
(-[DebuggerDocument step]):
(-[DebuggerDocument windowNibName]):
(-[DebuggerDocument windowDidLoad]):
(-[DebuggerDocument switchToServerNamed:]):
(-[DebuggerDocument applicationTerminating:]):
(-[DebuggerDocument serverConnectionDidDie:]):
(-[DebuggerDocument webView:windowScriptObjectAvailable:]):
(-[DebuggerDocument webView:didFinishLoadForFrame:]):
(-[DebuggerDocument webView:didParseSource:fromURL:sourceId:forWebFrame:]):
(-[DebuggerDocument webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
(-[DebuggerDocument webView:willExecuteStatement:sourceId:line:forWebFrame:]):
(-[DebuggerDocument webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
* Drosera/Drosera.pch: Added.
* Drosera/Drosera.xcodeproj/project.pbxproj: Added.
* Drosera/English.lproj/Debugger.nib/classes.nib: Added.
* Drosera/English.lproj/Debugger.nib/info.nib: Added.
* Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Added.
* Drosera/English.lproj/MainMenu.nib/classes.nib: Added.
* Drosera/English.lproj/MainMenu.nib/info.nib: Added.
* Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Added.
* Drosera/Images/breakPoint.tif: Added.
* Drosera/Images/breakPointDisabled.tif: Added.
* Drosera/Images/continue.tif: Added.
* Drosera/Images/finishFunction.tif: Added.
* Drosera/Images/glossyFooterFill.tif: Added.
* Drosera/Images/glossyHeader.png: Added.
* Drosera/Images/gradientBackground.png: Added.
* Drosera/Images/gutter.png: Added.
* Drosera/Images/navLeftDisabled.png: Added.
* Drosera/Images/navLeftNormal.png: Added.
* Drosera/Images/navLeftPressed.png: Added.
* Drosera/Images/navRightDisabled.png: Added.
* Drosera/Images/navRightNormal.png: Added.
* Drosera/Images/navRightPressed.png: Added.
* Drosera/Images/pause.tif: Added.
* Drosera/Images/popUpArrows.png: Added.
* Drosera/Images/programCounter.tif: Added.
* Drosera/Images/programCounterBreakPoint.tif: Added.
* Drosera/Images/programCounterBreakPointDisabled.tif: Added.
* Drosera/Images/run.tif: Added.
* Drosera/Images/splitterBar.tif: Added.
* Drosera/Images/splitterDimple.tif: Added.
* Drosera/Images/step.tif: Added.
* Drosera/Images/stepOver.tif: Added.
* Drosera/Images/stop.tif: Added.
* Drosera/Images/toolbarBackground.png: Added.
* Drosera/Info.plist: Added.
* Drosera/debugger.css: Added.
* Drosera/debugger.html: Added.
* Drosera/debugger.js: Added.
* Drosera/main.m: Added.
(main):
* Drosera/viewer.css: Added.
* Drosera/viewer.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 20 Jun 2006 19:08:16 +0000 (19:08 +0000)]
Reviewed by Darin.
Removes the @try/@catch from the callbacks to improve performance,
simply check if the proxy object's connection is still valid first.
Listener objects are now required to be NSDistantObjects.
Adds pause, resume and step support. The debugger process use to handle this,
but it caused problems when there were multiple listeners.
Sends the bundle identifier in the notification userInfo dictionary along with
process name and process ID.
* DefaultDelegates/WebScriptDebugServer.h:
* DefaultDelegates/WebScriptDebugServer.m:
(-[WebScriptDebugServer serverQuery:]):
(-[WebScriptDebugServer addListener:]):
(-[WebScriptDebugServer removeListener:]):
(-[WebScriptDebugServer step]):
(-[WebScriptDebugServer pause]):
(-[WebScriptDebugServer resume]):
(-[WebScriptDebugServer isPaused]):
(-[WebScriptDebugServer suspendProcessIfPaused]):
(-[WebScriptDebugServer webView:didParseSource:fromURL:sourceId:forWebFrame:]):
(-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
(-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]):
(-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
* DefaultDelegates/WebScriptDebugServerPrivate.h:
* WebKit.exp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 20 Jun 2006 08:14:30 +0000 (08:14 +0000)]
Reviewed by Eric.
- fix crasher on one of the layout tests caused by my recent checkin
* kcanvas/RenderSVGText.cpp:
(WebCore::RenderSVGText::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 20 Jun 2006 05:17:14 +0000 (05:17 +0000)]
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=5499
Page reload does not send any cache control headers
WebCore:
* bindings/js/kjs_window.cpp:
(KJS::LocationFunc::callAsFunction): Call scheduleRefresh() for Location::Reload.
* page/Frame.h: Add scheduleRefresh(). Don't derive from TransferJob or implement its methods - that was
used only for storing response HTTP headers, which was an overkill.
* page/FramePrivate.h: Replace TransferJob with a HashMap for storing response headers.
* page/Frame.cpp:
(WebCore::Frame::didOpenURL): Don't needlessly change d->m_cachePolicy. Don't create a TransferJob.
(WebCore::Frame::stopLoading): Directly access the metadata map, instead of going through a TransferJob.
(WebCore::Frame::receivedFirstData): Ditto.
(WebCore::Frame::addMetaData): Ditto.
(WebCore::Frame::scheduleRefresh): A new function that schedules a refresh, similarly to what
scheduleRedirection() does.
(WebCore::Frame::changeLocation): Set request.reload attribute based on the current cache policy.
WebKit:
* WebView/WebFrame.m:
(-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): Set a proper Cache-Control header for
reload requests.
(-[WebFrame loadRequest:]): Reset loadType to WebFrameLoadTypeStandard (after a reload, it stayed at
WebFrameLoadTypeReload, so _addExtraFieldsToRequest erroneously added a Cache-Control header to them).
LayoutTests:
* http/tests/misc/refresh-headers-expected.txt: Added.
* http/tests/misc/refresh-headers.php: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Tue, 20 Jun 2006 03:20:14 +0000 (03:20 +0000)]
WebCore:
Reviewed by Darin. Patch by Ben Goodger.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9501
Windows build fails with link error CharsetTable not defined
* platform/make-charset-table.pl:
(process_iana_charsets): Move test for equality to alias "None" until after
normalization steps to ensure escape characters in the input data don't
interfere with processing. Convert nearby tabs to 4 spaces in this function.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 20 Jun 2006 02:43:10 +0000 (02:43 +0000)]
Reviewed by Darin.
- fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=9488
"Animated GIFs do not respect transforms in SVG"
http://bugzilla.opendarwin.org/show_bug.cgi?id=6946
"SVG shows invalidation issues in WebKit"
http://www.treebuilder.de/default.asp?file=441875.xml
"Invalidation issues with "SVG 3d" demo"
http://code.google.com/webstats/2005-12/pages.html
"SVG text doesn't repaint correctly"
* kcanvas/KCanvasContainer.cpp:
(WebCore::KCanvasContainer::computeAbsoluteRepaintRect): Override base class, and apply
appropriate transforms, so damage rects in transformed SVG content get propagated up properly.
(WebCore::KCanvasContainer::getAbsoluteRepaintRect): note a FIXME; this method
seems wrong.
* kcanvas/KCanvasContainer.h: Prototype new method.
* css/svg.css: Don't apply overflow:hidden to foreignObject, since that makes it a RenderLayer
so it paints twice.
* kcanvas/RenderForeignObject.cpp:
(WebCore::RenderForeignObject::paint): Transform the damage rect before passing it down to HTML content,
so everything paints that is supposed to. Also handle opacity here since we won't get layers.
(WebCore::RenderForeignObject::computeAbsoluteRepaintRect): Override base class, and apply
appropriate transforms, so damage rects in HTML embedded in SVG get propagated up properly.
(WebCore::RenderForeignObject::requiresLayer): Never use a RenderLayer.
(WebCore::RenderForeignObject::layout): Make sure to dirty our previous bounds when layout
changes, as by transform.
* kcanvas/RenderForeignObject.h:
* kcanvas/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint): Transform the damage rect when painting. Also handle opacity
here since we won't get layers.
(WebCore::RenderForeignObject::computeAbsoluteRepaintRect): Override base class, and apply
appropriate transforms, so damage rects in SVG images get propagated up properly.
(WebCore::RenderSVGImage::translationForAttributes): New helper method, factored out of below.
(WebCore::RenderSVGImage::translateForAttributes): Use above.
(WebCore::RenderSVGImage::requiresLayer): Never use a RenderLayer.
(WebCore::RenderSVGImage::layout): Make sure to properly dirty the old bounds, accounting
for transforms.
(WebCore::RenderSVGImage::relativeBBox): Correct bbox computation.
* kcanvas/RenderSVGImage.h:
* kcanvas/RenderSVGText.cpp:
(WebCore::RenderSVGText::paint): Transform incoming damage rect. Handle opacity here since we
won't get a layer.
(WebCore::RenderSVGText::computeAbsoluteRepaintRect): Apply transforms.
(WebCore::RenderSVGText::requiresLayer): Never use a RenderLayer.
(WebCore::RenderSVGText::layout): Make sure to dirty the old bounds.
* platform/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::roundToDevicePixels): Instead of transforming rect to device space
and back to user space, do this for the origin and lower right corner of the rect. Otherwise the
rect will get inflated if user space is rotated or skewed.
* kcanvas/RenderPath.cpp:
(WebCore::RenderPath::layout): Make sure to dirty the old bounds.
(WebCore::RenderPath::paint): Hhandle opacity here.
Bonus fix:
* kcanvas/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::nodeAtPoint): Fix hit testing. Wasn't applying the x/y
attribute transform.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 19 Jun 2006 23:31:31 +0000 (23:31 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 19 Jun 2006 22:58:36 +0000 (22:58 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Mon, 19 Jun 2006 21:58:12 +0000 (21:58 +0000)]
Reviewed by Darin.
- added mechanism to notify UIDelegate when part of the webview is redrawn. For now, it only
works for HTML views.
* WebView/WebUIDelegatePrivate.h:
Define a new UIDelegate method -webView:didDrawRect:
* WebView/WebHTMLView.m:
(-[WebView drawSingleRect:]):
Call through to UIDelegate if it implements that method. I tested that this does not impact PLT numbers
in the case where the delegate implements the method but does nothing in it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 19 Jun 2006 21:39:28 +0000 (21:39 +0000)]
Reviewed by Brady.
- removed a few empty/unused files Brady found by tracking down the nm error message
* editing/VisibleRange.cpp: Removed.
* editing/VisibleRange.h: Removed.
* kcanvas/KCanvasImage.cpp: Removed.
* WebCore.vcproj/WebCore/WebCore.vcproj: Removed VisibleRange.cpp/h.
* WebCore.xcodeproj/project.pbxproj: Removed VisibleRange.cpp/h and KCanvasImage.cpp.
* WebCoreSources.bkl: Removed VisibleRange.cpp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Mon, 19 Jun 2006 19:23:18 +0000 (19:23 +0000)]
2006-06-19 Anders Carlsson <acarlsson@apple.com>
Reviewed by John.
* kjs/interpreter.cpp:
(KJS::TimeoutChecker::pauseTimeoutCheck):
(KJS::TimeoutChecker::resumeTimeoutCheck):
Fix argument order in setitimer calls.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 19 Jun 2006 16:42:35 +0000 (16:42 +0000)]
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9492
Fix or remove window.debug.
It was only available in newly created windows, and became undefined after changing the URL
or reloading. Let's try removing it; hopefully, no-one will notice.
* bindings/js/kjs_proxy.cpp:
(WebCore::KJSProxy::initScriptIfNeeded): Don't add window.debug.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 19 Jun 2006 16:15:31 +0000 (16:15 +0000)]
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=8972
REGRESSION: invalid UTF-8 sequences are not displayed
Test: LayoutTests/fast/encoding/invalid-UTF-8.html
* dom/xml_tokenizer.cpp:
(WebCore::getXHTMLEntity): Properly null-terminate the result. This didn't matter
before, because the garbage at the end was guaranteed to be invalid UTF-8, and was
omitted in appendOmittingUnwanted();
* platform/StreamingTextDecoder.cpp:
(WebCore::StreamingTextDecoder::appendOmittingBOM): Only omit BOM characters.
Renamed back from appendOmittingUnwanted();
(WebCore::StreamingTextDecoder::convertUsingICU):
* platform/StreamingTextDecoder.h:
Update for the above function renaming.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Mon, 19 Jun 2006 10:51:11 +0000 (10:51 +0000)]
WebKit:
Reviewed by Maciej.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9452
Assertion failure in -[WebFramePrivate setProvisionalDataSource:]
* WebView/WebFrame.m:
(-[WebFrame _checkLoadCompleteForThisFrame]): Avoid re-entering the delegate's
-[webView:didFailProvisionalLoadWithError:forFrame].
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Mon, 19 Jun 2006 00:00:53 +0000 (00:00 +0000)]
WebKitTools:
Reviewed by darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9485
Teach svn-apply and svn-unapply to use full path names
* Scripts/svn-apply: Changed to use full path names. Cleaned up code.
* Scripts/svn-unapply: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sun, 18 Jun 2006 23:54:59 +0000 (23:54 +0000)]
WebCore:
Reviewed by darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9498
Remove dead code left in JSHTMLDocument::getOwnPropertySlot() from r14298 (Bug 7838)
* bindings/js/kjs_html.cpp:
(KJS::JSHTMLDocument::getOwnPropertySlot): Remove dead code.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sun, 18 Jun 2006 22:20:04 +0000 (22:20 +0000)]
LayoutTests:
Reviewed by ggaren.
* fast/history/clicked-link-is-visited.html: Changed to use DOM mouse event.
WebCore:
Reviewed by ggaren.
* manual-tests/redraw-page-cache-visited-links.html: Changed to use DOM mouse event.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sun, 18 Jun 2006 17:58:53 +0000 (17:58 +0000)]
WebKit:
Reviewed by xenon.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=9479
Disassociate the inspector from the frame when it detaches from its parent
* WebInspector/WebInspector.m:
(-[NSWindow setWebFrame:]): Added code to (de)register with the WebFrame
the inspector is (no longer) targeting.
(-[WebInspector _webFrameDetached:]): Added. Moved the code that was previously
in -[inspectedWindowWillClose:] here. This is called by the WebFrame when it
is detached from its parent.
* WebInspector/WebInspectorInternal.h:
* WebView/WebFrame.m:
(-[WebFramePrivate dealloc]):
(-[WebFrame _detachFromParent]): Added code to notify all registered inspectors
that the WebFrame is detaching.
(-[WebFrame _addInspector:]): Added.
(-[WebFrame _removeInspector:]): Added.
* WebView/WebFrameInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log