WebKit-https.git
10 years ago2011-04-26 Leo Yang <leo.yang@torchmobile.com.cn>
leo.yang@torchmobile.com.cn [Tue, 26 Apr 2011 09:57:11 +0000 (09:57 +0000)]
2011-04-26  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        ASSERT failure in SVGUseElement
        https://bugs.webkit.org/show_bug.cgi?id=59313

        Test case to verify webkit doesn't crash when a <use> element
        is pending on resource and the document is not well-formed.
        Test passes if no crash occurs in debug mode.

        * svg/custom/use-crash-in-non-wellformed-document-expected.txt: Added.
        * svg/custom/use-crash-in-non-wellformed-document.svg: Added.
2011-04-26  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        ASSERT failure in SVGUseElement
        https://bugs.webkit.org/show_bug.cgi?id=59313

        In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
        was wrong because the document may not be well-formed.

        This patch asserts the element is not pending on resource or the
        document is not well-formed.

        Test: svg/custom/use-crash-in-non-wellformed-document.svg

        * svg/SVGUseElement.cpp:
        (WebCore::isWellFormedDocument):
        (WebCore::SVGUseElement::insertedIntoDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-26 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Tue, 26 Apr 2011 09:41:57 +0000 (09:41 +0000)]
2011-04-26  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Fix columns resizing in the detailed heap snapshot grids.
        https://bugs.webkit.org/show_bug.cgi?id=59438

        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.DetailedHeapshotView.prototype._changeView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-26 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Tue, 26 Apr 2011 08:38:28 +0000 (08:38 +0000)]
2011-04-26  Chang Shu  <cshu@webkit.org>

        Reviewed by Sam Weinig.

        Convert fast/dom/keydown-1.html to dumpAsText test
        https://bugs.webkit.org/show_bug.cgi?id=59390

        * fast/events/keydown-1-expected.txt: Added.
        * fast/events/keydown-1.html:
        * platform/mac/fast/events/keydown-1-expected.png: Removed.
        * platform/mac/fast/events/keydown-1-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-26 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Tue, 26 Apr 2011 08:37:25 +0000 (08:37 +0000)]
2011-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix WebKit2 GTK build after r84785.

        * UIProcess/gtk/WebInspectorGtk.cpp:
        (WebKit::WebInspectorProxy::platformAttach):
        (WebKit::WebInspectorProxy::platformDetach):
        (WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-26 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Tue, 26 Apr 2011 08:33:49 +0000 (08:33 +0000)]
2011-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix WebKit2 GTK build after r84886

        * Platform/gtk/RunLoopGtk.cpp: Include WorkItem.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-26 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 26 Apr 2011 08:31:24 +0000 (08:31 +0000)]
2011-04-26  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Chromium DevTools: recognize WebP as a valid mimetype in the Chromium port.
        https://bugs.webkit.org/show_bug.cgi?id=59332

        * src/js/DevTools.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 26 Apr 2011 07:43:22 +0000 (07:43 +0000)]
2011-04-26  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        WebKit/chromium should play nice with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59434

        This fixes about half the issues.

        * src/ApplicationCacheHost.cpp:
        (WebCore::ApplicationCacheHost::maybeLoadMainResource):
        * src/ApplicationCacheHostInternal.h:
        (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):
        * src/AutoFillPopupMenuClient.cpp:
        (WebKit::AutoFillPopupMenuClient::initialize):
        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3DInternal::initialize):
        * src/ResourceHandle.cpp:
        (WebCore::ResourceHandleInternal::start):
        (WebCore::ResourceHandle::ResourceHandle):
        (WebCore::ResourceHandle::loadResourceSynchronously):
        * src/SocketStreamHandle.cpp:
        (WebCore::SocketStreamHandleInternal::connect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a few OwnPtr strict errors in WebCore headers.
levin@chromium.org [Tue, 26 Apr 2011 07:31:19 +0000 (07:31 +0000)]
Fix a few OwnPtr strict errors in WebCore headers.
https://bugs.webkit.org/show_bug.cgi?id=59431

Reviewed by Adam Barth.

* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
* css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::prepareEvaluator):
* dom/NodeRareData.h:
(WebCore::NodeListsNodeData::create):
* dom/ScriptRunner.h:
(WebCore::ScriptRunner::create):
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::connectFrontend):
* loader/icon/IconDatabase.h:
(WebCore::IconDatabase::create):
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::verticalRightOrientationFontData):
(WebCore::SimpleFontData::uprightOrientationFontData):
(WebCore::SimpleFontData::brokenIdeographFontData):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
* rendering/svg/SVGResources.h:
(WebCore::SVGResources::ClipperFilterMaskerData::create):
(WebCore::SVGResources::MarkerData::create):
(WebCore::SVGResources::FillStrokeData::create):
* storage/StorageSyncManager.cpp:
(WebCore::StorageSyncManager::close):
* workers/WorkerContext.cpp:
(WebCore::CloseWorkerContextTask::create):
* workers/WorkerMessagingProxy.cpp:
(WebCore::MessageWorkerContextTask::create):
(WebCore::MessageWorkerTask::create):
(WebCore::WorkerExceptionTask::create):
(WebCore::WorkerContextDestroyedTask::create):
(WebCore::WorkerTerminateTask::create):
(WebCore::WorkerThreadActivityReportTask::create):
* workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::Task::create):
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::create):
(WebCore::WorkerThreadShutdownFinishTask::create):
(WebCore::WorkerThreadShutdownStartTask::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-26 Adam Klein <adamk@chromium.org>
abarth@webkit.org [Tue, 26 Apr 2011 07:30:16 +0000 (07:30 +0000)]
2011-04-26  Adam Klein  <adamk@chromium.org>

        Reviewed by Adam Barth.

        Fix last strict OwnPtr violation under svg/...
        https://bugs.webkit.org/show_bug.cgi?id=59429

        * svg/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::removePendingResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 26 Apr 2011 07:27:39 +0000 (07:27 +0000)]
2011-04-26  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Fix more strict OwnPtr violations in WebCore
        https://bugs.webkit.org/show_bug.cgi?id=59433

        These manifest in the Chromium build.

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::ScriptController):
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::editScriptSource):
        * bindings/v8/V8DOMMap.cpp:
        (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::precompileScript):
        * bindings/v8/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::WorkerScriptController):
        * page/Page.cpp:
        (WebCore::Page::Page):
        (WebCore::Page::speechInput):
        * platform/PlatformGestureRecognizer.cpp:
        (WebCore::PlatformGestureRecognizer::create):
        * platform/PlatformGestureRecognizer.h:
        * platform/graphics/chromium/DrawingBufferChromium.cpp:
        (WebCore::DrawingBuffer::DrawingBuffer):
        * platform/graphics/chromium/cc/CCLayerImpl.cpp:
        (WebCore::CCLayerImpl::CCLayerImpl):
        * platform/graphics/gpu/Texture.cpp:
        (WebCore::Texture::create):
        * platform/image-decoders/bmp/BMPImageDecoder.cpp:
        (WebCore::BMPImageDecoder::decodeHelper):
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::decode):
        * platform/image-decoders/ico/ICOImageDecoder.cpp:
        (WebCore::ICOImageDecoder::decodeAtIndex):
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageDecoder::decode):
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::decode):
        * storage/chromium/DatabaseTrackerChromium.cpp:
        (WebCore::DatabaseTracker::addOpenDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoConvert LayoutTests/fast/events/onloadFrameCrash.html from pixel test to text-based...
ossy@webkit.org [Tue, 26 Apr 2011 07:18:14 +0000 (07:18 +0000)]
Convert LayoutTests/fast/events/onloadFrameCrash.html from pixel test to text-based test
https://bugs.webkit.org/show_bug.cgi?id=59362

We don't need Qt specific expected file after r84817.

* platform/qt/fast/events/onloadFrameCrash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix OwnPtr strict errors in CrossThreadTask.h
levin@chromium.org [Tue, 26 Apr 2011 06:59:25 +0000 (06:59 +0000)]
Fix OwnPtr strict errors in CrossThreadTask.h
https://bugs.webkit.org/show_bug.cgi?id=59427

Reviewed by Adam Barth.

* dom/CrossThreadTask.h:
(WebCore::CrossThreadTask1::create):
(WebCore::CrossThreadTask2::create):
(WebCore::CrossThreadTask3::create):
(WebCore::CrossThreadTask4::create):
(WebCore::CrossThreadTask5::create):
(WebCore::CrossThreadTask6::create):
(WebCore::CrossThreadTask7::create):
(WebCore::CrossThreadTask8::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>'
mrowe@apple.com [Tue, 26 Apr 2011 06:54:30 +0000 (06:54 +0000)]
<rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>'

Reviewed by Dan Bernstein.

* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Don't initialize CSSPropertyWebkitMaskSize twice.
* css/CSSStyleApplyProperty.h:
(WebCore::CSSStyleApplyProperty::setPropertyValue): Add some asserts to catch this class of leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 26 Apr 2011 06:46:38 +0000 (06:46 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        WebKit2 should play nice with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59426

        Fix include ordering.

        * WebView/WebDeviceOrientationProviderMock.mm:
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        WebKit2 should play nice with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59426

        * Platform/CoreIPC/Connection.cpp:
        (CoreIPC::Connection::waitForMessage):
            - Lack of OwnPtr in HashMap is sad face.  This code becomes very
              pretty if we could use OwnPtr in HashMap...
        * Platform/RunLoop.cpp:
        (RunLoop::performWork):
        (RunLoop::scheduleWork):
        * Platform/RunLoop.h:
        * Platform/mac/WorkQueueMac.cpp:
        (WorkQueue::executeWorkItem):
        * WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
        (WebKit::NetscapePluginStream::deliverData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Tue, 26 Apr 2011 06:31:17 +0000 (06:31 +0000)]
2011-04-25  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        REGRESSION: a character appears after tab span when typing immediately before the tab span
        https://bugs.webkit.org/show_bug.cgi?id=58132

        Correcting the order of operations we use to avoid inserting into invalid positions in
        ReplaceSelectionCommand to avoid inserting into tab-spans.

        Test: editing/pasteboard/paste-before-tab-span.html

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Moving positionOutsideTabSpan to after
        positionAvoidingPrecedingNodes, since that function could once again put our position
        inside a tab span.
2011-04-25  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        REGRESSION: a character appears after tab span when typing immediately before the tab span
        https://bugs.webkit.org/show_bug.cgi?id=58132

        Correcting the order of operations we use to avoid inserting into invalid positions in
        ReplaceSelectionCommand to avoid inserting into tab-spans.

        * editing/pasteboard/paste-before-tab-span-expected.txt: Added.
        * editing/pasteboard/paste-before-tab-span.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix OwnPtr strict error in ImageBuffer.h
levin@chromium.org [Tue, 26 Apr 2011 06:26:59 +0000 (06:26 +0000)]
Fix OwnPtr strict error in ImageBuffer.h
https://bugs.webkit.org/show_bug.cgi?id=59422

Reviewed by Adam Barth.

* platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 26 Apr 2011 06:24:56 +0000 (06:24 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        WebKit1 should build cleanly with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59424

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem initFromDictionaryRepresentation:]):
        * Plugins/WebNetscapePluginEventHandler.h:
        * Plugins/WebNetscapePluginEventHandler.mm:
        (WebNetscapePluginEventHandler::create):
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView createPlugin]):
        * WebView/WebDeviceOrientationProviderMock.mm:
        * WebView/WebTextIterator.mm:
        (-[WebTextIterator initWithRange:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 26 Apr 2011 06:23:14 +0000 (06:23 +0000)]
2011-04-25  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Custom prototypes on DOM objects don't persist after garbage collection
        https://bugs.webkit.org/show_bug.cgi?id=59412

        SunSpider reports no change.

        The hasCustomProperties() check didn't check for a custom prototype.

        * runtime/JSObject.h:
        (JSC::JSObject::hasCustomProperties): Changed to delegate to Structure
        because it is the "truth" about an object's pedigree.

        * runtime/Structure.cpp:
        (JSC::Structure::Structure):
        * runtime/Structure.h:
        (JSC::Structure::didTransition): Track whether a Structure has ever
        transitioned for any reason. If so, we have to assume that the object
        holding it is custom in some way.
2011-04-25  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Custom prototypes on DOM objects don't persist after garbage collection
        https://bugs.webkit.org/show_bug.cgi?id=59412

        * fast/dom/gc-custom-prototype-expected.txt: Added.
        * fast/dom/gc-custom-prototype.html: Added.
        * fast/dom/script-tests/dataset-gc.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 26 Apr 2011 06:22:01 +0000 (06:22 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Fix strict OwnPtr violations and whitelist known-tricky files
        https://bugs.webkit.org/show_bug.cgi?id=59421

        With this patch, WebCore builds cleanly with strict OwnPtrs.

        * dom/MessagePort.cpp:
        (WebCore::MessagePort::MessagePort):
        * dom/XMLDocumentParserLibxml2.cpp:
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::ContextMenuController):
        (WebCore::ContextMenuController::clearContextMenu):
        * page/PluginHalter.cpp:
        * platform/graphics/MediaPlayer.cpp:
        * platform/network/ResourceRequestBase.cpp:
        (WebCore::ResourceRequestBase::adopt):
        (WebCore::ResourceRequestBase::copyData):
        * svg/SVGDocumentExtensions.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix OwnPtr strict errors in DatasetDOMStringMap.h.
levin@chromium.org [Tue, 26 Apr 2011 05:45:06 +0000 (05:45 +0000)]
Fix OwnPtr strict errors in DatasetDOMStringMap.h.
https://bugs.webkit.org/show_bug.cgi?id=59419

Reviewed by Adam Barth.

* dom/DatasetDOMStringMap.h:
(WebCore::DatasetDOMStringMap::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
abarth@webkit.org [Tue, 26 Apr 2011 05:40:53 +0000 (05:40 +0000)]
2011-04-25  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Eric Seidel.

        KeyboardEvent.cpp should work with strict OwnPtrs.
        https://bugs.webkit.org/show_bug.cgi?id=59403

        * dom/KeyboardEvent.cpp:
        (WebCore::KeyboardEvent::KeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 26 Apr 2011 05:10:08 +0000 (05:10 +0000)]
2011-04-25  Daniel Bates  <dbates@webkit.org>

        Update some call sites that referenced the old location for
        the scripts {animation, transition}-test-helpers.js. These
        scripts were moved in <http://trac.webkit.org/changeset/84872>,
        and <http://trac.webkit.org/changeset/84874>, respectively.

        * compositing/animation/computed-style-during-delay.html:
        * compositing/reflections/animation-inside-reflection.html:
        * compositing/reflections/nested-reflection-animated.html:
        * compositing/reflections/nested-reflection-transition.html:
        * compositing/transitions/scale-transition-no-start.html:
        * compositing/transitions/singular-scale-transition.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 26 Apr 2011 05:05:05 +0000 (05:05 +0000)]
2011-04-25  James Robinson  <jamesr@chromium.org>

        Reviewed by Eric Seidel.

        Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
        https://bugs.webkit.org/show_bug.cgi?id=59377

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * page/animation/AnimationBase.cpp:
        (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
        (WebCore::PropertyWrapperShadow::blend):
        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::setTextShadow):
        (WebCore::RenderStyle::setBoxShadow):
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::textShadow):
        * rendering/style/StyleRareInheritedData.cpp:
        (WebCore::StyleRareInheritedData::StyleRareInheritedData):
        (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
        * rendering/style/StyleRareInheritedData.h:
        * rendering/style/StyleRareNonInheritedData.cpp:
        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTeach build-webkit where newer Xcode versions store the application-wide build settin...
mitz@apple.com [Tue, 26 Apr 2011 04:53:27 +0000 (04:53 +0000)]
Teach build-webkit where newer Xcode versions store the application-wide build settings user default.

Reviewed by Mark Rowe.

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 26 Apr 2011 03:25:14 +0000 (03:25 +0000)]
2011-04-25  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Clean up transition tests
        https://bugs.webkit.org/show_bug.cgi?id=59410

        General test cleanup: use the named variables as
        arguments to runTransitionTest() for readability,
        remove unnecessary titles and meta tags, remove
        style and script tag attributes etc. No substantive
        changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 26 Apr 2011 03:17:17 +0000 (03:17 +0000)]
2011-04-25  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Daniel Bates.

        Move transition-test-helpers.js to resources/
        https://bugs.webkit.org/show_bug.cgi?id=59397

        Move transition-test-helpers.js and fix tests.

        * transitions/background-transitions.html:
        * transitions/border-radius-transition.html:
        * transitions/clip-transition.html:
        * transitions/color-transition-all.html:
        * transitions/color-transition-premultiplied.html:
        * transitions/default-timing-function.html:
        * transitions/font-family-during-transition.html:
        * transitions/mask-transitions.html:
        * transitions/min-max-width-height-transitions.html:
        * transitions/mismatched-shadow-styles.html:
        * transitions/move-after-transition.html:
        * transitions/multiple-background-size-transitions.html:
        * transitions/multiple-background-transitions.html:
        * transitions/multiple-mask-transitions.html:
        * transitions/multiple-shadow-transitions.html:
        * transitions/negative-delay.html:
        * transitions/resources/interrupted-accelerated-transition-final.html:
        * transitions/resources/transition-test-helpers.js:
        (roundNumber):
        (isCloseEnough):
        (isShadow):
        ():
        (expected):
        (callback.delay):
        * transitions/shorthand-border-transitions.html:
        * transitions/shorthand-transitions.html:
        * transitions/steps-timing-function.html:
        * transitions/svg-text-shadow-transition.html:
        * transitions/text-indent-transition.html:
        * transitions/transform-op-list-match.html:
        * transitions/transform-op-list-no-match.html:
        * transitions/transition-drt-api-delay.html:
        * transitions/transition-end-event-rendering.html:
        * transitions/transition-hit-test-transform.html:
        * transitions/transition-shorthand-delay.html:
        * transitions/zero-duration-in-list.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 26 Apr 2011 03:16:49 +0000 (03:16 +0000)]
2011-04-25  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Daniel Bates.

        Make a couple of animation tests into text tests
        https://bugs.webkit.org/show_bug.cgi?id=59389

        * animations/animation-drt-api-multiple-keyframes.html:
        * animations/animation-drt-api.html:
        No need for these two to be text tests.

        * animations/state-at-end-event.html:
        General cleanup.

        * animations/animation-drt-api-expected.txt: Added.
        * animations/animation-drt-api-multiple-keyframes-expected.txt: Added.
        * animations/animation-drt-api-multiple-keyframes.html:
        * animations/animation-drt-api.html:
        * animations/state-at-end-event.html:
        * platform/mac/animations/animation-drt-api-expected.png: Removed.
        * platform/mac/animations/animation-drt-api-expected.txt: Removed.
        * platform/mac/animations/animation-drt-api-multiple-keyframes-expected.png: Removed.
        * platform/mac/animations/animation-drt-api-multiple-keyframes-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 26 Apr 2011 03:16:31 +0000 (03:16 +0000)]
2011-04-25  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Daniel Bates.

        Move animation-test-helpers.js into resources directory
        https://bugs.webkit.org/show_bug.cgi?id=59365

        Move animation-test-helpers.js and fix the tests accordingly.

        * animations/3d/matrix-transform-type-animation.html:
        * animations/3d/transform-perspective.html:
        * animations/animation-direction.html:
        * animations/animation-drt-api-multiple-keyframes.html:
        * animations/animation-drt-api.html:
        * animations/animation-hit-test-transform.html:
        * animations/animation-hit-test.html:
        * animations/big-rotation.html:
        * animations/change-keyframes-name.html:
        * animations/change-keyframes.html:
        * animations/change-one-anim.html:
        * animations/combo-transform-rotate+scale.html:
        * animations/dynamic-stylesheet-loading.html:
        * animations/generic-from-to.html:
        * animations/import.html:
        * animations/keyframe-timing-functions-transform.html:
        * animations/keyframe-timing-functions.html:
        * animations/keyframe-timing-functions2.html:
        * animations/keyframes-comma-separated.html:
        * animations/keyframes-out-of-order.html:
        * animations/keyframes.html:
        * animations/lineheight-animation.html:
        * animations/longhand-timing-function.html:
        * animations/matrix-anim.html:
        * animations/missing-from-to-transforms.html:
        * animations/missing-from-to.html:
        * animations/missing-keyframe-properties-repeating.html:
        * animations/missing-keyframe-properties-timing-function.html:
        * animations/missing-keyframe-properties.html:
        * animations/missing-values-first-keyframe.html:
        * animations/missing-values-last-keyframe.html:
        * animations/multiple-animations.html:
        * animations/multiple-keyframes.html:
        * animations/negative-delay.html:
        * animations/opacity-transform-animation.html:
        * animations/play-state-suspend.html:
        * animations/play-state.html:
        * animations/resources/animation-test-helpers.js:
        (isCloseEnough):
        (matrixStringToArray):
        (checkExpectedValue):
        (endTest):
        (startTest):
        (runAnimationTest.else):
        (runAnimationTest):
        (waitForAnimationToStart):
        * animations/simultaneous-start-left.html:
        * animations/simultaneous-start-transform.html:
        * animations/stop-animation-on-suspend.html:
        * animations/suspend-resume-animation.html:
        * animations/timing-functions.html:
        * animations/transition-and-animation-1.html:
        * animations/transition-and-animation-2.html:
        * animations/transition-and-animation-3.html:
        * animations/unanimated-style.html:
        * animations/width-using-ems.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 26 Apr 2011 03:14:21 +0000 (03:14 +0000)]
2011-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84864.
        http://trac.webkit.org/changeset/84864
        https://bugs.webkit.org/show_bug.cgi?id=59413

        Expect result of use-crash-in-non-wellformed-document.svg is
        platform dependent (Requested by leoyang on #webkit).

        * svg/custom/use-crash-in-non-wellformed-document-expected.txt: Removed.
        * svg/custom/use-crash-in-non-wellformed-document.svg: Removed.
2011-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84864.
        http://trac.webkit.org/changeset/84864
        https://bugs.webkit.org/show_bug.cgi?id=59413

        Expect result of use-crash-in-non-wellformed-document.svg is
        platform dependent (Requested by leoyang on #webkit).

        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::insertedIntoDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 26 Apr 2011 02:56:42 +0000 (02:56 +0000)]
2011-04-25  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change. Remove tests that are no longer
        failing, add missing baselines for Chromium Mac SL.

        * platform/chromium/test_expectations.txt:
        * platform/chromium-mac/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
        * platform/chromium-mac/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added.
        * platform/chromium-mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 26 Apr 2011 02:26:03 +0000 (02:26 +0000)]
2011-04-25  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Ojan Vafai.

        Convert fast/events/focusingUnloadedFrame.html to dumpAsText
        https://bugs.webkit.org/show_bug.cgi?id=59371

        * fast/events/focusingUnloadedFrame-expected.txt: Added.
        * fast/events/focusingUnloadedFrame.html:
        * platform/chromium-linux/fast/events/focusingUnloadedFrame-expected.png: Removed.
        * platform/chromium-win/fast/events/focusingUnloadedFrame-expected.png: Removed.
        * platform/chromium-win/fast/events/focusingUnloadedFrame-expected.txt: Removed.
        * platform/gtk/fast/events/focusingUnloadedFrame-expected.png: Removed.
        * platform/gtk/fast/events/focusingUnloadedFrame-expected.txt: Removed.
        * platform/mac-leopard/fast/events/focusingUnloadedFrame-expected.png: Removed.
        * platform/mac/fast/events/focusingUnloadedFrame-expected.png: Removed.
        * platform/mac/fast/events/focusingUnloadedFrame-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Leo Yang <leo.yang@torchmobile.com.cn>
leo.yang@torchmobile.com.cn [Tue, 26 Apr 2011 02:04:12 +0000 (02:04 +0000)]
2011-04-25  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        ASSERT failure in SVGUseElement
        https://bugs.webkit.org/show_bug.cgi?id=59313

        In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
        was wrong because the document may not be well-formed.

        This patch asserts the element is not pending on resource or the
        document is not well-formed.

        Test: svg/custom/use-crash-in-non-wellformed-document.svg

        * svg/SVGUseElement.cpp:
        (WebCore::isWellFormedDocument):
        (WebCore::SVGUseElement::insertedIntoDocument):
2011-04-25  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        ASSERT failure in SVGUseElement
        https://bugs.webkit.org/show_bug.cgi?id=59313

        Test case to verify webkit doesn't crash when a <use> element
        is pending on resource and the document is not well-formed.
        Test passes if no crash occurs in debug mode.

        * svg/custom/use-crash-in-non-wellformed-document-expected.txt: Added.
        * svg/custom/use-crash-in-non-wellformed-document.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 26 Apr 2011 02:02:29 +0000 (02:02 +0000)]
2011-04-25  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        Convert fast/loader/start-load-in-unload.html to dumpAsText
        https://bugs.webkit.org/show_bug.cgi?id=59384

        * fast/loader/start-load-in-unload-expected.txt: Added.
        * fast/loader/start-load-in-unload.html:
        * platform/chromium-linux/fast/loader/start-load-in-unload-expected.png: Removed.
        * platform/chromium-win/fast/loader/start-load-in-unload-expected.png: Removed.
        * platform/chromium-win/fast/loader/start-load-in-unload-expected.txt: Removed.
        * platform/gtk/fast/loader/start-load-in-unload-expected.png: Removed.
        * platform/gtk/fast/loader/start-load-in-unload-expected.txt: Removed.
        * platform/mac-leopard/fast/loader/start-load-in-unload-expected.png: Removed.
        * platform/mac/fast/loader/start-load-in-unload-expected.png: Removed.
        * platform/mac/fast/loader/start-load-in-unload-expected.txt: Removed.
        * platform/qt/fast/loader/start-load-in-unload-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 26 Apr 2011 01:59:27 +0000 (01:59 +0000)]
2011-04-25  Tony Chang  <tony@chromium.org>

        Reviewed by Antonio Gomes.

        replace a setTimeout with a onload event to save 2 seconds in a test
        https://bugs.webkit.org/show_bug.cgi?id=59350

        * http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 26 Apr 2011 01:44:00 +0000 (01:44 +0000)]
2011-04-25  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Ojan Vafai.

        Convert fast/events/event-sender-mouse-moved.html to dumpAsText
        https://bugs.webkit.org/show_bug.cgi?id=59366

        * fast/events/event-sender-mouse-moved-expected.txt: Added.
        * fast/events/event-sender-mouse-moved.html:
        * platform/chromium-linux/fast/events/event-sender-mouse-moved-expected.png: Removed.
        * platform/chromium-win/fast/events/event-sender-mouse-moved-expected.png: Removed.
        * platform/chromium-win/fast/events/event-sender-mouse-moved-expected.txt: Removed.
        * platform/gtk/fast/events/event-sender-mouse-moved-expected.txt: Removed.
        * platform/mac-leopard/fast/events/event-sender-mouse-moved-expected.png: Removed.
        * platform/mac/fast/events/event-sender-mouse-moved-expected.png: Removed.
        * platform/mac/fast/events/event-sender-mouse-moved-expected.txt: Removed.
        * platform/qt/fast/events/event-sender-mouse-moved-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=59405
barraclough@apple.com [Tue, 26 Apr 2011 01:40:25 +0000 (01:40 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=59405
DFG JIT - add type speculation for integer & array types, for vars & args.

Reviewed by Geoff Garen.

If a var or argument is used as the base for a GetByVal or PutByVal access
we are speculating that it is of type Array (we only generate code on the
speculative path to perform array accesses). By typing the var or args slot
as Array, and checking on entry to the function (in the case of args), and
each time the local is written to, we can avoid a type check at each point
the array is accessed. This will typically hoist type checks out of loops.

Similarly, any local that is incremented or decremented, or is the input or
output or a bitwise operator, is likely to be an integer. By typing the
local as int32 we can avoid speculation checks on access, and tagging when
writing to the slot. All accesses can become 32bit instead of 64.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::predictArray):
(JSC::DFG::ByteCodeParser::predictInt32):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.h:
(JSC::DFG::PredictionSlot::PredictionSlot):
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::tagFor):
(JSC::DFG::JITCompiler::payloadFor):
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):
* dfg/DFGSpeculativeJIT.h:
* runtime/Executable.cpp:
(JSC::tryDFGCompile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 26 Apr 2011 01:23:23 +0000 (01:23 +0000)]
2011-04-25  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change. Remove tests that are no longer
        failing.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Igor Oliveira <igor.oliveira@openbossa.org>
commit-queue@webkit.org [Tue, 26 Apr 2011 00:31:36 +0000 (00:31 +0000)]
2011-04-25  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Tony Chang.

        Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class
        https://bugs.webkit.org/show_bug.cgi?id=59028

        The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms.
        Moving the code for base class we can reduce the efforts to support DataTransferItems
        element in different platforms.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/DataTransferItem.cpp:
        (WebCore::DataTransferItem::DataTransferItem):
        (WebCore::DataTransferItem::owner):
        (WebCore::DataTransferItem::kind):
        (WebCore::DataTransferItem::type):
        * dom/DataTransferItem.h:
        * dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.
        (WebCore::DataTransferItems::DataTransferItems):
        (WebCore::DataTransferItems::length):
        (WebCore::DataTransferItems::item):
        (WebCore::DataTransferItems::deleteItem):
        (WebCore::DataTransferItems::clear):
        (WebCore::DataTransferItems::add):
        * dom/DataTransferItems.h:
        * platform/chromium/DataTransferItemChromium.cpp:
        (WebCore::DataTransferItem::create):
        (WebCore::DataTransferItemChromium::DataTransferItemChromium):
        (WebCore::DataTransferItemChromium::getAsString):
        (WebCore::DataTransferItemChromium::getAsFile):
        * platform/chromium/DataTransferItemChromium.h:
        * platform/chromium/DataTransferItemsChromium.cpp:
        (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
        * platform/chromium/DataTransferItemsChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Tue, 26 Apr 2011 00:24:54 +0000 (00:24 +0000)]
2011-04-25  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        REGRESSION(75137): directly composited images are double-drawn sometimes
        https://bugs.webkit.org/show_bug.cgi?id=58632

        Depending on the order of operations (layout, creating compositing
        layers and creating simple image layers) a layer can have both image
        content and have m_drawsContent=true. In this case 2 copies of the image
        are drawn in the layer. If the image has alpha, it looks wrong.

        I added an updateDrawsContent() call after setting the image contents
        to make sure it's correct.

        I couldn't create a test case that shows the problem because layerTreeAsText()
        doesn't emit enough info to show this level of detail. I've opened
        https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateImageContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix OwnPtr strict mode violation in MessageQueue.h
levin@chromium.org [Tue, 26 Apr 2011 00:18:00 +0000 (00:18 +0000)]
Fix OwnPtr strict mode violation in MessageQueue.h
https://bugs.webkit.org/show_bug.cgi?id=59400

Reviewed by James Robinson.

* wtf/MessageQueue.h:
(WTF::::waitForMessage):
(WTF::::waitForMessageFilteredWithTimeout):
(WTF::::tryGetMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Kenneth Russell <kbr@google.com>
abarth@webkit.org [Tue, 26 Apr 2011 00:13:01 +0000 (00:13 +0000)]
2011-04-25  Kenneth Russell  <kbr@google.com>

        Reviewed by David Levin.

        Fix OwnPtr strict errors in InlineFlowBox.cpp
        https://bugs.webkit.org/show_bug.cgi?id=59392

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::setLayoutOverflow):
        (WebCore::InlineFlowBox::setVisualOverflow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Kenneth Russell <kbr@google.com>
abarth@webkit.org [Tue, 26 Apr 2011 00:11:09 +0000 (00:11 +0000)]
2011-04-25  Kenneth Russell  <kbr@google.com>

        Reviewed by David Levin.

        Fix OwnPtr strict errors in TransformState.cpp
        https://bugs.webkit.org/show_bug.cgi?id=59380

        * rendering/TransformState.cpp:
        (WebCore::TransformState::applyTransform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 26 Apr 2011 00:07:41 +0000 (00:07 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by James Robinson.

        DOMWindow.cpp should work with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59356

        * page/DOMWindow.cpp:
        (WebCore::PostMessageTimer::fired):
        (WebCore::DOMWindow::postMessageTimerFired):
        * page/DOMWindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Tue, 26 Apr 2011 00:06:17 +0000 (00:06 +0000)]
2011-04-25  Adam Klein  <adamk@chromium.org>

        Reviewed by James Robinson.

        Fix OwnPtr strict errors in some SVG classes.
        https://bugs.webkit.org/show_bug.cgi?id=59395

        * rendering/style/SVGRenderStyleDefs.cpp:
        (WebCore::StyleShadowSVGData::StyleShadowSVGData):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::SVGSVGElement):
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::supplementalTransform):
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::supplementalTransform):
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 26 Apr 2011 00:04:06 +0000 (00:04 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Re-land changes to ValidationMessage.

        * html/ValidationMessage.cpp:
        (WebCore::ValidationMessage::setMessage):
        (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
        (WebCore::ValidationMessage::requestToHideMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 26 Apr 2011 00:00:08 +0000 (00:00 +0000)]
2011-04-25  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.

        Change FAILS_ to DISABLED_ in r84813.

        * tests/TransparencyWinTest.cpp:
        (WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 25 Apr 2011 23:56:49 +0000 (23:56 +0000)]
2011-04-25  Ojan Vafai  <ojan@chromium.org>

        Reviewed by James Robinson.

        fix OwnPtr strict error in FrameView.cpp
        https://bugs.webkit.org/show_bug.cgi?id=59402

        * page/FrameView.cpp:
        (WebCore::FrameView::FrameView):
        (WebCore::FrameView::addWidgetToUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Mon, 25 Apr 2011 23:55:41 +0000 (23:55 +0000)]
2011-04-25  Adam Klein  <adamk@chromium.org>

        Unreviewed, rolling out r84844.
        http://trac.webkit.org/changeset/84844
        https://bugs.webkit.org/show_bug.cgi?id=59395

        Checked in too much.

        * rendering/style/SVGRenderStyleDefs.cpp:
        (WebCore::StyleShadowSVGData::StyleShadowSVGData):
        * svg/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::removePendingResource):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::SVGSVGElement):
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::supplementalTransform):
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::supplementalTransform):
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 23:54:38 +0000 (23:54 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        JavaScriptCore should play nice strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59401

        * dfg/DFGByteCodeParser.cpp:
        (JSC::DFG::ByteCodeParser::parse):
        * heap/Heap.cpp:
        (JSC::TypeCounter::TypeCounter):
        * jit/JITStubs.cpp:
        (JSC::JITThunks::JITThunks):
        * parser/JSParser.cpp:
        (JSC::JSParser::Scope::Scope):
        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::GenerationState::addParenthesesTail):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adrienne Walker <enne@google.com>
enne@google.com [Mon, 25 Apr 2011 23:52:51 +0000 (23:52 +0000)]
2011-04-25  Adrienne Walker  <enne@google.com>

        Reviewed by David Levin.

        Make ActiveDOMCallback play nice with OwnPtr strict mode
        https://bugs.webkit.org/show_bug.cgi?id=59398

        * bindings/generic/ActiveDOMCallback.cpp:
        (WebCore::ActiveDOMCallback::ActiveDOMCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Mon, 25 Apr 2011 23:51:13 +0000 (23:51 +0000)]
2011-04-25  Adam Klein  <adamk@chromium.org>

        Reviewed by James Robinson.

        Fix OwnPtr strict errors in some SVG classes.
        https://bugs.webkit.org/show_bug.cgi?id=59395

        * rendering/style/SVGRenderStyleDefs.cpp:
        (WebCore::StyleShadowSVGData::StyleShadowSVGData):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::SVGSVGElement):
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::supplementalTransform):
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::supplementalTransform):
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 25 Apr 2011 23:45:49 +0000 (23:45 +0000)]
2011-04-25  James Robinson  <jamesr@chromium.org>

        Unreviewed, rolling out r84835.
        http://trac.webkit.org/changeset/84835
        https://bugs.webkit.org/show_bug.cgi?id=59394

        Breaks compile because Deque<OwnPtr> doesn't work

        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::PendingCallbacks::~PendingCallbacks):
        (WebCore::PendingCallbacks::appendStartElementNSCallback):
        (WebCore::PendingCallbacks::appendEndElementNSCallback):
        (WebCore::PendingCallbacks::appendCharactersCallback):
        (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
        (WebCore::PendingCallbacks::appendCDATABlockCallback):
        (WebCore::PendingCallbacks::appendCommentCallback):
        (WebCore::PendingCallbacks::appendInternalSubsetCallback):
        (WebCore::PendingCallbacks::appendErrorCallback):
        (WebCore::XMLDocumentParser::XMLDocumentParser):
        * html/ValidationMessage.cpp:
        (WebCore::ValidationMessage::setMessage):
        (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
        (WebCore::ValidationMessage::requestToHideMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 25 Apr 2011 23:43:16 +0000 (23:43 +0000)]
2011-04-25  James Robinson  <jamesr@chromium.org>

        Reviewed by Sam Weinig.

        Fix OwnPtr strict mode violation in ImageBufferCG
        https://bugs.webkit.org/show_bug.cgi?id=59396

        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::ImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Should be able to inspect Web Inspector in Debug Builds
bweinstein@apple.com [Mon, 25 Apr 2011 23:43:04 +0000 (23:43 +0000)]
WebKit2: Should be able to inspect Web Inspector in Debug Builds
https://bugs.webkit.org/show_bug.cgi?id=59378

Reviewed by Adam Roben.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup): Creates an inspector page group and enables
    developer extras in a debug build.
(WebKit::WebInspectorProxy::inspectorPageGroup): Calls createInspectorPageGroup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 25 Apr 2011 23:41:59 +0000 (23:41 +0000)]
2011-04-25  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Roben.

        Leaks Viewer throws "Cannot post cyclic structures" in Safari 5
        https://bugs.webkit.org/show_bug.cgi?id=56090

        Make LeaksViewer work with versions of browsers that don't support message
        passing of cyclic structures.

        * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js:
        (LeaksParser.this._worker.onmessage):
        (LeaksParser):
        (LeaksParser.prototype.addLeaksFile):
        Use LeaksParserImpl directly if we don't support passing cyclic structures.

        * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js: Copied from BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js.
        (LeaksParserImpl):
        (LeaksParserImpl.prototype.addLeaksFile):
        (LeaksParserImpl.prototype._incorporateLeaks):
        * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
        (onmessage):
        Factor out LeaksParser implementation into LeaksParserImpl.js.

        * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
        (workersSupportCyclicStructures):
        Add function to detect if workers support passing cyclic structures.

        * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
        Add LeaksParserImpl.js include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoConvert a test to dump as text.
mitz@apple.com [Mon, 25 Apr 2011 23:41:46 +0000 (23:41 +0000)]
Convert a test to dump as text.

Reviewed by Sam Weinig.

* fast/dom/jsDevicePixelRatio-expected.txt: Added.
* fast/dom/jsDevicePixelRatio.html:
* platform/chromium-linux/fast/dom/jsDevicePixelRatio-expected.png: Removed.
* platform/chromium-win/fast/dom/jsDevicePixelRatio-expected.png: Removed.
* platform/chromium-win/fast/dom/jsDevicePixelRatio-expected.txt: Removed.
* platform/gtk/fast/dom/jsDevicePixelRatio-expected.png: Removed.
* platform/gtk/fast/dom/jsDevicePixelRatio-expected.txt: Removed.
* platform/mac-leopard/fast/dom/jsDevicePixelRatio-expected.png: Removed.
* platform/mac/fast/dom/jsDevicePixelRatio-expected.png: Removed.
* platform/mac/fast/dom/jsDevicePixelRatio-expected.txt: Removed.
* platform/qt/fast/dom/jsDevicePixelRatio-expected.png: Removed.
* platform/qt/fast/dom/jsDevicePixelRatio-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Huang Dongsung <luxtella@company100.net>
commit-queue@webkit.org [Mon, 25 Apr 2011 23:39:06 +0000 (23:39 +0000)]
2011-04-25  Huang Dongsung  <luxtella@company100.net>

        Reviewed by Dirk Schulze.

        [Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware().
        https://bugs.webkit.org/show_bug.cgi?id=59308

        An unused local variable is created and even allocates heap memory.

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::readbackHardwareToSoftware):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoQt build fix: Updated files not used by other ports for rename.
ggaren@apple.com [Mon, 25 Apr 2011 23:37:52 +0000 (23:37 +0000)]
Qt build fix: Updated files not used by other ports for rename.

* bindings/js/JSTouchCustom.cpp:
(WebCore::toJSNewlyCreated):
* bindings/js/JSTouchListCustom.cpp:
(WebCore::toJSNewlyCreated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adrienne Walker <enne@google.com>
enne@google.com [Mon, 25 Apr 2011 23:36:53 +0000 (23:36 +0000)]
2011-04-25  Adrienne Walker  <enne@google.com>

        Reviewed by David Levin.

        WebCore/css/CSS* files should play nice with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59382

        * css/CSSFontFaceSource.cpp:
        (WebCore::CSSFontFaceSource::getFontData):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::addProperty):
        (WebCore::CSSParser::parseValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 23:35:45 +0000 (23:35 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by James Robinson.

        ValidationMessage and XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59394

        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::PendingCallbacks::PendingCallbacks):
        (WebCore::PendingCallbacks::appendStartElementNSCallback):
        (WebCore::PendingCallbacks::appendEndElementNSCallback):
        (WebCore::PendingCallbacks::appendCharactersCallback):
        (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
        (WebCore::PendingCallbacks::appendCDATABlockCallback):
        (WebCore::PendingCallbacks::appendCommentCallback):
        (WebCore::PendingCallbacks::appendInternalSubsetCallback):
        (WebCore::PendingCallbacks::appendErrorCallback):
        (WebCore::XMLDocumentParser::XMLDocumentParser):
        * html/ValidationMessage.cpp:
        (WebCore::ValidationMessage::setMessage):
        (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
        (WebCore::ValidationMessage::requestToHideMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 25 Apr 2011 23:35:18 +0000 (23:35 +0000)]
2011-04-25  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK rebaseline and skip a couple of failing tests.

        * platform/gtk/Skipped: skip
        http/tests/security/mixedContent/insecure-css-in-main-frame.html
        and editing/text-iterator/findString.html
        * platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 25 Apr 2011 23:30:05 +0000 (23:30 +0000)]
2011-04-25  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        Fix OwnPtr strictness issues in WebCore/inspector/
        https://bugs.webkit.org/show_bug.cgi?id=59387

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheet::ensureSourceData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoved XPathNamespace because it was unused
ggaren@apple.com [Mon, 25 Apr 2011 23:25:27 +0000 (23:25 +0000)]
Removed XPathNamespace because it was unused
https://bugs.webkit.org/show_bug.cgi?id=59381

Reviewed by Beth Dakin.

This allows us to make Node::ownerDocument() non-virtual, though it has
the unhappy side-effect of rebuilding the world.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj: Bye bye dead code.

* dom/Node.h: Hello fast code!

* xml/XPathNamespace.cpp: Removed.
* xml/XPathNamespace.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove text-only results of a test that was switched to dump as text in r72166
mitz@apple.com [Mon, 25 Apr 2011 23:25:09 +0000 (23:25 +0000)]
Move text-only results of a test that was switched to dump as text in r72166
alongside the test, and remove old expected pixel results.

* fast/dom/setPrimitiveValue-expected.txt: Added.
* platform/chromium-linux/fast/dom/setPrimitiveValue-expected.png: Removed.
* platform/chromium-win/fast/dom/setPrimitiveValue-expected.png: Removed.
* platform/gtk/fast/dom/setPrimitiveValue-expected.txt: Removed.
* platform/mac-leopard/fast/dom/setPrimitiveValue-expected.png: Removed.
* platform/mac/fast/dom/setPrimitiveValue-expected.png: Removed.
* platform/mac/fast/dom/setPrimitiveValue-expected.txt: Removed.
* platform/qt/fast/dom/setPrimitiveValue-expected.png: Removed.
* platform/qt/fast/dom/setPrimitiveValue-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 23:24:57 +0000 (23:24 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        HistoryItemMac should play nice with OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59388

        * history/mac/HistoryItemMac.mm:
        (WebCore::HistoryItem::setTransientProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix strict OwnPtrs in ContextMenuController.cpp
levin@chromium.org [Mon, 25 Apr 2011 23:20:57 +0000 (23:20 +0000)]
Fix strict OwnPtrs in ContextMenuController.cpp
https://bugs.webkit.org/show_bug.cgi?id=59375

Reviewed by Kenneth Russell.

* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::createContextMenu):
(WebCore::separatorItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 23:19:50 +0000 (23:19 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        CheckedRadioButton should play nice with strict OwnPtr
        https://bugs.webkit.org/show_bug.cgi?id=59386

        * dom/CheckedRadioButtons.cpp:
        (WebCore::CheckedRadioButtons::addButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 23:17:04 +0000 (23:17 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Resource*.cpp should play nice with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59383

        * bridge/runtime_method.cpp:
        (JSC::RuntimeMethod::RuntimeMethod):
        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::ResourceHandle):
        * platform/network/ResourceResponseBase.cpp:
        (WebCore::ResourceResponseBase::adopt):
        (WebCore::ResourceResponseBase::copyData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Mon, 25 Apr 2011 23:15:47 +0000 (23:15 +0000)]
2011-04-25  Jeff Miller  <jeffm@apple.com>

        Reviewed by Timothy Hatcher.

        Treat strings defined with UI_STRING_LOCALIZE_LATER_KEY() as debugging strings in extract-localizable-strings
        https://bugs.webkit.org/show_bug.cgi?id=59373

        * Scripts/extract-localizable-strings: Add UI_STRING_LOCALIZE_LATER_KEY() to isDebugMacro var.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
mrowe@apple.com [Mon, 25 Apr 2011 23:14:34 +0000 (23:14 +0000)]
Build fix.

* wtf/ListHashSet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Web Inspector's style sidebar fails to display when inspecting element
bweinstein@apple.com [Mon, 25 Apr 2011 23:09:56 +0000 (23:09 +0000)]
WebKit2: Web Inspector's style sidebar fails to display when inspecting element
https://bugs.webkit.org/show_bug.cgi?id=58071
<rdar://problem/9243093>

Reviewed by Timothy Hatcher.

When creating our WebKit2 inspector views, we were creating them on both Mac and Windows
with the empty rect for their initial size. Before we sized them correctly, the inspector
was calling window.innerWidth on them, which returned 0, making the sidebar take up 0 pixels.

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create the window with the initial window width
    and height.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoConvert fast/events/label-focus.html to a text only test
adele@apple.com [Mon, 25 Apr 2011 23:09:14 +0000 (23:09 +0000)]
Convert fast/events/label-focus.html to a text only test
https://bugs.webkit.org/show_bug.cgi?id=59364

Reviewed by Adam Roben.

* fast/events/label-focus-expected.txt: Copied from LayoutTests/platform/mac/fast/events/label-focus-expected.txt.
* fast/events/label-focus.html:
* platform/chromium-linux/fast/events/label-focus-expected.png: Removed.
* platform/chromium-win/fast/events/label-focus-expected.png: Removed.
* platform/chromium-win/fast/events/label-focus-expected.txt: Removed.
* platform/gtk/fast/events/label-focus-expected.png: Removed.
* platform/gtk/fast/events/label-focus-expected.txt: Removed.
* platform/mac-leopard/fast/events/label-focus-expected.png: Removed.
* platform/mac/fast/events/label-focus-expected.png: Removed.
* platform/mac/fast/events/label-focus-expected.txt: Removed.
* platform/qt/fast/events/label-focus-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 23:08:40 +0000 (23:08 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Page*.cpp and objc_runtime.mm should play nice with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59374

        * bridge/objc/objc_runtime.mm:
        (JSC::Bindings::callObjCFallbackObject):
        * page/Page.cpp:
        (WebCore::Page::Page):
        (WebCore::Page::initGroup):
        * page/PageGroup.cpp:
        (WebCore::PageGroup::addUserScriptToWorld):
        (WebCore::PageGroup::addUserStyleSheetToWorld):
        * page/mac/PageMac.cpp:
        (WebCore::Page::addSchedulePair):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 59370 - DFG JIT - fix leak of BlocksBlocks
barraclough@apple.com [Mon, 25 Apr 2011 23:06:10 +0000 (23:06 +0000)]
Bug 59370 - DFG JIT - fix leak of BlocksBlocks
(put the blocks immediately into an OwnPtr).

Reviewed by Oliver Hunt.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix: This time for sure!
ggaren@apple.com [Mon, 25 Apr 2011 23:02:45 +0000 (23:02 +0000)]
Build fix: This time for sure!

* dom/make_names.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix: Let's edit the script instead of the autogenrated file. That
ggaren@apple.com [Mon, 25 Apr 2011 22:58:01 +0000 (22:58 +0000)]
Build fix: Let's edit the script instead of the autogenrated file. That
way, our change will stand the test of time.

* dom/make_names.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChanged a test to dump as text.
mitz@apple.com [Mon, 25 Apr 2011 22:57:35 +0000 (22:57 +0000)]
Changed a test to dump as text.

Reviewed by Sam Weinig.

* fast/css/affected-by-hover-after-style-change.html:
* platform/gtk/fast/css/affected-by-hover-after-style-change-expected.png: Removed.
* platform/gtk/fast/css/affected-by-hover-after-style-change-expected.txt: Removed.
* platform/mac/fast/css/affected-by-hover-after-style-change-expected.png: Removed.
* platform/mac/fast/css/affected-by-hover-after-style-change-expected.txt: Removed.
* platform/qt/fast/css/affected-by-hover-after-style-change-expected.png: Removed.
* platform/qt/fast/css/affected-by-hover-after-style-change-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 25 Apr 2011 22:56:14 +0000 (22:56 +0000)]
2011-04-25  Daniel Bates  <dbates@webkit.org>

        Reviewed by Sam Weinig.

        Convert LayoutTests/fast/events/onloadFrameCrash.html from pixel test to text-based test
        https://bugs.webkit.org/show_bug.cgi?id=59362

        * fast/events/onloadFrameCrash-expected.txt: Added.
        * fast/events/onloadFrameCrash.html: Modified to dump as text.
        * platform/gtk/fast/events/onloadFrameCrash-expected.png: Removed.
        * platform/gtk/fast/events/onloadFrameCrash-expected.txt: Removed.
        * platform/mac/fast/events/onloadFrameCrash-expected.png: Removed.
        * platform/mac/fast/events/onloadFrameCrash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 22:56:00 +0000 (22:56 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Fix strict OwnPtrs in HTMLMediaElement and HTTPHeaderMap
        https://bugs.webkit.org/show_bug.cgi?id=59368

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement):
        * platform/network/HTTPHeaderMap.cpp:
        (WebCore::HTTPHeaderMap::copyData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 25 Apr 2011 22:54:02 +0000 (22:54 +0000)]
2011-04-25  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        Fix strict OwnPtr violations in Render*.cpp
        https://bugs.webkit.org/show_bug.cgi?id=59361

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::RenderBlock):
        (WebCore::RenderBlock::finishDelayUpdateScrollInfo):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::addLayoutOverflow):
        (WebCore::RenderBox::addVisualOverflow):
        * rendering/RenderButton.cpp:
        (WebCore::RenderButton::styleDidChange):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateTransform):
        (WebCore::RenderLayer::paintChildLayerIntoColumns):
        (WebCore::RenderLayer::hitTestChildLayerColumns):
        (WebCore::RenderLayer::ensureBacking):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::styleDidChange):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::compositor):
        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::addCachedPseudoStyle):
        (WebCore::RenderStyle::accessCounterDirectives):
        (WebCore::RenderStyle::accessAnimations):
        (WebCore::RenderStyle::accessTransitions):
        * rendering/svg/RenderSVGResourceFilter.cpp:
        (WebCore::RenderSVGResourceFilter::applyResource):
        * rendering/svg/SVGResources.cpp:
        (WebCore::SVGResources::SVGResources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 22:48:31 +0000 (22:48 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Attempt to fix the compile.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::loadWithNextMediaEngine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 25 Apr 2011 22:47:57 +0000 (22:47 +0000)]
2011-04-25  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by James Robinson.

        Suppress test failure in Chromium webkit_unit_tests.
        https://bugs.webkit.org/show_bug.cgi?id=59358

        Looks like this started failing after
        http://trac.webkit.org/changeset/84631.

        * tests/TransparencyWinTest.cpp:
        (WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMerged CREATE_DOM_NODE_WRAPPER and CREATE_DOM_OBJECT_WRAPPER into
ggaren@apple.com [Mon, 25 Apr 2011 22:47:32 +0000 (22:47 +0000)]
Merged CREATE_DOM_NODE_WRAPPER and CREATE_DOM_OBJECT_WRAPPER into
CREATE_DOM_WRAPPER because there's no meaningful difference between
them anymore.

Rubber-stamped by Beth Dakin.

* bindings/js/JSCDATASectionCustom.cpp:
(WebCore::toJSNewlyCreated):
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS):
* bindings/js/JSElementCustom.cpp:
(WebCore::toJSNewlyCreated):
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS):
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
* bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
* bindings/js/JSSVGPathSegCustom.cpp:
(WebCore::toJS):
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::toJS):
* bindings/js/JSTextCustom.cpp:
(WebCore::toJSNewlyCreated):
* bindings/js/JSWebKitCSSMatrixCustom.cpp:
(WebCore::JSWebKitCSSMatrixConstructor::constructJSWebKitCSSMatrix):
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocketConstructor::constructJSWebSocket):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequestConstructor::constructJSXMLHttpRequest):
* bindings/js/JSXSLTProcessorCustom.cpp:
(WebCore::JSXSLTProcessorConstructor::constructJSXSLTProcessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 22:45:59 +0000 (22:45 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by James Robinson.

        HTMLDocumentParser should play nice with OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59363

        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::pumpTokenizer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 22:41:34 +0000 (22:41 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by James Robinson.

        Frame.cpp should work with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59360

        * page/Frame.cpp:
        (WebCore::createRegExpForLabels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChanged a test to dump as text.
mitz@apple.com [Mon, 25 Apr 2011 22:39:45 +0000 (22:39 +0000)]
Changed a test to dump as text.

Reviewed by Adam Roben.

* fast/css/zoom-property-parsing-expected.txt: Added.
* fast/css/zoom-property-parsing.html:
* platform/chromium-linux/fast/css/zoom-property-parsing-expected.png: Removed.
* platform/chromium-win/fast/css/zoom-property-parsing-expected.png: Removed.
* platform/chromium-win/fast/css/zoom-property-parsing-expected.txt: Removed.
* platform/gtk/fast/css/zoom-property-parsing-expected.png: Removed.
* platform/gtk/fast/css/zoom-property-parsing-expected.txt: Removed.
* platform/mac-leopard/fast/css/zoom-property-parsing-expected.png: Removed.
* platform/mac/fast/css/zoom-property-parsing-expected.png: Removed.
* platform/mac/fast/css/zoom-property-parsing-expected.txt: Removed.
* platform/qt/fast/css/zoom-property-parsing-expected.png: Removed.
* platform/qt/fast/css/zoom-property-parsing-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 22:38:14 +0000 (22:38 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Fix strict OwnPtr in Element.cpp
        https://bugs.webkit.org/show_bug.cgi?id=59357

        * dom/NodeRareData.h:
        (WebCore::NodeRareData::ensureEventTargetData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 25 Apr 2011 22:32:35 +0000 (22:32 +0000)]
2011-04-25  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        Missed the Chromium Mac baseline in the previous change.

        * platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 22:28:32 +0000 (22:28 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Fix strict OwnPtr issues in Media*.cpp
        https://bugs.webkit.org/show_bug.cgi?id=59354

        There's still a tricky case in MediaPlayer.cpp, but we'll worry about
        that later.

        * css/MediaQueryMatcher.cpp:
        (WebCore::MediaQueryMatcher::addListener):
        * dom/Document.cpp:
        * platform/graphics/MediaPlayer.cpp:
        (WebCore::createNullMediaPlayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 25 Apr 2011 22:22:36 +0000 (22:22 +0000)]
2011-04-25  James Robinson  <jamesr@chromium.org>

        Reviewed by David Levin.

        Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor
        https://bugs.webkit.org/show_bug.cgi?id=59353

        * wtf/ListHashSet.h:
        (WTF::::ListHashSet):
2011-04-25  James Robinson  <jamesr@chromium.org>

        Reviewed by David Levin.

        Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor
        https://bugs.webkit.org/show_bug.cgi?id=59353

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::RenderLayerCompositor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix PassOwnPtr issues in Structure and JSGlobalData.cpp
levin@chromium.org [Mon, 25 Apr 2011 21:48:58 +0000 (21:48 +0000)]
Fix PassOwnPtr issues in Structure and JSGlobalData.cpp
https://bugs.webkit.org/show_bug.cgi?id=59347

Reviewed by Adam Barth.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/Structure.cpp:
(JSC::Structure::copyPropertyTable):
(JSC::Structure::createPropertyMap):
* runtime/Structure.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 25 Apr 2011 21:48:34 +0000 (21:48 +0000)]
2011-04-25  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        * platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 21:48:05 +0000 (21:48 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by James Robinson.

        Worker*.cpp should work with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59346

        * inspector/WorkerInspectorController.cpp:
        (WebCore::WorkerInspectorController::WorkerInspectorController):
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::WorkerContext):
        * workers/WorkerRunLoop.cpp:
        (WebCore::WorkerRunLoop::WorkerRunLoop):
        * workers/WorkerScriptLoader.cpp:
        (WebCore::WorkerScriptLoader::createResourceRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 25 Apr 2011 21:21:29 +0000 (21:21 +0000)]
2011-04-25  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        Remove bad use of OwnPtr::set() in IconDatabase.cpp
        https://bugs.webkit.org/show_bug.cgi?id=59344

        Needed for strict OwnPtr compliance.

        * loader/icon/IconDatabase.cpp:
        (WebCore::readySQLiteStatement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 25 Apr 2011 21:21:28 +0000 (21:21 +0000)]
2011-04-25  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make ClassInfo required when creating a Structure
        https://bugs.webkit.org/show_bug.cgi?id=59340

        Add ClassInfo to all those types which currently don't
        have it, and add an assertion to Structure::create to
        ensure that the provided classInfo is not null.

        * runtime/Executable.h:
        (JSC::EvalExecutable::createStructure):
        (JSC::ProgramExecutable::createStructure):
        (JSC::FunctionExecutable::createStructure):
        * runtime/GetterSetter.cpp:
        * runtime/GetterSetter.h:
        (JSC::GetterSetter::createStructure):
        * runtime/JSAPIValueWrapper.cpp:
        * runtime/JSAPIValueWrapper.h:
        (JSC::JSAPIValueWrapper::createStructure):
        * runtime/JSCell.cpp:
        * runtime/JSCell.h:
        * runtime/JSString.cpp:
        * runtime/JSString.h:
        (JSC::RopeBuilder::createStructure):
        * runtime/Structure.h:
        (JSC::Structure::create):
        (JSC::JSCell::createDummyStructure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPropertyMapHashTable.h should use adoptPtr instead of implicit conversions to PassRefPtr.
levin@chromium.org [Mon, 25 Apr 2011 21:16:04 +0000 (21:16 +0000)]
PropertyMapHashTable.h should use adoptPtr instead of implicit conversions to PassRefPtr.
https://bugs.webkit.org/show_bug.cgi?id=59342

Reviewed by Adam Barth.

This patch is to prepare for the strict OwnPtr hack-a-thon.

* runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::copy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 20:57:09 +0000 (20:57 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        ImageBuffer.h should work with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59341

        This patch is to prepare for the strict OwnPtr hack-a-thon.

        * platform/graphics/ImageBuffer.h:
        (WebCore::ImageBuffer::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Mon, 25 Apr 2011 20:50:56 +0000 (20:50 +0000)]
2011-04-25  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Brian Weinstein.

        WebCore build on Windows should include windows.h in its precompiled header to speed builds
        https://bugs.webkit.org/show_bug.cgi?id=59339

        windows.h is included by several of the underlying wtf headers, including Atomics.h and
        ThreadingPrimitives.h anyway, so include it in the WebCorePrefix.h to speed up compilation.

        On my 8 core Mac Pro, this reduces a clean rebuild of debug WebCore from 8 minutes to 7 minutes
        (a 12% speedup).

        * WebCorePrefix.h: Include windows.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Thouraya ANDOLSI <thouraya.andolsi@st.com>
commit-queue@webkit.org [Mon, 25 Apr 2011 20:19:11 +0000 (20:19 +0000)]
2011-04-25  Thouraya ANDOLSI  <thouraya.andolsi@st.com>

        Reviewed by Gavin Barraclough.

        Rationalize MacroAssembler branch methods
        https://bugs.webkit.org/show_bug.cgi?id=58950

        split out the 'Condition' enum into 'RelationalCondition' and 'ResultCondition'
        and apply related changes (only for SH4 platforms).

        * assembler/MacroAssemblerSH4.cpp:
        * assembler/MacroAssemblerSH4.h:
        (JSC::MacroAssemblerSH4::compare32):
        (JSC::MacroAssemblerSH4::branch32WithUnalignedHalfWords):
        (JSC::MacroAssemblerSH4::branchDouble):
        (JSC::MacroAssemblerSH4::branch32):
        (JSC::MacroAssemblerSH4::branchTest8):
        (JSC::MacroAssemblerSH4::branch8):
        (JSC::MacroAssemblerSH4::branchTruncateDoubleToInt32):
        (JSC::MacroAssemblerSH4::test8):
        (JSC::MacroAssemblerSH4::branch16):
        (JSC::MacroAssemblerSH4::branchTest32):
        (JSC::MacroAssemblerSH4::branchAdd32):
        (JSC::MacroAssemblerSH4::branchMul32):
        (JSC::MacroAssemblerSH4::branchSub32):
        (JSC::MacroAssemblerSH4::branchOr32):
        (JSC::MacroAssemblerSH4::branchConvertDoubleToInt32):
        (JSC::MacroAssemblerSH4::branchPtrWithPatch):
        (JSC::MacroAssemblerSH4::SH4Condition):
        * assembler/SH4Assembler.h:
        (JSC::SH4Assembler::cmpEqImmR0):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 20:16:06 +0000 (20:16 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        PropertyMapHashTable should work with strict OwnPtr
        https://bugs.webkit.org/show_bug.cgi?id=59337

        This patch is in preparation for the strict OwnPtr hack-a-thon.

        * runtime/PropertyMapHashTable.h:
        (JSC::PropertyTable::PropertyTable):
        (JSC::PropertyTable::addDeletedOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84795 268f45cc-cd09-0410-ab3c-d52691b4dbfc