13 years ago2009-01-27 Paul Godavari <paul@chromium.org>
dglazkov@chromium.org [Tue, 27 Jan 2009 17:30:52 +0000 (17:30 +0000)]
2009-01-27  Paul Godavari  <paul@chromium.org>

        Reviewed by Eric Seidel.

        Explicitly send the MIME type from an image dragged from a web
        page to the desktop, to Chromium so that it can properly generate
        a file name.

        * platform/chromium/ChromiumDataObject.cpp:
        * platform/chromium/ChromiumDataObject.h:
        * platform/chromium/ClipboardChromium.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
dglazkov@chromium.org [Tue, 27 Jan 2009 17:24:04 +0000 (17:24 +0000)]

2009-01-27  Mads Ager  <ager@chromium.org>

        Reviewed by Darin Adler.

        Follow Firefox in throwing exceptions when using selection
        functions on HTMLInputElements that cannot have selection.

        This requires custom setSelectionRange, setSelectionStart and
        setSelectionEnd implementations, but it gets rid of the custom

        * bindings/js/JSHTMLInputElementCustom.cpp:
        * html/HTMLInputElement.idl:


2009-01-27  Mads Ager  <ager@chromium.org>

        Reviewed by Darin Adler.

        Update test of selection functions on HTMLInputElements to expect
        the selection functions to throw exceptions when used on buttons.
        This is consistent with the Firefox behavior.

        * fast/forms/selection-functions-expected.txt:
        * fast/forms/selection-functions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-27 Evan Stade <estade@chromium.org>
dglazkov@chromium.org [Tue, 27 Jan 2009 17:13:59 +0000 (17:13 +0000)]
2009-01-27  Evan Stade  <estade@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Make spreadMethod a member of Gradient rather than GraphicsContext.
        Implement spreadMethod for Skia.

        * platform/graphics/Gradient.cpp:
        * platform/graphics/Gradient.h:
        * platform/graphics/GraphicsContext.cpp:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/GraphicsContextPrivate.h:
        * platform/graphics/GraphicsTypes.h:
        * platform/graphics/cairo/GradientCairo.cpp:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        * platform/graphics/qt/GradientQt.cpp:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        * platform/graphics/skia/GradientSkia.cpp:
        * svg/SVGLinearGradientElement.cpp:
        * svg/SVGRadialGradientElement.cpp:
        * svg/graphics/SVGPaintServerGradient.cpp:
        * svg/graphics/SVGPaintServerGradient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-27 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Tue, 27 Jan 2009 16:03:51 +0000 (16:03 +0000)]
2009-01-27  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Simon Hausmann.


        [Qt] Map function keys F1 to F24.

        * platform/qt/PlatformKeyboardEventQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-27 Ariya Hidayat <ariya.hidayat@trolltech.com>
ariya@webkit.org [Tue, 27 Jan 2009 15:26:52 +0000 (15:26 +0000)]
2009-01-27  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon Hausmann.


        [Qt] If QPainter fails to start on a QPrinter instance, do not
        continue printing.

        * Api/qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson@apple.com [Tue, 27 Jan 2009 08:05:59 +0000 (08:05 +0000)]

2009-01-27  Brady Eidson  <beidson@apple.com>

        Reviewed by Dan Bernstein

        Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage

        * WebCore.base.exp:
        * history/CachedPage.cpp:
        * history/CachedPage.h:

        * loader/EmptyClients.h:

        * loader/FrameLoader.cpp:
        * loader/FrameLoaderClient.h:


2009-01-27  Brady Eidson  <beidson@apple.com>

        Reviewed by Dan Bernstein

        Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        * WebCoreSupport/FrameLoaderClientGtk.h:


2009-01-27  Brady Eidson  <beidson@apple.com>

        Reviewed by Dan Bernstein

        Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage

        * History/WebHistoryItem.mm:

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        * WebKit.order:


2009-01-27  Brady Eidson  <beidson@apple.com>

        Reviewed by Dan Bernstein

        Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        * WebCoreSupport/FrameLoaderClientQt.h:


2009-01-27  Brady Eidson  <beidson@apple.com>

        Reviewed by Dan Bernstein

        Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        * WebCoreSupport/WebFrameLoaderClient.h:

        * WebFrame.cpp:
        * WebFrame.h:


2009-01-27  Brady Eidson  <beidson@apple.com>

        Reviewed by Dan Bernstein

        Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage

        * WebKitSupport/FrameLoaderClientWx.cpp:
        * WebKitSupport/FrameLoaderClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 27 Jan 2009 06:58:13 +0000 (06:58 +0000)]
2009-01-26  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt


        Add variants of all the methods that compute dirty rects for repainting
        with versions that compute those rects relative to some container
        RenderBox that acts as a painting root.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 27 Jan 2009 04:40:36 +0000 (04:40 +0000)]
2009-01-26  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by David Hyatt

        Back out r40285, because it was checked in with no bug number, no
        testcase, is rendering change that did not get thorough review,
        and broke the Mac build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 27 Jan 2009 03:49:43 +0000 (03:49 +0000)]
2009-01-26  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        -Make the recently added back/forward cache logging much better by actually
         walking the entire frame tree and indenting the resulting output.
        -Fix a null-termination bug in HistoryItem tree logging

        * history/HistoryItem.cpp:

        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAllow option of hit testing frame content without clipping to the visible
treat@webkit.org [Tue, 27 Jan 2009 03:06:52 +0000 (03:06 +0000)]
Allow option of hit testing frame content without clipping to the visible

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix misspelling of "lowercase" in font-face-locally-installed.html
ddkilzer@apple.com [Tue, 27 Jan 2009 02:44:06 +0000 (02:44 +0000)]
    Fix misspelling of "lowercase" in font-face-locally-installed.html

        Reviewed by Dan Bernstein.

        * fast/css/font-face-locally-installed.html: Updated.
        * platform/mac/fast/css/font-face-locally-installed-expected.checksum: Updated.
        * platform/mac/fast/css/font-face-locally-installed-expected.png: Updated.
        * platform/mac/fast/css/font-face-locally-installed-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSam did _not_ review this
andersca@apple.com [Tue, 27 Jan 2009 01:59:06 +0000 (01:59 +0000)]
Sam did _not_ review this

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Adele Peterson <adele@apple.com>
adele@apple.com [Tue, 27 Jan 2009 01:57:11 +0000 (01:57 +0000)]
2009-01-26  Adele Peterson  <adele@apple.com>

        Build fix.

        * debugger/Debugger.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 27 Jan 2009 01:56:58 +0000 (01:56 +0000)]
2009-01-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add the ability for plug-ins to make WebKit operate in "modal mode"

        * Plugins/Hosted/NetscapePluginHostProxy.h:
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        If the plug-in crashes while we're modal, make sure to leave the modal mode.

        * Plugins/Hosted/WebKitPluginClient.defs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Tue, 27 Jan 2009 01:33:03 +0000 (01:33 +0000)]
2009-01-26  John Sullivan  <sullivan@apple.com>

        fixed <rdar://problem/6530053> REGRESSION (Leopard): Shift-tab in http authentication window gets
        stuck in the Name field rather than cycling around

        Reviewed by Dan Bernstein

        * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
        * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
        The two static text fields and the last button all had their "next key view" outlets set to the
        name field, which caused shift-tab from the name field to do the wrong thing. Fixed by making each
        selectable view have exactly one "next key view" set to it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Tue, 27 Jan 2009 01:08:53 +0000 (01:08 +0000)]
2009-01-26  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Darin Adler.

        Fixes for eq null & neq null, on 64-bit JIT.

        This patch degrades 64-bit JIT performance on some benchmarks,
        due to the whole not-being-incorrect thing.

        * jit/JIT.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Tue, 27 Jan 2009 00:45:36 +0000 (00:45 +0000)]

2009-01-26  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=18141
        Acid3 tests 77 and 78 fail on reload due to SVG font race

        Match Opera's behavior of loading SVGFonts as soon as <font-face-uri>
        tag is inserted into the document and not at the first use of the font
        as is done for CSS web fonts.

        This fixes a race condition noticeable by some in the Acid3 test that
        happened because the onload event handler for an iframe containing a
        <font-face-uri> with an external reference was not delayed by the pending
        load of the font.

        Test: http/tests/misc/SVGFont-delayed-load.html

        * svg/SVGFontFaceUriElement.cpp:
        (WebCore::SVGFontFaceUriElement::parseMappedAttribute): Call loadFont if
        the href attribute changes.
        (WebCore::SVGFontFaceUriElement::insertedIntoDocument): Call loadFont.
        (WebCore::SVGFontFaceUriElement::loadFont): Force a load of the
        font specified in href attribute.
        * svg/SVGFontFaceUriElement.h:


2009-01-26  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Test for https://bugs.webkit.org/show_bug.cgi?id=18141
        Acid3 tests 77 and 78 fail on reload due to SVG font race

        * http/tests/misc/SVGFont-delayed-load-expected.txt: Added.
        * http/tests/misc/SVGFont-delayed-load.html: Added.
        * http/tests/misc/resources/SVGFont-delayed-loader.svg: Added.
        * svg/custom/acid3-test-77.html:
        * svg/custom/resources/Acid3Font-loader.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 27 Jan 2009 00:38:23 +0000 (00:38 +0000)]
2009-01-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add the ability for a plug-in to show or hide the menu bar.

        * Plugins/Hosted/NetscapePluginHostProxy.h:
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        * Plugins/Hosted/WebKitPluginClient.defs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Pierre-Olivier Latour <pol@apple.com>
pol@apple.com [Tue, 27 Jan 2009 00:09:14 +0000 (00:09 +0000)]
2009-01-26  Pierre-Olivier Latour  <pol@apple.com>

        Updated the reference images for the video tests that rely on the H264 test movie,
        as QuickTime 7.6 apparently slightly changed the results from the 7.5.5 version.

        * platform/mac/media/video-aspect-ratio-expected.checksum:
        * platform/mac/media/video-aspect-ratio-expected.png:
        * platform/mac/media/video-controls-rendering-expected.checksum:
        * platform/mac/media/video-controls-rendering-expected.png:
        * platform/mac/media/video-display-toggle-expected.checksum:
        * platform/mac/media/video-display-toggle-expected.png:
        * platform/mac/media/video-layer-crash-expected.checksum:
        * platform/mac/media/video-layer-crash-expected.png:
        * platform/mac/media/video-transformed-expected.checksum:
        * platform/mac/media/video-transformed-expected.png:
        * platform/mac/media/video-zoom-expected.checksum:
        * platform/mac/media/video-zoom-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Change Web Archive serialization back to the binary property list format.
timothy@apple.com [Tue, 27 Jan 2009 00:00:26 +0000 (00:00 +0000)]
    Change Web Archive serialization back to the binary property list format.

        <rdar://problem/6127865> Web archives saved with Safari 4 cannot be read by Safari 3

        Reviewed by Brady Eidson.

        * loader/archive/cf/LegacyWebArchive.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 26 Jan 2009 23:57:55 +0000 (23:57 +0000)]
2009-01-26  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Gavin Barraclough.

        Bug 23552: Dashcode evaluator no longer works after making ExecStates actual call frames

        Dashcode will crash when using the evaluator because it saves a global call
        frame, even after global code has finished executing, and then uses this as
        a launching pad to execute new JS in the evaluator. The fix is to detect
        when Dashcode is attempting to do this and execute code from a global call
        frame instead.


        * JavaScriptCore.exp:
        * debugger/Debugger.cpp:
        (JSC::evaluateInGlobalCallFrame): Added so that WebScriptCallFrame can
        evaluate JS starting from a global call frame.
        * debugger/Debugger.h:


        * ForwardingHeaders/runtime/Protect.h: Added.
        * WebView/WebScriptDebugDelegate.mm:
        (-[WebScriptCallFrame _initWithGlobalObject:debugger:caller:debuggerCallFrame:]):
        Added debugger, a WebScriptDebugger* argument.
        (-[WebScriptCallFrame evaluateWebScript:]): Detect when Dashcode is using
        a stale WebScriptCallFrame to execute new JS and evaluate it starting from
        the global object's global call frame instead.
        * WebView/WebScriptDebugger.h:
        (WebScriptDebugger::globalObject): Added.
        (WebScriptDebugger::globalCallFrame): Added.
        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::WebScriptDebugger): Initialize m_globalObject.
        (WebScriptDebugger::initGlobalCallFrame): Created as a clone of callEvent
        so that the global call frame can be saved immediately after being created.
        (WebScriptDebugger::callEvent): Pass 'this' as the debugger argument of
        WebScriptCallFrame's _initWithGlobalObject method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 26 Jan 2009 23:27:23 +0000 (23:27 +0000)]
2009-01-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver Hunt.

        Make WKPCInvoke a simpleroutine.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        * Plugins/Hosted/WebKitPluginClient.defs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 26 Jan 2009 23:16:05 +0000 (23:16 +0000)]
2009-01-26  Anders Carlsson  <andersca@apple.com>

        Fix 64-bit build.

        * WebCore.LP64.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Dmitry Titov <dimich@chromium.org>
dglazkov@chromium.org [Mon, 26 Jan 2009 23:14:41 +0000 (23:14 +0000)]
2009-01-26  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Move DOMTimer from bindings/js to page/.
        This was prepared by moving all JSC dependencies from DOMTimer
        to ScheduledAction earlier, and helps unfork the Chromuim version
        of the DOMTimer.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.scons:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/DOMTimer.cpp: Removed.
        * bindings/js/DOMTimer.h: Removed.
        * page/DOMTimer.cpp: Copied from WebCore/bindings/js/DOMTimer.cpp.
        * page/DOMTimer.h: Copied from WebCore/bindings/js/DOMTimer.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 26 Jan 2009 23:07:30 +0000 (23:07 +0000)]
2009-01-26  David Hyatt  <hyatt@apple.com>

        Eliminate rightmostPosition, lowestPosition and leftmostPosition from RenderFlow.  Move the code into
        RenderBlock's methods.

        Reviewed by Eric Seidel

        * rendering/RenderBlock.cpp:
        * rendering/RenderFlow.cpp:
        * rendering/RenderFlow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Darin Fisher <darin@chromium.org>
darin@chromium.org [Mon, 26 Jan 2009 23:06:23 +0000 (23:06 +0000)]
2009-01-26  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        Upstream changes from jcampan to fix chromium bugs 6692 and 6694.

        * platform/chromium/PopupMenuChromium.cpp:
        * platform/chromium/PopupMenuChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove extraneous WebCore XCode project setting, introduced in previous commit.
dglazkov@chromium.org [Mon, 26 Jan 2009 22:54:16 +0000 (22:54 +0000)]
Remove extraneous WebCore XCode project setting, introduced in previous commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 26 Jan 2009 22:52:13 +0000 (22:52 +0000)]
2009-01-26  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Remove some historical CachedPage time stamp fluff.

        * history/CachedPage.cpp:
        * history/CachedPage.h:

        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 26 Jan 2009 22:45:24 +0000 (22:45 +0000)]
2009-01-26  David Hyatt  <hyatt@apple.com>

        Move absoluteClippedOverflowRect, linesBoundingBox and borderBoundingBox from RenderFlow to RenderInline.

        Reviewed by Eric Seidel

        * rendering/RenderBox.cpp:
        * rendering/RenderFlow.cpp:
        * rendering/RenderFlow.h:
        * rendering/RenderInline.cpp:
        * rendering/RenderInline.h:
        * rendering/RenderLayer.cpp:
        * rendering/RenderTreeAsText.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 26 Jan 2009 22:40:36 +0000 (22:40 +0000)]
2009-01-26  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Implement support for "Immutable" attribute to CodeGeneratorJS.pm, thus
        allowing to explicitly mark methods as immutable (i.e. returning a new
        instance rather than a reference to an existing instance).

        * bindings/js/JSSVGMatrixCustom.cpp: Removed custom methods.
        * bindings/scripts/CodeGeneratorJS.pm: Added check for Immutable
            attribute when generating function call.
        * svg/SVGMatrix.idl: Replaced Custom attribute with Immutable on

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 26 Jan 2009 22:29:19 +0000 (22:29 +0000)]
2009-01-26  David Hyatt  <hyatt@apple.com>

        Eliminate isInlineFlow() now that a RenderBlock can never be an inline flow.  isInlineFlow() is now
        equivalent to isRenderInline(), so all calls to isInlineFlow() have been replaced with isRenderInline().

        Reviewed by Eric Seidel

        * dom/Text.cpp:
        * rendering/InlineFlowBox.cpp:
        * rendering/RenderBlock.cpp:
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        * rendering/RenderBox.h:
        * rendering/RenderContainer.cpp:
        * rendering/RenderFlow.cpp:
        * rendering/RenderFlow.h:
        * rendering/RenderInline.h:
        * rendering/RenderLayer.cpp:
        * rendering/RenderListItem.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderSVGInline.cpp:
        * rendering/RenderSVGText.cpp:
        * rendering/RenderTableRow.cpp:
        * rendering/RenderTableSection.cpp:
        * rendering/RenderText.cpp:
        * rendering/RenderTreeAsText.cpp:
        * rendering/bidi.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 26 Jan 2009 22:27:13 +0000 (22:27 +0000)]
2009-01-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Implement using plug-in objects as constructors, and setting and getting properties from a plug-in object.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        Rename NPObjectInvokeReply to BooleanAndDataReply.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        Fix a cut and paste error.

        Handle NPObjects.

        * Plugins/Hosted/ProxyInstance.h:
        * Plugins/Hosted/ProxyInstance.mm:
        Call the ProxyInstance method.

        Release the NPObject.

        Ask the plug-in host if an instance supports construct.

        Call the plug-in host methods.

        * Plugins/Hosted/WebKitPluginHostTypes.h:
        Rename ObjectValueType to JSObjectValueType, and add NPObjectValueType.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand new layout tests now that display:compact support has been removed.
hyatt@apple.com [Mon, 26 Jan 2009 21:53:43 +0000 (21:53 +0000)]
Land new layout tests now that display:compact support has been removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand new layout tests now that display:compact support has been removed.
hyatt@apple.com [Mon, 26 Jan 2009 21:52:31 +0000 (21:52 +0000)]
Land new layout tests now that display:compact support has been removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand new layout tests now that display:compact support has been removed.
hyatt@apple.com [Mon, 26 Jan 2009 21:51:55 +0000 (21:51 +0000)]
Land new layout tests now that display:compact support has been removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand new layout tests now that display:compact support has been removed.
hyatt@apple.com [Mon, 26 Jan 2009 21:51:35 +0000 (21:51 +0000)]
Land new layout tests now that display:compact support has been removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 26 Jan 2009 21:50:57 +0000 (21:50 +0000)]
2009-01-26  David Hyatt  <hyatt@apple.com>

        Drop support for display:compact.

        (1) display:compact is no longer part of CSS2.1.
        (2) Shipping Safari has completely broken compact support with severely broken rendering
        (all of the compact text just piles on top of the text in the inserted block and on top of itself as well).
        (3) This has been broken in WebKit for years (ever since blocks converted to painting lines directly) without
        anyone even noticing.

        Reviewed by Eric Seidel

        * rendering/InlineFlowBox.cpp:
        * rendering/RenderBlock.cpp:
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        * rendering/RenderBox.h:
        * rendering/RenderFlow.cpp:
        * rendering/RenderObject.h:
        * rendering/bidi.cpp:
        * rendering/bidi.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the build.
mrowe@apple.com [Mon, 26 Jan 2009 21:44:03 +0000 (21:44 +0000)]
Fix the build.

Remove -Wformat=2 from the warning flags as newer versions of GCC emit
warnings about non-literal format strings for uses of our UI_STRING macro.

* Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Pierre-Olivier Latour <pol@apple.com>
pol@apple.com [Mon, 26 Jan 2009 21:42:51 +0000 (21:42 +0000)]
2009-01-26  Pierre-Olivier Latour  <pol@apple.com>

        Tweaked again earlier fix, this time just to print a warning and not abort if
        attempting to generate pixel results and Perian is installed.


        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Adam Langley <agl@google.com>
darin@chromium.org [Mon, 26 Jan 2009 20:55:59 +0000 (20:55 +0000)]
2009-01-26  Adam Langley  <agl@google.com>

        Reviewed by Nikolas Zimmermann.

        gtk2drawing: fix compiler warnings

        g_object_set_data expects a gpointer as the last argument. Cast the
          TRUE/FALSE values to avoid a warning.
        gtk_tree_view_column_new doesn't return a GtkWidget.

        * platform/gtk/gtk2drawing.c:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 26 Jan 2009 20:14:56 +0000 (20:14 +0000)]
2009-01-26  David Hyatt  <hyatt@apple.com>

        Change display:run-in handling so that we no longer reuse RenderBlock as though it is an inline flow.
        Instead we create a new RenderInline, move the RenderBlock's children underneath it, and then set the
        inline as the new element's renderer.

        Reviewed by Dan Bernstein

        * rendering/RenderBlock.cpp:
        * rendering/RenderInline.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoClean up after r40240.
mrowe@apple.com [Mon, 26 Jan 2009 19:43:52 +0000 (19:43 +0000)]
Clean up after r40240.

Rubber-stamped by Sam Weinig.

* WebKit.xcodeproj/project.pbxproj: Reinstate WebKitPluginHost.defs.

* Configurations/Base.xcconfig: Don't dead code strip in debug builds for now as it leads to link errors.
* Plugins/Hosted/HostedNetscapePluginStream.mm: Revert change that is no longer needed now that WebKitPluginHost.defs
is back in the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix an assertion failure when Safari loads an error page
aroben@apple.com [Mon, 26 Jan 2009 18:48:56 +0000 (18:48 +0000)]
    Fix an assertion failure when Safari loads an error page

        Reviewed by Alexey Proskuryakov.

        * WebFrame.cpp:
        (WebFrame::loadData): Use the two-argument version of KURL and
        MarshallingHelpers::BSTRToKURL, for reasons mentioned in r40248.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Mon, 26 Jan 2009 18:46:25 +0000 (18:46 +0000)]
2009-01-26  Christian Dywan  <christian@twotoasts.de>

        Rubber stamped by Holger Freyther.

        * GtkLauncher/main.c:
        (main): Initialize threads, which is required for libSoup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 David Boddie <dboddie@trolltech.com>
hausmann@webkit.org [Mon, 26 Jan 2009 16:46:09 +0000 (16:46 +0000)]
2009-01-26  David Boddie  <dboddie@trolltech.com>

        Reviewed by Simon Hausmann.

        Doc: qdoc fix for a link to a property and added a basic description of the offline caching and storage features from HTML 5.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 26 Jan 2009 16:44:04 +0000 (16:44 +0000)]
2009-01-26  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Add missing method stubs to BackForwardListChromium.

        * history/BackForwardListChromium.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix an assertion on launch in KURL::KURL
aroben@apple.com [Mon, 26 Jan 2009 15:19:05 +0000 (15:19 +0000)]
    Fix an assertion on launch in KURL::KURL

        All URL strings passed in to the WebKit API need to be passed to
        MarshallingHelpers::BSTRToKURL so that they may be properly parsed.

        Reviewed by Alexey Proskuryakov.

        * MarshallingHelpers.cpp:
        (MarshallingHelpers::BSTRToKURL): Changed to use the two-argument
        constructor for KURL so that the strings will be parsed rather than
        assumed to be in the correct encoding/form.

        * WebResource.cpp:
        * WebURLResponse.cpp:
        * WebView.cpp:
        Changed to use MarshallingHelpers::BSTRToKURL instead of trying to do
        the work manually.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-26 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 26 Jan 2009 10:16:38 +0000 (10:16 +0000)]
2009-01-26  Darin Adler  <darin@apple.com>

        Requested by David Hyatt.

        * platform/mac/fast/table/form-with-table-style-expected.checksum: Updated to reflect
        the progression; we now render things we used to fail to render.
        * platform/mac/fast/table/form-with-table-style-expected.png: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-25 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 26 Jan 2009 07:31:14 +0000 (07:31 +0000)]
2009-01-25  Darin Adler  <darin@apple.com>

        Try to fix GTK build.

        * webkit/webkitwebview.cpp: Added include of FloatQuad.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKit:
darin@apple.com [Mon, 26 Jan 2009 07:29:05 +0000 (07:29 +0000)]

2009-01-25  Darin Adler  <darin@apple.com>

        Try to fix full build on Mac Leopard.

        * WebKit.xcodeproj/project.pbxproj: Removed WebKitPluginClient.defs from the WebKit target.
        Maybe this is temporary, but I had to do it to get the full build to succeed.


2009-01-25  Darin Adler  <darin@apple.com>

        * Plugins/Hosted/HostedNetscapePluginStream.mm: Added a missing extern "C".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-25 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 26 Jan 2009 07:26:29 +0000 (07:26 +0000)]
2009-01-25  Darin Adler  <darin@apple.com>

        Try to fix Windows build.

        * WebView.cpp: Added FloatQuad.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-25 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 26 Jan 2009 07:14:59 +0000 (07:14 +0000)]
2009-01-25  Darin Adler  <darin@apple.com>

        Try to fix Tiger buildbot.

        * WebCore.xcodeproj/project.pbxproj: Turn off cast-qual for WebDashboardRegion.m.
        * page/mac/WebDashboardRegion.m:
        (typeName): Added.
        (-[WebDashboardRegion description]): Use typeName.
        (-[WebDashboardRegion isEqual:]): Added comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
ap@webkit.org [Mon, 26 Jan 2009 06:42:30 +0000 (06:42 +0000)]
    Reviewed by Darin Adler.

        Strengthen debug checks in KURL

        Covered (and prompted) by existing tests.

        * platform/KURL.cpp:
        (WebCore::checkEncodedString): Check that the first character of the URL is an allowed
        first scheme character, not just that it isn't a slash.
        (WebCore::KURL::KURL): Assert that parsing didn't affect the string (which must be the case
        because of parsing being idempotent).

        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::create): Added a check for the URL being valid - if it is not, an
        empty security origin is created.
        (WebCore::SecurityOrigin::createFromString): Parse the string as URL, do not just convert
        it - it is not guaranteed to be properly encoded.

        * dom/Document.cpp: (WebCore::Document::updateBaseURL): As documentURI is an arbitrary
        string, it needs to be parsed into an URL, not just converted into one.

        * html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
        Create the security origin with createFromString() instead of create(). I do not know where
        the string comes from and whether it might not be properly encoded, but this change can't
        hurt, and makes the code slightly more clear.

        * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::accessControlCheck): Create the security
        origin with createFromString() instead of create(). The string comes from an HTTP response
        header, so it may not be a properly encoded URL.

        * loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): Do not try to request using
        invalid URLs.

        * page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): Updated to call
        SecurityOrigin::createFromString() (no change in behavior).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-25 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 26 Jan 2009 05:13:35 +0000 (05:13 +0000)]
2009-01-25  Darin Adler  <darin@apple.com>

        Discussed with Mark Rowe; not sure he reviewed it.

        * Configurations/Base.xcconfig: Add all the same warnings as in WebCore except for
        -Wcast-qual and -Wunused-parameter, which both need to be off at least for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoImprove the consistency of settings in our .xcconfig files.
mrowe@apple.com [Mon, 26 Jan 2009 04:14:36 +0000 (04:14 +0000)]
Improve the consistency of settings in our .xcconfig files.

Rubber-stamped by Dan Bernstein.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand table/forms layout test progression.
hyatt@apple.com [Mon, 26 Jan 2009 03:40:34 +0000 (03:40 +0000)]
Land table/forms layout test progression.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
hyatt@apple.com [Mon, 26 Jan 2009 03:38:55 +0000 (03:38 +0000)]

2009-01-25  David Hyatt  <hyatt@apple.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=23524, lots of missing content in table sections.

        The new table code created a bug involving  markAllDescendantsWithFloatsForLayout, namely that it could
        end up marking ancestors of a block as needing layout when that block was still in the process of
        doing a layout.

        The fix is to add a parameter to markAllDescendantsWithFloatsForLayout that says whether or not
        we are "mid-layout."  If this flag is set, then the method will make sure to do only local dirtying
        of objects to avoid accidentally marking a clean ancestor as needing layout again.

        Ultimately the second parameter to setNeedsLayout and setChildNeedsLayout should just be removed,
        with a check of whether or not we are mid-layout being done by those methods instead.

        Reviewed by Oliver Hunt

        Added fast/repaint/dynamic-table-vertical-alignment-change.html

        * rendering/RenderBlock.cpp:
        * rendering/RenderBlock.h:
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderTableSection.cpp:


2009-01-25  David Hyatt  <hyatt@apple.com>

        Add layout test for https://bugs.webkit.org/show_bug.cgi?id=23524.

        Reviewed by Oliver Hunt

        * fast/repaint/dynamic-table-vertical-alignment-change.html: Added.
        * platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.checksum: Added.
        * platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.png: Added.
        * platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
darin@apple.com [Mon, 26 Jan 2009 03:02:08 +0000 (03:02 +0000)]

2009-01-25  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Bug 23352: Turn on more compiler warnings in the Mac build

        Turn on the following warnings:


        * Configurations/Base.xcconfig: Added the new warnings. Switched to -Wextra instead of
        -W for clarity since we don't have to support the older versions of gcc that require the
        old -W syntax. Since we now use -Wformat=2, removed -Wformat-security. Also removed
        -Wno-format-y2k since we can have that one on now.


2009-01-25  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Bug 23352: Turn on more compiler warnings in the Mac build

        Turn on the following warnings:


        * Configurations/Base.xcconfig: Added the new warnings. Switched to -Wextra instead of
        -W for clarity since we don't have to support the older versions of gcc that require the
        old -W syntax. Since we now use -Wformat=2, removed -Wformat-security. Also removed
        -Wno-format-y2k since we can have that one on now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Mon, 26 Jan 2009 01:32:54 +0000 (01:32 +0000)]

        Reviewed by Oliver Hunt.

        - fix <rdar://problem/6525618> REGRESSION (r39566): NewsFire crashes in
          string hashing code when opening a Digg RSS article

        Test: fast/loader/null-request-after-willSendRequest.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadItem): Null-check the request returned from
        the client's willSendRequest method.


        Reviewed by Oliver Hunt.

        - test for <rdar://problem/6525618> REGRESSION (r39566): NewsFire crashes in
          string hashing code when opening a Digg RSS article

        * fast/loader/null-request-after-willSendRequest-expected.txt: Added.
        * fast/loader/null-request-after-willSendRequest.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-25 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 26 Jan 2009 00:47:25 +0000 (00:47 +0000)]
2009-01-25  David Hyatt  <hyatt@apple.com>

        Fix for <rdar://problem/6525392> REGRESSION (r40180): Scroll wheel events over text scroll the page
        instead of the ancestor overflow (23525)

        Make sure that we always call scroll() on the nearest enclosing RenderBox.  No test case is possible
        here, since wheel scrolling is currently untestable (the offset varies from machine to machine).

        Reviewed by Dan Bernstein

        * page/EventHandler.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-25 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 25 Jan 2009 23:42:44 +0000 (23:42 +0000)]
2009-01-25  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23538: REGRESSION (r39969): Garbage text instead of blank content rendered when plug-ins are disabled

        I'm not sure how to make a regression test for this, since it depends on plug-ins being disabled.

        The main problem here is that when plug-ins were disabled, the code ignored the classId attribute and
        the <embed> element entirely. That resulted in a page treating a Flash document as plain HTML rather
        than doing fallback.

        * rendering/RenderPartObject.cpp:
        (WebCore::createClassIdToTypeMap): Added. Broke this out into a separate function so we could get rid of an
        inelegant if statement.
        (WebCore::activeXType): Added. To avoid repeating the MIME type for ActiveX and possibly having a typo.
        (WebCore::havePlugin): Added. Helper function to make sure we don't forget the null check.
        (WebCore::serviceTypeForClassId): Give this function a return value since that's a more natural way to
        return a string than an "out" parameter.  Fixed the logic to only prefer the ActiveX type over the
        type guessed from the classId when there actually is an ActiveX plug-in to use. The old function assumed
        there was one, which I presume right for Chrome on Windows when plug-ins are enabled, but wrong in many
        other cases, and wrong all the time for all clients on Mac. We don't want to assume either way. Use the
        new havePlugin function so we handle the case where pluginData is 0.
        (WebCore::shouldUseEmbedDescendant): Renamed. Simplified the comment. Changed to use serviceTypeForClassId
        instead of the old version that used an out parameter. Always use the <embed> if there isn't a plug-in
        that knows how to handle <object> elements.
        (WebCore::RenderPartObject::updateWidget): Removed null checks of pluginData. The two functions that
        use this data still need to be called; they still do something even if no plug-ins are present. And
        they have now been corrected to handle 0 properly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-25 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 25 Jan 2009 21:19:40 +0000 (21:19 +0000)]
2009-01-25  Darin Adler  <darin@apple.com>

        * rendering/RenderMenuList.cpp: Fix build by adding back needed include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-25 Judit Jasz <jasy@inf.u-szeged.hu>
darin@apple.com [Sun, 25 Jan 2009 21:11:42 +0000 (21:11 +0000)]
2009-01-25  Judit Jasz  <jasy@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Compilation problem fixing

        * jit/JITCall.cpp:
        (JSC::JIT::compileOpCall): Use JSValuePtr::encode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
darin@apple.com [Sun, 25 Jan 2009 20:27:41 +0000 (20:27 +0000)]

2009-01-25  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 23352: Turn on more compiler warnings in the Mac build

        Fourth patch: Deal with the last few stray warnings.

        * parser/Parser.cpp: Only declare jscyyparse if it's not already declared.
        This makes both separate compilation and all-in-one compilation work with the
        -Wredundant-decls warning.


2009-01-25  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 23352: Turn on more compiler warnings in the Mac build

        Fourth patch: Deal with the last few stray warnings.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::firstLineBlock): Handle the const_cast a little better.
        Also make the local variable be a RenderBlock so the cast is closer to the code
        that guarantees it's correct.

        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeStyle): Put the enum into a local variable that's a built-in
        type before using it with TextStream, so we don't get a warning due to -Wsign-promo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-25 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 25 Jan 2009 20:25:34 +0000 (20:25 +0000)]
2009-01-25  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 23352: Turn on more compiler warnings in the Mac build

        Third patch: Use the noreturn attribute on functions that don't
        return to prepare for the use of the -Wmissing-noreturn warning.

        * jit/JITCall.cpp:
        (JSC::unreachable): Added NO_RETURN.
        * jsc.cpp:
        (functionQuit): Ditto.
        (printUsageStatement): Ditto.
        * wtf/AlwaysInline.h: Added definition of NO_RETURN.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Sun, 25 Jan 2009 20:23:04 +0000 (20:23 +0000)]

2009-01-25  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 23522: use checked casts for render tree

        Step one: RenderText.

        Also change set of RenderFlow* to be a ListHashSet as the comment in the
        header indicated.

        * dom/CharacterData.cpp:
        (WebCore::CharacterData::setData): Use toRenderText.
        (WebCore::CharacterData::appendData): Ditto.
        (WebCore::CharacterData::insertData): Ditto.
        (WebCore::CharacterData::deleteData): Ditto.
        (WebCore::CharacterData::replaceData): Ditto.
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::getUpperLeftCorner): Ditto.
        (WebCore::ContainerNode::getLowerRightCorner): Ditto.
        * dom/Position.cpp:
        (WebCore::nextRenderedEditable): Ditto.
        (WebCore::previousRenderedEditable): Ditto.
        (WebCore::Position::renderedOffset): Ditto. Also use function members
        instead of data members of InlineTextBox.
        (WebCore::Position::upstream): Ditto.
        (WebCore::Position::downstream): Ditto.
        (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): Ditto.
        (WebCore::Position::inRenderedText): Ditto.
        (WebCore::Position::isRenderedCharacter): Ditto.
        (WebCore::searchAheadForBetterMatch): Ditto.
        (WebCore::Position::getInlineBoxAndOffset): Ditto.

        * dom/Range.cpp: Added include of VisiblePosition.h now that it's no longer
        included in RenderObject.h.

        * dom/Text.cpp:
        (WebCore::Text::splitText): Use toRenderText.
        (WebCore::Text::recalcStyle): Ditto.
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::deleteInsignificantText): Ditto.
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::debugRenderer): Ditto.
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::handleTextNode): Ditto.
        (WebCore::TextIterator::handleTextBox): Ditto.
        (WebCore::TextIterator::emitText): Ditto.
        (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto.

        * editing/VisiblePosition.cpp: Added include of FloatQuad.h now that it's
        no longer included in RenderObject.h.
        * inspector/InspectorController.cpp: Ditto.
        * page/Frame.cpp: Ditto.
        * rendering/RenderBox.cpp: Ditto.
        * rendering/RenderInline.cpp: Ditto.
        * rendering/RenderPath.cpp: Ditto.
        * rendering/RenderSVGContainer.cpp: Ditto.
        * rendering/RenderSVGImage.cpp: Ditto.
        * rendering/RenderSVGInlineText.cpp: Ditto.
        * rendering/RenderSVGTSpan.cpp: Ditto.
        * rendering/RenderSVGText.cpp: Ditto.
        * rendering/RenderSVGTextPath.cpp: Ditto.
        * rendering/RenderTableCell.cpp: Ditto.
        * rendering/RenderView.cpp: Ditto.

        * editing/visible_units.cpp:
        (WebCore::startPositionForLine): Use function members instead of data
        members of InlineTextBox.
        (WebCore::endPositionForLine): Ditto.
        (WebCore::startOfParagraph): Use toRenderText.
        (WebCore::endOfParagraph): Ditto.

        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Use toRenderText.
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::placeBoxesHorizontally): Ditto.
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::deleteLine): Ditto.
        (WebCore::InlineTextBox::extractLine): Ditto.
        (WebCore::InlineTextBox::attachLine): Ditto.
        (WebCore::InlineTextBox::placeEllipsisBox): Ditto.
        (WebCore::InlineTextBox::paintDecoration): Ditto.
        (WebCore::InlineTextBox::paintCompositionUnderline): Ditto.
        (WebCore::InlineTextBox::offsetForPosition): Ditto.
        (WebCore::InlineTextBox::positionForOffset): Ditto.

        * rendering/InlineTextBox.h: Made most members private. Use toRenderText.

        * rendering/RenderArena.cpp:
        (WebCore::RenderArena::allocate): Use static_cast instead of C-style cast.
        (WebCore::RenderArena::free): Ditto.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::addContinuationWithOutline): Use ListHashSet<RenderFlow*>
        instead of RenderFlowSequencedSet.
        (WebCore::RenderBlock::paintContinuationOutlines): Ditto.
        (WebCore::stripTrailingSpace): Ditto.
        (WebCore::RenderBlock::calcInlinePrefWidths): Ditto.
        (WebCore::RenderBlock::updateFirstLetter): Ditto.

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::addChild): Use toRenderText.

        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::dirtyLinesFromChangedChild): Use ListHashSet<RenderFlow*>
        instead of RenderFlowSequencedSet.
        (WebCore::RenderFlow::paintLines): Ditto.

        * rendering/RenderMenuList.cpp: Removed some unneeded includes.

        * rendering/RenderMenuList.h: Added now-needed forward declaration of RenderText.
        Made more members private.

        * rendering/RenderObject.cpp: Updated includes.
        (WebCore::RenderObject::isEditable): Use toRenderText.
        (WebCore::RenderObject::positionForPoint): Made non-inline so we wouldn't have to
        include VisiblePosition.h in the header just for this.

        * rendering/RenderObject.h: Removed unneeded includes and forward declarations.
        Changed special vertical position values to be constants rather than an enum.
        Eliminated RenderFlowSequencedSet, and changed clients to use ListHashSet<RenderFlow*>.

        * rendering/RenderText.cpp:
        (WebCore::RenderText::findNextInlineTextBox): Use function members instead of
        data members of InlineTextBox.
        (WebCore::RenderText::positionForCoordinates): Ditto.
        (WebCore::isInlineFlowOrEmptyText): Use toRenderText.
        (WebCore::RenderText::previousCharacter): Use function members instead of
        data members of InlineTextBox.
        (WebCore::RenderText::position): Ditto.
        (WebCore::RenderText::caretMinOffset): Ditto.
        (WebCore::RenderText::caretMaxOffset): Ditto.
        (WebCore::RenderText::caretMaxRenderedOffset): Ditto.

        * rendering/RenderText.h: Added definition of toRenderText.

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::textWithHardLineBreaks): Use toRenderText.
        * rendering/RenderTreeAsText.cpp:
        (WebCore::operator<<): Use toRenderText and toRenderBox.
        (WebCore::writeTextRun): Ditto.
        (WebCore::write): Ditto.

        * rendering/bidi.cpp:
        (WebCore::InlineIterator::increment): Use toRenderText.
        (WebCore::InlineIterator::current): Ditto.
        (WebCore::checkMidpoints): Ditto.
        (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto.
        (WebCore::RenderBlock::layoutInlineChildren): Ditto.
        (WebCore::RenderBlock::determineStartPosition): Ditto.
        (WebCore::shouldSkipWhitespaceAfterStartObject): Ditto.
        (WebCore::RenderBlock::findNextLineBreak): Ditto.


2009-01-25  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 23522: use checked casts for render tree

        Step one: RenderText.

        * WebView/WebRenderNode.mm:
        (copyRenderNode): Use toRenderText.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-25 Urs Wolfer <uwolfer@kde.org>
hausmann@webkit.org [Sun, 25 Jan 2009 17:29:05 +0000 (17:29 +0000)]
2009-01-25  Urs Wolfer  <uwolfer@kde.org>

        Reviewed by Simon Hausmann.

        Add QWebPage::SelectAll to WebAction enum to select all content.


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-25 Thiago Macieira <thiago.macieira@nokia.com>
hausmann@webkit.org [Sun, 25 Jan 2009 17:26:24 +0000 (17:26 +0000)]
2009-01-25  Thiago Macieira  <thiago.macieira@nokia.com>

        Reviewed by Simon Hausmann.

        Fix gcc compiler warning (deprecated conversion from constant string to char*)

        "" cannot be stored in a char*

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-25 David Boddie <dboddie@trolltech.com>
hausmann@webkit.org [Sun, 25 Jan 2009 17:22:44 +0000 (17:22 +0000)]
2009-01-25  David Boddie  <dboddie@trolltech.com>

        Reviewed by Simon Hausmann.

        Doc: Fixed the terminology used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-25 Thiago Macieira <thiago.macieira@nokia.com>
hausmann@webkit.org [Sun, 25 Jan 2009 17:20:52 +0000 (17:20 +0000)]
2009-01-25  Thiago Macieira  <thiago.macieira@nokia.com>

        Reviewed by Simon Hausmann.

        Rename links from trolltech.com to qtsoftware.com

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-25 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Sun, 25 Jan 2009 17:04:49 +0000 (17:04 +0000)]
2009-01-25  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon Hausmann.

        Make QWebPage auto-test more robust by cleaning up generated files

        Sometimes the auto-test may segfault, leaving behind files because the
        call to cleanupTestCase() never happens, so we also clean up the files
        at initTestCase() just to make sure we're running in a clean environment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-12-20 Urs Wolfer <uwolfer@kde.org>
hausmann@webkit.org [Sun, 25 Jan 2009 14:56:27 +0000 (14:56 +0000)]
2008-12-20  Urs Wolfer  <uwolfer@kde.org>

        Reviewed by Simon Hausmann.

        Fix: compile qwebhistory.h with pendantic comiler flag.


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove a slightly misleading comment from ChangeLog - the issue is related to bug...
ap@webkit.org [Sun, 25 Jan 2009 12:03:55 +0000 (12:03 +0000)]
Remove a slightly misleading comment from ChangeLog - the issue is related to bug 23500, but not the same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
ap@webkit.org [Sun, 25 Jan 2009 11:59:14 +0000 (11:59 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/5954398> REGRESSION: 1.1% PLT regression from 33577 and 33578 (encoding fixes)

        Changed single argument KURL constructors back to always expect an already encoded string,
        eliminating extra conversions.

        This is a rather unstable situation, as it is often unclear whether a given string is safe
        to convert to KURL without resolving. I think that going forward, the solution is to try to
        keep encoded URLs as KURL instances, and not as strings.

        * platform/KURL.h: Updated comments.

        * platform/KURL.cpp:
        (WebCore::KURL::KURL): In debug builds, verify that the passed string is ASCII-only. The
        intention is to verify that it is already parsed and encoded by KURL or equivalent code, but
        since encoding is scheme-dependent, such a verification would be quite complicated.
        Don't encode the string as UTF-8, as it supposed to be ASCII-only.
        Removed a hack that made strings beginning with "/" turn into "file:" URLs. I didn't find
        any reason for it to exist, but I saw several cases where this code path was taken
        inadvertently (see examples in LayoutTests/ChangeLog).
        (WebCore::KURL::setProtocol): Using a user-provided string without validation or encoding
        is clearly wrong here (e.g., the "protocol" can be set to a full URL, effectively replacing
        the old one), and an already encoded string is expected by parse().
        In debug builds, non-ASCII input will make an assertion in parse() fail. Added a FIXME.
        (WebCore::KURL::setHost): Ditto.
        (WebCore::KURL::setPort): Ditto.
        (WebCore::KURL::setHostAndPort): Ditto.
        (WebCore::KURL::setUser): Ditto.
        (WebCore::KURL::setPass): Ditto.
        (WebCore::KURL::setRef): Ditto.
        (WebCore::KURL::setQuery): Ditto.
        (WebCore::KURL::setPath): Ditto.  Note that problems described in bug 23500 mask some of
        the problems in release builds currently, as the incorrectly parsed URL is ignored.
        (WebCore::KURL::parse): Verify that the passed string is already encoded.

        * html/HTMLLinkElement.cpp:
        * html/HTMLLinkElement.h:
        Changed to avoid using invalid URLs (this was causing problems on DNS prefetch tests, see

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::init): Create an empty KURL without indirection for a small speedup.
        (WebCore::FrameLoader::requestFrame): Resolve and encode javascript URLs properly, now that
        String to KURL conversion requires the string to be already encoded.

        * page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): Resolve and encode the origin.
        HTML5 seems a little unclear on how this should work (it talks about "either parsing it as
        a URL, or resolving it", and then somehow compares unaltered targetOrigin string to a
        security origin object), so I just made the code as close to what we already had as possible.

        * http/tests/misc/dns-prefetch-control-expected.txt:
        * http/tests/misc/dns-prefetch-control.html:
        Google documentation for DNS Prefetch makes use of net-path relative URLs (//server-name),
        explaining that scheme is not necessary. This is of course true, but this test uses data:
        subframes, and data: is a non-hierachical scheme, so resolving such URLs fails, resulting
        in a KURL object that is not valid. WebKit used to ignore this, and tried to create a URL
        from this string again, now with a single argument KURL constructor, which resulted in a
        valid file: URL, which was successfully used! Both issues have been corrected in WebCore,
        so I had to change the test to no longer use relative net-path URLs.

        * http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
        * http/tests/security/postMessage/invalid-origin-throws-exception.html:
        URLs that start with "/" are no longer converted to "file:" ones, so the results now
        match Firefox.

        * http/tests/uri/resolve-encoding-relative-expected.txt: Added.
        * http/tests/uri/resolve-encoding-relative.html: Added.
        Added a test to cover some cases of relative URL resolving that were not covered before.
        Expected results are taken from Firefox 3, and WebKit doesn't match in how fragments are
        encoded (we use document encoding, while Firefox uses UTF-8). Since fragments are not
        sent in HTTP requests, this is not too dangerous, but the Firefox behavior looks more

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoOops, fix the Qt build.
treat@webkit.org [Sun, 25 Jan 2009 00:34:58 +0000 (00:34 +0000)]
Oops, fix the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-24 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Sat, 24 Jan 2009 22:41:22 +0000 (22:41 +0000)]
2009-01-24  Eric Carlson  <eric.carlson@apple.com>

        <video> controls visibility test needs to dump render tree as text because
        the test does not always end at the same time, so the timeline slider thumb
        is not always at the same position.

        * media/video-controls-visible-audio-only.html:
        * platform/mac/media/video-controls-visible-audio-only-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd QWebFrame::renderContents() method which allows arbitary rendering
treat@webkit.org [Sat, 24 Jan 2009 22:39:16 +0000 (22:39 +0000)]
Add QWebFrame::renderContents() method which allows arbitary rendering
of any content region within the QWebFrame.  It also does not draw any

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-24 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 24 Jan 2009 20:59:20 +0000 (20:59 +0000)]
2009-01-24  Darin Adler  <darin@apple.com>

        Try to fix expected results for new video element test.

        * platform/mac/media/video-controls-visible-audio-only-expected.png: Landed new result
        generated on my machine.
        * platform/mac/media/video-controls-visible-audio-only-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-24 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 24 Jan 2009 20:40:01 +0000 (20:40 +0000)]
2009-01-24  Darin Adler  <darin@apple.com>

        Try to fix Qt build.

        * WebCore.pro: Added JSTextCustom.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago https://bugs.webkit.org/show_bug.cgi?id=23467
cmarrin@apple.com [Sat, 24 Jan 2009 15:10:06 +0000 (15:10 +0000)]

        Change styleAvailable functionality to be a linked list
        rather than scanning every CompositeAnimation for
        Animations that are waiting for styleAvailable. This has
        potential for large performance improvement in cases where
        there are many animations firing at once. But it will also
        help in my next fix, which is to synchronize software and
        accelerated animations.

        I also changed slightly when the beginAnimationUpdate and
        endAnimationUpdate calls are made. But this has no real
        effect on performance or behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoForce inlining of Lexer::matchPunctuator
oliver@apple.com [Sat, 24 Jan 2009 09:55:16 +0000 (09:55 +0000)]
Force inlining of Lexer::matchPunctuator

Reviewed by Maciej Stachowiak.

2.2% win when parsing jQuery, Mootools, Prototype, etc

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
ap@webkit.org [Sat, 24 Jan 2009 09:39:19 +0000 (09:39 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/6368059> REGRESSION: URL encoding problems on http://www.cineman.ch

        Test: http/tests/xmlhttprequest/encode-request-url-2.html

        * platform/KURL.cpp:
        (WebCore::appendASCII): Added a helper function.
        (WebCore::KURL::KURL): Explicitly encode the URL to call two-argument parse() with better
        specified behavior.
        (WebCore::KURL::init): Ditto. This avoids trying to round-trip an URL encoded into a byte
        stream, but not yet transformed to ASCII-only using percent escapes. Since different parts
        of the byte stream can use different encodings, round-tripping is not possible.
        (WebCore::KURL::parse): Reverted an earlier change that made the single-argument version of
        this function convert the string to utf-8. I think that on the remanining code paths, it is
        correct to assume that the string is all ASCII, but I'm not yet confident enough to drop a
        FIXME warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-24 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 24 Jan 2009 08:05:24 +0000 (08:05 +0000)]
2009-01-24  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix after r40170

        * GNUmakefile.am: Removed editing/RemoveNodeAttributeCommand.cpp
        and editing/RemoveNodeAttributeCommand.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the Qt build after r40205.
treat@webkit.org [Sat, 24 Jan 2009 06:19:11 +0000 (06:19 +0000)]
Fix the Qt build after r40205.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-23 Brady Eidson <beidson@apple.com>
beidson@apple.com [Sat, 24 Jan 2009 05:47:59 +0000 (05:47 +0000)]
2009-01-23  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        In CachedPage, break off per-Frame pieces of data into a CachedFrame object.

        * GNUmakefile.am:
        * WebCore.base.exp:
        * WebCore.pro:
        * WebCore.scons:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:

        * history/CachedFrame.cpp: Added.
        * history/CachedFrame.h: Added.

        * history/CachedPage.cpp:
        * history/CachedPage.h:

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::cachePageForHistoryItem): Setting the DocumentLoader independently of
          creating a CachedPage was a historical relic.  Take the opportunity to clean that up.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-23 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 24 Jan 2009 03:59:09 +0000 (03:59 +0000)]
2009-01-23  David Hyatt  <hyatt@apple.com>

        Add ASSERTs to catch anyone trying to obtain the width/height of an inline flow.  Fix up all the places
        that triggered the ASSERT (since all of these places are effectively regressions from my landing that
        devirtualized width()/height()).

        Reviewed by Adele

        * dom/Position.cpp:
        * editing/DeleteButtonController.cpp:
        * html/HTMLAnchorElement.cpp:
        * rendering/RenderBox.cpp:
        * rendering/RenderBox.h:
        * rendering/RenderFlow.h:
        * rendering/RenderLayer.cpp:
        * rendering/RenderScrollbarPart.cpp:
        * rendering/RenderScrollbarPart.h:
        * wml/WMLAElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-23 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Sat, 24 Jan 2009 03:03:25 +0000 (03:03 +0000)]
2009-01-23  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Fix for <rdar://problem/6126212>
        Ensure that callbacks out from the JSC interface are only allowed
        to return in reverse-chronological order to that in which they were
        made.  If we allow earlier callbacks to return first, then this may
        result in setions of the RegisterFile in use by another thread
        being trampled.

        See uber-comment in JSLock.h for details.

        * runtime/JSLock.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-23 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 24 Jan 2009 02:39:56 +0000 (02:39 +0000)]
2009-01-23  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        Bug 23352: Turn on more compiler warnings in the Mac build

        Second patch: Slightly less simple cases of various warnings.

        * bridge/jni/jni_runtime.h:
        (JSC::Bindings::JavaString::_commonInit): Use reinterpret_cast here and avoid casting
        away const.

        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::PendingCallbacks::appendStartElementNSCallback): Use static_cast instead of
        reinterpret_cast; this is casting the result of malloc, and the idiom is to use
        static_cast, which works because we're casting from void*.
        (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): Use const_cast instead
        C-style casts.

        * xml/XSLTUnicodeSort.cpp:
        (inlineXSLTTransformError): Tweak soft linking of xsltTransformError to use a macro
        instead of redefining the function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-23 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 24 Jan 2009 02:23:12 +0000 (02:23 +0000)]
2009-01-23  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        Bug 23475: fast/text/find-backwards.html fails with ICU disabled SearchBuffer

        * editing/TextIterator.cpp:
        (WebCore::SearchBuffer::search): Set the character start flag to false to
        ensure we won't ever return the same result twice. There are other ways we
        could accomplish this, mentioned in the comment, but this one was the smallest
        and cleanest I could think of.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-01-23 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 24 Jan 2009 02:22:21 +0000 (02:22 +0000)]
2009-01-23  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        Bug 23510: REGRESSION (r40171): CDATASection objects not getting proper JavaScript wrappers

        That patch fixed the optimization that's supposed to give a faster path for
        allocating the wrappers for DOM Text objects. But CDATASection is the one
        subclass of Text objects.

        * GNUmakefile.am: Added JSCDATASectionCustom.cpp.
        * WebCore.scons: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.

        * bindings/js/JSCDATASectionCustom.cpp: Copied from bindings/js/JSTextCustom.cpp.
        (WebCore::toJSNewlyCreated): Changed to do CDATASection, not Text.

        * bindings/scripts/CodeGeneratorJS.pm: Added another toJSNewlyCreated function
        for CDATASection. We don't want to have to check when creating a wrapper for a
        Text object whether it's a CDATASection object or not, so we need to do this overload
        at compile time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Eric Seidel.
zimmermann@webkit.org [Sat, 24 Jan 2009 02:00:43 +0000 (02:00 +0000)]
Reviewed by Eric Seidel.

Add a base class for WML form control elements: WMLFormControlElement (as it's designed in HTML as well).
WMLFormControlElement inherits from WMLElement and FormControlElement (just like the HTMLFormControlElement equivalent).

WMLInputElement / WMLOptionElement / WMLOptGroupElement are supposed to inherit from the new WMLFormControlElement class.
Now WMLInputElement & WMLOptGroupElement only inherit from WMLElement and FormControlElement, but WMLOptionElement inherits
from WMLEventHandlingElement (which in turn inherits from WMLElement) and FormControlElement. In order to introduce a shared
base class, WMLEventHandlingElement is no longer allowed to inherit from WMLElement directly. Instead it should turn into
another base class, just like FormControlElement.

Add a base class for form control elements 'with state': FormControlElementWithState, serving as base class for
HTMLFormControlElementWithState and WMLFormControlElementWithState. -> Make Document operate on FormControlElementWithState
objects instead of HTMLFormControlElementWithState objects, to support save/restore control state for non HTMLFormControlElements.

Rename isGenericFormElement() to isFormControlElement(), and move it to Element.h
Add new virtual function isFormControlElementWithState() to Element.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBug 23492: Separating the WebKitSystemInterface Calls.
bfulgham@webkit.org [Sat, 24 Jan 2009 01:23:21 +0000 (01:23 +0000)]
Bug 23492: Separating the WebKitSystemInterface Calls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBug 23509: Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]
cfleizach@apple.com [Sat, 24 Jan 2009 01:21:29 +0000 (01:21 +0000)]
Bug 23509: Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]

Move null checking into makeRange

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the Gtk build too after removal of RenderBox::toConstRenderBox
treat@webkit.org [Sat, 24 Jan 2009 00:54:46 +0000 (00:54 +0000)]
Fix the Gtk build too after removal of RenderBox::toConstRenderBox

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the Qt build after rename of RenderBox::toConstRenderBox -> toRenderBox
treat@webkit.org [Sat, 24 Jan 2009 00:52:36 +0000 (00:52 +0000)]
Fix the Qt build after rename of RenderBox::toConstRenderBox -> toRenderBox

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the Qt build after r40168.
treat@webkit.org [Sat, 24 Jan 2009 00:47:44 +0000 (00:47 +0000)]
Fix the Qt build after r40168.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson@apple.com [Sat, 24 Jan 2009 00:26:43 +0000 (00:26 +0000)]

2009-01-23  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Darin Adler

        Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.

        * GNUmakefile.am:
        * WebCore.base.exp:
        * WebCore.order:
        * WebCore.xcodeproj/project.pbxproj:

        * history/CachedFramePlatformData.h: Copied from WebCore/history/CachedPagePlatformData.h.
        * history/CachedPagePlatformData.h: Removed.

        * history/CachedPage.cpp:
        * history/CachedPage.h:


2009-01-23  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Darin Adler

        Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.

        * WebKit.xcodeproj/project.pbxproj:


2009-01-23  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Darin Adler

        Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.

        * WebCoreSupport/WebCachedFramePlatformData.h: Copied from WebKit/mac/WebCoreSupport/WebCachedPagePlatformData.h.
        * WebCoreSupport/WebCachedPagePlatformData.h: Removed.

        * WebCoreSupport/WebFrameLoaderClient.mm:

        * WebKit.order:


2009-01-23  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Darin Adler

        Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.

        * WebCachedFramePlatformData.h: Copied from WebKit/win/WebCachedPagePlatformData.h.
        * WebCachedPagePlatformData.h: Removed.

        * WebCoreSupport/WebFrameLoaderClient.cpp:

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Sat, 24 Jan 2009 00:23:04 +0000 (00:23 +0000)]
Reviewed by Kevin Ollivier.

Fix drawing in situations where sub-portions of the bitmap are to be drawn to the screen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fixes for recent changes.
kevino@webkit.org [Sat, 24 Jan 2009 00:19:17 +0000 (00:19 +0000)]
Build fixes for recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Windows bustage.
hyatt@apple.com [Fri, 23 Jan 2009 23:33:57 +0000 (23:33 +0000)]
Fix Windows bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@40195 268f45cc-cd09-0410-ab3c-d52691b4dbfc