19 years ago Reviewed by Dave.
darin [Fri, 19 Sep 2003 22:16:10 +0000 (22:16 +0000)]
    Reviewed by Dave.

        * layout-tests: Updated for my mini-controls change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoWebCore:
darin [Fri, 19 Sep 2003 21:46:47 +0000 (21:46 +0000)]

        Reviewed by Dave.

        - do the prep work for the mini controls feature; Dave will finish this

        * khtml/rendering/render_form.cpp: (RenderFormElement::updateFromElement):
        Tell the widget about the font size. Our widgets use the font size to
        decide whether to use Aqua normal, small, or mini.

        * kwq/KWQButton.h: Add setFont.
        * kwq/KWQButton.mm:
        (QButton::setFont): Set control size based on font.
        (KWQNSControlSizeForFont): Determine control size given a font. Dave is going
        to tweak this later.

        * kwq/KWQCheckBox.h: Add dimensions function for metrics for each control size.
        * kwq/KWQCheckBox.mm:
        (QCheckBox::sizeHint): Use dimensions.
        (QCheckBox::frameGeometry): Use dimensions.
        (QCheckBox::setFrameGeometry): Use dimensions.
        (QCheckBox::baselinePosition): Use dimensions.
        (QCheckBox::dimensions): Added. Has newly tweaked values for all dimensions for
        all three control sizes.

        * kwq/KWQComboBox.h: Add setFont and dimensions.
        * kwq/KWQComboBox.mm:
        (QComboBox::sizeHint): Use dimensions.
        (QComboBox::frameGeometry): Use dimensions.
        (QComboBox::setFrameGeometry): Use dimensions.
        (QComboBox::baselinePosition): Use dimensions.
        (QComboBox::setFont): Use dimensions.
        (QComboBox::dimensions): Added. Has newly tweaked values for all dimensions for
        all three control sizes.

        * kwq/KWQFileButton.mm: (KWQFileButton::baselinePosition): Change to adapt to
        flipped version of file button NSControl.

        * kwq/KWQPushButton.h: Add dimensions function for metrics for each control size.
        * kwq/KWQPushButton.mm:
        (QPushButton::sizeHint): Use dimensions.
        (QPushButton::frameGeometry): Use dimensions.
        (QPushButton::setFrameGeometry): Use dimensions.
        (QPushButton::baselinePosition): Use dimensions.
        (QPushButton::dimensions): Added. Has newly tweaked values for all dimensions for
        all three control sizes.

        * kwq/KWQRadioButton.h: Add dimensions function for metrics for each control size.
        * kwq/KWQRadioButton.mm:
        (QRadioButton::sizeHint): Use dimensions.
        (QRadioButton::frameGeometry): Use dimensions.
        (QRadioButton::setFrameGeometry): Use dimensions.
        (QRadioButton::baselinePosition): Use dimensions.
        (QRadioButton::dimensions): Added. Has newly tweaked values for all dimensions for
        all three control sizes.


        Reviewed by Dave.

        - do the prep work for the mini controls feature; Dave will finish this

        * WebCoreSupport.subproj/WebFileButton.m:
        (-[WebFileButton isFlipped]): Make this flipped, easier to understand coordinates that way.
        (-[WebFileButton drawRect:]): Update for flipped-ness.
        (-[WebFileButton visualFrame]): Update for flipped-ness.
        (-[WebFileButton setVisualFrame:]): Update for flipped-ness.
        (-[WebFileButton baseline]): Update for flipped-ness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoWebCore:
mjs [Fri, 19 Sep 2003 20:46:17 +0000 (20:46 +0000)]

        Reviewed by Darin.

- fixed 3410980 - FileMaker: going forward with an empty forward list makes a frame come out blank sometimes

        * khtml/html/html_documentimpl.cpp:
        (HTMLDocumentImpl::close): Remove redundant check removed.
        * khtml/khtml_part.h:
        * kwq/KWQKHTMLPart.h:
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::scheduleHistoryNavigation): Only call the base class
method to actually schedule when it's possible to go back or forward
that number of steps.
        * kwq/WebCoreBridge.h:


        Reviewed by Darin.

- fixed 3410980 - FileMaker: going forward with an empty forward list makes a frame come out blank sometimes

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge backOrForwardItemWithDistance:]): Factored out from goBackOrForward.
        (-[WebBridge canGoBackOrForward:]): Use the new method.
        (-[WebBridge goBackOrForward:]): Likewise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Maciej.
darin [Thu, 18 Sep 2003 21:56:56 +0000 (21:56 +0000)]
    Reviewed by Maciej.

        * kjs/date_object.cpp: Removed our CF-based implementations of gmtime, localtime,
        mktime, timegm, and time, since they no longer have the slow "hit the filesystem
        every time" behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoWebCore:
sullivan [Thu, 18 Sep 2003 15:26:08 +0000 (15:26 +0000)]

- WebCore part of fix for 3157018 -- Would like option to
not print backgrounds

        Reviewed by Darin

        * kwq/KWQKHTMLSettings.h:
add _shouldPrintBackgrounds field and accessors

        * kwq/WebCoreSettings.h:
add shouldPrintBackgrounds field and accessors
        * kwq/WebCoreSettings.mm:
        (-[WebCoreSettings setShouldPrintBackgrounds:]):
new method, passes value to KHTMLSettings
        (-[WebCoreSettings shouldPrintBackgrounds]):
new method

        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge styleSheetForPrinting]):
new method, returns a style sheet that has backgrounds
turned off if preference is set that way.
        (-[WebCoreBridge reapplyStylesForDeviceType:]):
if printing, set the printStyleSheet to the one we
created based on the preferences. (KHTML has always
had support for a special printStyleSheet, but it was
only being used in !APPLE_CHANGES code.)

        * khtml/rendering/render_style.h:
add shouldCorrectTextColor boolean field and accessors

        * khtml/xml/dom_docimpl.cpp:
tell style to correct text colors if backgrounds aren't being printed

        * khtml/rendering/render_text.cpp:
added comment
new function, computes a quick measure of difference
between colors
if text and background colors are too similar, returns
lightened or darkened text color
if style says to correct text colors, call correctedTextColor


- WebKit part of fix for 3157018 -- Would like option to
not print backgrounds

        Reviewed by Darin

        * WebView.subproj/WebPreferences.h:
new accessor methods for new shouldPrintBackgrounds preference
        * WebView.subproj/WebPreferences.m:
        (+[WebPreferences initialize]):
set initial value for WebKitShouldPrintBackgroundsPreferenceKey
to NO
        (-[WebPreferences shouldPrintBackgrounds]):
new method, read NSUserDefaults value
        (-[WebPreferences setShouldPrintBackgrounds:]):
new method, write NSUserDefault value

        * WebView.subproj/WebViewPrivate.m:
        (-[WebView _updateWebCoreSettingsFromPreferences:]):
tell WebCore about value of shouldPrintBackgrounds

        * English.lproj/StringsNotToBeLocalized.txt:
Updated for these and other recent changes


- WebBrowser part of fix for 3157018 -- Would like option to
not print backgrounds

        Reviewed by Darin

* English.lproj/PrintingAccessoryView.nib:
new nib file, contains view holding single "Print
Backgrounds" checkbox

        * PrintingAccessoryViewController.h: Added.
        * PrintingAccessoryViewController.m: Added.
        (-[PrintingAccessoryViewController init]):
load the nib file with self as owner
        (+[PrintingAccessoryViewController sharedController]):
returns shared instance used by BrowserDocument
        (-[PrintingAccessoryViewController togglePrintBackgrounds:]):
toggle the WebKit preference (which in turn updates the
WebCore setting)
        (-[PrintingAccessoryViewController accessoryView]):
returns the view from the nib that will be displayed in the
print panel, after updating the checkbox state

        * BrowserDocument.m:
        (-[BrowserDocument printWebFrameView:showingPrintPanel:]):
Set up print panel's accessory view

        * Preferences.subproj/AppearancePreferences.m:
removed unused method I stumbled across

        * WebBrowser.pbproj/project.pbxproj:
updated for new files

        * English.lproj/StringsNotToBeLocalized.txt:
Updated for these changes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Maciej.
darin [Thu, 18 Sep 2003 00:08:53 +0000 (00:08 +0000)]
    Reviewed by Maciej.

        * Plugins.subproj/WebBasePluginPackage.m:
        (-[WebBasePluginPackage pathByResolvingSymlinksAndAliasesInPath:]): Pass the
        "no UI" flag, so we don't prompt the user when we're trying to load plug-ins.
        Also use OSStatus rather than OSErr so we don't miss error codes that just
        happen to have zeroes in the low 16 bits.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by John.
darin [Thu, 18 Sep 2003 00:05:40 +0000 (00:05 +0000)]
    Reviewed by John.

        * WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton setFilename:]):
        Don't call -[NSWorkspace iconForFile:] on a path that does not start with a '/'.
        This can happen if JavaScript or the web page sets the path explicitly, and
        adding this check avoids an unpleasant warning on the console.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Ken.
darin [Wed, 17 Sep 2003 21:51:07 +0000 (21:51 +0000)]
    Reviewed by Ken.

        - fixed 3423404 -- REGRESSION: Japanese page appears blank due to unexpected kTECPartialCharErr

        * kwq/KWQTextCodec.mm: (KWQTextDecoder::convertOneChunkUsingTEC): In the case where we're already
        going from the small buffer back to the large one, treat kTECPartialCharErr the same as noErr.
        Otherwise we'll get confused and drop the contents of the big buffer.
        (KWQTextDecoder::convert): Improve the debugging code a bit (still turned off).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agomarkers for WebKit-106, and updated release notes for Safari-100
vicki [Wed, 17 Sep 2003 00:25:11 +0000 (00:25 +0000)]
markers for WebKit-106, and updated release notes for Safari-100

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Backed out fix to 3412062 to resolve 3424197.
rjw [Tue, 16 Sep 2003 22:59:52 +0000 (22:59 +0000)]
Backed out fix to 3412062 to resolve 3424197.

Many sites use a technique of posting forms the same URL to generate content server side.  The fix to 3412062 broke those sites.

        Reviewed by Darin.

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _transitionToCommitted:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoupdated Release Notes for the never-ending Safari-100; markers for WebKit/WebCore-105
vicki [Tue, 16 Sep 2003 00:20:29 +0000 (00:20 +0000)]
updated Release Notes for the never-ending Safari-100; markers for WebKit/WebCore-105

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Darin and Don.
darin [Mon, 15 Sep 2003 22:32:44 +0000 (22:32 +0000)]
    Reviewed by Darin and Don.

        - fixed 3419957 -- REGRESSION: lines drawn across multiple columns at washingtonpost.com

        * khtml/rendering/render_box.cpp: (RenderBox::calcWidth): Always use the width of the line
        rather than the width of the containing block for "flow around floats" blocks (<hr>).
        This undoes half of the change made to fix bug 3384609.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Ken and Don.
darin [Mon, 15 Sep 2003 17:23:47 +0000 (17:23 +0000)]
    Reviewed by Ken and Don.

        - fixed 3417604 -- REGRESSION: dragging scroll thumb causes textarea contents to vanish

        * kwq/KWQTextArea.mm: (-[KWQTextArea initWithFrame:]): Deallocated cached graphics state for
        the text view as well as for the clip view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agomarker for WebCore-104
vicki [Mon, 15 Sep 2003 15:44:13 +0000 (15:44 +0000)]
marker for WebCore-104

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agomarker for WebKit-104
vicki [Mon, 15 Sep 2003 04:58:09 +0000 (04:58 +0000)]
marker for WebKit-104

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Maciej.
darin [Sat, 13 Sep 2003 19:44:25 +0000 (19:44 +0000)]
    Reviewed by Maciej.

        - fixed 3420547 -- REGRESSION: repro crash in khtml::RenderBlock::findNextLineBreak (wisdomtips.com)

        * khtml/rendering/render_block.cpp: (RenderBlock::addChildToFlow): Exclude BR elements when looking for
        an element to process first-letter style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago * layout-tests/fast/frames/empty-frame-src-expected.txt: Updated test results...
darin [Sat, 13 Sep 2003 15:38:02 +0000 (15:38 +0000)]
    * layout-tests/fast/frames/empty-frame-src-expected.txt: Updated test results that changed
        due to the change in our handling of frame borders.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoWebKit:
rjw [Sat, 13 Sep 2003 02:11:34 +0000 (02:11 +0000)]
Fixed 3420097.  If redirects are cancelled during a pending load don't reset the quickRedirect flag.

        Reviewed by Darin.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge reportClientRedirectCancelled:]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]):
        (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
        (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
        (-[WebFrame _clientRedirectCancelled:]):

Fixed 3420097.  Pass flag up to WebKit indicating that redirects are being cancelled during a pending load.

        Reviewed by Darin.

        * khtml/khtml_part.cpp:
        * khtml/khtml_part.h:
        * khtml/khtmlpart_p.h:
        * kwq/KWQKHTMLPart.mm:
        * kwq/WebCoreBridge.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agorelease markers for WebKit-103 and WebCore-103; updated release notes to include...
vicki [Sat, 13 Sep 2003 00:42:47 +0000 (00:42 +0000)]
release markers for WebKit-103 and WebCore-103; updated release notes to include -103 fixes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Darin.
mjs [Fri, 12 Sep 2003 23:41:54 +0000 (23:41 +0000)]
    Reviewed by Darin.

        * khtml/css/html4.css: Use the same hardcoded default size for
OBJECT and EMBED tags as for IFRAME.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fixed 3412062. Don't allow pages with the same URL as the current URL to enter...
rjw [Fri, 12 Sep 2003 23:17:46 +0000 (23:17 +0000)]
Fixed 3412062.  Don't allow pages with the same URL as the current URL to enter b/f or history.

        Reviewed by Maciej.

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _transitionToCommitted:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Darin.
mjs [Fri, 12 Sep 2003 22:55:47 +0000 (22:55 +0000)]
    Reviewed by Darin.

- fixed 3413463 - QuickTime plug-in content doesn't load in Safari (NPP_Write not called)

        * Plugins.subproj/npapi.h: Fix erroneous function pointer
declarations that led to an int16/int32 mismatch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Ken.
darin [Fri, 12 Sep 2003 22:53:11 +0000 (22:53 +0000)]
    Reviewed by Ken.

        - fixed 3403223 -- <input type=file> with initial value causes exception, bad results afterwards, when submitted

        * kwq/KWQFile.mm: (QFile::QFile): Don't pass an empty string to fileSystemRepresentation,
        because that will cause an exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fixed: <rdar://problem/3420112>: Reproducible Safari crash in in -[WebBaseNetscapePl...
cblu [Fri, 12 Sep 2003 22:48:49 +0000 (22:48 +0000)]
Fixed: <rdar://problem/3420112>: Reproducible Safari crash in in -[WebBaseNetscapePluginView sendEvent:]

        Reviewed by darin.

        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView sendEvent:]): temporarily retain self in case the plug-in view is released while sending an event.
        (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:targetFrame:]): don't deliver the return value of the JS evaluation if stringByEvaluatingJavaScriptFromString caused the plug-in to stop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoWebKit is open for business.
mjs [Fri, 12 Sep 2003 03:47:27 +0000 (03:47 +0000)]
WebKit is open for business.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoWebCore is open for business.
mjs [Fri, 12 Sep 2003 03:46:46 +0000 (03:46 +0000)]
WebCore is open for business.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoEr, I meant WebKit-102. Looks like there was no release marker for 101.
mjs [Fri, 12 Sep 2003 03:27:02 +0000 (03:27 +0000)]
Er, I meant WebKit-102. Looks like there was no release marker for 101.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoWebKit-101
mjs [Fri, 12 Sep 2003 03:23:18 +0000 (03:23 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoWebCore-101
mjs [Fri, 12 Sep 2003 03:22:58 +0000 (03:22 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Ken.
mjs [Fri, 12 Sep 2003 00:58:27 +0000 (00:58 +0000)]
    Reviewed by Ken.

- fixed 3417486 - after logging off from secure Etrade website, going back returns you to secure page

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _loadItem:withLoadType:]): Don't request stale data
for https pages, as this could be a security risk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoWebKit:
rjw [Fri, 12 Sep 2003 00:19:43 +0000 (00:19 +0000)]
Fixed 3406671.  Added a private method for Mail to get selection

        Reviewed by Darin Adler.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView updateTextBackgroundColor]):
        * WebView.subproj/WebHTMLViewPrivate.h:
        * WebView.subproj/WebHTMLViewPrivate.m:
        (-[WebHTMLView _handleMouseDragged:]):
        (-[WebHTMLView _pluginController]):
        (-[WebHTMLView _selectionRect]):

Fixed 3406671.  Added a private method for Mail to get selection

Fixed 3417688.  Don't allow https page into page cache.

        Reviewed by Darin.

        * kwq/KWQFrame.h:
        * kwq/KWQFrame.mm:
        * kwq/KWQKHTMLPart.mm:
        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge selectionRect]):
        (-[WebCoreBridge visibleSelectionRect]):
        (-[WebCoreBridge selectionImage]):
        (-[WebCoreBridge adjustViewSize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fixed 3231031. Use the normal methodology for displaying each frame of a GIF. ...
rjw [Thu, 11 Sep 2003 00:12:25 +0000 (00:12 +0000)]
Fixed 3231031.  Use the normal methodology for displaying each frame of a GIF.  That is,
just call setNeedsDisplayInRect, rather than drawing directly.  Drawing directly violates

        Reviewed by Dave Hyatt.

        * WebCoreSupport.subproj/WebImageRenderer.m:
        (-[WebImageRenderer nextFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago*** empty log message ***
vicki [Wed, 10 Sep 2003 00:10:42 +0000 (00:10 +0000)]
*** empty log message ***

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago*** empty log message ***
vicki [Tue, 9 Sep 2003 23:55:03 +0000 (23:55 +0000)]
*** empty log message ***

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoWebKit:
rjw [Tue, 9 Sep 2003 22:42:56 +0000 (22:42 +0000)]
Fixed 3414988.  Don't store absolute path to home directory.
Reviewed by Chris Blumenberg.

Fixed 3414319.  Send correct WebView back as parameter to webViewShow:
Review by Darin.

Fixed 3095029.  Draw a frame's border in WebFrameView, instead of WebHTMLView, and correctly inset the frame's scrollview to account for the border.  Mostly written by Darin.
        Reviewed by Darin (and Richard).

        * Misc.subproj/WebIconDatabase.m:
        (-[WebIconDatabase _createFileDatabase]):
Store @"~/Library/Icon" instead of absolute path, and always try to tilde expand stored path.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge setHasBorder:]):
        * WebView.subproj/WebFrameView.m:
        (-[WebFrameView drawRect:]):
        (-[WebFrameView setFrameSize:]):
        * WebView.subproj/WebFrameViewPrivate.h:
        * WebView.subproj/WebFrameViewPrivate.m:
        (-[WebFrameView _isMainFrame]):
        (-[WebFrameView _tile]):
        (-[WebFrameView _drawBorder]):
        (-[WebFrameView _shouldDrawBorder]):
        (-[WebFrameView _setHasBorder:]):
        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView drawRect:]):
Changes to correct draw border in WebFrameView instead of WebHTMLView.

        * WebView.subproj/WebViewPrivate.m:
        (-[WebView _openNewWindowWithRequest:]):
Send correct parameter (returned from webView:createWebViewWithRequest:), rather than self, to webViewShow:.

Fix for 3095029.  Written by Darin.
        Reviewed by Richard.

        * kwq/KWQFrame.h:
        * kwq/KWQFrame.mm:
Doesn't need to be virtual.

        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge adjustViewSize]):
Remove frameBorderStyle, no longer needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fixed: <rdar://problem/3412380>: REGRESSION (85-98): www.minoltan.com is decoded...
cblu [Tue, 9 Sep 2003 21:28:26 +0000 (21:28 +0000)]
Fixed: <rdar://problem/3412380>: REGRESSION (85-98): minoltan.com is decoded incorrectly on Japanese system

The default encoding that Safari uses is latin1 regardless of the current system encoding. This is how it's always been. The problem is that the UI is displaying shift JIS for the default text encoding instead of latin1. This is happening because WebKit is using "latin1" instead of "ISO-8859-1" for the default text encoding name. "ISO-8859-1" is the IANA character set name for latin1 and this is what the  WebKitDefaultTextEncodingNamePreferenceKey preference expects. This ends up confusing Safari, so Safari just ends up displaying the first item in the pop-up menu which is shift JIS.

        Reviewed by rjw.

        * WebView.subproj/WebPreferences.m:
        (+[WebPreferences initialize]): The WebKitDefaultTextEncodingNamePreferenceKey should be "ISO-8859-1" not "latin1" since "ISO-8859-1" is the IANA character set name for latin1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Chris.
darin [Tue, 9 Sep 2003 20:24:45 +0000 (20:24 +0000)]
    Reviewed by Chris.

        - fixed 3373654 -- REGRESSION: Yahoo chat applet reloads over and over due to "baseURL" param name conflict

        After some research by the Java team, we discovered that there was no need to
        pass in baseURL at all This patch gets rid of that by only passingindividual specified
        arguments, rather than passing all the arguments, as applet parameters.

        * khtml/rendering/render_applet.cpp: (RenderApplet::processArguments): Remove the
        call to KJavaApplet::processArguments, because we only want the individual arguments.
        * kwq/KWQKJavaAppletWidget.h: Implement setAppletClass, setAppletName, setArchives, and
        setCodeBase. Remove processArguments.
        * kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::setParameter): Lowercase all the
        parameters as we put them in the dictionary, since this is the semantics required by Java.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agotree is open for Safari-100!
vicki [Mon, 8 Sep 2003 23:33:24 +0000 (23:33 +0000)]
tree is open for Safari-100!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoSafari-99 stamp
vicki [Mon, 8 Sep 2003 23:14:16 +0000 (23:14 +0000)]
Safari-99 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Chris.
darin [Mon, 8 Sep 2003 18:45:28 +0000 (18:45 +0000)]
    Reviewed by Chris.

        - fixed 3412726 -- some HTML messages in Mail lose a line at page breaks when printed (multipart/alternative)

        * WebView.subproj/WebHTMLView.m: (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
        Go into printing mode when asked to adjust page height, if not already in it.
        We already have code in drawRect that does this when actually printing, but it's
        also important to lay out the same way when deciding where to break pages, otherwise
        the difference between printer and screen fonts can lead to page breaks that split a line
        of text across two pages, and that can lead to missing lines of text as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Maciej.
darin [Sun, 7 Sep 2003 23:06:28 +0000 (23:06 +0000)]
    Reviewed by Maciej.

        - fixed 3411827 -- REGRESSION: text drawing after text-shadow does not respect smoothing style (asahi.com)

        * kwq/KWQPainter.mm: (QPainter::clearShadow): Call CGContextSetShadowWithColor with a color of NULL,
        which actually clears the shadow, rather than CGContextSetShadow, which sets a black shadow (even
        if it is zero pixels in size).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Maciej.
darin [Sun, 7 Sep 2003 22:38:33 +0000 (22:38 +0000)]
    Reviewed by Maciej.

        - fixed 3410939 -- disabling Geneva and Helvetica (by removing them, or by using Font Book) makes Safari crash

        * WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fallbackFontWithTraits:size:]):
        Fall back on Lucida Grande (plain, not bothering with traits) if Helvetica is not present.

        * English.lproj/StringsNotToBeLocalized.txt: Update for this and other recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Ken.
darin [Sun, 7 Sep 2003 19:16:37 +0000 (19:16 +0000)]
    Reviewed by Ken.

        - fixed 3406660 -- screen fonts are not being used for substitute fonts (Japanese text, Roman font)

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer substituteFontForString:families:]): Get a printer or screen font,
        based on the renderer's mode. The old code didn't do anything explicit.
        (-[WebTextRenderer _setupFont]): Remove ignored parameter for clarity.
        (-[WebTextRenderer initWithFont:usingPrinterFont:]): Fixed code paths that would not
        explicitly get a printer or screen font, and code paths that would get data from the
        original "before mapping to printer or screen font" NSFont object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agotree is open for Safari-99!
vicki [Fri, 5 Sep 2003 23:27:27 +0000 (23:27 +0000)]
tree is open for Safari-99!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoSafari-98 stamp
vicki [Fri, 5 Sep 2003 23:12:10 +0000 (23:12 +0000)]
Safari-98 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoWebCore:
kocienda [Fri, 5 Sep 2003 20:00:35 +0000 (20:00 +0000)]

        Reviewed by Darin

Fix for this bug:

<rdar://problem/3226083>: REGRESSION (Panther): white box
overlaying select lists at nvidia.com drivers page

        * kwq/KWQListBox.mm:
        (QListBox::QListBox): Re-add releaseGState fix that Darin
added, but then removed. It turns out that we do need
this workaround in place to get proper drawing.

Fix for this bug:

<rdar://problem/3310943>: REGRESSION (Panther): textareas
in forms sometimes draw blank (bugreporter)

        * kwq/KWQTextArea.mm:
        (-[KWQTextArea initWithFrame:]): Same fix as above.


        Reviewed by Darin

Incorporate releaseGState fix that Darin developed for
textareas and list boxes in WebCore. It turns out that
we this workaround in WebClipView as well to get proper
drawing of subframes.

In addition, removed some tests that which performed
runtime checks for code in AppKit. AppKit will have
the checked-for code in all versions that will be used
with the version of WebKit.

        * WebView.subproj/WebClipView.m:
        (-[WebClipView initWithFrame:])
        (-[WebClipView resetAdditionalClip])
        (-[WebClipView setAdditionalClip:])

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoRemoved stray conflict marker.
sullivan [Fri, 5 Sep 2003 17:46:26 +0000 (17:46 +0000)]
Removed stray conflict marker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago - fixed 3409011 -- the graphics views palette does not open
sullivan [Fri, 5 Sep 2003 17:23:41 +0000 (17:23 +0000)]
- fixed 3409011 -- the graphics views palette does not open

        Reviewed by Maciej

        * WebView.subproj/WebPreferences.m:
        (+[WebPreferences _removeReferenceForIdentifier:]):
special-case nil, which is a magic initial identifier already
special-cased in the other mutator

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Darin.
mjs [Fri, 5 Sep 2003 08:34:22 +0000 (08:34 +0000)]
    Reviewed by Darin.

- fixed - REGRESSION (85-92): Javascript on page isn't triggered by typed characters (onKeyUp)

(This actually also requires an AppKit fix to be a full fix.)

        * kwq/KWQListBox.mm:
        (-[KWQTableView keyDown:]): Added. Send event through DOM.
        (-[KWQTableView keyUp:]): Likewise.
        (-[KWQTableView becomeFirstResponder]): Added. Report focus change
to DOM.
* kwq/KWQTextArea.mm:
        (-[KWQTextAreaTextView keyUp:]): Added. Send event through DOM.
        * kwq/KWQTextField.mm:
        (-[KWQTextField textView:shouldHandleEvent:]): Pass NSKeyUp events too
(not going to work until we get an AppKit fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Darin.
mjs [Fri, 5 Sep 2003 08:12:33 +0000 (08:12 +0000)]
    Reviewed by Darin.

- fixed 3406140 - REGRESSION (7B52-7B55): time spent in NSFont makes Safari 50% slower in Five Apps test

        * WebCoreSupport.subproj/WebTextRendererFactory.m:
        (-[WebTextRendererFactory fontWithFamily:traits:size:]): Make font
using the font name we found, not the one we were looking
for. Since the compare is case-insensitive, it makes a
difference. Also, don't make the font twice.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fixed: <rdar://problem/3316704>: Shockwave: getnetText steam is not functioning...
cblu [Fri, 5 Sep 2003 06:07:45 +0000 (06:07 +0000)]
Fixed: <rdar://problem/3316704>: Shockwave: getnetText steam is not functioning correctly

        Reviewed by mjs.

        * Plugins.subproj/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): if the content length is unknown, use 0 instead of -1

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago - fixed 3399880 -- Repro crash when filling out a form to
sullivan [Fri, 5 Sep 2003 01:22:49 +0000 (01:22 +0000)]
- fixed 3399880 -- Repro crash when filling out a form to
download Macromedia software. I managed to check in this
ChangeLog comment a few days ago without actually checking
in the changed file, weird.

        Reviewed by Chris

        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge elementForView:]):
check for nil widget before dereferencing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fix for 3408630, leak of child frame parts caused by a missing deref when frames
hyatt [Fri, 5 Sep 2003 00:29:10 +0000 (00:29 +0000)]
Fix for 3408630, leak of child frame parts caused by a missing deref when frames
get detached from their parent frame list.

        Reviewed by mjs

        * kwq/KWQKHTMLPart.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago * layout-tests/apple-only/base/www.msn.com/index-expected.txt: Update for...
darin [Thu, 4 Sep 2003 23:51:12 +0000 (23:51 +0000)]
    * layout-tests/apple-only/base/msn.com/index-expected.txt: Update for residual style fix.
        * layout-tests/fast/invalid/003-expected.txt: Update for residual style fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fixed: <rdar://problem/3286922>: Shockwave: Using HTTP to stream .mp3 or .swa files...
cblu [Thu, 4 Sep 2003 23:22:13 +0000 (23:22 +0000)]
Fixed: <rdar://problem/3286922>: Shockwave: Using HTTP to stream .mp3 or .swa files fails at ~50%

        Reviewed by mjs.

        * Plugins.subproj/WebBaseNetscapePluginStream.h: new deliveryData and reason ivars
        * Plugins.subproj/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream dealloc]): release deliveryData ivar
        (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): set new reason ivar
        (-[WebBaseNetscapePluginStream destroyStream]): new, calls NPP_StreamAsFile, NPP_DestroyStream and NPP_URLNotify
        (-[WebBaseNetscapePluginStream destroyStreamWithReason:]): set the reason, call destroyStream
        (-[WebBaseNetscapePluginStream receivedError:]): set deliveryData length to 0 so no more data is streamed, call destroyStreamWithReason
        (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): don't call NPP_StreamAsFile because this has to be called right before NPP_DestroyStream in destroyStream
        (-[WebBaseNetscapePluginStream deliverData]): new, call NPP_WriteReady and NPP_Write and properly obey their returned values
        (-[WebBaseNetscapePluginStream receivedData:]): call deliverData
        * Plugins.subproj/WebNetscapePluginStream.m:
        (-[WebNetscapePluginStream stop]): call receivedError here
        (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): don't call receivedError here because after the load is complete, stream is set to nil and receivedError can be called after the completed load

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago * kwq/KWQRenderTreeDebug.cpp: (write): Fix clip rectangle computation.
darin [Thu, 4 Sep 2003 20:31:47 +0000 (20:31 +0000)]
    * kwq/KWQRenderTreeDebug.cpp: (write): Fix clip rectangle computation.
        * layout-tests: Update test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago * Plugins.subproj/WebBaseNetscapePluginView.m:
cblu [Thu, 4 Sep 2003 18:29:54 +0000 (18:29 +0000)]
    * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView postURL:target:len:buf:file:]): Fixed typo in newly added comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fixed: <rdar://problem/3407328>: request headers at the start of the file passed...
cblu [Thu, 4 Sep 2003 18:08:42 +0000 (18:08 +0000)]
Fixed: <rdar://problem/3407328>: request headers at the start of the file passed to NPN_PostURL don't work for Acrobat plug-in?

        Reviewed by john.

        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView postURL:target:len:buf:file:]): As documented, allow headers to be specified via NPP_PostURL when using a file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agotree is open for Safari-98
vicki [Thu, 4 Sep 2003 00:16:27 +0000 (00:16 +0000)]
tree is open for Safari-98

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoSafari-97 stamp
vicki [Wed, 3 Sep 2003 23:56:13 +0000 (23:56 +0000)]
Safari-97 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Darin.
mjs [Wed, 3 Sep 2003 21:10:38 +0000 (21:10 +0000)]
    Reviewed by Darin.

        * khtml/khtml_part.cpp:
(KHTMLPart::clear): Un-ifdef cleanup of frames, and add similar
cleanup for objects. Replace delete with deref.
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::createPart): Add an extra ref to KHTMLParts since
both the bridge and the parent part want to deref.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago - fixed 3406411 -- infoseek.co.jp: many console errors about
sullivan [Wed, 3 Sep 2003 21:01:58 +0000 (21:01 +0000)]
- fixed 3406411 -- infoseek.co.jp: many console errors about
attempting to set non-screen font (HiraMinPro-W3)

        Reviewed by Ken

        * WebCoreSupport.subproj/WebTextRenderer.m:
use ERROR instead of NSLog for the printing-font-used-on-screen
case, so it doesn't flood the world's console logs. We need to
investigate why this is happening also, but that can probably
be post-Panther.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fix for 3404398, leak in residual style code. The code that built up the
hyatt [Wed, 3 Sep 2003 20:43:34 +0000 (20:43 +0000)]
Fix for 3404398, leak in residual style code.  The code that built up the
residualStyleStack was messed up and discarded tags.

        Reviewed by mjs

        * khtml/html/htmlparser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Darin
kocienda [Tue, 2 Sep 2003 22:54:54 +0000 (22:54 +0000)]
    Reviewed by Darin

Fix for this bug:

<rdar://problem/3399169>: 4 leaks of DOMString objects (Mail)

Remove circular reference between AttributeImpl and AttrImpl objects.
This was causing the leak.

        * khtml/xml/dom_elementimpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fix for 3359408, DirWS should not be used when collapsing/stripping spaces,
hyatt [Tue, 2 Sep 2003 22:28:26 +0000 (22:28 +0000)]
Fix for 3359408, DirWS should not be used when collapsing/stripping spaces,
since only ASCII spaces are supposed to be collapsed/stripped.

        Reviewed by mjs

        * khtml/rendering/bidi.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by John.
darin [Tue, 2 Sep 2003 21:59:00 +0000 (21:59 +0000)]
    Reviewed by John.

        - fixed 3403388 -- decoder mishandles pages which fill the decoding buffer (mainly ISO-2022-JP)

        * kwq/KWQTextCodec.mm: (KWQTextDecoder::convertUsingTEC): Keep decoding, passing in no additional bytes,
        until we get noErr, don't ever stop after a kTECOutputBufferFullStatus error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fix for 3404452, paint errors on mezzoblue.com's links list. There was a simple
hyatt [Tue, 2 Sep 2003 20:52:13 +0000 (20:52 +0000)]
Fix for 3404452, paint errors on mezzoblue.com's links list.  There was a simple
math error in the invalidation rect computation.

        Reviewed by mjs

        * khtml/rendering/render_flow.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoWebCore:
sullivan [Tue, 2 Sep 2003 01:52:49 +0000 (01:52 +0000)]

- WebCore part of fix for 3402489 -- REGRESSION (7B48-7B55): Some
printed web pages are too small (width is half a page)

This was a regression caused by the fix for 3378810.

        Reviewed by Maciej

        * kwq/WebCoreBridge.h:
add adjustingViewSize flag to forceLayout and forceLayoutForPageWidth:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge forceLayoutAdjustingViewSize:]):
respect new flag while we are set up for printing.
        (-[WebCoreBridge forceLayoutForPageWidth:adjustingViewSize:]):
        (-[WebCoreBridge adjustFrames:]):
pass NO for new flag here


- WebKit part of fix for 3402489 -- REGRESSION (7B48-7B55): Some  printed web pages are too small (width is half a page)

This was a regression caused by the fix for 3378810.

        Reviewed by Maciej

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView layoutToPageWidth:adjustingViewSize:]):
now takes adjustViewSize flag, and passes it down to
one of bridge's forceLayout calls.
        (-[WebHTMLView layout]):
pass NO for adjustViewSize flag in this case
        (-[WebHTMLView _setPrinting:pageWidth:adjustViewSize:]):
pass adjustViewSize flag down to layoutToPageWidth instead
of using it directly here; this is the wrong level to use
it directly since the bridge is no longer set up for
printing after the layoutToPageWidth call completes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by John.
mjs [Mon, 1 Sep 2003 23:46:24 +0000 (23:46 +0000)]
    Reviewed by John.

- fixed 3401709 - [WebView searchFor:] with wrap:NO hangs if the search fails

        * WebView.subproj/WebView.m:
        (-[WebView searchFor:direction:caseSensitive:wrap:]): Fix for
wrap:NO case as suggested by Darin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago * kwq/KWQPainter.mm:
sullivan [Mon, 1 Sep 2003 17:59:44 +0000 (17:59 +0000)]
    * kwq/KWQPainter.mm:
Removed the ERROR that warns of the CG memory trashing bug, now
that we are enough builds away from it that it is (almost?) never
reported anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agotree is open for Safari-97!
vicki [Sat, 30 Aug 2003 03:45:59 +0000 (03:45 +0000)]
tree is open for Safari-97!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoSafari-96 stamp
vicki [Fri, 29 Aug 2003 23:54:40 +0000 (23:54 +0000)]
Safari-96 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Ken.
mjs [Fri, 29 Aug 2003 22:04:02 +0000 (22:04 +0000)]
    Reviewed by Ken.

- fixed 3397775 21 leaks from CSS parser running PLT

        * khtml/css/css_ruleimpl.cpp:
        (CSSMediaRuleImpl::~CSSMediaRuleImpl): Clear the parent for all contained
        (CSSMediaRuleImpl::append): Call insertRule.
        (CSSMediaRuleImpl::insertRule): set parent of the rule to this media rule.
        (CSSRuleListImpl::append): Call insertRule to cover all the relevant
additional handling, instead of adding straight to the list.
        * khtml/css/css_ruleimpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fixed 3401334. Use IB document key when checking for reference removal on instances...
rjw [Fri, 29 Aug 2003 22:02:24 +0000 (22:02 +0000)]
Fixed 3401334.  Use IB document key when checking for reference removal on instances of WebPreferences.

Also removed _userDefaultsKeysForIB, no longer needed by IB.

        Reviewed by John.

        * WebView.subproj/WebPreferences.m:
        (+[WebPreferences _removeReferenceForIdentifier:]):
        (-[WebPreferences _postPreferencesChangesNotification]):
        * WebView.subproj/WebPreferencesPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fixed 3400807. Don't release state associated with the current b/f item. We should...
rjw [Fri, 29 Aug 2003 21:52:59 +0000 (21:52 +0000)]
Fixed 3400807.  Don't release state associated with the current b/f item.  We shouldn't normally have page cache state associated with the current item (3401376).  This fix guarantees that we won't prematurely release the page cache state for the current item.

        Reviewed byJohn Sullivan.

        * History.subproj/WebBackForwardList.m:
        (-[WebBackForwardList _clearPageCache]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago - fixed 3399880 -- Repro crash when filling out a form to
sullivan [Fri, 29 Aug 2003 20:18:11 +0000 (20:18 +0000)]
- fixed 3399880 -- Repro crash when filling out a form to
download Macromedia software

        Reviewed by Chris

        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge elementForView:]):
check for nil widget before dereferencing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fixed 3399736. Fixed several problems with WebView/WebPreferences
rjw [Thu, 28 Aug 2003 23:17:07 +0000 (23:17 +0000)]
Fixed 3399736.  Fixed several problems with WebView/WebPreferences

        Reviewed by Eric Seymour.

        * Misc.subproj/WebKitLogging.h:
        * Misc.subproj/WebKitLogging.m:
Added debug logging.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (_drawGlyphs): Checkin for 3398229 below.

        * WebView.subproj/WebPreferences.m:
        (-[WebPreferences initWithIdentifier:]):
        (-[WebPreferences initWithCoder:]):
        (-[WebPreferences encodeWithCoder:]):
        (+[WebPreferences standardPreferences]):
        (+[WebPreferences _getInstanceForIdentifier:]):
        (+[WebPreferences _setInstance:forIdentifier:]):
        (+[WebPreferences _concatenateKeyWithIBCreatorID:]):
        * WebView.subproj/WebView.m:
        (-[WebView _commonInitializationWithFrameName:groupName:]):
        (-[WebView initWithCoder:]):
        (-[WebView encodeWithCoder:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fix for 3381377, fix the calcBlockMinMaxWidth function to not use the
hyatt [Thu, 28 Aug 2003 21:24:07 +0000 (21:24 +0000)]
Fix for 3381377, fix the calcBlockMinMaxWidth function to not use the
renderobject's computed margins except when it has to.  This makes
table cells with align=right not mess up and fixes margin problems
in general with floated elements and table cells.

Since XUL boxes also use a similar function and since it had a similar
error, vertical XUL boxes have been patched as well.

        Reviewed by gramps

        * khtml/rendering/render_block.cpp:
        * khtml/rendering/render_flexbox.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fix for 3398463, a regression caused by an unintended line movement.
hyatt [Thu, 28 Aug 2003 08:14:20 +0000 (08:14 +0000)]
Fix for 3398463, a regression caused by an unintended line movement.
<br/> was no longer being treated just like <br> in HTML.

        Reviewed by gramps

        * khtml/html/htmltokenizer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fixed 3398229. When we request a font from NSFont by name we should use a case...
rjw [Thu, 28 Aug 2003 03:45:02 +0000 (03:45 +0000)]
Fixed 3398229.  When we request a font from NSFont by name we should use a case specific name.  We do case insensitve comparsion, but once a match is found we should use the actual font name, not the requested name.  Two layout tests are still failing, but I don't think the failures are font related.

        Reviewed by Hyatt.

        * WebCoreSupport.subproj/WebTextRendererFactory.m:
        (-[WebTextRendererFactory fontWithFamily:traits:size:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by John
mjs [Thu, 28 Aug 2003 02:50:55 +0000 (02:50 +0000)]
    Reviewed by John

- fixed rdar://problem/3397316 - sherlock crash: KJS::Collector::allocate(unsigned long)

* kjs/internal.cpp:
        (InterpreterImp::InterpreterImp): Hold the lock a bit longer, so
the call to initGlobalObject is covered.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agotree is open for Safari-96!
vicki [Thu, 28 Aug 2003 01:06:20 +0000 (01:06 +0000)]
tree is open for Safari-96!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agotop level:
vicki [Thu, 28 Aug 2003 00:35:37 +0000 (00:35 +0000)]
top level:

        Reviewed by Chris.

        * acconfig.h: Removed. The new autoconf in Panther doesn't need it.
        * configure.in: Removed HAVE_S_ISSOCK code; none of our code needs
        this define and it upsets the new autoconf if we leave out acconfig.h.


        * Scripts/create-tarball: Leave out anything with "apple-only" in the path.
        * Scripts/run-layout-tests: Print out whether each test succeeded or failed after it runs.


        Reviewed by John.

        - fixed 3098350 -- opt. params to date methods are ignored (can't set end date in Exchange/Outlook web cal.)

        * kjs/date_object.cpp: (DateProtoFuncImp::call): Added code to handle the optional parameters.
        Strangely, the table of functions already had the right number of parameters listed, but the
        code to look at the parameter values was missing.


        * PDFViewer/ApplicationController.m: Added missing include.
        * PDFViewer/PDFRepresentation.m: (-[PDFView layout]): Change to use
        the frame of the WebFrameView instead of the frame of the NSScrollView
        since there's noAPI to get the scroll view any more.


Fixed 3359408.  DON'T treat unicode whitespace as whitespace when collapsing spaces.

        Reviewed by David Hyatt.

        * khtml/rendering/bidi.cpp:
        * khtml/rendering/render_text.cpp:
        * khtml/xml/dom_stringimpl.cpp:


Fixed 3397235.  WebView wasn't archiving useBackForwardList.

        Reviewed by Eric Seymour.

        * WebView.subproj/WebView.m:
        (-[WebView initWithCoder:]):
        (-[WebView encodeWithCoder:]):


        Reviewed by John.

        - fixed 3390306 -- REGRESSION (Panther): Safari browser window titles not available via Accessibility APIs

        * BrowserWindow.m: (-[BrowserWindow accessibilityTitleAttribute]): Return the title.


        * CarbonDownloader/English.lproj/main.nib: Changed command key equivalent for Close to Cmd-W.
        Since this is example code and not localized, the localization freeze should not be an issue.
        * CarbonDownloader/English.lproj/main~.nib: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fixed 3359408. DON'T treat unicode whitespace as whitespace when collapsing spaces.
rjw [Wed, 27 Aug 2003 22:57:14 +0000 (22:57 +0000)]
Fixed 3359408.  DON'T treat unicode whitespace as whitespace when collapsing spaces.

        Reviewed by David Hyatt.

        * khtml/rendering/bidi.cpp:
        * khtml/rendering/render_text.cpp:
        * khtml/xml/dom_stringimpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fixed 3397235. WebView wasn't archiving useBackForwardList.
rjw [Wed, 27 Aug 2003 22:07:57 +0000 (22:07 +0000)]
Fixed 3397235.  WebView wasn't archiving useBackForwardList.

        Reviewed by Eric Seymour.

        * WebView.subproj/WebView.m:
        (-[WebView initWithCoder:]):
        (-[WebView encodeWithCoder:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoAdd inline fieldset test.
hyatt [Wed, 27 Aug 2003 21:00:20 +0000 (21:00 +0000)]
Add inline fieldset test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fix for 3396962, hang on quote.com. Fieldsets with display:inline should be treated
hyatt [Wed, 27 Aug 2003 20:53:13 +0000 (20:53 +0000)]
Fix for 3396962, hang on quote.com.  Fieldsets with display:inline should be treated
like inline-blocks. This matches WinIE's behavior.

        Reviewed by mjs

        * khtml/rendering/render_form.cpp:
        * khtml/rendering/render_form.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fixed 3385478. Look for an exact match for font names (using PS names) before match...
rjw [Wed, 27 Aug 2003 18:23:48 +0000 (18:23 +0000)]
Fixed 3385478.  Look for an exact match for font names (using PS names) before matching on family names.

Also added logging to help debug now resolved binding problem.

        Reviewed by Maciej.

        * Misc.subproj/WebKitLogging.h:
        * Misc.subproj/WebKitLogging.m:
        * WebCoreSupport.subproj/WebTextRendererFactory.m:
        (-[WebTextRendererFactory fontWithFamily:traits:size:]):
        * WebView.subproj/WebView.m:
        (-[WebView addObserver:forKeyPath:options:context:]):
        (-[WebView removeObserver:forKeyPath:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoWebCore:
darin [Wed, 27 Aug 2003 06:41:12 +0000 (06:41 +0000)]

        Reviewed by Maciej.

        - follow-on to fix for 3310943 -- REGRESSION (Panther): textareas in forms sometimes draw blank (bugreporter)

        * kwq/KWQListBox.mm: (QListBox::QListBox): Remove call to releaseGState. This was here to
        work around a problem we thought was an AppKit bug, but it turns out it was caused by
        NSView hackery in WebKit. We now do the WebKit part in a way that does not create the problem.


        Reviewed by Maciej.

        - fixed 3310943 -- REGRESSION (Panther): textareas in forms sometimes draw blank (bugreporter)

        There are two fixes here. The more elegant and slightly faster one that requires a new AppKit,
        and the less elegant one that works without AppKit support. By including both we don't have to
        worry about timing of submission of WebKit vs. AppKit but we get the good, elegant fix. Later,
        we can delete the less elegant fix.

        * WebView.subproj/WebClipView.m:
        (+[WebClipView initialize]): Set up a boolean global so we only hav to do the "does AppKit support
        _focusRingVisibleRect" check one time.
        (-[WebClipView resetAdditionalClip]): Only do the renewGState thing if we don't have the
        _focusRingVisibleRect method, but if we do the renewGState thing, do it to self and all descendants
        using _web_renewGStateDeep.
        (-[WebClipView setAdditionalClip:]): Ditto.
        (-[WebClipView visibleRect]): Only limit this based on the additional clip if we don't have the
        _focusRingVisibleRect method.
        (-[WebClipView _focusRingVisibleRect]): Override the new method. Harmless if it's an old AppKit
        that doesn't have the method yet.
        (-[NSView _web_renewGStateDeep]): Implemented this helper method. We can get rid of it once we
        are entirely on the new AppKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Maciej.
darin [Wed, 27 Aug 2003 05:47:43 +0000 (05:47 +0000)]
    Reviewed by Maciej.

        - fixed 3031562 -- most forms don't work in certain configurations because of a bug in KWQVariant

        * kwq/KWQVariant.mm: (QVariant::QVariant): Set the b element of the union, not the d element,
        in the constructor for bool.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoAdd a test for floats/clearing/margin-collapsing under the new system
hyatt [Wed, 27 Aug 2003 01:23:04 +0000 (01:23 +0000)]
Add a test for floats/clearing/margin-collapsing under the new system

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoRemove margin collapsing tests that are now buggy/invalid
hyatt [Wed, 27 Aug 2003 01:15:38 +0000 (01:15 +0000)]
Remove margin collapsing tests that are now buggy/invalid

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fix for 3395950, better support for self-collapsing blocks. Make them obey
hyatt [Wed, 27 Aug 2003 01:09:18 +0000 (01:09 +0000)]
Fix for 3395950, better support for self-collapsing blocks.  Make them obey
clear properly and also change the definition of self-collapsing to match
the CSS2.1 specification.

        Reviewed by gramps

        * khtml/rendering/render_block.cpp:
        * khtml/rendering/render_block.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoAdd a layout test for <script/>
hyatt [Wed, 27 Aug 2003 00:47:09 +0000 (00:47 +0000)]
Add a layout test for <script/>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fix for 3335175, www.calstone.com renders as blank. The fix is to deliberately
hyatt [Wed, 27 Aug 2003 00:46:19 +0000 (00:46 +0000)]
Fix for 3335175, calstone.com renders as blank.  The fix is to deliberately
introduce an error into our HTML parsing code that causes us to honor self-closing
XML-style <script/> tags.  This matches Mozilla and Opera behavior (both of them
have this bug), but it does not match WinIE.

        Reviewed by mjs

        * khtml/html/htmltokenizer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoAdd a display:none test.
hyatt [Tue, 26 Aug 2003 23:57:16 +0000 (23:57 +0000)]
Add a display:none test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years agoCommit an h2/form test case.
hyatt [Tue, 26 Aug 2003 23:44:33 +0000 (23:44 +0000)]
Commit an h2/form test case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Fix for 3286229, popup menu misplaced. <form> needs to be allowed as a child of
hyatt [Tue, 26 Aug 2003 23:43:16 +0000 (23:43 +0000)]
Fix for 3286229, popup menu misplaced.  <form> needs to be allowed as a child of
<h1>-<h6> tags.  All other browsers allow this.

        Reviewed by darin

        * khtml/html/dtd.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Maciej.
darin [Tue, 26 Aug 2003 23:13:37 +0000 (23:13 +0000)]
    Reviewed by Maciej.

        - re-fixed 3366542 -- filename with non-ASCII name left out of Content-Disposition for <input type=file>

        * khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::formData): Added missing # sign.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Maciej.
darin [Tue, 26 Aug 2003 23:09:47 +0000 (23:09 +0000)]
    Reviewed by Maciej.

        - fixed 3321247 -- window size box disappears from Help window (caused by WebKit NSView hackery)

        * WebView.subproj/WebHTMLViewPrivate.m:
        (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]),
        (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
        Don't propagate dirty rects at all. This was causing problems because now the AppKit uses
        dirty regions, not dirty rects. In AppKit-722 and newer, _setDrawsDescendants: takes care of this
        for us so we don't have to do anything at all.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4889 268f45cc-cd09-0410-ab3c-d52691b4dbfc