WebKit-https.git
8 years ago[BlackBerry] User credentials is not correctly handled
commit-queue@webkit.org [Thu, 28 Feb 2013 16:41:59 +0000 (16:41 +0000)]
[BlackBerry] User credentials is not correctly handled
https://bugs.webkit.org/show_bug.cgi?id=110994

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-02-28
Reviewed by Yong Li.

WTF::String::utf8 no longer receives a bool, see r134173.

* platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::encryptedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
kadam@inf.u-szeged.hu [Thu, 28 Feb 2013 15:19:01 +0000 (15:19 +0000)]
[Qt] Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=111058.

* platform/qt/TestExpectations: Skipped failing test after r144236.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Disable auto-filling password in forms when auto-form-filling is not...
liachen@rim.com [Thu, 28 Feb 2013 15:17:07 +0000 (15:17 +0000)]
[BlackBerry] Disable auto-filling password in forms when auto-form-filling is not enabled.
https://bugs.webkit.org/show_bug.cgi?id=111006

Internal PR: 295181
Internal reviewed by Joe Mason.

Reviewed by Yong Li.

Check WebSettings::isFormAutofillEnabled() before doing user credential form fill stuff.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] User credentials are not correctly handled for non-browser usage
liachen@rim.com [Thu, 28 Feb 2013 15:14:37 +0000 (15:14 +0000)]
[BlackBerry] User credentials are not correctly handled for non-browser usage
https://bugs.webkit.org/show_bug.cgi?id=111032

Internal PR: 295181
Internal reviewed by Joe Mason.

Reviewed by Yong Li.

Use encrypted password as binary data when calling SQLiteStatement::bindBlob(), in
stead of using it as a normal WTF::String.

No new tests as this causes no expected behaviour change.

* platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::addLogin):
(WebCore::CredentialBackingStore::updateLogin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Enable thin archives before parsing the project files
abecsi@webkit.org [Thu, 28 Feb 2013 15:03:06 +0000 (15:03 +0000)]
[Qt] Enable thin archives before parsing the project files

Rubber-stamped by Simon Hausmann.

The targetSubDir() function can be called before default_post.prf has been
parsed therefore the gnu_thin_archives option has to be set in default_pre.prf
which is parsed before the main project file.
This issue was revealed by r144299 and fixes the clean build.

* qmake/mkspecs/features/default_post.prf:
* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: "loadScript" function to load scripts via xhr
commit-queue@webkit.org [Thu, 28 Feb 2013 14:53:35 +0000 (14:53 +0000)]
Web Inspector: "loadScript" function to load scripts via xhr
https://bugs.webkit.org/show_bug.cgi?id=110879

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-28
Reviewed by Pavel Feldman.

Create an alias for "importScript" function and use it in those cases
which assume lazy script loading.

No new tests.

* inspector/front-end/Panel.js:
(WebInspector.PanelDescriptor.prototype.panel):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Move profiler tools into separate panels
commit-queue@webkit.org [Thu, 28 Feb 2013 14:43:48 +0000 (14:43 +0000)]
Web Inspector: Move profiler tools into separate panels
https://bugs.webkit.org/show_bug.cgi?id=109832

Patch by Alexei Filippov <alph@chromium.org> on 2013-02-28
Reviewed by Yury Semikhatsky.

This is a first part of the fix that puts each profiler tool into a separate panel.
The fix introduces separate panels for each profiler type.
There are now six panel (including experimental):
  1. JS CPU profiler
  2. CSS Selector profiler
  3. JS Heap profiler
  4. Canvas profier
  5. Native memory snapshots
  6. Native memory distribution
The new functionality is put behind experimental flag.

* inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView):
(WebInspector.ProfileLauncherView.prototype.addProfileType):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileHeader.prototype.view):
(WebInspector.ProfileHeader.prototype.createView):
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):
(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
(WebInspector.ProfilesPanel.prototype._showProfile):
(WebInspector.ProfilesPanel.prototype._searchableViews):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):
(WebInspector.ProfileGroupSidebarTreeElement):
(WebInspector.ProfileGroupSidebarTreeElement.prototype.onselect):
(WebInspector.CPUProfilerPanel):
(WebInspector.CSSSelectorProfilerPanel):
(WebInspector.HeapProfilerPanel):
(WebInspector.CanvasProfilerPanel):
(WebInspector.MemoryChartProfilerPanel):
(WebInspector.NativeMemoryProfilerPanel):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/inspector.css:
(.toolbar-item.cpu-profiler .toolbar-icon):
(.toolbar-item.css-profiler .toolbar-icon):
(.toolbar-item.heap-profiler .toolbar-icon):
(.toolbar-item.canvas-profiler .toolbar-icon):
(.toolbar-item.memory-chart-profiler .toolbar-icon):
(.toolbar-item.memory-snapshot-profiler .toolbar-icon):
* inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRenderTableCellDeathTest unit test fails on mac
schenney@chromium.org [Thu, 28 Feb 2013 14:34:17 +0000 (14:34 +0000)]
RenderTableCellDeathTest unit test fails on mac
https://bugs.webkit.org/show_bug.cgi?id=110992

Unreviewed revert of all changes. The problem seems to have resolved.

* tests/RenderTableCellTest.cpp: Remove Mac disable code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, update expectation
schenney@chromium.org [Thu, 28 Feb 2013 14:22:04 +0000 (14:22 +0000)]
Unreviewed gardening, update expectation

* platform/chromium/TestExpectations: Add ImageOnlyFailure for compositing/rtl/rtl-iframe-fixed-overflow.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, quick test breakage fix for android
toyoshim@chromium.org [Thu, 28 Feb 2013 14:16:35 +0000 (14:16 +0000)]
Unreviewed, quick test breakage fix for android
https://bugs.webkit.org/show_bug.cgi?id=110740

Patch by Seigo Nonaka <nona@chromium.org> on 2013-02-27

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputInfo): Reconstruct condition check order

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Enable CANVAS_PATH flag
allan.jensen@digia.com [Thu, 28 Feb 2013 13:57:42 +0000 (13:57 +0000)]
[Qt] Enable CANVAS_PATH flag
https://bugs.webkit.org/show_bug.cgi?id=108508

Reviewed by Simon Hausmann.

Tools:

Also enable CANVAS_PATH flag for Qt.

* qmake/mkspecs/features/features.pri:

LayoutTests:

Unskip CANVAS_PATH tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][TestWebKitAPI] The activeBuildConfig() function has been replaced with targetSub...
abecsi@webkit.org [Thu, 28 Feb 2013 13:41:13 +0000 (13:41 +0000)]
[Qt][TestWebKitAPI] The activeBuildConfig() function has been replaced with targetSubDir()

Rubber-stamped by Csaba Osztrogonác.

Besides suppressing a warning about the non-existing function this
fixes the build if there is a subdirectory (eg. debug-and-release).

* TestWebKitAPI/InjectedBundle.pri:
* TestWebKitAPI/TestWebKitAPI.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd calendar header for new calendar picker
keishi@webkit.org [Thu, 28 Feb 2013 13:05:56 +0000 (13:05 +0000)]
Add calendar header for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110967

Reviewed by Kent Tamura.

The calendar header showing the current month and containing navigation
buttons, which will be part of the new calendar picker (Bug 109439).

No new tests. Code is not yet used.

* Resources/pagepopups/calendarPicker.js:
(MonthPopupButton): Button that opens the month popup.
(MonthPopupButton.prototype._shouldUseShortMonth): Returns true if we should use the short month format in order to fit in the available width.
(MonthPopupButton.prototype.setCurrentMonth): Sets the month to the button label.
(MonthPopupButton.prototype.onClick): Dispatches buttonClick event which will tell the calendar picker to open the month popup.
(CalendarNavigationButton): A square button that fires repeatedly while the mouse is pressed down.
(CalendarNavigationButton.prototype.setDisabled):
(CalendarNavigationButton.prototype.onClick):
(CalendarNavigationButton.prototype.onMouseDown): Sets the timer to fire while the mouse is pressed down.
(CalendarNavigationButton.prototype.onWindowMouseUp):
(CalendarNavigationButton.prototype.onRepeatingClick):
(CalendarHeaderView): View containing month popup button and the navigation buttons.
(CalendarHeaderView.prototype.onCurrentMonthChanged): Sets the MonthPopupButton label and checks if the navigation buttons should be disabled.
(CalendarHeaderView.prototype.onNavigationButtonClick):
(CalendarHeaderView.prototype.setDisabled): Used to disable all the buttons while the month popup is open.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled Chromium DEPS to r184931. Requested by
commit-queue@webkit.org [Thu, 28 Feb 2013 12:55:13 +0000 (12:55 +0000)]
Unreviewed.  Rolled Chromium DEPS to r184931.  Requested by
"Takashi Toyoshima" <toyoshim@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-28

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
kadam@inf.u-szeged.hu [Thu, 28 Feb 2013 12:33:07 +0000 (12:33 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/TestExpectations: Skipped failing test after r144265.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: class console-formatted-string renamed to console-formatted- ?
pfeldman@chromium.org [Thu, 28 Feb 2013 12:28:19 +0000 (12:28 +0000)]
Web Inspector: class console-formatted-string renamed to console-formatted- ?
https://bugs.webkit.org/show_bug.cgi?id=110881

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._renderPropertyPreview):

LayoutTests:

* http/tests/inspector/console-test.js:
(initialize_ConsoleTest.InspectorTest.dumpConsoleMessages):
* inspector/console/console-object-preview-expected.txt:
* inspector/console/console-object-preview.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WTR] WTR cannot load injected bundle
mikhail.pozdnyakov@intel.com [Thu, 28 Feb 2013 12:28:00 +0000 (12:28 +0000)]
[EFL][WTR] WTR cannot load injected bundle
https://bugs.webkit.org/show_bug.cgi?id=111063

Reviewed by Csaba Osztrogonác.

WTR was not able to load injected bundle because of undefined
symbols for AccessibilityUIElement::scrollToMakeVisible().
Adding empty implementation of this function to AccessibilityUIElementAtk.cpp
solves the problem.

* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::scrollToMakeVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, update expectation
toyoshim@chromium.org [Thu, 28 Feb 2013 12:26:30 +0000 (12:26 +0000)]
Unreviewed gardening, update expectation

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoXSSAuditor should strip formaction attributes from input and button elements.
mkwst@chromium.org [Thu, 28 Feb 2013 12:22:11 +0000 (12:22 +0000)]
XSSAuditor should strip formaction attributes from input and button elements.
https://bugs.webkit.org/show_bug.cgi?id=110975

Reviewed by Daniel Bates.

Source/WebCore:

The 'formaction' attribute of 'input' and 'button' elements is just as
dangerous as the 'action' attribute of 'form' elements. This patch
teaches the XSSAuditor how to avoid them.

Tests: http/tests/security/xssAuditor/formaction-on-button.html
       http/tests/security/xssAuditor/formaction-on-input.html

* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterStartToken):
(WebCore::XSSAuditor::filterInputToken): Added.
(WebCore::XSSAuditor::filterButtonToken): Added.
* html/parser/XSSAuditor.h:
    Create filters for 'input' and 'button' elements, which currently
    only have the effect of filtering the 'formaction' attribute.

LayoutTests:

* http/tests/security/xssAuditor/formaction-on-button-expected.txt: Added.
* http/tests/security/xssAuditor/formaction-on-button.html: Added.
* http/tests/security/xssAuditor/formaction-on-input-expected.txt: Added.
* http/tests/security/xssAuditor/formaction-on-input.html: Added.
* http/tests/security/xssAuditor/resources/echo-intertag.pl:
    Support 'showFormaction' as a new option to write out formaction values.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, clean up expectations to remove lint errors #1.
toyoshim@chromium.org [Thu, 28 Feb 2013 12:08:53 +0000 (12:08 +0000)]
Unreviewed gardening, clean up expectations to remove lint errors #1.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r144169): It broke clipping
allan.jensen@digia.com [Thu, 28 Feb 2013 11:58:37 +0000 (11:58 +0000)]
REGRESSION(r144169): It broke clipping
https://bugs.webkit.org/show_bug.cgi?id=111065

Reviewed by Noam Rosenthal.

The clipstack was not marked dirty when new clips were added
leading to clipping never being applied.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::ClipStack::push):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOpenCL implementation of FEImage SVG Filter.
commit-queue@webkit.org [Thu, 28 Feb 2013 11:50:31 +0000 (11:50 +0000)]
OpenCL implementation of FEImage SVG Filter.
https://bugs.webkit.org/show_bug.cgi?id=110752

Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2013-02-28
Reviewed by Zoltan Herczeg.

The result of the image is uploaded to an OpenCL buffer.

* Target.pri:
* platform/graphics/gpu/opencl/OpenCLFEImage.cpp: Added.
(WebCore):
(WebCore::FEImage::platformApplyOpenCL):
* svg/graphics/filters/SVGFEImage.h:
(FEImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Make it obvious where command line functions come from
mkwst@chromium.org [Thu, 28 Feb 2013 11:35:47 +0000 (11:35 +0000)]
Web Inspector: Make it obvious where command line functions come from
https://bugs.webkit.org/show_bug.cgi?id=62367

Reviewed by Pavel Feldman.

Source/WebCore:

This patch adds a custom .toString() method on the various command-line
API methods that are bound in the inspector. Rather than dumping the
function text, we now model the response after that of native methods:
"function __() { [Command Line API] }".

Test: inspector/console/console-native-function-to-string.html

* inspector/InjectedScriptSource.js:
    Added a function to the CommandLineAPI constructor that creates a
    custom toString() method for each command-line API method.

LayoutTests:

* inspector/console/console-native-function-to-string-expected.txt: Added.
* inspector/console/console-native-function-to-string.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviwed gardening. Skip test that made to crash other test.
zarvai@inf.u-szeged.hu [Thu, 28 Feb 2013 11:15:47 +0000 (11:15 +0000)]
[Qt] Unreviwed gardening. Skip test that made to crash other test.

* platform/qt-5.0-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, update test expectation
toyoshim@chromium.org [Thu, 28 Feb 2013 11:06:37 +0000 (11:06 +0000)]
Unreviewed gardening, update test expectation

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, gardening.
toyoshim@chromium.org [Thu, 28 Feb 2013 10:47:17 +0000 (10:47 +0000)]
Unreviewed, gardening.
https://bugs.webkit.org/show_bug.cgi?id=111062

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 28 Feb 2013 10:35:57 +0000 (10:35 +0000)]
Unreviewed GTK gardening.

Generating missing baselines for an octet of media tests and removing related expectations.

* platform/gtk/TestExpectations: Also removing expectation for
fast/multicol/newmulticol/column-rules-fixed-height.html, the test is now passing.
* platform/gtk/media/audio-controls-rendering-expected.png: Added.
* platform/gtk/media/audio-controls-rendering-expected.txt: Added.
* platform/gtk/media/controls-after-reload-expected.png: Added.
* platform/gtk/media/controls-after-reload-expected.txt:
* platform/gtk/media/controls-strict-expected.png: Added.
* platform/gtk/media/controls-strict-expected.txt:
* platform/gtk/media/controls-styling-strict-expected.txt:
* platform/gtk/media/controls-without-preload-expected.png: Added.
* platform/gtk/media/controls-without-preload-expected.txt:
* platform/gtk/media/video-controls-rendering-expected.png:
* platform/gtk/media/video-controls-rendering-expected.txt:
* platform/gtk/media/video-display-toggle-expected.png: Added.
* platform/gtk/media/video-display-toggle-expected.txt:
* platform/gtk/media/video-playing-and-pause-expected.png: Added.
* platform/gtk/media/video-playing-and-pause-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 28 Feb 2013 10:15:00 +0000 (10:15 +0000)]
Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Adding failure expectations for tests added in r144236 and r144258.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCleanup: XSSAuditor's form[action] tests should be manually executable.
mkwst@chromium.org [Thu, 28 Feb 2013 10:07:25 +0000 (10:07 +0000)]
Cleanup: XSSAuditor's form[action] tests should be manually executable.
https://bugs.webkit.org/show_bug.cgi?id=111049

Reviewed by Daniel Bates.

We currently check whether we're running in a DRT-like world before
creating user-visible output for XSSAuditor's form[action] tests. This
patch removes that restriction in order to allow manually-run tests
to show some reasonable output.

* http/tests/security/xssAuditor/resources/echo-intertag.pl:
    Drop the 'if (window.testRunner)' from the 'showAction' branch in
    order to allow manually running the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening
toyoshim@chromium.org [Thu, 28 Feb 2013 09:49:26 +0000 (09:49 +0000)]
Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=111054

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Skipped failing ref html tests.
kadam@inf.u-szeged.hu [Thu, 28 Feb 2013 09:41:51 +0000 (09:41 +0000)]
[Qt] Unreviewed gardening. Skipped failing ref html tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][Mac] Fix massive parallel builds
hausmann@webkit.org [Thu, 28 Feb 2013 09:39:34 +0000 (09:39 +0000)]
[Qt][Mac] Fix massive parallel builds

Reviewed by Tor Arne Vestbø.

There exists a race condition that LLIntDesiredOffsets.h is written to
by two parllel instances of the ruby script. This patch ensures that similar to the output file,
the generated file is also prefixed according to the build configuration.

* LLIntOffsetsExtractor.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoResourceRequestCFNet.cpp won't compile after r144216
ddkilzer@apple.com [Thu, 28 Feb 2013 09:39:22 +0000 (09:39 +0000)]
ResourceRequestCFNet.cpp won't compile after r144216
<http://webkit.org/b/111034>

Reviewed by Alexey Proskuryakov.

* WebCore.exp.in: Move Mac-only symbol into !PLATFORM(IOS)
section.  Update iOS-only symbol to add argument.
* platform/network/cf/ResourceRequest.h: Remove unused method
declaration.
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody): Fix typos.
Add static_cast<CFStringRef>().
(WebCore::ResourceRequest::doUpdateResourceHTTPBody): Fix another
typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a failing test expectation to navigation-should-abort.html on Mac WebKit1.
rniwa@webkit.org [Thu, 28 Feb 2013 09:33:06 +0000 (09:33 +0000)]
Add a failing test expectation to navigation-should-abort.html on Mac WebKit1.
The failure is tracked by the bug 111052.

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Misc build fixes
commit-queue@webkit.org [Thu, 28 Feb 2013 09:32:00 +0000 (09:32 +0000)]
[BlackBerry] Misc build fixes
https://bugs.webkit.org/show_bug.cgi?id=110448

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-28
Reviewed by Rob Buis.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
WebString was replaced with BlackBerry::Platform::String in r131316.
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
Some webdatabase APIs are encapuslated in DatabaseManager since r137520.
(BlackBerry::WebKit::WebPagePrivate::postponeDocumentStyleRecalc):
Document::isPendingStyleRecalc() was renamed to hasPendingStyleRecalc() in r129844.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::updateFormState):
Add closing brace that was missing in r142482.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] TestRunnerBlackBerry: remove layerTreeAsText, it's gone from upstream
commit-queue@webkit.org [Thu, 28 Feb 2013 09:26:46 +0000 (09:26 +0000)]
[BlackBerry] TestRunnerBlackBerry: remove layerTreeAsText, it's gone from upstream
https://bugs.webkit.org/show_bug.cgi?id=110464

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-28
Reviewed by Rob Buis.

* DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] DumpRenderTreeSupport: update the set position methods
commit-queue@webkit.org [Thu, 28 Feb 2013 09:25:41 +0000 (09:25 +0000)]
[BlackBerry] DumpRenderTreeSupport: update the set position methods
https://bugs.webkit.org/show_bug.cgi?id=110578

Patch by Xan Lopez <xlopez@rim.com> on 2013-02-28
Reviewed by Rob Buis.

TestRunner::setMockGeolocationPosition() changed in r130416:
http://trac.webkit.org/changeset/130416/trunk/Tools/DumpRenderTree/TestRunner.h

Source/WebKit/blackberry:

* WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::setMockGeolocationPosition):
* WebKitSupport/DumpRenderTreeSupport.h:
(DumpRenderTreeSupport):

Tools:

DumpRenderTreeSupport::setMockGeolocationError() was renamed to
setMockGeolocationPositionUnavailableError() in r129444:
http://trac.webkit.org/changeset/129444/trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.h

* DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
(TestRunner::setMockGeolocationPosition):
(TestRunner::setMockGeolocationPositionUnavailableError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] WorkQueueItemBlackBerry: use the new FrameLoader API
commit-queue@webkit.org [Thu, 28 Feb 2013 09:17:51 +0000 (09:17 +0000)]
[BlackBerry] WorkQueueItemBlackBerry: use the new FrameLoader API
https://bugs.webkit.org/show_bug.cgi?id=110465

Patch by Xan Lopez <xlopez@rim.com> on 2013-02-28
Reviewed by Rob Buis.

* DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
(LoadItem::invoke):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoA couple more tweaks to TestExpectations after the threaded parser.
abarth@webkit.org [Thu, 28 Feb 2013 09:12:00 +0000 (09:12 +0000)]
A couple more tweaks to TestExpectations after the threaded parser.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r144184.
tkent@chromium.org [Thu, 28 Feb 2013 08:56:02 +0000 (08:56 +0000)]
Unreviewed, rolling out r144184.
http://trac.webkit.org/changeset/144184
https://bugs.webkit.org/show_bug.cgi?id=110974

The change didn't fix all of the problems.

Source/WebCore:

* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
* html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):

LayoutTests:

* fast/forms/date/date-appearance-basic-expected.txt:
* fast/forms/date/date-appearance-basic.html:
* platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, mark two tests as slow.
toyoshim@chromium.org [Thu, 28 Feb 2013 08:42:01 +0000 (08:42 +0000)]
Unreviewed gardening, mark two tests as slow.
https://bugs.webkit.org/show_bug.cgi?id=111038
https://bugs.webkit.org/show_bug.cgi?id=111046

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoApparently Failure does not include ImageOnlyFailure.
abarth@webkit.org [Thu, 28 Feb 2013 08:18:52 +0000 (08:18 +0000)]
Apparently Failure does not include ImageOnlyFailure.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
abarth@webkit.org [Thu, 28 Feb 2013 08:07:26 +0000 (08:07 +0000)]
Unreviewed.

The version of this file I landed in
http://trac.webkit.org/changeset/144262 appears to have been
ever-so-slightly incorrect.

* platform/chromium/inspector/timeline/timeline-script-tag-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPerfTestRunner doesn't need _needs_http and _has_http_lock
rniwa@webkit.org [Thu, 28 Feb 2013 07:57:29 +0000 (07:57 +0000)]
PerfTestRunner doesn't need _needs_http and _has_http_lock
https://bugs.webkit.org/show_bug.cgi?id=111037

Reviewed by Adam Barth.

Delete these variables in favor of using a local variable.

Member variables are like global variables. They introduce implicit dependencies
between member functions.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.__init__):
(PerfTestsRunner._start_http_servers):
(PerfTestsRunner):
(PerfTestsRunner._stop_http_servers):
(PerfTestsRunner.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r144224.
commit-queue@webkit.org [Thu, 28 Feb 2013 07:55:58 +0000 (07:55 +0000)]
Unreviewed, rolling out r144224.
http://trac.webkit.org/changeset/144224
https://bugs.webkit.org/show_bug.cgi?id=111045

Caused plugins/pass-different-npp-struct.html to time out
(Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-27

Tools:

* DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
(PassDifferentNPPStruct::NPP_SetWindow):
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_SetWindow):

LayoutTests:

* platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt: Added.
* plugins/netscape-plugin-setwindow-size-2.html:
* plugins/netscape-plugin-setwindow-size.html:
* plugins/pass-different-npp-struct.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Protocol] Genarate JS enum definitions.
eustas@chromium.org [Thu, 28 Feb 2013 07:50:22 +0000 (07:50 +0000)]
Web Inspector: [Protocol] Genarate JS enum definitions.
https://bugs.webkit.org/show_bug.cgi?id=110461

Reviewed by Pavel Feldman.

Generating corresponding type annotations
would help to compiler to point errors.

* inspector/CodeGeneratorInspector.py: Generate "registerEnum" records.
* inspector/InjectedScriptSource.js: Shadow compiler warning.
* inspector/front-end/InspectorBackend.js:
Added "registerEnum". Added "registerEnum" generation.
* inspector/front-end/NetworkManager.js: Use enum instead of literal.
* inspector/generate_protocol_externs.py: Generate enum typedefs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
abarth@webkit.org [Thu, 28 Feb 2013 07:44:46 +0000 (07:44 +0000)]
Unreviewed.

Update some test expectations based on the threaded parser behavior.
These look like test integration issues rather than actual bugs in the
parser. We will investigate them offline.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoINPUT_MULTIPLE_FIELDS_UI: Step-up/-down of hour field should respect min/max attributes
commit-queue@webkit.org [Thu, 28 Feb 2013 06:44:41 +0000 (06:44 +0000)]
INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of hour field should respect min/max attributes
https://bugs.webkit.org/show_bug.cgi?id=109555

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-02-27
Reviewed by Kent Tamura.

Source/WebCore:

Make step-up/-down of the hour field respect the min/max attributes of the element.
Note that it still accepts any keyboard inputs (the element
becomes 'invalid' state when out-of-range values entered).
Also, disable the hour field and/or the AMPM field when there is only single possible value.

Test: fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html
      fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-stepup-stepdown-from-renderer.html
      fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html
      fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html

* html/TimeInputType.cpp:
(WebCore::TimeInputType::setupLayoutParameters): Populates layoutParameters.{minimum,maximum}.
* html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder): Add data fields for min/max of day and hour fields.
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder): Set newly added data members.
(WebCore::DateTimeEditBuilder::visitField): Pass minimum/maximum value to the month field constructors.
(WebCore::DateTimeEditBuilder::shouldAMPMFieldDisabled): Added.
(WebCore::DateTimeEditBuilder::shouldDayOfMonthFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldHourFieldDisabled):
Disables the hour field when min, max, and value have the same hour, except when the minute
field is disabled (by step attribute), because we need to leave at least one field editable.
* html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeHourFieldElementBase::DateTimeHourFieldElementBase):
(WebCore::DateTimeHourFieldElementBase::initialize):
(WebCore::DateTimeHourFieldElementBase::setValueAsDate):
(WebCore::DateTimeHourFieldElementBase::setValueAsDateTimeFieldsState):
(WebCore::DateTimeHour11FieldElement::DateTimeHour11FieldElement):
(WebCore::DateTimeHour11FieldElement::create):
(WebCore::DateTimeHour11FieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeHour11FieldElement::setValueAsInteger):
(WebCore::DateTimeHour11FieldElement::clampValueForHardLimits):
(WebCore::DateTimeHour12FieldElement::DateTimeHour12FieldElement):
(WebCore::DateTimeHour12FieldElement::create):
(WebCore::DateTimeHour12FieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeHour12FieldElement::setValueAsInteger):
(WebCore::DateTimeHour12FieldElement::clampValueForHardLimits):
(WebCore::DateTimeHour23FieldElement::DateTimeHour23FieldElement):
(WebCore::DateTimeHour23FieldElement::create):
(WebCore::DateTimeHour23FieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeHour23FieldElement::setValueAsInteger):
(WebCore::DateTimeHour23FieldElement::clampValueForHardLimits):
(WebCore::DateTimeHour24FieldElement::DateTimeHour24FieldElement):
(WebCore::DateTimeHour24FieldElement::create):
(WebCore::DateTimeHour24FieldElement::populateDateTimeFieldsState):
(WebCore::DateTimeHour24FieldElement::setValueAsInteger):
(WebCore::DateTimeHour24FieldElement::clampValueForHardLimits):
* html/shadow/DateTimeFieldElements.h: Splitted DateTimeHourFieldElement into a base class and four derived classes that represents different hour formats.
(DateTimeHourFieldElementBase): Added.
(DateTimeHour11FieldElement): Added. Represents 0-11 hour format.
(DateTimeHour12FieldElement): Added. Represents 1-12 hour format.
(DateTimeHour23FieldElement): Added. Represents 0-23 hour format.
(DateTimeHour24FieldElement): Added. Represents 1-24 hour format.

LayoutTests:

Added test cases with min/max attributes.

* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield-expected.txt:
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html:
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Added.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-stepup-stepdown-from-renderer.html: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt:
* fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html:
* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:
* fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Enable threaded HTML parser by default in DumpRenderTree
abarth@webkit.org [Thu, 28 Feb 2013 06:41:00 +0000 (06:41 +0000)]
[Chromium] Enable threaded HTML parser by default in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=110907

Reviewed by Eric Seidel.

Tools:

This patch changes --enable-threaded-html-parser into
--disable-threaded-html-parser and thereby enables the threaded HTML
parser by default for the Chromium port.

* DumpRenderTree/chromium/DumpRenderTree.cpp:
* DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

LayoutTests:

Update test results to show subtle differences in FrameLoaderClient callbacks.

* platform/chromium-mac/security/block-test-no-port-expected.txt: Removed.
* platform/chromium-win/fast/images/support-broken-image-delegate-expected.txt:
* platform/chromium-win/security/block-test-no-port-expected.txt: Removed.
* platform/chromium/fast/images/support-broken-image-delegate-expected.txt:
* platform/chromium/fast/loader/main-document-url-for-non-http-loads-expected.txt: Added.
* platform/chromium/http/tests/loading/307-after-303-after-post-expected.txt: Added.
* platform/chromium/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Added.
* platform/chromium/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
* platform/chromium/http/tests/misc/window-dot-stop-expected.txt: Added.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Added.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Added.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt: Added.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Added.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Added.
* platform/chromium/inspector/debugger/pause-in-inline-script-expected.txt: Added.
* platform/chromium/inspector/timeline/timeline-script-tag-1-expected.txt: Added.
* platform/chromium/security/block-test-no-port-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Should not return WebTextInputTypeNone for date input element.
commit-queue@webkit.org [Thu, 28 Feb 2013 05:53:00 +0000 (05:53 +0000)]
[Chromium] Should not return WebTextInputTypeNone for date input element.
https://bugs.webkit.org/show_bug.cgi?id=110740

Patch by Seigo Nonaka <nona@chromium.org> on 2013-02-27
Reviewed by Kent Tamura.

In the case of Windows 8, text input state including on-screen keyboard is controlled by the
value of WebTextInputType returned from WebViewImpl::textInputType().
In past, it returned WebTextInputTypeDate for date text input but now it returns
WebTextInputTypeNone.
WebTextInputTypeNone is used for non editable node, so on-screen keyboard will be hidden if
the date text input is focused.  So there is no way to input on Windows 8 tablet without
physical keyboard except tapping small up/down arrow.

* public/WebTextInputType.h: Introduces WebTextInputTypeDateTimeField.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::textInputInfo): Fills type filed regardless of editable or not. It is
safe because textInputType returns editable type only for known editable element.
(WebKit::WebViewImpl::textInputType): Returns WebTextInputTypeDateTimeField for the date
time field element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNeed to re-layout fixed position elements after scale when using settings()->fixedEle...
commit-queue@webkit.org [Thu, 28 Feb 2013 05:04:24 +0000 (05:04 +0000)]
Need to re-layout fixed position elements after scale when using settings()->fixedElementsLayoutRelativeToFrame()
https://bugs.webkit.org/show_bug.cgi?id=105486

Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-02-27
Reviewed by James Robinson.

In settings()->fixedElementsLayoutRelativeToFrame() mode, fixed-position
elements are layout relative to the current visible viewport, which can
be different from the layout viewport when using fixed-layout mode.
We need to re-layout fixed-position elements in case of visible content
size changes.

The test is currently chromium-specific due to difficulties to make this
test works on Mac. The mac port seems to work very differently with
visible content size when a page is scaled. And there is no reliable way
to hide scrollbars in mac-wk1 that doesn't cause a side effect.

Source/WebCore:

Test: platform/chromium/fast/repaint/relayout-fixed-position-after-scale.html

* page/FrameView.h:
(FrameView):
* page/Page.cpp:
(WebCore::Page::setPageScaleFactor):

LayoutTests:

* platform/chromium/fast/repaint/relayout-fixed-position-after-scale-expected.html: Added.
* platform/chromium/fast/repaint/relayout-fixed-position-after-scale.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInitialize page visibility after creating WebKitTestRunner WebView on Mac
commit-queue@webkit.org [Thu, 28 Feb 2013 03:51:43 +0000 (03:51 +0000)]
Initialize page visibility after creating WebKitTestRunner WebView on Mac
https://bugs.webkit.org/show_bug.cgi?id=111025

Patch by Kiran Muppala <cmuppala@apple.com> on 2013-02-27
Reviewed by Simon Fraser.

Set page visibility to "visible" after creating WebView to override
visibility state inferred from window occlusion notifications on Mac.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions): Add call to
setVisibilityState.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Exclusions] Enable shape-inside rectangle support for shape-padding
hmuller@adobe.com [Thu, 28 Feb 2013 03:31:57 +0000 (03:31 +0000)]
[CSS Exclusions] Enable shape-inside rectangle support for shape-padding
https://bugs.webkit.org/show_bug.cgi?id=110500

Reviewed by Dirk Schulze.

Source/WebCore:

Added support for CSS shape-padding for shapes defined with shape-inside.

Tests: fast/exclusions/shape-inside/shape-inside-circle-padding.html
       fast/exclusions/shape-inside/shape-inside-ellipse-padding.html
       fast/exclusions/shape-inside/shape-inside-rectangle-padding.html
       fast/exclusions/shape-inside/shape-inside-rounded-rectangle-padding.html

* rendering/ExclusionRectangle.cpp:
(WebCore::FloatRoundedRect::paddingBounds): Inset the rounded rectangle to reflect the padding parameter.
(WebCore::FloatRoundedRect::marginBounds): Expand the rounded rectangle to reflect the margin parameter.
(WebCore::FloatRoundedRect::cornerInterceptForWidth): Moved this method from ExclusionRectangle to FloatRoundedRect.
(WebCore::ExclusionRectangle::shapePaddingBounds): Lazily compute the bounds of the padding box.
(WebCore::ExclusionRectangle::shapeMarginBounds): Lazily compute the bounds of the margin box.
(WebCore::ExclusionRectangle::getExcludedIntervals): This computuation is now based on the (new) margin box.
(WebCore::ExclusionRectangle::getIncludedIntervals): This computation is now base don the (new) padding box.
(WebCore::ExclusionRectangle::firstIncludedIntervalLogicalTop): This computation is now base don the (new) padding box.
* rendering/ExclusionRectangle.h:
(FloatRoundedRect): A subclass of FloatRect that includes corner radii specified as CSS shapes do.
(WebCore::FloatRoundedRect::FloatRoundedRect):
(WebCore::FloatRoundedRect::rx):
(WebCore::FloatRoundedRect::ry):
(WebCore::ExclusionRectangle::ExclusionRectangle):
* rendering/ExclusionShape.cpp:
(WebCore::ExclusionShape::createExclusionShape): Initialize the new shapeMargin and shapePadding properties.
* rendering/ExclusionShape.h:
(ExclusionShape):
(WebCore::ExclusionShape::shapeMargin): Added a public read-only property for shapeMargin.
(WebCore::ExclusionShape::shapePadding): Added a public read-only property for shapePadding.
* rendering/ExclusionShapeInfo.cpp:
(WebCore::::computedShape): Pass the values of the CSS shape-margin and shapp-padding properties to createExclusionShape().

LayoutTests:

Added one shape-inside, shape-padding test for each CSS shape type.

* fast/exclusions/shape-inside/shape-inside-circle-padding-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-circle-padding.html: Added.
* fast/exclusions/shape-inside/shape-inside-ellipse-padding-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-ellipse-padding.html: Added.
* fast/exclusions/shape-inside/shape-inside-rectangle-padding-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-rectangle-padding.html: Added.
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-padding-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-padding.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore style cleanup in GIFImageReader
hclam@chromium.org [Thu, 28 Feb 2013 03:09:54 +0000 (03:09 +0000)]
More style cleanup in GIFImageReader
https://bugs.webkit.org/show_bug.cgi?id=110776

Reviewed by Allan Sandfeld Jensen.

Renamed variable q to currentComponent which more accurately represent
the purpose.

No test. Simple refactoring.

* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::decodeInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Rebaseline after r144236
schenney@chromium.org [Thu, 28 Feb 2013 02:58:03 +0000 (02:58 +0000)]
[Chromium] Rebaseline after r144236
https://bugs.webkit.org/show_bug.cgi?id=109879

Unreviewed expectations update

* platform/chromium-linux/plugins/plugin-clip-subframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMerge PageLoadingPerfTest into ReplayPerfTest
rniwa@webkit.org [Thu, 28 Feb 2013 02:29:04 +0000 (02:29 +0000)]
Merge PageLoadingPerfTest into ReplayPerfTest
https://bugs.webkit.org/show_bug.cgi?id=111027

Reviewed by Dirk Pranke.

Merged two classes.

We should really move ahead with the bug 100991 and get rid of PageLoadingPerfTest
part of ReplayPerfTest.

* Scripts/webkitpy/performance_tests/perftest.py:
(ReplayPerfTest): Moved _FORCE_GC_FILE here.
(ReplayPerfTest.__init__):
(ReplayPerfTest._run_with_driver): Moved from PageLoadingPerfTest.
(ReplayPerfTest.run_single): Load the GC page as run_single on PageLoadingPerfTest did.
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestReplayPerfTest):
(TestReplayPerfTest.test_run_single.run_test):
(TestReplayPerfTest.test_run_single): Make sure test_time is passed down properly from output.
(TestReplayPerfTest.test_run_with_driver_accumulates_results): Renamed from
TestPageLoadingPerfTest.test_run.
(TestReplayPerfTest.test_run_with_driver_accumulates_results.mock_run_signle):
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Renamed from
TestPageLoadingPerfTest.test_run_with_memory_output
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results.mock_run_signle):
(TestReplayPerfTest.test_prepare_calls_run_single):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd month popup for new calendar picker
keishi@webkit.org [Thu, 28 Feb 2013 02:24:16 +0000 (02:24 +0000)]
Add month popup for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110830

Reviewed by Kent Tamura.

Adding month popup view for use in the new calendar picker (Bug 109439).
YearListCell will grow in height when selected to reveal the buttons for
selecting the month.

No new tests. Code is not used yet.

* Resources/pagepopups/calendarPicker.js:
(YearListCell): A row inside the month popup. Contains buttons for choosing a month.
(YearListCell.prototype._recycleBin):
(YearListCell.prototype.reset): Resets a thrown away cell for reuse at the given row.
(YearListCell.prototype.height):
(YearListCell.prototype.setHeight):
(YearListView): List view showing YearListCells.
(YearListView.prototype.onMouseOver): If the mouse is over a month button, highlights it.
(YearListView.prototype.onMouseOut): De-highlights the month button.
(YearListView.prototype.setWidth): Set scroll view width to leave space for the scroll bar.
(YearListView.prototype.setHeight): Sets the scroll bar height as well.
(YearListView.prototype._animateRow): Animates the row height to open/close the YearListCell.
(YearListView.prototype.onCellHeightAnimatorDidStop): Keep this._runningAnimators and this._animatingRows up to date.
(YearListView.prototype.onCellHeightAnimatorStep): Update the cell height and position.
(YearListView.prototype.onClick): If this is a click on a month button, select the month.
(YearListView.prototype.rowAtScrollOffset): Calculates the row currently at the given offset.
(YearListView.prototype.scrollOffsetForRow): Calculates the current scroll offset of the given row.
(YearListView.prototype.prepareNewCell): Prepares a new or recycled YearListCell.
(YearListView.prototype.updateCells): Updates the position of the visible cells.
(YearListView.prototype.deselect): Deselects a row.
(YearListView.prototype.deselectWithoutAnimating): Deselects a row without the closing animation.
(YearListView.prototype.select): Selects a row.
(YearListView.prototype.selectWithoutAnimating): Deselects a row without the opening animation.
(YearListView.prototype.buttonForMonth): Returns the month button for a given month. Returns null if the cell is not visible.
(YearListView.prototype.dehighlightMonth): Dehighlights the month button.
(YearListView.prototype.highlightMonth): Highlights the month button.
(YearListView.prototype.show): Call when showing the year list view. Shows the given month as highlighted.
(YearListView.prototype.hide): Dispatches a did hide event which will be picked up by the CalendarPicker and the MonthPopupView will close.
(YearListView.prototype._moveHighlightTo): Used to move the month highlight in response to a key event.
(YearListView.prototype.onKeyDown): Arrow keys and PageUp/PageDown keys work.
(MonthPopupView): The popup view to be overlayed over the calendar picker.
(MonthPopupView.prototype.show): Takes the initialMonth to show and the calendarTableRect so we can overlay the year list view right on top of it.
(MonthPopupView.prototype.hide):
(MonthPopupView.prototype.onClick): Hides itself if the use clicks outside the year list view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd --additional-drt-flag option to run-perf-tests to make it easy to test runtime...
eric@webkit.org [Thu, 28 Feb 2013 01:33:44 +0000 (01:33 +0000)]
Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
https://bugs.webkit.org/show_bug.cgi?id=111021

Reviewed by Dirk Pranke.

The underlying code (which is shared with run-webkit-tests)
already knew how to support this option, it just wasn't exposed
via the run-perf-tests front-end.  This patch fixes that.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStop uploading results to webkit-perf.appspot.com
rniwa@webkit.org [Thu, 28 Feb 2013 00:56:45 +0000 (00:56 +0000)]
Stop uploading results to webkit-perf.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=110954

Reviewed by Benjamin Poulain.

Pass in perf.webkit.org instead of webkit-perf.appspot.com as the test results server.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunAndUploadPerfTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Rebaseline after r144236
schenney@chromium.org [Thu, 28 Feb 2013 00:42:46 +0000 (00:42 +0000)]
[Chromium] Rebaseline after r144236
https://bugs.webkit.org/show_bug.cgi?id=109879

Unreviewed expectations update

* platform/chromium-mac/plugins/plugin-clip-subframe-expected.txt: Added.
* platform/chromium-win-xp/plugins: Removed.
* platform/chromium-win/plugins/plugin-clip-subframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse FeatureObserver to see how often web sites use multipart main documents
abarth@webkit.org [Thu, 28 Feb 2013 00:17:27 +0000 (00:17 +0000)]
Use FeatureObserver to see how often web sites use multipart main documents
https://bugs.webkit.org/show_bug.cgi?id=111015

Reviewed by Nate Chapin.

Multipart main documents add sigificant complexity to the loader.  It
would be interesting to know how often this complexity is used.

* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::responseReceived):
* page/FeatureObserver.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r144168.
commit-queue@webkit.org [Wed, 27 Feb 2013 23:50:41 +0000 (23:50 +0000)]
Unreviewed, rolling out r144168.
http://trac.webkit.org/changeset/144168
https://bugs.webkit.org/show_bug.cgi?id=111019

It broke the build and tronical is unavailable (Requested by
Ossy_night on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-27

* LLIntOffsetsExtractor.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Lower priority of preloaded images
simonjam@chromium.org [Wed, 27 Feb 2013 23:47:52 +0000 (23:47 +0000)]
[chromium] Lower priority of preloaded images
https://bugs.webkit.org/show_bug.cgi?id=110527

Source/WebCore:

Reviewed by Nate Chapin.

This improves Speed Index by ~5%, because it encourages us to load images that are needed for
painting over speculative preloads. Ideally, all embedders would use this, but it relies on
ResourceHandle::didChangePriority being implemented. Currently, only Chrome does that.

Test: http/tests/loading/promote-img-preload-priority.html

* loader/FrameLoaderClient.h:
(FrameLoaderClient):
(WebCore::FrameLoaderClient::dispatchDidChangeResourcePriority): Added callback to enable testing.
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::setLoadPriority): Signal callback.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::preload): Actual behavior change.

Source/WebKit/chromium:

Plumb the didChangePriority signal into DRT so it can be tested.

Reviewed by Nate Chapin.

* public/WebFrameClient.h:
(WebKit):
(WebKit::WebFrameClient::didChangeResourcePriority):
(WebFrameClient):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDidChangeResourcePriority):
(WebKit):
* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):

Tools:

Plumb the didChangePriority signal into DRT so it can be tested.

Reviewed by Nate Chapin.

* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestRunner::WebTestProxy::didChangeResourcePriority):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldDumpResourcePriorities):
(WebTestRunner):
(WebTestRunner::TestRunner::dumpResourceRequestPriorities):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
(WebTestRunner::WebTestProxyBase::willSendRequest):
(WebTestRunner::WebTestProxyBase::didChangeResourcePriority):
(WebTestRunner):

LayoutTests:

Reviewed by Nate Chapin.

* http/tests/loading/promote-img-preload-priority-expected.txt: Added.
* http/tests/loading/promote-img-preload-priority.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed trivial buildfix after r144190.
ossy@webkit.org [Wed, 27 Feb 2013 23:25:14 +0000 (23:25 +0000)]
Unreviewed trivial buildfix after r144190.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2013-02-27

* platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp:
(WebCore::GraphicsSurface::platformPaintToTextureMapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] One more unreviewed buildfix for EFL, GTK and Qt after r144218.
ossy@webkit.org [Wed, 27 Feb 2013 23:13:31 +0000 (23:13 +0000)]
[WK2] One more unreviewed buildfix for EFL, GTK and Qt after r144218.

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2013-02-27

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebProcess/Storage/StorageNamespaceProxy.cpp:
(WebKit::StorageNamespaceProxy::copy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline 2 SVG tests after WK108429
pdr@google.com [Wed, 27 Feb 2013 23:04:14 +0000 (23:04 +0000)]
Rebaseline 2 SVG tests after WK108429

This patch rebaselines svg/repaint after WK108429 and removes a stale
test expectations entry for svg/custom/text-ctm.

Unreviewed update of test expectations.

* platform/chromium-win/svg/repaint/svgsvgelement-repaint-children-expected.png: Added.
* platform/chromium-win/svg/repaint/svgsvgelement-repaint-children-expected.txt: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebSpeech: support speech cancel
cfleizach@apple.com [Wed, 27 Feb 2013 22:55:18 +0000 (22:55 +0000)]
WebSpeech: support speech cancel
https://bugs.webkit.org/show_bug.cgi?id=107349

Reviewed by Beth Dakin.

Source/WebCore:

Add the ability to cancel speech utterances and make it work with Mac
and the mock speech synthesizer.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-cancel.html

* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::pending):
(WebCore::SpeechSynthesis::cancel):
(WebCore::SpeechSynthesis::handleSpeakingCompleted):
* platform/PlatformSpeechSynthesizer.h:
(PlatformSpeechSynthesizer):
* platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper cancel]):
(WebCore::PlatformSpeechSynthesizer::cancel):
(WebCore):
* platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::cancel):
(WebCore):
(WebCore::PlatformSpeechSynthesizerMock::speak):
* platform/mock/PlatformSpeechSynthesizerMock.h:
(PlatformSpeechSynthesizerMock):

LayoutTests:

* platform/mac/fast/speechsynthesis/speech-synthesis-cancel-expected.txt: Added.
* platform/mac/fast/speechsynthesis/speech-synthesis-cancel.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed (speculative) build fixes for EFL, GTK and Qt after r144218.
zandobersek@gmail.com [Wed, 27 Feb 2013 22:53:43 +0000 (22:53 +0000)]
Unreviewed (speculative) build fixes for EFL, GTK and Qt after r144218.

* CMakeLists.txt:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnlock partially decoded images after passing them to the ImageDecodingStore
commit-queue@webkit.org [Wed, 27 Feb 2013 22:49:32 +0000 (22:49 +0000)]
Unlock partially decoded images after passing them to the ImageDecodingStore
https://bugs.webkit.org/show_bug.cgi?id=110778

Patch by Min Qin <qinmin@chromium.org> on 2013-02-27
Reviewed by Stephen White.

Source/WebCore:

For partially decoded images, we need to unlock them so that the memory can be freed.
This change unlocks all the image frames after they are passed to ImageDecodingStore.
Unit tests are added in ImageFrameGeneratorTest.

* platform/graphics/chromium/ImageFrameGenerator.cpp:
(WebCore::ImageFrameGenerator::tryToResumeDecodeAndScale):
(WebCore::ImageFrameGenerator::tryToDecodeAndScale):
(WebCore::ImageFrameGenerator::decode):
* platform/image-decoders/ImageDecoder.h:
(ImageDecoder):
(WebCore::ImageDecoder::lockFrameBuffers):
(WebCore::ImageDecoder::unlockFrameBuffers):

Source/WebKit/chromium:

Test for testing that image frames are unlocked after passing to ImageDecodingStore.

* tests/ImageFrameGeneratorTest.cpp:
(WebCore::ImageFrameGeneratorTest::SetUp):
(WebCore::ImageFrameGeneratorTest::frameBuffersUnlocked):
(ImageFrameGeneratorTest):
(WebCore::ImageFrameGeneratorTest::frameBuffersLocked):
(WebCore::TEST_F):
* tests/MockImageDecoder.h:
(WebCore::MockImageDecoderClient::frameBuffersLocked):
(WebCore::MockImageDecoderClient::frameBuffersUnlocked):
(WebCore::MockImageDecoder::unlockFrameBuffers):
(WebCore::MockImageDecoder::lockFrameBuffers):
(MockImageDecoder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInsufficient validation when uploading depth textures to WebGL
kbr@google.com [Wed, 27 Feb 2013 22:44:29 +0000 (22:44 +0000)]
Insufficient validation when uploading depth textures to WebGL
https://bugs.webkit.org/show_bug.cgi?id=110931

Reviewed by Abhishek Arya.

Source/WebCore:

Updated webgl/conformance/extensions/webgl-depth-texture.html
layout test with additional test cases.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2DImpl):
(WebCore::WebGLRenderingContext::texSubImage2D):
    Check for valid format/type combinations, depth, and
    depth+stencil formats when uploading HTML elements and
    ImageData as textures.

LayoutTests:

Updated webgl/conformance/extensions/webgl-depth-texture.html
layout test with additional test cases. These changes will be
added to the Khronos repository.

* webgl/resources/webgl_test_files/conformance/extensions/webgl-depth-texture.html:
    Added more test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThreaded HTML Parser fails fast/dom/HTMLAnchorElement/anchor-no-multiple-windows...
abarth@webkit.org [Wed, 27 Feb 2013 22:39:19 +0000 (22:39 +0000)]
Threaded HTML Parser fails fast/dom/HTMLAnchorElement/anchor-no-multiple-windows.html in debug
https://bugs.webkit.org/show_bug.cgi?id=110951

Reviewed by Eric Seidel.

We were triggering this ASSERT because we didn't understand that a
given frame might have multiple DocumentLoaders in various states. That
caused us to think that a DocumentLoader in the provisional state was
actually loading.

* dom/Document.cpp:
(WebCore::Document::decrementActiveParserCount):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: Mac platform should support ability to scroll an element into visible
cfleizach@apple.com [Wed, 27 Feb 2013 22:10:11 +0000 (22:10 +0000)]
AX: Mac platform should support ability to scroll an element into visible
https://bugs.webkit.org/show_bug.cgi?id=109860

Reviewed by Beth Dakin.

Source/WebCore:

Support the scrollToMakeVisible() action for MacOS accessibility clients.

Tests: platform/mac/accessibility/scroll-to-visible-action.html

* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
(-[WebAccessibilityObjectWrapper accessibilityScrollToVisible]):
(-[WebAccessibilityObjectWrapper accessibilityPerformAction:]):

Tools:

* DumpRenderTree/AccessibilityUIElement.cpp:
(scrollToMakeVisibleCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::scrollToMakeVisible):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::scrollToMakeVisible):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::scrollToMakeVisible):
(WTR):

LayoutTests:

* platform/mac/accessibility/scroll-to-visible-action.html: Added.
* platform/mac/accessibility/scroll-to-visible-action-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPlugin in iframe may not display
commit-queue@webkit.org [Wed, 27 Feb 2013 22:05:07 +0000 (22:05 +0000)]
Plugin in iframe may not display
https://bugs.webkit.org/show_bug.cgi?id=109879

Patch by John Bauman <jbauman@chromium.org> on 2013-02-27
Reviewed by Simon Fraser.

Source/WebCore:

Changing the cliprect on a layer containing an iframe may change the
cliprect of plugins inside the iframe, so recursively tell all plugins
in iframes that their cliprect has changed after doing layout on the
outer frame.

Test: plugins/plugin-clip-subframe.html

* platform/ScrollView.cpp:
(WebCore::ScrollView::clipRectChanged):
* platform/ScrollView.h:
* platform/Widget.h:
(WebCore::Widget::clipRectChanged):
* plugins/PluginView.cpp:
(WebCore::PluginView::clipRectChanged):
* plugins/PluginView.h:
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):

Source/WebKit/chromium:

Use clipRectChanged to update the geometry.

* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::clipRectChanged):
* src/WebPluginContainerImpl.h:

Source/WebKit/mac:

Ensure NetscapePluginWidget informs the plugin view of the cliprect change directly.

* Plugins/WebBaseNetscapePluginView.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(NetscapePluginWidget::clipRectChanged):

Source/WebKit2:

Update geometry when cliprect changes.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::clipRectChanged):
* WebProcess/Plugins/PluginView.h:

Tools:

LogNPPSetWindow will be used with other ports as well.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:

LayoutTests:

Use log-npp-set-window to ensure plugin clip changes correctly.

* platform/mac-wk2/plugins/plugin-clip-subframe-expected.txt: Added.
* platform/mac/plugins/plugin-clip-subframe-expected.txt: Added.
* plugins/plugin-clip-subframe-expected.txt: Added.
* plugins/plugin-clip-subframe.html: Added.
* plugins/resources/plugin-clip-subframe-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement channel up-mixing and down-mixing rules
crogers@google.com [Wed, 27 Feb 2013 21:46:32 +0000 (21:46 +0000)]
Implement channel up-mixing and down-mixing rules
https://bugs.webkit.org/show_bug.cgi?id=110812

Reviewed by Kenneth Russell.

Source/WebCore:

Please see Web Audio specification for details of the AudioNode mixing rules attributes:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#UpMix

Test: webaudio/audionode-channel-rules.html

* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::channelCount):
(WebCore):
(WebCore::AudioNode::setChannelCount):
(WebCore::AudioNode::channelCountMode):
(WebCore::AudioNode::setChannelCountMode):
(WebCore::AudioNode::channelInterpretation):
(WebCore::AudioNode::setChannelInterpretation):
(WebCore::AudioNode::updateChannelsForInputs):
* Modules/webaudio/AudioNode.h:
(AudioNode):
(WebCore::AudioNode::internalChannelCountMode):
(WebCore::AudioNode::internalChannelInterpretation):
* Modules/webaudio/AudioNode.idl:
* Modules/webaudio/AudioNodeInput.cpp:
(WebCore::AudioNodeInput::numberOfChannels):
(WebCore::AudioNodeInput::bus):
(WebCore::AudioNodeInput::internalSummingBus):
(WebCore::AudioNodeInput::sumAllConnections):
(WebCore::AudioNodeInput::pull):
* Modules/webaudio/AudioNodeInput.h:
(AudioNodeInput):
* Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::ConvolverNode):
* Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):
* Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::PannerNode):
* platform/audio/AudioBus.cpp:
(WebCore::AudioBus::speakersCopyFrom):
(WebCore::AudioBus::speakersSumFrom):
(WebCore::AudioBus::speakersSumFrom5_1_ToMono):
(WebCore):
* platform/audio/AudioBus.h:
(AudioBus):

LayoutTests:

* webaudio/audionode-channel-rules-expected.txt: Added.
* webaudio/audionode-channel-rules.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRenderTableCellDeathTest unit test fails on mac
schenney@chromium.org [Wed, 27 Feb 2013 21:42:18 +0000 (21:42 +0000)]
RenderTableCellDeathTest unit test fails on mac
https://bugs.webkit.org/show_bug.cgi?id=110992

Unreviewed second attempt. Trying to get the right define for the OS.

* tests/RenderTableCellTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Need WebPage API for animating scroll position & zoom changes
commit-queue@webkit.org [Wed, 27 Feb 2013 21:30:16 +0000 (21:30 +0000)]
[BlackBerry] Need WebPage API for animating scroll position & zoom changes
https://bugs.webkit.org/show_bug.cgi?id=110912

Patch by Andrew Lo <anlo@rim.com> on 2013-02-27
Reviewed by Rob Buis.

Internally reviewed by Jakob Petsovits.
Internal PR 285468.

Add an API to WebPage for animated scroll position & zoom level
adjustments.

Have InputHandler use the new API.

Rename some variables to reflect the fact that they are not only
used by block zoom now.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):
(BlackBerry::WebKit::WebPage::blockZoom):
(BlackBerry::WebKit::WebPagePrivate::animateToScaleAndDocumentScrollPosition):
(WebKit):
(BlackBerry::WebKit::WebPage::animateToScaleAndDocumentScrollPosition):
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebPagePrivate):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThreaded HTML parser hits ASSERTION FAILED: this == frameLoader()->activeDocumentLoader()
abarth@webkit.org [Wed, 27 Feb 2013 21:23:05 +0000 (21:23 +0000)]
Threaded HTML parser hits ASSERTION FAILED: this == frameLoader()->activeDocumentLoader()
https://bugs.webkit.org/show_bug.cgi?id=110937

Reviewed by Darin Adler.

This patch restores the ASSERT behind an ifdef so that we can continue
to get converage from the ASSERT while we investigate why it is
triggering in the threaded parser.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::checkLoadComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Introduce WebHyphenator class to consolidate hyphenation related method...
jochen@chromium.org [Wed, 27 Feb 2013 21:20:38 +0000 (21:20 +0000)]
[chromium] Introduce WebHyphenator class to consolidate hyphenation related method on WebKit::Platform
https://bugs.webkit.org/show_bug.cgi?id=110953

Reviewed by Adam Barth.

This patch makes it easier to mock the hyphenation related methods.

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::hyphenator):
* chromium/public/WebHyphenator.h: Added.
(WebKit):
(WebHyphenator):
(WebKit::WebHyphenator::canHyphenate):
(WebKit::WebHyphenator::computeLastHyphenLocation):
(WebKit::WebHyphenator::~WebHyphenator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip media tests that fail on content_shell
jochen@chromium.org [Wed, 27 Feb 2013 20:58:05 +0000 (20:58 +0000)]
Skip media tests that fail on content_shell

Unreviewed gardening.

* platform/chromium/ContentShellTestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] User credentials is not correctly handled
liachen@rim.com [Wed, 27 Feb 2013 20:50:35 +0000 (20:50 +0000)]
[BlackBerry] User credentials is not correctly handled
https://bugs.webkit.org/show_bug.cgi?id=110994

Source/WebCore:

Internal PR: 280990
Internal reviewed by Leo Yang.

Reviewed by Yong Li.

Following changes are made:
    Remove url from generating the hash to index user credential.
    Remove url from database.
    Use new CertMgrWrapper API to remove password from CertMgr.
    Handle encrypted password as binary data, instead of normal text string.
    When authentication fails, remove the saved user credential only when they match.
    Remove some url related API from CredentialBackingStore, as they are obsolete now.

No new tests as this is platform specific change about user credential.

* platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::hashCredentialInfo):
(WebCore::CredentialBackingStore::CredentialBackingStore):
(WebCore::CredentialBackingStore::~CredentialBackingStore):
(WebCore::CredentialBackingStore::open):
(WebCore::CredentialBackingStore::addLogin):
(WebCore::CredentialBackingStore::updateLogin):
(WebCore::CredentialBackingStore::hasLogin):
(WebCore::CredentialBackingStore::getLogin):
(WebCore::CredentialBackingStore::removeLogin):
(WebCore::CredentialBackingStore::addNeverRemember):
(WebCore::CredentialBackingStore::encryptedString):
(WebCore::CredentialBackingStore::decryptedString):
* platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::purgeCredentials):

Source/WebKit/blackberry:

Reviewed by Yong Li.

Following change are made:
    Remove url from CredentialTransformData, as url is not used anymore.
    Adapt to updated CredentialBackingStore API about removing url.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
* WebCoreSupport/CredentialManager.cpp:
(WebCore::CredentialManager::autofillPasswordForms):
(WebCore::CredentialManager::saveCredentialIfConfirmed):
* WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::CredentialTransformData):
* WebCoreSupport/CredentialTransformData.h:
(CredentialTransformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (48533): Full-frame plugins stopped working (download instead of loading...
jer.noble@apple.com [Wed, 27 Feb 2013 20:44:46 +0000 (20:44 +0000)]
REGRESSION (48533): Full-frame plugins stopped working (download instead of loading the plugin)
https://bugs.webkit.org/show_bug.cgi?id=111003

Reviewed by Anders Carlsson.

Also query the Page's pluginData when determining whether a given MIME type can be shown.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCanShowMIMEType):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::canShowMIMEType):
* WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRenderTableCellDeathTest unit test fails on mac
schenney@chromium.org [Wed, 27 Feb 2013 20:43:46 +0000 (20:43 +0000)]
RenderTableCellDeathTest unit test fails on mac
https://bugs.webkit.org/show_bug.cgi?id=110992

Unreviewed disabling of test that is hanging or crashing on Mac.

* tests/RenderTableCellTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactor transform painting/hit testing code in RenderLayer.
hyatt@apple.com [Wed, 27 Feb 2013 20:40:28 +0000 (20:40 +0000)]
Refactor transform painting/hit testing code in RenderLayer.
https://bugs.webkit.org/show_bug.cgi?id=110998

Reviewed by Eric Seidel.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
Pull the code that applies the transform for painting into a new
function that can also apply an additional translation offset. This
offset will be used by the new columns code when that patch lands.

(WebCore::RenderLayer::createLocalTransformState):
Also patched to be able to apply an additional translation offset.

(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestLayerByApplyingTransform):
Same as with painting, pull the code that applies the transform into
its own function and also enable an extra translation offset to be
applied.

* rendering/RenderLayer.h:
Added the new functions to the header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove suppression invalidation logic from WebViewImpl
commit-queue@webkit.org [Wed, 27 Feb 2013 20:39:40 +0000 (20:39 +0000)]
[chromium] Remove suppression invalidation logic from WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=110999

Patch by James Robinson <jamesr@chromium.org> on 2013-02-27
Reviewed by Adrienne Walker.

This suppression logic is now handled on the embedder side. In fact, scheduleComposite() is now only used
by DumpRenderTree.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::suppressInvalidations):
(WebKit::WebViewImpl::scheduleComposite):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoplugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct...
jochen@chromium.org [Wed, 27 Feb 2013 20:38:31 +0000 (20:38 +0000)]
plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
https://bugs.webkit.org/show_bug.cgi?id=110973

Reviewed by Adam Barth.

There is nothing that ensures that the log messages from the plugin
come in before the layout test finished loading.

Tools:

* DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
(PassDifferentNPPStruct::NPP_SetWindow):
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_SetWindow):

LayoutTests:

* platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt: Removed.
* plugins/netscape-plugin-setwindow-size-2.html:
* plugins/netscape-plugin-setwindow-size.html:
* plugins/pass-different-npp-struct.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTouch CSSGrammar.y.in to fix an internal buildbot
ddkilzer@apple.com [Wed, 27 Feb 2013 20:37:12 +0000 (20:37 +0000)]
Touch CSSGrammar.y.in to fix an internal buildbot

* css/CSSGrammar.y.in: Add copyright dates based on previous
commits.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Disable MathML support in release builds
zandobersek@gmail.com [Wed, 27 Feb 2013 20:21:39 +0000 (20:21 +0000)]
[GTK] Disable MathML support in release builds
https://bugs.webkit.org/show_bug.cgi?id=110981

Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-02-27
Reviewed by Martin Robinson.

* Source/autotools/SetupWebKitFeatures.m4: Disable the MathML support in release builds
as the code is not yet deemed production-ready.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd smartInsertDeleteEnabled setting to WebCore::Page
commit-queue@webkit.org [Wed, 27 Feb 2013 20:20:37 +0000 (20:20 +0000)]
Add smartInsertDeleteEnabled setting to WebCore::Page
https://bugs.webkit.org/show_bug.cgi?id=107840

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-02-27
Reviewed by Ryosuke Niwa.

Source/WebCore:

Covered by editing/deleting/smart-editing-disabled.html.

* page/Settings.in: Add new setting with true as initial value.

Source/WebKit2:

* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode): Remove code related to
isSmartInsertDeleteEnabled.
* Shared/WebPageCreationParameters.h:
(WebPageCreationParameters): Remove isSmartInsertDeleteEnabled.
* Shared/WebPreferencesStore.h:
(WebKit): Add macro for smartInsertDeleteEnabled setting.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetSmartInsertDeleteEnabled):
(WKPreferencesGetSmartInsertDeleteEnabled): Implement methods using the
new setting.
* UIProcess/API/C/WKPreferencesPrivate.h: Add new methods headers.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage): Set smartInsertDeleteEnabled
setting using m_isSmartInsertDeleteEnabled to keep initial value on Mac.
(WebKit::WebPageProxy::creationParameters): Remove usage of
parameters.isSmartInsertDeleteEnabled.
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::smartInsertDeleteEnabled): Enable method for
all platforms.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Remove m_isSmartInsertDeleteEnabled
initialization.
(WebKit::WebPage::updatePreferences): Set smartInsertDeleteEnabled
setting.
(WebKit::WebPage::isSmartInsertDeleteEnabled): Implement method using
settings.
(WebKit):
(WebKit::WebPage::setSmartInsertDeleteEnabled): Implement method using
settings.
* WebProcess/WebPage/WebPage.h:
(WebPage): Enable methods dealing with smartInsertDeleteEnabled for all
platforms and remove m_isSmartInsertDeleteEnabled as it will be a
setting.

LayoutTests:

Replace testRunner.setSmartInsertDeleteEnabled by
internals.settings.setSmartInsertDeleteEnabled in tests.

* editing/deleting/smart-editing-disabled.html:
* editing/selection/doubleclick-beside-cr-span.html:
* editing/selection/doubleclick-whitespace-crash.html:
* editing/selection/doubleclick-whitespace-img-crash.html:
* editing/selection/doubleclick-whitespace.html:
* platform/wk2/TestExpectations: Unflag
editing/deleting/smart-editing-disabled.html as it passes now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebSpeech: Support pause/resume ability
cfleizach@apple.com [Wed, 27 Feb 2013 20:14:45 +0000 (20:14 +0000)]
WebSpeech: Support pause/resume ability
https://bugs.webkit.org/show_bug.cgi?id=107345

Reviewed by Beth Dakin.

Source/WebCore:

Add in the pause/resume functionality to SpeechSynthesis. Also hook up
the callback events.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-pause-resume.html

* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::SpeechSynthesis):
(WebCore::SpeechSynthesis::pending):
(WebCore::SpeechSynthesis::paused):
(WebCore::SpeechSynthesis::startSpeakingImmediately):
(WebCore::SpeechSynthesis::pause):
(WebCore::SpeechSynthesis::resume):
(WebCore):
(WebCore::SpeechSynthesis::didPauseSpeaking):
(WebCore::SpeechSynthesis::didResumeSpeaking):
* Modules/speech/SpeechSynthesis.h:
(SpeechSynthesis):
* platform/PlatformSpeechSynthesizer.h:
(PlatformSpeechSynthesizerClient):
(PlatformSpeechSynthesizer):
* platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper pause]):
(-[WebSpeechSynthesisWrapper resume]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore::PlatformSpeechSynthesizer::pause):
(WebCore):
(WebCore::PlatformSpeechSynthesizer::resume):

LayoutTests:

* platform/mac/fast/speechsynthesis/speech-synthesis-pause-resume-expected.txt: Added.
* platform/mac/fast/speechsynthesis/speech-synthesis-pause-resume.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDisable some unsound DFG DCE
fpizlo@apple.com [Wed, 27 Feb 2013 20:11:40 +0000 (20:11 +0000)]
Disable some unsound DFG DCE
https://bugs.webkit.org/show_bug.cgi?id=110948

Reviewed by Michael Saboff.

DCE of bitops is not sound since the bitops might call some variant of valueOf.

This used to work right because ValueToInt32 was MustGenerate. From the DFG IR
standpoint it feels weird to make ValueToInt32 be MustGenerate since that node is
implemented entirely as a pure conversion. If we ever gave the DFG the ability to
do effectful bitops, we would most likely implement them as special nodes not
related to the ValueToInt32 and bitop nodes we have now.

This change is performance neutral.

* dfg/DFGNodeType.h:
(DFG):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore storage scaffolding
andersca@apple.com [Wed, 27 Feb 2013 20:04:58 +0000 (20:04 +0000)]
More storage scaffolding
https://bugs.webkit.org/show_bug.cgi?id=110997

Reviewed by Andreas Kling.

* DerivedSources.make:
Add StorageAreaProxy.

* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::setItem):
Send back a DidSetItem message.

* WebKit2.xcodeproj/project.pbxproj:
Add generated files.

* WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::StorageAreaProxy):
Add the message receiver.

(WebKit::StorageAreaProxy::~StorageAreaProxy):
Remove the message receiver.

(WebKit::StorageAreaProxy::didSetItem):
add stub.

* WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
* WebProcess/Storage/StorageAreaProxy.messages.in: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION: Loading flash switches to discrete graphics, 100 MB on membuster
weinig@apple.com [Wed, 27 Feb 2013 19:40:54 +0000 (19:40 +0000)]
REGRESSION: Loading flash switches to discrete graphics, 100 MB on membuster
<rdar://problem/13229828>

Reviewed by Dan Bernstein.

Due the change in CFBundleIdentifier, the WebProcess and PluginProcess were
unnecessarily muxing (they used to be whitelisted by OpenGL) to the discrete
GPU.

* PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
* WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
Add NSSupportsAutomaticGraphicsSwitching YES.

* WebKit2.xcodeproj/project.pbxproj:
Re-add the PluginService.32-64.Info.plist plist to the project file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Don't add a body to platform request until necessary
ap@apple.com [Wed, 27 Feb 2013 19:14:16 +0000 (19:14 +0000)]
    Don't add a body to platform request until necessary
        https://bugs.webkit.org/show_bug.cgi?id=110900

        Reviewed by NOBODY (OOPS!).

        Reviewed by Brady Eidson.

        ResourceRequest now has more state for syncing between resource and platform parts.
        In addition to tracking which is up to date, we also track which has up to date
        HTTP Body.

        The reason is that we don't need the body on request before it's actually sent,
        and we actually cannot build it when networking is out of process.

        * WebCore.exp.in: Updated exports.

        * platform/network/ResourceRequestBase.h:
        * platform/network/ResourceRequestBase.cpp:
        (WebCore::ResourceRequestBase::setHTTPBody): Update HTTP body before returning it.
        (WebCore::ResourceRequestBase::updatePlatformRequest): Update according to HTTPBodyUpdatePolicy.
        (WebCore::ResourceRequestBase::updateResourceRequest): Ditto.

        * platform/network/cf/FormDataStreamCFNet.cpp:
        (WebCore::formDataStreamLengthPropertyName):
        (WebCore::formCopyProperty):
        (WebCore::setHTTPBody):
        Changed to not update Content-Length in platform request directly. We need to keep it
        in sync with resource request, and it's easier to do in a caller. Exposed computed
        length as a property do avoid duplicating the work.

        * platform/network/cf/FormDataStreamCFNet.h: Removed unnecessary httpBodyFromStream().

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::willSendRequest):
        (WebCore::didReceiveResponse):
        (WebCore::ResourceHandle::createCFURLConnection):
        Update body when necessary.

        (WebCore::ResourceRequest::nsURLRequest):
        (WebCore::ResourceRequest::doUpdateResourceRequest):
        (WebCore::ResourceRequest::doUpdateResourceHTTPBody):
        (WebCore):
        (WebCore::ResourceRequest::doUpdatePlatformRequest):
        (WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
        (WebCore::ResourceRequest::updateFromDelegatePreservingOldHTTPBody):
        (WebCore::ResourceRequest::applyWebArchiveHackForMail):
        Ditto.

        * platform/network/cf/ResourceRequest.h: Track body up-to-date state.

        * platform/network/cf/ResourceRequestCFNet.cpp:
        (WebCore::ResourceRequest::cfURLRequest): Honor HTTPBodyUpdatePolicy.
        (WebCore::ResourceRequest::doUpdatePlatformRequest): Don't update body here.
        (WebCore::ResourceRequest::doUpdatePlatformHTTPBody): Update the body, and make sure
        that Content-Length is correct.
        (WebCore::ResourceRequest::doUpdateResourceRequest): Don't update body here.
        (WebCore::ResourceRequest::doUpdateResourceHTTPBody): Update the body, fixing a bug
        where body stream was lost if this function got called.
        (WebCore::ResourceRequest::applyWebArchiveHackForMail): No need to update body for this one.

        * platform/network/mac/ResourceRequestMac.mm: Ditto (but this didn't have a bug
        with streams in doUpdateResourceRequest()).

        * platform/network/mac/FormDataStreamMac.h: Forward declare formDataStreamLengthPropertyName().

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::createNSURLConnection):
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::platformLoadResourceSynchronously):
        (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
        Update body when necessary.

        * platform/network/blackberry/ResourceRequest.h:
        * platform/network/chromium/ResourceRequest.h:
        * platform/network/curl/ResourceRequest.h:
        * platform/network/qt/ResourceRequest.h:
        * platform/network/soup/ResourceRequest.h:
        * platform/network/win/ResourceRequest.h:
        Added stubs for new functions. These ports don't keep a platform request in ResourceRequest,
        and don't need updating.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Test expectations updates
schenney@chromium.org [Wed, 27 Feb 2013 19:03:00 +0000 (19:03 +0000)]
[Chromium] Test expectations updates

Unreviewed expectations after recent bug fixes.

* platform/chromium-mac-lion/fast/borders/border-radius-percent-expected.png: Added.
* platform/chromium-mac-lion/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-mac-snowleopard/fast/borders/border-radius-percent-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-mac/fast/borders/border-radius-percent-expected.png: Added.
* platform/chromium-mac/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-mac/svg/custom/transform-with-shadow-and-gradient-expected.png:
* platform/chromium-win/fast/borders/border-radius-percent-expected.png: Added.
* platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
* platform/chromium-win/svg/custom/transform-with-shadow-and-gradient-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd ENABLE_CSS3_TEXT_LINE_BREAK flag.
glenn@skynav.com [Wed, 27 Feb 2013 18:46:00 +0000 (18:46 +0000)]
Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
https://bugs.webkit.org/show_bug.cgi?id=110944

Reviewed by Dean Jackson.

.:

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r124739): fast/lists/list-marker-remove-crash.html hits an assertion in...
abucur@adobe.com [Wed, 27 Feb 2013 18:43:52 +0000 (18:43 +0000)]
REGRESSION(r124739): fast/lists/list-marker-remove-crash.html hits an assertion in MoveParagraphs
https://bugs.webkit.org/show_bug.cgi?id=93247

Reviewed by Darin Adler.

Source/WebCore:

The listifyParagraph function inside InsertListCommand triggered a layout for the new list and updated
only the "start" Position. The insertion and layout may have changed the "end" Position as well. The patch
makes sure "end" is also recomputed.

Test: No new test, the patch fixes a regression.

* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::listifyParagraph):

LayoutTests:

Update TestExpectations because the test doesn't crash any more.

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt-4.8/TestExpectations:
* platform/qt-mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd ENABLE_STREAM guards to FileReaderLoader
commit-queue@webkit.org [Wed, 27 Feb 2013 18:38:44 +0000 (18:38 +0000)]
Add ENABLE_STREAM guards to FileReaderLoader
https://bugs.webkit.org/show_bug.cgi?id=110938

Patch by Zach Kuznia <zork@chromium.org> on 2013-02-27
Reviewed by Hajime Morrita.

* fileapi/FileReaderLoader.cpp:
* fileapi/FileReaderLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Remove myself from watchlist.
commit-queue@webkit.org [Wed, 27 Feb 2013 18:38:27 +0000 (18:38 +0000)]
Unreviewed. Remove myself from watchlist.

Patch by Yong Li <yong.li.webkit@outlook.com> on 2013-02-27

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix build when DFG_JIT is not enabled
commit-queue@webkit.org [Wed, 27 Feb 2013 18:34:33 +0000 (18:34 +0000)]
Fix build when DFG_JIT is not enabled
https://bugs.webkit.org/show_bug.cgi?id=110991

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-02-27
Reviewed by Csaba Osztrogonác.

* jit/JIT.h:
(JSC::JIT::canBeOptimizedOrInlined):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix bug in HTML5 Fullscreen API implementation that was preventing YouTube HTML5...
commit-queue@webkit.org [Wed, 27 Feb 2013 18:19:04 +0000 (18:19 +0000)]
Fix bug in HTML5 Fullscreen API implementation that was preventing YouTube HTML5 media controls fullscreen button from working properly.
https://bugs.webkit.org/show_bug.cgi?id=110905

Patch by John Griggs <jgriggs@rim.com> on 2013-02-27
Reviewed by Yong Li.

Return true from ChromeClientBlackBerry::supportsFullScreenForElement instead of the negation of the boolean flag (withKeyboard) passed in.

* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::supportsFullScreenForElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144209 268f45cc-cd09-0410-ab3c-d52691b4dbfc