WebKit-https.git
10 years ago2010-09-22 Chris Rogers <crogers@google.com>
crogers@google.com [Wed, 22 Sep 2010 08:45:48 +0000 (08:45 +0000)]
2010-09-22  Chris Rogers  <crogers@google.com>

        Reviewed by James Robinson.

        Add HRTFElevation files
        https://bugs.webkit.org/show_bug.cgi?id=45864

        No new tests since audio API is not yet implemented.

        * platform/audio/HRTFElevation.cpp: Added.
        (WebCore::HRTFElevation::calculateSymmetricKernelsForAzimuthElevation):
        (WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):
        (WebCore::HRTFElevation::createForSubject):
        (WebCore::HRTFElevation::createByInterpolatingSlices):
        (WebCore::HRTFElevation::getKernelsFromAzimuth):
        * platform/audio/HRTFElevation.h: Added.
        (WebCore::HRTFElevation::kernelListL):
        (WebCore::HRTFElevation::kernelListR):
        (WebCore::HRTFElevation::elevationAngle):
        (WebCore::HRTFElevation::numberOfAzimuths):
        (WebCore::HRTFElevation::sampleRate):
        (WebCore::HRTFElevation::HRTFElevation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-22 Paul Knight <pknight@apple.com>
commit-queue@webkit.org [Wed, 22 Sep 2010 08:37:01 +0000 (08:37 +0000)]
2010-09-22  Paul Knight  <pknight@apple.com>

        Reviewed by Simon Fraser.

        -[WebView _scheduleCompositingLayerSync] should wake the run loop
        https://bugs.webkit.org/show_bug.cgi?id=46226

        Call CFRunLoopWakeUp to make sure the run loop is not sleeping, which could delay layer painting.

        * WebView/WebView.mm:
        (-[WebView _scheduleCompositingLayerSync]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-22 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 22 Sep 2010 08:23:20 +0000 (08:23 +0000)]
2010-09-22  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [gtk] Use the smart pointers to handle cairo_path_t
        https://bugs.webkit.org/show_bug.cgi?id=46212

        Modified the code to use smart pointers with cairo_path_t
        variables.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::appendPathToCairoContext):
        (WebCore::GraphicsContext::clip):
        (WebCore::GraphicsContext::drawTiledShadow):
        * platform/graphics/cairo/PathCairo.cpp:
        (WebCore::Path::Path):
        (WebCore::Path::operator=):
        (WebCore::Path::apply):
        (WebCore::Path::debugString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-22 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Wed, 22 Sep 2010 08:11:51 +0000 (08:11 +0000)]
2010-09-22  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        [BREWMP] Implement Image::loadPlatformResource
        https://bugs.webkit.org/show_bug.cgi?id=45873

        Load images from the resource directory.

        * platform/graphics/brew/ImageBrew.cpp: Added.
        (WebCore::Image::loadPlatformResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-22 Chris Rogers <crogers@google.com>
crogers@google.com [Wed, 22 Sep 2010 08:10:47 +0000 (08:10 +0000)]
2010-09-22  Chris Rogers  <crogers@google.com>

        Reviewed by James Robinson.

        Add HRTFKernel files
        https://bugs.webkit.org/show_bug.cgi?id=45863

        No new tests since audio API is not yet implemented.

        * platform/audio/HRTFKernel.cpp: Added.
        (WebCore::extractAverageGroupDelay):
        (WebCore::HRTFKernel::HRTFKernel):
        (WebCore::HRTFKernel::createImpulseResponse):
        (WebCore::HRTFKernel::createInterpolatedKernel):
        * platform/audio/HRTFKernel.h: Added.
        (WebCore::HRTFKernel::create):
        (WebCore::HRTFKernel::fftFrame):
        (WebCore::HRTFKernel::fftSize):
        (WebCore::HRTFKernel::frameDelay):
        (WebCore::HRTFKernel::sampleRate):
        (WebCore::HRTFKernel::nyquist):
        (WebCore::HRTFKernel::HRTFKernel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-22 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 22 Sep 2010 08:09:43 +0000 (08:09 +0000)]
2010-09-22  Kent Tamura  <tkent@chromium.org>

        Reviewed by Chris Fleizach.

        Support keyboard operations for <input type=range>.
        https://bugs.webkit.org/show_bug.cgi?id=45803

        * fast/forms/range-keyoperation-expected.txt: Added.
        * fast/forms/range-keyoperation.html: Added.
2010-09-22  Kent Tamura  <tkent@chromium.org>

        Reviewed by Chris Fleizach.

        Support keyboard operations for <input type=range>.
        https://bugs.webkit.org/show_bug.cgi?id=45803

        Increasing the value with Up/Right arrow keys by its step value,
        and decreasing with Down/Left arrow keys. If an input element has
        step=any attribute, increasing/decreasing by 1/100 of max-min.

        Note: This change is not useful on Mac because users can't set
        focus on range controls.

        Test: fast/forms/range-keyoperation.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::defaultEventHandler):
          Calls handleKeyEventForRange() for RANGE and key events.
        (WebCore::HTMLInputElement::handleKeyEventForRange):
        * html/HTMLInputElement.h: Add handleKeyEventForRange() declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-22 Mario Sanchez Prada <msanchez@igalia.com>
commit-queue@webkit.org [Wed, 22 Sep 2010 07:49:34 +0000 (07:49 +0000)]
2010-09-22  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [Gtk] Incorrect exposure of list items whose children are elements
        https://bugs.webkit.org/show_bug.cgi?id=45383

        Check that list items will be always exposed like that for GTK

        * platform/gtk/accessibility/list-items-always-exposed-expected.txt: Added.
        * platform/gtk/accessibility/list-items-always-exposed.html: Added.
2010-09-22  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [Gtk] Incorrect exposure of list items whose children are elements
        https://bugs.webkit.org/show_bug.cgi?id=45383

        Set ATK_ROLE_LIST_ITEM looking for the role of the parent object

        Test: platform/gtk/accessibility/list-items-always-exposed.html

        * accessibility/gtk/AccessibilityObjectAtk.cpp:
        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
        Always include objects with ListItemRole in accessibility for GTK.
        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (getInterfaceMaskFromObject): Add some specific code to handle the
        special case of list markers by implementing AtkText when needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-22 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 22 Sep 2010 07:42:12 +0000 (07:42 +0000)]
2010-09-22  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Make FilterEffects independent of SVG
        https://bugs.webkit.org/show_bug.cgi?id=46177

        Moving all FilterEffects from svg/graphics/filters to platform/graphics/filters, now that they
        are independent of SVG. Removed the SVG prefix of the files and updated the headers.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/filters/DistantLightSource.h: Copied from WebCore/svg/graphics/filters/SVGDistantLightSource.h.
        * platform/graphics/filters/FEConvolveMatrix.cpp: Copied from WebCore/svg/graphics/filters/SVGFEConvolveMatrix.cpp.
        * platform/graphics/filters/FEConvolveMatrix.h: Copied from WebCore/svg/graphics/filters/SVGFEConvolveMatrix.h.
        * platform/graphics/filters/FEDiffuseLighting.cpp: Copied from WebCore/svg/graphics/filters/SVGFEDiffuseLighting.cpp.
        * platform/graphics/filters/FEDiffuseLighting.h: Copied from WebCore/svg/graphics/filters/SVGFEDiffuseLighting.h.
        * platform/graphics/filters/FEDisplacementMap.cpp: Copied from WebCore/svg/graphics/filters/SVGFEDisplacementMap.cpp.
        * platform/graphics/filters/FEDisplacementMap.h: Copied from WebCore/svg/graphics/filters/SVGFEDisplacementMap.h.
        * platform/graphics/filters/FEFlood.cpp: Copied from WebCore/svg/graphics/filters/SVGFEFlood.cpp.
        * platform/graphics/filters/FEFlood.h: Copied from WebCore/svg/graphics/filters/SVGFEFlood.h.
        * platform/graphics/filters/FELighting.cpp: Copied from WebCore/svg/graphics/filters/SVGFELighting.cpp.
        * platform/graphics/filters/FELighting.h: Copied from WebCore/svg/graphics/filters/SVGFELighting.h.
        * platform/graphics/filters/FEMerge.cpp: Copied from WebCore/svg/graphics/filters/SVGFEMerge.cpp.
        * platform/graphics/filters/FEMerge.h: Copied from WebCore/svg/graphics/filters/SVGFEMerge.h.
        * platform/graphics/filters/FEMorphology.cpp: Copied from WebCore/svg/graphics/filters/SVGFEMorphology.cpp.
        * platform/graphics/filters/FEMorphology.h: Copied from WebCore/svg/graphics/filters/SVGFEMorphology.h.
        * platform/graphics/filters/FEOffset.cpp: Copied from WebCore/svg/graphics/filters/SVGFEOffset.cpp.
        * platform/graphics/filters/FEOffset.h: Copied from WebCore/svg/graphics/filters/SVGFEOffset.h.
        * platform/graphics/filters/FESpecularLighting.cpp: Copied from WebCore/svg/graphics/filters/SVGFESpecularLighting.cpp.
        * platform/graphics/filters/FESpecularLighting.h: Copied from WebCore/svg/graphics/filters/SVGFESpecularLighting.h.
        * platform/graphics/filters/FETile.cpp: Copied from WebCore/svg/graphics/filters/SVGFETile.cpp.
        * platform/graphics/filters/FETile.h: Copied from WebCore/svg/graphics/filters/SVGFETile.h.
        * platform/graphics/filters/FETurbulence.cpp: Copied from WebCore/svg/graphics/filters/SVGFETurbulence.cpp.
        * platform/graphics/filters/FETurbulence.h: Copied from WebCore/svg/graphics/filters/SVGFETurbulence.h.
        * platform/graphics/filters/LightSource.cpp: Copied from WebCore/svg/graphics/filters/SVGLightSource.cpp.
        * platform/graphics/filters/LightSource.h: Copied from WebCore/svg/graphics/filters/SVGLightSource.h.
        * platform/graphics/filters/PointLightSource.h: Copied from WebCore/svg/graphics/filters/SVGPointLightSource.h.
        * platform/graphics/filters/SpotLightSource.h: Copied from WebCore/svg/graphics/filters/SVGSpotLightSource.h.
        * svg/SVGFEConvolveMatrixElement.h:
        * svg/SVGFEDiffuseLightingElement.cpp:
        * svg/SVGFEDisplacementMapElement.h:
        * svg/SVGFEDistantLightElement.cpp:
        * svg/SVGFEFloodElement.h:
        * svg/SVGFELightElement.h:
        * svg/SVGFEMergeElement.h:
        * svg/SVGFEMorphologyElement.h:
        * svg/SVGFEOffsetElement.h:
        * svg/SVGFEPointLightElement.cpp:
        * svg/SVGFESpecularLightingElement.h:
        * svg/SVGFESpotLightElement.cpp:
        * svg/SVGFETileElement.h:
        * svg/SVGFETurbulenceElement.h:
        * svg/graphics/filters/SVGDistantLightSource.h: Removed.
        * svg/graphics/filters/SVGFEConvolveMatrix.cpp: Removed.
        * svg/graphics/filters/SVGFEConvolveMatrix.h: Removed.
        * svg/graphics/filters/SVGFEDiffuseLighting.cpp: Removed.
        * svg/graphics/filters/SVGFEDiffuseLighting.h: Removed.
        * svg/graphics/filters/SVGFEDisplacementMap.cpp: Removed.
        * svg/graphics/filters/SVGFEDisplacementMap.h: Removed.
        * svg/graphics/filters/SVGFEFlood.cpp: Removed.
        * svg/graphics/filters/SVGFEFlood.h: Removed.
        * svg/graphics/filters/SVGFELighting.cpp: Removed.
        * svg/graphics/filters/SVGFELighting.h: Removed.
        * svg/graphics/filters/SVGFEMerge.cpp: Removed.
        * svg/graphics/filters/SVGFEMerge.h: Removed.
        * svg/graphics/filters/SVGFEMorphology.cpp: Removed.
        * svg/graphics/filters/SVGFEMorphology.h: Removed.
        * svg/graphics/filters/SVGFEOffset.cpp: Removed.
        * svg/graphics/filters/SVGFEOffset.h: Removed.
        * svg/graphics/filters/SVGFESpecularLighting.cpp: Removed.
        * svg/graphics/filters/SVGFESpecularLighting.h: Removed.
        * svg/graphics/filters/SVGFETile.cpp: Removed.
        * svg/graphics/filters/SVGFETile.h: Removed.
        * svg/graphics/filters/SVGFETurbulence.cpp: Removed.
        * svg/graphics/filters/SVGFETurbulence.h: Removed.
        * svg/graphics/filters/SVGLightSource.cpp: Removed.
        * svg/graphics/filters/SVGLightSource.h: Removed.
        * svg/graphics/filters/SVGPointLightSource.h: Removed.
        * svg/graphics/filters/SVGSpotLightSource.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-22 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Wed, 22 Sep 2010 07:40:40 +0000 (07:40 +0000)]
2010-09-22  Michael Saboff  <msaboff@apple.com>

        Reviewed by Darin Adler.

        New test for ^ (BOL) anchored regular expressions.  Some of the
        tests inspired by https://bugs.webkit.org/show_bug.cgi?id=46049.

        * fast/js/regexp-bol-expected.txt: Added.
        * fast/js/regexp-bol.html: Added.
        * fast/js/script-tests/regexp-bol.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-22 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 22 Sep 2010 07:37:18 +0000 (07:37 +0000)]
2010-09-22  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WIN] Add internetHandle to WebCoreSynchronousLoader.
        https://bugs.webkit.org/show_bug.cgi?id=46185

        For loading content via network the WebCoreSynchronousLoader needs its own (synchronous) internetHandle.
        This also adds asynchronousInternetHandle() to create a static asynchronous internetHandle.

        * platform/network/win/ResourceHandleWin.cpp:
        (WebCore::createInternetHandle):
        (WebCore::asynchronousInternetHandle):
        (WebCore::WebCoreSynchronousLoader::internetHandle):
        (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): Create synchronous internetHandle.
        (WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader): Delete synchronous internetHandle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-22 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Wed, 22 Sep 2010 07:26:19 +0000 (07:26 +0000)]
2010-09-22  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Chris Fleizach.

        [chromium] Remove unused sys/types.h in VDMXParser.cpp
        https://bugs.webkit.org/show_bug.cgi?id=46136

        sys/types.h is not needed here.

        * platform/graphics/chromium/VDMXParser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-22 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Wed, 22 Sep 2010 07:25:03 +0000 (07:25 +0000)]
2010-09-22  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        [BREWMP] Change the home directory path to the WebKit module directory
        https://bugs.webkit.org/show_bug.cgi?id=45895

        AEEFS_HOME_DIR denotes the currently running application's directory.
        Change it to fs:/~<clsid> to use the WebKit module directory as home.

        * platform/brew/FileSystemBrew.cpp:
        (WebCore::homeDirectoryPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-22 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Wed, 22 Sep 2010 07:12:11 +0000 (07:12 +0000)]
2010-09-22  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        [BREWMP] Add dummy Pasteboard
        https://bugs.webkit.org/show_bug.cgi?id=46107

        Pasteboard is not supported yet. Add dummy implementation to avoid link errors.

        * platform/brew/PasteboardBrew.cpp: Added.
        (WebCore::Pasteboard::generalPasteboard):
        (WebCore::Pasteboard::Pasteboard):
        (WebCore::Pasteboard::clear):
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::writePlainText):
        (WebCore::Pasteboard::writeURL):
        (WebCore::Pasteboard::writeImage):
        (WebCore::Pasteboard::canSmartReplace):
        (WebCore::Pasteboard::plainText):
        (WebCore::Pasteboard::documentFragment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 22 Sep 2010 05:56:52 +0000 (05:56 +0000)]
2010-09-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Each EntityMaskIn* needs explanation
        https://bugs.webkit.org/show_bug.cgi?id=44833

        Added a description as to why we escape nbsp when serializing HTML documents but not when serializing XML documents.

        * editing/markup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 22 Sep 2010 05:53:17 +0000 (05:53 +0000)]
2010-09-21  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Check if the acceleratedCompositingEnabled setting is active in WebViewImpl::graphicsContext3D()
        https://bugs.webkit.org/show_bug.cgi?id=46239

        This adds a check for whether acceleratedCompositingEnabled is true on the Page's Settings
        object before creating and vending a GraphicsContext3D object.  This is needed because when
        an offscreen WebGraphicsContext3DCommandBufferImpl is initialized it first asks the WebViewImpl
        for the compositor context.  WebGraphicsContext3DCommandBufferImpl::initialize checks if the
        disable accelerated compositing command line switch is set, but this is insufficient as sometimes
        the Setting object does not agree exactly with the command line switches.  For example,
        we explicitly toggle accelerated compositing for some chrome UI URLs regardless of what the
        flag says.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::graphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 22 Sep 2010 05:36:45 +0000 (05:36 +0000)]
2010-09-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        cleanup: removeInlineStyleFromElement and extractInlineStyleToPushDown should be merged
        https://bugs.webkit.org/show_bug.cgi?id=46205

        Cleanup required to fix the bug 27818. Added the style extraction mechanism to removeInlineStyleFromElement
        and removeCSSStyle and replaced the call to extractInlineStyleToPushDown by a call to removeInlineStyleFromElement.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added extractedStyle argument.
        (WebCore::ApplyStyleCommand::removeCSSStyle): Added extractedStyle argument.
        (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls removeInlineStyleFromElement instead of
        extractInlineStyleToPushDown which has been deleted.
        * editing/ApplyStyleCommand.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 22 Sep 2010 05:22:27 +0000 (05:22 +0000)]
2010-09-21  Kent Tamura  <tkent@chromium.org>

        Unreviewed, text expectation update.

        * platform/chromium/drt_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 22 Sep 2010 03:45:35 +0000 (03:45 +0000)]
2010-09-21  Kent Tamura  <tkent@chromium.org>

        Reviewed by David Levin.

        [Chromium] Remove WebInputElement::InputType and inputType()
        https://bugs.webkit.org/show_bug.cgi?id=46238

        * DEPS: Roll Chromium revision to 60132, which removed all usage of inputType().
        * public/WebInputElement.h: Remove InputType and inputType().
        * src/AssertMatchingEnums.cpp: Remove WebInputElement::InputType -
          HTMLInputElement::InputType matching tests.
        * src/WebInputElement.cpp: Remove inputType().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 22 Sep 2010 03:35:51 +0000 (03:35 +0000)]
2010-09-21  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        * platform/chromium/drt_expectations.txt:
          Remove passing tests, and fix typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 22 Sep 2010 03:31:56 +0000 (03:31 +0000)]
2010-09-21  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        * platform/chromium/drt_expectations.txt: Update DRT results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 22 Sep 2010 03:13:38 +0000 (03:13 +0000)]
2010-09-21  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.

        new-run-webkit-tests: fix bug introduced in r68008 where if you
        specify --chromium and no --platform, and you're running on
        windows, you use the 'chromium-win' port by default instead of the
        version-specific port. This breaks the buildbots.

        It will be good for this refactoring to settle down so I can
        rewrite the logic for default ports and the unit tests to be
        clearer (and the testing more comprehensive).

        * Scripts/webkitpy/layout_tests/port/chromium_win.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 22 Sep 2010 02:24:51 +0000 (02:24 +0000)]
2010-09-21  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        Modify the Port interface to take only a series of keyword arguments
        in the constructor, and modify Port/factory.get() to accomodate that,
        and to accept user=XXX as an argument so we can pass
        webkitpy.common.system.user.User objects in.

        Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
        to use the common routine in webkitpy.common.system.user.open_url()
        to display HTML files.

        There was a routine in the Port interface to do the same thing,
        but I see no need for a port-specific hook for this, since it is
        something that will always be executed by the host environment
        and displaying web pages has nothing to do with running layout tests.

        Note that new-run-webkit-tests used to use test_shell to display
        the page; this is potentially useful so that you can actually click
        from a result to the broken page; however, since DumpRenderTree
        doesn't support this functionality, it will be going away eventually.

        https://bugs.webkit.org/show_bug.cgi?id=46128

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/dryrun.py:
        * Scripts/webkitpy/layout_tests/port/factory.py:
        * Scripts/webkitpy/layout_tests/port/google_chrome.py:
        * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
        * Scripts/webkitpy/layout_tests/port/gtk.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/qt.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/win.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 22 Sep 2010 01:22:25 +0000 (01:22 +0000)]
2010-09-21  Oliver Hunt  <oliver@apple.com>

        RS=Gavin Barraclough.

        Fix codeblock dumping

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        * runtime/Executable.h:
        (JSC::ScriptExecutable::ScriptExecutable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert "2010-09-21 Chris Guillory <chris.guillory@google.com>"
atwilson@chromium.org [Wed, 22 Sep 2010 01:10:54 +0000 (01:10 +0000)]
Revert "2010-09-21  Chris Guillory   <chris.guillory@google.com>"

This reverts commit 347aab9430be62b827cd1130adbfdf99d18bfaf0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Cosmin Truta <ctruta@chromium.org>
jamesr@google.com [Wed, 22 Sep 2010 01:08:21 +0000 (01:08 +0000)]
2010-09-21  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by James Robinson.

        RenderImage::intrinsicSizeChanged crashes when m_imageResource is missing
        https://bugs.webkit.org/show_bug.cgi?id=46120

        Test a style change applied to a zoomed image.

        * css3/style-zoomed-image.html: Added.
        * css3/style-zoomed-image-expected.txt: Added.
2010-09-21  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by James Robinson.

        RenderImage::intrinsicSizeChanged crashes when m_imageResource is missing
        https://bugs.webkit.org/show_bug.cgi?id=46120

        Avoid applying operator -> to m_imageResource when its underlying pointer is NULL.

        * rendering/RenderImage.h:
        (WebCore::RenderImage::intrinsicSizeChanged): Checked m_imageResource.
        * html/HTMLImageElement.cpp:
        (HTMLImageElement::createRenderer): Fixed indentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdated test after r67994.
mitz@apple.com [Wed, 22 Sep 2010 01:07:13 +0000 (01:07 +0000)]
Updated test after r67994.

Reviewed by Geoffrey Garen.

* fast/dom/Range/range-expand.html: Do not expect sentence selections to include
trailing newline characters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Lucas De Marchi <lucas.demarchi@profusion.mobi>
demarchi@webkit.org [Wed, 22 Sep 2010 00:38:41 +0000 (00:38 +0000)]
2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Get fresh theme when running EWebLauncher
        https://bugs.webkit.org/show_bug.cgi?id=46210

        If user tried to run EWebLauncher outside of the build tree, it would
        not find the theme and fallback to the installed one. However, since
        EWebLauncher is not installed, we always want to take the theme from
        the just compiled source code. If user had never installed WebKit's
        EFL port it could even receive a segv since no theme would be found.

        Now EWebLauncher does not fallback to the installed theme and CMake
        gives as DATA_DIR the directory of the theme it has just built.

        * CMakeListsEfl.txt: export DATA_DIR to parent CMakeLists.txt in order
        to be used by EWebLauncher.
2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Get fresh theme when running EWebLauncher
        https://bugs.webkit.org/show_bug.cgi?id=46210

        If user tried to run EWebLauncher outside of the build tree, it would
        not find the theme and fallback to the installed one. However, since
        EWebLauncher is not installed, we always want to take the theme from
        the just compiled source code. If user had never installed WebKit's
        EFL port it could even receive a segv since no theme would be found.

        Now EWebLauncher does not fallback to the installed theme and CMake
        gives as DATA_DIR the directory of the theme it has just built.

        * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
        EWebLauncher.
        * EWebLauncher/main.c: Use only the theme from build director. Do not
        fallback to others as this could hide real bugs.
        (quit):
        (browserCreate):
        (findThemePath):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 John Gregg <johnnyg@google.com>
johnnyg@google.com [Wed, 22 Sep 2010 00:35:23 +0000 (00:35 +0000)]
2010-09-21  John Gregg  <johnnyg@google.com>

        Unreviewed, chromium test expecations.

        [chromium] update test expectations
        https://bugs.webkit.org/show_bug.cgi?id=46235

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 22 Sep 2010 00:34:32 +0000 (00:34 +0000)]
2010-09-21  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        [chromium] Remove GLES2Context and WebGLES2Context
        https://bugs.webkit.org/show_bug.cgi?id=46131

        Removed now-obsolete GLES2Context and WebGLES2Context classes, and
        dependency on command buffer client code from WebCore. Built and
        tested 3D CSS and WebGL content on Mac OS X to test.

        * WebKit.gyp:
        * public/WebGLES2Context.h: Removed.
        * public/WebGraphicsContext3D.h:
        * public/WebKitClient.h:
        * public/WebView.h:
        * src/ChromeClientImpl.cpp:
        * src/GLES2Context.cpp: Removed.
        * src/GLES2ContextInternal.cpp: Removed.
        * src/GLES2ContextInternal.h: Removed.
        * src/WebGraphicsContext3DDefaultImpl.cpp:
        * src/WebGraphicsContext3DDefaultImpl.h:
        * src/WebViewImpl.cpp:
        * src/WebViewImpl.h:
2010-09-21  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        [chromium] Remove GLES2Context and WebGLES2Context
        https://bugs.webkit.org/show_bug.cgi?id=46131

        Removed now-obsolete GLES2Context and WebGLES2Context classes, and
        dependency on command buffer client code from WebCore. Built and
        tested 3D CSS and WebGL content on Mac OS X to test.

        * WebCore.gypi:
        * platform/chromium/GLES2Context.h: Removed.
        * platform/graphics/skia/ImageSkia.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 22 Sep 2010 00:33:05 +0000 (00:33 +0000)]
2010-09-21  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.

        Don't pass the --test-shell arg to the Chromium Mac port of DRT;
        it just confuses it.

        https://bugs.webkit.org/show_bug.cgi?id=46230

        * Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix the Windows build.
ggaren@apple.com [Wed, 22 Sep 2010 00:31:49 +0000 (00:31 +0000)]
Try to fix the Windows build.

* loader/Cache.cpp:
(WebCore::Cache::makeResourcePurgeable):
(WebCore::Cache::evict): Cast to int before using unary '-', to avoid an
MSVC warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd DirectX SDK include path.
sfalken@apple.com [Wed, 22 Sep 2010 00:27:24 +0000 (00:27 +0000)]
Add DirectX SDK include path.

Rubber stamped by Simon Fraser.

* win/WebKit2DirectX.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse purgeable memory to keep more dead resources in cache
ggaren@apple.com [Wed, 22 Sep 2010 00:18:03 +0000 (00:18 +0000)]
Use purgeable memory to keep more dead resources in cache
https://bugs.webkit.org/show_bug.cgi?id=44806
<rdar://problem/8350901>

Patch by Pratik Solanki <psolanki@apple.com> on 2010-09-21
Reviewed by Geoffrey Garen and Darin Adler.

This changes the behavior of dead resources in the WebCore cache to be the following if
shouldMakeResourcePurgeableOnEviction() returns true.

1. Dead resources in the cache are kept in non-purgeable memory.
2. When we prune dead resources, instead of freeing them, we mark their memory as purgeable
and keep the resources until the kernel reclaims the purgeable memory.

By leaving the in-cache dead resources in dirty resident memory, we decrease the likelihood
of the kernel claiming that memory and forcing us to refetch the resource (for example when
a user presses back).

And by having an unbounded number of resource objects using purgeable memory, we can use
as much memory as is available on the machine. The trade-off is that the CachedResource
object (and its member variables) are allocated in non-purgeable TC-malloc'd memory so
we would see slightly more memory use due to this.

* loader/Cache.cpp:
(WebCore::Cache::resourceForURL): Adjust sizes appropriately if we made resource memory
non-purgeable.
(WebCore::Cache::pruneDeadResources): When removing dead resources, try first to mark their
memory as purgeable. If not, evict the resource.
(WebCore::Cache::makeResourcePurgeable): Added. Try to mark resource
memory as purgeable. If successful, adjust the sizes so that we don't
factor this resources size in the Cache size calculation.
(WebCore::Cache::evict): Don't decrement size if we already did it in makeResourcePurgeable.
(WebCore::Cache::dumpLRULists): Extra debug logging.
* loader/Cache.h:
(WebCore::Cache::shouldMakeResourcePurgeableOnEviction): Added. Indicates if the new
behaviour is enabled.
* loader/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::allClientsRemoved): Do not mark memory as purgeable. The
Cache class takes care of this.
* loader/CachedImage.cpp:
(WebCore::CachedImage::destroyDecodedData): Ditto.
* loader/CachedScript.cpp:
(WebCore::CachedScript::destroyDecodedData): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake a new buildbot for Leopard Debug Test
slewis@apple.com [Wed, 22 Sep 2010 00:17:03 +0000 (00:17 +0000)]
Make a new buildbot for Leopard Debug Test

Reviewed by Stephanie Lewis.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7729077> Extending the selection to sentence boundary after a line...
mitz@apple.com [Wed, 22 Sep 2010 00:13:37 +0000 (00:13 +0000)]
<rdar://problem/7729077> Extending the selection to sentence boundary after a line break may select extra character
https://bugs.webkit.org/show_bug.cgi?id=46232

Reviewed by Darin Adler.

WebCore:

Test: editing/selection/extend-by-sentence-002.html

* editing/visible_units.cpp:
(WebCore::nextBoundary): The text iterator’s range end can be the position after
the line break, in which case the next visible is actually after the first character
of the next sentence. Instead, advance the text iterator past the newline character
and return the beginning of its range, which is guaranteed to still be before the
next sentence.

LayoutTests:

* editing/selection/extend-by-sentence-002-expected.txt: Added.
* editing/selection/extend-by-sentence-002.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 22 Sep 2010 00:06:58 +0000 (00:06 +0000)]
2010-09-21  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.

        Fix breakage of Chromium Mac DRT port caused by r67905.

        https://bugs.webkit.org/show_bug.cgi?id=46230

        * Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 21 Sep 2010 23:59:53 +0000 (23:59 +0000)]
2010-09-21  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        [chromium] Roll forward Chromium DEPS to pick up removal of WebGLES2Context dependencies
        https://bugs.webkit.org/show_bug.cgi?id=46231

        Ran build-webkit --chromium --debug on Mac OS X to test the roll-forward.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoForward window focus changes to the plug-in
andersca@apple.com [Tue, 21 Sep 2010 23:39:53 +0000 (23:39 +0000)]
Forward window focus changes to the plug-in
https://bugs.webkit.org/show_bug.cgi?id=46227

Reviewed by Dan Bernstein.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::windowFocusChanged):
Send the NPCocoaEventWindowFocusChanged event.

(WebKit::NetscapePlugin::windowFrameChanged):
(WebKit::NetscapePlugin::windowVisibilityChanged):
Add stubs.

* WebProcess/Plugins/Plugin.h:
Add windowFocusChanged, windowFrameChanged and windowVisibilityChanged.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::webPage):
Make webPage a member function instead.

(WebKit::PluginView::setWindowIsFocused):
Call the plug-in member function.

(WebKit::PluginView::initializePlugin):
When the plug-in has been initialized, update its window frame, window visibility
and window focus states.

(WebKit::PluginView::setParent):
Move viewGeometryDidChange to initializePlugin.

* WebProcess/Plugins/PluginView.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setActive):
Tell all plug-in views about the new window focus state.

(WebKit::WebPage::windowIsFocused):
Return whether the window is focused or not.

* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::windowIsVisible):
(WebKit::WebPage::windowFrame):
Add getters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 21 Sep 2010 23:19:53 +0000 (23:19 +0000)]
2010-09-21  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Speed up function.apply(..., arguments)
        https://bugs.webkit.org/show_bug.cgi?id=46207

        Add code to do argument copying inline in the case
        where we're using Function.apply to forward our arguments
        directly.

        * jit/JIT.cpp:
        (JSC::JIT::privateCompileSlowCases):
           Splitted op_load_varargs into fast and slow paths, so add the call
           to the slow path generator.
        * jit/JIT.h:
        * jit/JITCall32_64.cpp:
          Remove 32bit specific emit_op_load_varargs as the logic is the
          same for all value representations
        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_load_varargs):
          Copy arguments inline
        (JSC::JIT::emitSlow_op_load_varargs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Robert Hogan <robert@webkit.org>
robert@webkit.org [Tue, 21 Sep 2010 22:27:17 +0000 (22:27 +0000)]
2010-09-21  Robert Hogan  <robert@webkit.org>

        Rubber-stamped by Ariya Hidayat.

        [Qt] Build fix against qt trunk

        * platform/graphics/qt/ContextShadow.cpp:
        (WebCore::ContextShadow::beginShadowLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 21 Sep 2010 21:04:02 +0000 (21:04 +0000)]
2010-09-21  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        [Chromium] Plumb the IDBTransansaction's id
        https://bugs.webkit.org/show_bug.cgi?id=46197

        Next step, add the plumbing to Chromium.  Then we add code to WebKit
        that uses it (and take out the default IDBTransaction param).

        * public/WebIDBCursor.h:
        (WebKit::WebIDBCursor::key):
        (WebKit::WebIDBCursor::value):
        * public/WebIDBFactory.h:
        (WebKit::WebIDBFactory::open):
        * public/WebIDBIndex.h:
        (WebKit::WebIDBIndex::openObjectCursor):
        (WebKit::WebIDBIndex::openCursor):
        (WebKit::WebIDBIndex::getObject):
        (WebKit::WebIDBIndex::get):
        * public/WebIDBObjectStore.h:
        (WebKit::WebIDBObjectStore::get):
        (WebKit::WebIDBObjectStore::put):
        (WebKit::WebIDBObjectStore::remove):
        (WebKit::WebIDBObjectStore::createIndex):
        (WebKit::WebIDBObjectStore::removeIndex):
        (WebKit::WebIDBObjectStore::openCursor):
        * src/WebIDBIndexImpl.cpp:
        (WebKit::WebIDBIndexImpl::openCursor):
        (WebKit::WebIDBIndexImpl::openObjectCursor):
        (WebKit::WebIDBIndexImpl::getObject):
        (WebKit::WebIDBIndexImpl::get):
        * src/WebIDBIndexImpl.h:
        * src/WebIDBObjectStoreImpl.cpp:
        (WebKit::WebIDBObjectStoreImpl::get):
        (WebKit::WebIDBObjectStoreImpl::put):
        (WebKit::WebIDBObjectStoreImpl::remove):
        (WebKit::WebIDBObjectStoreImpl::openCursor):
        * src/WebIDBObjectStoreImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 21 Sep 2010 21:00:30 +0000 (21:00 +0000)]
2010-09-21  Tony Chang  <tony@chromium.org>

        Unreviewed, QT build fix.

        * platform/qt/ClipboardQt.cpp:
        (WebCore::ClipboardQt::ClipboardQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoHandle booleans in injected bundle messages
andersca@apple.com [Tue, 21 Sep 2010 20:51:05 +0000 (20:51 +0000)]
Handle booleans in injected bundle messages
https://bugs.webkit.org/show_bug.cgi?id=46213

Reviewed by John Sullivan.

* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Andy Estes <aestes@apple.com>
aestes@apple.com [Tue, 21 Sep 2010 20:43:51 +0000 (20:43 +0000)]
2010-09-21  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r61285): AIM 2.1.296: Code rendered as text in Welcome screen
        https://bugs.webkit.org/show_bug.cgi?id=46134

        AIM clients linked against versions of WebKit prior to the introduction
        of the HTML5 parser contain markup incompatible with the new parser.
        Enable parser quirks in this case to remain compatible with these
        clients.

        * WebView/WebView.mm:
        (shouldUsePreHTML5ParserQuirks): Returns true if the embedding
        application is AIM and was linked against a version of WebKit prior to
        the introduction of the HTML5 parser, or if the
        WebKitPreHTML5ParserQuirks WebPreference is enabled.
        (-[WebView _preferencesChangedNotification:]): Call
        WebCore::Settings::setUsePreHTML5ParserQuirks().
2010-09-21  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (r61285): AIM 2.1.296: Code rendered as text in Welcome screen
        https://bugs.webkit.org/show_bug.cgi?id=46134

        * WebCore.exp.in: Export __ZN7WebCore32applicationIsAOLInstantMessengerEv.
        * platform/mac/RuntimeApplicationChecks.h:
        * platform/mac/RuntimeApplicationChecks.mm:
        (WebCore::applicationIsAOLInstantMessenger): Determine if the embedding
        application is AOL Instant Messenger by checking the bundle identifier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Chris Guillory <chris.guillory@google.com>
commit-queue@webkit.org [Tue, 21 Sep 2010 20:22:15 +0000 (20:22 +0000)]
2010-09-21  Chris Guillory   <chris.guillory@google.com>

        Reviewed by Chris Fleizach.

        Send webkit accessibility notifications to Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=45156

        * platform/chromium/accessibility/post-notification-ActiveDescendantChanged-expected.txt:
        * platform/chromium/accessibility/post-notification-CheckedStateChanged-expected.txt:
        * platform/chromium/accessibility/post-notification-ChildrenChanged-expected.txt:
        * platform/chromium/accessibility/post-notification-FocusedUIElementChanged-expected.txt:
        * platform/chromium/accessibility/post-notification-FocusedUIElementChanged.html:
        * platform/chromium/accessibility/post-notification-LayoutComplete-expected.txt:
        * platform/chromium/accessibility/post-notification-LayoutComplete.html:
        * platform/chromium/accessibility/post-notification-LiveRegionChanged-expected.txt:
        * platform/chromium/accessibility/post-notification-LoadComplete-expected.txt:
        * platform/chromium/accessibility/post-notification-LoadComplete.html:
        * platform/chromium/accessibility/post-notification-MenuListValueChanged-expected.txt:
        * platform/chromium/accessibility/post-notification-RowCollapsed-expected.txt:
        * platform/chromium/accessibility/post-notification-RowCountChanged-expected.txt:
        * platform/chromium/accessibility/post-notification-RowExpanded-expected.txt:
        * platform/chromium/accessibility/post-notification-ScrolledToAnchor-expected.txt:
        * platform/chromium/accessibility/post-notification-ScrolledToAnchor.html:
        * platform/chromium/accessibility/post-notification-SelectedChildrenChanged-expected.txt:
        * platform/chromium/accessibility/post-notification-SelectedTextChanged-expected.txt:
        * platform/chromium/accessibility/post-notification-SelectedTextChanged.html:
        * platform/chromium/accessibility/post-notification-ValueChanged-expected.txt:
        * platform/chromium/accessibility/post-notification.js:
        (test):
2010-09-21  Chris Guillory   <chris.guillory@google.com>

        Reviewed by Chris Fleizach.

        Send webkit accessibility notifications to Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=45156

        * WebCore.gypi:
        * accessibility/chromium/AXObjectCacheChromium.cpp:
        (WebCore::AXObjectCache::postPlatformNotification):
        (WebCore::AXObjectCache::handleFocusedUIElementChanged):
        (WebCore::AXObjectCache::handleScrolledToAnchor):
        * dom/Document.cpp:
        (WebCore::Document::implicitClose):
        (WebCore::Document::setFocusedNode):
        * editing/SelectionController.h:
        * editing/chromium/SelectionControllerChromium.cpp: Added.
        (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        * page/chromium/ChromeClientChromium.h:
2010-09-21  Chris Guillory   <chris.guillory@google.com>

        Reviewed by Chris Fleizach.

        Send webkit accessibility notifications to Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=45156

        * public/WebAccessibilityCache.h:
        * public/WebViewClient.h:
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::focusedNodeChanged):
        (WebKit::ChromeClientImpl::getPopupMenuInfo):
        * src/ChromeClientImpl.h:
        * src/WebAccessibilityCache.cpp:
        (WebKit::WebAccessibilityCache::accessibilityEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Tue, 21 Sep 2010 20:21:27 +0000 (20:21 +0000)]
2010-09-21  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [gtk] Move copyContextProperties outside the GraphicsContextCairo
        https://bugs.webkit.org/show_bug.cgi?id=46179.

        Moved the copyContextProperties function to the CairoUtilities so
        we can use it outside GraphicsContextCairo. We moved also the old
        gtk CairoUtilities file to GdkCairoUtilities and added the new
        file in the cairo directory.

        * GNUmakefile.am:
        * platform/graphics/cairo/CairoUtilities.cpp: Added.
        (WebCore::copyContextProperties):
        * platform/graphics/cairo/CairoUtilities.h: Added.
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        * platform/graphics/gtk/CairoUtilities.cpp: Removed.
        * platform/graphics/gtk/CairoUtilities.h: Removed.
        * platform/graphics/gtk/GdkCairoUtilities.cpp: Added.
        (getCairoSurfacePixel):
        (getGdkPixbufPixel):
        (cairoImageSurfaceToGdkPixbuf):
        * platform/graphics/gtk/GdkCairoUtilities.h: Added.
        * platform/graphics/gtk/ImageBufferGtk.cpp:
        * platform/graphics/gtk/ImageGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed chromium expectations update.
atwilson@chromium.org [Tue, 21 Sep 2010 20:20:48 +0000 (20:20 +0000)]
Unreviewed chromium expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2 should look for WebKit2WebProcess.exe next to WebKit.dll
bweinstein@apple.com [Tue, 21 Sep 2010 20:19:42 +0000 (20:19 +0000)]
WebKit2 should look for WebKit2WebProcess.exe next to WebKit.dll
https://bugs.webkit.org/show_bug.cgi?id=46209
<rdar://problem/8445639>

Reviewed by Adam Roben.

Find WebKit2WebProcess.exe by getting the full path to WebKit.dll, and then
removing the last path component and replacing it with WebKit2WebProcess.exe.

* UIProcess/Launcher/win/ProcessLauncherWin.cpp:
(WebKit::ProcessLauncher::launchProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 21 Sep 2010 20:06:10 +0000 (20:06 +0000)]
2010-09-21  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.

        Add missing import of 'tempfile'.

        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Tue, 21 Sep 2010 19:48:49 +0000 (19:48 +0000)]
2010-09-21  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by James Robinson.

        [chromium] Cleaned up LayerRendererChromium::prepareToDrawLayers
        logic to avoid unnecessary copy operations if the existing root layer
        contents aren't useful for scrolling. Also removed call to updateLayersRecursive()
        as the composited layer update is actually happening in the drawLayers() method.
        https://bugs.webkit.org/show_bug.cgi?id=46199

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::prepareToDrawLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 21 Sep 2010 19:47:31 +0000 (19:47 +0000)]
2010-09-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        stray param elements are dropped during parsing
        https://bugs.webkit.org/show_bug.cgi?id=14551

        This bug was fixed by the HTML5 parser.  Add tests from bug.

        * fast/parser/stray-param-expected.txt: Added.
        * fast/parser/stray-param.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 21 Sep 2010 19:37:13 +0000 (19:37 +0000)]
2010-09-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        [html-parsing] make entity handling match IE7 / HTML5
        https://bugs.webkit.org/show_bug.cgi?id=14391

        This patch adds more test coverage of entity parsing.  We seem to have
        a bug with AElig, but I'll fix that in a future patch.

        * fast/tokenizer/entities-01.html: Added.
        * fast/tokenizer/entities-02.html: Added.
        * fast/tokenizer/entities-03.html: Added.
        * fast/tokenizer/entities-04.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 21 Sep 2010 19:11:35 +0000 (19:11 +0000)]
2010-09-17  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: pull the list of tests from the Port, and
           make it possible to run with no actual test files in the filesystem.

        This set of changes allows us to delete the special
        webkitpy/layout_tests/data directory and test the generic code without
        touching the filesystem (except to write results). This speeds up
        test-webkitpy substantially.

        This also cleans up and removes several code paths in the generic
        code and fixes some minor bugs, notably in the test_expectations
        parsing, which was previously fragile if the tests weren't present.

        We also change the way we diff image results to be able to do so
        in memory, without relying on files. This slows down chromium
        test_shell, which always writes images to files, but should speed
        up DRT and ImageDiff-based implementations slightly.

        Note that pulling the list of tests to run from the Port will allow
        ports to specify what tests to run as an inclusive list; previously
        you could only do this as an exclusive list by using a
        test_expectations file or Skipped files; nothing actually uses this
        feature yet and it's unclear if it should be used.

        Note that there are no functional changes -- apart from now
        always printing out the location of the checksum file when we are
        tracing test runs -- and the total number of lines of non-test code
        actually drops by two.

        There is some more cleanup that can be done in the Port/Driver
        interface and in some handling of filenames, but I'll save that
        for another change.

        https://bugs.webkit.org/show_bug.cgi?id=45801

        * Scripts/webkitpy/layout_tests/data/*: Removed.
            - no longer need special mock layout_tests_directory in the
              repository.
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
            - add code to display missing text files, checksums when tracing
            - update to not look at the filesystem directly.
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
            - add more unit tests
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
            - remove tests_are_present flag
            - update with changes in Port interface - no longer access
              the filesystem directly, although we still use os.path for
              filename manipulation.
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
            - add more unit tests
        * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
            - renamed to port/test_files.py
        * Scripts/webkitpy/layout_tests/port/base.py:
            - change diff_image() to expect actual image data, not filenames
            - add expected_checksum(), expected_image(), expected_text() to
              return the content of the files so that we don't need a filesystem
            - add path_exists(), path_isdir() for filesystem-like access.
            - add test_dirs() to keep clobber-test-results from needing to
              actually look at a real layout tests dir
            - add tests() to return the list of tests to run on the port
              (calls port/test_files to do the work).
            - add update_baseline() to be able to save new baselines
            - add uri_to_test_name() from port/dryrun.py so we can easily check
              filename_to_uri()
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
            - add more unit tests
        * Scripts/webkitpy/layout_tests/port/chromium.py:
            - change diff_image() to accept image content, not filenames.
              This will be slower for test_shell/image_diff, but faster
              for DRT/ImageDiff.
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
            - add more unit tests
        * Scripts/webkitpy/layout_tests/port/dryrun.py:
            - simplify greatly
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
            - add more unit tests
        * Scripts/webkitpy/layout_tests/port/test.py:
            - massive rewrite to use in-script list of tests and expectations
        * Scripts/webkitpy/layout_tests/port/test_files.py:
            - rename from layout_package/test_files.
        * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
            - add unit tests
        * Scripts/webkitpy/layout_tests/port/webkit.py:
            - update diff_image() to take image contents, not files. Should
              make things slightly faster.
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
            - update with changes to diff_image()
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
            - update with changes to diff_image()
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
            - remove tests_are_present from test_expectations
            - pull the list of tests from port.tests() instead
              of calling test_files.py directly.
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
            - update unit tests
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
            - update with changes to
        * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
            - update with change in Port interface
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
            - update with change in Port interface
        * Scripts/webkitpy/style/checkers/test_expectations.py:
            - remove the tests_are_present flag

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Daniel Cheng <dcheng@chromium.org>
commit-queue@webkit.org [Tue, 21 Sep 2010 18:50:16 +0000 (18:50 +0000)]
2010-09-21  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Tony Chang.

        Change Clipboard to use an enum instead of isForDragging = true/false
        https://bugs.webkit.org/show_bug.cgi?id=46004

        No new tests, since it's just a refactoring change.

        * bindings/js/JSClipboardCustom.cpp:
        (WebCore::JSClipboard::setDragImage):
        * bindings/v8/custom/V8ClipboardCustom.cpp:
        (WebCore::V8Clipboard::setDragImageCallback):
        * dom/Clipboard.cpp:
        (WebCore::Clipboard::Clipboard):
        (WebCore::Clipboard::setDropEffect):
        (WebCore::Clipboard::setEffectAllowed):
        * dom/Clipboard.h:
        (WebCore::Clipboard::isForCopyAndPaste):
        (WebCore::Clipboard::isForDragAndDrop):
        * editing/android/EditorAndroid.cpp:
        (WebCore::Editor::newGeneralClipboard):
        * editing/brew/EditorBrew.cpp:
        (WebCore::Editor::newGeneralClipboard):
        * editing/chromium/EditorChromium.cpp:
        (WebCore::Editor::newGeneralClipboard):
        * editing/haiku/EditorHaiku.cpp:
        (WebCore::Editor::newGeneralClipboard):
        * editing/mac/EditorMac.mm:
        (WebCore::Editor::newGeneralClipboard):
        * editing/wx/EditorWx.cpp:
        (WebCore::Editor::newGeneralClipboard):
        * page/chromium/EventHandlerChromium.cpp:
        (WebCore::EventHandler::createDraggingClipboard):
        * page/efl/EventHandlerEfl.cpp:
        (WebCore::EventHandler::createDraggingClipboard):
        * page/gtk/EventHandlerGtk.cpp:
        (WebCore::EventHandler::createDraggingClipboard):
        * page/haiku/EventHandlerHaiku.cpp:
        (WebCore::EventHandler::createDraggingClipboard):
        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::createDraggingClipboard):
        * page/qt/EventHandlerQt.cpp:
        (WebCore::EventHandler::createDraggingClipboard):
        * page/win/EventHandlerWin.cpp:
        (WebCore::EventHandler::createDraggingClipboard):
        * page/wx/EventHandlerWx.cpp:
        (WebCore::EventHandler::createDraggingClipboard):
        * platform/android/ClipboardAndroid.cpp:
        (WebCore::ClipboardAndroid::ClipboardAndroid):
        (WebCore::ClipboardAndroid::clearData):
        (WebCore::ClipboardAndroid::clearAllData):
        (WebCore::ClipboardAndroid::setData):
        * platform/android/ClipboardAndroid.h:
        * platform/brew/ClipboardBrew.cpp:
        (WebCore::ClipboardBrew::ClipboardBrew):
        (WebCore::ClipboardBrew::clearData):
        (WebCore::ClipboardBrew::clearAllData):
        (WebCore::ClipboardBrew::setData):
        * platform/brew/ClipboardBrew.h:
        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::Clipboard::create):
        (WebCore::ClipboardChromium::ClipboardChromium):
        (WebCore::ClipboardChromium::create):
        (WebCore::ClipboardChromium::getData):
        * platform/chromium/ClipboardChromium.h:
        * platform/efl/ClipboardEfl.cpp:
        (WebCore::Editor::newGeneralClipboard):
        (WebCore::ClipboardEfl::ClipboardEfl):
        * platform/efl/ClipboardEfl.h:
        (WebCore::ClipboardEfl::create):
        * platform/gtk/ClipboardGtk.cpp:
        (WebCore::Editor::newGeneralClipboard):
        (WebCore::Clipboard::create):
        (WebCore::ClipboardGtk::ClipboardGtk):
        (WebCore::dataObjectTypeFromHTMLClipboardType):
        (WebCore::ClipboardGtk::clearData):
        (WebCore::ClipboardGtk::getData):
        (WebCore::ClipboardGtk::setData):
        * platform/gtk/ClipboardGtk.h:
        (WebCore::ClipboardGtk::create):
        * platform/haiku/ClipboardHaiku.cpp:
        (WebCore::Clipboard::create):
        (WebCore::ClipboardHaiku::ClipboardHaiku):
        * platform/haiku/ClipboardHaiku.h:
        (WebCore::ClipboardHaiku::create):
        * platform/mac/ClipboardMac.h:
        (WebCore::ClipboardMac::create):
        * platform/mac/ClipboardMac.mm:
        (WebCore::Clipboard::create):
        (WebCore::ClipboardMac::ClipboardMac):
        * platform/qt/ClipboardQt.cpp:
        (WebCore::ClipboardQt::ClipboardQt):
        (WebCore::ClipboardQt::~ClipboardQt):
        (WebCore::ClipboardQt::clearData):
        (WebCore::ClipboardQt::clearAllData):
        (WebCore::ClipboardQt::setData):
        (WebCore::ClipboardQt::declareAndWriteDragImage):
        (WebCore::ClipboardQt::writeURL):
        (WebCore::ClipboardQt::writeRange):
        (WebCore::ClipboardQt::writePlainText):
        * platform/qt/ClipboardQt.h:
        (WebCore::ClipboardQt::create):
        * platform/win/ClipboardWin.cpp:
        (WebCore::Clipboard::create):
        (WebCore::ClipboardWin::ClipboardWin):
        (WebCore::ClipboardWin::clearData):
        (WebCore::ClipboardWin::clearAllData):
        (WebCore::ClipboardWin::setData):
        (WebCore::ClipboardWin::setExternalDataObject):
        * platform/win/ClipboardWin.h:
        (WebCore::ClipboardWin::create):
        * platform/win/EditorWin.cpp:
        (WebCore::Editor::newGeneralClipboard):
        * platform/wx/ClipboardWx.cpp:
        (WebCore::ClipboardWx::ClipboardWx):
        * platform/wx/ClipboardWx.h:
        (WebCore::ClipboardWx::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 21 Sep 2010 18:43:09 +0000 (18:43 +0000)]
2010-09-21  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/8363003> REGRESSION: ~1.4% sunspider regression in
        interpreter due to 54724 and 54596

        Fixed a typo (using "UNLIKELY" instead of "LIKELY").

        * wtf/PassRefPtr.h:
        (WTF::refIfNotNull):
        (WTF::derefIfNotNull): It is likely that m_ptr != 0 because most RefPtrs
        hold real data. Also, in cases where they do not hold real data, the
        compiler usually sees a call to release() right before the call to the
        destructor, so it can probably optimize out the test completely.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSend window visibility and window frame change sizes to the plug-in
andersca@apple.com [Tue, 21 Sep 2010 18:42:47 +0000 (18:42 +0000)]
Send window visibility and window frame change sizes to the plug-in
https://bugs.webkit.org/show_bug.cgi?id=46202

Reviewed by Adam Roben.

* Shared/CoreIPCSupport/WebPageMessageKinds.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView _updateWindowVisibility]):
Call WebPageProxy::setWindowIsVisible.

(-[WKView addWindowObserversForWindow:]):
Add additional observers.

(-[WKView removeWindowObservers]):
Remove observers.

(-[WKView _updateWindowFrame]):
Call WebPageProxy::setWindowFrame.

(-[WKView viewDidMoveToWindow]):
Update the window visibility and the web frame.

(-[WKView _windowDidMiniaturize:]):
(-[WKView _windowDidDeminiaturize:]):
Update the window visibility.

(-[WKView _windowFrameDidChange:]):
Update the window frame.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setWindowIsVisible):
(WebKit::WebPageProxy::setWindowFrame):
Send messages along to the web process.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):
Register the plug-in view.

(WebKit::PluginView::~PluginView):
Unregister the plug-in view.

(WebKit::PluginView::setWindowIsVisible):
(WebKit::PluginView::setWindowFrame):
Add empty stubs.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Initialize m_windowIsVisible.

(WebKit::WebPage::~WebPage):
Assert that all plug-in views have been removed.

(WebKit::WebPage::setWindowIsVisible):
Notify all plug-ins about the window visibility change.

(WebKit::WebPage::setWindowFrame):
Notify all plug-ins about the window frame change.

(WebKit::WebPage::didReceiveMessage):
Handle setWindowIsVisible and setWindowFrame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDisable logging.
andersca@apple.com [Tue, 21 Sep 2010 18:39:18 +0000 (18:39 +0000)]
Disable logging.

* MiniBrowser/mac/MiniBrowser_Prefix.pch:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 21 Sep 2010 18:32:33 +0000 (18:32 +0000)]
2010-09-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Closing <li> should close nested <div>
        https://bugs.webkit.org/show_bug.cgi?id=26170

        This bug is fixed by the HTML5 parser.  Adding test.  (We have lots of
        variations of this test, but I'm adding another one to make Alexey
        happy.)

        * html5lib/resources/webkit01.dat:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* Configurations/WebKit2.xcconfig:
andersca@apple.com [Tue, 21 Sep 2010 18:21:37 +0000 (18:21 +0000)]
* Configurations/WebKit2.xcconfig:
Add a note about keeping the path in MainMac.cpp in sync with the install path.

Reviewed by Mark Rowe.

* mac/MainMac.cpp:
(main):
Use the correct framework path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Tue, 21 Sep 2010 18:16:08 +0000 (18:16 +0000)]
2010-09-21  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Take isValueList() checks out of the asserts for memory safety.
        https://bugs.webkit.org/show_bug.cgi?id=46194

        Test: editing/execCommand/apply-style-text-decoration-crash.html

        * editing/ApplyStyleCommand.cpp:
        (WebCore::StyleChange::extractTextStyles):
        (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):
2010-09-21  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Tests that applying a text decoration style does not result in crash.
        https://bugs.webkit.org/show_bug.cgi?id=46194

        * editing/execCommand/apply-style-text-decoration-crash-expected.txt: Added.
        * editing/execCommand/apply-style-text-decoration-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Tue, 21 Sep 2010 17:51:21 +0000 (17:51 +0000)]
2010-09-21  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Fixing double translation of composited layers when scrolling.
        The scrolling transform is now applied by a separate layer maintained in
        the RenderLayerCompositor.
        https://bugs.webkit.org/show_bug.cgi?id=46193

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::drawLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 21 Sep 2010 17:50:26 +0000 (17:50 +0000)]
2010-09-21  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        add a script for running webkit_unit_tests
        https://bugs.webkit.org/show_bug.cgi?id=46014

        * Scripts/run-chromium-webkit-unit-tests: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=46196, add marginStart/Before/End/After acces...
hyatt@apple.com [Tue, 21 Sep 2010 17:49:19 +0000 (17:49 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46196, add marginStart/Before/End/After accessors to RenderBoxModelObject.

Reviewed by Dan Bernstein.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::marginBefore):
(WebCore::RenderBox::marginAfter):
(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):
* rendering/RenderBox.h:
* rendering/RenderBoxModelObject.h:
* rendering/RenderInline.cpp:
(WebCore::computeMargin):
(WebCore::RenderInline::marginLeft):
(WebCore::RenderInline::marginRight):
(WebCore::RenderInline::marginTop):
(WebCore::RenderInline::marginBottom):
(WebCore::RenderInline::marginStart):
(WebCore::RenderInline::marginEnd):
* rendering/RenderInline.h:
(WebCore::RenderInline::marginBefore):
(WebCore::RenderInline::marginAfter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Fridrich Strba <fridrich.strba@bluewin.ch>
commit-queue@webkit.org [Tue, 21 Sep 2010 17:44:31 +0000 (17:44 +0000)]
2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>

        Reviewed by Martin Robinson.

        Fix linking issues of the GTK+ port on Windows
        https://bugs.webkit.org/show_bug.cgi?id=45844

        * GNUmakefile.am: link on Windows with ole32.dll, winmm.dll and shlwapi.dll
        * configure.ac: link on Windows with ole32.dll, winmm.dll and shlwapi.dll
        and export correctly all needed symbols from the libwebkitgtk DLL.
2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>

        Reviewed by Martin Robinson.

        Build issues with Windows versions of the GTK+ port
        https://bugs.webkit.org/show_bug.cgi?id=45844

        Link with winmm.dll when necessary and specify the executable extension
        explicitely so that the Programs/jsc-@WEBKITGTK_API_MAJOR_VERSION@
        rule actually works.

        Don't try to build the ThreadSpecificWin.cpp since GTK+ port uses
        a section in ThreadSpecific.cpp

        * GNUmakefile.am:
2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>

        Reviewed by Martin Robinson.

        Fix linking problems on Windows.
        https://bugs.webkit.org/show_bug.cgi?id=45844

        * GNUmakefile.am: link the executables with winmm.dll

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 21 Sep 2010 17:05:32 +0000 (17:05 +0000)]
2010-09-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        HTML parser double quote error recovery doesn't match Firefox 3.0.x
        https://bugs.webkit.org/show_bug.cgi?id=23970

        This bug is fixed by the HTML5 parser.  Adding test.

        * fast/tokenizer/unterminated-quote-in-noscript-expected.txt: Added.
        * fast/tokenizer/unterminated-quote-in-noscript.html: Added.
        * html5lib/resources/webkit02.dat:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 21 Sep 2010 16:48:34 +0000 (16:48 +0000)]
2010-09-17  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        [chromium] last 16 linux baselines due to scrollbar arrows
        https://bugs.webkit.org/show_bug.cgi?id=46019

        * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10140-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1055-2-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug106966-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug22122-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug80762-2-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug91057-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/core/backgrounds-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/core/backgrounds-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/core/col_span2-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/core/col_span2-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/other/empty_cells-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/other/empty_cells-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.checksum:
        * platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=46190, add borderStart/Before/End/After acces...
hyatt@apple.com [Tue, 21 Sep 2010 16:34:59 +0000 (16:34 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46190, add borderStart/Before/End/After accessors to RenderBoxModelObject.

Reviewed by Dan Bernstein.

* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::borderBefore):
(WebCore::RenderBoxModelObject::borderAfter):
(WebCore::RenderBoxModelObject::borderStart):
(WebCore::RenderBoxModelObject::borderEnd):
(WebCore::RenderBoxModelObject::borderAndPaddingLogicalHeight):
(WebCore::RenderBoxModelObject::borderAndPaddingLogicalWidth):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::borderStart):
(WebCore::RenderTableCell::borderEnd):
(WebCore::RenderTableCell::borderBefore):
(WebCore::RenderTableCell::borderAfter):
* rendering/RenderTableCell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build.
andersca@apple.com [Tue, 21 Sep 2010 16:26:02 +0000 (16:26 +0000)]
Fix build.

* mac/MainMac.cpp:
(closeUnusedFileDescriptors):
Move this out into a separate function.

(main):
Don't use the soft linking macros, they were bringing in WTFReportAssertionFailure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed a typo in the change log
mitz@apple.com [Tue, 21 Sep 2010 16:16:26 +0000 (16:16 +0000)]
Fixed a typo in the change log

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 21 Sep 2010 16:02:48 +0000 (16:02 +0000)]
2010-09-21  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] 'make dist' should be fixed in preparation for the next release
        https://bugs.webkit.org/show_bug.cgi?id=46129

        * GNUmakefile.am: Update the sources list to include missing headers.
2010-09-21  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] 'make dist' should be fixed in preparation for the next release
        https://bugs.webkit.org/show_bug.cgi?id=46129

        * GNUmakefile.am: Update the sources list to include missing headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=46188, make the cross-platform setPrinting...
hyatt@apple.com [Tue, 21 Sep 2010 15:58:27 +0000 (15:58 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46188, make the cross-platform setPrinting method match the Mac version of the method.
Specifically don't pass the page size down to subframes of the one you're printing.

Reviewed by John Sullivan.

* page/Frame.cpp:
(WebCore::Frame::setPrinting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 21 Sep 2010 15:53:52 +0000 (15:53 +0000)]
2010-09-21  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Generate correct WebKit gir file with g-i 0.9.5
        https://bugs.webkit.org/show_bug.cgi?id=46173

        Generate a correct gir file for WebKit with the
        gobject-introspection 0.9.5 scanner.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoZombie WebProcesses are left around
andersca@apple.com [Tue, 21 Sep 2010 15:39:09 +0000 (15:39 +0000)]
Zombie WebProcesses are left around
https://bugs.webkit.org/show_bug.cgi?id=46148
<rdar://problem/8455898>

Reviewed by Dan Bernstein.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::setupTerminationNotificationHandler):
Register a dispatch handler that calls waitpid when the child process exits. This prevents zombies from
staying around after the child process has quit.

(WebKit::ProcessLauncher::launchProcess):
Pass POSIX_SPAWN_START_SUSPENDED to posix_spawn to avoid race conditions when setting up the termination
notification handler. When the handler is set up we send the SIGCONT signal to the child process.

* mac/MainMac.cpp:
(main):
Loop through all file descriptors except for stdin, stdout and stderr and close them.

* WebKit2.xcodeproj/project.pbxproj:
Soft-link the Web process with WebKit2. We do this so we can ensure that we won't accidentally close any
file descriptors opened by initialization code that would have been called before main().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 21 Sep 2010 14:35:48 +0000 (14:35 +0000)]
2010-09-21  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        Use WTF::Vector for storing formData in ResourceHandleWin.
        https://bugs.webkit.org/show_bug.cgi?id=46180

        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/win/ResourceHandleWin.cpp:
        (WebCore::ResourceHandle::onHandleCreated):
        (WebCore::ResourceHandle::onRequestComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Satish Sampath <satish@chromium.org>
satish@chromium.org [Tue, 21 Sep 2010 14:34:17 +0000 (14:34 +0000)]
2010-09-21  Satish Sampath  <satish@chromium.org>

        Unreviewed, rename a test baseline to the correct name and update a test's expectation for chromium linux.

        * platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-actual.txt.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
jocelyn.turcotte@nokia.com [Tue, 21 Sep 2010 14:30:51 +0000 (14:30 +0000)]
2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Check if the reply has been deleted before finishing a network request
        https://bugs.webkit.org/show_bug.cgi?id=46174

        A crash can happen with the following sequence:
        1. QNetworkReplyHandler::abort() emits reply->deleteLater()
        2. QNAM emits QNetworkReply::finished() -> calls QNetworkReplyHandler::finish()
        3. event loop would call reply->deleteLater()
        However a crash occurs since m_reply == 0 on step 2.

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::finish):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Jochen Eisinger <jochen@chromium.org>
jochen@chromium.org [Tue, 21 Sep 2010 14:19:44 +0000 (14:19 +0000)]
2010-09-21  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Jeremy Orlow.

        Use @ to concatenate the database name and the database identifier when building
        the filename to use for indexed databases. That character is valid for filenames
        but cannot occur in a database identifier derived from a security origin.
        https://bugs.webkit.org/show_bug.cgi?id=46178

        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::IDBFactoryBackendImpl::databaseFileName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Steve Block <steveblock@google.com>
steveblock@google.com [Tue, 21 Sep 2010 14:03:28 +0000 (14:03 +0000)]
2010-09-21  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods
        https://bugs.webkit.org/show_bug.cgi?id=45891

        Tested by existing DeviceOrientation tests.

        * dom/DeviceMotionClient.h:
        * dom/DeviceMotionController.cpp:
        (WebCore::DeviceMotionController::~DeviceMotionController):
        * dom/DeviceMotionController.h:
        * dom/DeviceOrientationClient.h:
        * dom/DeviceOrientationController.cpp:
        (WebCore::DeviceOrientationController::~DeviceOrientationController):
        * dom/DeviceOrientationController.h:
        * loader/EmptyClients.h:
        (WebCore::EmptyDeviceMotionClient::deviceOrientationControllerDestroyed):
        (WebCore::EmptyDeviceOrientationClient::deviceOrientationControllerDestroyed):
        * platform/mock/DeviceOrientationClientMock.h:
        (WebCore::DeviceOrientationClientMock::deviceOrientationControllerDestroyed):
2010-09-21  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods
        https://bugs.webkit.org/show_bug.cgi?id=45891

        Implements DeviceOrientationClientProxy::deviceOrientationControllerDestroyed() as a no-op,
        as the client's lifetime is determined by the WebViewImpl.

        * src/DeviceOrientationClientProxy.cpp:
        (WebKit::DeviceOrientationClientProxy::deviceOrientationControllerDestroyed):
        * src/DeviceOrientationClientProxy.h:
2010-09-21  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        DeviceOrientationClient and DeviceMotionClient should have controllerDestroyed() methods
        https://bugs.webkit.org/show_bug.cgi?id=45891

        Implements WebDeviceOrientationClient::deviceOrientationControllerDestroyed to delete the client.

        * WebCoreSupport/WebDeviceOrientationClient.h:
        * WebCoreSupport/WebDeviceOrientationClient.mm:
        (WebDeviceOrientationClient::deviceOrientationControllerDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 21 Sep 2010 13:47:10 +0000 (13:47 +0000)]
2010-09-21  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        Add "WinCE" to classname for all WebCoreSupport classes to match filename.
        https://bugs.webkit.org/show_bug.cgi?id=46175

        * WebCoreSupport/ContextMenuClientWinCE.cpp: Rename ContextMenuClient to ContextMenuClientWinCE.
        * WebCoreSupport/ContextMenuClientWinCE.h: Ditto.
        * WebCoreSupport/DragClientWinCE.cpp: Rename DragClient to DragClientWinCE.
        * WebCoreSupport/DragClientWinCE.h: Ditto.
        * WebCoreSupport/EditorClientWinCE.cpp: Rename EditorClient to EditorClientWinCE.
        * WebCoreSupport/EditorClientWinCE.h: Ditto.
        * WebCoreSupport/InspectorClientWinCE.cpp: Rename InspectorClient to InspectorClientWinCE.
        * WebCoreSupport/InspectorClientWinCE.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 21 Sep 2010 13:32:55 +0000 (13:32 +0000)]
2010-09-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        feeder-queue svn updates more often than needed
        https://bugs.webkit.org/show_bug.cgi?id=46171

        We don't need to poll SVN every time we feed the feeders.  Rather, we
        can count on the wrapper shell script to auto-update the queue.

        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 21 Sep 2010 13:10:32 +0000 (13:10 +0000)]
2010-09-21  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Update for 1.3.4 release.

        * configure.ac:

WebKit/gtk:

2010-09-21  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Update for 1.3.4 release.

        * NEWS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Andras Becsi <abecsi@inf.u-szeged.hu>
commit-queue@webkit.org [Tue, 21 Sep 2010 13:05:51 +0000 (13:05 +0000)]
2010-09-21  Andras Becsi  <abecsi@inf.u-szeged.hu>

        Reviewed by Csaba Osztrogonác.

        [Qt] QtWebProcess should clean up shared memory map files on close
        https://bugs.webkit.org/show_bug.cgi?id=45984

        Relocate MappedMemory struct code to it's own header and implement
        a singleton pool class (MappedMemoryPool) which tracks shared memory
        to be able to clean up map files from disk if RunLoop stops.

        * Shared/qt/MappedMemory.h: Added.
        (WebKit::MappedMemory::markUsed):
        (WebKit::MappedMemory::markFree):
        (WebKit::MappedMemory::isFree):
        * Shared/qt/MappedMemoryPool.cpp: Added.
        (WebKit::MappedMemoryPool::MappedMemoryPool):
        (WebKit::MappedMemoryPool::instance):
        (WebKit::MappedMemoryPool::size):
        (WebKit::MappedMemoryPool::at):
        (WebKit::MappedMemoryPool::append):
        (WebKit::MappedMemoryPool::cleanUp):
        * Shared/qt/UpdateChunk.cpp:
        (WebKit::mapMemory):
        (WebKit::mapFile):
        * Shared/qt/UpdateChunk.h:
        * WebKit2.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Satish Sampath <satish@chromium.org>
satish@chromium.org [Tue, 21 Sep 2010 12:31:21 +0000 (12:31 +0000)]
2010-09-21  Satish Sampath  <satish@chromium.org>

        Unreviewed, disable a test in chromium per the original author and added missing expectations for another.

        * platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-actual.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Dave Tapuska <dtapuska@rim.com>
commit-queue@webkit.org [Tue, 21 Sep 2010 11:59:34 +0000 (11:59 +0000)]
2010-09-21  Dave Tapuska  <dtapuska@rim.com>

        Reviewed by Csaba Osztrogonác.

        https://bugs.webkit.org/show_bug.cgi?id=45673

        r65596 caused ENABLE_PROFILER_REFERENCE_OFFSET to not be
        8 byte aligned. A non 8 byte divisible value for this will
        cause the sp to become non 8 byte aligned.

        Verify and correct offset values that r65596 effected that
        weren't updated.

        * jit/JITStubs.cpp:
        * jit/JITStubs.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Add robot loader timeout and extra time options.
jocelyn.turcotte@nokia.com [Tue, 21 Sep 2010 11:25:54 +0000 (11:25 +0000)]
[Qt] Add robot loader timeout and extra time options.
https://bugs.webkit.org/show_bug.cgi?id=46172

Reviewed by Andreas Kling.

[-robot-timeout <s>]: Load the next page after s seconds if the current
page didn't finish loading.
[-robot-extra-time <s>]: Wait s seconds after the current page finished
loading before loading the next one. This should allow some time for the
page's JavaScript to execute.

* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::applyPrefs):
* QtTestBrowser/main.cpp:
(LauncherApplication::robotTimeout):
(LauncherApplication::robotExtraTime):
(LauncherApplication::LauncherApplication):
(LauncherApplication::handleUserOptions):
(main):
* QtTestBrowser/urlloader.cpp:
(UrlLoader::UrlLoader):
(UrlLoader::loadNext):
(UrlLoader::loadUrlList):
* QtTestBrowser/urlloader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Jochen Eisinger <jochen@chromium.org>
jochen@chromium.org [Tue, 21 Sep 2010 11:15:37 +0000 (11:15 +0000)]
2010-09-21  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Jeremy Orlow.

        Factor out the file name used for a given indexed database to a static method.
        https://bugs.webkit.org/show_bug.cgi?id=46090

        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::openSQLiteDatabase):
        (WebCore::IDBFactoryBackendImpl::databaseFileName):
        * storage/IDBFactoryBackendImpl.h:
2010-09-21  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Jeremy Orlow.

        [chromium] expose the filename used for a given indexed DB
        https://bugs.webkit.org/show_bug.cgi?id=46090

        * WebKit.gyp:
        * public/WebIDBFactory.h:
        * src/WebIDBFactory.cpp:
        (WebKit::WebIDBFactory::databaseFileName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 21 Sep 2010 10:55:30 +0000 (10:55 +0000)]
2010-09-21  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Configure flag for Opcode stats
        https://bugs.webkit.org/show_bug.cgi?id=46081

        Opcode stats won't work with JIT enabled, so bail out if both are
        enabled at the same time.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 21 Sep 2010 10:55:22 +0000 (10:55 +0000)]
2010-09-21  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Fix Opcode stats compilation
        https://bugs.webkit.org/show_bug.cgi?id=46079

        The FixedArray API had changed, and <stdio.h> was not included for
        printf.

        * bytecode/Opcode.cpp:
        (JSC::OpcodeStats::~OpcodeStats):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 21 Sep 2010 10:55:13 +0000 (10:55 +0000)]
2010-09-21  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fix --disable-jit
        https://bugs.webkit.org/show_bug.cgi?id=46080

        Manually define ENABLE_JIT to 0 when we want the feature disabled.

        If the value is undefined Platform.h will enable it again
        automatically in some platforms, which is probably not what the
        user wanted if he passed --disable-jit.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Satish Sampath <satish@chromium.org>
satish@chromium.org [Tue, 21 Sep 2010 10:27:41 +0000 (10:27 +0000)]
2010-09-21  Satish Sampath  <satish@chromium.org>

        Unreviewed, move an xp-specific results to win-xp

        * platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.checksum.
        * platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.png: Renamed from LayoutTests/platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.png.
        * platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Andy Estes <aestes@apple.com>
aestes@apple.com [Tue, 21 Sep 2010 10:21:06 +0000 (10:21 +0000)]
2010-09-21  Andy Estes  <aestes@apple.com>

        Reviewed by Adam Barth.

        Test that parser quirks apply when processing both start and end tags.
        https://bugs.webkit.org/show_bug.cgi?id=40961

        * fast/parser/pre-html5-parser-quirks-expected.txt:
        * fast/parser/resources/pre-html5-parser-quirk-after-attribute-name-state.html:
        * fast/parser/resources/pre-html5-parser-quirk-after-attribute-value-quoted-state.html:
        * fast/parser/resources/pre-html5-parser-quirk-after-attribute-value-unquoted-state.html:
        * fast/parser/resources/pre-html5-parser-quirk-attribute-name-state.html:
        * fast/parser/resources/pre-html5-parser-quirk-before-attribute-name-state.html:
        * fast/parser/resources/pre-html5-parser-quirk-document-fragment.html:
        * fast/parser/resources/pre-html5-parser-quirk-tag-name-state.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 21 Sep 2010 10:09:48 +0000 (10:09 +0000)]
2010-09-21  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed.

        [Chromium] remove test expectations for tests regressed in r67178:r67358 (fixed in r67659)

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 21 Sep 2010 09:24:31 +0000 (09:24 +0000)]
2010-09-21  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed.

        Adding myself to the committers list.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Tue, 21 Sep 2010 09:21:38 +0000 (09:21 +0000)]
2010-09-21  Dirk Schulze  <krit@webkit.org>

        SVG Filter cleanup
        https://bugs.webkit.org/show_bug.cgi?id=45612

        Unreviewed change of episolon back to a more tolerant value in RenderTreeAsText and made it a static const.
        This should turn the bots green again.

        * rendering/RenderTreeAsText.cpp:
        (WebCore::hasFractions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Tue, 21 Sep 2010 08:29:55 +0000 (08:29 +0000)]
2010-09-21  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, skipped crashing test:
        media/video-controls-with-mutation-event-handler.html. Added the
        bug: https://bugs.webkit.org/show_bug.cgi?id=46169

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 21 Sep 2010 08:02:11 +0000 (08:02 +0000)]
2010-09-21  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        [reviewtool] Publish button doesn't work
        https://bugs.webkit.org/show_bug.cgi?id=46168

        Darin's recent patch had a runtime error.  Sadly, we don't have any
        testing for this code.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=46125, convert table cell intrinsic padding...
hyatt@apple.com [Tue, 21 Sep 2010 07:45:08 +0000 (07:45 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46125, convert table cell intrinsic padding from top/bottom-based
to before/after-based.  A vertical text table can have intrinsic padding built into the left/right
direction (and this allows the base class logical padding methods on RenderBoxModelObject to be safe to use).

Reviewed by Dan Bernstein.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::RenderTableCell):
(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::paddingBefore):
(WebCore::RenderTableCell::paddingAfter):
* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::setIntrinsicPaddingBefore):
(WebCore::RenderTableCell::setIntrinsicPaddingAfter):
(WebCore::RenderTableCell::setIntrinsicPadding):
(WebCore::RenderTableCell::intrinsicPaddingBefore):
(WebCore::RenderTableCell::intrinsicPaddingAfter):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowHeight):
(WebCore::RenderTableSection::layoutRows):
* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeTextRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-21 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Tue, 21 Sep 2010 07:36:13 +0000 (07:36 +0000)]
2010-09-21  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG Filter cleanup
        https://bugs.webkit.org/show_bug.cgi?id=45612

        Second cleanup patch. Modified files to follow webkit style. Removed dependencies
        to SVG of most of the filter effects and prepared them to move from WebCore/svg/graphics/filters
        to WebCore/platform/graphics/filters/.
        Renamed calculateDrawingIntRect and calculateDrawingRect to requestedRegionOfInputImageData and
        drawingRegionOfInputImage to clarify the functionality and make both functions distinguishable.

        * platform/graphics/filters/FEBlend.cpp:
        (WebCore::FEBlend::apply):
        * platform/graphics/filters/FEBlend.h:
        * platform/graphics/filters/FEColorMatrix.cpp:
        (WebCore::FEColorMatrix::apply):
        * platform/graphics/filters/FEColorMatrix.h:
        * platform/graphics/filters/FEComponentTransfer.cpp:
        (WebCore::FEComponentTransfer::apply):
        * platform/graphics/filters/FEComponentTransfer.h:
        (WebCore::ComponentTransferFunction::ComponentTransferFunction):
        * platform/graphics/filters/FEComposite.cpp:
        (WebCore::FEComposite::apply):
        * platform/graphics/filters/FEComposite.h:
        * platform/graphics/filters/FEGaussianBlur.cpp:
        (WebCore::FEGaussianBlur::apply):
        * platform/graphics/filters/FEGaussianBlur.h:
        * platform/graphics/filters/Filter.h:
        * platform/graphics/filters/FilterEffect.cpp:
        (WebCore::FilterEffect::requestedRegionOfInputImageData):
        (WebCore::FilterEffect::drawingRegionOfInputImage):
        (WebCore::FilterEffect::effectContext):
        * platform/graphics/filters/FilterEffect.h:
        * platform/graphics/filters/ImageBufferFilter.cpp:
        * platform/graphics/filters/ImageBufferFilter.h:
        * platform/graphics/filters/SourceAlpha.cpp:
        (WebCore::SourceAlpha::apply):
        * platform/graphics/filters/SourceAlpha.h:
        (WebCore::SourceAlpha::isSourceInput):
        (WebCore::SourceAlpha::SourceAlpha):
        * platform/graphics/filters/SourceGraphic.cpp:
        (WebCore::SourceGraphic::apply):
        * platform/graphics/filters/SourceGraphic.h:
        (WebCore::SourceGraphic::isSourceInput):
        (WebCore::SourceGraphic::SourceGraphic):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::hasFractions):
        (WebCore::operator<<):
        * rendering/RenderTreeAsText.h:
        (WebCore::operator<<):
        * rendering/SVGRenderTreeAsText.cpp:
        * rendering/SVGRenderTreeAsText.h:
        * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
        (WebCore::FEConvolveMatrix::apply):
        * svg/graphics/filters/SVGFEConvolveMatrix.h:
        * svg/graphics/filters/SVGFEDiffuseLighting.cpp:
        * svg/graphics/filters/SVGFEDiffuseLighting.h:
        * svg/graphics/filters/SVGFEDisplacementMap.cpp:
        (WebCore::FEDisplacementMap::apply):
        * svg/graphics/filters/SVGFEDisplacementMap.h:
        * svg/graphics/filters/SVGFEFlood.cpp:
        (WebCore::FEFlood::apply):
        (WebCore::FEFlood::externalRepresentation):
        * svg/graphics/filters/SVGFEFlood.h:
        * svg/graphics/filters/SVGFEImage.cpp:
        (WebCore::FEImage::apply):
        * svg/graphics/filters/SVGFEImage.h:
        * svg/graphics/filters/SVGFELighting.cpp:
        (WebCore::FELighting::apply):
        * svg/graphics/filters/SVGFELighting.h:
        * svg/graphics/filters/SVGFEMerge.cpp:
        (WebCore::FEMerge::apply):
        * svg/graphics/filters/SVGFEMerge.h:
        * svg/graphics/filters/SVGFEMorphology.cpp:
        (WebCore::FEMorphology::apply):
        * svg/graphics/filters/SVGFEMorphology.h:
        * svg/graphics/filters/SVGFEOffset.cpp:
        (WebCore::FEOffset::apply):
        * svg/graphics/filters/SVGFEOffset.h:
        * svg/graphics/filters/SVGFESpecularLighting.cpp:
        * svg/graphics/filters/SVGFESpecularLighting.h:
        * svg/graphics/filters/SVGFETile.cpp:
        (WebCore::FETile::apply):
        * svg/graphics/filters/SVGFETile.h:
        * svg/graphics/filters/SVGFETurbulence.cpp:
        (WebCore::FETurbulence::apply):
        * svg/graphics/filters/SVGFETurbulence.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-20 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 21 Sep 2010 06:54:09 +0000 (06:54 +0000)]
2010-09-20  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        [GTK] enhanced context menu for media elements
        https://bugs.webkit.org/show_bug.cgi?id=45021

        New items in the media Element context menu:
        - play/pause
        - mute/unmute
        - controls display control
        - switch to fullscreen (for video only)
        - loop playback control
        - copy media url to clipboard
        - open in new window

        Test: media/context-menu-actions.html

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate):
        (WebCore::ContextMenu::checkOrEnableIfNeeded):
        * platform/ContextMenuItem.h:
        * platform/LocalizationStrategy.h:
        * platform/LocalizedStrings.cpp:
        (WebCore::contextMenuItemTagOpenVideoInNewWindow):
        (WebCore::contextMenuItemTagOpenAudioInNewWindow):
        (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
        (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
        (WebCore::contextMenuItemTagToggleMediaControls):
        (WebCore::contextMenuItemTagToggleMediaLoop):
        (WebCore::contextMenuItemTagEnterVideoFullscreen):
        (WebCore::contextMenuItemTagMediaPlay):
        (WebCore::contextMenuItemTagMediaPause):
        (WebCore::contextMenuItemTagMediaMute):
        * platform/LocalizedStrings.h:
        * platform/android/LocalizedStringsAndroid.cpp:
        (WebCore::contextMenuItemTagOpenVideoInNewWindow):
        (WebCore::contextMenuItemTagOpenAudioInNewWindow):
        (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
        (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
        (WebCore::contextMenuItemTagToggleMediaControls):
        (WebCore::contextMenuItemTagToggleMediaLoop):
        (WebCore::contextMenuItemTagEnterVideoFullscreen):
        (WebCore::contextMenuItemTagMediaPlay):
        (WebCore::contextMenuItemTagMediaPause):
        (WebCore::contextMenuItemTagMediaMute):
        * platform/brew/LocalizedStringsBrew.cpp:
        (WebCore::contextMenuItemTagOpenVideoInNewWindow):
        (WebCore::contextMenuItemTagOpenAudioInNewWindow):
        (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
        (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
        (WebCore::contextMenuItemTagToggleMediaControls):
        (WebCore::contextMenuItemTagToggleMediaLoop):
        (WebCore::contextMenuItemTagEnterVideoFullscreen):
        (WebCore::contextMenuItemTagMediaPlay):
        (WebCore::contextMenuItemTagMediaPause):
        (WebCore::contextMenuItemTagMediaMute):
        * platform/efl/LocalizedStringsEfl.cpp:
        (WebCore::contextMenuItemTagOpenVideoInNewWindow):
        (WebCore::contextMenuItemTagOpenAudioInNewWindow):
        (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
        (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
        (WebCore::contextMenuItemTagToggleMediaControls):
        (WebCore::contextMenuItemTagToggleMediaLoop):
        (WebCore::contextMenuItemTagEnterVideoFullscreen):
        (WebCore::contextMenuItemTagMediaPlay):
        (WebCore::contextMenuItemTagMediaPause):
        (WebCore::contextMenuItemTagMediaMute):
        * platform/gtk/ContextMenuItemGtk.cpp:
        (WebCore::gtkStockIDFromContextMenuAction):
        * platform/gtk/LocalizedStringsGtk.cpp:
        (WebCore::contextMenuItemTagOpenVideoInNewWindow):
        (WebCore::contextMenuItemTagOpenAudioInNewWindow):
        (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
        (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
        (WebCore::contextMenuItemTagToggleMediaControls):
        (WebCore::contextMenuItemTagToggleMediaLoop):
        (WebCore::contextMenuItemTagEnterVideoFullscreen):
        (WebCore::contextMenuItemTagMediaPlay):
        (WebCore::contextMenuItemTagMediaPause):
        (WebCore::contextMenuItemTagMediaMute):
        * platform/haiku/LocalizedStringsHaiku.cpp:
        (WebCore::contextMenuItemTagOpenVideoInNewWindow):
        (WebCore::contextMenuItemTagOpenAudioInNewWindow):
        (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
        (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
        (WebCore::contextMenuItemTagToggleMediaControls):
        (WebCore::contextMenuItemTagToggleMediaLoop):
        (WebCore::contextMenuItemTagEnterVideoFullscreen):
        (WebCore::contextMenuItemTagMediaPlay):
        (WebCore::contextMenuItemTagMediaPause):
        (WebCore::contextMenuItemTagMediaMute):
        * platform/wx/LocalizedStringsWx.cpp:
        (WebCore::contextMenuItemTagOpenVideoInNewWindow):
        (WebCore::contextMenuItemTagOpenAudioInNewWindow):
        (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
        (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
        (WebCore::contextMenuItemTagToggleMediaControls):
        (WebCore::contextMenuItemTagToggleMediaLoop):
        (WebCore::contextMenuItemTagEnterVideoFullscreen):
        (WebCore::contextMenuItemTagMediaPlay):
        (WebCore::contextMenuItemTagMediaPause):
        (WebCore::contextMenuItemTagMediaMute):
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::absoluteMediaURL):
        (WebCore::HitTestResult::mediaSupportsFullscreen):
        (WebCore::HitTestResult::mediaElement):
        (WebCore::HitTestResult::toggleMediaControlsDisplay):
        (WebCore::HitTestResult::toggleMediaLoopPlayback):
        (WebCore::HitTestResult::enterFullscreenForVideo):
        (WebCore::HitTestResult::mediaControlsEnabled):
        (WebCore::HitTestResult::mediaLoopEnabled):
        (WebCore::HitTestResult::mediaPlaying):
        (WebCore::HitTestResult::toggleMediaPlayState):
        (WebCore::HitTestResult::mediaHasAudio):
        (WebCore::HitTestResult::mediaMuted):
        (WebCore::HitTestResult::toggleMediaMuteState):
        * rendering/HitTestResult.h:

LayoutTests:

        Reviewed by Eric Carlson.

        [GTK] enhanced context menu for media elements
        https://bugs.webkit.org/show_bug.cgi?id=45021

        New test checking the actions that can be triggered by activating
        the contex-menu of the media element. Skipped on mac, qt and win
        because of lack of DRT support.

        * media/context-menu-actions-expected.txt: Added.
        * media/context-menu-actions.html: Added.
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

WebKit:

        Reviewed by Eric Carlson.

        [GTK] enhanced context menu for media elements
        https://bugs.webkit.org/show_bug.cgi?id=45021

        Updated localizable strings.

        * English.lproj/Localizable.strings:

WebKit/chromium:

        Reviewed by Eric Carlson.

        [GTK] enhanced context menu for media elements
        https://bugs.webkit.org/show_bug.cgi?id=45021

        New localized strings for the media element context-menu.

        * src/LocalizedStrings.cpp:
        (WebCore::contextMenuItemTagOpenVideoInNewWindow):
        (WebCore::contextMenuItemTagOpenAudioInNewWindow):
        (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
        (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
        (WebCore::contextMenuItemTagToggleMediaControls):
        (WebCore::contextMenuItemTagToggleMediaLoop):
        (WebCore::contextMenuItemTagEnterVideoFullscreen):
        (WebCore::contextMenuItemTagMediaPlay):
        (WebCore::contextMenuItemTagMediaPause):
        (WebCore::contextMenuItemTagMediaMute):

WebKit/mac:

        Reviewed by Eric Carlson.

        [GTK] enhanced context menu for media elements
        https://bugs.webkit.org/show_bug.cgi?id=45021

        New localized strings for the media element context-menu.

        * WebCoreSupport/WebPlatformStrategies.h:
        * WebCoreSupport/WebPlatformStrategies.mm:
        (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow):
        (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow):
        (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard):
        (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard):
        (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
        (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
        (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
        (WebPlatformStrategies::contextMenuItemTagMediaPlay):
        (WebPlatformStrategies::contextMenuItemTagMediaPause):
        (WebPlatformStrategies::contextMenuItemTagMediaMute):

Webkit/qt:

        Reviewed by Eric Carlson.

        [GTK] enhanced context menu for media elements
        https://bugs.webkit.org/show_bug.cgi?id=45021

        * WebCoreSupport/WebPlatformStrategies.cpp:
        * WebCoreSupport/WebPlatformStrategies.h:
        (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow):
        (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow):
        (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard):
        (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard):
        (WebPlatformStrategies::contextMenuItemTagToggleMediaControls)
        (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop)
        (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen)
        (WebPlatformStrategies::contextMenuItemTagMediaPlay)
        (WebPlatformStrategies::contextMenuItemTagMediaPause)
        (WebPlatformStrategies::contextMenuItemTagMediaMute)

WebKit/win:

        Reviewed by Eric Carlson.

        [GTK] enhanced context menu for media elements
        https://bugs.webkit.org/show_bug.cgi?id=45021

        New localized strings for the media element context-menu.

        * WebCoreSupport/WebPlatformStrategies.cpp:
        (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow):
        (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow):
        (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard):
        (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard):
        (WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
        (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
        (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
        (WebPlatformStrategies::contextMenuItemTagMediaPlay):
        (WebPlatformStrategies::contextMenuItemTagMediaPause):
        (WebPlatformStrategies::contextMenuItemTagMediaMute):
        * WebCoreSupport/WebPlatformStrategies.h:

WebKit2:

        Reviewed by Eric Carlson.

        [GTK] enhanced context menu for media elements
        https://bugs.webkit.org/show_bug.cgi?id=45021

        New localized strings for the media element context-menu.

        * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
        (WebKit::WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow):
        (WebKit::WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow):
        (WebKit::WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard):
        (WebKit::WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard):
        (WebKit::WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
        (WebKit::WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
        (WebKit::WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
        (WebKit::WebPlatformStrategies::contextMenuItemTagMediaPlay):
        (WebKit::WebPlatformStrategies::contextMenuItemTagMediaPause):
        (WebKit::WebPlatformStrategies::contextMenuItemTagMediaMute):
        (WebKit::WebPlatformStrategies::contextMenuItemTagMediaUnMute):
        * WebProcess/WebCoreSupport/WebPlatformStrategies.h:

WebKitTools:

        Reviewed by Eric Carlson.

        [GTK] enhanced context menu for media elements
        https://bugs.webkit.org/show_bug.cgi?id=45021

        EventSender::contextClick() now returns an array of js
        objects. Each object has a title property and a click() method.

        * DumpRenderTree/gtk/EventSender.cpp:
        (getMenuItemTitleCallback):
        (setMenuItemTitleCallback):
        (menuItemClickCallback):
        (getMenuItemClass):
        (contextClickCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-20 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 21 Sep 2010 06:44:52 +0000 (06:44 +0000)]
2010-09-20  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Add Preview button and link to bug to patch review bar
        https://bugs.webkit.org/show_bug.cgi?id=46153

        * PrettyPatch/PrettyPatch.rb: Bump version number to make caches happy.
        * code-review.js: Added Preview button and link to bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67927 268f45cc-cd09-0410-ab3c-d52691b4dbfc