lforschler@apple.com [Wed, 13 Apr 2011 14:55:37 +0000 (14:55 +0000)]
Sort task kill list
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Apr 2011 14:33:25 +0000 (14:33 +0000)]
2011-04-13 Brian Salomon <bsalomon@google.com>
Reviewed by Kenneth Russell.
Use new skia API for wrapping DrawingBuffer's FBO/Tex IDs in skia object
https://bugs.webkit.org/show_bug.cgi?id=58363
No new tests needed, exercised by all existing canvas2d tests.
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::getGrPlatformSurfaceDesc):
* platform/graphics/gpu/DrawingBuffer.h:
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lforschler@apple.com [Wed, 13 Apr 2011 14:28:06 +0000 (14:28 +0000)]
2011-04-13 Lucas Forschler <lforschler@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=58384
Update kill-old-processes to include a few new ones.
* BuildSlaveSupport/win/kill-old-processes:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 13 Apr 2011 14:26:22 +0000 (14:26 +0000)]
2011-04-13 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Fix chromium clang build problem:
ApplyPropertyExpandingSuppressValue::applyValue() shadows a virtual method
with a different signature in base class instead of overriding it.
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyExpandingSuppressValue::applyValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 13 Apr 2011 14:25:47 +0000 (14:25 +0000)]
2011-04-13 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Rebaselined SVG test expectations following mac expectations change in r83710.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
* platform/chromium-linux/svg/custom/text-dom-01-f-expected.checksum: Removed.
* platform/chromium-linux/svg/custom/text-dom-01-f-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.checksum: Removed.
* platform/chromium-mac-leopard/svg/custom/text-dom-01-f-expected.png: Removed.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
* platform/chromium-win/svg/custom/text-dom-01-f-expected.checksum: Removed.
* platform/chromium-win/svg/custom/text-dom-01-f-expected.png:
* platform/chromium-win/svg/custom/text-dom-01-f-expected.txt:
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
* platform/chromium-win/svg/text/lengthAdjust-text-metrics-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Wed, 13 Apr 2011 14:20:00 +0000 (14:20 +0000)]
2011-04-13 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Add mock implementation and plumbing code for unified Quota API
https://bugs.webkit.org/show_bug.cgi?id=57927
Added plumbing code for the quota API, that is based on the
discussion on public-webapps:
http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html
* WebKit.gyp: Added new file entries.
* src/StorageInfoChromium.cpp: Added.
* src/WebStorageQuotaCallbacksImpl.cpp: Added. An implementation of
WebStorageQuotaCallbacks.
* src/WebStorageQuotaCallbacksImpl.h: Added.
2011-04-13 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by David Levin.
Add mock implementation and plumbing code for unified Quota API
https://bugs.webkit.org/show_bug.cgi?id=57927
Added mock implementation and some plumbing code for the quota API,
that is based on the discussion on public-webapps:
http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html
No new tests: tests will be added when we expose the API.
* CMakeLists.txt: Added new file entries.
* DerivedSources.cpp: Added new file entries.
* DerivedSources.make: Added new file entries.
* GNUmakefile.am: Added new file entries.
* WebCore.gypi: Added new file entries.
* WebCore.pro: Added new file entries.
* WebCore.vcproj/WebCore.vcproj: Added new file entries.
* WebCore.xcodeproj/project.pbxproj: Added new file entries.
* storage/StorageInfo.cpp: Added.
* storage/StorageInfo.h: Added.
* storage/StorageInfoErrorCallback.h: Added.
* storage/StorageInfoQuotaCallback.h: Added.
* storage/StorageInfoUsageCallback.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Apr 2011 14:05:15 +0000 (14:05 +0000)]
2011-04-13 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Martin Robinson.
[GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
https://bugs.webkit.org/show_bug.cgi?id=58297
Make sure we do not load plugins that use symbols of a different
GTK+ major version to avoid bugs and crashes.
* plugins/gtk/PluginPackageGtk.cpp:
(WebCore::moduleMixesGtkSymbols):
(WebCore::PluginPackage::load):
2011-04-13 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Martin Robinson.
[GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
https://bugs.webkit.org/show_bug.cgi?id=58297
Do not disable flash specifically when built with GTK+ 3 -
PluginPackage should do the right thing while loading plugins.
* GtkLauncher/main.c:
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Apr 2011 14:04:44 +0000 (14:04 +0000)]
2011-04-13 Grzegorz Czajkowski <g.czajkowski@samsung.com>
Reviewed by Kent Tamura.
[EFL] Doxygen documentation for ewk_main, ewk_history and tools
https://bugs.webkit.org/show_bug.cgi?id=58428
* ewk/EWebKit.h:
* ewk/ewk_eapi.h:
* ewk/ewk_history.h:
* ewk/ewk_logging.h:
* ewk/ewk_main.cpp:
* ewk/ewk_main.h:
* ewk/ewk_private.h:
* ewk/ewk_util.cpp:
* ewk/ewk_util.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Wed, 13 Apr 2011 14:01:55 +0000 (14:01 +0000)]
2011-04-13 Tony Gentilcore <tonyg@chromium.org>
Reviewed by David Levin.
[chromium] Regression(r80861): fast/dom/Window/window-lookup-precedence.html started failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=56608
Previously the test unintentionally navigated the iframe when setting
window.location. Instead, now, we just skip setting window.location.
* fast/dom/Window/window-lookup-precedence.html:
* platform/chromium-win/fast/dom/Window/window-lookup-precedence-expected.txt: Moved to chromium.
* platform/chromium/fast/dom/Window/window-lookup-precedence-expected.txt: Moved from chromium-win.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Apr 2011 13:39:00 +0000 (13:39 +0000)]
2011-04-13 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Implement undo/redo in text editor
https://bugs.webkit.org/show_bug.cgi?id=58426
Native undo/redo does not work because we modify DOM structure (highlights, chunks and etc.)
Implement it via keyboard shortcuts for now (Cmd/Ctrl+Z and Cmd/Ctrl+Shift+Z).
FIXME: Do something with the popup's Undo and Redo menu options - they invoke native's undo/redo.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.endEditing):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.prototype.setText):
(WebInspector.TextEditorModel.prototype._innerSetText):
(WebInspector.TextEditorModel.prototype._pushUndoableCommand):
(WebInspector.TextEditorModel.prototype.undo):
(WebInspector.TextEditorModel.prototype.redo):
(WebInspector.TextEditorModel.prototype._doUndo):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._textChanged):
(WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
(WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
(WebInspector.TextViewer.prototype._registerShortcuts):
(WebInspector.TextViewer.prototype._cancelEditing):
(WebInspector.TextViewer.prototype._handleUndoRedo):
(WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
(WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
(WebInspector.TextEditorGutterPanel.prototype.textChanged):
(WebInspector.TextEditorMainPanel.prototype.handleUndoRedo.callback):
(WebInspector.TextEditorMainPanel.prototype.handleUndoRedo):
(WebInspector.TextEditorMainPanel.prototype._restoreSelection):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype.textChanged):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 13 Apr 2011 13:24:02 +0000 (13:24 +0000)]
2011-04-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: make optional event parameter last to prevent regressions.
https://bugs.webkit.org/show_bug.cgi?id=58433
* inspector/Inspector.json:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::willSendRequest):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 13 Apr 2011 13:12:49 +0000 (13:12 +0000)]
LayoutTestController.computedStyleIncludingVisitedInfo-based tests don't work in WK2
http://webkit.org/b/58334
Make same changes in Qt WK2 Skipped list as r83595 in Mac WK2 Skipped list.
* platform/qt-wk2/Skipped: Skip a new test due to an identified bug in WKTR and classify
three other skipped tests with that same bug.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 13 Apr 2011 12:24:48 +0000 (12:24 +0000)]
2011-04-13 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: revert Inspector.json change for breaking world.
* inspector/Inspector.json:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 13 Apr 2011 12:14:12 +0000 (12:14 +0000)]
2011-04-13 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: swap methods in the Inspector.json.
* inspector/Inspector.json:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 13 Apr 2011 11:41:14 +0000 (11:41 +0000)]
2011-04-13 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed, rolling out r83695.
http://trac.webkit.org/changeset/83695
https://bugs.webkit.org/show_bug.cgi?id=58375
[Qt][WK2]It broke http tests
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::start):
(WebCore::QNetworkReplyHandler::synchronousLoad):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::resourceResponse):
(WebCore::WebCoreSynchronousLoader::resourceError):
(WebCore::WebCoreSynchronousLoader::data):
(WebCore::WebCoreSynchronousLoader::setReplyFinished):
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::WebCoreSynchronousLoader::waitForCompletion):
(WebCore::ResourceHandle::loadResourceSynchronously):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Wed, 13 Apr 2011 11:37:10 +0000 (11:37 +0000)]
2011-04-13 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: inactive style sheets should be read only.
https://bugs.webkit.org/show_bug.cgi?id=58423
* inspector/front-end/ResourceView.js:
(WebInspector.CSSSourceFrame):
(WebInspector.CSSSourceFrame.prototype.isContentEditable):
(WebInspector.CSSSourceFrame.prototype._loadStyleSheet.didGetAllStyleSheets.didCreateForId):
(WebInspector.CSSSourceFrame.prototype._loadStyleSheet):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Wed, 13 Apr 2011 11:35:00 +0000 (11:35 +0000)]
2011-04-13 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Prepare to move detailed heap snapshots storage and processing into workers.
https://bugs.webkit.org/show_bug.cgi?id=58320
Introduce a proxy object that emulates worker behavior and change UI code to cope with it.
* inspector/profiler/detailed-heapshots-test.js:
(initialize_DetailedHeapshotTest):
2011-04-13 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Prepare to move detailed heap snapshots storage and processing into workers.
https://bugs.webkit.org/show_bug.cgi?id=58320
Introduce a proxy object that emulates worker behavior and change UI code to cope with it.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate.sorted):
(WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate):
(WebInspector.HeapSnapshotGridNode.prototype._populate):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved.notify):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort.doSort.afterSort.afterPopulate):
(WebInspector.HeapSnapshotGridNode.prototype.sort.doSort.afterSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get _shallowSizePercent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype._updateHasChildren):
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
(WebInspector.HeapSnapshotInstanceNode):
(WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
(WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
(WebInspector.HeapSnapshotConstructorNode.prototype._createChildNode):
(WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotIteratorsTuple.prototype.sortAndRewind):
(WebInspector.HeapSnapshotDiffNode.prototype._calculateDiff):
(WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotDiffNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.else.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
(WebInspector.HeapSnapshotDominatorObjectNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.baseSnapshotNodeIdsReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.pushBaseSnapshotNodeIds):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource.snapshotNodeIdsReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotRetainingPathsList):
(WebInspector.HeapSnapshotRetainingPathsList.prototype._resetPaths):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.setDataSource):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.startSearching):
(WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext):
(WebInspector.DetailedHeapshotView.profileCallback):
(WebInspector.DetailedHeapshotView):
(WebInspector.DetailedHeapshotView.prototype.get profileWrapper):
(WebInspector.DetailedHeapshotView.prototype.get baseProfileWrapper):
(WebInspector.DetailedHeapshotView.prototype.show.profileCallback1):
(WebInspector.DetailedHeapshotView.prototype.show.profileCallback2):
(WebInspector.DetailedHeapshotView.prototype.show):
(WebInspector.DetailedHeapshotView.prototype._changeBase.baseProfileLoaded):
* inspector/front-end/HeapSnapshot.js:
* inspector/front-end/HeapSnapshotProxy.js: Added.
* inspector/front-end/PleaseWaitMessage.js:
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.else.parsed):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 13 Apr 2011 10:45:37 +0000 (10:45 +0000)]
Update Qt specific expected results after r83710.
* platform/qt/svg/custom/text-dom-01-f-expected.txt:
* platform/qt/svg/text/lengthAdjust-text-metrics-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 13 Apr 2011 10:20:35 +0000 (10:20 +0000)]
2011-04-13 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Web Page Performance auditing fails
https://bugs.webkit.org/show_bug.cgi?id=58322
* inspector/audits/audits-panel-functional.html:
2011-04-13 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Web Page Performance auditing fails
https://bugs.webkit.org/show_bug.cgi?id=58322
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.documentLoaded):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun.onDocumentAvailable):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.onDocumentAvailable):
(WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 13 Apr 2011 09:51:26 +0000 (09:51 +0000)]
2011-04-13 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: enumerate properties in Inspector.json using array, not object keys.
https://bugs.webkit.org/show_bug.cgi?id=58418
* inspector/Inspector.json:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Wed, 13 Apr 2011 09:33:25 +0000 (09:33 +0000)]
2011-04-12 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
Chromium: Set ENABLE_LEVELDB=1 and add leveldb and snappy to DEPS
https://bugs.webkit.org/show_bug.cgi?id=58343
Set ENABLE_LEVELDB=1 so that code gets compiled by the EWS bots.
Add the necessary dependencies to the DEPS file.
* DEPS:
* features.gypi:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Wed, 13 Apr 2011 09:32:15 +0000 (09:32 +0000)]
2011-04-06 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: add "De-obfuscate Source" item to source frame text area context menu.
https://bugs.webkit.org/show_bug.cgi?id=57942
* English.lproj/localizedStrings.js:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.formatSourceFilesToggled):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.toggleFormatSourceFiles):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.formatSourceFilesToggled):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._contextMenu):
(WebInspector.SourceFrame.prototype._populateLineGutterContextMenu):
(WebInspector.SourceFrame.prototype._populateTextAreaContextMenu):
(WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
(WebInspector.SourceFrameDelegate.prototype.toggleFormatSourceFiles):
(WebInspector.SourceFrameDelegate.prototype.formatSourceFilesToggled):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 13 Apr 2011 09:22:45 +0000 (09:22 +0000)]
2011-04-13 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg has different output on Windows
https://bugs.webkit.org/show_bug.cgi?id=58421
* platform/win/Skipped: Skip svdgdom-over-01-f.svg test. The test is fine, but its missing a line compared to the mac output.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 13 Apr 2011 09:00:25 +0000 (09:00 +0000)]
2011-04-13 Andrey Kosyakov <caseq@chromium.org>
Unreviewed.
Rebaselined expectations following console message format change in V8 bindings.
* platform/chromium/fast/dom/error-to-string-stack-overflow-expected.txt:
* platform/chromium/fast/js/recursion-limit-equal-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 13 Apr 2011 08:42:03 +0000 (08:42 +0000)]
2011-04-13 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
SVGTextContentElements textLength returns 0
https://bugs.webkit.org/show_bug.cgi?id=52543
Add proper handling of the SVGTextContentElement textLength property, according to SVG 1.1 2nd edition.
If the textLength attributes is not explicitely set "textContentElement.textLength.baseVal"
will return the same as "textContentElement.getComputedTextLength()". If it's set the values
aren't equal anymore. getComputedTextLength() ignores the textLength attributes as well as the
lengthAdjust attribute. Adapt all of SVGTextQuery to ignore the lengthAdjust/textLength attributes.
This is how Opera implements it, and it makes sense to a certain degree, as otherwhise getComputedTextLength()
and textLength.baseVal.value would always be the same. Nor does the spec mention that textLength is honored
in the SVG Text DOM API.
Fixes svg/custom/text-dom-01-f.svg (from SVG 1.1 2nd edition, should be moved into the new W3C-SVG-1.1-SE directory).
Fixes svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg (last subtest related to textLength now passes).
Added new svg/dynamic-updates testcases covering dynamic changes of lengthAdjust/textLength and the synchronization
with getComputedTextLength().
Tests: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg
svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr.html
svg/dynamic-updates/SVGTextElement-dom-textLength-attr.html
svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop.html
svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop.html
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::positionForPoint):
* rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::offsetForPositionInFragment):
(WebCore::SVGInlineTextBox::selectionRect):
(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::paint):
(WebCore::SVGInlineTextBox::calculateBoundaries):
* rendering/svg/SVGTextChunkBuilder.cpp:
(WebCore::SVGTextChunkBuilder::buildTextChunks):
(WebCore::SVGTextChunkBuilder::layoutTextChunks):
(WebCore::SVGTextChunkBuilder::addTextChunk):
(WebCore::SVGTextChunkBuilder::processTextChunk):
(WebCore::SVGTextChunkBuilder::processTextLengthSpacingCorrection):
(WebCore::SVGTextChunkBuilder::processTextAnchorCorrection):
* rendering/svg/SVGTextFragment.h:
(WebCore::SVGTextFragment::SVGTextFragment):
(WebCore::SVGTextFragment::buildFragmentTransform):
(WebCore::SVGTextFragment::transformAroundOrigin):
(WebCore::SVGTextFragment::buildTransformForTextOnPath):
(WebCore::SVGTextFragment::buildTransformForTextOnLine):
* rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::parentDefinesTextLength):
(WebCore::SVGTextLayoutEngine::beginTextPathLayout):
(WebCore::dumpTextBoxes):
(WebCore::SVGTextLayoutEngine::finalizeTransformMatrices):
(WebCore::SVGTextLayoutEngine::finishLayout):
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):
* rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::textLengthCallback):
(WebCore::SVGTextQuery::subStringLengthCallback):
(WebCore::SVGTextQuery::startPositionOfCharacterCallback):
(WebCore::SVGTextQuery::endPositionOfCharacterCallback):
(WebCore::SVGTextQuery::rotationOfCharacterCallback):
(WebCore::calculateGlyphBoundaries):
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::SVGTextContentElement):
(WebCore::SVGTextContentElement::synchronizeTextLength):
(WebCore::SVGTextContentElement::textLengthAnimated):
(WebCore::SVGTextContentElement::parseMappedAttribute):
(WebCore::SVGTextContentElement::svgAttributeChanged):
* svg/SVGTextContentElement.h:
(WebCore::SVGTextContentElement::specifiedTextLength):
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::svgAttributeChanged):
* svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::svgAttributeChanged):
2011-04-13 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
SVGTextContentElements textLength returns 0
https://bugs.webkit.org/show_bug.cgi?id=52543
Add new testcases from SVG 1.1 2nd edition. Correct all existing tests using textLength + SVG DOM Text API,
as we're not including textLength/lengthAdjust="spacingAndGlyphs" anymore in the SVGTextQuery results.
This matches Opera and a discussion on www-svg some time ago: http://www.w3.org/2010/05/24-svg-minutes.html.
* platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.checksum: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
* platform/mac/svg/custom/text-dom-01-f-expected.checksum:
* platform/mac/svg/custom/text-dom-01-f-expected.png:
* platform/mac/svg/custom/text-dom-01-f-expected.txt:
* platform/mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: Added.
* svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg: Added.
* svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.txt: Added.
* svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr.html: Added.
* svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.txt: Added.
* svg/dynamic-updates/SVGTextElement-dom-textLength-attr.html: Added.
* svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.txt: Added.
* svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop.html: Added.
* svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.txt: Added.
* svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop.html: Added.
* svg/dynamic-updates/script-tests/SVGTextElement-dom-lengthAdjust-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGTextElement-dom-textLength-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGTextElement-svgdom-lengthAdjust-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGTextElement-svgdom-textLength-prop.js: Added.
(executeTest):
* svg/text/lengthAdjust-text-metrics-expected.txt:
* svg/text/resources/SelectionTestCase.js:
(transformPoint):
(transformRect):
(toAbsoluteCoordinates):
(selectRange):
* svg/text/script-tests/lengthAdjust-text-metrics.js:
(transformPoint):
(transformRect):
(numberToString):
(lengthToString):
(pointToString):
(rectToString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Apr 2011 08:14:36 +0000 (08:14 +0000)]
2011-04-13 Paul Knight <pknight@apple.com>
Reviewed by Gavin Barraclough.
BACKTRACE() macro should check for Debug configuration in macro, not WTFReportBacktrace definition
https://bugs.webkit.org/show_bug.cgi?id=58405
The BACKTRACE() macro requires JavaScriptCore be built with a Debug
configuration in order for it to be enabled. Move the NDEBUG check to
the header so it will be enabled when the calling framework or
application is built with a Debug configuration, similar to how
ASSERT() and friends work.
* wtf/Assertions.cpp:
* wtf/Assertions.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 13 Apr 2011 07:52:13 +0000 (07:52 +0000)]
Unreviewed. Fixed chromium test expectations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 13 Apr 2011 07:22:34 +0000 (07:22 +0000)]
2011-04-13 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: requestDocument can result in race condition in DOMAgent.js
https://bugs.webkit.org/show_bug.cgi?id=58415
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.requestDocument.onDocumentAvailable):
(WebInspector.DOMAgent.prototype.requestDocument):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 13 Apr 2011 07:04:20 +0000 (07:04 +0000)]
2011-04-12 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: another pass of protocol renames.
https://bugs.webkit.org/show_bug.cgi?id=58340
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::setSearchingForNode):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._setSearchingForNode):
(WebInspector.ElementsPanel.prototype.setSearchingForNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 13 Apr 2011 06:54:36 +0000 (06:54 +0000)]
2011-04-12 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Adjusted chromium test expectations
- adding WIN crash for webgl-reflection.html
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Apr 2011 06:45:26 +0000 (06:45 +0000)]
2011-04-12 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=58131
Provide a workaround for an obscure Studio 12 compiler bug, which
couldn't call src->~T() on a const T *src.
* wtf/Vector.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 13 Apr 2011 06:34:47 +0000 (06:34 +0000)]
Unreviewed. Fixed malformed chromium test expectations line.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 13 Apr 2011 06:05:30 +0000 (06:05 +0000)]
2011-04-12 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Adjusted chromium test expectations:
- missing expectations for child-layer-3d-sorting.html
- adopt-node-crash.html crash of mac debug gpu
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 13 Apr 2011 05:47:47 +0000 (05:47 +0000)]
2011-04-12 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Add WebSettings::setValidationMessageTimerMagnification()
https://bugs.webkit.org/show_bug.cgi?id=57426
* platform/chromium/test_expectations.txt:
Remove validation-message-appearance.html because it becomes non-flaky
by the DRT change.
2011-04-12 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Add WebSettings::setValidationMessageTimerMagnification()
https://bugs.webkit.org/show_bug.cgi?id=57426
* public/WebSettings.h: Declare new function.
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setValidationMessageTimerMagnification):
Passing the specified value to WebCore::Settings.
* src/WebSettingsImpl.h: Declare new function.
2011-04-12 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Add WebSettings::setValidationMessageTimerMagnification()
https://bugs.webkit.org/show_bug.cgi?id=57426
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::applyTo): Disable the validation message timer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Apr 2011 05:12:39 +0000 (05:12 +0000)]
2011-04-12 Luke Macpherson <macpherson@chromium.org>
Reviewed by Dimitri Glazkov.
Implement remaining Background and Mask css properties in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=58390
No new tests required as no functionality changed.
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyExpanding): Class to expand one property to 0-4 properties.
(WebCore::ApplyPropertyExpandingSuppressValue): Expand properties but suppress applyValue.
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
(WebCore::CSSStyleSelector::applyProperty): Remove implementations that have been moved to CSSStyleApplyProperty.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Apr 2011 05:07:59 +0000 (05:07 +0000)]
2011-04-12 Sergey Glazunov <serg.glazunov@gmail.com>
Reviewed by Dimitri Glazkov.
Element::setAttribute should check the namespace of an id attribute
https://bugs.webkit.org/show_bug.cgi?id=58359
* fast/dom/id-attribute-with-namespace-crash-expected.txt: Added.
* fast/dom/id-attribute-with-namespace-crash.html: Added.
2011-04-12 Sergey Glazunov <serg.glazunov@gmail.com>
Reviewed by Dimitri Glazkov.
Element::setAttribute should check the namespace of an id attribute
https://bugs.webkit.org/show_bug.cgi?id=58359
Test: fast/dom/id-attribute-with-namespace-crash.html
* dom/Element.cpp:
(WebCore::Element::setAttribute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Apr 2011 04:49:52 +0000 (04:49 +0000)]
2011-04-12 Mike Lawther <mikelawther@chromium.org>
Reviewed by James Robinson.
Update boolean operators in RenderStyle to be compatible with check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=58409
No new functionality, so no new tests.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::operator==):
(WebCore::RenderStyle::inheritedNotEqual):
(WebCore::positionedObjectMoved):
(WebCore::RenderStyle::diff):
(WebCore::RenderStyle::applyTransform):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::isOriginalDisplayInlineType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Wed, 13 Apr 2011 04:35:33 +0000 (04:35 +0000)]
2011-04-12 Alexey Proskuryakov <ap@apple.com>
Reviewed by Oliver Hunt.
REGRESSION (WebKit2): Input methods are active in non-editable content
https://bugs.webkit.org/show_bug.cgi?id=58404
<rdar://problem/
9275940>
* UIProcess/API/mac/WKView.mm:
(-[WKView insertText:]): Re-add the old variant of this function, because it's not only part
of deprecated NSTextInput protocol, but it's also part of NSResponder, and it's called when
the input context in nil.
(-[WKView inputContext]): Return nil when not in editable content.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 13 Apr 2011 04:31:52 +0000 (04:31 +0000)]
2011-04-12 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Added chromium baselines for new tests.
* platform/chromium/test_expectations.txt:
* platform/chromium-linux/fast/borders/bidi-002-expected.png: Added.
* platform/chromium-linux/fast/borders/bidi-004-expected.png: Added.
* platform/chromium-linux/fast/borders/bidi-009a-expected.png: Added.
* platform/chromium-linux/fullscreen/full-screen-zIndex-expected.txt: Added.
* platform/chromium-mac-leopard/fast/borders/bidi-002-expected.png: Added.
* platform/chromium-mac-leopard/fast/borders/bidi-004-expected.png: Added.
* platform/chromium-mac-leopard/fast/borders/bidi-009a-expected.png: Added.
* platform/chromium-win/fast/borders/bidi-002-expected.png: Added.
* platform/chromium-win/fast/borders/bidi-002-expected.txt: Added.
* platform/chromium-win/fast/borders/bidi-004-expected.png: Added.
* platform/chromium-win/fast/borders/bidi-004-expected.txt: Added.
* platform/chromium-win/fast/borders/bidi-009a-expected.png: Added.
* platform/chromium-win/fast/borders/bidi-009a-expected.txt: Added.
* platform/chromium-win/fast/inline/positioned-object-between-replaced-elements-expected.txt: Added.
* platform/chromium-win/fullscreen/full-screen-zIndex-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
luiz@webkit.org [Wed, 13 Apr 2011 04:30:11 +0000 (04:30 +0000)]
[Qt] QNetworkReplyHandler refactoring: remove nested event loop.
https://bugs.webkit.org/show_bug.cgi?id=58375
Reviewed by Andreas Kling.
As QNAM now makes actual synchronous loads there is no need for a nested event loop
in ResourceHandleQt.
Moving the call for QNetworkReplyWrapper::synchronousLoad from
ResourceHandle::loadResourceSynchronously to QNetworkReplyHandler::start for the
redirections to work in synchronous requests.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::ResourceHandle::loadResourceSynchronously):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vangelis@chromium.org [Wed, 13 Apr 2011 04:13:33 +0000 (04:13 +0000)]
2011-04-12 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by James Robinson.
[chromium] Adding layout test for:
https://bugs.webkit.org/show_bug.cgi?id=58397
* platform/chromium-gpu-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.checksum: Added.
* platform/chromium-gpu-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Added.
* platform/chromium-gpu-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Added.
* platform/chromium/compositing/child-layer-3d-sorting.html: Added.
* platform/chromium/test_expectations.txt:
2011-04-12 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by James Robinson.
[chromium] Move the calculation of the layer's z coordinate to the
right spot so that it can be picked up by its sublayers.
https://bugs.webkit.org/show_bug.cgi?id=58397
Test: platform/chromium/compositing/child-layer-3d-sorting.html
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Apr 2011 04:04:01 +0000 (04:04 +0000)]
2011-04-12 Antoine Labour <piman@chromium.org>
Reviewed by Kenneth Russell.
Allow WebView users to recreate dependent contexts after a context lost
event. Similarly to the startup case, a temporary context gets created,
that gets used by the layer renderer once it itself gets recreated.
https://bugs.webkit.org/show_bug.cgi?id=58385
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::reallocateRenderer): use the temporary context to
recreate the layer renderer if it's valid.
(WebKit::WebViewImpl::graphicsContext3D): create a temporary context if
the layer renderer's context is lost.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
koz@chromium.org [Wed, 13 Apr 2011 03:55:14 +0000 (03:55 +0000)]
2011-04-12 James Kozianski <koz@chromium.org>
Unreviewed.
Adding myself to committers.py.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
luiz@webkit.org [Wed, 13 Apr 2011 03:30:32 +0000 (03:30 +0000)]
[Qt] QNetworkReplyHandler refactoring: signal queue
https://bugs.webkit.org/show_bug.cgi?id=57075
Reviewed by Andreas Kling.
The idea is to make all signals that come from the QNetworkReply to pass through a queue and to
stop that queue when loading is deferred. This way almost all the deferred logic can be removed
from QNetworkReplyHandler class and encapsulated in its own class.
To stop the queue during wrapper methods execution avoids stacking handler methods over wrapper
methods. Because of this there is no chance for the wrapper to be destroyed inside one of its methods.
This together with empting the queue at wrapper destruction time makes sure that the handler will
not receive calls from a dead wrapper.
The new class is named QNetworkReplyHandlerCallQueue.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandlerCallQueue::QNetworkReplyHandlerCallQueue):
(WebCore::QNetworkReplyHandlerCallQueue::push):
(WebCore::QNetworkReplyHandlerCallQueue::lock):
(WebCore::QNetworkReplyHandlerCallQueue::unlock):
(WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):
(WebCore::QNetworkReplyHandlerCallQueue::flush):
(WebCore::QueueLocker::QueueLocker):
(WebCore::QueueLocker::~QueueLocker):
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::readyRead):
(WebCore::QNetworkReplyWrapper::didReceiveFinished):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::resetState):
(WebCore::QNetworkReplyHandler::release):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
(WebCore::QNetworkReplyHandler::synchronousLoad):
* platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyHandlerCallQueue::deferSignals):
(WebCore::QNetworkReplyHandlerCallQueue::clear):
(WebCore::QNetworkReplyWrapper::synchronousLoad):
(WebCore::QNetworkReplyHandler::setLoadingDeferred):
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::loadResourceSynchronously):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 13 Apr 2011 03:24:58 +0000 (03:24 +0000)]
2011-04-12 Kenichi Ishibashi <bashi@chromium.org>
Reviewed by Kent Tamura.
Fix wrong calculation of HTMLFormElement::m_associatedElementsAfterIndex.
https://bugs.webkit.org/show_bug.cgi?id=58247
Added tests which ensure calculation of m_associatedElementsAfterIndex
doesn't get wrong.
* fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1-expected.txt: Added.
* fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html: Added.
* fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail2-expected.txt: Added.
* fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail2.html: Added.
2011-04-12 Kenichi Ishibashi <bashi@chromium.org>
Reviewed by Kent Tamura.
Fix wrong calculation of HTMLFormElement::m_associatedElementsAfterIndex.
https://bugs.webkit.org/show_bug.cgi?id=58247
- Increment m_associatedElementsAfterIndex when the form owner and an
inserted form associated element have the same parent chain.
- Always iterate over m_associatedElements to decrease indexes when a
form associated element is removed. This is needed for a case that the
form associated element is removed from the form element due to
deleting the 'form' attribute. No behavioral change expected with this
change.
Tests: fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html
fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail2.html
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formElementIndexWithFormAttribute):
Incremet m_associatedElementsAfterIndex when compareDocumentPosition()
returns DOCUMENT_POSITION_CONTAINED_BY.
(WebCore::HTMLFormElement::removeFormElement):
Always iterate m_associatedElements to adjust indexes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
diegohcg@webkit.org [Wed, 13 Apr 2011 02:43:14 +0000 (02:43 +0000)]
2011-04-12 Diego Gonzalez <diegohcg@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Do not show scrollbars when use mobile theme
https://bugs.webkit.org/show_bug.cgi?id=58380
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarThemeQt::scrollbarThickness):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 13 Apr 2011 02:27:44 +0000 (02:27 +0000)]
2011-04-12 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Alexey Proskuryakov.
The default backspace event handler should mark the event as handled if navigation succeeds.
https://bugs.webkit.org/show_bug.cgi?id=58379
We should mark the event as handled only if we were able to successfully navigate backwards or forwards.
These navigations can fail if there is now back/forward history. This can occur in cases like ChromeFrame
where history is managed by an external browser like IE.
No new tests added as this scenario can occur when the history view is split across two browsers (WebKit and IE)
It is non trivial to simulate this environment.
* page/EventHandler.cpp:
(WebCore::EventHandler::defaultBackspaceEventHandler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 13 Apr 2011 02:24:20 +0000 (02:24 +0000)]
<rdar://problem/
9029193> and https://bugs.webkit.org/show_bug.cgi?id=58406
Bringing up the context menu on a link might also follow the link.
Reviewed by Maciej Stachowiak.
This patch adds a flag that is set just before the WebProcess tells the UIProcess to show a context menu.
As long as this flag is set, the WebProcess will ignore any other mouse events that might have queued up
by the time the UIProcess gets around to showing the menu.
After the UIProcess is done showing the menu, it messages back telling the WebProcess to clear the flag
and resume normal MouseEvent handling.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showContextMenu): No matter what internalShowContextMenu does, always notify
the WebProcess that any context menu is now hidden.
(WebKit::WebPageProxy::internalShowContextMenu):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::show): Since we're telling the UIProcess to show the menu, tell the WebPage a
context menu is showing so it will stop handling mouse events.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::mouseEvent): Don't try to handle mouse events if a context menu is flagged as showing.
Add accessors to twiddle the "context menu showing" flag:
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::contextMenuShowing):
(WebKit::WebPage::contextMenuHidden):
* WebProcess/WebPage/WebPage.messages.in: Add the ContextMenuHidden message.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 13 Apr 2011 02:22:40 +0000 (02:22 +0000)]
Quarantine related sandbox denial when downloading files
<rdar://problem/
9203736>
Reviewed by Maciej Stachowiak.
* WebProcess/com.apple.WebProcess.sb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 13 Apr 2011 02:15:59 +0000 (02:15 +0000)]
Sandbox violations dragging an image to the desktop.
<rdar://problem/
9261834>
Reviewed by Anders Carlsson.
* WebProcess/com.apple.WebProcess.sb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 13 Apr 2011 02:13:33 +0000 (02:13 +0000)]
2011-04-12 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Make availableWidth and totalOverhangWidth in findNextLineBreak member variables of LineWidth
https://bugs.webkit.org/show_bug.cgi?id=58400
Added m_availableWidth and m_overhangWidth to LineWidth this allows us to encapsulate m_overhangWidth.
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::fitsOnLine): Added; returns true if current width + first argument <= availableWidth.
(WebCore::LineWidth::availableWidth): Added.
(WebCore::LineWidth::setAvailableWidth): Added; takes LineOffsets.
(WebCore::LineWidth::applyOverhang): Added; obtains the overhang width from ruby run and inflates
the available width.
(WebCore::LineWidth::fitBelowFloats): Moved from RenderBlock.
(WebCore::RenderBlock::findNextLineBreak): Uses LineWidth.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Wed, 13 Apr 2011 01:57:59 +0000 (01:57 +0000)]
2011-04-12 Alexis Menard <alexis.menard@openbossa.org>
Unreviewed warning fix.
MediaControlElements has been moved to html/shadow.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 13 Apr 2011 01:39:25 +0000 (01:39 +0000)]
Sandbox violations trying to access ~/Library/Keyboard Layouts and ~/Library/Input Methods
<rdar://problem/
8973159>
Reviewed by Cameron Zwarich.
* WebProcess/com.apple.WebProcess.sb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Wed, 13 Apr 2011 01:35:24 +0000 (01:35 +0000)]
Rename onEndChain and make it a static method.
https://bugs.webkit.org/show_bug.cgi?id=58403
Reviewed by Eric Seidel.
No new tests since this is refactoring only.
* rendering/InlineFlowBox.cpp:
(WebCore::isLastChildForRenderer):
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
* rendering/InlineFlowBox.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Wed, 13 Apr 2011 01:24:30 +0000 (01:24 +0000)]
Unreviewed, update chromium test expectations.
Mark array-proto-func-property-getter-except.html and full-screen-zIndex.html
as filed in chromium.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Wed, 13 Apr 2011 01:21:11 +0000 (01:21 +0000)]
2011-04-12 Eric Carlson <eric.carlson@apple.com>
Not reviewed, build fix.
Fix non-accelerated build after r83667.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerFirstVideoFrameAvailable): Guard call to
mediaPlayerRenderingModeChanged with USE(ACCELERATED_COMPOSITING.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Wed, 13 Apr 2011 01:01:35 +0000 (01:01 +0000)]
2011-04-12 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix.
* webkit/webkitwebhistoryitem.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Wed, 13 Apr 2011 00:50:36 +0000 (00:50 +0000)]
2011-04-12 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] TilingData mishandles very small texture sizes
https://bugs.webkit.org/show_bug.cgi?id=58364
Use zero tiles when the texture size is too small for tiling.
* platform/graphics/gpu/TilingData.cpp:
(WebCore::TilingData::TilingData):
(WebCore::TilingData::setMaxTextureSize):
2011-04-12 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] TilingData mishandles very small texture sizes
https://bugs.webkit.org/show_bug.cgi?id=58364
Update test to properly handle texture sizes of 0-3.
* tests/TilingDataTest.cpp:
(WebCore::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 13 Apr 2011 00:24:31 +0000 (00:24 +0000)]
2011-04-12 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed, rolling out r83634 and r83659.
http://trac.webkit.org/changeset/83634
http://trac.webkit.org/changeset/83659
https://bugs.webkit.org/show_bug.cgi?id=57075
It made 2 tests time out
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::didReceiveFinished):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::resetState):
(WebCore::QNetworkReplyHandler::setLoadingDeferred):
(WebCore::QNetworkReplyHandler::resumeDeferredLoad):
(WebCore::QNetworkReplyHandler::release):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::resourceResponse):
(WebCore::WebCoreSynchronousLoader::resourceError):
(WebCore::WebCoreSynchronousLoader::data):
(WebCore::WebCoreSynchronousLoader::setReplyFinished):
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::WebCoreSynchronousLoader::waitForCompletion):
(WebCore::ResourceHandle::loadResourceSynchronously):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 13 Apr 2011 00:20:11 +0000 (00:20 +0000)]
2011-04-12 Sam Weinig <sam@webkit.org>
Reviewed by Simon Fraser.
Frames prevent scrolling containing page
<rdar://problem/
8990409>
https://bugs.webkit.org/show_bug.cgi?id=58392
Also fixes:
Should rubber-band on pages with no scrollbars
<rdar://problem/
9034280>
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
Make the main frame rubber-band horizontally and vertically always.
* platform/ScrollTypes.h:
Add ScrollElasticity enum.
* platform/ScrollableArea.cpp:
Default to no elasticity.
(WebCore::ScrollableArea::ScrollableArea):
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::setVerticalScrollElasticity):
(WebCore::ScrollableArea::verticalScrollElasticity):
(WebCore::ScrollableArea::setHorizontalScrollElasticity):
(WebCore::ScrollableArea::horizontalScrollElasticity):
Add state for horizontal and vertical elasticity.
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleWheelEvent):
Bail out of new scrolling behavior if we can't rubber-band. By bailing before
accepting the wheel event, we allow the wheel event to be forwarded. We will
need to refine this logic to allow subframe scrolling in the future.
(WebCore::ScrollAnimatorMac::allowsVerticalStretching):
(WebCore::ScrollAnimatorMac::allowsHorizontalStretching):
Switch stretching behavior based on the ScrollableArea's elasticity.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 13 Apr 2011 00:18:29 +0000 (00:18 +0000)]
2011-04-12 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Try to fix the Chromium build.
Why have one URL when you can have two at twice the price?
* platform/KURL.h:
(WebCore::KURL::KURL):
(WebCore::KURL::isHashTableDeletedValue):
* platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::KURLGooglePrivate):
* platform/KURLGooglePrivate.h: Added a GoogleURL path for KURL's hash
table deleted value constructor.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 13 Apr 2011 00:18:04 +0000 (00:18 +0000)]
[Qt] http/tests/misc/favicon-loads-with-icon-loading-override.html fails
https://bugs.webkit.org/show_bug.cgi?id=58396
* platform/qt/Skipped: Add http/tests/misc/favicon-loads-with-icon-loading-override.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 13 Apr 2011 00:13:43 +0000 (00:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=58395
Exceptions thrown from property getters called from Array prototype functions can be missed
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
This is caught by an ASSERT in the top of Interpreter::executeCall.
Check for exceptions after accessing properties that could be getters.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):
(JSC::arrayProtoFuncEvery):
(JSC::arrayProtoFuncForEach):
(JSC::arrayProtoFuncSome):
(JSC::arrayProtoFuncReduce):
(JSC::arrayProtoFuncReduceRight):
- Add exception checks.
LayoutTests:
Added layout test.
* fast/js/array-proto-func-property-getter-except-expected.txt: Added.
* fast/js/array-proto-func-property-getter-except.html: Added.
* fast/js/script-tests/array-proto-func-property-getter-except.js: Added.
(test.propertyGetter):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Wed, 13 Apr 2011 00:13:11 +0000 (00:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=58280
Fix a layout test by correctly comparing enums, and not adding exceptions.
Reviewed by Oliver Hunt.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
* bindings/js/SerializedScriptValue.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Wed, 13 Apr 2011 00:01:11 +0000 (00:01 +0000)]
2011-04-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
Apple movie trailers play only audio
https://bugs.webkit.org/show_bug.cgi?id=58339
<rdar://problem/
9237606>
No new tests, covered by existing layout and manual tests.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerEngineUpdated): Do the logging before calling any functions.
(WebCore::HTMLMediaElement::mediaPlayerFirstVideoFrameAvailable): New, if still displaying the poster
change the display mode to Video and force a style recalc so the video layer gets hooked
up the the render tree.
* html/HTMLMediaElement.h: Define new display mode, PosterWaitingForVideo, to signal that we
want to stop displaying the poster as soon as the first frame of video is available.
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::setDisplayMode): Change display mode to PosterWaitingForVideo when
we want to display Video but the media engines doesn't have the first frame yet.
* html/HTMLVideoElement.h:
(WebCore::HTMLVideoElement::shouldDisplayPosterImage): Update to return true when display mode
is PosterWaitingForVideo.
* manual-tests/media-elements/video-replaces-poster.html: Clean up bit-rot from patch changes.
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::firstVideoFrameAvailable): New, passthrough from media engien to element.
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerFirstVideoFrameAvailable):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Initialize
m_haveReportedFirstVideoFrame and m_playWhenFramesAvailable.
(WebCore::MediaPlayerPrivateAVFoundation::play): Don't actually start playback until the first
frame of video has loaded, or audio will begin to play before we can show video.
(WebCore::MediaPlayerPrivateAVFoundation::pause): Clear m_playWhenFramesAvailable.
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): When first frame of video is
available, inform elment and begin playback if it was previousl requested.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyContextVideoRenderer): Correct logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPlay): Renamed from play.
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPause): Rename from pause.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Tue, 12 Apr 2011 23:56:37 +0000 (23:56 +0000)]
2011-04-12 Jian Li <jianli@chromium.org>
Unreviewed, rolling out r83649.
http://trac.webkit.org/changeset/83649
https://bugs.webkit.org/show_bug.cgi?id=57563
This patch causes compiling errors for chromium
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::Font::drawComplexText):
* platform/graphics/chromium/ImageBufferData.h:
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/PlatformCanvas.cpp:
(WebCore::PlatformCanvas::resize):
* platform/graphics/chromium/PlatformCanvas.h:
* platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::compositeTextComposite):
(WebCore::TransparencyWin::makeLayerOpaque):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::setCanvas):
(WebCore::PlatformContextSkia::isPrinting):
(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
* platform/graphics/skia/PlatformContextSkia.h:
(WebCore::PlatformContextSkia::canvas):
2011-04-12 Jian Li <jianli@chromium.org>
Unreviewed, rolling out r83649.
http://trac.webkit.org/changeset/83649
https://bugs.webkit.org/show_bug.cgi?id=57563
This patch causes compiling errors for chromium
* public/WebCanvas.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::printPage):
* tests/TransparencyWinTest.cpp:
(WebCore::drawNativeRect):
(WebCore::getPixelAt):
(WebCore::clearTopLayerAlphaChannel):
(WebCore::clearTopLayerAlphaPixel):
(WebCore::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Tue, 12 Apr 2011 23:51:59 +0000 (23:51 +0000)]
Implement non-activating clicks to allow dragging out of a background window.
https://bugs.webkit.org/show_bug.cgi?id=55053
<rdar://problem/
9042197>
Source/WebCore:
Reviewed by Alexey Proskuryakov.
* WebCore.exp.in: Added new exported method.
Source/WebKit2:
Reviewed by Alexey Proskuryakov and Sam Weinig.
Added methods to WKView to support non activating click. Unfortunately both
methods require a synchronous call to the WebProcess to decide what to do.
acceptFirstMouse is called only if shouldDelayWindowOrderingForEvent returns
true. In order to minimize the number of synchronous calls, we send the request
only if our window is not the key window.
* UIProcess/API/mac/WKView.mm:
(-[WKView acceptsFirstMouse:]):
(-[WKView shouldDelayWindowOrderingForEvent:]):
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::shouldDelayWindowOrderingForEvent):
(WebKit::WebPageProxy::acceptsFirstMouse):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Tue, 12 Apr 2011 23:48:11 +0000 (23:48 +0000)]
2011-04-12 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make API callback objects use weak handles to run their finalizers
https://bugs.webkit.org/show_bug.cgi?id=58389
Make the API object's private data struct act as a finalizer for
an api object if the callback object has a API defined finalizer.
* API/JSCallbackObject.cpp:
(JSC::JSCallbackObjectData::finalize):
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::init):
* heap/Handle.h:
2011-04-12 Geoffrey Garen <ggaren@apple.com>
Reviewed by Geoffrey Garen.
Cleaned up hash traits, and added hash traits for handles
https://bugs.webkit.org/show_bug.cgi?id=58381
* dom/QualifiedName.h: Use new SimpleClassHashTraits to avoid duplication.
* platform/KURL.h:
(WebCore::KURL::KURL):
(WebCore::KURL::isHashTableDeletedValue): Added explicit hash table
deleted value constructor, to be more explicit and enable use of
SimpleClassHashTraits.
* platform/KURLHash.h: Use new SimpleClassHashTraits to avoid duplication.
* platform/graphics/FontCache.cpp: Ditto.
* platform/network/ProtectionSpaceHash.h: Ditto.
* svg/properties/SVGAnimatedPropertyDescription.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Tue, 12 Apr 2011 23:37:18 +0000 (23:37 +0000)]
Unreviewed; add two new tests to the mac-wk2 SkippedList.
Skip fullscreen/video-specified-size.html and fullscreen/full-screen-zIndex.html
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 12 Apr 2011 23:34:07 +0000 (23:34 +0000)]
Reviewed by Oliver Hunt.
Crash when serializing a null AttributedString
https://bugs.webkit.org/show_bug.cgi?id=58393
<rdar://problem/
9275326>
* Shared/mac/AttributedString.mm:
(WebKit::AttributedString::encode):
(WebKit::AttributedString::decode):
Prefix the serialized value with an isNull tag.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 12 Apr 2011 23:27:37 +0000 (23:27 +0000)]
2011-04-12 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make API callback objects use weak handles to run their finalizers
https://bugs.webkit.org/show_bug.cgi?id=58389
Make the API object's private data struct act as a finalizer for
an api object if the callback object has a API defined finalizer.
* API/JSCallbackObject.cpp:
(JSC::JSCallbackObjectData::finalize):
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::init):
* heap/Handle.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jam@chromium.org [Tue, 12 Apr 2011 23:22:13 +0000 (23:22 +0000)]
2011-04-12 John Abd-El-Malek <jam@chromium.org>
Reviewed by Jian Li.
[chromium] Fix spellcheck regression in context menus
https://bugs.webkit.org/show_bug.cgi?id=58386
* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
2011-04-12 John Abd-El-Malek <jam@chromium.org>
Reviewed by Jian Li.
[chromium] Fix spellcheck regression in context menus
https://bugs.webkit.org/show_bug.cgi?id=58386
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
luiz@webkit.org [Tue, 12 Apr 2011 23:20:39 +0000 (23:20 +0000)]
[Qt] QNetworkReplyHandler refactoring: remove nested event loop.
https://bugs.webkit.org/show_bug.cgi?id=58375
Reviewed by Andreas Kling.
As QNAM now makes actual synchronous loads there is no need for a nested event loop
in ResourceHandleQt.
Moving the call for QNetworkReplyWrapper::synchronousLoad from
ResourceHandle::loadResourceSynchronously to QNetworkReplyHandler::start for the
redirections to work in synchronous requests.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::start):
* platform/network/qt/QNetworkReplyHandler.h:
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::ResourceHandle::loadResourceSynchronously):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 12 Apr 2011 23:11:09 +0000 (23:11 +0000)]
2011-04-12 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Tony Chang.
[chromium] Use new dragTargetDragEnter() function signature
https://bugs.webkit.org/show_bug.cgi?id=58303
After WebKit/chromium/DEPS rolls to chromium r80907, the drag identity
based version of dragTargetDragEnter() is no longer used; remove it.
* public/WebView.h:
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83658
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 12 Apr 2011 22:59:04 +0000 (22:59 +0000)]
Unreviewed build correction for WinCairo bot after r83639.
https://bugs.webkit.org/show_bug.cgi?id=51790
Correct typo for the new "update-webkit-wincairo-libs" script.
* Scripts/build-webkit: Incorrectly calling the
update-webkit-cairo-libs which does not exist.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Tue, 12 Apr 2011 22:49:46 +0000 (22:49 +0000)]
A change that should have been part of trac.webkit.org/changeset/83628
Reviewed by Jon Honeycutt.
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Tue, 12 Apr 2011 22:48:39 +0000 (22:48 +0000)]
Infinite recursion in WebHTMLView executeSavedKeypressCommands.
https://bugs.webkit.org/show_bug.cgi?id=58382
<rdar://problem/
9239370>
Reviewed by Alexey Proskuryakov.
Execution of some editing commands could trigger a call to selectedRange that
internally calls executeSavedKeypressCommands creating an infinite recursion.
Source/WebKit/mac:
* WebView/WebHTMLView.mm:
(-[WebHTMLView _executeSavedKeypressCommands]): Added a flag to avoid recursion.
(-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added flag initialization.
Source/WebKit2:
* UIProcess/API/mac/WKView.mm:
(-[WKView _executeSavedKeypressCommands]): Added flag to avoid recursion.
(-[WKView _interpretKeyEvent:withCachedTextInputState:savingCommandsTo:WebCore::]):
Added flag initialization.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Tue, 12 Apr 2011 22:46:01 +0000 (22:46 +0000)]
2011-04-11 Jer Noble <jer.noble@apple.com>
Reviewed by Simon Fraser.
REGRESSION: Vimeo fullscreen video displays incorrectly
https://bugs.webkit.org/show_bug.cgi?id=58291
* fullscreen/video-specified-size-expected.txt: Added.
* fullscreen/video-specified-size.html: Added.
* fullscreen/full-screen-test.js:
* fullscreen/full-screen-zIndex-expected.txt: Added.
* fullscreen/full-screen-zIndex.html: Added.
* platform/mac/fullscreen/full-screen-zIndex-expected.checksum: Added.
* platform/mac/fullscreen/full-screen-zIndex-expected.png: Added.
2011-04-11 Jer Noble <jer.noble@apple.com>
Reviewed by Simon Fraser.
REGRESSION: Vimeo fullscreen video displays incorrectly
https://bugs.webkit.org/show_bug.cgi?id=58291
Set the RenderFullScreen's zIndex to the max. And make sure to override
a video element's specified width and height by making its full screen rules
important. Also, always show the controls when a media element is in full
screen mode.
Test: fullscreen/video-specified-size.html
Test: fullscreen/full-screen-zIndex.html
* css/fullscreen.css:
(video:-webkit-full-screen):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::controls): Always show controls in full screen mode.
(WebCore::HTMLMediaElement::preDispatchEventHandler): Added. Handle the fullscreen
change event and hide or show the controls accordingly.
* html/HTMLMediaElement.h:
* rendering/RenderFullScreen.cpp:
(RenderFullScreen::createFullScreenStyle): Set the zIndex to INT_MAX and use a
vertical flexbox instead of a horizontal one.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Tue, 12 Apr 2011 22:43:19 +0000 (22:43 +0000)]
2011-04-12 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Page tears and stutters in WebKit2 when page is > 2048 pixels wide
https://bugs.webkit.org/show_bug.cgi?id=58330
Added API to GraphicsLayer to disable switching to tiled layers. This is
set in the nonCompositedContentLayer in WK2, causing that layer to never
switch to tiles and avoiding the asynchronous update of the content during
scroll.
* platform/graphics/ca/GraphicsLayerCA.cpp:
Implement setAllowTiledLayer() to simulate a SizeChanged action to
properly switch between tiled and untiled layer.
* platform/graphics/ca/GraphicsLayerCA.h:
2011-04-12 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Page tears and stutters in WebKit2 when page is > 2048 pixels wide
https://bugs.webkit.org/show_bug.cgi?id=58330
Turn off tiling for nonCompositedContentLayer to avoid tearing when
scrolling very wide (> 2048) windows.
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::initialize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Tue, 12 Apr 2011 22:43:01 +0000 (22:43 +0000)]
Unreviewed.
Unskip t0805-c5519-ibrdr-r-00-a.html, since it is now passing.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Tue, 12 Apr 2011 22:41:12 +0000 (22:41 +0000)]
Added http/tests/misc/favicon-loads-with-icon-loading-override.html
to mac-wk2 skipped list because resource load callbacks aren't implemented
in WebKitTestRunner.
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Tue, 12 Apr 2011 22:35:43 +0000 (22:35 +0000)]
Unreviewed.
Update results after r83638.
* platform/qt/css1/box_properties/padding_right_inline-expected.checksum:
* platform/qt/css1/box_properties/padding_right_inline-expected.png:
* platform/qt/css1/box_properties/padding_right_inline-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 12 Apr 2011 22:27:04 +0000 (22:27 +0000)]
2011-04-12 Alok Priyadarshi <alokp@chromium.org>
Reviewed by James Robinson.
Remove dependency on chromium skia::PlatformCanvas
https://bugs.webkit.org/show_bug.cgi?id=57563
This patch does not change any functionality, just the type of object skia::PlatformCanvas -> SkCanvas.
The object is still being created by a factory method skia::CreateBitmapCanvas defined in Chromium.
We will eventually define an API that every port using skia will define.
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
(WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
(WebCore::Font::drawComplexText):
* platform/graphics/chromium/ImageBufferData.h:
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/PlatformCanvas.cpp:
(WebCore::PlatformCanvas::resize):
* platform/graphics/chromium/PlatformCanvas.h:
* platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::compositeTextComposite):
(WebCore::TransparencyWin::makeLayerOpaque):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::setCanvas):
(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
* platform/graphics/skia/PlatformContextSkia.h:
(WebCore::PlatformContextSkia::canvas):
(WebCore::PlatformContextSkia::printing):
(WebCore::PlatformContextSkia::setPrinting):
2011-04-12 Alok Priyadarshi <alokp@chromium.org>
Reviewed by James Robinson.
Remove dependency on chromium skia::PlatformCanvas
https://bugs.webkit.org/show_bug.cgi?id=57563
* public/WebCanvas.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::printPage):
* tests/TransparencyWinTest.cpp:
(WebCore::drawNativeRect):
(WebCore::getPixelAt):
(WebCore::clearTopLayerAlphaChannel):
(WebCore::clearTopLayerAlphaPixel):
(WebCore::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Tue, 12 Apr 2011 22:20:17 +0000 (22:20 +0000)]
Unreviewed, update chromium test expectations.
Mark 3 bidi related layout tests as failed in chromium.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83648
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 12 Apr 2011 22:05:34 +0000 (22:05 +0000)]
2011-04-12 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Assertion in DrawingAreaImpl::resumePainting() (m_isPaintingSuspended) when clicking a link at twitter.com
https://bugs.webkit.org/show_bug.cgi?id=58377
<rdar://problem/
8976531>
Remove the assertion.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::resumePainting):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 12 Apr 2011 22:02:14 +0000 (22:02 +0000)]
2011-04-12 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: --results-directory is relative to builddir, not $PWD
https://bugs.webkit.org/show_bug.cgi?id=58272
NRWT was interpreting the --results-directory cmd line arg as
relative to the build directory, not the current working
directory (ORWT uses the latter, which is much more intuitive).
This patch fixes the base case, but includes an override for
Chromium that is needed until the bots can be updated.
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Tue, 12 Apr 2011 21:50:04 +0000 (21:50 +0000)]
../WebCore: https://bugs.webkit.org/show_bug.cgi?id=58280
<rdar://problem/
9252824> javascript in an inconsistent state due to serialization returning an un-handled exception
Currently serialization and deserialization can throw javascript exceptions. Since SerializedScriptValue is called in
several places that do not always involve direct calls into javascript have the functions return an error code and the callers
decide whether or not to throw exceptions.
Reviewed by Oliver Hunt.
Don't allow SerializedScriptValue to attempt to serialize objects that inherit from JSNavigator.h. Walking that object creates
additional objects which eventually causes serialization to end up throwing a stack overflow error. Instead fail immediately.
Untangle header includes. SerializedScriptValue was inheriting ScriptValue.h, but not using it. Since ScriptValue depends on
SerializedScriptValue this could lead to a circular header dependency.
No change in functionality, covered by current tests
* WebCore.exp.in:
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::initMessageEvent):
* bindings/js/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::deserialize):
* bindings/js/ScriptValue.h:
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::deserialize):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
(WebCore::SerializedScriptValue::maybeThrowExceptionIfSerializationFailed):
(WebCore::SerializedScriptValue::serializationDidCompleteSuccessfully):
* bindings/js/SerializedScriptValue.h:
* bindings/js/JSWorkerContextBase.cpp: header include fix
* loader/FrameLoader.h: header include fix
* page/Frame.cpp: header include fix
../WebKit/gtk: https://bugs.webkit.org/show_bug.cgi?id=58280
<rdar://problem/
9252824> javascript in an inconsistent state due to serialization returning an un-handled exception.
Reviewed by Oliver Hunt.
Add a header include. Fallout from untangling some header files in WebCore.
* webkit/webkitwebhistoryitem.cpp:
../WebKit2: https://bugs.webkit.org/show_bug.cgi?id=58280
<rdar://problem/
9252824> javascript in an inconsistent state due to serialization returning an un-handled exception
Change use of SerializedScriptValue::Create to use the same api as the rest of WebKit2. This has the benefit
of handling any exceptions so Javascript is not in an inconsistent state.
Reviewed by Oliver Hunt.
* Shared/API/c/WKSerializedScriptValue.h: fix a typo
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScriptInMainFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Tue, 12 Apr 2011 21:46:21 +0000 (21:46 +0000)]
Unreviewed, update chromium test expectations.
Mark 3 layout tests as failed in chromium.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 12 Apr 2011 21:42:32 +0000 (21:42 +0000)]
2011-04-12 Philippe Normand <pnormand@igalia.com>
Unreviewed, roll out r83621 as it broke the GTK build.
[GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
https://bugs.webkit.org/show_bug.cgi?id=58333
* Scripts/build-jsc:
* Scripts/build-webkit:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 12 Apr 2011 21:36:50 +0000 (21:36 +0000)]
2011-04-12 Adam Barth <abarth@webkit.org>
Revert unintentional changes to WebKit.
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
* src/WebSettingsImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 12 Apr 2011 21:34:16 +0000 (21:34 +0000)]
Move libtess from WebCore/thirdparty to ThirdParty
https://bugs.webkit.org/show_bug.cgi?id=57288
Reviewed by Kenneth Russell.
We're putting third party code in Source/ThirdParty these days.
* Source/ThirdParty/glu: Copied from Source/WebCore/thirdparty/glu.
* Source/ThirdParty/glu/glu.gyp: Added.
Source/WebCore:
* WebCore.gyp/WebCore.gyp:
- Add libtess as a legit dependency.
* WebCore.gypi:
- Remove libtess files from the gypi.
* thirdparty/glu: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 12 Apr 2011 21:32:58 +0000 (21:32 +0000)]
2011-04-12 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by David Hyatt.
Bundle w and tmpW in findNextLineBreak together as a class
https://bugs.webkit.org/show_bug.cgi?id=58362
Renamed w, tempW, and width in findNextLineBreak to committedWidth, uncommittedWidth,
and availableWidth respectively. Also bundled committedWidth and uncommittedWith as a class
named LineWidth.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::LineWidth): Added.
(WebCore::LineWidth::currentWidth): Added; returns the sum of committed and uncommitted width.
(WebCore::LineWidth::uncommittedWidth): Added.
(WebCore::LineWidth::committedWidth): Added.
(WebCore::LineWidth::addUncommittedWidth): Added; adds the specified width to the uncommitted width.
(WebCore::LineWidth::commit): Added; commits the current width and clears the uncommitted width.
(WebCore::RenderBlock::findNextLineBreak): Uses LineWidth.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 12 Apr 2011 21:28:53 +0000 (21:28 +0000)]
2011-04-12 Carl Lobo <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Patch to download the WinCairo dependancies as part of build-webkit.
https://bugs.webkit.org/show_bug.cgi?id=51790
This patch downloads the dependancies from
http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip
checking the modification timestamp etc.
* Tools/Scripts/build-webkit
* Tools/Scripts/update-webkit: Modified to understand the --wincairo
flag, and to update WinCairo dependencies when used.
* Tools/Scripts/update-webkit-cairo-libs: added
* Tools/Scripts/update-webkit-dependency: added
* Tools/Scripts/update-webkit-auxiliary-libs
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Tue, 12 Apr 2011 21:28:24 +0000 (21:28 +0000)]
2011-04-12 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Eric Seidel.
REGRESSION(r82419): extra border in t0805-c5519-ibrdr-r-00-a.html
https://bugs.webkit.org/show_bug.cgi?id=57459
* fast/borders/bidi-002.html: Added.
* fast/borders/bidi-004.html: Added.
* fast/borders/bidi-009a.html: Added.
* platform/mac/fast/borders/bidi-002-expected.checksum: Added.
* platform/mac/fast/borders/bidi-002-expected.png: Added.
* platform/mac/fast/borders/bidi-002-expected.txt: Added.
* platform/mac/fast/borders/bidi-004-expected.checksum: Added.
* platform/mac/fast/borders/bidi-004-expected.png: Added.
* platform/mac/fast/borders/bidi-004-expected.txt: Added.
* platform/mac/fast/borders/bidi-009a-expected.checksum: Added.
* platform/mac/fast/borders/bidi-009a-expected.png: Added.
* platform/mac/fast/borders/bidi-009a-expected.txt: Added.
2011-04-12 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Eric Seidel.
REGRESSION(r82419): extra border in t0805-c5519-ibrdr-r-00-a.html
https://bugs.webkit.org/show_bug.cgi?id=57459
Slightly change the way we decide if a InlineFlowBox is the last box for its renderer.
We include the border in that box under these conditions:
(1) The next line was not created, or it is constructed. We check the previous line for rtl.
(2) The logicallyLastRun is not a descendant of this renderer.
(3) The logicallyLastRun is a descendant of this renderer, but it is the last child of this renderer and it does not wrap to the next line.
I added the tests from bug 47210, because now the draw the borders correctly.
Tests: fast/borders/bidi-002.html
fast/borders/bidi-004.html
fast/borders/bidi-009a.html
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::onEndChain):
(WebCore::isAnsectorAndWithinBlock):
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
* rendering/InlineFlowBox.h:
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::constructLine):
(WebCore::RenderBlock::layoutInlineChildren):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Tue, 12 Apr 2011 21:12:33 +0000 (21:12 +0000)]
2011-04-12 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Cleaned up some Vector traits, and added missing Vector traits for handles
https://bugs.webkit.org/show_bug.cgi?id=58372
* heap/Local.h: Inherit from SimpleClassVectorTraits to avoid duplication.
* heap/Strong.h: Ditto.
* heap/Weak.h: Ditto.
* parser/JSParser.cpp: Fixed a traits error. No test case because this
particular trait is not currently exercised by the parser.
* runtime/UString.h: No need to override canInitializeWithMemset, since
our base class sets it to true.
* wtf/VectorTraits.h: Inherit from VectorTraitsBase to avoid duplication.
* wtf/text/WTFString.h: No need to override canInitializeWithMemset, since
our base class sets it to true.
2011-04-12 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Cleaned up some Vector traits, and added missing Vector traits for handles
https://bugs.webkit.org/show_bug.cgi?id=58372
* platform/graphics/BitmapImage.h: Added a FIXME because the current
Vector traits for FrameData are logically incorrect, but I couldn't find
a place where this currently results in bad behavior, and it's not
immediately obvious what the right solution is.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 12 Apr 2011 20:59:36 +0000 (20:59 +0000)]
2011-04-12 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Eric Seidel.
Move MediaControlElements to html/shadow.
https://bugs.webkit.org/show_bug.cgi?id=58347
Mechanical move of the files.
* Android.mk: Updated the build file.
* CMakeLists.txt: Ditto.
* GNUmakefile.list.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto, also ran sort-XCode-project-files.
* html/shadow/MediaControlElements.cpp: Copied from Source/WebCore/rendering/MediaControlElements.cpp.
(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
* html/shadow/MediaControlElements.h: Copied from Source/WebCore/rendering/MediaControlElements.h.
* rendering/MediaControlElements.cpp: Removed.
* rendering/MediaControlElements.h: Removed.
* rendering/RenderingAllInOne.cpp: Removed the files that were moved.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 12 Apr 2011 20:53:10 +0000 (20:53 +0000)]
2011-04-12 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory
https://bugs.webkit.org/show_bug.cgi?id=58290
This is some preliminary refactoring for bug 58272.
* Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
* Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
* Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
* Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83635
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
luiz@webkit.org [Tue, 12 Apr 2011 20:46:59 +0000 (20:46 +0000)]
[Qt] QNetworkReplyHandler refactoring: signal queue
https://bugs.webkit.org/show_bug.cgi?id=57075
Reviewed by Andreas Kling.
The idea is to make all signals that come from the QNetworkReply to pass through a queue and to
stop that queue when loading is deferred. This way almost all the deferred logic can be removed
from QNetworkReplyHandler class and encapsulated in its own class.
To stop the queue during wrapper methods execution avoids stacking handler methods over wrapper
methods. Because of this there is no chance for the wrapper to be destroyed inside one of its methods.
This together with empting the queue at wrapper destruction time makes sure that the handler will
not receive calls from a dead wrapper.
The new class is named QNetworkReplyHandlerCallQueue.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandlerCallQueue::QNetworkReplyHandlerCallQueue):
(WebCore::QNetworkReplyHandlerCallQueue::push):
(WebCore::QNetworkReplyHandlerCallQueue::lock):
(WebCore::QNetworkReplyHandlerCallQueue::unlock):
(WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):
(WebCore::QueueLocker::QueueLocker):
(WebCore::QueueLocker::~QueueLocker):
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::readyRead):
(WebCore::QNetworkReplyWrapper::didReceiveFinished):
(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::resetState):
(WebCore::QNetworkReplyHandler::release):
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::forwardData):
(WebCore::QNetworkReplyHandler::start):
(WebCore::QNetworkReplyHandler::synchronousLoad):
* platform/network/qt/QNetworkReplyHandler.h:
(WebCore::QNetworkReplyHandlerCallQueue::deferSignals):
(WebCore::QNetworkReplyHandlerCallQueue::clear):
(WebCore::QNetworkReplyWrapper::synchronousLoad):
(WebCore::QNetworkReplyHandler::setLoadingDeferred):
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::loadResourceSynchronously):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Tue, 12 Apr 2011 20:44:17 +0000 (20:44 +0000)]
2011-04-12 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
https://bugs.webkit.org/show_bug.cgi?id=56020
Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view,
since WebKit will do this for us. If we didn't do this, TranslateMessage() would be called twice,
which would generate two characters for every keypress (for example). I didn't bother doing this for
WebKitTestRunner, since it doesn't get any WM_KEYDOWN events.
Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior.
* MiniBrowser/win/main.cpp:
(shouldTranslateMessage): Added.
(_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
* TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows.
* TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown().
* TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added.
(TestWebKitAPI::didNotHandleKeyEventCallback): Added.
(TestWebKitAPI::runAndWatchForWMChar): Added.
(TestWebKitAPI::TEST): Added.
* TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
(TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
(TestWebKitAPI::Util::shouldTranslateMessage): Added.
* TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added.
* TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp.
2011-04-12 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
https://bugs.webkit.org/show_bug.cgi?id=56020
Safari was always calling TranslateMessage() on key events since it has no way to know whether
WebKit handled the event without a PageUIClient (which Safari only installs on pages inside
a Safari window), which was generating a WM_CHAR message containing the tab in this case. The fix
is for Safari to never call TranslateMessage() on key events outside of a Safari window, but this
means the WebPageProxy needs to do this for unhandled key events if there is no didNotHandleKeyEvent
callback in the PageUIClient.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent): Call TranslateMessage() on Windows for unhandled key events that can't be handled by the PageUIClient.
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::canNotHandleKeyEvent): Added.
* UIProcess/WebUIClient.h: Added canNotHandleKeyEvent().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jam@chromium.org [Tue, 12 Apr 2011 20:40:03 +0000 (20:40 +0000)]
[chromium] Fix spelling layout test. BUG=https://bugs.webkit.org/show_bug.cgi?id=58371
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83632
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log