WebKit-https.git
10 years ago2011-01-13 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 14 Jan 2011 00:39:52 +0000 (00:39 +0000)]
2011-01-13  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        simplify keyboard handling in code review tool
        https://bugs.webkit.org/show_bug.cgi?id=52407

        Now that we have DiffBlock containers, the only things that are
        focusable are previousComment nodes and DiffBlock containers
        that contain add/remove lines.

        Also, this means we show the focus border around the entire diff
        instead of just the first line.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 14 Jan 2011 00:14:46 +0000 (00:14 +0000)]
2011-01-13  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Flip input[type=range] to use the new shadow DOM model.
        https://bugs.webkit.org/show_bug.cgi?id=52317

        This is a straight-up flip, minimal change to the logic, which will be
        refactored in a follow-up patch.

        Covered by existing tests.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::initForStyleResolve): Changed to use either
            host or parent node to find parent.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::updateType): Added logic for destroying/creating
            shadow DOM subtree.
        * html/InputType.cpp:
        (WebCore::InputType::createShadowSubtree): Added empty decl.
        (WebCore::InputType::destroyShadowSubtree): Added a method to destroy
            shadow subtree.
        * html/InputType.h: Added defs.
        * html/RangeInputType.cpp:
        (WebCore::RangeInputType::createShadowSubtree): Added a virtual method to create
            slider thumb.
        * html/RangeInputType.h: Adde def.
        * html/shadow/SliderThumbElement.cpp: Added temporary RenderSliderThumb class
            to handle cascading appearance.
        (WebCore::RenderSliderThumb::RenderSliderThumb): Added.
        (WebCore::RenderSliderThumb::layout): Moved here the logic from
            RenderSlider::createThumbStyle.
        (WebCore::SliderThumbElement::createRenderer): Added virtual method to
            create RenderSliderThumb instance.
        (WebCore::SliderThumbElement::defaultEventHandler): Changed to use HTMLDivElement
            as base class.
        (WebCore::SliderThumbElement::detach): Ditto.
        * html/shadow/SliderThumbElement.h:
        (WebCore::SliderThumbElement::SliderThumbElement): Ditto.
        (WebCore::SliderThumbElement::create): Ditto.
        (WebCore::toSliderThumbElement): Added a casting helper.
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlInputElement::attach): Added handling of shadow DOM,
            since the whole method is hand-rolled.
        (WebCore::MediaControlInputElement::updateStyle): Ditto.
        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::~RenderSlider): Removed unneeded code.
        (WebCore::RenderSlider::thumbRect): Changed to use sliderThumbElement helper.
        (WebCore::RenderSlider::layout): Ditto.
        (WebCore::RenderSlider::sliderThumbElement): Added a temporary helper to access
            SliderThumbElement.
        (WebCore::RenderSlider::mouseEventIsInThumb): Changed to use sliderThumbElement helper.
        (WebCore::RenderSlider::mouseEventOffsetToThumb): Ditto.
        (WebCore::RenderSlider::setValueForPosition): Ditto.
        (WebCore::RenderSlider::positionForOffset): Ditto.
        (WebCore::RenderSlider::currentPosition): Ditto.
        (WebCore::RenderSlider::trackSize): Ditto.
        (WebCore::RenderSlider::forwardEvent): Ditto.
        (WebCore::RenderSlider::inDragMode): Ditto.
        * rendering/RenderSlider.h: Added def.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 13 Jan 2011 23:55:26 +0000 (23:55 +0000)]
2011-01-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Rename RGBA32Buffer to ImageFrame
        https://bugs.webkit.org/show_bug.cgi?id=52363

        Update references to the new name.

        * src/WebImageDecoder.cpp:
        (WebKit::WebImageDecoder::isFrameCompleteAtIndex):
        (WebKit::WebImageDecoder::getFrameAtIndex):
2011-01-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Rename RGBA32Buffer to ImageFrame
        https://bugs.webkit.org/show_bug.cgi?id=52363

        RGBA32Buffer is a terrible misnomer.  ImageFrame is vastly
        more accurate.  More cleanup to come.

        * WebCore.pro:
        * platform/graphics/ImageSource.cpp:
        (WebCore::ImageSource::createFrameAtIndex):
        (WebCore::ImageSource::frameDurationAtIndex):
        (WebCore::ImageSource::frameIsCompleteAtIndex):
        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::frameBufferAtIndex):
        (WebCore::ImageDecoderQt::internalReadImage):
        (WebCore::ImageDecoderQt::internalHandleCurrentImage):
        * platform/graphics/qt/ImageDecoderQt.h:
        * platform/graphics/wince/ImageWinCE.cpp:
        (WebCore::ImageFrame::asNewNativeImage):
        * platform/image-decoders/ImageDecoder.cpp:
        (WebCore::ImageFrame::ImageFrame):
        (WebCore::ImageFrame::operator=):
        (WebCore::ImageFrame::clear):
        (WebCore::ImageFrame::zeroFill):
        (WebCore::ImageFrame::copyReferenceToBitmapData):
        (WebCore::ImageFrame::copyBitmapData):
        (WebCore::ImageFrame::setSize):
        (WebCore::ImageFrame::hasAlpha):
        (WebCore::ImageFrame::setHasAlpha):
        (WebCore::ImageFrame::setColorProfile):
        (WebCore::ImageFrame::setStatus):
        (WebCore::ImageFrame::width):
        (WebCore::ImageFrame::height):
        * platform/image-decoders/ImageDecoder.h:
        (WebCore::ImageFrame::ImageFrame):
        * platform/image-decoders/bmp/BMPImageDecoder.cpp:
        (WebCore::BMPImageDecoder::frameBufferAtIndex):
        (WebCore::BMPImageDecoder::decode):
        * platform/image-decoders/bmp/BMPImageDecoder.h:
        * platform/image-decoders/bmp/BMPImageReader.cpp:
        (WebCore::BMPImageReader::decodeBMP):
        * platform/image-decoders/bmp/BMPImageReader.h:
        (WebCore::BMPImageReader::setBuffer):
        * platform/image-decoders/cairo/ImageDecoderCairo.cpp:
        (WebCore::ImageFrame::asNewNativeImage):
        * platform/image-decoders/cg/ImageDecoderCG.cpp:
        (WebCore::getPtrAsPixelData):
        (WebCore::ImageFrame::copyReferenceToBitmapData):
        (WebCore::ImageFrame::copyBitmapData):
        (WebCore::ImageFrame::setSize):
        (WebCore::ImageFrame::asNewNativeImage):
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::frameBufferAtIndex):
        (WebCore::GIFImageDecoder::clearFrameBufferCache):
        (WebCore::GIFImageDecoder::haveDecodedRow):
        (WebCore::GIFImageDecoder::frameComplete):
        (WebCore::GIFImageDecoder::initFrameBuffer):
        * platform/image-decoders/gif/GIFImageDecoder.h:
        * platform/image-decoders/gif/GIFImageReader.cpp:
        (GIFImageReader::read):
        * platform/image-decoders/gif/GIFImageReader.h:
        (GIFFrameReader::GIFFrameReader):
        * platform/image-decoders/haiku/ImageDecoderHaiku.cpp:
        (WebCore::ImageFrame::asNewNativeImage):
        * platform/image-decoders/ico/ICOImageDecoder.cpp:
        (WebCore::ICOImageDecoder::frameBufferAtIndex):
        (WebCore::ICOImageDecoder::decode):
        * platform/image-decoders/ico/ICOImageDecoder.h:
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageDecoder::frameBufferAtIndex):
        (WebCore::JPEGImageDecoder::outputScanlines):
        (WebCore::JPEGImageDecoder::jpegComplete):
        (WebCore::JPEGImageDecoder::decode):
        * platform/image-decoders/jpeg/JPEGImageDecoder.h:
        * platform/image-decoders/openvg/ImageDecoderOpenVG.cpp:
        (WebCore::ImageFrame::asNewNativeImage):
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::frameBufferAtIndex):
        (WebCore::PNGImageDecoder::rowAvailable):
        (WebCore::PNGImageDecoder::pngComplete):
        * platform/image-decoders/png/PNGImageDecoder.h:
        (WebCore::PNGImageDecoder::isComplete):
        * platform/image-decoders/qt/ImageFrameQt.cpp: Copied from Source/WebCore/platform/image-decoders/qt/RGBA32BufferQt.cpp.
        (WebCore::ImageFrame::ImageFrame):
        (WebCore::ImageFrame::operator=):
        (WebCore::ImageFrame::clear):
        (WebCore::ImageFrame::zeroFill):
        (WebCore::ImageFrame::copyBitmapData):
        (WebCore::ImageFrame::setSize):
        (WebCore::ImageFrame::asNewNativeImage):
        (WebCore::ImageFrame::hasAlpha):
        (WebCore::ImageFrame::setHasAlpha):
        (WebCore::ImageFrame::setColorProfile):
        (WebCore::ImageFrame::setStatus):
        (WebCore::ImageFrame::setPixmap):
        (WebCore::ImageFrame::width):
        (WebCore::ImageFrame::height):
        * platform/image-decoders/qt/RGBA32BufferQt.cpp: Removed.
        * platform/image-decoders/skia/ImageDecoderSkia.cpp:
        (WebCore::ImageFrame::ImageFrame):
        (WebCore::ImageFrame::operator=):
        (WebCore::ImageFrame::clear):
        (WebCore::ImageFrame::zeroFill):
        (WebCore::ImageFrame::copyBitmapData):
        (WebCore::ImageFrame::setSize):
        (WebCore::ImageFrame::asNewNativeImage):
        (WebCore::ImageFrame::hasAlpha):
        (WebCore::ImageFrame::setHasAlpha):
        (WebCore::ImageFrame::setColorProfile):
        (WebCore::ImageFrame::setStatus):
        (WebCore::ImageFrame::width):
        (WebCore::ImageFrame::height):
        * platform/image-decoders/webp/WEBPImageDecoder.cpp:
        (WebCore::WEBPImageDecoder::frameBufferAtIndex):
        (WebCore::WEBPImageDecoder::decode):
        * platform/image-decoders/webp/WEBPImageDecoder.h:
        * platform/image-decoders/wx/ImageDecoderWx.cpp:
        (WebCore::ImageFrame::asNewNativeImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 13 Jan 2011 23:52:42 +0000 (23:52 +0000)]
2011-01-13  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        add container divs for diff blocks
        https://bugs.webkit.org/show_bug.cgi?id=52400

        This will help simplify a lot of code in code-review.js
        and make side-by-side diffs better (i.e. put removed lines
        to the left of corresponding added lines).

        Also, allow for running the JS from a local file. Now you can modify code-review.js
        to point to a local file and then run:
        ruby prettify.rb < foo.diff > foo.html

        foo.html will load a dummy code review matching foo.diff.

        Before structure:
        Line
        Line remove
        Line add
        Line add
        Line

        After structure:
        DiffBlock
          DiffBlockPart shared
            Line shared
        DiffBlock
          DiffBlockPart remove
            Line remove
          DiffBlockPart add
            Line add
            Line add
        DiffBlock
          DiffBlockPart shared
            Line shared

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 13 Jan 2011 23:38:32 +0000 (23:38 +0000)]
2011-01-13  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Transferring nodes between documents should be aware of the shadow DOM.
        https://bugs.webkit.org/show_bug.cgi?id=52399

        No visible change in behavior at the moment.

        Once https://bugs.webkit.org/show_bug.cgi?id=52317 lands, the following
        tests should no longer crash:
        * fast/css/pseudo-in-range-invalid-value.html
        * fast/css/pseudo-in-range.html
        * fast/forms/form-collection-elements.html
        * fast/forms/range-keyoperation.html

        * dom/Document.cpp:
        (WebCore::Document::adoptNode): Changed to use Node::setDocumentRecursively.
        * dom/Node.cpp:
        (WebCore::Node::setDocumentRecursively): Added new method, taking existing
            logic and adding shadow DOM traversal.
        (WebCore::Node::traverseNextNode): Style fix.
        (WebCore::Node::traverseNextSibling): Ditto.
        (WebCore::Node::traversePreviousNode): Ditto.
        (WebCore::Node::traversePreviousNodePostOrder): Ditto.
        (WebCore::Node::checkReplaceChild): Changed to use setDocumentRecursively.
        (WebCore::Node::checkAddChild): Ditto.
        * dom/Node.h: Added def.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 13 Jan 2011 23:28:58 +0000 (23:28 +0000)]
2011-01-13  Justin Schuh  <jschuh@chromium.org>

        Unreviewed chromium expectations update.

        Remove exception for canvas-large-dimensions.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: WebKit2: Add support for drag and drop
enrica@apple.com [Thu, 13 Jan 2011 23:14:41 +0000 (23:14 +0000)]
Source/WebCore: WebKit2: Add support for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=52343
<rdar://problem/7660558>

Reviewed by Darin Adler.

This patch contains the changes required to support dropping content
in WebKit on the Mac. The DragData class has been extended to provide
additional context from the application (keyboard state, modal windows, etc.)
as well as information of the drag pasteboard being used.
The support for WebKit as drag source will be added with a separate patch.

* WebCore.exp.in:
* page/DragController.cpp:
(WebCore::DragController::dragIsMove): Added DragData parameter.
(WebCore::DragController::tryDocumentDrag): Modified call to dragIsMove.
(WebCore::DragController::concludeEditDrag): Same as above.
* page/DragController.h: Added parameter to isCopyKeyDown.
* page/mac/DragControllerMac.mm:
The following methods have been modified to use the information stored
in the DragData class.
(WebCore::DragController::isCopyKeyDown):
(WebCore::DragController::dragOperation):
* platform/DragData.h:
(WebCore::DragData::flags):
* platform/DragData.cpp: Added default flags parameter to the constructor.
* platform/mac/DragDataMac.mm:
(WebCore::DragData::DragData): Added constructor that receives the name of the pasteboard to use.
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::containsColor):
(WebCore::DragData::containsFiles):
(WebCore::DragData::asFilenames):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
All the following files have been modified to add the DragData
parameter to isCopyKeyDown. I plan to improve this in the future
and make isCopyKeyDown not platform specific.
* page/android/DragControllerAndroid.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/brew/DragControllerBrew.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/chromium/DragControllerChromium.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/efl/DragControllerEfl.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/gtk/DragControllerGtk.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/haiku/DragControllerHaiku.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/mac/DragControllerMac.mm:
(WebCore::DragController::isCopyKeyDown):
(WebCore::DragController::dragOperation):
* page/qt/DragControllerQt.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/win/DragControllerWin.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/wx/DragControllerWx.cpp:
(WebCore::DragController::isCopyKeyDown):

WebKit/mac: WebKit2: Add support for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=52343
<rdar://problem/7660558>

Reviewed by Darin Adler.

The DragData class has been extended to provide
additional context from the application (keyboard state, modal windows, etc.)
as well as information of the drag pasteboard being used.
These are the changes to align the behavior for WebKit.

* WebView/WebView.mm:
(-[WebView applicationFlags:]): Added.
(-[WebView draggingEntered:]): Added parameter to the DragData constructor.
(-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
(-[WebView draggingExited:]): Added parameter to the DragData constructor.
(-[WebView performDragOperation:]): Added parameter to the DragData constructor.

WebKit2: WebKit2: Add support for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=52343
<rdar://problem/7660558>

Reviewed by Darin Adler.

This patch contains the changes required to support dropping content
in WebKit on the Mac. The DragData class has been extended to provide
additional context from the application (keyboard state, modal windows, etc.)
as well as information of the drag pasteboard being used.
The support for WebKit as drag source will be added with a separate patch.

* Shared/DragControllerAction.h: Added.
* UIProcess/API/mac/WKView.mm:
Added implemention of the methods required to add suport for a drop target.
To maintain asynchronous communication with the WebProcess, we always return
the previous calculated value for the drag operation.
(-[WKView _registerDraggedTypes]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView applicationFlags:]):
(-[WKView draggingEntered:]):
(-[WKView draggingUpdated:]):
(-[WKView draggingExited:]):
(-[WKView prepareForDragOperation:]):
(-[WKView performDragOperation:]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::performDragControllerAction):
(WebKit::WebPageProxy::didPerformDragControllerAction):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::dragOperation):
(WebKit::WebPageProxy::resetDragOperation):
* UIProcess/WebPageProxy.messages.in:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebDragClient.cpp:
(WebKit::WebDragClient::willPerformDragDestinationAction):
(WebKit::WebDragClient::willPerformDragSourceAction):
(WebKit::WebDragClient::actionMaskForDrag):
(WebKit::WebDragClient::dragSourceActionMaskForPoint):
(WebKit::WebDragClient::startDrag):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd missing MathMLElementFactory.h and MathMLNames.h to Xcode project
ddkilzer@apple.com [Thu, 13 Jan 2011 23:11:38 +0000 (23:11 +0000)]
Add missing MathMLElementFactory.h and MathMLNames.h to Xcode project

Not reviewed.

* WebCore.xcodeproj/project.pbxproj: Add missing headers.  Note
that the corresponding source files were originally added to the
project in r48559.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 13 Jan 2011 23:05:32 +0000 (23:05 +0000)]
2011-01-12  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Use GC3D types in WebGLRenderingContext and related WebGL classes
        https://bugs.webkit.org/show_bug.cgi?id=51908

        * html/canvas/WebGLActiveInfo.h:
        (WebCore::WebGLActiveInfo::create):
        (WebCore::WebGLActiveInfo::type):
        (WebCore::WebGLActiveInfo::size):
        (WebCore::WebGLActiveInfo::WebGLActiveInfo):
        * html/canvas/WebGLBuffer.cpp:
        (WebCore::WebGLBuffer::associateBufferDataImpl):
        (WebCore::WebGLBuffer::associateBufferData):
        (WebCore::WebGLBuffer::associateBufferSubDataImpl):
        (WebCore::WebGLBuffer::associateBufferSubData):
        (WebCore::WebGLBuffer::byteLength):
        (WebCore::WebGLBuffer::getCachedMaxIndex):
        (WebCore::WebGLBuffer::setCachedMaxIndex):
        (WebCore::WebGLBuffer::setTarget):
        * html/canvas/WebGLBuffer.h:
        (WebCore::WebGLBuffer::getTarget):
        * html/canvas/WebGLFramebuffer.cpp:
        (WebCore::WebGLFramebuffer::setAttachment):
        (WebCore::WebGLFramebuffer::getAttachment):
        (WebCore::WebGLFramebuffer::getWidth):
        (WebCore::WebGLFramebuffer::getHeight):
        (WebCore::WebGLFramebuffer::getColorBufferFormat):
        (WebCore::WebGLFramebuffer::initializeRenderbuffers):
        * html/canvas/WebGLFramebuffer.h:
        * html/canvas/WebGLProgram.cpp:
        (WebCore::WebGLProgram::cacheActiveAttribLocations):
        (WebCore::WebGLProgram::numActiveAttribLocations):
        (WebCore::WebGLProgram::getActiveAttribLocation):
        (WebCore::WebGLProgram::isUsingVertexAttrib0):
        * html/canvas/WebGLProgram.h:
        (WebCore::WebGLProgram::getLinkCount):
        * html/canvas/WebGLRenderbuffer.h:
        (WebCore::WebGLRenderbuffer::setInternalFormat):
        (WebCore::WebGLRenderbuffer::getInternalFormat):
        (WebCore::WebGLRenderbuffer::setSize):
        (WebCore::WebGLRenderbuffer::getWidth):
        (WebCore::WebGLRenderbuffer::getHeight):
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::initializeNewContext):
        (WebCore::WebGLRenderingContext::sizeInBytes):
        (WebCore::WebGLRenderingContext::activeTexture):
        (WebCore::WebGLRenderingContext::bindAttribLocation):
        (WebCore::WebGLRenderingContext::bindBuffer):
        (WebCore::WebGLRenderingContext::bindFramebuffer):
        (WebCore::WebGLRenderingContext::bindRenderbuffer):
        (WebCore::WebGLRenderingContext::bindTexture):
        (WebCore::WebGLRenderingContext::blendColor):
        (WebCore::WebGLRenderingContext::blendEquation):
        (WebCore::WebGLRenderingContext::blendEquationSeparate):
        (WebCore::WebGLRenderingContext::blendFunc):
        (WebCore::WebGLRenderingContext::blendFuncSeparate):
        (WebCore::WebGLRenderingContext::bufferData):
        (WebCore::WebGLRenderingContext::bufferSubData):
        (WebCore::WebGLRenderingContext::checkFramebufferStatus):
        (WebCore::WebGLRenderingContext::clear):
        (WebCore::WebGLRenderingContext::clearColor):
        (WebCore::WebGLRenderingContext::clearDepth):
        (WebCore::WebGLRenderingContext::clearStencil):
        (WebCore::WebGLRenderingContext::colorMask):
        (WebCore::WebGLRenderingContext::copyTexImage2D):
        (WebCore::WebGLRenderingContext::copyTexSubImage2D):
        (WebCore::WebGLRenderingContext::createShader):
        (WebCore::WebGLRenderingContext::cullFace):
        (WebCore::WebGLRenderingContext::deleteBuffer):
        (WebCore::WebGLRenderingContext::depthFunc):
        (WebCore::WebGLRenderingContext::depthMask):
        (WebCore::WebGLRenderingContext::depthRange):
        (WebCore::WebGLRenderingContext::disable):
        (WebCore::WebGLRenderingContext::disableVertexAttribArray):
        (WebCore::WebGLRenderingContext::validateElementArraySize):
        (WebCore::WebGLRenderingContext::validateIndexArrayConservative):
        (WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
        (WebCore::WebGLRenderingContext::validateRenderingState):
        (WebCore::WebGLRenderingContext::drawArrays):
        (WebCore::WebGLRenderingContext::drawElements):
        (WebCore::WebGLRenderingContext::enable):
        (WebCore::WebGLRenderingContext::enableVertexAttribArray):
        (WebCore::WebGLRenderingContext::framebufferRenderbuffer):
        (WebCore::WebGLRenderingContext::framebufferTexture2D):
        (WebCore::WebGLRenderingContext::frontFace):
        (WebCore::WebGLRenderingContext::generateMipmap):
        (WebCore::WebGLRenderingContext::getActiveAttrib):
        (WebCore::WebGLRenderingContext::getActiveUniform):
        (WebCore::WebGLRenderingContext::getAttachedShaders):
        (WebCore::WebGLRenderingContext::getAttribLocation):
        (WebCore::WebGLRenderingContext::getBufferParameter):
        (WebCore::WebGLRenderingContext::getError):
        (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
        (WebCore::WebGLRenderingContext::getParameter):
        (WebCore::WebGLRenderingContext::getProgramParameter):
        (WebCore::WebGLRenderingContext::getRenderbufferParameter):
        (WebCore::WebGLRenderingContext::getShaderParameter):
        (WebCore::WebGLRenderingContext::getTexParameter):
        (WebCore::WebGLRenderingContext::getUniform):
        (WebCore::WebGLRenderingContext::getUniformLocation):
        (WebCore::WebGLRenderingContext::getVertexAttrib):
        (WebCore::WebGLRenderingContext::getVertexAttribOffset):
        (WebCore::WebGLRenderingContext::hint):
        (WebCore::WebGLRenderingContext::isBuffer):
        (WebCore::WebGLRenderingContext::isEnabled):
        (WebCore::WebGLRenderingContext::isFramebuffer):
        (WebCore::WebGLRenderingContext::isProgram):
        (WebCore::WebGLRenderingContext::isRenderbuffer):
        (WebCore::WebGLRenderingContext::isShader):
        (WebCore::WebGLRenderingContext::isTexture):
        (WebCore::WebGLRenderingContext::lineWidth):
        (WebCore::WebGLRenderingContext::linkProgram):
        (WebCore::WebGLRenderingContext::pixelStorei):
        (WebCore::WebGLRenderingContext::polygonOffset):
        (WebCore::WebGLRenderingContext::readPixels):
        (WebCore::WebGLRenderingContext::renderbufferStorage):
        (WebCore::WebGLRenderingContext::sampleCoverage):
        (WebCore::WebGLRenderingContext::scissor):
        (WebCore::WebGLRenderingContext::stencilFunc):
        (WebCore::WebGLRenderingContext::stencilFuncSeparate):
        (WebCore::WebGLRenderingContext::stencilMask):
        (WebCore::WebGLRenderingContext::stencilMaskSeparate):
        (WebCore::WebGLRenderingContext::stencilOp):
        (WebCore::WebGLRenderingContext::stencilOpSeparate):
        (WebCore::WebGLRenderingContext::texImage2DBase):
        (WebCore::WebGLRenderingContext::texImage2DImpl):
        (WebCore::WebGLRenderingContext::texImage2D):
        (WebCore::WebGLRenderingContext::texParameter):
        (WebCore::WebGLRenderingContext::texParameterf):
        (WebCore::WebGLRenderingContext::texParameteri):
        (WebCore::WebGLRenderingContext::texSubImage2DBase):
        (WebCore::WebGLRenderingContext::texSubImage2DImpl):
        (WebCore::WebGLRenderingContext::texSubImage2D):
        (WebCore::WebGLRenderingContext::uniform1f):
        (WebCore::WebGLRenderingContext::uniform1fv):
        (WebCore::WebGLRenderingContext::uniform1i):
        (WebCore::WebGLRenderingContext::uniform1iv):
        (WebCore::WebGLRenderingContext::uniform2f):
        (WebCore::WebGLRenderingContext::uniform2fv):
        (WebCore::WebGLRenderingContext::uniform2i):
        (WebCore::WebGLRenderingContext::uniform2iv):
        (WebCore::WebGLRenderingContext::uniform3f):
        (WebCore::WebGLRenderingContext::uniform3fv):
        (WebCore::WebGLRenderingContext::uniform3i):
        (WebCore::WebGLRenderingContext::uniform3iv):
        (WebCore::WebGLRenderingContext::uniform4f):
        (WebCore::WebGLRenderingContext::uniform4fv):
        (WebCore::WebGLRenderingContext::uniform4i):
        (WebCore::WebGLRenderingContext::uniform4iv):
        (WebCore::WebGLRenderingContext::uniformMatrix2fv):
        (WebCore::WebGLRenderingContext::uniformMatrix3fv):
        (WebCore::WebGLRenderingContext::uniformMatrix4fv):
        (WebCore::WebGLRenderingContext::vertexAttrib1f):
        (WebCore::WebGLRenderingContext::vertexAttrib1fv):
        (WebCore::WebGLRenderingContext::vertexAttrib2f):
        (WebCore::WebGLRenderingContext::vertexAttrib2fv):
        (WebCore::WebGLRenderingContext::vertexAttrib3f):
        (WebCore::WebGLRenderingContext::vertexAttrib3fv):
        (WebCore::WebGLRenderingContext::vertexAttrib4f):
        (WebCore::WebGLRenderingContext::vertexAttrib4fv):
        (WebCore::WebGLRenderingContext::vertexAttribPointer):
        (WebCore::WebGLRenderingContext::viewport):
        (WebCore::WebGLRenderingContext::getBooleanParameter):
        (WebCore::WebGLRenderingContext::getBooleanArrayParameter):
        (WebCore::WebGLRenderingContext::getFloatParameter):
        (WebCore::WebGLRenderingContext::getIntParameter):
        (WebCore::WebGLRenderingContext::getLongParameter):
        (WebCore::WebGLRenderingContext::getUnsignedLongParameter):
        (WebCore::WebGLRenderingContext::getWebGLFloatArrayParameter):
        (WebCore::WebGLRenderingContext::getWebGLIntArrayParameter):
        (WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid):
        (WebCore::WebGLRenderingContext::getBoundFramebufferColorFormat):
        (WebCore::WebGLRenderingContext::validateTextureBinding):
        (WebCore::WebGLRenderingContext::validateSize):
        (WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
        (WebCore::WebGLRenderingContext::validateTexFuncLevel):
        (WebCore::WebGLRenderingContext::validateTexFuncParameters):
        (WebCore::WebGLRenderingContext::validateTexFuncData):
        (WebCore::WebGLRenderingContext::validateDrawMode):
        (WebCore::WebGLRenderingContext::validateStencilFunc):
        (WebCore::WebGLRenderingContext::validateFramebufferFuncParameters):
        (WebCore::WebGLRenderingContext::validateBlendEquation):
        (WebCore::WebGLRenderingContext::validateBlendFuncFactors):
        (WebCore::WebGLRenderingContext::validateCapability):
        (WebCore::WebGLRenderingContext::validateUniformParameters):
        (WebCore::WebGLRenderingContext::validateUniformMatrixParameters):
        (WebCore::WebGLRenderingContext::validateBufferDataParameters):
        (WebCore::WebGLRenderingContext::vertexAttribfImpl):
        (WebCore::WebGLRenderingContext::vertexAttribfvImpl):
        (WebCore::WebGLRenderingContext::simulateVertexAttrib0):
        * html/canvas/WebGLRenderingContext.h:
        (WebCore::WebGLRenderingContext::VertexAttribState::VertexAttribState):
        * html/canvas/WebGLShader.cpp:
        (WebCore::WebGLShader::create):
        (WebCore::WebGLShader::WebGLShader):
        * html/canvas/WebGLShader.h:
        (WebCore::WebGLShader::getType):
        * html/canvas/WebGLTexture.cpp:
        (WebCore::WebGLTexture::setTarget):
        (WebCore::WebGLTexture::setParameteri):
        (WebCore::WebGLTexture::setParameterf):
        (WebCore::WebGLTexture::setLevelInfo):
        (WebCore::WebGLTexture::generateMipmapLevelInfo):
        (WebCore::WebGLTexture::getInternalFormat):
        (WebCore::WebGLTexture::getType):
        (WebCore::WebGLTexture::getWidth):
        (WebCore::WebGLTexture::getHeight):
        (WebCore::WebGLTexture::isNPOT):
        (WebCore::WebGLTexture::mapTargetToIndex):
        (WebCore::WebGLTexture::computeLevelCount):
        (WebCore::WebGLTexture::update):
        (WebCore::WebGLTexture::getLevelInfo):
        * html/canvas/WebGLTexture.h:
        (WebCore::WebGLTexture::LevelInfo::setInfo):
        * html/canvas/WebGLUniformLocation.cpp:
        (WebCore::WebGLUniformLocation::create):
        (WebCore::WebGLUniformLocation::WebGLUniformLocation):
        (WebCore::WebGLUniformLocation::location):
        * html/canvas/WebGLUniformLocation.h:
        * platform/graphics/GraphicsContext3D.h: Map GC3Dboolean to bool instead of unsigned char.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 13 Jan 2011 23:00:04 +0000 (23:00 +0000)]
2011-01-13  Martin Robinson  <mrobinson@igalia.com>

        Unskip editing/input/page-up-down-scrolls.html as it's passing locally.

        * platform/gtk/Skipped: Unskip test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange createObjectURL and revokeObjectURL to put under webkitURL.
jianli@chromium.org [Thu, 13 Jan 2011 22:55:05 +0000 (22:55 +0000)]
Change createObjectURL and revokeObjectURL to put under webkitURL.
https://bugs.webkit.org/show_bug.cgi?id=52257

Reviewed by Darin Fisher.

Source/WebCore:

Note that we add "webkit" vendor prefix to URL that is introduced in
the latest File API spec.

For the time being, we implement webkitURL as a readonly attribute
instead of a constructor so that we will not expose prototype property,
as required by the spec.

* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* Android.mk:
* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/DOMURL.cpp: Added.
* html/DOMURL.h: Added.
* html/DOMURL.idl: Added.
* inspector/front-end/NetworkPanel.js:
* inspector/front-end/utilities.js:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::webkitURL):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::webkitURL):
* workers/WorkerContext.h:
* workers/WorkerContext.idl:

LayoutTests:

Change all related test scripts and results to account for this change.

* fast/dom/Window/script-tests/window-property-descriptors.js:
* fast/dom/Window/window-properties-expected.txt:
* fast/dom/Window/window-properties.html:
* fast/dom/script-tests/prototype-inheritance-2.js:
* fast/dom/script-tests/prototype-inheritance.js:
* fast/files/apply-blob-url-to-img.html:
* fast/files/apply-blob-url-to-xhr.html:
* fast/files/create-blob-url-crash.html:
* fast/files/revoke-blob-url.html:
* fast/files/workers/resources/worker-apply-blob-url-to-xhr.js:
(onmessage):
* platform/qt/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Emil Eklund <eae@chromium.org>
commit-queue@webkit.org [Thu, 13 Jan 2011 22:49:44 +0000 (22:49 +0000)]
2011-01-13  Emil Eklund  <eae@chromium.org>

        Reviewed by Dimitri Glazkov.

        Setting outerText should convert CR/LF to <br>
        https://bugs.webkit.org/show_bug.cgi?id=52268

        Add test for setting Element.outerText.

        * fast/dom/set-outer-text-expected.txt: Added.
        * fast/dom/set-outer-text.html: Added.
        * fast/dom/text-node-append-data-remove-crash-expected.txt: Changed
            expectation to "didn't crash" from "threw dom exception" as test
            assumed the DOMCharacterDataModified event would fire before the node
            would be replaced.
        * fast/dom/text-node-append-data-remove-crash.html:
2011-01-13  Emil Eklund  <eae@chromium.org>

        Reviewed by Dimitri Glazkov.

        Setting outerText should convert CR/LF to <br>
        https://bugs.webkit.org/show_bug.cgi?id=52268

        Make set outerText support line breaks (sharing the text to fragment code
        with setInnerText) and handle empty text nodes the same way IE does.

        Test: fast/dom/set-outer-text.html

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::textToFragment): Shared between setInnerText and setOuterText
        (WebCore::HTMLElement::setInnerText): Split out text parsing code.
        (WebCore::mergeWithNextTextNode): Split out text node merging code.
        (WebCore::HTMLElement::setOuterText): Added support for line breaks.
        * html/HTMLElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip a crashing test on Windows
aroben@apple.com [Thu, 13 Jan 2011 22:39:04 +0000 (22:39 +0000)]
Skip a crashing test on Windows

See <http://webkit.org/b/52397>.

* platform/win/Skipped: Added
compositing/reflections/load-video-in-reflection.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 13 Jan 2011 22:35:48 +0000 (22:35 +0000)]
2011-01-13  Martin Robinson  <mrobinson@igalia.com>

        Skip fast/text/emphasis.html as it shows a 1 pixel difference on the 32-bit Debug bot.

        * platform/gtk/Skipped: Skip fast/text/emphasis.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 13 Jan 2011 22:34:43 +0000 (22:34 +0000)]
2011-01-13  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Relax the ESSL valid charset a little bit to include " ' `
        https://bugs.webkit.org/show_bug.cgi?id=52396

        * html/canvas/WebGLRenderingContext.cpp:
2011-01-13  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Relax the ESSL valid charset a little bit to include " ' `
        https://bugs.webkit.org/show_bug.cgi?id=52396

        * fast/canvas/webgl/invalid-passed-params-expected.txt:
        * fast/canvas/webgl/invalid-passed-params.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Thu, 13 Jan 2011 21:52:37 +0000 (21:52 +0000)]
2011-01-13  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Tony Chang.

        [chromium]: Only swallow ctrl+c for windowless plugins if we know the plugin has a selection
        https://bugs.webkit.org/show_bug.cgi?id=52393

        * src/WebPluginContainerImpl.cpp:
        (WebKit::WebPluginContainerImpl::copy):
        (WebKit::WebPluginContainerImpl::handleKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 13 Jan 2011 20:51:45 +0000 (20:51 +0000)]
2011-01-13  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Russell.

        [chromium] Attempt to fix crash in tiled compositor memcpy
        https://bugs.webkit.org/show_bug.cgi?id=52379

        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Thu, 13 Jan 2011 20:36:06 +0000 (20:36 +0000)]
2011-01-13  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by nobody - reinstrumenting a test to save burning trees.

        fast/canvas/canvas-large-dimensions.html (introduced in r75648) is failing on all platforms except Snow Leopard
        https://bugs.webkit.org/show_bug.cgi?id=52341

        * fast/canvas/canvas-large-dimensions-expected.txt: Replaced.
        * fast/canvas/canvas-large-dimensions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 13 Jan 2011 20:11:50 +0000 (20:11 +0000)]
2011-01-13  Justin Schuh  <jschuh@chromium.org>

        Unreviewed chromium expectations update.

        Exclude destroy-on-setwindow.html (added in r75720).

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Thu, 13 Jan 2011 20:07:25 +0000 (20:07 +0000)]
2011-01-11  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Add support to allow printing just a plugin in a frame
        https://bugs.webkit.org/show_bug.cgi?id=52134

        * public/WebContextMenuData.h:
        * public/WebFrame.h:
        * src/ContextMenuClientImpl.cpp:
        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
        * src/WebFrameImpl.cpp:
        (WebKit::ChromePluginPrintContext::ChromePluginPrintContext):
        (WebKit::ChromePluginPrintContext::end):
        (WebKit::ChromePluginPrintContext::computePageRects):
        (WebKit::ChromePluginPrintContext::spoolPage):
        (WebKit::WebFrameImpl::printBegin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Thu, 13 Jan 2011 19:48:10 +0000 (19:48 +0000)]
2011-01-13  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [gtk] Zero-sized font does not yet work
        https://bugs.webkit.org/show_bug.cgi?id=49793

        Unskip font-size-zero.html.

        * platform/gtk/Skipped:

2011-01-13  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [gtk] Zero-sized font does not yet work
        https://bugs.webkit.org/show_bug.cgi?id=49793

        Set minimum-font-size to 0 for the DRT.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

2011-01-13  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [gtk] Zero-sized font does not yet work
        https://bugs.webkit.org/show_bug.cgi?id=49793

        Allow 0 as a minimum-font-size value for the settings.

        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r75725.
dglazkov@chromium.org [Thu, 13 Jan 2011 19:38:11 +0000 (19:38 +0000)]
Unreviewed, rolling out r75725.
http://trac.webkit.org/changeset/75725
https://bugs.webkit.org/show_bug.cgi?id=52317

Caused crashes in layout tests.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForStyleResolve):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
* html/InputType.cpp:
* html/InputType.h:
* html/RangeInputType.cpp:
* html/RangeInputType.h:
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::defaultEventHandler):
(WebCore::SliderThumbElement::detach):
* html/shadow/SliderThumbElement.h:
(WebCore::SliderThumbElement::SliderThumbElement):
(WebCore::SliderThumbElement::create):
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlInputElement::attach):
(WebCore::MediaControlInputElement::updateStyle):
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::~RenderSlider):
(WebCore::RenderSlider::styleDidChange):
(WebCore::RenderSlider::createThumbStyle):
(WebCore::RenderSlider::thumbRect):
(WebCore::RenderSlider::layout):
(WebCore::RenderSlider::updateFromElement):
(WebCore::RenderSlider::mouseEventIsInThumb):
(WebCore::RenderSlider::mouseEventOffsetToThumb):
(WebCore::RenderSlider::setValueForPosition):
(WebCore::RenderSlider::positionForOffset):
(WebCore::RenderSlider::currentPosition):
(WebCore::RenderSlider::trackSize):
(WebCore::RenderSlider::forwardEvent):
(WebCore::RenderSlider::inDragMode):
* rendering/RenderSlider.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 13 Jan 2011 18:56:14 +0000 (18:56 +0000)]
2011-01-13  Tony Chang  <tony@chromium.org>

        Unreviewed, updating chromium test_expectations.txt

        * platform/chromium/test_expectations.txt: Mark a test as slow in debug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Csaba Osztrogonác <ossy@webkit.org>
ossy@webkit.org [Thu, 13 Jan 2011 18:37:33 +0000 (18:37 +0000)]
2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by Darin Adler.

        Make old-run-webkit-tests more robust on buildbots
        https://bugs.webkit.org/show_bug.cgi?id=52364

        * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 13 Jan 2011 18:35:02 +0000 (18:35 +0000)]
2011-01-12  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Flip input[type=range] to use the new shadow DOM model.
        https://bugs.webkit.org/show_bug.cgi?id=52317

        This is a straight-up flip, minimal change to the logic, which will be
        refactored in a follow-up patch.

        Covered by existing tests.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::initForStyleResolve): Changed to use either
            host or parent node to find parent.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::updateType): Added logic for destroying/creating
            shadow DOM subtree.
        * html/InputType.cpp:
        (WebCore::InputType::createShadowSubtree): Added empty decl.
        (WebCore::InputType::destroyShadowSubtree): Added a method to destroy
            shadow subtree.
        * html/InputType.h: Added defs.
        * html/RangeInputType.cpp:
        (WebCore::RangeInputType::createShadowSubtree): Added a virtual method to create
            slider thumb.
        * html/RangeInputType.h: Adde def.
        * html/shadow/SliderThumbElement.cpp: Added temporary RenderSliderThumb class
            to handle cascading appearance.
        (WebCore::RenderSliderThumb::RenderSliderThumb): Added.
        (WebCore::RenderSliderThumb::layout): Moved here the logic from
            RenderSlider::createThumbStyle.
        (WebCore::SliderThumbElement::createRenderer): Added virtual method to
            create RenderSliderThumb instance.
        (WebCore::SliderThumbElement::defaultEventHandler): Changed to use HTMLDivElement
            as base class.
        (WebCore::SliderThumbElement::detach): Ditto.
        * html/shadow/SliderThumbElement.h:
        (WebCore::SliderThumbElement::SliderThumbElement): Ditto.
        (WebCore::SliderThumbElement::create): Ditto.
        (WebCore::toSliderThumbElement): Added a casting helper.
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlInputElement::attach): Added handling of shadow DOM,
            since the whole method is hand-rolled.
        (WebCore::MediaControlInputElement::updateStyle): Ditto.
        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::~RenderSlider): Removed unneeded code.
        (WebCore::RenderSlider::thumbRect): Changed to use sliderThumbElement helper.
        (WebCore::RenderSlider::layout): Ditto.
        (WebCore::RenderSlider::sliderThumbElement): Added a temporary helper to access
            SliderThumbElement.
        (WebCore::RenderSlider::mouseEventIsInThumb): Changed to use sliderThumbElement helper.
        (WebCore::RenderSlider::mouseEventOffsetToThumb): Ditto.
        (WebCore::RenderSlider::setValueForPosition): Ditto.
        (WebCore::RenderSlider::positionForOffset): Ditto.
        (WebCore::RenderSlider::currentPosition): Ditto.
        (WebCore::RenderSlider::trackSize): Ditto.
        (WebCore::RenderSlider::forwardEvent): Ditto.
        (WebCore::RenderSlider::inDragMode): Ditto.
        * rendering/RenderSlider.h: Added def.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCheck in Windows-XP-specific results for fast/canvas/set-colors.html
aroben@apple.com [Thu, 13 Jan 2011 18:34:25 +0000 (18:34 +0000)]
Check in Windows-XP-specific results for fast/canvas/set-colors.html

See <http://webkit.org/b/52374>.

* platform/win-xp/fast/canvas/set-colors-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDisable fast/profiler/throw-exception-from-eval.html
aroben@apple.com [Thu, 13 Jan 2011 18:33:54 +0000 (18:33 +0000)]
Disable fast/profiler/throw-exception-from-eval.html

This test fails non-deterministically. See <http://webkit.org/b/49801>.

* fast/profiler/throw-exception-from-eval.html-disabled: Renamed from LayoutTests/fast/profiler/throw-exception-from-eval.html.

* platform/gtk/Skipped:
* platform/mac-leopard/Skipped:
* platform/qt/Skipped:
Un-skipped this test now that it's been disabled by other means.

* platform/win-xp/fast/profiler/throw-exception-from-eval-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIncorrect assertion in DrawingAreaImpl::scroll()
mitz@apple.com [Thu, 13 Jan 2011 18:24:17 +0000 (18:24 +0000)]
Incorrect assertion in DrawingAreaImpl::scroll()
https://bugs.webkit.org/show_bug.cgi?id=52376

Reviewed by John Sullivan.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::scroll): Changed to take the fast path if the rects have the same area.
This made the assertion valid, but I removed it anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Csaba Osztrogonác <ossy@webkit.org>
ossy@webkit.org [Thu, 13 Jan 2011 18:22:58 +0000 (18:22 +0000)]
2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by Darin Adler.

        Make old-run-webkit-tests more robust on buildbots
        https://bugs.webkit.org/show_bug.cgi?id=52364

        * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8098442> Crash in Widget::setFrameRect()
mitz@apple.com [Thu, 13 Jan 2011 18:21:15 +0000 (18:21 +0000)]
<rdar://problem/8098442> Crash in Widget::setFrameRect()
https://bugs.webkit.org/show_bug.cgi?id=52375

Reviewed by Simon Fraser.

Source/WebCore:

Test: plugins/destroy-on-setwindow.html

* platform/mac/WidgetMac.mm:
(WebCore::Widget::setFrameRect): Protect the Widget from being deleted as a result of calling
out to the view.
(WebCore::Widget::getOuterView): Coding style fix.
(WebCore::Widget::paint): Protect the Widget from being deleted as a result of calling out to
the views. This is precautionary, since this function does not applear to access member variables
after such calls.
* platform/wx/WidgetWx.cpp:
(WebCore::Widget::setFrameRect): Protect the Widget from being deleted as a result of calling
out to the platform widget.

LayoutTests:

* plugins/destroy-on-setwindow-expected.txt: Added.
* plugins/destroy-on-setwindow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 13 Jan 2011 17:52:11 +0000 (17:52 +0000)]
2011-01-13  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
        https://bugs.webkit.org/show_bug.cgi?id=52332

        Fix Linux baseline. Mac should now match Safari Mac.

        * platform/chromium-linux/plugins/plugin-javascript-access-expected.txt:
        * platform/chromium/test_expectations.txt:
2011-01-13  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
        https://bugs.webkit.org/show_bug.cgi?id=52332

        Forked Info.plist is not longer needed.

        * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2011-01-13  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
        https://bugs.webkit.org/show_bug.cgi?id=52332

        * WebKit.gyp: Remove WebKitTestNetscapePlugIn

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed buildfix after r75715.
ossy@webkit.org [Thu, 13 Jan 2011 17:25:27 +0000 (17:25 +0000)]
Unreviewed buildfix after r75715.

* WebCore.pri:
* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 13 Jan 2011 17:23:32 +0000 (17:23 +0000)]
2011-01-13  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: inspector extensions tests should not use
        sources as test data. Commenting one out temporarily, filing a bug.

        * inspector/extensions-events-expected.txt:
        * inspector/extensions-events.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 13 Jan 2011 16:57:48 +0000 (16:57 +0000)]
2011-01-13  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: Qt build fix.

        * WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 13 Jan 2011 16:42:03 +0000 (16:42 +0000)]
2011-01-12  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: embed injected script into the backend.
        https://bugs.webkit.org/show_bug.cgi?id=52312

        InjectedScript belongs to the backend of the system and
        should be exposed by means of protocol, not InjectedScriptAccess.
        This patch makes injected script a part of the backend.
        It introduces single manual generation step (xxd -i) that should be
        automated by the build scripts for all the platforms.

        * CMakeLists.txt:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::injectedScriptFor):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::injectedScriptFor):
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::injectedScriptSource):
        * inspector/InjectedScriptHost.h:
        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::restoreInspectorStateFromCookie):
        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::InspectorState):
        * inspector/InspectorState.h:
        * inspector/front-end/InjectedScript.js: Removed.
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.doLoadedDone.propertyNamesCallback):
        (WebInspector.doLoadedDone):
        * inspector/xxd.pl: Added.

2011-01-12  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: embed injected script into the backend.
        https://bugs.webkit.org/show_bug.cgi?id=52312

        * WebKit.grd:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Thu, 13 Jan 2011 15:49:37 +0000 (15:49 +0000)]
2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Cleanup after r75613 -- make all UI-facing strings
        to be passed directly to WebInspector.UIString

        https://bugs.webkit.org/show_bug.cgi?id=52365

        * English.lproj/localizedStrings.js:
        * inspector/front-end/ApplicationCacheItemsView.js:
        (WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
        (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.GzipRule.prototype.doRun):
        (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
        (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.EventListenerBreakpointsSidebarPane):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView.prototype._updateWithCookies):
        * inspector/front-end/ImageView.js:
        (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
        (WebInspector.ImageView.prototype._createContentIfNeeded):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkTimeCalculator.prototype.formatValue):
        (WebInspector.NetworkTransferTimeCalculator.prototype.formatValue):
        (WebInspector.NetworkTransferDurationCalculator.prototype.formatValue):
        * inspector/front-end/ProfileDataGridTree.js:
        (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
        (WebInspector.ProfileDataGridNode.prototype.get data):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.Type.toUIString):
        (WebInspector.Resource.Type.toString):
        * inspector/front-end/TimelineOverviewPane.js:
        (WebInspector.TimelineOverviewCalculator.prototype.formatValue):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelineCalculator.prototype.formatValue):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
        * inspector/front-end/utilities.js:
        ():
        * Scripts/check-inspector-strings:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
commit-queue@webkit.org [Thu, 13 Jan 2011 15:45:39 +0000 (15:45 +0000)]
2011-01-13  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Need a way to inform the application when a Netscape plugin is created.
        https://bugs.webkit.org/show_bug.cgi?id=30179

        Added "c" style static method for the application to hook up for
        receiving notifications when a plugin is created.

        * plugins/symbian/PluginViewSymbian.cpp:
        (qtwebkit_setPluginCreatedCallback):
        (WebCore::PluginView::platformStart):
2011-01-13  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Need a way to inform the application when a Netscape plugin is created.
        https://bugs.webkit.org/show_bug.cgi?id=30179

        Added "c" style static method for the application to hook up for
        receiving notifications when a plugin is created.

        * symbian/bwins/QtWebKitu.def:
        * symbian/eabi/QtWebKitu.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Yi Shen <yi.4.shen@nokia.com>
commit-queue@webkit.org [Thu, 13 Jan 2011 15:29:24 +0000 (15:29 +0000)]
2011-01-13  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] Use a black background color for the video element on Qt Mobile
        https://bugs.webkit.org/show_bug.cgi?id=52252

        Use black as the background color for the video element on Qt Mobile.

        * css/themeQtMobile.css:
        (video):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Yi Shen <yi.4.shen@nokia.com>
commit-queue@webkit.org [Thu, 13 Jan 2011 15:12:08 +0000 (15:12 +0000)]
2011-01-13  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] Use a big central media play control button for video element
        https://bugs.webkit.org/show_bug.cgi?id=52315

        When ChromeClient::requiresFullscreenForVideoPlayback() returns true,
        all other control buttons for the video element are hidden, except
        a big centralized play button.

        No new tests because no client implements requiresFullscreenForVideoPlayback yet.

        * WebCore.pri:
        * css/mediaControlsQtFullscreen.css: Added.
        (audio):
        (audio::-webkit-media-controls-panel):
        (video::-webkit-media-controls-panel):
        (video:-webkit-full-page-media::-webkit-media-controls-panel):
        (audio::-webkit-media-controls-mute-button):
        (video::-webkit-media-controls-mute-button):
        (audio::-webkit-media-controls-play-button):
        (video::-webkit-media-controls-play-button):
        (audio::-webkit-media-controls-timeline-container):
        (video::-webkit-media-controls-timeline-container):
        (audio::-webkit-media-controls-current-time-display):
        (video::-webkit-media-controls-current-time-display):
        (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
        (audio::-webkit-media-controls-timeline):
        (video::-webkit-media-controls-timeline):
        (audio::-webkit-media-controls-volume-slider-container):
        (video::-webkit-media-controls-volume-slider-container):
        (audio::-webkit-media-controls-volume-slider):
        (video::-webkit-media-controls-volume-slider):
        (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
        (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
        (audio::-webkit-media-controls-fullscreen-button):
        (video::-webkit-media-controls-fullscreen-button):
        (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
        (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
        (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 13 Jan 2011 12:07:22 +0000 (12:07 +0000)]
2011-01-13  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Paint toggle buttons inconsistent when the object state is indeterminate
        https://bugs.webkit.org/show_bug.cgi?id=52361

        Check whether the object state is indeterminate to set the flag
        GTK_STATE_FLAG_INCONSISTENT before rendering check and radio
        buttons.

        * platform/gtk/RenderThemeGtk3.cpp:
        (WebCore::paintToggle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 13 Jan 2011 11:58:25 +0000 (11:58 +0000)]
2011-01-13  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gavin Barraclough.

        JIT requires VM overcommit (particularly on x86-64), Linux does not by default support this without swap?
        https://bugs.webkit.org/show_bug.cgi?id=42756

        The FixedVMPool Allocator does not work well on systems where
        allocating very large amounts of memory upfront is not reasonable,
        like Linux without overcommit enabled. As a workaround, on Linux,
        default to the values used in embedded environments (in the MB
        range), and only jump to the GB range if we detect at runtime that
        overcommit is enabled. Should fix crashes on Linux/x86_64 with
        less than 3 or 4GB of RAM.

        * jit/ExecutableAllocatorFixedVMPool.cpp:
        (JSC::FixedVMPoolAllocator::free): use new variables for VM pool
        size and coalesce limit.
        (JSC::ExecutableAllocator::isValid): swap the variables from
        embedded to generic values at runtime, on linux, if overcommit is
        enabled.
        (JSC::ExecutableAllocator::underMemoryPressure): use new variables
        for VM pool size and coalesce limit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Yi Shen <yi.4.shen@nokia.com>
commit-queue@webkit.org [Thu, 13 Jan 2011 11:46:53 +0000 (11:46 +0000)]
2011-01-13  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Extend the Platform Plugin to support full screen video handler
        https://bugs.webkit.org/show_bug.cgi?id=51249

        Make MediaPlayerPrivateQt support a fullscreen player.

        No new tests because LayoutTests/media/media-fullscreen-inline.html already exists.
        However, this test failed for Qt (QtMediaPlayer) due to durationchange event getting fired twice.
        So, still skip it for Qt.

        * WebCore.pro:
        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
        (WebCore::MediaPlayerPrivateQt::removeVideoItem):
        (WebCore::MediaPlayerPrivateQt::restoreVideoItem):
        * platform/graphics/qt/MediaPlayerPrivateQt.h:
        (WebCore::MediaPlayerPrivateQt::supportsFullscreen):
        (WebCore::MediaPlayerPrivateQt::mediaPlayer):
2011-01-13  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Extend the Platform Plugin to support full screen video handler
        https://bugs.webkit.org/show_bug.cgi?id=51249

        Add a new webkit platform plugin interface to support full screen video handler.

        * Api/qwebkitplatformplugin.h:
        (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
        (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::ChromeClientQt):
        (WebCore::ChromeClientQt::~ChromeClientQt):
        (WebCore::ChromeClientQt::fullScreenVideo):
        (WebCore::ChromeClientQt::supportsFullscreenForNode):
        (WebCore::ChromeClientQt::requiresFullscreenForVideoPlayback):
        (WebCore::ChromeClientQt::enterFullscreenForNode):
        (WebCore::ChromeClientQt::exitFullscreenForNode):
        * WebCoreSupport/ChromeClientQt.h:
        * WebCoreSupport/FullScreenVideoQt.cpp: Added.
        (WebCore::FullScreenVideoQt::FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::enterFullScreenForNode):
        (WebCore::FullScreenVideoQt::exitFullScreenForNode):
        (WebCore::FullScreenVideoQt::aboutToClose):
        (WebCore::FullScreenVideoQt::mediaPlayer):
        (WebCore::FullScreenVideoQt::mediaPlayerForNode):
        (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
        * WebCoreSupport/FullScreenVideoQt.h: Added.
        (WebCore::FullScreenVideoQt::isValid):
        * WebCoreSupport/QtPlatformPlugin.cpp:
        (WebCore::QtPlatformPlugin::createFullScreenVideoHandler):
        * WebCoreSupport/QtPlatformPlugin.h:
        * examples/platformplugin/WebPlugin.cpp:
        (FullScreenVideoWidget::FullScreenVideoWidget):
        (FullScreenVideoWidget::event):
        (FullScreenVideoWidget::keyPressEvent):
        (FullScreenVideoHandler::FullScreenVideoHandler):
        (FullScreenVideoHandler::~FullScreenVideoHandler):
        (FullScreenVideoHandler::requiresFullScreenForVideoPlayback):
        (FullScreenVideoHandler::enterFullScreen):
        (FullScreenVideoHandler::exitFullScreen):
        (WebPlugin::supportsExtension):
        (WebPlugin::createExtension):
        * examples/platformplugin/WebPlugin.h:
        (FullScreenVideoWidget::~FullScreenVideoWidget):
        * examples/platformplugin/platformplugin.pro:
        * examples/platformplugin/qwebkitplatformplugin.h:
        (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
        (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8858548> Disable inheritance of text emphasis marks to ruby text
mitz@apple.com [Thu, 13 Jan 2011 09:50:33 +0000 (09:50 +0000)]
<rdar://problem/8858548> Disable inheritance of text emphasis marks to ruby text
https://bugs.webkit.org/show_bug.cgi?id=52359

Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/ruby/text-emphasis.html

* css/html.css:
(rt):

LayoutTests:

* fast/ruby/text-emphasis-expected.txt: Added.
* fast/ruby/text-emphasis.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Thu, 13 Jan 2011 08:39:55 +0000 (08:39 +0000)]
2011-01-13  Hayato Ito  <hayato@chromium.org>

        Unreviewed, chromium test expectations.

        Flaky expectations for html5lib/webkit-resumer.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-13 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 13 Jan 2011 08:26:53 +0000 (08:26 +0000)]
2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74881.
        http://trac.webkit.org/changeset/74881
        https://bugs.webkit.org/show_bug.cgi?id=52357

        The EFL builder has been red for days (Requested by abarth on
        #webkit).

        * Scripts/webkitpy/common/net/buildbot/buildbot.py:
        * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTrivial fix after r75682.
ossy@webkit.org [Thu, 13 Jan 2011 08:25:14 +0000 (08:25 +0000)]
Trivial fix after r75682.

Rubber-stamped by David Levin.

* loader/FrameLoader.cpp: Remove accidentally committed debug code.
(WebCore::FrameLoader::shouldClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 13 Jan 2011 07:27:13 +0000 (07:27 +0000)]
2011-01-12  Adam Barth  <abarth@webkit.org>

        Removing this test from the Skipped list caused the next test
        alphabetically to fail instead.

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 13 Jan 2011 07:09:26 +0000 (07:09 +0000)]
2011-01-12  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by David Levin.

        Add beforeunload support to WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=52353

        * platform/mac-wk2/Skipped: Unskip a test that was failing solely due to missing
        beforeunload support.
2011-01-12  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by David Levin.

        Add beforeunload support to WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=52353

        This makes a number of currently failing tests pass.

        * WebKitTestRunner/TestController.cpp:
        (WTR::runBeforeUnloadConfirmPanel):
        (WTR::createOtherPage):
        (WTR::TestController::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Thu, 13 Jan 2011 05:55:16 +0000 (05:55 +0000)]
2011-01-12  Hayato Ito  <hayato@chromium.org>

        Unreviewed test expectations files fix.

        Fix a culprit revision number.

        * platform/chromium-gpu/test_expectations.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Thu, 13 Jan 2011 04:59:47 +0000 (04:59 +0000)]
2011-01-12  Hayato Ito  <hayato@chromium.org>

        Unreviewed chromium-gpu test expectations fix.

        Disable canvas-large-dimensions.html after r75639.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 13 Jan 2011 04:51:16 +0000 (04:51 +0000)]
2011-01-12  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION(r69831): focus() in onkeypress discards input (affects chaseonline.chase.com)
        https://bugs.webkit.org/show_bug.cgi?id=52241

        The bug was caused by RenderTextControl::selection's creating a Range with m_insertText
        which is a shadow DOM div as both start and end containers. Fixed the bug by traversing
        through the descendents of m_innerText and using the right start and end containers to
        create a Range.

        Test: fast/forms/focus-change-on-keypress.html

        * rendering/RenderTextControl.cpp:
        (WebCore::setContainerAndOffsetForRange): Added; a helper function.
        (WebCore::RenderTextControl::selection): See above.
2011-01-12  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION(r69831): focus() in onkeypress discards input (affects chaseonline.chase.com)
        https://bugs.webkit.org/show_bug.cgi?id=52241

        Added a test to ensure WebKit inserts the character typed by a user when focus's node
        is changed by a presskey event handler.

        * fast/forms/focus-change-on-keypress-expected.txt: Added.
        * fast/forms/focus-change-on-keypress.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Kenichi Ishibashi <bashi@google.com>
tkent@chromium.org [Thu, 13 Jan 2011 03:55:50 +0000 (03:55 +0000)]
2011-01-12  Kenichi Ishibashi  <bashi@google.com>

        Reviewed by Kent Tamura.

        M_formElementsWithFormAttribute not cleared when FormAssociatedElement is inserted with a null m_form and then removed.
        https://bugs.webkit.org/show_bug.cgi?id=51905

        Calls unregisterFormElementWithFormAttribute() when 'form' attribute
        is removed.

        Tests: fast/forms/form-associated-element-crash.html
               fast/forms/form-associated-element-crash2.html

        * html/FormAssociatedElement.cpp:
        (WebCore::FormAssociatedElement::formAttributeChanged):

2011-01-12  Kenichi Ishibashi  <bashi@google.com>

        Reviewed by Kent Tamura.

        M_formElementsWithFormAttribute not cleared when FormAssociatedElement is inserted with a null m_form and then removed.
        https://bugs.webkit.org/show_bug.cgi?id=51905

        Add test for crash when modifying the form attribute of a form
        associated element before removing it.

        * fast/forms/form-associated-element-crash-expected.txt: Added.
        * fast/forms/form-associated-element-crash.html: Added.
        * fast/forms/form-associated-element-crash2-expected.txt: Added.
        * fast/forms/form-associated-element-crash2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Kenichi Ishibashi <bashi@google.com>
tkent@chromium.org [Thu, 13 Jan 2011 03:48:42 +0000 (03:48 +0000)]
2011-01-12  Kenichi Ishibashi  <bashi@google.com>

        Reviewed by Kent Tamura.

        M_formElementsWithFormAttribute not cleared when Node is moved to another document.
        https://bugs.webkit.org/show_bug.cgi?id=51418

        Calls unregisterFormElementWithFormAttribute() when form associated elements
        are moved to another document.

        Test: fast/forms/change-form-element-document-crash.html

        * html/FormAssociatedElement.cpp:
        (WebCore::FormAssociatedElement::willMoveToNewOwnerDocument): Added.
        * html/FormAssociatedElement.h: Added willMoveToNewOwnerDocument().
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::willMoveToNewOwnerDocument): Added.
        * html/HTMLFormControlElement.h: Added willMoveToNewOwnerDocument().
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::willMoveToNewOwnerDocument): Added.
        * html/HTMLObjectElement.h: Added willMoveToNewOwnerDocument().
        * html/HTMLPlugInImageElement.h: Moves willMoveToNewOwnerDocument() to protected.

2011-01-12  Kenichi Ishibashi  <bashi@google.com>

        Reviewed by Kent Tamura.

        M_formElementsWithFormAttribute not cleared when Node is moved to another document.
        https://bugs.webkit.org/show_bug.cgi?id=51418

        Added test for crash when moving form elements from one document to another.

        * fast/forms/change-form-element-document-crash-expected.txt: Added.
        * fast/forms/change-form-element-document-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviwed. Added the missing bug id for r75672.
rniwa@webkit.org [Thu, 13 Jan 2011 03:26:57 +0000 (03:26 +0000)]
Unreviwed. Added the missing bug id for r75672.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
kbalazs@webkit.org [Thu, 13 Jan 2011 03:23:56 +0000 (03:23 +0000)]
Unreviewed.

Getting rid of the unused 'viewportSize' argument in QWKPagePrivate:init.
The argument is unused since http://trac.webkit.org/changeset/75468.

* UIProcess/API/qt/qgraphicswkview.cpp:
(QGraphicsWKView::QGraphicsWKView):
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::init):
* UIProcess/API/qt/qwkpage_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 13 Jan 2011 03:17:04 +0000 (03:17 +0000)]
2011-01-12  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Removed instantiation of legacy editing positions.
        Calls to Position::Position are replaced by calls to Position's convenience functions.

        Also added firstPositionInOrBeforeNode and lastPositionInOrAfterNode,
        which are functions that return firstPositionInNode and lastPositionInNode respectively
        when the specified node can have children for editing purpose and return positionBeforeNode
        and positionAfterNode respectively otherwise. They can be used to guarantee that we never
        create a bogus position like [img, 0] or [br, 0].

        No tests are added since this is a cleanup.

        * editing/ApplyBlockElementCommand.cpp:
        (WebCore::ApplyBlockElementCommand::formatSelection):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyBlockStyle):
        (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle):
        (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle):
        (WebCore::ApplyStyleCommand::removeInlineStyle):
        (WebCore::ApplyStyleCommand::nodeFullySelected):
        (WebCore::ApplyStyleCommand::nodeFullyUnselected):
        (WebCore::ApplyStyleCommand::splitTextAtStart):
        (WebCore::ApplyStyleCommand::splitTextAtEnd):
        (WebCore::ApplyStyleCommand::splitTextElementAtStart):
        (WebCore::ApplyStyleCommand::splitTextElementAtEnd):
        (WebCore::ApplyStyleCommand::isValidCaretPositionInTextNode):
        (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
        (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
        (WebCore::ApplyStyleCommand::computedFontSize):
        (WebCore::ApplyStyleCommand::joinChildTextNodes):
        * editing/ApplyStyleCommand.h:
        * editing/htmlediting.h:
        (WebCore::firstPositionInOrBeforeNode): Added.
        (WebCore::lastPositionInOrAfterNode): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 13 Jan 2011 02:50:58 +0000 (02:50 +0000)]
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Implement DrawingAreaImpl::scroll
        https://bugs.webkit.org/show_bug.cgi?id=52346

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::scroll):
        If there is already an active scroll, compute the area of both scroll rects and
        invalidate the smallest one. Compute a new dirty region if necessary and also
        add the scroll repaint region to the dirty region.

        (WebKit::DrawingAreaImpl::display):
        Reset the scroll area and scroll delta.

        * WebProcess/WebPage/DrawingAreaImpl.h:
        Add scroll area and scroll delta member variables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 13 Jan 2011 02:34:55 +0000 (02:34 +0000)]
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Region improvements
        https://bugs.webkit.org/show_bug.cgi?id=52344

        * Platform/Region.cpp:
        (WebKit::Region::Shape::move):
        (WebKit::Region::move):
        Change Region::move to take an IntSize.

        * Platform/Region.h:
        (WebKit::intersect):
        (WebKit::subtract):
        (WebKit::move):
        Add convenience functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAnother build fix.
weinig@apple.com [Thu, 13 Jan 2011 02:01:43 +0000 (02:01 +0000)]
Another build fix.

* platform/mac/WheelEventMac.mm:
(WebCore::phaseForEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 13 Jan 2011 01:58:16 +0000 (01:58 +0000)]
2011-01-12  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Qt build fix for r75661

        * Shared/WebEvent.h: Don't declare phase() on non-Mac platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 13 Jan 2011 01:47:38 +0000 (01:47 +0000)]
2011-01-12  Justin Schuh  <jschuh@chromium.org>

        Unreviewed chromium test expectations fix.

        Disable canvas-large-dimensions.html after r75639.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build.
weinig@apple.com [Thu, 13 Jan 2011 01:45:41 +0000 (01:45 +0000)]
Fix build.

* platform/mac/WheelEventMac.mm:
(WebCore::phaseForEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 13 Jan 2011 01:39:26 +0000 (01:39 +0000)]
2011-01-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Remove premature optimization from SchemeRegistry
        https://bugs.webkit.org/show_bug.cgi?id=52283

        As far as I can tell, this optimization isn't necessary.  I'm slightly
        unsure which benchmarks to run to demonstrate this numerically, but
        none of the benchmarks Chromium tracks were affected by adding a
        similar check for "display-isolated" schemes.

        * platform/SchemeRegistry.cpp:
        (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix, unreviewed.
enrica@apple.com [Thu, 13 Jan 2011 01:38:26 +0000 (01:38 +0000)]
Build fix, unreviewed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd-on for https://bugs.webkit.org/show_bug.cgi?id=52309
bdakin@apple.com [Thu, 13 Jan 2011 01:34:01 +0000 (01:34 +0000)]
Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309
Expose fixed layout through WebKit SPI
-and corresponding-
<rdar://problem/8844464>

Reviewed by Anders Carlsson.

Source/WebCore:

And now with getters!
* WebCore.exp.in:

WebKit/mac:

And now with getters!
* WebView/WebView.mm:
(-[WebView _useFixedLayout]):
(-[WebView _fixedLayoutSize]):
* WebView/WebViewPrivate.h:

WebKit2:

And now with getters!
* UIProcess/API/C/WKPage.cpp:
(WKPageUseFixedLayout):
(WKPageFixedLayoutSize):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::useFixedLayout):
(WebKit::WebPageProxy::fixedLayoutSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=52337
weinig@apple.com [Thu, 13 Jan 2011 01:25:56 +0000 (01:25 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=52337
PlatformWheelEvent should know about the scroll phase on the Mac

Reviewed by Anders Carlsson.

Source/WebCore:

Add a phase parameter on Mac PlatformWheelEvents.

* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::phase):
* platform/mac/WheelEventMac.mm:
(WebCore::phaseForEvent):
(WebCore::PlatformWheelEvent::PlatformWheelEvent):

WebKit2:

Add a phase parameter on Mac WebWheelEvent and pipe it down to PlatformWheelEvent.

* Shared/WebEvent.h:
(WebKit::WebWheelEvent::phase):
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
* Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::WebWheelEvent):
(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):
* Shared/mac/WebEventFactory.mm:
(WebKit::phaseForEvent):
(WebKit::WebEventFactory::createWebWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Thu, 13 Jan 2011 01:24:33 +0000 (01:24 +0000)]
2011-01-12  Chris Marrin  <cmarrin@apple.com>

        Unreviewed.

        A couple of lines of the patch for https://bugs.webkit.org/show_bug.cgi?id=52321
        were omitted.

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 13 Jan 2011 01:02:07 +0000 (01:02 +0000)]
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Get rid of an unneeded parameter from DrawingArea::scroll
        https://bugs.webkit.org/show_bug.cgi?id=52336

        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::scroll):
        * WebProcess/WebCoreSupport/WebChromeClient.h:
        * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
        (WebKit::ChunkedUpdateDrawingArea::scroll):
        * WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
        * WebProcess/WebPage/DrawingArea.h:
        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::scroll):
        * WebProcess/WebPage/DrawingAreaImpl.h:
        * WebProcess/WebPage/LayerBackedDrawingArea.cpp:
        (WebKit::LayerBackedDrawingArea::scroll):
        * WebProcess/WebPage/LayerBackedDrawingArea.h:
        * WebProcess/WebPage/TiledDrawingArea.cpp:
        (WebKit::TiledDrawingArea::scroll):
        * WebProcess/WebPage/TiledDrawingArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 13 Jan 2011 00:51:11 +0000 (00:51 +0000)]
2011-01-12  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by David Levin.

        [Chromium] Remove PartScrollbarHoriztonalTrack
        https://bugs.webkit.org/show_bug.cgi?id=52329

        Remove PartScrollbarHoriztonalTrack now that usages of it were removed
        with http://crrev.com/71249.

        * DEPS:
        * public/linux/WebThemeEngine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 13 Jan 2011 00:41:21 +0000 (00:41 +0000)]
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Get the new drawing area painting to the screen
        https://bugs.webkit.org/show_bug.cgi?id=52331

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
        Call setViewNeedsDisplay on all the update rects.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::setViewNeedsDisplay):
        Call through to the page client.

        (WebKit::WebPageProxy::processDidCrash):
        Null out the drawing area proxy.

        * UIProcess/mac/BackingStoreMac.mm:
        (WebKit::BackingStore::paint):
        Paint.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Thu, 13 Jan 2011 00:35:59 +0000 (00:35 +0000)]
2011-01-12  Chris Marrin  <cmarrin@apple.com>

        Unreviewed.

        Getting rid of an assert that was causing build failures that turns out not to be needed.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintsWithTransform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 13 Jan 2011 00:22:53 +0000 (00:22 +0000)]
2011-01-12  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        Detect, identify and recover from WebProcess crashes in run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=52330

        * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
        a web process crash.
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::initialize): Set up a processDidCrash
        callback.
        (WTR::TestController::processDidCrash): Report that the Web process
        crashed.
        * WebKitTestRunner/TestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 13 Jan 2011 00:20:07 +0000 (00:20 +0000)]
2011-01-12  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Mihai Parparita.

        fix assorted bugs with expansion lines
        https://bugs.webkit.org/show_bug.cgi?id=52326

        -Clicking "all" would collapse whitespace in the expanded lines.
        -Converted the remaining line creation code to using the DOM.

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Thu, 13 Jan 2011 00:14:09 +0000 (00:14 +0000)]
2011-01-12  Chris Marrin  <cmarrin@apple.com>

        Unreviewed.

        Another fix for Gtk

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintsWithTransform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Thu, 13 Jan 2011 00:08:28 +0000 (00:08 +0000)]
2011-01-12  Chris Marrin  <cmarrin@apple.com>

        Unreviewed.

        Fix for Gtk and Windows builds

        * page/Frame.cpp:
        (WebCore::Frame::scalePage):
        * page/Frame.h:
        * platform/graphics/ca/win/PlatformCALayerWin.cpp:
        (PlatformCALayer::contentsScale):
        (PlatformCALayer::setContentsScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 12 Jan 2011 23:52:46 +0000 (23:52 +0000)]
2011-01-12  Chris Marrin  <cmarrin@apple.com>

        UNreviewed.

        Fix for the Windows build

        * platform/graphics/ca/win/PlatformCALayerWin.cpp:
        (contentsScale):
        (setContentsScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 12 Jan 2011 23:48:54 +0000 (23:48 +0000)]
2011-01-12  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        review tool formatted diff doesn't match the uploaded diff
        https://bugs.webkit.org/show_bug.cgi?id=51960

        PrettyPatch works just fine if there is no newline at the end of the file.

        * attachment.cgi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 12 Jan 2011 23:41:25 +0000 (23:41 +0000)]
2011-01-12  Chris Marrin  <cmarrin@apple.com>

        Unreviewed.

        Another build fix

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::clampedContentsScaleForScale):
        * platform/graphics/ca/mac/PlatformCALayerMac.mm:
        (PlatformCALayer::setContentsScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-11 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Wed, 12 Jan 2011 23:35:54 +0000 (23:35 +0000)]
2011-01-11  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Max area bound needed in creation of IOSurface in ImageBufferCG.cpp
        https://bugs.webkit.org/show_bug.cgi?id=52172

        Tests: fast/canvas/canvas-large-dimensions.html

        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::ImageBuffer):
2011-01-11  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Max area bound needed in creation of IOSurface in ImageBufferCG.cpp
        https://bugs.webkit.org/show_bug.cgi?id=52172

        * fast/canvas/canvas-large-dimensions.html: Added.
        * fast/canvas/canvas-large-dimensions-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 12 Jan 2011 23:29:27 +0000 (23:29 +0000)]
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        More work on getting the drawing area proxy to paint
        https://bugs.webkit.org/show_bug.cgi?id=52328

        * UIProcess/API/mac/WKView.mm:
        (-[WKView drawRect:]):
        Handle the new drawing area.

        * UIProcess/BackingStore.cpp:
        (WebKit::BackingStore::BackingStore):
        Assert that the size isn't empty.

        * UIProcess/BackingStore.h:
        * UIProcess/mac/BackingStoreMac.mm:
        (WebKit::BackingStore::incorporateUpdate):
        Paint all update rects into the bitmap context.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::display):
        Create a handle so the shareable bitmap will actually be transferred over.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 12 Jan 2011 23:27:42 +0000 (23:27 +0000)]
2011-01-12  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        Bugzilla: Add keyboard shortcuts to jump to next change
        https://bugs.webkit.org/show_bug.cgi?id=52305

        Comments and diff blocks go in the same queue. If you have a
        comment focused, then j/k will focus the next/prev diff block
        with respect to that comment.

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Wed, 12 Jan 2011 23:27:30 +0000 (23:27 +0000)]
2011-01-12  Daniel Bates  <dbates@rim.com>
            And Benjamin C Meyer  <bmeyer@rim.com>

        Build fix when building with Inspector disabled
        https://bugs.webkit.org/show_bug.cgi?id=52313

        After changeset 75604 <http://trac.webkit.org/changeset/75604> it's not
        possible to build when the Inspector is disabled.

        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::updateApplicationCacheStatus): Fix build breakage when building
        with Inspector disabled and Offline Web Applications enabled by moving macro guard condition
        ENABLE(INSPECTOR) && ENABLE(OFFLINE_WEB_APPLICATIONS) into function body. This makes us also
        consistent with the form we use for InspectorInstrumentation::networkStateChanged() and other
        InspectorInstrumentation functions.
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::didReceiveData): Fix build breakage when building with Inspector
        disabled by adding ENABLE(INSPECTOR) guard around code that references the instance variable
        ApplicationCacheGroup::m_currentResourceIdentifier as this variable only exists when building
        with the Inspector.
        (WebCore::ApplicationCacheGroup::didFinishLoading): Ditto.
        (WebCore::ApplicationCacheGroup::didFail): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 12 Jan 2011 23:12:57 +0000 (23:12 +0000)]
2011-01-12  Chris Marrin  <cmarrin@apple.com>

        Unreviewed.

        Fix a build issue from http://trac.webkit.org/changeset/75639.

        * platform/graphics/GraphicsLayer.h:
        (WebCore::GraphicsLayer::contentsScale):
        (WebCore::GraphicsLayer::setContentsScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 12 Jan 2011 23:06:09 +0000 (23:06 +0000)]
2011-01-12  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Kevin Decker.

        Pages with accelerated layers lose subpixel-AA and become blurry when a scale factor is applied
        rdar://problem/8824974

        This prevents the rootLayer (with the WebKit rendered content) from going becoming
        a tiled layer when zoomed, and when there is other layered content on the page.
        This speeds up zooming a lot and avoids some buggy behavior in CA with a very large
        number of layers.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintsWithTransform):
        * rendering/RenderLayer.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::paintingGoesToWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 12 Jan 2011 22:58:31 +0000 (22:58 +0000)]
2011-01-12  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        show shared lines on both sides in code review tool
        https://bugs.webkit.org/show_bug.cgi?id=52308

        We were appending the same DOM node twice. Instead, make
        the from column a clone of the original node.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build.
andersca@apple.com [Wed, 12 Jan 2011 22:44:20 +0000 (22:44 +0000)]
Fix build.

* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::incorporateUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 12 Jan 2011 22:34:35 +0000 (22:34 +0000)]
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Begin stubbing out some more BackingStore member functions
        https://bugs.webkit.org/show_bug.cgi?id=52323

        * UIProcess/BackingStore.cpp:
        (WebKit::BackingStore::~BackingStore):
        This was accidentally made into a constructor; it should be a destructor.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::paint):
        Call the backing store.

        (WebKit::DrawingAreaProxyImpl::update):
        Incorporate the update.

        (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
        Create the backing store if needed and incorporate the update.

        * UIProcess/mac/BackingStoreMac.mm: Added.
        (WebKit::BackingStore::platformInitialize):
        Create a bitmap context.

        (WebKit::BackingStore::paint):
        (WebKit::BackingStore::incorporateUpdate):
        Add stubs.

        * WebKit2.xcodeproj/project.pbxproj:
        Add BackingStoreMac.mm

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 12 Jan 2011 22:27:27 +0000 (22:27 +0000)]
2011-01-12  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Pages with accelerated layers lose subpixel-AA and become blurry when a scale factor is applied
        rdar://problem/8824974

        When scaled, WebKit renders the page content at the scaled up size, so there are no
        scaling artifacts. But content drawn into a layer's backing store does not scale up.
        This is made worse by the fact that the root page contents become layered when there
        are other accelerated compositing layers present (video, plugins, etc.).

        Plumb scaling factor from Frame::scalePage() down into all layers with content. It
        eventually calls CALayer::setContentsScale which renders to a backing store whose dimensions
        are scaled, causing them to render larger and appear pixel perfect at the scaled
        page size.

         * page/Frame.cpp:
         (WebCore::Frame::updateContentsScale):
         (WebCore::Frame::scalePage):
         * page/Frame.h:
         * platform/graphics/GraphicsLayer.h:
         * platform/graphics/ca/GraphicsLayerCA.cpp:
         (WebCore::GraphicsLayerCA::setContentsScale):
         (WebCore::GraphicsLayerCA::clampedContentsScaleForScale):
         * platform/graphics/ca/GraphicsLayerCA.h:
         (WebCore::GraphicsLayerCA::contentsScale):
         * platform/graphics/ca/PlatformCALayer.h:
         * platform/graphics/ca/mac/PlatformCALayerMac.mm:
         (PlatformCALayer::contentsScale):
         (PlatformCALayer::setContentsScale):
         * rendering/RenderLayer.cpp:
         (WebCore::RenderLayer::updateContentsScale):
         * rendering/RenderLayer.h:
         * rendering/RenderLayerBacking.cpp:
         (WebCore::RenderLayerBacking::createGraphicsLayer):
         (WebCore::RenderLayerBacking::updateForegroundLayer):
         (WebCore::RenderLayerBacking::updateMaskLayer):
         (WebCore::RenderLayerBacking::updateContentsScale):
         * rendering/RenderLayerBacking.h:
         * rendering/RenderLayerCompositor.cpp:
         (WebCore::RenderLayerCompositor::updateContentsScale):
         * rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 12 Jan 2011 22:26:21 +0000 (22:26 +0000)]
2011-01-12  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        output the value of input and textarea nodes when using dump-as-markup
        https://bugs.webkit.org/show_bug.cgi?id=52319

        * editing/inserting/5607069-2-expected.txt:
        * editing/inserting/5607069-3-expected.txt:
        * editing/selection/dump-as-markup-expected.txt:
        * editing/selection/dump-as-markup-form-text-expected.txt: Added.
        * editing/selection/dump-as-markup-form-text.html: Added.
        * fast/parser/object-with-textarea-fallback-expected.txt:
        * html5lib/runner.html:
        * html5lib/webkit-resumer.html:
        * resources/dump-as-markup.js:
        (Markup.useHTML5libOutputFormat): Add a flag for html5lib compatibility
        (Markup._get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Wed, 12 Jan 2011 21:58:12 +0000 (21:58 +0000)]
2011-01-12  Stephen White  <senorblanco@chromium.org>

        Reviewed by James Robinson.

        Fix DrawingBuffer issues for depth/stencil, extensions, etc.
        https://bugs.webkit.org/show_bug.cgi?id=52310

        1)  GL_TEXTURE is not a valid argument to glFramebufferTexture2D()
        (should be GL_TEXTURE_2D).
        2)  Support for the multisampling extension was being checked after
        the DrawingBuffer constructor was called, which calls multisample()
        to check for the extension.
        3)  If depth or stencil is set, the corresponding framebuffers must
        be created in the DrawingBuffer constructor.
        4)  GL_DEPTH_STENCIL is not a valid framebuffer internal type in
        GLES2.  Must use GL_OES_DEPTH24_STENCIL8, and check for the
        OES_packed_depth_stencil extension.

        * platform/graphics/chromium/DrawingBufferChromium.cpp:
        (WebCore::DrawingBuffer::DrawingBuffer):
        Record the extension support in the constructor.  Create all the
        secondary drawing buffers (for multisampling, depth/stencil).
        * platform/graphics/gpu/DrawingBuffer.cpp:
        (WebCore::DrawingBuffer::create):
        Check for the extensions before calling the DrawingBuffer constructor.
        (WebCore::DrawingBuffer::createSecondaryBuffers):
        Refactor creation of the secondary buffers from DrawingBufferMac.mm to
        here.
        (WebCore::DrawingBuffer::reset):
        Use DEPTH24_STENCIL8 format, not DEPTH_STENCIL.  Use
        DEPTH_COMPONENT16, not DEPTH_COMPONENT.
        Use GL_TEXTURE_2D, not GL_TEXTURE (for glFramebufferTexture2D).
        * platform/graphics/gpu/DrawingBuffer.h:
        Refactor createSecondaryBuffers().  Add extension support arguments to
        constructor.  Add support for packed_depth_stencil extension.
        * platform/graphics/gpu/mac/DrawingBufferMac.mm:
        (WebCore::DrawingBuffer::DrawingBuffer):
        Record extension support in constructor.  Refactor out creation of
        secondary buffers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Robert Hogan <robert@webkit.org>
robert@webkit.org [Wed, 12 Jan 2011 21:12:25 +0000 (21:12 +0000)]
2011-01-12  Robert Hogan  <robert@webkit.org>

        Unreviewed, add expected results.

        [Qt] Add new expected results from r75632

        https://bugs.webkit.org/show_bug.cgi?id=42887

        * platform/qt/fast/forms/search-display-none-cancel-button-expected.txt: Added.
        * platform/qt/fast/forms/search-placeholder-value-changed-expected.txt: Added.
        * platform/qt/fast/forms/search-rtl-expected.txt: Added.
        * platform/qt/fast/forms/search-styled-expected.txt: Added.
        * platform/qt/fast/forms/search-transformed-expected.txt: Added.
        * platform/qt/fast/forms/search-zoomed-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
bdakin@apple.com [Wed, 12 Jan 2011 21:04:05 +0000 (21:04 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
fixed layout through WebKit SPI
-and corresponding-
<rdar://problem/8844464>

Reviewed by Anders Carlsson.

Source/WebCore:

Export symbols for ScrollView::setUseFixedLayout() and
ScrollView::setFixedLayoutSize()
* WebCore.exp.in:

WebKit/mac:

* WebView/WebView.mm:
(-[WebView _setUseFixedLayout:]):
(-[WebView _setFixedLayoutSize:]):
* WebView/WebViewPrivate.h:

WebKit2:

Store useFixedLayout and fixedLayoutSize in the
WebPageCreationParameters and the WebPageProxy.
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageSetUseFixedLayout):
(WKPageSetFixedLayoutSize):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setUseFixedLayout):
(WebKit::WebPageProxy::setFixedLayoutSize):
(WebKit::WebPageProxy::creationParameters):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setUseFixedLayout):
(WebKit::WebPage::setFixedLayoutSize):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Robert Hogan <robert@webkit.org>
robert@webkit.org [Wed, 12 Jan 2011 21:03:46 +0000 (21:03 +0000)]
2011-01-12  Robert Hogan  <robert@webkit.org>

        Unreviewed, update expected results.

        [Qt] Update expected results from r75632

        https://bugs.webkit.org/show_bug.cgi?id=42887

        * platform/qt/fast/css/pseudo-cache-stale-expected.txt:
        * platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
        * platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
        * platform/qt/fast/forms/search-vertical-alignment-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 12 Jan 2011 20:53:09 +0000 (20:53 +0000)]
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Beth Dakin.

        Add BackingStore class
        https://bugs.webkit.org/show_bug.cgi?id=52318

        * UIProcess/BackingStore.cpp: Added.
        (WebKit::BackingStore::create):
        (WebKit::BackingStore::BackingStore):
        * UIProcess/BackingStore.h: Added.
        * WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Robert Hogan <robert@webkit.org>
robert@webkit.org [Wed, 12 Jan 2011 20:27:43 +0000 (20:27 +0000)]
2011-01-12  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Search input field doesn't have cancel button

        Add a cancel button to the search field and make it customizable
        by the client. For now, use the close dialog button associated
        with the application's style as the default.

        Unskip a bunch of search field related tests that pass now:

        fast/forms/search-cancel-button-mouseup.html
        fast/forms/search-rtl.html
        fast/forms/search-abs-pos-cancel-button.html
        fast/forms/search-styled.html
        fast/forms/search-transformed.html
        fast/forms/search-zoomed.html
        fast/forms/search-cancel-button-style-sharing.html
        fast/forms/search-display-none-cancel-button.html
        fast/forms/search-placeholder-value-changed.html
        fast/repaint/search-field-cancel.html
        fast/forms/search-cancel-button-events.html

        https://bugs.webkit.org/show_bug.cgi?id=42887

        * platform/qt/Skipped:
2011-01-12  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Search input field doesn't have cancel button

        Add a cancel button to the search field and make it customizable
        by the client. For now, use the close dialog button associated
        with the application's style as the default.

        Unskip a bunch of search field related tests that pass now:

        fast/forms/search-cancel-button-mouseup.html
        fast/forms/search-rtl.html
        fast/forms/search-abs-pos-cancel-button.html
        fast/forms/search-styled.html
        fast/forms/search-transformed.html
        fast/forms/search-zoomed.html
        fast/forms/search-cancel-button-style-sharing.html
        fast/forms/search-display-none-cancel-button.html
        fast/forms/search-placeholder-value-changed.html
        fast/repaint/search-field-cancel.html
        fast/forms/search-cancel-button-events.html

        https://bugs.webkit.org/show_bug.cgi?id=42887

        * platform/graphics/qt/ImageQt.cpp:
        (loadResourcePixmap):
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::isControlStyled):
        (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
        (WebCore::RenderThemeQt::paintSearchField):
        (WebCore::RenderThemeQt::adjustSearchFieldStyle):
        (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
        (WebCore::RenderThemeQt::convertToPaintingRect):
        (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
        * platform/qt/RenderThemeQt.h:
2011-01-12  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Search input field doesn't have cancel button

        Add a cancel button to the search field and make it customizable
        by the client. For now, use the close dialog button associated
        with the application's style as the default.

        https://bugs.webkit.org/show_bug.cgi?id=42887

        * Api/qwebsettings.cpp:
        (graphics):
        * Api/qwebsettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8837307>, <rdar://problem/8637038>, and https://bugs.webkit.org/show_...
beidson@apple.com [Wed, 12 Jan 2011 20:12:40 +0000 (20:12 +0000)]
<rdar://problem/8837307>, <rdar://problem/8637038>, and https://bugs.webkit.org/show_bug.cgi?id=52248
Back/forward list recovery after a WebProcess crash is crashy itself.

Reviewed by Sam Weinig.

Add an isEmpty() accessor so the WebProcess knows if it is actually restoring a session:
* Shared/SessionState.cpp:
(WebKit::SessionState::isEmpty):
* Shared/SessionState.h:

Keep track of the highest used itemID so a relaunched WebProcess can later be informed:
* Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
(WebKit::WebBackForwardListItem::highedUsedItemID):
* Shared/WebBackForwardListItem.h:
* WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::generateHistoryItemID):
(WebKit::WebBackForwardListProxy::setHighestItemIDFromUIProcess):
(WebKit::WebBackForwardListProxy::addItemFromUIProcess): Remove a now-invalid ASSERT, as the UIProcess
  now tells the WebProcess that a previous WebProcess created.
* WebProcess/WebPage/WebBackForwardListProxy.h:

Encode/decode data relevant to restoring a session on WebPage creation:
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:

If the WebProcess has crashed since the last load, change reload and the various back/forward APIs to
update the current back/forward item (if necessary) then relaunch the process:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::reattachToWebProcess): Renamed from "relaunch()" and made private.
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::creationParameters):
* UIProcess/WebPageProxy.h:

Rename "RestoreSession" to "RestoreSessionAndNavigateToCurrentItem"
* WebProcess/WebPage/WebPage.messages.in:
* UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::restoreFromSessionStateData):

Restore a session on page creation if the parameters include it:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Call restoreSession if session state exists.
(WebKit::WebPage::restoreSessionAndNavigateToCurrentItem):
(WebKit::WebPage::restoreSession):
* WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 12 Jan 2011 20:11:47 +0000 (20:11 +0000)]
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Send Update and DidUpdate messages
        https://bugs.webkit.org/show_bug.cgi?id=52316

        * UIProcess/DrawingAreaProxy.h:
        (WebKit::DrawingAreaProxy::update):
        Add empty stub.

        * UIProcess/DrawingAreaProxy.messages.in:
        Add Update message.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::update):
        Just send back a DidUpdate message.

        * WebProcess/WebPage/DrawingArea.h:
        (WebKit::DrawingArea::didUpdate):
        Add empty stub.

        * WebProcess/WebPage/DrawingArea.messages.in:
        Add DidUpdate message.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::didUpdate):
        Call display().

        (WebKit::DrawingAreaImpl::display):
        Send an Update message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 12 Jan 2011 20:07:53 +0000 (20:07 +0000)]
2011-01-12  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: cookie table is multiplied after repeated switching to cookies tab in network item view
        Only create cookiesTable is it hasn't been done yet.
        https://bugs.webkit.org/show_bug.cgi?id=52303

        * inspector/front-end/ResourceCookiesView.js:
        (WebInspector.ResourceCookiesView.prototype.show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agocheck-webkit-style -- close_expression function doesn't work correctly.
levin@chromium.org [Wed, 12 Jan 2011 19:41:54 +0000 (19:41 +0000)]
check-webkit-style -- close_expression function doesn't work correctly.
https://bugs.webkit.org/show_bug.cgi?id=52272

Reviewed by Shinichiro Hamaji.

* Scripts/webkitpy/style/checkers/cpp.py:
(Position.__str__): Added a way to convert it to a string which is useful in tests.
(Position.__cmp__): Added a way to compare Position which is useful in tests and
generally useful (for upcoming code changes).
(close_expression): Changed to use Position for input and output.
Also, fixed many bugs such as only working correctly for parenthesis,
not working correctly if given an offset in a line and not finding
the real closing element if there were multiple closing elements in
the same line.
(detect_functions): Adjusted due to the change in arguments for
close_expression.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTestBase.assert_positions_equal): Added a way to verify that
two positions are the same.
(CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
(CppStyleTest.test_close_expression): Added tests to catch the issues
that were fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-01-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 12 Jan 2011 19:41:22 +0000 (19:41 +0000)]
2011-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Make the new drawing area actually draw something
        https://bugs.webkit.org/show_bug.cgi?id=52314

        * Shared/UpdateInfo.cpp:
        (WebKit::UpdateInfo::encode):
        (WebKit::UpdateInfo::decode):
        Encode and decode newly added fields.

        * Shared/UpdateInfo.h:
        Add a vector of update rects and a handle for the sharable bitmap.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::display):
        Get the individual rects from the region and paint them into the shareable bitmap.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::mainFrameHasCustomRepresentation):
        * WebProcess/WebPage/WebPage.h:
        Add helper function.

        * WebProcess/WebPage/mac/ChunkedUpdateDrawingAreaMac.cpp:
        (WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
        Use helper function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75627 268f45cc-cd09-0410-ab3c-d52691b4dbfc