WebKit-https.git
12 years ago2008-11-20 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 21 Nov 2008 00:26:29 +0000 (00:26 +0000)]
2008-11-20  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=20368

        Implement getComputedStyle for animation properties. Remove individual
        computed values for transform-origin-x, transform-origin-y, and just
        return transform-origin instead. Return "none" for default animation-name,
        and fix the initial value.

        Tests: animations/computed-style.html
               transforms/computed-style-origin.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::getDelayValue):
        (WebCore::getDurationValue):
        (WebCore::getTimingFunctionValue):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::initialAnimationName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-20 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 21 Nov 2008 00:23:34 +0000 (00:23 +0000)]
2008-11-20  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        A little more RegExp refactoring.

        Created a helper function in the assembler for linking a vector of
        JmpSrc to a location, and deployed it in a bunch of places.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::link):
        * wrec/WREC.cpp:
        (JSC::WREC::compileRegExp):
        * wrec/WRECGenerator.cpp:
        (JSC::WREC::Generator::generateNonGreedyQuantifier):
        (JSC::WREC::Generator::generateGreedyQuantifier):
        (JSC::WREC::Generator::generateCharacterClassInverted):
        (JSC::WREC::Generator::generateParentheses):
        (JSC::WREC::Generator::generateParenthesesResetTrampoline):
        (JSC::WREC::Generator::generateAssertionBOL):
        (JSC::WREC::Generator::generateAssertionEOL):
        (JSC::WREC::Generator::generateAssertionWordBoundary):
        (JSC::WREC::Generator::terminateAlternative):
        (JSC::WREC::Generator::terminateDisjunction):
        * wrec/WRECParser.cpp:
        * wrec/WRECParser.h:
        (JSC::WREC::Parser::consumeHex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-20 Pamela Greene <pam@chromium.org>
pam@chromium.org [Thu, 20 Nov 2008 23:51:55 +0000 (23:51 +0000)]
2008-11-20  Pamela Greene  <pam@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22371
        Add a test for accessing form element items by index.

        * fast/dom/HTMLFormElement/htmlformelement-indexed-getter-expected.txt: Added.
        * fast/dom/HTMLFormElement/htmlformelement-indexed-getter.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-20 Pamela Greene <pam@chromium.org>
pam@chromium.org [Thu, 20 Nov 2008 23:47:00 +0000 (23:47 +0000)]
2008-11-20  Pamela Greene  <pam@chromium.org>

        Reviewed by Darin Adler.

        Test for https://bugs.webkit.org/show_bug.cgi?22370
        Add a test to check detectability of HTMLCollections.

        * fast/dom/htmlcollection-detectability-expected.txt: Added.
        * fast/dom/htmlcollection-detectability.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-20 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 20 Nov 2008 23:33:12 +0000 (23:33 +0000)]
2008-11-20  Sam Weinig  <sam@webkit.org>

        Fix non-mac builds.

        * parser/Lexer.cpp:
        * parser/Parser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-20 Pamela Greene <pam@chromium.org>
pam@chromium.org [Thu, 20 Nov 2008 23:31:08 +0000 (23:31 +0000)]
2008-11-20  Pamela Greene  <pam@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22369
        Add test cases covering more basic operations.

        * fast/js/function-dot-arguments-expected.txt:
        * fast/js/resources/function-dot-arguments.js:
        (basicTest): Added
        (lengthTest): Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-20 Pamela Greene <pam@chromium.org>
pam@chromium.org [Thu, 20 Nov 2008 23:27:09 +0000 (23:27 +0000)]
2008-11-20  Pamela Greene  <pam@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22363
        Add a test for DOM1 and DOM2 versions of add() on a select control.

        * fast/dom/dom-add-optionelement-expected.txt: Added.
        * fast/dom/dom-add-optionelement.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-20 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 20 Nov 2008 23:23:59 +0000 (23:23 +0000)]
2008-11-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Patch for https://bugs.webkit.org/show_bug.cgi?id=22385
        <rdar://problem/6390179>
        Lazily reparse FunctionBodyNodes on first execution.

        - Saves 57MB on Membuster head.

        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::generate): Remove vector shrinking since this is now
        handled by destroying the ScopeNodeData after generation.

        * parser/Grammar.y: Add alternate NoNode version of the grammar
        that does not create nodes.  This is used to lazily create FunctionBodyNodes
        on first execution.

        * parser/Lexer.cpp:
        (JSC::Lexer::setCode): Fix bug where on reparse, the Lexer was confused about
        what position and length meant. Position is the current position in the original
        data buffer (important for getting correct line/column information) and length
        the end offset in the original buffer.
        * parser/Lexer.h:
        (JSC::Lexer::sourceCode): Positions are relative to the beginning of the buffer.

        * parser/Nodes.cpp:
        (JSC::ScopeNodeData::ScopeNodeData): Move initialization of ScopeNode data here.
        (JSC::ScopeNode::ScopeNode): Add constructor that only sets the JSGlobalData
        for FunctionBodyNode stubs.
        (JSC::ScopeNode::~ScopeNode): Release m_children now that we don't inherit from
        BlockNode.
        (JSC::ScopeNode::releaseNodes): Ditto.
        (JSC::EvalNode::generateBytecode): Only shrink m_children, as we need to keep around
        the rest of the data.
        (JSC::FunctionBodyNode::FunctionBodyNode): Add constructor that only sets the
        JSGlobalData.
        (JSC::FunctionBodyNode::create): Ditto.
        (JSC::FunctionBodyNode::generateBytecode): If we don't have the data, do a reparse
        to construct it. Then after generation, destroy the data.
        (JSC::ProgramNode::generateBytecode): After generation, destroy the AST data.
        * parser/Nodes.h:
        (JSC::ExpressionNode::): Add isFuncExprNode for FunctionConstructor.
        (JSC::StatementNode::): Add isExprStatementNode for FunctionConstructor.
        (JSC::ExprStatementNode::): Ditto.
        (JSC::ExprStatementNode::expr): Add accessor for FunctionConstructor.
        (JSC::FuncExprNode::): Add isFuncExprNode for FunctionConstructor

        (JSC::ScopeNode::adoptData): Adopts a ScopeNodeData.
        (JSC::ScopeNode::data): Accessor for ScopeNodeData.
        (JSC::ScopeNode::destroyData): Deletes the ScopeNodeData.
        (JSC::ScopeNode::setFeatures): Added.
        (JSC::ScopeNode::varStack): Added assert.
        (JSC::ScopeNode::functionStack): Ditto.
        (JSC::ScopeNode::children): Ditto.
        (JSC::ScopeNode::neededConstants): Ditto.
        Factor m_varStack, m_functionStack, m_children and m_numConstants into ScopeNodeData.

        * parser/Parser.cpp:
        (JSC::Parser::reparse): Reparse the SourceCode in the FunctionBodyNode and set
        set up the ScopeNodeData for it.
        * parser/Parser.h:

        * parser/SourceCode.h:
        (JSC::SourceCode::endOffset): Added for use in the lexer.

        * runtime/FunctionConstructor.cpp:
        (JSC::getFunctionBody): Assuming a ProgramNode with one FunctionExpression in it,
        get the FunctionBodyNode.  Any issues signifies a parse failure in constructFunction.
        (JSC::constructFunction): Make parsing functions in the form new Function(""), easier
        by concatenating the strings together (with some glue) and parsing the function expression
        as a ProgramNode from which we can receive the FunctionBodyNode. This has the added benefit
        of not having special parsing code for the arguments and lazily constructing the
        FunctionBodyNode's AST on first execution.

        * runtime/Identifier.h:
        (JSC::operator!=): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-20 Pamela Greene <pam@chromium.org>
pam@chromium.org [Thu, 20 Nov 2008 23:23:16 +0000 (23:23 +0000)]
2008-11-20  Pamela Greene  <pam@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22359
        Add test for document.write() with multiple parameters.

        * fast/dom/document_write_params-expected.txt: Added.
        * fast/dom/document_write_params.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-20 Pamela Greene <pam@chromium.org>
pam@chromium.org [Thu, 20 Nov 2008 23:19:34 +0000 (23:19 +0000)]
2008-11-20  Pamela Greene  <pam@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22387
        Add a test for HTMLOptionsCollection indexed getter and setter.

        * fast/dom/HTMLOptionElement/collection-setter-getter-expected.txt: Added.
        * fast/dom/HTMLOptionElement/collection-setter-getter.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-20 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 20 Nov 2008 22:27:34 +0000 (22:27 +0000)]
2008-11-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Speedup the lexer to offset coming re-parsing patch.

        - .6% progression on Sunspider.

        * bytecompiler/SegmentedVector.h:
        (JSC::SegmentedVector::shrink): Fixed bug where m_size would not be
        set when shrinking to 0.

        * parser/Lexer.cpp:
        (JSC::Lexer::Lexer):
        (JSC::Lexer::isIdentStart): Use isASCIIAlpha and isASCII to avoid going into ICU in the common cases.
        (JSC::Lexer::isIdentPart): Use isASCIIAlphanumeric and isASCII to avoid going into ICU in the common cases
        (JSC::isDecimalDigit): Use version in ASCIICType.h. Inlining it was a regression.
        (JSC::Lexer::isHexDigit): Ditto.
        (JSC::Lexer::isOctalDigit): Ditto.
        (JSC::Lexer::clear): Resize the m_identifiers SegmentedVector to initial
        capacity
        * parser/Lexer.h: Remove unused m_strings vector. Make m_identifiers
        a SegmentedVector<Identifier> to avoid allocating a new Identifier* for
        each identifier found.  The SegmentedVector is need so we can passes
        references to the Identifier to the parser, which remain valid even when
        the vector is resized.
        (JSC::Lexer::makeIdentifier): Inline and return a reference to the added
        Identifier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Thu, 20 Nov 2008 22:02:37 +0000 (22:02 +0000)]
WebCore:

2008-11-20  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Beth Dakin.

        Preparation for:
        <rdar://problem/2610675> Blank line that is quoted can't be deleted

        To fix this we need to make changes to the code that creates selections to delete
        when the user does a backward or forward delete with a caret selection.  For certain
        caret positions, we now want to remove something other than the standard "caret extended
        backward/forward by one unit".  The problem is that there were two pieces of code
        responsible for doing this, one in Editor::deleteWithDirection, and another inside
        TypingCommand::deleteKeyPressed.  The code in deleteWithDirection is a recent
        addition (r19172), and adding it there caused regressions because it prevented the
        code in deleteKeyPressed from ever running.  The regressions were never caught because
        JS deletion uses deleteKeyPressed while manual deletion uses deleteWithDirection.

        This patch removes selection creation code from deleteWithDirection so that deleteKeyPressed
        can handle it.  That required moving code to handle the kill ring down into deleteKeyPressed.

        Follow up patches will fix <rdar://problem/2610675>, and attempt to eliminate the rest of the
        discrepancies between the behavior of JS deletions and manual deletions, so that we
        have better test coverage.

        * editing/Editor.cpp:
        (WebCore::Editor::deleteWithDirection): Early return if m_frame->document() is null, instead
        of checking for that periodically throughout the function.  There's really nothing to be done
        if it's null anyway.
        Move kill ring code down into deleteKeyPressed.
        * editing/Editor.h:
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::TypingCommand):
        (WebCore::TypingCommand::deleteKeyPressed):
        (WebCore::TypingCommand::forwardDeleteKeyPressed):
        (WebCore::TypingCommand::doApply):
        * editing/TypingCommand.h:
        (WebCore::TypingCommand::create):

LayoutTests:

2008-11-20  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Beth Dakin.

        <rdar://problem/2610675> Blank line that is quoted can't be deleted

        The old selection modification code for caret case deletions set the selection
        about to be deleted on the frame, instead of just setting the endingSelection.

        * platform/mac/editing/deleting/delete-by-word-001-expected.txt:
        * platform/mac/editing/deleting/delete-by-word-002-expected.txt:
        * platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.txt:
        * platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
        * platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-20 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 20 Nov 2008 21:51:10 +0000 (21:51 +0000)]
2008-11-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Add isASCII to ASCIICType.  Use coming soon!

        * wtf/ASCIICType.h:
        (WTF::isASCII):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin@apple.com [Thu, 20 Nov 2008 21:41:20 +0000 (21:41 +0000)]
WebCore:

2008-11-20  Darin Adler  <darin@apple.com>

        Earlier version reviewed by Justin Garcia.

        - fix <rdar://problem/4108572> REGRESSION: Can't extend selection with shift-arrow in read only mode

        * editing/Editor.cpp:
        (WebCore::Editor::handleKeyboardEvent): Remove isContentEditable check -- keyboard events can be
        handled even when the selection is not in an editable area.
        (WebCore::Editor::handleInputMethodKeydown): Ditto.

        * editing/EditorCommand.cpp: Changed the enabled rule for operations that change the selection to
        allow use when there's a selection even if it's not in an editable area. This includes commands
        like shift-arrow keys to extend the slection, but not commands like arrow keys to move the
        insertion point.

WebKit/mac:

2008-11-20  Darin Adler  <darin@apple.com>

        Earlier version reviewed by Justin Garcia.

        - part of fix for <rdar://problem/4108572> REGRESSION: Can't extend selection with shift-arrow in read only mode
          Also resolves <rdar://problem/5000134>.

        * WebView/WebHTMLView.mm: Removed some unused code, and made the Tiger workaround for bug 3789278
        be Tiger-only.
        (-[WebHTMLView resignFirstResponder]): Removed code setting unused resigningFirstResponder flag.
        (-[WebHTMLView _wantsKeyDownForEvent:]): Added. Returns YES.
        (-[WebHTMLView insertText:]): Don't try to insert text if the selection is not editable. We used
        to prevent even processing the input, but that's not practical since some commands need to work
        even in non-editable regions.

LayoutTests:

2008-11-20  Darin Adler  <darin@apple.com>

        - update test result for <rdar://problem/4108572> REGRESSION: Can't extend
          selection with shift-arrow in read only mode

        * editing/selection/selection-actions.html: Removed the actions that are
        supposed to modify selections now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-20 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 20 Nov 2008 21:25:35 +0000 (21:25 +0000)]
2008-11-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Add OwnPtr constructor and OwnPtr::adopt that take an auto_ptr.

        * wtf/OwnPtr.h:
        (WTF::OwnPtr::OwnPtr):
        (WTF::OwnPtr::adopt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-20 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 20 Nov 2008 20:52:48 +0000 (20:52 +0000)]
2008-11-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Jon Honeycutt.

        Move some frame/page checking code down to the base class.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView start]):
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView _createPlugin]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Thu, 20 Nov 2008 20:36:20 +0000 (20:36 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22380
        Fix WorkerContext refcounting

        * dom/WorkerContext.cpp:
        (WebCore::WorkerContext::WorkerContext):
        * dom/WorkerContext.h:
        (WebCore::WorkerContext::script):
        (WebCore::WorkerContext::clearScript):
        Added a method to manually destroy WorkerSctriptController.

        * dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread):
        Destroy WorkerScriptController to release any references to WorkerContext.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-19 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Thu, 20 Nov 2008 19:40:25 +0000 (19:40 +0000)]
2008-11-19  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin Adler.

        Last part of bug 21106: .in format discussed changes
        https://bugs.webkit.org/show_bug.cgi?id=21106

        - Renamed isAudioHack to wrapperOnlyIfMediaIsAvailable as requested.

        - Cleaned up additionnal function parameters that were unneeded.

        * dom/make_names.pl:
        * html/HTMLTagNames.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-20 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Thu, 20 Nov 2008 18:52:31 +0000 (18:52 +0000)]
2008-11-20  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Geoff Garen.

        Add tests for bug 22148: nytime.com page crashes browser during load
        <https://bugs.webkit.org/show_bug.cgi?id=22148>

        This bug was unknowingly fixed in r38322 by a rewrite of the recursion
        limit code.

        * fast/js/deep-recursion-test-expected.txt:
        * fast/js/deep-recursion-test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Thu, 20 Nov 2008 18:18:50 +0000 (18:18 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22383
        Worker tests spill error messages over to consequent tests

        * dom/Worker.cpp: (WebCore::Worker::Worker):
        Raise an exception immediately if URL is empty. Dcoument::completeURL() returns document URL
        in this case, and there is no sense in starting a thread and trying to parse document source
        as JavaScript.

        * bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
        Return quickly if toString() raised an exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Thu, 20 Nov 2008 18:11:14 +0000 (18:11 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22364
        Crashes seen on Tiger buildbots due to worker threads exhausting pthread keys

        * runtime/Collector.cpp:
        (JSC::Heap::Heap):
        (JSC::Heap::destroy):
        (JSC::Heap::makeUsableFromMultipleThreads):
        (JSC::Heap::registerThread):
        * runtime/Collector.h:
        Pthread key for tracking threads is only created on request now, because this is a limited
        resource, and thread tracking is not needed for worker heaps, or for WebCore heap.

        * API/JSContextRef.cpp: (JSGlobalContextCreateInGroup): Call makeUsableFromMultipleThreads().

        * runtime/JSGlobalData.cpp: (JSC::JSGlobalData::sharedInstance): Ditto.

        * runtime/JSGlobalData.h: (JSC::JSGlobalData::makeUsableFromMultipleThreads): Just forward
        the call to Heap, which clients need not know about, ideally.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-20 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 20 Nov 2008 17:38:50 +0000 (17:38 +0000)]
2008-11-20  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        A little more WREC refactoring.

        Removed the "Register" suffix from register names in WREC, and renamed:
            currentPosition => index
            currentValue => character
            quantifierCount => repeatCount

        Added a top-level parsePattern function to the WREC parser, which
        allowed me to remove the error() and atEndOfPattern() accessors.

        Factored out an MSVC customization into a constant.

        Renamed nextLabel => beginPattern.

        * wrec/WREC.cpp:
        (JSC::WREC::compileRegExp):
        * wrec/WRECGenerator.cpp:
        (JSC::WREC::Generator::generateBacktrack1):
        (JSC::WREC::Generator::generateBacktrackBackreference):
        (JSC::WREC::Generator::generateBackreferenceQuantifier):
        (JSC::WREC::Generator::generateNonGreedyQuantifier):
        (JSC::WREC::Generator::generateGreedyQuantifier):
        (JSC::WREC::Generator::generatePatternCharacter):
        (JSC::WREC::Generator::generateCharacterClassInvertedRange):
        (JSC::WREC::Generator::generateCharacterClassInverted):
        (JSC::WREC::Generator::generateCharacterClass):
        (JSC::WREC::Generator::generateParentheses):
        (JSC::WREC::Generator::generateParenthesesResetTrampoline):
        (JSC::WREC::Generator::generateAssertionBOL):
        (JSC::WREC::Generator::generateAssertionEOL):
        (JSC::WREC::Generator::generateAssertionWordBoundary):
        (JSC::WREC::Generator::generateBackreference):
        (JSC::WREC::Generator::generateDisjunction):
        (JSC::WREC::Generator::terminateDisjunction):
        * wrec/WRECGenerator.h:
        * wrec/WRECParser.h:
        (JSC::WREC::Parser::parsePattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-19 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 20 Nov 2008 16:43:11 +0000 (16:43 +0000)]
2008-11-19  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adele Peterson.

        https://bugs.webkit.org/show_bug.cgi?id=22190

        Fix the painting and event handling in transformed search fields.
        When painting the cancel and results button parts,  get the rect from AppKit
        relative to the input bounds (rather than in absolute coords), then convert
        it into the coords of the part's renderer (which is the one that is painting).
        To do this we need to compute an offset relative to some container, so expose
        a method on RenderObject for that.

        Also fix the location at which the search popup shows up to take transforms
        into account, and fix the math that is used to figure out if the search
        results button, or the cancel button should get the mouse events.

        Test: fast/forms/search-transformed.html

        * rendering/RenderBox.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::offsetFromContainer):
        * rendering/RenderObject.h:
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::forwardEvent):
        (WebCore::RenderTextControl::showPopup):
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::convertToPaintingRect):
        (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
        (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
        (WebCore::RenderThemeMac::paintSearchFieldResultsButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the previous submit and re-add accidential pcre/pcre.h inclusion
hausmann@webkit.org [Thu, 20 Nov 2008 13:50:18 +0000 (13:50 +0000)]
Fix the previous submit and re-add accidential pcre/pcre.h inclusion

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-20 Joerg Bornemann <joerg.bornemann@trolltech.com>
hausmann@webkit.org [Thu, 20 Nov 2008 13:44:01 +0000 (13:44 +0000)]
2008-11-20  Joerg Bornemann  <joerg.bornemann@trolltech.com>

        Reviewed by Simon Hausmann.

        Steps towards making the the Qt port of WebKit compile on Windows CE

        https://bugs.webkit.org/show_bug.cgi?id=20746

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-20 Antti Koivisto <antti@apple.com>
antti@apple.com [Thu, 20 Nov 2008 10:47:22 +0000 (10:47 +0000)]
2008-11-20  Antti Koivisto  <antti@apple.com>

        Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=22379
        Make CSSOM use less memory

        - Shrink CSSProperty by half by using bitfields.
        - Get rid of m_strictParsing field in StyleBase by moving it up to CSSStyleSheet
          and CSSMutableStyleDeclaration. This reduces size of many highly popular objects.

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
        (WebCore::CSSMutableStyleDeclaration::operator=):
        * css/CSSMutableStyleDeclaration.h:
        (WebCore::CSSMutableStyleDeclaration::setStrictParsing):
        (WebCore::CSSMutableStyleDeclaration::useStrictParsing):
        * css/CSSProperty.h:
        * css/CSSStyleSheet.cpp:
        (WebCore::CSSStyleSheet::CSSStyleSheet):
        * css/CSSStyleSheet.h:
        (WebCore::CSSStyleSheet::setStrictParsing):
        (WebCore::CSSStyleSheet::useStrictParsing):
        * css/StyleBase.h:
        (WebCore::StyleBase::useStrictParsing):
        (WebCore::StyleBase::StyleBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-19 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 20 Nov 2008 04:46:11 +0000 (04:46 +0000)]
2008-11-19  Darin Fisher  <darin@chromium.org>

        Fix bustage.

        https://bugs.webkit.org/show_bug.cgi?id=22373
        Ports busted by addition of ScriptValue.{h,cpp}

        * Api/qwebframe.cpp:
        (QWebFrame::evaluateJavaScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-19 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 20 Nov 2008 03:31:08 +0000 (03:31 +0000)]
2008-11-19  Darin Fisher  <darin@chromium.org>

        Fix bustage.

        https://bugs.webkit.org/show_bug.cgi?id=22373
        Ports busted by addition of ScriptValue.{h,cpp}

        * Api/qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-19 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 20 Nov 2008 03:27:50 +0000 (03:27 +0000)]
2008-11-19  Darin Fisher  <darin@chromium.org>

        Fix bustage.

        https://bugs.webkit.org/show_bug.cgi?id=22373
        Ports busted by addition of ScriptValue.{h,cpp}

        * plugins/PluginView.cpp:
        (WebCore::PluginView::performRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-19 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 20 Nov 2008 03:19:28 +0000 (03:19 +0000)]
2008-11-19  Darin Fisher  <darin@chromium.org>

        Bustage fix.

        https://bugs.webkit.org/show_bug.cgi?id=22373
        Ports busted by addition of ScriptValue.{h,cpp}

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCoreSources.bkl:
        * dom/XMLTokenizerQt.cpp:
        * plugins/PluginView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Antti Koivisto
simon.fraser@apple.com [Thu, 20 Nov 2008 02:44:28 +0000 (02:44 +0000)]
    Reviewed by Antti Koivisto

        https://bugs.webkit.org/show_bug.cgi?id=22111

        Fix hit testing in controls on transformed video elements
        by replacing absoluteBoundingBoxRect().contains() with
        code that maps the point into local coords, taking
        transforms into account.

        Test: media/video-controls-transformed.html

        * platform/graphics/MediaPlayer.h:
        * rendering/RenderMedia.cpp:
        (WebCore::rendererContainsPoint):
        (WebCore::RenderMedia::forwardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit/mac:
andersca@apple.com [Thu, 20 Nov 2008 02:33:09 +0000 (02:33 +0000)]
WebKit/mac:

2008-11-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Test: plugins/netscape-plugin-setwindow-size-2.html

        Fix bug where NPP_SetWindow wasn't getting called for some plug-ins.

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView updateAndSetWindow]):
        Don't bail if the drawing model is not the CA drawing model. Remove some code
        that was doing the wrong thing.

LayoutTests:

2008-11-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Add NPP_SetWindow test.

        * plugins/netscape-plugin-setwindow-size-2-expected.txt: Added.
        * plugins/netscape-plugin-setwindow-size-2.html: Copied from plugins/netscape-plugin-setwindow-size.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 20 Nov 2008 02:05:41 +0000 (02:05 +0000)]
2008-11-18  Darin Fisher  <darin@chromium.org>

        Reviewed by Geoff Garen.

        https://bugs.webkit.org/show_bug.cgi?id=22345
        Define ScriptValue as a thin container for a JSC::Value*.

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/ScheduledAction.cpp:
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::evaluate):
        * bindings/js/ScriptController.h:
        * bindings/js/ScriptValue.cpp: Added.
        (WebCore::ScriptValue::getString):
        * bindings/js/ScriptValue.h: Added.
        (WebCore::ScriptValue::ScriptValue):
        (WebCore::ScriptValue::jsValue):
        * dom/ScriptElement.cpp:
        * dom/XMLTokenizer.cpp:
        * dom/XMLTokenizerLibxml2.cpp:
        * html/HTMLTokenizer.cpp:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::executeIfJavaScriptURL):
        (WebCore::FrameLoader::executeScript):
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-19 William Siegrist <wsiegrist@apple.com>
wsiegrist@apple.com [Thu, 20 Nov 2008 01:53:32 +0000 (01:53 +0000)]
2008-11-19 William Siegrist <wsiegrist@apple.com>

Reviewed by David Kilzer

Sync config changes made to bugzilla on the server

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-19 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Thu, 20 Nov 2008 01:33:05 +0000 (01:33 +0000)]
2008-11-19  Beth Dakin  <bdakin@apple.com>

        Reviewed by Justin Garcia.

        Fix for <rdar://problem/5472507> Remove color property when a user
        sets color to black

        This patch prevents us from inserting font nodes during the
        ApplyStyleCommand if they will not change the computed style of an
        element.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::fontColorChangesComputedStyle):
        (WebCore::fontSizeChangesComputedStyle):
        (WebCore::fontFaceChangesComputedStyle):
        (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-19 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 20 Nov 2008 01:30:20 +0000 (01:30 +0000)]
2008-11-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/6383762> WebKit r38340 crash on key press in plugin

        Set the value to 0 before calling NPP_GetValue, in case the plug-in returns NPERR_NO_ERROR but does not
        update the value.

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView createPlugin]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-19 Adele Peterson <adele@apple.com>
adele@apple.com [Thu, 20 Nov 2008 00:45:00 +0000 (00:45 +0000)]
2008-11-19  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        For transparent views, clear the dirty rect instead of painting it white.

        * WebView.cpp: (WebView::paintIntoBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-19 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 19 Nov 2008 22:11:55 +0000 (22:11 +0000)]
2008-11-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Make sure to copy the MIME type.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-19 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 19 Nov 2008 21:59:57 +0000 (21:59 +0000)]
2008-11-19  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        First step toward fixing <rdar://problem/6263293> WebScriptDebugDelegate
        should use intptr_t for sourceId, not int

        Added a conditional typedef (currently disabled) to switch sourceId to
        intptr_t in non-Tiger, non-Leopard builds.

        * DefaultDelegates/WebDefaultScriptDebugDelegate.m:
        (-[WebDefaultScriptDebugDelegate webView:didParseSource:fromURL:sourceId:forWebFrame:]):
        (-[WebDefaultScriptDebugDelegate webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
        (-[WebDefaultScriptDebugDelegate webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
        (-[WebDefaultScriptDebugDelegate webView:willExecuteStatement:sourceId:line:forWebFrame:]):
        (-[WebDefaultScriptDebugDelegate webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
        (-[WebDefaultScriptDebugDelegate webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
        * WebView/WebScriptDebugDelegate.h:
        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::sourceParsed):
        (WebScriptDebugger::callEvent):
        (WebScriptDebugger::atStatement):
        (WebScriptDebugger::returnEvent):
        (WebScriptDebugger::exception):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
ggaren@apple.com [Wed, 19 Nov 2008 21:08:40 +0000 (21:08 +0000)]
JavaScriptCore:

2008-11-19  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22361
        A little more RegExp refactoring.

        Consistently named variables holding the starting position at which
        regexp matching should begin to "startOffset".

        A few more "regExpObject" => "regExpConstructor" changes.

        Refactored RegExpObject::match for clarity, and replaced a slow "get"
        of the "global" property with a fast access to the global bit.

        Made the error message you see when RegExpObject::match has no input a
        little more informative, as in Firefox.

        * runtime/RegExp.cpp:
        (JSC::RegExp::match):
        * runtime/RegExp.h:
        * runtime/RegExpObject.cpp:
        (JSC::RegExpObject::match):
        * runtime/StringPrototype.cpp:
        (JSC::stringProtoFuncReplace):
        (JSC::stringProtoFuncMatch):
        (JSC::stringProtoFuncSearch):

LayoutTests:

2008-11-19  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Test for https://bugs.webkit.org/show_bug.cgi?id=22361
        A little more RegExp refactoring

        * fast/js/regexp-test-null-string.html: Added.
        * fast/js/regexp-test-null-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-19 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 19 Nov 2008 21:07:15 +0000 (21:07 +0000)]
2008-11-19  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=22348

        Need to educate style sharing about autofill, so that style does not
        get shared between input elements that are autofilled, and those
        that are not. Setting autofill should also do a setChanged on the node.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::canShareStyleWithElement):
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
        * dom/Node.h:
        (WebCore::Node::isAutofilled):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setAutofilled):
        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::isAutofilled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Antti Koivisto.
brettw@chromium.org [Wed, 19 Nov 2008 20:44:37 +0000 (20:44 +0000)]
Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=22349

Clear the subresource loader client when the client is removed in
response to a 304 (not modified). This prevents an inconsistent state
where the loader thinks it's active and the loader::Host doesn't.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-19 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 19 Nov 2008 19:16:30 +0000 (19:16 +0000)]
2008-11-19  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        A little more refactoring.

        Removed the "emit" and "emitUnlinked" prefixes from the assembler.

        Moved the JmpSrc and JmpDst class definitions to the top of the X86
        assembler class, in accordance with WebKit style guidelines.

        * assembler/X86Assembler.h:
        (JSC::X86Assembler::JmpSrc::JmpSrc):
        (JSC::X86Assembler::JmpDst::JmpDst):
        (JSC::X86Assembler::int3):
        (JSC::X86Assembler::pushl_m):
        (JSC::X86Assembler::popl_m):
        (JSC::X86Assembler::movl_rr):
        (JSC::X86Assembler::addl_rr):
        (JSC::X86Assembler::addl_i8r):
        (JSC::X86Assembler::addl_i8m):
        (JSC::X86Assembler::addl_i32r):
        (JSC::X86Assembler::addl_mr):
        (JSC::X86Assembler::andl_rr):
        (JSC::X86Assembler::andl_i32r):
        (JSC::X86Assembler::cmpl_i8r):
        (JSC::X86Assembler::cmpl_rr):
        (JSC::X86Assembler::cmpl_rm):
        (JSC::X86Assembler::cmpl_mr):
        (JSC::X86Assembler::cmpl_i32r):
        (JSC::X86Assembler::cmpl_i32m):
        (JSC::X86Assembler::cmpl_i8m):
        (JSC::X86Assembler::cmpw_rm):
        (JSC::X86Assembler::orl_rr):
        (JSC::X86Assembler::orl_mr):
        (JSC::X86Assembler::orl_i32r):
        (JSC::X86Assembler::subl_rr):
        (JSC::X86Assembler::subl_i8r):
        (JSC::X86Assembler::subl_i8m):
        (JSC::X86Assembler::subl_i32r):
        (JSC::X86Assembler::subl_mr):
        (JSC::X86Assembler::testl_i32r):
        (JSC::X86Assembler::testl_i32m):
        (JSC::X86Assembler::testl_rr):
        (JSC::X86Assembler::xorl_i8r):
        (JSC::X86Assembler::xorl_rr):
        (JSC::X86Assembler::sarl_i8r):
        (JSC::X86Assembler::sarl_CLr):
        (JSC::X86Assembler::shl_i8r):
        (JSC::X86Assembler::shll_CLr):
        (JSC::X86Assembler::imull_rr):
        (JSC::X86Assembler::imull_i32r):
        (JSC::X86Assembler::idivl_r):
        (JSC::X86Assembler::negl_r):
        (JSC::X86Assembler::movl_mr):
        (JSC::X86Assembler::movzbl_rr):
        (JSC::X86Assembler::movzwl_mr):
        (JSC::X86Assembler::movl_rm):
        (JSC::X86Assembler::movl_i32r):
        (JSC::X86Assembler::movl_i32m):
        (JSC::X86Assembler::leal_mr):
        (JSC::X86Assembler::jmp_r):
        (JSC::X86Assembler::jmp_m):
        (JSC::X86Assembler::movsd_mr):
        (JSC::X86Assembler::xorpd_mr):
        (JSC::X86Assembler::movsd_rm):
        (JSC::X86Assembler::movd_rr):
        (JSC::X86Assembler::cvtsi2sd_rr):
        (JSC::X86Assembler::cvttsd2si_rr):
        (JSC::X86Assembler::addsd_mr):
        (JSC::X86Assembler::subsd_mr):
        (JSC::X86Assembler::mulsd_mr):
        (JSC::X86Assembler::addsd_rr):
        (JSC::X86Assembler::subsd_rr):
        (JSC::X86Assembler::mulsd_rr):
        (JSC::X86Assembler::ucomis_rr):
        (JSC::X86Assembler::pextrw_irr):
        (JSC::X86Assembler::call):
        (JSC::X86Assembler::jmp):
        (JSC::X86Assembler::jne):
        (JSC::X86Assembler::jnz):
        (JSC::X86Assembler::je):
        (JSC::X86Assembler::jl):
        (JSC::X86Assembler::jb):
        (JSC::X86Assembler::jle):
        (JSC::X86Assembler::jbe):
        (JSC::X86Assembler::jge):
        (JSC::X86Assembler::jg):
        (JSC::X86Assembler::ja):
        (JSC::X86Assembler::jae):
        (JSC::X86Assembler::jo):
        (JSC::X86Assembler::jp):
        (JSC::X86Assembler::js):
        (JSC::X86Assembler::predictNotTaken):
        (JSC::X86Assembler::convertToFastCall):
        (JSC::X86Assembler::restoreArgumentReference):
        (JSC::X86Assembler::restoreArgumentReferenceForTrampoline):
        (JSC::X86Assembler::modRm_rr):
        (JSC::X86Assembler::modRm_rr_Unchecked):
        (JSC::X86Assembler::modRm_rm):
        (JSC::X86Assembler::modRm_rm_Unchecked):
        (JSC::X86Assembler::modRm_rmsib):
        (JSC::X86Assembler::modRm_opr):
        (JSC::X86Assembler::modRm_opr_Unchecked):
        (JSC::X86Assembler::modRm_opm):
        (JSC::X86Assembler::modRm_opm_Unchecked):
        (JSC::X86Assembler::modRm_opmsib):
        * jit/JIT.cpp:
        (JSC::JIT::emitNakedCall):
        (JSC::JIT::emitNakedFastCall):
        (JSC::JIT::emitCTICall):
        (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
        (JSC::JIT::emitJumpSlowCaseIfNotImmNum):
        (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
        (JSC::JIT::emitFastArithIntToImmOrSlowCase):
        (JSC::JIT::emitArithIntToImmWithJump):
        (JSC::JIT::compileOpCall):
        (JSC::JIT::compileOpStrictEq):
        (JSC::JIT::emitSlowScriptCheck):
        (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate):
        (JSC::JIT::compileBinaryArithOp):
        (JSC::JIT::privateCompileMainPass):
        (JSC::JIT::privateCompileSlowCases):
        (JSC::JIT::privateCompile):
        (JSC::JIT::privateCompileGetByIdSelf):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdChain):
        (JSC::JIT::privateCompilePutByIdReplace):
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::privateCompileCTIMachineTrampolines):
        (JSC::JIT::privateCompilePatchGetArrayLength):
        * wrec/WREC.cpp:
        (JSC::WREC::compileRegExp):
        * wrec/WRECGenerator.cpp:
        (JSC::WREC::Generator::generateBackreferenceQuantifier):
        (JSC::WREC::Generator::generateNonGreedyQuantifier):
        (JSC::WREC::Generator::generateGreedyQuantifier):
        (JSC::WREC::Generator::generatePatternCharacter):
        (JSC::WREC::Generator::generateCharacterClassInvertedRange):
        (JSC::WREC::Generator::generateCharacterClassInverted):
        (JSC::WREC::Generator::generateCharacterClass):
        (JSC::WREC::Generator::generateParentheses):
        (JSC::WREC::Generator::generateParenthesesNonGreedy):
        (JSC::WREC::Generator::generateParenthesesResetTrampoline):
        (JSC::WREC::Generator::generateAssertionBOL):
        (JSC::WREC::Generator::generateAssertionEOL):
        (JSC::WREC::Generator::generateAssertionWordBoundary):
        (JSC::WREC::Generator::generateBackreference):
        (JSC::WREC::Generator::generateDisjunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Wed, 19 Nov 2008 18:28:57 +0000 (18:28 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22355
        Systematize code for replacing global constructors

        Test: fast/workers/worker-replace-global-constructor.html

        * bindings/js/JSDOMWindowBase.cpp:
        (setJSDOMWindowBaseEvent): Changed to put the value as property, matching what generated
        code for global constructor setters does.
        (setJSDOMWindowBaseAudio): Ditto.
        (setJSDOMWindowBaseImage): Ditto.
        (setJSDOMWindowBaseMessageChannel): Ditto.
        (setJSDOMWindowBaseOption): Ditto.
        (setJSDOMWindowBaseWorker): Ditto.
        (setJSDOMWindowBaseXMLHttpRequest): Ditto.
        (setJSDOMWindowBaseXSLTProcessor): Ditto.
        (WebCore::JSDOMWindowBase::put): Removed special cases for global constructors.

        * bindings/js/JSWorkerContext.cpp:
        (WebCore::JSWorkerContext::getOwnPropertySlot): Look up overrides before own properties,
        as it is done for Window.
        (WebCore::setJSWorkerContextMessageEvent): Implemented in the same way as Window global
        constructors are.
        (WebCore::setJSWorkerContextWorkerLocation): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-19 Greg Bolsinga <bolsinga@apple.com>
bolsinga@apple.com [Wed, 19 Nov 2008 18:09:47 +0000 (18:09 +0000)]
2008-11-19  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=21810
        Remove use of static C++ objects that are destroyed at exit time (destructors)

        All static C++ objects that create atexit calls are gone. Update script
        to indicate how to fix the problem should a new one appear.

        * Scripts/check-for-exit-time-destructors:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Wed, 19 Nov 2008 17:57:58 +0000 (17:57 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22341
        Text codecs should not use static data without locking

        * platform/text/TextCodecICU.cpp:
        * platform/text/mac/TextCodecMac.cpp:
        Made cached converters per-thread.

        * platform/text/TextEncodingRegistry.cpp:
        (WebCore::encodingRegistryMutex): Added a mutex for codec maps access.
        (WebCore::addToTextCodecMap): Don't use TextEncoding just to cacnonicalize the name, as it
        causes a dedalock due to a recursive call into registry.
        (WebCore::buildBaseTextCodecMaps): Added assertions.
        (WebCore::newTextCodec): Take a lock to avoid concurrent access to codec maps.
        (WebCore::atomicCanonicalTextEncodingName): Ditto.
        (WebCore::noExtendedTextEncodingNameUsed): Added a comment, explaining why locking is not
        necessary here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Touch WebCorePrefix.h to force a rebuild, needed because of changed feature...
ap@webkit.org [Wed, 19 Nov 2008 17:57:00 +0000 (17:57 +0000)]
    Touch WebCorePrefix.h to force a rebuild, needed because of changed feature defines.

        * WebCorePrefix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Wed, 19 Nov 2008 17:42:39 +0000 (17:42 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22310
        Worker exceptions should be printed to console

        * dom/Document.cpp: (WebCore::Document::reportException):
        * dom/Document.h:
        * dom/ScriptExecutionContext.h:
        * dom/WorkerContext.cpp: (WebCore::WorkerContext::reportException):
        * dom/WorkerContext.h:
        Added a reportException() method on ScriptExecutionContext. It forwards the exception info
        up until it finds a Document context, and then it prints it to console.

        * bindings/js/JSEventListener.cpp:
        (WebCore::JSAbstractEventListener::handleEvent): Don't talk to Console directly, use
        ScriptExecutionContext::reportException. Also, fixed a bug where Document::updateDocumentsRendering()
        could be called from workers.
        (WebCore::JSLazyEventListener::parseCode): Moved variable declaration inside if block for clarity.

        * bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
        Report exceptions to ScriptExecutionContext.

        * dom/WorkerMessagingProxy.cpp:
        (WebCore::MessageWorkerTask::performTask):
        (WebCore::WorkerExceptionTask::create):
        (WebCore::WorkerExceptionTask::WorkerExceptionTask):
        (WebCore::WorkerExceptionTask::performTask):
        (WebCore::WorkerMessagingProxy::postWorkerException):
        * dom/WorkerMessagingProxy.h:
        Added a task for posting exception information.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::reportException):
        (WebCore::reportCurrentException):
        * bindings/js/JSDOMBinding.h:
        Added helper methods for reporting exceptions via ScriptExecutionContext.

        * page/Console.cpp:
        * page/Console.h:
        Removed methods for directly reporting exceptions to console.

        * bindings/js/JSCustomPositionCallback.cpp:
        (WebCore::JSCustomPositionCallback::handleEvent):
        * bindings/js/JSCustomPositionErrorCallback.cpp:
        (WebCore::JSCustomPositionErrorCallback::handleEvent):
        * bindings/js/JSCustomSQLStatementCallback.cpp:
        (WebCore::JSCustomSQLStatementCallback::handleEvent):
        * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
        (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
        * bindings/js/JSCustomSQLTransactionCallback.cpp:
        (WebCore::JSCustomSQLTransactionCallback::handleEvent):
        * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
        (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
        * bindings/js/JSCustomVoidCallback.cpp:
        (WebCore::JSCustomVoidCallback::handleEvent):
        * bindings/js/JSCustomXPathNSResolver.cpp:
        (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::execute):
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::evaluate):
        * bindings/objc/WebScriptObject.mm:
        (WebCore::addExceptionToConsole):
        Switch to JSDOMBinding methods for reporting exceptions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-19 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Wed, 19 Nov 2008 16:19:30 +0000 (16:19 +0000)]
2008-11-19  Simon Hausmann  <hausmann@webkit.org>

        Sun CC build fix, removed trailing comman for last enum value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-19 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Wed, 19 Nov 2008 12:17:12 +0000 (12:17 +0000)]
2008-11-19  Simon Hausmann  <hausmann@webkit.org>

        Fix the Qt build, remove file referenced in the qrc file that does not
        exist and is not needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoExpand the workaround for Apple GCC compiler bug <rdar://problem/6354696> to all...
mrowe@apple.com [Wed, 19 Nov 2008 09:06:05 +0000 (09:06 +0000)]
Expand the workaround for Apple GCC compiler bug <rdar://problem/6354696> to all versions of GCC 4.0.1.
It has been observed with builds 5465 (Xcode 3.0) and 5484 (Xcode 3.1), and there is no evidence
that it has been fixed in newer builds of GCC 4.0.1.

This addresses <https://bugs.webkit.org/show_bug.cgi?id=22351> (WebKit nightly crashes on launch on 10.4.11).

Reviewed by Alexey Proskuryakov.

* wtf/StdLibExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark Rowe.
mitz@apple.com [Wed, 19 Nov 2008 07:51:47 +0000 (07:51 +0000)]
    Reviewed by Mark Rowe.

        - WebCore part of https://bugs.webkit.org/show_bug.cgi?id=22331
          <rdar://problem/6381657> REGRESSION: Contextual menu no longer has an "Inspect Element" item

        * platform/ContextMenuItem.h:
        (WebCore::ContextMenuAction): Reorder this enum to keep it in sync with
        the one in WebUIDelegate.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Wed, 19 Nov 2008 04:04:01 +0000 (04:04 +0000)]
2008-11-18  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Maciej Stachowiak and Geoff Garen.

        Bug 22287: ASSERTION FAILED: Not enough jumps linked in slow case codegen in CTI::privateCompileSlowCases())
        <https://bugs.webkit.org/show_bug.cgi?id=22287>

        Fix a typo in the number cell reuse code where the first and second
        operands are sometimes confused.

        JavaScriptcore:

        * jit/JIT.cpp:
        (JSC::JIT::compileBinaryArithOpSlowCase):

        LayoutTests:

        * fast/js/number-cell-reuse-expected.txt: Added.
        * fast/js/number-cell-reuse.html: Added.
        * fast/js/resources/number-cell-reuse.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Dimitri Glazkov <dglazkov@chromium.org>
darin@chromium.org [Wed, 19 Nov 2008 01:58:39 +0000 (01:58 +0000)]
2008-11-18  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22346
        PlatformString should also include HashSet.h for non-JSC builds

        * platform/text/PlatformString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Adele Peterson <adele@apple.com>
adele@apple.com [Wed, 19 Nov 2008 01:22:59 +0000 (01:22 +0000)]
2008-11-18  Adele Peterson  <adele@apple.com>

        Reverting last change.  I just realized it causes the view to never get cleared out.

        * WebView.cpp: (WebView::paintIntoBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Adele Peterson <adele@apple.com>
adele@apple.com [Wed, 19 Nov 2008 01:11:01 +0000 (01:11 +0000)]
2008-11-18  Adele Peterson  <adele@apple.com>

        Reviewed by John Sullivan.

        Don't fill the view with white if its transparent.

        * WebView.cpp: (WebView::paintIntoBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark Rowe.
mitz@apple.com [Wed, 19 Nov 2008 00:57:06 +0000 (00:57 +0000)]
    Reviewed by Mark Rowe.

        - fix https://bugs.webkit.org/show_bug.cgi?id=22331
          <rdar://problem/6381657> REGRESSION: Contextual menu no longer has an "Inspect Element" item

        * WebView/WebUIDelegatePrivate.h: Reorder new enum values after existing
        ones.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Wed, 19 Nov 2008 00:46:04 +0000 (00:46 +0000)]
2008-11-18  Holger Hans Peter Freyther  <zecke@selfish.org>

        Rubber-stamped by Mark Rowe.

        Skip some more tests to make the Gtk+ build bot pass. We will
        have to investigate why some tests only fail on the build bot.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Adele Peterson <adele@apple.com>
adele@apple.com [Wed, 19 Nov 2008 00:25:41 +0000 (00:25 +0000)]
2008-11-18  Adele Peterson  <adele@apple.com>

        Reviewed by Holger Hans Peter Freyther.

        Flip check added in recent refactoring so the background gets updated when the background color is valid, not invalid.

        * loader/FrameLoaderClient.cpp: (WebCore::FrameLoaderClient::transitionToCommittedForNewPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 19 Nov 2008 00:05:34 +0000 (00:05 +0000)]
2008-11-18  Sam Weinig  <sam@webkit.org>

        Fix incorrect result.

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReverting r38574 since it caused some layout test failures.
darin@chromium.org [Tue, 18 Nov 2008 23:52:28 +0000 (23:52 +0000)]
Reverting r38574 since it caused some layout test failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed. Checked in wrong result in last commit.
zimmermann@webkit.org [Tue, 18 Nov 2008 23:51:18 +0000 (23:51 +0000)]
Not reviewed. Checked in wrong result in last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Dimitri Glazkov <dglazkov@chromium.org>
darin@chromium.org [Tue, 18 Nov 2008 23:39:00 +0000 (23:39 +0000)]
2008-11-18  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=22343
        Remove unused runtime/Collector, JSLock includes in Page.cpp

        * page/Page.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Bug 22344: Make select popup window opaque
adachan@apple.com [Tue, 18 Nov 2008 23:30:12 +0000 (23:30 +0000)]
    Bug 22344: Make select popup window opaque
        https://bugs.webkit.org/show_bug.cgi?id=22344

        Reviewed by Steve Falkenburg.

        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Dimitri Glazkov <dglazkov@chromium.org>
darin@chromium.org [Tue, 18 Nov 2008 23:16:59 +0000 (23:16 +0000)]
2008-11-18  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=22342
        Remove unused JSLock.h include

        * dom/Document.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Sam Weinig.
zimmermann@webkit.org [Tue, 18 Nov 2008 22:15:33 +0000 (22:15 +0000)]
Reviewed by Sam Weinig.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=22334

Add WMLBRElement, correcting <br/> behaviour in WML.
Enable entity replacment for WML documents.
Handle WML specific <p> 'mode' attribute.

Generate layout tests results for fast/wml.

Tests cases that pass now:
fast/wml/br-element-in-table.wml
fast/wml/br-element-in-text.wml
fast/wml/case-sensitivity.wml
fast/wml/cdata-section.wml
fast/wml/comment.wml
fast/wml/entity.wml
fast/wml/p-align.wml
fast/wml/p-mode.wml
fast/wml/text-emphasis.wml
fast/wml/validate-dtd.wml

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - try to fix the Windows build
mitz@apple.com [Tue, 18 Nov 2008 22:04:27 +0000 (22:04 +0000)]
    - try to fix the Windows build

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 18 Nov 2008 21:52:48 +0000 (21:52 +0000)]
2008-11-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Minor RegExp cleanup.

        SunSpider says no change.

        * runtime/RegExpObject.cpp:
        (JSC::RegExpObject::match): Renamed "regExpObj" to "regExpConstructor".

        * wrec/WREC.cpp:
        (JSC::WREC::compileRegExp): Instead of checking for a NULL output vector,
        ASSERT that the output vector is not NULL. (The rest of WREC is not
        safe to use with a NULL output vector, and we probably don't want to
        spend the time and/or performance to make it safe.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Aaron Boodman aa@chromium.org
darin@chromium.org [Tue, 18 Nov 2008 21:21:52 +0000 (21:21 +0000)]
2008-11-18  Aaron Boodman  aa@chromium.org

        Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=22301
        Always call dispatchDidFinishDocumentLoad before Window's onload event.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::finishedParsing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 18 Nov 2008 20:38:55 +0000 (20:38 +0000)]
2008-11-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Alexey Proskuryakov.

        Updated layout test result for addition of window.Worker.

        * fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 18 Nov 2008 20:07:45 +0000 (20:07 +0000)]
2008-11-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        A little more renaming and refactoring.

        VM_CHECK_EXCEPTION() => CHECK_FOR_EXCEPTION().
        NEXT_INSTRUCTION => NEXT_INSTRUCTION().

        Removed the "Error_" and "TempError_" prefixes from WREC error types.

        Refactored the WREC parser so it doesn't need a "setError" function,
        and changed "isEndOfPattern" and its use -- they read kind of backwards
        before.

        Changed our "TODO:" error messages at least to say something, since you
        can't say "TODO:" in shipping software.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute):
        (JSC::Interpreter::cti_op_convert_this):
        (JSC::Interpreter::cti_op_add):
        (JSC::Interpreter::cti_op_pre_inc):
        (JSC::Interpreter::cti_op_loop_if_less):
        (JSC::Interpreter::cti_op_loop_if_lesseq):
        (JSC::Interpreter::cti_op_put_by_id):
        (JSC::Interpreter::cti_op_put_by_id_second):
        (JSC::Interpreter::cti_op_put_by_id_generic):
        (JSC::Interpreter::cti_op_put_by_id_fail):
        (JSC::Interpreter::cti_op_get_by_id):
        (JSC::Interpreter::cti_op_get_by_id_second):
        (JSC::Interpreter::cti_op_get_by_id_generic):
        (JSC::Interpreter::cti_op_get_by_id_fail):
        (JSC::Interpreter::cti_op_instanceof):
        (JSC::Interpreter::cti_op_del_by_id):
        (JSC::Interpreter::cti_op_mul):
        (JSC::Interpreter::cti_op_call_NotJSFunction):
        (JSC::Interpreter::cti_op_resolve):
        (JSC::Interpreter::cti_op_construct_NotJSConstruct):
        (JSC::Interpreter::cti_op_get_by_val):
        (JSC::Interpreter::cti_op_resolve_func):
        (JSC::Interpreter::cti_op_sub):
        (JSC::Interpreter::cti_op_put_by_val):
        (JSC::Interpreter::cti_op_put_by_val_array):
        (JSC::Interpreter::cti_op_lesseq):
        (JSC::Interpreter::cti_op_loop_if_true):
        (JSC::Interpreter::cti_op_negate):
        (JSC::Interpreter::cti_op_resolve_skip):
        (JSC::Interpreter::cti_op_resolve_global):
        (JSC::Interpreter::cti_op_div):
        (JSC::Interpreter::cti_op_pre_dec):
        (JSC::Interpreter::cti_op_jless):
        (JSC::Interpreter::cti_op_not):
        (JSC::Interpreter::cti_op_jtrue):
        (JSC::Interpreter::cti_op_post_inc):
        (JSC::Interpreter::cti_op_eq):
        (JSC::Interpreter::cti_op_lshift):
        (JSC::Interpreter::cti_op_bitand):
        (JSC::Interpreter::cti_op_rshift):
        (JSC::Interpreter::cti_op_bitnot):
        (JSC::Interpreter::cti_op_resolve_with_base):
        (JSC::Interpreter::cti_op_mod):
        (JSC::Interpreter::cti_op_less):
        (JSC::Interpreter::cti_op_neq):
        (JSC::Interpreter::cti_op_post_dec):
        (JSC::Interpreter::cti_op_urshift):
        (JSC::Interpreter::cti_op_bitxor):
        (JSC::Interpreter::cti_op_bitor):
        (JSC::Interpreter::cti_op_push_scope):
        (JSC::Interpreter::cti_op_to_jsnumber):
        (JSC::Interpreter::cti_op_in):
        (JSC::Interpreter::cti_op_del_by_val):
        * wrec/WREC.cpp:
        (JSC::WREC::compileRegExp):
        * wrec/WRECParser.cpp:
        (JSC::WREC::Parser::parseGreedyQuantifier):
        (JSC::WREC::Parser::parseParentheses):
        (JSC::WREC::Parser::parseCharacterClass):
        (JSC::WREC::Parser::parseEscape):
        * wrec/WRECParser.h:
        (JSC::WREC::Parser::):
        (JSC::WREC::Parser::atEndOfPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-17 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Tue, 18 Nov 2008 19:58:33 +0000 (19:58 +0000)]
2008-11-17  Beth Dakin  <bdakin@apple.com>

        Reviewed by Adele Peterson.

        Fix for <rdar://problem/6373102> REGRESSION (r36919): In a new mail
        message, the caret appears in message body by default

        This fixes a regression caused by http://trac.webkit.org/changeset/36919.
        That change was too sweeping; we do not want to
        unconditionally set the page to be active, but we can be looser
        than the original constraints. This patch set the window active if
        the first responder is or is a descendant of the main frame's frame
        view.

        * WebView/WebView.mm:
        (-[WebView _updateFocusedAndActiveStateForFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-17 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Tue, 18 Nov 2008 19:57:33 +0000 (19:57 +0000)]
2008-11-17  Beth Dakin  <bdakin@apple.com>

        Reviewed by Adele Peterson.

        Fix for <rdar://problem/6373102> REGRESSION (r36919): In a new mail
        message, the caret appears in message body by default

        This fixes a regression caused by http://trac.webkit.org/changeset/
        36919. That change was too sweeping; we do not want to
        unconditionally set the page to be active, but we can be looser
        than the original constraints. This patch set the window active if
        the first responder is or is a descendant of the main frame's frame
        view.

        * WebView/WebView.mm:
        (-[WebView _updateFocusedAndActiveStateForFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix.
ap@webkit.org [Tue, 18 Nov 2008 19:23:27 +0000 (19:23 +0000)]
    Windows build fix.

        * WebCore.vcproj/WebCore.vcproj: Fix relative paths to use $(WebKitOutputDir).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 18 Nov 2008 18:26:08 +0000 (18:26 +0000)]
2008-11-18  Darin Adler  <darin@apple.com>

        - try to fix Wx build

        * WebCoreSources.bkl: Added FrameLoaderClient.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Tue, 18 Nov 2008 18:25:29 +0000 (18:25 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22337
        Enable workers by default

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin@apple.com [Tue, 18 Nov 2008 18:23:02 +0000 (18:23 +0000)]
WebCore:

2008-11-18  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        - first cut at https://bugs.webkit.org/show_bug.cgi?id=10957
          <rdar://problem/5516594> please add support for HTTP-only cookies

        Test: http/tests/xmlhttprequest/get-dangerous-headers.html

        No test for HTTP-only support in JavaScript yet, since the Mac and Win changes
        require an updated CFNetwork.

        * platform/mac/CookieJar.mm:
        (WebCore::isHTTPOnly): Added.
        (WebCore::filterCookies): Added.
        (WebCore::cookies): Use filterCookies to prevent getting HTTP-only cookies.
        (WebCore::setCookies): Use filterCookies to prevent setting HTTP-only cookies.

        * platform/network/win/CookieJarCFNetWin.cpp:
        (WebCore::isHTTPOnly): Added.
        (WebCore::filterCookies): Added.
        (WebCore::setCookies): Use filterCookies to prevent getting HTTP-only cookies.
        (WebCore::cookies): Use filterCookies to prevent getting HTTP-only cookies.

        * xml/XMLHttpRequest.cpp:
        (WebCore::isSetCookieHeader): Added.
        (WebCore::XMLHttpRequest::getAllResponseHeaders): Hide Set-Cookie headers from
        clients that don't have local-resource privileges.
        (WebCore::XMLHttpRequest::getResponseHeader): Ditto.

        - clean soup-specific details out of shared cookie jar header

        * platform/CookieJar.h: Removed the soup-specific parts of this.
        * platform/network/soup/CookieJarSoup.cpp: Changed to include
        CookieJarSoup.h. Tweaked implementation a bit to handle UTF-8 better.
        * platform/network/soup/CookieJarSoup.h: Added. Has the Soup-specified
        part of CookieJar.h.
        * platform/network/soup/ResourceHandleSoup.cpp: Changed to include
        CookieJarSoup.h.

LayoutTests:

2008-11-18  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        - add a test for XMLHttpRequest Set-Cookie blocking

        * http/tests/xmlhttprequest/access-control-basic-whitelist-response-headers-expected.txt:
        Updated since we now log attempts to get headers that are not allowed cross-domain to the console.
        * http/tests/xmlhttprequest/get-dangerous-headers-expected.txt: Added.
        * http/tests/xmlhttprequest/get-dangerous-headers.html: Added.
        * http/tests/xmlhttprequest/resources/get-set-cookie.cgi: Tweak script a bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Tue, 18 Nov 2008 17:59:54 +0000 (17:59 +0000)]
2008-11-18  Steve Falkenburg  <sfalken@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=22329
        Improper bitwise and tests against 0 in Windows context menu code

        Reviewed by John Sullivan.

        * platform/win/ContextMenuItemWin.cpp:
        (WebCore::ContextMenuItem::type):
        (WebCore::ContextMenuItem::enabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Tue, 18 Nov 2008 17:32:35 +0000 (17:32 +0000)]
2008-11-18  John Sullivan  <sullivan@apple.com>

        Yet more Mac build fixing

        * WebCore.base.exp: Export __ZTVN7WebCore17FrameLoaderClientE

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Ariya Hidayat <ariya.hidayat@trolltech.com>
vestbo@webkit.org [Tue, 18 Nov 2008 16:19:43 +0000 (16:19 +0000)]
2008-11-18  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Tor Arne Vestbø.

        Missing file in new unit test for QWebFrame (r38493).

        * tests/qwebframe/qwebframe.pro:
        * tests/qwebframe/qwebframe.qrc: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Tor Arne Vestbø <tavestbo@trolltech.com>
vestbo@webkit.org [Tue, 18 Nov 2008 16:09:19 +0000 (16:09 +0000)]
2008-11-18  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Rubber-stamped by Simon Hausmann.

        Make sure QWidget based plugins are invisible until placed into the layout

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - Windows build fix
ap@webkit.org [Tue, 18 Nov 2008 14:43:49 +0000 (14:43 +0000)]
    - Windows build fix

        * wrec/WRECFunctors.h:
        * wrec/WRECGenerator.h:
        * wrec/WRECParser.h:
        CharacterClass is a struct, not a class, fix forward declarations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Tor Arne Vestbø <tavestbo@trolltech.com>
vestbo@webkit.org [Tue, 18 Nov 2008 14:41:42 +0000 (14:41 +0000)]
2008-11-18  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon Hausmann.

        React properly to frame rect changes for QWidget based plugins

        We now set the geometry of the QWidget in frameRectsChanged,
        intead of setFrameRect, which means we pick up the changes to
        the frame rect when scrolling. We also set a mask on the
        widget to keep it from painting over scrollbars and the like

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Tor Arne Vestbø <tavestbo@trolltech.com>
vestbo@webkit.org [Tue, 18 Nov 2008 14:41:18 +0000 (14:41 +0000)]
2008-11-18  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Rubber-stamped by Simon Hausmann.

        Don't mark scrollbars as focused in QtWebKit

        When initing from the widget we also got the focus state,
        but this does not make sense for scrollbars.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTry to fix the Windows build.
zecke@webkit.org [Tue, 18 Nov 2008 14:30:40 +0000 (14:30 +0000)]
Try to fix the Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago More Mac build fixing.
ap@webkit.org [Tue, 18 Nov 2008 13:46:59 +0000 (13:46 +0000)]
    More Mac build fixing.

        * WebCore.base.exp: Export FrameLoaderClient destructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Mac build fix.
ap@webkit.org [Tue, 18 Nov 2008 12:53:14 +0000 (12:53 +0000)]
    Mac build fix.

        * WebCore.xcodeproj/project.pbxproj: Add FrameLoaderClient.cpp for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Ariya Hidayat <ariya.hidayat@trolltech.com>
vestbo@webkit.org [Tue, 18 Nov 2008 12:37:48 +0000 (12:37 +0000)]
2008-11-18  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Tor Arne Vestbø.

        Fix crash when trying to pick a file using the file chooser.

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::runOpenPanel):

2008-11-17  Geoffrey Garen  <ggaren@apple.com>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAttempt to share transitionToCommittedForNewPage of FrameLoaderClient with the differ...
zecke@webkit.org [Tue, 18 Nov 2008 12:33:24 +0000 (12:33 +0000)]
Attempt to share transitionToCommittedForNewPage of FrameLoaderClient with the different ports

    https://bugs.webkit.org/show_bug.cgi?id=22056

    After Hyatt's work on Widget and ScrollView there is little difference
    between the implementation of Qt, Gtk+ and Win. In fact any kind of
    difference is mostly a bug. Alp has fixed two of such errors for the Gtk+
    port and the Qt port has at least one of them left.

    The only difference between the implementations is in getting the the
    IntSize for the new FrameView, the background color to be applied and
    eventually some post processing.

    Unify the implementations by providing a static helper function that
    takes a Frame, IntSize, color and transparency bit and calling it from
    the Gtk+, the Qt and the Windows port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMove setting the background color and transparency to WebCore
zecke@webkit.org [Tue, 18 Nov 2008 12:32:49 +0000 (12:32 +0000)]
Move setting the background color and transparency to WebCore

    Move setting the background color and transparency from WebKit/win
    to WebCore. This allows WebKit/win, WebKit/Qt and WebKit/Gtk+
    to share this code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-17 Ariya Hidayat <ariya.hidayat@trolltech.com>
vestbo@webkit.org [Tue, 18 Nov 2008 11:36:23 +0000 (11:36 +0000)]
2008-11-17  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Tor Arne Vestbø.

        Fix the bug where select elements are painted without border.
        http://trolltech.com/developer/task-tracker/index_html?id=218957&method=entry

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::paintMenuList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-18 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Tue, 18 Nov 2008 10:06:21 +0000 (10:06 +0000)]
2008-11-18  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix. Not reviewed.

        * GNUmakefile.am: Fix USER_AGENT_STYLESHEETS, wml.css is in css/,
        not in wml/.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Darin Adler.
ap@webkit.org [Tue, 18 Nov 2008 08:53:12 +0000 (08:53 +0000)]
    Rubber-stamped by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22306
        Disable channel messaging support

        * Scripts/build-webkit: Add an option to enable channel messaging.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Tue, 18 Nov 2008 08:44:40 +0000 (08:44 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22308
        Improve Worker GC behavior

        * dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::hasPendingActivity):
        * dom/ActiveDOMObject.h:
        Made hasPendingActivity() virtual, letting Worker add behavior to it.

        * bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
        * dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread):
        Tell message proxy whether there are active objects in the worker whenever JS execution
        finishes.

        * dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::activeDOMObjects):
        Added a typedef for activeDOMObjects() return type, necessary to declare iterators.

        * dom/Worker.h:
        * dom/Worker.cpp: (WebCore::Worker::hasPendingActivity): A Worker is active if it is still
        loading, or if it has unconfirmed messages, or it the worker thread has pending activity.

        * dom/WorkerContext.h:
        * dom/WorkerContext.cpp: (WebCore::WorkerContext::hasPendingActivity): Check all registered
        active objects for pending activity.

        * dom/WorkerMessagingProxy.cpp:
        (WebCore::MessageWorkerContextTask::performTask):
        (WebCore::WorkerThreadActivityReportTask::create):
        (WebCore::WorkerThreadActivityReportTask::WorkerThreadActivityReportTask):
        (WebCore::WorkerThreadActivityReportTask::performTask):
        (WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
        (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
        (WebCore::WorkerMessagingProxy::workerObjectDestroyed):
        (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal):
        (WebCore::WorkerMessagingProxy::confirmWorkerThreadMessage):
        (WebCore::WorkerMessagingProxy::reportWorkerThreadActivity):
        (WebCore::WorkerMessagingProxy::reportWorkerThreadActivityInternal):
        (WebCore::WorkerMessagingProxy::workerThreadHasPendingActivity):
        * dom/WorkerMessagingProxy.h:
        Track outstanding messages, and activity reported by worker thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - Windows build fix
mitz@apple.com [Tue, 18 Nov 2008 08:25:47 +0000 (08:25 +0000)]
    - Windows build fix

        * assembler/X86Assembler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Darin Adler.
ap@webkit.org [Tue, 18 Nov 2008 08:03:25 +0000 (08:03 +0000)]
    Rubber-stamped by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22306
        Disable channel messaging support

WebCore:
        * bindings/js/JSDOMWindowBase.cpp:
        (jsDOMWindowBaseMessageChannel):
        * page/DOMWindow.idl:
        Hide MesssagePort and MessageChannel global constructors. Due to the way MessageChannel
        constructor is added, it remains enumerable, but undefined.

LayoutTests:
        * fast/events/message-port-no-wrapper.html-disabled: Added a test that I had in my tree.

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/constructors-cached-expected.txt:
        * fast/dom/constructors-cached-navigate-expected.txt:
        * fast/js/global-constructors-expected.txt:
        Updated results.

        * fast/events/destroyed-atomic-string.html: Removed.
        * fast/events/destroyed-atomic-string.html-disabled: Copied from LayoutTests/fast/events/destroyed-atomic-string.html.
        * fast/events/message-channel-gc-2.html: Removed.
        * fast/events/message-channel-gc-2.html-disabled: Copied from LayoutTests/fast/events/message-channel-gc-2.html.
        * fast/events/message-channel-gc-3.html: Removed.
        * fast/events/message-channel-gc-3.html-disabled: Copied from LayoutTests/fast/events/message-channel-gc-3.html.
        * fast/events/message-channel-gc.html: Removed.
        * fast/events/message-channel-gc.html-disabled: Copied from LayoutTests/fast/events/message-channel-gc.html.
        * fast/events/message-channel-listener-circular-ownership.html: Removed.
        * fast/events/message-channel-listener-circular-ownership.html-disabled: Copied from LayoutTests/fast/events/message-channel-listener-circular-ownership.html.
        * fast/events/message-port-constructor-for-deleted-document.html: Removed.
        * fast/events/message-port-constructor-for-deleted-document.html-disabled: Copied from LayoutTests/fast/events/message-port-constructor-for-deleted-document.html.
        * fast/events/message-port-deleted-document.html: Removed.
        * fast/events/message-port-deleted-document.html-disabled: Copied from LayoutTests/fast/events/message-port-deleted-document.html.
        * fast/events/message-port-deleted-frame.html: Removed.
        * fast/events/message-port-deleted-frame.html-disabled: Copied from LayoutTests/fast/events/message-port-deleted-frame.html.
        * fast/events/message-port-inactive-document.html: Removed.
        * fast/events/message-port-inactive-document.html-disabled: Copied from LayoutTests/fast/events/message-port-inactive-document.html.
        * fast/events/message-port-onclose.html: Removed.
        * fast/events/message-port-onclose.html-disabled: Copied from LayoutTests/fast/events/message-port-onclose.html.
        * fast/events/message-port.html: Removed.
        * fast/events/message-port.html-disabled: Copied from LayoutTests/fast/events/message-port.html.
        * http/tests/security/MessagePort/event-listener-context.html: Removed.
        * http/tests/security/MessagePort/event-listener-context.html-disabled: Copied from LayoutTests/http/tests/security/MessagePort/event-listener-context.html.
        Disabled MessagePort tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-17 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 18 Nov 2008 03:34:48 +0000 (03:34 +0000)]
2008-11-17  Geoffrey Garen  <ggaren@apple.com>

        Not reviewed.

        Try to fix gtk build.

        * wrec/Quantifier.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-17 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 18 Nov 2008 03:25:03 +0000 (03:25 +0000)]
2008-11-17  Geoffrey Garen  <ggaren@apple.com>

        Not reviewed.

        Try to fix gtk build.

        * assembler/AssemblerBuffer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-11-17 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 18 Nov 2008 03:17:11 +0000 (03:17 +0000)]
2008-11-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Split WREC classes out into individual files, with a few modifications
        to more closely match the WebKit coding style.

        * GNUmakefile.am:
        * JavaScriptCore.scons:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * assembler/X86Assembler.h:
        * runtime/RegExp.cpp:
        * wrec/CharacterClass.cpp: Copied from wrec/CharacterClassConstructor.cpp.
        (JSC::WREC::CharacterClass::newline):
        (JSC::WREC::CharacterClass::digits):
        (JSC::WREC::CharacterClass::spaces):
        (JSC::WREC::CharacterClass::wordchar):
        (JSC::WREC::CharacterClass::nondigits):
        (JSC::WREC::CharacterClass::nonspaces):
        (JSC::WREC::CharacterClass::nonwordchar):
        * wrec/CharacterClass.h: Copied from wrec/CharacterClassConstructor.h.
        * wrec/CharacterClassConstructor.cpp:
        (JSC::WREC::CharacterClassConstructor::addSortedRange):
        (JSC::WREC::CharacterClassConstructor::append):
        * wrec/CharacterClassConstructor.h:
        * wrec/Quantifier.h: Copied from wrec/WREC.h.
        * wrec/WREC.cpp:
        (JSC::WREC::compileRegExp):
        * wrec/WREC.h:
        * wrec/WRECFunctors.cpp: Copied from wrec/WREC.cpp.
        * wrec/WRECFunctors.h: Copied from wrec/WREC.cpp.
        (JSC::WREC::GenerateAtomFunctor::~GenerateAtomFunctor):
        (JSC::WREC::GeneratePatternCharacterFunctor::GeneratePatternCharacterFunctor):
        (JSC::WREC::GenerateCharacterClassFunctor::GenerateCharacterClassFunctor):
        (JSC::WREC::GenerateBackreferenceFunctor::GenerateBackreferenceFunctor):
        (JSC::WREC::GenerateParenthesesNonGreedyFunctor::GenerateParenthesesNonGreedyFunctor):
        * wrec/WRECGenerator.cpp: Copied from wrec/WREC.cpp.
        (JSC::WREC::Generator::generatePatternCharacter):
        (JSC::WREC::Generator::generateCharacterClassInvertedRange):
        (JSC::WREC::Generator::generateCharacterClassInverted):
        (JSC::WREC::Generator::generateCharacterClass):
        (JSC::WREC::Generator::generateParentheses):
        (JSC::WREC::Generator::generateAssertionBOL):
        (JSC::WREC::Generator::generateAssertionEOL):
        (JSC::WREC::Generator::generateAssertionWordBoundary):
        * wrec/WRECGenerator.h: Copied from wrec/WREC.h.
        * wrec/WRECParser.cpp: Copied from wrec/WREC.cpp.
        (JSC::WREC::Parser::parseGreedyQuantifier):
        (JSC::WREC::Parser::parseCharacterClassQuantifier):
        (JSC::WREC::Parser::parseParentheses):
        (JSC::WREC::Parser::parseCharacterClass):
        (JSC::WREC::Parser::parseEscape):
        (JSC::WREC::Parser::parseTerm):
        * wrec/WRECParser.h: Copied from wrec/WREC.h.
        (JSC::WREC::Parser::):
        (JSC::WREC::Parser::Parser):
        (JSC::WREC::Parser::setError):
        (JSC::WREC::Parser::error):
        (JSC::WREC::Parser::recordSubpattern):
        (JSC::WREC::Parser::numSubpatterns):
        (JSC::WREC::Parser::ignoreCase):
        (JSC::WREC::Parser::multiline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Mark Rowe.
zimmermann@webkit.org [Tue, 18 Nov 2008 00:46:24 +0000 (00:46 +0000)]
Reviewed by Mark Rowe.

Remove WBXML code. MainResourceLoader is not an appropriate location.
Revert until we find a better place.

The mime type which belongs to wmlc should be enabled anyway so WML documents get build.
Remove the ENABLE(WBXML) blocks around these types in MIMETypeRegistry / DOMImplementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@38543 268f45cc-cd09-0410-ab3c-d52691b4dbfc