WebKit-https.git
10 years agoWebKit2 needs to be made localizable
weinig@apple.com [Tue, 1 Mar 2011 18:45:59 +0000 (18:45 +0000)]
WebKit2 needs to be made localizable
<rdar://problem/8728860>

Reviewed by Anders Carlsson.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Tue, 1 Mar 2011 18:26:18 +0000 (18:26 +0000)]
2011-03-01  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed.

        Removed accessibility/canvas-fallback-content.html from Skipped
        list as it was removed in 79920

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSave a crash log when the web process crashes
aroben@apple.com [Tue, 1 Mar 2011 18:13:54 +0000 (18:13 +0000)]
Save a crash log when the web process crashes

On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
until it has finished crashing, which guarantees that the crash log will have had time to be
saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
log, so all we have to do is choose the right crash log out of the CrashReporter directory.

Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive

Reviewed by Sam Weinig.

* Scripts/old-run-webkit-tests:
(testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
(captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
WebProces_*.crash files when the web process crashes.

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
along to platformInitialize.

* WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.

* WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
(WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.

* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):
* WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
(WTR::InjectedBundle::platformInitialize):
Updated function signature.

* WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
(WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
webProcessCrashingEvent, then lets the crash continue as normal.

(WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
event we should use to tell the UI process we're crashing from the initializationUserData,
and get a handle to that event.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController): Initialize new members.
(WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
only print the "#CRASHED - WebProcess" message once, since this can be called more than once
when a crash log is being saved on Windows. Exit right away if specified. (This is the
default.)

* WebKitTestRunner/TestController.h: Added new members.

* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::platformInitialize): Set up the event the web process will use to tell
us it's crashing.
(WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
so the test harness will know the web process has crashed and not try to kill us, then wait
for the web process to finish crashing so a crash log will have time to be saved.
(WTR::toWK): Simple hepler function.
(WTR::TestController::platformInitializeContext): Pass along the name of the event the web
process should use to tell us it is crashing in the context's initialization user data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 1 Mar 2011 18:00:23 +0000 (18:00 +0000)]
2011-03-01  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Tony Gentilcore.

        Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
        https://bugs.webkit.org/show_bug.cgi?id=55476

        Chromium Win uses BuildAndTestFactory, not TestFactory.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Tue, 1 Mar 2011 17:47:11 +0000 (17:47 +0000)]
2011-03-01  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Anders Carlsson.

        [Qt][WK2] Plugin initialization
        https://bugs.webkit.org/show_bug.cgi?id=48127

        Apply the quirks that are necessary for the flash plugin
        to not crash on X11.

        * Platform/qt/ModuleQt.cpp:
        (WebKit::Module::load): Use the ResolveAllSymbols hint as we do in WebCore.
        * Shared/Plugins/Netscape/NetscapePluginModule.cpp:
        (WebKit::NetscapePluginModule::tryLoad): Call applyX11QuirksBeforeLoad
        if PLUGIN_ARCHITECTURE is X11.
        * Shared/Plugins/Netscape/NetscapePluginModule.h:
        * Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
        (WebKit::initializeGTK):  The same hack that we do in WebCore.
        Call gtk_init because flash don't do it for itself.
        (WebKit::NetscapePluginModule::applyX11QuirksBeforeLoad): Added for X11.
        Do the hacks that we need to do before calling NP_Initialize on the
        flash plugin to save it form crashing.
        * Shared/Plugins/PluginQuirks.h: Use PLUGIN_ARCHITECTURE macros.
        Added RequiresGTKToolKit quirk for X11.
        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        (WebKit::NPN_GetValue): Handle the RequiresGTKToolKit quirk on X11.
        * WebProcess/Plugins/Netscape/NetscapePlugin.h:
        (WebKit::NetscapePlugin::quirks): Added getter for the PluginModule's
        quirks to be available in NPN_GetValue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 1 Mar 2011 17:41:12 +0000 (17:41 +0000)]
2011-02-28  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Gavin Barraclough.

        Past-the-end writes in VM exceptions (caused crashes in r79627)
        https://bugs.webkit.org/show_bug.cgi?id=55448

        Some exceptions had the wrong structures, so they misoverestimated their
        inline storage sizes.

        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData): Use the right structure.

        * runtime/JSObject.h:
        (JSC::JSNonFinalObject::JSNonFinalObject):
        (JSC::JSFinalObject::JSFinalObject): ASSERT that our structure capacity
        is correct to verify this doesn't happen again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 1 Mar 2011 17:28:39 +0000 (17:28 +0000)]
2011-03-01  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: InjectedScript.setPropertyValue doesn't work.
        https://bugs.webkit.org/show_bug.cgi?id=55475

        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::setPropertyValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Steve Block <steveblock@google.com>
steveblock@google.com [Tue, 1 Mar 2011 17:23:39 +0000 (17:23 +0000)]
2011-03-01  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Remove unused JavaString::uchars()
        https://bugs.webkit.org/show_bug.cgi?id=55465

        No new tests, removing dead code only.

        * bridge/jni/JNIBridge.h:
        * bridge/jni/jsc/JavaStringJSC.h:
        (JSC::Bindings::JavaStringImpl::utf8):
        * bridge/jni/v8/JavaStringV8.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Tue, 1 Mar 2011 16:51:03 +0000 (16:51 +0000)]
2011-03-01  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Extremely slow DOM search in GMail
        https://bugs.webkit.org/show_bug.cgi?id=55456

        The solution comprises three major parts:
        - avoid multiple invocations of highlightSearchResults(), one per each nodeIds chunk.
        - cache highlighted node's innerHTML so that no extra _nodeTitleInfo() calls will be needed.
        - replace hand-written Text nodes iteration with a snapshot-based ".//text()" XPathResult.

        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.searchCanceled):
        (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.highlightSearchResults):
        (WebInspector.ElementsTreeElement.prototype.updateTitle):
        ():
        * inspector/front-end/utilities.js:
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix multiple-definition linker warnings introduced by r79978 on Windows
aroben@apple.com [Tue, 1 Mar 2011 15:42:00 +0000 (15:42 +0000)]
Fix multiple-definition linker warnings introduced by r79978 on Windows

* rendering/RenderingAllInOne.cpp: Removed TextControlInnerElements.cpp, as it is now being
compiled separately.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoConvert seconds to milliseconds before calling ::SetTimer
aroben@apple.com [Tue, 1 Mar 2011 15:29:44 +0000 (15:29 +0000)]
Convert seconds to milliseconds before calling ::SetTimer

Fixes <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
early on Windows

Reviewed by Anders Carlsson.

Source/WebKit2:

* Platform/win/RunLoopWin.cpp:
(RunLoop::TimerBase::start): Convert the timeout interval to milliseconds, since that's what
::SetTimer expects.

Tools:

Test that the WebKit2 responsiveness timer doesn't fire too early

* TestWebKitAPI/PlatformUtilities.h: Added sleep().

* TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::processDidBecomeUnresponsive):
(TestWebKitAPI::setInjectedBundleClient):
(TestWebKitAPI::setPageLoaderClient):
Simple helper functions.

(TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
tell the web process to pause and press the spacebar key. The spacebar keypress should cause
the responsiveness timer to start, but the web process should unpause before it has a chance
to fire. Run until the web process has unpaused, and assert that the timer didn't fire.

* TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.
(TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
Call up to the base class.
(TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
pause, sleep for 0.5 seconds, then send back a message saying we paused.

* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::sleep): Added. Calls through to usleep.
* TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
(TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
* TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
Added new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Rebaselining Chromium expectations.
antonm@chromium.org [Tue, 1 Mar 2011 15:14:09 +0000 (15:14 +0000)]
Unreviewed.  Rebaselining Chromium expectations.

*    platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum
*    platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum
*    platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png
*    platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png
*    platform/chromium/test_expectations.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Tue, 1 Mar 2011 15:13:25 +0000 (15:13 +0000)]
2011-03-01  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Clean up the project files and move common options to WebKit.pri.

        Mac related changes suggested by Prasanth Ullattil <prasanth.ullattil@nokia.com>

        * Source/WebKit.pri: Common options should be here.
        Also move Mac options to this file to fix the Mac build.
2011-03-01  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Clean up the project files and move common options to WebKit.pri.

        * JavaScriptCore.pri: Move options also needed in WebCore into WebKit.pri.
        * JavaScriptCore.pro: Deduplicate options.
        * jsc.pro: Ditto.
2011-03-01  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Clean up the project files and move common options to WebKit.pri.

        * api/QtScript.pro: Deduplicate options.
2011-03-01  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Clean up the project files and move common options to WebKit.pri.

        No new tests needed.

        * WebCore.pri: Move common options to WebKit.pri.
        * WebCore.pro: Ditto.
2011-03-01  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Clean up the project files and move common options to WebKit.pri.

        * QtWebKit.pro: Move common options to WebKit.pri.
2011-03-01  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Clean up the project files and move common options to WebKit.pri.

        * WebKit2.pro: Deduplicate options.
2011-03-01  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Clean up the project files and move common options to WebKit.pri.

        * WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Steve Block <steveblock@google.com>
steveblock@google.com [Tue, 1 Mar 2011 14:31:22 +0000 (14:31 +0000)]
2011-03-01  Steve Block  <steveblock@google.com>

        Reviewed by Pavel Feldman.

        JNI code in Java bridge is not correctly guarded
        https://bugs.webkit.org/show_bug.cgi?id=55459

        No new tests, build fix only.

        * bridge/jni/v8/JNIBridgeV8.cpp:
        * bridge/jni/v8/JNIBridgeV8.h:
        * bridge/jni/v8/JNIUtilityPrivate.cpp:
        * bridge/jni/v8/JNIUtilityPrivate.h:
        * bridge/jni/v8/JavaClassV8.cpp:
        * bridge/jni/v8/JavaClassV8.h:
        * bridge/jni/v8/JavaInstanceV8.cpp:
        * bridge/jni/v8/JavaInstanceV8.h:
        * bridge/jni/v8/JavaNPObjectV8.cpp:
        * bridge/jni/v8/JavaNPObjectV8.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Juha Savolainen <juha.savolainen@weego.fi>
commit-queue@webkit.org [Tue, 1 Mar 2011 14:13:04 +0000 (14:13 +0000)]
2011-03-01  Juha Savolainen  <juha.savolainen@weego.fi>

        Reviewed by Andreas Kling.

        [Qt] WebKit2 needs to support font size changing and getting default font size
        https://bugs.webkit.org/show_bug.cgi?id=53671

        Added new enum for font size type and added methods to set and get default font sizes.

        * UIProcess/API/qt/qwkpreferences.cpp:
        (QWKPreferences::setFontSize): Added.
        (QWKPreferences::fontSize): Added.
        * UIProcess/API/qt/qwkpreferences.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Aparna Nandyal <aparna.nand@wipro.com>
commit-queue@webkit.org [Tue, 1 Mar 2011 14:01:04 +0000 (14:01 +0000)]
2011-03-01  Aparna Nandyal  <aparna.nand@wipro.com>

        Reviewed by Simon Hausmann.

        [Qt]tst_QWebPage::backActionUpdate fails when there is not network connection
        https://bugs.webkit.org/show_bug.cgi?id=55319

        The test case required internet connection to be able to connect to
        google.com. Added new html file which refers to local html file.

        * tests/qwebpage/resources/content.html: Added.
        * tests/qwebpage/resources/frame_c.html: Added.
        * tests/qwebpage/resources/framedindex.html: Added.
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::backActionUpdate):
        * tests/qwebpage/tst_qwebpage.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 1 Mar 2011 13:55:02 +0000 (13:55 +0000)]
2011-03-01  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: remove manual watchdog from the inspector tests.
        https://bugs.webkit.org/show_bug.cgi?id=55447

        * http/tests/inspector/inspector-test.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip another timing-out test on Windows XP
aroben@apple.com [Tue, 1 Mar 2011 13:53:16 +0000 (13:53 +0000)]
Skip another timing-out test on Windows XP

<http://webkit.org/b/51596> tracks the failure.

* platform/win-xp/Skipped: Added http/tests/xmlhttprequest/basic-auth-nouser.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip another multiprocessing test on Windows
aroben@apple.com [Tue, 1 Mar 2011 13:52:50 +0000 (13:52 +0000)]
Skip another multiprocessing test on Windows

It is sometimes failing (and may be leaving child Python processes around).
<http://webkit.org/b/55087> tracks the failure.

* Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
(FuncitonTests.test_get__processes): Skip this test on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip fast/events/pageshow-pagehide-on-back-cached.html on Windows
aroben@apple.com [Tue, 1 Mar 2011 13:52:20 +0000 (13:52 +0000)]
Skip fast/events/pageshow-pagehide-on-back-cached.html on Windows

It is flaky. The failure is tracked by <http://webkit.org/b/55329>.

* platform/win/Skipped:
* platform/win/fast/events/pageshow-pagehide-on-back-cached-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCheck in Windows pixel results to match text results added in r79979
aroben@apple.com [Tue, 1 Mar 2011 13:51:47 +0000 (13:51 +0000)]
Check in Windows pixel results to match text results added in r79979

Fixes <http://webkit.org/b/55451> [Win] select-listbox-multiple-no-focusring.html needs
rebaseline

* platform/win/fast/forms/select-listbox-multiple-no-focusring-expected.checksum: Added.
* platform/win/fast/forms/select-listbox-multiple-no-focusring-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 1 Mar 2011 13:14:35 +0000 (13:14 +0000)]
2011-03-01  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip one crashing tests on GTK. See also
        https://bugs.webkit.org/show_bug.cgi?id=53146

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 1 Mar 2011 12:09:20 +0000 (12:09 +0000)]
2011-03-01  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip 2 crashing tests on GTK. See also
        https://bugs.webkit.org/show_bug.cgi?id=53146

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Steve Block <steveblock@google.com>
steveblock@google.com [Tue, 1 Mar 2011 11:51:46 +0000 (11:51 +0000)]
2011-03-01  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Bridge.h should not include BridgeJSC.h
        https://bugs.webkit.org/show_bug.cgi?id=55212

        Instead, BridgeJSC.h should include Bridge.h and code should include
        BridgeJSC.h as appropriate.

        This prevents ports that use V8 from having to include JSC-specific
        files, even if the contents of those files are guarded.

        No new tests, cleanup only.

        * bindings/js/JSPluginElementFunctions.cpp:
        * bindings/js/ScriptControllerBrew.cpp:
        * bindings/js/ScriptControllerGtk.cpp:
        * bindings/js/ScriptControllerHaiku.cpp:
        * bindings/js/ScriptControllerQt.cpp:
        * bindings/js/ScriptControllerMac.mm:
        * bindings/js/ScriptControllerWin.cpp:
        * bindings/js/ScriptControllerWx.cpp:
        * bindings/js/ScriptInstance.h:
        * bindings/objc/WebScriptObject.mm:
        * bridge/Bridge.h:
        * bridge/c/c_class.h:
        * bridge/c/c_instance.h:
        * bridge/c/c_runtime.h:
        * bridge/jni/jsc/JNIBridgeJSC.h:
        * bridge/jni/jsc/JavaInstanceJSC.h:
        * bridge/jsc/BridgeJSC.h:
        * bridge/objc/objc_runtime.h:
        * bridge/qt/qt_class.h:
        * bridge/qt/qt_instance.h:
        * bridge/qt/qt_pixmapruntime.h:
        * bridge/qt/qt_runtime.h:
        * bridge/runtime_array.h:
        * bridge/runtime_method.h:
        * bridge/runtime_object.h:
        * bridge/runtime_root.cpp:
        * bridge/testbindings.cpp:
        * bridge/testbindings.mm:
        * bridge/testqtbindings.cpp:
        * page/win/FrameWin.cpp:
        * platform/graphics/wince/MediaPlayerProxy.cpp:
        * plugins/PluginView.cpp:
        * plugins/PluginViewNone.cpp:
        * plugins/gtk/PluginViewGtk.cpp:
        * plugins/mac/PluginViewMac.mm:
        * plugins/qt/PluginViewQt.cpp:
        * plugins/symbian/PluginViewSymbian.cpp:
        * plugins/win/PluginViewWin.cpp:
2011-02-25 Steve Block <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Bridge.h should not include BridgeJSC.h
        https://bugs.webkit.org/show_bug.cgi?id=55212

        Include BridgeJSC.h directly instead.

        * Plugins/Hosted/ProxyInstance.h:
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2011-02-25 Steve Block <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Bridge.h should not include BridgeJSC.h
        https://bugs.webkit.org/show_bug.cgi?id=55212

        Include BridgeJSC.h directly instead.

        * Api/qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Changing Chromium expectations for recently added tests.
antonm@chromium.org [Tue, 1 Mar 2011 11:35:54 +0000 (11:35 +0000)]
Unreviewed.  Changing Chromium expectations for recently added tests.

*    chromium/test_expectations.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Temporary disabling tests which may affect others.
antonm@chromium.org [Tue, 1 Mar 2011 10:53:44 +0000 (10:53 +0000)]
Unreviewed.  Temporary disabling tests which may affect others.

*    chromium/test_expectations.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 1 Mar 2011 10:52:51 +0000 (10:52 +0000)]
2011-03-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Antti Koivisto.

        SVG 1.1 2nd Edition color-prop-05-t.svg exposes bug in 'currentColor' handling
        https://bugs.webkit.org/show_bug.cgi?id=54800

        Add new layout test from the SVG 1.1 2nd Edition test suite, covering currentColor handling.
        Add tests ensuring that mutating a previously shared SVGPaint object makes it unique, so that
        mutations take affect, but don't affect other renderers which shared the SVGPaint object before.

        * platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.checksum: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
        * platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.checksum: Added.
        * platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.png: Added.
        * platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.txt: Added.
        * platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.checksum: Added.
        * platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.png: Added.
        * platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Added.
        * svg/W3C-SVG-1.1-SE/color-prop-05-t.svg: Added.
        * svg/animations/animate-color-fill-currentColor-expected.txt: Added.
        * svg/animations/animate-color-fill-currentColor.html: Added.
        * svg/animations/script-tests/animate-color-fill-currentColor.js: Added.
        * svg/custom/SVGPaint-mutate-attribute.svg: Added.
        * svg/custom/SVGPaint-mutate-inline-style.svg: Added.
        * svg/dom/SVGColor-expected.txt: SVGColor mutations now reflected in style/computed style.
        * svg/dom/SVGPaint-expected.txt: Same for SVGPaint.
2011-03-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Antti Koivisto.

        SVG 1.1 2nd Edition color-prop-05-t.svg exposes bug in 'currentColor' handling
        https://bugs.webkit.org/show_bug.cgi?id=54800

        Wrong handling of currentColor on inherit
        https://bugs.webkit.org/show_bug.cgi?id=38102

        Stop storing RefPtr<SVGPaint> objects in the SVGRenderStyle for fill/stroke. These are the last
        two objects that held references to CSSValues, they're all gone now, aligning better with RenderStyle.
        It's also dangerous, as a SVGPaint object can be shared by multiple SVGRenderStyles (MappedAttribute will
        once create a CSSStyleDeclaration for fill="red" and reuse it where possible), and it was easy to
        accidently mutate the object, affecting multiple styles. Instead store a Color, an URI and a paint
        type in SVGRenderStyle, enough to create a SVGPaint object, if needed (eg for computed styles).

        <g color="green"><rect fill="currentColor"/> already worked fine in trunk, but
        <g fill="currentColor" color="green"><rect color="red"/> procuded a red rectangle.

        In order to fix to bug we have to resolve all currentColor values for SVGPaint objects, in SVGCSSStyleSelector,
        as it's already done for SVGColor objects (stop-color, flood-color, etc.) instead of in RenderSVGResource::fill/strokePaintingResource,
        when trying to use the paint server. The correct "color" value that should be used from the RenderStyle, is directly
        available in CSSStyleSelector: in applyProperty m_style->color() gives the desired value. In CSSStyleSelector it's handled
        exactly this way for non-SVG currentColor properties. Also fix computed styles, which did not resolve currentColor for SVGPaint/SVGColor.

        A previous patch implemented the SVGPaint/SVGColor API. SVG demands these CSSValues to be mutable. Introduce
        CSSMutableValue, which extends CSSValue by a Node pointer, and let SVGPaint/SVGColor inherit from it.
        Mutating a SVGPaint/SVGColor object now takes immediate effect, which is reflected in the inline style / computed style.
        (Note that getPresentationAttribute() already takes care of removing the CSSValue from the mapped attribute cache, so that it's no longer shared.)

        Add several new tests covering the patch.

        Tests: svg/W3C-SVG-1.1-SE/color-prop-05-t.svg
               svg/animations/animate-color-fill-currentColor.html
               svg/custom/SVGPaint-mutate-attribute.svg
               svg/custom/SVGPaint-mutate-inline-style.svg

        * GNUMakefile.am: Add CSSMutableValue.h
        * WebCore.gypi: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * css/CSSMutableStyleDeclaration.cpp: Reset the Node pointer in all CSSMutableValues belonging to this style declaration.
        (WebCore::CSSMutableStyleDeclaration::~CSSMutableStyleDeclaration):
        * css/CSSMutableStyleDeclaration.h: Add destructor.
        * css/CSSMutableValue.h: Added.
        (WebCore::CSSMutableValue::CSSMutableValue):
        (WebCore::CSSMutableValue::~CSSMutableValue):
        (WebCore::CSSMutableValue::isMutableValue):
        (WebCore::CSSMutableValue::node):
        (WebCore::CSSMutableValue::setNode):
        (WebCore::CSSMutableValue::setNeedsStyleRecalc):
        * css/CSSStyleDeclaration.cpp:
        (WebCore::CSSStyleDeclaration::getPropertyCSSValue): Set the Node object of a CSSMutableValue to the Node, this style declaration belongs to.
        * css/CSSValue.h:
        (WebCore::CSSValue::isMutableValue): Return false, default.
        * css/SVGCSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::adjustSVGPaintForCurrentColor): Add helper function, resolving currentColor values for SVGPaint objects.
        (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): Use currentColorOrValidColor/adjustSVGPaintForCurrentColor to resolve SVGColor/SVGPaint values.
        * css/SVGCSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applySVGProperty): Store fill/stroke uri, color, paint type seperated in SVGRenderStyle, don't store the full SVGPaint object anymore.
        * rendering/style/SVGRenderStyle.cpp:
        (WebCore::SVGRenderStyle::diff): Adapt to SVGPaint changes.
        * rendering/style/SVGRenderStyle.h: Ditto.
        (WebCore::SVGRenderStyle::initialFillOpacity):
        (WebCore::SVGRenderStyle::initialFillPaintType):
        (WebCore::SVGRenderStyle::initialFillPaintColor):
        (WebCore::SVGRenderStyle::initialFillPaintUri):
        (WebCore::SVGRenderStyle::initialStrokeOpacity):
        (WebCore::SVGRenderStyle::initialStrokePaintType):
        (WebCore::SVGRenderStyle::initialStrokePaintColor):
        (WebCore::SVGRenderStyle::initialStrokePaintUri):
        (WebCore::SVGRenderStyle::initialStrokeMiterLimit):
        (WebCore::SVGRenderStyle::initialStopOpacity):
        (WebCore::SVGRenderStyle::initialFloodOpacity):
        (WebCore::SVGRenderStyle::setFillPaint):
        (WebCore::SVGRenderStyle::setStrokePaint):
        (WebCore::SVGRenderStyle::fillPaintType):
        (WebCore::SVGRenderStyle::fillPaintColor):
        (WebCore::SVGRenderStyle::fillPaintUri):
        (WebCore::SVGRenderStyle::strokePaintType):
        (WebCore::SVGRenderStyle::strokePaintColor):
        (WebCore::SVGRenderStyle::strokePaintUri):
        (WebCore::SVGRenderStyle::hasStroke):
        (WebCore::SVGRenderStyle::hasFill):
        * rendering/style/SVGRenderStyleDefs.cpp: Ditto.
        (WebCore::StyleFillData::StyleFillData):
        (WebCore::StyleFillData::operator==):
        (WebCore::StyleStrokeData::StyleStrokeData):
        (WebCore::StyleStrokeData::operator==):
        * rendering/style/SVGRenderStyleDefs.h: Ditto.
        * rendering/svg/RenderSVGResource.cpp: Ditto.
        (WebCore::requestPaintingResource):
        * rendering/svg/RenderSVGResourceClipper.cpp: Ditto.
        (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
        * rendering/svg/SVGResources.cpp: Ditto.
        (WebCore::paintingResourceFromSVGPaint):
        (WebCore::SVGResources::buildCachedResources):
        * svg/SVGColor.cpp: Call setNeedsStyleRecalc() after mutating the object.
        (WebCore::SVGColor::setRGBColor):
        (WebCore::SVGColor::setRGBColorICCColor):
        (WebCore::SVGColor::setColor):
        * svg/SVGColor.h:
        * svg/SVGPaint.cpp: Ditto.
        (WebCore::SVGPaint::setUri):
        (WebCore::SVGPaint::setPaint):
        * svg/SVGPaint.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Tue, 1 Mar 2011 10:21:07 +0000 (10:21 +0000)]
2011-03-01  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: [Text editor] Handle decorated lines in the editor
        https://bugs.webkit.org/show_bug.cgi?id=55373

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._startEditing):
        (WebInspector.SourceFrame.prototype._endEditing):
        (WebInspector.SourceFrame.prototype._createTextViewer):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextEditorGutterPanel.prototype.textChanged):
        (WebInspector.TextEditorGutterChunk.prototype.addDecoration):
        (WebInspector.TextEditorGutterChunk.prototype.removeDecoration):
        (WebInspector.TextEditorMainPanel.prototype.set readOnly):
        (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
        (WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified):
        (WebInspector.TextEditorMainPanel.prototype._markDirtyLines):
        (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
        (WebInspector.TextEditorMainPanel.prototype._removeDecorationsInRange):
        (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
        (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):
        (WebInspector.TextEditorMainChunk.prototype.addDecoration):
        (WebInspector.TextEditorMainChunk.prototype.removeDecoration):
        (WebInspector.TextEditorMainChunk.prototype.removeAllDecorations):
        (WebInspector.TextEditorMainChunk.prototype.get decorated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 1 Mar 2011 09:31:14 +0000 (09:31 +0000)]
2011-03-01  Philippe Normand  <pnormand@igalia.com>

        Unreviewed GTK build fix after r79978

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Tue, 1 Mar 2011 09:29:27 +0000 (09:29 +0000)]
2011-03-01  Andras Becsi  <abecsi@webkit.org>

        Unreviewed build fix.

        [Qt] Fix minimal build.

        * Source/WebKit.pri: Move the XP_UNIX define back to WebCore.pri.
2011-03-01  Andras Becsi  <abecsi@webkit.org>

        Unreviewed build fix.

        [Qt] Fix minimal build.

        No new tests needed.

        * WebCore.pri: Is included in WebKit2.pro, so XP_UNIX can remain here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 anthony taranto <anthony.taranto@gmail.com>
yurys@chromium.org [Tue, 1 Mar 2011 08:59:36 +0000 (08:59 +0000)]
2011-03-01  anthony taranto  <anthony.taranto@gmail.com>

        Return undefined value from ScriptController::evaluate(), allowing the
        caller to distinguish between an error and an undefined return value.
        https://bugs.webkit.org/show_bug.cgi?id=51528

        * bindings/v8/ScriptController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 1 Mar 2011 08:58:31 +0000 (08:58 +0000)]
2011-03-01  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: fixing flaky snow XMLViewer test on snow leopard.

        * http/tests/xmlviewer/dumpAsText/frames.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 1 Mar 2011 08:56:04 +0000 (08:56 +0000)]
2011-03-01  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Windows rebaseline. The bug 55451 tracks this rebaseline.

        * platform/win/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Tue, 1 Mar 2011 08:48:46 +0000 (08:48 +0000)]
2011-03-01  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Kent Tamura.

        Bug 54853 - Move TextControlInnerElements from WebCore/rendering to WebCore/html/shadow
        https://bugs.webkit.org/show_bug.cgi?id=54853

        Moving the files from rendering to html/shadow, with the exception of
        the class RenderTextControlInnerBlock, which I moved to RenderTextControlSingleLine
        (this place is not ideal, but only a temporary state during the larger refactoring
        for <input>).

        No new tests. (refactoring)

        * Android.mk:
        * CMakeLists.txt:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/shadow/TextControlInnerElements.cpp: Copied from Source/WebCore/rendering/TextControlInnerElements.cpp.
        * html/shadow/TextControlInnerElements.h: Copied from Source/WebCore/rendering/TextControlInnerElements.h.
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlInnerBlock::positionForPoint):
        * rendering/RenderTextControlSingleLine.h:
        (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
        (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
        * rendering/TextControlInnerElements.cpp: Removed.
        * rendering/TextControlInnerElements.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Joone Hur <joone.hur@collabora.co.uk>
joone.hur@collabora.co.uk [Tue, 1 Mar 2011 08:46:21 +0000 (08:46 +0000)]
2011-03-01  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Convert use of cairo_t to RefPtr<cairo_t> in webkitwebiew.cpp
        https://bugs.webkit.org/show_bug.cgi?id=55437

        * webkit/webkitwebview.cpp: Convert use of cairo_t to RefPtr<cairo_t>.
        (webkit_web_view_expose_event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 1 Mar 2011 08:39:55 +0000 (08:39 +0000)]
2011-03-01  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        applyInlineStyleToPushDown and removeInlineStyleFromElement should take EditingStyle
        https://bugs.webkit.org/show_bug.cgi?id=55338

        Deployed EditingStyle in applyInlineStyleToPushDown and removeInlineStyleFromElement.

        Also added a convenience function EditingStyle::setProperty, which lazily instantiates
        new CSSMutableStyleDeclaration for m_mutableStyle.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Takes EditingStyle*.
        (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Ditto.
        (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto.
        (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Calls the above three functions.
        (WebCore::ApplyStyleCommand::removeInlineStyle): Calls pushDownInlineStyleAroundNode.
        * editing/ApplyStyleCommand.h:
        * editing/EditingStyle.cpp:
        (WebCore::HTMLElementEquivalent::addToStyle): Takes EditingStyle*; calls EditingStyle::setProperty.
        (WebCore::HTMLAttributeEquivalent::addToStyle): Ditto.
        (WebCore::EditingStyle::setProperty): Added.  This member function lazily instantiates
        new CSSMutableStyleDeclaration for m_mutableStyle.
        (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Takes EditingStyle*.
        (WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Ditto.
        (WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes): Ditto.
        * editing/EditingStyle.h: Added HTMLElementEquivalent and HTMLAttributeEquivalent as friends.
        (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Ditto.
        * editing/InsertTextCommand.cpp: Removed unnecessary includes.
        * editing/RemoveCSSPropertyCommand.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 1 Mar 2011 08:14:32 +0000 (08:14 +0000)]
2011-03-01  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: reduce inspector tests flakiness.
        https://bugs.webkit.org/show_bug.cgi?id=55401

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::runFileTest):
        * DumpRenderTree/chromium/WebPreferences.cpp:
        (WebPreferences::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 1 Mar 2011 08:14:29 +0000 (08:14 +0000)]
2011-03-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Teach JavaScriptCore GYP build about DEPTH
        https://bugs.webkit.org/show_bug.cgi?id=55425

        In addition to teaching the JavaScriptCore GYP build about DEPTH, this
        change overrides the GCC warning configuration to disable a warning
        that's causing probems in Assertions.cpp.  With that warning disabled,
        JavaScriptCore builds again.

        * gyp/JavaScriptCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 1 Mar 2011 07:41:28 +0000 (07:41 +0000)]
2011-02-28  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by James Robinson.

        NRWT should still upload results when it exits early due to too many failures
        https://bugs.webkit.org/show_bug.cgi?id=55432

        Only keyboard interrupts should prevent results from being uploaded.

        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Tue, 1 Mar 2011 07:09:44 +0000 (07:09 +0000)]
2011-02-28  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Darin Adler.

        Fix a race condition in editing/selection/4975120
        https://bugs.webkit.org/show_bug.cgi?id=55429

        If the parser yields between the iframe and the script, it would have been
        possible for step2() to be called before runTest() and the test would hang.

        * editing/selection/4975120.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Benjamin Kalman <kalman@chromium.org>
kalman@chromium.org [Tue, 1 Mar 2011 07:07:38 +0000 (07:07 +0000)]
2011-02-28  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Ryosuke Niwa.

        Make editing/selection/extend-selection-home-end test match other extend-selection with granularity tests
        https://bugs.webkit.org/show_bug.cgi?id=55422

        The other extend-selection tests which test a granularity just call into resources/extend-selection.js with the
        granularity they're testing.  The lineboundary test didn't due to RTL bugs in lineboundary, but these have now
        been fixed.

        * editing/selection/extend-selection-home-end-expected.txt:
        * editing/selection/extend-selection-home-end.html:
        * platform/mac/editing/selection/extend-selection-home-end-expected.txt:
        * platform/win/editing/selection/extend-selection-home-end-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 1 Mar 2011 07:06:12 +0000 (07:06 +0000)]
2011-02-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        Teach JavaScriptGlue gyp build about DEPTH
        https://bugs.webkit.org/show_bug.cgi?id=55421

        Moves the previously JavaScriptGlue-specific GYP helper shell scripts
        to the gyp directory in Source, where they can be shared by multiple
        frameworks.

        * Source/gyp: Added.
        * Source/gyp/remove-headers-if-needed.sh: Copied from Source/JavaScriptGlue/gyp/remove-headers-if-needed.sh.
        * Source/gyp/run-if-exists.sh: Copied from Source/JavaScriptGlue/gyp/run-if-exists.sh.
        * Source/gyp/update-info-plist.sh: Copied from Source/JavaScriptGlue/gyp/update-info-plist.sh.
2011-02-28  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam Weinig & Darin Adler.

        Bug 55423 - Clean up property tables in Structure

        Encapsulate, reduce duplication of table search code,
        and reduce the size of the tables (remove the index,
        just maintain the tables in the correct order).

        Shows a 0.5% - 1% progression on sunspider.

        * ForwardingHeaders/wtf/HashTable.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 1 Mar 2011 06:26:00 +0000 (06:26 +0000)]
2011-02-28  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: chromium rebuilds XMLViewer after noop. Fixed gyp file.

        * WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
barraclough@apple.com [Tue, 1 Mar 2011 05:26:39 +0000 (05:26 +0000)]
Windows build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 1 Mar 2011 05:12:37 +0000 (05:12 +0000)]
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79948.
        http://trac.webkit.org/changeset/79948
        https://bugs.webkit.org/show_bug.cgi?id=55439

        "caused crashes on the SL release bot" (Requested by ggaren on
        #webkit).

        * runtime/JSGlobalData.h:
        * runtime/WriteBarrier.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebKit2: https://bugs.webkit.org/show_bug.cgi?id=54898
alice.liu@apple.com [Tue, 1 Mar 2011 04:40:31 +0000 (04:40 +0000)]
Source/WebKit2: https://bugs.webkit.org/show_bug.cgi?id=54898
InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle

Reviewed by Adam Roben and Gavin Barraclough.

* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultCopyNodeHandle):
Instead of .get(), call .release.leakRef() like other functions that return WKBundleNodeHandleRef.
* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
Renamed from "get" to "copy", because it leaksRef.

Tools: Test for https://bugs.webkit.org/show_bug.cgi?id=54898
InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle.

Reviewed by Adam Roben and Gavin Barraclough.

* TestWebKitAPI/InjectedBundleController.h:
(TestWebKitAPI::InjectedBundleController::bundle):
* TestWebKitAPI/PlatformWebView.h:
* TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added.
(TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest):
(TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
(TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
* TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::simulateRightClick):
* TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::simulateRightClick):

Added files to:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
* TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=55442
alice.liu@apple.com [Tue, 1 Mar 2011 04:27:25 +0000 (04:27 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=55442
Webarchives don't contain subframe content

Reviewed by Gavin Barraclough.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getWebArchiveOfFrame):
Pass the frame's document instead of just the frame, to use a different LegacyWebArchive::create function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
barraclough@apple.com [Tue, 1 Mar 2011 03:59:00 +0000 (03:59 +0000)]
Windows build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 55423 - Clean up property tables in Structure
barraclough@apple.com [Tue, 1 Mar 2011 03:53:09 +0000 (03:53 +0000)]
Bug 55423 - Clean up property tables in Structure

Reviewed by Sam Weinig & Darin Adler.

Encapsulate, reduce duplication of table search code,
and reduce the size of the tables (remove the index,
just maintain the tables in the correct order).

Shows a 0.5% - 1% progression on sunspider.

../JavaScriptCore:

* JavaScriptCore.exp:
* runtime/PropertyMapHashTable.h:
(JSC::isPowerOf2):
(JSC::nextPowerOf2):
    bit ops used to calculate table size.
(JSC::PropertyMapEntry::PropertyMapEntry):
(JSC::PropertyTable::ordered_iterator::operator++):
(JSC::PropertyTable::ordered_iterator::operator==):
(JSC::PropertyTable::ordered_iterator::operator!=):
(JSC::PropertyTable::ordered_iterator::operator*):
(JSC::PropertyTable::ordered_iterator::operator->):
(JSC::PropertyTable::ordered_iterator::ordered_iterator):
    implementation of the iterator types
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::~PropertyTable):
    constructors take an initial capacity for the table,
    a table to copy, or both.
(JSC::PropertyTable::begin):
(JSC::PropertyTable::end):
    create in-order iterators.
(JSC::PropertyTable::find):
    search the hash table
(JSC::PropertyTable::add):
    add a value to the hash table
(JSC::PropertyTable::remove):
    remove a value from the hash table
(JSC::PropertyTable::size):
(JSC::PropertyTable::isEmpty):
    accessors.
(JSC::PropertyTable::propertyStorageSize):
(JSC::PropertyTable::clearDeletedOffsets):
(JSC::PropertyTable::hasDeletedOffset):
(JSC::PropertyTable::getDeletedOffset):
(JSC::PropertyTable::addDeletedOffset):
    cache deleted (available) offsets in the property storage array.
(JSC::PropertyTable::copy):
    take a copy of the PropertyTable, potentially expanding the capacity.
(JSC::PropertyTable::sizeInMemory):
    used for DEBUG build statistics
(JSC::PropertyTable::reinsert):
(JSC::PropertyTable::rehash):
(JSC::PropertyTable::tableCapacity):
(JSC::PropertyTable::deletedEntryIndex):
(JSC::PropertyTable::skipDeletedEntries):
(JSC::PropertyTable::table):
(JSC::PropertyTable::usedCount):
(JSC::PropertyTable::dataSize):
(JSC::PropertyTable::sizeForCapacity):
(JSC::PropertyTable::canInsert):
    these methods provide internal implementation.
* runtime/Structure.cpp:
(JSC::Structure::dumpStatistics):
(JSC::Structure::~Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::despecifyAllFunctions):
(JSC::Structure::put):
(JSC::Structure::remove):
(JSC::Structure::createPropertyMap):
(JSC::Structure::getPropertyNames):
(JSC::PropertyTable::checkConsistency):
(JSC::Structure::checkConsistency):
    factored out code to PropertyMapHashTable.h
* runtime/Structure.h:
(JSC::Structure::propertyStorageSize):
(JSC::Structure::isEmpty):
(JSC::Structure::get):
    factored out code to PropertyMapHashTable.h

../JavaScriptGlue:

* ForwardingHeaders/wtf/HashTable.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 1 Mar 2011 03:42:13 +0000 (03:42 +0000)]
2011-02-28  James Robinson  <jamesr@chromium.org>

        Chromium baseline updates.

        * platform/chromium-linux/svg/text/font-size-below-point-five-expected.txt:
        * platform/chromium/test_expectations.txt:
        * platform/mac-leopard/svg/text/font-size-below-point-five-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 1 Mar 2011 03:21:25 +0000 (03:21 +0000)]
2011-02-28  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations change.

        Rebaseline editing/ tests for Snow Leopard (mac/ baselines can't be used
        due to spell checking differences).

        * platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-002-expected.checksum: Added.
        * platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-002-expected.png: Added.
        * platform/chromium-mac-leopard/editing/inserting/typing-around-br-001-expected.checksum: Added.
        * platform/chromium-mac-leopard/editing/inserting/typing-around-br-001-expected.png: Added.
        * platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-3-expected.checksum: Added.
        * platform/chromium-mac-leopard/editing/pasteboard/paste-blockquote-3-expected.png: Added.
        * platform/chromium-mac-leopard/editing/selection/4932260-3-expected.checksum: Added.
        * platform/chromium-mac-leopard/editing/selection/4932260-3-expected.png: Added.
        * platform/chromium-mac-leopard/editing/selection/5234383-1-expected.checksum: Added.
        * platform/chromium-mac-leopard/editing/selection/5234383-1-expected.png: Added.
        * platform/chromium-mac-leopard/editing/selection/5234383-2-expected.checksum: Added.
        * platform/chromium-mac-leopard/editing/selection/5234383-2-expected.png: Added.
        * platform/chromium-mac-leopard/editing/selection/drag-in-iframe-expected.checksum: Added.
        * platform/chromium-mac-leopard/editing/selection/drag-in-iframe-expected.png: Added.
        * platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.png: Added.
        * platform/chromium-mac/editing/inserting/typing-around-br-001-expected.checksum: Added.
        * platform/chromium-mac/editing/inserting/typing-around-br-001-expected.png: Added.
        * platform/chromium-mac/editing/pasteboard/paste-blockquote-3-expected.checksum: Added.
        * platform/chromium-mac/editing/pasteboard/paste-blockquote-3-expected.png: Added.
        * platform/chromium-mac/editing/selection/4932260-3-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/4932260-3-expected.png: Added.
        * platform/chromium-mac/editing/selection/5234383-1-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/5234383-1-expected.png: Added.
        * platform/chromium-mac/editing/selection/5234383-2-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/5234383-2-expected.png: Added.
        * platform/chromium-mac/editing/selection/drag-in-iframe-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/drag-in-iframe-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 1 Mar 2011 02:34:02 +0000 (02:34 +0000)]
2011-02-28  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations change.

        Update Snow Leopard expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 1 Mar 2011 02:30:36 +0000 (02:30 +0000)]
2011-02-28  Xan Lopez  <xlopez@igalia.com>

        Another fix build :(

        Fix typo.

        * runtime/MachineStackMarker.cpp:
        (JSC::freePlatformThreadRegisters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 1 Mar 2011 02:26:19 +0000 (02:26 +0000)]
2011-02-28  Xan Lopez  <xlopez@igalia.com>

        Unreviewed build fix for Snow Leopard.

        * runtime/MachineStackMarker.cpp:
        (JSC::freePlatformThreadRegisters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Tue, 1 Mar 2011 02:20:33 +0000 (02:20 +0000)]
2011-02-28  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, fix SnowLeopard compilation after r79952.

        * runtime/MachineStackMarker.cpp:
        (JSC::freePlatformThreadRegisters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoKURL should expose a referrer property.
levin@chromium.org [Tue, 1 Mar 2011 02:10:28 +0000 (02:10 +0000)]
KURL should expose a referrer property.
https://bugs.webkit.org/show_bug.cgi?id=55415

Reviewed by Darin Adler.

No change in functionality so no new tests.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::setOutgoingReferrer): Refactor to put the majority
of functionality in KURL::strippedForUseAsReferrer() so that this code can
be more easily reused.
* platform/KURL.cpp:
(WebCore::KURL::strippedForUseAsReferrer): Converts the url to a string
which is suitable for use as a referrer.
* platform/KURL.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/55430> OwnArrayPtr.h's LOOSE_OWN_ARRAY_PTR results in link errors.
mrowe@apple.com [Tue, 1 Mar 2011 01:55:24 +0000 (01:55 +0000)]
<webkit.org/b/55430> OwnArrayPtr.h's LOOSE_OWN_ARRAY_PTR results in link errors.

Reviewed by Darin Adler.

* wtf/OwnArrayPtr.h:
(WTF::::set): Implement OwnArrayPtr::set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNumber type input cannot be set to empty string if it has an initial value
tkent@chromium.org [Tue, 1 Mar 2011 01:51:45 +0000 (01:51 +0000)]
Number type input cannot be set to empty string if it has an initial value
https://bugs.webkit.org/show_bug.cgi?id=53744

Reviewed by Darin Adler.

Source/WebCore:

We need to distinguish null strings and empty strings for
InputElementData::value. So InputType::sanitizeValue() also needs to
take care of it.

* dom/InputElement.h: Add a comment to InputElementData::value and
  setValue about null strings.
* html/InputType.h: Add a comment to sanitizeValue about null strings.
* html/NumberInputType.cpp:
(WebCore::NumberInputType::sanitizeValue): Returns a null string if the
  proposed value is a null string. Returning an empty string if the
  proposed value is not a number.

LayoutTests:

* fast/forms/input-value-sanitization-expected.txt:
* fast/forms/script-tests/input-value-sanitization.js: Add some tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Tue, 1 Mar 2011 01:47:06 +0000 (01:47 +0000)]
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Updated expected results after the change that syncs the WebKit isEditable
        and WebCore isContentEditable.

        * platform/mac/editing/selection/designmode-no-caret-expected.txt:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Frame::isContentEditable is currently based on two things: Editor::clientIsEditable and
        Document::inDesignMode. In fact, it should only rely on Document::inDesignMode. As a result,
        Editor::clientIsEditable and its client-side implementation can be removed.

        * WebCore.exp.in:
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::isReadOnly):
        * editing/Editor.cpp:
        * editing/Editor.h:
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelectionFromNone):
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::isContentEditable):
        (WebCore::HTMLElement::isContentRichlyEditable):
        * page/DragController.cpp:
        (WebCore::DragController::operationForLoad):
        * page/EditorClient.h:
        * page/Frame.cpp:
        * page/Frame.h:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Remove the WebKit side implementation.

        * src/EditorClientImpl.cpp:
        * src/EditorClientImpl.h:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Remove the WebKit side implementation.

        * WebCoreSupport/EditorClientEfl.cpp:
        * WebCoreSupport/EditorClientEfl.h:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.

        * WebCoreSupport/EditorClientGtk.cpp:
        * WebCoreSupport/EditorClientGtk.h:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_init):
        (webkit_web_view_get_editable):
        (webkit_web_view_set_editable):
        * webkit/webkitwebviewprivate.h:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Remove the WebKit side implementation.

        * WebCoreSupport/EditorClientHaiku.cpp:
        * WebCoreSupport/EditorClientHaiku.h:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.

        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        * WebView/WebView.mm:
        (-[WebView setEditable:]):
        (-[WebView isEditable]):
        * WebView/WebViewData.h:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate):
        (QWebPage::setContentEditable):
        (QWebPage::isContentEditable):
        * Api/qwebpage_p.h:
        * WebCoreSupport/EditorClientQt.cpp:
        * WebCoreSupport/EditorClientQt.h:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Remove the WebKit side implementation.

        * WebCoreSupport/WebEditorClient.cpp:
        * WebCoreSupport/WebEditorClient.h:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Remove the WebKit side implementation.

        * WebCoreSupport/EditorClientWinCE.cpp:
        * WebCoreSupport/EditorClientWinCE.h:
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Ryosuke Niwa.

        Remove the support of Frame::isContentEditable and its dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=54292

        Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.

        * WebFrame.cpp:
        (wxWebFrame::wxWebFrame):
        (wxWebFrame::MakeEditable):
        (wxWebFrame::IsEditable):
        * WebFrame.h:
        * WebKitSupport/EditorClientWx.cpp:
        * WebKitSupport/EditorClientWx.h:
        * WebView.cpp:
        (wxWebView::wxWebView):
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Martin Zoubek <martin.zoubek@acision.com> and Alejandro G. Castro ...
alex@webkit.org [Tue, 1 Mar 2011 01:45:01 +0000 (01:45 +0000)]
2011-02-28  Martin Zoubek  <martin.zoubek@acision.com> and Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        Multithread support for JSC on UNIX
        https://bugs.webkit.org/show_bug.cgi?id=26838

        Implement suspendThread() and resumeThread() for systems with
        pthread.h using thread signal handler.

        * runtime/MachineStackMarker.cpp:
        (JSC::pthreadSignalHandlerSuspendResume):
        (JSC::MachineStackMarker::Thread::Thread):
        (JSC::getCurrentPlatformThread):
        (JSC::suspendThread):
        (JSC::resumeThread):
        (JSC::getPlatformThreadRegisters):
        (JSC::otherThreadStackPointer):
        (JSC::freePlatformThreadRegisters):
        (JSC::MachineStackMarker::markOtherThreadConservatively):
        * wtf/Platform.h: Added Gtk port to use
        ENABLE_JSC_MULTIPLE_THREADS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNumber type input should not handle mouse wheel events if it has no focus.
tkent@chromium.org [Tue, 1 Mar 2011 01:40:22 +0000 (01:40 +0000)]
Number type input should not handle mouse wheel events if it has no focus.
https://bugs.webkit.org/show_bug.cgi?id=53638

Reviewed by Darin Adler.

Source/WebCore:

* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleWheelEventForSpinButton): Check focused().

LayoutTests:

Add a test case.

* fast/forms/input-number-wheel-expected.txt:
* fast/forms/script-tests/input-number-wheel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Noel Gordon <noel.gordon@gmail.com>
commit-queue@webkit.org [Tue, 1 Mar 2011 01:33:49 +0000 (01:33 +0000)]
2011-02-28  Noel Gordon  <noel.gordon@gmail.com>
        Reviewed by James Robinson.

        [chromium] GradientSkia: use the common Gradient stop sorting methods.
        https://bugs.webkit.org/show_bug.cgi?id=54625

        Remove a FIXME: call the Gradient.cpp stop storting routines, no need
        to duplicate that code herein.

        No change in behavior, so no new tests.

        * platform/graphics/skia/GradientSkia.cpp:
        (WebCore::Gradient::platformGradient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Tue, 1 Mar 2011 01:31:35 +0000 (01:31 +0000)]
2011-02-28  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Darin Adler.

        Fix race condition in 4 media tests
        https://bugs.webkit.org/show_bug.cgi?id=55414

        The parser may yield and give events a chance to dispatch between any two tokens. So
        it is possible that the loadstart event fires immediately after the video tag is
        inserted into the document but before the subsequent script is parsed. This is very
        rare in the layout test environment since these small files are loaded from disk.

        This patch eliminates that race condition by allowing waitForEvent to register for
        events that bubble up to the document from any element. Then the registration can
        happen before before the element is inserted into the document.

        * media/video-source-media.html:
        * media/video-source-none-supported.html:
        * media/video-source-type-params.html:
        * media/video-source-type.html:
        * media/video-test.js:
        (waitForEvent):
        (waitForEventAndTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 1 Mar 2011 01:06:21 +0000 (01:06 +0000)]
2011-02-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Darin Adler.

        Stop using DeprecatedPtr for the global exception slot
        https://bugs.webkit.org/show_bug.cgi?id=55424

        Create GCRootPtr to signify that the exception slot is
        a gcroot, and so is exempt from the usual writebarrier
        restrictions.

        * runtime/JSGlobalData.h:
        * runtime/WriteBarrier.h:
        (JSC::GCRootPtr::GCRootPtr):
        (JSC::GCRootPtr::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Steve Block <steveblock@google.com>
steveblock@google.com [Tue, 1 Mar 2011 01:02:30 +0000 (01:02 +0000)]
2011-02-28  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        JNI code should include <jni.h> on non-OSX platforms.
        https://bugs.webkit.org/show_bug.cgi?id=55219

        On Mac we need to include <JavaVM/jni.h> as this is a framework
        include. We include jni.h through JNIUtility.h to minimize the
        number of ifdefs.

        No new tests, build fix only.

        * WebCore.xcodeproj/project.pbxproj
        * bridge/jni/JNIUtility.h:
        * bridge/jni/jni_jsobject.h:
        * bridge/jni/jsc/JNIBridgeJSC.h:
        * bridge/jni/jsc/JavaInstanceJSC.h:
        * bridge/jni/v8/JavaInstanceV8.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Nebojsa Sabovic <neb@chromium.org>
jamesr@google.com [Tue, 1 Mar 2011 00:59:56 +0000 (00:59 +0000)]
2011-02-28  Nebojsa Sabovic  <neb@chromium.org>

        Reviewed by James Robinson.

        [chromium] Pepper plugins render upside down
        https://bugs.webkit.org/show_bug.cgi?id=55101

        No layout tests for pepper plugins (yet).

        * platform/graphics/chromium/PluginLayerChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Tue, 1 Mar 2011 00:57:09 +0000 (00:57 +0000)]
2011-02-28  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Add a way to test the WebKit 2 APIs
        https://bugs.webkit.org/show_bug.cgi?id=55408

        Add the build file for test to the build system.

        * Source/WebKit.pri: Add the include path for WebKit 2 APIs.
        * Source/WebKit.pro: Add the dependency to build the new test project.
2011-02-28  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Add a way to test the WebKit 2 APIs
        https://bugs.webkit.org/show_bug.cgi?id=55408

        Add an initial test for the WebKit 2 APIs of Qt.

        * UIProcess/API/qt/tests/html/basic_page.html: Added.
        * UIProcess/API/qt/tests/qgraphicswkview/qgraphicswkview.pro: Added.
        * UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp: Added.
        (View::View):
        (View::resizeEvent):
        (tst_QGraphicsWKView::init):
        (tst_QGraphicsWKView::cleanup):
        (tst_QGraphicsWKView::loadEmptyPage):
        * UIProcess/API/qt/tests/tests.pri: Added.
        * UIProcess/API/qt/tests/tests.pro: Added.
        * UIProcess/API/qt/tests/util.h: Added.
        (waitForSignal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Tue, 1 Mar 2011 00:54:55 +0000 (00:54 +0000)]
2011-02-28  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Follow HTML5 spec for document.open() a little more closely
        https://bugs.webkit.org/show_bug.cgi?id=55392

        * fast/parser/double-write-from-closed-iframe-expected.txt: Added.
        * fast/parser/double-write-from-closed-iframe.html: Added. Prior to this patch, the second write of 'PASS' could fail indeterminately.
        * fast/parser/script-tests/double-write-from-closed-iframe.js: Added.
        * fast/regex/script-tests/cross-frame-callable.js: Necessary to close late writes.
2011-02-28  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Follow HTML5 spec for document.open() a little more closely
        https://bugs.webkit.org/show_bug.cgi?id=55392

        See: 3.5.1.4 at http://www.whatwg.org/specs/web-apps/current-work/#dom-document-open.

        The second return check matches the spec. The first return check (isExecutingScript())
        was left in place because without it, fast/tokenizer/write-external-script-open.html
        would fail. It also possible there is a spec bug because FF4 crashes on that test and
        IE9 prints "FAILURE." The isLoadingMainResource() check was removed because the main
        resource is always loading while parser->isParsing().

        Test: fast/parser/double-write-from-closed-iframe.html

        * dom/Document.cpp:
        (WebCore::Document::open):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix clang build.
andersca@apple.com [Tue, 1 Mar 2011 00:54:06 +0000 (00:54 +0000)]
Fix clang build.

* UIProcess/API/mac/FindIndicatorWindow.mm:
* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::deprecatedUpdate):
(WebKit::ChunkedUpdateDrawingAreaProxy::didReceiveMessage):
* UIProcess/ChunkedUpdateDrawingAreaProxy.h:
* WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
(WebKit::ChunkedUpdateDrawingArea::deprecatedResumePainting):
(WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
* WebProcess/WebPage/ChunkedUpdateDrawingArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Avi Drissman <avi@google.com>
commit-queue@webkit.org [Tue, 1 Mar 2011 00:51:45 +0000 (00:51 +0000)]
2011-02-28  Avi Drissman  <avi@google.com>

        Reviewed by James Robinson.

        WebCursorInfo needs to match enums in platform/Cursor.h
        https://bugs.webkit.org/show_bug.cgi?id=55094

        * platform/chromium/CursorChromium.cpp:
        (WebCore::grabCursor):
        (WebCore::grabbingCursor):
        * platform/chromium/PlatformCursor.h:
2011-02-28  Avi Drissman  <avi@google.com>

        Reviewed by James Robinson.

        WebCursorInfo needs to match enums in platform/Cursor.h
        https://bugs.webkit.org/show_bug.cgi?id=55094

        * public/WebCursorInfo.h:
        * src/AssertMatchingEnums.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 1 Mar 2011 00:49:44 +0000 (00:49 +0000)]
2011-02-28  James Robinson  <jamesr@chromium.org>

        Update chromium expectations and baselines.

        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/001-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/001-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/002-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/002-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/003-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/003-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/004-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/004-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/005-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/005-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/006-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/006-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/007-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/001-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/001-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/002-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/002-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/003-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/003-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/004-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/004-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/005-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/005-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/006-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/006-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/007-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
        * platform/chromium-linux/fast/forms/select-listbox-multiple-no-focusring-expected.checksum: Added.
        * platform/chromium-linux/fast/forms/select-listbox-multiple-no-focusring-expected.png: Added.
        * platform/chromium-linux/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/001-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/001-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/001-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/002-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/002-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/002-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/003-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/003-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/003-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/004-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/004-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/004-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/005-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/005-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/005-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/006-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/006-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/006-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/007-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-lr/007-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/001-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/001-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/001-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/002-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/002-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/002-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/003-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/003-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/003-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/004-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/004-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/004-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/005-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/005-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/005-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/006-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/006-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/006-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/007-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/auto/vertical-rl/007-expected.txt: Added.
        * platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.checksum: Added.
        * platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.png: Added.
        * platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Added.
        * platform/chromium/fast/dom/prototype-inheritance-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDo not copy config.h into WebKit2.
mitz@apple.com [Tue, 1 Mar 2011 00:02:45 +0000 (00:02 +0000)]
Do not copy config.h into WebKit2.

Rubber-stamped by Anders Carlsson.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLLVM Compiler build fix.
mitz@apple.com [Mon, 28 Feb 2011 23:59:14 +0000 (23:59 +0000)]
LLVM Compiler build fix.

* Scripts/webkit2/messages.py:
* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStart running InjectedBundle API tests on Windows
aroben@apple.com [Mon, 28 Feb 2011 23:59:04 +0000 (23:59 +0000)]
Start running InjectedBundle API tests on Windows

A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL.

Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows

Reviewed by Darin Adler.

Source/WebKit/win:

Build TestWebKitAPIInjectedBundle on Windows

* WebKit.vcproj/WebKit.sln: Added TestWebKitAPIInjectedBundle. Let VS simplify the paths to
the project files.

Tools:

* TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added.
* TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added.
* TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added.
* TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added.
* TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added.
These are just extracted from TestWebKitAPI.vcproj.

* TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets
up the DLL's filename.

* TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name.
(TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of
0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string.

* TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus
"all" configuration.

* TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added
injected bundle tests. Let VS resort things.

* TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 28 Feb 2011 23:55:34 +0000 (23:55 +0000)]
2011-02-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein, Sam Weinig, Alexey Proskuryakov and Darin Adler.

        Open PDF in Preview doesn't work
        https://bugs.webkit.org/show_bug.cgi?id=55400
        <rdar://problem/8750353>

        * UIProcess/API/mac/PDFViewController.mm:
        (-[WKPDFView initWithFrame:PDFViewController:]):
        Set the WKPDFView as the delegate of itself.

        (-[WKPDFView PDFViewOpenPDFInNativeApplication:]):
        Call PDFViewController::openPDFInFinder.

        (WebKit::PDFViewController::PDFViewController):
        Initialize m_hasWrittenPDFToDisk to false.

        (WebKit::PDFViewController::openPDFInFinder):
        Write the PDF to disk if needed and then open it using -[NSWorkspace openFile:].

        (WebKit::temporaryPDFDirectoryPath):
        Create a directory to put PDFs in.

        (WebKit::PDFViewController::pathToPDFOnDisk):
        Return a path to a (non-existent) file in the temporary PDF directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Mon, 28 Feb 2011 23:50:27 +0000 (23:50 +0000)]
2011-02-28  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        [Mac] Make "Change back to …" contextual menu item work with new autocorrection.
        https://bugs.webkit.org/show_bug.cgi?id=55396
        <rdar://problem/8836093>

        The change in InlineTextBox.cpp fixes a bug, where the rectangle of Replacement marker isn't
        calculated. We need this to do hit test when deciding whether to show "Change back to ..." on
        contextual menu.

        The change in Editor.cpp is for notifying spellchecker about the reversion whenever "Change
        back to ..." is clicked.

        * editing/Editor.cpp:
        (WebCore::Editor::changeBackToReplacedString):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintDocumentMarkers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Victoria Kirst <vrk@google.com>
commit-queue@webkit.org [Mon, 28 Feb 2011 23:35:54 +0000 (23:35 +0000)]
2011-02-28  Victoria Kirst  <vrk@google.com>

        Reviewed by Kenneth Russell.

        [chromium] Fall back to texSubImage2D when mapTexSubImage2D fails in VideoLayerChromium
        https://bugs.webkit.org/show_bug.cgi?id=55269

        Mesa does not support mapTexSubImage2D, so this change lets
        GPU-accelerated video work with DRT layout tests.

        * platform/graphics/chromium/VideoLayerChromium.cpp:
        (WebCore::VideoLayerChromium::updateTexture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Mon, 28 Feb 2011 23:33:28 +0000 (23:33 +0000)]
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Antonio Gomes.

        REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
        https://bugs.webkit.org/show_bug.cgi?id=55323

        Added test case that draws focus rings on selected items when spatial navigation is enabled.

        * fast/spatial-navigation/snav-multiple-select-focusring.html: Added.
        * platform/mac/fast/spatial-navigation: Added.
        * platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.checksum: Added.
        * platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.png: Added.
        * platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with...
hyatt@apple.com [Mon, 28 Feb 2011 23:21:36 +0000 (23:21 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46500, make positioned elements work with vertical text.  Change staticX and staticY
to be staticInlinePosition and staticBlockPosition.  Patch all of the computations involving these variables to be writing
mode aware.  Mixed writing modes are not yet supported.

Reviewed by Dan Bernstein.

Added new tests in fast/block/positioning/auto.

Source/WebCore:

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::layoutPositionedObjects):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::startOffsetForLine):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::appendRunsForObject):
(WebCore::setStaticPositions):
(WebCore::RenderBlock::skipTrailingWhitespace):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::positionLineBox):
(WebCore::computeInlineStaticDistance):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::computeBlockStaticDistance):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::borderAndPaddingLogicalLeft):
(WebCore::RenderBoxModelObject::borderAndPaddingStart):
(WebCore::RenderBoxModelObject::borderLogicalLeft):
(WebCore::RenderBoxModelObject::borderLogicalRight):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::relativePositionedInlineOffset):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::staticInlinePosition):
(WebCore::RenderLayer::staticBlockPosition):
(WebCore::RenderLayer::setStaticInlinePosition):
(WebCore::RenderLayer::setStaticBlockPosition):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::hasAutoLeftAndRight):
(WebCore::InheritedFlags::hasAutoTopAndBottom):
(WebCore::InheritedFlags::hasStaticInlinePosition):
(WebCore::InheritedFlags::hasStaticBlockPosition):

LayoutTests:

* fast/block/positioning/auto/vertical-lr: Added.
* fast/block/positioning/auto/vertical-lr/001.html: Added.
* fast/block/positioning/auto/vertical-lr/002.html: Added.
* fast/block/positioning/auto/vertical-lr/003.html: Added.
* fast/block/positioning/auto/vertical-lr/004.html: Added.
* fast/block/positioning/auto/vertical-lr/005.html: Added.
* fast/block/positioning/auto/vertical-lr/006.html: Added.
* fast/block/positioning/auto/vertical-lr/007.html: Added.
* fast/block/positioning/auto/vertical-rl: Added.
* fast/block/positioning/auto/vertical-rl/001.html: Added.
* fast/block/positioning/auto/vertical-rl/002.html: Added.
* fast/block/positioning/auto/vertical-rl/003.html: Added.
* fast/block/positioning/auto/vertical-rl/004.html: Added.
* fast/block/positioning/auto/vertical-rl/005.html: Added.
* fast/block/positioning/auto/vertical-rl/006.html: Added.
* fast/block/positioning/auto/vertical-rl/007.html: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/001-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/001-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/001-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/002-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/002-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/002-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/003-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/003-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/003-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/004-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/004-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/004-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/005-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/005-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/005-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/006-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/006-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/006-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-lr/007-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/001-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/001-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/001-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/002-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/002-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/002-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/003-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/003-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/003-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/004-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/004-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/004-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/005-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/005-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/005-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/006-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/006-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/006-expected.txt: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.checksum: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
* platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Dan Bernstein.
ap@apple.com [Mon, 28 Feb 2011 23:05:48 +0000 (23:05 +0000)]
    Reviewed by Dan Bernstein.

        Frequent crashes in CFURLCache code on Snow Leopard
        https://bugs.webkit.org/show_bug.cgi?id=55412
        <rdar://problem/9063922>

        CString is evil, it has two lengths which can be different - specifically, fileSystemRepresentation()
        creates a string with maximum possible buffer size. A path with garbage at the end confused
        CFURLCache into corrupting its data structures.

        * Shared/WebProcessCreationParameters.h: Added a FIXME about merging Mac and Windows code.
        This problem wouldn't have occured if we didn't use CString in the first place.

        * UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformInitializeWebProcess):
        Added an assertion matching Windows behavior (seems likely that NSURLCache also wouldn't
        have liked trailing slash).

        * UIProcess/win/WebContextWin.cpp: (WebKit::WebContext::platformInitializeWebProcess):
        Made slash removal conditional for robustness.

        * WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeWebProcess):
        Use actual string length, not CString::length().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Mon, 28 Feb 2011 22:48:29 +0000 (22:48 +0000)]
2011-02-28  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Anders Carlsson.

        [Qt][WK2] Plugin initialization
        https://bugs.webkit.org/show_bug.cgi?id=48127

        * Source/WebKit.pri: Lift the definition of the XP_UNIX macro
        from WebCore.pri to WebKit.pri to apply it to WebKit2 as well.
2011-02-28  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Anders Carlsson.

        [Qt][WK2] Plugin initialization
        https://bugs.webkit.org/show_bug.cgi?id=48127

        No function change so no new tests.

        * WebCore.pri: Lift the definition of the XP_UNIX macro
        from WebCore.pri to WebKit.pri to apply it to WebKit2 as well.
2011-02-28  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Anders Carlsson.

        [Qt][WK2] Plugin initialization
        https://bugs.webkit.org/show_bug.cgi?id=48127

        Specialize the way of initializing the plugin for X11.
        Introduce PLUGIN_ARCHITECTURE macros to allow code sharing
        across platforms.

        * Shared/Plugins/Netscape/NetscapePluginModule.cpp:
        (WebKit::NetscapePluginModule::tryLoad):
        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 28 Feb 2011 22:40:30 +0000 (22:40 +0000)]
2011-02-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        Use more xcconfig files in JavaScriptCore gyp build
        https://bugs.webkit.org/show_bug.cgi?id=55391

        The GYP experts tell me that we have have a total of two xcconfig
        files: one for the xcodeproj as a whole and one for each target.  This
        patch uses that technique to re-use the existing xcconfig files and
        eliminate the duplication.

        Technically, this patch introduces some build errors because the
        xcconfig files assume that the xcodeproj file is one level higher in
        the directory hierarchy.  Specifically, the xcodeproj file can no
        longer find the Info.plist or the prefix header.  I plan to fix that in
        a subsequent patch.

        Also, this patch introduces the Release and Production configurations,
        which should work correctly now.

        * gyp/JavaScriptCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Dean Jackson <dino@apple.com>
dino@apple.com [Mon, 28 Feb 2011 22:32:38 +0000 (22:32 +0000)]
2011-02-28  Dean Jackson  <dino@apple.com>

        Reviewed by Eric Carlson.

        https://bugs.webkit.org/show_bug.cgi?id=55239

        Allow webkitEnterFullScreen to be called from outside
        a user gesture, but only when the correct restrictions
        have been lifted in WebCore. Add a new restriction type
        for this situation. Meanwhile, expose the current
        restrictions externally from HTMLMediaElement, so that
        clients can easily set restrictions on their port.

        No new tests. This doesn't change existing behavior. Some
        WebKit clients may lift the restriction.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement):
        - ensure restrictions initialize with fullscreen restricted
        * html/HTMLMediaElement.h:
        (WebCore::HTMLMediaElement::requireUserGestureForLoad):
        (WebCore::HTMLMediaElement::requireUserGestureForRateChange):
        (WebCore::HTMLMediaElement::requireUserGestureForFullScreen):
        (WebCore::HTMLMediaElement::setBehaviorRestrictions):
        - new methods to expose the current restrictions
        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::webkitEnterFullscreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Jungshik Shin <jshin@chromium.org>
jshin@chromium.org [Mon, 28 Feb 2011 22:18:37 +0000 (22:18 +0000)]
2011-02-28  Jungshik Shin  <jshin@chromium.org>

        https://bugs.webkit.org/show_bug.cgi?id=55121

        [chromium] Unreviewed change of test_expectations.txt
        With the platform-specific expectation file landed in r79912,
        fast/xsl/sort-locale-expected.txt should pass now on chromium.
        So, remove it from the failure list.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
inferno@chromium.org [Mon, 28 Feb 2011 22:14:21 +0000 (22:14 +0000)]
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r78789.
        http://trac.webkit.org/changeset/78789
        https://bugs.webkit.org/show_bug.cgi?id=55409

        Incorrect canvas fallback implementation (Requested by
        inferno-sec on #webkit).

        * public/WebAccessibilityRole.h:
        * src/AssertMatchingEnums.cpp:
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r78789.
        http://trac.webkit.org/changeset/78789
        https://bugs.webkit.org/show_bug.cgi?id=55409

        Incorrect canvas fallback implementation (Requested by
        inferno-sec on #webkit).

        * AccessibleBase.cpp:
        (MSAARole):
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r78789.
        http://trac.webkit.org/changeset/78789
        https://bugs.webkit.org/show_bug.cgi?id=55409

        Incorrect canvas fallback implementation (Requested by
        inferno-sec on #webkit).

        * accessibility/AccessibilityObject.h:
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
        (WebCore::AccessibilityRenderObject::canHaveChildren):
        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (atkRole):
        * accessibility/mac/AccessibilityObjectWrapper.mm:
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::isFocusable):
        * rendering/RenderHTMLCanvas.cpp:
        * rendering/RenderHTMLCanvas.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaint):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::write):
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r78789.
        http://trac.webkit.org/changeset/78789
        https://bugs.webkit.org/show_bug.cgi?id=55409

        Incorrect canvas fallback implementation (Requested by
        inferno-sec on #webkit).

        * accessibility/canvas-fallback-content-expected.txt: Removed.
        * accessibility/canvas-fallback-content.html: Removed.
        * accessibility/canvas.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
inferno@chromium.org [Mon, 28 Feb 2011 22:09:45 +0000 (22:09 +0000)]
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79425.
        http://trac.webkit.org/changeset/79425
        https://bugs.webkit.org/show_bug.cgi?id=55406

        Incorrect canvas fallback implementation. (Requested by
        inferno-sec on #webkit).

        * canvas/canvas-mouse-events-expected.txt: Removed.
        * canvas/canvas-mouse-events.html: Removed.
        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:
        * platform/win-wk2/Skipped:
2011-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79425.
        http://trac.webkit.org/changeset/79425
        https://bugs.webkit.org/show_bug.cgi?id=55406

        Incorrect canvas fallback implementation. (Requested by
        inferno-sec on #webkit).

        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
jhoneycutt@apple.com [Mon, 28 Feb 2011 22:00:58 +0000 (22:00 +0000)]
Windows build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Add symbol to export.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Mon, 28 Feb 2011 21:55:18 +0000 (21:55 +0000)]
2011-02-28  Adam Klein  <adamk@chromium.org>

        Reviewed by Adam Barth.

        [fileapi] Implement LocalFileSystem.resolveLocalFileSystemURI
        https://bugs.webkit.org/show_bug.cgi?id=54774

        Tests for resolveLocalFileSystemURI.

        * fast/filesystem/resolve-uri-expected.txt: Added.
        * fast/filesystem/resolve-uri.html: Added.
        * fast/filesystem/script-tests/resolve-uri.js: Added.
2011-02-28  Adam Klein  <adamk@chromium.org>

        Reviewed by Adam Barth.

        [fileapi] Implement LocalFileSystem.resolveLocalFileSystemURI
        https://bugs.webkit.org/show_bug.cgi?id=54774

        See http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#methods
        for the spec implemented by this patch.

        Test: fast/filesystem/resolve-uri.html

        * fileapi/DOMFileSystemBase.cpp:
        (WebCore::DOMFileSystemBase::crackFileSystemURL):
        * fileapi/DOMFileSystemBase.h:
        Added constants for "temporary" and "persistent".
        * fileapi/EntryBase.cpp:
        Replace hardcoded strings with aforementioned constants.
        * fileapi/FileSystemCallbacks.cpp:
        (WebCore::ResolveURICallbacks::create):
        (WebCore::ResolveURICallbacks::ResolveURICallbacks):
        (WebCore::ResolveURICallbacks::didOpenFileSystem):
        Chains a call of openFileSystem to calls to getDirectory/getFile.
        * fileapi/FileSystemCallbacks.h:
        * fileapi/LocalFileSystem.cpp:
        (WebCore::LocalFileSystem::readFileSystem):
        * fileapi/LocalFileSystem.h:
        Remove size argument from readFileSystem()
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::resolveLocalFileSystemURI):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
2011-02-28  Adam Klein  <adamk@chromium.org>

        Reviewed by Adam Barth.

        [fileapi] Implement LocalFileSystem.resolveLocalFileSystemURI
        https://bugs.webkit.org/show_bug.cgi?id=54774

        * src/LocalFileSystemChromium.cpp:
        (WebCore::LocalFileSystem::readFileSystem):
        Removed size argument to readFileSystem()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix for Qt port after API changes of http://trac.webkit.org/changeset/79904.
ossy@webkit.org [Mon, 28 Feb 2011 21:51:58 +0000 (21:51 +0000)]
Build fix for Qt port after API changes of trac.webkit.org/changeset/79904.

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-02-28
Reviewed by Oliver Hunt.

Source/WebCore:

* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtConnectionObject::execute):

Source/WebKit/qt:

* Api/qwebelement.cpp:
(QWebElement::evaluateJavaScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Mon, 28 Feb 2011 21:41:26 +0000 (21:41 +0000)]
2011-02-28  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium rebaseline.

        Fix 3 tests for Snow Leopard by removing out of date chromium-mac
        baselines (there are already chromium-mac-leopard results).

        Revert rebaseline done by r79881 since the behavior was reverted by
        r79900.

        * platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Removed.
        * platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Removed.
        * platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Removed.
        * platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Removed.
        * platform/chromium-mac/fast/forms/placeholder-position-expected.checksum: Removed.
        * platform/chromium-mac/fast/forms/placeholder-position-expected.png: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/forms/listbox-hit-test-zoomed-expected.checksum:
        * platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWK2 Context Menus - Implement LookUpInDictionary
weinig@apple.com [Mon, 28 Feb 2011 21:39:27 +0000 (21:39 +0000)]
WK2 Context Menus - Implement LookUpInDictionary
https://bugs.webkit.org/show_bug.cgi?id=55405

Reviewed by Brady Eidson.

* Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
* Shared/DictionaryPopupInfo.h:
Add type to differentiate between HotKey and ContextMenu triggered
dictionary popups. This is necessary since HotKey triggered ones want
to override the style to always be overlay.

* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup):
Only force the overlay style for HotKey triggered dictionary lookups.

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::performDictionaryLookupForRange):
Factor out shared functionality into performDictionaryLookupForRange.

* WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::lookUpInDictionary):
Get selected range and call newly factored out performDictionaryLookupForRange.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Jungshik Shin <jshin@chromium.org>
jshin@chromium.org [Mon, 28 Feb 2011 21:35:13 +0000 (21:35 +0000)]
2011-02-28  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Tony Chang

        https://bugs.webkit.org/show_bug.cgi?id=55121

[chromium] Recently, French Academy changed the sorting
rules for French in such a way that accents are not weighted
from the end of a word any more. ICU 4.6 / CLDR 1.9
incorporated the change. Canadian French hasn't adopted the
change, yet.

        Chrome is the only port that uses new rules with ICU 4.6. So,
        for now, I'm changing the expectation file for Chrome only.

        * platform/chromium/fast/xsl: Added.
        * platform/chromium/fast/xsl/sort-locale-expected.txt: Copied from LayoutTests/fast/xsl/sort-locale-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove some duplicate code from KURLGoogle.cpp
levin@chromium.org [Mon, 28 Feb 2011 21:07:41 +0000 (21:07 +0000)]
Remove some duplicate code from KURLGoogle.cpp
https://bugs.webkit.org/show_bug.cgi?id=55266

Reviewed by Darin Adler.

No change in functionality so no new tests.

* WebCore.gyp/WebCore.gyp: Make KURL.cpp get built by Chromium.
* platform/KURL.cpp:
Simply moved #include's and some code that was identical (i.e.
had been copied) to KURLGoogle.cpp outside of ifdef !USE(GOOGLEURL)
to reduce duplication.
* platform/KURLGoogle.cpp:
Removed the duplicate code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 28 Feb 2011 21:07:24 +0000 (21:07 +0000)]
2011-02-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        Use more xcconfig files in JavaScriptGlue gyp build
        https://bugs.webkit.org/show_bug.cgi?id=55395

        Technically this patch breaks the build because the generated project
        can't find the Info.plist file or the list of exported symbols.  I'll
        fix that in a follow-up patch.

        * gyp/JavaScriptGlue.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 28 Feb 2011 21:05:22 +0000 (21:05 +0000)]
2011-02-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Make ScopeChainNode GC allocated
        https://bugs.webkit.org/show_bug.cgi?id=55283

        Simplify lifetime and other issues with the scopechain
        by making it gc allocated.  This allows us to simplify
        function exit and unwinding, as well as making the
        current iterative refcounting go away.

        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::createActivation):
        * bytecode/StructureStubInfo.cpp:
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::generate):
        (JSC::BytecodeGenerator::BytecodeGenerator):
        (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
        (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
        * bytecompiler/BytecodeGenerator.h:
        * debugger/Debugger.cpp:
        (JSC::Recompiler::operator()):
        * debugger/DebuggerCallFrame.h:
        (JSC::DebuggerCallFrame::scopeChain):
        * interpreter/CachedCall.h:
        (JSC::CachedCall::CachedCall):
        * interpreter/CallFrame.h:
        * interpreter/Interpreter.cpp:
        (JSC::depth):
        (JSC::Interpreter::unwindCallFrame):
        (JSC::Interpreter::throwException):
        (JSC::Interpreter::execute):
        (JSC::Interpreter::executeCall):
        (JSC::Interpreter::executeConstruct):
        (JSC::Interpreter::privateExecute):
        * jit/JITCall.cpp:
        (JSC::JIT::compileOpCallInitializeCallFrame):
        (JSC::JIT::compileOpCall):
        * jit/JITCall32_64.cpp:
        (JSC::JIT::compileOpCallInitializeCallFrame):
        (JSC::JIT::emit_op_ret):
        (JSC::JIT::emit_op_ret_object_or_this):
        (JSC::JIT::compileOpCall):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_end):
        (JSC::JIT::emit_op_ret):
        (JSC::JIT::emit_op_ret_object_or_this):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::emit_op_end):
        * jit/JITStubs.cpp:
        (JSC::DEFINE_STUB_FUNCTION):
        * jit/JITStubs.h:
        * runtime/ArgList.cpp:
        * runtime/Completion.cpp:
        (JSC::evaluate):
        * runtime/Completion.h:
        * runtime/DateConversion.cpp:
        * runtime/Executable.cpp:
        (JSC::EvalExecutable::compileInternal):
        (JSC::ProgramExecutable::compileInternal):
        (JSC::FunctionExecutable::compileForCallInternal):
        (JSC::FunctionExecutable::compileForConstructInternal):
        * runtime/FunctionConstructor.cpp:
        (JSC::constructFunction):
        * runtime/GCActivityCallbackCF.cpp:
        * runtime/Identifier.cpp:
        * runtime/JSCell.h:
        * runtime/JSChunk.cpp: Added.
        * runtime/JSChunk.h: Added.
        * runtime/JSFunction.cpp:
        (JSC::JSFunction::JSFunction):
        (JSC::JSFunction::markChildren):
        (JSC::JSFunction::getCallData):
        (JSC::JSFunction::getOwnPropertySlot):
        (JSC::JSFunction::getConstructData):
        * runtime/JSFunction.h:
        (JSC::JSFunction::scope):
        (JSC::JSFunction::setScope):
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        * runtime/JSGlobalData.h:
        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::init):
        (JSC::JSGlobalObject::markChildren):
        * runtime/JSGlobalObject.h:
        (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
        (JSC::JSGlobalObject::globalScopeChain):
        * runtime/JSGlobalObjectFunctions.cpp:
        (JSC::globalFuncEval):
        * runtime/JSLock.cpp:
        * runtime/JSNumberCell.cpp:
        * runtime/JSZombie.cpp:
        * runtime/MarkedBlock.cpp:
        * runtime/MarkedSpace.cpp:
        * runtime/PropertyNameArray.cpp:
        * runtime/ScopeChain.cpp:
        (JSC::ScopeChainNode::print):
        (JSC::ScopeChainNode::localDepth):
        (JSC::ScopeChainNode::markChildren):
        * runtime/ScopeChain.h:
        (JSC::ScopeChainNode::ScopeChainNode):
        (JSC::ScopeChainNode::createStructure):
        (JSC::ScopeChainNode::push):
        (JSC::ScopeChainNode::pop):
        (JSC::ScopeChainIterator::ScopeChainIterator):
        (JSC::ScopeChainIterator::operator*):
        (JSC::ScopeChainIterator::operator->):
        (JSC::ScopeChainIterator::operator++):
        (JSC::ScopeChainNode::begin):
        (JSC::ScopeChainNode::end):
        (JSC::ExecState::globalData):
        (JSC::ExecState::lexicalGlobalObject):
        (JSC::ExecState::globalThisValue):
        * runtime/ScopeChainMark.h:
        * wtf/DateMath.cpp:
2011-02-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Make ScopeChainNode GC allocated
        https://bugs.webkit.org/show_bug.cgi?id=55283

        Update WebCore to deal with the absence of the ScopeChain
        class.

        * ForwardingHeaders/runtime/ScopeChain.h: Added.
        * bindings/js/JSHTMLElementCustom.cpp:
        (WebCore::JSHTMLElement::pushEventHandlerScope):
        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        (WebCore::JSJavaScriptCallFrame::scopeChain):
        (WebCore::JSJavaScriptCallFrame::scopeType):
        * bindings/js/JSLazyEventListener.cpp:
        (WebCore::JSLazyEventListener::initializeJSFunction):
        * bindings/js/JSMainThreadExecState.h:
        (WebCore::JSMainThreadExecState::evaluate):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::pushEventHandlerScope):
        * bindings/js/JavaScriptCallFrame.cpp:
        (WebCore::JavaScriptCallFrame::scopeChain):
        * bindings/js/JavaScriptCallFrame.h:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/c/c_class.cpp:
        * bridge/c/c_runtime.cpp:
        * bridge/jni/JNIBridge.cpp:
        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtConnectionObject::execute):
        * plugins/PluginViewNone.cpp:
2011-02-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Make ScopeChainNode GC allocated
        https://bugs.webkit.org/show_bug.cgi?id=55283

        More updates for the absence of the ScopeChain class

        * WebView/WebScriptDebugDelegate.mm:
        (-[WebScriptCallFrame scopeChain]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Mon, 28 Feb 2011 20:51:44 +0000 (20:51 +0000)]
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Adele Peterson.

        REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
        https://bugs.webkit.org/show_bug.cgi?id=55323

        Added test case to make sure no focus ring is drawn on selected items.

        * fast/forms/select-listbox-multiple-no-focusring.html: Added.
        * platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.checksum: Added.
        * platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.png: Added.
        * platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Added.
2011-02-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Adele Peterson.

        REGRESSION (r79762): Items in <select multiple> have focus rings, but shouldn't
        https://bugs.webkit.org/show_bug.cgi?id=55323

        Draw focus ring on selected items only if spatial navigation is enabled.

        Test: fast/forms/select-listbox-multiple-no-focusring.html

        * rendering/RenderBlock.h:
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::addFocusRingRects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Mon, 28 Feb 2011 20:29:51 +0000 (20:29 +0000)]
2011-02-28  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Anders Carlsson.

        We can cancel the plugin load and fail with error before m_manualStream
        got a chance to initialize in PluginView::didReceiveResponse. This can
        happen when we run pending document onload events during plugin load that
        remove the frame from underneath. So, change the assert into a null check.
        https://bugs.webkit.org/show_bug.cgi?id=55307

        * plugins/PluginView.cpp:
        (WebCore::PluginView::didFail):
2011-02-28  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Anders Carlsson.

        Unskip crashing test fast/frames/iframe-plugin-load-remove-document-crash.html.
        https://bugs.webkit.org/show_bug.cgi?id=55307

        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
commit-queue@webkit.org [Mon, 28 Feb 2011 20:25:04 +0000 (20:25 +0000)]
2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Alexey Proskuryakov.

        Build fix for Intel ICC Compiler.
        https://bugs.webkit.org/show_bug.cgi?id=55221

        The virtual inheritance seems to confuse ICC.
        Anything that links with webkit has an undefined reference otherwise.

        * svg/SVGTransformable.cpp:
        (WebCore::SVGTransformable::~SVGTransformable):
        * svg/SVGTransformable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-02-28 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Mon, 28 Feb 2011 20:18:14 +0000 (20:18 +0000)]
2011-02-28  Adam Klein  <adamk@chromium.org>

        Reviewed by James Robinson.

        [chromium] Remove "PASS TEXT" expectation for fast/filesystem/op-get-entry.html
        https://bugs.webkit.org/show_bug.cgi?id=55262

        Test now passes as Chromium has rolled past r76098.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt]tst_QDeclarativeWebView - 8 test cases fail
ossy@webkit.org [Mon, 28 Feb 2011 20:12:40 +0000 (20:12 +0000)]
[Qt]tst_QDeclarativeWebView - 8 test cases fail
https://bugs.webkit.org/show_bug.cgi?id=55214

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-02-28
Reviewed by Andreas Kling.

Fix the API tests for the QML WebView element. The default size of the element should be the size of the QGraphicsWebView
if no preferred width or height are provided (see http://trac.webkit.org/changeset/79672).
I also refactored the tests so we don't use the network but instead a local html file.
QML doesn't support qrc loading so I had to workaround by using a property that I update afterwards.

* tests/qdeclarativewebview/resources/sample.html: Added.
* tests/qdeclarativewebview/resources/webviewtest.qml:
* tests/qdeclarativewebview/resources/webviewtestdefault.qml:
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
(tst_QDeclarativeWebView::preferredWidthTest):
(tst_QDeclarativeWebView::preferredHeightTest):
(tst_QDeclarativeWebView::preferredWidthDefaultTest):
(tst_QDeclarativeWebView::preferredHeightDefaultTest):
* tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79894 268f45cc-cd09-0410-ab3c-d52691b4dbfc