WebKit-https.git
17 months agoRemove duplicate layout test results
simon.fraser@apple.com [Mon, 3 Aug 2020 17:27:52 +0000 (17:27 +0000)]
Remove duplicate layout test results
https://bugs.webkit.org/show_bug.cgi?id=215069

Reviewed by Darin Adler.

Remove results deleted by check-for-duplicated-platform-test-results.

* platform/glib/imported/w3c/web-platform-tests/cors/credentials-flag-expected.txt: Removed.
* platform/glib/imported/w3c/web-platform-tests/css/css-animations/Element-getAnimations.tentative-expected.txt: Removed.
* platform/glib/imported/w3c/web-platform-tests/css/css-sizing/percentage-height-in-flexbox-expected.txt: Removed.
* platform/glib/imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch-expected.txt: Removed.
* platform/glib/imported/w3c/web-platform-tests/eventsource/format-field-id-2-expected.txt: Removed.
* platform/glib/imported/w3c/web-platform-tests/eventsource/format-field-id-expected.txt: Removed.
* platform/glib/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any-expected.txt: Removed.
* platform/glib/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any.worker-expected.txt: Removed.
* platform/glib/imported/w3c/web-platform-tests/svg/shapes/scripted/disabled-shapes-not-hit-expected.txt: Removed.
* platform/gtk/fast/backgrounds/size/contain-and-cover-expected.txt: Removed.
* platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
* platform/gtk/fast/forms/fieldset/fieldset-elements-htmlcollection-expected.txt: Removed.
* platform/gtk/fast/tokenizer/script_extra_close-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-from-image-computed-style-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-none-computed-style-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/animations/seeking-events-4-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/embedded/image-fractional-width-vertical-fidelity-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-001-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-002-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-003-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-001-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-002-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-003-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-001-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-002-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-003-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-invalid-base-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-001-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-002-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-003-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/painting/marker-009-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-001-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-003-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-011-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-012-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-013-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-strokewidth-non-scaling-stroke-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-userspaceonuse-non-scaling-stroke-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/painting/reftests/mask-print-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-mutating-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-zero-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-mutating-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-01.tentative-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-02.tentative-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-01.tentative-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-02.tentative-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-empty-string-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-xhtml.tentative-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/struct/reftests/use-adopted-with-external-resource.tentative-expected.txt: Removed.
* platform/gtk/imported/w3c/web-platform-tests/svg/struct/reftests/use-inheritance-001-expected.txt: Removed.
* platform/gtk/media/video-controls-no-scripting-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
* platform/gtk/svg/custom/circular-marker-reference-2-expected.txt: Removed.
* platform/gtk/svg/custom/non-circular-marker-reference-expected.txt: Removed.
* platform/ios-13/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt: Removed.
* platform/ios-13/fast/forms/input-double-click-selection-gap-bug-expected.txt: Removed.
* platform/ios-13/fast/inline/br-text-decoration-expected.txt: Removed.
* platform/ios-13/fast/layers/inline-dirty-z-order-lists-expected.txt: Removed.
* platform/ios-13/fast/replaced/percent-height-in-anonymous-block-widget-expected.txt: Removed.
* platform/ios-13/fast/text/international/bidi-LDB-2-CSS-expected.txt: Removed.
* platform/ios-13/fast/text/international/bidi-LDB-2-HTML-expected.txt: Removed.
* platform/ios-13/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt: Removed.
* platform/ios-simulator/fast/canvas/webgl/copy-tex-image-and-sub-image-2d-bad-input-expected.txt: Removed.
* platform/ios-simulator/webgl/2.0.0/conformance/buffers/buffer-uninitialized-expected.txt: Removed.
* platform/ios-simulator/webgl/2.0.0/conformance/extensions/webgl-draw-buffers-framebuffer-unsupported-expected.txt: Removed.
* platform/ios-simulator/webgl/2.0.0/conformance/glsl/misc/shaders-with-invariance-expected.txt: Removed.
* platform/ios-simulator/webgl/2.0.0/conformance/reading/read-pixels-test-expected.txt: Removed.
* platform/ios-simulator/webgl/2.0.0/conformance2/rendering/clear-srgb-color-buffer-expected.txt: Removed.
* platform/ios-simulator/webgl/2.0.0/conformance2/textures/misc/tex-3d-size-limit-expected.txt: Removed.
* platform/ios-wk2/compositing/overflow/overflow-scroll-expected.txt: Removed.
* platform/ios-wk2/compositing/overflow/scrollbar-painting-expected.txt: Removed.
* platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-004a-expected.txt: Removed.
* platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-004b-expected.txt: Removed.
* platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-004c-expected.txt: Removed.
* platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-004d-expected.txt: Removed.
* platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-004e-expected.txt: Removed.
* platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-004f-expected.txt: Removed.
* platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-005a-expected.txt: Removed.
* platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-005b-expected.txt: Removed.
* platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-005c-expected.txt: Removed.
* platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-005d-expected.txt: Removed.
* platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-009a-expected.txt: Removed.
* platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-009b-expected.txt: Removed.
* platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-009e-expected.txt: Removed.
* platform/ios-wk2/css2.1/20110323/abspos-containing-block-initial-009f-expected.txt: Removed.
* platform/ios-wk2/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt: Removed.
* platform/ios-wk2/fast/clip/014-expected.txt: Removed.
* platform/ios-wk2/fast/dom/Window/window-lookup-precedence-expected.txt: Removed.
* platform/ios-wk2/fast/dom/elementFromPoint-relative-to-viewport-expected.txt: Removed.
* platform/ios-wk2/fast/forms/input-text-click-inside-expected.txt: Removed.
* platform/ios-wk2/fast/forms/input-text-self-emptying-click-expected.txt: Removed.
* platform/ios-wk2/fast/forms/tabbing-input-iframe-expected.txt: Removed.
* platform/ios-wk2/fast/html/details-add-summary-1-and-click-expected.txt: Removed.
* platform/ios-wk2/fast/html/details-add-summary-10-and-click-expected.txt: Removed.
* platform/ios-wk2/fast/html/details-add-summary-2-and-click-expected.txt: Removed.
* platform/ios-wk2/fast/html/details-add-summary-3-and-click-expected.txt: Removed.
* platform/ios-wk2/fast/html/details-add-summary-4-and-click-expected.txt: Removed.
* platform/ios-wk2/fast/html/details-add-summary-5-and-click-expected.txt: Removed.
* platform/ios-wk2/fast/html/details-add-summary-6-and-click-expected.txt: Removed.
* platform/ios-wk2/fast/html/details-add-summary-7-and-click-expected.txt: Removed.
* platform/ios-wk2/fast/html/details-add-summary-8-and-click-expected.txt: Removed.
* platform/ios-wk2/fast/html/details-add-summary-9-and-click-expected.txt: Removed.
* platform/ios-wk2/fast/html/details-remove-summary-1-and-click-expected.txt: Removed.
* platform/ios-wk2/fast/html/details-remove-summary-2-and-click-expected.txt: Removed.
* platform/ios-wk2/fast/html/details-remove-summary-3-and-click-expected.txt: Removed.
* platform/ios-wk2/fast/html/details-remove-summary-4-and-click-expected.txt: Removed.
* platform/ios-wk2/fast/html/details-remove-summary-5-and-click-expected.txt: Removed.
* platform/ios-wk2/fast/html/details-remove-summary-6-and-click-expected.txt: Removed.
* platform/ios-wk2/fast/multicol/overflow-unsplittable-expected.txt: Removed.
* platform/ios-wk2/fast/multicol/pagination/BottomToTop-bt-expected.txt: Removed.
* platform/ios-wk2/fast/multicol/pagination/BottomToTop-lr-expected.txt: Removed.
* platform/ios-wk2/fast/multicol/pagination/BottomToTop-rl-expected.txt: Removed.
* platform/ios-wk2/fast/multicol/pagination/BottomToTop-tb-expected.txt: Removed.
* platform/ios-wk2/fast/multicol/pagination/RightToLeft-bt-expected.txt: Removed.
* platform/ios-wk2/fast/multicol/pagination/RightToLeft-lr-expected.txt: Removed.
* platform/ios-wk2/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.txt: Removed.
* platform/ios-wk2/fast/multicol/pagination/RightToLeft-rl-expected.txt: Removed.
* platform/ios-wk2/fast/multicol/pagination/RightToLeft-tb-expected.txt: Removed.
* platform/ios-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Removed.
* platform/ios-wk2/fast/multicol/vertical-rl/column-rules-expected.txt: Removed.
* platform/ios-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Removed.
* platform/ios-wk2/fast/overflow/overflow-auto-position-absolute-expected.txt: Removed.
* platform/ios-wk2/fast/overflow/paged-x-div-expected.txt: Removed.
* platform/ios-wk2/fast/overflow/paged-x-div-with-column-gap-expected.txt: Removed.
* platform/ios-wk2/http/tests/adClickAttribution/anchor-tag-attributes-validation-expected.txt: Removed.
* platform/ios-wk2/http/tests/security/anchor-download-block-crossorigin-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-xhtml-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/html/interaction/focus/processing-model/preventScroll-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/selection-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-dashoffset-computed-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-linecap-computed-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-linejoin-computed-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/web-share/canShare-insecure.http-expected.txt: Removed.
* platform/ios/animations/3d/replace-filling-transform-expected.txt: Removed.
* platform/ios/animations/animation-offscreen-to-onscreen-expected.txt: Removed.
* platform/ios/animations/opacity-transform-animation-expected.txt: Removed.
* platform/ios/animations/suspend-transform-animation-expected.txt: Removed.
* platform/ios/compositing/contents-opaque/background-clip-expected.txt: Removed.
* platform/ios/compositing/contents-opaque/background-color-expected.txt: Removed.
* platform/ios/compositing/contents-opaque/table-parts-expected.txt: Removed.
* platform/ios/compositing/images/clip-on-directly-composited-image-expected.txt: Removed.
* platform/ios/compositing/repaint/absolute-painted-into-composited-ancestor-expected.txt: Removed.
* platform/ios/css3/calc/line-height-expected.txt: Removed.
* platform/ios/fast/attachment/attachment-disabled-dom-expected.txt: Removed.
* platform/ios/fast/attachment/attachment-dom-expected.txt: Removed.
* platform/ios/fast/block/basic/quirk-percent-height-table-cell-expected.txt: Removed.
* platform/ios/fast/borders/border-radius-different-width-001-expected.txt: Removed.
* platform/ios/fast/css-generated-content/first-letter-in-nested-before-expected.txt: Removed.
* platform/ios/fast/css/box-shadow-and-border-radius-expected.txt: Removed.
* platform/ios/fast/dynamic/001-expected.txt: Removed.
* platform/ios/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
* platform/ios/fast/events/constructors/keyboard-event-constructor-expected.txt: Removed.
* platform/ios/fast/forms/005-expected.txt: Removed.
* platform/ios/fast/multicol/span/before-child-anonymous-column-block-expected.txt: Removed.
* platform/ios/fast/reflections/table-cell-expected.txt: Removed.
* platform/ios/fast/replaced/table-percent-height-positioned-expected.txt: Removed.
* platform/ios/fast/table/008-expected.txt: Removed.
* platform/ios/fast/table/caption-relayout-expected.txt: Removed.
* platform/ios/fast/table/growCellForImageQuirk-expected.txt: Removed.
* platform/ios/fast/table/growCellForImageQuirk-vertical-expected.txt: Removed.
* platform/ios/fast/table/table-row-before-after-content-around-table-cell-expected.txt: Removed.
* platform/ios/fast/table/table-row-outline-paint-expected.txt: Removed.
* platform/ios/fast/table/table-row-split2-expected.txt: Removed.
* platform/ios/fast/table/table-section-split2-expected.txt: Removed.
* platform/ios/fast/table/table-split-expected.txt: Removed.
* platform/ios/fast/table/table-split2-expected.txt: Removed.
* platform/ios/fast/text/system-font-weight-expected.txt: Removed.
* platform/ios/fast/writing-mode/table-percent-width-quirk-expected.txt: Removed.
* platform/ios/http/tests/security/contentSecurityPolicy/audio-redirect-blocked-expected.txt: Removed.
* platform/ios/http/tests/security/contentSecurityPolicy/video-redirect-blocked-expected.txt: Removed.
* platform/ios/imported/w3c/web-platform-tests/cors/access-control-expose-headers-parsing.window-expected.txt: Removed.
* platform/ios/imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio-affects-container-width-when-height-changes-expected.txt: Removed.
* platform/ios/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any-expected.txt: Removed.
* platform/ios/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any.worker-expected.txt: Removed.
* platform/ios/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-navigation-cross-origin-expected.txt: Removed.
* platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-filter-expected.txt: Removed.
* platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/color-expected.txt: Removed.
* platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-meter-element/meter-expected.txt: Removed.
* platform/ios/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/centering-expected.txt: Removed.
* platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt: Removed.
* platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt: Removed.
* platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt: Removed.
* platform/ios/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt: Removed.
* platform/ios/imported/w3c/web-platform-tests/xhr/getresponseheader-case-insensitive-expected.txt: Removed.
* platform/ios/quicklook/numbers-expected.html: Removed.
* platform/ios/svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
* platform/ios/swipe/basic-cached-back-swipe-expected.txt: Removed.
* platform/ios/swipe/pushState-cached-back-swipe-expected.txt: Removed.
* platform/ios/tables/mozilla/bugs/bug120107-expected.txt: Removed.
* platform/ios/tables/mozilla/bugs/bug1271-expected.txt: Removed.
* platform/ios/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
* platform/ios/tables/mozilla/bugs/bug12910-2-expected.txt: Removed.
* platform/ios/tables/mozilla/bugs/bug13169-expected.txt: Removed.
* platform/ios/tables/mozilla/bugs/bug137388-1-expected.txt: Removed.
* platform/ios/tables/mozilla/bugs/bug137388-3-expected.txt: Removed.
* platform/ios/tables/mozilla/bugs/bug269566-expected.txt: Removed.
* platform/ios/tables/mozilla/bugs/bug277062-expected.txt: Removed.
* platform/ios/tables/mozilla/bugs/bug28933-expected.txt: Removed.
* platform/ios/tables/mozilla/bugs/bug2954-expected.txt: Removed.
* platform/ios/tables/mozilla/bugs/bug50695-2-expected.txt: Removed.
* platform/ios/tables/mozilla_expected_failures/bugs/bug23847-expected.txt: Removed.
* platform/ios/webaudio/audiobuffersource-expected.wav: Removed.
* platform/ios/webaudio/audiobuffersource-multi-channels-expected.wav: Removed.
* platform/ios/webaudio/audiochannelmerger-stereo-expected.txt: Removed.
* platform/ios/webaudio/audionode-channel-rules-expected.txt: Removed.
* platform/ios/webaudio/audionode-connect-order-expected.txt: Removed.
* platform/ios/webaudio/audioparam-connect-audioratesignal-expected.txt: Removed.
* platform/ios/webaudio/audioparam-exponentialRampToValueAtTime-expected.txt: Removed.
* platform/ios/webaudio/audioparam-linearRampToValueAtTime-expected.txt: Removed.
* platform/ios/webaudio/audioparam-setTargetAtTime-expected.txt: Removed.
* platform/ios/webaudio/audioparam-setValueAtTime-expected.txt: Removed.
* platform/ios/webaudio/audioparam-setValueCurveAtTime-expected.txt: Removed.
* platform/ios/webaudio/audioparam-summingjunction-expected.txt: Removed.
* platform/ios/webaudio/audioprocessingevent-expected.txt: Removed.
* platform/ios/webaudio/automatic-pull-node-expected.txt: Removed.
* platform/ios/webaudio/biquad-allpass-expected.txt: Removed.
* platform/ios/webaudio/biquad-bandpass-expected.txt: Removed.
* platform/ios/webaudio/biquad-getFrequencyResponse-expected.txt: Removed.
* platform/ios/webaudio/biquad-highpass-expected.txt: Removed.
* platform/ios/webaudio/biquad-highshelf-expected.txt: Removed.
* platform/ios/webaudio/biquad-lowpass-expected.txt: Removed.
* platform/ios/webaudio/biquad-lowshelf-expected.txt: Removed.
* platform/ios/webaudio/biquad-notch-expected.txt: Removed.
* platform/ios/webaudio/biquad-peaking-expected.txt: Removed.
* platform/ios/webaudio/codec-tests/wav/24bit-44khz-expected.wav: Removed.
* platform/ios/webaudio/convolution-mono-mono-expected.txt: Removed.
* platform/ios/webaudio/delaynode-expected.txt: Removed.
* platform/ios/webaudio/delaynode-max-default-delay-expected.txt: Removed.
* platform/ios/webaudio/delaynode-max-nondefault-delay-expected.txt: Removed.
* platform/ios/webaudio/delaynode-maxdelay-expected.txt: Removed.
* platform/ios/webaudio/delaynode-scheduling-expected.txt: Removed.
* platform/ios/webaudio/dynamicscompressor-basic-expected.txt: Removed.
* platform/ios/webaudio/gain-basic-expected.txt: Removed.
* platform/ios/webaudio/gain-expected.wav: Removed.
* platform/ios/webaudio/javascriptaudionode-downmix8-2channel-input-expected.txt: Removed.
* platform/ios/webaudio/javascriptaudionode-upmix2-8channel-input-expected.txt: Removed.
* platform/ios/webaudio/javascriptaudionode-zero-input-channels-expected.txt: Removed.
* platform/ios/webaudio/mediaelementaudiosourcenode-gc-expected.txt: Removed.
* platform/ios/webaudio/mixing-expected.wav: Removed.
* platform/ios/webaudio/oscillator-sine-expected.wav: Removed.
* platform/ios/webaudio/panner-equalpower-expected.txt: Removed.
* platform/ios/webaudio/panner-equalpower-stereo-expected.txt: Removed.
* platform/ios/webaudio/realtimeanalyser-fft-scaling-expected.txt: Removed.
* platform/ios/webaudio/sample-accurate-scheduling-expected.txt: Removed.
* platform/ios/webaudio/stereo2mono-down-mixing-expected.txt: Removed.
* platform/ios/webaudio/test-basic-expected.wav: Removed.
* platform/ios/webaudio/up-mixing-mono-51-expected.wav: Removed.
* platform/ios/webaudio/up-mixing-mono-stereo-expected.wav: Removed.
* platform/ios/webaudio/up-mixing-stereo-51-expected.wav: Removed.
* platform/ios/webaudio/waveshaper-expected.txt: Removed.
* platform/ios/webaudio/waveshaper-oversample-2x-expected.txt: Removed.
* platform/ios/webaudio/waveshaper-oversample-4x-expected.txt: Removed.
* platform/ios/webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats-expected.txt: Removed.
* platform/ios/webgl/2.0.0/conformance/extensions/oes-vertex-array-object-expected.txt: Removed.
* platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-expected.txt: Removed.
* platform/mac-mojave/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf.https-expected.txt: Removed.
* platform/mac-mojave/imported/w3c/web-platform-tests/xhr/getresponseheader-case-insensitive-expected.txt: Removed.
* platform/mac-mojave/media/video-controls-captions-trackmenu-localized-expected.txt: Removed.
* platform/mac-wk1/compositing/tiling/coverage-adjustment-secondary-quad-mapping-expected.txt: Removed.
* platform/mac-wk1/http/tests/webarchive/test-preload-resources-expected.txt: Removed.
* platform/mac-wk1/http/wpt/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-async-delegate-expected.txt: Removed.
* platform/mac-wk1/imported/w3c/web-platform-tests/css/geometry/DOMMatrix2DInit-validate-fixup-expected.txt: Removed.
* platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/history/joint-session-history/joint-session-history-only-fully-active-expected.txt: Removed.
* platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/001-expected.txt: Removed.
* platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/002-expected.txt: Removed.
* platform/mac-wk1/imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window-expected.txt: Removed.
* platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-dashoffset-computed-expected.txt: Removed.
* platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-linecap-computed-expected.txt: Removed.
* platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-linejoin-computed-expected.txt: Removed.
* platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-miterlimit-computed-expected.txt: Removed.
* platform/mac-wk1/imported/w3c/web-platform-tests/svg/painting/parsing/stroke-opacity-computed-expected.txt: Removed.
* platform/mac-wk1/inspector/model/remote-object/number-expected.txt: Removed.
* platform/mac-wk1/pageoverlay/overlay-small-frame-paints-expected.txt: Removed.
* platform/mac-wk2/editing/style/unbold-in-bold-expected.txt: Removed.
* platform/mac-wk2/fast/frames/flattening/frameset-flattening-simple-expected.txt: Removed.
* platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt: Removed.
* platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-xhtml-expected.txt: Removed.
* platform/mac-wk2/imported/w3c/web-platform-tests/html/rendering/widgets/appearance/default-styles-expected.txt: Removed.
* platform/mac-wk2/imported/w3c/web-platform-tests/web-share/canShare-insecure.http-expected.txt: Removed.
* platform/mac/accessibility/negative-tabindex-does-not-expose-label-expected.txt: Removed.
* platform/mac/accessibility/svg-bounds-expected.txt: Removed.
* platform/mac/canvas/philip/tests/2d.fillStyle.parse.rgb-eof-expected.txt: Removed.
* platform/mac/canvas/philip/tests/2d.fillStyle.parse.rgba-eof-expected.txt: Removed.
* platform/mac/canvas/philip/tests/2d.line.join.parallel-expected.txt: Removed.
* platform/mac/compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style-expected.txt: Removed.
* platform/mac/compositing/contents-format/subpixel-antialiased-text-configs-expected.txt: Removed.
* platform/mac/compositing/contents-format/subpixel-antialiased-text-enabled-expected.txt: Removed.
* platform/mac/compositing/contents-format/subpixel-antialiased-text-images-expected.txt: Removed.
* platform/mac/compositing/contents-format/subpixel-antialiased-text-traversal-expected.txt: Removed.
* platform/mac/compositing/contents-format/subpixel-antialiased-text-visibility-expected.txt: Removed.
* platform/mac/compositing/contents-opaque/table-parts-expected.txt: Removed.
* platform/mac/css2.1/t1508-c527-font-00-b-expected.txt: Removed.
* platform/mac/editing/mac/selection/context-menu-select-editability-expected.txt: Removed.
* platform/mac/editing/selection/collapse-selection-in-bidi-expected.txt: Removed.
* platform/mac/editing/selection/drag-start-event-client-x-y-expected.txt: Removed.
* platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
* platform/mac/fast/block/basic/quirk-percent-height-table-cell-expected.txt: Removed.
* platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
* platform/mac/fast/borders/border-radius-different-width-001-expected.txt: Removed.
* platform/mac/fast/css-generated-content/first-letter-in-nested-before-expected.txt: Removed.
* platform/mac/fast/css-generated-content/table-parts-before-and-after-expected.txt: Removed.
* platform/mac/fast/css/box-shadow-and-border-radius-expected.txt: Removed.
* platform/mac/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Removed.
* platform/mac/fast/css/caption-width-absolute-position-expected.txt: Removed.
* platform/mac/fast/css/caption-width-absolute-position-offset-top-expected.txt: Removed.
* platform/mac/fast/css/caption-width-fixed-position-expected.txt: Removed.
* platform/mac/fast/css/caption-width-fixed-position-offset-top-expected.txt: Removed.
* platform/mac/fast/css/caption-width-relative-position-expected.txt: Removed.
* platform/mac/fast/css/caption-width-relative-position-offset-top-expected.txt: Removed.
* platform/mac/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Removed.
* platform/mac/fast/css/image-rendering-expected.txt: Removed.
* platform/mac/fast/css/min-width-with-spanned-cell-expected.txt: Removed.
* platform/mac/fast/dom/HTMLImageElement/resources/blue_rect.jpg: Removed.
* platform/mac/fast/dom/adopt-attribute-crash-expected.txt: Removed.
* platform/mac/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Removed.
* platform/mac/fast/dynamic/001-expected.txt: Removed.
* platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
* platform/mac/fast/events/document-elementFromPoint-expected.txt: Removed.
* platform/mac/fast/flexbox/flex-hang-expected.txt: Removed.
* platform/mac/fast/forms/005-expected.txt: Removed.
* platform/mac/fast/images/repaint-subrect-grid-expected.txt: Removed.
* platform/mac/fast/images/zoomed-img-size-expected.txt: Removed.
* platform/mac/fast/invalid/018-expected.txt: Removed.
* platform/mac/fast/lists/list-marker-before-content-table-expected.txt: Removed.
* platform/mac/fast/loader/javascript-url-in-embed-expected.txt: Removed.
* platform/mac/fast/multicol/break-properties-expected.txt: Removed.
* platform/mac/fast/multicol/span/before-child-anonymous-column-block-expected.txt: Removed.
* platform/mac/fast/multicol/vertical-lr/break-properties-expected.txt: Removed.
* platform/mac/fast/multicol/vertical-rl/break-properties-expected.txt: Removed.
* platform/mac/fast/parser/style-script-head-test-expected.txt: Removed.
* platform/mac/fast/reflections/reflection-with-zoom-expected.txt: Removed.
* platform/mac/fast/reflections/table-cell-expected.txt: Removed.
* platform/mac/fast/repaint/float-overflow-expected.txt: Removed.
* platform/mac/fast/repaint/float-overflow-right-expected.txt: Removed.
* platform/mac/fast/repaint/subtree-root-clip-3-expected.txt: Removed.
* platform/mac/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
* platform/mac/fast/repaint/table-cell-overflow-expected.txt: Removed.
* platform/mac/fast/repaint/table-cell-vertical-overflow-expected.txt: Removed.
* platform/mac/fast/repaint/table-col-background-expected.txt: Removed.
* platform/mac/fast/repaint/table-outer-border-expected.txt: Removed.
* platform/mac/fast/repaint/table-row-expected.txt: Removed.
* platform/mac/fast/repaint/table-section-overflow-expected.txt: Removed.
* platform/mac/fast/repaint/table-section-repaint-expected.txt: Removed.
* platform/mac/fast/repaint/table-writing-modes-h-expected.txt: Removed.
* platform/mac/fast/repaint/table-writing-modes-v-expected.txt: Removed.
* platform/mac/fast/replaced/table-percent-height-positioned-expected.txt: Removed.
* platform/mac/fast/table/008-expected.txt: Removed.
* platform/mac/fast/table/031-expected.txt: Removed.
* platform/mac/fast/table/032-expected.txt: Removed.
* platform/mac/fast/table/border-collapsing/bug14274-expected.txt: Removed.
* platform/mac/fast/table/border-collapsing/cached-change-cell-border-color-expected.txt: Removed.
* platform/mac/fast/table/border-collapsing/cached-change-cell-border-width-expected.txt: Removed.
* platform/mac/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.txt: Removed.
* platform/mac/fast/table/border-collapsing/cached-change-row-border-color-expected.txt: Removed.
* platform/mac/fast/table/border-collapsing/cached-change-table-border-color-expected.txt: Removed.
* platform/mac/fast/table/border-collapsing/cached-change-table-border-width-expected.txt: Removed.
* platform/mac/fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.txt: Removed.
* platform/mac/fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.txt: Removed.
* platform/mac/fast/table/caption-relayout-expected.txt: Removed.
* platform/mac/fast/table/growCellForImageQuirk-expected.txt: Removed.
* platform/mac/fast/table/growCellForImageQuirk-vertical-expected.txt: Removed.
* platform/mac/fast/table/height-percent-test-expected.txt: Removed.
* platform/mac/fast/table/height-percent-test-vertical-expected.txt: Removed.
* platform/mac/fast/table/table-anonymous-cell-bug-expected.txt: Removed.
* platform/mac/fast/table/table-anonymous-row-bug-expected.txt: Removed.
* platform/mac/fast/table/table-anonymous-section-bug-expected.txt: Removed.
* platform/mac/fast/table/table-before-child-style-update-expected.txt: Removed.
* platform/mac/fast/table/table-cell-before-after-content-around-table-block-expected.txt: Removed.
* platform/mac/fast/table/table-cell-before-after-content-around-table-expected.txt: Removed.
* platform/mac/fast/table/table-cell-before-after-content-around-table-row-expected.txt: Removed.
* platform/mac/fast/table/table-cell-split-expected.txt: Removed.
* platform/mac/fast/table/table-insert-before-non-anonymous-block-expected.txt: Removed.
* platform/mac/fast/table/table-row-before-after-content-around-block-expected.txt: Removed.
* platform/mac/fast/table/table-row-before-after-content-around-table-cell-expected.txt: Removed.
* platform/mac/fast/table/table-row-before-after-content-around-table-expected.txt: Removed.
* platform/mac/fast/table/table-row-before-child-style-update-expected.txt: Removed.
* platform/mac/fast/table/table-row-outline-paint-expected.txt: Removed.
* platform/mac/fast/table/table-row-split2-expected.txt: Removed.
* platform/mac/fast/table/table-row-style-not-updated-expected.txt: Removed.
* platform/mac/fast/table/table-row-style-not-updated-with-after-content-expected.txt: Removed.
* platform/mac/fast/table/table-row-style-not-updated-with-before-content-expected.txt: Removed.
* platform/mac/fast/table/table-section-split2-expected.txt: Removed.
* platform/mac/fast/table/table-split-expected.txt: Removed.
* platform/mac/fast/table/table-split2-expected.txt: Removed.
* platform/mac/fast/table/table-style-not-updated-expected.txt: Removed.
* platform/mac/fast/table/wide-colspan-expected.txt: Removed.
* platform/mac/fast/table/wide-column-expected.txt: Removed.
* platform/mac/fast/text/whitespace/013-expected.txt: Removed.
* platform/mac/fast/text/whitespace/014-expected.txt: Removed.
* platform/mac/fast/writing-mode/table-percent-width-quirk-expected.txt: Removed.
* platform/mac/http/tests/cookies/third-party-cookie-relaxing-expected.txt: Removed.
* platform/mac/http/tests/inspector/network/resource-sizes-memory-cache-expected.txt: Removed.
* platform/mac/imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-large-expected.txt: Removed.
* platform/mac/imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-small-expected.txt: Removed.
* platform/mac/imported/w3c/web-platform-tests/cors/access-control-expose-headers-parsing.window-expected.txt: Removed.
* platform/mac/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any-expected.txt: Removed.
* platform/mac/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any.worker-expected.txt: Removed.
* platform/mac/media/track/video-track-alternate-groups-expected.txt: Removed.
* platform/mac/security/block-test-expected.txt: Removed.
* platform/mac/security/block-test-no-port-expected.txt: Removed.
* platform/mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Removed.
* platform/mac/svg/as-image/svg-non-integer-scaled-image-expected.txt: Removed.
* platform/mac/svg/custom/fractional-rects-expected.txt: Removed.
* platform/mac/svg/custom/js-update-container-expected.txt: Removed.
* platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
* platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt: Removed.
* platform/mac/svg/custom/viewBox-hit-expected.txt: Removed.
* platform/mac/svg/hixie/text/001-expected.txt: Removed.
* platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Removed.
* platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt: Removed.
* platform/mac/svg/text/text-hkern-expected.txt: Removed.
* platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
* platform/mac/svg/zoom/page/zoom-svg-as-image-expected.txt: Removed.
* platform/mac/svg/zoom/page/zoom-svg-as-object-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug120107-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug1271-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug12910-2-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug13169-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug137388-1-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug137388-3-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug269566-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug277062-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug28933-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug29314-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug2954-expected.txt: Removed.
* platform/mac/tables/mozilla/bugs/bug56201-expected.txt: Removed.
* platform/mac/tables/mozilla_expected_failures/bugs/bug128876-expected.txt: Removed.
* platform/mac/userscripts/script-run-at-end-expected.txt: Removed.
* platform/win-7sp0/editing/selection/collapse-selection-in-bidi-expected.txt: Removed.
* platform/win-7sp0/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Removed.
* platform/win-7sp0/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
* platform/win-7sp0/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Removed.
* platform/win-7sp0/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Removed.
* platform/win/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
* platform/win/css2.1/tables/table-anonymous-objects-181-expected.txt: Removed.
* platform/win/editing/deleting/smart-delete-001-expected.txt: Removed.
* platform/win/editing/deleting/smart-delete-002-expected.txt: Removed.
* platform/win/editing/deleting/smart-delete-003-expected.txt: Removed.
* platform/win/editing/deleting/smart-delete-004-expected.txt: Removed.
* platform/win/editing/selection/collapse-selection-in-bidi-expected.txt: Removed.
* platform/win/fast/block/basic/quirk-percent-height-table-cell-expected.txt: Removed.
* platform/win/fast/borders/border-radius-different-width-001-expected.txt: Removed.
* platform/win/fast/borders/table-borders-expected.txt: Removed.
* platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Removed.
* platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
* platform/win/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
* platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Removed.
* platform/win/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
* platform/win/fast/canvas/fallback-content-expected.txt: Removed.
* platform/win/fast/css-generated-content/first-letter-in-nested-before-expected.txt: Removed.
* platform/win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
* platform/win/fast/css-generated-content/table-parts-before-and-after-expected.txt: Removed.
* platform/win/fast/css/box-shadow-and-border-radius-expected.txt: Removed.
* platform/win/fast/css/button-height-expected.txt: Removed.
* platform/win/fast/css/caption-width-absolute-position-expected.txt: Removed.
* platform/win/fast/css/caption-width-absolute-position-offset-top-expected.txt: Removed.
* platform/win/fast/css/caption-width-fixed-position-expected.txt: Removed.
* platform/win/fast/css/caption-width-fixed-position-offset-top-expected.txt: Removed.
* platform/win/fast/css/caption-width-relative-position-expected.txt: Removed.
* platform/win/fast/css/caption-width-relative-position-offset-top-expected.txt: Removed.
* platform/win/fast/css/first-letter-block-form-controls-crash-expected.txt: Removed.
* platform/win/fast/css/min-width-with-spanned-cell-expected.txt: Removed.
* platform/win/fast/css/percentage-non-integer-expected.txt: Removed.
* platform/win/fast/css/relative-position-replaced-in-table-display-crash-expected.txt: Removed.
* platform/win/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
* platform/win/fast/dom/adopt-attribute-crash-expected.txt: Removed.
* platform/win/fast/dom/adopt-node-crash-2-expected.txt: Removed.
* platform/win/fast/dynamic/001-expected.txt: Removed.
* platform/win/fast/dynamic/subtree-table-cell-height-expected.txt: Removed.
* platform/win/fast/events/event-attribute-expected.txt: Removed.
* platform/win/fast/events/ondragenter-expected.txt: Removed.
* platform/win/fast/forms/005-expected.txt: Removed.
* platform/win/fast/forms/access-key-for-all-elements-expected.txt: Removed.
* platform/win/fast/forms/form-associated-element-crash3-expected.txt: Removed.
* platform/win/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Removed.
* platform/win/fast/invalid/012-expected.txt: Removed.
* platform/win/fast/lists/list-marker-before-content-table-expected.txt: Removed.
* platform/win/fast/multicol/renderer-positioned-assert-crash-expected.txt: Removed.
* platform/win/fast/multicol/span/before-child-anonymous-column-block-expected.txt: Removed.
* platform/win/fast/reflections/table-cell-expected.txt: Removed.
* platform/win/fast/repaint/block-selection-gap-in-table-cell-expected.txt: Removed.
* platform/win/fast/repaint/float-overflow-expected.txt: Removed.
* platform/win/fast/repaint/float-overflow-right-expected.txt: Removed.
* platform/win/fast/repaint/subtree-root-clip-3-expected.txt: Removed.
* platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
* platform/win/fast/repaint/table-cell-overflow-expected.txt: Removed.
* platform/win/fast/repaint/table-cell-vertical-overflow-expected.txt: Removed.
* platform/win/fast/repaint/table-col-background-expected.txt: Removed.
* platform/win/fast/repaint/table-hover-on-link-expected.txt: Removed.
* platform/win/fast/repaint/table-outer-border-expected.txt: Removed.
* platform/win/fast/repaint/table-row-expected.txt: Removed.
* platform/win/fast/repaint/table-section-overflow-expected.txt: Removed.
* platform/win/fast/repaint/table-section-repaint-expected.txt: Removed.
* platform/win/fast/repaint/table-writing-modes-h-expected.txt: Removed.
* platform/win/fast/repaint/table-writing-modes-v-expected.txt: Removed.
* platform/win/fast/replaced/005-expected.txt: Removed.
* platform/win/fast/replaced/table-percent-height-positioned-expected.txt: Removed.
* platform/win/fast/table/005-expected.txt: Removed.
* platform/win/fast/table/006-expected.txt: Removed.
* platform/win/fast/table/008-expected.txt: Removed.
* platform/win/fast/table/013-expected.txt: Removed.
* platform/win/fast/table/031-expected.txt: Removed.
* platform/win/fast/table/032-expected.txt: Removed.
* platform/win/fast/table/border-collapsing/002-expected.txt: Removed.
* platform/win/fast/table/border-collapsing/002-vertical-expected.txt: Removed.
* platform/win/fast/table/border-collapsing/bug14274-expected.txt: Removed.
* platform/win/fast/table/border-collapsing/cached-change-cell-border-color-expected.txt: Removed.
* platform/win/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.txt: Removed.
* platform/win/fast/table/border-collapsing/cached-change-row-border-color-expected.txt: Removed.
* platform/win/fast/table/border-collapsing/cached-change-table-border-color-expected.txt: Removed.
* platform/win/fast/table/border-collapsing/cached-change-table-border-width-expected.txt: Removed.
* platform/win/fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.txt: Removed.
* platform/win/fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.txt: Removed.
* platform/win/fast/table/caption-relayout-expected.txt: Removed.
* platform/win/fast/table/dynamic-cellpadding-expected.txt: Removed.
* platform/win/fast/table/growCellForImageQuirk-expected.txt: Removed.
* platform/win/fast/table/growCellForImageQuirk-vertical-expected.txt: Removed.
* platform/win/fast/table/height-percent-test-expected.txt: Removed.
* platform/win/fast/table/height-percent-test-vertical-expected.txt: Removed.
* platform/win/fast/table/multiple-percent-height-rows-expected.txt: Removed.
* platform/win/fast/table/table-anonymous-cell-bug-expected.txt: Removed.
* platform/win/fast/table/table-anonymous-row-bug-expected.txt: Removed.
* platform/win/fast/table/table-anonymous-section-bug-expected.txt: Removed.
* platform/win/fast/table/table-before-child-style-update-expected.txt: Removed.
* platform/win/fast/table/table-cell-before-after-content-around-table-block-expected.txt: Removed.
* platform/win/fast/table/table-cell-before-after-content-around-table-expected.txt: Removed.
* platform/win/fast/table/table-cell-before-after-content-around-table-row-expected.txt: Removed.
* platform/win/fast/table/table-cell-split-expected.txt: Removed.
* platform/win/fast/table/table-insert-before-non-anonymous-block-expected.txt: Removed.
* platform/win/fast/table/table-row-before-after-content-around-block-expected.txt: Removed.
* platform/win/fast/table/table-row-before-after-content-around-table-cell-expected.txt: Removed.
* platform/win/fast/table/table-row-before-after-content-around-table-expected.txt: Removed.
* platform/win/fast/table/table-row-before-child-style-update-expected.txt: Removed.
* platform/win/fast/table/table-row-outline-paint-expected.txt: Removed.
* platform/win/fast/table/table-row-split2-expected.txt: Removed.
* platform/win/fast/table/table-row-style-not-updated-expected.txt: Removed.
* platform/win/fast/table/table-row-style-not-updated-with-after-content-expected.txt: Removed.
* platform/win/fast/table/table-row-style-not-updated-with-before-content-expected.txt: Removed.
* platform/win/fast/table/table-section-split2-expected.txt: Removed.
* platform/win/fast/table/table-split-expected.txt: Removed.
* platform/win/fast/table/table-split2-expected.txt: Removed.
* platform/win/fast/table/table-style-not-updated-expected.txt: Removed.
* platform/win/fast/table/wide-colspan-expected.txt: Removed.
* platform/win/fast/table/wide-column-expected.txt: Removed.
* platform/win/fast/text/whitespace/013-expected.txt: Removed.
* platform/win/fast/text/whitespace/014-expected.txt: Removed.
* platform/win/fast/writing-mode/table-percent-width-quirk-expected.txt: Removed.
* platform/win/http/tests/webarchive/test-preload-resources-expected.txt: Removed.
* platform/win/mathml/presentation/menclose-notation-default-longdiv-expected.txt: Removed.
* platform/win/plugins/netscape-dom-access-and-reload-expected.txt: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1/render-elems-07-t-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1/render-elems-08-t-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Removed.
* platform/win/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Removed.
* platform/win/svg/custom/glyph-setting-d-attribute-expected.png: Removed.
* platform/win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Removed.
* platform/win/svg/foreignObject/text-tref-02-b-expected.png: Removed.
* platform/win/svg/text/kerning-expected.png: Removed.
* platform/win/svg/text/multichar-glyph-expected.png: Removed.
* platform/win/tables/mozilla/bugs/bug106795-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug120107-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug1220-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug1261-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug1271-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug12910-2-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug13169-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug137388-1-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug137388-3-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug139524-1-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug139524-3-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug139524-4-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug15933-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug18440-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug2123-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug219693-1-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug219693-2-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug22513-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug2585-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug269566-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug277062-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug28933-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug29314-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug2954-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug46944-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug53690-1-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug53690-2-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug55789-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug56201-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug8361-expected.txt: Removed.
* platform/win/tables/mozilla/bugs/bug97383-expected.txt: Removed.
* platform/win/tables/mozilla/other/slashlogo-expected.txt: Removed.
* platform/win/tables/mozilla_expected_failures/bugs/bug128876-expected.txt: Removed.
* platform/win/tables/mozilla_expected_failures/bugs/bug1647-expected.txt: Removed.
* platform/win/tables/mozilla_expected_failures/bugs/bug178855-expected.txt: Removed.
* platform/win/tables/mozilla_expected_failures/bugs/bug72393-expected.txt: Removed.
* platform/wincairo/css3/calc/line-height-expected.txt: Removed.
* platform/wincairo/fast/dom/adopt-node-crash-2-expected.txt: Removed.
* platform/wk2/http/tests/contentdispositionattachmentsandbox/cross-origin-frames-disabled-expected.txt: Removed.
* platform/wk2/http/tests/contentextensions/block-everything-unless-domain-expected.txt: Removed.
* platform/wk2/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https-expected.txt: Removed.
* platform/wk2/http/tests/security/drag-drop-local-file-expected.txt: Removed.
* platform/wk2/imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name-expected.txt: Removed.
* platform/wk2/webarchive/loading/javascript-url-iframe-crash-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-from-image-computed-style-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-none-computed-style-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-update-disallowed-input.https-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/blob.https-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/embedded/image-fractional-width-vertical-fidelity-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-001-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-002-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/circle-003-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-001-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-002-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/ellipse-003-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-001-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-002-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/geometry/reftests/rect-003-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-invalid-base-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-001-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-002-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/linking/reftests/url-processing-whitespace-003-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/painting/marker-009-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-001-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-003-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-011-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-012-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-013-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-strokewidth-non-scaling-stroke-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-userspaceonuse-non-scaling-stroke-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/painting/reftests/mask-print-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-mutating-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathlength-path-zero-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/path/distance/pathlength-rect-mutating-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-01.tentative-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/pservers/reftests/gradient-inheritance-not-in-rendertree-02.tentative-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-01.tentative-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/pservers/reftests/pattern-inheritance-not-in-rendertree-02.tentative-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-empty-string-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/struct/reftests/requiredextensions-xhtml.tentative-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/struct/reftests/use-adopted-with-external-resource.tentative-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/svg/struct/reftests/use-inheritance-001-expected.txt: Removed.
* platform/wpe/webgl/2.0.0/conformance/extensions/ext-sRGB-expected.txt: Removed.
* platform/wpe/webgl/2.0.0/conformance/extensions/oes-vertex-array-object-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agodoesParentProcessHaveITPEnabled() check should match behavior in determineITPStateInt...
katherine_cheney@apple.com [Mon, 3 Aug 2020 17:13:41 +0000 (17:13 +0000)]
doesParentProcessHaveITPEnabled() check should match behavior in determineITPStateInternal() check
https://bugs.webkit.org/show_bug.cgi?id=215031
<rdar://problem/66384618>

Reviewed by Brent Fulgham.

Checking ITP state from a WebKit child process should have the same
behavior as checking it from the UI process. In order to do this,
we must pass the value of hasRequestedCrossWebsiteTrackingPermission
to the network process to know if an application has included the
NSCrossWebsiteTrackingUsageDescription value in their Info.plist.

* NetworkProcess/NetworkSessionCreationParameters.cpp:
(WebKit::NetworkSessionCreationParameters::encode const):
(WebKit::NetworkSessionCreationParameters::decode):
* NetworkProcess/NetworkSessionCreationParameters.h:
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::activateSessionCleanup):
* Shared/Cocoa/DefaultWebBrowserChecks.h:
* Shared/Cocoa/DefaultWebBrowserChecks.mm:
(WebKit::hasRequestedCrossWebsiteTrackingPermission):
(WebKit::doesParentProcessHaveITPEnabled):
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoREGRESSION(r264766) webkitpy: newly added --suite flag conflicts with other --suite...
bburg@apple.com [Mon, 3 Aug 2020 16:59:25 +0000 (16:59 +0000)]
REGRESSION(r264766) webkitpy: newly added --suite flag conflicts with other --suite flags in safaripy
https://bugs.webkit.org/show_bug.cgi?id=215038

Reviewed by Jonathan Bedard.

* Scripts/webkitpy/results/options.py:
(upload_options):
For compatibility, make it possible to create the option with a differently-named flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[ macOS wk2 ] webrtc/datachannel/gather-candidates-networkprocess-crash.html is a...
tsavell@apple.com [Mon, 3 Aug 2020 16:54:52 +0000 (16:54 +0000)]
[ macOS wk2 ] webrtc/datachannel/gather-candidates-networkprocess-crash.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=215088

Unreviewed test gardening.

Patch by Hector Lopez <hector_i_lopez@apple.com> on 2020-08-03

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoNon-unified build fixes, early August 20202 edition
aperez@igalia.com [Mon, 3 Aug 2020 16:42:33 +0000 (16:42 +0000)]
Non-unified build fixes, early August 20202 edition
https://bugs.webkit.org/show_bug.cgi?id=215082

Unreviewed build fix.

Source/JavaScriptCore:

* dfg/DFGOSREntry.h: Add missing inclusion of CodeLocation.h
* ftl/FTLGeneratedFunction.h: Ditto.
* jit/CallFrameShuffler.h: Forward-declare CCallHelpers.

Source/WebCore:

No new tests needed.

* accessibility/AccessibilityRenderObject.cpp: Add missing inclusion of Range.h.
* dom/RadioButtonGroups.cpp: Ditto.
* editing/Editing.cpp: Ditto.
* editing/EditingStyle.cpp: Ditto.
* editing/EditorCommand.cpp: Ditto.
* editing/FrameSelection.cpp: Ditto.
* editing/TypingCommand.cpp: Ditto.
* editing/VisiblePosition.cpp: Add missing inclusion of SimpleRange.h.
* rendering/HitTestResult.cpp: Add missing inclusion of Range.h.

Source/WebKit:

* WebProcess/WebPage/FindController.h: Add missing inclusion of WebCore/SimpleRange.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoREGRESSION(r259585) Text decoration color with value currentColor miscomputed in...
antti@apple.com [Mon, 3 Aug 2020 16:18:21 +0000 (16:18 +0000)]
REGRESSION(r259585) Text decoration color with value currentColor miscomputed in some cases
https://bugs.webkit.org/show_bug.cgi?id=215079

Reviewed by Zalan Bujtas.

Source/WebCore:

r259585 did some refactoring that broke a special case where text decoration color comes from
'-webkit-text-fill-color' property.

Test: fast/text/text-decoration-currentcolor-fill-color.html

* rendering/TextDecorationPainter.cpp:
(WebCore::TextDecorationPainter::decorationColor):

Move resolving currentColor to RenderStyle.

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::colorResolvingCurrentColor const):

Handle CSSPropertyTextDecorationColor as a special case here.

(WebCore::RenderStyle::visitedDependentColor const):

LayoutTests:

* fast/text/text-decoration-currentcolor-fill-color-expected.html: Added.
* fast/text/text-decoration-currentcolor-fill-color.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[ macOS wk2 Release ] media/video-background-tab-playback.html is a flaky failure
tsavell@apple.com [Mon, 3 Aug 2020 16:03:10 +0000 (16:03 +0000)]
[ macOS wk2 Release ] media/video-background-tab-playback.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=209353

Unreviewed test gardening.

Patch by Hector Lopez <hector_i_lopez@apple.com> on 2020-08-03

* platform/mac-wk1/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoAdded Constructor to AnalyserNode
commit-queue@webkit.org [Mon, 3 Aug 2020 15:51:42 +0000 (15:51 +0000)]
Added Constructor to AnalyserNode
https://bugs.webkit.org/show_bug.cgi?id=215040

Patch by Clark Wang <clark_wang@apple.com> on 2020-08-03
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Re-baselined existing tests.

* web-platform-tests/webaudio/idlharness.https.window-expected.txt:
* web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt:
* web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-sizing-expected.txt:
* web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analysernode-expected.txt:

Source/WebCore:

Introduced AnalyserNode constructor and AnalyserOptions according to spec:
https://www.w3.org/TR/webaudio/#AnalyserNode-constructors.

Re-baselined existing tests.

* CMakeLists.txt:
* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
* Modules/webaudio/AnalyserNode.cpp:
(WebCore::AnalyserNode::create):
(WebCore::AnalyserNode::AnalyserNode):
(WebCore::AnalyserNode::setFftSize):
(WebCore::AnalyserNode::setMinMaxDecibels):
(WebCore::AnalyserNode::setMinDecibels):
(WebCore::AnalyserNode::setMaxDecibels):
* Modules/webaudio/AnalyserNode.h:
* Modules/webaudio/AnalyserNode.idl:
* Modules/webaudio/AnalyserOptions.h: Added.
* Modules/webaudio/AnalyserOptions.idl: Added.
* Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::createAnalyser):
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Re-baselined existing tests.

* webaudio/analyser-exception-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[WPE][GTK] run-minibrowser no longer assumes release configuration by default
commit-queue@webkit.org [Mon, 3 Aug 2020 12:29:30 +0000 (12:29 +0000)]
[WPE][GTK] run-minibrowser no longer assumes release configuration by default
https://bugs.webkit.org/show_bug.cgi?id=214961

Patch by Philippe Normand <pnormand@igalia.com> on 2020-08-03
Reviewed by Adrian Perez de Castro.

* Scripts/webkitpy/port/base.py:
(Port.set_option_default): Ensure default value is set on optparsed options. In the case of
the default build configuration being set from the Port constructor, this wasn't done
properly. After fixing this, the WPE and GTK ports are correctly implicitely reusing the
build configuration option through the _build_path() method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoREGRESSION(r264096): [flatpak] Clean gst-build within build-webkit fails
commit-queue@webkit.org [Mon, 3 Aug 2020 12:26:11 +0000 (12:26 +0000)]
REGRESSION(r264096): [flatpak] Clean gst-build within build-webkit fails
https://bugs.webkit.org/show_bug.cgi?id=214080

Patch by Philippe Normand <pnormand@igalia.com> on 2020-08-03
Reviewed by Adrian Perez de Castro.

* flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox): Don't attempt to configure the gst-env when starting sccache-dist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[JSC][MIPS] Test gardening July 31st edition
ticaiolima@gmail.com [Mon, 3 Aug 2020 11:44:21 +0000 (11:44 +0000)]
[JSC][MIPS] Test gardening July 31st edition
https://bugs.webkit.org/show_bug.cgi?id=215023

Unreviewed Gardening.

* stress/typedarray-access-neutered.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoMediaRecorderPrivateWriter::appendEndOfVideoSampleDurationIfNeeded should only call...
youenn@apple.com [Mon, 3 Aug 2020 10:09:39 +0000 (10:09 +0000)]
MediaRecorderPrivateWriter::appendEndOfVideoSampleDurationIfNeeded should only call requestMediaDataWhenReadyOnQueue once
https://bugs.webkit.org/show_bug.cgi?id=214972

Reviewed by Eric Carlson.

When processing a compressed sample, pass it to the writer if its ready.
Otherwise buffer it and retry passing it to the writer next time we have a sample.
When finishing a write, we call requestMediaDataWhenReadyOnQueue to finish passing samples that are still enqueued.

Covered by existing tests no longer triggering ObjC exception.

* platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
* platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
(WebCore::MediaRecorderPrivateWriter::appendCompressedAudioSampleBuffer):
(WebCore::MediaRecorderPrivateWriter::appendCompressedVideoSampleBufferIfPossible):
(WebCore::MediaRecorderPrivateWriter::appendCompressedVideoSampleBuffer):
(WebCore::MediaRecorderPrivateWriter::appendCompressedSampleBuffers):
(WebCore::MediaRecorderPrivateWriter::finishAppendingCompressedAudioSampleBuffers):
(WebCore::MediaRecorderPrivateWriter::finishAppendingCompressedVideoSampleBuffers):
(WebCore::MediaRecorderPrivateWriter::flushCompressedSampleBuffers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoImprove the check-for-duplicated-platform-test-results script
simon.fraser@apple.com [Mon, 3 Aug 2020 06:41:45 +0000 (06:41 +0000)]
Improve the check-for-duplicated-platform-test-results script
https://bugs.webkit.org/show_bug.cgi?id=215072

Reviewed by Darin Adler.

check-for-duplicated-platform-test-results had some problems.

First, it defaulted to -wk1 results directories, and didn't check -wk2 directories, so
run the logic twice, with options.webkit_test_runner True and False.
Second, it only looked for results in the most specific fallback directory, so
with a fallback path like 'mac-mojave-wk1 -> mac-mojave -> mac-wk1 -> mac -> generic'
it would only remove results in mac-mojave-wk1, not in 'mac-mojave'.
Also add some logging to the script.

* Scripts/check-for-duplicated-platform-test-results:
(remove_layout_test_path_prefix):
(check_duplicate.sha1):
(check_duplicate):
(platform_list):
(find_duplicates_in_path):
(find_duplicates_in_path.find_duplicates):
(check_platform):
(main):
* Scripts/webkitpy/port/base.py:
(Port.supports_layout_tests): Some ports (iOS and watch device ports) don't support
testing with no associated device. Need to fix errors thrown from default_baseline_search_path().
* Scripts/webkitpy/port/ios_device.py:
(IOSDevicePort.supports_layout_tests):
* Scripts/webkitpy/port/watch_device.py:
(WatchDevicePort.supports_layout_tests):
* Scripts/webkitpy/port/win.py: self._os_version is None when run on another platform.
(WinPort.default_baseline_search_path):
(WinCairoPort._search_paths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoRemove some member functions of Range and many calls to createLiveRange
darin@apple.com [Mon, 3 Aug 2020 00:47:52 +0000 (00:47 +0000)]
Remove some member functions of Range and many calls to createLiveRange
https://bugs.webkit.org/show_bug.cgi?id=215070

Reviewed by Sam Weinig.

Source/WebCore:

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::nextBoundary): Remove createLiveRange.
(WebCore::AXObjectCache::previousBoundary): Ditto.

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _convertToNSRange:]): Take SimpleRange.
(-[WebAccessibilityObjectWrapper positionForTextMarker:]): Remove createLiveRange.
(-[WebAccessibilityObjectWrapper textRectsFromMarkers:withText:]): Ditto.

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper _convertToNSRange:]): Take SimpleRange.
(-[WebAccessibilityObjectWrapper _indexForTextMarker:]): Remove createLiveRange.
(-[WebAccessibilityObjectWrapper _textMarkerForIndex:]): Ditto.

* dom/DocumentMarkerController.cpp:
(WebCore::updateRenderedRectsForMarker): Renamed range to makeSimpleRange.
(WebCore::makeSimpleRange): Ditto.
* dom/DocumentMarkerController.h: Update for the above.

* dom/Range.cpp:
(WebCore::Range::text const): Use makeSimpleRange.
(WebCore::Range::shadowRoot const): Deleted.
(WebCore::intervalsSufficientlyOverlap): Deleted.
(WebCore::adjustLineHeightOfSelectionRects): Deleted.
(WebCore::coalesceSelectionRects): Deleted.
(WebCore::Range::collectSelectionRectsWithoutUnionInteriorLines const): Deleted.
(WebCore::Range::collectSelectionRects const): Deleted.
* dom/Range.h: Update for the above. Also make pastLastNode private since it is
only used inside the Range class's implementation.

* dom/SimpleRange.cpp:
(WebCore::SimpleRange::SimpleRange): Removed overload that takes a Range.
* dom/SimpleRange.h: Update for the above. Removed both constructor overloads
that take a Range.

* editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::timerFired): Remove createLiveRange.
(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord): Use
makeSimpleRange.
(WebCore::AlternativeTextController::applyAlternativeTextToRange):
Remove createLiveRange.

* editing/EditingStyle.cpp:
(WebCore::EditingStyle::styleAtSelectionStart): Remove createLiveRange.
* editing/Editor.cpp:
(WebCore::Editor::performCutOrCopy): Ditto.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.
(WebCore::Editor::replaceRangeForSpellChecking): Ditto.
(WebCore::correctSpellcheckingPreservingTextCheckingParagraph): Ditto.
(WebCore::Editor::changeBackToReplacedString): Ditto.
(WebCore::Editor::countMatchesForText): Ditto.
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply): Ditto.
(WebCore::InsertListCommand::doApplyForSingleParagraph): Change out
argument type to SimpleRange.
* editing/InsertListCommand.h: Update for above.

* editing/SpellChecker.cpp:
(WebCore::SpellChecker::isCheckable const): Rewrite questionable logic
to use intersectingNodes instead of firstNode.

* editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::findUngrammaticalPhrases const): Remove createLiveRange.
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed): Ditto.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
* editing/markup.cpp:
(WebCore::createFragmentFromText): Ditto.

* editing/ios/EditorIOS.mm:
(WebCore::Editor::setTextAsChildOfElement): Use makeRangeSelectingNodeContents.

* editing/win/EditorWin.cpp:
(WebCore::Editor::pasteWithPasteboard): Remove createLiveRange.

* page/DOMSelection.cpp:
(WebCore::DOMSelection::addRange): Use makeSimpleRange.
(WebCore::DOMSelection::deleteFromDocument): Remove createLiveRange.

* page/DragController.cpp:
(WebCore::documentFragmentFromDragData): Take SimpleRange.
(WebCore::DragController::concludeEditDrag): Remove createLiveRange.
(WebCore::DragController::startDrag): Ditto.

* page/TextIndicator.cpp:
(WebCore::selectionRects): Deleted.
(WebCore::initializeIndicator): Call collectSelectionRects directly here,
avoiding createLiveRange and using map to convert from Vector<SelectionRect>
to Vector<FloatRect>.

* page/ios/FrameIOS.mm:
(WebCore::Frame::interpretationsForCurrentRoot const): Use makeSimpleRange.

* platform/DragImage.cpp:
(WebCore::createDragImageForRange): Take SimpleRange.
* platform/DragImage.h: Update createDragImageForRange to take SimpleRange.

* platform/Pasteboard.h: Updated Windows-only layering-violating functions
to take SimpleRange.

* platform/ios/DragImageIOS.mm:
(WebCore::createDragImageForRange): Take SimpleRange.

* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeRangeToDataObject): Take SimpleRange.
(WebCore::Pasteboard::writeSelection): Ditto.
(WebCore::Pasteboard::documentFragment): Ditto.

* rendering/RenderObject.cpp:
(WebCore::intervalsSufficientlyOverlap): Added. Moved from Range. Mostly unchanged
but uses SimpleRange now instead of a live range, and intersectingNodes instead of
a loop using firstNode and pastLastNode.
(WebCore::adjustLineHeightOfSelectionRects): Ditto.
(WebCore::coalesceSelectionRects): Ditto.
(WebCore::RenderObject::collectSelectionRectsWithoutUnionInteriorLines): Ditto.
(WebCore::RenderObject::collectSelectionRectsInternal): Ditto.
(WebCore::RenderObject::collectSelectionRects): Ditto.
* rendering/RenderObject.h: Update for above.

* testing/Internals.cpp:
(WebCore::Internals::markerRangeForNode): Use makeSimplRange.
(WebCore::Internals::locationFromRange): Ditto.
(WebCore::Internals::lengthFromRange): Ditto.
(WebCore::Internals::rangeAsTextUsingBackwardsTextIterator): Ditto.
(WebCore::Internals::subrange): Ditto.
(WebCore::Internals::rangeOfStringNearLocation): Ditto.
(WebCore::Internals::textIndicatorForRange): Ditto.

Source/WebKit:

* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.mm:
(-[WKWebProcessPlugInRangeHandle detectDataWithTypes:context:]): Use makeSimpleRange.
* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(API::PageOverlayClientImpl::actionContextForResultAtPoint): Ditto.
* WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:
(-[WKDOMRange textRects]): Ditto.
* WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm:
(-[WKDOMTextIterator initWithRange:]): Ditto.
* WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
(WebKit::InjectedBundleRangeHandle::renderedImage): Ditto.

* WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation): Remove createLiveRange.
(WebKit::WebPage::performDictionaryLookupForSelection): Ditto.
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindUIAfterPageScroll): Ditto.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPlatformEditorState const): Ditto.
(WebKit::WebPage::computeAndSendEditDragSnapshot): Ditto.
(WebKit::WebPage::getRectsForGranularityWithSelectionOffset): Ditto.
(WebKit::WebPage::getRectsAtSelectionOffsetWithText): Ditto.
(WebKit::WebPage::requestAutocorrectionData): Ditto.

Source/WebKitLegacy/ios:

* WebCoreSupport/WebFrameIOS.mm:
(-[WebFrame selectionRectsForCoreRange:]): Remove createLiveRange.
(-[WebFrame selectionRectsForRange:]): Use makeSimpleRange.
* WebCoreSupport/WebVisiblePosition.mm:
(-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]): Ditto.
(-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]): Ditto.
(+[DOMRange rangeForFirstPosition:second:]): Rename firstVP/secondVP
to firstPosition/secondPosition.

Source/WebKitLegacy/mac:

* DOM/DOM.mm:
(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):
Use makeSimpleRange.
(-[DOMRange textRects]): Ditto.

* DOM/DOMDocument.mm: Update includes.
* DOM/DOMRange.mm: Ditto.
* DOM/DOMRangeInternal.h: Ditto.
* DOM/DOMUIKitExtensions.mm: Ditto.
* DOM/DOMUtility.mm: Ditto.

* DOM/WebDOMOperations.mm:
(-[DOMRange webArchive]): Use makeSimpleRange.
(-[DOMRange markupString]): Ditto.

* WebView/WebFrame.mm:
(-[WebFrame _stringForRange:]): Use makeSimpleRange.
(-[WebFrame _convertToDOMRange:]): Return a SimpleRange.
(-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]): Ditto.
(-[WebFrame _convertNSRangeToDOMRange:]): Update for above.
(-[WebFrame _convertDOMRangeToNSRange:]): Use makeSimpleRange.
(-[WebFrame _selectNSRange:]): Update for above.
(-[WebFrame selectWithoutClosingTypingNSRange:]): Ditto.
(-[WebFrame getDictationResultRanges:andMetadatas:]): Use makeSimpleRange.
(-[WebFrame dictationResultMetadataForRange:]): Ditto.
* WebView/WebFrameInternal.h: Update for above.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
Use makeSimpleRange.
(-[WebHTMLView attributedSubstringFromRange:]): Use auto.
(-[WebHTMLView _attributedStringFromDOMRange:]): Deleted.
(-[WebHTMLView attributedString]): Rewrote to use SimpleRange consistently.
(-[WebHTMLView selectedAttributedString]): Ditto.

* WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _animationControllerForDataDetectedText]):
Use makeSimpleRange.
* WebView/WebTextIterator.mm:
(-[WebTextIterator initWithRange:]): Ditto.

* WebView/WebView.mm:
(-[WebView _didConcludeEditDrag]): Remove createLiveRange.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoUnreviewed, fix CLoop build
ysuzuki@apple.com [Sun, 2 Aug 2020 23:05:35 +0000 (23:05 +0000)]
Unreviewed, fix CLoop build
https://bugs.webkit.org/show_bug.cgi?id=215010

* tools/SigillCrashAnalyzer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoTable data is incorrectly translated in some articles on en.wikipedia.org
wenson_hsieh@apple.com [Sun, 2 Aug 2020 20:49:26 +0000 (20:49 +0000)]
Table data is incorrectly translated in some articles on en.wikipedia.org
https://bugs.webkit.org/show_bug.cgi?id=215071
<rdar://problem/66354013>

Reviewed by Darin Adler.

Source/WebCore:

Text in table cells sometimes end up in adjacent cells after translation, since adjacent cells are currently
extracted as different tokens in a single item; mitigate this by splitting text in table cells into different
text manipulation items instead.

Test: TextManipulation.StartTextManipulationExtractsTableCellsAsSeparateItems

* editing/TextManipulationController.cpp:
(WebCore::isEnclosingItemBoundaryElement):

Tools:

Add a new API test to exercise the change.

* TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoWrite a script to find duplicate files and delete some duplicate tests in LayoutTests
darin@apple.com [Sun, 2 Aug 2020 15:12:40 +0000 (15:12 +0000)]
Write a script to find duplicate files and delete some duplicate tests in LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=215073

Reviewed by Anders Carlsson.

Tools:

* Scripts/find-duplicate-files: Added. Basic script that uses MD5 digests
to find duplicate files.

* Scripts/report-non-inclusive-language: Tweaked a tiny bit; use a variable.

LayoutTests:

* TestExpectations: Removed expectations for removed tests.

* css2.1/20110323/abspos-containing-block-initial-004d.htm.1: Removed.
The above was just a stray copy of a test with the wrong extension, so ignored.

* css3/font-variant-petite-caps-synthesis-coverage-expected.html: Removed.
* css3/font-variant-petite-caps-synthesis-coverage.html: Removed.
* css3/font-variant-small-caps-synthesis-coverage-expected.html: Removed.
* css3/font-variant-small-caps-synthesis-coverage.html: Removed.
These are duplicates of the same tests without the suffix "coverage".

* fast/dom/Document/document-close-iframe-load-expected.txt: Removed.
* fast/dom/Document/document-close-iframe-load.html: Removed.
* fast/dom/Document/document-close-nested-iframe-load-expected.txt: Removed.
* fast/dom/Document/document-close-nested-iframe-load.html: Removed.
These tests are also in the directory "fast/parser". Chose to delete this copy.

* fast/forms/label/labels-set-htmlFor-attribute-expected.txt: Removed.
* fast/forms/label/labels-set-htmlFor-attribute.html: Removed.
This test also exists under the name "labels-change-...".

* fast/loader/unload-form-about-blank-expected.txt: Removed.
* fast/loader/unload-form-about-blank.html: Removed.
This test also exists under the name "unload-form-post-about-blank...".

* fast/ruby/before-table-doesnt-crash-expected.txt: Removed.
* fast/ruby/before-table-doesnt-crash.html: Removed.
This is just a copy of the test "before-block-...", not a separate test.

* http/tests/misc/submit-post-in-utf16be.html:
Used the iconv tool to turn this into a UTF-16BE input file so it tests
what it is intended to test. Before this was a UTF-16LE file.

* imported/blink/001-a-expected.html: Removed.
* imported/blink/001-a.html: Removed.
* imported/blink/001-q-expected.html: Removed.
* imported/blink/001-q.html: Removed.
* imported/blink/001-s-expected.html: Removed.
* imported/blink/001-s.html: Removed.
These are identical duplicates of tests that are in WPT.

* imported/blink/animations/animation-events-prefixed-04-expected.txt: Removed.
* imported/blink/animations/animation-events-prefixed-04.html: Removed.
* imported/blink/animations/animation-events-unprefixed-04-expected.txt: Removed.
* imported/blink/animations/animation-events-unprefixed-04.html: Removed.
These are duplicates of tests in the directory imported/blink/virtual/stable/animations-unprefixed.

* imported/blink/css3/flexbox/relpos-with-scrollable-with-abspos-crash-expected.txt: Removed.
* imported/blink/css3/flexbox/relpos-with-scrollable-with-abspos-crash.html: Removed.
* imported/blink/fast/css-grid-layout/grid-item-before-anonymous-child-crash-expected.txt: Removed.
* imported/blink/fast/css-grid-layout/grid-item-before-anonymous-child-crash.html: Removed.
* imported/blink/fast/css-grid-layout/grid-item-paddings-and-writing-modes-expected.html: Removed.
* imported/blink/fast/css-grid-layout/grid-item-paddings-and-writing-modes.html: Removed.
* imported/blink/fast/dom/Range/create-contextual-fragment-script-not-ran-expected.txt: Removed.
* imported/blink/fast/dom/Range/create-contextual-fragment-script-not-ran.html: Removed.
* imported/blink/fast/dom/Range/create-contextual-fragment-script-unmark-already-started-expected.txt: Removed.
* imported/blink/fast/dom/Range/create-contextual-fragment-script-unmark-already-started.html: Removed.
* imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-archive-codebase-expected.txt: Removed.
* imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-archive-codebase.html: Removed.
* imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-archive-expected.txt: Removed.
* imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-archive.html: Removed.
* imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-code-codebase-expected.txt: Removed.
* imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-code-codebase.html: Removed.
* imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-code-expected.txt: Removed.
* imported/blink/http/tests/security/contentSecurityPolicy/object-src-applet-code.html: Removed.
These are identical duplicates of tests in the same named directories outside "imported/blink".
Maybe imported by Blink from WebKit and then back?

* imported/blink/img_border_percent-expected.xhtml: Removed.
* imported/blink/img_border_percent.xhtml: Removed.
* imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/cols-default-expected.html: Removed.
* imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/cols-default.html: Removed.
* imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/cols-zero-expected.html: Removed.
* imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/cols-zero.html: Removed.
* imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/rows-default-expected.html: Removed.
* imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/rows-default.html: Removed.
* imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/rows-zero-expected.html: Removed.
* imported/blink/imported/web-platform-tests/html/rendering/bindings/the-textarea-element-0/rows-zero.html: Removed.
* imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/figure-expected.html: Removed.
* imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/figure.html: Removed.
* imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/tables/table-layout-expected.html: Removed.
* imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/tables/table-layout.html: Removed.
* imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/tables/table-width-150percent-expected.html: Removed.
* imported/blink/imported/web-platform-tests/html/rendering/non-replaced-elements/tables/table-width-150percent.html: Removed.
* imported/blink/imported/web-platform-tests/html/rendering/replaced-elements/images/space-expected.html: Removed.
* imported/blink/imported/web-platform-tests/html/rendering/replaced-elements/images/space.html: Removed.
* imported/blink/object_border_perc-expected.xhtml: Removed.
* imported/blink/object_border_perc.xhtml: Removed.
* imported/blink/object_border_pixel-expected.xhtml: Removed.
* imported/blink/object_border_pixel.xhtml: Removed.
These are identical duplicates of tests that are in WPT.

* platform/gtk/TestExpectations: Removed expectations for removed tests.
* platform/ios/TestExpectations: Ditto.
* platform/win/TestExpectations: Ditto.
* platform/wpe/TestExpectations: Ditto.

* svg/dom/SVGLengthList-removeItem-expected.txt: Removed.
* svg/dom/SVGLengthList-removeItem.xhtml: Removed.
This was a duplicate of the SVGLengthList-addItem test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoUnreviewed, reverting r265151.
commit-queue@webkit.org [Sun, 2 Aug 2020 08:22:41 +0000 (08:22 +0000)]
Unreviewed, reverting r265151.
https://bugs.webkit.org/show_bug.cgi?id=215074

Broke ARM64E JSC tests

Reverted changeset:

"validate untagArrayPtr"
https://bugs.webkit.org/show_bug.cgi?id=214953
https://trac.webkit.org/changeset/265151

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoRemove superfluous ResourceTiming constructor overload
commit-queue@webkit.org [Sun, 2 Aug 2020 06:21:06 +0000 (06:21 +0000)]
Remove superfluous ResourceTiming constructor overload
https://bugs.webkit.org/show_bug.cgi?id=215063

Patch by Rob Buis <rbuis@igalia.com> on 2020-08-01
Reviewed by Sam Weinig.

Remove superfluous ResourceTiming constructor overload, we
can just call another overload from ResourceTiming::fromLoad.

* loader/ResourceTiming.cpp:
(WebCore::ResourceTiming::fromLoad):
* loader/ResourceTiming.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoRemove test expectation for a WPT test that was removed
darin@apple.com [Sun, 2 Aug 2020 03:19:39 +0000 (03:19 +0000)]
Remove test expectation for a WPT test that was removed
https://bugs.webkit.org/show_bug.cgi?id=215066
rdar://42904780

Reviewed by Sam Weinig.

* platform/mac-wk1/TestExpectations: Removed failure expectation for
a WPT WebCryptoAPI test that no longer exists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoSpecial HID mapping for the Logitech F310/F710 controllers.
beidson@apple.com [Sun, 2 Aug 2020 02:53:25 +0000 (02:53 +0000)]
Special HID mapping for the Logitech F310/F710 controllers.
https://bugs.webkit.org/show_bug.cgi?id=215050

Reviewed by Tim Horton.

Source/WebCore:

Covered by API test.

These two controllers match the standard mapping perfectly. Easy to support.

* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:

* platform/gamepad/KnownGamepads.h:

* platform/gamepad/mac/GamepadConstantsMac.h:

* platform/gamepad/mac/HIDGamepad.cpp:
(WebCore::HIDGamepad::create):

* platform/gamepad/mac/HIDGamepadElement.cpp:
(WebCore::HIDGamepadElement::HIDGamepadElement):
* platform/gamepad/mac/HIDGamepadElement.h:
(WebCore::HIDGamepadElement::isAxis const):

* platform/gamepad/mac/LogitechGamepad.cpp: Added.
(WebCore::LogitechGamepadHatswitch::gamepadValueChanged):
(WebCore::LogitechGamepad::LogitechGamepad):
* platform/gamepad/mac/LogitechGamepad.h:

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

* TestWebKitAPI/Tests/mac/HIDGamepads.mm:

* TestWebKitAPI/mac/GamepadMappings/LogitechF310.mm: Added.
(TestWebKitAPI::publishReportCallback):
(TestWebKitAPI::VirtualGamepad::logitechF310Mapping):

* TestWebKitAPI/mac/GamepadMappings/LogitechF710.mm: Added.
(TestWebKitAPI::publishReportCallback):
(TestWebKitAPI::VirtualGamepad::logitechF710Mapping):

* TestWebKitAPI/mac/VirtualGamepad.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoUnreviewed. Remove the build warnings below since r265150.
jh718.park@samsung.com [Sun, 2 Aug 2020 01:50:08 +0000 (01:50 +0000)]
Unreviewed. Remove the build warnings below since r265150.
warning: unused parameter ‘foo’ [-Wunused-parameter]

No new tests, no new behaviors.

* workers/service/server/SWServerJobQueue.cpp:
(WebCore::doCertificatesMatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoFix and further refine makefile rule for WebKit messages generated files
darin@apple.com [Sun, 2 Aug 2020 01:18:20 +0000 (01:18 +0000)]
Fix and further refine makefile rule for WebKit messages generated files
https://bugs.webkit.org/show_bug.cgi?id=215064

Reviewed by Sam Weinig.

* DerivedSources-output.xcfilelist: Updated for a file that was omitted
because of a typo in the makefile.
* DerivedSources.make: Fix "addsufix" typo and reorganized things a bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoSpecial HID mapping for the Google Stadia controller
beidson@apple.com [Sat, 1 Aug 2020 22:55:47 +0000 (22:55 +0000)]
Special HID mapping for the Google Stadia controller
https://bugs.webkit.org/show_bug.cgi?id=215061

Reviewed by Tim Horton.

Source/WebCore:

New API test coverage.

* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/gamepad/GamepadConstants.h:
* platform/gamepad/KnownGamepads.h:
* platform/gamepad/mac/GamepadConstantsMac.h:

* platform/gamepad/mac/HIDGamepad.cpp:
(WebCore::HIDGamepad::create):

* platform/gamepad/mac/HIDGamepadElement.cpp:
(WebCore::HIDGamepadElement::HIDGamepadElement):
(WebCore::HIDGamepadHatswitch::gamepadValueChanged):
(WebCore::HIDGamepadHatswitch::normalizedValue):
* platform/gamepad/mac/HIDGamepadElement.h:
(WebCore::HIDGamepadElement::isAxis const):
(WebCore::HIDGamepadHatswitch::HIDGamepadHatswitch):

* platform/gamepad/mac/StadiaHIDGamepad.cpp: Added.
(WebCore::StadiaHIDGamepad::StadiaHIDGamepad):
* platform/gamepad/mac/StadiaHIDGamepad.h:

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/HIDGamepads.mm:

* TestWebKitAPI/mac/GamepadMappings/GoogleStadia.mm: Added.
(TestWebKitAPI::publishReportCallback):

(TestWebKitAPI::VirtualGamepad::googleStadiaMapping):
* TestWebKitAPI/mac/VirtualGamepad.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoUnreviewed, reverting r265097, r265113, and r265122.
commit-queue@webkit.org [Sat, 1 Aug 2020 21:48:25 +0000 (21:48 +0000)]
Unreviewed, reverting r265097, r265113, and r265122.
https://bugs.webkit.org/show_bug.cgi?id=215065

Broke AppleSilicon Big Sur

Reverted changesets:

"Strip pointers instead of authing for byteOffset to not allow
for a possible way to guess data pac"
https://bugs.webkit.org/show_bug.cgi?id=214952
https://trac.webkit.org/changeset/265097

"Compute number of PAC bits from what the OS says its address
space is"
https://bugs.webkit.org/show_bug.cgi?id=214986
https://trac.webkit.org/changeset/265113

"Remove UB from nonPACBitsMask computation"
https://bugs.webkit.org/show_bug.cgi?id=214996
https://trac.webkit.org/changeset/265122

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoPrevent multiple invocations of generate-message-receiver.py
krollin@apple.com [Sat, 1 Aug 2020 17:54:44 +0000 (17:54 +0000)]
Prevent multiple invocations of generate-message-receiver.py
https://bugs.webkit.org/show_bug.cgi?id=215054

Reviewed by Darin Adler.

WebKit/DerivedSources.make is written such that
generate-message-receiver.py can be invoked N times, where N is the
value passed to -j. This results in the N invocations of
generate-message-receiver.py trying trying to generate the same set of
files at the same time, possibly leading to their being corrupted. We
have reports of generated files starting with a 4K block of NULs, and
this contention may be causing it. Address this by using a "pattern
rule" in the makefile, which is documented in GNU make's documentation
as the approach to take when there is one build rule that creates
multiple outputs, as is the case here.

See also <https://bugs.webkit.org/show_bug.cgi?id=166814> and
<http://trac.webkit.org/changeset/210507>.

No new tests -- no new or changed functionality.

* DerivedSources.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoConvert LinkHeader to use StringParsingBuffer
weinig@apple.com [Sat, 1 Aug 2020 17:51:17 +0000 (17:51 +0000)]
Convert LinkHeader to use StringParsingBuffer
https://bugs.webkit.org/show_bug.cgi?id=215017

Reviewed by Darin Adler.

Update LinkHeader parsing to use StringParsingBuffer and do some light cleanup.

* loader/LinkHeader.cpp:
(WebCore::isSpaceOrTab):
(WebCore::isNotURLTerminatingChar):
(WebCore::isValidParameterNameChar):
(WebCore::isParameterValueEnd):
(WebCore::isParameterValueChar):
(WebCore::findURLBoundaries):
(WebCore::invalidParameterDelimiter):
(WebCore::validFieldEnd):
(WebCore::parseParameterDelimiter):
(WebCore::paramterNameFromString):
(WebCore::parseParameterName):
(WebCore::skipQuotesIfNeeded):
(WebCore::parseParameterValue):
(WebCore::findNextHeader):
(WebCore::LinkHeader::LinkHeader):
(WebCore::LinkHeaderSet::LinkHeaderSet):
(WebCore::LinkHeaderSet::init): Deleted.
* loader/LinkHeader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoRemove Range::create and many more uses of live ranges
darin@apple.com [Sat, 1 Aug 2020 15:50:36 +0000 (15:50 +0000)]
Remove Range::create and many more uses of live ranges
https://bugs.webkit.org/show_bug.cgi?id=215004

Reviewed by Sam Weinig.

Source/WebCore:

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange const):
Use makeSimpleRange.
* accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::nodeTextChangePlatformNotification): Use SimpleRange.
* accessibility/atk/WebKitAccessibleHyperlink.cpp:
(rangeLengthForObject): Take SimpleRange.
(webkitAccessibleHyperlinkGetStartIndex): Use makeSimpleRange.
(webkitAccessibleHyperlinkGetEndIndex): Ditto.
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getSelectionOffsetsForObject): Ditto.
* accessibility/atk/WebKitAccessibleUtil.cpp:
(objectFocusedAndCaretOffsetUnignored): Ditto.

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(+[WebAccessibilityTextMarker startOrEndTextMarkerForRange:isStart:cache:]):
Take SimpleRange.
(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):
Use makeSimpleRange.
(-[WebAccessibilityObjectWrapper _convertToDOMRange:]): Return SimpleRange.
(-[WebAccessibilityObjectWrapper textMarkerRange]): Remove createLiveRange.
(-[WebAccessibilityObjectWrapper textMarkerForPosition:]): Use auto.
(-[WebAccessibilityObjectWrapper misspellingTextMarkerRange:forward:]):
Remove createLiveRange.
(-[WebAccessibilityObjectWrapper rangeFromMarkers:withText:]): Return SimpleRange.
(-[WebAccessibilityObjectWrapper textRectsFromMarkers:withText:]): Add createLiveRange.
(-[WebAccessibilityObjectWrapper rangeForTextMarkers:]): Return SimpleRange.
(-[WebAccessibilityObjectWrapper startOrEndTextMarkerForTextMarkers:isStart:]):
Use auto.
(-[WebAccessibilityObjectWrapper textMarkerRangeForMarkers:]): Get rid of local.
(-[WebAccessibilityObjectWrapper textMarkersForRange:]): Take SimpleRange.

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(accessibilityTextOperationForParameterizedAttribute): Remove makeSimpleRange.
(accessibilityMisspellingSearchCriteriaForParameterizedAttribute): Return SimpleRange.
(-[WebAccessibilityObjectWrapper textMarkerRangeFromRange:]): Take SimpleRange.
(textMarkerRangeFromRange): Ditto.
(-[WebAccessibilityObjectWrapper startOrEndTextMarkerForRange:isStart:]): Ditto.
(startOrEndTextmarkerForRange): Return SimpleRange.
(-[WebAccessibilityObjectWrapper rangeForTextMarkerRange:]): Ditto.
(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:]):
Use auto.
(-[WebAccessibilityObjectWrapper doAXAttributedStringForRange:]): Remove createLiveRange.
(-[WebAccessibilityObjectWrapper textMarkerRangeAtTextMarker:forUnit:]): Ditto.
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]): Ditto.

* dom/DocumentMarkerController.cpp:
(WebCore::updateRenderedRectsForMarker): Use document marker range function.
(WebCore::range): Added.
* dom/DocumentMarkerController.h: Update for above.

* dom/Position.cpp: Removed unneeded Range.h include.

* dom/Range.cpp:
(WebCore::Range::Range): Removed unused overload that takes start/end.
(WebCore::Range::create): Removed overloads that take start/end.
(WebCore::Range::setStart): Removed overload that takes Position.
(WebCore::Range::setEnd): Ditto.
(WebCore::Range::cloneRange const): Rewrote to use setStart/End since
that's what the constructor used to do.
(WebCore::Range::contains const): Use SimpleRange/createLiveRange
instead of makeRange. Soon this function will be deleted.
(WebCore::rangeOfContents): Deleted.
(WebCore::createLiveRange): Rewrote to use setStart/End since that's
what the constructor used to do.
* dom/Range.h: Update for above removals.

* dom/SimpleRange.h: Export commonInclusiveAncestor for use outside WebCore.

* dom/StaticRange.cpp:
(WebCore::StaticRange::create): Added overload that copies the SimpleRange.
* dom/StaticRange.h: Update for above.

* editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord): Use document
marker range function.

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): Use makeSimpleRange.
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::mergeParagraphs): Ditto.
(WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
Ditto.

* editing/EditingStyle.cpp:
(WebCore::EditingStyle::textDirectionForSelection): Use makeSimpleRange and
intersectingNodes.

* editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment): Use makeRangeSelectingNodeContents.
(WebCore::Editor::updateMarkersForWordsAffectedByEditing): Use makeSimpleRange.
(WebCore::Editor::transpose): Ditto.
(WebCore::Editor::rangeOfString): Use makeRangeSelectingNodeContents.
(WebCore::Editor::handleAcceptedCandidate): Update since rangeForTextCheckingResult
now returns an Optional<SimpleRange>.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::selectRangeOnElement): Use SimpleRange.

* editing/ReplaceRangeWithTextCommand.cpp:
(WebCore::ReplaceRangeWithTextCommand::ReplaceRangeWithTextCommand): Take
SimpleRange.
(WebCore::ReplaceRangeWithTextCommand::willApplyCommand): Update since
m_rangeToBeReplaced is a SimpleRange.
(WebCore::ReplaceRangeWithTextCommand::doApply): Ditto.
(WebCore::ReplaceRangeWithTextCommand::targetRanges const): Ditto.
* editing/ReplaceRangeWithTextCommand.h: Update for above.

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::insertedContentRange const):
Return a SimpleRange.
* editing/ReplaceSelectionCommand.h: Update for above.

* editing/SpellingCorrectionCommand.cpp:
(WebCore::SpellingCorrectionCommand::SpellingCorrectionCommand):
Take a SimpleRange.
(WebCore::SpellingCorrectionCommand::create): Moved here from header.
* editing/SpellingCorrectionCommand.h: Update for above.

* editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::findFirstMisspelledWordOrUngrammaticalPhrase const):
Use makeSimpleRange.

* editing/TypingCommand.cpp:
(WebCore::TypingCommand::markMisspellingsAfterTyping): Use makeSimpleRange.
(WebCore::TypingCommand::willAddTypingToOpenCommand): Take SimpleRange.
(WebCore::TypingCommand::deleteKeyPressed): Remove createLiveRange.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
* editing/TypingCommand.h: Update for above.

* editing/VisiblePosition.cpp:
(WebCore::makeRange): Deleted.
(WebCore::startVisiblePosition): Deleted.
(WebCore::endVisiblePosition): Deleted.
(WebCore::setStart): Deleted.
(WebCore::setEnd): Deleted.
* editing/VisiblePosition.h: Update for above. Also export makeSimpleRange
for use outside WebCore.

* editing/VisibleUnits.cpp:
(WebCore::suffixLengthForRange): Take SimpleRange.
(WebCore::prefixLengthForRange): Ditto.
(WebCore::previousBoundary): Use makeSimpleRange.
(WebCore::nextBoundary): Ditto.
* editing/VisibleUnits.h: Update for above.

* editing/cocoa/DataDetection.mm:
(WebCore::buildQuery): Remove unused local variable.

* editing/ios/EditorIOS.mm:
(WebCore::Editor::setDictationPhrasesAsChildOfElement): Use makeRangeSelectingNodeContents.

* page/DOMSelection.cpp:
(WebCore::DOMSelection::getRangeAt): Use createLiveRange.

* page/DragController.cpp:
(WebCore::DragController::insertDroppedImagePlaceholdersAtCaret): Remove makeSimpleRange.

* page/Frame.cpp:
(WebCore::Frame::rangeForPoint): Return SimpleRange.
* page/Frame.h: Update for above.

* page/ios/FrameIOS.mm:
(WebCore::Frame::interpretationsForCurrentRoot const): Use makeRangeSelectingNodeContents,
intersectingNodes, and makeSimpleRange.

* testing/Internals.cpp:
(WebCore::Internals::markerRangeForNode): Use createLiveRange and the document
marker range function.

Source/WebKit:

* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(API::PageOverlayClientImpl::actionContextForResultAtPoint): Return a
structure that includes a SimpleRange.

* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::visibleRange): Use makeSimpleRange.

* WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.h: Use SimpleRange.
* WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:
(WebKit::TextCheckingControllerProxy::rangeAndOffsetRelativeToSelection): Use SimpleRange.
(WebKit::TextCheckingControllerProxy::replaceRelativeToSelection): Ditto.
(WebKit::TextCheckingControllerProxy::removeAnnotationRelativeToSelection): Ditto.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::characterIndexForPointAsync): Remove makeSimpleRange.
(WebKit::WebPage::deleteSurrounding): Use makeSimpleRange.

* WebProcess/WebPage/WebPageOverlay.cpp:
(WebKit::WebPageOverlay::actionContextForResultAtPoint): Use return value instead of out argument.
* WebProcess/WebPage/WebPageOverlay.h: Update for above.

* WebProcess/WebPage/glib/WebPageGLib.cpp:
(WebKit::WebPage::getPlatformEditorState const): Use makeSimpleRange.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::computeEditableRootHasContentAndPlainText): Use makeSimpleRange.
(WebKit::WebPage::getRectsForGranularityWithSelectionOffset): Removed unneeded null checks that
are already done by makeSimpleRange.
(WebKit::WebPage::getRectsAtSelectionOffsetWithText): Use makeSimpleRange.
(WebKit::WebPage::requestDictationContext): Ditto.
(WebKit::WebPage::autocorrectionContext): Ditto.
(WebKit::linkIndicatorPositionInformation): Use makeRangeSelectingNodeContents.
(WebKit::dataDetectorLinkPositionInformation): Ditto.
(WebKit::WebPage::requestDocumentEditingContext): Use makeSimpleRange.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performImmediateActionHitTestAtLocation): Update for change to the
actionContextForResultAtPoint return value.

Source/WebKitLegacy/ios:

* WebCoreSupport/WebFrameIOS.mm:
(-[WebFrame wordAtPoint:]): Use makeSimpleRange.

* WebCoreSupport/WebVisiblePosition.mm:
(-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]): Use document
marker range function.
(-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]): Ditto.
(+[DOMRange rangeForFirstPosition:second:]): Use makeSimpleRange.

Source/WebKitLegacy/mac:

* DOM/DOMUIKitExtensions.mm:
(-[DOMNode rangeOfContainingParagraph]): Use makeSimpleRange.

* WebView/WebFrame.mm:
(-[WebFrame _characterRangeAtPoint:]): Update since rangeAtPoint takes a SimpleRange.
(-[WebFrame getDictationResultRanges:andMetadatas:]): Use document marker range function.

* WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _defaultAnimationController]): Use makeRangeSelectingNodeContents.
(-[WebImmediateActionController _animationControllerForDataDetectedLink]): Ditto.

Source/WebKitLegacy/win:

* AccessibleTextImpl.cpp:
(AccessibleText::scrollSubstringTo): Use makeSimpleRange.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoUnreviewed, reverting r265171.
commit-queue@webkit.org [Sat, 1 Aug 2020 13:40:58 +0000 (13:40 +0000)]
Unreviewed, reverting r265171.
https://bugs.webkit.org/show_bug.cgi?id=215060

broke 2 mac api tests

Reverted changeset:

"[Mac] Add Experimental Feature preference for SW VP9"
https://bugs.webkit.org/show_bug.cgi?id=215043
https://trac.webkit.org/changeset/265171

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoUnable to select multiple lines of vertical text correctly
megan_gardner@apple.com [Sat, 1 Aug 2020 08:02:05 +0000 (08:02 +0000)]
Unable to select multiple lines of vertical text correctly
https://bugs.webkit.org/show_bug.cgi?id=213671
<rdar://problem/53753636>

Reviewed by Darin Adler.

In order to make for a better text selection experience, we pulled the selection position
down to be on the last line selectable, rather than snap the selection to a single position.
This made for a better selection experience on small text, but we failed to take
vertical text into account, and a user is locked into only selecting vertical text that ends below the
other anchor point of the selection. We should have the same behavior for vertical text, but correctly
calculated for X instead of Y.
This does not fix all cases, but it fixes the most glaring cases.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::rangeForPointInRootViewCoordinates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[Mac] AudioSessionRoutingArbitrator causes a launch time regression checking for...
jer.noble@apple.com [Sat, 1 Aug 2020 06:09:15 +0000 (06:09 +0000)]
[Mac] AudioSessionRoutingArbitrator causes a launch time regression checking for CoreAudio muted state
https://bugs.webkit.org/show_bug.cgi?id=214993

Reviewed by Eric Carlson.

The initial query of isMuted() is only there to tell whether, when we get a notification that the mute state
changed, whether our internal state is dirty and we need to fire a notification. Instead, replace the bool member
with an Optional<bool>, so we know we need to fire a changed notification whenever the first mute state change
comes in.

* platform/audio/mac/AudioSessionMac.mm:
(WebCore::AudioSession::AudioSession):
(WebCore::AudioSession::handleMutedStateChange):
(WebCore::AudioSessionPrivate::AudioSessionPrivate): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoUnreviewed Windows build fix after r265167; add some missing includes.
jer.noble@apple.com [Sat, 1 Aug 2020 05:57:38 +0000 (05:57 +0000)]
Unreviewed Windows build fix after r265167; add some missing includes.

* page/Screen.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[Mac] Add Experimental Feature preference for SW VP9
jer.noble@apple.com [Sat, 1 Aug 2020 01:29:57 +0000 (01:29 +0000)]
[Mac] Add Experimental Feature preference for SW VP9
https://bugs.webkit.org/show_bug.cgi?id=215043
<rdar://problem/66400034>

Reviewed by Beth Dakin.

* FeatureFlags/WebKit.plist:
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
* Shared/WebPageCreationParameters.h:
* Shared/WebPreferences.yaml:
* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultVP9SWDecoderEnabledOnBattery):
* Shared/WebPreferencesDefaultValues.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::m_limitsNavigationsToAppBoundDomains):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::enableVP9Decoder):
(WebKit::WebProcess::enableVP9SWDecoder):
* WebProcess/WebProcess.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoClean up text layout code a bit
mmaxfield@apple.com [Sat, 1 Aug 2020 00:36:14 +0000 (00:36 +0000)]
Clean up text layout code a bit
https://bugs.webkit.org/show_bug.cgi?id=215013

Reviewed by Zalan Bujtas.

This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=214769.

See file-specific ChangeLog entries for more information.

No tests because there is no behavior change.

* platform/graphics/Font.h: Remove unnecessary declaration.
* platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::layoutText const): Rename glyphBufferForTextRun() to layoutText().
Also, make it return a GlyphBuffer instead of taking a GlyphBuffer as an out param.
Its previous return, the initial advance, is now returned in GlyphBuffer::initialAdvance.
(WebCore::FontCascade::drawText const): Update to new signature of layoutText().
(WebCore::FontCascade::drawEmphasisMarks const): Inline drawEmphasisMarksForSimpleText()
and drawEmphasisMarksForComplexText(), since they're nearly identical. Update to the new
signature of layoutText().
(WebCore::FontCascade::displayListForTextRun const): Update to the new signature of
layoutText().
(WebCore::FontCascade::layoutSimpleText const): Make this return a new GlyphBuffer, instead
of taking one as an out param. Also, use accessors of WidthIterator instead of reaching
into its guts. The previous return value is now returned in GlyphBuffer::initialAdvance.
(WebCore::FontCascade::layoutComplexText const): Ditto.
(WebCore::FontCascade::floatWidthForSimpleText const): Use accessors of WidthIterator
instead of reaching into its guts.
(WebCore::FontCascade::adjustSelectionRectForSimpleText const): Ditto.
(WebCore::FontCascade::offsetForPositionForSimpleText const): Ditto.
(WebCore::FontCascade::dashesForIntersectionsWithRect const): Same as
FontCascade::drawEmphasisMarks() above.
(WebCore::FontCascade::glyphBufferForTextRun const): Renamed to layoutText().
(WebCore::FontCascade::getGlyphsAndAdvancesForSimpleText const): Renamed to
layoutSimpleText().
(WebCore::FontCascade::getGlyphsAndAdvancesForComplexText const): Renamed to
layoutComplexText().
(WebCore::FontCascade::drawEmphasisMarksForSimpleText const): Inlined into
drawEmphasisMarks().
(WebCore::FontCascade::drawEmphasisMarksForComplexText const): Ditto.
* platform/graphics/FontCascade.h:
* platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBufferAdvance::GlyphBufferAdvance):
(WebCore::GlyphBufferAdvance::operator FloatSize):
* platform/graphics/TextRun.h: Remove unnecessary declaration.
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator): Update for changes to WidthIterator.h
* platform/graphics/WidthIterator.h: Rearrange the class members to sort them by size,
to get better packing. Also, make all member variables private, and initialize them
all with { } syntax.
(WebCore::WidthIterator::finalRoundingWidth const):
(WebCore::WidthIterator::currentCharacter const):
* rendering/svg/SVGTextMetrics.cpp: Remove unnecessary include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoUse more inclusive terminology in Tools
commit-queue@webkit.org [Sat, 1 Aug 2020 00:30:07 +0000 (00:30 +0000)]
Use more inclusive terminology in Tools
https://bugs.webkit.org/show_bug.cgi?id=214971

Patch by Alex Christensen <achristensen@webkit.org> on 2020-07-31
Reviewed by Sam Weinig.

Source/WebKitLegacy/win:

* Interfaces/IWebViewPrivate.idl:
Rename some test-only API.  This should not affect binary compatibility because everything is in the same locations, and the changed API is only used for tests.
* WebView.h:
* WebView.cpp:

Tools:

* DumpRenderTree/TestRunner.cpp:
(addOriginAccessAllowListEntryCallback):
(removeOriginAccessAllowListEntryCallback):
(TestRunner::staticFunctions):
(addOriginAccessWhitelistEntryCallback): Deleted.
(removeOriginAccessWhitelistEntryCallback): Deleted.
* DumpRenderTree/TestRunner.h:
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::addOriginAccessAllowListEntry):
(TestRunner::removeOriginAccessAllowListEntry):
(TestRunner::addOriginAccessWhitelistEntry): Deleted.
(TestRunner::removeOriginAccessWhitelistEntry): Deleted.
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::addOriginAccessAllowListEntry):
(TestRunner::removeOriginAccessAllowListEntry):
(TestRunner::addOriginAccessWhitelistEntry): Deleted.
(TestRunner::removeOriginAccessWhitelistEntry): Deleted.
* TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
(removeOldInjectedContentAndResetLists):
(testUserContentManagerInjectedStyleSheet):
(testUserContentManagerInjectedScript):
(testUserContentManagerContentFilter):
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::addOriginAccessAllowListEntry):
(WTR::TestRunner::removeOriginAccessAllowListEntry):
(WTR::TestRunner::addOriginAccessWhitelistEntry): Deleted.
(WTR::TestRunner::removeOriginAccessWhitelistEntry): Deleted.
* WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

* http/tests/security/contentSecurityPolicy/report-blocked-file-uri.php:
* http/tests/security/contentSecurityPolicy/xsl-redirect-allowed.html:
* http/tests/security/contentSecurityPolicy/xsl-redirect-allowed2.html:
* http/tests/security/contentSecurityPolicy/xsl-redirect-blocked.html:
* http/tests/security/isolatedWorld/cross-origin-xhr.html:
* http/tests/security/local-image-from-remote-allow-list-expected.txt: Copied from http/tests/security/local-image-from-remote-whitelisted-expected.txt.
* http/tests/security/local-image-from-remote-allow-list.html: Copied from http/tests/security/local-image-from-remote-whitelisted.html.
* http/tests/security/local-image-from-remote-whitelisted-expected.txt: Removed.
* http/tests/security/local-image-from-remote-whitelisted.html: Removed.
* http/tests/xmlhttprequest/access-control-basic-allow-list-request-headers-expected.txt: Copied from http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers-expected.txt.
* http/tests/xmlhttprequest/access-control-basic-allow-list-request-headers.html: Copied from http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html.
* http/tests/xmlhttprequest/access-control-basic-allow-list-response-headers-expected.txt: Copied from http/tests/xmlhttprequest/access-control-basic-whitelist-response-headers-expected.txt.
* http/tests/xmlhttprequest/access-control-basic-allow-list-response-headers.html: Copied from http/tests/xmlhttprequest/access-control-basic-whitelist-response-headers.html.
* http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers-expected.txt: Removed.
* http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html: Removed.
* http/tests/xmlhttprequest/access-control-basic-whitelist-response-headers-expected.txt: Removed.
* http/tests/xmlhttprequest/access-control-basic-whitelist-response-headers.html: Removed.
* http/tests/xmlhttprequest/origin-allow-list-all-expected.txt: Copied from http/tests/xmlhttprequest/origin-whitelisting-all-expected.txt.
* http/tests/xmlhttprequest/origin-allow-list-all.html: Copied from http/tests/xmlhttprequest/origin-whitelisting-all.html.
* http/tests/xmlhttprequest/origin-allow-list-exact-match-expected.txt: Copied from http/tests/xmlhttprequest/origin-whitelisting-exact-match-expected.txt.
* http/tests/xmlhttprequest/origin-allow-list-exact-match.html: Copied from http/tests/xmlhttprequest/origin-whitelisting-exact-match.html.
* http/tests/xmlhttprequest/origin-allow-list-https-expected.txt: Copied from http/tests/xmlhttprequest/origin-whitelisting-https-expected.txt.
* http/tests/xmlhttprequest/origin-allow-list-https.html: Copied from http/tests/xmlhttprequest/origin-whitelisting-https.html.
* http/tests/xmlhttprequest/origin-allow-list-ip-addresses-expected.txt: Copied from http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-expected.txt.
* http/tests/xmlhttprequest/origin-allow-list-ip-addresses-with-subdomains-expected.txt: Copied from http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains-expected.txt.
* http/tests/xmlhttprequest/origin-allow-list-ip-addresses-with-subdomains.html: Copied from http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains.html.
* http/tests/xmlhttprequest/origin-allow-list-ip-addresses.html: Copied from http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html.
* http/tests/xmlhttprequest/origin-allow-list-removal-expected.txt: Copied from http/tests/xmlhttprequest/origin-whitelisting-removal-expected.txt.
* http/tests/xmlhttprequest/origin-allow-list-removal.html: Copied from http/tests/xmlhttprequest/origin-whitelisting-removal.html.
* http/tests/xmlhttprequest/origin-allow-list-subdomains-expected.txt: Copied from http/tests/xmlhttprequest/origin-whitelisting-subdomains-expected.txt.
* http/tests/xmlhttprequest/origin-allow-list-subdomains.html: Copied from http/tests/xmlhttprequest/origin-whitelisting-subdomains.html.
* http/tests/xmlhttprequest/origin-whitelisting-all-expected.txt: Removed.
* http/tests/xmlhttprequest/origin-whitelisting-all.html: Removed.
* http/tests/xmlhttprequest/origin-whitelisting-exact-match-expected.txt: Removed.
* http/tests/xmlhttprequest/origin-whitelisting-exact-match.html: Removed.
* http/tests/xmlhttprequest/origin-whitelisting-https-expected.txt: Removed.
* http/tests/xmlhttprequest/origin-whitelisting-https.html: Removed.
* http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-expected.txt: Removed.
* http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains-expected.txt: Removed.
* http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains.html: Removed.
* http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html: Removed.
* http/tests/xmlhttprequest/origin-whitelisting-removal-expected.txt: Removed.
* http/tests/xmlhttprequest/origin-whitelisting-removal.html: Removed.
* http/tests/xmlhttprequest/origin-whitelisting-subdomains-expected.txt: Removed.
* http/tests/xmlhttprequest/origin-whitelisting-subdomains.html: Removed.
* platform/win/TestExpectations:
* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoAdd OfflineAudioCompletionEvent constructor
cdumez@apple.com [Fri, 31 Jul 2020 23:41:39 +0000 (23:41 +0000)]
Add OfflineAudioCompletionEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=214994

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

* web-platform-tests/webaudio/idlharness.https.window-expected.txt:

Source/WebCore:

Add OfflineAudioCompletionEvent constructor, as per:
- https://www.w3.org/TR/webaudio/#OfflineAudioCompletionEvent

Test: webaudio/OfflineAudioCompletionEvent-constructor.html

* CMakeLists.txt:
* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
* Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::finishedRendering):
* Modules/webaudio/OfflineAudioCompletionEvent.cpp:
(WebCore::OfflineAudioCompletionEvent::create):
(WebCore::OfflineAudioCompletionEvent::OfflineAudioCompletionEvent):
* Modules/webaudio/OfflineAudioCompletionEvent.h:
* Modules/webaudio/OfflineAudioCompletionEvent.idl:
* Modules/webaudio/OfflineAudioCompletionEventInit.h: Copied from Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.idl.
* Modules/webaudio/OfflineAudioCompletionEventInit.idl: Copied from Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.idl.
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Add layout test coverage.

* webaudio/OfflineAudioCompletionEvent-constructor-expected.txt: Added.
* webaudio/OfflineAudioCompletionEvent-constructor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[Mac] YouTube does not offer HDR variants to devices which support HDR
jer.noble@apple.com [Fri, 31 Jul 2020 23:40:06 +0000 (23:40 +0000)]
[Mac] YouTube does not offer HDR variants to devices which support HDR
https://bugs.webkit.org/show_bug.cgi?id=215022

Reviewed by Eric Carlson.

Source/WebCore:

Test: platform/mac/media/media-source/is-type-supported-vp9-codec-check.html

There are three separate issues which block YouTube from offering HDR:

1) YouTube checks both valid and invalid VP9 strings through MediaSource.isTypeSupported(), and UAs
   which answer `true` to even invalid VP9 strings are blocked from HDR. To solve this, we will now
   send isTypeSupported() through the same code path as Media Capabilities.

2) YouTube's standard valid and invalid VP9 strings do not include the fullRangeVideoFlag field, which
   would normally be tossed as invalid. We shouldn't relax our requirements globally, so we will
   add a Quirk which relaxes the requriement that VP9 strings contain a fullRangeVideoFlag.

3) YouTube's HDR query checks that window.screen.pixelDepth is > 24. We obviously don't want to change
   the value of this field globally, so we will add separate Quirk which sets window.screen.pixelDepth
   to 25 (a totally nonsensical value) when HDR is available.

Each of these Quirks has a path towards removal for YouTube. The fullRangeVideoFlag field involves
YouTube updating their compatibility check to inculde the fullRangeVideoFlag. The pixelDepth check
can be replaced by the `dynamic-range:high` Media Query.

* Modules/mediasource/MediaSource.cpp:
(WebCore::addVP9FullRangeVideoFlagToContentType):
(WebCore::MediaSource::addSourceBuffer):
(WebCore::MediaSource::removeSourceBuffer):
(WebCore::MediaSource::isTypeSupported):
(WebCore::MediaSource::onReadyStateChange):
(WebCore::MediaSource::activeRanges const):
* Modules/mediasource/MediaSource.h:
* page/Quirks.cpp:
(WebCore::Quirks::needsVP9FullRangeFlagQuirk const):
(WebCore::Quirks::needsHDRPixelDepthQuirk const):
* page/Quirks.h:
* page/Screen.cpp:
(WebCore::Screen::pixelDepth const):
* platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::SourceBufferParserWebM::isContentTypeSupported):
* platform/graphics/cocoa/VP9UtilitiesCocoa.h:
* platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
(WebCore::isVPCodecConfigurationRecordSupported):
(WebCore::validateVPParameters):

LayoutTests:

* platform/mac/media/media-source/is-type-supported-vp9-codec-check-expected.txt: Added.
* platform/mac/media/media-source/is-type-supported-vp9-codec-check.html: Added.
* platform/mac/media/mediacapabilities/vp9-decodingInfo-sw-expected.txt:
* platform/mac/media/mediacapabilities/vp9-decodingInfo-sw.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[test-webkitpy] Have CI use verbose logging
jbedard@apple.com [Fri, 31 Jul 2020 23:36:43 +0000 (23:36 +0000)]
[test-webkitpy] Have CI use verbose logging
https://bugs.webkit.org/show_bug.cgi?id=215019
<rdar://problem/66383986>

Reviewed by Aakash Jain.

* BuildSlaveSupport/ews-build/steps.py:
(RunWebKitPyPython2Tests): Add --verbose flag.
(RunWebKitPyPython3Tests): Ditto.
* BuildSlaveSupport/ews-build/steps_unittest.py:
(test_success): Add --verbose flag to test-webkitpy command.
(test_unexpected_failure): Ditto.
(test_failure): Ditto.
(test_errors): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoAdd linked-on-after check to keep WebSQL working in UIWebView until apps are rebuilt...
cdumez@apple.com [Fri, 31 Jul 2020 22:56:30 +0000 (22:56 +0000)]
Add linked-on-after check to keep WebSQL working in UIWebView until apps are rebuilt with iOS 14 SDK
https://bugs.webkit.org/show_bug.cgi?id=215035
<rdar://problem/65003342>

Reviewed by Tim Horton.

Source/WebCore:

* platform/RuntimeApplicationChecks.h:
* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::IOSApplication::isJesusCalling): Deleted.
(WebCore::IOSApplication::isFudget): Deleted.
(WebCore::IOSApplication::isFamilyHealthApp): Deleted.
Drop code that is no longer needed.

Source/WebKitLegacy/mac:

Add linked-on-after check to keep WebSQL working in UIWebView until apps are rebuilt with iOS 14 SDK.

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[ macOS ] imported/w3c/web-platform-tests/css/css-scoping/css-scoping-shadow-dynamic...
tsavell@apple.com [Fri, 31 Jul 2020 22:50:31 +0000 (22:50 +0000)]
[ macOS ] imported/w3c/web-platform-tests/css/css-scoping/css-scoping-shadow-dynamic-remove-style-detached.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215039

Unreviewed test gardening.

Patch by Hector Lopez <hector_i_lopez@apple.com> on 2020-07-31

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoLaunch time regression due to EndowmentStateTracker initialization in WebPageProxy...
cdumez@apple.com [Fri, 31 Jul 2020 22:23:52 +0000 (22:23 +0000)]
Launch time regression due to EndowmentStateTracker initialization in WebPageProxy constructor
https://bugs.webkit.org/show_bug.cgi?id=215029
<rdar://problem/66362333>

Reviewed by Geoffrey Garen.

EndowmentStateTracker was expensive and in a critical code path during MobileSafari app launch. Since
this code is new, this was a net app launch time regression. To address the regression, the following
changes were made:
1. We only need the EndowmentStateTracker to monitor if the app is user-facing or not, so that we can
   suspend / resume media playback as needed. As a result, it is unnecessary to start monitoring
   user-facing state changes as soon as the WebPageProxy is constructed. Instead, we now wait until
   media plays on the page for the first time.
2. It turns out that over 70% of CPU time in the EndowmentStateTracker constructor was spent getting
   the current endownment for the process. As a result, I updated the code to lazy populate those
   until they are requested for the first time.
3. The remaining 30% of CPU time in the EndowmentStateTracker constructor was spent constructing the
   RBSProcessMonitor. I moved the initialization of the RBSProcessMonitor from the constructor to
   EndowmentStateTracker::addClient() so that we only construct a monitor when we actually have our
   first client.
4. All this code was actually only useful for Catalyst app and was therefore doing work on iOS for no
   reason. I properly #ifdef'd out this code so that it now only applies to Catalyst apps.

* UIProcess/EndowmentStateTracker.h:
(WebKit::EndowmentStateTracker::isVisible const):
(WebKit::EndowmentStateTracker::isUserFacing const):
* UIProcess/EndowmentStateTracker.mm:
(WebKit::EndowmentStateTracker::stateFromEndowments):
(WebKit::EndowmentStateTracker::registerMonitorIfNecessary):
(WebKit::EndowmentStateTracker::addClient):
(WebKit::EndowmentStateTracker::ensureState const const):
(WebKit::EndowmentStateTracker::setState):
(WebKit::EndowmentStateTracker::EndowmentStateTracker): Deleted.
(WebKit::EndowmentStateTracker::setIsUserFacing): Deleted.
(WebKit::EndowmentStateTracker::setIsVisible): Deleted.
* UIProcess/WebPageProxy.cpp:
(WebKit::m_transcodingQueue):
(WebKit::WebPageProxy::updatePlayingMediaDidChange):
* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoDrop ProcessAssertion::Client and replace with a simple invalidation handler
cdumez@apple.com [Fri, 31 Jul 2020 22:23:06 +0000 (22:23 +0000)]
Drop ProcessAssertion::Client and replace with a simple invalidation handler
https://bugs.webkit.org/show_bug.cgi?id=214976

Reviewed by Brady Eidson.

ProcessAssertion had a Client class with 2 functions:
(1) one to indicate that the assertion was invalidated
(2) one to indicate that the UI assertion is about to expire

While ProcessAssertion is used in several places, only the ProcessThrottler
ever sets itself as a client. The reason is that other call sites use
assertion types that do not expire. Also, (2) only makes sense for
ProcessAndUIAssertion, not for ProcessAssertion. Only the ProcessThrottler
is using a ProcessAndUIAssertion.

I think a better design is to have a simple invalidation handler on
the ProcessAssertion, that the call site can set if they are interested
in invalidation.

Similarly, I added a UIAssertion expiration handler on ProcessAndUIAssertion
so that the ProcessThrottler can know if the UIAssertion is about to expire.

This new design also matches more closely the system process assertion API
that ProcessAssertion / ProcessAndUIAssertion are wrapping.

This patch also fixes a bug found by Youenn Fablet where the ProcessThrottler
would only set its invalidation handler in didConnectToProcess(), instead of
doing it every time a new ProcessAssertion is created in setAssertionType().
The assertion type can change (e.g. from foreground to background) after the
process has launched.

* UIProcess/ProcessAssertion.h:
(WebKit::ProcessAssertion::setInvalidationHandler):
(WebKit::ProcessAssertion::Client::~Client): Deleted.
(WebKit::ProcessAssertion::setClient): Deleted.
(WebKit::ProcessAssertion::client): Deleted.
* UIProcess/ProcessThrottler.cpp:
(WebKit::ProcessThrottler::setAssertionType):
(WebKit::ProcessThrottler::didConnectToProcess):
* UIProcess/ProcessThrottler.h:
* UIProcess/ios/ProcessAssertionIOS.mm:
(WebKit::ProcessAssertion::processAssertionWasInvalidated):
(WebKit::ProcessAndUIAssertion::uiAssertionWillExpireImminently):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[ macOS wk1 iOS wk2 Release ] imported/w3c/web-platform-tests/websockets/cookies...
tsavell@apple.com [Fri, 31 Jul 2020 22:22:23 +0000 (22:22 +0000)]
[ macOS wk1 iOS wk2 Release ] imported/w3c/web-platform-tests/websockets/cookies/third-party-cookie-accepted.https.html  is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215033

Unreviewed test gardening.

Patch by Hector Lopez <hector_i_lopez@apple.com> on 2020-07-31

* platform/ios-simulator-wk2/TestExpectations:
* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoLog a warning to the dev console when gamepads are accessed from an insecure context.
beidson@apple.com [Fri, 31 Jul 2020 22:14:04 +0000 (22:14 +0000)]
Log a warning to the dev console when gamepads are accessed from an insecure context.
https://bugs.webkit.org/show_bug.cgi?id=214995

Reviewed by Tim Horton.

Source/WebCore:

Test: http/tests/misc/gamepads-insecure.html

* Modules/gamepad/NavigatorGamepad.cpp:
(WebCore::NavigatorGamepad::getGamepads): Insecure contexts should log that getGamepads() will
  be going away in a future release. Just do it once, because getGamepads() is called frequently.

LayoutTests:

* http/tests/misc/gamepads-insecure-expected.txt: Added.
* http/tests/misc/gamepads-insecure.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoMove Options setter to where we allow access to the Options object
keith_miller@apple.com [Fri, 31 Jul 2020 21:02:16 +0000 (21:02 +0000)]
Move Options setter to where we allow access to the Options object
https://bugs.webkit.org/show_bug.cgi?id=215028

Reviewed by Saam Barati.

Right now jsc CLI crashes when assertions are enabled on iOS.

* jsc.cpp:
(main):
(CommandLine::parseArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoSOAuthorizationSession::dismissViewController could crash on calling WebPageProxy...
jiewen_tan@apple.com [Fri, 31 Jul 2020 20:39:04 +0000 (20:39 +0000)]
SOAuthorizationSession::dismissViewController could crash on calling WebPageProxy::platformWindow
https://bugs.webkit.org/show_bug.cgi?id=214816
<rdar://problem/65681530>

Reviewed by Youenn Fablet.

pageClient() called in WebPageProxy::platformWindow() could be null. Therefore, platformWindow()
needs to check m_pageClient instead.

* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::platformWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[macOS] Date/time input types should have a textfield appearance
akeerthi@apple.com [Fri, 31 Jul 2020 20:19:02 +0000 (20:19 +0000)]
[macOS] Date/time input types should have a textfield appearance
https://bugs.webkit.org/show_bug.cgi?id=214978

Reviewed by Wenson Hsieh.

Source/WebCore:

On iOS, date/time input types have a menulist-button appearance. However, this appearance
does not match the style of native date controls on macOS. The textfield appearance
with no focus ring brings us closer to a natively styled control.

* rendering/RenderTheme.h:
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::dateInputStyleSheet const):
(WebCore::RenderThemeMac::dateTimeLocalInputStyleSheet const):
(WebCore::RenderThemeMac::monthInputStyleSheet const):
(WebCore::RenderThemeMac::timeInputStyleSheet const):
(WebCore::RenderThemeMac::weekInputStyleSheet const):

LayoutTests:

Rebaselined tests for updated appearance.

* platform/mac-wk2/fast/forms/date/date-input-rendering-basic-expected.txt:
* platform/mac-wk2/fast/forms/time/time-input-rendering-basic-expected.txt:
* platform/mac-wk2/imported/w3c/web-platform-tests/html/rendering/widgets/appearance/default-styles-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoSpecial HID mapping for the Dualshock 3 controller
beidson@apple.com [Fri, 31 Jul 2020 19:50:33 +0000 (19:50 +0000)]
Special HID mapping for the Dualshock 3 controller
<rdar://problem/66255198> and https://bugs.webkit.org/show_bug.cgi?id=214911

Reviewed by Tim Horton.

Source/WebCore:

Covered by API tests.

- Move GamepadButtons into a GamepadConstants header
- Add a "KnownGamepads" header to hold all vendor/product pairs that WebKit knows about
- Add a Dualshock3 controller mapping based on its HID report
- Add a basic DS3 test based on the HID report

* Sources.txt:
* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:

* platform/gamepad/GamepadConstants.cpp: Copied from Source/WebCore/platform/gamepad/mac/GenericHIDGamepad.h.
(WebCore::standardGamepadMappingString):
* platform/gamepad/GamepadConstants.h: Added.

* platform/gamepad/KnownGamepads.h: Copied from Source/WebCore/platform/gamepad/mac/GenericHIDGamepad.h.

* platform/gamepad/cocoa/GameControllerGamepad.mm:
(WebCore::GameControllerGamepad::setupAsExtendedGamepad):

* platform/gamepad/mac/Dualshock3HIDGamepad.cpp: Added.
(WebCore::Dualshock3HIDGamepad::Dualshock3HIDGamepad):
* platform/gamepad/mac/Dualshock3HIDGamepad.h: Copied from Source/WebCore/platform/gamepad/mac/GenericHIDGamepad.h.

* platform/gamepad/mac/GenericHIDGamepad.cpp:
(WebCore::GenericHIDGamepad::GenericHIDGamepad):
(WebCore::GenericHIDGamepad::id): Deleted.
* platform/gamepad/mac/GenericHIDGamepad.h:

* platform/gamepad/mac/HIDGamepad.cpp:
(WebCore::HIDGamepad::create):
(WebCore::HIDGamepad::HIDGamepad):
(WebCore::HIDGamepad::initialize):
* platform/gamepad/mac/HIDGamepad.h:

* platform/mac/HIDDevice.h:
(WebCore::HIDDevice::fullProductIdentifier const):
* platform/mac/HIDElement.h:
(WebCore::HIDElement::fullUsage const):

Tools:

Add a virtual Dualshock3 and verify a few attributes about it.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/HIDGamepads.mm:
* TestWebKitAPI/mac/GamepadMappings/SonyDualShock3.mm: Added.
(TestWebKitAPI::publishReportCallback):
(TestWebKitAPI::VirtualGamepad::sonyDualshock3Mapping):
* TestWebKitAPI/mac/VirtualGamepad.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoFix Windows build.
achristensen@apple.com [Fri, 31 Jul 2020 19:39:18 +0000 (19:39 +0000)]
Fix Windows build.
https://bugs.webkit.org/show_bug.cgi?id=214988

* platform/network/cf/CertificateInfo.h:
* platform/network/cf/CertificateInfoCFNet.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoRe-enable NO_SMT on Catalina
sbarati@apple.com [Fri, 31 Jul 2020 19:24:08 +0000 (19:24 +0000)]
Re-enable NO_SMT on Catalina
https://bugs.webkit.org/show_bug.cgi?id=215024

Reviewed by Alexey Proskuryakov.

* runtime/Options.cpp:
(JSC::defaultTCSMValue):
* runtime/OptionsList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoREGRESSION: [ iOS wk2 Debug ] imported/w3c/web-platform-tests/webrtc/RTCSctpTransport...
commit-queue@webkit.org [Fri, 31 Jul 2020 18:57:08 +0000 (18:57 +0000)]
REGRESSION: [ iOS wk2 Debug ] imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-maxChannels.html is a constant crash
https://bugs.webkit.org/show_bug.cgi?id=215025

Unreviewed test gardening.

Patch by Hector Lopez <hector_i_lopez@apple.com> on 2020-07-31

* platform/ios-simulator-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoAdd constructor for WaveShaperNode
cdumez@apple.com [Fri, 31 Jul 2020 18:47:49 +0000 (18:47 +0000)]
Add constructor for WaveShaperNode
https://bugs.webkit.org/show_bug.cgi?id=214989

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

* web-platform-tests/webaudio/idlharness.https.window-expected.txt:
* web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/ctor-waveshaper-expected.txt:
* web-platform-tests/webaudio/the-audio-api/the-waveshapernode-interface/waveshaper-simple-expected.txt:

Source/WebCore:

Add constructor for WaveShaperNode:
- https://www.w3.org/TR/webaudio/#waveshapernode

No new tests, rebaselined existing tests.

* CMakeLists.txt:
* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
* Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::createWaveShaper):
* Modules/webaudio/OverSampleType.h: Copied from Source/WebCore/Modules/webaudio/WaveShaperNode.idl.
* Modules/webaudio/OverSampleType.idl: Copied from Source/WebCore/Modules/webaudio/WaveShaperNode.idl.
* Modules/webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::create):
(WebCore::WaveShaperNode::setCurve):
(WebCore::processorType):
* Modules/webaudio/WaveShaperNode.h:
(WTF::LogArgument<WebCore::OverSampleType>::toString):
* Modules/webaudio/WaveShaperNode.idl:
* Modules/webaudio/WaveShaperOptions.h: Copied from Source/WebCore/Modules/webaudio/WaveShaperNode.idl.
* Modules/webaudio/WaveShaperOptions.idl: Copied from Source/WebCore/Modules/webaudio/WaveShaperNode.idl.
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agovalidate untagArrayPtr
sbarati@apple.com [Fri, 31 Jul 2020 18:46:18 +0000 (18:46 +0000)]
validate untagArrayPtr
https://bugs.webkit.org/show_bug.cgi?id=214953

Reviewed by Keith Miller.

This patch adds validation to untagArrayPtr along paths where we don't
immediately store/load from the result.

This patch also changes the removeArrayPtrTag macro assembler function to
use shifts instead of xpacd to strip the tag, because it's faster.

* assembler/MacroAssemblerARM64E.h:
(JSC::MacroAssemblerARM64E::untagArrayPtr):
(JSC::MacroAssemblerARM64E::removeArrayPtrTag):
* assembler/testmasm.cpp:
(JSC::testCagePreservesPACFailureBit):
* bytecode/AccessCase.cpp:
(JSC::AccessCase::generateWithGuard):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::cageTypedArrayStorage):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::untagArrayPtr):
(JSC::FTL::DFG::LowerDFGToB3::caged):
* jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::cageWithoutUntagging):
(JSC::AssemblyHelpers::cageConditionallyAndUntag):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::cageWithoutUntagging): Deleted.
(JSC::AssemblyHelpers::cageConditionally): Deleted.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):
* wasm/WasmAirIRGenerator.cpp:
(JSC::Wasm::AirIRGenerator::restoreWebAssemblyGlobalState):
(JSC::Wasm::AirIRGenerator::addCallIndirect):
* wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::restoreWebAssemblyGlobalState):
(JSC::Wasm::B3IRGenerator::addCallIndirect):
* wasm/WasmBinding.cpp:
(JSC::Wasm::wasmToWasm):
* wasm/js/JSToWasm.cpp:
(JSC::Wasm::createJSToWasmWrapper):
* wasm/js/WebAssemblyFunction.cpp:
(JSC::WebAssemblyFunction::jsCallEntrypointSlow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoUpdate service worker if certificate info does not match when soft updating
youenn@apple.com [Fri, 31 Jul 2020 17:54:46 +0000 (17:54 +0000)]
Update service worker if certificate info does not match when soft updating
https://bugs.webkit.org/show_bug.cgi?id=214988

Reviewed by Alex Christensen.

Source/WebCore:

In case service worker certificate info does not match, treat it as if the script changed.
This is a convenient way to update the service worker and the stored registration database.
Covered by API test.

* platform/network/cf/CertificateInfo.h:
* platform/network/cf/CertificateInfoCFNet.cpp:
(WebCore::certificatesMatch):
* workers/service/server/SWServerJobQueue.cpp:
(WebCore::doCertificatesMatch):
(WebCore::SWServerJobQueue::scriptFetchFinished):
* workers/service/server/SWServerWorker.h:
(WebCore::SWServerWorker::certificateInfo const):

Source/WebKit:

Make sure service worker soft updater gathers certificate info.

* NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.cpp:
(WebKit::ServiceWorkerSoftUpdateLoader::loadFromNetwork):
(WebKit::ServiceWorkerSoftUpdateLoader::didReceiveResponse):
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::allowsSpecificHTTPSCertificateForHost):

Tools:

Update HTTPServer to pass two optional parameters:
- A port number to listen to if provided
- A custom server identity to use if provided

The API test is loading an URL on a first server.
This triggers registration of a service worker.
It then stops this server and launches a second server on the same port with a different certificate.
A second page is loaded on the same URL.
This triggers the case of updating a service worker certificate info.

* TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
(createTestIdentity):
(testIdentity):
(testIdentity2):
* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
* TestWebKitAPI/cocoa/HTTPServer.h:
* TestWebKitAPI/cocoa/HTTPServer.mm:
(TestWebKitAPI::HTTPServer::listenerParameters):
(TestWebKitAPI::HTTPServer::HTTPServer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago-[WKWebsiteDataStore _renameOrigin:] needs to support IndexedDB renames
commit-queue@webkit.org [Fri, 31 Jul 2020 17:44:19 +0000 (17:44 +0000)]
-[WKWebsiteDataStore _renameOrigin:] needs to support IndexedDB renames
https://bugs.webkit.org/show_bug.cgi?id=214905
<rdar://problem/66247978>

Patch by Sihui Liu <sihui_liu@appe.com> on 2020-07-31
Reviewed by Alex Christensen.

Source/WebCore:

To do the renaming, we close all existing databases whose top origin is old origin, and move all files in
directory of old origin to that of new origin.

API test: WebKit.WebsiteDataStoreRenameOriginForIndexedDatabase

* Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::closeDatabasesForOrigins):
(WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesForOrigins):
(WebCore::IDBServer::IDBServer::renameOrigin):
* Modules/indexeddb/server/IDBServer.h:

Source/WebKit:

* NetworkProcess/IndexedDB/WebIDBServer.cpp:
(WebKit::WebIDBServer::renameOrigin):
* NetworkProcess/IndexedDB/WebIDBServer.h:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::renameOriginInWebsiteData):
* UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _renameOrigin:to:forDataOfTypes:completionHandler:]):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoAX: Inteterminate progressbar reading as 50% with Voiceover
cfleizach@apple.com [Fri, 31 Jul 2020 17:27:47 +0000 (17:27 +0000)]
AX: Inteterminate progressbar reading as 50% with Voiceover
https://bugs.webkit.org/show_bug.cgi?id=214330
<rdar://problem/65570800>

Reviewed by Zalan Bujtas.

Expose indeterminate status to iOS API.

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityIsIndeterminate]):
(-[WebAccessibilityObjectWrapper accessibilityIsInDescriptionListTerm]):
(-[WebAccessibilityObjectWrapper accessibilityIsInDescriptionListDefinition]):
  - Drive by style fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoVersioning.
alancoon@apple.com [Fri, 31 Jul 2020 17:26:27 +0000 (17:26 +0000)]
Versioning.

WebKit-610.1.25

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoPIP on netflix.com shows only a gray window and spinner
peng.liu6@apple.com [Fri, 31 Jul 2020 17:09:04 +0000 (17:09 +0000)]
PIP on netflix.com shows only a gray window and spinner
https://bugs.webkit.org/show_bug.cgi?id=214899

Reviewed by Jer Noble.

Use an empty "seekableRanges" instead of a special "duration" value (NaN) to indicate
that seeking is not supported. With this change, the "duration" will always have a meaningful
value, so that WebAVPlayerController can work properly in the picture-in-picture mode.
Related change: https://trac.webkit.org/changeset/217858.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::supportsSeeking const):
* platform/cocoa/PlaybackSessionModelMediaElement.mm:
(WebCore::PlaybackSessionModelMediaElement::duration const):
(WebCore::PlaybackSessionModelMediaElement::seekableRanges const):
* platform/mac/WebPlaybackControlsManager.mm:
(-[WebPlaybackControlsManager canBeginTouchBarScrubbing]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoUnreviewed Catalyst build fix.
ryanhaddad@apple.com [Fri, 31 Jul 2020 16:27:20 +0000 (16:27 +0000)]
Unreviewed Catalyst build fix.

* WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.h: I should have added the include here.
* WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[webkitcorepy] Changes to Tools/Scripts/libraries should trigger EWS
jbedard@apple.com [Fri, 31 Jul 2020 16:10:02 +0000 (16:10 +0000)]
[webkitcorepy] Changes to Tools/Scripts/libraries should trigger EWS
https://bugs.webkit.org/show_bug.cgi?id=214998
<rdar://problem/66355658>

Reviewed by Aakash Jain.

* BuildSlaveSupport/ews-build/steps.py:
(CheckPatchRelevance): Add Tools/Scripts/libraries.
* BuildSlaveSupport/ews-build/steps_unittest.py:
(TestCheckPatchRelevance.test_relevant_webkitpy_patch):
(TestCheckPatchRelevance.test_relevant_libraries_patch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoReduce over include usage in JSC
keith_miller@apple.com [Fri, 31 Jul 2020 16:00:27 +0000 (16:00 +0000)]
Reduce over include usage in JSC
https://bugs.webkit.org/show_bug.cgi?id=215010

Reviewed by Mark Lam.

My first attempt to fix
https://bugs.webkit.org/show_bug.cgi?id=215009 by making it so we
don't include FastJITPermissions.h in TestWebKitAPI, was
unsuccessful. Mostly because I gave up after several hours of
building... I figure it's still worth it to land the last working
version I was able to get building.

* assembler/MacroAssemblerCodeRef.h:
* bytecode/CodeBlock.cpp:
* bytecode/PolymorphicAccess.h:
* inspector/agents/InspectorRuntimeAgent.cpp:
* interpreter/CallFrame.h:
* jit/ThunkGenerators.cpp:
* llint/LLIntOffsetsExtractor.cpp:
* runtime/TypeLocationCache.cpp:
* runtime/VM.cpp:
(JSC::VM::getCTIStub):
* runtime/VM.h:
(JSC::VM::getCTIStub): Deleted.
* tools/JSDollarVM.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoFix build around broken internal SDK for iOS 13
keith_miller@apple.com [Fri, 31 Jul 2020 15:54:30 +0000 (15:54 +0000)]
Fix build around broken internal SDK for iOS 13
https://bugs.webkit.org/show_bug.cgi?id=215009

Reviewed by Mark Lam.

We need to manually include the private headers because the system tries to hide them from us even on internal builds...

* TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
* TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[ews] Add unit-tests for various builder factories
aakash_jain@apple.com [Fri, 31 Jul 2020 15:36:02 +0000 (15:36 +0000)]
[ews] Add unit-tests for various builder factories
https://bugs.webkit.org/show_bug.cgi?id=214969

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/ews-build/factories_unittest.py: Added unit-tests.
(TestBuildFactory.test_generic_build_factory):
(TestBuildFactory.test_gtk_build_factory):
(TestBuildFactory.test_wpe_factory):
(TestBuildFactory.test_wincairo_factory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[iOS] Issue a temporary extension to the MobileGestalt daemon when the MobileGestalt...
pvollan@apple.com [Fri, 31 Jul 2020 14:03:35 +0000 (14:03 +0000)]
[iOS] Issue a temporary extension to the MobileGestalt daemon when the MobileGestalt cache is invalid
https://bugs.webkit.org/show_bug.cgi?id=214965

Reviewed by Geoffrey Garen.

Source/WebCore/PAL:

Declare MobileGestalt queestion identifier.

* pal/spi/ios/MobileGestaltSPI.h:

Source/WebKit:

When the MobileGestalt cache is invalid, some MG queries will fail in the WebContent process, since it has no access to the daemon.
This can be fixed by issuing a temporary extension to the daemon, and having the WebContent process query all relevant MG values
while holding the extension. This will bring the values into the in-memory cache, which will be valid after the extension to the
daemon has been revoked. We will still attempt to rebuild the MG cache if invalid, but since we now have a workaround for when the
cache is invalid, we can do this on a secondary thread to avoid blocking the main thread. We also only attempt to rebuild once now,
instead of every time a WebContent process is started. Additionally, add IOKit property read access to "platform-name", since that
is needed by a MG query.

No new tests, since testing this depends on having an invalid cache, which is rare, and non-trivial to enforce in the test
environment.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitialize):
(WebKit::WebProcessPool::platformInitializeWebProcess):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[GTK] Mouse wheel events on horizontal scrollbar not correctly handled when AC mode...
carlosgc@webkit.org [Fri, 31 Jul 2020 10:57:19 +0000 (10:57 +0000)]
[GTK] Mouse wheel events on horizontal scrollbar not correctly handled when AC mode is forced
https://bugs.webkit.org/show_bug.cgi?id=207113

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Remove GTK specific code to invert scroll direction of wheel events.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::shouldSwapScrollDirection const): Deleted.
* platform/SourcesGLib.txt:
* platform/glib/EventHandlerGLib.cpp: Removed.

Source/WebKit:

Move the direction swap to the UI process before passing the event to the web
process. WebHitTestResultData::isScrollbar is now an enum with values No, Verttical, Horizontal. When a wheel
event is received in the widget we check whether we should invert the direction or not.

* Shared/API/glib/WebKitHitTestResult.cpp:
(webkitHitTestResultCreate):
(webkitHitTestResultCompare):
* Shared/WebHitTestResultData.cpp:
(WebKit::WebHitTestResultData::WebHitTestResultData):
* Shared/WebHitTestResultData.h:
* UIProcess/API/APIHitTestResult.h:
(API::HitTestResult::isScrollbar const):
* UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewMouseTargetChanged):
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(shouldInvertDirectionForScrollEvent):
(webkitWebViewBaseScrollEvent):
(webkitWebViewBaseScroll):
(webkitWebViewBaseSetMouseIsOverScrollbar):
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[WebXR] Retrieve supported reference spaces from actual XR systems
svillar@igalia.com [Fri, 31 Jul 2020 09:00:54 +0000 (09:00 +0000)]
[WebXR] Retrieve supported reference spaces from actual XR systems
https://bugs.webkit.org/show_bug.cgi?id=214187

Reviewed by Carlos Garcia Campos.

Each XR system supports a set of reference spaces which are used by WebXR to stablish
a spatial relationship with user's physical environment. The list of supported reference
spaces determine whether or not a session request succeeds or not, as it will refuse to
start a session with an unsupported reference space.

So far, no reference spaces were retrieved from the actual devices. This patch adds the
required OpenXR machinery to retrieve them. In particular, we have to create a XrSession
(although we don't have to start it) in order to retrieve the reference spaces. Since we
don't need it to show content to the user we can create it in headless mode and then discard
it afterwards when no longer needed.

* Modules/webxr/WebXRSession.cpp:
(WebCore::WebXRSession::WebXRSession): Clarify a comment. Also s/TODO/FIXME/g.
* platform/xr/openxr/PlatformXROpenXR.cpp:
(PlatformXR::isExtensionSupported): New method to check whether a specific extension
is supported.
(PlatformXR::Instance::Impl::checkInstanceExtensionProperties const): renamed from
enumerateInstanceExtensionProperties(). Returns whether or not the call succeeded.
(PlatformXR::Instance::Impl::Impl): Pass the list of enabled extensions to the instance.
(PlatformXR::Instance::enumerateImmersiveXRDevices): Log the systems found.
(PlatformXR::OpenXRDevice::OpenXRDevice):
(PlatformXR::OpenXRDevice::enumerateReferenceSpaces const): New method to list the
supported reference spaces by the XR system.
(PlatformXR::OpenXRDevice::collectSupportedSessionModes): Store reference spaces as
enabled features for supported modes.
(PlatformXR::OpenXRDevice::collectConfigurationViews): Renamed from
enumerateConfigurationViews().
(PlatformXR::Instance::Impl::enumerateInstanceExtensionProperties const): Deleted.
(PlatformXR::OpenXRDevice::enumerateConfigurationViews): Deleted.
* platform/xr/openxr/PlatformXROpenXR.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[JSC] Follow-up changes after r265036
ysuzuki@apple.com [Fri, 31 Jul 2020 07:45:16 +0000 (07:45 +0000)]
[JSC] Follow-up changes after r265036
https://bugs.webkit.org/show_bug.cgi?id=214982

Reviewed by Darin Adler.

* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::compileExit): Remove dupe definitions in OSRExit.
* jit/JITCall32_64.cpp:
(JSC::JIT::emit_op_iterator_open): We should use emitJumpSlowCaseIfNotJSCell(regT1).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoAdd LibWebRTCAudioModule logging
youenn@apple.com [Fri, 31 Jul 2020 07:15:25 +0000 (07:15 +0000)]
Add LibWebRTCAudioModule logging
https://bugs.webkit.org/show_bug.cgi?id=214987

Reviewed by Eric Carlson.

* platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:
(WebCore::LibWebRTCAudioModule::RegisterAudioCallback):
(WebCore::LibWebRTCAudioModule::StartPlayout):
(WebCore::LibWebRTCAudioModule::StopPlayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoOptimize WebsiteDataStoreConfiguration::copy
commit-queue@webkit.org [Fri, 31 Jul 2020 06:16:33 +0000 (06:16 +0000)]
Optimize WebsiteDataStoreConfiguration::copy
https://bugs.webkit.org/show_bug.cgi?id=215012
<rdar://problem/64263406>

Patch by Alex Christensen <achristensen@webkit.org> on 2020-07-30
Reviewed by Brady Eidson.

The WebsiteDataStoreConfiguration constructor does some read/write heavy things.
We only want to do these things if we are not just going to overwrite the strings with strings from another WebsiteDataStoreConfiguration.
No change in behavior, just making things faster.

* UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:
(WebKit::WebsiteDataStoreConfiguration::WebsiteDataStoreConfiguration):
(WebKit::WebsiteDataStoreConfiguration::copy const):
* UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:
(WebKit::WebsiteDataStoreConfiguration::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoMinor RenderLayerCompositor::updateBackingAndHierarchy() cleanup
simon.fraser@apple.com [Fri, 31 Jul 2020 06:05:29 +0000 (06:05 +0000)]
Minor RenderLayerCompositor::updateBackingAndHierarchy() cleanup
https://bugs.webkit.org/show_bug.cgi?id=215008

Reviewed by Zalan Bujtas.

Instead of setting child layers, and then adding another child (overflowControlLayer),
append overflowControlLayer to the vector and then set children.

No behavior change.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBackingAndHierarchy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoSkip stress/operand-should-fit-in-abstract-heap-encoded-payload-format.js
sbarati@apple.com [Fri, 31 Jul 2020 05:51:38 +0000 (05:51 +0000)]
Skip stress/operand-should-fit-in-abstract-heap-encoded-payload-format.js
https://bugs.webkit.org/show_bug.cgi?id=215001

Reviewed by Darin Adler.

The test takes > 4 minutes when run on an idle machine. That's too long.

* stress/operand-should-fit-in-abstract-heap-encoded-payload-format.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoHave TimingScope track the max event duration
simon.fraser@apple.com [Fri, 31 Jul 2020 04:49:30 +0000 (04:49 +0000)]
Have TimingScope track the max event duration
https://bugs.webkit.org/show_bug.cgi?id=215006

Reviewed by Tim Horton.

Have TimingScope track and print the longest event, as well as the count and
mean duration.

* wtf/TimingScope.cpp:
(WTF::TimingScope::scopeDidEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[GTK][WPE] Garden three persistent failures from gtk release bot.
lmoura@igalia.com [Fri, 31 Jul 2020 04:43:22 +0000 (04:43 +0000)]
[GTK][WPE] Garden three persistent failures from gtk release bot.

Unreviewed test gardening.

These were also affecting the debug and WPE bots.

* platform/glib/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoIt would be nice if the predicate taking functions in ParsingUtilities.h didn't requi...
weinig@apple.com [Fri, 31 Jul 2020 03:44:09 +0000 (03:44 +0000)]
It would be nice if the predicate taking functions in ParsingUtilities.h didn't require specifying the character type
https://bugs.webkit.org/show_bug.cgi?id=215002

Reviewed by Darin Adler.

Remove the need for specifying the character type by providing overloads for LChar and UChar
explicitly.

* html/parser/HTMLSrcsetParser.cpp:
(WebCore::parseImageCandidatesFromSrcsetAttribute):
* html/parser/ParsingUtilities.h:
(WebCore::characterPredicate):
* html/track/VTTScanner.h:
(WebCore::characterPredicate):
* loader/LinkHeader.cpp:
(WebCore::findURLBoundaries):
(WebCore::invalidParameterDelimiter):
(WebCore::parseParameterDelimiter):
(WebCore::parseParameterName):
(WebCore::skipQuotesIfNeeded):
(WebCore::parseParameterValue):
(WebCore::findNextHeader):
* loader/ResourceCryptographicDigest.cpp:
(WebCore::parseCryptographicDigestImpl):
(WebCore::parseEncodedCryptographicDigestImpl):
* loader/SubresourceIntegrity.cpp:
(WebCore::splitOnSpaces):
* loader/appcache/ApplicationCacheManifestParser.cpp:
(WebCore::parseApplicationCacheManifest):
* page/csp/ContentSecurityPolicyDirectiveList.cpp:
(WebCore::ContentSecurityPolicyDirectiveList::parseDirective):
(WebCore::ContentSecurityPolicyDirectiveList::parseReportURI):
* page/csp/ContentSecurityPolicyMediaListDirective.cpp:
(WebCore::ContentSecurityPolicyMediaListDirective::parse):
* page/csp/ContentSecurityPolicySourceList.cpp:
(WebCore::isSourceListNone):
(WebCore::ContentSecurityPolicySourceList::parse):
(WebCore::ContentSecurityPolicySourceList::parseSource):
(WebCore::ContentSecurityPolicySourceList::parseScheme):
(WebCore::ContentSecurityPolicySourceList::parseHost):
(WebCore::ContentSecurityPolicySourceList::parsePath):
(WebCore::ContentSecurityPolicySourceList::parsePort):
(WebCore::ContentSecurityPolicySourceList::parseNonceSource):
* platform/DateComponents.cpp:
(WebCore::countDigits):
* svg/SVGLengthList.cpp:
(WebCore::SVGLengthList::parse):
* svg/SVGParserUtilities.cpp:
(WebCore::genericParseNumber):
* svg/SVGParserUtilities.h:
(WebCore::skipOptionalSVGSpaces):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[webkitcorepy] Add an auto-installer (Unreviewed follow-up fix)
jbedard@apple.com [Fri, 31 Jul 2020 03:25:33 +0000 (03:25 +0000)]
[webkitcorepy] Add an auto-installer (Unreviewed follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=214606

Unreviewed development nit.

* .gitignore: Add Scripts/libraries/autoinstalled to .gitignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoUnreviewed second attempt to fix Catalyst build after r265084.
ryanhaddad@apple.com [Fri, 31 Jul 2020 03:18:12 +0000 (03:18 +0000)]
Unreviewed second attempt to fix Catalyst build after r265084.

* WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoConvert DateComponents to use StringParsingBuffer
weinig@apple.com [Fri, 31 Jul 2020 02:05:36 +0000 (02:05 +0000)]
Convert DateComponents to use StringParsingBuffer
https://bugs.webkit.org/show_bug.cgi?id=213929

Reviewed by Darin Adler.

- Switches string parsing in DateComponents to using StringParsingBuffer,
  making use of ParsingUtilities to streamline / simplify the code.
- Moves a few constant values only used in DateComponents.cpp to DateComponents.cpp
- Rename toInt in DateComponents.cpp to parseInt, and have use an Optional return
  value rather than bool + out-parameter.
- Add new parseIntWithinLimits that also checks that parsed value is within specfied
  limits, as this is what almost all of the int parsing in DateComponents needs.

* platform/DateComponents.cpp:
(WebCore::countDigits):
(WebCore::parseInt):
(WebCore::parseIntWithinLimits):
(WebCore::DateComponents::parseYear):
(WebCore::withinHTMLDateLimits):
(WebCore::createFromString):
(WebCore::DateComponents::fromParsingMonth):
(WebCore::DateComponents::fromParsingDate):
(WebCore::DateComponents::fromParsingWeek):
(WebCore::DateComponents::fromParsingTime):
(WebCore::DateComponents::fromParsingDateTimeLocal):
(WebCore::DateComponents::fromParsingDateTime):
(WebCore::DateComponents::parseTimeZone):
(WebCore::DateComponents::parseMonth):
(WebCore::DateComponents::parseDate):
(WebCore::DateComponents::parseWeek):
(WebCore::DateComponents::parseTime):
(WebCore::DateComponents::parseDateTimeLocal):
(WebCore::DateComponents::parseDateTime):
(WebCore::DateComponents::setMonthsSinceEpoch):
(WebCore::DateComponents::setMillisecondsSinceEpochForWeek):
(WebCore::toInt): Deleted.
* platform/DateComponents.h:
(WebCore::DateComponents::minimumYear): Deleted.
(WebCore::DateComponents::maximumYear): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoREGRESSION (r?): Web Inspector: Timelines: blue border below selected timeline when...
nvasilyev@apple.com [Fri, 31 Jul 2020 01:44:55 +0000 (01:44 +0000)]
REGRESSION (r?): Web Inspector: Timelines: blue border below selected timeline when in edit mode
https://bugs.webkit.org/show_bug.cgi?id=214979
<rdar://problem/66338399>

Reviewed by Devin Rousso.

Color the top border after the selected item with the same background as the selected item.
When editing, don't color that border with the selected item background.

* UserInterface/Views/TimelineOverview.css:
(.timeline-overview.edit-instruments > .tree-outline.timelines .item:not(:first-child),):
(body:matches(.window-inactive, .window-docked-inactive) .timeline-overview:not(.edit-instruments) > .tree-outline.timelines .item.selected + .item):
(body:not(.window-inactive, .window-docked-inactive) .timeline-overview:not(.edit-instruments) > .tree-outline.timelines:focus-within .item.selected + .item):
(@media (prefers-color-scheme: dark) .timeline-overview:not(.frames) > .graphs-container > .timeline-overview-graph:nth-child(even)):
(.timeline-overview > .tree-outline.timelines .item.selected + .item): Deleted.
(body:not(.window-inactive, .window-docked-inactive) .timeline-overview > .tree-outline.timelines:focus-within .item.selected + .item): Deleted.
(@media (prefers-color-scheme: dark) .timeline-overview.edit-instruments > .tree-outline.timelines .item:not(:first-child),): Deleted.
(@media (prefers-color-scheme: dark) .timeline-overview > .tree-outline.timelines .item.selected + .item): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agowebkitpy: If LC_ALL is set to a empty string, svn doesn't use the password store
Hironori.Fujii@sony.com [Fri, 31 Jul 2020 01:14:26 +0000 (01:14 +0000)]
webkitpy: If LC_ALL is set to a empty string, svn doesn't use the password store
https://bugs.webkit.org/show_bug.cgi?id=214983

Reviewed by Darin Adler.

If LC_ALL is set to a empty string, svn doesn't use the password
store in my environment. I'm using svn with gpg-agent on Ubuntu
20.04 (svn version 1.13.0, gpg-agent 2.2.19).

r101274 (Bug 68691) has set LC_ALL to a empty string.

If I invoke 'svn ci' on my terminal, svn askes gpg-agent my
password as expected, but if I invoke 'LC_ALL= svn ci', svn askes
my password by itself.

* Scripts/webkitpy/common/host.py:
(Host._engage_awesome_locale_hacks): Set the env var LC_ALL to 'en_US.UTF-8'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[webkitcorepy] Make scripts called with sudo use a userspace autoinstall
jbedard@apple.com [Fri, 31 Jul 2020 00:42:41 +0000 (00:42 +0000)]
[webkitcorepy] Make scripts called with sudo use a userspace autoinstall
https://bugs.webkit.org/show_bug.cgi?id=214981
<rdar://problem/66342996>

Reviewed by Dewei Zhu.

Sudo can bring havoc to the autoinstaller, because the directories it creates will belong
to the root user. We should ensure that the directories created by a sudo script call
are owned by the user that called sudo, when possible.

* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py:
* Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.install): Ensure that installed packages are not owned by root, if possible.
(AutoInstall.userspace_should_own): Ensure that a directory or file is not owned by root, if possible.
(AutoInstall.set_directory): Ensure that the directories containing auto-installed packages are not
owned by root, if possible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoRemove UB from nonPACBitsMask computation
keith_miller@apple.com [Fri, 31 Jul 2020 00:17:53 +0000 (00:17 +0000)]
Remove UB from nonPACBitsMask computation
https://bugs.webkit.org/show_bug.cgi?id=214996

Reviewed by Tadeu Zagallo.

For non-ARM64E we now set numberOfPACBits to zero, which was causing UB in our computation of the nonPACBitsMask.

Source/JavaScriptCore:

* assembler/MacroAssemblerARM64E.h:

Source/WTF:

* wtf/CagedPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoWeb Inspector: Add another Protocol Version (iOS 14.0)
drousso@apple.com [Fri, 31 Jul 2020 00:15:53 +0000 (00:15 +0000)]
Web Inspector: Add another Protocol Version (iOS 14.0)
https://bugs.webkit.org/show_bug.cgi?id=214991
<rdar://problem/59156892>

Reviewed by Brian Burg.

* UserInterface/Protocol/Legacy/14.0/InspectorBackendCommands.js: Added.
* Versions/Inspector-iOS-14.0.json: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoWeb Inspector: on Big Sur, match OS background, text, and border colors
nvasilyev@apple.com [Fri, 31 Jul 2020 00:12:06 +0000 (00:12 +0000)]
Web Inspector: on Big Sur, match OS background, text, and border colors
https://bugs.webkit.org/show_bug.cgi?id=214366
<rdar://problem/65617290>

Reviewed by Devin Rousso.

Refactoring:
- Remove --background-color-code because it was always the same value as --background-color-content.
- Replace commonly hardcoded `hsl(0, 0%, 97%)` background with --background-color-intermediate.

* UserInterface/Views/AnimationDetailsSidebarPanel.css:
(.sidebar > .panel.details.animation > .content > .details-section.animation-keyframes .details-section):
(.sidebar > .panel.details.animation > .content > .details-section.animation-keyframes .details-section .row.styles .CodeMirror):
* UserInterface/Views/BoxShadowEditor.css:
(.box-shadow-editor > table > tr > td > input[type="text"]):
* UserInterface/Views/BreakpointActionView.css:
(@media (prefers-color-scheme: dark) .breakpoint-action-eval-editor):
* UserInterface/Views/BreakpointPopoverController.css:
(.edit-breakpoint-popover-condition):
* UserInterface/Views/ChangesDetailsSidebarPanel.css:
(.sidebar > .panel.changes-panel .css-rule):
* UserInterface/Views/ComputedStyleSection.css:
(.computed-style-section .computed-property-item.expanded):
(.computed-style-properties.details-section > .content,):
* UserInterface/Views/ConsolePrompt.css:
(.console-prompt):
(.console-prompt > .CodeMirror-scroll):
* UserInterface/Views/CookiePopover.css:
(.popover .cookie-popover-content > table > tr > td > input:matches([type="text"], [type="datetime-local"])):

* UserInterface/Views/DetailsSection.css:
(.details-section .details-section):
(.details-section .details-section > .header):
Refactor. --background-color-content is the same color value.

(.details-section .details-section:not(.collapsed) > .header):
Refactor. --border-color-secondary is the same color value.

(.details-section > .content > .group:nth-child(even)):
(.details-section > .content > .group > .row:matches(.empty, .text)):
(@media (prefers-color-scheme: dark) .details-section > .header > label,):

* UserInterface/Views/DividerNavigationItem.css:
(.navigation-bar .item.divider):
Don't use hairline dividers. MacOS Catalina and Big Sur don't use hairline borders.

* UserInterface/Views/GraphicsOverviewContentView.css:
(.content-view.graphics-overview > section > .header):
(@media (prefers-color-scheme: dark) .content-view.graphics-overview):
* UserInterface/Views/LocalResourceOverridePopover.css:
(.popover .local-resource-override-popover-content .editor):
* UserInterface/Views/LogContentView.css:
(@media (prefers-color-scheme: dark) .console-messages):
* UserInterface/Views/QuickConsole.css:
(.quick-console):
* UserInterface/Views/ScopeChainDetailsSidebarPanel.css:
(@media (prefers-color-scheme: dark) .watch-expression-editor):
* UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:
(.spreadsheet-css-declaration):
(.spreadsheet-css-declaration.locked):
* UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
(@media (prefers-color-scheme: dark) .cm-s-default,):
* UserInterface/Views/TabBar.css:
(body.big-sur.docked .tab-bar > .border.bottom):
* UserInterface/Views/URLBreakpointPopover.css:
(.popover .url-breakpoint-content > .editor-wrapper > .editor):

* UserInterface/Views/Variables.css:
(:root):
Add --separator-color, which has the same semantics as `separator` color from Apple HIG
(https://developer.apple.com/design/human-interface-guidelines/ios/visual-design/color/#dynamic-system-colors).
--border-color-secondary was only defined in the dark mode. Define it in the light mode, too.

(body.window-inactive):
Remove unused variable.

(body.big-sur):
(@media (prefers-color-scheme: dark) :root):
(@media (prefers-color-scheme: dark) body.big-sur):
(@media (prefers-color-scheme: dark) body.window-inactive):
(body.window-inactive *): Remove unnecessarily greedy selector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoUnreviewed attempt to fix Catalyst build after r265084.
ryanhaddad@apple.com [Thu, 30 Jul 2020 23:54:39 +0000 (23:54 +0000)]
Unreviewed attempt to fix Catalyst build after r265084.

* editing/cocoa/DictionaryLookup.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoWeb Inspector: only show scrollbars when needed
drousso@apple.com [Thu, 30 Jul 2020 23:35:15 +0000 (23:35 +0000)]
Web Inspector: only show scrollbars when needed
https://bugs.webkit.org/show_bug.cgi?id=214980

Reviewed by Brian Burg.

Prefer `overflow: auto;` instead of `overflow: scroll;` wherever possible, as when using a
hardware mouse scrollbars are always shown for the latter, even when the content fits.

* UserInterface/Debug/UncaughtExceptionReporter.css:
(.sheet-container):
* UserInterface/Views/AuditTestContentView.css:
(.content-view-container > .content-view.audit-test):
* UserInterface/Views/CanvasOverviewContentView.css:
(.content-view.canvas-overview > .content-view.canvas.saved-recordings .tree-outline):
* UserInterface/Views/CanvasSidebarPanel.css:
(.sidebar > .panel.navigation.canvas.has-recordings > .content > .recording-content):
* UserInterface/Views/DOMEventsBreakdownView.css:
(.waterfall-popover-content .dom-events-breakdown):
* UserInterface/Views/DOMNodeEventsContentView.css:
(.dom-node-details.dom-events):
* UserInterface/Views/GraphicsOverviewContentView.css:
(.content-view.graphics-overview):
* UserInterface/Views/LocalRemoteObjectContentView.css:
(.content-view.local-remote-object):
* UserInterface/Views/NetworkResourceDetailView.css:
(.content-view.resource-details):
* UserInterface/Views/OpenResourceDialog.css:
(.open-resource-dialog > .tree-outline):
* UserInterface/Views/SourceCodeTextEditor.css:
(.popover .debugger-popover-content > .body):

* UserInterface/Views/CPUTimelineView.css:
(.timeline-view.cpu): Added.
(body .timeline-view.cpu): Deleted.
* UserInterface/Views/MemoryTimelineView.css:
(.timeline-view.memory): Added.
(body .timeline-view.memory): Deleted.
Although `!important` is kind of a "hack", adding `body` to the selector is more of a "hack"
and is easier to unintentionally break.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[iPadOS] Two taps are required to choose a country/region when creating an account...
wenson_hsieh@apple.com [Thu, 30 Jul 2020 23:31:59 +0000 (23:31 +0000)]
[iPadOS] Two taps are required to choose a country/region when creating an account on ea.com
https://bugs.webkit.org/show_bug.cgi?id=214984
<rdar://problem/66261490>

Reviewed by Devin Rousso.

Source/WebKit:

On the desktop version of the account creation page on ea.com, tapping a custom selection menu element
programmatically focuses a real `select` element that is positioned far outside the viewport. As a result, on
iPad, we still attempt to show a popover for this focused select at the element location. This popover is not
visible to the user, but on iOS 13, it still steals modal focus from the web view, which means that an
additional tap anywhere in the window is required to dismiss the (invisible) popover before the user can choose
one of the options in the custom in-page menu that is shown.

Furthermore, upon choosing one of these options, the page programmatically focuses the offscreen select again.
This causes us to re-present the offscreen popover, which requires yet another tap to dismiss on iOS 13.
However, on iOS 14, this actually results in a crash when attempting to scroll the popover's inner UITableView
to the selected row.

To fix both the crash on iOS 14 and the multiple redundant taps required to dismiss the popover on iOS 13, avoid
showing popovers altogether if the popover's presentation rect is outside the bounds of the content view, since
we cannot reasonably expect a user to interact with such a popover anyways.

Test: fast/forms/ios/repeatedly-focus-offscreen-select.html

* UIProcess/ios/forms/WKFormPopover.mm:
(-[WKRotatingPopover presentPopoverAnimated:]):

LayoutTests:

Add a test that exercises both the crash and the UI bug on iPadOS. Note that this test already passes on iOS,
where we don't use popovers for focused selects.

* fast/forms/ios/repeatedly-focus-offscreen-select-expected.txt: Added.
* fast/forms/ios/repeatedly-focus-offscreen-select.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[WebGL] Safari snapshots of WebGL content in the tab picker don't work
dino@apple.com [Thu, 30 Jul 2020 23:22:55 +0000 (23:22 +0000)]
[WebGL] Safari snapshots of WebGL content in the tab picker don't work
https://bugs.webkit.org/show_bug.cgi?id=214452
<rdar://problem/21243082>

Source/WebCore:

Original patch by Justin Fan. Reviewed by Darin Adler.

Test is in TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint): Will properly request a paint when a snapshot is requested.
* html/HTMLCanvasElement.h:
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::paintRenderingResultsToCanvas): Only clear the last snapshot if readPixels will succeed.
* rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::paintReplaced):

Tools:

Test for snapshotting. Marked as PLATFORM(MAC) for now.

* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[Cocoa] Adopt -[AVContentKeyRequest willOutputBeObscuredDueToInsufficientExternalProt...
jer.noble@apple.com [Thu, 30 Jul 2020 23:08:00 +0000 (23:08 +0000)]
[Cocoa] Adopt -[AVContentKeyRequest willOutputBeObscuredDueToInsufficientExternalProtectionForDisplays:]
https://bugs.webkit.org/show_bug.cgi?id=214659
<rdar://problem/63555006>

Reviewed by Darin Adler.
Source/WebCore:

Use the new WTF::Observer object as the listener type for notifying clients of display changes. When a displayChanged
event is observed, use the new AVContentKeyRequest -willOutputBeObscuredDueToInsufficientExternalProtectionForDisplays:
to set the keyStatus for that request appropriately.

* Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::MediaKeySession):
(WebCore::MediaKeySession::displayID):
(WebCore::MediaKeySession::displayChanged):
* Modules/encryptedmedia/MediaKeySession.h:
* dom/Document.cpp:
(WebCore::Document::windowScreenDidChange):
(WebCore::Document::addDisplayChangedObserver):
* dom/Document.h:
* platform/encryptedmedia/CDMInstanceSession.h:
(WebCore::CDMInstanceSession::displayChanged):
* platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
* platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(-[WebCoreFPSContentKeySessionDelegate contentKeySession:externalProtectionStatusDidChangeForContentKeyRequest:]):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::externalProtectionStatusDidChangeForContentKeyRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::displayChanged):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::externalProtectionStatusDidChangeForContentKeyRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateProtectionStatusForDisplayID):

Source/WebCore/PAL:

* pal/spi/cocoa/AVFoundationSPI.h:

Source/WebKit:

Support clients in the GPU process asking for (and receiving updates to) the current displayID.

* GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp:
(WebKit::RemoteCDMInstanceSessionProxy::displayIDChanged):
* GPUProcess/media/RemoteCDMInstanceSessionProxy.h:
* GPUProcess/media/RemoteCDMInstanceSessionProxy.messages.in:

Source/WTF:

Add a new Observer template class. This allows classes to provide support for listeners without requiring
those listeners to subclass from a pure-virtual (and CanMakeWeakPtr capable) client class. Instead, clients
can just create one of these Observer objects, and pass a WeakPtr to that observer to the notifying object.
When the client object destroys the observer, it is automatically unregistered when the observing object
uses a WeakHashSet.

* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/Observer.h: Added.
(WTF::Observer<Out):

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WTF/Observer.cpp: Added.
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[WebGL2] Buffer updates
commit-queue@webkit.org [Thu, 30 Jul 2020 22:27:30 +0000 (22:27 +0000)]
[WebGL2] Buffer updates
https://bugs.webkit.org/show_bug.cgi?id=209511

Patch by James Darpinian <jdarpinian@chromium.org> on 2020-07-30
Reviewed by Dean Jackson.

Various fixes in bufferData, bufferSubData, and getBufferSubData. Passes all WebGL conformance tests in conformance/buffers/* and conformance2/buffers/*.

* html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::sliceArrayBufferView):
(WebCore::WebGL2RenderingContext::getBufferSubData):
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::bufferData):
(WebCore::WebGLRenderingContextBase::bufferSubData):
* html/canvas/WebGLRenderingContextBase.h:
* html/canvas/WebGLRenderingContextBase.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoCompute number of PAC bits from what the OS says its address space is
keith_miller@apple.com [Thu, 30 Jul 2020 22:26:01 +0000 (22:26 +0000)]
Compute number of PAC bits from what the OS says its address space is
https://bugs.webkit.org/show_bug.cgi?id=214986

Reviewed by Saam Barati.

Source/JavaScriptCore:

* assembler/MacroAssemblerARM64E.h:

Source/WTF:

* wtf/CagedPtr.h:
* wtf/PtrTag.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[JSC][32-bits] interator_next should check for EmptyValue instead of undefined to...
ticaiolima@gmail.com [Thu, 30 Jul 2020 22:17:10 +0000 (22:17 +0000)]
[JSC][32-bits] interator_next should check for EmptyValue instead of undefined to execute LLInt fast path
https://bugs.webkit.org/show_bug.cgi?id=214963

Reviewed by Yusuke Suzuki.

JSTests:

* stress/invalidate-array-iterator-prototype-next.js: Added.

Source/JavaScriptCore:

There was a bug in previous implementation that allows execution of
`interator_next` fast path if we set ArrayIterator.prototype.next to
0. This happened because we were not properly checking `ValueEmpty`
from `m_next`. This patch is fixing such issue and doing the proper
verification.

* llint/LowLevelInterpreter32_64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[ iOS ] webanimations/accelerated-animation-with-easing.html is still flaky
graouts@webkit.org [Thu, 30 Jul 2020 21:51:39 +0000 (21:51 +0000)]
[ iOS ] webanimations/accelerated-animation-with-easing.html is still flaky
https://bugs.webkit.org/show_bug.cgi?id=214327
<rdar://problem/65569237>

Reviewed by Dean Jackson.

Source/WebKit:

When we fixed bug 213495 in r263506, we started calling PlatformCAAnimation::setTimingFunction()
to set the animation-wide timing function of CSS Animations and JS-originated animations alike.
However, we neglected to update PlatformCAAnimationRemote, used on iOS, to be able to handle
both animation-wide timing functions as well as keyframe-specific timing functions. This patch
adds a new "timingFunction" member to PlatformCAAnimationRemote::Properties to allow for this
and this new member is used in setTimingFunction() and copyTimingFunctionFrom(). Finally, after
the animation is decoded in the UI process, we call -[CAKeyframeAnimation setTimingFunction:]
inside addAnimationToLayer() to use this animation-wide timing function.

This fixes the test added originally in r263506 which would only work flakily, a symptom of this
missing implementation on iOS.

* WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.h:
* WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:
(WebKit::encodeTimingFunction):
(WebKit::decodeTimingFunction):
(WebKit::PlatformCAAnimationRemote::Properties::encode const):
(WebKit::PlatformCAAnimationRemote::Properties::decode):
(WebKit::PlatformCAAnimationRemote::setTimingFunction):
(WebKit::PlatformCAAnimationRemote::copyTimingFunctionFrom):
(WebKit::addAnimationToLayer):
(WebKit::operator<<):

LayoutTests:

Remove the flaky expectation and remove the extra tolerance added in r263761 when it was thought that
this test was merely flaky and not completely broken on iOS as it turned out to be.

* platform/ios-wk2/TestExpectations:
* webanimations/accelerated-animation-with-easing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoStrip pointers instead of authing for byteOffset to not allow for a possible way...
sbarati@apple.com [Thu, 30 Jul 2020 21:44:45 +0000 (21:44 +0000)]
Strip pointers instead of authing for byteOffset to not allow for a possible way to guess data pac
https://bugs.webkit.org/show_bug.cgi?id=214952

Reviewed by Keith Miller.

In the old way of doing things, we would auth the vector pointer before subtracting
the base from it. Since we never validated the auth, this allowed for a
potential data-PAC bypass by just repeatedly calling byteOffset in a loop
and observing the integer result of the operation.

Since byteOffset does no loads/stores, it suffices to just strip the PAC
bits before doing the subtraction. This eliminates any such attacks like
the above because the PAC bits are ignored.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetTypedArrayByteOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agocheck-webkit-style should enforce acronym capitalization at start/end of an identifier
ddkilzer@apple.com [Thu, 30 Jul 2020 21:44:33 +0000 (21:44 +0000)]
check-webkit-style should enforce acronym capitalization at start/end of an identifier
<https://webkit.org/b/214954>

Reviewed by Jonathan Bedard.

* DumpRenderTree/mac/DumpRenderTree.mm:
(shouldIgnoreWebCoreNodeLeaks):
(changeWindowScaleIfNeeded):
- Fix case issues in variables using URL acronym.

* Scripts/webkitpy/style/checkers/cpp.py:
(_check_identifier_name_for_acronyms): Add.
- This contains the logic to report acronyms with invalid case
  at the start and at the end of an identifer.
(check_identifier_name_in_declaration):
- Keep track of whether the identifer came from a class,
  namespace or struct.
- Fix bug where `auto` variables would not be checked because
  `auto` was removed with other non-type keywords like `inline`,
  leaving no type for the variable.  Add a comment to describe
  what this line is doing.
- Fix bug when removing "new" that changed an identifier named
  "newURL" to "URL".
- Add call to _check_identifier_name_for_acronyms() to implement
  the check.
(CppChecker):
- Add 'readability/naming/acronym' to the list of active
  checkers.

* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_identifier_names_with_acronyms):
- Add tests.  About half of the tests were taken from actual
  code that initially caused false positives during development.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[Cocoa] Make DecoderTest run against .mp4 files; add rate-limiting.
jer.noble@apple.com [Thu, 30 Jul 2020 21:28:38 +0000 (21:28 +0000)]
[Cocoa] Make DecoderTest run against .mp4 files; add rate-limiting.
https://bugs.webkit.org/show_bug.cgi?id=214807

Reviewed by Darin Adler.

PerformanceTests:

Look up the UTI type of the specified file, and create the appropriate SourceBufferParser
by passing in the ContentType (converted from UTI). Also, add a --rate-limit flag which
causes the decompression session to run at the same FPS as the underlying media.

* DecoderTest/DecoderTest.xcodeproj/project.pbxproj:
* DecoderTest/DecoderTest/main.mm:
(main):

Source/WebCore:

Export registerWebKitVP9Decoder() from VP9UtilitiesCocoa instead of LibWebRTCProvider to make it easier
for DecodeTest to import, as LibWebRTCProvider also pulls in a bunch of libwebrtc headers. Also, export
SourceBufferParser.h so DecoderTest can create parsers for fMP4 files.

* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/cocoa/VP9UtilitiesCocoa.h:
* platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
(WebCore::registerWebKitVP9Decoder):

Source/WebKit:

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::enableVP9Decoder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoMake report-non-inclusive-language ignore xcuserstate
bdakin@apple.com [Thu, 30 Jul 2020 21:24:43 +0000 (21:24 +0000)]
Make report-non-inclusive-language ignore xcuserstate
https://bugs.webkit.org/show_bug.cgi?id=214985

Reviewed by Darin Adler.

Ignore xcuserstate since it introduces random noise.
* Scripts/report-non-inclusive-language:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months ago[WebGL2] Enable conformance2/textures/{image,video} and related layout tests
commit-queue@webkit.org [Thu, 30 Jul 2020 21:21:54 +0000 (21:21 +0000)]
[WebGL2] Enable conformance2/textures/{image,video} and related layout tests
https://bugs.webkit.org/show_bug.cgi?id=214977

Patch by Kenneth Russell <kbr@chromium.org> on 2020-07-30
Reviewed by Dean Jackson.

Enable dozens more WebGL 2.0 conformance tests, most
significantly:
    webgl/2.0.0/conformance/textures/image/*
    webgl/2.0.0/conformance[2]/textures/video/*
which are now passing completely.

* TestExpectations:
* webgl/2.0.0/conformance2/textures/video/tex-2d-r11f_g11f_b10f-rgb-float-expected.txt:
* webgl/2.0.0/conformance2/textures/video/tex-2d-r11f_g11f_b10f-rgb-half_float-expected.txt:
* webgl/2.0.0/conformance2/textures/video/tex-2d-r11f_g11f_b10f-rgb-unsigned_int_10f_11f_11f_rev-expected.txt:
* webgl/2.0.0/conformance2/textures/video/tex-2d-r16f-red-float-expected.txt:
* webgl/2.0.0/conformance2/textures/video/tex-2d-r16f-red-half_float-expected.txt:
* webgl/2.0.0/conformance2/textures/video/tex-2d-r32f-red-float-expected.txt:
* webgl/2.0.0/conformance2/textures/video/tex-2d-rg16f-rg-float-expected.txt:
* webgl/2.0.0/conformance2/textures/video/tex-2d-rg16f-rg-half_float-expected.txt:
* webgl/2.0.0/conformance2/textures/video/tex-2d-rg32f-rg-float-expected.txt:
* webgl/2.0.0/conformance2/textures/video/tex-2d-rg8-rg-unsigned_byte-expected.txt:
* webgl/2.0.0/conformance2/textures/video/tex-2d-rg8ui-rg_integer-unsigned_byte-expected.txt:
* webgl/2.0.0/conformance2/textures/video/tex-2d-rgb5_a1-rgba-unsigned_byte-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoClicking on a shadow DOM does not move the selection to the focused element when...
rniwa@webkit.org [Thu, 30 Jul 2020 20:14:26 +0000 (20:14 +0000)]
Clicking on a shadow DOM does not move the selection to the focused element when delegatesFocus is set to true
https://bugs.webkit.org/show_bug.cgi?id=214859
<rdar://problem/66192901>

Reviewed by Wenson Hsieh.

Source/WebCore:

The bug was caused by EventHandler moving the selection to where the user had clicked, not to where the focus
had been delegated, which is a uniquely WebKit behavior. Fixed the bug by revealing the focused element as done
in Element::focus in EventHandler::dispatchMouseEvent and avoid updating the selection to the clicked point
later in EventHandler::handleMousePressEventSingleClick by adding an early exit.

Test: fast/shadow-dom/delegates-focus-and-types-into-input.html

* dom/Element.cpp:
(WebCore::Element::focus):
(WebCore::Element::revealFocusedElement): Extracted from Element::focus.
* dom/Element.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEventSingleClick): Added an early exit when dispatchMouseEvent had
delegated the focus to an element different from the one the user had clicked.
(WebCore::EventHandler::dispatchMouseEvent): Added a code to reveal the newly focused element when the focus
had been delegated.
* page/EventHandler.h:

LayoutTests:

Added a regression test.

* fast/shadow-dom/delegates-focus-and-types-into-input-expected.txt: Added.
* fast/shadow-dom/delegates-focus-and-types-into-input.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoWeb content gets stuck in an inactive state (no cursor updates or text insertion...
timothy_horton@apple.com [Thu, 30 Jul 2020 18:25:47 +0000 (18:25 +0000)]
Web content gets stuck in an inactive state (no cursor updates or text insertion caret) when activating a tab with a thumbnail visible
https://bugs.webkit.org/show_bug.cgi?id=214962
<rdar://problem/65670984>

Reviewed by Wenson Hsieh.

Source/WebCore:

New API test: WebKit.WKThumbnailViewResetsViewStateWhenUnparented

* testing/Internals.cpp:
(WebCore::Internals::isPageActive const):
* testing/Internals.h:
* testing/Internals.idl:
Add a "view window is active" getter.

Source/WebKit:

* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::setThumbnailView):
When WKThumbnailView is unparented, invalidate all activity state bits.
We do this because many of the functions that compute activity state bits
use the WKThumbnailView's window while it is parented. When it is unparented,
and we switch back to using the WKWebView's window, we mustn't get stuck
with activity state bits from WKThumbnailView's window.

This was particularly problematic in the case of the WKThumbnailViews
used for tab hover previews, because that window is not key, so we'd get
stuck with the inactive-window state, resulting in a lack of cursor updates,
a hidden text caret, the wrong selection color, etc.

* UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::isViewWindowActive):
While writing the API test for this, I noticed that isViewWindowActive
returns YES if there is no key window AND WKWebView is unparented
([NSApp keyWindow] == activeWindow() == nil).
This seems completely insane (how can the window be active if it doesn't
exist?), and breaks the test, so ensure that we only say YES if we actually
have a window.

Tools:

* TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
(TestWebKitAPI::TEST):
Add a test ensuring that we go back to the active-window state after
unparenting a WKThumbnailView that was installed in an inactive window.

(-[WKThumbnailViewDelegate webView:didFinishNavigation:]): Deleted.
* TestWebKitAPI/mac/OffscreenWindow.h:
* TestWebKitAPI/mac/OffscreenWindow.mm:
(-[OffscreenWindow initWithSize:]):
(-[OffscreenWindow initWithSize:isKeyWindow:]):
(-[OffscreenWindow isKeyWindow]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 months agoUnreviewed, fix bottom-tuple.js test
ysuzuki@apple.com [Thu, 30 Jul 2020 18:20:56 +0000 (18:20 +0000)]
Unreviewed, fix bottom-tuple.js test
https://bugs.webkit.org/show_bug.cgi?id=214956

Only thing we would like to check in this test is whether this does not crash.

* wasm/stress/bottom-tuple.js:
(catch): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265090 268f45cc-cd09-0410-ab3c-d52691b4dbfc