WebKit-https.git
15 years agoMake http cookies work
staikos [Mon, 5 Feb 2007 23:39:23 +0000 (23:39 +0000)]
Make http cookies work

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Mon, 5 Feb 2007 23:25:44 +0000 (23:25 +0000)]
LayoutTests:

        Reviewed by Mitz and Anders.

        Tests for http://bugs.webkit.org/show_bug.cgi?id=11811
        <rdar://problem/4947184> REGRESSION (r11783): Hebrew text in list boxes is reversed

        * fast/text/international/bidi-listbox-expected.checksum: Added.
        * fast/text/international/bidi-listbox-expected.png: Added.
        * fast/text/international/bidi-listbox-expected.txt: Added.
        * fast/text/international/bidi-listbox.html: Added.

        * fast/text/international/bidi-listbox-atsui-expected.checksum: Added.
        * fast/text/international/bidi-listbox-atsui-expected.png: Added.
        * fast/text/international/bidi-listbox-atsui-expected.txt: Added.
        * fast/text/international/bidi-listbox-atsui.html: Added.

WebCore:

        Reviewed by Mitz and Anders.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=11811
        <rdar://problem/4947184> REGRESSION (r11783): Hebrew text in list boxes is reversed

        http://bugs.webkit.org/show_bug.cgi?id=11812
        <rdar://problem/4960269> REGRESSION (Native file upload): Hebrew filenames are reversed

        Tests:
        fast/text/international/bidi-listbox.html
        fast/text/international/bidi-listbox-atsui.html

        * rendering/RenderBlock.h: Added static bidiReorderCharacters that will run the bidi algorithm on a character buffer.
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::bidiReorderCharacters): Added. Creates an anonymous RenderBlock and RenderText to feed into bidiReorderLines.
        (WebCore::RenderBlock::constructLine): Uses the new convenience methods on BidiRun.
        * rendering/bidi.h:
        (WebCore::BidiRun::reversed): Added convenience method.
        (WebCore::BidiRun::dirOverride): ditto.

        * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Creates a buffer and calls bidiReorderCharacters
          to get a correctly ordered character buffer for drawText.
        * rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Mon, 5 Feb 2007 23:19:10 +0000 (23:19 +0000)]
LayoutTests:

        Reviewed by Darin.

        - repaint test for http://bugs.webkit.org/show_bug.cgi?id=12590
          REGRESSION: Text selection is weird in textareas in Trac wiki editing pages

        * fast/repaint/selection-gap-overflow-scroll-expected.checksum: Added.
        * fast/repaint/selection-gap-overflow-scroll-expected.png: Added.
        * fast/repaint/selection-gap-overflow-scroll-expected.txt: Added.
        * fast/repaint/selection-gap-overflow-scroll.html: Added.

WebCore:

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12590
          REGRESSION: Text selection is weird in textareas in Trac wiki editing pages

        Test: fast/repaint/selection-gap-overflow-scroll.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::selectionGapRects): Adjust for overflow scroll.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Mon, 5 Feb 2007 23:07:03 +0000 (23:07 +0000)]
LayoutTests:

        Reviewed by Adele.

        - test for http://bugs.webkit.org/show_bug.cgi?id=11916
          REGRESSION (SearchField): RTL search fields are mixed up

        * fast/forms/search-rtl-expected.checksum: Added.
        * fast/forms/search-rtl-expected.png: Added.
        * fast/forms/search-rtl-expected.txt: Added.
        * fast/forms/search-rtl.html: Added.

WebCore:

        Reviewed by Adele.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11916
          REGRESSION (SearchField): RTL search fields are mixed up

        Test: fast/forms/search-rtl.html

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::createInnerBlockStyle): Always make the inner
        block LTR so that the results button will be on the left and the cancel
        button will be on the right.
        (WebCore::RenderTextControl::createInnerTextStyle): Inherit the direction
        property directly from the control so that it won't be masked by the inner
        block's LTR override.
        (WebCore::RenderTextControl::nodeAtPoint): Removed code that swapped the
        results and cancel buttons for RTL.
        (WebCore::RenderTextControl::forwardEvent): Ditto.
        (WebCore::RenderTextControl::clientPaddingLeft): Ditto.
        (WebCore::RenderTextControl::clientPaddingRight): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Mon, 5 Feb 2007 22:55:25 +0000 (22:55 +0000)]
LayoutTests:

        Reviewed by Adele.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12618
          REGRESSION (SearchField): Dragging across the text and releasing over the clear button clears the field

        * fast/forms/search-cancel-button-mouseup-expected.txt: Added.
        * fast/forms/search-cancel-button-mouseup.html: Added.

WebCore:

        Reviewed by Adele.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12618
          REGRESSION (SearchField): Dragging across the text and releasing over the clear button clears the field

        Test: fast/forms/search-cancel-button-mouseup.html

        Made the cancel button capturing.

        * html/HTMLTextFieldInnerElement.cpp:
        (WebCore::HTMLSearchFieldCancelButtonElement::HTMLSearchFieldCancelButtonElement):
        (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
        * html/HTMLTextFieldInnerElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler.
ggaren [Mon, 5 Feb 2007 21:12:13 +0000 (21:12 +0000)]
    Reviewed by Darin Adler.

        New script that allows you to ignore leaks by regular expression.

        * Scripts/run-leaks: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
bdakin [Mon, 5 Feb 2007 21:10:49 +0000 (21:10 +0000)]
    Reviewed by Adam.

        Fix for <rdar://problem/4975161> REGRESSION: With BumperCar 2.1.1,
        the contextual menu fails to appear when I ctrl-click on page

        * WebCoreSupport/WebContextMenuClient.mm:
        (WebContextMenuClient::getCustomMenuFromDefaultItems): If the
        delegate does not respond to contextMenuItemsForElement, return the
        default menu instead of nil.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan and Darin Adler.
ggaren [Mon, 5 Feb 2007 21:08:44 +0000 (21:08 +0000)]
    Reviewed by John Sullivan and Darin Adler.

        Focused gc-8.html on the issue it was really trying to test (a crash)
        to fix intermittent failures seen on buildbot.

        * fast/dom/gc-8.html: Don't test the value of our custom property, which
        (legitimately) can be cleared by garbage collection.
        * fast/dom/gc-8-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-02-05 Mitz Pettel <mitz@webkit.org>
ap [Mon, 5 Feb 2007 18:32:29 +0000 (18:32 +0000)]
2007-02-05  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=6626
          Arabic & Farsi rendered with no shaping (all glyphs separate, unreadable!)

        No test possible since Mac OS X only ships with fonts that contain shaping
        information.

        * icu/unicode/ushape.h: Added from
        http://www.opensource.apple.com/darwinsource/10.4.8.ppc/ICU-6.2.9/icuSources/common/unicode/
        * platform/FontData.h:
        (WebCore::FontData::shapesArabic): Added. Returns whether the font contains
        shaping information for Arabic or not.
        * platform/mac/FontDataMac.mm:
        (WebCore::FontData::platformInit):
        (WebCore::FontData::checkShapesArabic): Added. Checks whether the font contains
        a glyph metamorphosis table. The heuristic is that if a font contains Arabic glyphs
        and a metamorphosis table, then it includes shaping information for Arabic.
        * platform/mac/FontMac.mm:
        (WebCore::overrideLayoutOperation): Changed to use the same character buffer passed
        to ATSUI instead of the original character buffer and to give zero-width spaces zero
        width.
        (WebCore::isArabicLamWithAlefLigature): Added. Checks if the character is one
        of the Arabic presentation forms of Lam with Alef.
        (WebCore::shapeArabic): Added. This is a wrapper around the ICU Arabic shaping routine
        that replaces each space following a Lam with Alef ligature resulting from shaping
        with a zero-width space.
        (WebCore::ATSULayoutParameters::initialize): Changed to allocate the auxiliary buffer
        lazily for mirroring and Arabic shaping. Added a call to shapeArabic() when required.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoClean up changelog entry. Also testing new svn-co-one-file script.
ddkilzer [Mon, 5 Feb 2007 15:18:59 +0000 (15:18 +0000)]
Clean up changelog entry.  Also testing new svn-co-one-file script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-02-05 Eric Seidel <eric@webkit.org>
eseidel [Mon, 5 Feb 2007 13:07:34 +0000 (13:07 +0000)]
2007-02-05  Eric Seidel  <eric@webkit.org>

        No review, build fix only.

        * ksvg2/svg/SVGStyleElement.cpp: add forgotten header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-02-05 Eric Seidel <eric@webkit.org>
eseidel [Mon, 5 Feb 2007 12:46:59 +0000 (12:46 +0000)]
2007-02-05  Eric Seidel  <eric@webkit.org>

        Reviewed by bdash.

        Fix style name testcase which I broke in my last commit.

        * ksvg2/svg/SVGStyleElement.cpp:
        (WebCore::SVGStyleElement::xmlspace):
        (WebCore::SVGStyleElement::title): override Element::title()
        (WebCore::SVGStyleElement::parseMappedAttribute):
        * ksvg2/svg/SVGStyleElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-02-04 Eric Seidel <eric@webkit.org>
eseidel [Mon, 5 Feb 2007 11:21:15 +0000 (11:21 +0000)]
2007-02-04  Eric Seidel  <eric@webkit.org>

        Reviewed by darin.

        Fix hand cursor on link hover for SVG
        Fix status text on link hover for SVG
        Fix tooltips on link hover for SVG
        Fix link dragging for SVG
        http://bugs.webkit.org/show_bug.cgi?id=12575

        Test: added manual-tests/svg-links.svg

        * dom/Document.cpp:
        (WebCore::Document::prepareMouseEvent):
        * dom/Element.cpp:
        (WebCore::Element::title):
        * dom/Element.h:
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::setId):
        (WebCore::HTMLElement::title):
        (WebCore::HTMLElement::setTitle):
        (WebCore::HTMLElement::setLang):
        * html/HTMLElement.h:
        * ksvg2/svg/SVGAElement.cpp:
        (WebCore::SVGAElement::title):
        (WebCore::SVGAElement::parseMappedAttribute):
        (WebCore::SVGAElement::defaultEventHandler):
        * ksvg2/svg/SVGAElement.h:
        * ksvg2/svg/SVGTitleElement.cpp:
        * ksvg2/svg/SVGTitleElement.h:
        * manual-tests/svg-links.svg: Added.
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::title):
        (WebCore::HitTestResult::absoluteImageURL):
        (WebCore::HitTestResult::absoluteLinkURL):
        (WebCore::HitTestResult::isLiveLink):
        (WebCore::HitTestResult::titleDisplayString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Mon, 5 Feb 2007 06:06:53 +0000 (06:06 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=12602
        XPath functions string(), normalize-space() and string-length() don't work
        without arguments

        Test: fast/xpath/implicit-node-args.html

        * xml/XPathFunctions.cpp:
        (WebCore::XPath::FunString::doEvaluate):
        (WebCore::XPath::FunStringLength::doEvaluate):
        (WebCore::XPath::FunNormalizeSpace::doEvaluate):
        Don't try to pass RefPtr<Node> to the Value ctor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Mon, 5 Feb 2007 05:56:16 +0000 (05:56 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=8791
        XPath should support custom node resolvers

WebCore:
        * bindings/js/JSCustomXPathNSResolver.cpp: Added.
        (WebCore::JSCustomXPathNSResolver::create):
        (WebCore::JSCustomXPathNSResolver::JSCustomXPathNSResolver):
        (WebCore::JSCustomXPathNSResolver::~JSCustomXPathNSResolver):
        (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
        * bindings/js/JSCustomXPathNSResolver.h: Added.
        * bindings/objc/DOMCustomXPathNSResolver.h: Added.
        * bindings/objc/DOMCustomXPathNSResolver.mm: Added.
        (WebCore::DOMCustomXPathNSResolver::DOMCustomXPathNSResolver):
        (WebCore::DOMCustomXPathNSResolver::~DOMCustomXPathNSResolver):
        (WebCore::DOMCustomXPathNSResolver::lookupNamespaceURI):
        Wrappers for JS/ObjC objects that can be used as resolvers.

        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorObjC.pm:
        Use the above wrappers to support custom resolvers.

        * xml/XPathNSResolver.cpp:
        * xml/XPathNSResolver.h:
        Turned this class into an abstract one.

        * xml/NativeXPathNSResolver.cpp: Added.
        (WebCore::NativeXPathNSResolver::NativeXPathNSResolver):
        (WebCore::NativeXPathNSResolver::~NativeXPathNSResolver):
        (WebCore::NativeXPathNSResolver::lookupNamespaceURI):
        * xml/NativeXPathNSResolver.h: Added.
        A XPathNSResolver subclass, doing what XPathNSResolver used to do.

        * xml/XPathEvaluator.cpp:
        (WebCore::XPathEvaluator::createNSResolver): Create a NativeXPathNSResolver.

        * WebCore.xcodeproj/project.pbxproj: Added new files.

LayoutTests:
        * fast/xpath/nsresolver-bad-object-expected.txt: Added.
        * fast/xpath/nsresolver-bad-object.xhtml: Added.
        * fast/xpath/nsresolver-exception-expected.txt: Added.
        * fast/xpath/nsresolver-exception.xhtml: Added.
        * fast/xpath/nsresolver-function-expected.txt: Added.
        * fast/xpath/nsresolver-function.xhtml: Added.
        * fast/xpath/nsresolver-object-expected.txt: Added.
        * fast/xpath/nsresolver-object.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
weinig [Mon, 5 Feb 2007 02:54:45 +0000 (02:54 +0000)]
    Reviewed by Darin.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=12562
        Fix test cases that are now spewing console errors that
        they are not testing for

        * fast/events/iframe-object-onload-expected.txt:
        * fast/events/iframe-object-onload.html: Change nil to null.
        * fast/forms/display-none-in-onchange-keyboard-expected.txt:
        * fast/forms/display-none-in-onchange-keyboard.html: Add missing id to div, change
        its text, and change the resulting text.
        * fast/forms/input-text-click-inside-expected.checksum:
        * fast/forms/input-text-click-inside-expected.png:
        * fast/forms/input-text-click-inside-expected.txt:
        * fast/forms/input-text-click-inside.html: Change moveTo(x,y) to mouseMoveTo(x,y).
        * fast/forms/input-text-click-outside-expected.txt:
        * fast/forms/input-text-click-outside.html: Ditto.
        * fast/js/array-foreach-expected.txt:
        * fast/js/array-foreach.html: Add try-catch blocks to catch exceptions and print them and
        general cleanup.
        * fast/js/array-some-expected.txt:
        * fast/js/array-some.html: Ditto.
        * fast/table/click-near-anonymous-table-expected.checksum:
        * fast/table/click-near-anonymous-table-expected.png:
        * fast/table/click-near-anonymous-table-expected.txt:
        * fast/table/click-near-anonymous-table.html: Change timeForward(ms) to leapForward(ms) and
        change the amount of time from 500ms to 1000ms to avoid clicking.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-02-04 Oliver Hunt <oliver@apple.com>
oliver [Mon, 5 Feb 2007 02:37:02 +0000 (02:37 +0000)]
2007-02-04  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Tidying up EventHandler, and moving more of
        EventHandlerMac.mm to EventHandler.cpp

        Also added EventHandler::eventLoopHandleMouse[Dragged,Up]
        these are basically helper functions to allow correct event
        handling on MacOS.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseUp):
        (WebCore::EventHandler::dragSourceMovedTo):
        (WebCore::EventHandler::dragSourceEndedAt):
        (WebCore::EventHandler::dispatchDragSrcEvent):
           Moved from EventHandlerMac to EventHandler

        * page/EventHandler.h:
        (WebCore::EventHandler::eventLoopHandleMouseUp):
        (WebCore::EventHandler::eventLoopHandleMouseDragged):
          Null implementations of two Mac helper functions
        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::eventLoopHandleMouseDragged):
        (WebCore::EventHandler::handleDrag):
          Much tidying, reduced nesting, made less dependent on NS types
        (WebCore::EventHandler::eventLoopHandleMouseDragged):
        (WebCore::EventHandler::eventLoopHandleMouseUp):
          Helper functions to let us process events properly on MacOS

        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoVarious Qt related hacks and cleanups to make forms work better
staikos [Sun, 4 Feb 2007 14:15:14 +0000 (14:15 +0000)]
Various Qt related hacks and cleanups to make forms work better

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Adam.
mjs [Sun, 4 Feb 2007 07:56:40 +0000 (07:56 +0000)]
    Rubber stamped by Adam.

        - remove obsolete code that has an annoying space in the directory name

        * WebCore.vcproj/Image Viewer.cpp: Removed.
        * WebCore.vcproj/Image Viewer.h: Removed.
        * WebCore.vcproj/Image Viewer.ico: Removed.
        * WebCore.vcproj/Image Viewer.rc: Removed.
        * WebCore.vcproj/Image Viewer.reg: Removed.
        * WebCore.vcproj/Image Viewer.vcproj: Removed.
        * WebCore.vcproj/Image Viewer/ImageDocument.cpp: Removed.
        * WebCore.vcproj/Image Viewer/ImageDocument.h: Removed.
        * WebCore.vcproj/Image Viewer/ImageMainFrame.cpp: Removed.
        * WebCore.vcproj/Image Viewer/ImageMainFrame.h: Removed.
        * WebCore.vcproj/Image Viewer/ImageView.cpp: Removed.
        * WebCore.vcproj/Image Viewer/ImageView.h: Removed.
        * WebCore.vcproj/Image Viewer/Resource.h: Removed.
        * WebCore.vcproj/Image Viewer/res/ImageViewer.rc2: Removed.
        * WebCore.vcproj/Image Viewer/res/Toolbar.bmp: Removed.
        * WebCore.vcproj/Image Viewer/stdafx.cpp: Removed.
        * WebCore.vcproj/Image Viewer/stdafx.h: Removed.
        * WebCore.vcproj/Image iewerDoc.ico: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agofix crash on JS that ends with an identifier
staikos [Sun, 4 Feb 2007 07:37:45 +0000 (07:37 +0000)]
fix crash on JS that ends with an identifier

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-02-04 Mitz Pettel <mitz@webkit.org>
oliver [Sun, 4 Feb 2007 07:34:44 +0000 (07:34 +0000)]
2007-02-04  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Oliver.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12564
          REGRESSION: Uncaught AppKit exception when using the scrollwheel while Gmail is loading

        * platform/mac/PlatformMouseEventMac.mm:
        (WebCore::eventNumberForEvent): Scroll wheel events don't have an event number.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Landing results that I think Maciej intended to land, to get the buildbot
ggaren [Sun, 4 Feb 2007 02:07:03 +0000 (02:07 +0000)]
    Landing results that I think Maciej intended to land, to get the buildbot
        back to green.

        * fast/forms/disabled-select-change-index-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Sam.
zimmermann [Sun, 4 Feb 2007 01:25:03 +0000 (01:25 +0000)]
Reviewed by Sam.

Add support for xml:space="preserve" for SVG text.
It can be modeled by using white-space="pre" and replace \n by spaces.

Handle xml:space="default" correctly.
Always remove tabs from SVG text - as demanded by spec.

Added test: svg/custom/text-whitespace-handling.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Sat, 3 Feb 2007 20:35:33 +0000 (20:35 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=12560
        W3C XPath test Text_Nodes.svg fails

        Covered by dom/svg/level3/xpath/Text_Nodes.svg

        * xml/XPathStep.cpp:
        (WebCore::XPath::Step::nodeTestMatches): Only include the first text sibling in text() matches.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Sat, 3 Feb 2007 20:22:06 +0000 (20:22 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=12485
        XPath id() function doesn't work as root in paths

        Test: fast/xpath/id-path.html

        * xml/XPathPath.cpp:
        (WebCore::XPath::Path::doEvaluate): Implemented.
        (WebCore::XPath::LocationPath::evaluate): A new overload that takes an initial NodeVector.
        (WebCore::XPath::LocationPath::doEvaluate): Moved most of the logic to the new evaluate().

        * xml/XPathPath.h: Added a new evaluate() overload and a using declaration to keep the
        generic one visible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Sat, 3 Feb 2007 20:14:59 +0000 (20:14 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=12559
        REGRESSION: Crash in checkForHeadCharset() under GuardMalloc

        No tests possible.

        * loader/TextResourceDecoder.cpp:
        (WebCore::TextResourceDecoder::checkForHeadCharset): Fix end of buffer checks; sprinkle a number
        of new ones over the function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark.
weinig [Sat, 3 Feb 2007 15:00:42 +0000 (15:00 +0000)]
    Reviewed by Mark.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=12555
        Drosera doesn't handle CR ( carriage returns ) well

        - Normalize all the line endings.

        * Drosera/debugger.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
ddkilzer [Sat, 3 Feb 2007 12:16:36 +0000 (12:16 +0000)]
WebCore:

        Reviewed by NOBODY (no-svg build fix).

        * page/EventHandler.cpp: Include FloatPoint.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
ap [Sat, 3 Feb 2007 10:53:11 +0000 (10:53 +0000)]
    Reviewed by Mitz.

        http://bugs.webkit.org/show_bug.cgi?id=12549
        Wrong character encoding at www.ravmilim.co.il

        Test: fast/encoding/meta-charset.html

        * loader/TextResourceDecoder.cpp:
        (WebCore::TextResourceDecoder::checkForHeadCharset): Fix an off by one error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
mjs [Sat, 3 Feb 2007 05:54:46 +0000 (05:54 +0000)]
LayoutTests:

        Reviewed by Hyatt & Adele.

        - test case for <rdar://problem/4896972> TV guide listings page doesn't finish loading (11674)

        * fast/forms/disabled-select-change-index.html: Added.

WebCore:

        Reviewed by Hyatt & Adele.

        - <rdar://problem/4896972> TV guide listings page doesn't finish loading (11674)

        Test case: fast/forms/disabled-select-change-index.html

        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::setSelected): Allow changing selected state of a disabled
        option.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBuild fix, not reviewed.
zimmermann [Sat, 3 Feb 2007 01:36:05 +0000 (01:36 +0000)]
Build fix, not reviewed.
Blind attempt to fix Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Eric & Maciej.
zimmermann [Sat, 3 Feb 2007 01:33:38 +0000 (01:33 +0000)]
Reviewed by Eric & Maciej.

Fix serveral <use> issues:
- When events are dispatch to a referenced element, the actual event.target
has to be set to the corresponding SVGElementInstance object

- Node::shadowAncestorNode() should _not_ return the shadowParentNode for SVG elements
This is only needed for the HTML forms concept and breaks event dispatching for SVG shadow tree elements.

- Add SVGElementInstance as possible EventTarget in bindings/js/kjs_dom.cpp
(Now event.target returns the actual SVGElementInstance object for a shadow tree element)

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12502 (Reproducible crash when browsing SVG map.)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12511 (<use> has event dispatching issues)
Added test: svg/custom/use-event-handler-on-use-element.svg
Added test: svg/custom/use-event-handler-on-referenced-element.svg
Added test: svg/custom/use-elementInstance-event-target.svg
Added test: svg/custom/use-elementInstance-methods.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler.
ggaren [Sat, 3 Feb 2007 01:06:51 +0000 (01:06 +0000)]
    Reviewed by Darin Adler.

        Added some more known leaks to the leaks ignore list.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Why does XCode
        hate itself so much?
        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-02-02 Oliver Hunt <oliver@apple.com>
oliver [Sat, 3 Feb 2007 00:25:19 +0000 (00:25 +0000)]
2007-02-02  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoff.

        Add guard around accessing [NSEvent eventNumber] to ensure
        we don't attempt to access it on on non-mouse related NSEvent.

        * platform/mac/PlatformMouseEventMac.mm:
        (WebCore::eventNumberForEvent):
        (WebCore::PlatformMouseEvent::PlatformMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders.
aroben [Fri, 2 Feb 2007 23:53:11 +0000 (23:53 +0000)]
    Reviewed by Anders.

        Try to be a little less selfish about DocumentLoader.

        Spotted while working on <rdar://problem/4957747>.

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
            Everyone can open frames in new windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Eric.
zimmermann [Fri, 2 Feb 2007 23:45:48 +0000 (23:45 +0000)]
Reviewed by Eric.

Move xml:space/xml:lang from svgattrs.in to xmlattrs.in where they actually belong.
Now they are actually recognized by SVGLangSpace::parseMappedAttribute.
Patch implementing xml:space="preserve" coming soon, which acts as test for this stuff.

Always build XMLNames.cpp (not only for SVG) and replace all occourences of
"http://www.w3.org/XML/1998/namespace" by "XMLNames::xmlNamespaceURI".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
bdakin [Fri, 2 Feb 2007 23:03:31 +0000 (23:03 +0000)]
    Reviewed by Maciej.

        Working on a layout test.

        Fix for <rdar://problem/4966100> REGRESSION: Reproducible ASSERT
        hit at Walgreens.com

        * page/Frame.cpp:
        (WebCore::Frame::setView): If we are setting the view to 0 and
        detaching the document, call unscheduleRealyout() on the old view
        before setting it to 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoadd const back, too
ggaren [Fri, 2 Feb 2007 19:57:28 +0000 (19:57 +0000)]
add const back, too

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Even better build fix than the last.
ggaren [Fri, 2 Feb 2007 19:56:16 +0000 (19:56 +0000)]
    Even better build fix than the last.

        * ChangeLog:
        * DumpRenderTree/DumpRenderTree.m:
        (shouldIgnoreWebCoreNodeLeaks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fixed build. Added work-around for GCC bug.
ggaren [Fri, 2 Feb 2007 18:57:55 +0000 (18:57 +0000)]
    Fixed build. Added work-around for GCC bug.

        * DumpRenderTree/DumpRenderTree.m:
        (shouldIgnoreWebCoreNodeLeaks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agobuild fix? i don't think so, but let's see...
ggaren [Fri, 2 Feb 2007 18:36:27 +0000 (18:36 +0000)]
build fix? i don't think so, but let's see...

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders.
darin [Fri, 2 Feb 2007 17:57:28 +0000 (17:57 +0000)]
    Reviewed by Anders.

        - fix copying and assigning a ListHashSet

        No test because the code path with bugs I am fixing is not used yet.

        * wtf/ListHashSet.h: Tweaked ListHashSetNodeAllocator a little bit for clarity.
        Changed m_allocator to be an OwnPtr instead of doing an explicit delete.
        Fixed bug in copy constructor where we'd have an uninitialized m_allocator.
        Fixed bug in assignment operator where it would swap only the hash table, and
        not the head, tail, and allocator pointers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
ggaren [Fri, 2 Feb 2007 17:55:33 +0000 (17:55 +0000)]
JavaScriptCore:

        Reviewed by Maciej Stachowiak.

        Use WTFLog instead of fprintf for logging KJS::Node leaks.

        * kjs/nodes.cpp:
        (NodeCounter::~NodeCounter): Changed count to unsigned, updated
        to match style guidelines.

WebCore:

        Reviewed by Maciej Stachowiak.

        Added support for selectively ignoring WebCore::Node leaks during layout
        tests, so that we can ignore known leaks in other components.

        * WebCore.exp:
        * dom/Node.cpp:
        (WebCore::Node::isSupported): Moved isSupported up with the rest of the static functions.

        (WebCore::): Added an ignoreSet, which collects WebCore::Nodes whose lifetime
        we want to ignore. We need to track which nodes to ignore rather than, say,
        just suspending the count, because node destruction depends on lots of
        different variables, so it would be nearly impossible to know when exactly
        to suspend the count and when exactly to resume it.

        (WebCore::NodeCounter::~NodeCounter): Changed to use WTFLog instead of fprintf.

        (WebCore::Node::startIgnoringLeaks): Do the ignoring.
        (WebCore::Node::stopIgnoringLeaks): ditto
        (WebCore::Node::Node): ditto
        (WebCore::Node::~Node): ditto

        * dom/Node.h: Moved isSupported up with the rest of the static functions.

        * platform/mac/LoggingMac.mm:
        (WebCore::initializeWithUserDefault): Renamed from "initializeLoggingChannel"
        because the real goal here is to honor a user default -- WTFLoggingChannels
        need no run-time initialization. Also replaced "off by default, on if a
        user default says so" behavior with "only override existing setting if a
        user default says so" behavior. It seemed like a bug that you would specify
        a channel's on/off state in its definition, but this function would unconditionally
        blow that state away.
        (WebCore::InitializeLoggingChannelsIfNecessary):

WebKit:

        Reviewed by Maciej Stachowiak.

        Added support for selectively ignoring WebCore::Node leaks during layout
        tests, so that we can ignore known leaks in other components.

        * Misc/WebCoreStatistics.h:
        * Misc/WebCoreStatistics.mm:
        (+[WebCoreStatistics startIgnoringWebCoreNodeLeaks]):
        (+[WebCoreStatistics stopIgnoringWebCoreNodeLeaks]):

WebKitTools:

        Reviewed by Maciej Stachowiak.

        Added support for selectively ignoring WebCore::Node leaks during layout
        tests, so that we can ignore known leaks in other components.

        * DumpRenderTree/DumpRenderTree.m:
        (shouldIgnoreWebCoreNodeLeaks): Implements a black list of tests whose
        WebCore::Node leaks we have to ignore. Does this CFString gobbledy-gook
        confuse anyone else?
        (runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-02-02 Eric Seidel <eric@webkit.org>
eseidel [Fri, 2 Feb 2007 16:28:09 +0000 (16:28 +0000)]
2007-02-02  Eric Seidel  <eric@webkit.org>

        Reviewed by mitz.

        Fix gradient stop style resolution to be less of a hack, fixing style invalidation:
        http://bugs.webkit.org/show_bug.cgi?id=12193
        and fix stop-color and stop-opacity not to inherit:
        http://bugs.webkit.org/show_bug.cgi?id=12193

        Tests:
        * svg/custom/gradient-stops-style-change.svg: added
        * svg/W3C-SVG-1.1/pservers-grad-18-b.svg: updated

        * WebCore.xcodeproj/project.pbxproj:
        * ksvg2/css/SVGCSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applySVGProperty):
        * ksvg2/css/SVGRenderStyle.cpp:
        (WebCore::SVGRenderStyle::inheritedNotEqual):
        (WebCore::SVGRenderStyle::inheritFrom):
        * ksvg2/css/SVGRenderStyle.h:
        * ksvg2/svg/SVGDefsElement.cpp:
        (WebCore::SVGDefsElement::createRenderer):
        * ksvg2/svg/SVGGradientElement.cpp:
        (WebCore::SVGGradientElement::createRenderer):
        (WebCore::SVGGradientElement::buildStops):
        * ksvg2/svg/SVGGradientElement.h:
        (WebCore::SVGGradientElement::rendererIsNeeded):
        * ksvg2/svg/SVGStopElement.cpp:
        (WebCore::SVGStopElement::createRenderer):
        * ksvg2/svg/SVGStopElement.h:
        (WebCore::SVGStopElement::rendererIsNeeded):
        * rendering/RenderSVGGradientStop.cpp: Added.
        * rendering/RenderSVGGradientStop.h: Added.
        * rendering/RenderSVGHiddenContainer.cpp: Added.
        * rendering/RenderSVGHiddenContainer.h: Added.
        * rendering/RenderSVGContainer.cpp:
        * rendering/RenderSVGContainer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix scrolling-on-selection bug by correctly
zack [Fri, 2 Feb 2007 14:41:23 +0000 (14:41 +0000)]
Fix scrolling-on-selection bug by correctly
scrolling to the offset instead of trying to
ensure visibility with margins
r=Lars

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoactually set the pen on color setting
zack [Fri, 2 Feb 2007 10:26:06 +0000 (10:26 +0000)]
actually set the pen on color setting

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix drawing of dashed and colored lines. Pen
zack [Fri, 2 Feb 2007 10:24:46 +0000 (10:24 +0000)]
Fix drawing of dashed and colored lines. Pen
has to be inherited for stroke to stay consistent.
r=Lars

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoCompilation fix: forward declare d-ptr.
zack [Fri, 2 Feb 2007 09:49:48 +0000 (09:49 +0000)]
Compilation fix: forward declare d-ptr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - not reviewed, build fix
mjs [Fri, 2 Feb 2007 09:35:54 +0000 (09:35 +0000)]
    - not reviewed, build fix

        * wtf/ListHashSet.h:
        (WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator): ummm, use union correctly

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
mjs [Fri, 2 Feb 2007 09:14:15 +0000 (09:14 +0000)]
    Reviewed by Darin.

        - use a custom allocator for ListHashSet, to fix ~1% perf regression using it for form control

        * wtf/ListHashSet.h:
        (WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator):
        (WTF::ListHashSetNodeAllocator::allocate):
        (WTF::ListHashSetNodeAllocator::deallocate):
        (WTF::ListHashSetNode::operator new):
        (WTF::ListHashSetNode::operator delete):
        (WTF::ListHashSetNode::destroy):
        (WTF::ListHashSetTranslator::translate):
        (WTF::::ListHashSet):
        (WTF::::~ListHashSet):
        (WTF::::add):
        (WTF::::unlinkAndDelete):
        (WTF::::deleteAllNodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
mjs [Fri, 2 Feb 2007 09:09:59 +0000 (09:09 +0000)]
    Reviewed by Darin.

        - use a custom allocator for ListHashSet, to fix ~1% per regression using it for form control

        * wtf/ListHashSet.h:
        (WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator):
        (WTF::ListHashSetNodeAllocator::allocate):
        (WTF::ListHashSetNodeAllocator::deallocate):
        (WTF::ListHashSetNode::operator new):
        (WTF::ListHashSetNode::operator delete):
        (WTF::ListHashSetNode::destroy):
        (WTF::ListHashSetTranslator::translate):
        (WTF::::ListHashSet):
        (WTF::::~ListHashSet):
        (WTF::::add):
        (WTF::::unlinkAndDelete):
        (WTF::::deleteAllNodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMake the frames white by default and get the
zack [Fri, 2 Feb 2007 08:41:12 +0000 (08:41 +0000)]
Make the frames white by default and get the
files that WebCore can handle render inside
the frames.
r=Lars

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-02-01 Nicholas Shanks <webkit@nickshanks.com>
bdash [Fri, 2 Feb 2007 07:43:25 +0000 (07:43 +0000)]
2007-02-01  Nicholas Shanks  <webkit@nickshanks.com>

        Reviewed by Mark.

        Add support for CSS2 font-stretch property.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyDeclarations):
        (WebCore::CSSStyleSelector::applyProperty):
        * platform/FontCache.cpp:
        (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
        (WebCore::FontPlatformDataCacheKey::operator==):
        (WebCore::computeHash):
        (WebCore::FontPlatformDataCacheKeyTraits::deletedValue):
        (WebCore::FontPlatformDataCacheKeyTraits::emptyValue):
        (WebCore::FontCache::getCachedFontPlatformData):
        * platform/FontDescription.h:
        (WebCore::):
        (WebCore::FontDescription::FontDescription):
        (WebCore::FontDescription::stretch):
        (WebCore::FontDescription::narrowerStretch):
        (WebCore::FontDescription::widerStretch):
        (WebCore::FontDescription::setStretch):
        (WebCore::FontDescription::operator==):
        * platform/mac/FontCacheMac.mm:
        (WebCore::FontCache::createFontPlatformData):
        * platform/mac/WebFontCache.mm:
        (acceptableChoice):
        (betterChoice):
        (+[WebFontCache fontWithFamily:traits:size:]):

2007-02-01  Nicholas Shanks  <webkit@nickshanks.com>

        Reviewed by Mark.

        CSS2 font-stretch property; uses American Typewriter and Helvetica Neue fonts,
        requiring Regular, Condensed, Bold and Bold Condensed faces.

        * fast/css/computed-style-expected.txt: Updated.
        * fast/css/font-stretch-expected.checksum: Added.
        * fast/css/font-stretch-expected.png: Added.
        * fast/css/font-stretch-expected.txt: Added.
        * fast/css/font-stretch.html: Added.

2007-02-01  Nicholas Shanks  <webkit@nickshanks.com>

        Reviewed by Mark.

        Add support for CSS2 font-stretch property.

        * WebInspector/webInspector/inspector.js:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _addToStyle:fontA:fontB:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark Rowe.
thatcher [Fri, 2 Feb 2007 06:57:38 +0000 (06:57 +0000)]
    Reviewed by Mark Rowe.

        <rdar://problem/4969201> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/

        * platform/mac/WebFontCache.mm:
        (+[WebFontCache fontWithFamily:traits:size:]): Don't call [NSFont fontWithName:] with the desiredFamily on Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Fri, 2 Feb 2007 05:52:37 +0000 (05:52 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=12506
        REGRESSION: Safari doesn't display hebrew text on a web page,
        displayed correctly on Tiger

WebCore:
        * loader/TextResourceDecoder.cpp:
        (WebCore::TextResourceDecoder::checkForHeadCharset): Advance the pointer when necessary.

LayoutTests:
        * fast/encoding/pseudo-tags-in-attributes-expected.txt: Changing back to success.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd a cookie interface for the Qt build.
staikos [Fri, 2 Feb 2007 05:44:31 +0000 (05:44 +0000)]
Add a cookie interface for the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoun-doing accidental change that made all of the files in tables/mozilla/bugs allow...
bdakin [Fri, 2 Feb 2007 03:11:49 +0000 (03:11 +0000)]
un-doing accidental change that made all of the files in tables/mozilla/bugs allow tabs. whoopsie!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
mjs [Fri, 2 Feb 2007 02:40:03 +0000 (02:40 +0000)]
    Reviewed by Adele.

        - fixed <rdar://problem/4922764> ASSERTION: (!m_contentFunction) in PolicyCheck::call trying to visit feed URL (CNN, Apple, etc.)

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stopPolicyCheck): Call new cancel method instead of call(false) on old check.
        (WebCore::PolicyCheck::cancel): call any callback function that is set with false or PolicyIgnore as
        appropriate.
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
andersca [Fri, 2 Feb 2007 01:34:40 +0000 (01:34 +0000)]
LayoutTests:

        Reviewed by Darin.

        Update test results that have console messages.

        * dom/html/level2/html/HTMLFrameElement09-expected.txt:
        * dom/html/level2/html/HTMLIFrameElement11-expected.txt:
        * dom/xhtml/level2/html/HTMLBaseElement01-expected.txt:
        * dom/xhtml/level2/html/HTMLBaseElement02-expected.txt:
        * dom/xhtml/level2/html/frame-expected.txt:
        * dom/xhtml/level2/html/iframe-expected.txt:
        * editing/execCommand/4920488-expected.txt:
        * editing/selection/contenteditable-click-inside-expected.txt:
        * editing/selection/contenteditable-click-outside-expected.txt:
        * fast/AppleScript/001-expected.txt:
        * fast/dynamic/015-expected.txt:
        * fast/events/iframe-object-onload-expected.txt:
        * fast/events/updateLayoutForHitTest-expected.txt:
        * fast/forms/display-none-in-onchange-keyboard-expected.txt:
        * fast/forms/input-text-click-inside-expected.txt:
        * fast/forms/input-text-click-outside-expected.txt:
        * fast/forms/selected-index-assert-expected.txt:
        * fast/js/array-foreach-expected.txt:
        * fast/js/array-some-expected.txt:
        * fast/js/kde/exception_propagation-expected.txt:
        * fast/js/kde/garbage-n-expected.txt:
        * fast/js/kde/string-1-n-expected.txt:
        * fast/js/kde/string-2-n-expected.txt:
        * fast/parser/script-tag-with-trailing-slash-expected.txt:
        * fast/table/click-near-anonymous-table-expected.txt:
        * fast/tokenizer/002-expected.txt:
        * fast/tokenizer/external-script-document-write_2-expected.txt:
        * fast/tokenizer/script_extra_close-expected.txt:
        * fast/xsl/transform-xhr-doc-expected.txt:
        * http/tests/navigation/error404-goback-expected.txt:
        * http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
        * svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
        * svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
        * svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
        * svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
        * svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
        * svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
        * svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
        * svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
        * svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
        * svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
        * svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
        * svg/custom/dynamic-empty-path-expected.txt:
        * svg/custom/js-update-container-expected.txt:
        * svg/custom/js-update-gradient-expected.txt:
        * svg/custom/js-update-polygon-changes-expected.txt:
        * svg/custom/js-update-polygon-removal-expected.txt:
        * svg/custom/path-bad-data-expected.txt:
        * svg/custom/polyline-hittest-expected.txt:
        * svg/custom/polyline-invalid-points-expected.txt:
        * svg/custom/polyline-setattribute-points-null-expected.txt:
        * svg/custom/svgpolyparser-extra-space-expected.txt:
        * svg/custom/use-modify-target-symbol-expected.txt:
        * svg/custom/viewbox-syntax-expected.txt:
        * tables/mozilla/bugs/bug53690-1-expected.txt:
        * tables/mozilla/bugs/bug9024-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug3517-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
        * tables/mozilla_expected_failures/core/captions1-expected.txt:
        * tables/mozilla_expected_failures/dom/appendCells1-expected.txt:
        * tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.txt:
        * tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
        * tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:

WebKitTools:

        Reviewed by Darin.

        * DumpRenderTree/UIDelegate.m:
        (-[UIDelegate webView:addMessageToConsole:]):
        Dump console messages.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
bdakin [Fri, 2 Feb 2007 00:52:29 +0000 (00:52 +0000)]
WebCore:
        Reviewed by Hyatt.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=10517 REGRESSION
        (r12065-r12082): Navigation graphic wraps to the next line on
        duart.com and <rdar://problem/4960505> REGRESSION: The Awesome
        Windows Vista page has a layout error in the header table (10517)

        The problem is that we never supported a quirk that other browsers
        support where, under very specific circumstances, a table cell will
        grow to fit an image inside of it. This is only a regression
        because a bug was fixed were we were 1 pixel off in the calculation
        of overflow in some cases.

        * rendering/RenderBlock.cpp:
        (WebCore::shouldGrowTableCellForImage):
        (WebCore::RenderBlock::calcInlineMinMaxWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
lars [Thu, 1 Feb 2007 19:57:05 +0000 (19:57 +0000)]
    Reviewed by Adam.

        Fix form loading for the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * fast/encoding/pseudo-tags-in-attributes-expected.txt: Change test result...
darin [Thu, 1 Feb 2007 17:34:05 +0000 (17:34 +0000)]
    * fast/encoding/pseudo-tags-in-attributes-expected.txt: Change test result to reflect failure
        because bug 12506 isn't fixed yet; we'll change it back once the bug is re-fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoImplement native look for comboboxes
zack [Thu, 1 Feb 2007 12:27:56 +0000 (12:27 +0000)]
Implement native look for comboboxes
and fix/implement popup menus. Also add the m_timestamp
and m_eventType setting to PlatformMouseEvent
r=Lars

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
mjs [Thu, 1 Feb 2007 08:56:18 +0000 (08:56 +0000)]
    Reviewed by Adam.

        <rdar://problem/4730469> REGRESSION: Assertion failure in -[WebDataSource(WebInternal) _bridge] when forwarding message

        * WebView/WebDataSource.mm:
        (-[WebDataSource subresources]): Check for being uncommitted and return emtpy result.
        (-[WebDataSource subresourceForURL:]): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Thu, 1 Feb 2007 08:36:53 +0000 (08:36 +0000)]
LayoutTests:

        Reviewed by Maciej.

        - test for <rdar://problem/4887428> REGRESSION: Implement slight delay for firing incremental onSearch event

        * fast/forms/search-event-delay-expected.txt: Added.
        * fast/forms/search-event-delay.html: Added.

WebCore:

        Reviewed by Maciej.

        - fix <rdar://problem/4887428> REGRESSION: Implement slight delay for firing incremental onSearch event

        * rendering/RenderTextControl.h:
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::RenderTextControl): Set up timer.
        (WebCore::RenderTextControl::subtreeHasChanged): Start timer here instead of immediately sending event.
        (WebCore::RenderTextControl::searchEventTimerFired): Added. Sends search event.
        (WebCore::RenderTextControl::stopSearchEventTimer): Added.
        (WebCore::RenderTextControl::startSearchEventTimer): Added. Sends search event right away if there is
        no text. If there is some text, sets the timer using the same delay rule as NSSearchField. If you keep
        typing, then the timer keeps getting reset 0.2 seconds into the future until you pause.

        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::onSearch): Tell the renderer to
        stop the timer, since we're sending a search event. This helps when a caller other than
        the timer decides to send an explicit search event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix by Darin, reviewed by Maciej.
mjs [Thu, 1 Feb 2007 08:23:31 +0000 (08:23 +0000)]
    Fix by Darin, reviewed by Maciej.

        - fix ~10% performance regression from encoding fix

        * loader/TextResourceDecoder.cpp:
        (WebCore::TextResourceDecoder::checkForHeadCharset): Fix a logic
        error which made huge strings accidentally.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agofix the Qt build
lars [Thu, 1 Feb 2007 07:53:52 +0000 (07:53 +0000)]
fix the Qt build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Thu, 1 Feb 2007 06:55:43 +0000 (06:55 +0000)]
LayoutTests:

        Reviewed by Adam and Geoff.

        - test for <rdar://problem/4786767> REGRESSION: <select> controls are not resized when zooming text

        * fast/forms/select-width-font-change-expected.txt: Added.
        * fast/forms/select-width-font-change.html: Added.

WebCore:

        Reviewed by Adam and Geoff.

        - fix <rdar://problem/4786767> REGRESSION: <select> controls are not resized when zooming text

        Test: fast/forms/select-width-font-change.html

        * rendering/RenderMenuList.h: Cleaned up formatting a bit. Removed unneeded include of PopupMenu.h.
        Made a lot more things private, including the PopupMenuClient base class, all of the virtual
        functions from PopupMenuClient, and the setTextFromOption function. Added updateOptionsWidth.

        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::setStyle): Added code to call updateOptionsWidth when the font changes.
        (WebCore::RenderMenuList::updateOptionsWidth): Added. Factored code out of updateFromElement.
        Changed to do nothing when m_optionsWidth is already correct.
        (WebCore::RenderMenuList::updateFromElement): Moved code to recomputed options width to the new
        updateOptionsWidth function.
        (WebCore::RenderMenuList::text): Made const.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoliver Hunt <oliver@apple.com>
oliver [Thu, 1 Feb 2007 06:02:09 +0000 (06:02 +0000)]
liver Hunt  <oliver@apple.com>

        Reviewed by Adam.
WebCore:
        Migrate more drag and drop logic to WebCore, start preparing
        to move EventHandler::handleDrag from EventHandlerMac to EventHandler

        * WebCore.exp:
          updating methods

        * dom/Clipboard.cpp:
        * dom/Clipboard.h:
        (WebCore::Clipboard::Clipboard):
        (WebCore::Clipboard::setDragHasStarted):
        (WebCore::Clipboard::dragStarted):
          Moving from ClipboardMac to Clipboard

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchMouseEvent):
          PlatformMouseEvent no longer lies about button state, however
          DOM Events don't allow NoButton, so we need to convert NoButton
          to LeftButton when we create a DOM Event from PlatformMouseEvent

        * page/DragClient.h:
          Tidying comment

        * page/DragController.cpp:
        (WebCore::createMouseEvent):
          Updated for new PlatformMouseEvent constructors
        (WebCore::DragController::mayStartDragAtEventLocation):
          Migrated from WebKit

        * page/DragController.h:
          Added above function declarations

        * page/EventHandler.cpp:
        (WebCore::EventHandler::dragState):
        (WebCore::EventHandler::dragHysteresisExceeded):
        (WebCore::EventHandler::freeClipboard):
        (WebCore::EventHandler::shouldDragAutoNode):
          Moved from EventHandlerMac
        (WebCore::EventHandler::handleMouseMoveEvent):
        (WebCore::EventHandler::eventMayStartDrag):
        (WebCore::EventHandler::handleMousePressEvent):
          Use DragController

        * page/EventHandler.h:
          Added DragState struct definition to EventHandler

        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::eventActivatedView):
        (WebCore::EventHandler::handleDrag):
        (WebCore::EventHandler::handleMouseUp):
        (WebCore::EventHandler::mouseDown):
          Update to use DragController and PlatformMouseEvent

        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge dragSourceMovedTo:]):
        (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
          Use DragController for state

WebKit:
        Migrating methods to WebCore

        * WebCoreSupport/WebFrameBridge.mm:
        * WebView/WebHTMLView.mm:
        * WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Thu, 1 Feb 2007 04:26:51 +0000 (04:26 +0000)]
LayoutTests:

        Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=12506
        REGRESSION: Safari doesn't display hebrew text on a web page,
        displayed correctly on Tiger

        * fast/encoding/pseudo-tags-in-attributes-expected.txt: Added.
        * fast/encoding/pseudo-tags-in-attributes.html: Added.

WebCore:

        Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=12506
        REGRESSION: Safari doesn't display hebrew text on a web page,
        displayed correctly on Tiger

        * loader/TextResourceDecoder.cpp:
        (WebCore::TextResourceDecoder::checkForHeadCharset): Skip over
        quoted attributes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
weinig [Thu, 1 Feb 2007 04:20:02 +0000 (04:20 +0000)]
    Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12510
        Initialize the variable m_totalLoops
        Is tested by LayoutTests/fast/css/MarqueeLayoutTest.html

        * rendering/RenderLayer.cpp:
        (WebCore::Marquee::Marquee):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
andersca [Thu, 1 Feb 2007 03:51:00 +0000 (03:51 +0000)]
LayoutTests:

        Reviewed by Maciej.

        <rdar://problem/4886776>
        REGRESSION: After opening a web archive, location shows the actual URL, not the webarchive file

        * webarchive/loading/resources/helloworld.webarchive: Added.
        * webarchive/loading/test-loading-archive-expected.txt: Added.
        * webarchive/loading/test-loading-archive.html: Added.

WebCore:

        Reviewed by Maciej.

        <rdar://problem/4886776>
        REGRESSION: After opening a web archive, location shows the actual URL, not the webarchive file

        * WebCore.exp:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::continueLoadWithData):
        * loader/FrameLoader.h:
        New function which continues a load but using a given buffer instead.

WebKit:

        Reviewed by Maciej.

        <rdar://problem/4886776>
        REGRESSION: After opening a web archive, location shows the actual URL, not the webarchive file

        "Revert" the change done in 13734.

        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation loadArchive]):
        Don't do a new load here, as this would cancel the current load and call the resource load
        delegate's didFailLoadingWithError: method. Instead, call continueLoadWithData.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * DumpRenderTree/ResourceLoadDelegate.m:
andersca [Thu, 1 Feb 2007 03:30:39 +0000 (03:30 +0000)]
    * DumpRenderTree/ResourceLoadDelegate.m:
        (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
        Use an NSString here so we can guarantee that -description always returns the same value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
mjs [Thu, 1 Feb 2007 02:14:09 +0000 (02:14 +0000)]
    Reviewed by Adam.

        - fix sporadic crash

        * wtf/ListHashSet.h:
        (WTF::::remove): remove before deleting

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
adele [Thu, 1 Feb 2007 01:55:30 +0000 (01:55 +0000)]
    Reviewed by Adam.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=12516
        REGRESSION (r19313): All keyboard navigation has stopped working

        For non-editable selections, handleKeyPress doesn't need to call _interceptEditingKeyEvent.

        * editing/Editor.cpp:
        (WebCore::selectionForEvent): Moved this to the top of the file.
        (WebCore::Editor::handleKeyPress): Do the equivalent of the _canEdit check that used to be in WebKit WebEditorClient::handleKeyPress.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
mjs [Thu, 1 Feb 2007 01:33:23 +0000 (01:33 +0000)]
    Reviewed by Maciej.

        Fix run-pageloadtest to actually work again.

        * Misc/WebNSWindowExtras.m:
        (+[NSWindow _webkit_displayThrottledWindows]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
ggaren [Thu, 1 Feb 2007 01:03:22 +0000 (01:03 +0000)]
WebCore:

        Reviewed by Darin Adler.

        Added a Range counter to detect leaks. Tweaked the Node counter.

        Also fixed a TextIterator destructive modification bug that I noticed along the
        way. No test case for this bug because no clients have been bitten by it
        yet.

        * dom/Node.cpp: Renamed NodeImplCounter to NodeCounter, changed counter
        to unsigned, fixed formatting to match style guidelines.
        (WebCore::NodeCounter::~NodeCounter):
        (WebCore::Node::Node):
        (WebCore::Node::~Node):

        * dom/Range.cpp:
        (WebCore::RangeCounter::~RangeCounter): Added.
        (WebCore::Range::Range):
        (WebCore::Range::~Range):
        (WebCore::Range::ownerDocument): New accessor, used by TextIterator to avoid
        annoying NULL checks.
        * dom/Range.h:

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::subrange):
        (1) Don't initialize result with entireRange --  doing so would create a
        PassRefPtr that pointed to entireRange, so this function would destructively
        modify the Range you passed it. Initialize it with a new Range instead.
        (2) Don't use a PassRefPtr as a local variable, because they have sneaky
        semantics. Use a RefPtr instead.
        (3) Don't call CharacterIterator::range() willy-nilly, since it does
        non-trivial work. Use a local variable instead.

WebKitTools:

        Reviewed by Darin Adler.

        Added Selection::toRange to the leaks -exclude list, since it comes up
        as a false positive (Radar 4967949).

        Also added RangeCounter to the global initializer exclude list. I added
        a RangeCounter since leaks won't detect all Range leaks anymore.

        * Scripts/check-for-global-initializers:
        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * DumpRenderTree/ResourceLoadDelegate.m:
andersca [Thu, 1 Feb 2007 00:31:52 +0000 (00:31 +0000)]
    * DumpRenderTree/ResourceLoadDelegate.m:
        (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
        Don't try to create an identifier if resource loads shouldn't be dumped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
andersca [Wed, 31 Jan 2007 23:00:19 +0000 (23:00 +0000)]
    Reviewed by Geoff.

        Add dumping of resource loads. This isn't completely tweaked yet since the test results would
        rely on resources being delivered in the same order which might not always be true. However, it works good
        enough for the simple webarchive tests I want to do right now.

        * DumpRenderTree/DumpRenderTree.h:
        * DumpRenderTree/DumpRenderTree.m:
        (dumpRenderTree):
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (-[LayoutTestController dumpResourceLoadCallbacks]):
        (runTest):

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/ResourceLoadDelegate.h: Added.
        * DumpRenderTree/ResourceLoadDelegate.m: Added.
        Add new resource load delegate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Maciej.
zimmermann [Wed, 31 Jan 2007 22:59:23 +0000 (22:59 +0000)]
Reviewed by Maciej.
Fix run-pageloadtest to actually work again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Wed, 31 Jan 2007 22:55:56 +0000 (22:55 +0000)]
LayoutTests:

        Reviewed by Darin.

        Test for <rdar://problem/4521461> REGRESSION: when keyPress event changes form focus, inserted key goes to wrong control

        * fast/events/keypress-focus-change-expected.txt: Added.
        * fast/events/keypress-focus-change.html: Added.
        * fast/events/resources/keypress-frame.html: Added.

WebCore:

        Reviewed by Darin.

        WebCore part of fix for <rdar://problem/4521461> REGRESSION: when keyPress event changes form focus, inserted key goes to wrong control

        Test: fast/events/keypress-focus-change.html

        * editing/Editor.cpp:
        (WebCore::selectionForEvent): Added.  This computes a selection that considers the case where an event handler
         has moved the selection outside of a text control.  In that case, we use the target control's selection.
        (WebCore::Editor::insertText): This gets the selectionForEvent, checks that the selection is editable,
         and calls TypingCommand::insertText with the correct selection.

        * editing/TypingCommand.h: Added a version of insertText that takes a selection.  The old version of insertText will call this, and pass
          in the frame's selection.
        * editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Added. Uses the passed in selection to
          set the starting and ending selections correctly so that the editing machinery will insert the text in the correct place.

        * page/Page.h: Added convenience method to get selection from focused or main frame.
        * page/Page.cpp: (WebCore::Page::selection):

        * html/HTMLInputElement.h: Added selection methods to get selection for text controls.
        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::selection):
        * html/HTMLTextAreaElement.h:
        * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::selection):
        * rendering/RenderTextControl.h:
        * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selection):

WebKit:

        Reviewed by Darin.

        WebKit part of fix for <rdar://problem/4521461> REGRESSION: when keyPress event changes form focus, inserted key goes to wrong control

        * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): Instead of using the selected frame, use the
          frame for the target of the keyboard event.  Also, don't do the canEdit check here, since the target's frame might not
          have a selection at this point.  Do the canEdit check within Editor::insertText, where we determine which selection to use
          for inserting text.
        * WebView/WebEditingDelegatePrivate.h: Added forward declaration of DOMHTMLElement. This is needed after reordering includes in WebEditorClient.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Backing out the CFRunLoopRunSpecific exclude command because it was overly
ggaren [Wed, 31 Jan 2007 22:01:34 +0000 (22:01 +0000)]
    Backing out the CFRunLoopRunSpecific exclude command because it was overly
        broad. We'll either need to work around this leak in DRT, or do some
        custom grep-based leak ignoring.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Hatcher.
aliceli1 [Wed, 31 Jan 2007 21:15:57 +0000 (21:15 +0000)]
    Reviewed by Tim Hatcher.

        Turning an accidental API change to an SPI change

        * WebView/WebEditingDelegate.h:
        * WebView/WebEditingDelegatePrivate.h:
        move some declarations into private header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin [Wed, 31 Jan 2007 15:08:49 +0000 (15:08 +0000)]
WebCore:

        - fix build

        * ForwardingHeaders/wtf/ListHashSet.h: Added.

WebKit:

        - fix build

        * ForwardingHeaders/wtf/ListHashSet.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoImplement native colors for selections.
zack [Wed, 31 Jan 2007 14:08:05 +0000 (14:08 +0000)]
Implement native colors for selections.
r=Lars

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoExpose the fact that the form has been edited
zack [Wed, 31 Jan 2007 13:44:45 +0000 (13:44 +0000)]
Expose the fact that the form has been edited
in the public Qt api.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
mjs [Wed, 31 Jan 2007 13:43:13 +0000 (13:43 +0000)]
JavaScriptCore:

        Reviewed by Mark with help from Lars.

        - added new ListHashSet class, which combines a hashtable and a linked list to provide a set
        that keeps elements in inserted order

        This is to assist in fixing the following:
        <rdar://problem/4751164> REGRESSION: Safari places text on incorrect button when returning to a page via back [10541]
        http://bugs.webkit.org/show_bug.cgi?id=10541

        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wtf/HashTable.h:
        (WTF::HashTable::find):
        (WTF::HashTable::contains):
        (WTF::::find):
        (WTF::::contains):
        * wtf/ListHashSet.h: Added.
        (WTF::ListHashSetNode::ListHashSetNode):
        (WTF::ListHashSetNodeHashFunctions::hash):
        (WTF::ListHashSetNodeHashFunctions::equal):
        (WTF::ListHashSetIterator::ListHashSetIterator):
        (WTF::ListHashSetIterator::get):
        (WTF::ListHashSetIterator::operator*):
        (WTF::ListHashSetIterator::operator->):
        (WTF::ListHashSetIterator::operator++):
        (WTF::ListHashSetIterator::operator--):
        (WTF::ListHashSetIterator::operator==):
        (WTF::ListHashSetIterator::operator!=):
        (WTF::ListHashSetIterator::operator const_iterator):
        (WTF::ListHashSetIterator::node):
        (WTF::ListHashSetConstIterator::ListHashSetConstIterator):
        (WTF::ListHashSetConstIterator::get):
        (WTF::ListHashSetConstIterator::operator*):
        (WTF::ListHashSetConstIterator::operator->):
        (WTF::ListHashSetConstIterator::operator++):
        (WTF::ListHashSetConstIterator::operator--):
        (WTF::ListHashSetConstIterator::operator==):
        (WTF::ListHashSetConstIterator::operator!=):
        (WTF::ListHashSetConstIterator::node):
        (WTF::ListHashSetTranslator::hash):
        (WTF::ListHashSetTranslator::equal):
        (WTF::ListHashSetTranslator::translate):
        (WTF::::ListHashSet):
        (WTF::::operator):
        (WTF::::~ListHashSet):
        (WTF::::size):
        (WTF::::capacity):
        (WTF::::isEmpty):
        (WTF::::begin):
        (WTF::::end):
        (WTF::::find):
        (WTF::::contains):
        (WTF::::add):
        (WTF::::remove):
        (WTF::::clear):
        (WTF::::unlinkAndDelete):
        (WTF::::appendNode):
        (WTF::::deleteAllNodes):
        (WTF::::makeIterator):
        (WTF::::makeConstIterator):
        (WTF::deleteAllValues):

WebCore:

        Reviewed by Mark.

        - fixed <rdar://problem/4751164> REGRESSION: Safari places text on incorrect button when returning to a page via back [10541]
        http://bugs.webkit.org/show_bug.cgi?id=10541

        * dom/Document.cpp:
        (WebCore::Document::formElementsState):
        * dom/Document.h:

        I couldn't figure out the back/forward support in the tests enough
        to make an automated test, but this maual test reproduces the
        problem 100% without this patch:

        * manual-tests/back.html: Added.
        * manual-tests/form-control-madness.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdded Bugzilla bug number. Thanks Mitz!
ddkilzer [Wed, 31 Jan 2007 12:59:41 +0000 (12:59 +0000)]
Added Bugzilla bug number.  Thanks Mitz!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
ddkilzer [Wed, 31 Jan 2007 12:51:30 +0000 (12:51 +0000)]
WebCore:

        Reviewed by Mitz.

        No test cases since there is no change in functionality.

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::findNextLineBreak): Simplify canFitOnLine expression.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdding comments explaining how the focus ring implementation
zack [Wed, 31 Jan 2007 12:36:24 +0000 (12:36 +0000)]
Adding comments explaining how the focus ring implementation
works on the Qt platform and just move focus ring rendering
related code to the same spot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
mjs [Wed, 31 Jan 2007 12:20:57 +0000 (12:20 +0000)]
    Reviewed by Eric.

        - add back no-op version of silly method so that shipping Safari can still run the PLT

        * Misc/WebNSWindowExtras.m:
        (-[NSWindow _webkit_displayThrottledWindows]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoClean up key event handling on Qt.
zack [Wed, 31 Jan 2007 12:00:23 +0000 (12:00 +0000)]
Clean up key event handling on Qt.
r=Lars

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix a double delete on cancel as well as a crash with proxy
staikos [Wed, 31 Jan 2007 08:57:13 +0000 (08:57 +0000)]
Fix a double delete on cancel as well as a crash with proxy

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-31 Mark Rowe <mrowe@apple.com>
bdash [Wed, 31 Jan 2007 08:33:31 +0000 (08:33 +0000)]
2007-01-31  Mark Rowe  <mrowe@apple.com>

        More build fixing.

        * Misc/WebKitLogging.h: Use !defined() rather than !.
        * Plugins/WebNetscapePluginStream.h: Remove #if __cplusplus as this file is only included from Obj-C++ files.
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Use #ifdef rather than #if.
        * WebView/WebView.mm:
        (-[WebView isGrammarCheckingEnabled]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-31 Mark Rowe <mrowe@apple.com>
bdash [Wed, 31 Jan 2007 08:11:28 +0000 (08:11 +0000)]
2007-01-31  Mark Rowe  <mrowe@apple.com>

        Build fix.

        * WebView/WebView.mm:
        (-[WebView initWithFrame:frameName:groupName:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agofix a crash on exit
staikos [Wed, 31 Jan 2007 08:10:22 +0000 (08:10 +0000)]
fix a crash on exit
remove focusFrame
add childFrames

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-31 Mark Rowe <mrowe@apple.com>
bdash [Wed, 31 Jan 2007 07:26:13 +0000 (07:26 +0000)]
2007-01-31  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver.

        Enable -Wundef in WebKit, and change misuses of #if to #ifdef or #ifndef as appropriate.

        * Misc/WebKitLogging.h:
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebFrame.mm:
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView validateUserInterfaceItem:]):
        (-[WebHTMLView delete:]):
        (-[WebHTMLView showGuessPanel:]):
        (-[WebHTMLView copy:]):
        (-[WebHTMLView cut:]):
        (-[WebHTMLView paste:]):
        * WebView/WebHTMLViewInternal.h:
        * WebView/WebView.mm:
        (-[WebViewPrivate init]):
        (-[WebView validateUserInterfaceItem:]):
        * WebView/WebViewPrivate.h:

2007-01-31  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver.

        * dom/Document.h: Change #if XSLT_SUPPORT to #ifdef XSLT_SUPPORT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix the Qt build.
lars [Wed, 31 Jan 2007 07:20:24 +0000 (07:20 +0000)]
Fix the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoImplement SVGImage on the Qt platform.
zack [Wed, 31 Jan 2007 06:43:50 +0000 (06:43 +0000)]
Implement SVGImage on the Qt platform.
r=Eric

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady.
mjs [Wed, 31 Jan 2007 05:45:47 +0000 (05:45 +0000)]
    Reviewed by Brady.

        - fixed <rdar://problem/4939366> REGRESSION: Assertion failure and crash when going back in history (12314)

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::createWindow): special case a frame name of "_blank"
        (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19289 268f45cc-cd09-0410-ab3c-d52691b4dbfc