WebKit-https.git
14 years agoGtk build fix.
mrowe@apple.com [Thu, 29 Nov 2007 11:57:00 +0000 (11:57 +0000)]
Gtk build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:44:31 +0000 (11:44 +0000)]
2007-11-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Mark Rowe.

        Attempt to fix non-mac builds after PCRE cleanup.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCoreSources.bkl:
        * pcre/pcre.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:39:12 +0000 (11:39 +0000)]
2007-11-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Give consistent naming to the RegExp options/compile flags

        * pcre/pcre_compile.cpp:
        (compile_branch):
        (is_anchored):
        (find_firstassertedchar):
        (printCompiledRegExp):
        (jsRegExpCompile):
        * pcre/pcre_exec.cpp:
        (jsRegExpExecute):
        * pcre/pcre_internal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:38:26 +0000 (11:38 +0000)]
2007-11-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Give consistent naming to the RegExp options/compile flags

        * pcre/pcre_compile.cpp:
        (compile_branch):
        (is_anchored):
        (find_firstassertedchar):
        (printCompiledRegExp):
        (jsRegExpCompile):
        * pcre/pcre_exec.cpp:
        (jsRegExpExecute):
        * pcre/pcre_internal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:37:40 +0000 (11:37 +0000)]
2007-11-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Pull first_byte and req_byte optimizations out into separate static funtions, SunSpider reported this as a win.

        * pcre/pcre_exec.cpp:
        (tryFirstByteOptimization):
        (tryRequiredByteOptimization):
        (jsRegExpExecute):
        * pcre/pcre_internal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:37:08 +0000 (11:37 +0000)]
2007-11-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej.

        give PCRE_MULTILINE a better name: OptionMatchAcrossMultipleLines

        * pcre/pcre_compile.cpp:
        (compile_branch):
        (is_anchored):
        (printCompiledRegExp):
        (jsRegExpCompile):
        * pcre/pcre_exec.cpp:
        (jsRegExpExecute):
        * pcre/pcre_internal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:35:37 +0000 (11:35 +0000)]
2007-11-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Oliver.

        Deprecate jsRegExpExecute's offset-vector fallback code

        * pcre/pcre_exec.cpp:
        (jsRegExpExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:34:33 +0000 (11:34 +0000)]
2007-11-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej.

        Centralize code for subjectPtr adjustments using inlines, only ever check for a single trailing surrogate (as UTF16
 only allows one), possibly fix PCRE bugs involving char classes and garbled UTF16 strings.

        * pcre/pcre_exec.cpp:
        (match):
        (jsRegExpExecute):
        * pcre/pcre_internal.h:
        (getPreviousChar):
        (movePtrToPreviousChar):
        (movePtrToNextChar):
        (movePtrToStartOfCurrentChar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:33:47 +0000 (11:33 +0000)]
2007-11-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej.

        Make cur_is_word and prev_is_word locals, and change OP_ANY to OP_ANY_CHAR for clarity

        * pcre/pcre_compile.cpp:
        (find_fixedlength):
        (compile_branch):
        (canApplyFirstCharOptimization):
        * pcre/pcre_exec.cpp:
        (match):
        * pcre/pcre_internal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:32:46 +0000 (11:32 +0000)]
2007-11-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Mitz & Maciej.

        Change _NC operators to use _IGNORING_CASE for clarity

        * pcre/pcre_compile.cpp:
        (find_fixedlength):
        (compile_branch):
        (find_firstassertedchar):
        * pcre/pcre_exec.cpp:
        (match):
        * pcre/pcre_internal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:32:01 +0000 (11:32 +0000)]
2007-11-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Mitz.

        Remove branch from return

        * pcre/pcre_compile.cpp:
        (compile_branch):
        * pcre/pcre_exec.cpp:
        (match):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:31:24 +0000 (11:31 +0000)]
2007-11-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej.

        Add repeatInformationFromInstructionOffset inline

        * pcre/pcre_exec.cpp:
        (repeatInformationFromInstructionOffset):
        (match):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:30:52 +0000 (11:30 +0000)]
2007-11-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej.

        Remove no longer used error code JSRegExpErrorMatchLimit

        * kjs/regexp.cpp:
        (KJS::RegExp::match):
        * pcre/pcre.h:
        * pcre/pcre_internal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:30:20 +0000 (11:30 +0000)]
2007-11-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej.

        change getChar* functions to return result and push 'c' into local scopes for clarity

        * pcre/pcre_compile.cpp:
        (compile_branch):
        (calculateCompiledPatternLengthAndFlags):
        * pcre/pcre_exec.cpp:
        (match):
        * pcre/pcre_internal.h:
        (getChar):
        (getCharAndAdvance):
        (getCharAndLength):
        (getCharAndAdvanceIfSurrogate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:29:46 +0000 (11:29 +0000)]
2007-11-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Make i locally scoped for better code clarity

        * pcre/pcre_exec.cpp:
        (match):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:29:07 +0000 (11:29 +0000)]
2007-11-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Comment cleanup

        * pcre/pcre_exec.cpp:
        (match):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:28:29 +0000 (11:28 +0000)]
2007-11-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej.

        Give subjectPtr and instructionPtr sane names, reduce size of MatchFrame for a 0.2% speedup.

        * pcre/pcre_compile.cpp:
        (compile_branch):
        (calculateCompiledPatternLengthAndFlags):
        * pcre/pcre_exec.cpp:
        (match_ref):
        (MatchStack::pushNewFrame):
        (getUTF8CharAndIncrementLength):
        (match):
        * pcre/pcre_internal.h:
        (getChar):
        (getCharAndAdvance):
        (getCharAndLength):
        (getCharAndAdvanceIfSurrogate):
        * pcre/pcre_xclass.cpp:
        (getUTF8CharAndAdvancePointer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:27:47 +0000 (11:27 +0000)]
2007-11-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Small speedup (0.7%) by simplifying canUseStackBufferForNextFrame() check

        * pcre/pcre_exec.cpp:
        (MatchStack::MatchStack):
        (MatchStack::popCurrentFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:27:11 +0000 (11:27 +0000)]
2007-11-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Lower MATCH_LIMIT_RECURSION to more sane levels to prevent hangs on run-javascriptcore-tests

        * pcre/pcre_internal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:26:33 +0000 (11:26 +0000)]
2007-11-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej.

        Remove match_is_group variable for another 5% speedup

        * pcre/pcre_compile.cpp:
        * pcre/pcre_exec.cpp:
        (startNewGroup):
        (match):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:25:55 +0000 (11:25 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Remove redundant eptrblock struct

        * pcre/pcre_exec.cpp:
        (MatchStack::pushNewFrame):
        (match):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:25:16 +0000 (11:25 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej.

        Remove redundant match_call_count and move recursion check out of super-hot code path
        SunSpider says this is at least an 8% speedup for regexp.

        * pcre/pcre_exec.cpp:
        (MatchStack::MatchStack):
        (MatchStack::pushNewFrame):
        (MatchStack::popCurrentFrame):
        (MatchStack::popAllFrames):
        (match):
        (jsRegExpExecute):
        * pcre/pcre_internal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:24:39 +0000 (11:24 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Get rid of GETCHAR* macros, replacing them with better named inlines

        * pcre/pcre_compile.cpp:
        (compile_branch):
        (calculateCompiledPatternLengthAndFlags):
        * pcre/pcre_exec.cpp:
        (match):
        * pcre/pcre_internal.h:
        (getCharAndAdvance):
        (getCharAndLength):
        (getCharAndAdvanceIfSurrogate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:24:00 +0000 (11:24 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Further cleanup GET/PUT inlines

        * pcre/pcre_internal.h:
        (putOpcodeValueAtOffset):
        (getOpcodeValueAtOffset):
        (putOpcodeValueAtOffsetAndAdvance):
        (put2ByteOpcodeValueAtOffset):
        (get2ByteOpcodeValueAtOffset):
        (put2ByteOpcodeValueAtOffsetAndAdvance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:23:11 +0000 (11:23 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Give GET, PUT better names, and add (poor) moveOpcodePtrPastAnyAlternateBranches

        * pcre/pcre_compile.cpp:
        (firstSignificantOpCodeSkippingAssertions):
        (find_fixedlength):
        (complete_callout):
        (compile_branch):
        (compile_regex):
        (is_anchored):
        (canApplyFirstCharOptimization):
        (find_firstassertedchar):
        * pcre/pcre_exec.cpp:
        (match):
        * pcre/pcre_internal.h:
        (putOpcodeValueAtOffset):
        (getOpcodeValueAtOffset):
        (putOpcodeValueAtOffsetAndAdvance):
        (put2ByteOpcodeValueAtOffset):
        (get2ByteOpcodeValueAtOffset):
        (moveOpcodePtrPastAnyAlternateBranches):
        * pcre/pcre_ucp_searchfuncs.cpp:
        (_pcre_ucp_othercase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:22:30 +0000 (11:22 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Add inlines for toLowerCase, isWordChar, isSpaceChar for further regexp speedup

        * pcre/pcre_compile.cpp:
        (compile_branch):
        (jsRegExpCompile):
        * pcre/pcre_exec.cpp:
        (match):
        (jsRegExpExecute):
        * pcre/pcre_internal.h:
        (toLowerCase):
        (flipCase):
        (classBitmapForChar):
        (charTypeForChar):
        (isWordChar):
        (isSpaceChar):
        (CompileData::CompileData):
        * pcre/pcre_xclass.cpp:
        (_pcre_xclass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:21:50 +0000 (11:21 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        cleanup _pcre_ucp_othercase

        * pcre/pcre_ucp_searchfuncs.cpp:
        (_pcre_ucp_othercase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:21:07 +0000 (11:21 +0000)]
2007-11-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Abstract frame variables into locals and args

        * pcre/pcre_compile.cpp:
        (compile_branch):
        * pcre/pcre_exec.cpp:
        (match):
        * pcre/pcre_internal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:20:26 +0000 (11:20 +0000)]
2007-11-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Section off MatchData arguments into args struct

        * pcre/pcre_exec.cpp:
        (MatchStack::pushNewFrame):
        (match):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:19:42 +0000 (11:19 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        split first_significant_code into two simpler functions

        * pcre/pcre_compile.cpp:
        (firstSignificantOpCode):
        (firstSignificantOpCodeSkippingAssertions):
        (is_anchored):
        (canApplyFirstCharOptimization):
        (find_firstassertedchar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:18:59 +0000 (11:18 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        split first_significant_code into two simpler functions

        * pcre/pcre_compile.cpp:
        (firstSignificantOpCode):
        (firstSignificantOpCodeSkippingAssertions):
        (is_anchored):
        (canApplyFirstCharOptimization):
        (find_firstassertedchar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:18:16 +0000 (11:18 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        clean up is_counted_repeat

        * pcre/pcre_compile.cpp:
        (is_counted_repeat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:17:32 +0000 (11:17 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        clean up check_escape

        * pcre/pcre_compile.cpp:
        (check_escape):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:16:48 +0000 (11:16 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Reformat find_fixedlength

        * pcre/pcre_compile.cpp:
        (find_fixedlength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:16:01 +0000 (11:16 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        reformat is_anchored

        * pcre/pcre_compile.cpp:
        (is_anchored):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:15:13 +0000 (11:15 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej.

        Remove unused function could_be_empty_branch

        * pcre/pcre_compile.cpp:
        (first_significant_code):
        (find_fixedlength):
        (compile_branch):
        (canApplyFirstCharOptimization):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:14:21 +0000 (11:14 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Pass around MatchData objects by reference

        * pcre/pcre_exec.cpp:
        (pchars):
        (match_ref):
        (match):
        (jsRegExpExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:13:33 +0000 (11:13 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        give PCRE_STARTLINE a better name and rename match_data to MatchData

        * pcre/pcre_compile.cpp:
        (compile_branch):
        (canApplyFirstCharOptimization):
        (find_firstassertedchar):
        (printCompiledRegExp):
        (jsRegExpCompile):
        * pcre/pcre_exec.cpp:
        (pchars):
        (jsRegExpExecute):
        * pcre/pcre_internal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:12:11 +0000 (11:12 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Clean up find_firstassertedchar

        * pcre/pcre_compile.cpp:
        (get_othercase_range):
        (find_firstassertedchar):
        (calculateCompiledPatternLengthAndFlags):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:11:23 +0000 (11:11 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Tim Hatcher.

        Pass around CompileData& instead of CompileData*

        * pcre/pcre_compile.cpp:
        (compile_branch):
        (jsRegExpCompile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:10:33 +0000 (11:10 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Clean up compile_branch, move _pcre_ord2utf8, and rename CompileData

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * pcre/pcre_compile.cpp:
        (_pcre_ord2utf8):
        (calculateCompiledPatternLengthAndFlags):
        (jsRegExpCompile):
        * pcre/pcre_internal.h:
        * pcre/pcre_ord2utf8.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:09:42 +0000 (11:09 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        removing more macros

        * pcre/pcre_compile.cpp:
        (could_be_empty_branch):
        (compile_branch):
        (calculateCompiledPatternLengthAndFlags):
        * pcre/pcre_exec.cpp:
        (match):
        (jsRegExpExecute):
        * pcre/pcre_internal.h:
        * pcre/pcre_xclass.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:08:50 +0000 (11:08 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej.

        clean up formating in compile_branch

        * pcre/pcre_compile.cpp:
        (compile_branch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:07:57 +0000 (11:07 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Fix spacing for read_repeat_counts

        * pcre/pcre_compile.cpp:
        (read_repeat_counts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:06:57 +0000 (11:06 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        Get rid of PCRE custom char types

        * pcre/pcre_compile.cpp:
        (check_escape):
        (complete_callout):
        (compile_branch):
        (compile_regex):
        (calculateCompiledPatternLengthAndFlags):
        (jsRegExpCompile):
        * pcre/pcre_exec.cpp:
        (match_ref):
        (match):
        (jsRegExpExecute):
        * pcre/pcre_internal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:06:02 +0000 (11:06 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Sam.

        reformat get_othercase_range

        * pcre/pcre_compile.cpp:
        (get_othercase_range):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:05:07 +0000 (11:05 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej.

        Remove register keyword and more cleanup

        * pcre/pcre_compile.cpp:
        (find_fixedlength):
        (compile_branch):
        (is_anchored):
        (is_startline):
        (find_firstassertedchar):
        (calculateCompiledPatternLengthAndFlags):
        (jsRegExpCompile):
        * pcre/pcre_exec.cpp:
        (MatchStack::canUseStackBufferForNextFrame):
        (MatchStack::allocateNextFrame):
        (MatchStack::pushNewFrame):
        (MatchStack::frameIsStackAllocated):
        (MatchStack::popCurrentFrame):
        (MatchStack::unrollAnyHeapAllocatedFrames):
        (getUTF8CharAndIncrementLength):
        (match):
        (jsRegExpExecute):
        * pcre/pcre_internal.h:
        (PUT2INC):
        (isLeadingSurrogate):
        (isTrailingSurrogate):
        (decodeSurrogatePair):
        (getChar):
        * pcre/pcre_ord2utf8.cpp:
        (_pcre_ord2utf8):
        * pcre/pcre_xclass.cpp:
        (getUTF8CharAndAdvancePointer):
        (_pcre_xclass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Nov 2007 11:04:06 +0000 (11:04 +0000)]
2007-11-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej.

        Clean up jsRegExpExecute

        * pcre/pcre_compile.cpp:
        (returnError):
        (jsRegExpCompile):
        * pcre/pcre_exec.cpp:
        (jsRegExpExecute):
        * pcre/pcre_internal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix REGRESSION(r27885): Installer hits assertion failure in JavaScriptGlue.
mrowe@apple.com [Thu, 29 Nov 2007 10:16:27 +0000 (10:16 +0000)]
Fix REGRESSION(r27885): Installer hits assertion failure in JavaScriptGlue.

Reviewed by Maciej.

* JSValueWrapper.cpp:
(getThreadGlobalExecState): Set the global object on the Interpreter before using it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix an assertion failure seen on the layout tests, and when closing the window after...
mrowe@apple.com [Thu, 29 Nov 2007 09:05:32 +0000 (09:05 +0000)]
Fix an assertion failure seen on the layout tests, and when closing the window after visiting <coudal.com/losalamos/>.

Reviewed by Oliver Hunt.

* Plugins/WebBaseNetscapePluginStream.mm:
(-[WebBaseNetscapePluginStream _destroyStream]): Unlink the file and close the file
descriptor even when the stream is being destroyed without the load completing. This
avoids leaking the path and file descriptor, and leaving the temporary file on disk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMerging updated system alloc and spinlock code from r38 of TCMalloc.
oliver@apple.com [Thu, 29 Nov 2007 08:46:14 +0000 (08:46 +0000)]
Merging updated system alloc and spinlock code from r38 of TCMalloc.

Reviewed by Geoff

This is needed as a precursor to the merge of TCMalloc proper.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUnreviewed layout test fix. Fix typos in the name of four files used by HTTP layout...
mrowe@apple.com [Thu, 29 Nov 2007 06:20:35 +0000 (06:20 +0000)]
Unreviewed layout test fix.  Fix typos in the name of four files used by HTTP layout tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
antti@apple.com [Thu, 29 Nov 2007 06:07:20 +0000 (06:07 +0000)]
WebCore:

        Reviewed by Geoff.

        Fallback content inside media elements should not be rendered.

        Test: media/fallback.html

        * rendering/RenderMedia.h:
        (WebCore::RenderMedia::canHaveChildren):

LayoutTests:

        Reviewed by Geoff.

        Test that fallback content inside media elements is not be rendered.

        * media/fallback-expected.txt: Added.
        * media/fallback.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff
beidson@apple.com [Thu, 29 Nov 2007 06:04:21 +0000 (06:04 +0000)]
    Reviewed by Geoff

        Add copyKeysToVector utility, mirroring copyValuesToVector
        Also change the copyValuesToVector implementation to be a little more attractive

        * wtf/HashMap.h:
        (WTF::copyKeysToVector):
        (WTF::copyValuesToVector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWindows build fix.
mrowe@apple.com [Thu, 29 Nov 2007 05:33:22 +0000 (05:33 +0000)]
Windows build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoGtk build fix.
mrowe@apple.com [Thu, 29 Nov 2007 05:29:56 +0000 (05:29 +0000)]
Gtk build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver.
antti@apple.com [Thu, 29 Nov 2007 04:50:24 +0000 (04:50 +0000)]
    Reviewed by Oliver.

        Make QTMovieView fill color transparent. This behavior matches the specification
        (and allows nice alpha blended video).

        * platform/graphics/mac/MoviePrivateQTKit.mm:
        (WebCore::MoviePrivate::createQTMovieView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago just some more typo fixes
alice.liu@apple.com [Thu, 29 Nov 2007 02:25:10 +0000 (02:25 +0000)]
    just some more typo fixes

        * http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame-2-level-expected.txt:
        * http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame-2-level.html:
        * http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-from-javscript-url-expected.txt:
        * http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-from-javscript-url.html:
        * http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level-expected.txt:
        * http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level.html:
        * http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-expected.txt:
        * http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame.html:
        * http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe-expected.txt:
        * http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe.html:
        * http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open-expected.txt:
        * http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open.html:
        * http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe-expected.txt:
        * http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe.html:
        * http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open-expected.txt:
        * http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
antti@apple.com [Thu, 29 Nov 2007 02:02:11 +0000 (02:02 +0000)]
WebCore:

        Reviewed by Darin.

        Test: media/video-controls.html

        <rdar://problem/5605668>
        Implement controls attribute for video element

        - Add RenderMedia and make RenderVideo its subclass. Controls code goes to RenderMedia while
          video specific (painting etc) code stays in RenderVideo. For example audio controls can be implemented
          later by just instantiating RenderMedia as renderer.
        - Make media renderer hierarchy inherit from RenderBlock instead of RenderReplaced so it can
          have child nodes (for controls).
        - Controls are implemented as a shadow DOM.
        - Current look is a placeholder. It is defined purely in CSS.
        - Some things like volume controls are not yet implemented.
        - Fade-in/out is done manually, CSS animations don't work well in shadow trees.

        * WebCore.xcodeproj/project.pbxproj:
        * css/html4.css:
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::attributeChanged):
        (WebCore::HTMLMediaElement::updateMovie):
        (WebCore::HTMLMediaElement::defaultEventHandler):
        * html/HTMLMediaElement.h:
        * rendering/RenderMedia.cpp: Added.
        (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
        (WebCore::MediaControlShadowRootElement::isShadowNode):
        (WebCore::MediaControlShadowRootElement::shadowParentNode):
        (WebCore::MediaControlInputElement::MediaControlInputElement):
        (WebCore::MediaControlInputElement::attachToParent):
        (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
        (WebCore::MediaControlPlayButtonElement::inPausedState):
        (WebCore::MediaControlPlayButtonElement::defaultEventHandler):
        (WebCore::MediaControlPlayButtonElement::update):
        (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
        (WebCore::MediaControlTimelineElement::defaultEventHandler):
        (WebCore::MediaControlTimelineElement::update):
        (WebCore::RenderMedia::RenderMedia):
        (WebCore::RenderMedia::~RenderMedia):
        (WebCore::RenderMedia::mediaElement):
        (WebCore::RenderMedia::movie):
        (WebCore::RenderMedia::setStyle):
        (WebCore::RenderMedia::createControlsShadowRoot):
        (WebCore::RenderMedia::createPanel):
        (WebCore::RenderMedia::createPlayButton):
        (WebCore::RenderMedia::createTimeline):
        (WebCore::RenderMedia::createTimeDisplay):
        (WebCore::RenderMedia::updateFromElement):
        (WebCore::RenderMedia::updateControls):
        (WebCore::RenderMedia::timeUpdateTimerFired):
        (WebCore::RenderMedia::updateTimeDisplay):
        (WebCore::RenderMedia::updateControlVisibility):
        (WebCore::RenderMedia::changeOpacity):
        (WebCore::RenderMedia::opacityAnimationTimerFired):
        (WebCore::RenderMedia::forwardEvent):
        * rendering/RenderMedia.h: Added.
        (WebCore::RenderMedia::renderName):
        (WebCore::RenderMedia::isMedia):
        (WebCore::RenderMedia::intrinsicSize):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isMedia):
        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::RenderVideo):
        (WebCore::RenderVideo::videoSizeChanged):
        (WebCore::RenderVideo::paintObject):
        (WebCore::RenderVideo::layout):
        (WebCore::RenderVideo::updateFromElement):
        (WebCore::RenderVideo::calcAspectRatioWidth):
        (WebCore::RenderVideo::calcAspectRatioHeight):
        * rendering/RenderVideo.h:

LayoutTests:

        Reviewed by Darin.

        <rdar://problem/5605668>
        Implement controls attribute for video element

        - A new test for the controls attribute.
        - Add the controls attibute to all existing video tests. This will give the code
          some additional exercise without affecting test results.

        * media/progress-event.html:
        * media/video-append-source.html:
        * media/video-autoplay.html:
        * media/video-buffered.html:
        * media/video-controls-expected.txt: Added.
        * media/video-controls.html: Added.
        * media/video-currentTime-set.html:
        * media/video-currentTime-set2.html:
        * media/video-currentTime.html:
        * media/video-dom-autoplay.html:
        * media/video-dom-end.html:
        * media/video-dom-loopcount.html:
        * media/video-dom-loopend.html:
        * media/video-dom-loopstart.html:
        * media/video-dom-src.html:
        * media/video-dom-start.html:
        * media/video-end.html:
        * media/video-error-abort.html:
        * media/video-error-does-not-exist.html:
        * media/video-load-networkState.html:
        * media/video-load-readyState.html:
        * media/video-loopcount.html:
        * media/video-loopend.html:
        * media/video-loopstart.html:
        * media/video-muted.html:
        * media/video-no-autoplay.html:
        * media/video-pause-empty-events.html:
        * media/video-play-empty-events.html:
        * media/video-play-pause-events.html:
        * media/video-play-pause-exception.html:
        * media/video-poster.html:
        * media/video-seek-past-end-paused.html:
        * media/video-seek-past-end-playing.html:
        * media/video-seekable.html:
        * media/video-seeking.html:
        * media/video-size.html:
        * media/video-source-media.html:
        * media/video-source-type.html:
        * media/video-source.html:
        * media/video-src-change.html:
        * media/video-src-remove.html:
        * media/video-src-set.html:
        * media/video-src-source.html:
        * media/video-src.html:
        * media/video-start.html:
        * media/video-volume.html:
        * media/video-width-height.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justin.garcia@apple.com [Thu, 29 Nov 2007 01:33:52 +0000 (01:33 +0000)]
WebCore:

        Reviewed by Darin Adler.

        <rdar://problem/5573879> GMail Beta: Crash in when undoing Remove Formating

        In the new beta, Google has added some custom code on top of our RemoveFormat
        to work around a bug where fully selected lists aren't removed.  This code corrupts
        the undo stack and causes crashes.  This change fixes two problems with RemoveFormat
        so that Google doesn't have to have any custom code. After checking this in I'll
        work on bulletproofing the undo stack

        * WebCore.xcodeproj/project.pbxproj:
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::insertLineBreak): Added this convenience method.
        (WebCore::CompositeEditCommand::inputText): Added code to select all inserted text, not
        just the last paragraph.  Added code to support an input string with '\n's.
        * editing/CompositeEditCommand.h:
        * editing/Editor.cpp:
        (WebCore::Editor::removeFormattingAndStyle): Moved code to its own EditCommand.
        * editing/RemoveFormatCommand.cpp: Added. Moved code from removeFormattingAndStyle here.
        (WebCore::RemoveFormatCommand::RemoveFormatCommand):
        (WebCore::RemoveFormatCommand::doApply): Added code to remove fully selected lists.
        * editing/RemoveFormatCommand.h: Added.
        (WebCore::RemoveFormatCommand::editingAction):

LayoutTests:

        Reviewed by Darin Adler.

        <rdar://problem/5573879> GMail Beta: Crash in when undoing Remove Formating

        Added to demonstrate fixes:
        * editing/execCommand/5573879.html: Added.
        * platform/mac/editing/execCommand/5573879-expected.checksum: Added.
        * platform/mac/editing/execCommand/5573879-expected.png: Added.
        * platform/mac/editing/execCommand/5573879-expected.txt: Added.

        Fixes (RemoveFormat now preserves the selection correctly):
        * platform/mac/editing/execCommand/4920742-1-expected.checksum:
        * platform/mac/editing/execCommand/4920742-1-expected.png:
        * platform/mac/editing/execCommand/4920742-1-expected.txt:
        * platform/mac/editing/execCommand/remove-formatting-2-expected.checksum:
        * platform/mac/editing/execCommand/remove-formatting-2-expected.png:
        * platform/mac/editing/execCommand/remove-formatting-2-expected.txt:
        * platform/mac/editing/execCommand/remove-formatting-expected.checksum:
        * platform/mac/editing/execCommand/remove-formatting-expected.png:
        * platform/mac/editing/execCommand/remove-formatting-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Make this test not depend on the screen size.
timothy@apple.com [Thu, 29 Nov 2007 01:05:47 +0000 (01:05 +0000)]
    Make this test not depend on the screen size.

        * fast/dom/Window/window-resize-expected.txt:
        * fast/dom/Window/window-resize.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben.
darin@apple.com [Thu, 29 Nov 2007 00:43:14 +0000 (00:43 +0000)]
    Reviewed by Adam Roben.

        * DumpRenderTree/mac/EventSendingController.mm:
        (-[EventSendingController keyDown:withModifiers:]):
        Send capital letters through as lowercase letters with the shift key down
        rather than sending them as if they were highly unusual "capital letter keys".

        * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
        where you need to update results and more tests are failing than before.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
andersca@apple.com [Thu, 29 Nov 2007 00:33:33 +0000 (00:33 +0000)]
WebKitTools:

        Reviewed by Darin.

        <rdar://problem/5132001>
        contextClick is not implemented in DRT on Windows.

        * DumpRenderTree/win/EventSender.cpp:
        (contextClickCallback):
        Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
        by a WM_RBUTTONUP message.

        * DumpRenderTree/win/UIDelegate.cpp:
        (UIDelegate::hasCustomMenuImplementation):
        (UIDelegate::trackCustomPopupMenu):
        * DumpRenderTree/win/UIDelegate.h:
        Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
        menu from being shown (and causing the DRT to hang).

LayoutTests:

        Reviewed by Darin.

        <rdar://problem/5132001>
        contextClick is not implemented in DRT on Windows.

        Remove tests that pass now that we have contextClick.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Removing some tests tracked by <rdar://5130762> because they don't fail.
alice.liu@apple.com [Wed, 28 Nov 2007 23:05:21 +0000 (23:05 +0000)]
    Removing some tests tracked by <rdar://5130762> because they don't fail.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Removing fixed tests tracked by <rdar://5128229>
alice.liu@apple.com [Wed, 28 Nov 2007 22:45:10 +0000 (22:45 +0000)]
    Removing fixed tests tracked by <rdar://5128229>

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubberstamped by Sam.
alice.liu@apple.com [Wed, 28 Nov 2007 22:27:48 +0000 (22:27 +0000)]
    Rubberstamped by Sam.

        Fixing a typo in some filenames

        * http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe-expected.txt: Removed.
        * http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe.html: Removed.
        * http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open-expected.txt: Removed.
        * http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open.html: Removed.
        * http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe-expected.txt.
        * http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe.html: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe.html.
        * http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open-expected.txt.
        * http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open.html: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open.html.
        * http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe-expected.txt: Removed.
        * http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe.html: Removed.
        * http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open-expected.txt: Removed.
        * http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open.html: Removed.
        * http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe-expected.txt.
        * http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe.html: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe.html.
        * http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open-expected.txt.
        * http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open.html: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open.html.
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim.
kmccullough@apple.com [Wed, 28 Nov 2007 22:24:49 +0000 (22:24 +0000)]
    Reviewed by Tim.

        - Added guards to the wait loop so execution would not hang and now the
        console window can process JavaScript.

        * WebScriptDebugServer.cpp:
        (WebScriptDebugServer::suspendProcessIfPaused):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Wed, 28 Nov 2007 22:04:44 +0000 (22:04 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5612459> CrashTracer: [REGRESSION] 61 crashes in Safari at com.apple.WebCore: WebCore::AutoTableLayout::layout + 2046

        Test: fast/table/empty-auto-column-zero-divide.html

        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::recalcColumn):
        (WebCore::AutoTableLayout::fullRecalc):
        (WebCore::AutoTableLayout::calcEffectiveWidth):
        (WebCore::AutoTableLayout::layout): When distributing the remaining
        width among columns, skip those whose effective (rather than
        specified) width is auto and contain only empty cells.

LayoutTests:

        Reviewed by Dave Hyatt.

        - test for <rdar://problem/5612459> CrashTracer: [REGRESSION] 61 crashes in Safari at com.apple.WebCore: WebCore::AutoTableLayout::layout + 2046

        * fast/table/empty-auto-column-zero-divide-expected.txt: Added.
        * fast/table/empty-auto-column-zero-divide.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
adele@apple.com [Wed, 28 Nov 2007 22:03:40 +0000 (22:03 +0000)]
    Reviewed by Darin.

        Fix for <rdar://problem/5524216> CrashTracer: [USER] 496 crashes in Safari at com.apple.WebCore: WebCore::Frame::eventHandler const + 6

        The CrashTracer shows a variety of crashes in different methods (including keyDown and keyUp). This change adds nil checks for the frame in
        WebHTMLView to prevent future problems in other methods as well.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
        (-[WebHTMLView keyDown:]):
        (-[WebHTMLView keyUp:]):
        (-[WebHTMLView flagsChanged:]):
        (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
        (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
        (-[WebHTMLView checkSpelling:]):
        (-[WebHTMLView showGuessPanel:]):
        (-[WebHTMLView indent:]):
        (-[WebHTMLView outdent:]):
        (-[WebHTMLView paste:]):
        (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
        (-[WebHTMLView insertText:]):
        (-[WebHTMLView selectionTextRects]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
andersca@apple.com [Wed, 28 Nov 2007 21:17:59 +0000 (21:17 +0000)]
    Reviewed by Adam.

        Implement the last bits of the WebDatabaseManager API.

        * Interfaces/IWebDatabaseManager.idl:
        * WebDatabaseManager.cpp:
        (isEqual):
        (WebDatabaseManager::sharedWebDatabaseManager):
        (WebDatabaseManager::dispatchDidModifyOrigin):
        (WebDatabaseManager::dispatchDidModifyDatabase):
        * WebDatabaseManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Get Drosera working again for real.
andersca@apple.com [Wed, 28 Nov 2007 20:12:17 +0000 (20:12 +0000)]
    Get Drosera working again for real.

        * COMEnumVariant.h:
        (::Next):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-28 Peter Kasting <zerodpx@gmail.com>
alp@webkit.org [Wed, 28 Nov 2007 19:57:31 +0000 (19:57 +0000)]
2007-11-28  Peter Kasting  <zerodpx@gmail.com>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=16169
        GIF decoder needs to set hasAlpha() correctly on subsequent frames.

        This also removes the workaround for this problem in
        ImageSourceCairo.cpp.

        * platform/graphics/cairo/ImageSourceCairo.cpp:
        (WebCore::ImageSource::frameHasAlphaAtIndex):
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::initFrameBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-28 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Wed, 28 Nov 2007 19:37:33 +0000 (19:37 +0000)]
2007-11-28  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Dan.

        <rdar://problem/5507360> plugins/return-error-from-new-stream-callback-
        in-full-frame-plugin.html is crashing

        Alice fixed this in r28046

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej and Adam.
kmccullough@apple.com [Wed, 28 Nov 2007 17:46:51 +0000 (17:46 +0000)]
    Reviewed by Maciej and Adam.

        - Added Drosera to the WebKit project.

        * WebKit.vcproj/WebKit.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler and Adam Roben.
mitz@apple.com [Wed, 28 Nov 2007 16:47:39 +0000 (16:47 +0000)]
    Reviewed by Darin Adler and Adam Roben.

        - <rdar://problem/5057218> Reenable "recent searches" search field menu when menu is fully implemented

        * platform/win/SearchPopupMenuWin.cpp:
        (WebCore::SearchPopupMenu::enabled): Changed to return true.
        (WebCore::autosaveKey): Added. Returns a preferences key for the
        autosave name by prefixing it with "com.apple.WebKit.searchField:".
        (WebCore::SearchPopupMenu::saveRecentSearches): Implemented.
        (WebCore::SearchPopupMenu::loadRecentSearches): Implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRoll out r28106 and r28108. These introduced a frequent assertion failure on page...
mrowe@apple.com [Wed, 28 Nov 2007 13:12:03 +0000 (13:12 +0000)]
Roll out r28106 and r28108.  These introduced a frequent assertion failure on page load and broke all non-Mac builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-28 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 28 Nov 2007 12:47:37 +0000 (12:47 +0000)]
2007-11-28  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        http://bugs.webkit.org/show_bug.cgi?id=15689
        [GTK] Background of loading images is always black

        frameHasAlphaAtIndex() exists only to allow optimization for cases we
        are certain the image can be blitted rather than composited.

        Thus we need to be conservative, returning false only when we are
        absolutely certain there is no need for composited copying, and true
        otherwise.

        CG doesn't even bother with this optimization at all and always
        returns true.

        Patch includes a workaround for
          http://bugs.webkit.org/show_bug.cgi?id=16169
          GIF ImageDecoder hasAlpha() return value incorrect

        * platform/graphics/cairo/ImageSourceCairo.cpp:
        (WebCore::ImageSource::frameHasAlphaAtIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
mjs@apple.com [Wed, 28 Nov 2007 11:03:10 +0000 (11:03 +0000)]
JavaScriptCore:

        Add files missing from previous commit.

        * kjs/MarkStack.h: Added.

LayoutTests:

        add files missing from previous commit.

        * fast/js/gc-breadth-2-expected.txt: Added.
        * fast/js/gc-breadth-2.html: Added.
        * fast/js/gc-breadth-expected.txt: Added.
        * fast/js/gc-breadth.html: Added.
        * fast/js/gc-depth-expected.txt: Added.
        * fast/js/gc-depth.html: Added.
        * fast/js/resources/gc-breadth-2.js: Added.
        * fast/js/resources/gc-breadth.js: Added.
        * fast/js/resources/gc-depth.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-26 Rodney Dawes <dobey@wayofthemonkey.com>
mrowe@apple.com [Wed, 28 Nov 2007 10:42:20 +0000 (10:42 +0000)]
2007-11-26  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Mark Rowe.

        Set CONFIG option for the window system GTK+ is using

        * WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
mjs@apple.com [Wed, 28 Nov 2007 10:08:09 +0000 (10:08 +0000)]
JavaScriptCore:

        Reviewed by Darin and Geoff.

        - Fixed "Stack overflow crash in JavaScript garbage collector mark pass"
        http://bugs.webkit.org/show_bug.cgi?id=12216

        Implement mark stack. This version is not suitable for prime time because it makes a
        huge allocation on every collect, and potentially makes marking of detached subtrees
        slow. But it is an 0.4% SunSpider speedup even without much tweaking.

        The basic approach is to replace mark() methods with
        markChildren(MarkStack&) methods. Reachable references are pushed
        onto a mark stack (which encapsulates ignoring already-marked
        references).

        Objects are no longer responsible for actually setting their own
        mark bits, the collector does that. This means that for objects on
        the number heap we don't have to call markChildren() at all since
        we know there aren't any.

        The mark phase of collect pushes roots onto the mark stack
        and drains it as often as possible.

        To make this approach viable requires a constant-size mark stack
        and a slow fallback approach for when the stack size is exceeded,
        plus optimizations to make the required stack small in common
        cases. This should be doable.

        * JavaScriptCore.exp: Export new symbols.
        * JavaScriptCore.xcodeproj/project.pbxproj: Add new file.
        * kjs/collector.cpp:
        (KJS::Collector::heapAllocate):
        (KJS::drainMarkStack): Helper for all of the below.
        (KJS::Collector::markStackObjectsConservatively): Use mark stack.
        (KJS::Collector::markCurrentThreadConservatively): ditto
        (KJS::Collector::markOtherThreadConservatively): ditto
        (KJS::Collector::markProtectedObjects): ditto
        (KJS::Collector::markMainThreadOnlyObjects): ditto
        (KJS::Collector::collect): ditto
        * kjs/collector.h:
        (KJS::Collector::cellMayHaveRefs): Helper for MarkStack.

        * kjs/MarkStack.h: Added. The actual mark stack implementation.
        (KJS::MarkStack::push):
        (KJS::MarkStack::pushAtom):
        (KJS::MarkStack::pop):
        (KJS::MarkStack::isEmpty):
        (KJS::MarkStack::reserveCapacity):

        Changed mark() methods to markChildren() methods:

        * kjs/ExecState.cpp:
        (KJS::ExecState::markChildren):
        * kjs/ExecState.h:
        * kjs/JSWrapperObject.cpp:
        (KJS::JSWrapperObject::markChildren):
        * kjs/JSWrapperObject.h:
        * kjs/array_instance.cpp:
        (KJS::ArrayInstance::markChildren):
        * kjs/array_instance.h:
        * kjs/bool_object.cpp:
        (BooleanInstance::markChildren):
        * kjs/bool_object.h:
        * kjs/error_object.cpp:
        * kjs/error_object.h:
        * kjs/function.cpp:
        (KJS::FunctionImp::markChildren):
        (KJS::Arguments::Arguments):
        (KJS::Arguments::markChildren):
        (KJS::ActivationImp::markChildren):
        * kjs/function.h:
        * kjs/internal.cpp:
        (KJS::GetterSetterImp::markChildren):
        * kjs/interpreter.cpp:
        (KJS::Interpreter::markRoots):
        * kjs/interpreter.h:
        * kjs/list.cpp:
        (KJS::List::markProtectedListsSlowCase):
        * kjs/list.h:
        (KJS::List::markProtectedLists):
        * kjs/object.cpp:
        (KJS::JSObject::markChildren):
        * kjs/object.h:
        (KJS::ScopeChain::markChildren):
        * kjs/property_map.cpp:
        (KJS::PropertyMap::markChildren):
        * kjs/property_map.h:
        * kjs/scope_chain.h:
        * kjs/string_object.cpp:
        (KJS::StringInstance::markChildren):
        * kjs/string_object.h:

JavaScriptGlue:

        Reviewed by Darin and Geoff.

        Fixups for JavaScriptCore mark stack.

        * JSObject.cpp:
        (JSUserObject::Mark):
        * JSObject.h:
        * JSValueWrapper.cpp:
        (JSValueWrapper::JSObjectMark):
        * JSValueWrapper.h:
        * UserObjectImp.cpp:
        * UserObjectImp.h:

WebCore:

        Reviewed by Darin and Geoff.

        Implement mark stack. This version is not suitable for prime time because it makes a
        huge allocation on every collect, and potentially makes marking of detached subtrees
        slow. But it is a .2% - .4% speedup even without much tweaking.

        I replaced mark() methods with markChildren() as usual. One
        optimization that is lost is avoiding walking detached DOM
        subtrees more than once to mark them; since marking is not
        recursive there's no obvious way to bracket operation on the tree
        any more.

        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::markChildren):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::markChildren):
        * bindings/js/JSNodeFilterCondition.cpp:
        * bindings/js/JSNodeFilterCondition.h:
        * bindings/js/JSNodeFilterCustom.cpp:
        (WebCore::JSNodeFilter::markChildren):
        * bindings/js/JSNodeIteratorCustom.cpp:
        (WebCore::JSNodeIterator::markChildren):
        * bindings/js/JSTreeWalkerCustom.cpp:
        (WebCore::JSTreeWalker::markChildren):
        * bindings/js/JSXMLHttpRequest.cpp:
        (KJS::JSXMLHttpRequest::markChildren):
        * bindings/js/JSXMLHttpRequest.h:
        * bindings/js/kjs_binding.cpp:
        (KJS::ScriptInterpreter::markDOMNodesForDocument):
        * bindings/js/kjs_binding.h:
        * bindings/js/kjs_events.cpp:
        (WebCore::JSUnprotectedEventListener::markChildren):
        * bindings/js/kjs_events.h:
        * bindings/js/kjs_window.cpp:
        (KJS::Window::markChildren):
        * bindings/js/kjs_window.h:
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Node.cpp:
        (WebCore::Node::Node):
        * dom/Node.h:
        * dom/NodeFilter.h:
        * dom/NodeFilterCondition.h:

LayoutTests:

        Not reviewed.

        - Test cases for "Stack overflow crash in JavaScript garbage collector mark pass"
        http://bugs.webkit.org/show_bug.cgi?id=12216

        I have fixed this with the mark stack work.

        * fast/js/gc-breadth-2-expected.txt: Added.
        * fast/js/gc-breadth-2.html: Added.
        * fast/js/gc-breadth-expected.txt: Added.
        * fast/js/gc-breadth.html: Added.
        * fast/js/gc-depth-expected.txt: Added.
        * fast/js/gc-depth.html: Added.
        * fast/js/resources/gc-breadth-2.js: Added.
        * fast/js/resources/gc-breadth.js: Added.
        * fast/js/resources/gc-depth.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoNot reviewer for this patch.
mjs@apple.com [Wed, 28 Nov 2007 09:24:30 +0000 (09:24 +0000)]
Not reviewer for this patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej Stachowiak.
mitz@apple.com [Wed, 28 Nov 2007 09:04:15 +0000 (09:04 +0000)]
    Reviewed by Maciej Stachowiak.

        - fix <rdar://problem/5596160> fast/events/objc-event-api.html fails when run alone (or first)

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView setDataSource:]): This method calls addMouseMovedObserver
        because addMouseMovedObserver returns early if the dataSource
        is not nil. But if the dataSource is already set (which happens when
        a WebHTMLView is being reused) then addMouseMovedObserver must not
        be called again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-27 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 28 Nov 2007 08:27:10 +0000 (08:27 +0000)]
2007-11-27  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Install the JavaScriptCore headers as part of the GTK+ port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
bdakin@apple.com [Wed, 28 Nov 2007 06:31:28 +0000 (06:31 +0000)]
WebCore:

        Reviewed by Oliver.

        Fix for <rdar://problem/5616052> SVGs with width or height of 100%
        hang when used as a background-image (16164)

        * platform/graphics/svg/SVGImage.cpp:
        (WebCore::SVGImage::size): Use valueAsPercentage() for percents
        instead of valueInSpecifiedUnits(). valueInSpecifiedUnits()
        returns, for example, 50 for 50%, so multiplying percentages by the
        default size of 300 x 150 led to ridiculously huge dimensions for
        SVG images, and the subsequent hang.

LayoutTests:

        Reviewed by Oliver.

        Test for <rdar://problem/5616052> SVGs with width or height of 100%
        hang when used as a background-image (16164)

        * fast/images/resources/width-100-percent.svg: Added.
        * fast/images/svg-width-100p-as-background.html: Added.
        * platform/mac/fast/images/svg-width-100p-as-background-expected.checksum: Added.
        * platform/mac/fast/images/svg-width-100p-as-background-expected.png: Added.
        * platform/mac/fast/images/svg-width-100p-as-background-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Not reviewed.
mjs@apple.com [Wed, 28 Nov 2007 05:54:53 +0000 (05:54 +0000)]
    Not reviewed.

        Fix DumpRenderTree ObjC bug comparing strings.

        * DumpRenderTree/mac/ObjCController.m:
        (-[ObjCController identityIsEqual::]): Compare strings with string
        equality instead of identiy equality.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-27 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 28 Nov 2007 05:48:22 +0000 (05:48 +0000)]
2007-11-27  Alp Toker  <alp@atoker.com>

        Prospective MSVC build fix.

        Roll back dllexport/dllimport support for now.

        * API/JSBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-27 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Wed, 28 Nov 2007 04:50:45 +0000 (04:50 +0000)]
2007-11-27  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam.

        Return bool from registerWebViewWindowClass, as nothing uses the ATOM.
        Set haveRegisteredWindowClass to true

        * WebView.cpp:
        (registerWebViewWindowClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-27 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Wed, 28 Nov 2007 04:47:48 +0000 (04:47 +0000)]
2007-11-27  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam.

        Set haveRegisteredWindowClass when we register the window class.

        * plugins/win/PluginViewWin.cpp:
        (WebCore::registerPluginView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-11-27 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 28 Nov 2007 04:31:51 +0000 (04:31 +0000)]
2007-11-27  Alp Toker  <alp@atoker.com>

        Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=15569
        [gtk] GTK JavaScriptCore needs to export symbols for JSC API and WTF

        Introduce JS_EXPORT to mark symbols to be exported as public API.

        Export all public symbols in the JavaScriptCore C API.

        This matches conventions for exporting symbols set by the CF and CG
        frameworks.

        * API/JSBase.h:
        * API/JSContextRef.h:
        * API/JSObjectRef.h:
        * API/JSStringRef.h:
        * API/JSStringRefBSTR.h:
        * API/JSStringRefCF.h:
        * API/JSValueRef.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Speculative fix to get Drosera working.
andersca@apple.com [Wed, 28 Nov 2007 02:47:12 +0000 (02:47 +0000)]
    Speculative fix to get Drosera working.

        * COMEnumVariant.h:
        (::Next):
        Update the number of elements fetched correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Brady.
andersca@apple.com [Wed, 28 Nov 2007 01:34:54 +0000 (01:34 +0000)]
    Reviewed by Brady.

        * Storage/WebDatabaseManager.mm:
        * Storage/WebDatabaseManagerPrivate.h:
        * Storage/WebDatabaseTrackerClient.mm:
        (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
        (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
        * Storage/WebSecurityOrigin.mm:
        (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
        * Storage/WebSecurityOriginInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam.
timothy@apple.com [Wed, 28 Nov 2007 01:22:21 +0000 (01:22 +0000)]
    Reviewed by Sam.

        Reset the authorAndUserStylesEnabled preference
        back to YES for each test. Fixes the broken tests.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebViewToConsistentStateBeforeTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam Weinig.
timothy@apple.com [Wed, 28 Nov 2007 01:12:22 +0000 (01:12 +0000)]
    Reviewed by Sam Weinig.

        Bug 16165: Dragging the inspector toolbar should move the window
        http://bugs.webkit.org/show_bug.cgi?id=16165

        * page/inspector/DocumentPanel.js: Call the new drag functions, and cleanup code.
        * page/inspector/inspector.css: Only make the toolbar transparent in detached mode.
        * page/inspector/inspector.js: Call the new drag functions, and cleanup code. Add
          toolbar drag functions that move the window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
andersca@apple.com [Wed, 28 Nov 2007 01:12:14 +0000 (01:12 +0000)]
    Reviewed by Adam.

        Some COM cleanup.

        * CFDictionaryPropertyBag.cpp:
        (CFDictionaryPropertyBag::QueryInterface):
        * CFDictionaryPropertyBag.h:
        * WebBackForwardList.cpp:
        (WebBackForwardList::addItem):
        (WebBackForwardList::removeItem):
        * WebDownload.cpp:
        (WebDownload::initWithRequest):
        * WebFrame.cpp:
        (WebFrame::loadRequest):
        (WebFrame::initWithWebFrameView):
        (WebFrame::webHistory):
        (WebFrame::dispatchWillSendRequest):
        * WebURLAuthenticationChallenge.cpp:
        (WebURLAuthenticationChallenge::QueryInterface):
        (WebURLAuthenticationChallenge::initWithProtectionSpace):
        * WebURLAuthenticationChallenge.h:
        * WebURLAuthenticationChallengeSender.cpp:
        (WebURLAuthenticationChallengeSender::QueryInterface):
        * WebURLAuthenticationChallengeSender.h:
        * WebURLResponse.cpp:
        (WebURLResponse::QueryInterface):
        * WebURLResponse.h:
        * WebView.cpp:
        (WebView::notifyDidAddIcon):
        (WebView::goToBackForwardItem):
        (WebView::canHandleRequest):
        (WebView::loadBackForwardListFromOtherView):
        (core):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
kmccullough@apple.com [Wed, 28 Nov 2007 00:35:08 +0000 (00:35 +0000)]
    Reviewed by Adam.

        - Drosera now displays the console window, although it cannot currently
        process JavaScript.

        * Drosera/win/DebuggerClient.cpp: Shows the console window.
        (registerConsoleClass): Implemented.
        (consoleWndProc): Implemented.
        (DebuggerClient::onSize): Implemented.
        (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
        new window.
        * Drosera/win/DebuggerClient.h: Added needed method and members for
        creating and maintaining a new window.
        * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
        lines of code to more appropriate places.
        (Drosera::handleCommand):
        (Drosera::initUI):
        (Drosera::onSize):
        (Drosera::attach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add COMEnumVariant.h to the project.
andersca@apple.com [Wed, 28 Nov 2007 00:12:12 +0000 (00:12 +0000)]
    Add COMEnumVariant.h to the project.

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
andersca@apple.com [Wed, 28 Nov 2007 00:11:32 +0000 (00:11 +0000)]
    Reviewed by Adam.

        Return E_INVALIDARG if the databaseName BSTR is null;

        * WebDatabaseManager.cpp:
        (WebDatabaseManager::detailsForDatabaseWithOrigin):
        (WebDatabaseManager::deleteDatabaseWithOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
andersca@apple.com [Tue, 27 Nov 2007 23:57:43 +0000 (23:57 +0000)]
    Reviewed by Adam.

        Implement the rest of the WebDatabaseManager API.

        * COMEnumVariant.h:
        * Interfaces/IWebDatabaseManager.idl:
        * WebDatabaseManager.cpp:
        (isEqual):
        (DatabaseDetailsPropertyBag::DatabaseDetailsPropertyBag):
        (DatabaseDetailsPropertyBag::~DatabaseDetailsPropertyBag):
        (DatabaseDetailsPropertyBag::createInstance):
        (DatabaseDetailsPropertyBag::AddRef):
        (DatabaseDetailsPropertyBag::Release):
        (DatabaseDetailsPropertyBag::QueryInterface):
        (DatabaseDetailsPropertyBag::Read):
        (DatabaseDetailsPropertyBag::Write):
        (WebDatabaseManager::detailsForDatabaseWithOrigin):
        (WebDatabaseManager::deleteAllDatabases):
        (WebDatabaseManager::deleteDatabasesWithOrigin):
        (WebDatabaseManager::deleteDatabaseWithOrigin):
        * WebDatabaseManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLand results for my last test change,
timothy@apple.com [Tue, 27 Nov 2007 23:34:40 +0000 (23:34 +0000)]
Land results for my last test change,

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5616098> The BSTR returned by WebHistoryItem::alternateTitle
adachan@apple.com [Tue, 27 Nov 2007 23:32:36 +0000 (23:32 +0000)]
    <rdar://problem/5616098> The BSTR returned by WebHistoryItem::alternateTitle
        was not allocated correctly.

        Reviewed by Anders.

        * WebHistoryItem.cpp:
        (WebHistoryItem::setAlternateTitle):
        (WebHistoryItem::alternateTitle):
        * WebHistoryItem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28086 268f45cc-cd09-0410-ab3c-d52691b4dbfc