WebKit-https.git
13 years ago2008-03-06 Alp Toker <alp@atoker.com>
alp@webkit.org [Thu, 6 Mar 2008 23:11:37 +0000 (23:11 +0000)]
2008-03-06  Alp Toker  <alp@atoker.com>

        Fix the build fix in r30845 to support out-of-tree builds.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
mitz@apple.com [Thu, 6 Mar 2008 21:45:50 +0000 (21:45 +0000)]
    Reviewed by Darin Adler.

        - fix a regression from r30741: a crash under
          WebFrameLoaderClient::createPlugin() when showing a Mail message with
          an attachment

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
sfalken@apple.com [Thu, 6 Mar 2008 21:09:29 +0000 (21:09 +0000)]
    Build fix.

        * wtf/ThreadingWin.cpp:
        (WTF::ThreadCondition::timedWait):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Tiger build fix...?
beidson@apple.com [Thu, 6 Mar 2008 20:58:35 +0000 (20:58 +0000)]
    Tiger build fix...?

        * DumpRenderTree/mac/WatchdogMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - another small step towards fixing the Qt build
darin@apple.com [Thu, 6 Mar 2008 20:08:54 +0000 (20:08 +0000)]
    - another small step towards fixing the Qt build

        * JavaScriptCore.pri: Remove more references to the now-obsolete bindings directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
darin@apple.com [Thu, 6 Mar 2008 20:02:04 +0000 (20:02 +0000)]
JavaScriptCore:

        - a small step towards fixing the Qt build

        * JavaScriptCore.pri: Remove references to files no longer present in JavaScriptCore/bindings.

WebCore:

        - try to fix Wx build

        * WebCoreSources.bkl: Added PageGroup.cpp.

WebKit/mac:

        - fix Tiger build

        * History/WebHistory.mm: Added include of WebTypesInternal.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Gtk Build fix
beidson@apple.com [Thu, 6 Mar 2008 19:50:32 +0000 (19:50 +0000)]
    Gtk Build fix

        * wtf/ThreadingGtk.cpp:
        (WTF::ThreadCondition::timedWait):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Wx build fix.
ap@webkit.org [Thu, 6 Mar 2008 19:34:31 +0000 (19:34 +0000)]
    Wx build fix.

        * wtf/unicode/icu/CollatorICU.cpp:
        (WTF::Collator::userDefault): Put ICU workaround under both PLATFORM(DARWIN) and
        PLATFORM(CF) checks, so that each port can decide if it wants to use CF on Mac for it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
beidson@apple.com [Thu, 6 Mar 2008 18:55:02 +0000 (18:55 +0000)]
JavaScriptCore:

        Reviewed by Darin

        Add a timedWait() method to ThreadCondition

        * JavaScriptCore.exp:

        * wtf/Threading.h:

        * wtf/ThreadingGtk.cpp:
        (WTF::ThreadCondition::timedWait):

        * wtf/ThreadingNone.cpp:
        (WTF::ThreadCondition::timedWait):

        * wtf/ThreadingPthreads.cpp:
        (WTF::ThreadCondition::timedWait):

        * wtf/ThreadingWin.cpp:
        (WTF::ThreadCondition::timedWait): Needs implementation

WebKitTools:

        Reviewed by Darin

        Added a cross-platform Watchdog thread to DRT.

        The current watchdog in both DRTWin and DRTMac is Timer based.  Therefore, deadlocks and long running
        main thread hangs still affect DRT.

        By placing the watchdog on a thread and having DRT "check in" after each test, long-running hangs
        and true deadlocks can be caught.

        There is one hook for platform specific code.  As I did my development and testing on Mac, and Mac has
        `sample` available, the Mac implementation of this hook samples the process before it is killed.

        I arbitrarily chose 30 seconds as the timeout for now - this can be tweaked easily if we find a need.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/mac/Configurations/Base.xcconfig: Added LINKER_DISPLAYS_MANGLED_NAMES

        * DumpRenderTree/ForwardingHeaders/wtf/Locker.h: Added.
        * DumpRenderTree/ForwardingHeaders/wtf/Threading.h: Added.

        * DumpRenderTree/Watchdog.cpp: Added.
        (Watchdog::Watchdog):
        (Watchdog::~Watchdog):
        (Watchdog::start):
        (Watchdog::stop):
        (Watchdog::checkIn):
        (Watchdog::setWatchdogInterval):
        (Watchdog::handleHang):
        (Watchdog::watchdogThreadStart):
        (Watchdog::watchdogThread):
        * DumpRenderTree/Watchdog.h: Added.

        * DumpRenderTree/mac/WatchdogMac.h: Added.
        * DumpRenderTree/mac/WatchdogMac.mm: Added.
        (WatchdogMac::handleHang): Sample the process and write it out to a file

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (dumpRenderTree): Setup and start the watchdog before running any tests
        (runTest): Checkin with the watchdog after each test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago More build fixes.
ap@webkit.org [Thu, 6 Mar 2008 18:51:57 +0000 (18:51 +0000)]
    More build fixes.

        * jscore.bkl: Add the wtf/unicode directory.
        * wtf/unicode/CollatorDefault.cpp:
        (WTF::Collator::userDefault): Use a constructor that does exist.
        * wtf/unicode/icu/CollatorICU.cpp: Mac build fix for case-sensitive file systems.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - fix Release build
darin@apple.com [Thu, 6 Mar 2008 18:21:27 +0000 (18:21 +0000)]
    - fix Release build

        * History/WebHistory.mm:
        (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]): Removed underscore.
        (-[WebHistoryPrivate loadFromURL:collectDiscardedItemsInto:error:]): Added #if.
        (-[WebHistoryPrivate saveToURL:error:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - try to fix the Qt build
darin@apple.com [Thu, 6 Mar 2008 18:19:09 +0000 (18:19 +0000)]
    - try to fix the Qt build

        * JavaScriptCore.pri: Add the wtf/unicode directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - try to fix the GTK build
darin@apple.com [Thu, 6 Mar 2008 18:18:06 +0000 (18:18 +0000)]
    - try to fix the GTK build

        * GNUmakefile.am: Add a -I for the unicode directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - try to fix the Mac build
darin@apple.com [Thu, 6 Mar 2008 18:14:28 +0000 (18:14 +0000)]
    - try to fix the Mac build

        * icu/unicode/parseerr.h: Copied from ../WebCore/icu/unicode/parseerr.h.
        * icu/unicode/ucol.h: Copied from ../WebCore/icu/unicode/ucol.h.
        * icu/unicode/uloc.h: Copied from ../WebCore/icu/unicode/uloc.h.
        * icu/unicode/unorm.h: Copied from ../WebCore/icu/unicode/unorm.h.
        * icu/unicode/uset.h: Copied from ../WebCore/icu/unicode/uset.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - fix some builds
darin@apple.com [Thu, 6 Mar 2008 17:51:26 +0000 (17:51 +0000)]
    - fix some builds

        * GNUmakefile.am: Added PageGroup.cpp.
        * WebCore.base.exp: Removed WebCoreHistory.
        * WebCore.pro: Added PageGroup.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap@webkit.org [Thu, 6 Mar 2008 17:50:08 +0000 (17:50 +0000)]
    Reviewed by Darin.

        <rdar://problem/5687269> Need to create a Collator abstraction for WebCore and JavaScriptCore

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
mitz@apple.com [Thu, 6 Mar 2008 17:45:27 +0000 (17:45 +0000)]
    Reviewed by Adele.

        - add test for r30823 (background-position: inherit)

        * fast/css/background-position-inherit-expected.txt: Added.
        * fast/css/background-position-inherit.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Thu, 6 Mar 2008 17:21:55 +0000 (17:21 +0000)]
WebCore:

        Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17526
          REGRESSION: iframes are added to Safari's History menu
          by separating the visited link machinery from global history

        This should also make page loading faster due to more efficient visited link coloring.

        * WebCore.base.exp: Updated.
        * WebCore.vcproj/WebCore.vcproj: Added PageGroup.h/cpp, removed GlobalHistory.h/cpp.
        * WebCore.xcodeproj/project.pbxproj: Ditto. Also removed WebCoreHistory.h/m.

        * css/CSSStyleSelector.cpp: Updated includes.
        (WebCore::CSSStyleSelector::initElementAndPseudoState): Eliminated code to set
        currentEncodedURL.
        (WebCore::checkPseudoState): Moved most of the code inside a new
        PageGroup::isLinkVisited function.
        (WebCore::CSSStyleSelector::canShareStyleWithElement): Tightened code a bit by using
        references and only getting colors when needed.
        (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Ditto.
        * css/CSSStyleSelector.h: Removed EncodedURL, m_encodedURL, and setEncodedURL.

        * dom/Document.cpp:
        (WebCore::Document::attach): Removed call to setEncodedURL.
        (WebCore::Document::setURL): Ditto.
        (WebCore::Document::recalcStyleSelector): Ditto.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Changed code to use
        early exit idiom to be a little more readable.
        (WebCore::FrameLoader::urlsMatchItem): Change to use a reference for slightly
        better efficiency.
        (WebCore::FrameLoader::goToItem): Use early exit idiom to be a little more
        readable.
        (WebCore::FrameLoader::updateHistoryForStandardLoad): Moved history code back
        in here and got rid of the helper function updateGlobalHistory, restoring the
        logic before r30549. Also added a call to the new addVisitedLink function.
        (WebCore::FrameLoader::updateHistoryForClientRedirect): Added code to call
        addVisitedLink here.
        (WebCore::FrameLoader::updateHistoryForBackForwardNavigation): Removed comment.
        (WebCore::FrameLoader::updateHistoryForReload): Removed call to
        updateGlobalHistory; we can just go without updating global history or
        visited links here, at least for now, since it's not clear that a reload
        is a "history event".
        (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory): Moved
        history code back where it was, and added the call to addVisitedLink, just
        as in updateHistoryForStandardLoad above.
        * loader/FrameLoader.h: Removed updateGlobalHistory function.

        * page/Chrome.cpp:
        (WebCore::ChromeClient::populateVisitedLinks): Added. Empty placeholder so we
        don't have to implement this for every port all at once.
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Changed to use the
        new PageGroup class.
        * page/ChromeClient.h: Added populateVisitedLinks function, used to fill the
        visited links set from the global history at application startup time.

        * page/FrameTree.cpp:
        (WebCore::FrameTree::find): Updated to use the new PageGroup class.

        * page/GlobalHistory.h: Removed.
        * page/win/GlobalHistoryWin.cpp: Removed.
        * page/mac/GlobalHistoryMac.mm: Removed.
        * platform/mac/WebCoreHistory.h: Removed.
        * platform/mac/WebCoreHistory.m: Removed.
        * platform/win/WebCoreHistory.cpp: Removed.
        * platform/win/WebCoreHistory.h: Removed.

        * page/Page.cpp:
        (WebCore::Page::Page): Set m_group to 0.
        (WebCore::Page::setGroupName): Set up m_group. If the page is not in any
        group, set it to 0 for now to postpone the cost of creating a group.
        (WebCore::Page::initGroup): Added. Sets m_group to point to a single-page
        group; used when getting a group.
        (WebCore::Page::removeAllVisitedLinks): Added. Calls removeVisitedLinks
        on all page groups.
        * page/Page.h: Moved enums inside the WebCore namespace. Removed the
        frameNamespace function and instead added the group and groupPtr functions.

        * page/PageGroup.cpp: Added. Contains all the visited code from the
        CSSStyleSelector in the isVisitedLink function, but more efficient because
        we don't allocate memory for the buffer.
        * page/PageGroup.h: Added.

        * platform/gtk/TemporaryLinkStubs.cpp: Removed historyContains.
        * platform/qt/TemporaryLinkStubs.cpp: Removed unneeded include.
        * platform/wx/TemporaryLinkStubs.cpp: Removed historyContains.

WebKit:

        * WebKit.xcodeproj/project.pbxproj: Added WebHistoryInternal.h.

WebKit/mac:

        Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17526
          REGRESSION: iframes are added to Safari's History menu
          by separating the visited link machinery from global history

        * History/WebHistory.mm: Moved WebHistoryPrivate inside this file.
        (-[WebHistoryPrivate removeItemFromDateCaches:]): Removed the underscore from this
        method name, since it's on a private object.
        (-[WebHistoryPrivate removeItemForURLString:]): Added a call to the
        PageGroup::removeAllVisitedLinks function if the last URL was removed.
        (-[WebHistoryPrivate addItemToDateCaches:]): Removed the underscore from this
        method name, since it's on a private object.
        (-[WebHistoryPrivate removeAllItems]): Call PageGroup::removeAllVisitedLinks.
        (-[WebHistoryPrivate ageLimitDate]): Removed the underscore from this
        method name, since it's on a private object.
        (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
        Ditto.
        (-[WebHistoryPrivate saveHistoryGuts:URL:error:]): Ditto. Also changed this
        to correctly return the error by using the newer version of writeToURL: and
        removed the FIXME about that.
        (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Added. Calls addVisitedLink
        for every link in the history.
        (-[WebHistory saveToURL:error:]): Removed the FIXME, since we do get the error now.
        (-[WebHistory addItem:]): Moved into the WebPrivate category.
        (-[WebHistory addItemForURL:]): Ditto.
        (-[WebHistory _addItemForURL:title:]): Added. Used for the normal case where we
        create an item and already know its title.
        (-[WebHistory ageLimitDate]): Moved into the WebPrivate category.
        (-[WebHistory containsItemForURLString:]): Ditto.
        (-[WebHistory removeItem:]): Ditto.
        (-[WebHistory setLastVisitedTimeInterval:forItem:]): Ditto.
        (-[WebHistory _itemForURLString:]): Ditto.
        (-[WebHistory _addVisitedLinksToPageGroup:]): Added. For use only inside WebKit.

        * History/WebHistoryInternal.h: Added.
        * History/WebHistoryItemInternal.h: Tweaked formatting and includes.
        * History/WebHistoryPrivate.h: Moved the WebHistoryPrivate class out of this header.
        Also reorganized what was left behind.

        * WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks.
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::populateVisitedLinks): Added a call to the new
        -[WebHistory _addVisitedLinksToPageGroup:] method.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::updateGlobalHistory): Changed code to use the new
        -[WebHistory _addItemForURL:title:] method.

WebKit/win:

        Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17526
          REGRESSION: iframes are added to Safari's History menu
          by separating the visited link machinery from global history

        * WebCoreSupport/WebChromeClient.cpp:
        (WebChromeClient::populateVisitedLinks): Added a call to the new
        WebHistory::addVisitedLinksToPageGroup function.
        * WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks.
        Also fixed the webView function to be non-virtual.

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::updateGlobalHistory): Changed to use the
        new WebHistory::addItem function.
        (WebFrameLoaderClient::webHistory): Changed to return a WebHistory*,
        there's no reason to AddRef the result from this function.
        * WebCoreSupport/WebFrameLoaderClient.h: Ditto.

        * WebHistory.cpp: Removed IWebHistoryPrivate and _WebCoreHistoryProvider.
        (WebHistory::QueryInterface): Removed IWebHistoryPrivate.
        (sharedHistoryStorage): Added.
        (WebHistory::sharedHistory): Added.
        (WebHistory::optionalSharedHistory): Changed to use sharedHistory().
        (WebHistory::setOptionalSharedHistory): Changed to require a WebHistory
        object, not just an IWebHistory.
        (WebHistory::removeAllItems): Call PageGroup::removeAllVisitedLinks.
        (WebHistory::addItem): Changed parameter types since this is called with
        arguments from WebCore -- at some point this could allow better efficiency.
        (WebHistory::removeItemForURLString):  Call PageGroup::removeAllVisitedLinks
        if the last URL is being removed.
        (addVisitedLinkToPageGroup): Added. Helper. Adds a single link to a group's
        visited link set.
        (WebHistory::addVisitedLinksToPageGroup): Added. Adds all links to a group's
        visited link.
        * WebHistory.h: Removed IWebHistoryPrivate. Removed optionalSharedHistoryInternal
        and added sharedHistory. Replaced addItemForURL and containsItemForURLString with
        non-virtual addItem and addVisitedLinksToPageGroup functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Adam Roben.
timothy@apple.com [Thu, 6 Mar 2008 17:03:56 +0000 (17:03 +0000)]
    Rubber-stamped by Adam Roben.

        Add a simple page that has various demo functions for Drosera.

        * demos/drosera: Added.
        * demos/drosera/demo.js: Added.
        * demos/drosera/drosera.png: Added.
        * demos/drosera/index.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}
aroben@apple.com [Thu, 6 Mar 2008 16:15:28 +0000 (16:15 +0000)]
Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}

WebKit:

        Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}

        Reviewed by Kevin M.

        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

        Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}

        Reviewed by Kevin M.

        * WebView/WebFrame.mm:
        * WebView/WebScriptDebugDelegate.mm:
        * WebView/WebScriptDebugger.h: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.h.
        * WebView/WebScriptDebugger.mm: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rename WebCoreScriptDebuggerImp to WebScriptDebugger
aroben@apple.com [Thu, 6 Mar 2008 16:15:08 +0000 (16:15 +0000)]
    Rename WebCoreScriptDebuggerImp to WebScriptDebugger

        Reviewed by Kevin M.

        * WebView/WebCoreScriptDebuggerImp.h:
        * WebView/WebCoreScriptDebuggerImp.mm:
        * WebView/WebFrame.mm:
        (-[WebFrame _attachScriptDebugger]):
        * WebView/WebFrameInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove WebScriptDebugger
aroben@apple.com [Thu, 6 Mar 2008 16:14:49 +0000 (16:14 +0000)]
Remove WebScriptDebugger

WebKit:

        Remove WebScriptDebugger

        Reviewed by Kevin M.

        * WebKit.xcodeproj/project.pbxproj: Remove
        WebScriptDebugDelegatePrivate.h from the project.

WebKit/mac:

        Remove WebScriptDebugger

        Uses of WebScriptDebugger have been replaced with
        WebCoreScriptDebuggerImp.

        Reviewed by Kevin M.

        * WebView/WebFrame.mm:
        (-[WebFramePrivate dealloc]): Use delete instead of release since
        WebCoreScriptDebuggerImp is a C++ class.
        (-[WebFrame _attachScriptDebugger]): Updated to use early returns and
        WebCoreScriptDebuggerImp.
        (-[WebFrame _detachScriptDebugger]): Ditto.
        * WebView/WebFrameInternal.h:
        * WebView/WebScriptDebugDelegate.mm: Removed WebScriptDebugger
        * WebView/WebScriptDebugDelegatePrivate.h: Removed.
        * WebView/WebView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove -webFrame and -globalObject from WebScriptDebugger
aroben@apple.com [Thu, 6 Mar 2008 16:14:27 +0000 (16:14 +0000)]
Remove -webFrame and -globalObject from WebScriptDebugger

WebCore:

        Export a header/symbol for WebKit

        Reviewed by Kevin M.

        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:

WebKit/mac:

        Remove -webFrame and -globalObject from WebScriptDebugger

        WebCoreScriptDebuggerImp is now unaware of WebScriptDebugger

        Reviewed by Kevin M.

        * WebView/WebCoreScriptDebuggerImp.h: Removed WebScriptDebugger*
        parameter to the constructor.
        * WebView/WebCoreScriptDebuggerImp.mm:
        (toWebFrame): Added.
        (WebCoreScriptDebuggerImp::sourceParsed): Call toWebFrame.
        (WebCoreScriptDebuggerImp::callEvent): Ditto, and get the Frame's
        WindowScriptObject ourselves instead of asking WebScriptDebugger for
        it.
        (WebCoreScriptDebuggerImp::atStatement): Call toWebFrame.
        (WebCoreScriptDebuggerImp::returnEvent): Ditto.
        (WebCoreScriptDebuggerImp::exception): Ditto.
        * WebView/WebScriptDebugDelegate.mm:
        (-[WebScriptDebugger initWithWebFrame:]): Updated for change to
        WebScriptDebuggerImp's constructor.
        * WebView/WebScriptDebugDelegatePrivate.h: Removed
        -webFrame/-globalObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Remove -enterFrame: and -leaveFrame from WebScriptDebugger
aroben@apple.com [Thu, 6 Mar 2008 16:13:56 +0000 (16:13 +0000)]
    Remove -enterFrame: and -leaveFrame from WebScriptDebugger

        Reviewed by Kevin M.

        * WebView/WebCoreScriptDebuggerImp.h: Changed to store m_topCallFrame
        in a RetainPtr, now that WebCoreScriptDebuggerImp is in charge of its
        lifetime.
        * WebView/WebCoreScriptDebuggerImp.mm:
          - Added declaration of -[WebScriptCallFrame
            _initWithGlobalObject:caller:state:].
          - Changed most uses of m_topCallFrame to m_topCallFrame.get()
        (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Removed
        now-unnecessary initialization of m_topCallFrame.
        (WebCoreScriptDebuggerImp::callEvent): Replaced call to enterFrame:
        with its implementation. The one difference between this
        implementation and the old enterFrame: method is that we don't hand
        our reference to m_topCallFrame to _initWithGlobalObject: -- that
        method must now retain the passed-in WebScriptCallFrame manually.
        (WebCoreScriptDebuggerImp::atStatement):
        (WebCoreScriptDebuggerImp::returnEvent): Replaced call to leaveFrame
        with its implementation.
        (WebCoreScriptDebuggerImp::exception):
        * WebView/WebScriptDebugDelegate.mm: Removed declaration of
        -[WebScriptCallFrame _initWithGlobalObject:caller:state:].
        (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Changed
        to retain the passed-in caller.
        * WebView/WebScriptDebugDelegatePrivate.h:
          - Removed _current ivar
          - Removed enterFrame:/leaveFrame declarations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Remove -parsedSource: from WebScriptDebugger
aroben@apple.com [Thu, 6 Mar 2008 16:13:39 +0000 (16:13 +0000)]
    Remove -parsedSource: from WebScriptDebugger

        Reviewed by Kevin M.

        * WebView/WebCoreScriptDebuggerImp.mm:
        (WebCoreScriptDebuggerImp::sourceParsed): Moved code here from
        -[WebScriptDebugger parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]
        * WebView/WebScriptDebugDelegate.mm: Removed -parsedSource:.
        * WebView/WebScriptDebugDelegatePrivate.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Remove -enteredFrame:, -leavingFrame:, and -exceptionRaised: from WebScriptDe...
aroben@apple.com [Thu, 6 Mar 2008 16:13:23 +0000 (16:13 +0000)]
    Remove -enteredFrame:, -leavingFrame:, and -exceptionRaised: from WebScriptDebugger

        Reviewed by Kevin M.

        * WebView/WebCoreScriptDebuggerImp.mm:
        (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Changed to call
        trhough to callEvent instead of duplicating its code here.
        (WebCoreScriptDebuggerImp::callEvent): Moved code from
        -[WebScriptDebugger enteredFrame:sourceId:line:] here.
        (WebCoreScriptDebuggerImp::returnEvent): Moved code from
        -[WebScriptDebugger leavingFrame:sourceId:line:] here.
        (WebCoreScriptDebuggerImp::exception): Moved code from
        -[WebScriptDebugger exceptionRaised:sourceId:line:] here.
        * WebView/WebScriptDebugDelegate.mm: Removed -enteredFrame:,
        -leavingFrame:, and -exceptionRaised:.
        * WebView/WebScriptDebugDelegatePrivate.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Remove -[WebScriptDebugger hitStatement:sourceId:line:]
aroben@apple.com [Thu, 6 Mar 2008 16:13:08 +0000 (16:13 +0000)]
    Remove -[WebScriptDebugger hitStatement:sourceId:line:]

        Reviewed by Kevin M.

        * WebView/WebCoreScriptDebuggerImp.mm:
        (WebCoreScriptDebuggerImp::atStatement): Moved code here from
        -[WebScriptDebugger hitStatement:sourceId:line:].
        * WebView/WebScriptDebugDelegate.mm:
        (-[WebScriptDebugger webFrame]): Added.
        * WebView/WebScriptDebugDelegatePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove WebCoreScriptDebugger
aroben@apple.com [Thu, 6 Mar 2008 16:12:52 +0000 (16:12 +0000)]
Remove WebCoreScriptDebugger

WebKit:

        Remove WebCoreScriptDebugger.{h,mm}

        Reviewed by Kevin M.

        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

        Remove WebCoreScriptDebugger

        Reviewed by Kevin M.

        * WebView/WebCoreScriptDebugger.h: Removed.
        * WebView/WebCoreScriptDebugger.mm: Removed.
        * WebView/WebCoreScriptDebuggerImp.h: Replaced WebCoreScriptDebugger
        with WebScriptDebugger.
        * WebView/WebCoreScriptDebuggerImp.mm: Ditto, and replaced [m_debugger
        delegate] with just m_debugger.
        (toNSString): Moved here from WebCoreScriptDebugger.mm.
        (toNSURL): Ditto.
        (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
        (WebCoreScriptDebuggerImp::sourceParsed):
        (WebCoreScriptDebuggerImp::callEvent):
        (WebCoreScriptDebuggerImp::atStatement):
        (WebCoreScriptDebuggerImp::returnEvent):
        (WebCoreScriptDebuggerImp::exception):
        * WebView/WebScriptDebugDelegate.mm:
        (-[WebScriptDebugger initWithWebFrame:]): _debugger now holds a
        WebCoreScriptDebuggerImp, so initialize it properly.
        * WebView/WebScriptDebugDelegatePrivate.h: Changed _debugger to hold a
        WebCoreScriptDebuggerImp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMove WebCoreScriptDebuggerImp to its own source files
aroben@apple.com [Thu, 6 Mar 2008 16:12:33 +0000 (16:12 +0000)]
Move WebCoreScriptDebuggerImp to its own source files

WebKit:

        Move WebCoreScriptDebuggerImp to its own source files

        Reviewed by Kevin M.

        * WebKit.xcodeproj/project.pbxproj: Added new files to the project.

WebKit/mac:

        Move WebCoreScriptDebuggerImp to its own source files

        Also changed WebCoreScriptDebuggerImp coding style to match our style
        guidelines.

        Reviewed by Kevin M.

        * WebView/WebCoreScriptDebugger.h: Added declaration of toNSURL
        function.
        * WebView/WebCoreScriptDebugger.mm: Removed WebCoreScriptDebuggerImp
        implementation.
        (toNSURL): Made no longer static.
        * WebView/WebCoreScriptDebuggerImp.h: Added.
        * WebView/WebCoreScriptDebuggerImp.mm: Added. Code was moved here from
        WebCoreScriptDebugger.mm and cleaned up.
        (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
        (WebCoreScriptDebuggerImp::sourceParsed):
        (WebCoreScriptDebuggerImp::callEvent):
        (WebCoreScriptDebuggerImp::atStatement):
        (WebCoreScriptDebuggerImp::returnEvent):
        (WebCoreScriptDebuggerImp::exception):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move -_enterFrame and -_leaveFrame from WebCoreScriptDebugger to WebScriptDeb...
aroben@apple.com [Thu, 6 Mar 2008 16:12:14 +0000 (16:12 +0000)]
    Move -_enterFrame and -_leaveFrame from WebCoreScriptDebugger to WebScriptDebugger

        Reviewed by Kevin M.

        * WebView/WebCoreScriptDebugger.h:
          - Removed newFrameWithGlobalObject:caller:state: from
            WebScriptDebugger protocol
          - Added enterFrame: and leaveFrame: to WebScriptDebugger protocol
          - Removed _current ivar from WebCoreScriptDebugger
        * WebView/WebCoreScriptDebugger.mm:
        (WebCoreScriptDebuggerImp::callEvent): Changed to call enterFrame on
        the delegate.
        (WebCoreScriptDebuggerImp::returnEvent): Ditto for leaveFrame.
        * WebView/WebScriptDebugDelegate.mm:
        (-[WebScriptDebugger dealloc]): Added code to release _current.
        (-[WebScriptDebugger enterFrame:]): Added. Code came from
        WebCoreScriptDebugger.
        (-[WebScriptDebugger leaveFrame]): Ditto.
        * WebView/WebScriptDebugDelegatePrivate.h: Added _current ivar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Name the WebKit build phase script that generates WebKit.LP64.exp.
ddkilzer@apple.com [Thu, 6 Mar 2008 12:15:12 +0000 (12:15 +0000)]
    Name the WebKit build phase script that generates WebKit.LP64.exp.

        * WebKit.xcodeproj/project.pbxproj: Name the build phase script
        that generates the 64-bit export file to match the corresponding
        build phase script in WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix 64-bit Mac build.
mrowe@apple.com [Thu, 6 Mar 2008 09:40:57 +0000 (09:40 +0000)]
Fix 64-bit Mac build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLeopard build fix.
mrowe@apple.com [Thu, 6 Mar 2008 09:24:51 +0000 (09:24 +0000)]
Leopard build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the wx build after the bindings move.
kevino@webkit.org [Thu, 6 Mar 2008 06:26:42 +0000 (06:26 +0000)]
Fix the wx build after the bindings move.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele Peterson.
mitz@apple.com [Thu, 6 Mar 2008 06:20:53 +0000 (06:20 +0000)]
    Reviewed by Adele Peterson.

        - fix "background-position: inherit"

        * css/CSSStyleSelector.cpp:
        Made HANDLE_MULTILAYER_INHERIT_AND_INITIAL fall through and added
        a return statement in HANDLE_MULTILAYER_VALUE. Also removed an unused
        macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-05 Alp Toker <alp@atoker.com>
alp@webkit.org [Thu, 6 Mar 2008 06:18:14 +0000 (06:18 +0000)]
2008-03-05  Alp Toker  <alp@atoker.com>

        Add a missing make dependency for derived sources to improve
        autotools build dependency tracking.

        Issue spotted by Ori Bernstein.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-05 Alp Toker <alp@atoker.com>
alp@webkit.org [Thu, 6 Mar 2008 04:44:06 +0000 (04:44 +0000)]
2008-03-05  Alp Toker  <alp@atoker.com>

        GTK+ build fix for breakage introduced in r30800.

        Track moved bridge sources from JavaScriptCore to WebCore.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
justin.garcia@apple.com [Thu, 6 Mar 2008 04:07:05 +0000 (04:07 +0000)]
WebCore:

        Reviewed by Darin.

        One part of fix for:
        <rdar://problem/5780697> Copying content with percentage based rules in a style sheet will cause fidelity issues

        * editing/markup.cpp:
        (WebCore::appendStartMarkup): Styles from matched rules should take precedence over those in
        inline style declarations, not the other way around.

LayoutTests:

        Reviewed by Darin.

        <rdar://problem/5780697> Copying content with CSS property values that are percentages can cause fidelity issues

        * editing/pasteboard/5780697-1-expected.txt: Added.
        * editing/pasteboard/5780697-1.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAnother buildbot fix attempt, pass SHELL=/bin/bash
alp@webkit.org [Thu, 6 Mar 2008 04:02:25 +0000 (04:02 +0000)]
Another buildbot fix attempt, pass SHELL=/bin/bash

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-05 Alp Toker <alp@atoker.com>
alp@webkit.org [Thu, 6 Mar 2008 03:49:21 +0000 (03:49 +0000)]
2008-03-05  Alp Toker  <alp@atoker.com>

        Attempt to get the autotools build working again on the bot with
        build-webkit.

        Force the use of /bin/bash since we seem to have bash-isms in the
        configure script right now.

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix typo in ChangeLog.
mrowe@apple.com [Thu, 6 Mar 2008 02:21:36 +0000 (02:21 +0000)]
Fix typo in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
andersca@apple.com [Thu, 6 Mar 2008 02:08:48 +0000 (02:08 +0000)]
    Reviewed by Darin.

        Move JNI specific code from runtime_root over to jni_jsobject, where it is used.

        * bridge/jni/jni_jsobject.cpp:
        (completedJavaScriptAccess):
        (initializeJavaScriptAccessLock):
        (lockJavaScriptAccess):
        (unlockJavaScriptAccess):
        (dispatchToJavaScriptThread):
        (performJavaScriptAccess):
        (JavaJSObject::initializeJNIThreading):
        (isJavaScriptThread):
        (JavaJSObject::invoke):
        * bridge/jni/jni_jsobject.h:
        * bridge/runtime_root.cpp:
        * bridge/runtime_root.h:
        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge init]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
darin@apple.com [Thu, 6 Mar 2008 02:05:47 +0000 (02:05 +0000)]
    Reviewed by Sam.

        - add functions giving offsets within a KURL, slated to replace the
          EncodedURL object in CSSStyleSelector (in a future "visited link" change)
        - chagned all KURL data members names to use the traditional m_ prefix
        - initialize all members to 0 in invalid KURLs rather than having all
          functions check m_isValid

        * platform/KURL.cpp:
        (WebCore::KURL::invalidate): Added. Initializes all the fields except for
        m_string to the "invalid" values. For use in the empty constructor and
        in the init and parse functions.
        (WebCore::KURL::init): Tweaked comments. Changed all code paths that return
        early to use the invalidate() function. Updated for member variable name
        changes.
        (WebCore::KURL::hasPath): Updated for member variable name changes.
        Remove now-unneeded check of m_isValid.
        (WebCore::KURL::lastPathComponent): Ditto.
        (WebCore::KURL::protocol): Ditto.
        (WebCore::KURL::host): Ditto.
        (WebCore::KURL::port): Ditto.
        (WebCore::KURL::pass): Ditto.
        (WebCore::KURL::user): Ditto.
        (WebCore::KURL::ref): Ditto.
        (WebCore::KURL::hasRef): Ditto.
        (WebCore::KURL::protocolIs): Ditto.
        (WebCore::KURL::query): Ditto.
        (WebCore::KURL::path): Ditto.
        (WebCore::KURL::setProtocol): Ditto.
        (WebCore::KURL::setHost): Ditto.
        (WebCore::KURL::setPort): Ditto.
        (WebCore::KURL::setHostAndPort): Ditto.
        (WebCore::KURL::setUser): Ditto.
        (WebCore::KURL::setPass): Ditto.
        (WebCore::KURL::setRef): Ditto.
        (WebCore::KURL::setQuery): Ditto.
        (WebCore::KURL::setPath): Ditto.
        (WebCore::KURL::prettyURL): Ditto.
        (WebCore::copyPathRemovingDots): Removed braces to match our code style.
        (WebCore::KURL::parse): Changed all code paths that return early to use
        the invalidate function. Moved code to set m_isValid to true to the very
        end of the function. Removed braces to match our code style. Removed an
        extra copy of the path/query/fragment code (there were two identical copies
        in the two sides of an if statement). Removed some commented-out code.
        Reversed an if statment. Added code to set the new m_pathAfterLastSlash
        field. Updated for member variable name changes.
        (WebCore::equalIgnoringRef): Updated for member variable name changes.
        (WebCore::KURL::isHierarchical): Ditto.

        * platform/KURL.h: Added a FIXME about ref vs. fragment. Made the empty
        constructor inline and called the new invalidate function. Added new
        pathStart, pathEnd, and pathAfterLastSlash functions, for use in the
        new visited link code. Added an invalidate function. Renamed all the
        data members to use the m_ prefix.

        * WebCore.base.exp: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
andersca@apple.com [Thu, 6 Mar 2008 01:39:21 +0000 (01:39 +0000)]
    Reviewed by Sam.

        * WebCore.xcodeproj/project.pbxproj:
        Change jni_jsobject.cpp to be Obj-C++ for now. The plan is to merge
        this with jni_objc.mm and create jni_jsobject.mm.

        * bridge/jni/jni_jsobject.cpp:
        (createRootObject):
        Move createRootObject here from WebCoreFrameBridge.

        (JavaJSObject::createNative):
        Call the newly added createRootObject function.

        * bridge/runtime_root.cpp:
        (KJS::Bindings::RootObject::initializeJNIThreading):
        * bridge/runtime_root.h:
        setCreateRootObject no longer takes a root object, rename it to initializeJNIThreading.

        * page/mac/FrameMac.mm:
        (WebCore::Frame::createScriptInstanceForWidget):
        Just call Frame::createRootObject here.

        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge init]):
        Call initializeJNIThreading.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
andersca@apple.com [Wed, 5 Mar 2008 23:52:14 +0000 (23:52 +0000)]
    Reviewed by Sam.

        Change some static class variables to be regular static variables,
        making it easier to move the chunk of mac-specific code out of runtime_root.[cpp|h]

        * bridge/runtime_root.cpp:
        (KJS::Bindings::completedJavaScriptAccess):
        (KJS::Bindings::RootObject::dispatchToJavaScriptThread):
        (KJS::Bindings::performJavaScriptAccess):
        (KJS::Bindings::RootObject::createRootObject):
        (KJS::Bindings::RootObject::runLoop):
        (KJS::Bindings::RootObject::setCreateRootObject):
        * bridge/runtime_root.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-05 Brent Fulgham <bfulgham@gmail.com>
mrowe@apple.com [Wed, 5 Mar 2008 22:44:12 +0000 (22:44 +0000)]
2008-03-05  Brent Fulgham <bfulgham@gmail.com>

        Reviewed by Adam Roben.

        Modify source files to use the USE(SAFARI_THEME) macro, rather than
        USE_SAFARI_THEME.  (http://bugs.webkit.org/show_bug.cgi?id=17683)

        * WebCore/platform/win/PlatformScrollBarSafari.cpp
        * WebCore/rendering/RenderThemeSafari.cpp
        * WebCore/rendering/RenderThemeSafari.h
        * config.h: Move definition of WTF_USE_SAFARI_THEME here

2008-03-05  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Adam Roben.

        Remove definition of WTF_USE_SAFARI_THEME from wtf/Platform.h
        because the PLATFORM(CG) flag is not set until config.h has
        already included this file.

        * wtf/Platform.h:  Remove useless definition of WTF_USE_SAFARI_THEME

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
beidson@apple.com [Wed, 5 Mar 2008 22:26:34 +0000 (22:26 +0000)]
JavaScriptCore:

        Reviewed by Alexey and Mark Rowe

        Fix for <rdar://problem/5778247> - Reproducible crash on storage/execute-sql-args.html

        DatabaseThread::unscheduleDatabaseTasks() manually filters through a MessageQueue,
        removing particular items for Databases that were shutting down.

        This filtering operation is not atomic, and therefore causes a race condition with the
        MessageQueue waking up and reading from the message queue.

        The end result was an attempt to dereference a null DatabaseTask.  Timing-wise, this never
        seemed to happen in a debug build, otherwise an assertion would've caught it.  Replacing that
        assertion with a crash in a release build is what revealed this bug.

        * wtf/MessageQueue.h:
        (WTF::::waitForMessage): Tweak the waiting logic to check the queue's empty state then go back
          to sleep if the queue was empty - checking m_killed each time it wakes up.

WebCore:

        Reviewed by Alexey and Mark Rowe

        Fix for <rdar://problem/5778247> - Reproducible crash on storage/execute-sql-args.html

        DatabaseThread::unscheduleDatabaseTasks() manually filters through a MessageQueue,
        removing particular items for Databases that were shutting down.

        This filtering operation is not atomic, and therefore causes a race condition with the
        database thread waking up and reading from the message queue.

        The end result was an attempt to dereference a null DatabaseTask.  Timing-wise, this never
        seemed to happen in a debug build, otherwise an assertion would've caught it.  Replacing that
        assertion with a crash in a release build is what revealed this bug.

        The fix for the above symptom was entirely in WTF::MessageQueue in JSCore.  With this fix in
        place, another crash popped up in the layout tests that was related to dereferencing a
        deallocated object - simply because SQLTransaction had a raw pointer to it's Database object
        when it needed to be a ref pointer.

        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::runCurrentStatement):
        * storage/SQLTransaction.h: Change m_database to be a RefPtr
        (WebCore::SQLTransaction::database):

LayoutTests:

        Reviewed by Alexey + Mark Rowe

        Fix for <rdar://problem/5778247> - Reproducible crash on storage/execute-sql-args.html

        This test takes its best shot at handling two databases on a single database thread at once,
        then having one of those databases go away completely (garbage collection and everything)

        * storage/multiple-databases-garbage-collection-expected.txt: Added.
        * storage/multiple-databases-garbage-collection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Remove unused header includes from interpreter.cpp.
ddkilzer@apple.com [Wed, 5 Mar 2008 22:20:12 +0000 (22:20 +0000)]
    Remove unused header includes from interpreter.cpp.

        Reviewed by Darin.

        * kjs/interpreter.cpp: Remove unused header includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix. Remove symbol that no longer exists from the exports file.
mrowe@apple.com [Wed, 5 Mar 2008 22:08:17 +0000 (22:08 +0000)]
Build fix.  Remove symbol that no longer exists from the exports file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixed commit date.
ddkilzer@apple.com [Wed, 5 Mar 2008 21:51:58 +0000 (21:51 +0000)]
Fixed commit date.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-05 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 5 Mar 2008 20:56:19 +0000 (20:56 +0000)]
2008-03-05  Alp Toker  <alp@atoker.com>

        Re-attempt to switch to the autotools build system for GTK+.

        Change scripts to continue when distclean fails.

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Remove WebCoreScriptCallFrame
aroben@apple.com [Wed, 5 Mar 2008 19:35:32 +0000 (19:35 +0000)]
     Remove WebCoreScriptCallFrame

         Reviewed by Tim.

         * WebView/WebCoreScriptDebugger.h:
           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
           - Replaced -newWrapperForFrame: with
             -newFrameWithGlobalObject:caller:state:
           - Removed WebCoreScriptCallFrame interface.
         * WebView/WebCoreScriptDebugger.mm: Replaced WebCoreScriptCallFrame
         with WebScriptCallFrame.
         (-[WebCoreScriptDebugger _enterFrame:]): Changed to call
         -newFrameWithGlobalObject:caller:state.
         (-[WebCoreScriptDebugger _leaveFrame]):
         * WebView/WebScriptDebugDelegate.h: Changed WebScriptCallFrame's
         _private ivar to be of type WebScriptCallFramePrivate*.
         * WebView/WebScriptDebugDelegate.mm:
           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
           - Added WebScriptCallFramePrivate
         (-[WebScriptDebugger enteredFrame:sourceId:line:]):
         (-[WebScriptDebugger hitStatement:sourceId:line:]):
         (-[WebScriptDebugger leavingFrame:sourceId:line:]):
         (-[WebScriptDebugger exceptionRaised:sourceId:line:]):
         (-[WebScriptCallFramePrivate dealloc]): Added.
         (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Added.
         Code came from WebCoreScriptCallFrame.
         (-[WebScriptCallFrame dealloc]): Added a call to release the _private
         ivar.
         (-[WebScriptCallFrame _convertValueToObjcValue:]): Replaced calls to
         _private with direct access of _private's ivars.
         (-[WebScriptCallFrame caller]): Ditto.
         (-[WebScriptCallFrame scopeChain]): Ditto.
         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move -_convertValueToObjcValue to WebScriptCallFrame
aroben@apple.com [Wed, 5 Mar 2008 19:35:09 +0000 (19:35 +0000)]
     Move -_convertValueToObjcValue to WebScriptCallFrame

         Reviewed by Darin.

         * WebView/WebCoreScriptDebugger.h: Removed declaration of
         -_convertValueToObjcValue.
         * WebView/WebCoreScriptDebugger.mm: Removed -_convertValueToObjcValue.
         * WebView/WebScriptDebugDelegate.mm:
         (-[WebScriptCallFrame _convertValueToObjcValue:]): Added. Code came
         from -[WebCoreScriptCallFrame _convertValueToObjcValue].
         (-[WebScriptCallFrame scopeChain]): Changed to call
         -_convertValueToObjcValue on self instead of _private.
         (-[WebScriptCallFrame exception]): Ditto.
         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move -exception and -evaluateWebScript: to WebScriptCallFrame
aroben@apple.com [Wed, 5 Mar 2008 19:34:44 +0000 (19:34 +0000)]
     Move -exception and -evaluateWebScript: to WebScriptCallFrame

         Reviewed by Darin.

         * WebView/WebCoreScriptDebugger.h: Removed declarations of -exception
         and -evaluateWebScript:.
         * WebView/WebCoreScriptDebugger.mm: Removed -exception and
         -evaluateWebScript:.
         * WebView/WebScriptDebugDelegate.mm:
         (-[WebScriptCallFrame exception]): Added. Code came from
         -[WebCoreScriptCallFrame exception].
         (-[WebScriptCallFrame evaluateWebScript:]): Added. Code came from
         -[WebCoreScriptCallFrame evaluateWebScript:].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move -scopeChain to WebScriptCallFrame
aroben@apple.com [Wed, 5 Mar 2008 19:34:29 +0000 (19:34 +0000)]
     Move -scopeChain to WebScriptCallFrame

         Reviewed by Darin.

         * WebView/WebCoreScriptDebugger.h:
           - Added declarations of -globalObject and -_convertValueToObjcValue:
             to WebCoreScriptCallFrame
           - Removed declaration of -scopeChain.
         * WebView/WebCoreScriptDebugger.mm: Moved -_convertValueToObjcValue
         within the main WebCoreScriptCallFrame implementation.
         (-[WebCoreScriptCallFrame globalObject]): Added.
         * WebView/WebScriptDebugDelegate.mm:
         (-[WebScriptCallFrame scopeChain]): Added. Code came from
         -[WebCoreScriptCallFrame scopeChain].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move -functionName from WebCoreScriptCallFrame to WebScriptCallFrame
aroben@apple.com [Wed, 5 Mar 2008 19:34:13 +0000 (19:34 +0000)]
     Move -functionName from WebCoreScriptCallFrame to WebScriptCallFrame

         Reviewed by Darin.

         * WebView/WebCoreScriptDebugger.h:
           - Removed #else case of #ifdef __cplusplus since this file is only
             ever used by C++ Objective-C files
           - Removed 'using KJS::ExecState' statement since we prefer not to
             have using statements in header files
           - Consequently prefixed uses of ExecState with KJS::
           - Added declaration of toNSString method that takes a const
             UString&
           - Added declaration of -[WebCoreScriptCallFrame state]
           - Removed declaration of -[WebCoreScriptCallFrame functionName]
         * WebView/WebCoreScriptDebugger.mm:
         (toNSString): Made this no longer static.
         (-[WebCoreScriptCallFrame state]): Added.
         * WebView/WebScriptDebugDelegate.mm:
         (-[WebScriptCallFrame functionName]): Added. Code came from
         -[WebCoreScriptCallFrame functionName], though I changed some nested
         ifs into early returns.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMove WebCoreScriptDebugger up to WebKit
aroben@apple.com [Wed, 5 Mar 2008 19:33:58 +0000 (19:33 +0000)]
Move WebCoreScriptDebugger up to WebKit

WebCore:

        Move WebCoreScriptDebugger up to WebKit

        Reviewed by Darin.

        * WebCore.base.exp: Exported some functions used by
        WebCoreScriptDebugger, and sorted the list.
        * WebCore.xcodeproj/project.pbxproj: Removed
        WebCoreScriptDebugger.{h,mm} from the project and marked
        a few headers private so that WebKit can use them.
        * page/mac/WebCoreScriptDebugger.h: Removed.
        * page/mac/WebCoreScriptDebugger.mm: Removed.

WebKit:

        Move WebCoreScriptDebugger to WebKit

        Reviewed by Darin.

        * WebKit.xcodeproj/project.pbxproj: Added WebCoreScriptDebugger.{h,mm}
        to the project.

WebKit/mac:

        Move WebCoreScriptDebugger to WebKit

        Reviewed by Darin.

        * WebView/WebCoreScriptDebugger.h: Renamed from WebCore/page/mac/WebCoreScriptDebugger.h.
        * WebView/WebCoreScriptDebugger.mm: Renamed from WebCore/page/mac/WebCoreScriptDebugger.mm.
        (toNSString):
        (toNSURL):
        (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
        (WebCoreScriptDebuggerImp::sourceParsed):
        (WebCoreScriptDebuggerImp::callEvent):
        (WebCoreScriptDebuggerImp::atStatement):
        (WebCoreScriptDebuggerImp::returnEvent):
        (WebCoreScriptDebuggerImp::exception):
        (+[WebCoreScriptDebugger initialize]):
        (-[WebCoreScriptDebugger initWithDelegate:]):
        (-[WebCoreScriptDebugger dealloc]):
        (-[WebCoreScriptDebugger finalize]):
        (-[WebCoreScriptDebugger delegate]):
        (-[WebCoreScriptDebugger _enterFrame:]):
        (-[WebCoreScriptDebugger _leaveFrame]):
        (-[WebCoreScriptCallFrame _initWithGlobalObject:caller:state:]):
        (-[WebCoreScriptCallFrame _setWrapper:]):
        (-[WebCoreScriptCallFrame _convertValueToObjcValue:]):
        (-[WebCoreScriptCallFrame dealloc]):
        (-[WebCoreScriptCallFrame wrapper]):
        (-[WebCoreScriptCallFrame caller]):
        (-[WebCoreScriptCallFrame scopeChain]):
        (-[WebCoreScriptCallFrame functionName]):
        (-[WebCoreScriptCallFrame exception]):
        (-[WebCoreScriptCallFrame evaluateWebScript:]):
        * WebView/WebScriptDebugDelegate.mm: Updated header path.
        * WebView/WebScriptDebugDelegatePrivate.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
andersca@apple.com [Wed, 5 Mar 2008 19:14:50 +0000 (19:14 +0000)]
    Reviewed by Sam.

        Remove bindings/.

        * bindings: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
andersca@apple.com [Wed, 5 Mar 2008 19:13:48 +0000 (19:13 +0000)]
    Build fix.

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build bridge/. Copy some headers over to WebKit as part of the post-build...
andersca@apple.com [Wed, 5 Mar 2008 19:12:51 +0000 (19:12 +0000)]
    Build bridge/. Copy some headers over to WebKit as part of the post-build step.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Don't build bindings/ anymore.
andersca@apple.com [Wed, 5 Mar 2008 19:11:39 +0000 (19:11 +0000)]
    Don't build bindings/ anymore.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
andersca@apple.com [Wed, 5 Mar 2008 19:04:21 +0000 (19:04 +0000)]
JavaScriptCore:

        Reviewed by Geoff.

        Don't build JavaScriptCore/bindings.

        * JavaScriptCore.exp:
        Export a couple of new functions.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        Remove bindings/

        * kjs/config.h:
        No need to define HAVE_JNI anymore.

        * kjs/interpreter.cpp:
        Remove unnecessary include.

WebCore:

        Reviewed by Geoff.

        * WebCore.base.exp:
        Add the NPN and KJS methods.

        * WebCore.xcodeproj/project.pbxproj:
        Bring in bridge/

        * config.h:
        Add HAVE_JNI define.

        * bindings/js/kjs_html.cpp:
        * bindings/objc/DOMInternal.mm:
        * bindings/objc/DOMUtility.mm:
        * bindings/objc/WebScriptObject.mm:
        * html/HTMLAppletElement.cpp:
        * html/HTMLEmbedElement.cpp:
        * html/HTMLObjectElement.cpp:
        * html/HTMLPlugInElement.cpp:
        * page/Frame.cpp:
        * page/mac/FrameMac.mm:
        * page/mac/WebCoreFrameBridge.mm:
        * page/mac/WebCoreScriptDebugger.mm:
        * plugins/win/PluginViewWin.cpp:
        Include file changes.

WebKit/mac:

        Reviewed by Geoff.

        Include file changes.

        * Plugins/WebBaseNetscapePluginView.mm:
        * Plugins/WebNetscapePluginPackage.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Allow override of default script file name using command-line argument.
ddkilzer@apple.com [Wed, 5 Mar 2008 18:19:12 +0000 (18:19 +0000)]
    Allow override of default script file name using command-line argument.

        Reviewed by Adele.

        * API/minidom.c:
        (main): Allow first command-line argument to override the default script
        file name of "minidom.js".
        * API/testapi.c:
        (main): Allow first command-line argument to override the default script
        file name of "testapi.js".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
andersca@apple.com [Wed, 5 Mar 2008 17:02:17 +0000 (17:02 +0000)]
    Reviewed by Sam.

        Rewrite NPRuntime string conversion routines to use WebCore::String

        * bridge/NP_jsobject.cpp:
        (_NPN_Evaluate):
        * bridge/c/c_utility.cpp:
        (KJS::Bindings::convertUTF8ToUTF16WithLatin1Fallback):
        (KJS::Bindings::convertNPVariantToValue):
        (KJS::Bindings::convertNPStringToUTF16):
        (KJS::Bindings::identifierFromNPIdentifier):
        * bridge/c/c_utility.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSmall performance improvement to putImageData (3-5% on assignment in my tests)
oliver@apple.com [Wed, 5 Mar 2008 09:13:42 +0000 (09:13 +0000)]
Small performance improvement to putImageData (3-5% on assignment in my tests)

Reviewed by Alexey P

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-05 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 5 Mar 2008 08:44:28 +0000 (08:44 +0000)]
2008-03-05  Alp Toker  <alp@atoker.com>

        Force qmake for the GTK+ build until we get the build bot to succeed
        with autotools (currently dies at make distclean)

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
weinig@apple.com [Wed, 5 Mar 2008 07:31:01 +0000 (07:31 +0000)]
    Reviewed by Adele.

        * bindings/js/JSXMLHttpRequest.h: Remove unnecessary override of toBoolean.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mjs@apple.com [Wed, 5 Mar 2008 07:08:43 +0000 (07:08 +0000)]
WebCore:

        Reviewed by Sam and Oliver.

        - fixed http://bugs.webkit.org/show_bug.cgi?id=16289
        - fixed Acid3 tests 26 and 27 (not exactly the same issue but related)

        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::mark): When marking a node that's in-document,
        mark the owner document if it hasn't been already. This means holding on
        to a single node from an unreferenced document now keeps the whole document alive.

        We are now at 90/100 on Acid3.

LayoutTests:

        Reviewed by Sam and Oliver.

        - test for http://bugs.webkit.org/show_bug.cgi?id=16289
        - test for Acid3 tests 26 and 27 (not exactly the same issue but related)

        * fast/dom/gc-11-expected.txt: Added. Test case from bug 16289.
        * fast/dom/gc-11.html: Added.
        * fast/dom/gc-acid3.html: Added. DOM garbage collection part of Acid3.
        * fast/dom/gc-acid3-expected.txt: Added.
        * fast/dom/gc-6-expected.txt: Updated results. The old assumptions of this test
        were in conflict with the requirements of Acid3.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-04 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 5 Mar 2008 06:54:54 +0000 (06:54 +0000)]
2008-03-04  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Switch the default GTK+ build system from qmake to autotools.

        qmake can still be used by defining WEBKIT_BUILD_SYSTEM=qmake

        * Scripts/build-webkit:
        * Scripts/run-launcher:
        * Scripts/run-webkit-tests:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Qt build fix.
weinig@apple.com [Wed, 5 Mar 2008 06:42:15 +0000 (06:42 +0000)]
    Qt build fix.

        * page/qt/FrameQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Wed, 5 Mar 2008 06:17:10 +0000 (06:17 +0000)]
WebCore:

        Reviewed by Mark Rowe.

        Rename kjs_window to JSDOMWindowBase.

        - Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including
          JSDOMWindow.h

        * ChangeLog:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSCustomVoidCallback.cpp:
        * bindings/js/JSCustomXPathNSResolver.cpp:
        * bindings/js/JSDOMWindowBase.cpp: Copied from bindings/js/kjs_window.cpp.
        * bindings/js/JSDOMWindowBase.h: Copied from bindings/js/kjs_window.h.
        * bindings/js/JSDOMWindowCustom.cpp:
        * bindings/js/JSDatabaseCustom.cpp:
        * bindings/js/JSEventTargetBase.cpp:
        * bindings/js/JSEventTargetBase.h:
        * bindings/js/JSEventTargetNode.cpp:
        * bindings/js/JSHTMLDocumentCustom.cpp:
        * bindings/js/JSHTMLFrameSetElementCustom.cpp:
        * bindings/js/JSHistoryCustom.cpp:
        * bindings/js/JSLocation.cpp:
        * bindings/js/JSSQLTransactionCustom.cpp:
        * bindings/js/JSXMLHttpRequest.cpp:
        * bindings/js/ScheduledAction.cpp:
        * bindings/js/kjs_binding.cpp:
        * bindings/js/kjs_events.cpp:
        * bindings/js/kjs_navigator.cpp:
        * bindings/js/kjs_proxy.cpp:
        * bindings/js/kjs_window.cpp: Removed.
        * bindings/js/kjs_window.h: Removed.
        * bindings/scripts/CodeGeneratorJS.pm:
        * history/CachedPage.cpp:
        * loader/FrameLoader.cpp:
        * page/Chrome.cpp:
        * page/InspectorController.cpp:
        * page/mac/FrameMac.mm:
        * page/mac/WebCoreFrameBridge.mm:
        * page/qt/FrameQt.cpp:
        * page/win/FrameWin.cpp:
        * plugins/win/PluginViewWin.cpp:

WebKit/gtk:

        Reviewed by Mark Rowe.

        - Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including
          JSDOMWindow.h

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        * webkit/webkitwebframe.cpp:

WebKit/qt:

        Reviewed by Mark Rowe.

        - Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including
          JSDOMWindow.h

        * Api/qwebframe.cpp:
        (QWebFrame::addToJSWindowObject):

WebKit/win:

        Reviewed by Mark Rowe.

        - Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including
          JSDOMWindow.h

        * WebFrame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the Tiger build.
timothy@apple.com [Wed, 5 Mar 2008 04:48:04 +0000 (04:48 +0000)]
Fix the Tiger build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAnother go at fixing the Qt build.
mrowe@apple.com [Wed, 5 Mar 2008 04:40:36 +0000 (04:40 +0000)]
Another go at fixing the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate link to Windows Platform SDK to its new location.
mrowe@apple.com [Wed, 5 Mar 2008 04:34:58 +0000 (04:34 +0000)]
Update link to Windows Platform SDK to its new location.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSpeculative Qt build fix.
mrowe@apple.com [Wed, 5 Mar 2008 04:22:54 +0000 (04:22 +0000)]
Speculative Qt build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
andersca@apple.com [Wed, 5 Mar 2008 02:14:41 +0000 (02:14 +0000)]
    Reviewed by Sam.

        Update include paths. This code is not used yet.

        * bridge/NP_jsobject.cpp:
        * bridge/c/c_class.cpp:
        * bridge/c/c_instance.cpp:
        * bridge/c/c_utility.cpp:
        (KJS::Bindings::convertUTF8ToUTF16WithLatin1Fallback):
        #if 0 this out for now.

        * bridge/jni/jni_class.cpp:
        * bridge/jni/jni_jsobject.cpp:
        * bridge/jni/jni_objc.mm:
        * bridge/jni/jni_runtime.cpp:
        * bridge/jni/jni_utility.cpp:
        * bridge/jni/jni_utility.h:
        * bridge/npruntime.cpp:
        * bridge/objc/WebScriptObject.h:
        * bridge/objc/objc_class.h:
        * bridge/objc/objc_instance.h:
        * bridge/objc/objc_runtime.h:
        * bridge/objc/objc_utility.h:
        * bridge/objc/objc_utility.mm:
        * bridge/runtime.cpp:
        * bridge/runtime.h:
        * bridge/runtime_array.cpp:
        * bridge/runtime_array.h:
        * bridge/runtime_method.cpp:
        * bridge/runtime_method.h:
        * bridge/runtime_object.cpp:
        * bridge/runtime_object.h:
        * bridge/runtime_root.cpp:
        * bridge/runtime_root.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Wed, 5 Mar 2008 02:09:04 +0000 (02:09 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17676
          <rdar://problem/5781091> REGRESSION (r30240-r30267): href attribute values with non-ASCII characters in the host part do not work

        Test: fast/encoding/url-host-name-non-ascii.html

        * platform/KURL.cpp:
        (WebCore::appendEncodedHostname): Added an early return in the all-ASCII
        case to avoid copying the host name twice and corrected the error
        checking after calling uidna_IDNToASCII().

LayoutTests:

        - test for http://bugs.webkit.org/show_bug.cgi?id=17676
          <rdar://problem/5781091> REGRESSION (r30240-r30267): href attribute values with non-ASCII characters in the host part do not work

        * fast/encoding/url-host-name-non-ascii-expected.txt: Added.
        * fast/encoding/url-host-name-non-ascii.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the Tiger build.
timothy@apple.com [Wed, 5 Mar 2008 01:21:42 +0000 (01:21 +0000)]
Fix the Tiger build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Dan Bernstein.
weinig@apple.com [Wed, 5 Mar 2008 01:02:41 +0000 (01:02 +0000)]
    Reviewed by Dan Bernstein.

        Use JSDOMWindow exclusively instead of JSDOMWindowBase.

        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::execute):
        * bindings/js/ScheduledAction.h:
        * bindings/js/kjs_window.cpp:
        (WebCore::JSDOMWindowBase::timerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
timothy@apple.com [Wed, 5 Mar 2008 00:57:26 +0000 (00:57 +0000)]
WebCore:

        Reviewed by Darin Adler.

        <rdar://problem/5720160> Browser windows "do nothing" while modal
        dialog or menu is up due to run loop modes (or while scrolling)

        Adds a new SchedulePair object that holds a runloop and the mode to use.
        A HashSet of SchedulePairs is tracked by Page so it can be used for resource
        loading and, in the future, maybe SharedTimerMac.

        * WebCore.base.exp: Add new exports for WebKit.
        * WebCore.xcodeproj/project.pbxproj: Add new files.
        * loader/mac/DocumentLoaderMac.cpp: Added.
        (WebCore::scheduleAll): Call schedule all the ResourceLoader handles.
        (WebCore::unscheduleAll): Call unschedule all the ResourceLoader handles.
        (WebCore::DocumentLoader::schedule): Schedule all the ResourceLoaders owned by the DocumentLoader.
        (WebCore::DocumentLoader::unschedule): Unschedule all the ResourceLoaders owned by the DocumentLoader.
        * loader/DocumentLoader.h:
        * page/Page.h:
        (WebCore::Page::scheduledRunLoopPairs): Return m_scheduledRunLoopPairs.
        * page/mac/PageMac.cpp:
        (WebCore::Page::addSchedulePair): Add a SchedulePair to m_scheduledRunLoopPairs.
        (WebCore::Page::removeSchedulePair): Removes a SchedulePair from m_scheduledRunLoopPairs.
        * platform/cf/SchedulePair.cpp: Added.
        * platform/cf/SchedulePair.h: Added.
        * platform/mac/SchedulePairMac.mm: Added.
        * platform/network/ResourceHandle.h:
        * platform/network/mac/FormDataStreamMac.mm:
        (WebCore::advanceCurrentStream): Use the new SchedulePair.
        (WebCore::formCreate): Ditto.
        (WebCore::formFinalize): Ditto.
        (WebCore::formSchedule): Ditto.
        (WebCore::formUnschedule): Ditto.
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::start): Schedule the connection with all the SchedulePairs
        that Page holds. If Page has no SchedulePairs, schedule with the current runloop, and
        pick the mode based on ResourceHandle::loadsDuringCommonRunLoopModes.
        (WebCore::ResourceHandle::schedule):
        (WebCore::ResourceHandle::unschedule):

WebKit/mac:

        Reviewed by Darin Adler.

        <rdar://problem/5720160> Browser windows "do nothing" while modal
        dialog or menu is up due to run loop modes (or while scrolling)

        Add new API that lets a WebView be scheduled with multiple runloops and modes.
        This lets loading continue when in a nested runloop or in a different mode.

        * Misc/WebKitVersionChecks.h: Add a new version define:
        WEBKIT_FIRST_VERSION_WITH_LOADING_DURING_COMMON_RUNLOOP_MODES.
        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:]): Schedule in the main runloop and with
        the default runloop mode if we are linked on an earlier WebKit version, use common modes otherwise.
        (-[WebView scheduleInRunLoop:forMode:]): New API, that calls through to Page.
        (-[WebView unscheduleFromRunLoop:forMode:]): Ditto.
        * WebView/WebViewPrivate.h: Add the new pending API methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Eric.
zimmermann@webkit.org [Wed, 5 Mar 2008 00:53:11 +0000 (00:53 +0000)]
Reviewed by Eric.
Fix svg/dynamic-updates time-dependancy problem. Remove unneeded setTimeout() call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
weinig@apple.com [Wed, 5 Mar 2008 00:28:28 +0000 (00:28 +0000)]
    Reviewed by Darin Adler.

        Rename kjs_css to JSRGBColor.

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSRGBColor.cpp: Copied from bindings/js/kjs_css.cpp.
        * bindings/js/JSRGBColor.h: Copied from bindings/js/kjs_css.h.
        * bindings/js/kjs_css.cpp: Removed.
        * bindings/js/kjs_css.h: Removed.
        * bindings/js/kjs_window.cpp:
        * bindings/objc/DOMUtility.mm:
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix 64-bit build.
andersca@apple.com [Wed, 5 Mar 2008 00:08:13 +0000 (00:08 +0000)]
    Fix 64-bit build.

        * html/HTMLPlugInElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago WebScriptDebugServer cleanup
aroben@apple.com [Wed, 5 Mar 2008 00:05:08 +0000 (00:05 +0000)]
     WebScriptDebugServer cleanup

         Reviewed by Anders.

         * WebScriptDebugServer.cpp: Renamed m_callingServer to
         m_callingListeners.
         (WebScriptDebugServer::WebScriptDebugServer):
         (WebScriptDebugServer::sharedWebScriptDebugServer): Changed to keep
         the shared instance as a function-level static.
         (WebScriptDebugServer::didLoadMainResourceForDataSource): Made return
         void.
         (WebScriptDebugServer::sourceParsed):
         (WebScriptDebugServer::callEvent):
         (WebScriptDebugServer::atStatement):
         (WebScriptDebugServer::returnEvent):
         (WebScriptDebugServer::exception):
         (WebScriptDebugServer::serverDidDie): Made return void.
         * WebScriptDebugServer.h:
           - Removed unnecessary #includes
           - Made inheritance from KJS::Debugger private
           - Made some methods private

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Remove WebScriptDebugger
aroben@apple.com [Wed, 5 Mar 2008 00:04:50 +0000 (00:04 +0000)]
     Remove WebScriptDebugger

         Reviewed by Anders.

         * WebKit.vcproj/WebKit.vcproj: Removed files from project.
         * WebScriptDebugServer.cpp:
         (frame): Moved here from WebScriptDebugger.cpp.
         (webFrame): Ditto.
         (webView): Ditto.
         (WebScriptDebugServer::WebScriptDebugServer): Initialize new member.
         * WebScriptDebugServer.h: Changed to inherit directly from
         KJS::Debugger instead of from WebScriptDebugger, and added
         m_callingServer member that WebScriptDebugger used to own.
         * WebScriptDebugger.cpp: Removed.
         * WebScriptDebugger.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move sourceParsed to WebScriptDebugServer
aroben@apple.com [Wed, 5 Mar 2008 00:04:31 +0000 (00:04 +0000)]
     Move sourceParsed to WebScriptDebugServer

         Reviewed by Anders.

         * WebScriptDebugServer.cpp:
         (WebScriptDebugServer::sourceParsed): Moved here from
         WebScriptDebugger and merged with didParseSource/failedToParseSource.
         * WebScriptDebugServer.h: Removed didParseSource/failedToParseSource.
         * WebScriptDebugger.cpp: Removed sourceParsed.
         * WebScriptDebugger.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move callEvent, returnEvent, and exception to WebScriptDebugServer
aroben@apple.com [Wed, 5 Mar 2008 00:04:11 +0000 (00:04 +0000)]
 Move callEvent, returnEvent, and exception to WebScriptDebugServer

 WebCore:

         Add ExecState.h to ForwardingHeaders

         Reviewed by Anders.

         * ForwardingHeaders/kjs/ExecState.h: Added.
         * page/Page.cpp: Touch this to force WebCore to build and the headers
         to be copied.

 WebKit/win:

         Move callEvent, returnEvent, and exception to WebScriptDebugServer

         Reviewed by Anders.

         * WebScriptDebugServer.cpp:
         (WebScriptDebugServer::callEvent): Moved here from WebScriptDebugger
         and merged with didEnterCallFrame.
         (WebScriptDebugServer::returnEvent): Ditto for willLeaveCallFrame.
         (WebScriptDebugServer::exception): Ditto for exceptionWasRaised.
         * WebScriptDebugServer.h: Removed didEnterCallFrame,
         willLeaveCallFrame, and exceptionWasRaised.
         * WebScriptDebugger.cpp: Removed callEvent, returnEvent, and
         exception.
         * WebScriptDebugger.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move atStatement to WebScriptDebugServer
aroben@apple.com [Wed, 5 Mar 2008 00:03:37 +0000 (00:03 +0000)]
     Move atStatement to WebScriptDebugServer

         Reviewed by Anders.

         * WebScriptDebugServer.cpp:
         (WebScriptDebugServer::atStatement): Moved here and merged with the
         old willExecuteStatement method.
         * WebScriptDebugServer.h: Removed inheritance from
         IWebScriptDebugListener, which no one was relying on.
         * WebScriptDebugger.cpp:
         (webFrame): Made non-static.
         (webView): Ditto.
         * WebScriptDebugger.h: Added declarations of webFrame and webView
         methods for WebScriptDebugServer's benefit. Removed unused m_webView
         and m_frame members.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Start to merge WebScriptDebugger and WebScriptDebugServer
aroben@apple.com [Wed, 5 Mar 2008 00:02:54 +0000 (00:02 +0000)]
     Start to merge WebScriptDebugger and WebScriptDebugServer

         WebScriptDebugServer now inherits from WebScriptDebugger.

         Reviewed by Anders.

         * WebScriptDebugServer.cpp:
         (WebScriptDebugServer::pageCreated): Use sharedWebScriptDebugServer
         instead of WebScriptDebugger::shared.
         (WebScriptDebugServer::addListener): Ditto.
         (WebScriptDebugServer::removeListener): Ditto.
         * WebScriptDebugServer.h: Changed to inherit from WebScriptDebugger.
         * WebScriptDebugger.cpp: Removed shared method.
         * WebScriptDebugger.h: Made constructor/destructor protected, and
         removed shared method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMac build fix. Add new symbol to exports file.
mrowe@apple.com [Tue, 4 Mar 2008 23:43:11 +0000 (23:43 +0000)]
Mac build fix.  Add new symbol to exports file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Eric & David.
zimmermann@webkit.org [Tue, 4 Mar 2008 23:21:50 +0000 (23:21 +0000)]
Reviewed by Eric & David.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=17078
Fix getSubStringLength() handling, verified by Acid3 test 77.
Brings up Acid3 score to 88/100.

Added test: svg/custom/acid3-test-77.html
            svg/custom/getSubStringLength.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Mac build fix. Neither me, Sam nor Adam know why we need to do this though :(
andersca@apple.com [Tue, 4 Mar 2008 23:07:04 +0000 (23:07 +0000)]
    Mac build fix. Neither me, Sam nor Adam know why we need to do this though :(

        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::attachDebugger):
        * page/Page.cpp:
        (WebCore::Page::setDebuggerForAllPages):
        (WebCore::Page::setDebugger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
andersca@apple.com [Tue, 4 Mar 2008 22:35:27 +0000 (22:35 +0000)]
    Reviewed by Darin.

        Fix crash that happens when trying to load a page with a Java applet.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        Don't release the names and values array - the kit method returns an autoreleased array.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move debugger-attaching code from WebKit/win to WebCore
aroben@apple.com [Tue, 4 Mar 2008 22:26:17 +0000 (22:26 +0000)]
 Move debugger-attaching code from WebKit/win to WebCore

 WebCore:

         Make it possible to set a KJS::Debugger on all Frames in a Page and
         all Pages in the process

         Reviewed by Kevin M.

         * ForwardingHeaders/kjs/debugger.h: Added.
         * bindings/js/kjs_proxy.cpp:
         (WebCore::KJSProxy::initScript): Attach the Page's debugger if there
         is one.
         (WebCore::KJSProxy::attachDebugger): Attach the passed-in debugger, or
         detach any existing debugger if none was passed in.
         * bindings/js/kjs_proxy.h:
         * page/Page.cpp:
         (WebCore::Page::Page): Initialize new member.
         (WebCore::Page::setDebuggerForAllPages): Call setDebugger on each Page
         in the process.
         (WebCore::Page::setDebugger): Store the debugger and pass it off to
         all our Frames.
         * page/Page.h:

 WebKit/win:

         Use WebCore's new debugger-attaching code

         Reviewed by Kevin M.

         * WebCoreSupport/WebFrameLoaderClient.cpp: Moved a kit() function to
         WebView.{cpp,h} so that other files can call it.
         * WebFrame.cpp:
         (WebFrame::WebFrame): Removed m_scriptDebugger member.
         (WebFrame::windowObjectCleared): Removed attach/detach calls. This is
         no longer needed because WebScriptDebugger no longer stores any
         per-WebFrame state.
         * WebFrame.h:
         * WebScriptDebugServer.cpp:
         (WebScriptDebugServer::pageCreated): Added. Attaches our shared
         debugger to the Page if we have any listeners.
         (WebScriptDebugServer::addListener): Sets our shared debugger for all
         Pages when we get our first listener.
         (WebScriptDebugServer::removeListener): Removes our shared debugger
         from all Pages when we lose our last listener.
         * WebScriptDebugServer.h:
         * WebScriptDebugger.cpp:
         (WebScriptDebugger::shared): Added.
         (WebScriptDebugger::WebScriptDebugger): Removed m_frame member.
         (WebScriptDebugger::~WebScriptDebugger): Added.
         (frame): Gets a Frame from an ExecState.
         (webFrame): Gets a WebFrame from an ExecState.
         (webView): Gets a WebView from an ExecState.
         (WebScriptDebugger::sourceParsed): Changed to call webFrame() and
         webView() instead of using m_frame and m_webView members.
         (WebScriptDebugger::callEvent): Ditto.
         (WebScriptDebugger::atStatement): Ditto.
         (WebScriptDebugger::returnEvent): Ditto.
         (WebScriptDebugger::exception): Ditto.
         * WebScriptDebugger.h:
         * WebView.cpp:
         (kit): Moved here from WebFrameLoaderClient.cpp.
         (WebView::initWithFrame): Tell the WebScriptDebugServer about the new
         Page so it can attach a debugger if needed.
         * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Tue, 4 Mar 2008 22:05:52 +0000 (22:05 +0000)]
WebCore:

        Reviewed by Darin Adler.

        Add ClassInfo to custom constructors so that they toString properly

        - Take this chance to remove the "Imp" from the end of JSXMLHttpRequestConstructorImp,
          and XSLTProcessorConstructorImp and prefix all the classes with JS.

        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::): Added ClassInfo definition.
        (WebCore::JSAudioConstructor::JSAudioConstructor):
        (WebCore::JSAudioConstructor::construct): Cleanup.
        * bindings/js/JSAudioConstructor.h: Rename m_doc to m_document.
        (WebCore::JSAudioConstructor::classInfo): Added.

        * bindings/js/JSHTMLInputElementBase.cpp: Rename HTMLInputElementBasePrototype
        to JSHTMLInputElementBasePrototype as seen if toString'ed.
        (WebCore::):

        * bindings/js/JSHTMLOptionElementConstructor.cpp:
        (WebCore::): Added ClassInfo definition.
        * bindings/js/JSHTMLOptionElementConstructor.h:
        (WebCore::JSHTMLOptionElementConstructor::classInfo): Added.

        * bindings/js/JSImageConstructor.cpp:
        (WebCore::): Added ClassInfo definition.
        (WebCore::JSImageConstructor::implementsConstruct): Moved here from header.
        * bindings/js/JSImageConstructor.h:
        (WebCore::JSImageConstructor::classInfo): Added.

        * bindings/js/JSXMLHttpRequest.cpp:
        (WebCore::): Rename XMLHttpRequestPrototype  to JSXMLHttpRequestPrototype
        as seen if toString'ed.
        (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
        (WebCore::JSXMLHttpRequestConstructor::implementsConstruct):
        (WebCore::JSXMLHttpRequestConstructor::construct):
        * bindings/js/JSXMLHttpRequest.h: Renamed JSXMLHttpRequestConstructorImp to
        JSXMLHttpRequestConstructor and doc to m_document and
        (WebCore::JSXMLHttpRequestConstructor::classInfo): Added.

        * bindings/js/JSXSLTProcessor.cpp:
        (WebCore::): Renamed XSLTProcessorPrototype to JSXSLTProcessorPrototype and
        XSLTProcessorConstructorImp to JSXSLTProcessorConstructor.
        (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
        (WebCore::JSXSLTProcessorConstructor::implementsConstruct):
        (WebCore::JSXSLTProcessorConstructor::construct):
        * bindings/js/JSXSLTProcessor.h:
        (WebCore::JSXSLTProcessorConstructor::classInfo): Added.

        * bindings/js/kjs_window.cpp:
        (WebCore::JSDOMWindowBase::getValueProperty): Fixed to work with the new class names.

WebKitTools:

        Reviewed by Darin Adler.

        * Scripts/do-webcore-rename: Update renaming plan.

LayoutTests:

        Reviewed by Darin Adler.

        Update results for fixed class names.

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/xmlhttprequest-get-expected.txt:
        * http/tests/xmlhttprequest/event-target-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Tue, 4 Mar 2008 21:12:31 +0000 (21:12 +0000)]
WebCore:

        Reviewed by Oliver Hunt and Geoffrey Garen.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17667
          <rdar://problem/5779658> REGRESSION (r30587): Document::implicitClose() not called when done loading page (Image does not get scaled to fit)

        * loader/loader.cpp:
        (WebCore::Loader::didFinishLoading): Changed to call
        setLoadInProgress(false) even for 4xx errors, because that triggers
        load completion check.

LayoutTests:

        Reviewed by Oliver Hunt and Geoffrey Garen.

        - extended test to cover http://bugs.webkit.org/show_bug.cgi?id=17667
          <rdar://problem/5779658> REGRESSION (r30587): Document::implicitClose() not called when done loading page (Image does not get scaled to fit)

        * http/tests/misc/missing-style-sheet-expected.txt:
        * http/tests/misc/missing-style-sheet.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
adele@apple.com [Tue, 4 Mar 2008 21:09:07 +0000 (21:09 +0000)]
WebCore:

        Reviewed by Beth.

        Fix for <rdar://problem/5779718> focus() does not work for anchor elements with no content

        If an anchor has zero size, don't exclude it from being focusable from JS, just exclude it
        from being keyboard focusable (using the tab key).

        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::isFocusable):
        (WebCore::HTMLAnchorElement::isKeyboardFocusable):

LayoutTests:

        Reviewed by Beth.

        Test for <rdar://problem/5779718> focus() does not work for anchor elements with no content

        * fast/events/anchor-empty-focus-expected.txt: Added.
        * fast/events/anchor-empty-focus.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/5119360> ER - Seed: Google results do not have AXHeading information
cfleizach@apple.com [Tue, 4 Mar 2008 19:36:01 +0000 (19:36 +0000)]
<rdar://problem/5119360> ER - Seed: Google results do not have AXHeading information

Make headers appear in AX regardless of whether they have BlockFlow renderers or not

Reviewed by Darin Adler.

* page/mac/WebCoreAXObject.mm:
(headingLevel): no longer ignores BlockFlow rendered headers
(-[WebCoreAXObject accessibilityIsIgnored]): does not ignore headers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * PrettyPatch/PrettyPatch.rb: Allow the extent of the previous file to be...
aroben@apple.com [Tue, 4 Mar 2008 19:15:16 +0000 (19:15 +0000)]
    * PrettyPatch/PrettyPatch.rb: Allow the extent of the previous file to be omitted from the hunk header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Change WebView's string-finding methods to call through to Page
aroben@apple.com [Tue, 4 Mar 2008 17:59:28 +0000 (17:59 +0000)]
     Change WebView's string-finding methods to call through to Page

         These methods were added to Page back in r28878 (and the
         implementation was copied from WebView!) but we never switched over to
         using them.

         Reviewed by Sam.

         * WebView.cpp:
         (WebView::searchFor): Call through to Page::findString.
         (WebView::markAllMatchesForText): Call through to Page.
         (WebView::unmarkAllTextMatches): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30758 268f45cc-cd09-0410-ab3c-d52691b4dbfc