WebKit-https.git
14 years ago Delay load additional libraries to improve startup time.
sfalken [Thu, 11 Oct 2007 18:20:43 +0000 (18:20 +0000)]
    Delay load additional libraries to improve startup time.

        Reviewed by Darin, Ada.

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adachan [Thu, 11 Oct 2007 17:04:38 +0000 (17:04 +0000)]
WebCore:
        <rdar://problem/5534421>
        Switched to using wkGetDefaultHTTPCookieStorage() and removed some cookie-related
        methods we no longer need in ResourceHandle.

        <rdar://problem/5244261> "Never" cookie policy was ignored on windows
        Need to set the cookie accept policy on each CFURLRequest.

WebKit/win:
        <rdar://problem/5534421>
        Switched to using wkGetDefaultHTTPCookieStorage() to avoid recreating CFHTTPCookieStorageRef.
        Removed usage of ResourceHandle::cookieStorage().

        Reviewed by Oliver.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5534421>
adachan [Thu, 11 Oct 2007 16:57:40 +0000 (16:57 +0000)]
    <rdar://problem/5534421>
        Added wkGetDefaultHTTPCookieStorage().  Updated libraries.

        Reviewed by Darin.

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-11 Mark Rowe <mrowe@apple.com>
bdash [Thu, 11 Oct 2007 15:16:58 +0000 (15:16 +0000)]
2007-10-11  Mark Rowe  <mrowe@apple.com>

        Reviewed by Tim Hatcher.

        Fix for <rdar://problem/5488678>.  Disable debugging symbols in production builds for 10.4
        PowerPC to prevent a huge STABS section from being generated.

        * Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoEnsure that setting innerHTML on an element doesn't do
lars [Thu, 11 Oct 2007 09:30:54 +0000 (09:30 +0000)]
Ensure that setting innerHTML on an element doesn't do
weird things with the document.
Fixes most issues with http://bugs.webkit.org/show_bug.cgi?id=15456

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoOops, forgot to save this file.
darin [Thu, 11 Oct 2007 00:25:51 +0000 (00:25 +0000)]
Oops, forgot to save this file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Kevin McCullough and Sam Weinig.
darin [Thu, 11 Oct 2007 00:24:27 +0000 (00:24 +0000)]
    Reviewed by Kevin McCullough and Sam Weinig.

        - fix mistake in test function that treated all non-prototype objects as equal

        That means that all numbers are treated as equal!
        And all boolean values!

        Kevin noticed that his new test was succeeding even though the bug was still
        there. Turns out the code to compare arrays that I added with my fix for
        bug 14931 was misfiring all the time.

        * fast/js/resources/js-test-pre.js: Use Object.prototype.toString.call
        to test if something is an array. Thanks, Sam.

        * fast/dom/Window/new-window-opener-expected.txt: Update this to reflect the
        fact that the test is actually failing!
        * fast/forms/focus-selection-textarea-expected.txt: Ditto.
        * fast/js/kde/encode_decode_uri-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Remove now-passing tests
aroben [Wed, 10 Oct 2007 20:48:04 +0000 (20:48 +0000)]
    Remove now-passing tests

        Rubberstamped by Sam.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the build on Win32 for VS2005. A solution for mingw and others may be
staikos [Wed, 10 Oct 2007 18:54:39 +0000 (18:54 +0000)]
Fix the build on Win32 for VS2005.  A solution for mingw and others may be
needed for FTPDirectory*.cpp still

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agogtk:
aliceli1 [Wed, 10 Oct 2007 18:31:20 +0000 (18:31 +0000)]
gtk:

        Reviewed by Geoff Garen.

        changes to keep the build from breaking

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::createFrame):
        * WebCoreSupport/FrameLoaderClientGtk.h:

qt:

        Reviewed by Geoff Garen.

        changes to keep the build from breaking

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::createFrame):
        * WebCoreSupport/FrameLoaderClientQt.h:

WebCore:

        Reviewed by Geoff Garen.

        Fixed <rdar://5464402> Crash when running fast/frames/onload-remove-iframe-crash.html in DRT
        createFrame() now returns a RefPtr instead of a raw Frame pointer.
        Making this change improves the way we handle frames on Windows webkit.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadSubframe):
        * loader/FrameLoaderClient.h:
        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyFrameLoaderClient::createFrame):

WebKit:

        Reviewed by Geoff Garen.

        Fixed <rdar://5464402> Crash when running fast/frames/onload-remove-iframe-crash.html in DRT
        createFrame() now returns a RefPtr instead of a raw Frame pointer.
        Making this change improves the way we handle frames on Windows WebKit.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::createFrame):

win:

        Reviewed by Geoff Garen.

        Fixed <rdar://5464402> Crash when running fast/frames/onload-remove-iframe-crash.html in DRT

        * WebFrame.cpp:
        (WebFrame::createFrame):
        The crash was caused by the early destruction of the subframe.  To resolve this issue,
        the manual deref of the child frame that occurs in between being appended to the
        frametree and being used in loadURLIntoChild wasn't exactly incorrect, but just needed
        to be moved until after loadURLIntoChild. This hasn't been a problem for other uses of
        child frames because this test case involves removing a child frame immediately after
        loading it, all in an onload handler.  Even better than just moving the deref would be
        to change the signature of createFrame to use a RefPtr<Frame> so that a manual deref isn't
        necessary. This is what was done in this patch.
        * WebFrame.h:
        createFrame() now returns a RefPtr instead of a raw Frame pointer.
        Making this change improves the way we handle frames on Windows WebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix compilation using gcc 4.3. Header files have been reorganized and as a result...
hausmann [Wed, 10 Oct 2007 11:12:20 +0000 (11:12 +0000)]
Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
includes are needed for INT_MAX, std::auto_ptr and the like.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBump versions for submit
sfalken [Wed, 10 Oct 2007 05:09:05 +0000 (05:09 +0000)]
Bump versions for submit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoremove some passing tests from teh Skipped list, and adapt some results.
lars [Tue, 9 Oct 2007 13:58:47 +0000 (13:58 +0000)]
remove some passing tests from teh Skipped list, and adapt some results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoimplement layoutTestController.encode/decodeHostName. We still don't pass fast/encodi...
lars [Tue, 9 Oct 2007 13:58:40 +0000 (13:58 +0000)]
implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agofix the invokation of slots with return types. Add a JSLock around the conversion...
lars [Tue, 9 Oct 2007 13:58:36 +0000 (13:58 +0000)]
fix the invokation of slots with return types. Add a JSLock around the conversion from QVariant to JSValue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoremove some tests that are now passing.
lars [Tue, 9 Oct 2007 13:58:31 +0000 (13:58 +0000)]
remove some tests that are now passing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoset a default encoding for documents. Makes fast/dom/Document/document-charset.html...
lars [Tue, 9 Oct 2007 13:58:24 +0000 (13:58 +0000)]
set a default encoding for documents. Makes fast/dom/Document/document-charset.html pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoDon't return a 404 status code for empty data: urls. Fixes fast/dom/HTMLHeadElement...
lars [Tue, 9 Oct 2007 13:58:22 +0000 (13:58 +0000)]
Don't return a 404 status code for empty data: urls. Fixes fast/dom/HTMLHeadElement/head-check.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoDon't set up connections inside QWebPage::createFrame, as users might be reimplementi...
lars [Tue, 9 Oct 2007 13:58:19 +0000 (13:58 +0000)]
Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agodon't try to test objc wrappers on platforms that don't support objc. Add a platform...
lars [Tue, 9 Oct 2007 13:58:14 +0000 (13:58 +0000)]
don't try to test objc wrappers on platforms that don't support objc. Add a platform dependent result for Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoexpected result for this test. This differs from the Mac result, as I suspect their...
lars [Tue, 9 Oct 2007 13:58:06 +0000 (13:58 +0000)]
expected result for this test. This differs from the Mac result, as I suspect their XMLHttpRequest implementation to have a bug here for local files. If a request is ok, the returned status code should be 200, not 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agofix up the results for one test case, and remove 2 others from the skipped list.
lars [Tue, 9 Oct 2007 13:57:58 +0000 (13:57 +0000)]
fix up the results for one test case, and remove 2 others from the skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoadd a dummy implementation for layoutTestController.display() and implement layoutTes...
lars [Tue, 9 Oct 2007 13:57:51 +0000 (13:57 +0000)]
add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoeven though this is a text only test the result is platform dependent.
lars [Tue, 9 Oct 2007 13:57:47 +0000 (13:57 +0000)]
even though this is a text only test the result is platform dependent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoadd a clear() method to QWebPageHistory.
lars [Tue, 9 Oct 2007 13:57:39 +0000 (13:57 +0000)]
add a clear() method to QWebPageHistory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agomake --git-reviewer work again.
lars [Tue, 9 Oct 2007 13:52:51 +0000 (13:52 +0000)]
make --git-reviewer work again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMerge r26108 from feature-branch to trunk.
weinig [Mon, 8 Oct 2007 21:07:14 +0000 (21:07 +0000)]
Merge r26108 from feature-branch to trunk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix Bug 15305: Crash when dragging an image when "load images automatically...
aroben [Mon, 8 Oct 2007 00:14:02 +0000 (00:14 +0000)]
     Fix Bug 15305: Crash when dragging an image when "load images automatically" preference is off

         http://bugs.webkit.org/show_bug.cgi?id=15305
         <rdar://problem/5524774>

         Reviewed by Eric Seidel.

         No test possible: to reproduce this you have to change a WebKit
        preference and reload the page. See
        http://bugs.webkit.org/show_bug.cgi?id=15414

         * platform/win/ClipboardWin.cpp:
         (WebCore::createGlobalImageFileDescriptor): ASSERT that we have an
         image and that it has a SharedBuffer.
         (WebCore::writeImageToDataObject): The fix: null-check imageBuffer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-07 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Sun, 7 Oct 2007 08:07:23 +0000 (08:07 +0000)]
2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>

        Rubber stamped by Eric.

        Connect to the "hovering-over-link" signal emitted by WebKitPage and
        show the current link inside the statusbar.
        This shows how to make use of this signal and allows to easily test
        http://bugs.webkit.org/show_bug.cgi?id=15299.

        * GtkLauncher/main.cpp:
        (hoveringOverLink):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ggaren [Sat, 6 Oct 2007 00:54:00 +0000 (00:54 +0000)]
JavaScriptCore:

        Reviewed by Sam Weinig.

        Added JSObject::removeDirect, to support the fix for
        <rdar://problem/5522487> REGRESSION: With JavaScript disabled, any
        page load causes a crash in PropertyMap::put

        * kjs/object.cpp:
        (KJS::JSObject::removeDirect):
        * kjs/object.h:

WebCore:

        Reviewed by Sam Weinig.

        New fix for <rdar://problem/5522487> REGRESSION: With JavaScript
        disabled, any page load causes a crash in PropertyMap::put

        Explicitly remove the "document" property from the window. The old
        solution would leave a stale "document" property around after JavaScript
        was re-enabled.

        The architecture for disabling JavaScript could use some consolidation.
        It seems wrong that a script proxy even exists when JavaScript is
        disabled. It also seems wrong that so many individual call sites are
        responsible for checking whether JavaScript is enabled. I've filed a
        bug about this: http://bugs.webkit.org/show_bug.cgi?id=15385.

        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::clearDocumentWrapper):
        * bindings/js/kjs_proxy.h:
        * page/Frame.cpp:
        (WebCore::Frame::setDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-05 Jon Honeycutt <jhoneycutt@apple.com>
honeycutt [Fri, 5 Oct 2007 21:38:31 +0000 (21:38 +0000)]
2007-10-05  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Anders.

        <rdar://5520913> Ticketmaster.com doesn't display correctly (Flash
        related?)

        The plugin is requesting files that don't exist on the server, and
        we are passing the 404 error page to the plugin. This change cancels the
        stream if the response code indicates a failure.

        This is a port of the safari / mac code.

        * loader/win/NetscapePlugInStreamLoaderWin.cpp:
        (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): If the
        response code indicates a failure, cancel the stream

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam Weinig.
ggaren [Fri, 5 Oct 2007 20:12:58 +0000 (20:12 +0000)]
    Reviewed by Sam Weinig.

        Fixed <rdar://problem/5522487> REGRESSION: With JavaScript disabled,
        any page load causes a crash in PropertyMap::put

        The problem was that we were using JavaScript when JavaScript was
        disabled. The architecture for disabling JavaScript could use some
        consolidation, but this is the simplest, safest change for now.

        Currently passing layout tests still pass.

        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::updateDocumentWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
bdakin [Fri, 5 Oct 2007 20:04:49 +0000 (20:04 +0000)]
WebCore:

        Reviewed by John Sullivan.

        Fix for <rdar://problem/5441823> REGRESSION (r25142, Tiger only):
        Vertical scroll bar not redrawn properly when going back in history
        (15033)

        This fix if-defs r25142 to be Leopard-only since it causes
        correctness issues on Tiger and does not seem to have any
        performance impact on Tiger either.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::transitionToCommitted):

WebKit:

        Reviewed by John Sullivan.

        Fix for <rdar://problem/5441823> REGRESSION (r25142, Tiger only):
        Vertical scroll bar not redrawn properly when going back in history
        (15033)

        This fix if-defs r25142 to be Leopard-only since it causes
        correctness issues on Tiger and does not seem to have any
        performance impact on Tiger either.

        * WebView/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]):
        (-[WebDynamicScrollBarsView reflectScrolledClipView:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5436617>
adachan [Fri, 5 Oct 2007 16:57:10 +0000 (16:57 +0000)]
    <rdar://problem/5436617>
        Implement WebIconDatabase::delayDatabaseCleanup() and WebIconDatabase::allowDatabaseCleanup().

        Reviewed by Brady.

        * WebIconDatabase.cpp:
        (WebIconDatabase::delayDatabaseCleanup):
        (WebIconDatabase::allowDatabaseCleanup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5436617> Favicons sometimes don't show up even when they are
adachan [Fri, 5 Oct 2007 16:52:03 +0000 (16:52 +0000)]
    <rdar://problem/5436617> Favicons sometimes don't show up even when they are
        in the database
        - A client can try to retain an icon for a page before the database is actually
        opened.  Since isOpened() is not a requirement to retain an icon, remove the check
        for that.  Instead, we'll check to make sure whether this database is enabled
        before proceeding.

        Reviewed by Brady.

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::retainIconForPageURL):
        (WebCore::IconDatabase::releaseIconForPageURL): only check isOpen() before we
        schedule for a sync.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agothese tests deliver the same results as on the Mac, which
lars [Fri, 5 Oct 2007 10:56:59 +0000 (10:56 +0000)]
these tests deliver the same results as on the Mac, which
makes them pass :)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agofix a hang in editing/selection/extend-by-word-002.html
lars [Fri, 5 Oct 2007 10:25:31 +0000 (10:25 +0000)]
fix a hang in editing/selection/extend-by-word-002.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoforgot to add these files in r26061.
lars [Fri, 5 Oct 2007 09:10:15 +0000 (09:10 +0000)]
forgot to add these files in r26061.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoremove platform specific results, after r26045 turned
lars [Fri, 5 Oct 2007 09:06:22 +0000 (09:06 +0000)]
remove platform specific results, after r26045 turned
these tests into being text only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoremove four more passing tests from the skipped list.
lars [Fri, 5 Oct 2007 09:04:34 +0000 (09:04 +0000)]
remove four more passing tests from the skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoadd proper error messages to the FrameLoaderClient.
lars [Fri, 5 Oct 2007 08:57:12 +0000 (08:57 +0000)]
add proper error messages to the FrameLoaderClient.
Implement ChromeClientQt::closeWindowSoon and
FrameLoaderClientQt::dispatchCreatePage (which should go
away IMO).
Some fixes in DRT to make it work correctly with multiple
windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd a dummy plugin to DRT to fix fast/dom/Window/Plug-Ins.html.
lars [Fri, 5 Oct 2007 08:57:06 +0000 (08:57 +0000)]
Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
Add support for layoutTextController.setCanOpenWindows() to DRT
fixing another 2 test cases in fast/dom/Window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-04 Mark Rowe <mrowe@apple.com>
bdash [Fri, 5 Oct 2007 03:52:22 +0000 (03:52 +0000)]
2007-10-04  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver.

        Switch to default level of debugging symbols to resolve <rdar://problem/5488678>.
        The "full" level appears to offer no observable benefits even though the documentation
        suggests it be used for dead code stripping.  This should also decrease link times.

        * Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber stamped by Adam.
weinig [Fri, 5 Oct 2007 03:37:44 +0000 (03:37 +0000)]
    Rubber stamped by Adam.

        Remove empty directories.

        * DumpRenderTree/DumpRenderTree.qtproj: Removed.
        * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * Interfaces/IWebViewPrivate.idl: Moving setInitialFocus down to the end...
adele [Thu, 4 Oct 2007 23:23:41 +0000 (23:23 +0000)]
    * Interfaces/IWebViewPrivate.idl: Moving setInitialFocus down to the end to avoid breaking the OpenSource build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adele [Thu, 4 Oct 2007 22:21:55 +0000 (22:21 +0000)]
WebCore:

        Reviewed by Darin.

        WebCore part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content

        * page/FocusController.h: Added FocusDirection argument.
        * page/FocusController.cpp: (WebCore::FocusController::setInitialFocus):
          Use FocusDirection argument instead of key modifiers to send direction to advanceFocus.
        * WebCore.exp: Updated symbol.

WebKit:

        Reviewed by Darin.

        WebKit part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content

        * WebView/WebHTMLView.mm: (-[WebHTMLView becomeFirstResponder]): Pass in the FocusDirection.

win:

        Reviewed by Darin.

        WebKit/win part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content

        * WebView.cpp: Added setInitialFocus so the application can specify that its handing off focus to WebKit
          and so that it can specify the focus direction.
        * WebView.h: ditto.
        * Interfaces/IWebViewPrivate.idl: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * WebView/WebHTMLView.mm: (-[WebHTMLView _updateActiveState]):
darin [Thu, 4 Oct 2007 20:34:28 +0000 (20:34 +0000)]
    * WebView/WebHTMLView.mm: (-[WebHTMLView _updateActiveState]):
        Removed a bogus comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Darin.
weinig [Thu, 4 Oct 2007 18:33:02 +0000 (18:33 +0000)]
    Rubber-stamped by Darin.

        Make traversal tests dumpAsText.

        * platform/mac/traversal: Removed.
        * platform/mac/traversal/node-iterator-001-expected.checksum: Removed.
        * platform/mac/traversal/node-iterator-001-expected.png: Removed.
        * platform/mac/traversal/node-iterator-001-expected.txt: Removed.
        * platform/mac/traversal/node-iterator-002-expected.checksum: Removed.
        * platform/mac/traversal/node-iterator-002-expected.png: Removed.
        * platform/mac/traversal/node-iterator-002-expected.txt: Removed.
        * platform/mac/traversal/node-iterator-003-expected.checksum: Removed.
        * platform/mac/traversal/node-iterator-003-expected.png: Removed.
        * platform/mac/traversal/node-iterator-003-expected.txt: Removed.
        * platform/mac/traversal/node-iterator-004-expected.checksum: Removed.
        * platform/mac/traversal/node-iterator-004-expected.png: Removed.
        * platform/mac/traversal/node-iterator-004-expected.txt: Removed.
        * platform/mac/traversal/node-iterator-005-expected.checksum: Removed.
        * platform/mac/traversal/node-iterator-005-expected.png: Removed.
        * platform/mac/traversal/node-iterator-005-expected.txt: Removed.
        * platform/mac/traversal/node-iterator-006-expected.checksum: Removed.
        * platform/mac/traversal/node-iterator-006-expected.png: Removed.
        * platform/mac/traversal/node-iterator-006-expected.txt: Removed.
        * platform/mac/traversal/node-iterator-007-expected.checksum: Removed.
        * platform/mac/traversal/node-iterator-007-expected.png: Removed.
        * platform/mac/traversal/node-iterator-007-expected.txt: Removed.
        * platform/mac/traversal/node-iterator-008-expected.checksum: Removed.
        * platform/mac/traversal/node-iterator-008-expected.png: Removed.
        * platform/mac/traversal/node-iterator-008-expected.txt: Removed.
        * platform/mac/traversal/stay-within-root-expected.checksum: Removed.
        * platform/mac/traversal/stay-within-root-expected.png: Removed.
        * platform/mac/traversal/stay-within-root-expected.txt: Removed.
        * platform/mac/traversal/tree-walker-001-expected.checksum: Removed.
        * platform/mac/traversal/tree-walker-001-expected.png: Removed.
        * platform/mac/traversal/tree-walker-001-expected.txt: Removed.
        * platform/mac/traversal/tree-walker-002-expected.checksum: Removed.
        * platform/mac/traversal/tree-walker-002-expected.png: Removed.
        * platform/mac/traversal/tree-walker-002-expected.txt: Removed.
        * platform/mac/traversal/tree-walker-003-expected.checksum: Removed.
        * platform/mac/traversal/tree-walker-003-expected.png: Removed.
        * platform/mac/traversal/tree-walker-003-expected.txt: Removed.
        * platform/mac/traversal/tree-walker-004-expected.checksum: Removed.
        * platform/mac/traversal/tree-walker-004-expected.png: Removed.
        * platform/mac/traversal/tree-walker-004-expected.txt: Removed.
        * platform/mac/traversal/tree-walker-005-expected.checksum: Removed.
        * platform/mac/traversal/tree-walker-005-expected.png: Removed.
        * platform/mac/traversal/tree-walker-005-expected.txt: Removed.
        * traversal/node-iterator-001-expected.txt: Added.
        * traversal/node-iterator-001.html:
        * traversal/node-iterator-002-expected.txt: Added.
        * traversal/node-iterator-002.html:
        * traversal/node-iterator-003-expected.txt: Added.
        * traversal/node-iterator-003.html:
        * traversal/node-iterator-004-expected.txt: Added.
        * traversal/node-iterator-004.html:
        * traversal/node-iterator-005-expected.txt: Added.
        * traversal/node-iterator-005.html:
        * traversal/node-iterator-006-expected.txt: Added.
        * traversal/node-iterator-006.html:
        * traversal/node-iterator-007-expected.txt: Added.
        * traversal/node-iterator-007.html:
        * traversal/node-iterator-008-expected.txt: Added.
        * traversal/node-iterator-008.html:
        * traversal/stay-within-root-expected.txt: Added.
        * traversal/stay-within-root.html:
        * traversal/tree-walker-001-expected.txt: Added.
        * traversal/tree-walker-001.html:
        * traversal/tree-walker-002-expected.txt: Added.
        * traversal/tree-walker-002.html:
        * traversal/tree-walker-003-expected.txt: Added.
        * traversal/tree-walker-003.html:
        * traversal/tree-walker-004-expected.txt: Added.
        * traversal/tree-walker-004.html:
        * traversal/tree-walker-005-expected.txt: Added.
        * traversal/tree-walker-005.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John.
kdecker [Thu, 4 Oct 2007 17:45:44 +0000 (17:45 +0000)]
    Reviewed by John.

        <rdar://problems/5516309>

        * page/FrameView.cpp:
        (WebCore::FrameView::updateControlTints): Avoid the expense of updating tints on controls for the
        empty-window case since this can take a significant amount of time even on windows that have no
        content at all. Note this fix specifically optimizes the empty window/tab case; for a more broad
        fix John wrote up rdar://problem/5521050.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * page/Frame.h: Put functions into categories to indicate other classes
darin [Thu, 4 Oct 2007 17:13:36 +0000 (17:13 +0000)]
    * page/Frame.h: Put functions into categories to indicate other classes
        we'd like to move them into in the future. Just organizational -- no code
        change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agofix a crash in the FrameLoader that can happen under certain
lars [Thu, 4 Oct 2007 08:45:12 +0000 (08:45 +0000)]
fix a crash in the FrameLoader that can happen under certain
conditions in the Qt port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoforgot to move one file in the last commit.
lars [Thu, 4 Oct 2007 07:36:09 +0000 (07:36 +0000)]
forgot to move one file in the last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Move png files that are not test results and where mistakenly moved in r26026
lars [Thu, 4 Oct 2007 07:32:23 +0000 (07:32 +0000)]
    Move png files that are not test results and where mistakenly moved in r26026
        back to where they belong.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
darin [Thu, 4 Oct 2007 00:43:30 +0000 (00:43 +0000)]
    Reviewed by Adam.

        * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
        we find the internal libraries in the libraries directory. This
        is helpful for Safari team engineers at Apple.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5521230> Implement IWebIconDatabase::iconURLForURL in WebKit...
adachan [Wed, 3 Oct 2007 22:48:58 +0000 (22:48 +0000)]
    <rdar://problem/5521230> Implement IWebIconDatabase::iconURLForURL in WebKit for windows

        Reviewed by Steve and Brady.

        * Interfaces/IWebIconDatabase.idl:
        * WebIconDatabase.cpp:
        (WebIconDatabase::iconURLForURL):
        * WebIconDatabase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Move pixel test results that were mistakenly left in place after r25970
aroben [Wed, 3 Oct 2007 21:00:48 +0000 (21:00 +0000)]
    Move pixel test results that were mistakenly left in place after r25970

        Rubberstamped by Sam.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add some sometimes-timing-out tests to the Skipped file
aroben [Wed, 3 Oct 2007 17:40:56 +0000 (17:40 +0000)]
    Add some sometimes-timing-out tests to the Skipped file

        Rubberstamped by Sam.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Update the location of AHEM___.TTF after r25968
aroben [Wed, 3 Oct 2007 17:33:13 +0000 (17:33 +0000)]
    Update the location of AHEM___.TTF after r25968

        Reviewed by Sam.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-03 Alp Toker <alp@atoker.com>
alp [Wed, 3 Oct 2007 17:25:43 +0000 (17:25 +0000)]
2007-10-03  Alp Toker  <alp@atoker.com>

        Reviewed by Adam.

        http://bugs.webkit.org/show_bug.cgi?id=14726
        [gtk] API design. Mapping the WebView delegates to signals.

        Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-03 Alp Toker <alp@atoker.com>
alp [Wed, 3 Oct 2007 17:16:23 +0000 (17:16 +0000)]
2007-10-03  Alp Toker  <alp@atoker.com>

        Reviewed by Eric.

        http://bugs.webkit.org/show_bug.cgi?id=14129
        [CAIRO] Support the canvas element

        Add a new canvas implementation using Cairo for rendering.

        * html/CanvasGradient.cpp:
        (WebCore::CanvasGradient::CanvasGradient):
        (WebCore::CanvasGradient::~CanvasGradient):
        (WebCore::CanvasGradient::addColorStop):
        (WebCore::CanvasGradient::platformShading):
        * html/CanvasGradient.h:
        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::setFillStyle):
        (WebCore::CanvasRenderingContext2D::fill):
        (WebCore::CanvasRenderingContext2D::stroke):
        (WebCore::CanvasRenderingContext2D::fillRect):
        (WebCore::CanvasRenderingContext2D::drawImage):
        (WebCore::CanvasRenderingContext2D::applyStrokePattern):
        * html/CanvasStyle.cpp:
        (WebCore::CanvasStyle::applyStrokeColor):
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::~HTMLCanvasElement):
        (WebCore::HTMLCanvasElement::reset):
        (WebCore::HTMLCanvasElement::paint):
        (WebCore::HTMLCanvasElement::createDrawingContext):
        (WebCore::HTMLCanvasElement::createPlatformImage):
        * html/HTMLCanvasElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-02 Cosimo Cecchi <cosimoc@svn.gnome.org>
zecke [Wed, 3 Oct 2007 16:31:13 +0000 (16:31 +0000)]
2007-10-02  Cosimo Cecchi  <cosimoc@svn.gnome.org>

        Reviewed by Mark.

        http://bugs.webkit.org/show_bug.cgi?id=15299
        Fix "hovering_over_link" signal being fired every time mouse moves.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::ChromeClient):
        (WebKit::ChromeClient::mouseDidMoveOverElement):
        * WebCoreSupport/ChromeClientGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-09-21 Sean Egan <seanegan@gmail.com>
zecke [Wed, 3 Oct 2007 16:30:50 +0000 (16:30 +0000)]
2007-09-21  Sean Egan  <seanegan@gmail.com>

        Reviewed by Alp.

        Add an "execute_script" method to programmatically call Javascript
        http://bugs.webkit.org/show_bug.cgi?id=15255

        * Api/webkitgtkpage.cpp:
        * Api/webkitgtkpage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago This fixes --strict mode in run-webkit-tests again after
lars [Wed, 3 Oct 2007 14:20:38 +0000 (14:20 +0000)]
    This fixes --strict mode in run-webkit-tests again after
        the platform dependent test results have been moved.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix a stupid bug in Unicode::toUpper/toLower.
lars [Wed, 3 Oct 2007 14:14:13 +0000 (14:14 +0000)]
    Fix a stupid bug in Unicode::toUpper/toLower.
        Fixes all three test failures in the JavaScriptCore test
        suite.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoadd some more passing tests, and update one result.
lars [Wed, 3 Oct 2007 13:28:35 +0000 (13:28 +0000)]
add some more passing tests, and update one result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoremove the hack in run-webkit-tests that forced text only test
lars [Wed, 3 Oct 2007 11:52:24 +0000 (11:52 +0000)]
remove the hack in run-webkit-tests that forced text only test
to be taken from the platform independent dir. It was only left
there from early days.

Remove platform dependent results for tests that are text only nowadays,
and add one platform dependent result for a text only test that requires it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoadd some more results.
lars [Wed, 3 Oct 2007 11:33:12 +0000 (11:33 +0000)]
add some more results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Move all test results that are platform dependent but
lars [Wed, 3 Oct 2007 10:53:05 +0000 (10:53 +0000)]
    Move all test results that are platform dependent but
        stored in the platform independent part to their
        correct locations (inside platform/mac).

        This will make it a lot easier to maintain test
        results for other platforms than mac.

        Signed off by aroben.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agomove WebKitQt to WebKit/qt for consistency with the other ports.
lars [Wed, 3 Oct 2007 10:29:35 +0000 (10:29 +0000)]
move WebKitQt to WebKit/qt for consistency with the other ports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMove the Qt version of DRT into the correct place and put the binary into BUILDDIR...
lars [Wed, 3 Oct 2007 10:29:15 +0000 (10:29 +0000)]
Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-03 Mark Rowe <mrowe@apple.com>
bdash [Wed, 3 Oct 2007 09:25:21 +0000 (09:25 +0000)]
2007-10-03  Mark Rowe  <mrowe@apple.com>

        Reviewed by Alp Toker.

        Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
        should take precedence over QTDIR when determining which port we are working with.

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove pixel test results for text only tests
lars [Wed, 3 Oct 2007 09:03:13 +0000 (09:03 +0000)]
Remove pixel test results for text only tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBump to correct version
aroben [Wed, 3 Oct 2007 06:31:38 +0000 (06:31 +0000)]
Bump to correct version

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBump versions for submit
sfalken [Wed, 3 Oct 2007 06:08:26 +0000 (06:08 +0000)]
Bump versions for submit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Adam Roben.
weinig [Wed, 3 Oct 2007 02:15:21 +0000 (02:15 +0000)]
    Rubber-stamped by Adam Roben.

        * Interfaces/IWebPreferences.idl: Remove unnecessary comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add keychain to the list of default packages to install
aroben [Wed, 3 Oct 2007 00:18:47 +0000 (00:18 +0000)]
    Add keychain to the list of default packages to install

        Rubberstamped by Sam.

        * CygwinDownloader/cygwin-downloader.py:
        * CygwinDownloader/cygwin-downloader.zip: Regenerated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver and Adam.
weinig [Wed, 3 Oct 2007 00:17:53 +0000 (00:17 +0000)]
    Reviewed by Oliver and Adam.

        Patch for <rdar://problem/5506968> Fail to DnD local file with non-ascii character in path from desktop to Safari (can open it with file menu)

        Use CoreFoundation to do the conversion from path to URL, as the Windows API was not
        correctly converting to UTF-8 and we know CFURL will.

        * platform/win/ClipboardUtilitiesWin.cpp:
        (WebCore::urlFromPath):
        (WebCore::getURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
tristan [Tue, 2 Oct 2007 23:36:06 +0000 (23:36 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/5511842> REGRESSION: Webkit stops responding while loading Apple Store Canada page (15304)

        Included the NSSynchronousURLConnection_PrivateMode mode, in addition to the default run loop modes
        as an acceptable mode when using performSelectorOnMainThread with our syncronous url callbacks.

        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
        Added NSSynchronousURLConnection_PrivateMode to the list of accepted modes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Added a mention of a bug that this test demonstrates:
justing [Tue, 2 Oct 2007 21:20:55 +0000 (21:20 +0000)]
    Added a mention of a bug that this test demonstrates:

        * editing/execCommand/5144139-1-expected.checksum: Removed.
        * editing/execCommand/5144139-1-expected.png: Removed.
        * editing/execCommand/5144139-1-expected.txt: Removed.
        * editing/execCommand/5144139-1.html:
        * platform/mac/editing/execCommand/5144139-1-expected.checksum: Added.
        * platform/mac/editing/execCommand/5144139-1-expected.png: Added.
        * platform/mac/editing/execCommand/5144139-1-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mark Rowe.
kdecker [Tue, 2 Oct 2007 21:20:18 +0000 (21:20 +0000)]
    Reviewed by Mark Rowe.

        Re-added _minimumRequiredSafariBuildNumber. It turns out older version of Safari still rely
        on this method, so we need to keep it around at least until the next major Safari release.

        * StringsNotToBeLocalized.txt:
        * WebView/WebView.mm:
        (+[WebView _minimumRequiredSafariBuildNumber]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSet svn:eol-style for all .sln files to CRLF.
darin [Tue, 2 Oct 2007 20:57:06 +0000 (20:57 +0000)]
Set svn:eol-style for all .sln files to CRLF.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin [Tue, 2 Oct 2007 20:49:13 +0000 (20:49 +0000)]
JavaScriptCore:

        Reviewed by Adam.

        - add support for GDI objects to OwnPtr; I plan to use this
          to fix some GDI handle leaks

        * kjs/grammar.y: Change parser to avoid macros that conflict
        with macros defined in Windows system headers: THIS, DELETE,
        VOID, IN, and CONST. This is needed because OwnPtr.h will now
        include <windows.h>.
        * kjs/keywords.table: Ditto.

        * wtf/OwnPtr.h: For PLATFORM(WIN), add support so that OwnPtr can be
        a GDI handle, and it will call DeleteObject. Also change to use the
        RemovePointer technique used by RetainPtr, so you can say OwnPtr<HBITMAP>
        rather than having to pass in the type pointed to by HBITMAP.

        * wtf/OwnPtrWin.cpp: Added.
        (WebCore::deleteOwnedPtr): Put this in a separate file so that we
        don't have to include <windows.h> in OwnPtr.h.

        * JavaScriptCore.vcproj/WTF/WTF.vcproj: Added OwnPtrWin.cpp.

WebCore:

        Reviewed by Adam.

        - add support for GDI objects to OwnPtr; I plan to use this
          to fix some GDI handle leaks

        * css/CSSGrammar.y: Change parser to avoid macro that conflicts
        with macro defined in Windows system headers: FLOAT. This is needed
        because OwnPtr.h will now include <windows.h>.
        * css/CSSParser.cpp: (WebCore::CSSParser::lex): Ditto.
        * css/tokenizer.flex: Ditto.

        * platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor):
        Use OwnPtr for a few HBITMAP objects as a test case.

        * platform/win/COMPtr.h: (COMPtr::COMPtr): Fix so that we can use
        Query with other COMPtr. Before this would not compile if it was
        ever instantiated.

win:

        Reviewed by Adam.

        - started using the new OwnPtr everywhere we do DeleteObject

        * WebNodeHighlight.cpp:
        (WebNodeHighlight::updateWindow):
        * WebView.cpp:
        (WebView::WebView):
        (WebView::deleteBackingStore):
        (WebView::ensureBackingStore):
        (WebView::addToDirtyRegion):
        (WebView::scrollBackingStore):
        (WebView::updateBackingStore):
        (WebView::paint):
        (WebView::paintIntoBackingStore):
        (WebView::paintIntoWindow):
        * WebView.h:

Also set svn:eol-style on all .vcproj to CRLF.

Also added svn:ignore of *.user for WebKitInitializer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
ddkilzer [Tue, 2 Oct 2007 20:38:36 +0000 (20:38 +0000)]
WebKitTools:

        Reviewed by Adam.

        Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
        Also makes WebCore regression test case logic work when using git.

        * Scripts/prepare-ChangeLog:
        (reviewerAndDescriptionForGitCommit): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam, Ada.
sfalken [Tue, 2 Oct 2007 19:58:14 +0000 (19:58 +0000)]
    Reviewed by Adam, Ada.

        Fix leak of GDI handle when we call MLANG.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix <rdar://5505062> WebKit's version-independent ProgIDs contain version...
aroben [Tue, 2 Oct 2007 17:55:01 +0000 (17:55 +0000)]
    Fix <rdar://5505062> WebKit's version-independent ProgIDs contain version numbers

        I also added a few registry keys for our version-independent ProgIDs
        that we were missing.

        Reviewed by Steve.

        * ProgIDMacros.h: Added new macros to get version-independent ProgIDs.
        * WebKitDLL.cpp: Use the version-independent ProgIDs in the right
        places, and added some new keys for version-independent ProgIDs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
kdecker [Tue, 2 Oct 2007 17:35:26 +0000 (17:35 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/5517710>

        * WebView/WebView.mm: Removed -[WebView _minimumRequiredSafariBuildNumber] because newer
         versions of Safari no longer use this method. This won't break existing Safaris because
         they always use a respondsToSelector check before calling this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
andersca [Tue, 2 Oct 2007 17:31:11 +0000 (17:31 +0000)]
    Reviewed by Adam.

        Fix a bug discovered by app verifier where we would treat an LPCTSTR as a BSTR causing a crash.

        Also rename some protection space constants and change their values to match the mac version.

        * Interfaces/IWebURLAuthenticationChallenge.idl:
        * WebURLProtectionSpace.cpp:
        (WebURLProtectionSpace::initWithHost):
        (WebURLProtectionSpace::initWithProxyHost):
        (WebURLProtectionSpace::protocol):
        (WebURLProtectionSpace::proxyType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Eric Seidel.
treat [Tue, 2 Oct 2007 16:21:57 +0000 (16:21 +0000)]
Reviewed by Eric Seidel.

Open the requested url on the newly created window.
Implement createModalDialog and provide new API for this.
Patch by M. Mehdi Salem Naraghi (momesana) with additions by me.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agodirty way of getting the Qt port to 0 test failures.
lars [Tue, 2 Oct 2007 14:04:42 +0000 (14:04 +0000)]
dirty way of getting the Qt port to 0 test failures.
It's still a good thing to do, as we now have a complete
list of all tests that are currently failing in the Skipped
file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoupdate two more test results and skip two crashing test cases for now.
lars [Tue, 2 Oct 2007 13:19:16 +0000 (13:19 +0000)]
update two more test results and skip two crashing test cases for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd API to retrieve the frame name from QWebFrame.
lars [Tue, 2 Oct 2007 13:02:43 +0000 (13:02 +0000)]
Add API to retrieve the frame name from QWebFrame.
Implement support for DRT::dumpChildrenAsText.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoupdate two more test results.
lars [Tue, 2 Oct 2007 12:56:11 +0000 (12:56 +0000)]
update two more test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSkip some tests that fail due to a bug in Qt 4.3, and update one more result.
lars [Tue, 2 Oct 2007 12:02:22 +0000 (12:02 +0000)]
Skip some tests that fail due to a bug in Qt 4.3, and update one more result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the handling of the response header for data urls. Make sure we always pass absol...
lars [Tue, 2 Oct 2007 11:29:43 +0000 (11:29 +0000)]
Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-02 Mark Rowe <mrowe@apple.com>
bdash [Tue, 2 Oct 2007 10:34:32 +0000 (10:34 +0000)]
2007-10-02  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver.

        Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.

        * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
        * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-02 Mark Rowe <mrowe@apple.com>
bdash [Tue, 2 Oct 2007 09:13:00 +0000 (09:13 +0000)]
2007-10-02  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Maciej.

        Configuration changes from build.webkit.org.  The major change is refactoring to work
        with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
        last few weeks.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
        * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
        * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
        * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
        * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
        * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
        * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add support for eventSender.mouseMove to DRT.
lars [Tue, 2 Oct 2007 09:10:53 +0000 (09:10 +0000)]
    Add support for eventSender.mouseMove to DRT.
        Fixes fast/css/hover-affects-child.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago The cookies() method should only return the value of the
lars [Tue, 2 Oct 2007 08:46:50 +0000 (08:46 +0000)]
    The cookies() method should only return the value of the
        cookie, not additional info such as the expiration date.
        Fixes LayoutTests/fast/cookies/local-file-can-set-cookies.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded some more test results.
lars [Tue, 2 Oct 2007 08:46:41 +0000 (08:46 +0000)]
Added some more test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate test result.
lars [Tue, 2 Oct 2007 08:09:06 +0000 (08:09 +0000)]
Update test result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25911 268f45cc-cd09-0410-ab3c-d52691b4dbfc