WebKit-https.git
12 years ago2010-01-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 4 Jan 2010 09:42:04 +0000 (09:42 +0000)]
2010-01-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool should not require users to install mechanize
        https://bugs.webkit.org/show_bug.cgi?id=32635

        * .gitignore: Ignore autoinstall.cache.d directory created by autoinstall.py
2010-01-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool should not require users to install mechanize
        https://bugs.webkit.org/show_bug.cgi?id=32635

        Use the nifty "autoinstall" module from Daniel Krech:
        http://pypi.python.org/pypi/autoinstall/0.2
        http://code.google.com/p/pyautoinstall/
        It's available under a WebKit-compatible BSD license.

        * Scripts/webkitpy/__init__.py:
         - bind "mechanize" to an autoinstall importer which will
           auto-download mechanize if necessary.
        * Scripts/webkitpy/autoinstall.py: Added.
        * Scripts/webkitpy/bugzilla.py: use "mechanize" instead of webkit_mechanize
        * Scripts/webkitpy/statusbot.py: ditto.
        * Scripts/webkitpy/webkit_mechanize.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 4 Jan 2010 09:33:43 +0000 (09:33 +0000)]
2010-01-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Move AbstractSequencedCommand to a more general location
        https://bugs.webkit.org/show_bug.cgi?id=33137

        I do what the FIXME tell me to do.

        * Scripts/webkitpy/commands/abstractsequencedcommand.py: Added.
        * Scripts/webkitpy/commands/download.py:
        * Scripts/webkitpy/commands/upload.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 4 Jan 2010 09:30:11 +0000 (09:30 +0000)]
2010-01-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Rename StatusBot to StatusServer
        https://bugs.webkit.org/show_bug.cgi?id=33139

        It's not a bot.  It's a server.

        * Scripts/bugzilla-tool:
        * Scripts/webkitpy/bugzilla.py:
        * Scripts/webkitpy/commands/early_warning_system.py:
        * Scripts/webkitpy/commands/queues.py:
        * Scripts/webkitpy/mock_bugzillatool.py:
        * Scripts/webkitpy/queueengine.py:
        * Scripts/webkitpy/statusbot.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 4 Jan 2010 09:05:11 +0000 (09:05 +0000)]
2010-01-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] submit-pach should have a -o/--open option to open the bug after submit
        https://bugs.webkit.org/show_bug.cgi?id=33136

        Python makes this very easy.

        * Scripts/webkitpy/mock_bugzillatool.py:
        * Scripts/webkitpy/steps/options.py:
        * Scripts/webkitpy/steps/postdiff.py:
        * Scripts/webkitpy/user.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-04 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 4 Jan 2010 08:47:16 +0000 (08:47 +0000)]
2010-01-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Move steps to a submodule
        https://bugs.webkit.org/show_bug.cgi?id=33135

        For great victory.  This will probably introduce some regressions
        because our test coverage isn't perfect, but I've tried to be careful.

        * Scripts/test-webkitpy:
        * Scripts/webkitpy/buildsteps.py: Removed.
        * Scripts/webkitpy/buildsteps_unittest.py: Removed.
        * Scripts/webkitpy/commands/download.py:
        * Scripts/webkitpy/commands/upload.py:
        * Scripts/webkitpy/steps/__init__.py: Added.
        * Scripts/webkitpy/steps/abstractstep.py: Added.
        * Scripts/webkitpy/steps/applypatch.py: Added.
        * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Added.
        * Scripts/webkitpy/steps/build.py: Added.
        * Scripts/webkitpy/steps/checkstyle.py: Added.
        * Scripts/webkitpy/steps/cleanworkingdirectory.py: Added.
        * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Added.
        * Scripts/webkitpy/steps/closebug.py: Added.
        * Scripts/webkitpy/steps/closebugforlanddiff.py: Added.
        * Scripts/webkitpy/steps/closepatch.py: Added.
        * Scripts/webkitpy/steps/commit.py: Added.
        * Scripts/webkitpy/steps/completerollout.py: Added.
        * Scripts/webkitpy/steps/confirmdiff.py: Added.
        * Scripts/webkitpy/steps/createbug.py: Added.
        * Scripts/webkitpy/steps/editchangelog.py: Added.
        * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Added.
        * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Added.
        * Scripts/webkitpy/steps/metastep.py: Added.
        * Scripts/webkitpy/steps/obsoletepatches.py: Added.
        * Scripts/webkitpy/steps/options.py: Added.
        * Scripts/webkitpy/steps/postdiff.py: Added.
        * Scripts/webkitpy/steps/preparechangelog.py: Added.
        * Scripts/webkitpy/steps/preparechangelogforrevert.py: Added.
        * Scripts/webkitpy/steps/promptforbugortitle.py: Added.
        * Scripts/webkitpy/steps/revertrevision.py: Added.
        * Scripts/webkitpy/steps/runtests.py: Added.
        * Scripts/webkitpy/steps/steps_unittest.py: Added.
        * Scripts/webkitpy/steps/update.py: Added.
        * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Added.
        * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Added.
        * Scripts/webkitpy/stepsequence.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-04 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 4 Jan 2010 08:43:22 +0000 (08:43 +0000)]
2010-01-04  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=33097

        Cleans up the File menu to better conform to the File menu in Safari
        both in terms of options and keyboard shortcuts. Adds a "Quit" menu
        options to close all open windows.

        * QGVLauncher/main.cpp:
        (MainWindow::buildUI):
2010-01-04  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=33097

        Cleans up the File menu to better conform to the File menu in Safari
        both in terms of options and keyboard shortcuts. Adds a "Quit" menu
        options to close all open windows. Also, renames the Tools menu to
        Develop.

        * QtLauncher/main.cpp:
        (MainWindow::setupUI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-04 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 4 Jan 2010 08:40:11 +0000 (08:40 +0000)]
2010-01-04  Daniel Bates  <dbates@webkit.org>

        https://bugs.webkit.org/show_bug.cgi?id=33039

        Unreviewed fix.

        * Scripts/webkitpy/credentials.py:
        * Scripts/webkitpy/credentials_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-04 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 4 Jan 2010 08:35:23 +0000 (08:35 +0000)]
2010-01-04  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Barth.

        Clean up COMPILER macros and remove unused ones.
        https://bugs.webkit.org/show_bug.cgi?id=33132

        Removed values are COMPILER(BORLAND) and COMPILER(CYGWIN) - they were
        not used anywhere.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-04 Daniel Bates <dbates@webkit.org>
eric@webkit.org [Mon, 4 Jan 2010 08:30:15 +0000 (08:30 +0000)]
2010-01-04  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=33039

        [bzt] Second attempt to fix an issue where bugzilla-tool dies
        when the keychain lookup fails to find an entry for bugs.webkit.org.

        * Scripts/webkitpy/credentials.py:
        * Scripts/webkitpy/credentials_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-03 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 4 Jan 2010 08:21:52 +0000 (08:21 +0000)]
2010-01-03  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGResources don't invalidate if target object changes attributes
        https://bugs.webkit.org/show_bug.cgi?id=33091

        It's neccessary to invalidate all resources of an object, if the attributes of this
        target change. Otherwise the saved resource data (like ImageBuffers) don't match
        to the new object properties.

        Test: svg/custom/resource-invalidate-on-target-update.svg

        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::svgAttributeChanged):
        (WebCore::SVGStyledElement::invalidateResources):
        * svg/SVGStyledElement.h:

2010-01-03  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGResources don't invalidate if target object changes attributes
        https://bugs.webkit.org/show_bug.cgi?id=33091

        Check if SVG resources are invalidated, if target object changes
        attributes.

        * platform/mac/svg/custom/resource-invalidate-on-target-update-expected.checksum: Added.
        * platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
        * platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt: Added.
        * svg/custom/resource-invalidate-on-target-update.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-04 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 4 Jan 2010 08:20:19 +0000 (08:20 +0000)]
2010-01-04  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=33039

        [bzt] Second attempt to fix an issue where bugzilla-tool dies
        when the keychain lookup fails to find an entry for bugs.webkit.org.

        * Scripts/webkitpy/credentials.py:
        * Scripts/webkitpy/credentials_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-04 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 4 Jan 2010 08:13:19 +0000 (08:13 +0000)]
2010-01-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Make all commands AbstractDeclarativeCommmands instead of direct Command subclasses
        https://bugs.webkit.org/show_bug.cgi?id=33131

        Evenetually we'll probably roll AbstractDeclarativeCommmand directly into Command
        but for now we just deploy it everywhere and don't try to fix up the few valid uses
        of Command.

        * Scripts/webkitpy/commands/download.py:
        * Scripts/webkitpy/commands/queries.py:
        * Scripts/webkitpy/commands/upload.py:
        * Scripts/webkitpy/multicommandtool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-03 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 4 Jan 2010 07:40:03 +0000 (07:40 +0000)]
2010-01-03  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Eric Seidel.

        Update wtf/Platform.h to document the new system for porting macros.
        https://bugs.webkit.org/show_bug.cgi?id=33130

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 4 Jan 2010 07:15:25 +0000 (07:15 +0000)]
2010-01-03  Adam Barth  <abarth@webkit.org>

        Unreviewed "build" fix.  Need to import ScriptError.

        * Scripts/webkitpy/buildsteps.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 4 Jan 2010 07:08:08 +0000 (07:08 +0000)]
2010-01-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Make it easier to run submit-patch when previous run cancelled
        https://bugs.webkit.org/show_bug.cgi?id=33070

        This patch renames create-review to submit-patch (as requested by
        Maciej).

        This patch makes it easier to run submit-patch after the user has
        already cancelled a previous run of submit-patch by detecting when we
        already have ChangeLogs and reading the bug number from them (and not
        attempting to recreate them).  Aside from performance and the extra
        edit step, this command should not subsume post-dif.

        Also, added a --email command line argument so that the output of
        prepare-ChangeLog makes sense when it can't find the user's email
        address.

        * Scripts/webkitpy/bugzilla.py:
        * Scripts/webkitpy/buildsteps.py:
        * Scripts/webkitpy/commands/upload.py:
        * Scripts/webkitpy/commands/upload_unittest.py:
        * Scripts/webkitpy/mock_bugzillatool.py:
        * Scripts/webkitpy/user.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-03 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 4 Jan 2010 07:04:57 +0000 (07:04 +0000)]
2010-01-03  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Rename Scripts/modules to Scripts/webkitpy
        https://bugs.webkit.org/show_bug.cgi?id=33128

        Just search-replace and svn mv commands.

        * Scripts/bugzilla-tool:
        * Scripts/check-webkit-style:
        * Scripts/modules: Removed.
        * Scripts/modules/BeautifulSoup.py: Removed.
        * Scripts/modules/__init__.py: Removed.
        * Scripts/modules/bugzilla.py: Removed.
        * Scripts/modules/bugzilla_unittest.py: Removed.
        * Scripts/modules/buildbot.py: Removed.
        * Scripts/modules/buildbot_unittest.py: Removed.
        * Scripts/modules/buildsteps.py: Removed.
        * Scripts/modules/buildsteps_unittest.py: Removed.
        * Scripts/modules/changelogs.py: Removed.
        * Scripts/modules/changelogs_unittest.py: Removed.
        * Scripts/modules/commands: Removed.
        * Scripts/modules/commands/__init__.py: Removed.
        * Scripts/modules/commands/commandtest.py: Removed.
        * Scripts/modules/commands/download.py: Removed.
        * Scripts/modules/commands/download_unittest.py: Removed.
        * Scripts/modules/commands/early_warning_system.py: Removed.
        * Scripts/modules/commands/early_warning_system_unittest.py: Removed.
        * Scripts/modules/commands/queries.py: Removed.
        * Scripts/modules/commands/queries_unittest.py: Removed.
        * Scripts/modules/commands/queues.py: Removed.
        * Scripts/modules/commands/queues_unittest.py: Removed.
        * Scripts/modules/commands/queuestest.py: Removed.
        * Scripts/modules/commands/upload.py: Removed.
        * Scripts/modules/commands/upload_unittest.py: Removed.
        * Scripts/modules/comments.py: Removed.
        * Scripts/modules/committers.py: Removed.
        * Scripts/modules/committers_unittest.py: Removed.
        * Scripts/modules/cpp_style.py: Removed.
        * Scripts/modules/cpp_style_unittest.py: Removed.
        * Scripts/modules/credentials.py: Removed.
        * Scripts/modules/credentials_unittest.py: Removed.
        * Scripts/modules/diff_parser.py: Removed.
        * Scripts/modules/diff_parser_unittest.py: Removed.
        * Scripts/modules/executive.py: Removed.
        * Scripts/modules/executive_unittest.py: Removed.
        * Scripts/modules/grammar.py: Removed.
        * Scripts/modules/mock.py: Removed.
        * Scripts/modules/mock_bugzillatool.py: Removed.
        * Scripts/modules/multicommandtool.py: Removed.
        * Scripts/modules/multicommandtool_unittest.py: Removed.
        * Scripts/modules/outputcapture.py: Removed.
        * Scripts/modules/patchcollection.py: Removed.
        * Scripts/modules/queueengine.py: Removed.
        * Scripts/modules/queueengine_unittest.py: Removed.
        * Scripts/modules/scm.py: Removed.
        * Scripts/modules/scm_unittest.py: Removed.
        * Scripts/modules/statusbot.py: Removed.
        * Scripts/modules/stepsequence.py: Removed.
        * Scripts/modules/style: Removed.
        * Scripts/modules/style.py: Removed.
        * Scripts/modules/style_unittest.py: Removed.
        * Scripts/modules/text_style.py: Removed.
        * Scripts/modules/text_style_unittest.py: Removed.
        * Scripts/modules/user.py: Removed.
        * Scripts/modules/webkit_logging.py: Removed.
        * Scripts/modules/webkit_logging_unittest.py: Removed.
        * Scripts/modules/webkit_mechanize.py: Removed.
        * Scripts/modules/webkitport.py: Removed.
        * Scripts/modules/webkitport_unittest.py: Removed.
        * Scripts/test-webkit-python: Removed.
        * Scripts/test-webkitpy: Copied from WebKitTools/Scripts/test-webkit-python.
        * Scripts/validate-committer-lists:
        * Scripts/webkitpy: Copied from WebKitTools/Scripts/modules.
        * Scripts/webkitpy/bugzilla.py:
        * Scripts/webkitpy/bugzilla_unittest.py:
        * Scripts/webkitpy/buildbot.py:
        * Scripts/webkitpy/buildbot_unittest.py:
        * Scripts/webkitpy/buildsteps.py:
        * Scripts/webkitpy/buildsteps_unittest.py:
        * Scripts/webkitpy/commands/commandtest.py:
        * Scripts/webkitpy/commands/download.py:
        * Scripts/webkitpy/commands/download_unittest.py:
        * Scripts/webkitpy/commands/early_warning_system.py:
        * Scripts/webkitpy/commands/early_warning_system_unittest.py:
        * Scripts/webkitpy/commands/queries.py:
        * Scripts/webkitpy/commands/queries_unittest.py:
        * Scripts/webkitpy/commands/queues.py:
        * Scripts/webkitpy/commands/queues_unittest.py:
        * Scripts/webkitpy/commands/queuestest.py:
        * Scripts/webkitpy/commands/upload.py:
        * Scripts/webkitpy/commands/upload_unittest.py:
        * Scripts/webkitpy/comments.py:
        * Scripts/webkitpy/credentials.py:
        * Scripts/webkitpy/credentials_unittest.py:
        * Scripts/webkitpy/executive.py:
        * Scripts/webkitpy/executive_unittest.py:
        * Scripts/webkitpy/mock_bugzillatool.py:
        * Scripts/webkitpy/multicommandtool.py:
        * Scripts/webkitpy/multicommandtool_unittest.py:
        * Scripts/webkitpy/queueengine.py:
        * Scripts/webkitpy/queueengine_unittest.py:
        * Scripts/webkitpy/scm.py:
        * Scripts/webkitpy/scm_unittest.py:
        * Scripts/webkitpy/statusbot.py:
        * Scripts/webkitpy/stepsequence.py:
        * Scripts/webkitpy/webkit_logging_unittest.py:
        * Scripts/webkitpy/webkitport_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-03 Chris Jerdonek <chris.jerdonek@gmail.com>
eric@webkit.org [Mon, 4 Jan 2010 06:31:43 +0000 (06:31 +0000)]
2010-01-03  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by Eric Seidel.

        Added script to test both Perl and Python, and renamed
        run-webkit-unittests to test-webkit-python.

        https://bugs.webkit.org/show_bug.cgi?id=33045

        * Scripts/VCSUtils_unittest.pl:
          - Tweaked so it can be run from outside Scripts directory.

        * Scripts/run-webkit-unittests: Removed.
          - Renamed to test-webkit-python.

        * Scripts/test-webkit-perl:
          - Tweaked so it can be run from outside Scripts directory.

        * Scripts/test-webkit-python: Copied from Scripts/run-webkit-unittests.

        * Scripts/test-webkit-scripts: Added.
          - Runs both test-webkit-perl and test-webkit-python.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-03 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 4 Jan 2010 03:12:35 +0000 (03:12 +0000)]
2010-01-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        commit-queue/bugzilla-tool should build both Debug and Release
        https://bugs.webkit.org/show_bug.cgi?id=28450

        Add a --build-style command that lets the master process tell the child
        process to build both debug and release.  Eventually we want to teach
        the test step to understand this option too, but that's a patch for
        another day.

        * Scripts/modules/buildsteps.py:
        * Scripts/modules/commands/queues.py:
        * Scripts/modules/webkitport.py:
        * Scripts/modules/webkitport_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-03 Kenneth Russell <kbr@google.com>
eric@webkit.org [Mon, 4 Jan 2010 02:40:02 +0000 (02:40 +0000)]
2010-01-03  Kenneth Russell  <kbr@google.com>

        Reviewed by Maciej Stachowiak.

        Index validation code must always copy client data
        https://bugs.webkit.org/show_bug.cgi?id=32748

        Client data must always be copied during bufferData and
        bufferSubData calls, because otherwise the data the GL uses to
        draw may differ from that checked by the index validation code.

        * fast/canvas/webgl/index-validation-copies-indices-expected.txt: Added.
        * fast/canvas/webgl/index-validation-copies-indices.html: Added.
2010-01-03  Kenneth Russell  <kbr@google.com>

        Reviewed by Maciej Stachowiak.

        Index validation code must always copy client data
        https://bugs.webkit.org/show_bug.cgi?id=32748

        Client data must always be copied during bufferData and
        bufferSubData calls, because otherwise the data the GL uses to
        draw may differ from that checked by the index validation code.

        Test: fast/canvas/webgl/index-validation-copies-indices.html

        * html/canvas/WebGLBuffer.cpp:
        (WebCore::WebGLBuffer::WebGLBuffer):
        (WebCore::WebGLBuffer::associateBufferData):
        (WebCore::WebGLBuffer::associateBufferSubData):
        * html/canvas/WebGLBuffer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-03 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 4 Jan 2010 02:32:06 +0000 (02:32 +0000)]
2010-01-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [Chromium] Implement CookieJarChromium::cookiesEnabled
        https://bugs.webkit.org/show_bug.cgi?id=33123

        Call out to ChromiumBridge to find out if cookies are enabled.

        * platform/chromium/ChromiumBridge.h:
        * platform/network/chromium/CookieJarChromium.cpp:
        (WebCore::cookiesEnabled):
2010-01-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [Chromium] Implement CookieJarChromium::cookiesEnabled
        https://bugs.webkit.org/show_bug.cgi?id=33123

        Call out to the webKitClient() to see if cookies are enabled.  Also
        remove some straggling references to policyURL!

        * public/WebKitClient.h:
        (WebKit::WebKitClient::setCookies):
        (WebKit::WebKitClient::cookies):
        (WebKit::WebKitClient::rawCookies):
        (WebKit::WebKitClient::cookiesEnabled):
        * src/ChromiumBridge.cpp:
        (WebCore::ChromiumBridge::cookiesEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-03 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 4 Jan 2010 02:24:53 +0000 (02:24 +0000)]
2010-01-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [Chromium] Remove evaluateInNewContext (it's useless)
        https://bugs.webkit.org/show_bug.cgi?id=33068

        This function has no clients and makes life complicated.  Isolated
        worlds won out over NewContext and there's not really any going back
        now.

        No new tests because this is all minus lines.

        * bindings/v8/ScriptController.cpp:
        * bindings/v8/ScriptController.h:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertWindowToV8Object):
        * bindings/v8/V8Proxy.cpp:
        * bindings/v8/V8Proxy.h:
2010-01-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [Chromium] Remove evaluateInNewContext (it's useless)
        https://bugs.webkit.org/show_bug.cgi?id=33068

        This function has no clients and makes life complicated.  Isolated
        worlds won out over NewContext and there's not really any going back
        now.

        * public/WebFrame.h:
        * src/FrameLoaderClientImpl.h:
        * src/WebFrameImpl.cpp:
        * src/WebFrameImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-03 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Mon, 4 Jan 2010 02:17:36 +0000 (02:17 +0000)]
2010-01-03  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Eric Seidel.

        [Qt] EventSender: add support for Enter key events
        https://bugs.webkit.org/show_bug.cgi?id=33064

        Unskip 5 tests that are fixed now.

        * platform/qt/Skipped:
2010-01-03  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Eric Seidel.

        [Qt] EventSender: add support for Enter key events
        https://bugs.webkit.org/show_bug.cgi?id=33064

        Unskip 5 tests that are fixed now.

        * DumpRenderTree/qt/EventSenderQt.cpp:
        (EventSender::keyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-03 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 4 Jan 2010 02:10:13 +0000 (02:10 +0000)]
2010-01-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Add test for previous typo fix
        https://bugs.webkit.org/show_bug.cgi?id=33083

        A trivial test for a trivial fix, as requested by Eric.

        * Scripts/modules/bugzilla_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-03 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 4 Jan 2010 02:03:01 +0000 (02:03 +0000)]
2010-01-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement mac-ews
        https://bugs.webkit.org/show_bug.cgi?id=33072

        The mac-ews is slightly different than the other early warning systems
        because we can't run Mac OS X inside a VM.  For that reason, we only
        process patches that were uploaded by committers.  This isn't as much
        coverage as the other EWS bots, but it's better than nothing.

        * Scripts/modules/commands/early_warning_system.py:
        * Scripts/modules/commands/early_warning_system_unittest.py:
        * Scripts/modules/commands/queues.py:
        * Scripts/modules/commands/queuestest.py:
        * Scripts/modules/mock_bugzillatool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-03 Mario Bensi <mbensi@pleyo.com>
eric@webkit.org [Mon, 4 Jan 2010 01:55:55 +0000 (01:55 +0000)]
2010-01-03  Mario Bensi  <mbensi@pleyo.com>

        Reviewed by Simon Fraser.

        create 3d directory and move tests dependent of 3D Rendering in this
        directory.

        https://bugs.webkit.org/show_bug.cgi?id=33081

        * animations/3d: Added.
        * animations/3d/change-transform-in-end-event.html: Copied from LayoutTests/animations/change-transform-in-end-event.html.
        * animations/3d/state-at-end-event-transform.html: Copied from LayoutTests/animations/state-at-end-event-transform.html.
        * animations/3d/transform-origin-vs-functions-expected.txt: Copied from LayoutTests/animations/transform-origin-vs-functions-expected.txt.
        * animations/3d/transform-origin-vs-functions.html: Copied from LayoutTests/animations/transform-origin-vs-functions.html.
        * animations/change-transform-in-end-event.html: Removed.
        * animations/state-at-end-event-transform.html: Removed.
        * animations/transform-origin-vs-functions-expected.txt: Removed.
        * animations/transform-origin-vs-functions.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSkip test that fails on and off on the release bot.
kov@webkit.org [Sun, 3 Jan 2010 21:48:45 +0000 (21:48 +0000)]
Skip test that fails on and off on the release bot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRefactored svn-apply and svn-unapply to use a common "patch"
ddkilzer@apple.com [Sun, 3 Jan 2010 21:25:30 +0000 (21:25 +0000)]
Refactored svn-apply and svn-unapply to use a common "patch"
command method, and added unit tests for this new method.

Patch by Chris Jerdonek <chris.jerdonek@gmail.com> on 2010-01-03
Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=33098

* Scripts/VCSUtils.pm:
  - Added generateRunPatchCommand().
  - Added runPatchCommand().
  - Added exitStatus() from webkitdirs.pm to address FIXME.

* Scripts/VCSUtils_unittest.pl:
  - Added 10 unit tests for generateRunPatchCommand().
  - Added 4 unit tests for runPatchCommand().
  - Added callSilently() method.

* Scripts/svn-apply:
  - Refactored applyPatch().
  - Removed $pathScriptWasRunFrom global variable.
  - Addressed issue where "--force" option was getting added twice.

* Scripts/svn-unapply:
  - Refactored applyPatch().
  - Removed $pathScriptWasRunFrom global variable.
  - Added support for --force option.
  - Enhanced to return meaningful exit status.

* Scripts/webkitdirs.pm:
  - Moved exitStatus() implementation to VCSUtils.pm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Dan Bernstein.
weinig@apple.com [Sun, 3 Jan 2010 19:39:42 +0000 (19:39 +0000)]
Rubber-stamped by Dan Bernstein.

Remove out of date commented out attributes in IDLs. We have implemented onpopstate.

* html/HTMLBodyElement.idl:
* html/HTMLFrameSetElement.idl:
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-31 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Sun, 3 Jan 2010 19:36:38 +0000 (19:36 +0000)]
2009-12-31  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Enable all HTML5 persistent features for QGVLauncher
        https://bugs.webkit.org/show_bug.cgi?id=33086

        * QGVLauncher/main.cpp: Call enablePersistentStorage()
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-03 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sun, 3 Jan 2010 17:45:33 +0000 (17:45 +0000)]
2010-01-03  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Mark more filter effect as alphaImage if possible
        https://bugs.webkit.org/show_bug.cgi?id=33111

        Mark more effects as alphaImage if the previous effect is a
        alphaImage. This can reduce the calculation on the next effect
        like feGaussianBlur.

        Test: This changes don't affect any LayoutTests and can't be tested
              somehow, since the changes are 'invisible'.

        * platform/graphics/filters/FEColorMatrix.cpp:
        (WebCore::FEColorMatrix::apply):
        * svg/graphics/filters/SVGFEMorphology.cpp:
        (WebCore::FEMorphology::apply):
        * svg/graphics/filters/SVGFEOffset.cpp:
        (WebCore::FEOffset::apply):
        * svg/graphics/filters/SVGFETile.cpp:
        (WebCore::FETile::apply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-02 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sat, 2 Jan 2010 19:57:48 +0000 (19:57 +0000)]
2010-01-02  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=33109

        Cleans up the XSSAuditor test directory by removing unnecessary test scripts.

        The patch for bug #33107 added notifyDone() functionality to the script
        echo-intertag.pl. So, we can substitute this script for scripts echo-intertag-and-notify.php,
        echo-intertag-post-and-notify.pl, and echo-intertag-post.pl.

        * http/tests/security/xssAuditor/link-opens-new-window.html: Modified to call script echo-intertag.pl.
        * http/tests/security/xssAuditor/resources/echo-intertag-and-notify.php: Removed.
        * http/tests/security/xssAuditor/resources/echo-intertag-post-and-notify.pl: Removed.
        * http/tests/security/xssAuditor/resources/echo-intertag-post.pl: Removed.
        * http/tests/security/xssAuditor/script-tag-post-control-char.html: Modified to call script echo-intertag.pl.
        * http/tests/security/xssAuditor/script-tag-post-null-char.html: Modified to call script echo-intertag.pl.
        * http/tests/security/xssAuditor/script-tag-post.html: Modified to call script echo-intertag.pl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-02 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sat, 2 Jan 2010 19:54:01 +0000 (19:54 +0000)]
2010-01-02  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=33107

        Removes the use of window.setTimeout from the XSSAuditor tests:
        get-from-iframe.html and post-from-iframe.html by having the
        script echo-intertag.pl (called by these tests) call
        layoutTestController.notifyDone().

        * http/tests/security/xssAuditor/get-from-iframe.html: Removes call of window.setTimeout.
        * http/tests/security/xssAuditor/post-from-iframe.html: Ditto.
        * http/tests/security/xssAuditor/resources/echo-intertag.pl: If the query argument
        notifyDone is found, then the script will generate a JavaScript script to call
        layoutTestController.notifyDone().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2010-01-01 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 1 Jan 2010 19:40:38 +0000 (19:40 +0000)]
2010-01-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Scrollbar of overflow:scroll div in compositing layer fails to render
        https://bugs.webkit.org/show_bug.cgi?id=32439

        When deciding whether a RenderLayer needs backing store, check whether it has
        overflow controls that need painting.

        Test: compositing/overflow/scrollbar-painting.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hasOverflowControls):
        * rendering/RenderLayer.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-31 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Thu, 31 Dec 2009 20:03:23 +0000 (20:03 +0000)]
2009-12-31  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha Silva.

        [GTK] context menu overriding API is very limited
        https://bugs.webkit.org/show_bug.cgi?id=27546

        Only show font menu items in rich text areas in the GTK+ port.

        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-31 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Thu, 31 Dec 2009 19:58:29 +0000 (19:58 +0000)]
2009-12-31  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha Silva.

        [GTK] context menu overriding API is very limited
        https://bugs.webkit.org/show_bug.cgi?id=27546

        Don't show spell checking menu items in text areas in the GTK+ port.

        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/7503279> REGRESSION (r47440): Incomplete repaint at macworldexpo.com
mitz@apple.com [Thu, 31 Dec 2009 18:41:23 +0000 (18:41 +0000)]
<rdar://problem/7503279> REGRESSION (r47440): Incomplete repaint at macworldexpo.com
https://bugs.webkit.org/show_bug.cgi?id=33067

Reviewed by Simon Fraser.

WebCore:

Test: fast/repaint/table-cell-overflow.html

* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::hasVisibleOverflow): Added.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows): Set m_hasOverflowingCell if
any cell has visible overflow, like it was before r47440.

LayoutTests:

* fast/repaint/table-cell-overflow-expected.checksum: Added.
* fast/repaint/table-cell-overflow-expected.png: Added.
* fast/repaint/table-cell-overflow-expected.txt: Added.
* fast/repaint/table-cell-overflow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-31 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Thu, 31 Dec 2009 18:07:03 +0000 (18:07 +0000)]
2009-12-31  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Do not include Frame.h under WebCore/html/canvas
        https://bugs.webkit.org/show_bug.cgi?id=33082

        No new tests, as there is no new functionality.

        * html/canvas/CanvasRenderingContext2D.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-31 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 31 Dec 2009 16:38:37 +0000 (16:38 +0000)]
2009-12-31  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Implement build-and-test
        https://bugs.webkit.org/show_bug.cgi?id=33073

        Some of the early warning system bots want to use build-and-test so
        they can cover LayoutTests in addition to just compilation.

        * Scripts/modules/commands/download.py:
        * Scripts/modules/commands/download_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-31 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 31 Dec 2009 12:49:29 +0000 (12:49 +0000)]
2009-12-31  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Show mac-ews status on QueueStatusServer
        https://bugs.webkit.org/show_bug.cgi?id=33076

        Also make error status purple.

        * QueueStatusServer/model/attachment.py:
        * QueueStatusServer/model/queues.py:
        * QueueStatusServer/templates/dashboard.html:
        * QueueStatusServer/templates/statusbubble.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 31 Dec 2009 08:35:46 +0000 (08:35 +0000)]
2009-12-31  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        [bzt] REGRESSION: Bugzila is a typo
        https://bugs.webkit.org/show_bug.cgi?id=33074

        Eric should test his code before landing!  :)

        * Scripts/modules/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 31 Dec 2009 08:25:34 +0000 (08:25 +0000)]
2009-12-31  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Fix the unit tests!

        * Scripts/run-webkit-unittests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Darin Fisher <darin@chromium.org>
eric@webkit.org [Thu, 31 Dec 2009 04:58:54 +0000 (04:58 +0000)]
2009-12-30  Darin Fisher  <darin@chromium.org>

        Reviewed by David Levin.

        [Chromium] Delete ResourceRequest::securityInfo
        https://bugs.webkit.org/show_bug.cgi?id=26847

        * src/WebWorkerBase.cpp:
        (WebKit::WebWorkerBase::initializeLoader):
2009-12-30  Darin Fisher  <darin@chromium.org>

        Reviewed by David Levin.

        [Chromium] Delete ResourceRequest::securityInfo
        https://bugs.webkit.org/show_bug.cgi?id=26847

        * platform/network/chromium/ResourceRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed. Trivial Chromium build fix.
ajwong@chromium.org [Thu, 31 Dec 2009 00:12:15 +0000 (00:12 +0000)]
Not reviewed.  Trivial Chromium build fix.

Add static_cast<unsigned>() to fix signed/unsigned comparison warning.

* src/AutocompletePopupMenuClient.cpp:
(WebKit::AutocompletePopupMenuClient::selectionChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 30 Dec 2009 23:54:25 +0000 (23:54 +0000)]
2009-12-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        Remove unused code from V8DOMWrapper.

        * bindings/v8/V8DOMWrapper.cpp: Removed code that I added but it's no longer used.
        * bindings/v8/V8DOMWrapper.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 30 Dec 2009 23:47:02 +0000 (23:47 +0000)]
2009-12-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        [V8] Generate configuring undetectable collection.
        https://bugs.webkit.org/show_bug.cgi?id=33063

        Refactoring, covered by existing tests.

        * bindings/scripts/CodeGeneratorV8.pm: Added GenerateImplementationMasqueradeAsUndefined.
        * bindings/v8/DerivedSourcesAllInOne.cpp: Touched to keep IB-based builds happy.
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate): Removed hand-configuring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Zelidrag Hornung <zelidrag@chromium.org>
eric@webkit.org [Wed, 30 Dec 2009 23:08:58 +0000 (23:08 +0000)]
2009-12-30  Zelidrag Hornung  <zelidrag@chromium.org>

        Reviewed by Dimitri Glazkov.

        Autocomplete in Chromium now offers suggestions within the input element as a user
        a) types text that produces some autocomplete suggestions, and
        b) scrolls through suggested values in the menu
        The suggested value is rendered but not exposed through JS unti the
        user makes the final selection.

        No new tests since this new functionality (autocomplete suggestions)
        is intentionally hidden from everything else than renderer.

        * src/AutocompletePopupMenuClient.cpp:
        (WebKit::AutocompletePopupMenuClient::initialize):
        (WebKit::AutocompletePopupMenuClient::setInitialAutocompleteValue):
        (WebKit::AutocompletePopupMenuClient::selectionChanged):
        (WebKit::AutocompletePopupMenuClient::popupDidHide):
        (WebKit::AutocompletePopupMenuClient::setTextFromItem):
        (WebKit::AutocompletePopupMenuClient::resetLastFieldValue):
        * src/AutocompletePopupMenuClient.h:

2009-12-30  Zelidrag Hornung  <zelidrag@chromium.org>

        Reviewed by Dimitri Glazkov.

        Added ability for PopupMenuClient to signal when
        a) selection changed, and
        b) weather suggested value should be accepted when popup menu closes

        No new tests since this new functionality (autocomplete suggestions)
        is intentionally hidden from everything else than renderer.

        * platform/PopupMenuClient.h:
        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::hidePopup):
        (WebCore::PopupListBox::handleKeyEvent):
        (WebCore::PopupListBox::abandon):
        (WebCore::PopupListBox::acceptIndex):
        (WebCore::PopupListBox::selectIndex):
        (WebCore::PopupListBox::clearSelection):
        (WebCore::PopupListBox::hidePopup):
        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenu::menuUnmapped):
        * platform/mac/PopupMenuMac.mm:
        (WebCore::PopupMenu::show):
        * platform/qt/QtFallbackWebPopup.cpp:
        (WebCore::QtFallbackWebPopup::hidePopup):
        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::hide):
        * platform/wx/PopupMenuWx.cpp:
        (WebCore::PopupMenu::OnMenuItemSelected):
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::popupDidHide):
        * rendering/RenderMenuList.h:
        (WebCore::RenderMenuList::selectionChanged):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::popupDidHide):
        * rendering/RenderTextControlSingleLine.h:
        (WebCore::RenderTextControlSingleLine::selectionChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 30 Dec 2009 21:59:07 +0000 (21:59 +0000)]
2009-12-30  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Auto-generate V8 bindings header declarations for
        property accessor getter/setters, and remove a couple of
        unnecessarily custom bindings that weren't properly declared
        custom anyway.

        * Android.v8bindings.mk: Remove V8NavigatorCustom.cpp.
        * WebCore.gypi: Remove V8NavigatorCustom.cpp.
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8DOMWrapper.cpp:
        * bindings/v8/custom/V8AttrCustom.cpp:
        * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
        * bindings/v8/custom/V8ClipboardCustom.cpp:
        * bindings/v8/custom/V8CoordinatesCustom.cpp:
        * bindings/v8/custom/V8CustomBinding.cpp:
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        * bindings/v8/custom/V8DocumentCustom.cpp:
        * bindings/v8/custom/V8DocumentLocationCustom.cpp:
        * bindings/v8/custom/V8EventCustom.cpp:
        * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
        * bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
        * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
        * bindings/v8/custom/V8HTMLInputElementCustom.cpp:
        * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
        * bindings/v8/custom/V8LocationCustom.cpp:
        * bindings/v8/custom/V8MessageEventCustom.cpp:
        * bindings/v8/custom/V8NavigatorCustom.cpp: Removed.
        * bindings/v8/custom/V8SVGLengthCustom.cpp:
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Dirk Schulze <krit@webkit.org>
eric@webkit.org [Wed, 30 Dec 2009 21:24:46 +0000 (21:24 +0000)]
2009-12-30  Dirk Schulze  <krit@webkit.org>

        Reviewed by Anders Carlsson.

        svg/custom/use-on-symbol-inside-pattern.svg is failing
        https://bugs.webkit.org/show_bug.cgi?id=17393

        Reenable the test. It isn't failing anymore.

        * platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.checksum:
        * platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.png:
        * platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
        * svg/custom/use-on-symbol-inside-pattern.svg: Copied from LayoutTests/svg/custom/use-on-symbol-inside-pattern.svg-disabled.
        * svg/custom/use-on-symbol-inside-pattern.svg-disabled: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 30 Dec 2009 20:05:04 +0000 (20:05 +0000)]
2009-12-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, build fix.

        [Chromium] Touch DerivedSourcesAllInOne to avoid clobbering IB-based builds.

        * bindings/v8/DerivedSourcesAllInOne.cpp: Added a line-break.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 30 Dec 2009 19:28:21 +0000 (19:28 +0000)]
2009-12-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        [V8] Generate configuring of call-as-function callbacks.
        https://bugs.webkit.org/show_bug.cgi?id=33061

        Refactoring, covered by existing tests.

        * bindings/scripts/CodeGeneratorV8.pm: Added GenerateHeaderCustomCall and
            GenerateImplementationCustomCall.
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate): Removed all hand-configuring of call-as-function
            callbacks.
        * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
        (WebCore::V8HTMLAppletElement::callAsFunctionCallback): Added.
        (WebCore::V8HTMLEmbedElement::callAsFunctionCallback): Added.
        (WebCore::V8HTMLObjectElement::callAsFunctionCallback): Added.
        * bindings/v8/custom/V8HTMLPlugInElementCustom.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Wed, 30 Dec 2009 19:26:15 +0000 (19:26 +0000)]
Reviewed by Kevin Ollivier.

Introduce wxWebSettings API interface for editing wxWebView / page settings.

https://bugs.webkit.org/show_bug.cgi?id=32956

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 30 Dec 2009 18:37:32 +0000 (18:37 +0000)]
2009-12-30  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        logging.py should be renamed to webkit_logging.py and eventually die
        https://bugs.webkit.org/show_bug.cgi?id=33058

        Change all imports of "logging" to webkit_logging,
        except the ones which came from Google's cpp_lint.py and diff_parser.py
        which clearly are assuming python's logging.py.

        * Scripts/modules/bugzilla.py:
        * Scripts/modules/buildbot.py:
        * Scripts/modules/buildsteps.py:
        * Scripts/modules/commands/download.py:
        * Scripts/modules/commands/queries.py:
        * Scripts/modules/commands/queues.py:
        * Scripts/modules/commands/upload.py:
        * Scripts/modules/credentials.py:
        * Scripts/modules/executive.py:
        * Scripts/modules/multicommandtool.py:
        * Scripts/modules/queueengine.py:
        * Scripts/modules/scm.py:
        * Scripts/modules/statusbot.py:
        * Scripts/modules/stepsequence.py:
        * Scripts/modules/webkit_logging.py: Renamed from WebKitTools/Scripts/modules/logging.py.
        * Scripts/modules/webkit_logging_unittest.py: Renamed from WebKitTools/Scripts/modules/logging_unittest.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 30 Dec 2009 18:22:56 +0000 (18:22 +0000)]
2009-12-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [v8] Move world-specific state out of V8Proxy
        https://bugs.webkit.org/show_bug.cgi?id=33034

        This is the first step towards unifying the V8 implementation of
        isolated worlds with the JSC implementation.  We need an object to
        encapulate all the world-specific bindings state.  Previoulsy, we used
        V8Proxy for this purpose (along with a million other things), but
        there's a one-to-one mapping between V8Proxy objects and Frame objects.

        This patch takes the world-specific state and moves it to a new object,
        affectionately called V8DOMWindowShell.  This object is the moral
        equivalent of JSDOMWindowShell but with more data members because life
        is more complicated in V8-land.

        This patch is almost entirely code motion.  Future patches will clean
        up this class as we use it to represent window shells in isolated
        worlds as well as the main world.

        * WebCore.gypi:
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::updateSecurityOrigin):
        (WebCore::ScriptController::haveInterpreter):
        (WebCore::ScriptController::updateDocument):
        * bindings/v8/V8DOMWindowShell.cpp: Added.
        (WebCore::handleFatalErrorInV8):
        (WebCore::reportFatalErrorInV8):
        (WebCore::reportUnsafeJavaScriptAccess):
        (WebCore::V8DOMWindowShell::create):
        (WebCore::V8DOMWindowShell::V8DOMWindowShell):
        (WebCore::V8DOMWindowShell::isContextInitialized):
        (WebCore::V8DOMWindowShell::disposeContextHandles):
        (WebCore::V8DOMWindowShell::destroyGlobal):
        (WebCore::V8DOMWindowShell::clearForClose):
        (WebCore::V8DOMWindowShell::clearForNavigation):
        (WebCore::V8DOMWindowShell::initContextIfNeeded):
        (WebCore::V8DOMWindowShell::createNewContext):
        (WebCore::V8DOMWindowShell::installDOMWindow):
        (WebCore::V8DOMWindowShell::updateDocumentWrapper):
        (WebCore::V8DOMWindowShell::clearDocumentWrapper):
        (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
        (WebCore::V8DOMWindowShell::clearDocumentWrapperCache):
        (WebCore::V8DOMWindowShell::setSecurityToken):
        (WebCore::V8DOMWindowShell::updateDocument):
        (WebCore::V8DOMWindowShell::updateSecurityOrigin):
        (WebCore::V8DOMWindowShell::getHiddenObjectPrototype):
        (WebCore::V8DOMWindowShell::installHiddenObjectPrototype):
        (WebCore::V8DOMWindowShell::createWrapperFromCacheSlowCase):
        * bindings/v8/V8DOMWindowShell.h: Added.
        (WebCore::V8DOMWindowShell::context):
        (WebCore::V8DOMWindowShell::createWrapperFromCache):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getConstructorForContext):
        (WebCore::V8DOMWrapper::instantiateV8Object):
        (WebCore::V8DOMWrapper::convertDocumentToV8Object):
        (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
        * bindings/v8/V8IsolatedWorld.cpp:
        (WebCore::V8IsolatedWorld::V8IsolatedWorld):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::V8Proxy):
        (WebCore::V8Proxy::~V8Proxy):
        (WebCore::V8Proxy::handleOutOfMemory):
        (WebCore::V8Proxy::evaluateInIsolatedWorld):
        (WebCore::V8Proxy::evaluateInNewContext):
        (WebCore::V8Proxy::setInjectedScriptContextDebugId):
        (WebCore::V8Proxy::clearForClose):
        (WebCore::V8Proxy::clearForNavigation):
        (WebCore::V8Proxy::mainWorldContext):
        (WebCore::V8Proxy::setContextDebugId):
        * bindings/v8/V8Proxy.h:
        (WebCore::V8Proxy::windowShell):
        (WebCore::V8Proxy::extensions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Dirk Schulze <krit@webkit.org>
eric@webkit.org [Wed, 30 Dec 2009 17:50:25 +0000 (17:50 +0000)]
2009-12-30  Dirk Schulze  <krit@webkit.org>

        Reviewed by Eric Seidel.

        SVGResourceClipper needs to invalidate content
        https://bugs.webkit.org/show_bug.cgi?id=33054

        Added invalidate() to SVGResourceClipper to reset clipData
        and drawing area after attribute changes.

        This fixes two LayoutTests.

        * svg/graphics/SVGResourceClipper.cpp:
        (WebCore::SVGResourceClipper::resetClipData):
        (WebCore::SVGResourceClipper::invalidate):
        * svg/graphics/SVGResourceClipper.h:
2009-12-30  Dirk Schulze  <krit@webkit.org>

        Reviewed by Eric Seidel.

        SVGResourceClipper needs to invalidate content
        https://bugs.webkit.org/show_bug.cgi?id=33054

        Drawing area should change after attribute changes in clipPath or
        it's childs.

        * platform/mac/svg/custom/clip-path-child-changes-expected.txt:
        * platform/mac/svg/custom/clip-path-units-changes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Carol Szabo <carol.szabo@nokia.com>
eric@webkit.org [Wed, 30 Dec 2009 17:42:05 +0000 (17:42 +0000)]
2009-12-30  Carol Szabo  <carol.szabo@nokia.com>

        Reviewed by Laszlo Gombos.

         [Qt] RenderThemeQt::applyTheme is a misnomer and is suboptimally coded.
        https://bugs.webkit.org/show_bug.cgi?id=33035

        This patch:
        - renames RenderThemeQt::applyTheme to initializeCommonQStyleOptions,
        - extracts the palette initialization code to a separate function in order to
        provide for readable pointer checking and moves this code up in the function to
        allow for future changes to the palette brushes needed for bug 30173,
        - optimizes some of the code in the function for readability, speed and size.
        - fixes some minor style issues

        No new tests because code behavior is not changed.

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::paintButton):
        (WebCore::RenderThemeQt::paintTextField):
        (WebCore::RenderThemeQt::paintMenuList):
        (WebCore::RenderThemeQt::paintMenuListButton):
        (WebCore::initPaletteFromPageClientIfExists):
        (WebCore::RenderThemeQt::initializeCommonQStyleOptions):
        * platform/qt/RenderThemeQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 30 Dec 2009 16:49:43 +0000 (16:49 +0000)]
2009-12-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        [V8] Generate configuring of all indexers.
        https://bugs.webkit.org/show_bug.cgi?id=33031

        Refactorig, covered by existing tests.

        * bindings/scripts/CodeGeneratorV8.pm: Added generation of indexers for
            special cases.
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate): Removed custom tempalte configuration of
            indexers.
        * bindings/v8/custom/V8CustomBinding.h: Added decls for Applet, Embed, and Object
            elements (these will be generated, too -- later.)
        * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
        (WebCore::npObjectIndexedGetter): Moved common code to a separate method.
        (WebCore::npObjectIndexedSetter): Ditto.
        (WebCore::INDEXED_PROPERTY_GETTER): Added custom handlers for Applet, Embed, and Object
          all calling the common method.
        (WebCore::INDEXED_PROPERTY_SETTER): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Wed, 30 Dec 2009 16:43:55 +0000 (16:43 +0000)]
2009-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] It should be possible to disable inspector
        https://bugs.webkit.org/show_bug.cgi?id=32724

        This change fixes the build break. Some QtWebKit interfaces
        will not be fully functional (most notable QWebInspector) if
        INSPECTOR is disabled.

        * Api/qwebinspector.cpp:
        (QWebInspector::showEvent):
        (QWebInspector::closeEvent):
        * Api/qwebpage.cpp:
        (webActionForContextMenuAction):
        (QWebPagePrivate::getOrCreateInspector):
        (QWebPagePrivate::inspectorController):
        (QWebPage::triggerAction):
        (QWebPage::updatePositionDependentActions):
        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientQt::showWindow):
        (WebCore::InspectorClientQt::closeWindow):
2009-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] It should be possible to disable inspector
        https://bugs.webkit.org/show_bug.cgi?id=32724

        This makes the r48430 available for other ports as well.
        No new tests, as there is no new functionality.

        * inspector/InjectedScriptHost.idl: Guard the interface with
        INSPECTOR guard.

        * inspector/InspectorBackend.idl: Ditto.

        * inspector/InspectorFrontendHost.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 30 Dec 2009 16:13:48 +0000 (16:13 +0000)]
2009-12-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        [V8] Generate configuring of all named property getters/setters/enumerators.
        https://bugs.webkit.org/show_bug.cgi?id=32996

        Refactoring, covered by existing tests.

        * bindings/scripts/CodeGeneratorV8.pm: Added generation of named property handlers
            for special cases (See bug for more info).
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate): Removed custom template configuration of named
            property handlers.
        * bindings/v8/custom/V8CustomBinding.h: Added decls for Applet, Embed, and Object
            elements (these will be generated, too -- later.)
        * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
        (WebCore::npObjectNamedGetter): Moved common code to a separate method.
        (WebCore::npObjectNamedSetter): Ditto.
        (WebCore::NAMED_PROPERTY_GETTER): Added custom handlers for Applet, Embed, and Object
          all calling the common method.
        (WebCore::NAMED_PROPERTY_SETTER): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Wed, 30 Dec 2009 14:58:29 +0000 (14:58 +0000)]
2009-12-30  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix PluginView::handlePostReadFile().
        https://bugs.webkit.org/show_bug.cgi?id=33052

        The function should actually rewrite the given file to the buffer.

        This change fixes http/tests/plugins/post-url-file.html, which can be unskipped
        now along with other passing http/plugins tests.

        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::handlePostReadFile):
2009-12-30  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix PluginView::handlePostReadFile().
        https://bugs.webkit.org/show_bug.cgi?id=33052

        The function should actually rewrite the given file to the buffer.

        This change fixes http/tests/plugins/post-url-file.html, which can be unskipped
        now along with other passing http/plugins tests.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Wed, 30 Dec 2009 14:30:33 +0000 (14:30 +0000)]
2009-12-30  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] layoutTestController.pathToLocalResource() should return a path, not an URL
        https://bugs.webkit.org/show_bug.cgi?id=33051

        Moreover, its primary function is to normalize the path in regard of platform
        specific directory separators. Therefore, it can simply make use of the
        QDir::toNativeSeparators function.

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::pathToLocalResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix executable bits for r52646
ddkilzer@apple.com [Wed, 30 Dec 2009 14:16:04 +0000 (14:16 +0000)]
Fix executable bits for r52646

* Scripts/VCSUtils_unittest.pl: Added property svn:executable.
* Scripts/test-webkit-perl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Revert "Implement ImageDecoderQt::clearFrameBufferCache()" from r52516.
zecke@webkit.org [Wed, 30 Dec 2009 14:12:47 +0000 (14:12 +0000)]
[Qt] Revert "Implement ImageDecoderQt::clearFrameBufferCache()" from r52516.

https://bugs.webkit.org/show_bug.cgi?id=32121

The implementation appears to either run into an ASSERT
or leak memory at runtime as the m_buffer, m_reader may
already exist. The bug was reopened and we do have a plan now.

* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::clearFrameBufferCache):
* platform/graphics/qt/ImageDecoderQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 30 Dec 2009 13:09:59 +0000 (13:09 +0000)]
2009-12-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Skipping isolatedWorld test - we still do not support that.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: [Qt] Add support for Symbian def files
hausmann@webkit.org [Wed, 30 Dec 2009 12:58:39 +0000 (12:58 +0000)]
WebCore: [Qt] Add support for Symbian def files

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-12-30
Reviewed by Simon Hausmann.

* WebCore.pro:

WebKit/qt: Upstream Symbian def files from Qt 4.6.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-12-30
Reviewed by Simon Hausmann.

These files define the ABI of QtWebKit on Symbian.

* symbian/bwins/QtWebKitu.def: Added.
* symbian/eabi/QtWebKitu.def: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed Qt/Symbian build fix.
hausmann@webkit.org [Wed, 30 Dec 2009 12:40:06 +0000 (12:40 +0000)]
Unreviewed Qt/Symbian build fix.

Don't build network state notifier support when building inside of Qt.
Otherwise the Qt build depends on an external module that itself depends
on Qt again.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 30 Dec 2009 12:34:40 +0000 (12:34 +0000)]
2009-12-30  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Dimitri Glazkov.

        [v8] Use current isolated world's context for ScriptCallStack.

        https://bugs.webkit.org/show_bug.cgi?id=33016

        * bindings/v8/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::ScriptCallStack):
        * bindings/v8/ScriptCallStack.h:
        (WebCore::ScriptCallStack::state):
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::mainWorldScriptState):
        (WebCore::ScriptController::currentScriptState):
        (WebCore::ScriptController::clearWindowShell):
        * bindings/v8/ScriptController.h:
        * bindings/v8/V8IsolatedWorld.cpp:
        (WebCore::V8IsolatedWorld::scriptState):
        * bindings/v8/V8IsolatedWorld.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Holger Hans Peter Freyther.
ossy@webkit.org [Wed, 30 Dec 2009 10:46:28 +0000 (10:46 +0000)]
Rubber-stamped by Holger Hans Peter Freyther.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-30
[Qt] Add expected files for the following new passing tests.

* platform/qt/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
* platform/qt/fast/block/float/in-margin-expected.txt: Copied from LayoutTests/platform/mac/fast/block/float/in-margin-expected.txt.
* platform/qt/fast/text/fake-italic-expected.txt: Added.
* platform/qt/svg/custom/empty-mask-expected.txt: Added.
* platform/qt/svg/filters/filter-source-position-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Expected files updated after r52647.
ossy@webkit.org [Wed, 30 Dec 2009 10:20:43 +0000 (10:20 +0000)]
[Qt] Expected files updated after r52647.

Reviewed by Dirk Schulze.

* platform/qt/svg/css/clippath-with-shadow-expected.txt:
* platform/qt/svg/filters/feGaussianBlur-expected.txt:
* platform/qt/svg/filters/feMerge-expected.txt:
* platform/qt/svg/filters/feOffset-expected.txt:
* platform/qt/svg/filters/feTile-expected.txt:
* platform/qt/svg/filters/shadow-on-filter-expected.txt:
* platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
* platform/qt/svg/filters/sourceAlpha-expected.txt:
* platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
* platform/qt/svg/filters/subRegion-one-effect-expected.txt:
* platform/qt/svg/filters/subRegion-two-effects-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Simon Hausmann.
ossy@webkit.org [Wed, 30 Dec 2009 09:20:04 +0000 (09:20 +0000)]
Rubber-stamped by Simon Hausmann.

[Qt] DataGrid support turned off by r52648. Expected files updated.

* platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
* platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.
* platform/qt/fast/js/global-constructors-expected.txt: updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-30 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 30 Dec 2009 08:56:25 +0000 (08:56 +0000)]
2009-12-30  Dirk Schulze  <krit@webkit.org>

        Unreviewed test result fix.

        Detailed boundingBoxes in SVG Renderer
        https://bugs.webkit.org/show_bug.cgi?id=32815

        Forgot to update this test.

        * platform/mac/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTurn off DataGrid support by default.
hausmann@webkit.org [Wed, 30 Dec 2009 08:47:17 +0000 (08:47 +0000)]
Turn off DataGrid support by default.

Patch by Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2009-12-30
Reviewed by Simon Hausmann.

No new tests, as there is no new functionality.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 30 Dec 2009 08:10:44 +0000 (08:10 +0000)]
2009-12-29  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Detailed boundingBoxes in SVG Renderer
        https://bugs.webkit.org/show_bug.cgi?id=32815

        Add new bounding boxes for strokes, filters, masker and clipper in SVG.
        These new bounding boxes help to fix repaintRectInLocalCoordinates.
        We calculate the smallest repaint rect considering the new bounding boxes
        now, filters get the correct paint area, masker clip the mask image size
        to the visible area of the target.

        Tests: Many tests need an update. The changes in repaintRectInLocalCoordinates
               affect the LayoutTests.

        * rendering/RenderForeignObject.h:
        (WebCore::RenderForeignObject::strokeBoundingBox):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::toSVGRenderBase):
        * rendering/RenderObject.h:
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::strokeBoundingBox):
        (WebCore::RenderPath::repaintRectInLocalCoordinates):
        (WebCore::RenderPath::setPath):
        * rendering/RenderPath.h:
        (WebCore::RenderPath::markerBoundingBox):
        * rendering/RenderSVGBlock.h:
        (WebCore::RenderSVGBlock::toSVGRenderBase):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::strokeBoundingBox):
        (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::layout):
        (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
        * rendering/RenderSVGImage.h:
        (WebCore::RenderSVGImage::toSVGRenderBase):
        (WebCore::RenderSVGImage::strokeBoundingBox):
        * rendering/RenderSVGInline.h:
        (WebCore::RenderSVGInline::objectBoundingBox):
        (WebCore::RenderSVGInline::repaintRectInLocalCoordinates):
        * rendering/RenderSVGModelObject.h:
        (WebCore::RenderSVGModelObject::toSVGRenderBase):
        * rendering/RenderSVGRoot.h:
        (WebCore::RenderSVGRoot::strokeBoundingBox):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::strokeBoundingBox):
        (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
        * rendering/RenderSVGText.h:
        (WebCore::RenderSVGText::toSVGRenderBase):
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderBase::~SVGRenderBase):
        (WebCore::SVGRenderBase::prepareToRenderSVGContent):
        (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
        (WebCore::SVGRenderBase::clipperBoundingBoxForRenderer):
        (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer):
        * rendering/SVGRenderSupport.h:
        (WebCore::SVGRenderBase::toSVGRenderBase):
        (WebCore::SVGRenderBase::strokeBoundingBox):
        (WebCore::SVGRenderBase::markerBoundingBox):
        * rendering/SVGRootInlineBox.h:
        (WebCore::SVGRootInlineBox::toSVGRenderBase):
        (WebCore::SVGRootInlineBox::objectBoundingBox):
        (WebCore::SVGRootInlineBox::repaintRectInLocalCoordinates):
        * svg/SVGFilterElement.cpp:
        (WebCore::SVGFilterElement::filterBoundingBox):
        * svg/SVGFilterElement.h:
        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::maskBoundingBox):
        (WebCore::SVGMaskElement::drawMaskerContent):
        * svg/SVGMaskElement.h:
        * svg/graphics/SVGResourceClipper.cpp:
        (WebCore::SVGResourceClipper::clipperBoundingBox):
        * svg/graphics/SVGResourceClipper.h:
        * svg/graphics/SVGResourceFilter.cpp:
        (WebCore::SVGResourceFilter::filterBoundingBox):
        (WebCore::shouldProcessFilter):
        (WebCore::SVGResourceFilter::prepareFilter):
        * svg/graphics/SVGResourceFilter.h:
        * svg/graphics/SVGResourceMasker.cpp:
        (WebCore::SVGResourceMasker::maskerBoundingBox):
        (WebCore::SVGResourceMasker::applyMask):
        * svg/graphics/SVGResourceMasker.h:

2009-12-30  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmmermann.

        Detailed boundingBoxes in SVG Renderer
        https://bugs.webkit.org/show_bug.cgi?id=32815

        Mainly Filter and Masker tests need new test results.
        repaintRectInLocalCoordinates changed to calculate the smallest
        repaint area considering the bounding bo of masker, filter and
        clipper as well as the stroke and marker boundaries.

        * platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
        * platform/mac/svg/batik/filters/feTile-expected.txt:
        * platform/mac/svg/batik/filters/filterRegions-expected.txt:
        * platform/mac/svg/batik/masking/maskRegions-expected.txt:
        * platform/mac/svg/batik/text/textEffect-expected.txt:
        * platform/mac/svg/batik/text/textEffect3-expected.txt:
        * platform/mac/svg/css/clippath-with-shadow-expected.txt:
        * platform/mac/svg/custom/clip-path-display-none-child-expected.txt:
        * platform/mac/svg/custom/clip-path-href-changes-expected.txt:
        * platform/mac/svg/custom/clip-path-referencing-use-expected.txt:
        * platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
        * platform/mac/svg/custom/clip-path-with-transform-expected.txt:
        * platform/mac/svg/custom/empty-merge-expected.txt:
        * platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
        * platform/mac/svg/custom/focus-ring-expected.checksum:
        * platform/mac/svg/custom/focus-ring-expected.png:
        * platform/mac/svg/custom/focus-ring-expected.txt:
        * platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
        * platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
        * platform/mac/svg/custom/js-late-clipPath-creation-expected.txt:
        * platform/mac/svg/custom/mask-excessive-malloc-expected.checksum:
        * platform/mac/svg/custom/mask-excessive-malloc-expected.png:
        * platform/mac/svg/custom/mask-with-all-units-expected.txt:
        * platform/mac/svg/custom/non-opaque-filters-expected.txt:
        * platform/mac/svg/custom/recursive-clippath-expected.txt:
        * platform/mac/svg/custom/text-clip-expected.txt:
        * platform/mac/svg/custom/visibility-override-clip-expected.txt:
        * platform/mac/svg/filters/big-sized-filter-2-expected.txt:
        * platform/mac/svg/filters/big-sized-filter-expected.txt:
        * platform/mac/svg/filters/feDisplacementMap-expected.txt:
        * platform/mac/svg/filters/feMerge-expected.txt:
        * platform/mac/svg/filters/feOffset-expected.txt:
        * platform/mac/svg/filters/feTile-expected.txt:
        * platform/mac/svg/filters/filter-source-position-expected.txt:
        * platform/mac/svg/filters/filterRes-expected.txt:
        * platform/mac/svg/filters/shadow-on-filter-expected.txt:
        * platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
        * platform/mac/svg/filters/subRegion-one-effect-expected.txt:
        * platform/mac/svg/filters/subRegion-two-effects-expected.txt:
        * svg/custom/use-clipped-transform-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Chris Jerdonek <chris.jerdonek@gmail.com>
eric@webkit.org [Wed, 30 Dec 2009 07:19:18 +0000 (07:19 +0000)]
2009-12-29  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by David Kilzer.

        Fixed a bug in fixChangeLogPatch, made it work correctly in
        more circumstances, and added unit tests.

        https://bugs.webkit.org/show_bug.cgi?id=32919

        * Scripts/VCSUtils.pm:
          Rewrote fixChangeLogPatch.

        * Scripts/VCSUtils_unittest.pl: Added.
          Added 7 unit tests for fixChangeLogPatch.

        * Scripts/test-webkit-perl: Added.
          Added test harness for unit tests of Perl code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 30 Dec 2009 06:46:22 +0000 (06:46 +0000)]
2009-12-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Split out BugzillaQueries class from Bugzilla
        https://bugs.webkit.org/show_bug.cgi?id=33042

        * Scripts/modules/bugzilla.py:
         - Split out BugzillaQueries from Bugzilla.
         - Try to isolate self.bugzilla usage into helper functions whenever possible.
         - Add a bunch of FIXMEs.
         - Rename fetch_bug_ids_from_needs_commit_list to fetch_bug_ids_from_pending_commit_list
        * Scripts/modules/bugzilla_unittest.py:
         - Create a new BugzillaQueriesTest testcase and move logic there.
        * Scripts/modules/buildsteps_unittest.py:
         - Use Bug 75 instead of 1 since bug 1 doesn't actually exist.
        * Scripts/modules/commands/queries.py:
         - Update to use bugzilla.queries
        * Scripts/modules/commands/queues.py:
         - Ditto.
        * Scripts/modules/commands/upload.py:
         - Ditto.
        * Scripts/modules/mock_bugzillatool.py:
         - Add a MockBugzillaQueries.
         - Make patches and bugs global privates.
         - Let _id_to_object_dictionary take a variable argument list instead of an array.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Wed, 30 Dec 2009 06:29:24 +0000 (06:29 +0000)]
2009-12-29  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=33041

        Speed up the test method test_read_credentials_with_SVN by not actually
        creating an SVN repository to test against (by default). Instead, it is
        sufficient to create a temporary directory that does not contain a Git
        repository.

        Also, renamed method test_read_credentials_with_SVN to
        test_read_credentials_without_git_repo, to better reflect what it is
        testing.

        * Scripts/modules/credentials_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Wed, 30 Dec 2009 06:04:15 +0000 (06:04 +0000)]
2009-12-29  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=33039

        [bzt] Fixes an issue where bugzilla-tool dies when the keychain lookup
        fails to find an entry for bugs.webkit.org.

        Under Mac OS X, bugzilla-tool tries to query the keychain and Security
        framework (via /usr/sbin/security) for an internet-password entry for
        bugs.webkit.org so that it can use it to login to bugs.webkit.org.
        However, if no such entry exists then bugzilla-tool dies with an error.

        * Scripts/modules/credentials.py: Modified method _parse_security_tool_output to return
        [None, None] if /usr/sbin/security cannot find keychain entry for bugs.webkit.org.
        * Scripts/modules/credentials_unittest.py: Added method test_security_output_parse_entry_not_found.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 30 Dec 2009 05:03:34 +0000 (05:03 +0000)]
2009-12-29  Eric Seidel  <eric@webkit.org>

        Rubber-stamped by Adam Barth.

        Remove unused BugzillaException.

        * Scripts/modules/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 30 Dec 2009 04:47:56 +0000 (04:47 +0000)]
2009-12-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Need a script to assign bugs with r+ patches to committers for landing
        https://bugs.webkit.org/show_bug.cgi?id=33009

        This is just one more small tool to help in the fight against our
        ever-growing list of to-be-committed patches.

        * Scripts/modules/bugzilla.py:
         - Rename assign_to_email to assigned_to_email (typo).
         - Add assigned_to_email() method on Bug.
         - Add reassign_bug method.
         - Add Bugzilla.unassigned_email, eventually should move to some webkit_config.py module.
        * Scripts/modules/bugzilla_unittest.py:
         - Update test after assigned_to_email rename.
        * Scripts/modules/commands/commandtest.py:
         - Call bind_to_tool to that self.tool works in Command testing.
        * Scripts/modules/commands/download.py:
         - Move AbstractDeclarativeCommmand multicommandtool.py, it should be part of Command.
        * Scripts/modules/commands/queries_unittest.py:
         - One of the test patches is now posted by "eric@webkit.org" which is a committer.
         - Eventually we'll mock out CommitterList and be able to better control what's a committer and what's not.
        * Scripts/modules/commands/upload.py:
         - Add new assign-to-committer command.
        * Scripts/modules/commands/upload_unittest.py:
         - Add basic assign-to-committer test.
        * Scripts/modules/committers.py:
         - Add bugzilla_email() accessor.
        * Scripts/modules/committers_unittest.py:
         - Test our assumption that bugzilla_email is the first email.
        * Scripts/modules/mock_bugzillatool.py:
         - Add _id_to_object_dictionary for generating bug_cache from list of bugs.
         - Remove unused fetch_attachments_from_bug.
         - Add fetch_bug support and a bug_cache.
        * Scripts/modules/multicommandtool.py:
         - Move AbstractDeclarativeCommmand here from download.py

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Adam Barth <abarth@webkit.org>
eric@webkit.org [Wed, 30 Dec 2009 04:19:58 +0000 (04:19 +0000)]
2009-12-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Don't crash if user types a number during PromptForBugOrTitleStep
        https://bugs.webkit.org/show_bug.cgi?id=33038

        Simple fix with test.

        * Scripts/modules/buildsteps.py:
        * Scripts/modules/buildsteps_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Adam Barth <abarth@webkit.org>
eric@webkit.org [Wed, 30 Dec 2009 04:12:07 +0000 (04:12 +0000)]
2009-12-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] post-diff requires reading to the end
        https://bugs.webkit.org/show_bug.cgi?id=33036

        Catch the IOError caused by not reading to the end of the diff.  We
        don't have a good way to test this currently.

        * Scripts/modules/user.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Adam Barth <abarth@webkit.org>
eric@webkit.org [Wed, 30 Dec 2009 00:48:13 +0000 (00:48 +0000)]
2009-12-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Add a test for window.top and isolated worlds
        https://bugs.webkit.org/show_bug.cgi?id=33030

        I wrote this test to investigate an issue that turns out is working
        properly.  No sense wasting a perfectly good test, so we should add it.

        * http/tests/security/isolatedWorld/top-properties-expected.txt: Added.
        * http/tests/security/isolatedWorld/top-properties.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Tue, 29 Dec 2009 23:19:45 +0000 (23:19 +0000)]
2009-12-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Maciej Stachowiak.

        PLATFORM(CAIRO) should be defined by WIN_CAIRO define
        https://bugs.webkit.org/show_bug.cgi?id=22250

        * wtf/Platform.h: Define WTF_PLATFORM_CAIRO for GTK port only
        For the WinCairo port WTF_PLATFORM_CAIRO is already defined in config.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Chang Shu <Chang.Shu@nokia.com>
eric@webkit.org [Tue, 29 Dec 2009 23:06:30 +0000 (23:06 +0000)]
2009-12-29  Chang Shu  <Chang.Shu@nokia.com>

        Reviewed by Adam Barth.

        [Qt] Move logic that handles Qt headers before primary headers
        so that Qt headers won't be treated as primary headers by mistake.
        https://bugs.webkit.org/show_bug.cgi?id=32991

        * Scripts/modules/cpp_style.py:
        * Scripts/modules/cpp_style_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Andrei Popescu <andreip@google.com>
eric@webkit.org [Tue, 29 Dec 2009 22:50:32 +0000 (22:50 +0000)]
2009-12-29  Andrei Popescu  <andreip@google.com>

        Reviewed by Adam Barth.

        Add Android hook to NetworkStateNotifier class
        so that the Java side can notify WebCore when the
        network state changes.
        https://bugs.webkit.org/show_bug.cgi?id=32871

        No new tests required, this is platform code.

        * platform/network/NetworkStateNotifier.h:
        * platform/network/android/NetworkStateNotifierAndroid.cpp: Added.
        (WebCore::NetworkStateNotifier::networkStateChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Simon Hausmann.
ossy@webkit.org [Tue, 29 Dec 2009 22:32:29 +0000 (22:32 +0000)]
Rubber-stamped by Simon Hausmann.

[Qt] Remove a bunch of now passing tests from skiplist.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 29 Dec 2009 22:08:30 +0000 (22:08 +0000)]
2009-12-29  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52630.
        https://bugs.webkit.org/show_bug.cgi?id=33012
        http://trac.webkit.org/changeset/52630

        This caused 2 layout test failures, and 2 layout test crashes on Leopard bots.

        * platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-1-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-2-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-3-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-4-expected.txt:
        * platform/mac/svg/custom/js-late-marker-and-object-creation-expected.txt:
        * platform/mac/svg/custom/js-late-marker-creation-expected.txt:
        * platform/mac/svg/custom/marker-changes-expected.checksum:
        * platform/mac/svg/custom/marker-changes-expected.png:
        * platform/mac/svg/custom/marker-changes-expected.txt:
        * platform/mac/svg/custom/marker-child-changes-expected.checksum:
        * platform/mac/svg/custom/marker-child-changes-expected.png:
        * platform/mac/svg/custom/marker-child-changes-expected.txt:
        * platform/mac/svg/custom/marker-default-width-height-expected.txt:
        * platform/mac/svg/custom/marker-overflow-clip-expected.txt:
        * platform/mac/svg/custom/marker-referencePoint-expected.checksum: Removed.
        * platform/mac/svg/custom/marker-referencePoint-expected.png: Removed.
        * platform/mac/svg/custom/marker-referencePoint-expected.txt: Removed.
        * platform/mac/svg/custom/marker-viewBox-changes-expected.checksum:
        * platform/mac/svg/custom/marker-viewBox-changes-expected.png:
        * platform/mac/svg/custom/marker-viewBox-changes-expected.txt:
        * platform/mac/svg/custom/non-circular-marker-reference-expected.txt:
        * platform/mac/svg/custom/shapes-supporting-markers-expected.txt:
        * svg/custom/marker-referencePoint.svg: Removed.
2009-12-29  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52630.
        http://trac.webkit.org/changeset/52630

        Change caused layout tests failures and crashes.

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::repaintRectInLocalCoordinates):
        (WebCore::RenderPath::setPath):
        (WebCore::RenderPath::path):
        (WebCore::RenderPath::paint):
        (WebCore::):
        (WebCore::DrawMarkersData::DrawMarkersData):
        (WebCore::drawMarkerWithData):
        (WebCore::updateMarkerDataForElement):
        (WebCore::drawStartAndMidMarkers):
        (WebCore::RenderPath::drawMarkersIfNeeded):
        * rendering/RenderPath.h:
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::paint):
        * rendering/RenderSVGViewportContainer.h:
        * rendering/SVGMarkerLayoutInfo.cpp: Removed.
        * rendering/SVGMarkerLayoutInfo.h: Removed.
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::canvasResource):
        * svg/graphics/SVGResource.cpp:
        (WebCore::SVGResource::SVGResource):
        (WebCore::ResourceSet::ResourceSet):
        (WebCore::clientMap):
        (WebCore::SVGResource::~SVGResource):
        (WebCore::SVGResource::removeClient):
        (WebCore::SVGResource::addClient):
        * svg/graphics/SVGResourceMarker.cpp:
        (WebCore::SVGResourceMarker::SVGResourceMarker):
        (WebCore::SVGResourceMarker::setMarker):
        (WebCore::SVGResourceMarker::setRef):
        (WebCore::SVGResourceMarker::draw):
        (WebCore::SVGResourceMarker::cachedBounds):
        (WebCore::SVGResourceMarker::externalRepresentation):
        * svg/graphics/SVGResourceMarker.h:
        (WebCore::SVGResourceMarker::refX):
        (WebCore::SVGResourceMarker::refY):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMove the focus ring rect array, width and offset out of GraphicsContext
mitz@apple.com [Tue, 29 Dec 2009 21:05:56 +0000 (21:05 +0000)]
Move the focus ring rect array, width and offset out of GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=33028

Reviewed by Sam Weinig.

* platform/graphics/GraphicsContext.cpp: Removed initFocusRing(),
clearFocusRing(), focusRingBoundingRect(), addFocusRingRect(),
focusRingWidth(), focusRingOffset(), and focusRingRects().
* platform/graphics/GraphicsContext.h: Ditto. Added the focus ring rect
vector, width and offset as parameters to drawFocusRing().
* platform/graphics/GraphicsContextPrivate.h:
(WebCore::GraphicsContextState::GraphicsContextState): Cleaned up style.
(WebCore::GraphicsContextPrivate::GraphicsContextPrivate): Removed
m_focusRingRects, m_focusRingWidth and m_focusRingOffset.
* platform/graphics/IntRect.cpp:
(WebCore::unionRect): Added this helper function.
* platform/graphics/IntRect.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawFocusRing):
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::drawFocusRing): Ditto.
* platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawFocusRing): Ditto.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawFocusRing): Ditto.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawFocusRing): Ditto.
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::drawFocusRing): Ditto.
* platform/graphics/wince/GraphicsContextWince.cpp:
(WebCore::GraphicsContext::drawFocusRing): Ditto.
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::drawFocusRing): Ditto.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addFocusRingRects): Updated for new prototype.
Added empty rect checks that were previously done in
GraphicsContext::addFocusRingRect().
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::addFocusRingRects): Ditto.
* rendering/RenderBox.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::addFocusRingRects): Ditto.
(WebCore::RenderInline::paintOutline): Collect focus ring rects into a
vector and pass it to drawFocusRing(). Use unionRect() instead of
focusRingBoundingRect().
* rendering/RenderInline.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::paintOutline): Ditto.
* rendering/RenderObject.h:
(WebCore::RenderObject::addFocusRingRects): Changed to take a
Vector<IntRect> to which the rects are added.
* rendering/RenderPath.cpp:
(WebCore::RenderPath::addFocusRingRects): Updated for new prototype.
Added empty rect check that was previously done in
GraphicsContext::addFocusRingRect().
* rendering/RenderPath.h:
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::addFocusRingRects): Updated for new prototype.
Added empty rect check that was previously done in
GraphicsContext::addFocusRingRect().
* rendering/RenderSVGContainer.h:
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::addFocusRingRects): Updated for new prototype.
Added empty rect check that was previously done in
GraphicsContext::addFocusRingRect().
* rendering/RenderSVGImage.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::addFocusRingRects): Updated for new prototype.
Added empty rect check that was previously done in
GraphicsContext::addFocusRingRect().
* rendering/RenderTextControl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago1. Changes the order in which some functions are called to match
dumi@chromium.org [Tue, 29 Dec 2009 20:51:32 +0000 (20:51 +0000)]
1. Changes the order in which some functions are called to match
the pre-r52536 order. Namely, when a new Database object is
created, DatabaseTracker::addOpenDatabase() is called in the
constructor, before doing anything else related to that database
(like trying to get a file handle to the database
file). Chromium's implementation depends on this ordering.
2. Changes Database::performOpenAndVerify() to close the open
handle to the database file immediately if the database version
does not match the expected one. The current behavior is to add
the Database object to a DatabaseThread collection and let the
database thread close the handle when it's destroyed.

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=33005

All LayoutTests/storage tests pass in clean WebKit and Chromium
clients.

* storage/Database.cpp:
(WebCore::Database::openDatabase): Notify DatabaseTracker and
Document that a Database object is about to be destroyed (when a
database file cannot be opened, or its version doesn't match the
expected one).
(WebCore::Database::Database): Notify DatabaseTracker and Document
that a new Database object was created.
(WebCore::Database::performOpenAndVerify): If a database version
does not match the expected one, immediately close the open file
handle to the database file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Nikolas Zimmermann <nzimmermann@rim.com>
krit@webkit.org [Tue, 29 Dec 2009 20:46:17 +0000 (20:46 +0000)]
2009-12-29  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Marker code is buggy: referencePoint translation is off
        https://bugs.webkit.org/show_bug.cgi?id=33012

        Rewrite marker code, as it was buggy:
        - Correct refX/refY handling (covered by new marker-referencePoint.svg test)
        - Calculate marker bounds on layout time, instead of paint time, to deliver correct repaint rects
        - Cleanup RenderPath code, which was cluttered by marker stuff (outlay in SVGMarkerLayoutInfo)
        - Fix SVGResource assuming that there is only one resource per resource type per element. Markers
          can have three different resources of the same type (three markers, start/mid/end markers)

        Fixes all svg/custom/marker*.svg tests, that use dynamic updates (propagation failed before).
        Test: svg/custom/marker-referencePoint.svg

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::repaintRectInLocalCoordinates):
        (WebCore::RenderPath::setPath):
        (WebCore::RenderPath::paint):
        (WebCore::RenderPath::calculateMarkerBoundsIfNeeded):
        * rendering/RenderPath.h:
        (WebCore::RenderPath::path):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::markerContentTransformation):
        * rendering/RenderSVGViewportContainer.h:
        * rendering/SVGMarkerLayoutInfo.cpp: Added.
        (WebCore::SVGMarkerLayoutInfo::SVGMarkerLayoutInfo):
        (WebCore::SVGMarkerLayoutInfo::~SVGMarkerLayoutInfo):
        (WebCore::SVGMarkerLayoutInfo::initialize):
        (WebCore::updateMarkerDataForElement):
        (WebCore::recordMarkerData):
        (WebCore::processStartAndMidMarkers):
        (WebCore::SVGMarkerLayoutInfo::calculateBoundaries):
        (WebCore::SVGMarkerLayoutInfo::drawMarkers):
        * rendering/SVGMarkerLayoutInfo.h: Added.
        (WebCore::MarkerData::):
        (WebCore::MarkerData::MarkerData):
        (WebCore::MarkerLayout::MarkerLayout):
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::canvasResource):
        * svg/graphics/SVGResource.cpp:
        (WebCore::resourceSet):
        (WebCore::SVGResource::SVGResource):
        (WebCore::SVGResource::~SVGResource):
        (WebCore::SVGResource::removeClient):
        (WebCore::SVGResource::addClient):
        * svg/graphics/SVGResourceMarker.cpp:
        (WebCore::SVGResourceMarker::SVGResourceMarker):
        (WebCore::SVGResourceMarker::markerBoundaries):
        (WebCore::SVGResourceMarker::markerTransformation):
        (WebCore::SVGResourceMarker::draw):
        (WebCore::SVGResourceMarker::externalRepresentation):
        * svg/graphics/SVGResourceMarker.h:
        (WebCore::SVGResourceMarker::setRenderer):
        (WebCore::SVGResourceMarker::setReferencePoint):
        (WebCore::SVGResourceMarker::referencePoint):

2009-12-29  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Marker code is buggy: referencePoint translation is off
        https://bugs.webkit.org/show_bug.cgi?id=33012

        Update SVG test baseline, after rewriting marker support.

        * platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-1-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-2-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-3-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-4-expected.txt:
        * platform/mac/svg/custom/js-late-marker-and-object-creation-expected.txt:
        * platform/mac/svg/custom/js-late-marker-creation-expected.txt:
        * platform/mac/svg/custom/marker-changes-expected.checksum:
        * platform/mac/svg/custom/marker-changes-expected.png:
        * platform/mac/svg/custom/marker-changes-expected.txt:
        * platform/mac/svg/custom/marker-child-changes-expected.checksum:
        * platform/mac/svg/custom/marker-child-changes-expected.png:
        * platform/mac/svg/custom/marker-child-changes-expected.txt:
        * platform/mac/svg/custom/marker-default-width-height-expected.txt:
        * platform/mac/svg/custom/marker-overflow-clip-expected.txt:
        * platform/mac/svg/custom/marker-referencePoint-expected.checksum: Added.
        * platform/mac/svg/custom/marker-referencePoint-expected.png: Added.
        * platform/mac/svg/custom/marker-referencePoint-expected.txt: Added.
        * platform/mac/svg/custom/marker-viewBox-changes-expected.checksum:
        * platform/mac/svg/custom/marker-viewBox-changes-expected.png:
        * platform/mac/svg/custom/marker-viewBox-changes-expected.txt:
        * platform/mac/svg/custom/non-circular-marker-reference-expected.txt:
        * platform/mac/svg/custom/shapes-supporting-markers-expected.txt:
        * svg/custom/marker-referencePoint.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Tue, 29 Dec 2009 19:55:59 +0000 (19:55 +0000)]
2009-12-29  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Fix UI nits in the Audits panel.
        https://bugs.webkit.org/show_bug.cgi?id=32932

        * inspector/front-end/AuditLauncherView.js:
        (WebInspector.AuditLauncherView.prototype._selectAllClicked):
        (WebInspector.AuditLauncherView.prototype._createCategoryElement):
        (WebInspector.AuditLauncherView.prototype._createLauncherUI.handleSelectAllClick):
        (WebInspector.AuditLauncherView.prototype._createLauncherUI):
        * inspector/front-end/AuditResultView.js:
        (WebInspector.AuditResultView):
        (WebInspector.AuditRuleResultPane):
        * inspector/front-end/audits.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 29 Dec 2009 19:33:01 +0000 (19:33 +0000)]
2009-12-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add the start of a Bug object for bugzilla.py
        https://bugs.webkit.org/show_bug.cgi?id=32995

        This allowed us to get rid of some duplicated "is_obsolete" checks.

        * Scripts/modules/bugzilla.py:
         - Add a new Bug class, and move patches/unreviewed_patches filtering logic there.
         - Add _fetch_bug_page for possible future mocking.
           (I did not try to test fetch_*_from_bug now due to difficulties with our current validate_reviewer logic.)
         - Rename fetch_bug to fetch_bug_dictionary and add a new fetch_bug which returns a Bug object.
         - Use fetch_bug and attachments(), patches(), etc. instead of custom fetch_*_from_bug methods.
         - Reduce code in fetch_patches_from_pending_commit_list and fetch_patches_from_review_queue
           using list comprehensions. Use a sum(list, []) trick to flatten a list of lists into a single list.
        * Scripts/modules/bugzilla_unittest.py:
         - Remove an unneeded unicode string marker.
        * Scripts/modules/buildsteps.py:
         - define __all__ to include just the BuildSteps
        * Scripts/modules/commands/download.py:
         - import * now that we have an __all__ defined.
        * Scripts/modules/commands/upload.py:
         - Use fetch_bug_dictionary instead of fetch_bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Johnny Ding <jnd@chromium.org>
eric@webkit.org [Tue, 29 Dec 2009 19:25:08 +0000 (19:25 +0000)]
2009-12-29  Johnny Ding  <jnd@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=32863
        Make NodeList support call-as-function

        Test: fast/dom/NodeList/nodelist-item-call-as-function.html

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate):
        * bindings/v8/custom/V8NodeListCustom.cpp:
        (WebCore::V8NodeList::callAsFunctionCallback):
2009-12-29  Johnny Ding  <jnd@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=32863
        Make NodeList support call-as-function.

        * fast/dom/NodeList/nodelist-item-call-as-function-expected.txt: Added.
        * fast/dom/NodeList/nodelist-item-call-as-function.html: Added.
        * fast/dom/NodeList/script-tests: Added.
        * fast/dom/NodeList/script-tests/TEMPLATE.html: Added.
        * fast/dom/NodeList/script-tests/nodelist-item-call-as-function.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 29 Dec 2009 18:27:33 +0000 (18:27 +0000)]
2009-12-29  Daniel Bates  <dbates@webkit.org>

        Reviewed by Ariya Hidayat.

        https://bugs.webkit.org/show_bug.cgi?id=32925

        Adds an Open File dialog to make it convenient to open a file
        to view in the browser.

        * QGVLauncher/main.cpp:
        (MainWindow::load): Modified to call loadURL.
        (MainWindow::openFile): Added.
        (MainWindow::loadURL): Added.
        (MainWindow::buildUI): Added menu item Open File.
2009-12-29  Daniel Bates  <dbates@webkit.org>

        Reviewed by Ariya Hidayat.

        https://bugs.webkit.org/show_bug.cgi?id=32925

        Adds an Open File dialog to make it convenient to open a file
        to view in the browser.

        Currently a person must either specify the path to a file as a
        command-line argument or type a file URL. Instead, we should
        have a file dialog to allow a person to open a file without
        memorizing its path.

        * QtLauncher/main.cpp:
        (MainWindow::MainWindow): Changed urlEdit->setText(qurl.toEncoded())
        to urlEdit->setText(qurl.toString()).
        (MainWindow::openFile): Added.
        (MainWindow::changeLocation): Moved code to load URL into method
        MainWindow::loadURL.
        (MainWindow::loadURL): Added.
        (MainWindow::setupUI): Added menu item Open File.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Robert Hogan <robert@roberthogan.net>
eric@webkit.org [Tue, 29 Dec 2009 17:44:32 +0000 (17:44 +0000)]
2009-12-29  Robert Hogan  <robert@roberthogan.net>

        Reviewed by Eric Seidel.

        [Qt] Fix crash on LayoutTests/fast/loader/empty-embed-src-attribute.html

        Related to https://bugs.webkit.org/show_bug.cgi?id=23806

        If an embedded document is loaded within a page and it has an empty
        URL, use a blank URL for the load request.

        https://bugs.webkit.org/show_bug.cgi?id=33017

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::createFrame):
2009-12-29  Robert Hogan  <robert@roberthogan.net>

        Reviewed by Eric Seidel.

        [Qt] Fix crash on LayoutTests/fast/loader/empty-embed-src-attribute.html

        Related to https://bugs.webkit.org/show_bug.cgi?id=23806

        If an embedded document is loaded within a page and it has an empty
        URL, use a blank URL for the load request.

        https://bugs.webkit.org/show_bug.cgi?id=33017

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 29 Dec 2009 17:18:45 +0000 (17:18 +0000)]
2009-12-29  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Typed text in table not correctly redrawn on page with compositing layers
        https://bugs.webkit.org/show_bug.cgi?id=32874

        Use the same test in RenderTableCell::computeRectForRepaint() that we use elsewhere
        to decide when to use layoutState, which is to test for layoutStateEnabled()
        and no repaint container.

        Not possible to make a repaint test that exercises the problem, so no test.

        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::computeRectForRepaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Tue, 29 Dec 2009 16:51:14 +0000 (16:51 +0000)]
2009-12-29  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Timothy Hatcher.

        Discard port from cookie domain when matching cookies.

        WebKit cookies do not hold the port information, so we should match only hostnames.
        https://bugs.webkit.org/show_bug.cgi?id=31787

        * inspector/front-end/inspector.js:
        (WebInspector.updateResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Tue, 29 Dec 2009 15:55:51 +0000 (15:55 +0000)]
2009-12-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Rubber-stamped by Simon Hausmann and Holger Freyther.

        [Qt] Remove WebKit/qt/WebKitPart empty directory

        The content of the directory has been removed by r34888.

        * WebKitPart: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Tue, 29 Dec 2009 15:32:56 +0000 (15:32 +0000)]
2009-12-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix warnings in MediaPlayerPrivatePhonon.cpp
        https://bugs.webkit.org/show_bug.cgi?id=33019

        No new tests as there is no new functionality.

        * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
        (WebCore::MediaPlayerPrivate::totalTimeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-29 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Tue, 29 Dec 2009 14:28:58 +0000 (14:28 +0000)]
2009-12-29  Kent Tamura  <tkent@chromium.org>

        Reviewed by Maciej Stachowiak.

        Implement HTML5 <aside> element.
        https://bugs.webkit.org/show_bug.cgi?id=32943

        <aside> should behave the same as <nav>, <section>, and <article>.

        Test: fast/html/aside-element.html

        * css/html.css: Add aside as a block element.
        * editing/htmlediting.cpp:
        (WebCore::validBlockTag): Add asideTag.
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::tagPriority): Returns 5 for asideTag.
        (WebCore::blockTagList): Add asideTag.
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::getNode): Add asideTag.
        * html/HTMLTagNames.in: Add aside.
2009-12-29  Kent Tamura  <tkent@chromium.org>

        Reviewed by Maciej Stachowiak.

        Implement HTML5 <aside> element.
        https://bugs.webkit.org/show_bug.cgi?id=32943

        The new test file tests:
        - <p> closing,
        - Residual style, and
        - FormatBlock.

        * fast/html/aside-element-expected.txt: Added.
        * fast/html/aside-element.html: Added.
        * fast/html/script-tests/aside-element.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-12-27 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 29 Dec 2009 13:52:57 +0000 (13:52 +0000)]
2009-12-27  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Alexey Proskuryakov.

        plugins/get-url-with-iframe-target.html fails on SnowLeopard (64-bit)
        https://bugs.webkit.org/show_bug.cgi?id=32982

        This test has been failing on SnowLeopard since it was landed.

        The problem is that we never delivered the notification for
        NPN_GetURLNotify, in the frame-targeting case, for out-of-process
        plugins on Mac.

        I implemented support for this based on how in-process Mac plugins
        do it.

        * Plugins/Hosted/HostedNetscapePluginStream.h:
        * Plugins/Hosted/HostedNetscapePluginStream.mm:
        (WebKit::HostedNetscapePluginStream::reasonForError):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::PluginRequest::create):
        (WebKit::NetscapePluginInstanceProxy::PluginRequest::PluginRequest):
        (WebKit::NetscapePluginInstanceProxy::destroy):
        (WebKit::NetscapePluginInstanceProxy::performRequest):
        (WebKit::NetscapePluginInstanceProxy::webFrameDidFinishLoadWithReason):
        (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
        (WebKit::NetscapePluginInstanceProxy::loadRequest):
        * Plugins/Hosted/WebHostedNetscapePluginView.h:
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView webFrame:didFinishLoadWithReason:]):
        (-[WebHostedNetscapePluginView webFrame:didFinishLoadWithError:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52619 268f45cc-cd09-0410-ab3c-d52691b4dbfc