15 years ago2007-06-08 Mark Rowe <mrowe@apple.com>
bdash [Fri, 8 Jun 2007 06:50:59 +0000 (06:50 +0000)]
2007-06-08  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Hyatt.

        Switch to using Internet Explorer's conditional comments to target IE-specific styles rather
        than doing server-side user agent checks.  This resolves an issue some people were seeing where
        caching would lead to a page generated for an Internet Explorer user being served to a Safari
        user.  The visible symptom of this was many of the graphics were missing.

        * blog/wp-content/themes/webkit/header.php:
        * header.inc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam "The Intern" Weinig.
oliver [Fri, 8 Jun 2007 06:38:16 +0000 (06:38 +0000)]
    Reviewed by Sam "The Intern" Weinig.

        Don't be overzealous with the input checks, firstRectForCharacterRange
        can be determined even when there is not an active editable region.

        This unbreaks editing/input/range-for-empty-document which was broken
        by aforementioned overzealousness.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView firstRectForCharacterRange:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix crash. Null check layer. Bug 13984.
hyatt [Fri, 8 Jun 2007 05:25:17 +0000 (05:25 +0000)]
    Fix crash.  Null check layer.  Bug 13984.

        Reviewed by andersca

        * WebCore.xcodeproj/project.pbxproj:
        * page/FrameView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
oliver [Fri, 8 Jun 2007 03:07:04 +0000 (03:07 +0000)]

        Reviewed by Justin.

        Remove incorrect assertions.

        These assertions were made on the assumption that
        TSM would always call with a range that was contained
        by an editable region.

        TSM may call -[WebHTMLView characterIndexForPoint:] on a mouse
        event that is otherwise unrelated to editing, which may
        be outside the current editing region, triggering these

        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge convertToNSRange:]):


        Reviewed by Justin.

        Add checks to make sure we don't try to create, use
        or return invalid ranges to TSM when it calls us despite
        not currently being in an editable region.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView textStorage]):
        (-[WebHTMLView firstRectForCharacterRange:]):
        (-[WebHTMLView selectedRange]):
        (-[WebHTMLView attributedSubstringFromRange:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Fri, 8 Jun 2007 00:02:06 +0000 (00:02 +0000)]

        Reviewed by John.

        <rdar://problem/5237074> REGRESSION: editing/unsupported-content/table-delete-003 is failing (13931)

        Corrected the description and added a FIXME:
        * editing/unsupported-content/table-delete-003-expected.checksum:
        * editing/unsupported-content/table-delete-003-expected.png:
        * editing/unsupported-content/table-delete-003-expected.txt:
        * editing/unsupported-content/table-delete-003.html:


        Reviewed by John.

        <rdar://problem/5237074> REGRESSION: editing/unsupported-content/table-delete-003 is failing (13931)

        * editing/DeleteSelectionCommand.cpp:
        We wouldn't expand the selection to include a special element
        at the start of the selection unless the end of the selection
        was at the end of a special element. Avoid a special
        element at the start as long as it's fully selected. Ditto for
        the end.
        * editing/htmlediting.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
andersca [Thu, 7 Jun 2007 23:16:37 +0000 (23:16 +0000)]
    Reviewed by Geoff.

        Get rid of Instance::setRootObject and pass the root object to the instance constructor instead.

        * bindings/c/c_instance.cpp:
        * bindings/c/c_instance.h:
        * bindings/jni/jni_instance.cpp:
        * bindings/jni/jni_instance.h:
        * bindings/jni/jni_jsobject.cpp:
        * bindings/objc/objc_instance.h:
        * bindings/objc/objc_instance.mm:
        * bindings/runtime.cpp:
        * bindings/runtime.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
andersca [Thu, 7 Jun 2007 22:31:46 +0000 (22:31 +0000)]
    Reviewed by Adam.

        Don't use a JavaInstance to store the field when all we want to do is to keep the field
        from being garbage collected. Instead, use a JObjectWrapper.

        * bindings/jni/jni_instance.h:
        * bindings/jni/jni_runtime.cpp:
        * bindings/jni/jni_runtime.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Thu, 7 Jun 2007 20:58:15 +0000 (20:58 +0000)]

        Reviewed by Anders.

        Update test for http://bugs.webkit.org/show_bug.cgi?id=14028
        Finish autogenerating the JS bindings for Node

        * fast/dom/prototype-chain-expected.txt: DOMNodePrototype is no longer in the prototype chain.


        Reviewed by Anders.

        Patch for  http://bugs.webkit.org/show_bug.cgi?id=14028
        Finish autogenerating the JS bindings for Node

        * DerivedSources.make:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSHTMLElementWrapperFactory.cpp:
        * bindings/js/JSHTMLElementWrapperFactory.h:
        * bindings/js/JSHTMLOptionElementConstructor.cpp:
        * bindings/js/JSNamedNodeMapCustom.cpp:
        * bindings/js/JSNodeCustom.cpp:
        * bindings/js/JSSVGElementWrapperFactory.cpp:
        * bindings/js/JSSVGElementWrapperFactory.h:
        * bindings/js/JSXSLTProcessor.cpp:
        * bindings/js/kjs_binding.cpp:
        * bindings/js/kjs_binding.h:
        * bindings/js/kjs_dom.cpp:
        * bindings/js/kjs_dom.h:
        * bindings/js/kjs_domnode.h: Removed.
        * bindings/objc/DOMUtility.mm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Node.h:
        * dom/Node.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@22044 268f45cc-cd09-0410...
adele [Thu, 7 Jun 2007 18:34:04 +0000 (18:34 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Another Gdk and Qt build fix.
weinig [Thu, 7 Jun 2007 08:07:43 +0000 (08:07 +0000)]
    Another Gdk and Qt build fix.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Gdk and Qt build fix.
weinig [Thu, 7 Jun 2007 07:48:30 +0000 (07:48 +0000)]
    Gdk and Qt build fix.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Thu, 7 Jun 2007 04:28:36 +0000 (04:28 +0000)]

        Reviewed by Hyatt.

        Update tests for http://bugs.webkit.org/show_bug.cgi?id=13973
        Autogenerate most of the rest of kjs_dom.h/cpp

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/prototype-chain-expected.txt:


        Reviewed by Hyatt.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13973
        Autogenerate most of the rest of kjs_dom.h/cpp

        - Autogenerate JSNodeList and JSNamedNodeMap.
        - Move JSEventTargetNode, JSNamedNodesCollection, and JSDOMExceptionConstructor
          into their own files.
        - Rename KJS::DOMEventTargeNode to WebCore::JSEventTargetNode to adhere
          to convention and allow easier code generation.
        - Add JS constructors for JSNodeList and JSNamedNodeMap.
        - Moved more toJS methods into the correct (corresponding) header files.
        - Cleaned up code in order for changes to work.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMExceptionConstructor.cpp: Added.
        * bindings/js/JSDOMExceptionConstructor.h: Added.
        * bindings/js/JSDOMWindowCustom.cpp: Added.
        * bindings/js/JSDocumentCustom.cpp:
        * bindings/js/JSEventTargetNode.cpp: Added.
        * bindings/js/JSEventTargetNode.h: Added.
        * bindings/js/JSHTMLElementCustom.cpp:
        * bindings/js/JSHTMLFormElementCustom.cpp:
        * bindings/js/JSHTMLOptionElementConstructor.cpp:
        * bindings/js/JSNamedNodeMapCustom.cpp: Added.
        * bindings/js/JSNamedNodesCollection.cpp: Added.
        * bindings/js/JSNamedNodesCollection.h: Added.
        * bindings/js/JSNodeCustom.cpp: Added.
        * bindings/js/JSNodeListCustom.cpp: Added.
        * bindings/js/kjs_dom.cpp:
        * bindings/js/kjs_dom.h:
        * bindings/js/kjs_domnode.h:
        * bindings/js/kjs_events.cpp:
        * bindings/js/kjs_html.cpp:
        * bindings/js/kjs_html.h:
        * bindings/js/kjs_window.cpp:
        * bindings/js/kjs_window.h:
        * bindings/objc/DOMInternal.mm:
        (-[WebScriptObject _initializeScriptDOMNodeImp]):
        * bindings/objc/DOMUtility.mm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/mac/WebCoreAXObject.mm:
        * dom/Attr.idl:
        * dom/CharacterData.idl:
        * dom/Document.idl:
        * dom/DocumentFragment.idl:
        * dom/DocumentType.idl:
        * dom/Element.idl:
        * dom/NamedNodeMap.idl:
        * dom/Node.idl:
        * dom/NodeList.idl:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Thu, 7 Jun 2007 03:42:45 +0000 (03:42 +0000)]

        Reviewed by Oliver.

        * editing/pasteboard/5245519-expected.checksum: Added.
        * editing/pasteboard/5245519-expected.png: Added.
        * editing/pasteboard/5245519-expected.txt: Added.
        * editing/pasteboard/5245519.html: Added.


        Reviewed by Oliver.

        <rdar://problem/5245519> CrashTracer: [USER] 457 crashes in Mail at WebCore::CSSComputedStyleDeclaration::copyInheritableProperties()

        If the user pastes something into a region that ends up being
        invisible, or if the pasted content contains style spans
        that are render-less, we'll crash when we try to remove
        redundant styles from style spans.

        * css/CSSComputedStyleDeclaration.cpp:
        Add null checks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Thu, 7 Jun 2007 03:11:34 +0000 (03:11 +0000)]

        Reviewed by Harrison.

        <rdar://problem/4889598> Problems with moveDown: and moveUp: in Notes with ToDos

        * editing/selection/4889598-expected.checksum: Added.
        * editing/selection/4889598-expected.png: Added.
        * editing/selection/4889598-expected.txt: Added.
        * editing/selection/4889598.html: Added.


        Reviewed by Harrison.

        <rdar://problem/4889598> Problems with moveDown: and moveUp: in Notes with ToDos

        The caret would disappear when moving from content above or below
        a ToDo if that ToDo doesn't have any content in it with the same
        x position as the caret. That's because closestLeafChildForXPos
        would return non-editable leaves, and which turn into non-editable
        VisiblePositions, which are invisible.

        * editing/visible_units.cpp:
        (WebCore::previousLinePosition): Ask closestLeafForXPos to only
        return editable leaves.
        (WebCore::nextLinePosition): Ditto.
        * rendering/RootInlineBox.cpp:
        (WebCore::isEditableLeaf): Added.
        (WebCore::RootInlineBox::closestLeafChildForXPos): If requested,
        return the closest editable leaf. Removed an early return if the
        position is before the first leaf, it's not really much of an
        * rendering/RootInlineBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders.
weinig [Thu, 7 Jun 2007 02:36:49 +0000 (02:36 +0000)]
    Reviewed by Anders.

        Fix release build.

        * bindings/objc/DOM.mm:
        (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): Add missing null initialization.
        (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): Add missing null initialization.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Thu, 7 Jun 2007 00:54:18 +0000 (00:54 +0000)]

        Reviewed by Hyatt.

        Update results for http://bugs.webkit.org/show_bug.cgi?id=13947
        Finish autogenerating the JS DOM traversal code

        * fast/dom/Window/window-properties-expected.txt:


        Reviewed by Hyatt.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13947
        Finish autogenerating the JS DOM traversal code

        - Completely generate JSNodeFilter.
        - Move JSNodeFilterCondition into its own file

        * DerivedSources.make:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSNodeFilterCondition.cpp: Copied from WebCore/bindings/js/kjs_traversal.cpp.
        * bindings/js/JSNodeFilterCondition.h: Copied from WebCore/bindings/js/kjs_traversal.h.
        * bindings/js/JSNodeFilterCustom.cpp: Added.
        * bindings/js/kjs_dom.cpp:
        * bindings/js/kjs_traversal.cpp: Removed.
        * bindings/js/kjs_traversal.h: Removed.
        * bindings/js/kjs_window.cpp:
        * bindings/objc/DOM.mm:
        (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
        (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Document.cpp:
        * dom/Document.h:
        * dom/NodeFilter.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Make sure to hand back a script object for webkit plugins (the container
hyatt [Wed, 6 Jun 2007 22:37:09 +0000 (22:37 +0000)]
    Make sure to hand back a script object for webkit plugins (the container
        view forwards to its plugin child).

        Reviewed by sullivan

        * Plugins/WebKitPluginContainerView.h:
        * Plugins/WebKitPluginContainerView.mm:
        (-[WebKitPluginContainerView objectForWebScript]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark Rowe.
weinig [Wed, 6 Jun 2007 18:42:44 +0000 (18:42 +0000)]
    Reviewed by Mark Rowe.

        Fixes Bug 13996: http://bugs.webkit.org/show_bug.cgi?id=13996
        [Drosera] Items in the file list don't get un-highlighted when
        files are selected from the file drop-down

        * Drosera/debugger.js: currentFile was getting modified before file in the file
        browser got un-highlighted. Changed the order in which the functions execute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric Seidel.
weinig [Wed, 6 Jun 2007 18:14:27 +0000 (18:14 +0000)]
    Reviewed by Eric Seidel.

        Cairo: Unwanted gradient effect for small stretched images

        * platform/graphics/cairo/ImageCairo.cpp: Use CAIRO_FILTER_NEAREST to
        work around the issue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Zack
lars [Wed, 6 Jun 2007 14:47:42 +0000 (14:47 +0000)]
    Reviewed by Zack

        Add an API to create and load plugins.
        Don't include moc files by hand anymore, rather let
        qmake handle them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-06-06 Mark Rowe <mrowe@apple.com>
bdash [Wed, 6 Jun 2007 10:55:43 +0000 (10:55 +0000)]
2007-06-06  Mark Rowe  <mrowe@apple.com>

        Reviewed by Maciej.

        Bug 13988: Colon in file path crashes WebKit Nightly

        The WebKit launcher makes use of two `dyld' variables to coerce Safari into running with
        the bundled WebKit framework.  Both of these variables are interpreted as containing a
        colon-delimited list of paths.  There is no escaping mechanism defined, so if we detect
        a path with a colon in it we need to bail out to prevent `dyld' from throwing an error
        when we execute Safari.

        * WebKitLauncher/main.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-06-06 Mark Rowe <mrowe@apple.com>
bdash [Wed, 6 Jun 2007 09:45:49 +0000 (09:45 +0000)]
2007-06-06  Mark Rowe  <mrowe@apple.com>

        Qt build fix.

        * rendering/RenderTextControl.cpp: Fix case of #include filename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
lars [Wed, 6 Jun 2007 09:01:39 +0000 (09:01 +0000)]
    Reviewed by Maciej.

        Define WTF_USE_NPOBJECT for Qt. Fix includes
        in HTMLPluginElement and add proper forwarding headers
        from JavaScriptCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemove bogus assert that is hit depressingly often.
hyatt [Wed, 6 Jun 2007 08:46:08 +0000 (08:46 +0000)]
Remove bogus assert that is hit depressingly often.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Bulletproof windowClipRect, since it can be called at crazy times.
hyatt [Wed, 6 Jun 2007 07:05:57 +0000 (07:05 +0000)]
    Bulletproof windowClipRect, since it can be called at crazy times.
        Part of fix for 13972.

        Reviewed by olliej

        * bindings/objc/DOM.mm:
        (-[DOMElement _windowClipRect]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for bug 13972, quicktime doesn't respect CSS clip and overflow properties.
hyatt [Wed, 6 Jun 2007 07:04:17 +0000 (07:04 +0000)]
    Fix for bug 13972, quicktime doesn't respect CSS clip and overflow properties.
        Make sure that calls to [NSView visibleRect] will do the right thing for both
        Netscape plugins and WebKit plugins.

        Reviewed by olliej

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView visibleRect]):
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
        (-[WebBaseNetscapePluginView isOpaque]):
        * Plugins/WebKitPluginContainerView.h: Added.
        * Plugins/WebKitPluginContainerView.mm: Added.
        (-[WebKitPluginContainerView initWithFrame:DOMElement:]):
        (-[WebKitPluginContainerView dealloc]):
        (-[WebKitPluginContainerView visibleRect]):
        * Plugins/WebPluginController.mm:
        (-[WebPluginController destroyAllPlugins]):
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView addSubview:]):
        (-[WebHTMLView willRemoveSubview:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-06-05 MorganL <morganl.webkit@yahoo.com>
bdash [Wed, 6 Jun 2007 04:17:41 +0000 (04:17 +0000)]
2007-06-05  MorganL  <morganl.webkit@yahoo.com>

        Reviewed by Dave Hyatt.

        Fixes http://bugs.webkit.org/show_bug.cgi?id=14008

        * rendering/RenderTextControl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by.
kmccullo [Wed, 6 Jun 2007 02:36:00 +0000 (02:36 +0000)]
    Reviewed by.

        - Respelling Oliver's name right.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark and Olliver.
kmccullo [Wed, 6 Jun 2007 02:32:15 +0000 (02:32 +0000)]
    Reviewed by Mark and Olliver.

        - http://bugs.webkit.org/show_bug.cgi?id=13352  REGRESSION: Gmail hangs on send message.
        - Now we don't hang, but we do so by avoiding certain legitimate characters, the evangelism bug for this is: <rdar://problem/5252577> gmail does not accept legal characters in the form boundary

        * html/HTMLFormElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix.
andersca [Tue, 5 Jun 2007 21:01:59 +0000 (21:01 +0000)]
    Build fix.

        * xml/xmlhttprequest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
andersca [Tue, 5 Jun 2007 20:47:19 +0000 (20:47 +0000)]

        Reviewed by Geoff.

        <rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
        <rdar://problem/5246208> HTTP injection in XMLHttpRequest.open method parameter
        <rdar://problem/5246242> HTTP header injection in HXMLHttpRequest.setRequestHeader header parameter

        * fast/dom/xmlhttprequest-invalid-values-expected.txt: Added.
        * fast/dom/xmlhttprequest-invalid-values.html: Added.


        Reviewed by Geoff.

        <rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
        <rdar://problem/5246208> HTTP injection in XMLHttpRequest.open method parameter
        <rdar://problem/5246242> HTTP header injection in HXMLHttpRequest.setRequestHeader header parameter

        Check method names, header names and header values and throw exceptions if any of them are
        invalid. This is what the new XMLHttpRequest spec states that we should do.

        * xml/xmlhttprequest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
weinig [Tue, 5 Jun 2007 20:33:54 +0000 (20:33 +0000)]
    Reviewed by Geoff.

        Optimize JSCSSStyleDeclaration after performance regression in r21854.

        - Check static table before name getter in JSCSSStyleDeclaration::getOwnPropertySlot()
        - Get rid of a string allocation by keeping string as KJS::Identifier for canGetItemsForName()

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        * bindings/js/JSHTMLAppletElementCustom.cpp:
        * bindings/js/JSHTMLDocumentCustom.cpp:
        * bindings/js/JSHTMLEmbedElementCustom.cpp:
        * bindings/js/JSHTMLFormElementCustom.cpp:
        * bindings/js/JSHTMLFrameSetElementCustom.cpp:
        * bindings/js/JSHTMLObjectElementCustom.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        * css/CSSStyleDeclaration.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff and Justin.
oliver [Tue, 5 Jun 2007 00:15:31 +0000 (00:15 +0000)]
    Reviewed by Geoff and Justin.

        Fix for <rdar://problem/5246941> Clicking URL field on
        Safari causes halt for a minute when using input methods.
        and <rdar://problem/5245964> Safari hangs for several
        seconds when trying to select text using mouse

        This is a by product of the textStorage hack used to fix
        rdar://problem/5000470 -- TSM calls textStorage repeatedly
        when changing focus, on certain mouse events, etc.  If there
        is no selection/editable region we repeatedly create an
        NSAttributedString from the full document.  If the document is
        sufficiently long this starts consuming an inordinate amount of

        This check should really have been present in the original

        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView textStorage]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed, tweaked and landed by Anders.
andersca [Tue, 5 Jun 2007 00:10:40 +0000 (00:10 +0000)]
    Reviewed, tweaked and landed by Anders.

        <rdar://problem/5247178> REGRESSION: With CSS Edit 2.5, a crash occurs at WebCore::DeprecatedString::DeprecatedString when page fails to be extracted

        Null check the provisional document loader. If an application stops the load
        inside of the didFailProvisionalLoad delegate method, the provisional document loader will be nulled out.

        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-06-04 Alp Toker <alp.toker@collabora.co.uk>
bdash [Mon, 4 Jun 2007 23:43:38 +0000 (23:43 +0000)]
2007-06-04  Alp Toker  <alp.toker@collabora.co.uk>

        Reviewed by Anders.

        Cairo graphics fixes and cleanups

        * platform/graphics/ImageBuffer.h:
        * platform/graphics/cairo/ImageBufferCairo.cpp:
        (WebCore::ImageBuffer::surface): Provide surface() accessor.
        * platform/graphics/cairo/AffineTransformCairo.cpp:
        (WebCore::AffineTransform::rotate): Convert from degrees to radians to
        fix rotation.
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::drawRect): Add save/restore.
        (WebCore::GraphicsContext::rotate): Rename parameter to "radians" to
        avoid further confusion.
        * platform/graphics/cairo/PathCairo.cpp:
        (WebCore::Path::boundingRect): The cairo_fill_extents() parameters do
        not describe a point/size but rather the two control points of the
        rectangular region.
        (WebCore::Path::contains): Remove needless casts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-06-05 Mark Rowe <mrowe@apple.com>
bdash [Mon, 4 Jun 2007 23:40:53 +0000 (23:40 +0000)]
2007-06-05  Mark Rowe  <mrowe@apple.com>

        Reviewed by Anders.

        * WebKitLauncher/Info.plist: Update CFBundleGetInfoString, and add CFBundleShortVersionString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
weinig [Mon, 4 Jun 2007 21:27:08 +0000 (21:27 +0000)]
    Reviewed by Adam Roben.

        Fix the buildbot.

        * rendering/RenderSVGContainer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Mon, 4 Jun 2007 18:39:10 +0000 (18:39 +0000)]

        Reviewed by Kimon Tsinteris.

        <rdar://problem/5241148> REGRESSION: ActivEdit can't perform operations on certain selections

        Demonstrates bug:
        * editing/selection/5241148-expected.txt: Added.
        * editing/selection/5241148.html: Added.
        Updated to reflect new equivalents for positions before/after tables:
        * editing/selection/click-before-and-after-table-expected.txt:
        * editing/selection/click-before-and-after-table.html:


        Reviewed by Kimon Tsinteris.

        <rdar://problem/5241148> REGRESSION: ActivEdit can't perform operations on certain selections

        Return valid equivalents from these methods (no [img, 1] for
        example). ActivEdit was using positions returned from these
        methods to create new DOM Ranges.

        * editing/SelectionController.cpp:
        * editing/SelectionController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix the svg experimental build.
rwlbuis [Mon, 4 Jun 2007 13:41:08 +0000 (13:41 +0000)]
Fix the svg experimental build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-04 Mark Rowe <mrowe@apple.com>
bdash [Mon, 4 Jun 2007 09:41:09 +0000 (09:41 +0000)]
2007-05-04  Mark Rowe  <mrowe@apple.com>

        Upgrade to WordPress 2.2.  I didn't go to the effort of tracking down files
        present in the old version which have since been removed, but it's unlikely
        they'll ever cause a problem.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-04 Mark Rowe <mrowe@apple.com>
bdash [Mon, 4 Jun 2007 08:30:58 +0000 (08:30 +0000)]
2007-05-04  Mark Rowe  <mrowe@apple.com>

        Add graphics used by existing blog posts into SVN.

        * blog/wp-content/rotate.png: Added.
        * blog/wp-content/drosera.png: Added.
        * blog/wp-content/hitlist.png: Added.
        * blog/wp-content/svgtextmini.png: Added.
        * blog/wp-content/svgtextmini_01.png: Added.
        * blog/wp-content/textfield_screenshot.jpg: Added.
        * blog/wp-content/Picture9.png: Added.
        * blog/wp-content/svgtext.png: Added.
        * blog/wp-content/webInspector.png: Added.
        * blog/wp-content/rotate.svg: Added.
        * blog/wp-content/chucknorris.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
rwlbuis [Mon, 4 Jun 2007 08:04:55 +0000 (08:04 +0000)]
    Reviewed by Hyatt.

        CSS1: Properties for :first-letter aren't recalculated on color change

        Mark styles with first-letter as unique.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by David Harrison.
andersca [Sat, 2 Jun 2007 02:37:45 +0000 (02:37 +0000)]
    Reviewed by David Harrison.

        CrashTracer: [USER] 3 crashes in Mail at WebCore::Loader::didReceiveResponse(WebCore::SubresourceLoader*, WebCore::ResourceResponse const&)

        This is by no means the best solution for handling user style sheets. I've filed <rdar://problem/5244734>
        for tracking that.

        * loader/loader.cpp:
        If a load starts while the frame is still in the provisional state
        (this can be the case when loading the user style sheet), committing the load then causes all
        requests to be removed from the m_requestsLoading map. This means that req might be null here.
        In that case we just return early.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
weinig [Fri, 1 Jun 2007 23:54:33 +0000 (23:54 +0000)]
    Reviewed by Adele.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13958
          REGRESSION: Form select menu in iframe destroys form select menu on page

        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking): Instead of calling
        the event handler methods directly, post the fake event on the application event
        queue. This ensures that the fake event is handled only after handling of the
        initiating event has ended, and is seen by ancestor frames' event handlers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-06-01 George Staikos <staikos@kde.org>
staikos [Fri, 1 Jun 2007 12:47:35 +0000 (12:47 +0000)]
2007-06-01  George Staikos  <staikos@kde.org>

        Reviewed by bdash.

        Redo the build fix again after it was backed out

        * WebCore.pro: add an include guard around CSSGrammar.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRoll out r21916 as it did nothing to fix the build.
bdash [Fri, 1 Jun 2007 09:34:57 +0000 (09:34 +0000)]
Roll out r21916 as it did nothing to fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Beth Dakin.
ggaren [Fri, 1 Jun 2007 07:25:38 +0000 (07:25 +0000)]
    Reviewed by Beth Dakin.

        Fixed <rdar://problem/5238177> Continuing after hitting breakpoint doesn't
        execute the next step.

        No test because the only code affected is the debugger, and none of the
        relevant API is exported.

        Reverted an accidental change in 21324 that caused originRootObject for
        the window object always to be 0. We could probably just remove the debugger's
        dependency on originRootObject, but I wanted to be safe.

        * page/mac/FrameMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
hyatt [Fri, 1 Jun 2007 05:57:33 +0000 (05:57 +0000)]

        Fix for 11768, Flash plugin does not respect clips set via CSS.

        Reviewed by olliej

        * bindings/objc/DOM.mm:
        (-[DOMElement _windowClipRect]):
        * bindings/objc/DOMPrivate.h:
        * page/FrameView.cpp:
        * platform/ScrollView.h:
        * platform/mac/ScrollViewMac.mm:


        Fix for 11768, Flash plugin does not respect clips set by CSS.

        Reviewed by olliej

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
weinig [Fri, 1 Jun 2007 05:46:58 +0000 (05:46 +0000)]
    Reviewed by Adam.

        Update test to reflect new correct result.

        * fast/dom/Window/atob-btoa-expected.txt:
        * fast/dom/Window/atob-btoa.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
weinig [Fri, 1 Jun 2007 05:45:08 +0000 (05:45 +0000)]
    Reviewed by Adam.

        Fix build bot.

        * ksvg2/svg/SVGSVGElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix Qt and Gdk builds.
weinig [Fri, 1 Jun 2007 03:19:32 +0000 (03:19 +0000)]
    Fix Qt and Gdk builds.

        * WebCore.pro: remove bindings/js/JSHTMLAnchorElementCustom.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Fri, 1 Jun 2007 03:13:44 +0000 (03:13 +0000)]

        Reviewed by Geoff.

        Tests for http://bugs.webkit.org/show_bug.cgi?id=10782
        Classes should not override JSObject::toString(ExecState *)

        - Adds a new test to test overriding toString and valueOf for
          multiple objects.
        - Update tests to reflect the correction of the toString architecture.

        * editing/selection/getRangeAt-expected.txt:
        * fast/dom/Window/atob-btoa-expected.txt:
        * fast/js/toString-and-valueOf-override-expected.txt: Added.
        * fast/js/toString-and-valueOf-override.html: Added.


        Reviewed by Geoff.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=10782
        Classes should not override JSObject::toString(ExecState *)

        Remove all overrides of JSObject::toString and JSObject::toPrimitive
        which is a bad practice.  Instead, if an object, like the
        HTMLAnchorElement, needs to override to toString, it should add
        a function to the JS object which will be called when needed.  This
        also allows developers to override toString and valueOf from within JS.

        Test: fast/js/toString-and-valueOf-override.html

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSHTMLAnchorElementCustom.cpp: Removed.
        * bindings/js/kjs_binding.cpp:
        * bindings/js/kjs_binding.h:
        * bindings/js/kjs_dom.cpp:
        * bindings/js/kjs_dom.h:
        * bindings/js/kjs_domnode.h:
        * bindings/js/kjs_window.cpp:
        * bindings/js/kjs_window.h:
        * bindings/scripts/CodeGeneratorJS.pm:
        * html/HTMLAnchorElement.cpp:
        * html/HTMLAnchorElement.h:
        * html/HTMLAnchorElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
weinig [Fri, 1 Jun 2007 01:52:31 +0000 (01:52 +0000)]
    Reviewed by Darin.

        Implement currentScale(), setCurrentScale() and currentTranslate() in SVGSVGElement

        Allow zooming and panning, thereby implementing the above methods.

        * ksvg2/svg/SVGDocument.cpp:
        * ksvg2/svg/SVGDocument.h:
        * ksvg2/svg/SVGSVGElement.cpp:
        * ksvg2/svg/SVGSVGElement.h:
        * page/EventHandler.cpp:
        * page/EventHandler.h:
        * page/Frame.cpp:
        * rendering/RenderSVGContainer.cpp:
        * rendering/RenderSVGContainer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Fri, 1 Jun 2007 01:35:51 +0000 (01:35 +0000)]

        Reviewed by Niko.

        Test for fix: http://bugs.webkit.org/show_bug.cgi?id=12570

        * svg/custom/prevent-default-expected.checksum: Added.
        * svg/custom/prevent-default-expected.png: Added.
        * svg/custom/prevent-default-expected.txt: Added.
        * svg/custom/prevent-default.svg: Added.


        Reviewed by Niko.

        Links are activated based on mouse down events instead of click events

        Test: svg/custom/prevent-default.svg

        * html/HTMLAnchorElement.cpp: use MiddleButton and RightButton instead of 1 and 2
        * ksvg2/svg/SVGAElement.cpp:
        (WebCore::SVGAElement::defaultEventHandler): make it function more like the HTML side

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
mjs [Fri, 1 Jun 2007 00:21:21 +0000 (00:21 +0000)]
    Reviewed by Hyatt.

        - fix layout test editing/style/table-selection.html

        * editing/style/table-selection-expected.txt: Updated selection delegate output.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
mjs [Fri, 1 Jun 2007 00:19:05 +0000 (00:19 +0000)]

        Reviewed by Hyatt.

        - fix layout test editing/style/table-selection.html

        * editing/style/table-selection-expected.txt: Updated selection delegate output.


        Reviewed by Hyatt.

        - fix layout test editing/style/table-selection.html

        This was broken by the change to keep whitespace text nodes in tables. They safely didn't render,
        but the font delta style change command would wrap them in spans, creating extra anonymous table

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Don't wrap in a span if the text node
        is not rendered.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agotop level:
weinig [Thu, 31 May 2007 23:50:37 +0000 (23:50 +0000)]
top level:

        Reviewed by Eric Seidel.

        Rename WebCore/platform/network/gdk to WebCore/platform/network/curl

        * WebKit.pri:


        Reviewed by Eric Seidel.

        Rename WebCore/platform/network/gdk to WebCore/platform/network/curl

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Niko.
weinig [Thu, 31 May 2007 20:33:37 +0000 (20:33 +0000)]
    Reviewed by Niko.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13945
        GraphicsContextCairo enhancements necessary for SVG support

        * platform/graphics/cairo/GraphicsContextCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago<rdar://problem/5221920> AXLink is returning a CFString instead of a CFURL for AXURL
pyeh [Thu, 31 May 2007 19:49:35 +0000 (19:49 +0000)]
<rdar://problem/5221920> AXLink is returning a CFString instead of a CFURL for AXURL

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityAttributeValue:]):
        Convert the url string to an NSURL before returning as the AXURLAttribute

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-31 George Staikos <staikos@kde.org>
staikos [Thu, 31 May 2007 19:44:19 +0000 (19:44 +0000)]
2007-05-31  George Staikos  <staikos@kde.org>

        Reviewed by Nikolas.

        Compile again - Qt build.

        * WebCore.pro: header guard added to CSSGrammar.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Thu, 31 May 2007 05:21:11 +0000 (05:21 +0000)]

        Reviewed by Oliver.

        Update results for http://bugs.webkit.org/show_bug.cgi?id=13943
        Autogenerate the JS bindings for the CSSStyleSheet

        * fast/dom/Window/window-properties-expected.txt:


        Reviewed by Oliver.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13943
        Autogenerate the JS bindings for the CSSStyleSheet

        * DerivedSources.make:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSStyleSheetCustom.cpp:
        * bindings/js/kjs_css.cpp:
        * bindings/js/kjs_css.h:
        * bindings/scripts/CodeGeneratorJS.pm:
        * css/CSSStyleSheet.cpp:
        * css/CSSStyleSheet.h:
        * css/CSSStyleSheet.idl:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
weinig [Thu, 31 May 2007 05:05:11 +0000 (05:05 +0000)]
    Reviewed by Oliver.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13937
        Autogenerate the JS bindings for the CSSValue

        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSCSSValueCustom.cpp: Added.
        * bindings/js/kjs_css.cpp:
        * bindings/js/kjs_css.h:
        * bindings/objc/DOMUtility.mm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * css/CSSValue.h:
        * css/CSSValue.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Thu, 31 May 2007 03:36:08 +0000 (03:36 +0000)]

        Reviewed by Oliver the Hun.

        Update results for http://bugs.webkit.org/show_bug.cgi?id=13944
        Generate and add missing JS constructors

        * fast/dom/Window/window-properties-expected.txt:


        Reviewed by Oliver the Hun.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13944
        Generate and add missing JS constructors

        * css/CSSRuleList.idl:
        * css/CSSValueList.idl:
        * css/Counter.idl:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
justing [Thu, 31 May 2007 00:39:14 +0000 (00:39 +0000)]
    Reviewed by Darin.

        REGRESSION(r21687): editing/inserting/paragraph-separator-* failing pixel test (misspelling markers)

        After r21687, SimplifiedBackwardsTextIterator was no longer
        emitting a '\n' as it left the first block of a range ending
        at [block, 0]. So, foo<div>^<br></div> looked like foo^ to
        spell checking (foo wasn't marked as misspelled).

        After r21687, SBTI stopped emitting '\n's in the above case
        because 1) we stopped incorrectly emitting '\n's for nodes as
        we entered them and 2) we were and still are incorrectly calling
        code that should only be called when entering nodes as we leave
        them and 3) we don't call exitNode(), which is responsible
        for emitting the '\n' in the above testcase, when we should.

        Before and after r21687, we'd call exitNode() for a node as
        we traversed in reverse pre-order from its first descendant
        out to its sibling or one of its ancestors' siblings.  We
        weren't calling it a) after we'd enter a node that could
        have children but had none and b) when leaving a container
        that contained the end of the range used to create the iterator.

        * editing/TextIterator.cpp:
        (WebCore::SimplifiedBackwardsTextIterator::advance): Call exitNode() as we
        leave a childless container node and a node where the range ended.
        * editing/TextIterator.h: Track the end of the range used to create
        the SimplifiedBackwardsTextIterator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoUpdate ChangeLogs with correct Bugzilla URLs.
weinig [Thu, 31 May 2007 00:23:03 +0000 (00:23 +0000)]
Update ChangeLogs with correct Bugzilla URLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
weinig [Thu, 31 May 2007 00:16:27 +0000 (00:16 +0000)]

        Reviewed by Brady.

        Enable logging in the Gdk port.

        * wtf/Assertions.cpp:
        * wtf/Assertions.h: Add WTFLogVerbose which also logs
        the file, line number and function.


        Reviewed by Brady.

        Enable logging in the Gdk port.

        * WebCore.pro:
        * platform/NotImplemented.h: Changed to use WTFLogVerbose.
        * platform/gdk/LoggingGdk.cpp: Added.


        Reviewed by Brady.

        Enable logging in the Gdk port.

        * GdkLauncher/main.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
bdakin [Wed, 30 May 2007 23:03:51 +0000 (23:03 +0000)]
    Reviewed by Hyatt.

        Fix for <rdar://problem/5198882> CrashTracer: [USER] 7 crashes in
        Safari at com.apple.WebCore: WebCore::RenderBlock::layoutBlock +

        The problem is that we are re-entering layout when we should not.
        http://trac.webkit.org/projects/webkit/changeset/21778 actually
        fixed this crash, but we have been inspired to add the same guard
        in two other possibly-dangerous places.

        * page/FrameView.cpp:
        (WebCore::FrameView::layout): Add the guard in two more places.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
justing [Wed, 30 May 2007 22:06:51 +0000 (22:06 +0000)]
    Reviewed by Oliver.

        <rdar://problem/5096134> VO gets stuck on Howto.apple.com
        VisiblePositions aren't canonicalized in some cases

        No new test cases added: can't write automated tests
        for VO.

        * editing/IndentOutdentCommand.cpp:
        VisiblePositions must be recomputed after nodes that
        may have effected their canonicalization are removed.
        * editing/VisiblePosition.cpp:
        (WebCore::canonicalizeCandidate): Added.
        (WebCore::VisiblePosition::canonicalPosition): Canonicalize
        the candidates returned by next/previousCandidate before
        returning them.
        * editing/VisiblePosition.h:
        (WebCore::operator==): Remove the workaround for 8622.
        * editing/visible_units.cpp:
        (WebCore::startOfParagraph): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Wed, 30 May 2007 21:08:16 +0000 (21:08 +0000)]

        Reviewed by Dr. Harrison.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13868
        REGRESSION: crash on accessing a new iframe's contentWindow property

        * fast/dom/frame-contentWindow-crash-expected.txt: Added.
        * fast/dom/frame-contentWindow-crash.html: Added.
        * fast/dom/iframe-contentWindow-crash-expected.txt: Added.
        * fast/dom/iframe-contentWindow-crash.html: Added.


        Reviewed by Dr. Harrison.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13868
        REGRESSION: crash on accessing a new iframe's contentWindow property

        Adds a null check in for the contentWindow property for HTMLIFrameElement
        and HTMLFrameElement.

        * bindings/scripts/CodeGeneratorJS.pm:
        * html/HTMLFrameElement.idl:
        * html/HTMLIFrameElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-30 Mitz Pettel <mitz@webkit.org>
bdash [Wed, 30 May 2007 19:16:19 +0000 (19:16 +0000)]
2007-05-30  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13775
          REGRESSION: Popup button text should use "natural" directionality to match the items in the popup menu

        Test: fast/forms/select-writing-direction-natural.html

        * platform/PopupMenu.h: Added the static method itemWritingDirectionIsNatural
        which says whether items in the popup ignore the CSS text-align and direction
        properties and instead are left-aligned and use natural writing direction.
        * platform/gdk/PopupMenuGdk.cpp:
        * platform/mac/PopupMenuMac.mm:
        * platform/qt/PopupMenuQt.cpp:
        * platform/win/TemporaryLinkStubs.cpp:
        * platform/wx/TemporaryLinkStubs.cpp:
        * rendering/RenderMenuList.cpp:
        (WebCore::textDirectionForParagraph): Added this helper function that uses
        the Unicode Bidi Algorithm rules P2 and P3 to determine the writing direction
        of text.
        (WebCore::RenderMenuList::adjustInnerStyle): Made the alignment and direction
        adjustment conditional on the popup implementation.
        (WebCore::RenderMenuList::setText): Added call to adjustInnerStyle() since
        the style depends on the text when natural writing direction is used.

2007-05-30  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=13775
          REGRESSION: Popup button text should use "natural" directionality to match the items in the popup menu

        * fast/forms/select-writing-direction-natural-expected.checksum: Added.
        * fast/forms/select-writing-direction-natural-expected.png: Added.
        * fast/forms/select-writing-direction-natural-expected.txt: Added.
        * fast/forms/select-writing-direction-natural.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd radar to ChangeLog.
weinig [Wed, 30 May 2007 18:57:10 +0000 (18:57 +0000)]
Add radar to ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
weinig [Wed, 30 May 2007 18:45:50 +0000 (18:45 +0000)]
    Reviewed by Hyatt.

        - http://bugs.webkit.org/show_bug.cgi?id=13932
          REGRESSION: fast/dynamic/containing-block-change is failing

        * fast/dynamic/containing-block-change.html: Removed whitespace that
        got turned into text nodes, thereby making lastNode be not what the script
        expected it to be.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
thatcher [Wed, 30 May 2007 18:11:05 +0000 (18:11 +0000)]
    Reviewed by Darin.

        <rdar://problem/5200795> REGRESSION (r21057): lineBoxRects doesn't match actual text when wrapping occurs

        Use box->end() instead of box->len().

        * rendering/RenderText.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Wed, 30 May 2007 17:43:55 +0000 (17:43 +0000)]

        Reviewed by Darin.

        - Update results for http://bugs.webkit.org/show_bug.cgi?id=13919
          Autogenerate the JS bindings for the CSSRule and its subclasses

        * fast/dom/Window/window-properties-expected.txt: adds new constructors
        * fast/dom/wrapper-classes-expected.txt: CSSStyleRule now passes!!


        Reviewed by Darin.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13919
        Autogenerate the JS bindings for the CSSRule and its subclasses

        - subclasses generated are CSSCharsetRule, CSSFontFaceRule, CSSImportRule
          CSSMediaRule, CSSPageRule and CSSStyleRule.

        * DerivedSources.make:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSCSSRuleCustom.cpp: Added.
        * bindings/js/kjs_css.cpp:
        * bindings/js/kjs_css.h:
        * bindings/objc/DOMUtility.mm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * css/CSSCharsetRule.h:
        * css/CSSCharsetRule.idl:
        * css/CSSFontFaceRule.idl:
        * css/CSSImportRule.idl:
        * css/CSSMediaRule.idl:
        * css/CSSPageRule.cpp:
        * css/CSSPageRule.h:
        * css/CSSPageRule.idl:
        * css/CSSRule.cpp:
        * css/CSSRule.h:
        * css/CSSRule.idl:
        * css/CSSStyleRule.cpp:
        * css/CSSStyleRule.h:
        * css/CSSStyleRule.idl:
        * page/DOMWindow.idl: add new constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-30 Mark Rowe <mrowe@apple.com>
bdash [Wed, 30 May 2007 13:28:53 +0000 (13:28 +0000)]
2007-05-30  Mark Rowe  <mrowe@apple.com>

        Build fixes after r21889.  Add missing #includes.

        * ForwardingHeaders/kjs/function.h: Added.
        * bindings/js/kjs_binding.h:
        * bindings/js/kjs_dom.h:
        * bindings/js/kjs_window.h:

2007-05-30  Mark Rowe  <mrowe@apple.com>

        Build fixes after r21889.

        * ForwardingHeaders/kjs/function.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-30 Mark Rowe <mrowe@apple.com>
bdash [Wed, 30 May 2007 12:27:09 +0000 (12:27 +0000)]
2007-05-30  Mark Rowe  <mrowe@apple.com>

        Mac build fix.  Update #include.

        * API/JSCallbackFunction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-30 Luciano Montanaro <mikelima@cirulla.net>
bdash [Wed, 30 May 2007 12:19:36 +0000 (12:19 +0000)]
2007-05-30  Luciano Montanaro  <mikelima@cirulla.net>

        Reviewed by Maciej.

        - cross-port Harri Porten's commits 636099 and 636108 from KJS:
        "publish a class anyway public already" and "class is being used from
        outside for quite some time" in preparation for further syncronizations

        * kjs/context.h:
        * kjs/date_object.cpp:
        * kjs/date_object.h:
        * kjs/function.h:
        * kjs/function_object.h:
        * kjs/internal.h:
        * kjs/lookup.h:
        * kjs/object_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-30 Oliver Hunt <oliver@apple.com>
oliver [Wed, 30 May 2007 10:36:29 +0000 (10:36 +0000)]
2007-05-30  Oliver Hunt  <oliver@apple.com>

        Reviewed by Mitz.

        Remove reference to SVG node from test -- otherwise this test incorrectly appears
        to fail in non-SVG builds

        * http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard-expected.txt:
        * http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-30 Mark Rowe <mrowe@apple.com>
bdash [Wed, 30 May 2007 07:27:11 +0000 (07:27 +0000)]
2007-05-30  Mark Rowe  <mrowe@apple.com>

        Gdk build fix.  Update WidgetGdk to use NotImplemented.h.

        * platform/gdk/WidgetGdk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-29 Holger Freyther <zecke@selfish.org>
bdash [Wed, 30 May 2007 06:24:52 +0000 (06:24 +0000)]
2007-05-29  Holger Freyther  <zecke@selfish.org>

        Reviewed by Anders.

        Make ScrollView use a GtkLayout. This class matches QScrollView the most and promises
        to ease the implementation of ScrollView::addChild. GtkLayout should be resource friendly
        even with huge width and heights of frames.
        Make Widget aware of GtkLayout to use the right GdkWindow as drawable. For GtkLayout one must
        draw on the bin_window.
        Remove the layer violation from FrameGdk.cpp and ScrollView. FrameGdk is no longer responsible to
        implement scrolling on keyboard events. ScrollView is no longer required to know that it could be
        a FrameView and handles scrolling of Frames magically.

        * platform/ScrollView.h:
        * platform/gdk/FrameGdk.cpp:
        * platform/gdk/ScrollViewGdk.cpp:
        * platform/gdk/TemporaryLinkStubs.cpp: Move Widget methods to WidgetGdk.cpp
        * platform/gdk/WidgetGdk.cpp:

2007-05-29  Holger Freyther  <zecke@selfish.org>

        Reviewed by Anders.

        Create a GtkLayout and pass it to the FrameView/ScrollView. Embed the GtkLayout into a GtkScrolledWindow
        to provide ScrollBars for the FrameView.

        * GdkLauncher/main.cpp:
        (layout_realize_callback): Only after realization we can access the GtkLayout::bin_window
        (frameResizeCallback): Inform the ScrollView about its new viewport size, and ask the FrameView to adjust

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-29 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
bdash [Wed, 30 May 2007 06:12:43 +0000 (06:12 +0000)]
2007-05-29  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>

        Reviewed by Maciej.

        Curl (linux/gdk) networking improvements:
        a) POST support
        b) don't use CURL in a re-entrant way.
        c) turn on curl's internal debugging support in a debug build if the DEBUG_CURL environment variable is set.

        * platform/network/ResourceHandleInternal.h:
        * platform/network/gdk/ResourceHandleCurl.cpp:
        * platform/network/gdk/ResourceHandleManager.cpp:
        * platform/network/gdk/ResourceHandleManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix the Qt and Gdk builds.
weinig [Wed, 30 May 2007 06:08:52 +0000 (06:08 +0000)]
    Fix the Qt and Gdk builds.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
adele [Wed, 30 May 2007 05:55:30 +0000 (05:55 +0000)]
    Reviewed by Adam.

        Fix for <rdar://problem/5109711> REGRESSION: Focus ring artifacts appear around a widget's search field at times (Address Book, Dictionary)

        * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSearchField):
          We only need this hack for drawing the search field focus ring on Tiger.  On Leopard, drawWithFrame correctly draws the cell's focus ring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-29 Alp Toker <alp.toker@collabora.co.uk>
bdash [Wed, 30 May 2007 05:53:02 +0000 (05:53 +0000)]
2007-05-29  Alp Toker  <alp.toker@collabora.co.uk>

        Reviewed by Mitz.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13899

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::strokeArc): Use cairo_arc_negative() to fix
        CSS rounded borders.
        (WebCore::GraphicsContext::endTransparencyLayer): save/restore is
        redundant. push/pop group does this implicitly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Wed, 30 May 2007 05:47:42 +0000 (05:47 +0000)]

        Reviewed by Oliver.

        Update results for http://bugs.webkit.org/show_bug.cgi?id=13912
        Autogenerate the JS bindings for the MediaList

        * fast/dom/Window/window-properties-expected.txt: new constructors added.


        Reviewed by Oliver.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13912
        Autogenerate the JS bindings for the MediaList

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/kjs_css.cpp:
        * bindings/js/kjs_css.h:
        * bindings/objc/DOMUtility.mm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * css/MediaList.idl:
        * page/DOMWindow.idl: Add constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-29 Matt Perry <mpComplete@gmail.com>
bdash [Wed, 30 May 2007 05:41:46 +0000 (05:41 +0000)]
2007-05-29  Matt Perry  <mpComplete@gmail.com>

        Reviewed by Maciej.

        Fixed some rendering issues for <select>s on Windows.

        * rendering/RenderThemeWin.cpp:
        * rendering/RenderThemeWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fold the invalidateVerticalPositions crawl into the bidi iteration.
hyatt [Wed, 30 May 2007 05:32:40 +0000 (05:32 +0000)]
    Fold the invalidateVerticalPositions crawl into the bidi iteration.
        This makes it more correct (since we won't drill into elements that
        did not need to be reset) and cuts out an extra walk of all our children.
        We're still O(n^2) as new content streams in, but this at least cuts
        out one separate O(n^2) crawl.

        Reviewed by olliej

        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/bidi.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Wed, 30 May 2007 04:45:45 +0000 (04:45 +0000)]

        Reviewed by Oliver.

        Update results after http://bugs.webkit.org/show_bug.cgi?id=13908
        Autogenerate the JS bindings for the StyleSheet

        * fast/dom/Window/window-properties-expected.txt: Adds StyleSheet constructor


        Reviewed by Oliver.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13908
        Autogenerate the JS bindings for the StyleSheet

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSStyleSheetCustom.cpp: Added.
        * bindings/js/kjs_css.cpp:
        * bindings/js/kjs_css.h:
        * bindings/objc/DOMUtility.mm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * css/StyleSheet.idl:
        * page/DOMWindow.idl: Add new constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Make sure <embed> does not allow an end tag.
hyatt [Wed, 30 May 2007 03:58:48 +0000 (03:58 +0000)]
    Make sure <embed> does not allow an end tag.

        Reviewed by olliej

        * html/HTMLEmbedElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Wed, 30 May 2007 00:36:04 +0000 (00:36 +0000)]

        Reviewed by Brady.

        Updated tests for <rdar://problem/5213039> REGRESSION: Wells Fargo registration page returns blank

        * fast/dom/HTMLInputElement/input-hidden-value-expected.txt:
        * fast/dom/HTMLInputElement/input-text-reset-expected.txt:
        * fast/dom/HTMLInputElement/input-text-reset.html:


        Reviewed by Brady.

        Fix for <rdar://problem/5213039> REGRESSION: Wells Fargo registration page returns blank

        Roll out updated fix for 11866 that tried to make reset work for hidden inputs.  Since
        all browsers update the value attribute when setting the value, it doesn't really make sense to reset.
        Its true that IE does support resetting these controls, but in this case, it doesn't really make sense to have
        another place to store an alternate version of the value.

        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::reset):
        * html/HTMLInputElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Tue, 29 May 2007 23:23:43 +0000 (23:23 +0000)]

        Reviewed by Anders.

        - updated results since I removed many cases of the innerHTML optimization

        * fast/dom/HTMLElement/set-inner-outer-optimization.html: Updated.


        Reviewed by Anders.

        - removed the general case optimization for innerHTML because some sites
          rely on setting innerHTML to trigger loading plug-ins for example; we
          could consider bringing it back some day, perhaps with a list of element
          types to exclude

        * dom/CharacterData.cpp: (WebCore::CharacterData::setData):
        Do nothing if the old data is identical to the new data.

        * html/HTMLElement.cpp:
        (WebCore::replaceChildrenWithFragment): Remove childrenAreEqual optimization.
        (WebCore::replaceChildrenWithText): Remove optimization for cases where the
        text data is identical to the new data, since CharacterData handles that now.
        (WebCore::HTMLElement::setOuterHTML): Remove childrenAreEqual optimization.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
weinig [Tue, 29 May 2007 23:07:02 +0000 (23:07 +0000)]
    Reviewed by Adam Roben.

        Cleanup function and fix to match comparison API.

        * kjs/string_object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoTweak my noscript fix to just always allow it inside the head.
hyatt [Tue, 29 May 2007 22:09:29 +0000 (22:09 +0000)]
Tweak my noscript fix to just always allow it inside the head.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Tue, 29 May 2007 21:36:10 +0000 (21:36 +0000)]

        Reviewed by Maciej.

        - updated results for http://bugs.webkit.org/show_bug.cgi?id=13904

        * fast/forms/box-shadow-override-expected.checksum:
        * fast/forms/box-shadow-override-expected.png:


        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13904
          REGRESSION: Search fields with a results popup do not always draw the popup arrow

        Covered by fast/forms/box-shadow-override.html

        The search button draws a popup arrow depending on whether the
        search menu template is set, rather than on the maximum number of recent
        search strings.

        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): Removed the
        call to -setMaxmiumRecents:.
        (WebCore::RenderThemeMac::paintSearchFieldResultsButton): Replaced calling
        -setMaximumRecents: with setting the search menu template.
        (WebCore::RenderThemeMac::search): Removed initialization of the menu.
        (WebCore::RenderThemeMac::searchMenuTemplate): Added. Returns an empty
        NSMenu to be used as the search menu template.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for bug 13907, <noscript> should be allowed inside <head> when
hyatt [Tue, 29 May 2007 21:32:07 +0000 (21:32 +0000)]
    Fix for bug 13907, <noscript> should be allowed inside <head> when
        scripting is enabled.

        Reviewed by aroben

        * html/HTMLHeadElement.cpp:
        * html/HTMLParser.cpp:
        * html/HTMLParserErrorCodes.cpp:
        * html/HTMLParserErrorCodes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Tue, 29 May 2007 20:33:04 +0000 (20:33 +0000)]

        Reviewed by Maciej.

        - test for http://bugs.webkit.org/show_bug.cgi?id=13792
          REGRESSION: WebKit doesn't show this javascript screenshot page (and crashes after click on its "hidden link")

        * fast/frames/removal-before-attach-crash-expected.txt: Added.
        * fast/frames/removal-before-attach-crash.html: Added.


        Reviewed by Maciej.

        - fix crash in http://bugs.webkit.org/show_bug.cgi?id=13792
          REGRESSION: WebKit doesn't show this javascript screenshot page (and crashes after click on its "hidden link")

        Test: fast/frames/removal-before-attach-crash.html

        Delayed the queueing of the post-attach callback until attach().

        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::parseMappedAttribute): Replaced call to the
        HTMLElement implementation with a call to the HTMLFrameOwnerElement
        implementation, as the latter is the parent class.
        (WebCore::HTMLFrameElementBase::insertedIntoDocument): Instead of queueing
        the post-attach callback here, just set a flag telling us to do so
        at the beginning of attach().
        (WebCore::HTMLFrameElementBase::removedFromDocument): Reset the above flag.
        (WebCore::HTMLFrameElementBase::attach): If this is the first attach() after
        being inserted into the document, queue a post-attach callback to load the
        (WebCore::HTMLFrameElementBase::willRemove): Changed to call up to the correct
        parent class.
        (WebCore::HTMLFrameElementBase::setFocus): Ditto.
        * html/HTMLFrameElementBase.h:
        * html/HTMLPlugInElement.cpp:
        (WebCore::HTMLPlugInElement::mapToEntry): Replaced call to the HTMLElement
        implementation with a call to the HTMLFrameOwnerElement implementation,
        as the latter is the parent class.
        (WebCore::HTMLPlugInElement::parseMappedAttribute): Ditto.
        (WebCore::HTMLPlugInElement::checkDTD): Ditto.
        (WebCore::HTMLPlugInElement::detach): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Tue, 29 May 2007 19:39:14 +0000 (19:39 +0000)]

        Reviewed by Maciej.

        - test for http://bugs.webkit.org/show_bug.cgi?id=13602
          Amazon product pages keep repainting over and over again

        * fast/dom/HTMLElement/set-inner-outer-optimization-expected.txt: Added.
        * fast/dom/HTMLElement/set-inner-outer-optimization.html: Added.

        * editing/execCommand/copy-without-selection.html: Added missing preventDefault calls
        to prevent this from being a double-paste test.

        * fast/css/first-letter-detach-expected.checksum: Updated.
        * fast/css/first-letter-detach-expected.png: Updated.
        * fast/css/first-letter-detach-expected.txt: Updated.
        * fast/css/first-letter-detach.html: Updated to test three different ways of setting the
        text of the first-letter element; setInnerHTML and two other ways.

        * fast/events/updateLayoutForHitTest-expected.txt: Updated result that changed slightly
        due to setInnerHTML improvement.
        * fast/forms/textarea-setinnerhtml-expected.txt: Ditto.


        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13602
          Amazon product pages keep repainting over and over again

        - fix first-letter when the text of the affected text node is changed

        Optimize setInnerHTML, setOuterHTML, and setInnerText so they don't change the DOM at all
        if they don't need to.

        Test: fast/dom/HTMLElement/set-inner-outer-optimization.html
        Test: fast/css/first-letter-detach.html

        * html/HTMLElement.cpp:
        (WebCore::equal): Added. Helper function that compares two Text nodes or two NamedAttrMap
        attribute maps.
        (WebCore::shallowEqual): Added. Helper function that compares two Element nodes or two
        arbitrary nodes.
        (WebCore::childrenAreEqual): Added. Helper functions that compare children of nodes.
        (WebCore::hasOneChild): Added. Helper function.
        (WebCore::hasOneTextChild): Added. Helper function.
        (WebCore::replaceChildrenWithFragment): Added. Helper function used by setInnerHTML and
        setInnerText. Optimizes the cases where all the nodes are the same, where both the current
        and the new content are single text nodes, and where the current content is a single node
        that can be replaced with replaceChild.
        (WebCore::replaceChildrenWithText): Added. Helper function used by setInnerText. Optimizes
        the case where the current content is a single text node or a single node that can be
        replaced with replaceChild.
        (WebCore::HTMLElement::setInnerHTML): Changed to call replaceChildrenWithFragment.
        (WebCore::HTMLElement::setOuterHTML): Added special case to optimize when the new content
        exactly matches the current node.
        (WebCore::HTMLElement::setInnerText): Changed to call replaceChildrenWithText in a few
        cases instead of doing removeChildren/appendChild. Changed code that was using
        DeprecatedString to instead use String. Changed general case to use a document fragment
        and replaceChildrenWithFragment.

        * dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
        Fixed bug where we would not dispatch the DOMSubtreeModified event unless someone
        was registered for the DOMCharacterDataModified event. Caused trouble in the test.

        * rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter): Set first-letter
        after the setStyle call so calls to setTextInternal inside setStyle don't clear it.

        * rendering/RenderText.h: Made setTextInternal virtual so that RenderTextFragment can do
        appropriate work when the text changes.

        * rendering/RenderTextFragment.h: Added an override of setTextInternal. Removed the
        firstLetter parameter to the constructor and made it a separate setter. Also changed
        m_generatedContentStr to m_contentString to match the getter function.
        * rendering/RenderTextFragment.cpp:
        (WebCore::RenderTextFragment::RenderTextFragment): Removed firstLetter parameter.
        (WebCore::RenderTextFragment::setTextInternal): When the text changes, destroy the
        first-letter node and reset the fragment values so that RenderBlock::updateFirstLetter,
        which will run during layout, will create a new first-letter child. Otherwise we end up
        with the first letter of the old text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix Qt build.
weinig [Tue, 29 May 2007 18:53:42 +0000 (18:53 +0000)]
    Fix Qt build.

        * platform/NotImplemented.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-29 David Kilzer <ddkilzer@webkit.org>
ddkilzer [Tue, 29 May 2007 18:41:38 +0000 (18:41 +0000)]
2007-05-29  David Kilzer  <ddkilzer@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13901
          run-pageloadtest does not obey testName on command-line

        * Scripts/run-pageloadtest: Grab $testName from the command-line if it is present,
        otherwise default to "svg".  Added dummy check to make sure $testName.pltsuite

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
weinig [Tue, 29 May 2007 18:37:58 +0000 (18:37 +0000)]
    Reviewed by Adam Roben.

        Consolidate platform dependent notImplemented() macros
        into one platform independent macro that uses WTFLog.

        * platform/NotImplemented.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21858 268f45cc-cd09-0410-ab3c-d52691b4dbfc