WebKit-https.git
11 years ago2010-06-17 Shu Chang <chang.shu@nokia.com>
chang.shu@nokia.com [Thu, 17 Jun 2010 17:46:41 +0000 (17:46 +0000)]
2010-06-17  Shu Chang  <chang.shu@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix the link error on symbian with ENABLE_JIT=0.
        1. Add "#if ENABLE(JIT)" in the header file;
        2. Put feature enable/disable logic to a common.pri so
        that both JavaScriptCore.pri and WebCore.pri can share.

        https://bugs.webkit.org/show_bug.cgi?id=40780

        * JavaScriptCore.pri:
        * jit/ExecutableAllocator.h:

2010-06-17  Shu Chang  <chang.shu@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix the link error on symbian with ENABLE_JIT=0.
        1. Add "#if ENABLE(JIT)" in the header file;
        2. Put feature enable/disable logic to a common.pri so
        that both JavaScriptCore.pri and WebCore.pri can share.

        https://bugs.webkit.org/show_bug.cgi?id=40780

        * common.pri: Added.

2010-06-17  Shu Chang  <chang.shu@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix the link error on symbian with ENABLE_JIT=0.
        1. Add "#if ENABLE(JIT)" in the header file;
        2. Put feature enable/disable logic to a common.pri so
        that both JavaScriptCore.pri and WebCore.pri can share.

        https://bugs.webkit.org/show_bug.cgi?id=40780

        * WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 17 Jun 2010 17:39:54 +0000 (17:39 +0000)]
2010-06-17  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Differences in error reporting for overloaded methods causing fast/canvas/webgl/texImageTest.html to fail
        https://bugs.webkit.org/show_bug.cgi?id=40750

        Added V8Proxy::throwTypeError() and throwSyntaxError for parity
        with JSC::throwTypeError() and throwSyntaxError. Changed
        CodeGeneratorV8.pm to use throwTypeError for overload resolution
        failures. Revised CodeGeneratorJS.pm to use throwVMTypeError
        instead of manual call to JSValue::encode. Deleted now-unnecessary
        Chromium expectations for fast/canvas/webgl/texImageTest.html.

        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::throwTypeError):
        (WebCore::V8Proxy::throwSyntaxError):
        * bindings/v8/V8Proxy.h:
2010-06-17  Kenneth Russell  <kbr@google.com>

        Reviewed by Oliver Hunt.

        Differences in error reporting for overloaded methods causing fast/canvas/webgl/texImageTest.html to fail
        https://bugs.webkit.org/show_bug.cgi?id=40750

        Added V8Proxy::throwTypeError() and throwSyntaxError for parity
        with JSC::throwTypeError() and throwSyntaxError. Changed
        CodeGeneratorV8.pm to use throwTypeError for overload resolution
        failures. Revised CodeGeneratorJS.pm to use throwVMTypeError
        instead of manual call to JSValue::encode. Deleted now-unnecessary
        Chromium expectations for fast/canvas/webgl/texImageTest.html.

        * platform/chromium-mac/fast/canvas/webgl/texImageTest-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 17 Jun 2010 17:24:03 +0000 (17:24 +0000)]
2010-06-17  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed.

        tables/mozilla/images/adforce_imgis_com.html was removed after r61289. Remove
        it from the GTK+ skipped list.

        * platform/gtk/Skipped: Remove a defunct test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 17 Jun 2010 17:23:31 +0000 (17:23 +0000)]
2010-06-17  Darin Fisher  <darin@chromium.org>

        Reviewed by Brady Eidson.

        If Page::goToItem is passed a HistoryItem that is the current item,
        then the page should be loaded again.

        https://bugs.webkit.org/show_bug.cgi?id=40660

        * loader/HistoryController.cpp:
        (WebCore::HistoryController::recursiveGoToItem): Add a check to
        recursiveGoToItem that matches the one in FrameLoader::loadItem.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 17 Jun 2010 17:06:13 +0000 (17:06 +0000)]
2010-06-17  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        [BREWMP] Build fix for DragDataBrew
        https://bugs.webkit.org/show_bug.cgi?id=40610

        http://trac.webkit.org/changeset/60957 was not applied to DragDataBrew.cpp.
        Add FilenameConversionPolicy argument to DragData::containsURL and DragData::asURL.

        * platform/brew/DragDataBrew.cpp:
        (WebCore::DragData::containsURL):
        (WebCore::DragData::asURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Thu, 17 Jun 2010 16:53:51 +0000 (16:53 +0000)]
2010-06-17  Zhenyao Mo  <zmo@google.com>

        Reviewed by David Levin.

        Rename internalformat to internalFormat
        https://bugs.webkit.org/show_bug.cgi?id=40149

        * html/canvas/WebGLFramebuffer.cpp: Rename internalformat to internalFormat.
        (WebCore::WebGLFramebuffer::getColorBufferFormat):
        * html/canvas/WebGLRenderbuffer.cpp: Ditto.
        (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
        * html/canvas/WebGLRenderbuffer.h: Ditto.
        (WebCore::WebGLRenderbuffer::setInternalFormat):
        (WebCore::WebGLRenderbuffer::getInternalFormat):
        * html/canvas/WebGLRenderingContext.cpp: Ditto.
        (WebCore::WebGLRenderingContext::copyTexImage2D):
        (WebCore::WebGLRenderingContext::copyTexSubImage2D):
        (WebCore::WebGLRenderingContext::framebufferRenderbuffer):
        (WebCore::WebGLRenderingContext::getRenderbufferParameter):
        (WebCore::WebGLRenderingContext::renderbufferStorage):
        (WebCore::WebGLRenderingContext::texImage2DBase):
        (WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid):
        * html/canvas/WebGLRenderingContext.h: Ditto.
        * html/canvas/WebGLTexture.cpp: Ditto.
        (WebCore::WebGLTexture::WebGLTexture):
        * html/canvas/WebGLTexture.h: Ditto.
        (WebCore::WebGLTexture::setInternalFormat):
        (WebCore::WebGLTexture::getInternalFormat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Thu, 17 Jun 2010 16:39:38 +0000 (16:39 +0000)]
2010-06-17  Zhenyao Mo  <zmo@google.com>

        Reviewed by David Levin.

        Remove input parameter validation for "level" upper limit in *tex* functions
        https://bugs.webkit.org/show_bug.cgi?id=40603

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::validateTexFuncParameters): Don't check for "level" upper limit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Lucas De Marchi <lucas.demarchi@profusion.mobi>
eric@webkit.org [Thu, 17 Jun 2010 16:26:13 +0000 (16:26 +0000)]
2010-06-17  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Eric Seidel.

        Clean EFL header files in order to diminish the compilation time with
        EFL from subversion. We remove the EFL includes from header files and use
        forward declarations, including the headers in correspondent source
        files when needed. This causes only the needed source files to be
        recompiled in case a new version of EFL is installed instead of
        triggering a recompilation of almost all WebCore/WebKit.
        https://bugs.webkit.org/show_bug.cgi?id=40575

        No new functionalities, so no new tests.

        * CMakeListsEfl.txt:
        * platform/PlatformKeyboardEvent.h: forward declaration.
        * platform/PlatformMouseEvent.h: forward declaration and change method
        signature to not require enum.
        * platform/PlatformWheelEvent.h: forward declaration.
        * platform/Widget.h: forward declaration.
        * platform/efl/PlatformKeyboardEventEfl.cpp: include needed header.
        * platform/efl/PlatformMouseEventEfl.cpp:
        (WebCore::PlatformMouseEvent::setClickCount): change method signature
        as mentioned above.
        * platform/efl/PlatformWheelEventEfl.cpp: include needed header.
        * platform/efl/RenderThemeEfl.cpp: include needed header
        * platform/efl/RenderThemeEfl.h: forward declaration.
        * platform/efl/ScrollbarEfl.cpp: include needed header.
        * platform/efl/ScrollbarEfl.h: forward declaration.
        * platform/efl/WidgetEfl.cpp: include needed header.
        * platform/graphics/FloatRect.h: remove unused method.
        * platform/graphics/Icon.h: forward declaration.
        * platform/graphics/IntRect.h: remove unused method.
        * platform/graphics/efl/FloatRectEfl.cpp: Removed. This file was
        implementing an unused method.
        * platform/graphics/efl/IntRectEfl.cpp: Removed. This file was
        implementing an unused method.
2010-06-17  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Eric Seidel.

        Clean EFL header files in order to diminish the compilation time with
        EFL from subversion. We remove the EFL includes from header files and use
        forward declarations, including the headers in correspondent source
        files when needed. This causes only the needed source files to be
        recompiled in case a new version of EFL is installed instead of
        triggering a recompilation of almost all WebCore/WebKit.
        https://bugs.webkit.org/show_bug.cgi?id=40575

        * efl/WebCoreSupport/ChromeClientEfl.cpp: include needed header.
        * efl/WebCoreSupport/ChromeClientEfl.h: forward declaration.
        * efl/WebCoreSupport/EditorClientEfl.h: forward declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 17 Jun 2010 16:25:37 +0000 (16:25 +0000)]
2010-06-17  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, test expectations update.

        * platform/chromium-mac/fast/dom/wrapper-classes-expected.txt:
        * platform/chromium-win/fast/dom/wrapper-classes-expected.txt: Updated results after r61322.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoOne more try at fix for Chromium build.
darin@apple.com [Thu, 17 Jun 2010 15:51:29 +0000 (15:51 +0000)]
One more try at fix for Chromium build.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell): Use set again instead of =.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Chromium build.
darin@apple.com [Thu, 17 Jun 2010 15:45:14 +0000 (15:45 +0000)]
Fix Chromium build.

       I didn't realize that neither Chromium nor Qt share the DumpRenderTree
code with all the other platforms! Wow, that should be fixed at some point.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell): Changed back to using "new".
* DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed Qt build fix.
hausmann@webkit.org [Thu, 17 Jun 2010 15:16:04 +0000 (15:16 +0000)]
Unreviewed Qt build fix.

LayoutTestController in the Qt DRT is not using refs :)

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Alex Milowski <alex@milowski.com>
darin@apple.com [Thu, 17 Jun 2010 15:11:42 +0000 (15:11 +0000)]
2010-06-17  Alex Milowski  <alex@milowski.com>

        Reviewed by Darin Adler.

        Fixed a compile error in the paint() methods by making them use the
        new visitedDependentColor() method.
        https://bugs.webkit.org/show_bug.cgi?id=40327

        * mathml/RenderMathMLRoot.cpp:
        (WebCore::RenderMathMLRoot::paint):
        (WebCore::RenderMathMLRoot::layout): Fixed a crash where every child
        was assumed to be a RenderMathMLBlock instance when that isn't the
        case.  Also, layout() needed to mark the index for layout before
        calling layout() on the index.
        * mathml/RenderMathMLSquareRoot.cpp:
        (WebCore::RenderMathMLSquareRoot::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Upstream the WebKit QML integration plugin
hausmann@webkit.org [Thu, 17 Jun 2010 15:03:46 +0000 (15:03 +0000)]
[Qt] Upstream the WebKit QML integration plugin
https://bugs.webkit.org/show_bug.cgi?id=40050

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-17
Reviewed by Kenneth Rohde Christiansen.

.:

Add to the build the QML WebKit integration plugin.

* WebKit.pro:

WebKit/qt:

Add to the Qt port the QML WebKit integration plugin.
QDeclarativeWebView is creating the item and expose
properties. The C++ API is not public, only the
properties are.

* declarative/declarative.pro: Added.
* declarative/plugin.cpp: Added.
(WebKitQmlPlugin::registerTypes):
* declarative/qdeclarativewebview.cpp: Added.
(QDeclarativeWebViewPrivate::QDeclarativeWebViewPrivate):
(QDeclarativeWebViewPrivate::):
(QDeclarativeWebViewPrivate::windowObjectsAppend):
(GraphicsWebView::GraphicsWebView):
(GraphicsWebView::mousePressEvent):
(GraphicsWebView::mouseReleaseEvent):
(GraphicsWebView::mouseDoubleClickEvent):
(GraphicsWebView::timerEvent):
(GraphicsWebView::mouseMoveEvent):
(QDeclarativeWebView::QDeclarativeWebView):
(QDeclarativeWebView::~QDeclarativeWebView):
(QDeclarativeWebView::init):
(QDeclarativeWebView::componentComplete):
(QDeclarativeWebView::status):
(QDeclarativeWebView::progress):
(QDeclarativeWebView::doLoadStarted):
(QDeclarativeWebView::doLoadProgress):
(QDeclarativeWebView::pageUrlChanged):
(QDeclarativeWebView::doLoadFinished):
(QDeclarativeWebView::url):
(QDeclarativeWebView::setUrl):
(QDeclarativeWebView::preferredWidth):
(QDeclarativeWebView::setPreferredWidth):
(QDeclarativeWebView::preferredHeight):
(QDeclarativeWebView::setPreferredHeight):
(QDeclarativeWebView::evaluateJavaScript):
(QDeclarativeWebView::updateDeclarativeWebViewSize):
(QDeclarativeWebView::initialLayout):
(QDeclarativeWebView::updateContentsSize):
(QDeclarativeWebView::geometryChanged):
(QDeclarativeWebView::javaScriptWindowObjects):
(QDeclarativeWebView::qmlAttachedProperties):
(QDeclarativeWebViewPrivate::updateWindowObjects):
(QDeclarativeWebView::renderingEnabled):
(QDeclarativeWebView::setRenderingEnabled):
(QDeclarativeWebView::heuristicZoom):
(QDeclarativeWebView::pressGrabTime):
(QDeclarativeWebView::setPressGrabTime):
(QDeclarativeWebView::backAction):
(QDeclarativeWebView::forwardAction):
(QDeclarativeWebView::reloadAction):
(QDeclarativeWebView::stopAction):
(QDeclarativeWebView::title):
(QDeclarativeWebView::icon):
(QDeclarativeWebView::setStatusText):
(QDeclarativeWebView::windowObjectCleared):
(QDeclarativeWebView::statusText):
(QDeclarativeWebView::page):
(QDeclarativeWebView::settingsObject):
(QDeclarativeWebView::setPage):
(QDeclarativeWebView::load):
(QDeclarativeWebView::html):
(QDeclarativeWebView::setHtml):
(QDeclarativeWebView::setContent):
(QDeclarativeWebView::history):
(QDeclarativeWebView::settings):
(QDeclarativeWebView::createWindow):
(QDeclarativeWebView::newWindowComponent):
(QDeclarativeWebView::setNewWindowComponent):
(QDeclarativeWebView::newWindowParent):
(QDeclarativeWebView::setNewWindowParent):
(QDeclarativeWebView::contentsSize):
(QDeclarativeWebView::contentsScale):
(QDeclarativeWebView::setContentsScale):
(QDeclarativeWebView::elementAreaAt):
(QDeclarativeWebPage::QDeclarativeWebPage):
(QDeclarativeWebPage::~QDeclarativeWebPage):
(QDeclarativeWebPage::chooseFile):
(QDeclarativeWebPage::javaScriptAlert):
(QDeclarativeWebPage::javaScriptConfirm):
(QDeclarativeWebPage::javaScriptPrompt):
(QDeclarativeWebPage::viewItem):
(QDeclarativeWebPage::createWindow):
* declarative/qdeclarativewebview_p.h: Added.
(QDeclarativeWebView::):
(QDeclarativeWebView::isComponentCompletePublic):
(QDeclarativeWebViewAttached::QDeclarativeWebViewAttached):
(QDeclarativeWebViewAttached::windowObjectName):
(QDeclarativeWebViewAttached::setWindowObjectName):
(QDeclarativeWebSettings::QDeclarativeWebSettings):
(QDeclarativeWebSettings::standardFontFamily):
(QDeclarativeWebSettings::setStandardFontFamily):
(QDeclarativeWebSettings::fixedFontFamily):
(QDeclarativeWebSettings::setFixedFontFamily):
(QDeclarativeWebSettings::serifFontFamily):
(QDeclarativeWebSettings::setSerifFontFamily):
(QDeclarativeWebSettings::sansSerifFontFamily):
(QDeclarativeWebSettings::setSansSerifFontFamily):
(QDeclarativeWebSettings::cursiveFontFamily):
(QDeclarativeWebSettings::setCursiveFontFamily):
(QDeclarativeWebSettings::fantasyFontFamily):
(QDeclarativeWebSettings::setFantasyFontFamily):
(QDeclarativeWebSettings::minimumFontSize):
(QDeclarativeWebSettings::setMinimumFontSize):
(QDeclarativeWebSettings::minimumLogicalFontSize):
(QDeclarativeWebSettings::setMinimumLogicalFontSize):
(QDeclarativeWebSettings::defaultFontSize):
(QDeclarativeWebSettings::setDefaultFontSize):
(QDeclarativeWebSettings::defaultFixedFontSize):
(QDeclarativeWebSettings::setDefaultFixedFontSize):
(QDeclarativeWebSettings::autoLoadImages):
(QDeclarativeWebSettings::setAutoLoadImages):
(QDeclarativeWebSettings::javascriptEnabled):
(QDeclarativeWebSettings::setJavascriptEnabled):
(QDeclarativeWebSettings::javaEnabled):
(QDeclarativeWebSettings::setJavaEnabled):
(QDeclarativeWebSettings::pluginsEnabled):
(QDeclarativeWebSettings::setPluginsEnabled):
(QDeclarativeWebSettings::privateBrowsingEnabled):
(QDeclarativeWebSettings::setPrivateBrowsingEnabled):
(QDeclarativeWebSettings::javascriptCanOpenWindows):
(QDeclarativeWebSettings::setJavascriptCanOpenWindows):
(QDeclarativeWebSettings::javascriptCanAccessClipboard):
(QDeclarativeWebSettings::setJavascriptCanAccessClipboard):
(QDeclarativeWebSettings::developerExtrasEnabled):
(QDeclarativeWebSettings::setDeveloperExtrasEnabled):
(QDeclarativeWebSettings::linksIncludedInFocusChain):
(QDeclarativeWebSettings::setLinksIncludedInFocusChain):
(QDeclarativeWebSettings::zoomTextOnly):
(QDeclarativeWebSettings::setZoomTextOnly):
(QDeclarativeWebSettings::printElementBackgrounds):
(QDeclarativeWebSettings::setPrintElementBackgrounds):
(QDeclarativeWebSettings::offlineStorageDatabaseEnabled):
(QDeclarativeWebSettings::setOfflineStorageDatabaseEnabled):
(QDeclarativeWebSettings::offlineWebApplicationCacheEnabled):
(QDeclarativeWebSettings::setOfflineWebApplicationCacheEnabled):
(QDeclarativeWebSettings::localStorageDatabaseEnabled):
(QDeclarativeWebSettings::setLocalStorageDatabaseEnabled):
(QDeclarativeWebSettings::localContentCanAccessRemoteUrls):
(QDeclarativeWebSettings::setLocalContentCanAccessRemoteUrls):
* declarative/qmldir: Added.
* docs/qtwebkit.qdocconf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 17 Jun 2010 14:58:48 +0000 (14:58 +0000)]
2010-06-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Use adoptRef and create functions in more code paths
        https://bugs.webkit.org/show_bug.cgi?id=40760

        * API/JSClassRef.h: Removed unneeded include of RefCounted.h.
        * API/JSWeakObjectMapRefPrivate.cpp: Ditto.

        * bytecode/CodeBlock.h:
        (JSC::FunctionCodeBlock::FunctionCodeBlock): Use the
        SharedSymbolTable::create function instead of calling new directly.

        * runtime/SymbolTable.h: Added a create function to the SharedSymbolTable
        class and made the constructor private.
2010-06-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Use adoptRef and create functions in more code paths
        https://bugs.webkit.org/show_bug.cgi?id=40760

        * Plugins/Hosted/NetscapePluginInstanceProxy.h: Made create no longer
        be an inline function.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
        Moved the call to addPluginInstance out of here.
        (WebKit::NetscapePluginInstanceProxy::create): Move it in here.
        This makes sure we call adoptRef on the new proxy before any caller
        calls ref on it.
2010-06-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Use adoptRef and create functions in more code paths
        https://bugs.webkit.org/show_bug.cgi?id=40760

        This helps prepare for an assertion that fires if you ref or destroy an
        object before calling adoptRef on it. That will help us catch mistakes
        that can lead to storage leaks.

        * WebCore.base.exp: Updated export now that Frame::create is not an
        inline function.

        * css/CSSInitialValue.h:
        (WebCore::CSSInitialValue::createExplicit): Use create.
        (WebCore::CSSInitialValue::createImplicit): Ditto.
        (WebCore::CSSInitialValue::create): Added.

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::createUncachedIdentifier): Added.
        (WebCore::CSSPrimitiveValue::createUncachedColor): Added.
        (WebCore::CSSPrimitiveValue::createUncached): Added.
        (WebCore::CSSPrimitiveValue::createIdentifier): Use createUncachedIdentifier
        instead of using new directly.
        (WebCore::CSSPrimitiveValue::createColor): Use createUncachedColor instead
        of using new directly.
        (WebCore::CSSPrimitiveValue::create): Use createdUncached instead of using
        new directly.
        * css/CSSPrimitiveValue.h: Declare the new functions above.

        * css/CSSStyleSelector.cpp:
        (WebCore::loadFullDefaultStyle): Deref simpleDefaultStyleSheet instead of
        explicitly deleting it.

        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::SubresourceLoader): Move the call to
        addSubresourceLoader out of here.
        (WebCore::SubresourceLoader::create): Move it in here. This makes it so
        we don't ref the loader before finishing its creation and calling adoptRef.

        * page/Frame.cpp:
        (WebCore::Frame::Frame): Move the call to setMainFrame out of here.
        Also refactor the code so an assertion is easier to read.
        (WebCore::Frame::create): Move the call to setMainFrame in here.
        This makes it so we don't ref the frame before finishing its creation
        and calling adoptRef.
        * page/Frame.h: Made the create function non-inline.

        * platform/text/BidiContext.cpp:
        (WebCore::BidiContext::createUncached): Added.
        (WebCore::BidiContext::create): Call createUncached instead of callling
        new directly.
        * platform/text/BidiContext.h: Declare createUncached.

        * rendering/RenderSVGResourceFilter.cpp:
        (WebCore::RenderSVGResourceFilter::buildPrimitives): Use PassRefPtr and
        RefPtr instead of OwnPtr. And use the create function instead of new.
        * rendering/RenderSVGResourceFilter.h: Ditto.
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeSVGResourceContainer): Ditto.

        * storage/StorageAreaImpl.cpp:
        (WebCore::StorageAreaImpl::StorageAreaImpl): Move the code that calls
        StorageAreaSync::create out of here.
        (WebCore::StorageAreaImpl::create): Move it in here. This makes it so we
        don't ref the storage area before finishing its creation and calling adoptRef.

        * svg/SVGPaint.cpp:
        (WebCore::SVGPaint::defaultFill): Use create instead of new.
        (WebCore::SVGPaint::defaultStroke): Ditto.

        * svg/graphics/filters/SVGFilterBuilder.h: Made the constructor private
        and added a create function since this is a reference counted object and
        should not be constructed directly.
2010-06-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Use adoptRef and create functions in more code paths
        https://bugs.webkit.org/show_bug.cgi?id=40760

        * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::create): Added.
        * DumpRenderTree/LayoutTestController.h: Declare the create function.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell): Use create instead of new.
        * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (runTest): Use RefPtr and create instead of OwnPtr and new.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (runTest): Use RefPtr and create instead of OwnPtr and new.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
        instead of new.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (runTest): Use RefPtr and create instead of OwnPtr and new.

        * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
        (runTest): Use RefPtr and create instead of OwnPtr and new.
        (MyApp::OnInit): Removed unneeded code to delete the layout
        test controller. This is done during each test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Update CMake build system to use new script for generating source files
abecsi@webkit.org [Thu, 17 Jun 2010 14:47:03 +0000 (14:47 +0000)]
    Update CMake build system to use new script for generating source files
        with gperf (r61091).
        https://bugs.webkit.org/show_bug.cgi?id=40628

        Patch by Lucas De Marchi <lucas.demarchi@profusion.mobi> on 2010-06-17
        Reviewed by Gustavo Noronha.

    * cmake/WebKitGenerators.cmake:

        WebCore: Update CMake build system to use new script for generating source files
        with gperf (r61091).
        This updates also the build system to cope with recent changes to
        source files list.
        https://bugs.webkit.org/show_bug.cgi?id=40628

        Patch by Lucas De Marchi <lucas.demarchi@profusion.mobi> on 2010-06-17
        Reviewed by Gustavo Noronha.

        No new tests since it's just compilation fixes.

    * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 17 Jun 2010 14:24:09 +0000 (14:24 +0000)]
2010-06-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Fix boolean reflected attributes to use empty string consistently for the content attribute value
        https://bugs.webkit.org/show_bug.cgi?id=40758

        Test: fast/dom/boolean-attribute-reflection.html

        The HTML5 specification and other browsers are all consistent:
        When setting a boolean IDL attribute to true, the attribute value
        gets set to the empty string. The guidelines for authors allow either
        the empty string or the name of the attribute, but for implementers
        of the DOM, the reflected attribute gets empty string.

        * dom/Element.cpp:
        (WebCore::Element::setBooleanAttribute): Use emptyAtom to set the
        attribute to the empty string.

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::setAutofocus): Use the empty string,
        not "autofocus".
        (WebCore::HTMLFormControlElement::setRequired): Use the empty string,
        not "required".
2010-06-17  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Fix boolean reflected attributes to use empty string consistently for the content attribute value
        https://bugs.webkit.org/show_bug.cgi?id=40758

        * fast/dom/boolean-attribute-reflection-expected.txt: Added.
        * fast/dom/boolean-attribute-reflection.html: Added.
        * fast/dom/script-tests/boolean-attribute-reflection.js: Added.

        * fast/dom/wrapper-classes-expected.txt: Regenerated.
        * fast/dom/wrapper-classes.html: Added some classes.

        * media/video-controls-expected.txt: Regenerated.
        * media/video-controls.html: Changed to expect the new correct results.
        Removed unnecessary use of offsetTop to force layout. This test covers only
        the DOM and has nothing to do with layout.

        * svg/dom/svgpath-getPathSegAtLength.html: Let the
        make-script-test-wrappers script regenerate this file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 17 Jun 2010 13:19:29 +0000 (13:19 +0000)]
2010-06-17  Pavel Feldman  <pfeldman@chromium.org>

        Unreviewed: chromium tests fix. Added InspectorBackend delegates for new inspector methods.

        * inspector/front-end/InspectorBackendStub.js:
        (.WebInspector.InspectorBackendStub.prototype.clearConsoleMessages):
        (.WebInspector.InspectorBackendStub.prototype.getOuterHTML):
        (.WebInspector.InspectorBackendStub.prototype.setOuterHTML):
        (.WebInspector.InspectorBackendStub.prototype.addInspectedNode):

2010-06-17  Pavel Feldman  <pfeldman@chromium.org>

        Unreviewed: chromium tests fix. Added InspectorBackend delegates for new inspector methods.

        * src/js/InspectorControllerImpl.js:
        (devtools.InspectorBackendImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Thu, 17 Jun 2010 12:19:29 +0000 (12:19 +0000)]
2010-06-17  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        [Chromium] Prepare to making WebDevToolsAgentClient::sendMessageToFrontendOnIOThread virtual

        https://bugs.webkit.org/show_bug.cgi?id=39302

        * public/WebDevToolsAgent.h:
        * public/WebDevToolsAgentClient.h:
        (WebKit::WebDevToolsMessageTransport::~WebDevToolsMessageTransport):
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::):
        (WebKit::WebDevToolsAgent::dispatchMessageFromFrontendOnIOThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] use "win32-g++*" scope to match all MinGW makespecs
hausmann@webkit.org [Thu, 17 Jun 2010 10:23:11 +0000 (10:23 +0000)]
[Qt] use "win32-g++*" scope to match all MinGW makespecs

Patch by Mark Brand <mabrand@mabrand.nl> on 2010-06-17
Reviewed by Simon Hausmann.

The scope "win32-g++" comes from the name of the makespec. However, it
is frequently used to check for MinGW. This works fine as long as
win32-g++ is the only makespec for MinGW. Now we need the wildcard
to cover "win32-g++-cross" as well.

.:

* WebKit.pri:

JavaScriptCore:

* JavaScriptCore.pro:

WebCore:

* WebCore.pro:

WebKit/qt:

* Api/DerivedSources.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 17 Jun 2010 10:20:54 +0000 (10:20 +0000)]
2010-06-17  Pavel Feldman  <pfeldman@chromium.org>

        Unreviewed, tests fix.

        * inspector/elements-panel-search.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 17 Jun 2010 09:43:57 +0000 (09:43 +0000)]
2010-06-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Joe Pecoraro.

        Web Inspector: move get/setOuterHTML, addInspectedNode and
        clearConsole to native InspectorDOMAgent. This is done to allow
        inspected nodes array to store nodes from different domains,
        also moves outerhtml manipulation closer to the rest of the DOM
        operations. In addition to that, we are slowly getting rid of
        InjectedScriptAccess in favor of IDL-defined InspectorBackend
        interface for clearer remote debugging API.

        https://bugs.webkit.org/show_bug.cgi?id=40733

        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::inspectedNode):
        * inspector/InjectedScriptHost.h:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::changeTagName):
        (WebCore::InspectorBackend::getOuterHTML):
        (WebCore::InspectorBackend::setOuterHTML):
        (WebCore::InspectorBackend::addInspectedNode):
        (WebCore::InspectorBackend::clearConsoleMessages):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::inspectedNode):
        (WebCore::InspectorDOMAgent::changeTagName):
        (WebCore::InspectorDOMAgent::getOuterHTML):
        (WebCore::InspectorDOMAgent::setOuterHTML):
        (WebCore::InspectorDOMAgent::addInspectedNode):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::didGetOuterHTML):
        (WebCore::InspectorFrontend::didSetOuterHTML):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.requestClearMessages):
        * inspector/front-end/DOMAgent.js:
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
        (WebInspector.ElementsPanel):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback):
        (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
        ():
        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):
        * inspector/front-end/InjectedScriptAccess.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 John Gregg <johnnyg@google.com>
eric@webkit.org [Thu, 17 Jun 2010 09:29:23 +0000 (09:29 +0000)]
2010-06-17  John Gregg  <johnnyg@google.com>

        Reviewed by David Levin.

        Move the call to the notification presenter that a Notification is being
        destroyed from the destructor (not safe) to the ActiveDOMObject::contextDestroyed
        method.

        Also fix up an incorrect reference loss in the V8 bindings code for Notifications.
        https://bugs.webkit.org/show_bug.cgi?id=40097

        No new tests; code paths are well-covered by existing tests.

        * bindings/v8/custom/V8NotificationCenterCustom.cpp:
        (WebCore::V8NotificationCenter::createHTMLNotificationCallback):
        (WebCore::V8NotificationCenter::createNotificationCallback):
        * notifications/Notification.cpp:
        (WebCore::Notification::~Notification):
        (WebCore::Notification::contextDestroyed):
        * notifications/Notification.h:
2010-06-17  John Gregg  <johnnyg@google.com>

        Reviewed by David Levin.

        Undo the build fix with the correct patch: Chromium NotificationPresenter
        is now informed of the destruction before it actually happens, so this
        use of the Notification object is correct.
        https://bugs.webkit.org/show_bug.cgi?id=40097

        * src/NotificationPresenterImpl.cpp:
        (WebKit::NotificationPresenterImpl::notificationObjectDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed rollout r61311, because it made 2 tests fail on Qt bot.
ossy@webkit.org [Thu, 17 Jun 2010 09:00:35 +0000 (09:00 +0000)]
Unreviewed rollout r61311, because it made 2 tests fail on Qt bot.

[Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved
https://bugs.webkit.org/show_bug.cgi?id=36702

WebCore:

* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::updatePluginWidget):

LayoutTests:

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 17 Jun 2010 08:31:30 +0000 (08:31 +0000)]
2010-06-17  Kent Tamura  <tkent@chromium.org>

        Reviewed by Shinichiro Hamaji.

        [DRT/Chromium] Fix a bug of Windows pixel tests
        https://bugs.webkit.org/show_bug.cgi?id=40763

        * DumpRenderTree/chromium/TestEventPrinter.cpp:
        (TestShellPrinter::handleImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 17 Jun 2010 08:23:44 +0000 (08:23 +0000)]
2010-06-17  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        Land new expected baselines for fill-opacity-(hsl|rgba).png
        DRT showed a mysterious error, and the baseline obviously had a problem.

        * platform/mac/svg/custom/fill-opacity-hsl-expected.checksum:
        * platform/mac/svg/custom/fill-opacity-hsl-expected.png:
        * platform/mac/svg/custom/fill-opacity-rgba-expected.checksum:
        * platform/mac/svg/custom/fill-opacity-rgba-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Make repaint throttling parameters runtime configurable.
hausmann@webkit.org [Thu, 17 Jun 2010 07:48:31 +0000 (07:48 +0000)]
WebCore: Make repaint throttling parameters runtime configurable.
https://bugs.webkit.org/show_bug.cgi?id=38401

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2010-05-28
Reviewed by Simon Hausmann, Antti Koivisto

REPAINT_THROTTLING now chooses default values for throttling parameters.
Should be removed when applications start using runtime configuration.

* page/FrameView.cpp:
(WebCore::FrameView::reset):
(WebCore::FrameView::updateDeferredRepaintDelay):
(WebCore::FrameView::setRepaintThrottlingDeferredRepaintDelay):
(WebCore::FrameView::setRepaintThrottlingnInitialDeferredRepaintDelayDuringLoading):
(WebCore::FrameView::setRepaintThrottlingMaxDeferredRepaintDelayDuringLoading):
(WebCore::FrameView::setRepaintThrottlingDeferredRepaintDelayIncrementDuringLoading):
* page/FrameView.h:

WebKit/qt: [Qt] Add internal Qt Api to configure repaint throttling parameters.
https://bugs.webkit.org/show_bug.cgi?id=38401

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2010-05-28
Reviewed by Simon Hausmann, Antti Koivisto

* Api/qwebpage.cpp:
(QWebPagePrivate::dynamicPropertyChangeEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-17 Robert Hogan <robert@webkit.org>
eric@webkit.org [Thu, 17 Jun 2010 07:33:11 +0000 (07:33 +0000)]
2010-06-17  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

        https://bugs.webkit.org/show_bug.cgi?id=36702

        setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
        work for DRT. So call it if we are in DRT mode and the window geometry
        has changed.

        Unskips plugins/reentrant-update-widget-positions.html

        * platform/qt/Skipped:
2010-06-17  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved

        https://bugs.webkit.org/show_bug.cgi?id=36702

        setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't
        work for DRT. So call it if we are in DRT mode and the window geometry
        has changed.

        Unskips plugins/reentrant-update-widget-positions.html

        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::updatePluginWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Avoid unnecessary calls to save() and restore() when drawing images
hausmann@webkit.org [Thu, 17 Jun 2010 07:15:46 +0000 (07:15 +0000)]
[Qt] Avoid unnecessary calls to save() and restore() when drawing images

Reviewed by Kenneth Christiansen.

Avoid calling the expensive save() and restore() on the GraphicsContext just
for changing the composition mode. Instead save and restore it manually
on QPainter.

Change fac227f609e544f8f55aca8447b4328d6534407a in Qt makes sure that the
call to QPainter::setCompositionMode doesn't do anything if the mode hasn't
changed.

* platform/graphics/GraphicsContext.h:
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::toQtCompositionMode):
* platform/graphics/qt/ImageQt.cpp:
(WebCore::BitmapImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Hayato Ito <hayato@chromium.org>
hamaji@chromium.org [Thu, 17 Jun 2010 06:59:49 +0000 (06:59 +0000)]
2010-06-16  Hayato Ito  <hayato@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Refactor layout tests for printing to use common code.

        https://bugs.webkit.org/show_bug.cgi?id=40559

        * printing/numberOfPages-expected.txt:
        * printing/numberOfPages.html:
        * printing/page-break-always-expected.txt:
        * printing/page-break-always-for-overflow-expected.txt:
        * printing/page-break-always-for-overflow.html:
        * printing/page-break-always.html:
        * printing/page-break-inside-avoid-expected.txt: Added.
        * printing/page-break-inside-avoid.html: Added.
        * printing/page-break-inside-expected.txt: Removed.
        * printing/page-break-inside.html: Removed.
        * printing/pageNumerForElementById-expected.txt:
        * printing/pageNumerForElementById.html:
        * printing/resources/paged-media-test-utils.js:
        (numberOfPagesShouldBe):
        (ratioToPageHeightToPixels):
        (createBlockWithRatioToPageHeight):
        (createBlockWithNumberOfLines):
        * printing/script-tests/TEMPLATE.html:
        * printing/script-tests/numberOfPages.js:
        (test):
        * printing/script-tests/page-break-always-for-overflow.js:
        (test):
        * printing/script-tests/page-break-always.js:
        (test):
        * printing/script-tests/page-break-inside-avoid.js: Added.
        (test):
        * printing/script-tests/page-break-inside.js: Removed.
        * printing/script-tests/pageNumerForElementById.js:
        (test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 17 Jun 2010 06:28:26 +0000 (06:28 +0000)]
2010-06-16  Kent Tamura  <tkent@chromium.org>

        Reviewed by Shinichiro Hamaji.

        [DRT/Chromium] Fix crash on Mac Release
        https://bugs.webkit.org/show_bug.cgi?id=40759

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::paintRect): We should not use m_canvas directly because
          it is created lazily in canvas().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] QtWebKit crashes while initializing flash plugin 10.1.53.64.
hausmann@webkit.org [Thu, 17 Jun 2010 05:38:10 +0000 (05:38 +0000)]
[Qt] QtWebKit crashes while initializing flash plugin 10.1.53.64.
https://bugs.webkit.org/show_bug.cgi?id=40567

Patch by Dawit Alemayehu <adawit@kde.org> on 2010-06-16
Reviewed by Simon Hausmann.

Avoid preventable crashes by ensuring gtk_init() is called in the
flash viewer plugins before calling NP_Initialize.

* plugins/qt/PluginPackageQt.cpp:
(WebCore::PluginPackage::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Tony Gentilcore <tonyg@chromium.org>
eric@webkit.org [Thu, 17 Jun 2010 05:23:00 +0000 (05:23 +0000)]
2010-06-16  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by David Levin.

        Guarantee that references are held for CachedScripts in HTMLDocumentParser.
        https://bugs.webkit.org/show_bug.cgi?id=40177

        No new tests because no new functionality.

        * html/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::reset):
        (WebCore::HTMLDocumentParser::executeExternalScriptsIfReady):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Jeremy Moskovich <jeremy@chromium.org>
eric@webkit.org [Thu, 17 Jun 2010 05:07:52 +0000 (05:07 +0000)]
2010-06-16  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Darin Adler.

        Improve assertion macro documentation.

        https://bugs.webkit.org/show_bug.cgi?id=40565

        * coding/assertion-guidelines.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Jeremy Moskovich <jeremy@chromium.org>
eric@webkit.org [Thu, 17 Jun 2010 04:29:37 +0000 (04:29 +0000)]
2010-06-16  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Geoffrey Garen.

        Add an index of technical articles to the WebKit site.  This makes the
        links to the RefPtr and Assertion documentation discoverable and
        provides an easy way to find some useful blog posts.

        https://bugs.webkit.org/show_bug.cgi?id=40561

        * coding/technical-articles.html: Added.
        * nav.inc: Add link to technical articles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Qi Zhang <qi.2.zhang@nokia.com>
eric@webkit.org [Thu, 17 Jun 2010 04:15:05 +0000 (04:15 +0000)]
2010-06-16  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Repeat pattern should start from origin
        https://bugs.webkit.org/show_bug.cgi?id=39225

        Remove the following test case from Skipped:
        canvas/philip/tests/2d.pattern.paint.norepeat.coord3.html
        canvas/philip/tests/2d.pattern.paint.repeatx.coord1.html
        canvas/philip/tests/2d.pattern.paint.repeaty.coord1.html

        * platform/qt/Skipped:
2010-06-16  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Laszlo Gombos.

         [Qt] Repeat pattern should start from origin
         https://bugs.webkit.org/show_bug.cgi?id=39225

         Patterns must be painted so that the top left of the first image
         is anchored at the origin of the coordinate space.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::drawRepeatPattern):
        (WebCore::GraphicsContext::fillRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[wx] Build fix after new method addition.
kevino@webkit.org [Thu, 17 Jun 2010 04:04:59 +0000 (04:04 +0000)]
[wx] Build fix after new method addition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
eric@webkit.org [Thu, 17 Jun 2010 02:55:10 +0000 (02:55 +0000)]
2010-06-16  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] WebGL viewport does not show up on N900
        https://bugs.webkit.org/show_bug.cgi?id=38528

        With OGLES2 add default precision to the shader code.
        Use GLsizeiptr and GLintptr with OGLES2.
        Call paint() in beginPaint() so that drawTexture() is used
        whenever possible.

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::beginPaint):
        (WebCore::GraphicsContext3D::paint):
        (WebCore::GraphicsContext3D::shaderSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 17 Jun 2010 02:18:17 +0000 (02:18 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        This "test" no longer exists.  Turns out it was an image resource for
        another test.

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 17 Jun 2010 02:05:54 +0000 (02:05 +0000)]
2010-06-16  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Set current working directory for each of tests
        https://bugs.webkit.org/show_bug.cgi?id=40668

        * DEPS: Update Chromium to r49915 to have
          webkit_support::SetCurrentDirectoryForFileURL().
2010-06-16  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Set current working directory for each of tests
        https://bugs.webkit.org/show_bug.cgi?id=40668

        This change fixes tests with eventSender.beginDragWithFiles().

        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSpatial Navigation: refactor scrollInDirection to work with scrollable content
tonikitoo@webkit.org [Thu, 17 Jun 2010 00:57:15 +0000 (00:57 +0000)]
Spatial Navigation: refactor scrollInDirection to work with scrollable content
https://bugs.webkit.org/show_bug.cgi?id=39195

Reviewed by Simon Fraser.
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebCore:

scrollInDirection now receives as parameter the node that the Spatial Navigation
found as the more appropriated to move focus to. If it is in a scrollable container
(e.g. <div> with clipped overflow content), it scrolls recursively starting from
the container, not the current focused node.

Test: fast/events/spatial-navigation/snav-only-clipped-overflow-content.html

* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusDirectionally):
* page/SpatialNavigation.cpp:
(WebCore::scrollInDirection):
* page/SpatialNavigation.h:

LayoutTests:

* fast/events/spatial-navigation/snav-only-clipped-overflow-content-expected.txt: Added.
* fast/events/spatial-navigation/snav-only-clipped-overflow-content.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=40732
weinig@apple.com [Thu, 17 Jun 2010 00:51:43 +0000 (00:51 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=40732
WebKit2: Implement didClearWindowForFrame for InjectedBundles

Reviewed by Geoffrey Garen.

WebKit2:

More InjectedBundle work.
- Add really basic page level APIs for the WebProcess side:
    - Basic client interface with just didClearWindowForFrame (more will be added later)
    - Simple main frame url getter.

These APIs are experimental and are intended to allow me to get a DRT implementation
up and running. They will be changing.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: Added.
(WKBundlePageSetClient):
(WKBundlePageGetMainFrameURL):
* WebProcess/InjectedBundle/API/c/WKBundlePage.h: Added.
* WebProcess/InjectedBundle/InjectedBundlePageClient.cpp: Added.
(WebKit::InjectedBundlePageClient::InjectedBundlePageClient):
(WebKit::InjectedBundlePageClient::initialize):
(WebKit::InjectedBundlePageClient::didClearWindowObjectForFrame):
* WebProcess/InjectedBundle/InjectedBundlePageClient.h: Added.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::initializeInjectedBundleClient):
(WebKit::WebPage::mainFrameURL):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundleClient):
* mac/WebKit2.exp:
* win/WebKit2.vcproj:

WebKitTools:

- Stub out use of bundlified didClearWindowForFrame with logging.

* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
* MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
* MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.
(_didClearWindow):
(_didCreatePage):
(WKBundleInitialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/7249553> and https://bugs.webkit.org/show_bug.cgi?id=40749
beidson@apple.com [Thu, 17 Jun 2010 00:27:52 +0000 (00:27 +0000)]
<rdar://problem/7249553> and https://bugs.webkit.org/show_bug.cgi?id=40749
ResourceLoader::willCacheResponse() needs to null-check Frame::Settings()

Reviewed by Eric Carlson

No new tests. (Discovered via crash reports, no reproducible cases noted)

* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willCacheResponse):  Null check m_frame->settings(),
  but also add an ASSERT so debug-build developers can learn more about why
  this might be happening.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 16 Jun 2010 23:53:32 +0000 (23:53 +0000)]
2010-06-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        Allow transitions and animations of clip: rect
        https://bugs.webkit.org/show_bug.cgi?id=38130

        Make the CSS clip property animatable.

        Test: transitions/clip-transition.html

        * page/animation/AnimationBase.cpp:
        (WebCore::blendFunc): New blend function for LengthBox
        (WebCore::AnimationBase::ensurePropertyMap): Create a PropertyWrapper for LengthBoxes.

        * platform/LengthBox.h:
        (WebCore::LengthBox::LengthBox): New ctor that takes 4 length values.
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::setClip): New method that takes a LengthBox.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTry to fix the MathML build.
darin@apple.com [Wed, 16 Jun 2010 23:39:14 +0000 (23:39 +0000)]
Try to fix the MathML build.

* mathml/MathMLMathElement.h: Added missing return type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 16 Jun 2010 23:07:32 +0000 (23:07 +0000)]
2010-06-16  Darin Adler  <darin@apple.com>

        Reviewed by David Levin.

        Deploy adoptRef in more places, including all HTML and MathML elements
        https://bugs.webkit.org/show_bug.cgi?id=39941

        * wtf/ThreadSafeShared.h: Made the constructor protected and removed the
        unneeded support for initial reference counts other than 1.
2010-06-16  Darin Adler  <darin@apple.com>

        Reviewed by David Levin.

        Deploy adoptRef in more places, including all HTML and MathML elements
        https://bugs.webkit.org/show_bug.cgi?id=39941

        * dom/Element.cpp:
        (WebCore::Element::dispatchAttrRemovalEvent): Use create instead of new
        in commented-out code.
        (WebCore::Element::dispatchAttrAdditionEvent): Ditto.

        * dom/Node.h: Removed now-unused CreateElementZeroRefCount and
        CreateHTMLElementZeroRefCount.

        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::insertList): Use create instead of new, fixing
        a storage leak.

        * editing/ModifySelectionListLevel.cpp:
        (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel):
        Removed "WithType" from function name. Use create instead of new, fixing a
        storage leak.
        (WebCore::DecreaseSelectionListLevelCommand::decreaseSelectionListLevel): Use
        create instead of new, fixing a storage leak.

        * storage/IndexedDatabaseImpl.cpp:
        (WebCore::IndexedDatabaseImpl::create): Use adoptRef, fixing a storage leak.

        * editing/ModifySelectionListLevel.h: Added create functions.

        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::HTMLAnchorElement):
        * html/HTMLFrameOwnerElement.cpp:
        (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
        * html/HTMLMeterElement.cpp:
        (WebCore::HTMLMeterElement::HTMLMeterElement):
        * html/HTMLProgressElement.cpp:
        (WebCore::HTMLProgressElement::HTMLProgressElement):
        Removed code to explicitly pass CreateHTMLElement construction type since that's
        now the type used for all HTML elements.

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::HTMLFormControlElement):
        * html/HTMLFormControlElement.h:
        Removed construction type argument, since CreateHTMLElement is now the type used
        for all HTML elements.

        * mathml/MathMLElement.cpp:
        (WebCore::MathMLElement::MathMLElement): Removed construction type of
        CreateStyledElementZeroRefCount so we'll use the default construction
        type, CreateStyledElement.
        (WebCore::MathMLElement::create): Use adoptRef.

        * mathml/MathMLElement.h: Made isMathMLElement function private and
        removed unneeded override of createRenderer, because it did the
        same thing as the base class's createRenderer function.

        * mathml/MathMLInlineContainerElement.cpp:
        (WebCore::MathMLInlineContainerElement::create): Use adoptRef.
        (WebCore::MathMLInlineContainerElement::createRenderer):
        Removed unnecessarily initialization of local variable and removed the
        case for mathTag, since that uses a different derived class.

        * mathml/MathMLInlineContainerElement.h: Made createRenderrer override
        private.

        * mathml/MathMLMathElement.cpp:
        (WebCore::MathMLMathElement::MathMLMathElement): Marked inline since
        it is called in only one place.
        (WebCore::MathMLMathElement::create): Use adoptRef.
        (WebCore::MathMLMathElement::createRenderer): Added. Creates a
        RenderMathMLMath object.

        * mathml/MathMLMathElement.h: Made constructor private and added a
        private override of createRenderer.

        * mathml/MathMLTextElement.cpp:
        (WebCore::MathMLTextElement::MathMLTextElement): Marked inline since
        it is called in only one place.
        (WebCore::MathMLTextElement::create): Use adoptRef.
        (WebCore::MathMLTextElement::createRenderer): Changed to call through
        to the base class instead of calling RenderObject::createObject directly.

        * mathml/MathMLTextElement.h: Made the constructor and createRenderer
        function private.

        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::RenderFileUploadControl):
        Removed an unneeded initializer.

        * rendering/RenderProgress.cpp: Tweaked includes.

        * rendering/ShadowElement.cpp: Added a "using namespace" directive.
        * rendering/ShadowElement.h: Tweaked formatting. Made more functions
        private.

        * editing/DeleteButton.cpp:
        (WebCore::DeleteButton::create):
        * html/HTMLAudioElement.cpp:
        (WebCore::HTMLAudioElement::create):
        (WebCore::HTMLAudioElement::createForJSConstructor):
        * html/HTMLBRElement.cpp:
        (WebCore::HTMLBRElement::create):
        * html/HTMLBaseElement.cpp:
        (WebCore::HTMLBaseElement::create):
        * html/HTMLBaseFontElement.cpp:
        (WebCore::HTMLBaseFontElement::create):
        * html/HTMLBlockquoteElement.cpp:
        (WebCore::HTMLBlockquoteElement::create):
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::create):
        * html/HTMLButtonElement.cpp:
        (WebCore::HTMLButtonElement::create):
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::create):
        * html/HTMLDListElement.cpp:
        (WebCore::HTMLDListElement::create):
        * html/HTMLDataGridCellElement.cpp:
        (WebCore::HTMLDataGridCellElement::create):
        * html/HTMLDataGridColElement.cpp:
        (WebCore::HTMLDataGridColElement::create):
        * html/HTMLDataGridElement.cpp:
        (WebCore::HTMLDataGridElement::create):
        * html/HTMLDataGridRowElement.cpp:
        (WebCore::HTMLDataGridRowElement::create):
        * html/HTMLDataListElement.cpp:
        (WebCore::HTMLDataListElement::create):
        * html/HTMLDivElement.cpp:
        (WebCore::HTMLDivElement::create):
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::create):
        * html/HTMLElement.h:
        (WebCore::HTMLElement::HTMLElement):
        * html/HTMLFieldSetElement.cpp:
        (WebCore::HTMLFieldSetElement::create):
        * html/HTMLFontElement.cpp:
        (WebCore::HTMLFontElement::create):
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::create):
        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::create):
        * html/HTMLHRElement.cpp:
        (WebCore::HTMLHRElement::create):
        * html/HTMLHeadElement.cpp:
        (WebCore::HTMLHeadElement::create):
        * html/HTMLHeadingElement.cpp:
        (WebCore::HTMLHeadingElement::create):
        * html/HTMLHtmlElement.cpp:
        (WebCore::HTMLHtmlElement::create):
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::create):
        (WebCore::HTMLImageElement::createForJSConstructor):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::create):
        * html/HTMLIsIndexElement.cpp:
        (WebCore::HTMLIsIndexElement::create):
        * html/HTMLKeygenElement.cpp:
        (WebCore::HTMLKeygenElement::create):
        * html/HTMLLIElement.cpp:
        (WebCore::HTMLLIElement::create):
        * html/HTMLLabelElement.cpp:
        (WebCore::HTMLLabelElement::create):
        * html/HTMLLegendElement.cpp:
        (WebCore::HTMLLegendElement::create):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::create):
        * html/HTMLMapElement.cpp:
        (WebCore::HTMLMapElement::create):
        * html/HTMLMarqueeElement.cpp:
        (WebCore::HTMLMarqueeElement::create):
        * html/HTMLMenuElement.cpp:
        (WebCore::HTMLMenuElement::create):
        * html/HTMLMetaElement.cpp:
        (WebCore::HTMLMetaElement::create):
        * html/HTMLModElement.cpp:
        (WebCore::HTMLModElement::create):
        * html/HTMLNoScriptElement.cpp:
        (WebCore::HTMLNoScriptElement::create):
        * html/HTMLOListElement.cpp:
        (WebCore::HTMLOListElement::create):
        * html/HTMLOptGroupElement.cpp:
        (WebCore::HTMLOptGroupElement::create):
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::create):
        (WebCore::HTMLOptionElement::createForJSConstructor):
        * html/HTMLParagraphElement.cpp:
        (WebCore::HTMLParagraphElement::create):
        * html/HTMLParamElement.cpp:
        (WebCore::HTMLParamElement::create):
        * html/HTMLPreElement.cpp:
        (WebCore::HTMLPreElement::create):
        * html/HTMLQuoteElement.cpp:
        (WebCore::HTMLQuoteElement::create):
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::create):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::create):
        * html/HTMLSourceElement.cpp:
        (WebCore::HTMLSourceElement::create):
        * html/HTMLStyleElement.cpp:
        (WebCore::HTMLStyleElement::create):
        * html/HTMLTableCaptionElement.cpp:
        (WebCore::HTMLTableCaptionElement::create):
        * html/HTMLTableCellElement.cpp:
        (WebCore::HTMLTableCellElement::create):
        * html/HTMLTableColElement.cpp:
        (WebCore::HTMLTableColElement::create):
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::create):
        * html/HTMLTableRowElement.cpp:
        (WebCore::HTMLTableRowElement::create):
        * html/HTMLTableSectionElement.cpp:
        (WebCore::HTMLTableSectionElement::create):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::create):
        * html/HTMLTitleElement.cpp:
        (WebCore::HTMLTitleElement::create):
        * html/HTMLUListElement.cpp:
        (WebCore::HTMLUListElement::create):
        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::create):
        * loader/ImageDocument.cpp:
        (WebCore::ImageDocumentElement::create):
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlShadowRootElement::create):
        (WebCore::MediaControlElement::create):
        (WebCore::MediaControlTimelineContainerElement::create):
        (WebCore::MediaControlVolumeSliderContainerElement::create):
        (WebCore::MediaControlStatusDisplayElement::create):
        (WebCore::MediaControlMuteButtonElement::create):
        (WebCore::MediaControlPlayButtonElement::create):
        (WebCore::MediaControlSeekButtonElement::create):
        (WebCore::MediaControlRewindButtonElement::create):
        (WebCore::MediaControlReturnToRealtimeButtonElement::create):
        (WebCore::MediaControlToggleClosedCaptionsButtonElement::create):
        (WebCore::MediaControlTimelineElement::create):
        (WebCore::MediaControlVolumeSliderElement::create):
        (WebCore::MediaControlFullscreenButtonElement::create):
        (WebCore::MediaControlTimeDisplayElement::create):
        * rendering/RenderSlider.cpp:
        (WebCore::SliderThumbElement::create):
        * rendering/TextControlInnerElements.cpp:
        (WebCore::TextControlInnerElement::create):
        (WebCore::TextControlInnerTextElement::create):
        (WebCore::SearchFieldResultsButtonElement::create):
        (WebCore::SearchFieldCancelButtonElement::create):
        (WebCore::SpinButtonElement::create):
        Use adoptRef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 16 Jun 2010 23:04:39 +0000 (23:04 +0000)]
2010-06-16  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, expectations tweak.

        * platform/chromium/test_expectations.txt: Transferred a failure from downstream.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 16 Jun 2010 22:58:04 +0000 (22:58 +0000)]
2010-06-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] r60803 broke media/controls-drag-timebar.html
        https://bugs.webkit.org/show_bug.cgi?id=40269

        * platform/gtk/Skipped: Unskip test which is now passing.
2010-06-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] r60803 broke media/controls-drag-timebar.html
        https://bugs.webkit.org/show_bug.cgi?id=40269

        Only queue events while the mouse button is down, if drag mode is enabled. Some
        tests may disable drag mode, to prevent the queuing of events in this situation.

        * DumpRenderTree/gtk/EventSender.cpp:
        (sendOrQueueEvent): Only queue events here if dragMode is true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove some CVS directories that snuck into Subversion
aroben@apple.com [Wed, 16 Jun 2010 22:47:47 +0000 (22:47 +0000)]
Remove some CVS directories that snuck into Subversion

These were added back when the Mozilla tables tests were imported.

Rubber-stamped by Dan Berstein.

* tables/mozilla/images/CVS: Removed.
* tables/mozilla_expected_failures/images/CVS: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDelete tables/mozilla/images/adforce_imgis_com.html and its associated results
aroben@apple.com [Wed, 16 Jun 2010 22:38:23 +0000 (22:38 +0000)]
Delete tables/mozilla/images/adforce_imgis_com.html and its associated results

This file is a GIF that somehow obtained a .html extension. It isn't
referenced by any other test. (It was failing on Windows because the
HTML5 parser turns null bytes into U+FFFD, whose rendering is
font-dependent.)

Fixes <http://webkit.org/b/40741> REGRESSION (r61234):
tables/mozilla/images/adforce_imgis_com.html fails on Windows.

Reviewed by Dave Hyatt.

* platform/chromium-linux/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
* platform/chromium-linux/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
* platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
* platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
* platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.txt: Removed.
* platform/mac-leopard/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
* platform/mac-leopard/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
* platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
* platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
* platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.txt: Removed.
* platform/mac/tables/mozilla/images/adforce_imgis_com-expected.checksum: Removed.
* platform/mac/tables/mozilla/images/adforce_imgis_com-expected.png: Removed.
* platform/mac/tables/mozilla/images/adforce_imgis_com-expected.txt: Removed.
* platform/qt/tables/mozilla/images/adforce_imgis_com-expected.txt: Removed.
* tables/mozilla/images/adforce_imgis_com.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 16 Jun 2010 22:26:35 +0000 (22:26 +0000)]
2010-06-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
        https://bugs.webkit.org/show_bug.cgi?id=40600

        * platform/gtk/Skipped: This change exposed some failures which were previously not reported. Skip them.
2010-06-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
        https://bugs.webkit.org/show_bug.cgi?id=40600

        * WebCoreSupport/DragClientGtk.cpp:
        (WebKit::DragClient::startDrag): Reset the click count after a drag starts.
        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::postCommitFrameViewSetup): Reset the click count after a load is committed.
        * webkit/webkitprivate.h: Move static click counting variables to be per-view.
        * webkit/webkitwebview.cpp:
        (getEventTime): Added.
        (webkit_web_view_button_press_event): If the event time is zero, use the current time.
        (webkit_web_view_finalize): Clean up click counting member.
        (webkit_web_view_init): Initialize click counting member.
2010-06-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
        https://bugs.webkit.org/show_bug.cgi?id=40600

        * DumpRenderTree/gtk/EventSender.cpp:
        (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 22:13:12 +0000 (22:13 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        Add a hidden land-cowboy command to webkit-patch to help land quick
        build fixes.

        * Scripts/webkitpy/tool/commands/download.py:
        * Scripts/webkitpy/tool/steps/preparechangelog.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 21:57:34 +0000 (21:57 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTML5 parser crash when setTimeout document.write after slow script
        https://bugs.webkit.org/show_bug.cgi?id=40726

        According to the HTML5 spec, we're supposed to open() a new document if
        we receive a document.write() after we've received EOF for the network.
        The old parser just dumped those bytes onto the end of the network
        stream.  After this patch, our behavior matches Minefield.

        Test: http/tests/misc/write-while-waiting.html

        * WebCore.xcodeproj/project.pbxproj:
        * dom/Document.cpp:
        (WebCore::Document::write):
        * dom/DocumentParser.h:
        * dom/XMLDocumentParser.cpp:
        (WebCore::XMLDocumentParser::finishWasCalled):
        * dom/XMLDocumentParser.h:
        * html/HTML5DocumentParser.cpp:
        (WebCore::HTML5DocumentParser::finishWasCalled):
        * html/HTML5DocumentParser.h:
        (WebCore::HTML5DocumentParser::InputStream::isClosed):
        * html/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::finishWasCalled):
        * html/HTMLDocumentParser.h:
        * loader/ImageDocument.cpp:
        (WebCore::ImageTokenizer::finishWasCalled):
        * loader/MediaDocument.cpp:
        (WebCore::MediaDocumentParser::finishWasCalled):
        * loader/PluginDocument.cpp:
        (WebCore::PluginDocumentParser::finishWasCalled):
        * loader/SinkDocument.cpp:
        (WebCore::SinkDocumentParser::finishWasCalled):
        * loader/TextDocument.cpp:
        (WebCore::TextDocumentParser::finishWasCalled):
2010-06-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTML5 parser crash when setTimeout document.write after slow script
        https://bugs.webkit.org/show_bug.cgi?id=40726

        Adds a test for what happens when we receive a document.write() while
        we're waiting for an external script to load (and after receiving EOF
        from the network).

        * http/tests/misc/write-while-waiting-expected.txt: Added.
        * http/tests/misc/write-while-waiting.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 16 Jun 2010 21:56:28 +0000 (21:56 +0000)]
2010-06-16  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Enable HTML5 Parser in Safari on Mac
        https://bugs.webkit.org/show_bug.cgi?id=40739

        The HTML5 parser is probably off on all webkit ports.
        We should either flip the meaning of the default so that
        "false" means HTML5 on all ports, or we'll have to write
        more code like this for all the other ports.

        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, expectations update.
dglazkov@chromium.org [Wed, 16 Jun 2010 21:51:22 +0000 (21:51 +0000)]
Unreviewed, expectations update.

Updated platform/chromium-* expectations for the tests after HTML5 parser switch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, expectations update.
dglazkov@chromium.org [Wed, 16 Jun 2010 21:38:03 +0000 (21:38 +0000)]
Unreviewed, expectations update.

* platform/chromium/test_expectations.txt: Removed already passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoConvert fast/dom/stripNullFromTextNodes.html to dumpAsText
aroben@apple.com [Wed, 16 Jun 2010 21:22:08 +0000 (21:22 +0000)]
Convert fast/dom/stripNullFromTextNodes.html to dumpAsText

There's nothing in this test that requires a render tree dump. We have
other tests that test rendering of U+FFFD characters (which was what
was causing the test to fail, since Windows uses a different font for
that character than Mac does).

Fixes <http://webkit.org/b/40738> REGRESSION: (r61234):
fast/dom/stripNullFromTextNodes.html fails on Windows

Reviewed by Dan Bernstein.

* fast/dom/stripNullFromTextNodes-expected.txt: Added.

* fast/dom/stripNullFromTextNodes.html: Added a call to
layoutTestController.dumpAsText().

* platform/chromium-linux/fast/dom/stripNullFromTextNodes-expected.checksum: Removed.
* platform/chromium-linux/fast/dom/stripNullFromTextNodes-expected.png: Removed.
* platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.checksum: Removed.
* platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.png: Removed.
* platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.txt: Removed.
* platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.checksum: Removed.
* platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.png: Removed.
* platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.txt: Removed.
* platform/mac/fast/dom/stripNullFromTextNodes-expected.checksum: Removed.
* platform/mac/fast/dom/stripNullFromTextNodes-expected.png: Removed.
* platform/mac/fast/dom/stripNullFromTextNodes-expected.txt: Removed.
* platform/qt/fast/dom/stripNullFromTextNodes-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 16 Jun 2010 21:18:09 +0000 (21:18 +0000)]
2010-06-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] ClipboardGtk::setURL does not match the behavior of other platforms
        https://bugs.webkit.org/show_bug.cgi?id=40640

        Instead of writing URL labels to the text portion of the clipboard or
        drag-and-drop data, write the URL itself. Also escape the label text
        of URLs. Abstracts logic into DataObjectGtk, so ClipboardGtk and
        PasteboardGtk can share it.

        Tests for this issue will be activated when dropping support has been
        added to the GTK+ EventSender.

        * platform/gtk/ClipboardGtk.cpp:
        (WebCore::ClipboardGtk::writeURL): Use DataObjectGtk::setURL.
        * platform/gtk/DataObjectGtk.cpp:
        (WebCore::DataObjectGtk::setURL):
        Added. Write URL to the text portion and remember to escape the
        label when creating the markup portion.
        * platform/gtk/DataObjectGtk.h: Add declaration of new method.
        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::Pasteboard::writeURL): Use DataObjectGtk::setURL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 21:15:20 +0000 (21:15 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Hit assertion in WebCore::HTML5Token::appendToSystemIdentifier
        https://bugs.webkit.org/show_bug.cgi?id=40729

        This was a copy/paste error.  Yay for ASSERTs.

        * html/HTML5Lexer.cpp:
        (WebCore::HTML5Lexer::nextToken):
2010-06-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Hit assertion in WebCore::HTML5Token::appendToSystemIdentifier
        https://bugs.webkit.org/show_bug.cgi?id=40729

        Add more test coverage of DOCTYPE parsing states.  Turns out you use a
        different state if there's no whitespace between the public and system
        identifiers.

        * html5lib/resources/doctype01.dat:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoConvert console messages to UTF-8 before printing them
aroben@apple.com [Wed, 16 Jun 2010 20:54:19 +0000 (20:54 +0000)]
Convert console messages to UTF-8 before printing them

Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
http/tests/security/xssAuditor/embed-tag-null-char.html and
http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
Windows. (I can't test the fix because Apache is crashing on my
computer.)

Reviewed by Alexey Proskuryakov.

* DumpRenderTree/win/DumpRenderTree.cpp:
(toUTF8): Extracted the code into an overload that takes a wide string
and a length, then added an overload that takes a wstring.

* DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
overload.

* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
UTF-8 instead of letting printf convert to the current code page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Drew Wilson <atwilson@chromium.org>
eric@webkit.org [Wed, 16 Jun 2010 20:28:58 +0000 (20:28 +0000)]
2010-06-16  Drew Wilson  <atwilson@chromium.org>

        Reviewed by Kent Tamura.

        Added plumbing to Chromium WebKit API to allow setting/getting the name
        of top level frames.

        https://bugs.webkit.org/show_bug.cgi?id=40430
        * public/WebFrame.h:
        Added setName() API.
        * public/WebViewClient.h:
        (WebKit::WebViewClient::createView):
        Now takes a "name" parameter.
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::createWindow):
        Passes a name parameter.
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::setName):
        Allows setting the frame name by calling through to the WebCore API.
        * src/WebFrameImpl.h:
2010-06-16  Drew Wilson  <atwilson@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] Plumbing for top-level frame names
        https://bugs.webkit.org/show_bug.cgi?id=40430

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::createView):
        Migrate to new createView() API.
        * DumpRenderTree/chromium/WebViewHost.h:
        Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Stuart Morgan <stuartmorgan@chromium.org>
eric@webkit.org [Wed, 16 Jun 2010 20:08:10 +0000 (20:08 +0000)]
2010-06-16  Stuart Morgan  <stuartmorgan@chromium.org>

        Reviewed by Anders Carlsson.

        Bring npapi.h more in line with upstream npapi-headers version:
        - Remove obsolete XP_MAC sections.
        - Remove Metrowerks defines.
        - Add OS/2 defines.
        - Add Maemo defines.
        - Add new version of the custom Carbon event definitions.
        - Sync platform define style/details

        https://bugs.webkit.org/show_bug.cgi?id=38666

        * bridge/npapi.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Diego Gonzalez <diegohcg@webkit.org>
diegohcg@webkit.org [Wed, 16 Jun 2010 19:27:55 +0000 (19:27 +0000)]
2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>

    [Qt] Scroll wheel event support to graphics based DRT
    https://bugs.webkit.org/show_bug.cgi?id=40577

    Reviewed by Kenneth Rohde Christiansen.

    * DumpRenderTree/qt/EventSenderQt.cpp:
    (EventSender::continuousMouseScrollBy):
    (EventSender::createGraphicsSceneWheelEvent):
    * DumpRenderTree/qt/EventSenderQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 16 Jun 2010 19:16:17 +0000 (19:16 +0000)]
2010-06-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Fix clipping via CSS clip: with composited descendants
        https://bugs.webkit.org/show_bug.cgi?id=40579

        Consult the 'clip' style, as well as overflow, when creating clipping
        compositing layers.

        Tests: compositing/geometry/clip.html
               compositing/overflow/clip-descendents.html

        * rendering/RenderLayerBacking.cpp:
        (WebCore::clipBox): Utility function that returns the union of the clip and overflow
        boxes.
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Use clipBox() to
        get the correct clipping rectangle.
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::enclosingNonStackingClippingLayer): Look for
        clip as well as overflow.
        (WebCore::RenderLayerCompositor::clipsCompositingDescendants): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 16 Jun 2010 19:11:46 +0000 (19:11 +0000)]
2010-06-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        REGRESSION: Undocked inspector toolbar is white
        https://bugs.webkit.org/show_bug.cgi?id=40644

        Make the html element 100% height so that we don't erase the background to white, after r61215.

        * inspector/front-end/inspector.css:
        (html):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove a stray newline from the Windows version of TestNetscapePlugin
aroben@apple.com [Wed, 16 Jun 2010 19:10:18 +0000 (19:10 +0000)]
Remove a stray newline from the Windows version of TestNetscapePlugin

Reviewed by Alexey Proskuryakov.

Fixes <http://webkit.org/b/40728>
plugins/geturlnotify-during-document-teardown.html fails on Windows

* DumpRenderTree/win/TestNetscapePlugin/main.cpp:
(NPP_Destroy): Removed extra newline that the Mac version doesn't
have.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix build.
andersca@apple.com [Wed, 16 Jun 2010 19:02:17 +0000 (19:02 +0000)]
Fix build.

* NetscapeCoreAnimationMoviePlugin/main.m:
(NPP_New):
(NPP_WriteReady):
(NPP_Write):
(NPP_HandleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUser scripts injected on start are not run on image documents.
bweinstein@apple.com [Wed, 16 Jun 2010 19:00:49 +0000 (19:00 +0000)]
User scripts injected on start are not run on image documents.
https://bugs.webkit.org/show_bug.cgi?id=40722
<rdar://8087394>

Reviewed by Darin Adler.

User scripts that are injected on start are run from FrameLoader::dispatchDocumentElementAvailable,
but this is never called from ImageDocument, so call it when we create a document element for
our image document.

* loader/ImageDocument.cpp:
(WebCore::ImageDocument::createDocumentStructure): Call FrameLoader::dispatchDocumentElementAvailable
    after creating our document element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRespect LayoutTestController::isPrinting on Windows
aroben@apple.com [Wed, 16 Jun 2010 18:56:50 +0000 (18:56 +0000)]
Respect LayoutTestController::isPrinting on Windows

This gets some printing tests closer to passing (like
printing/page-rule-in-media-query.html).

Fixes <http://webkit.org/b/40727>.

Reviewed by Dan Bernstein.

WebKit/win:

Add a "forPrinting" boolean parameter to
IWebFramePrivate::renderTreeAsExternalRepresentation

* Interfaces/IWebFramePrivate.idl: Renamed the current
renderTreeAsExternalRepresentation to unused1, and added a new version
that takes a boolean "forPrinting" parameter.

* Interfaces/WebKit.idl: Touched to force a build.

* WebFrame.cpp:
(WebFrame::renderTreeAsExternalRepresentation): Added a boolean
"forPrinting" parameter, and used it to tell externalRepresentation
what kind of behavior to use.

* WebFrame.h: Renamed the old renderTreeAsExternalRepresentation and
added the new one.

WebKitTools:

* DumpRenderTree/win/DumpRenderTree.cpp:
(dump): Pass LayoutTestController::isPrinting to
IWebFramePrivate::renderTreeAsExternalRepresentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNow fixing the path to WebGLLayer.*
cmarrin@apple.com [Wed, 16 Jun 2010 18:51:13 +0000 (18:51 +0000)]
Now fixing the path to WebGLLayer.*

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdditional minor fix to path of GraphicsContext3D.mac
cmarrin@apple.com [Wed, 16 Jun 2010 18:47:30 +0000 (18:47 +0000)]
Additional minor fix to path of GraphicsContext3D.mac

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFixing path to GraphicsContext3D.mac (hopefully)
cmarrin@apple.com [Wed, 16 Jun 2010 18:46:09 +0000 (18:46 +0000)]
Fixing path to GraphicsContext3D.mac (hopefully)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 16 Jun 2010 18:32:54 +0000 (18:32 +0000)]
2010-06-16  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Disabling a test which fails on Tiger for platform-specific decoding reasons.

        fast/encoding/japanese-encoding-mix.html fails on Tiger after enabling HTML5 Lexer
        https://bugs.webkit.org/show_bug.cgi?id=40725

        * platform/mac-tiger/Skipped:
         - Skipping the test until someone with Tiger access can look.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* WebCore.xcodeproj/project.pbxproj: Make paths relative to the project root.
beidson@apple.com [Wed, 16 Jun 2010 18:17:44 +0000 (18:17 +0000)]
* WebCore.xcodeproj/project.pbxproj: Make paths relative to the project root.

Reviewed by NOBODY (Build fix for Mac)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 18:05:18 +0000 (18:05 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Enable HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=40650

        Add Tiger-specific expectations because U+FFFD is a different length on
        Tiger.  :(

        * platform/mac-tiger/fast/dom: Added.
        * platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.checksum: Added.
        * platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.png: Added.
        * platform/mac-tiger/fast/dom/stripNullFromTextNodes-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 16 Jun 2010 17:33:15 +0000 (17:33 +0000)]
2010-06-16  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Eric Carlson.

        https://bugs.webkit.org/show_bug.cgi?id=40643

        Second of three steps - rename Canvas3DLayer to WebGLLayer

        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/mac/Canvas3DLayer.h: Removed.
        * platform/graphics/mac/Canvas3DLayer.mm: Removed.
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::setContentsToGraphicsContext3D):
        * platform/graphics/mac/WebGLLayer.h: Copied from WebCore/platform/graphics/mac/Canvas3DLayer.h.
        * platform/graphics/mac/WebGLLayer.mm: Copied from WebCore/platform/graphics/mac/Canvas3DLayer.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 16 Jun 2010 17:05:17 +0000 (17:05 +0000)]
2010-06-16  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=40643

        Rename GraphicsContext3DMac.cpp so it can interact with CALayer

        * platform/graphics/mac/GraphicsContext3DMac.cpp: Removed.
        * platform/graphics/mac/GraphicsContext3DMac.mm: Copied from WebCore/platform/graphics/mac/GraphicsContext3DMac.cpp.
        * WebCore.xcodeproj/project.pbxproj

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLand new expected Windows results for two failing tests
aroben@apple.com [Wed, 16 Jun 2010 16:12:16 +0000 (16:12 +0000)]
Land new expected Windows results for two failing tests

These test results should have been updated in r61136, but weren't.

Reviewed by Anders Carlsson.

Fixes <http://webkit.org/b/40713> REGRESSION (r61136):
fast/dom/prototype-inheritance-2.html and
fast/js/global-constructors.html are failing on Windows.

* platform/win/fast/dom/prototype-inheritance-2-expected.txt:
* platform/win/fast/js/global-constructors-expected.txt:
Updated with the actual results from the bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 16 Jun 2010 16:04:39 +0000 (16:04 +0000)]
2010-06-16  Martin Robinson  <mrobinson@igalia.com>

        Not reviewed.

        Add baselines for tests that should be passing consistently now.

        * platform/gtk/Skipped: Unskip tests. They should pass consistently.
        * platform/gtk/editing/spelling/spellcheck-attribute-expected.txt: Added.
        * platform/gtk/svg/text/foreignObject-repaint-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Wed, 16 Jun 2010 15:53:18 +0000 (15:53 +0000)]
2010-06-16  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] Rebaseline tests following r61240
        https://bugs.webkit.org/show_bug.cgi?id=40711

        Following r61240 (new HTML5 lexer), we need to rebaseline a few tests.

        * platform/chromium-linux/fast/text/international/hindi-whitespace-expected.checksum:
        * platform/chromium-linux/fast/text/international/hindi-whitespace-expected.png:
        * platform/chromium-linux/fast/text/international/hindi-whitespace-expected.txt:
        * platform/chromium-mac/fast/parser/script-tag-with-trailing-slash-expected.txt: Removed.
        * platform/chromium-mac/fast/tokenizer/script_extra_close-expected.txt:
        * platform/chromium-win/css1/box_properties/float_elements_in_series-expected.checksum:
        * platform/chromium-win/css1/box_properties/float_elements_in_series-expected.png:
        * platform/chromium-win/fast/doctypes/003-expected.checksum:
        * platform/chromium-win/fast/doctypes/003-expected.png:
        * platform/chromium-win/fast/doctypes/003-expected.txt:
        * platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.checksum:
        * platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.png:
        * platform/chromium-win/fast/dom/stripNullFromTextNodes-expected.txt:
        * platform/chromium-win/fast/invalid/016-expected.checksum:
        * platform/chromium-win/fast/invalid/016-expected.png:
        * platform/chromium-win/fast/invalid/016-expected.txt:
        * platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.checksum:
        * platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.png:
        * platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.txt: Removed.
        * platform/chromium-win/fast/parser/comment-in-style-expected.checksum:
        * platform/chromium-win/fast/parser/comment-in-style-expected.png:
        * platform/chromium-win/fast/parser/comment-in-style-expected.txt:
        * platform/chromium-win/fast/parser/parseCommentsInTitles-expected.checksum:
        * platform/chromium-win/fast/parser/parseCommentsInTitles-expected.png:
        * platform/chromium-win/fast/parser/parseCommentsInTitles-expected.txt:
        * platform/chromium-win/fast/parser/script-tag-with-trailing-slash-expected.txt: Removed.
        * platform/chromium-win/fast/text/international/bidi-linebreak-001-expected.checksum:
        * platform/chromium-win/fast/text/international/bidi-linebreak-001-expected.png:
        * platform/chromium-win/fast/text/international/bidi-linebreak-001-expected.txt:
        * platform/chromium-win/fast/text/international/bidi-linebreak-002-expected.checksum:
        * platform/chromium-win/fast/text/international/bidi-linebreak-002-expected.png:
        * platform/chromium-win/fast/text/international/bidi-linebreak-002-expected.txt:
        * platform/chromium-win/fast/text/international/bidi-linebreak-003-expected.checksum:
        * platform/chromium-win/fast/text/international/bidi-linebreak-003-expected.png:
        * platform/chromium-win/fast/text/international/bidi-linebreak-003-expected.txt:
        * platform/chromium-win/fast/text/international/hindi-whitespace-expected.checksum:
        * platform/chromium-win/fast/text/international/hindi-whitespace-expected.png:
        * platform/chromium-win/fast/text/international/hindi-whitespace-expected.txt:
        * platform/chromium-win/fast/tokenizer/missing-title-end-tag-1-expected.checksum:
        * platform/chromium-win/fast/tokenizer/missing-title-end-tag-1-expected.png:
        * platform/chromium-win/fast/tokenizer/missing-title-end-tag-1-expected.txt: Removed.
        * platform/chromium-win/fast/tokenizer/missing-title-end-tag-2-expected.checksum:
        * platform/chromium-win/fast/tokenizer/missing-title-end-tag-2-expected.png:
        * platform/chromium-win/fast/tokenizer/missing-title-end-tag-2-expected.txt: Removed.
        * platform/chromium-win/fast/tokenizer/script_extra_close-expected.txt:
        * platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.checksum:
        * platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.png:
        * platform/chromium-win/tables/mozilla/images/adforce_imgis_com-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 16 Jun 2010 15:45:20 +0000 (15:45 +0000)]
2010-06-16  Martin Robinson  <mrobinson@igalia.com>

        Not reviewed.

        Unskip passing test.

        * platform/gtk/Skipped: Unskip this test which appears to be passing now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 15:32:41 +0000 (15:32 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Enable HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=40650

        Skip this test because I keep screwing up the expectations for this
        test.  I'll get it cleared up by the end of the day.

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLand new expected Windows results for tests that use <video controls>
aroben@apple.com [Wed, 16 Jun 2010 15:15:00 +0000 (15:15 +0000)]
Land new expected Windows results for tests that use <video controls>

The current expected results expect a fullscreen button to be included
in the controls. But the fullscreen button is only included when
accelerated compositing is enabled, and the bots build without
accelerated compositing enabled.

Rubber-stamped by Dan Bernstein.

Fixes <http://webkit.org/b/40710> Tests that use <video controls> are
failing on Windows.

* platform/win/media/controls-after-reload-expected.txt:
* platform/win/media/controls-drag-timebar-expected.txt:
* platform/win/media/controls-strict-expected.txt:
* platform/win/media/controls-styling-expected.txt:
* platform/win/media/video-controls-rendering-expected.txt:
* platform/win/media/video-display-toggle-expected.txt:
* platform/win/media/video-no-audio-expected.txt:
Updated with the actual results from the bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 16 Jun 2010 15:10:16 +0000 (15:10 +0000)]
2010-06-16  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Add new files, needed in SVG Text rewrite
        https://bugs.webkit.org/show_bug.cgi?id=40676

        Land SVGTextChunkLayoutInfo.cpp and SVGTextQuery.(cpp|h), both with an "#if 0" on top, as they will be needed
        in a later patch, completing the SVG Text rewrite, that will enable them.

        Doesn't affect any code for now, it should just reduce the review amount.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/SVGTextChunkLayoutInfo.cpp: Added.
        (WebCore::cummulatedWidthOrHeightOfTextChunk):
        (WebCore::cummulatedWidthOfTextChunk):
        (WebCore::cummulatedHeightOfTextChunk):
        (WebCore::calculateTextAnchorShiftForTextChunk):
        (WebCore::applyTextAnchorToTextChunk):
        (WebCore::calculateTextLengthCorrectionForTextChunk):
        (WebCore::applyTextLengthCorrectionToTextChunk):
        (WebCore::SVGTextChunkLayoutInfo::startTextChunk):
        (WebCore::SVGTextChunkLayoutInfo::closeTextChunk):
        (WebCore::SVGTextChunkLayoutInfo::buildTextChunks):
        (WebCore::SVGTextChunkLayoutInfo::recursiveBuildTextChunks):
        (WebCore::SVGTextChunkLayoutInfo::layoutTextChunks):
        * rendering/SVGTextChunkLayoutInfo.h: Add missing include, otherwhise compiling SVGTextChunkLayoutInfo.cpp will fail.
        * rendering/SVGTextQuery.cpp: Added.
        (WebCore::SVGTextQuery::Data::Data):
        (WebCore::flowBoxForRenderer):
        (WebCore::mapLengthThroughChunkTransformation):
        (WebCore::SVGTextQuery::SVGTextQuery):
        (WebCore::SVGTextQuery::collectTextBoxesInFlowBox):
        (WebCore::SVGTextQuery::executeQuery):
        (WebCore::SVGTextQuery::mapStartAndLengthIntoChunkPartCoordinates):
        (WebCore::SVGTextQuery::measureCharacterRange):
        (WebCore::NumberOfCharactersData::NumberOfCharactersData):
        (WebCore::SVGTextQuery::numberOfCharactersCallback):
        (WebCore::SVGTextQuery::numberOfCharacters):
        (WebCore::TextLengthData::TextLengthData):
        (WebCore::SVGTextQuery::textLengthCallback):
        (WebCore::SVGTextQuery::textLength):
        (WebCore::SubStringLengthData::SubStringLengthData):
        (WebCore::SVGTextQuery::subStringLengthCallback):
        (WebCore::SVGTextQuery::subStringLength):
        (WebCore::StartPositionOfCharacterData::StartPositionOfCharacterData):
        (WebCore::SVGTextQuery::startPositionOfCharacterCallback):
        (WebCore::SVGTextQuery::startPositionOfCharacter):
        (WebCore::EndPositionOfCharacterData::EndPositionOfCharacterData):
        (WebCore::SVGTextQuery::endPositionOfCharacterCallback):
        (WebCore::SVGTextQuery::endPositionOfCharacter):
        (WebCore::RotationOfCharacterData::RotationOfCharacterData):
        (WebCore::SVGTextQuery::rotationOfCharacterCallback):
        (WebCore::SVGTextQuery::rotationOfCharacter):
        (WebCore::ExtentOfCharacterData::ExtentOfCharacterData):
        (WebCore::SVGTextQuery::extentOfCharacterCallback):
        (WebCore::SVGTextQuery::extentOfCharacter):
        (WebCore::CharacterNumberAtPositionData::CharacterNumberAtPositionData):
        (WebCore::SVGTextQuery::characterNumberAtPositionCallback):
        (WebCore::SVGTextQuery::characterNumberAtPosition):
        * rendering/SVGTextQuery.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Fix tiled backing store painting when calling QGraphicsWebView::setPage() after...
hausmann@webkit.org [Wed, 16 Jun 2010 15:09:22 +0000 (15:09 +0000)]
[Qt] Fix tiled backing store painting when calling QGraphicsWebView::setPage() after setResizesToContents(true)

Patch by Alexis Menard <alexis.menard@nokia.com> on 2010-06-16
Reviewed by Simon Hausmann.

When calling setPage() after setResizesToContents, the value of the property wasn't propagated
to the page client. Therefore the visible rect for the tiled backing store was incorrect.

Simply move the variable assignment into updateResizesToContentsForPage(), which is always called.

* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::updateResizesToContentsForPage):
(QGraphicsWebView::setResizesToContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 16 Jun 2010 13:51:21 +0000 (13:51 +0000)]
2010-06-16  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Provide floating-point support for text selection framework
        https://bugs.webkit.org/show_bug.cgi?id=40665

        This is the first chunk of the SVG Text rewrite patches.
        offsetForPosition() / selectionRectForText() should accept float/FloatPoint arguments instead
        of int/IntPoint. offsetForPosition() already worked with floats internally in Qt and Mac.
        selectionRectForText() was already returning a FloatRect, but the passed in origin was an integer.
        Fixing these problems in order to support sub-pixel positioning in the upcoming SVG Text rewrite patch.

        Add a glyphScale parameter to TextRun, that will be used to support text selection
        in lengthAdjust/textLength scenarios in SVG text, soon.

        Doesn't affect any testcases so far. HTML is not affected in any way,
        as it only ever passes integers to these functions.

        * platform/graphics/Font.cpp:
        (WebCore::Font::selectionRectForText):
        (WebCore::Font::offsetForPosition):
        * platform/graphics/Font.h:
        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::selectionRectForSimpleText):
        (WebCore::Font::offsetForPositionForSimpleText):
        * platform/graphics/TextRun.h:
        (WebCore::TextRun::TextRun):
        (WebCore::TextRun::glyphScale):
        (WebCore::TextRun::setGlyphScale):
        (WebCore::TextRun::applyGlyphScaling):
        * platform/graphics/WidthIterator.cpp:
        (WebCore::WidthIterator::advance):
        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::Font::selectionRectForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):
        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):
        * platform/graphics/efl/FontEfl.cpp:
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):
        * platform/graphics/gtk/FontGtk.cpp:
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):
        * platform/graphics/haiku/FontHaiku.cpp:
        (WebCore::Font::selectionRectForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):
        * platform/graphics/mac/ComplexTextController.cpp:
        (WebCore::ComplexTextController::offsetForPosition):
        * platform/graphics/mac/ComplexTextController.h:
        * platform/graphics/mac/FontComplexTextMac.cpp:
        (WebCore::Font::selectionRectForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):
        * platform/graphics/qt/FontQt.cpp:
        (WebCore::Font::offsetForPositionForSimpleText):
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForSimpleText):
        (WebCore::Font::selectionRectForComplexText):
        * platform/graphics/win/FontWin.cpp:
        (WebCore::Font::selectionRectForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):
        * platform/graphics/wince/FontWince.cpp:
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):
        * platform/graphics/wx/FontWx.cpp:
        (WebCore::Font::selectionRectForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):
        * svg/SVGFont.cpp:
        (WebCore::Font::selectionRectForTextUsingSVGFont):
        (WebCore::Font::offsetForPositionForTextUsingSVGFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Wed, 16 Jun 2010 12:42:29 +0000 (12:42 +0000)]
2010-06-16  Anton Muhin  <antonm@chromium.org>

        Reviewed by Nate Chapin.

        [v8] Introduce single element caches for WebCore::String to v8::String conversions
        https://bugs.webkit.org/show_bug.cgi?id=40435
        Measurements show that for some web apps (GMail, Wave) and some scenarios
        (intensive reading and/or keeping a tab open for a long time),
        hit rate lies in 30--50% interval.
        Inlining fast case gives another minor performance win.

        * bindings/v8/V8Binding.cpp:
        (WebCore::getStringCache):
        (WebCore::v8ExternalStringSlow):
        * bindings/v8/V8Binding.h:
        (WebCore::v8ExternalString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSwap WebGL and SiteSpecificQuirks attributes in the QWebSettings
hausmann@webkit.org [Wed, 16 Jun 2010 11:47:01 +0000 (11:47 +0000)]
Swap WebGL and SiteSpecificQuirks attributes in the QWebSettings
enum, to allow for binary compatibility with qtwebkit-2.0, where
WebGL is not in the settings but SiteSpecificQuirks will be.

Rubber-stamped by Tor Arne Vestbø.

* Api/qwebsettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-05-20 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Wed, 16 Jun 2010 11:46:51 +0000 (11:46 +0000)]
2010-05-20  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Kenneth Christiansen.

        Spatial Navigation: using offset{Left,Top} is not enough to get the proper inner frames position
        https://bugs.webkit.org/show_bug.cgi?id=39439

        As pointed out by Darin Adler in https://bugs.webkit.org/show_bug.cgi?id=18662#c20,
        "It's not correct to use the offsetLeft and offsetTop of the frame owner element's renderer because
        that's just the distance from the offsetParent, not the absolute position".

        Patch fixes that behavior by now considering the offsetTop and offsetLeft the offsetParent recursively,
        starting from the HtmlFrameOwnerElement. Previously, only calling offsetTop and offsetLeft works
        because all tests were done in html samples where the {i}frame element was a directly a child of the body,
        e.g. <html>...<body><iframe src=xxx>....<body></html>.

        WebCore:
        Test: fast/events/spatial-navigation/snav-iframe-recursive-offset-parent.html

        * page/SpatialNavigation.cpp:
        (WebCore::renderRectRelativeToRootDocument):

        LayoutTests:
        * fast/events/spatial-navigation/snav-iframe-recursive-offset-parent-expected.txt: Added.
        * fast/events/spatial-navigation/snav-iframe-recursive-offset-parent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTry to fix the Tiger build
mitz@apple.com [Wed, 16 Jun 2010 09:26:13 +0000 (09:26 +0000)]
Try to fix the Tiger build

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformBoundsForGlyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 16 Jun 2010 09:23:38 +0000 (09:23 +0000)]
2010-06-16  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Disabling a test which fails on Gtk for unexplained
        reasons which are specific to the Gtk port.

        Gtk pumps the HTML5Lexer an extra time, causing inspector/timeline-script-tag-1.html to fail
        https://bugs.webkit.org/show_bug.cgi?id=40664

        * platform/qt/Skipped:
         - Skip the test until a Gtk person can take a look.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTry to fix the Tiger build
mitz@apple.com [Wed, 16 Jun 2010 09:15:27 +0000 (09:15 +0000)]
Try to fix the Tiger build

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformBoundsForGlyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 16 Jun 2010 09:12:04 +0000 (09:12 +0000)]
2010-06-16  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Disabling a test which due to a Qt decoding bug
        is now failing with the HTML5 lexer.

        fast/encoding/japanese-encoding-mix.html fails on Qt after enabling HTML5 Lexer
        https://bugs.webkit.org/show_bug.cgi?id=40661

        Qt's decoders don't seem to be passing the "--" of the "-->" to the
        HTML5DocumentParser correctly, thus the comment is never closed
        and the rest of the document gets eaten.

        * platform/qt/Skipped:
         - Skip the test until a Qt person can take a look.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 08:59:21 +0000 (08:59 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Enable HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=40650

        Add two XSS Auditor tests to the Skipped list.  These tests actually
        pass in the sense that the attack is blocked.  However, the U+FFFD in
        the console output is getting mangled.  We could check in Qt-specific
        expected results, but that doesn't quite seem right.  There's something
        wrong with the Qt UT8 decoder, which I suspect is related to (or the
        same as) https://bugs.webkit.org/show_bug.cgi?id=35263

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Store matchBegin directly in the array of output instead of the stack.
abecsi@webkit.org [Wed, 16 Jun 2010 08:50:38 +0000 (08:50 +0000)]
Store matchBegin directly in the array of output instead of the stack.
    https://bugs.webkit.org/show_bug.cgi?id=38988

    Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-06-16
    Reviewed by Geoffrey Garen.

    * yarr/RegexJIT.cpp:
    (JSC::Yarr::RegexGenerator::generateDisjunction):
    (JSC::Yarr::RegexGenerator::generate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 08:48:15 +0000 (08:48 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Enable HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=40650

        Add platform-specific results for Snow Leopard.  Maciej thinks there is
        something going on here related to BIDI and additional FFFD
        replacements.  This test is already on our list of things to
        investigate more closely.

        * platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.checksum: Added.
        * platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.png: Added.
        * platform/mac-snowleopard/tables/mozilla/images/adforce_imgis_com-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 16 Jun 2010 08:25:11 +0000 (08:25 +0000)]
2010-06-16  Eric Seidel  <eric@webkit.org>

        Unreviewed, just updating qt platform result to match new expectations.

        Enable HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=40650

        Windows and Chromium will still need updates, but I don't have easy
        access to those results.

        * platform/qt/fast/text/stripNullFromText-expected.txt:
         - \0 now gets converted to 0xfffd per HTML5.
        * platform/qt/fast/text/international/hindi-whitespace-expected.txt:
          - Expected CR handling change after http://trac.webkit.org/changeset/61234.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: <rdar://problem/8077119> REGRESSION (r60247): Google Reader contains the...
mitz@apple.com [Wed, 16 Jun 2010 08:20:18 +0000 (08:20 +0000)]
WebCore: <rdar://problem/8077119> REGRESSION (r60247): Google Reader contains the tops of pieces of unidentifiable text under feed headlines.
https://bugs.webkit.org/show_bug.cgi?id=40386

Reviewed by Alexey Proskuryakov.

Test: platform/mac/fast/text/x-height.html

The result of platformBoundsForGlyph() is in flipped coordinates, whereas the result of
-[NSFont boundingRectForGlyph:] was not. r60247 failed to account for this.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit): Measure the height of the x glyph above the baseline
correctly.
(WebCore::SimpleFontData::platformBoundsForGlyph): Return a rect in flipped coordinates on Tiger
as well.

LayoutTests: <rdar://problem/8077119> REGRESSION: Google Reader contains the tops of pieces of unidentifiable text under feed headlines.
https://bugs.webkit.org/show_bug.cgi?id=40386

Reviewed by Alexey Proskuryakov.

* platform/mac/fast/text/x-height-expected.checksum: Added.
* platform/mac/fast/text/x-height-expected.png: Added.
* platform/mac/fast/text/x-height-expected.txt: Added.
* platform/mac/fast/text/x-height.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 08:06:14 +0000 (08:06 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Enable HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=40650

        Update platform-specific expected results for Qt.

        * platform/qt/fast/text/international/hindi-whitespace-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-06-16 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 16 Jun 2010 07:59:23 +0000 (07:59 +0000)]
2010-06-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Don't crash when a document ends with an entity
        https://bugs.webkit.org/show_bug.cgi?id=40658

        When we SWITCH_TO a state, we're expecting our caller to have advanced
        the source.  Rather than have all the callers check for empty, we do
        that ourselves.

        * html/HTML5Lexer.cpp:
2010-06-16  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Don't crash when a document ends with an entity
        https://bugs.webkit.org/show_bug.cgi?id=40658

        Add a test for an entity being the only contents of a file.

        * html5lib/resources/webkit01.dat:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61239 268f45cc-cd09-0410-ab3c-d52691b4dbfc