WebKit-https.git
15 years agoPath implementing more Cliboard from Marius Bugge Monsen.
zack [Tue, 22 May 2007 08:53:55 +0000 (08:53 +0000)]
Path implementing more Cliboard from Marius Bugge Monsen.

Adding implementations of some of the missing methods.
r=me

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix http headers for POST.
hausmann [Tue, 22 May 2007 07:31:11 +0000 (07:31 +0000)]
Fix http headers for POST.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoUpdating expected results for r21074.
justing [Tue, 22 May 2007 06:53:49 +0000 (06:53 +0000)]
Updating expected results for r21074.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-21 Oliver Hunt <oliver@apple.com>
oliver [Tue, 22 May 2007 03:10:06 +0000 (03:10 +0000)]
2007-05-21  Oliver Hunt  <oliver@apple.com>

LayoutTests:

        Reviewed by Sam.

        Layout test for http://bugs.webkit.org/show_bug.cgi?id=13789

        * svg/custom/getscreenctm-in-mixed-content-expected.checksum: Added.
        * svg/custom/getscreenctm-in-mixed-content-expected.png: Added.
        * svg/custom/getscreenctm-in-mixed-content-expected.txt: Added.
        * svg/custom/getscreenctm-in-mixed-content.xhtml: Added.

WebCore:

        Reviewed by Sam.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=13789
        -- SVGLocatable::getScreenCTM() faulty

        Needed to update SVGLength to handle the case where the SVGElement is
        not the root document element -- we do this by falling back on the
        renderer for the context.

        For <svg> elements embedded as mixed content in xhtml we consider the
        absolutePosition of the parent to be the origin for the <svg> element.

        * ksvg2/svg/SVGLength.cpp:
        (WebCore::SVGLength::PercentageOfViewport):
        * ksvg2/svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::getScreenCTM):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
thatcher [Tue, 22 May 2007 02:14:03 +0000 (02:14 +0000)]
    Reviewed by Adam.

        <rdar://problem/5084400> -[DOMRange lineBoxRects] returns an empty array when the DOM nodes have just been created

        Do a updateLayoutIgnorePendingStylesheets before asking the Node or Range for it's box rects.

        * bindings/objc/DOM.mm:
        (-[DOMNode boundingBox]):
        (-[DOMNode lineBoxRects]):
        (-[DOMRange boundingBox]):
        (-[DOMRange lineBoxRects]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by George Staikos.
weinig [Tue, 22 May 2007 01:42:21 +0000 (01:42 +0000)]
    Reviewed by George Staikos.

        Fix Qt build.

        * WebCore.pro: add missing IDL files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Tue, 22 May 2007 01:29:17 +0000 (01:29 +0000)]
LayoutTests:

        Reviewed by Darin.

        - update tests and results for http://bugs.webkit.org/show_bug.cgi?id=13803
          to account for the new JSHTMLMarquee that is being autogenerated and
          can now produce a constructor.

        * fast/dom/Window/element-constructors-on-window-expected.txt:
        * fast/dom/Window/element-constructors-on-window.html:
        * fast/dom/Window/window-properties-expected.txt:

WebCore:

        Reviewed by Darin.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13803
        Autogenerate the JS bindings for the HTMLMarqueeElement.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSHTMLElementWrapperFactory.cpp:
        * bindings/js/kjs_css.cpp:
        (KJS::DOMCSSRule::getOwnPropertySlot): Fix possible null pointer issue.
        (KJS::DOMCSSRule::put): Fix possible null pointer issue.
        * bindings/js/kjs_html.cpp:
        (KJS::):
        (KJS::JSHTMLElement::classInfo):
        (KJS::JSHTMLElement::accessors):
        (KJS::JSHTMLElement::getOwnPropertySlot): Fix null pointer issue.
        (KJS::HTMLElementFunction::callAsFunction):
        (KJS::JSHTMLElement::put):
        * bindings/js/kjs_html.h:
        (KJS::JSHTMLElement::):
        * html/HTMLMarqueeElement.cpp:
        (WebCore::HTMLMarqueeElement::start):
        (WebCore::HTMLMarqueeElement::stop):
        * html/HTMLMarqueeElement.h: Add start() and stop() functions.
        * html/HTMLMarqueeElement.idl: Added.
        * page/DOMWindow.idl: Add marquee constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
adele [Tue, 22 May 2007 00:08:08 +0000 (00:08 +0000)]
WebCore:

        Fix by Darin, reviewed by me.

        Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts

        * platform/mac/WidgetMac.mm:
        (WebCore::safeRemoveFromSuperview): Added. If the view is the window's first responder, then
         set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it.
        (WebCore::Widget::setFocus): Don't attempt to focus the view if it has no window.
        (WebCore::Widget::removeFromSuperview): Call safeRemoveFromSuperview.
        (WebCore::Widget::afterMouseDown): ditto.

WebKit:

        Fix by Darin, reviewed by me.

        Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts

        * WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]): If the old view is the first responder,
        then set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@21631 268f45cc-cd09-0410...
weinig [Mon, 21 May 2007 23:13:56 +0000 (23:13 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Make a line gutter backdrop so that tiny view source docs don't look
hyatt [Mon, 21 May 2007 22:03:29 +0000 (22:03 +0000)]
    Make a line gutter backdrop so that tiny view source docs don't look
        bad.

        Reviewed by aroben

        * css/view-source.css:
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::createContainingTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Make sure to distinguish between links to internal resources and
hyatt [Mon, 21 May 2007 21:32:00 +0000 (21:32 +0000)]
    Make sure to distinguish between links to internal resources and
        real links (anchors) in view source mode.

        Reviewed by aroben

        * css/view-source.css:
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):
        (WebCore::HTMLViewSourceDocument::addLink):
        * html/HTMLViewSourceDocument.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Making the importance of my last change more clear
beidson [Mon, 21 May 2007 19:07:19 +0000 (19:07 +0000)]
    Making the importance of my last change more clear

        * WebView/WebViewPrivate.h: "Leave for Dashboard, people!"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin (Sarge)
beidson [Mon, 21 May 2007 18:45:01 +0000 (18:45 +0000)]
    Reviewed by Kevin (Sarge)

        <rdar://problem/5217124> - Re-add mistakenly removed SPI

        * WebView/WebView.mm:
        (-[WebView handleAuthenticationForResource:challenge:fromDataSource:]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Mon, 21 May 2007 18:19:41 +0000 (18:19 +0000)]
LayoutTests:

        Reviewed by Adam and Darin.

        - update results for http://bugs.webkit.org/show_bug.cgi?id=13791
          to account for new JSHTMLElements that are being autogenerated and
          can now produce constructors.

        * fast/dom/Window/element-constructors-on-window-expected.txt:
        * fast/dom/Window/window-properties-expected.txt:

WebCore:

        Reviewed by Adam and Darin.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13791
        Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSHTMLAnchorElementCustom.cpp:
        * bindings/js/JSHTMLElementWrapperFactory.cpp:
        * bindings/js/kjs_html.cpp:
        (KJS::):
        (KJS::JSHTMLElement::classInfo):
        (KJS::JSHTMLElement::accessors):
        (KJS::HTMLElementFunction::callAsFunction):
        * bindings/js/kjs_html.h:
        (KJS::JSHTMLElement::):
        * bindings/scripts/CodeGeneratorJS.pm:
        * html/HTMLFrameElement.idl:
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::location):
        * html/HTMLFrameElementBase.h:
        * html/HTMLFrameOwnerElement.h:
        (WebCore::HTMLFrameOwnerElement::contentWindow):
        * html/HTMLIFrameElement.idl:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Ada.
andersca [Mon, 21 May 2007 17:57:33 +0000 (17:57 +0000)]
    Reviewed by Ada.

        <rdar://problem/5200816> REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )

        Null check the request.

        * WebView/WebView.mm:
        (+[WebView _canHandleRequest:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoUpdating and adding test cases.
lars [Mon, 21 May 2007 13:57:35 +0000 (13:57 +0000)]
Updating and adding test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Simon
lars [Mon, 21 May 2007 13:36:01 +0000 (13:36 +0000)]
    Reviewed by Simon

        Remove the userHandle methods from QWebnetworkJob again.
        They don't really give us anything and just clutter the API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoExport the new qt network API.
hausmann [Mon, 21 May 2007 13:09:59 +0000 (13:09 +0000)]
Export the new qt network API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Zack.
lars [Mon, 21 May 2007 12:33:59 +0000 (12:33 +0000)]
    Reviewed by Zack.

        Add an API layer for network downloads. Basically QWebnetworkInterface
        is an interface class for downloading resources. QWebnetworkJob describes
        the actual object to download.

        QWebNetworkInterface has a default implementation that replaces the
        old ResourceHandleManager class in the Qt port.

        Remove the ResourceHandleManager class, it is now part of
        QWebNetworkInterface. Adapt ResourceHandle to the new way
        of things.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
mjs [Mon, 21 May 2007 11:04:51 +0000 (11:04 +0000)]
    Reviewed by Geoff.

        <rdar://problem/5205358> REGRESSION (r21367): All messages appear entirely blank when running Mail off of tip of tree WebKit

        The fix is to return nil from [WebFrame dataSource] when it has not loaded anything but the fake
        empty initial document. However, WebKit still needs the real data source internally, so I also
        added a [WebFrame _dataSource] method that skips this check, and made WebKit use it throughout.

        * Misc/WebNSAttributedStringExtras.mm:
        (fileWrapperForElement):
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView dataSource]):
        * Plugins/WebNullPluginView.mm:
        (-[WebNullPluginView viewDidMoveToWindow]):
        * Plugins/WebPluginController.mm:
        (-[WebPluginController URLPolicyCheckReferrer]):
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge dataSource]):
        (-[WebFrameBridge redirectDataToPlugin:]):
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::makeDocumentView):
        (WebFrameLoaderClient::forceLayoutForNonHTML):
        (WebFrameLoaderClient::prepareForDataSourceReplacement):
        (WebFrameLoaderClient::canCachePage):
        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory bridgeForView:]):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebArchiver.mm:
        (+[WebArchiver archiveFrame:]):
        (+[WebArchiver archiveMainResourceForFrame:]):
        (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
        (+[WebArchiver archiveSelectionInFrame:]):
        * WebView/WebFrame.mm:
        (-[WebFrame _loadURL:referrer:intoChild:]):
        (-[WebFrame _addChild:]):
        (-[WebFrame _dataSource]):
        (-[WebFrame DOMDocument]):
        (-[WebFrame dataSource]):
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
        * WebView/WebRenderNode.mm:
        (-[WebRenderNode initWithWebFrameView:]):
        * WebView/WebView.mm:
        (-[WebView _mainFrameOverrideEncoding]):
        (-[WebView mainFrameURL]):
        (-[WebView mainFrameTitle]):
        (-[WebView mainFrameIcon]):
        (-[WebView validateUserInterfaceItemWithoutDelegate:]):
        (-[WebView replaceSelectionWithArchive:]):
        (-[WebView _isLoading]):
        (-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]):
        (-[WebView _notifyTextSizeMultiplierChanged]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoUpdate test results for improved colgroup span handling.
hyatt [Mon, 21 May 2007 07:40:04 +0000 (07:40 +0000)]
Update test results for improved colgroup span handling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd new layout test for spanning colgroup rules=groups bug.
hyatt [Mon, 21 May 2007 07:31:36 +0000 (07:31 +0000)]
Add new layout test for spanning colgroup rules=groups bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Second half of fix for 13793, make sure rules=groups works properly with
hyatt [Mon, 21 May 2007 07:30:15 +0000 (07:30 +0000)]
    Second half of fix for 13793, make sure rules=groups works properly with
        spanning colgroups.

        Also make sure colgroups get an actual span of 1 (instead of incorrectly
        giving them a span of 0).

        Reviewed by mitz

        fast/table/colgroup-spanning-groups-rules.html

        * html/HTMLTableColElement.cpp:
        (WebCore::HTMLTableColElement::HTMLTableColElement):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::colElement):
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::collapsedLeftBorder):
        (WebCore::RenderTableCell::collapsedRightBorder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Half of a fix for 13793, make sure rules=groups and border behave properly
hyatt [Mon, 21 May 2007 06:29:30 +0000 (06:29 +0000)]
    Half of a fix for 13793, make sure rules=groups and border behave properly
        together.

        Reviewed by mitz

        No tests added, two Mozilla table tests now pass that failed before.

        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::getSharedCellDecl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix spelling.
bdash [Mon, 21 May 2007 00:44:22 +0000 (00:44 +0000)]
Fix spelling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoose Garen
beidson [Sun, 20 May 2007 22:55:22 +0000 (22:55 +0000)]
    Reviewed by Geoose Garen

        <rdar://problem/4758919> - Incorrect favicon shown for URL after going back

        When restoring a cached page, we'd try to kick off the icon load for it, which ended up causing
        shenanigans with the icon url -> page url mapping.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::endIfNotLoading): Only try an icon load if we're not restoring from the page cache
        (WebCore::FrameLoader::startIconLoader): Added helpful logging that helped me track this down
        (WebCore::FrameLoader::commitIconURLToIconDatabase): Ditto (and fixed a comment typo)

        * loader/icon/IconLoader.cpp:
        (WebCore::IconLoader::stopLoading): Don't null out the ResourceLoader here, as clearLoadingState() does that
        (WebCore::IconLoader::finishLoading): Added helpful logging that helped me track this down

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver Hunt.
darin [Sun, 20 May 2007 21:14:40 +0000 (21:14 +0000)]
    Reviewed by Oliver Hunt.

        - fix <rdar://problem/5193416> REGRESSION: Selection on large pages extremely slow

        * dom/Document.cpp: (WebCore::Document::removeMarkers): Added an early exit for the common
        case where there are no markers. Changed code to iterate over all the nodes in the range
        instead of using TextIterator, which is more efficient.

        * page/Frame.cpp: (WebCore::Frame::respondToChangedSelection): Added checks for editable,
        so we don't bother doing work related to spell checking and grammar checking when changing
        the selection in non-editable text. Also rearranged the code so we only compute the old
        word boundaries and sentence boundaries when actually needed, and don't do the sentence
        range checks unless grammar checking is enabled.

        * platform/TextBreakIteratorICU.cpp:
        (WebCore::setUpIterator): Don't take a locale parameter. Always pass in currentTextBreakLocaleID.
        (WebCore::characterBreakIterator): Removed local parameter.
        (WebCore::wordBreakIterator): Ditto.
        (WebCore::lineBreakIterator): Ditto.
        (WebCore::sentenceBreakIterator): Ditto.

        * platform/mac/TextBreakIteratorInternalICUMac.mm:
        (WebCore::getTextBreakLocale): Broke out the code to actually get the locale.
        (WebCore::currentTextBreakLocaleID): This function now handles only the caching and calls
        getTextBreakLocale to actually figure it out.

        * editing/visible_units.cpp: Added lots of FIXME comments, but no code change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoadd -f to cp for some obscure build systems.
staikos [Sun, 20 May 2007 18:36:13 +0000 (18:36 +0000)]
add -f to cp for some obscure build systems.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd missing include for auto_ptr
staikos [Sun, 20 May 2007 17:45:02 +0000 (17:45 +0000)]
Add missing include for auto_ptr

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-20 David Kilzer <ddkilzer@webkit.org>
ddkilzer [Sun, 20 May 2007 14:12:06 +0000 (14:12 +0000)]
2007-05-20  David Kilzer  <ddkilzer@webkit.org>

        Reviewed by Adam Roben.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13565
          Change svn-create-patch to put LayoutTests in the end

        In addition to reordering test files under the LayoutTests directory so that they
        appear after source code files, this patch fixes an issue with prepare-ChangeLog
        if the first argument passed to it is a file name instead of a directory name.

        * Scripts/prepare-ChangeLog:
        (isGIT()): If first value in @dirs array is a file, use dirname() to get the directory.
        (isSVN()): Ditto.
        * Scripts/svn-create-patch:
        (generateFileList($\%\%\%)): Differentiate test files in the LayoutTests directory from
        source code files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for bug 13785, O(n^2) counter creation.
hyatt [Sun, 20 May 2007 00:20:32 +0000 (00:20 +0000)]
    Fix for bug 13785, O(n^2) counter creation.

        Reviewed by darin

        * rendering/RenderCounter.cpp:
        (WebCore::findPlaceForCounter):
        (WebCore::RenderCounter::originalText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-19 Mitz Pettel <mitz@webkit.org>
bdash [Sun, 20 May 2007 00:16:53 +0000 (00:16 +0000)]
2007-05-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12729
          box-shadow disappears when scrolling a div that it falls on/under

        Tests: fast/repaint/box-shadow-dynamic.html
               fast/repaint/box-shadow-h.html
               fast/repaint/box-shadow-v.html

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::placeBoxesHorizontally): Factor in box shadow.
        (WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
        (WebCore::InlineFlowBox::paint): Account for box shadow when checking if
        the damage rect intersects.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::overflowHeight): For overflow areas, when asked
        for the "exterior" overflow, add box shadow overflow.
        (WebCore::RenderBlock::overflowWidth): Ditto.
        (WebCore::RenderBlock::overflowLeft): Ditto.
        (WebCore::RenderBlock::overflowTop): Ditto.
        (WebCore::RenderBlock::overflowRect): Ditto.
        (WebCore::RenderBlock::layoutBlock): Factor box shadow into visual overflow.
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::lowestPosition): For overflow areas, when asked for
        the "exterior" extreme position, add box shadow.
        (WebCore::RenderFlow::rightmostPosition): Ditto.
        (WebCore::RenderFlow::leftmostPosition): Ditto.
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::calculateRects): Avoid clipping out box shadow.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Make sure to paint
        the box shadow when an edge with a shadow moves.
        (WebCore::RenderObject::adjustRectForOutlineAndShadow): Helper function
        that expands a given rectangle to encompass outline and box shadow.
        (WebCore::RenderObject::absoluteOutlineBox): Changed to include box shadow.
        * rendering/RenderObject.h:

2007-05-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - repaint tests and updated results for http://bugs.webkit.org/show_bug.cgi?id=12729
          box-shadow disappears when scrolling a div that it falls on/under

        * fast/box-shadow/basic-shadows-expected.checksum:
        * fast/box-shadow/basic-shadows-expected.png:
        * fast/box-shadow/basic-shadows-expected.txt:
        * fast/repaint/box-shadow-dynamic-expected.checksum: Added.
        * fast/repaint/box-shadow-dynamic-expected.png: Added.
        * fast/repaint/box-shadow-dynamic-expected.txt: Added.
        * fast/repaint/box-shadow-dynamic.html: Added.
        * fast/repaint/box-shadow-h-expected.checksum: Added.
        * fast/repaint/box-shadow-h-expected.png: Added.
        * fast/repaint/box-shadow-h-expected.txt: Added.
        * fast/repaint/box-shadow-h.html: Added.
        * fast/repaint/box-shadow-v-expected.checksum: Added.
        * fast/repaint/box-shadow-v-expected.png: Added.
        * fast/repaint/box-shadow-v-expected.txt: Added.
        * fast/repaint/box-shadow-v.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-20 Mark Rowe <mrowe@apple.com>
bdash [Sat, 19 May 2007 23:42:28 +0000 (23:42 +0000)]
2007-05-20  Mark Rowe  <mrowe@apple.com>

        Update test results after r21597.

        * fast/frames/viewsource-attribute-expected.checksum:
        * fast/frames/viewsource-attribute-expected.png:
        * fast/frames/viewsource-attribute-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-19 Mitz Pettel <mitz@webkit.org>
bdash [Sat, 19 May 2007 23:11:31 +0000 (23:11 +0000)]
2007-05-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13783
          REGRESSION (r21120): Frame resizers not repainted properly when dragged

        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-19 Mitz Pettel <mitz@webkit.org>
bdash [Sat, 19 May 2007 23:09:17 +0000 (23:09 +0000)]
2007-05-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13774
          REGRESSION: Crash emailing blog entry using Google Reader

        Test: fast/table/stale-grid-crash.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::recalcSections): Made const and replaced
        setNeedsLayout(true) with an assertion that the table is already
        marked for layout.
        (WebCore::RenderTable::sectionAbove): Added call to recalcSectionsIfNeeded().
        (WebCore::RenderTable::sectionBelow): Ditto.
        (WebCore::RenderTable::cellAbove): Ditto.
        (WebCore::RenderTable::cellBelow): Ditto.
        (WebCore::RenderTable::cellBefore): Ditto.
        (WebCore::RenderTable::cellAfter): Ditto.
        * rendering/RenderTable.h:
        Made some private member variables which are used in section recalc mutable.
        (WebCore::RenderTable::setNeedsSectionRecalc): Moved the call to
        setNeedsLayout() from recalcSections() into here, because I made
        recalcSections() const.
        (WebCore::RenderTable::recalcSectionsIfNeeded): Made const.

2007-05-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=13774
          REGRESSION: Crash emailing blog entry using Google Reader

        * fast/table/stale-grid-crash-expected.checksum: Added.
        * fast/table/stale-grid-crash-expected.png: Added.
        * fast/table/stale-grid-crash-expected.txt: Added.
        * fast/table/stale-grid-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-19 Mitz Pettel <mitz@webkit.org>
bdash [Sat, 19 May 2007 22:54:26 +0000 (22:54 +0000)]
2007-05-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=13320
          rounded corners with drop shadows are really slow

        Test for a rendering bug fixed by this patch:
            fast/box-shadow/border-radius-big.html

        No test for the performance ingredient.

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::addRoundedRectClip): Made cross-platform.
        Changed to use a single clipping path. If all the radii cannot be
        accommodated, clips to a rect.
        (WebCore::GraphicsContext::clipOutRoundedRect): Changed to use a single
        clipping path. If all the radii cannot be accommodated, clips out a rect.
        * platform/graphics/GraphicsContext.h: Added clipOut(const Path&).
        * platform/graphics/Path.cpp:
        (WebCore::Path::createRoundedRectangle): Added. Returns a rounded rectangle
        with the specified radii. If all the radii cannot be accommodated, returns
        a rectangular path.
        * platform/graphics/Path.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::clipOut): Added.
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::fillRoundedRect): Changed to use a single path.
        (WebCore::GraphicsContext::clipOut): Added.
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::clipOut): Added.

2007-05-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=13320
          rounded corners with drop shadows are really slow

        * fast/box-shadow/border-radius-big-expected.checksum: Added.
        * fast/box-shadow/border-radius-big-expected.png: Added.
        * fast/box-shadow/border-radius-big-expected.txt: Added.
        * fast/box-shadow/border-radius-big.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
andersca [Sat, 19 May 2007 13:14:44 +0000 (13:14 +0000)]
LayoutTests:

        Reviewed by Mitz.

        http://bugs.webkit.org/show_bug.cgi?id=13771
        Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester

        * fast/frames/inline-object-inside-frameset-expected.txt: Added.
        * fast/frames/inline-object-inside-frameset.html: Added.

WebCore:

        Reviewed by Mitz.

        Test: fast/frames/inline-object-inside-frameset.html

        http://bugs.webkit.org/show_bug.cgi?id=13771
        Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester

        Don't paint inline objects.

        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add support for plain text MIME types (CSS/JS/TXT) to view source mode.
hyatt [Sat, 19 May 2007 07:42:59 +0000 (07:42 +0000)]
    Add support for plain text MIME types (CSS/JS/TXT) to view source mode.
        CSS/JS will eventually tokenize via their own special tokenizers so that
        they can also be syntax-highlighted, but for now just treat them as
        plain text.

        Reviewed by aroben

        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createDocument):
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
        (WebCore::HTMLViewSourceDocument::createTokenizer):
        (WebCore::HTMLViewSourceDocument::createContainingTable):
        (WebCore::HTMLViewSourceDocument::addViewSourceText):
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):
        * html/HTMLViewSourceDocument.h:
        * loader/TextDocument.cpp:
        (WebCore::TextTokenizer::TextTokenizer):
        (WebCore::TextTokenizer::write):
        * loader/TextDocument.h:
        (WebCore::TextTokenizer::checkBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix a glitch in view source mode attribute names.
hyatt [Sat, 19 May 2007 06:48:50 +0000 (06:48 +0000)]
    Fix a glitch in view source mode attribute names.

        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago "Linkify" view source mode links.
hyatt [Sat, 19 May 2007 05:16:08 +0000 (05:16 +0000)]
    "Linkify" view source mode links.

        Reviewed by andersca

        * css/view-source.css:
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):
        (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
        (WebCore::HTMLViewSourceDocument::addLink):
        * html/HTMLViewSourceDocument.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Oliver Hunt <oliver@apple.com>
oliver [Sat, 19 May 2007 02:05:48 +0000 (02:05 +0000)]
2007-05-18  Oliver Hunt  <oliver@apple.com>

WebCore:

        Reviewed by Sam

        No longer need to pass HTMLImageElement and HTMLImageLoader on to WebKit
        Need to expose CachedResourceClient constructor

        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:

WebKit:

        Reviewed by Sam.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=13782
        REGRESSION (r21528-r21533): Failing editing/selection/drag-in-iframe in pixel mode

        r21533 made used a DOMElement as the source for promise data, this meant it had to
        clear the dragging pasteboard following the drag.  In DRT a drag is non-blocking
        so this resulted in us prematurely clearing the pasteboard.

        This patch avoids this problem by referencing the source CachedImage rather than the
        DOMElement, so we don't need to worry about retaining an entire document forever, so
        we don't need to clear the dragging pasteboard following the drag.

        * Misc/WebNSPasteboardExtras.mm:
        (imageFromElement):
          Extract the underlying CachedImage from a DOMElement
        (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
          Use a CachedImage instead of a DOMElement

        * WebCoreSupport/WebDragClient.mm:
        (WebDragClient::startDrag):

        * WebKit.xcodeproj/project.pbxproj:

        * WebView/WebHTMLView.mm:
        (-[WebHTMLViewPrivate dealloc]):
        (-[WebHTMLViewPrivate clear]):
        (-[WebHTMLView pasteboardChangedOwner:]):
        (-[WebHTMLView pasteboard:provideDataForType:]):
        (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
        (-[WebHTMLView WebCore::]):
        (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
          Use CachedImage rather than DOMElement as promised data source

        * WebView/WebHTMLViewInternal.h:
        * WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix more malformed test cases.
hyatt [Fri, 18 May 2007 23:32:59 +0000 (23:32 +0000)]
Fix more malformed test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix more malformed test cases.
hyatt [Fri, 18 May 2007 23:32:13 +0000 (23:32 +0000)]
Fix more malformed test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix more malformed test cases.
hyatt [Fri, 18 May 2007 23:31:14 +0000 (23:31 +0000)]
Fix more malformed test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix more malformed test cases.
hyatt [Fri, 18 May 2007 23:29:09 +0000 (23:29 +0000)]
Fix more malformed test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix more malformed test cases.
hyatt [Fri, 18 May 2007 23:26:03 +0000 (23:26 +0000)]
Fix more malformed test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBeating my head against these malformed http/navigation tests still.
hyatt [Fri, 18 May 2007 23:12:20 +0000 (23:12 +0000)]
Beating my head against these malformed http/navigation tests still.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBeating my head against these malformed http/navigation tests still.
hyatt [Fri, 18 May 2007 23:06:48 +0000 (23:06 +0000)]
Beating my head against these malformed http/navigation tests still.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBeating my head against these malformed http/navigation tests still.
hyatt [Fri, 18 May 2007 23:04:43 +0000 (23:04 +0000)]
Beating my head against these malformed http/navigation tests still.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBeating my head against these malformed http/navigation tests still.
hyatt [Fri, 18 May 2007 23:03:48 +0000 (23:03 +0000)]
Beating my head against these malformed http/navigation tests still.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBeating my head against these malformed http/navigation tests still.
hyatt [Fri, 18 May 2007 23:03:08 +0000 (23:03 +0000)]
Beating my head against these malformed http/navigation tests still.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBeating my head against these malformed http/navigation tests still.
hyatt [Fri, 18 May 2007 23:01:12 +0000 (23:01 +0000)]
Beating my head against these malformed http/navigation tests still.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixing broken http/navigation test cases that were written with malformed HTML.
hyatt [Fri, 18 May 2007 22:50:34 +0000 (22:50 +0000)]
Fixing broken http/navigation test cases that were written with malformed HTML.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixing broken http/navigation test cases that were written with malformed HTML.
hyatt [Fri, 18 May 2007 22:48:51 +0000 (22:48 +0000)]
Fixing broken http/navigation test cases that were written with malformed HTML.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixed potential crash with ASSERT in download due to previous commit.
tristan [Fri, 18 May 2007 22:46:36 +0000 (22:46 +0000)]
Fixed potential crash with ASSERT in download due to previous commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for <rdar://problem/5214338> REGRESSION: / mishandled in
hyatt [Fri, 18 May 2007 22:44:26 +0000 (22:44 +0000)]
    Fix for <rdar://problem/5214338> REGRESSION: / mishandled in
        HTML tokenization (13780).

        Reviewed by ggaren

        * html/HTMLTokenizer.cpp:
        (WebCore::Token::addAttribute):
        (WebCore::HTMLTokenizer::parseTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdded bugzilla link
beidson [Fri, 18 May 2007 22:40:56 +0000 (22:40 +0000)]
Added bugzilla link

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * WebCoreSupport/WebFrameLoaderClient.mm:
tristan [Fri, 18 May 2007 22:38:46 +0000 (22:38 +0000)]
    * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::download):
        asked the webframeloaderclient for its webview's history and
        injected the originated url into the created WebDownload

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej
beidson [Fri, 18 May 2007 22:38:16 +0000 (22:38 +0000)]
    Reviewed by Maciej

        <rdar://problem/5166149> - window.open() causes server to be hit twice

        This regressed in http://trac.webkit.org/projects/webkit/changeset/14637
        That patch was to fix broken behavior when opening an already existant window.
        The unfortunate side effect was to cause the server to be hit twice.
        Once during the call to frame->loader()->createWindow(), and again via a
        scheduled redirection.

        I decided to restore the original de-facto behavior by making the new window
        open via a scheduled redirection - there is a FIXME that was already here that
        explains the reason why we have to do it this way for now.

        Additionally, there were two distinct places that had their own logic to open
        a new window - the logic for window.open() and the logic for
        window.showModalDialog().  The logic was almost identical so I condensed them
        into one utility function that takes a flag to handle the slight difference.

        A layout test is not possible at this time since it would involve capturing
        server logs (the 1st connection does not exist long enough to result in any
        delegate callbacks).  That task is documented in
        http://bugs.webkit.org/show_bug.cgi?id=13769

        * bindings/js/kjs_window.cpp:
        (KJS::createWindow): Merged the two slightly different versions of "creating a window"
          logic here.  For the modal dialog case the load is an immediate call to changeLocation(),
          which is triggered by the "immediate" flag, and the other cases load via scheduleLocationChange()
        (KJS::showModalDialog): Call createWindow()
        (KJS::WindowFunc::callAsFunction): Handle frame targets of _top or _parent immediately and call
          createWindow() for all others

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Fri, 18 May 2007 21:06:14 +0000 (21:06 +0000)]
LayoutTests:

        Reviewed by Geoff.

        - update results to account for new JSHTMLElements that are being
          auto-generated and can now produce Constructors.

        * fast/dom/Window/element-constructors-on-window-expected.txt:
        * fast/dom/Window/window-properties-expected.txt:

WebCore:

        Reviewed by Geoff.

        Autogenerate the JS bindings for the HTMLTableElement, HTMLTableCaptionElement,
        HTMLTableCellElement, HTMLTableColElement, HTMLTableRowElement, HTMLTableSectionElement.

        * DerivedSources.make:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSHTMLElementWrapperFactory.cpp:
        (WebCore::createJSHTMLWrapper):
        * bindings/js/kjs_html.cpp:
        (KJS::):
        (KJS::JSHTMLElement::classInfo):
        (KJS::JSHTMLElement::accessors):
        (KJS::HTMLElementFunction::callAsFunction):
        * bindings/js/kjs_html.h:
        (KJS::JSHTMLElement::):
        * html/HTMLTableCaptionElement.idl:
        * html/HTMLTableCellElement.idl:
        * html/HTMLTableColElement.idl:
        * html/HTMLTableElement.idl:
        * html/HTMLTableRowElement.idl:
        * html/HTMLTableSectionElement.idl:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin Decker
sullivan [Fri, 18 May 2007 20:47:45 +0000 (20:47 +0000)]
    Reviewed by Kevin Decker

        Improvement to WebKit part of fix for 5201499 based on more modern understanding. (That is,
        a couple of hours more modern.)

        * WebView/WebUIDelegatePrivate.h:
        add showPanel: parameter to just-introduced delegate method webView:saveFrameView:

        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewSavePDFToDownloadFolder:]):
        pass NO for new showPanel: parameter, and update comment

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John.
mjs [Fri, 18 May 2007 20:33:57 +0000 (20:33 +0000)]
    Reviewed by John.

        <rdar://problem/5204792> REGRESSION (r21367): System widgets are drawn with vertical/horizontal scroll bars

        No test because the bug requires calling setAllowsScrolling: to reproduce.

        * WebView/WebFrameView.mm:
        (-[WebFrameView setAllowsScrolling:]): Update the FrameView's scroll state as well as the one
        on WebDynamicScrollBarsView, otherwise this setting won't stick if the frame has already loaded
        a document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Not Reviewed, buildbot test fix.
mjs [Fri, 18 May 2007 20:32:15 +0000 (20:32 +0000)]
    Not Reviewed, buildbot test fix.

        - updated results for the last fiew checkins.

        * fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt:
        * fast/dom/replaceChild-expected.txt:
        * http/tests/loading/bad-scheme-subframe-expected.txt:
        * webarchive/loading/test-loading-archive-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Oliver Hunt <oliver@apple.com>
oliver [Fri, 18 May 2007 19:14:22 +0000 (19:14 +0000)]
2007-05-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam.

        Fix for <rdar://problem/5211122> DRT crash below
        SVGTimer::applyAnimations when page cache is enabled
        (SVG animation timers do not properly cancel themselves)

        There were still a few paths in the SVG Animation code
        that could cause timers to be created and used.  This
        patch inserts addition SVG_EXPERIMENTAL blocks to prevent
        these timers from being used.

        * ksvg2/misc/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::startAnimations):
        * ksvg2/misc/SVGTimer.cpp:
        (WebCore::SVGTimer::animationsByElement):
        (WebCore::SVGTimer::applyAnimations):
        (WebCore::SVGTimer::notifyAll):
        (WebCore::SVGTimer::addNotify):
        (WebCore::SVGTimer::removeNotify):
        * ksvg2/misc/TimeScheduler.cpp:
        (WebCore::TimeScheduler::addTimer):
        (WebCore::TimeScheduler::connectIntervalTimer):
        (WebCore::TimeScheduler::disconnectIntervalTimer):
        (WebCore::TimeScheduler::startAnimations):
        (WebCore::TimeScheduler::toggleAnimations):
        (WebCore::TimeScheduler::timerFired):
        * ksvg2/svg/SVGAnimationElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fixed spelling error.
ggaren [Fri, 18 May 2007 18:58:13 +0000 (18:58 +0000)]
    Fixed spelling error.

        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
weinig [Fri, 18 May 2007 17:52:02 +0000 (17:52 +0000)]
    Reviewed by Mitz.

        Update test results after Hyatt's update of view-source
        to include line numbers and a gutter.

        * fast/frames/viewsource-attribute-expected.checksum:
        * fast/frames/viewsource-attribute-expected.png:
        * fast/frames/viewsource-attribute-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin Decker
sullivan [Fri, 18 May 2007 17:05:30 +0000 (17:05 +0000)]
    Reviewed by Kevin Decker

        WebKit part of fix for 5201499 (support for PDFKit UI for saving PDFs to disk)

        Also, the PDFKit mechanism for notifying clients about "Open File Externally" was
        changed from a notification to a delegate method. The notification was new to
        Leopard, so removing it doesn't affect clients in the field.

        * WebView/WebUIDelegatePrivate.h:
        Declared new UI delegate method webView:saveFrameView:, analogous to the existing
        webView:printFrameView:

        * WebView/WebPDFView.mm:
        removed declaration of _webkit_PDFKitLaunchNotification
        (-[WebPDFView viewDidMoveToWindow]):
        don't observe _webkit_PDFKitLaunchNotification
        (-[WebPDFView viewWillMoveToWindow:]):
        ditto
        (-[WebPDFView PDFViewOpenPDFInNativeApplication:]):
        new PDFKit delegate method, replaces our use of _webkit_PDFKitLaunchNotification
        (-[WebPDFView PDFViewSavePDFToDownloadFolder:]):
        new PDFKit delegate method, calls through to new WebKit UI delegate method

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoPatch from Marius Bugge Monsen to fix clipboard crash.
zack [Fri, 18 May 2007 15:36:18 +0000 (15:36 +0000)]
Patch from Marius Bugge Monsen to fix clipboard crash.

Return a valid pointer to a Clipboard object
from newGeneralClipboard.
r=me

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoChanged the QWebPage::loadProgressChange API to have an integer (percent) argument
hausmann [Fri, 18 May 2007 14:17:52 +0000 (14:17 +0000)]
Changed the QWebPage::loadProgressChange API to have an integer (percent) argument
instead of a double precision float.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoKeyboard event crash fix by Marius Bugge Monsen.
zack [Fri, 18 May 2007 12:11:58 +0000 (12:11 +0000)]
Keyboard event crash fix by Marius Bugge Monsen.

The default constructed KeyboardEvent has
no PlatformKeyboardEvent.
r=me

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Oliver Hunt <oliver@apple.com>
oliver [Fri, 18 May 2007 10:15:05 +0000 (10:15 +0000)]
2007-05-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Mark.

        Fix capitalisation of resources referenced by test case.

        * svg/carto.net/window.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Mark Rowe <mrowe@apple.com>
bdash [Fri, 18 May 2007 09:50:19 +0000 (09:50 +0000)]
2007-05-18  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver.

        Force LC_ALL to C when parsing locale-specific strings in 'svn' output.

        * Scripts/svn-create-patch:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Mark Rowe <mrowe@apple.com>
bdash [Fri, 18 May 2007 09:21:31 +0000 (09:21 +0000)]
2007-05-18  Mark Rowe  <mrowe@apple.com>

        Attempt to fix the Gdk build after r21562.

        * platform/gdk/TemporaryLinkStubs.cpp:
        (Widget::isEnabled):
        * platform/gdk/WidgetGdk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Adam Treat <treat@kde.org>
lars [Fri, 18 May 2007 08:49:00 +0000 (08:49 +0000)]
2007-05-18  Adam Treat <treat@kde.org>

        Reviewed by Lars

        Remove dead code.

        * platform/Widget.h:
        * platform/mac/WidgetMac.mm:
        * platform/qt/WidgetQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Holger Freyther <zecke@selfish.org>
bdash [Fri, 18 May 2007 08:44:11 +0000 (08:44 +0000)]
2007-05-18  Holger Freyther  <zecke@selfish.org>

        Reviewed by Maciej.

        Return true to make loading of pages working again

        * loader/gdk/FrameLoaderClientGdk.cpp:
        (WebCore::FrameLoaderClientGdk::canHandleRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Holger Freyther <zecke@selfish.org>
bdash [Fri, 18 May 2007 08:41:43 +0000 (08:41 +0000)]
2007-05-18  Holger Freyther  <zecke@selfish.org>

        Reviewed by Maciej.

        Make WebCore::Widget use GtkWidget to fix focus handling.

        * WebCore.pro: Add PlatformScrollBar
        * platform/ScrollView.h: Gtk stuff
        * platform/Widget.h: Take a GtkWidget
        * platform/gdk/PlatformScrollBarGdk.cpp: Added.
        (PlatformScrollbar::PlatformScrollbar):
        (PlatformScrollbar::~PlatformScrollbar):
        (PlatformScrollbar::width):
        (PlatformScrollbar::height):
        (PlatformScrollbar::setEnabled):
        (PlatformScrollbar::paint):
        (PlatformScrollbar::updateThumbPosition):
        (PlatformScrollbar::updateThumbProportion):
        (PlatformScrollbar::setRect):
        * platform/gdk/ScreenGdk.cpp: Implement depth handling
        (WebCore::screenDepth):
        * platform/gdk/ScrollViewGdk.cpp: use setGtkWidget, not setDrawable
        (WebCore::ScrollView::setGtkWidget):
        * platform/gdk/TemporaryLinkStubs.cpp:
        * platform/gdk/WidgetGdk.cpp:
        (WebCore::Widget::Widget):
        (WebCore::Widget::gtkWidget):
        (WebCore::Widget::setGtkWidget):
        (WebCore::Widget::hasFocus):
        (WebCore::Widget::setFocus):

2007-05-18  Holger Freyther  <zecke@selfish.org>

        Reviewed by Maciej.

        * GdkLauncher/main.cpp: Call setGtkWidget
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Zack
lars [Fri, 18 May 2007 08:38:11 +0000 (08:38 +0000)]
    Reviewed by Zack

        Correctly implement initialiseSupportedImageMIMETypes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org>
bdash [Fri, 18 May 2007 08:34:04 +0000 (08:34 +0000)]
2007-05-18  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Maciej.

        Build fix for non-Qt and non-Mac ports.

        * html/HTMLCanvasElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org>
bdash [Fri, 18 May 2007 08:29:58 +0000 (08:29 +0000)]
2007-05-18  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Mark Rowe.

        No test added as this is hard to time.

        * platform/gdk/FrameGdk.cpp: Use needsLayout() to decide if layout()
        is needed.

        (WebCore::FrameGdk::dumpRenderTree):
        (WebCore::FrameGdk::handleGdkEvent):

2007-05-18  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Mark Rowe.

        * kjs/testkjs.pro: Make the Gdk port link to icu

2007-05-18  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Mark Rowe.

        * WebKit.pro: Build testkjs for Gdk and Qt

2007-05-18  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Mark Rowe.

        * GdkLauncher/main.cpp:
        (main): Call Frame::init to catch up with Maciej's changes.
        * Scripts/run-javascriptcore-tests: Remove --gdk from the command line
        passed to the helper scripts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoGenerate pkgconfig files for the Qt build.
hausmann [Fri, 18 May 2007 07:54:37 +0000 (07:54 +0000)]
Generate pkgconfig files for the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
lars [Fri, 18 May 2007 07:09:43 +0000 (07:09 +0000)]
    Reviewed by Hyatt.

        Remove unused handleMouseEvent methods in the Widget
        and derived classes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoUse the proper clipping algorithm
staikos [Fri, 18 May 2007 07:00:11 +0000 (07:00 +0000)]
Use the proper clipping algorithm

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by George Staikos.
weinig [Fri, 18 May 2007 06:36:07 +0000 (06:36 +0000)]
    Reviewed by George Staikos.

        Fix Qt build after adding JSHTMLAnchorElementCustom.cpp.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago- patch from Adam Treat to implement frameLoadCompleted()
staikos [Fri, 18 May 2007 06:32:08 +0000 (06:32 +0000)]
- patch from Adam Treat to implement frameLoadCompleted()
- build fix from George Staikos

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix preprocessor logic for CG/QT
staikos [Fri, 18 May 2007 06:08:11 +0000 (06:08 +0000)]
Fix preprocessor logic for CG/QT

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoImplement forceLayoutForNonHTML
staikos [Fri, 18 May 2007 05:32:12 +0000 (05:32 +0000)]
Implement forceLayoutForNonHTML

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoImplement canShowMIMEType
staikos [Fri, 18 May 2007 05:28:31 +0000 (05:28 +0000)]
Implement canShowMIMEType

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add a line gutter to view source mode. The gutter uses counters, and this...
hyatt [Fri, 18 May 2007 05:07:23 +0000 (05:07 +0000)]
    Add a line gutter to view source mode.  The gutter uses counters, and this exposed the fact
        that pseudoStyleForElement was not walking all UA rules properly.

        Reviewed by aroben

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::pseudoStyleForElement):
        * css/view-source.css:
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):
        (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
        (WebCore::HTMLViewSourceDocument::addLine):
        (WebCore::HTMLViewSourceDocument::addText):
        * html/HTMLViewSourceDocument.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Fri, 18 May 2007 04:17:59 +0000 (04:17 +0000)]
LayoutTests:

        Reviewed by ggaren

        <rdar://problem/5209984> REGRESSION: Crash on click after clearing Facebook status

        * editing/selection/5209984-expected.txt: Added.
        * editing/selection/5209984.html: Added.

WebCore:

        Reviewed by ggaren

        <rdar://problem/5209984> REGRESSION: Crash on click after clearing Facebook status

        comparePositions() expects non-null positions.  It's
        given a null position by contains() if the current
        selection is a range selection but contains only invisible
        content *and* visible positions cannot be created from its
        end points.  This can happen when there is a range selection
        inside shadow content (like that inside text fields) that
        is made invisible.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::contains): Check for
        invisible end points.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Fri, 18 May 2007 02:50:44 +0000 (02:50 +0000)]
LayoutTests:

        Reviewed by Adam.

        Tests for <rdar://problem/5201423> REGRESSION: Links in
        sidebar don't work on Honda website

        * fast/dom/anchor-toString-expected.txt: Added.
        * fast/dom/anchor-toString.html: Added.
        * fast/forms/focus2.html:

WebCore:

        Reviewed by Adam.

        Fix for <rdar://problem/5201423> REGRESSION: Links in
        sidebar don't work on Honda website

        Anchor elements need to have the same behavior for implicit and
        explicit toString() calls.

        Test: fast/dom/anchor-toString.html

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSHTMLAnchorElementCustom.cpp: Added.
        (WebCore::JSHTMLAnchorElement::toString):
        * html/HTMLAnchorElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix.
ggaren [Thu, 17 May 2007 23:38:51 +0000 (23:38 +0000)]
    Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
adele [Thu, 17 May 2007 23:15:37 +0000 (23:15 +0000)]
    Reviewed by Hyatt.

        Update RenderMenuList PopupClient methods to consider style of inner block.

        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::itemStyle):
        (WebCore::RenderMenuList::clientStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Not reviewed, emergency test fix.
mjs [Thu, 17 May 2007 22:57:49 +0000 (22:57 +0000)]
    Not reviewed, emergency test fix.

        - avoid crash on layout tests.

        Patched up my last change so that  widgets don't crash.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::mainReceivedCompleteError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
antti [Thu, 17 May 2007 22:25:01 +0000 (22:25 +0000)]
LayoutTests:

        Reviewed by Darin.

        Test for http://bugs.webkit.org/show_bug.cgi?id=13727
        REGRESSION: Reproducible hang setting the selection's extent offset to -1
        <rdar://problem/5206890>

        * LayoutTests/editing/selection/selection-invalid-offset-expected.txt: Added.
        * LayoutTests/editing/selection/selection-invalid-offset.html: Added.

WebCore:

        Reviewed by Darin.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=13727
        REGRESSION: Reproducible hang setting the selection's extent offset to -1
        <rdar://problem/5206890>

        Rise INDEX_SIZE_ERR if used selection index is negative. This matches HTML5 for
        getRangeAt() and collapse() which are part of the spec (FF throws NS_ERROR_FAILURE).

        Not throwing exceptions yet for too high offsets (except getRangeAt()) as it is
        unclear if WebCore's definition of offsets is the same as other browsers.

        * bindings/js/kjs_window.cpp:
        * WebCore/editing/SelectionController.cpp:
        * WebCore/editing/SelectionController.h:
        * WebCore/editing/VisiblePosition.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Thu, 17 May 2007 21:42:21 +0000 (21:42 +0000)]
LayoutTests:

        Reviewed by Mitz.

        Test for <rdar://problem/5096035> REGRESSION: rtl text should be left-aligned in <select>s

        * fast/text/international/bidi-menulist-expected.checksum: Added.
        * fast/text/international/bidi-menulist-expected.png: Added.
        * fast/text/international/bidi-menulist-expected.txt: Added.
        * fast/text/international/bidi-menulist.html: Added.

WebCore:

        Reviewed by Mitz.

        Fix for <rdar://problem/5096035> REGRESSION: rtl text should be left-aligned in <select>s

        Test: fast/text/international/bidi-menulist.html

        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::adjustInnerStyle): Set the inner block style to direction: ltr, and text-align: left.  This means that
         we will ignore those settings in the button to match the way the text is displayed in the popup menu.
        (WebCore::RenderMenuList::createInnerBlock): Call adjustInnerStyle.
        (WebCore::RenderMenuList::setStyle): ditto.
        * rendering/RenderMenuList.h: Added adjustInnerStyle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoI accidently mucked around with these tests after generating results.
justing [Thu, 17 May 2007 21:16:48 +0000 (21:16 +0000)]
I accidently mucked around with these tests after generating results.
Correcting them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Thu, 17 May 2007 21:06:12 +0000 (21:06 +0000)]
LayoutTests:

        Reviewed by harrison

        * editing/execCommand/4924441-expected.checksum: Added.
        * editing/execCommand/4924441-expected.png: Added.
        * editing/execCommand/4924441-expected.txt: Added.
        * editing/execCommand/4924441.html: Added.
        * editing/execCommand/5207369-expected.checksum: Added.
        * editing/execCommand/5207369-expected.png: Added.
        * editing/execCommand/5207369-expected.txt: Added.
        * editing/execCommand/5207369.html: Added.
        * editing/execCommand/5210032-expected.checksum: Added.
        * editing/execCommand/5210032-expected.png: Added.
        * editing/execCommand/5210032-expected.txt: Added.
        * editing/execCommand/5210032.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/4924441> List becomes nested when changing its type
        <rdar://problem/5210032> Content before a list is placed at the end of the list when its made into a list item
        <rdar://problem/5207369> Crash when removing ordering from a nested list

        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::doApply):
        The outermostEnclosingList of the position before the start isn't
        the previousList if it contains the start.
        Ditto for the position after the end and the nextList.
        If we're putting the newly created list item into the next list,
        insert it at the start of that list, not the end (don't append).
        Avoid nesting newly created lists inside list items.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago<rdar://problem/4775672> AXTextMarkerRangeForUnorderedTextMarkers returns incorrect...
pyeh [Thu, 17 May 2007 18:35:18 +0000 (18:35 +0000)]
<rdar://problem/4775672> AXTextMarkerRangeForUnorderedTextMarkers returns incorrect order

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
        A selection's m_start is not guranteed to equal m_base since m_start can actually be m_base's downstream().
        A more accurate way to determine the order from selection is to ask directly for isBaseFirst().
        In addition, if the two visible positions given are the same position but different affinity, we need to
        handle it here rather than depend on the selection. This is because selection does not retain the
        affinity of both selection start/end visible positions as part of the selection validation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
beidson [Thu, 17 May 2007 17:52:44 +0000 (17:52 +0000)]
LayoutTests:

        Reviewed by Brady

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=13759
          REGRESSION (r20182-r20184): Incorrect rendering of multipart images

        Created http/tests/multipart and moved the existing multipart test there.

        * http/tests/misc/multipart-expected.txt: Removed.
        * http/tests/misc/multipart.html: Removed.
        * http/tests/misc/resources/1x1-blue.png: Removed.
        * http/tests/misc/resources/multipart.php: Removed.
        * http/tests/multipart/invalid-image-data-expected.checksum: Added.
        * http/tests/multipart/invalid-image-data-expected.png: Added.
        * http/tests/multipart/invalid-image-data-expected.txt: Added.
        * http/tests/multipart/invalid-image-data.html: Added.
        * http/tests/multipart/resources/2x2-green.png: Added. Shared by both
        multipart tests.
        * http/tests/multipart/resources/abe.png: Added.
        * http/tests/multipart/resources/multipart.php: Added. Shared by both
        multipart tests.
        * http/tests/multipart/stop-crash.html: Renamed from misc/multipart.html.

WebCore:

        Reviewed by Brady

        - fix http://bugs.webkit.org/show_bug.cgi?id=13759
          REGRESSION (r20182-r20184): Incorrect rendering of multipart images

        Test: http/tests/multipart/invalid-image-data.html

        * loader/loader.cpp:
        (WebCore::Loader::didReceiveData): Make a copy of the current part's data
        instead of using the resource data, because the latter is going to be
        overwritten by the new part being received.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-17 Oliver Hunt <oliver@apple.com>
oliver [Thu, 17 May 2007 11:32:11 +0000 (11:32 +0000)]
2007-05-17  Oliver Hunt  <oliver@apple.com>

WebCore:

        Reviewed by Justin.

        Fix for <rdar://problem/4244861> Safari fails to create image file
        after releasing dragged image that has changed on source page

        Tell xcode to copy HTMLImageElement.h and HTMLImageLoader.h headers
        across to WebKit as private headers.

        * WebCore.xcodeproj/project.pbxproj:

WebKit:

        Reviewed by Justin.

        Fix for <rdar://problem/4244861> Safari fails to create image file
        after releasing dragged image that has changed on source page

        This patch fixes this bug by manually creating an NSFileWrapper from
        the TIFF promise data for a drag if it is available.  This bypasses
        the problem of the required resource no longer being held due to page
        loads or other constraints.

        We need to leave the old path in place to allow for the case where
        the promised data is not available.

        * WebCoreSupport/WebDragClient.mm:
        (WebDragClient::declareAndWriteDragImage):
          Always use the top WebHTMLView as the pasteboard owner, this is
          safe as we only use the owner for resolving promised types.
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _writeSelectionToPasteboard:]):
        (-[WebHTMLView writeSelectionToPasteboard:types:]):
          Always use the top WebHTMLView as the pasteboard owner.
        (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
          Add path to create NSFileWrapper from promise data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21535 268f45cc-cd09-0410-ab3c-d52691b4dbfc