WebKit-https.git
9 years agoWebHTTPBody: Keep track of whether the data includes passwords.
commit-queue@webkit.org [Wed, 14 Mar 2012 12:41:37 +0000 (12:41 +0000)]
WebHTTPBody: Keep track of whether the data includes passwords.
https://bugs.webkit.org/show_bug.cgi?id=81003

Patch by Marja Hölttä <marja@google.com> on 2012-03-14
Reviewed by Darin Fisher.

This change enables Chrome to save HTTP bodies selectively, only
if they don't contain passwords.

Source/WebCore:

* loader/FormSubmission.cpp:
(WebCore::FormSubmission::create): Check if the data contains passwords.
* platform/network/FormData.cpp:
(WebCore::FormData::FormData): Added containsPasswordData, setContainsPasswordData.
* platform/network/FormData.h:
(WebCore::FormData::containsPasswordData): Added.
(WebCore::FormData::setHasPasswordData): Added.
(FormData):

Source/WebKit/chromium:

* public/platform/WebHTTPBody.h:
(WebHTTPBody): Added containsPasswordData, setContainsPasswordData.
* src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::containsPasswordData): Added.
(WebKit):
(WebKit::WebHTTPBody::setContainsPasswordData): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Add snippets tab to scripts navigator.
vsevik@chromium.org [Wed, 14 Mar 2012 12:23:08 +0000 (12:23 +0000)]
Web Inspector: Add snippets tab to scripts navigator.
https://bugs.webkit.org/show_bug.cgi?id=81018

Reviewed by Pavel Feldman.

Source/WebCore:

* English.lproj/localizedStrings.js:
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.get defaultFocusedElement):
(WebInspector.ScriptsNavigator.prototype.focus):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsNavigator.prototype.reset):
(WebInspector.ScriptsNavigator.prototype._getOrCreateFolderTreeElement):
(WebInspector.ScriptsNavigator.prototype._createFolderTreeElement):
(WebInspector.ScriptsNavigator.prototype._getOrCreateSnippetEvaluationsFolderTreeElement):
(WebInspector.ScriptsNavigator.prototype._scriptFolderIdentifier):
(WebInspector.NavigatorTreeOutline):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):
* inspector/front-end/SnippetsModel.js:

LayoutTests:

* http/tests/inspector/debugger-test.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Copy on the Console gives a mangled result.
pfeldman@chromium.org [Wed, 14 Mar 2012 12:03:48 +0000 (12:03 +0000)]
Web Inspector: Copy on the Console gives a mangled result.
https://bugs.webkit.org/show_bug.cgi?id=81091

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype._populateStackTraceTreeElement):

LayoutTests:

* http/tests/inspector-enabled/console-clear-arguments-on-frame-remove-expected.txt:
* http/tests/inspector/console-xhr-logging-async-expected.txt:
* http/tests/inspector/console-xhr-logging-expected.txt:
* inspector/console/console-assert-expected.txt:
* inspector/console/console-big-array-expected.txt:
* inspector/console/console-clear-expected.txt:
* inspector/console/console-command-clear-expected.txt:
* inspector/console/console-dir-expected.txt:
* inspector/console/console-dirxml-expected.txt:
* inspector/console/console-external-array-expected.txt:
* inspector/console/console-format-collections-expected.txt:
* inspector/console/console-format-expected.txt:
* inspector/console/console-log-before-inspector-open-expected.txt:
* inspector/console/console-log-document-proto-expected.txt:
* inspector/console/console-log-syntax-error-expected.txt:
* inspector/console/console-log-toString-object-expected.txt:
* inspector/console/console-nested-group-expected.txt:
* inspector/console/console-object-constructor-name-expected.txt:
* inspector/console/console-repeat-count-expected.txt:
* inspector/console/console-tests-expected.txt:
* inspector/console/console-trace-expected.txt:
* inspector/extensions/extensions-console-expected.txt:
* platform/chromium/http/tests/inspector/console-cross-origin-iframe-logging-expected.txt:
* platform/chromium/http/tests/inspector/console-resource-errors-expected.txt:
* platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
* platform/chromium/http/tests/inspector/network/script-as-text-loading-expected.txt:
* platform/chromium/inspector/console/alert-toString-exception-expected.txt:
* platform/chromium/inspector/console/console-dir-expected.txt:
* platform/chromium/inspector/console/console-format-collections-expected.txt:
* platform/chromium/inspector/console/console-format-expected.txt:
* platform/chromium/inspector/console/console-log-document-proto-expected.txt:
* platform/chromium/inspector/console/console-log-syntax-error-expected.txt:
* platform/chromium/inspector/console/console-object-constructor-name-expected.txt:
* platform/chromium/inspector/console/console-trace-in-eval-expected.txt:
* platform/chromium/inspector/console/console-uncaught-exception-expected.txt:
* platform/chromium/inspector/console/console-uncaught-exception-in-eval-expected.txt:
* platform/qt/inspector/console/console-format-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-03-14 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 14 Mar 2012 12:00:44 +0000 (12:00 +0000)]
2012-03-14  Nikolas Zimmermann  <nzimmermann@rim.com>

        External <use> xlink:href references do not work
        https://bugs.webkit.org/show_bug.cgi?id=12499

        Reviewed by Zoltan Herczeg.

        Rebaseline tests after r110676 using Generic RGB Profile on Lion, and update them after my fixes.
        Replace xml:id with id everywhere, to make the new tiny tests work.

        * platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt:
        * platform/mac/svg/batik/filters/feTile-expected.png:
        * platform/mac/svg/batik/filters/filterRegions-expected.png:
        * platform/mac/svg/batik/text/textEffect-expected.png:
        * platform/mac/svg/batik/text/textEffect3-expected.png:
        * platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png:
        * svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg:
        * svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t.svg:
        * svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg:
        * svg/custom/use-external-crash-expected.txt: Added.
        * svg/custom/use-external-crash.svg: Added.

2012-03-14  Nikolas Zimmermann  <nzimmermann@rim.com>

        External <use> xlink:href references do not work
        https://bugs.webkit.org/show_bug.cgi?id=12499

        Reviewed by Zoltan Herczeg.

        Follow-up fix after r110676.
        Assertions are firing due last minute changes in isExternalURIReference.

        Fix detecting local resources properly, when the given iri contains a /complex/path.
        Use document->completeURL() instead, and compare with the document->url() to decide
        if its a local reference or not.

        If an external document load fails with an error (eg. file missing) don't assert
        in debug builds, instead handle it gracefully.

        I decided to clean the code up as well, to make it more safe & obvious.

        Test: svg/custom/use-external-crash.svg

        * svg/SVGURIReference.cpp:
        (WebCore::SVGURIReference::targetElementFromIRIString):
        * svg/SVGURIReference.h:
        (WebCore::SVGURIReference::isExternalURIReference):
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::externalDocument):
        (WebCore::SVGUseElement::buildPendingResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago3D transformed surfaces with z>0 gets cropped
commit-queue@webkit.org [Wed, 14 Mar 2012 11:56:47 +0000 (11:56 +0000)]
3D transformed surfaces with z>0 gets cropped
https://bugs.webkit.org/show_bug.cgi?id=81009

Patch by Lars Knudsen <lars.knudsen@nokia.com> on 2012-03-14
Reviewed by Noam Rosenthal.

The scissor clipping in TextureMapperGL didn't take 3D transforms
into account when calculating the clipping region.
Now, it will bail out early if the transform is not affine.

No new tests. Tested by current compositing layout tests.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::beginScissorClip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Rebaseline after r110667.
ossy@webkit.org [Wed, 14 Mar 2012 11:47:36 +0000 (11:47 +0000)]
[Qt] Rebaseline after r110667.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-14
Reviewed by Csaba Osztrogonác.

* platform/qt/http/tests/security/cross-frame-access-put-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed. Add platform specific expectaions after r110593
kkristof@inf.u-szeged.hu [Wed, 14 Mar 2012 11:43:53 +0000 (11:43 +0000)]
[Qt] Unreviewed. Add platform specific expectaions after r110593
new file:   LayoutTests/platform/qt/svg/custom/delete-text-crash-expected.png
new file:   LayoutTests/platform/qt/svg/custom/delete-text-crash-expected.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed flakiness marking.
morrita@google.com [Wed, 14 Mar 2012 11:39:46 +0000 (11:39 +0000)]
Unreviewed flakiness marking.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed rebaselining expectations.
morrita@google.com [Wed, 14 Mar 2012 11:06:09 +0000 (11:06 +0000)]
Unreviewed rebaselining expectations.

* platform/chromium-linux/svg/batik/filters/feTile-expected.png:
* platform/chromium-linux/svg/batik/filters/feTile-expected.txt: Added.
* platform/chromium-linux/svg/batik/paints/gradientLimit-expected.png:
* platform/chromium-linux/svg/batik/paints/gradientLimit-expected.txt: Added.
* platform/chromium-linux/svg/batik/paints/patternRegionA-expected.png:
* platform/chromium-linux/svg/batik/paints/patternRegionA-expected.txt: Added.
* platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/longTextOnPath-expected.png:
* platform/chromium-linux/svg/batik/text/longTextOnPath-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textAnchor-expected.png:
* platform/chromium-linux/svg/batik/text/textAnchor-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textEffect-expected.png:
* platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
* platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textLayout-expected.png:
* platform/chromium-linux/svg/batik/text/textLayout-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textLength-expected.png:
* platform/chromium-linux/svg/batik/text/textLength-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.png:
* platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/textPosition2-expected.png:
* platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
* platform/chromium-linux/svg/batik/text/textProperties2-expected.png:
* platform/chromium-linux/svg/batik/text/textProperties2-expected.txt: Added.
* platform/chromium-linux/svg/batik/text/verticalText-expected.png:
* platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
* platform/chromium-mac-leopard/svg/batik/filters/feTile-expected.png:
* platform/chromium-mac-leopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textAnchor-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textEffect-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textEffect3-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textLayout-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textLength-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textOnPathSpaces-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textProperties2-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/verticalText-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/batik/filters/feTile-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/paints/gradientLimit-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/paints/patternRegionA-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/longTextOnPath-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/longTextOnPath-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/batik/text/textAnchor-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textEffect-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textEffect3-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textLayout-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textLength-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textOnPathSpaces-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textPosition2-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textProperties2-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/verticalText-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] svg/animations tests are very flaky
kkristof@inf.u-szeged.hu [Wed, 14 Mar 2012 10:44:51 +0000 (10:44 +0000)]
[Qt] svg/animations tests are very flaky
https://bugs.webkit.org/show_bug.cgi?id=80703

Unreviewd, skipp svg/animations/animate-elem-08-t-drt.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed, rebaseline after r110587.
kkristof@inf.u-szeged.hu [Wed, 14 Mar 2012 10:31:37 +0000 (10:31 +0000)]
[Qt] Unreviewed, rebaseline after r110587.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix.
morrita@google.com [Wed, 14 Mar 2012 10:11:30 +0000 (10:11 +0000)]
Unreviewed build fix.

* html/track/TextTrackList.cpp:
(TextTrackList::append):
(TextTrackList::remove):
(TextTrackList::owner): Changed return type from HTMLMediaElement* to Node* and uninlined.
* html/track/TextTrackList.h:
(TextTrackList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [InspectorIndexedDB] Remote object should be released when data view...
vsevik@chromium.org [Wed, 14 Mar 2012 10:04:33 +0000 (10:04 +0000)]
Web Inspector: [InspectorIndexedDB] Remote object should be released when data view is removed/updated.
https://bugs.webkit.org/show_bug.cgi?id=81022

Reviewed by Pavel Feldman.

* inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView):
(WebInspector.IDBDataView.prototype._updateData.callback):
(WebInspector.IDBDataView.prototype._updateData):
(WebInspector.IDBDataView.prototype.get statusBarItems):
(WebInspector.IDBDataView.prototype.clear):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.IndexedDBTreeElement.prototype._indexedDBRemoved):
(WebInspector.IDBDatabaseTreeElement.prototype.update):
(WebInspector.IDBDatabaseTreeElement.prototype.onselect):
(WebInspector.IDBDatabaseTreeElement.prototype._objectStoreRemoved):
(WebInspector.IDBDatabaseTreeElement.prototype.clear):
(WebInspector.IDBObjectStoreTreeElement.prototype.update):
(WebInspector.IDBObjectStoreTreeElement.prototype.onselect):
(WebInspector.IDBObjectStoreTreeElement.prototype._indexRemoved):
(WebInspector.IDBObjectStoreTreeElement.prototype.clear):
(WebInspector.IDBIndexTreeElement.prototype.onselect):
(WebInspector.IDBIndexTreeElement.prototype.clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed. Update expectaions after r110676
kkristof@inf.u-szeged.hu [Wed, 14 Mar 2012 10:02:17 +0000 (10:02 +0000)]
[Qt] Unreviewed. Update expectaions after r110676

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Introduce SnippetsScriptMapping.
vsevik@chromium.org [Wed, 14 Mar 2012 09:59:50 +0000 (09:59 +0000)]
Web Inspector: Introduce SnippetsScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=80890

Reviewed by Pavel Feldman.

* inspector/front-end/ScriptMapping.js:
(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.addScript):
(WebInspector.MainScriptMapping.prototype._mappingForScript):
* inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsModel.prototype.snippetForId):
(WebInspector.SnippetsModel.prototype.snippetForSourceURL):
(WebInspector.SnippetsScriptMapping):
(WebInspector.SnippetsScriptMapping.prototype.uiSourceCodeList):
(WebInspector.SnippetsScriptMapping.prototype.addScript):
(WebInspector.SnippetsScriptMapping.prototype._snippetAdded):
(WebInspector.SnippetsScriptMapping.prototype._releaseSnippetScript.get if):
(WebInspector.SnippetsScriptMapping.prototype._releaseSnippetScript):
(WebInspector.SnippetsScriptMapping.prototype._snippetDeleted.get this):
(WebInspector.SnippetsScriptMapping.prototype._snippetDeleted):
(WebInspector.SnippetsScriptMapping.prototype.reset):
(WebInspector.SnippetContentProvider):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK svg rebaseline after r110676.
philn@webkit.org [Wed, 14 Mar 2012 09:38:09 +0000 (09:38 +0000)]
Unreviewed, GTK svg rebaseline after r110676.

* platform/gtk/svg/batik/filters/feTile-expected.txt:
* platform/gtk/svg/batik/filters/filterRegions-expected.txt:
* platform/gtk/svg/batik/masking/maskRegions-expected.txt:
* platform/gtk/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
* platform/gtk/svg/batik/paints/patternRegionA-expected.txt:
* platform/gtk/svg/batik/paints/patternRegions-expected.txt:
* platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
* platform/gtk/svg/batik/text/longTextOnPath-expected.txt:
* platform/gtk/svg/batik/text/textAnchor-expected.txt:
* platform/gtk/svg/batik/text/textDecoration-expected.txt:
* platform/gtk/svg/batik/text/textEffect-expected.txt:
* platform/gtk/svg/batik/text/textEffect2-expected.txt:
* platform/gtk/svg/batik/text/textEffect3-expected.txt:
* platform/gtk/svg/batik/text/textFeatures-expected.txt:
* platform/gtk/svg/batik/text/textLayout-expected.txt:
* platform/gtk/svg/batik/text/textLayout2-expected.txt:
* platform/gtk/svg/batik/text/textLength-expected.txt:
* platform/gtk/svg/batik/text/textOnPath-expected.txt:
* platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt:
* platform/gtk/svg/batik/text/textPosition-expected.txt:
* platform/gtk/svg/batik/text/textPosition2-expected.txt:
* platform/gtk/svg/batik/text/textProperties-expected.txt:
* platform/gtk/svg/batik/text/textProperties2-expected.txt:
* platform/gtk/svg/batik/text/textStyles-expected.txt:
* platform/gtk/svg/batik/text/verticalText-expected.txt:
* platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/gtk/svg/hixie/error/014-expected.txt:
* platform/gtk/svg/hixie/use/002-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-03-14 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 14 Mar 2012 09:08:49 +0000 (09:08 +0000)]
2012-03-14  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Update two pixel test results on Lion, now svg/ passes with --tolerance 0 again.

        * platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
        * platform/mac/svg/hixie/mixed/003-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r110673.
commit-queue@webkit.org [Wed, 14 Mar 2012 09:01:47 +0000 (09:01 +0000)]
Unreviewed, rolling out r110673.
http://trac.webkit.org/changeset/110673
https://bugs.webkit.org/show_bug.cgi?id=81090

"Qt minimal build broken" (Requested by yurys on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14

* inspector/CodeGeneratorInspector.py:
(CommandReturnPassModel.ByPointer.get_set_return_condition):
(TypeModel.Enum.get_optional.EnumOptional.get_command_return_pass_model):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(Generator.process_event):
(Generator.process_command):
* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::buildObjectForSearchMatch):
(WebCore::ContentSearchUtils::searchInTextByLines):
* inspector/ContentSearchUtils.h:
(ContentSearchUtils):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::makeEvalCall):
* inspector/InjectedScript.h:
(InjectedScript):
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/InspectorPageAgent.cpp:
(WebCore::buildObjectForCookie):
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
* inspector/InspectorPageAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLast buildfix for Qt after r110595. :)
ossy@webkit.org [Wed, 14 Mar 2012 08:55:15 +0000 (08:55 +0000)]
Last buildfix for Qt after r110595. :)

Reviewed by Benjamin Poulain.

* Api/qwebpage.cpp:
* WebCoreSupport/GeolocationClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExternal <use> xlink:href references do not work
reni@webkit.org [Wed, 14 Mar 2012 08:52:35 +0000 (08:52 +0000)]
External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499

Reviewed by Nikolas Zimmermann.

Source/WebCore:

This is a follow-up patch after r108785.
In this patch we bind the previously introduced CachedSVGDocument class
into the caching mechanism of SVGUseElement. The mode how external resources
are handled is similar to the processing of internal ones. We build the instance
and shadow tree the same way but we have to keep in mind that the requested resources
maybe not loaded yet. We can check it with cachedDocumentIsStillLoading() function.

SVGURIReference::targetElementFromIRIString() also need to be extended. The baseURI
computation needs to take the referenced documents URL into account, instead of the current documents.

The patch affects a lot of tests which have external resources especially in svg/batik. Because
of the size of that test refactor they will be commited in a follow-up patch.

Tests: svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg
       svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t.svg
       svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg
       svg/custom/use-extern-href.svg
       svg/custom/use-referencing-an-image-expected.svg
       svg/custom/use-referencing-an-image.svg
       svg/custom/use-referencing-indirectly-itself-expected.svg
       svg/custom/use-referencing-indirectly-itself.svg
       svg/custom/use-referencing-itself-expected.svg
       svg/custom/use-referencing-itself.svg
       svg/dynamic-updates/SVGUseElement-dom-href1-attr.html
       svg/dynamic-updates/SVGUseElement-dom-href2-attr.html
       svg/dynamic-updates/SVGUseElement-svgdom-href1-prop.html
       svg/dynamic-updates/SVGUseElement-svgdom-href2-prop.html

* loader/cache/CachedResourceLoader.cpp:
(WebCore):
(WebCore::CachedResourceLoader::requestSVGDocument):
* loader/cache/CachedResourceLoader.h:
(WebCore):
(CachedResourceLoader):
* page/ContentSecurityPolicy.h:
* platform/KURL.cpp:
(WebCore::equalIgnoringFragmentIdentifier):
* platform/network/chromium/ResourceRequest.h:
* svg/SVGURIReference.cpp:
(WebCore::urlFromIRIStringWithFragmentIdentifier):
(WebCore):
(WebCore::SVGURIReference::targetElementFromIRIString):
* svg/SVGURIReference.h:
(SVGURIReference):
(WebCore::SVGURIReference::isExternalURIReference):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::~SVGUseElement):
(WebCore):
(WebCore::SVGUseElement::referencedDocument):
(WebCore::SVGUseElement::externalDocument):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::dumpInstanceTree):
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::hasCycleUseReferencing):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
(WebCore::SVGUseElement::notifyFinished):
(WebCore::SVGUseElement::cachedDocumentIsStillLoading):
(WebCore::SVGUseElement::instanceTreeIsLoading):
* svg/SVGUseElement.h:
(WebCore):
(SVGUseElement):

LayoutTests:

Adding tests to check the new functionality of SVGUseElement what can use
sources from external URIs too. New tests in this patch cover the corner cases
of this feature: referencing resources directly and indirectly, changing
the referenced URI from an internal to an external one, handling
security issues like self referencing, self referencing across document, etc.
Furthermore the patch infer some rebaseline in svg/batik directory because
they use external resources.

* platform/chromium/test_expectations.txt:
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Added.
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Added.
* platform/mac/svg/batik/filters/feTile-expected.png:
* platform/mac/svg/batik/filters/feTile-expected.txt:
* platform/mac/svg/batik/filters/filterRegions-expected.png:
* platform/mac/svg/batik/filters/filterRegions-expected.txt:
* platform/mac/svg/batik/masking/maskRegions-expected.png:
* platform/mac/svg/batik/masking/maskRegions-expected.txt:
* platform/mac/svg/batik/paints/gradientLimit-expected.png:
* platform/mac/svg/batik/paints/gradientLimit-expected.txt:
* platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
* platform/mac/svg/batik/paints/patternRegionA-expected.png:
* platform/mac/svg/batik/paints/patternRegionA-expected.txt:
* platform/mac/svg/batik/paints/patternRegions-expected.png:
* platform/mac/svg/batik/paints/patternRegions-expected.txt:
* platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
* platform/mac/svg/batik/text/longTextOnPath-expected.png:
* platform/mac/svg/batik/text/longTextOnPath-expected.txt:
* platform/mac/svg/batik/text/smallFonts-expected.png:
* platform/mac/svg/batik/text/smallFonts-expected.txt:
* platform/mac/svg/batik/text/textAnchor-expected.png:
* platform/mac/svg/batik/text/textAnchor-expected.txt:
* platform/mac/svg/batik/text/textDecoration-expected.png:
* platform/mac/svg/batik/text/textDecoration-expected.txt:
* platform/mac/svg/batik/text/textEffect-expected.png:
* platform/mac/svg/batik/text/textEffect-expected.txt:
* platform/mac/svg/batik/text/textEffect2-expected.png:
* platform/mac/svg/batik/text/textEffect2-expected.txt:
* platform/mac/svg/batik/text/textEffect3-expected.png:
* platform/mac/svg/batik/text/textEffect3-expected.txt:
* platform/mac/svg/batik/text/textFeatures-expected.png:
* platform/mac/svg/batik/text/textFeatures-expected.txt:
* platform/mac/svg/batik/text/textLayout-expected.png:
* platform/mac/svg/batik/text/textLayout-expected.txt:
* platform/mac/svg/batik/text/textLayout2-expected.png:
* platform/mac/svg/batik/text/textLayout2-expected.txt:
* platform/mac/svg/batik/text/textLength-expected.png:
* platform/mac/svg/batik/text/textLength-expected.txt:
* platform/mac/svg/batik/text/textOnPath-expected.png:
* platform/mac/svg/batik/text/textOnPath-expected.txt:
* platform/mac/svg/batik/text/textOnPathSpaces-expected.png:
* platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
* platform/mac/svg/batik/text/textPosition-expected.png:
* platform/mac/svg/batik/text/textPosition-expected.txt:
* platform/mac/svg/batik/text/textPosition2-expected.png:
* platform/mac/svg/batik/text/textPosition2-expected.txt:
* platform/mac/svg/batik/text/textProperties-expected.png:
* platform/mac/svg/batik/text/textProperties-expected.txt:
* platform/mac/svg/batik/text/textProperties2-expected.png:
* platform/mac/svg/batik/text/textProperties2-expected.txt:
* platform/mac/svg/batik/text/textStyles-expected.png:
* platform/mac/svg/batik/text/textStyles-expected.txt:
* platform/mac/svg/batik/text/verticalText-expected.png:
* platform/mac/svg/batik/text/verticalText-expected.txt:
* platform/mac/svg/batik/text/verticalTextOnPath-expected.png:
* platform/mac/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/mac/svg/custom/use-extern-href-expected.png: Added.
* platform/mac/svg/custom/use-extern-href-expected.txt: Added.
* platform/mac/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
* platform/mac/svg/hixie/error/014-expected.txt:
* platform/mac/svg/hixie/use/002-expected.png:
* platform/mac/svg/hixie/use/002-expected.txt:
* svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg: Added.
* svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t.svg: Added.
* svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t.svg: Added.
* svg/batik/filters/filterRegions.svg:
* svg/batik/text/textProperties.svg:
* svg/batik/text/textProperties2.svg:
* svg/batik/text/textStyles.svg:
* svg/custom/resources/rgb.svg:
* svg/custom/use-extern-href.svg: Added.
* svg/custom/use-referencing-an-image-expected.svg: Added.
* svg/custom/use-referencing-an-image.svg: Added.
* svg/custom/use-referencing-indirectly-itself-expected.svg: Added.
* svg/custom/use-referencing-indirectly-itself.svg: Added.
* svg/custom/use-referencing-itself-expected.svg: Added.
* svg/custom/use-referencing-itself.svg: Added.
* svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.txt: Added.
* svg/dynamic-updates/SVGUseElement-dom-href1-attr.html: Added.
* svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.txt: Added.
* svg/dynamic-updates/SVGUseElement-dom-href2-attr.html: Added.
* svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.txt: Added.
* svg/dynamic-updates/SVGUseElement-svgdom-href1-prop.html: Added.
* svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.txt: Added.
* svg/dynamic-updates/SVGUseElement-svgdom-href2-prop.html: Added.
* svg/dynamic-updates/script-tests/SVGUseElement-dom-href1-attr.js: Added.
(repaintTest):
* svg/dynamic-updates/script-tests/SVGUseElement-dom-href2-attr.js: Added.
(repaintTest):
* svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href1-prop.js: Added.
(repaintTest):
* svg/dynamic-updates/script-tests/SVGUseElement-svgdom-href2-prop.js: Added.
(repaintTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, skip a new failing inspector test in GTK and add new
philn@webkit.org [Wed, 14 Mar 2012 08:32:39 +0000 (08:32 +0000)]
Unreviewed, skip a new failing inspector test in GTK and add new
baseline for a svg test.

* platform/gtk/Skipped:
* platform/gtk/svg/custom/delete-text-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Wed, 14 Mar 2012 08:18:35 +0000 (08:18 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-14

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: TypeBuilder: Introduce OptOutput class for optional output parameters
commit-queue@webkit.org [Wed, 14 Mar 2012 08:04:18 +0000 (08:04 +0000)]
Web Inspector: TypeBuilder: Introduce OptOutput class for optional output parameters
https://bugs.webkit.org/show_bug.cgi?id=80789

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-03-14
Reviewed by Yury Semikhatsky.

OptOutput class is added for optional return parameters.

Strict mode added to Generator that makes all parameter types strict
and drop pre-set default values for return parameters.

Debugger and Page domain is switched to strict mode.

* inspector/CodeGeneratorInspector.py:
(CommandReturnPassModel.ByPointer):
(CommandReturnPassModel):
(CommandReturnPassModel.OptOutput):
(CommandReturnPassModel.OptOutput.__init__):
(CommandReturnPassModel.OptOutput.get_return_var_type):
(CommandReturnPassModel.OptOutput.get_output_argument_prefix):
(CommandReturnPassModel.OptOutput.get_output_to_raw_expression):
(CommandReturnPassModel.OptOutput.get_output_parameter_type):
(CommandReturnPassModel.OptOutput.get_set_return_condition):
(TypeModel.Enum.get_optional.EnumOptional.get_command_return_pass_model):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(OptOutput):
(Generator.process_event):
(Generator.process_command):
* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::buildObjectForSearchMatch):
(WebCore::ContentSearchUtils::searchInTextByLines):
* inspector/ContentSearchUtils.h:
(ContentSearchUtils):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::makeEvalCall):
* inspector/InjectedScript.h:
(InjectedScript):
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/InspectorPageAgent.cpp:
(WebCore::buildObjectForCookie):
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
* inspector/InspectorPageAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r110667.
philn@webkit.org [Wed, 14 Mar 2012 08:04:02 +0000 (08:04 +0000)]
Unreviewed, GTK rebaseline after r110667.

* platform/gtk/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Build fix for EFL after r110669.
sergio@webkit.org [Wed, 14 Mar 2012 07:32:07 +0000 (07:32 +0000)]
Unreviewed. Build fix for EFL after r110669.

* PlatformEfl.cmake: added DNSSoup.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Use the same DNS prefetching path than the other ports.
sergio@webkit.org [Wed, 14 Mar 2012 07:23:49 +0000 (07:23 +0000)]
[GTK] Use the same DNS prefetching path than the other ports.
https://bugs.webkit.org/show_bug.cgi?id=80997

Reviewed by Martin Robinson.

This patch basically reverts r56128. There is no need to add an
special code path for GTK+ DNS pre-fetching because the main
reason to do that (some potential changes in libsoup) is not
going to happen. It also reduces the amount of DNS queries by
adding a NULL hostname check.

No need for new tests as this just moves code around.

* GNUmakefile.list.am:
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):
* html/HTMLLinkElement.cpp:
* loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLink):
* page/Chrome.cpp:
(WebCore::Chrome::mouseDidMoveOverElement):
* platform/network/DNS.h:
(WebCore):
* platform/network/ResourceHandle.cpp:
* platform/network/ResourceHandle.h:
(ResourceHandle):
* platform/network/chromium/DNSChromium.cpp:
* platform/network/soup/DNSSoup.cpp: restored.
(WebCore):
(WebCore::prefetchDNS):
* platform/network/soup/ResourceHandleSoup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGTK 32-bit Linux Release build failing after r110580 (from bug 80338)
commit-queue@webkit.org [Wed, 14 Mar 2012 07:11:22 +0000 (07:11 +0000)]
GTK 32-bit Linux Release build failing after r110580 (from bug 80338)
https://bugs.webkit.org/show_bug.cgi?id=81063

Prospective build fix for GTK 32-bit Linux Release.

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-03-14
Reviewed by Martin Robinson.

* Source/autotools/symbols.filter: Adding symbol for ClientRectList(Vector<FloatQuad>) for
GTK 32-bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReturn null when shouldAllowAccessToNode() fails
haraken@chromium.org [Wed, 14 Mar 2012 07:06:03 +0000 (07:06 +0000)]
Return null when shouldAllowAccessToNode() fails
https://bugs.webkit.org/show_bug.cgi?id=80205

Reviewed by Adam Barth.

shouldAllowAccessToNode() is used for window.frameElement, HTMLFrameElement.contentDocument,
and getSVGDocument(). The spec of window.frameElement and HTMLFrameElement.contentDocument
requires that they should return null when the security check fails.
Thus this patch changes the return value from undefined to null.

http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#navigating-nested-browsing-contexts-in-the-dom
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#dom-iframe-contentdocument

Source/WebCore:

Tests: http/tests/security/local-iFrame-from-remote.html
       http/tests/security/cross-frame-access-frameelement.html
       http/tests/security/cross-frame-access-put.html

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallback):

* bindings/scripts/test/JS/JSTestObj.cpp: Updated run-bindings-tests results.
(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjPrototypeFunctionGetSVGDocument):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::contentDocumentAttrGetter):
(WebCore::TestObjInternal::getSVGDocumentCallback):

LayoutTests:

* http/tests/security/cross-frame-access-frameelement-expected.txt:
* http/tests/security/local-iFrame-from-remote.html:
* platform/chromium/http/tests/security/cross-frame-access-put-expected.txt:
* platform/gtk/http/tests/security/cross-frame-access-put-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, mark verifyCullChildLinesUpTopLeft() as failed.
morrita@google.com [Wed, 14 Mar 2012 07:02:49 +0000 (07:02 +0000)]
Unreviewed, mark verifyCullChildLinesUpTopLeft() as failed.

* tests/CCQuadCullerTest.cpp:
(WebCore):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: [Forms] Hidden input element should not have labels.
commit-queue@webkit.org [Wed, 14 Mar 2012 06:54:01 +0000 (06:54 +0000)]
Source/WebCore: [Forms] Hidden input element should not have labels.
https://bugs.webkit.org/show_bug.cgi?id=80403

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.

This patch changes "labels" attribute behavior for hidden input type.
It returns null instead of NodeList of labels or empty node list.

Note: The HTML5 specification isn't clear for non-labelable element's "labels"
attribute return value. Firefox and Opera return empty node list. IE returns null.

No new tests. Existing tests are updated.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isLabelable): Added. Dispatch to InputType.
* html/HiddenInputType.h:  Added isLabelable returning false.
* html/InputType.cpp:
(WebCore::InputType::isLabelable): Added. Returning true for all input types except for "hidden" type.
(WebCore):
* html/InputType.h:
(InputType): Added isLabelable declaration.

LayoutTests: [Forms] Hidden input element should not have labels.
https://bugs.webkit.org/show_bug.cgi?id=80403

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.

This patch changes expected text for null value of labels attribute
of hidden input type and labelable-elements to check null value for
the labels attribute of input type.

* fast/forms/label/labelable-elements-expected.txt:
* fast/forms/label/labelable-elements.html:
* fast/forms/label/labels-add-htmlFor-label-expected.txt:
* fast/forms/label/labels-add-parent-label-expected.txt:
* fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
* fast/forms/label/labels-multiple-sibling-labels-expected.txt:
* fast/forms/label/labels-parent-and-sibling-labels-expected.txt:
* fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
* fast/forms/label/labels-remove-htmlFor-label-expected.txt:
* fast/forms/label/labels-remove-parent-label-expected.txt:
* fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
* platform/chromium/fast/forms/label/labelable-elements-expected.txt:
* platform/mac/fast/forms/label/labelable-elements-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Forms] The "output" element should have labels.
commit-queue@webkit.org [Wed, 14 Mar 2012 06:35:49 +0000 (06:35 +0000)]
[Forms] The "output" element should have labels.
https://bugs.webkit.org/show_bug.cgi?id=80466

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-03-13
Reviewed by Kent Tamura.

Source/WebCore:

This patch enables functionality of "labels" attribute for
HTMLOutputElement implemented in LabelableElement which use
isLabelable predicate whether an element can have label or not.

Update existing tests in fast/forms/label/ directory to cover
the "output" element with the "labels" attribute.

* html/HTMLOutputElement.h: Implement virtual method isLabelable.

LayoutTests:

This patch updates expectation for functioning the "labels"
attribute of the "output" elements which was not working
so far.

* fast/forms/label/labelable-elements-expected.txt:
* fast/forms/label/labels-add-htmlFor-label-expected.txt:
* fast/forms/label/labels-add-parent-label-expected.txt:
* fast/forms/label/labels-change-htmlFor-attribute-expected.txt:
* fast/forms/label/labels-multiple-sibling-labels-expected.txt:
* fast/forms/label/labels-parent-and-sibling-labels-expected.txt:
* fast/forms/label/labels-remove-htmlFor-attribute-expected.txt:
* fast/forms/label/labels-remove-htmlFor-label-expected.txt:
* fast/forms/label/labels-remove-parent-label-expected.txt:
* fast/forms/label/labels-set-htmlFor-attribute-expected.txt:
* platform/chromium/fast/forms/label/labelable-elements-expected.txt:
* platform/mac/fast/forms/label/labelable-elements-expected.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, marking some tests flaky.
morrita@google.com [Wed, 14 Mar 2012 06:24:15 +0000 (06:24 +0000)]
Unreviewed, marking some tests flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove opacity clamping into RenderStyle setter.
macpherson@chromium.org [Wed, 14 Mar 2012 03:19:02 +0000 (03:19 +0000)]
Move opacity clamping into RenderStyle setter.
https://bugs.webkit.org/show_bug.cgi?id=76966

Reviewed by Eric Seidel.

Covered by existing tests.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::setOpacity):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoValueToInt32 speculation will cause OSR exits even when it does not have to
fpizlo@apple.com [Wed, 14 Mar 2012 02:54:58 +0000 (02:54 +0000)]
ValueToInt32 speculation will cause OSR exits even when it does not have to
https://bugs.webkit.org/show_bug.cgi?id=81068
<rdar://problem/11043926>

Reviewed by Anders Carlsson.

Two related changes:
1) ValueToInt32 will now always just defer to the non-speculative path, instead
   of exiting, if it doesn't know what speculations to perform.
2) ValueToInt32 will speculate boolean if it sees this to be profitable.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateBoolean):
(Node):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueToInt32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore Windows build fixing
mhahnenberg@apple.com [Wed, 14 Mar 2012 02:47:48 +0000 (02:47 +0000)]
More Windows build fixing

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix
mhahnenberg@apple.com [Wed, 14 Mar 2012 02:40:19 +0000 (02:40 +0000)]
Windows build fix

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoType conversion of exponential part failed
mhahnenberg@apple.com [Wed, 14 Mar 2012 02:12:25 +0000 (02:12 +0000)]
Type conversion of exponential part failed
https://bugs.webkit.org/show_bug.cgi?id=80673

Reviewed by Geoffrey Garen.

* parser/Lexer.cpp:
(JSC::::lex):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::parseInt):
(JSC):
(JSC::jsStrDecimalLiteral): Added another template argument that exposes whether or not
we accept trailing junk to clients of jsStrDecimalLiteral. Also added additional template
parameter for strtod to allow trailing spaces.
(JSC::toDouble):
(JSC::parseFloat): Accept trailing junk, as per the ECMA 262 spec (15.1.2.3).
* runtime/LiteralParser.cpp:
(JSC::::Lexer::lexNumber):
* tests/mozilla/expected.html: Update the expected page for run-javascriptcore-tests so that
we will run ecma/TypeConversion/9.3.1-3.js as a regression test now.
* wtf/dtoa.cpp:
(WTF):
(WTF::strtod): We also needed to sometimes accept trailing spaces to pass a few other tests that were
broken by changing the default allowance of trailing junk in jsStrDecimalLiteral.
* wtf/dtoa.h:
* wtf/dtoa/double-conversion.cc: When the AdvanceToNonspace function was lifted out of the
Chromium codebase, the person porting it only thought to check for spaces when skipping whitespace.
A few of our JSC tests check for other types of trailing whitespace, so I've added checks for those
here to cover those cases (horizontal tab, vertical tab, carriage return, form feed, and line feed).
* wtf/text/WTFString.cpp:
(WTF::toDoubleType): Disallow trailing spaces, as this breaks form input verification stuff.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSplit the extra logic out of RenderObjectChildList::updateBeforeAfterContent
igor.o@sisa.samsung.com [Wed, 14 Mar 2012 01:38:08 +0000 (01:38 +0000)]
Split the extra logic out of RenderObjectChildList::updateBeforeAfterContent
https://bugs.webkit.org/show_bug.cgi?id=80856

Extra part of the generated content handling logic out of RenderObjectChildList::updateBeforeAfterContent

Reviewed by Julien Chaffraix.

No change in behavior expected.

* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterStyle):
(WebCore::createRenderForBeforeAfterContent):
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
* rendering/RenderObjectChildList.h:
(WebCore):
(RenderObjectChildList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFREEEEEDOOM!!! Last set of bulk Chromium-Lion rebaselines.
ojan@chromium.org [Wed, 14 Mar 2012 01:37:58 +0000 (01:37 +0000)]
FREEEEEDOOM!!! Last set of bulk Chromium-Lion rebaselines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, build fix since is_pod<> includes some header that I didn't know about.
fpizlo@apple.com [Wed, 14 Mar 2012 01:26:38 +0000 (01:26 +0000)]
Unreviewed, build fix since is_pod<> includes some header that I didn't know about.
Removing the assert for now.

* dfg/DFGOperations.h:
* llint/LLIntSlowPaths.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFind bouncy doesn’t hide when a subframe is scrolled
andersca@apple.com [Wed, 14 Mar 2012 01:09:47 +0000 (01:09 +0000)]
Find bouncy doesn’t hide when a subframe is scrolled
https://bugs.webkit.org/show_bug.cgi?id=81060
<rdar://problem/9365329>

Reviewed by Andreas Kling.

Instead of hiding the find indicator when pageDidScroll is called, add a check to FindController::drawRect and hide
the find indicator there if the find selection bounds have changed since the last call to drawRect.

* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::drawRect):
* WebProcess/WebPage/FindController.h:
(FindController):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::pageDidScroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKitTestRunner needs a more-complete implementation of eventSender.
jberlin@webkit.org [Wed, 14 Mar 2012 01:07:29 +0000 (01:07 +0000)]
WebKitTestRunner needs a more-complete implementation of eventSender.
https://bugs.webkit.org/show_bug.cgi?id=42194

Skip yet another test that uses eventSender.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFunctions with C linkage should return POD types
fpizlo@apple.com [Wed, 14 Mar 2012 00:46:03 +0000 (00:46 +0000)]
Functions with C linkage should return POD types
https://bugs.webkit.org/show_bug.cgi?id=81061

Reviewed by Mark Rowe.

* dfg/DFGOperations.h:
* llint/LLIntSlowPaths.h:
(LLInt):
(SlowPathReturnType):
(JSC::LLInt::encodeResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove duplicate GC functions from layout tests
arv@chromium.org [Wed, 14 Mar 2012 00:36:34 +0000 (00:36 +0000)]
Remove duplicate GC functions from layout tests
https://bugs.webkit.org/show_bug.cgi?id=81047

Reviewed by Ojan Vafai.

* fast/canvas/webgl/shader-deleted-by-accessor.html:
* fast/dom/Window/customized-property-survives-gc.html:
* fast/dom/inline-event-attributes-lookup-removed-form.html:
* fast/dom/inline-event-attributes-lookup-removed.html:
* fast/dom/shadow/gc-shadow.html:
* fast/filesystem/resources/file-writer-gc-blob.js:
* fast/forms/input-image-submit.html:
* fast/forms/interactive-validation-remove-node-in-handler.html:
* fast/forms/select-set-length-with-mutation-remove.html:
* fast/js/resources/js-test-pre.js:
(gc.else.gcRec):
(gc):
* http/tests/websocket/tests/hixie76/close-on-unload-and-force-gc.html:
* http/tests/websocket/tests/hybi/close-on-unload-and-force-gc.html:
* webaudio/mediaelementaudiosourcenode-gc.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKitTestRunner needs layoutTestController.setEditingBehavior
jberlin@webkit.org [Wed, 14 Mar 2012 00:31:03 +0000 (00:31 +0000)]
WebKitTestRunner needs layoutTestController.setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=42689

Add more tests that use setEditingBehavior to the wk2 Skipped list.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed, rebaseline fast/canvas/canvas-text-alignment
enne@google.com [Wed, 14 Mar 2012 00:28:46 +0000 (00:28 +0000)]
[chromium] Unreviewed, rebaseline fast/canvas/canvas-text-alignment
https://bugs.webkit.org/show_bug.cgi?id=78529

After r110620, root layer scrollbars are drawn opaque, so they no
longer differ between debug and release due to alpha values.
Rebaselining this test.

* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago * platform/mac/fast/js/global-constructors-expected.txt: Added Selection...
ap@apple.com [Wed, 14 Mar 2012 00:27:01 +0000 (00:27 +0000)]
    * platform/mac/fast/js/global-constructors-expected.txt: Added Selection.toString and
        WebKitMutationObserver.toString.
        Selection got exposed in <http://trac.webkit.org/changeset/109306>, and
        WebKitMutationObserver was probably failing for even longer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix potential crash when loading test results
simon.fraser@apple.com [Wed, 14 Mar 2012 00:18:43 +0000 (00:18 +0000)]
Fix potential crash when loading test results
https://bugs.webkit.org/show_bug.cgi?id=81062
<rdar://problem/11041732>

Reviewed by Dean Jackson.

If RenderLayerBacking::isSimpleContainerCompositingLayer() is called early,
before the document has a documentElement(), then it crashes. Fix with
a null check on documentElement().

No test because it's timing dependent.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoplatform/mac/fast/forms/input-appearance-spinbutton(-up) fail on Lion
timothy_horton@apple.com [Wed, 14 Mar 2012 00:08:39 +0000 (00:08 +0000)]
platform/mac/fast/forms/input-appearance-spinbutton(-up) fail on Lion
https://bugs.webkit.org/show_bug.cgi?id=81058

Add unreviewed expected failing result (which may actually be correct) for mac.

* platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
* platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMediaStream is not enabled on Mac. Skip all related tests.
jberlin@webkit.org [Wed, 14 Mar 2012 00:06:53 +0000 (00:06 +0000)]
MediaStream is not enabled on Mac. Skip all related tests.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/11025225> Assertion failure in RenderView::computeRectForRepaint...
mitz@apple.com [Tue, 13 Mar 2012 23:58:59 +0000 (23:58 +0000)]
<rdar://problem/11025225> Assertion failure in RenderView::computeRectForRepaint() (!repaintContainer || repaintContainer == this) at store.apple.com
https://bugs.webkit.org/show_bug.cgi?id=81051

Reviewed by Simon Fraser.

.:

* ManualTests/inline-repaint-container.html: Added.

Source/WebCore:

Test: ManualTests/inline-repaint-container.html.

* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint): This function was not handling the
case of the repaint container being a descendant of the containing block correctly, leading
to the assertion failure, but also to a correctness bug seen in the new test. If the repaint
container is a descendant of the containing block, just return the rect in the repaint
container coordinates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/11025217> [Mac] Assertion failure in collectComplexTextRunsForCharact...
mitz@apple.com [Tue, 13 Mar 2012 23:57:32 +0000 (23:57 +0000)]
<rdar://problem/11025217> [Mac] Assertion failure in collectComplexTextRunsForCharactersCoreText
https://bugs.webkit.org/show_bug.cgi?id=77044

Reviewed by Sam Weinig.

Source/WebCore:

Test: platform/mac/fast/text/core-text-fallback-to-unknown-font.html

Handle the case of Core Text choosing a fallback font that NSFontManager cannot find by name.

* platform/graphics/FontCache.h:
(FontCache): Made ComplexTextController a friend class.
* platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Removed the
failing assertion, which was not true, and added code to handle the case where a font
cannot be found by name by using the font as returned from Core Text.

LayoutTests:

* platform/mac/fast/text/core-text-fallback-to-unknown-font-expected.txt: Added.
* platform/mac/fast/text/core-text-fallback-to-unknown-font.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Use v8::V8::AddImplicitReferences instead of SetHiddenValue
arv@chromium.org [Tue, 13 Mar 2012 23:56:45 +0000 (23:56 +0000)]
[V8] Use v8::V8::AddImplicitReferences instead of SetHiddenValue
https://bugs.webkit.org/show_bug.cgi?id=80880

Reviewed by Adam Barth.

Source/WebCore:

We used to add a hidden property in the getter to the returned wrapper.
With this patch we instead handle the liveness of the wrapper in the GC phase by
calling v8::V8::AddHiddenReference.

To reduce the amount of custom code we need, the V8 code generator now supports
GenerateIsReachable (as well as CustomIsReachable) which, even though different
from the JSC attribute, is used in the same cases and takes the same values (even though
at the moment not all JSC values are supported by V8). Interfaces that have *IsReachable
also have a dependent life time (just like if V8DependentLifetime was present).

Second try. This time with an added include in TextTrackList.cpp.

No new tests. Covered by existing tests.

* Target.pri:
* UseV8.cmake:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorJS.pm:
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(NeedsToVisitDOMWrapper):
(GetGenerateIsReachable):
(GetCustomIsReachable):
(GenerateVisitDOMWrapper):
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
* bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
* bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
* bindings/v8/V8GCController.cpp:
(WebCore::GrouperVisitor::visitDOMWrapper):
* bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WrapperTypeInfo):
* bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Removed.
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
* bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
* bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
* css/CSSStyleSheet.idl:
* css/StyleSheet.idl:
* dom/DOMStringMap.idl:
* dom/NamedNodeMap.idl:
* html/DOMTokenList.idl:
* html/track/TextTrackList.cpp:
* html/track/TextTrackList.idl:

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMathML crash in WebCore::Node::previousSibling()
commit-queue@webkit.org [Tue, 13 Mar 2012 23:45:53 +0000 (23:45 +0000)]
MathML crash in WebCore::Node::previousSibling()
https://bugs.webkit.org/show_bug.cgi?id=80773

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-03-13
Reviewed by Julien Chaffraix.

Source/WebCore:

When adding child for msub render, if the child is mtr or mtd render,
we will creat an anonymous render as the container. As the anonymous
render's node is 0, accessing it directly can cause crash.
We should do a valid check of the node before using. In addition to
that, for msub, attach the anonymous render and it's children to render
tree. For msubsup, such kind of situation should never happen based on
the current codebase.

Test: mathml/msub-anonymous-child-render-crash.html

* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::addChild):

LayoutTests:

* mathml/msub-anonymous-child-render-crash-expected.txt: Added.
* mathml/msub-anonymous-child-render-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSSRegions]NamedFlow::getRegionsByContentNode should not return a live NodeList
mihnea@adobe.com [Tue, 13 Mar 2012 23:43:07 +0000 (23:43 +0000)]
[CSSRegions]NamedFlow::getRegionsByContentNode should not return a live NodeList
https://bugs.webkit.org/show_bug.cgi?id=81021

Reviewed by Ryosuke Niwa.

Reverting the original patch as we need a better solution.

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Node.cpp:
(WebCore::NodeListsNodeData::invalidateCaches):
(WebCore::NodeListsNodeData::isEmpty):
* dom/Node.h:
(Node):
* dom/NodeRareData.h:
(NodeListsNodeData):
* dom/RegionNodeList.cpp: Removed.
* dom/RegionNodeList.h: Removed.
* dom/WebKitNamedFlow.cpp:
* dom/WebKitNamedFlow.h:
(WebKitNamedFlow):
* dom/WebKitNamedFlow.idl:
* rendering/RenderFlowThread.cpp:
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.h:
(RenderRegion):

LayoutTests:

* fast/regions/get-regions-by-content-node-expected.txt: Removed.
* fast/regions/get-regions-by-content-node-horiz-bt-expected.txt: Removed.
* fast/regions/get-regions-by-content-node-horiz-bt.html: Removed.
* fast/regions/get-regions-by-content-node-horiz-tb-expected.txt: Removed.
* fast/regions/get-regions-by-content-node-horiz-tb.html: Removed.
* fast/regions/get-regions-by-content-node-vert-lr-expected.txt: Removed.
* fast/regions/get-regions-by-content-node-vert-lr.html: Removed.
* fast/regions/get-regions-by-content-node-vert-rl-expected.txt: Removed.
* fast/regions/get-regions-by-content-node-vert-rl.html: Removed.
* fast/regions/get-regions-by-content-node.html: Removed.
* fast/regions/get-regions-by-content-node2-expected.txt: Removed.
* fast/regions/get-regions-by-content-node2.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSupport loading a WKPage from web archive data
jeffm@apple.com [Tue, 13 Mar 2012 23:39:11 +0000 (23:39 +0000)]
Support loading a WKPage from web archive data
https://bugs.webkit.org/show_bug.cgi?id=81044

This code was written by Jessie Berlin.

Reviewed by Brady Eidson.

* UIProcess/API/C/WKPage.cpp:
(WKPageLoadWebArchiveData): Added.

* UIProcess/API/C/WKPage.h: Added WKPageLoadWebArchiveData().

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadWebArchiveData): Added.

* UIProcess/WebPageProxy.h: Added loadWebArchiveData().

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadWebArchiveData): Added.

* WebProcess/WebPage/WebPage.h: Added loadWebArchiveData().

* WebProcess/WebPage/WebPage.messages.in: Added LoadWebArchiveData message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNote that this test is flaky. The flakiness dashboard says that this
abarth@webkit.org [Tue, 13 Mar 2012 23:31:50 +0000 (23:31 +0000)]
Note that this test is flaky.  The flakiness dashboard says that this
test has been flaky for a while.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a Leopard-specific baseline for
abarth@webkit.org [Tue, 13 Mar 2012 23:28:56 +0000 (23:28 +0000)]
Add a Leopard-specific baseline for
fast/forms/file/file-input-pressed-state and generalize the
chromium-win-vista baseline to include all of windows.

* platform/chromium-mac-leopard/fast/forms/file/file-input-pressed-state-expected.png: Added.
* platform/chromium-win-vista/fast/forms/file: Removed.
* platform/chromium-win-vista/fast/forms/file/file-input-pressed-state-expected.png: Removed.
* platform/chromium-win-xp/fast/forms/file: Removed.
* platform/chromium-win/fast/forms/file/file-input-pressed-state-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] wrong transform causing incorrect culling
shawnsingh@chromium.org [Tue, 13 Mar 2012 23:28:38 +0000 (23:28 +0000)]
[chromium] wrong transform causing incorrect culling
https://bugs.webkit.org/show_bug.cgi?id=80471

Reviewed by James Robinson.

Source/WebCore:

Unit test added to CCRenderSurfaceTest.cpp

In addition to using originTransform() instead of drawTransform(),
this patch shuffles a bit of code so that a unit test can be
easily added.

* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):

Source/WebKit/chromium:

* tests/CCRenderSurfaceTest.cpp:
(WebCore::TEST):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agomore multiline flexbox tests
tony@chromium.org [Tue, 13 Mar 2012 23:18:42 +0000 (23:18 +0000)]
more multiline flexbox tests
https://bugs.webkit.org/show_bug.cgi?id=81025

Reviewed by Ojan Vafai.

Add a test case for wrap-reverse to verify that we align with the end of the flexbox.

* css3/flexbox/multiline-reverse-wrap-overflow-expected.txt: Added.
* css3/flexbox/multiline-reverse-wrap-overflow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/loader/form-submission-after-beforeunload-cancel.html is flaky
darin@chromium.org [Tue, 13 Mar 2012 23:11:25 +0000 (23:11 +0000)]
fast/loader/form-submission-after-beforeunload-cancel.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=81024

Reviewed by Andy Estes.

* fast/loader/form-submission-after-beforeunload-cancel.html:
Give the form post a better chance of loading before the FAIL timer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAlternate xml-stylesheets with no title are loaded, in violation of the CSSOM draft
tomz@codeaurora.org [Tue, 13 Mar 2012 23:00:15 +0000 (23:00 +0000)]
Alternate xml-stylesheets with no title are loaded, in violation of the CSSOM draft
https://bugs.webkit.org/show_bug.cgi?id=77549

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-03-13
Reviewed by David Hyatt.

Source/WebCore:

Amended code to ignore alternate stylesheets that do not have a title attribute.

Test: fast/css/xml-stylesheet-alternate-no-title.xhtml

* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet):

LayoutTests:

Added new text test, modified existing test: added title attribute to alternate stylesheet.

* fast/css/xml-stylesheet-alternate-no-title-expected.txt: Added.
* fast/css/xml-stylesheet-alternate-no-title.xhtml: Added.
* fast/css/xml-stylesheet-alternate-processing.xhtml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLoads from UInt32Arrays should not result in a double up-convert if it isn't necessary
fpizlo@apple.com [Tue, 13 Mar 2012 22:59:43 +0000 (22:59 +0000)]
Loads from UInt32Arrays should not result in a double up-convert if it isn't necessary
https://bugs.webkit.org/show_bug.cgi?id=80979
<rdar://problem/11036848>

Reviewed by Oliver Hunt.

Also improved DFG IR dumping to include type information in a somewhat more
intuitive way.

* bytecode/PredictedType.cpp:
(JSC::predictionToAbbreviatedString):
(JSC):
* bytecode/PredictedType.h:
(JSC):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Input focus state should unfocus the frame selection instead of the...
commit-queue@webkit.org [Tue, 13 Mar 2012 22:57:43 +0000 (22:57 +0000)]
[BlackBerry] Input focus state should unfocus the frame selection instead of the field.
https://bugs.webkit.org/show_bug.cgi?id=81023

Patch by Mike Fenton <mifenton@rim.com> on 2012-03-13
Reviewed by Antonio Gomes.

PR 137400.

Prevent cursor drawing by unfocusing the frame selection
when input mode is not ready.

Greatly simplify the decision to focus input fields by removing
all ties to the page load state and base it on input.  Input mode
is disabled when a page load begins and enabled on any user input.

The field is focused and ready for input immediately, only the
frame selection (or cursor) is unfocused.

Reviewed Internally by Gen Mak, Antonio Gomes and Nima Ghanavatian.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
* Api/WebPageClient.h:
* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldBeginEditing):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::enableInputMode):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
(BlackBerry::WebKit::InputHandler::setComposingText):
* WebKitSupport/InputHandler.h:
(InputHandler):
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert RenderLayer::absoluteBoundingBox to an IntRect
leviw@chromium.org [Tue, 13 Mar 2012 22:53:35 +0000 (22:53 +0000)]
Revert RenderLayer::absoluteBoundingBox to an IntRect
https://bugs.webkit.org/show_bug.cgi?id=81017

Reviewed by Eric Seidel.

Reverting RenderLayer::absoluteBoundingBox to an (pixel snapped) IntRect. Whenever
possible, we use integers representing for absolute coordinates. This is especially
relevant for methods, such as this one, that are exported and used in platform code.

No new tests. No change in behavior.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::absoluteBoundingBox):
* rendering/RenderLayer.h:
(RenderLayer):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition): This intersects
the absolute bounding box with the FrameView, which uses all integer values. It's
the only use of absoluteBoundingBox in WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Adding missing results.
ap@apple.com [Tue, 13 Mar 2012 22:51:44 +0000 (22:51 +0000)]
    Adding missing results.

        * platform/mac/media/audio-repaint-expected.txt: Added.
        * platform/mac/media/controls-strict-expected.txt: Added.
        * platform/mac/media/video-controls-rendering-expected.txt: Added.
        * platform/mac/media/video-no-audio-expected.txt: Added.
        * platform/mac/media/video-display-toggle-expected.txt: Added.
        These already had PNG results, but no text results for platform/mac.

        * platform/mac/media/controls-layout-direction-expected.png: Added.
        * platform/mac/media/video-playing-and-pause-expected.png: Added.
        These had text results, but no pixel ones.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] vsync ticks are needed in invisible tabs when we are still updating resources
nduca@chromium.org [Tue, 13 Mar 2012 22:50:18 +0000 (22:50 +0000)]
[chromium] vsync ticks are needed in invisible tabs when we are still updating resources
https://bugs.webkit.org/show_bug.cgi?id=80910

Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::vsyncCallbackNeeded):

Source/WebKit/chromium:

* tests/CCSchedulerStateMachineTest.cpp:
(WebCore::TEST):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAlternate stylesheets (without title attribute) are loaded on refresh
commit-queue@webkit.org [Tue, 13 Mar 2012 22:40:16 +0000 (22:40 +0000)]
Alternate stylesheets (without title attribute) are loaded on refresh
https://bugs.webkit.org/show_bug.cgi?id=24354

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-03-13
Reviewed by David Hyatt.

Source/WebCore:

Alternate stylesheets are now ignored in <link> tags if
they have no title attribute (per spec).

Tests: fast/css/link-alternate-stylesheet-1.html
       fast/css/link-alternate-stylesheet-2.html
       fast/css/link-alternate-stylesheet-3.html
       fast/css/link-alternate-stylesheet-4.html
       fast/css/link-alternate-stylesheet-5.html

* dom/Document.cpp:
(WebCore::Document::collectActiveStylesheets):

LayoutTests:

Addapted alternate stylesheet tests from http://robballou.com/switcher/sandbox/alternate1.php

* fast/css/link-alternate-stylesheet-1-expected.txt: Added.
* fast/css/link-alternate-stylesheet-1.html: Added.
* fast/css/link-alternate-stylesheet-2-expected.txt: Added.
* fast/css/link-alternate-stylesheet-2.html: Added.
* fast/css/link-alternate-stylesheet-3-expected.txt: Added.
* fast/css/link-alternate-stylesheet-3.html: Added.
* fast/css/link-alternate-stylesheet-4-expected.txt: Added.
* fast/css/link-alternate-stylesheet-4.html: Added.
* fast/css/link-alternate-stylesheet-5-expected.txt: Added.
* fast/css/link-alternate-stylesheet-5.html: Added.
* fast/css/resources/basic.css: Added.
(body):
(code):
(#source):
* fast/css/resources/high.css: Added.
(body):
(h1):
* fast/css/resources/normal.css: Added.
(body):
(h1):
* fast/css/resources/small.css: Added.
(body):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWKTR needs an implementation of setAsynchronousSpellCheckingEnabled.
jberlin@webkit.org [Tue, 13 Mar 2012 22:36:05 +0000 (22:36 +0000)]
WKTR needs an implementation of setAsynchronousSpellCheckingEnabled.
https://bugs.webkit.org/show_bug.cgi?id=81042

Skip some tests on Mac WK2 that use setAsynchronousSpellCheckingEnabled.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRegion::contains(IntPoint) is slow
commit-queue@webkit.org [Tue, 13 Mar 2012 22:35:16 +0000 (22:35 +0000)]
Region::contains(IntPoint) is slow
https://bugs.webkit.org/show_bug.cgi?id=81008

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-13
Reviewed by Anders Carlsson.

Source/WebCore:

Speed up Region::contains(IntPoint) by directly testing if the point
is inside the Region's shape, rather than using a temporary 1x1 Region
for the test.

Unit test: RegionTest.containsPoint

* platform/graphics/Region.cpp:
(WebCore::Region::contains):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/RegionTest.cpp: Added.
(WebCore):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCopy the platform-independent result for this test to chromium-mac to
abarth@webkit.org [Tue, 13 Mar 2012 22:32:49 +0000 (22:32 +0000)]
Copy the platform-independent result for this test to chromium-mac to
hide the failing result added to apple-mac in
http://trac.webkit.org/changeset/110614.

* platform/chromium/fast/forms/label: Added.
* platform/chromium/fast/forms/label/labelable-elements-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFor some reason chromium-win and chromium-linux have a different number
abarth@webkit.org [Tue, 13 Mar 2012 22:21:52 +0000 (22:21 +0000)]
For some reason chromium-win and chromium-linux have a different number
of spaces in the expected results file.

* platform/chromium-win/media/sources-fallback-codecs-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMerge expectations for
abarth@webkit.org [Tue, 13 Mar 2012 22:13:30 +0000 (22:13 +0000)]
Merge expectations for
svg/as-background-image/svg-as-background-6.html.  Previously, Snow
Leopard had different expectations than every other platform, but the
behavior seems to match the expectations for other platforms.

Really what's going on is that this is a bad test for the reasons
explained in the test_expectations.txt file.  I'm not entirely sure how
to fix the test to have repeatable results.

This patch also notes some more compositing reflection tests as flaky,
similar to the failures in
https://bugs.webkit.org/show_bug.cgi?id=79823.  These tests have been
flaky for a while, but they seem to be failing more frequently now.  I
couldn't find any recent changes to explain why that might be.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Mark root layer scrollbars as always opaque to disable blending
enne@google.com [Tue, 13 Mar 2012 22:06:24 +0000 (22:06 +0000)]
[chromium] Mark root layer scrollbars as always opaque to disable blending
https://bugs.webkit.org/show_bug.cgi?id=79951

Reviewed by James Robinson.

Source/WebCore:

Now that scrollbar layers exist, mark non-overlay root scrollbars as
opaque. This disables blending for correctness and performance.

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::scrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawTileQuad):

LayoutTests:

Mark canvas-text-alignment.html as failing on Linux in general, not
just in debug. I believe that with this change, the same image will
pass on both release and debug, but will land that change separately.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][DRT] Expose window.internals object
commit-queue@webkit.org [Tue, 13 Mar 2012 21:59:21 +0000 (21:59 +0000)]
[EFL][DRT] Expose window.internals object
https://bugs.webkit.org/show_bug.cgi?id=79900

Exposes window.internals for EFL's DRT. Makes possible to
remove some tests from the skip list.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-03-13
Reviewed by Antonio Gomes.

Tools:

* DumpRenderTree/efl/CMakeLists.txt:
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onWindowObjectCleared):

LayoutTests:

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove vestigal abortEvent from image attribute.
gavinp@chromium.org [Tue, 13 Mar 2012 21:59:06 +0000 (21:59 +0000)]
Remove vestigal abortEvent from image attribute.
https://bugs.webkit.org/show_bug.cgi?id=80795

Reviewed by Adam Barth.

It seems we installed a listener for the abort event on images,
but never ever raised them.  So this patch removes it.  This could
cause different behaviour if the user sends abort events directly
at an image element, although addEventListener will still work.

* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe callback is only used if SA_RESTART is defined. Compile it out
staikos@webkit.org [Tue, 13 Mar 2012 21:52:27 +0000 (21:52 +0000)]
The callback is only used if SA_RESTART is defined.  Compile it out
otherwise to avoid a warning.
https://bugs.webkit.org/show_bug.cgi?id=80926

Reviewed by Alexey Proskuryakov.

* heap/MachineStackMarker.cpp:
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a mac-specific baseline for this new test introduced in
abarth@webkit.org [Tue, 13 Mar 2012 21:51:59 +0000 (21:51 +0000)]
Add a mac-specific baseline for this new test introduced in
http://trac.webkit.org/changeset/110593.  This test is interested in
whether it crashes, not in a 1px difference in text metrics.

* platform/chromium-mac-snowleopard/svg/custom/delete-text-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove bogus expectation.
abarth@webkit.org [Tue, 13 Mar 2012 21:48:14 +0000 (21:48 +0000)]
Remove bogus expectation.

* platform/chromium-mac/fast/dom/nodesFromRect-basic-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agor110542: New fast/forms/label/labelable-elements.html fails.
jberlin@webkit.org [Tue, 13 Mar 2012 21:43:01 +0000 (21:43 +0000)]
r110542: New fast/forms/label/labelable-elements.html fails.
https://bugs.webkit.org/show_bug.cgi?id=80985

Add failing expected results for Mac to get the bots green.

* platform/mac/fast/forms/label/labelable-elements-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd image baselines after http://trac.webkit.org/changeset/110598.
abarth@webkit.org [Tue, 13 Mar 2012 21:42:22 +0000 (21:42 +0000)]
Add image baselines after trac.webkit.org/changeset/110598.
These tests show the platform-specific file chooser UI.

* platform/chromium-linux-x86/fast/forms/file: Removed.
* platform/chromium-linux/fast/forms/file/file-input-pressed-state-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/file/file-input-pressed-state-expected.png: Added.
* platform/chromium-win-vista/fast/forms/file/file-input-pressed-state-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocss3/filters/custom/custom-filter-property-computed-style.html passes in browser...
timothy_horton@apple.com [Tue, 13 Mar 2012 21:37:15 +0000 (21:37 +0000)]
css3/filters/custom/custom-filter-property-computed-style.html passes in browser, fails in DRT
https://bugs.webkit.org/show_bug.cgi?id=81029
<rdar://problem/11040673>

Add unreviewed expected failing result for mac.

* platform/mac/css3/filters/custom/custom-filter-property-computed-style-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium-Lion rebaselines.
ojan@chromium.org [Tue, 13 Mar 2012 21:36:22 +0000 (21:36 +0000)]
Chromium-Lion rebaselines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAttempt to fix QtMinimal bot after r110595
benjamin@webkit.org [Tue, 13 Mar 2012 21:30:18 +0000 (21:30 +0000)]
Attempt to fix QtMinimal bot after r110595

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-13

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother attempt at fixing QtMinimal bot after r110595
benjamin@webkit.org [Tue, 13 Mar 2012 21:22:04 +0000 (21:22 +0000)]
Another attempt at fixing QtMinimal bot after r110595

Blind fix, unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-13

* WebCoreSupport/GeolocationClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Rework how a CachedRawResource decides if it can be reused
japhet@chromium.org [Tue, 13 Mar 2012 21:18:25 +0000 (21:18 +0000)]
Source/WebCore: Rework how a CachedRawResource decides if it can be reused
for a given ResourceRequest. Ensure method, body, cookie policy,
and all headers match.
http://bugs.webkit.org/show_bug.cgi?id=79325

Reviewed by Oliver Hunt.

Test: http/tests/cache/xhr-body.html

* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::canReuse):
* loader/cache/CachedRawResource.h: Take a ResourceRequest in canReuse().
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::determineRevalidationPolicy): Remove Range header
    check, since it is now redundant.

LayoutTests: Test for http://bugs.webkit.org/show_bug.cgi?id=79325.

Reviewed by Oliver Hunt.

* http/tests/cache/resources/body.php: Added.
* http/tests/cache/xhr-body-expected.txt: Added.
* http/tests/cache/xhr-body.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Updating some Mac results in media directory.
ap@apple.com [Tue, 13 Mar 2012 21:15:00 +0000 (21:15 +0000)]
    Updating some Mac results in media directory.

        * platform/chromium-mac/media/sources-fallback-codecs-expected.txt: Removed.
        * media/sources-fallback-codecs-expected.txt:
        Chromium result just matched what actually happened on Mac, so merging it into cross-platform.

        * platform/mac/media/audio-controls-rendering-expected.txt:
        * platform/mac/media/controls-after-reload-expected.txt:
        * platform/mac/media/media-controls-clone-expected.txt:
        * platform/mac/media/video-playing-and-pause-expected.txt:
        Updated for render tree changes. I'm getting the same results locally as buildbot does.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed rebaseline of fast/css/getComputedStyle/computed-style(without-renderer...
timothy_horton@apple.com [Tue, 13 Mar 2012 21:12:30 +0000 (21:12 +0000)]
Unreviewed rebaseline of fast/css/getComputedStyle/computed-style(without-renderer).html for mac, adding -webkit-grid-*

* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Added.
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDump the generated code for ARM_TRADITIONAL
commit-queue@webkit.org [Tue, 13 Mar 2012 21:10:47 +0000 (21:10 +0000)]
Dump the generated code for ARM_TRADITIONAL
https://bugs.webkit.org/show_bug.cgi?id=80975

Patch by Hojong Han <hojong.han@samsung.com> on 2012-03-13
Reviewed by Gavin Barraclough.

* assembler/LinkBuffer.h:
(JSC::LinkBuffer::dumpCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAttempt to fix QtMinimal bot after r110595
benjamin@webkit.org [Tue, 13 Mar 2012 21:06:44 +0000 (21:06 +0000)]
Attempt to fix QtMinimal bot after r110595

Blind fix, unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-13

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::resetGeolocationMock):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
* WebCoreSupport/GeolocationPermissionClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r110587.
philn@webkit.org [Tue, 13 Mar 2012 21:03:09 +0000 (21:03 +0000)]
Unreviewed, GTK rebaseline after r110587.

* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix cast-align GCC warning
rwlbuis@webkit.org [Tue, 13 Mar 2012 21:02:30 +0000 (21:02 +0000)]
Fix cast-align GCC warning
https://bugs.webkit.org/show_bug.cgi?id=80790

Reviewed by Dan Bates.

This touches unpackOneRowOfBGRA8ToRGBA8.

* platform/graphics/GraphicsContext3D.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactor some code that is used to check whether a layer needs backing store
simon.fraser@apple.com [Tue, 13 Mar 2012 20:59:59 +0000 (20:59 +0000)]
Refactor some code that is used to check whether a layer needs backing store
https://bugs.webkit.org/show_bug.cgi?id=80917

Reviewed by Dean Jackson.

Move some code out of isSimpleContainerCompositingLayer() in two new
methods to make the code more self-descriptive.

No behavior change, so no tests.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintsBoxDecorations):
(WebCore::RenderLayerBacking::paintsChildren):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement ApplicationCacheHost::canCacheInPageCache() for chromium.
gavinp@chromium.org [Tue, 13 Mar 2012 20:47:58 +0000 (20:47 +0000)]
Implement ApplicationCacheHost::canCacheInPageCache() for chromium.
https://bugs.webkit.org/show_bug.cgi?id=80905

Reviewed by Eric Seidel.

This won't cause chrome to use the PageCache, but it will cause our histogram statistics
describing PageCache use to be more accurate.

* src/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::canCacheInPageCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoToo many tests (200+ on SL, 80+ on Lion) tests are failing on Mac port
jchaffraix@webkit.org [Tue, 13 Mar 2012 20:30:24 +0000 (20:30 +0000)]
Too many tests (200+ on SL, 80+ on Lion) tests are failing on Mac port
https://bugs.webkit.org/show_bug.cgi?id=80447

Unreviewed test rebaseline after r110072.

* platform/mac/test_expectations.txt:
* platform/mac/Skipped:
Moved an entry from test_expectations.txt to Skipped as it was failing differently
that expected (same image, different text baseline).

* platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt:
* platform/mac/fast/block/lineboxcontain/glyphs-expected.txt:
* platform/mac/fast/clip/008-expected.txt:
* platform/mac/fast/forms/input-text-double-click-expected.txt:
* platform/mac/fast/repaint/overflow-delete-line-expected.txt:
Rebaselined those tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r99369): File input button doesn't highlight when pressed
dbates@webkit.org [Tue, 13 Mar 2012 20:15:53 +0000 (20:15 +0000)]
REGRESSION(r99369): File input button doesn't highlight when pressed
https://bugs.webkit.org/show_bug.cgi?id=79385

Reviewed by Kent Tamura.

Source/WebCore:

Fixes an issue where the file input button doesn't highlight on mouse press.

Currently we always override the active state of the button with whether
a dragged file is being hovered over the file input control (i.e. can the control
receive a dropped file; HTMLInputElement::canReceiveDroppedFiles()).
Instead, we should only override the active state of the button when the state
changes for whether we can receive dropped files (e.g. during a drag) so that
we honor the active state of the button when it is pressed.

Test: fast/forms/file/file-input-pressed-state.html

* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::RenderFileUploadControl):
(WebCore::RenderFileUploadControl::updateFromElement):
* rendering/RenderFileUploadControl.h:
(RenderFileUploadControl):

LayoutTests:

Add test to ensure that the file input button visually changes when pressed.

* fast/forms/file/file-input-pressed-state-expected.txt: Added.
* fast/forms/file/file-input-pressed-state.html: Added.
* platform/mac/fast/forms/file/file-input-pressed-state-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Use CCOcclusionTracker for draw culling
commit-queue@webkit.org [Tue, 13 Mar 2012 20:14:39 +0000 (20:14 +0000)]
[chromium] Use CCOcclusionTracker for draw culling
https://bugs.webkit.org/show_bug.cgi?id=80743

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-13
Reviewed by Adrienne Walker.

Source/WebCore:

In this CL we enable the use of CCOcclusionTracker for draw-side
culling. This means moving from a per-quad culling model to a
per-layer model.

When calculating RenderPasses, we construct the set of passes,
then iterate over layers in front-to-back order. We make
CCQuadCuller instantiable, and pass it to the layer
appendQuads() methods instead of the bare list, where it can
filter quads before the end up in the list.

Covered by existing tests.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawRenderPass):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
(CCCanvasLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::appendQuads):
(WebCore::CCLayerImpl::appendGutterQuads):
(WebCore::CCLayerImpl::appendDebugBorderQuad):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore):
(CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCPluginLayerImpl.h:
(CCPluginLayerImpl):
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::CCQuadCuller):
(WebCore::CCQuadCuller::append):
* platform/graphics/chromium/cc/CCQuadCuller.h:
(WebCore):
(CCQuadCuller):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForLayer):
* platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore):
(CCQuadList):
(WebCore::CCQuadList::backToFrontBegin):
(WebCore::CCQuadList::backToFrontEnd):
(CCRenderPass):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(CCScrollbarLayerImpl):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
(WebCore::CCSolidColorLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:
(CCSolidColorLayerImpl):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(CCVideoLayerImpl):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::BlendStateCheckLayer::appendQuads):
* tests/CCQuadCullerTest.cpp:
(TestCCOcclusionTrackerImpl):
(WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):
(WebCore::TestCCOcclusionTrackerImpl::layerScissorRectInTargetSurface):
(WebCore::makeLayer):
(WebCore::appendQuads):
(WebCore):
(WebCore::TEST):
* tests/CCSolidColorLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
* tests/CCTiledLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):
* tests/MockCCQuadCuller.h: Added.
(WebCore):
(MockCCQuadCuller):
(WebCore::MockCCQuadCuller::MockCCQuadCuller):
(WebCore::MockCCQuadCuller::append):
(WebCore::MockCCQuadCuller::quadList):

LayoutTests:

* platform/chromium-linux/compositing/direct-image-compositing-expected.png:
* platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAlways enable ENABLE(CLIENT_BASED_GEOLOCATION)
benjamin@webkit.org [Tue, 13 Mar 2012 20:10:27 +0000 (20:10 +0000)]
Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
https://bugs.webkit.org/show_bug.cgi?id=78853

Patch by Adam Barth  <abarth@webkit.org> && Benjamin Poulain <bpoulain@apple.com> on 2012-03-13
Reviewed by Adam Barth.

.:

* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsWinCE.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:

Source/WebCore:

* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Modules/geolocation/Geolocation.cpp:
(WebCore):
(WebCore::createPositionError):
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::stop):
(WebCore::Geolocation::lastPosition):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):
* Modules/geolocation/Geolocation.h:
(WebCore):
(Geolocation):
* Modules/geolocation/GeolocationController.cpp:
* Modules/geolocation/GeolocationController.h:
* Modules/geolocation/GeolocationError.h:
* Modules/geolocation/GeolocationPosition.h:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* bindings/js/JSGeolocationCustom.cpp:
* loader/EmptyClients.h:
(EmptyChromeClient):
* page/ChromeClient.h:
(ChromeClient):
* page/Page.cpp:
(WebCore::Page::Page):
* page/Page.h:
(Page):
* platform/GeolocationService.cpp: Removed.
* platform/GeolocationService.h: Removed.
* platform/mock/GeolocationClientMock.cpp:
* platform/mock/GeolocationClientMock.h:
* platform/mock/GeolocationServiceMock.cpp: Removed.
* platform/mock/GeolocationServiceMock.h: Removed.

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
* WebCoreSupport/AboutDataEnableFeatures.in:
* WebCoreSupport/ChromeClientBlackBerry.cpp:
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
* WebKitSupport/DumpRenderTreeSupport.cpp:
(toGeolocationClientMock):
(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):

Source/WebKit/chromium:

* features.gypi:
* src/ChromeClientImpl.cpp:
* src/ChromeClientImpl.h:
(ChromeClientImpl):

Source/WebKit/efl:

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore):
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit):
* WebCoreSupport/ChromeClientGtk.h:
(WebKit::ChromeClient::scrollRectIntoView):
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::resetGeolocationClientMock):
(DumpRenderTreeSupportGtk::setMockGeolocationPermission):
(DumpRenderTreeSupportGtk::setMockGeolocationPosition):
(DumpRenderTreeSupportGtk::setMockGeolocationError):
(DumpRenderTreeSupportGtk::numberOfPendingGeolocationPermissionRequests):
* WebCoreSupport/GeolocationClientGtk.cpp:
(WebKit::GeolocationClient::requestPermission):
(WebKit::GeolocationClient::cancelPermissionRequest):
* WebCoreSupport/GeolocationClientGtk.h:
(WebKit):
* webkit/webkitwebview.cpp:
(webkit_web_view_init):

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
* WebCoreSupport/WebGeolocationClient.mm:
(WebGeolocationClient::lastPosition):
* WebView/WebGeolocationPosition.mm:
(-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
(core):
(-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
* WebView/WebGeolocationPositionInternal.h:
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _geolocationDidChangePosition:]):
(-[WebView _geolocationDidFailWithError:]):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
* WebCoreSupport/ChromeClientQt.h:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(toGeolocationClientMock):
(DumpRenderTreeSupportQt::resetGeolocationMock):
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
(DumpRenderTreeSupportQt::setMockGeolocationError):
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
* WebCoreSupport/GeolocationClientQt.h:
(WebCore):

Source/WebKit/win:

* WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
* WebCoreSupport/WebGeolocationClient.cpp:
(WebGeolocationClient::lastPosition):
* WebGeolocationPosition.cpp:
(WebGeolocationPosition::initWithTimestamp):
(core):
* WebGeolocationPosition.h:
(WebGeolocationPosition):
(WebGeolocationPosition::impl):
* WebView.cpp:
(WebView::initWithFrame):
(WebView::geolocationDidChangePosition):
(WebView::geolocationDidFailWithError):

Source/WebKit/wince:

* WebCoreSupport/ChromeClientWinCE.cpp:
* WebCoreSupport/ChromeClientWinCE.h:
(ChromeClientWinCE):

Source/WebKit/wx:

* WebKitSupport/ChromeClientWx.cpp:
* WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:
* WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::registerWebPage):
(WebKit::WebGeolocationManager::unregisterWebPage):
(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setGeoLocationPermission):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit):
* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
* WebProcess/WebCoreSupport/WebGeolocationClient.cpp:
* WebProcess/WebCoreSupport/WebGeolocationClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
* mac/WebKit2.order:

Tools:

* Scripts/build-webkit:
* qmake/mkspecs/features/features.prf:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvert nodesFromRect tests to use Internals interface
tonikitoo@webkit.org [Tue, 13 Mar 2012 20:05:01 +0000 (20:05 +0000)]
Convert nodesFromRect tests to use Internals interface
https://bugs.webkit.org/show_bug.cgi?id=80886

Reviewed by Ryosuke Niwa.
Patch by Antonio Gomes <agomes@rim.com>

Source/WebCore:

Add Internals::nodesFromRect implementation to unify
the codepath for testing Document::nodesFromRect in a
cross port way.

No new tests, since we are improving here the infra-structure
for testing a specific method.

* testing/Internals.cpp:
(WebCore::Internals::nodesFromRect):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit/gtk:

Removed DRTSupportGtk::nodesFromRect support, since
it can work in the cross-port way through the
Internals interface.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Removed mac specific support for nodesFromRect for testing purposes only,
since it can work in a cross-port way through the Internals interface.

* WebKit.order:
* WebView/WebView.mm:
* WebView/WebViewPrivate.h:

Source/WebKit/qt:

Removed DRTSupportQt::nodesFromRect support, since
it can work in the cross-port way through the
Internals interface.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

This clean up allows to remove port specific bits of each
DRT implementation that supports testing Document::nodesFromRect,
in favor of making use of the 'Internals' interface to test it.

This makes its code conveniently more expansible and cleaner.

Also removed stubs from Win and EFL, Wn and BlackBerry DRTs.

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:

LayoutTests:

Adjust nodesFromRect tests to use Internals
instead of LayoutTestController interface.

* fast/dom/resources/nodesFromRect.js:
(check):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the use of stale text fragments
schenney@chromium.org [Tue, 13 Mar 2012 19:48:20 +0000 (19:48 +0000)]
Fix the use of stale text fragments
https://bugs.webkit.org/show_bug.cgi?id=80729

Patch by Philip Rogers <pdr@google.com> on 2012-03-13
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Previously, we were allowing SVGTextFragments to get out of sync with the
actual text in RenderSVGInlineTextBox. This patch reuses the dirty line
box code in RenderText::setTextWithOffset to force
clearTextFragments() when setTextWithOffset is called, preventing the use
of stale SVGTextFragments.

Test: svg/custom/delete-text-crash.html

* rendering/InlineBox.h:
(InlineBox):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::dirtyLineBoxes):
(WebCore):
* rendering/svg/SVGInlineTextBox.h:
(SVGInlineTextBox):

LayoutTests:

* svg/custom/delete-text-crash-expected.png: Added.
* svg/custom/delete-text-crash-expected.txt: Added.
* svg/custom/delete-text-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110593 268f45cc-cd09-0410-ab3c-d52691b4dbfc