ap [Fri, 6 Oct 2006 17:55:21 +0000 (17:55 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11183
REGRESSION: Safari loads error pages unstyled
* WebView/WebFrame.m:
(-[WebFrame _loadHTMLString:baseURL:unreachableURL:]):
Use utf-8 encoding instead of the string's "fastest" encoding.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 6 Oct 2006 12:25:52 +0000 (12:25 +0000)]
Reviewed by Tim H.
Patch for http://bugs.webkit.org/show_bug.cgi?id=11177
Another round of Objective-C SVG DOM bindings auto-generation
- Auto-generate DOMSVGAnimatedNumberList, DOMSVGAnimatedRect,
DOMSVGComponentTransferFunctionElement, DOMSVGFEBlendElement,
DOMSVGFEColorMatrixElement, DOMSVGFEComponentTransferElement,
DOMSVGFECompositeElement, DOMSVGFEDiffuseLightingElement,
DOMSVGFEDisplacementMapElement, DOMSVGFEDistantLightElement,
DOMSVGFEFloodElement, DOMSVGFEFuncAElement, DOMSVGFEFuncBElement,
DOMSVGFEFuncGElement, DOMSVGFEFuncRElement, DOMSVGFEGaussianBlurElement,
DOMSVGFEImageElement, DOMSVGFEMergeElement, DOMSVGFEMergeNodeElement,
DOMSVGFEOffsetElement, DOMSVGFEPointLightElement,
DOMSVGFESpecularLightingElement, DOMSVGFESpotLightElement,
DOMSVGFETileElement, DOMSVGFETurbulenceElement,
DOMSVGFilterPrimitiveStandardAttributes and DOMSVGNumberList.
- Adds interfaces and implementation stubs for DOMSVGNumber, DOMSVGPoint
and DOMSVGRect.
- IDL clean up.
- Make numOctaves in SVGFETurbulenceElement use a long instead of an int
in it's macro declaration and definition.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOMCSS.mm:
(+[DOMCSSValue _CSSValueWith:WebCore::]):
* bindings/objc/DOMInternal.h:
* bindings/objc/DOMSVG.h:
* bindings/objc/DOMSVGNumber.h: Added.
* bindings/objc/DOMSVGNumber.mm: Added.
(-[DOMSVGNumber dealloc]):
(-[DOMSVGNumber finalize]):
(-[DOMSVGNumber value]):
(-[DOMSVGNumber setValue:]):
(-[DOMSVGNumber _SVGNumber]):
(-[DOMSVGNumber _initWithFloat:]):
(+[DOMSVGNumber _SVGNumberWith:]):
* bindings/objc/DOMSVGPoint.h: Added.
* bindings/objc/DOMSVGPoint.mm: Added.
(-[DOMSVGPoint dealloc]):
(-[DOMSVGPoint finalize]):
(-[DOMSVGPoint x]):
(-[DOMSVGPoint setX:]):
(-[DOMSVGPoint y]):
(-[DOMSVGPoint setY:]):
(-[DOMSVGPoint WebCore::]):
(-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
(+[DOMSVGPoint _SVGPointWith:WebCore::]):
* bindings/objc/DOMSVGRect.h: Added.
* bindings/objc/DOMSVGRect.mm: Added.
(-[DOMSVGRect dealloc]):
(-[DOMSVGRect finalize]):
(-[DOMSVGRect x]):
(-[DOMSVGRect setX:]):
(-[DOMSVGRect y]):
(-[DOMSVGRect setY:]):
(-[DOMSVGRect width]):
(-[DOMSVGRect setWidth:]):
(-[DOMSVGRect height]):
(-[DOMSVGRect setHeight:]):
(-[DOMSVGRect WebCore::]):
(-[DOMSVGRect _initWithFloatRect:WebCore::]):
(+[DOMSVGRect _SVGRectWith:WebCore::]):
* bindings/scripts/CodeGeneratorObjC.pm:
* ksvg2/svg/SVGAnimatedNumberList.idl:
* ksvg2/svg/SVGAnimatedRect.idl:
* ksvg2/svg/SVGComponentTransferFunctionElement.idl:
* ksvg2/svg/SVGCursorElement.idl:
* ksvg2/svg/SVGFEBlendElement.idl:
* ksvg2/svg/SVGFEColorMatrixElement.idl:
* ksvg2/svg/SVGFEComponentTransferElement.idl:
* ksvg2/svg/SVGFECompositeElement.idl:
* ksvg2/svg/SVGFEDiffuseLightingElement.idl:
* ksvg2/svg/SVGFEDisplacementMapElement.idl:
* ksvg2/svg/SVGFEDistantLightElement.idl:
* ksvg2/svg/SVGFEFloodElement.idl:
* ksvg2/svg/SVGFEFuncAElement.idl:
* ksvg2/svg/SVGFEFuncBElement.idl:
* ksvg2/svg/SVGFEFuncGElement.idl:
* ksvg2/svg/SVGFEFuncRElement.idl:
* ksvg2/svg/SVGFEGaussianBlurElement.idl:
* ksvg2/svg/SVGFEImageElement.idl:
* ksvg2/svg/SVGFEMergeElement.idl:
* ksvg2/svg/SVGFEMergeNodeElement.idl:
* ksvg2/svg/SVGFEOffsetElement.idl:
* ksvg2/svg/SVGFEPointLightElement.idl:
* ksvg2/svg/SVGFESpecularLightingElement.idl:
* ksvg2/svg/SVGFESpotLightElement.idl:
* ksvg2/svg/SVGFETileElement.idl:
* ksvg2/svg/SVGFETurbulenceElement.cpp:
* ksvg2/svg/SVGFETurbulenceElement.h:
* ksvg2/svg/SVGFETurbulenceElement.idl:
* ksvg2/svg/SVGNumberList.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 6 Oct 2006 11:18:54 +0000 (11:18 +0000)]
Reviewed by Adam.
- fixed the following bugs:
http://bugs.webkit.org/show_bug.cgi?id=11136
"REGRESSION: Safari snippet editor doesn't work"
http://bugs.webkit.org/show_bug.cgi?id=11140
"REGRESSION: view source window blank"
http://bugs.webkit.org/show_bug.cgi?id=11146
"REGRESSION: Instead of showing the error page, Safari opens its Resources folder in the Finder"
Possibly more.
* Loader/WebDocumentLoadState.h:
* Loader/WebDocumentLoadState.m:
(-[WebDocumentLoadState actualRequest]): New method.
* WebView/WebDataSource.m:
(-[WebDataSource _startLoading]): We need to make sure not to start loading the main
resource with the fake external request for an applewebdata: request.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 6 Oct 2006 10:30:17 +0000 (10:30 +0000)]
Fix win32 bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 6 Oct 2006 10:28:22 +0000 (10:28 +0000)]
Fix win32 bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 6 Oct 2006 10:22:30 +0000 (10:22 +0000)]
Fix build bustage on many platforms by making sure the includes of ScrollBar stay the way they were.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 6 Oct 2006 10:18:40 +0000 (10:18 +0000)]
Backing out my previous change.
* WebCore.xcodeproj/project.pbxproj:
* page/FrameView.cpp:
(WebCore::FrameView::adjustViewSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 6 Oct 2006 10:17:27 +0000 (10:17 +0000)]
Fix build bustage like... everywhere.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 6 Oct 2006 10:06:48 +0000 (10:06 +0000)]
Build fix.
* WebCore.xcodeproj/project.pbxproj:
* page/FrameView.cpp:
(WebCore::FrameView::windowResizerRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 6 Oct 2006 10:01:54 +0000 (10:01 +0000)]
Fix win32 bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 6 Oct 2006 09:43:24 +0000 (09:43 +0000)]
Reviewed by Maciej.
More loader tweaks.
* platform/ResourceLoader.h:
* platform/ResourceLoaderInternal.h:
(WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
* platform/win/TemporaryLinkStubs.cpp:
(WebCore::ResourceLoader::newHTTPRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Fri, 6 Oct 2006 07:44:42 +0000 (07:44 +0000)]
2006-10-05 Steve Falkenburg <sfalken@apple.com>
Reviewed by aroben.
Stub out some methods that we'll be able to use to dodge a window resizer.
* bridge/win/FrameWin.h:
* page/Frame.h:
(WebCore::Frame::windowResizerRect):
* page/FrameView.h:
* platform/ScrollView.h:
(WebCore::ScrollView::windowResizerRect):
* platform/Widget.h:
* platform/win/TemporaryLinkStubs.cpp:
(FrameView::windowResizerRect):
(Widget::setParent):
(Widget::parent):
(FrameWin::windowResizerRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 6 Oct 2006 06:14:34 +0000 (06:14 +0000)]
Stub out setFrameGeometry.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 6 Oct 2006 05:30:09 +0000 (05:30 +0000)]
Temporary hack.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 6 Oct 2006 05:18:36 +0000 (05:18 +0000)]
Reverting autoscroll fix. I need to rework this a little.
* page/Frame.cpp:
(WebCore::Frame::handleAutoscroll):
(WebCore::Frame::autoscrollTimerFired):
(WebCore::Frame::stopAutoscrollTimer):
* page/Frame.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::~RenderLayer):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::~RenderListBox):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 6 Oct 2006 04:48:14 +0000 (04:48 +0000)]
2006-10-05 Oliver Hunt <ohunt@apple.com>
Reviewed by Anders.
* Scripts/run-webkit-tests:
Fix pixel tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Fri, 6 Oct 2006 03:57:08 +0000 (03:57 +0000)]
Reviewed by Adam.
Fixed <rdar://problem/
4731778>
* editing/CommandByName.cpp:
(WebCore::Frame::Command::):
was calling the wrong enabledFn for arrow selection and navigation
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 6 Oct 2006 03:34:36 +0000 (03:34 +0000)]
Reviewed by Maciej.
- Fix for <rdar://problem/
4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type="text">
and <rdar://problem/
4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
* rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): If the renderer is being autoscrolled, then stop the autoscroll timer.
* rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): ditto.
* page/Frame.cpp: Added getter and setter for the renderer being autoscrolled.
(WebCore::Frame::handleAutoscroll):
(WebCore::Frame::autoscrollTimerFired):
(WebCore::Frame::autoscrollRenderer):
(WebCore::Frame::setAutoscrollRenderer):
(WebCore::Frame::stopAutoscrollTimer):
* page/Frame.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 6 Oct 2006 02:48:36 +0000 (02:48 +0000)]
2006-10-05 Don Gibson <dgibson77@gmail.com>
Reviewed by Eric.
Fix win32 build bustage after ggaren's Scrollbar renaming changes.
Properly include PlatformScrollBar.h in WbCore.vcproj.
Clean up WidgetWin.cpp a bit.
* WebCore.vcproj/WebCore/WebCore.vcproj:
* platform/Widget.h:
* platform/win/PlatformScrollBar.h:
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
(WebCore::ScrollView::resizeContents):
(WebCore::ScrollView::scrollBy):
(WebCore::ScrollView::hScrollbarMode):
(WebCore::ScrollView::vScrollbarMode):
(WebCore::ScrollView::suppressScrollbars):
(WebCore::ScrollView::setHScrollbarMode):
(WebCore::ScrollView::setVScrollbarMode):
(WebCore::ScrollView::setScrollbarsMode):
(WebCore::ScrollView::updateScrollbars):
* platform/win/TemporaryLinkStubs.cpp:
(FrameView::passMousePressEventToScrollbar):
(Widget::removeFromParent):
(ScrollView::scrollbarUnderMouse):
(PlatformScrollbar::PlatformScrollbar):
(PlatformScrollbar::~PlatformScrollbar):
(PlatformScrollbar::width):
(PlatformScrollbar::height):
(PlatformScrollbar::setEnabled):
(PlatformScrollbar::paint):
(PlatformScrollbar::updateThumbPosition):
(PlatformScrollbar::updateThumbProportion):
(PlatformScrollbar::setRect):
(Scrollbar::Scrollbar):
(Scrollbar::setSteps):
(Scrollbar::scroll):
(Scrollbar::setValue):
(Scrollbar::setProportion):
* platform/win/WidgetWin.cpp:
(WebCore::WidgetPrivate::WidgetPrivate):
(WebCore::Widget::Widget):
(WebCore::Widget::setContainingWindow):
(WebCore::Widget::containingWindow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 6 Oct 2006 01:23:47 +0000 (01:23 +0000)]
Reviewed by the letter 'B'.
More build fixes.
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebDynamicScrollBarsView.h:
* WebView/WebDynamicScrollBarsView.m:
(-[WebDynamicScrollBarsView updateScrollers]):
(-[WebDynamicScrollBarsView setAllowsScrolling:]):
(-[WebDynamicScrollBarsView allowsScrolling]):
(-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
(-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]):
(-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
(-[WebDynamicScrollBarsView allowsVerticalScrolling]):
(-[WebDynamicScrollBarsView horizontalScrollingMode]):
(-[WebDynamicScrollBarsView verticalScrollingMode]):
(-[WebDynamicScrollBarsView setHorizontalScrollingMode:]):
(-[WebDynamicScrollBarsView setVerticalScrollingMode:]):
(-[WebDynamicScrollBarsView setScrollingMode:]):
* WebView/WebView.m:
(-[WebView setAlwaysShowVerticalScroller:]):
(-[WebView alwaysShowVerticalScroller]):
(-[WebView setAlwaysShowHorizontalScroller:]):
(-[WebView alwaysShowHorizontalScroller]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 6 Oct 2006 01:01:59 +0000 (01:01 +0000)]
build fix.
* WebCore.xcodeproj/project.pbxproj:
* bridge/mac/BrowserExtensionMac.mm:
(WebCore::BrowserExtensionMac::createNewWindow):
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::createFrame):
* bridge/mac/FrameViewMac.mm:
(WebCore::FrameView::passMousePressEventToScrollbar):
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge installInFrame:]):
* bridge/mac/WebCoreFrameView.h:
* platform/ScrollBar.cpp:
* platform/Widget.h:
* platform/mac/PlatformScrollBar.h:
* platform/mac/PlatformScrollBarMac.mm:
(NSControlSizeForScrollBarControlSize):
(-[WebCoreScrollBar initWithPlatformScrollbar:]):
(-[WebCoreScrollBar detachPlatformScrollbar]):
(-[WebCoreScrollBar scroll:]):
(-[WebCoreScrollBar widget]):
(WebCore::PlatformScrollbar::PlatformScrollbar):
(WebCore::PlatformScrollbar::~PlatformScrollbar):
(WebCore::PlatformScrollbar::updateThumbPosition):
(WebCore::PlatformScrollbar::updateThumbProportion):
(WebCore::PlatformScrollbar::scrollbarHit):
(WebCore::PlatformScrollbar::width):
(WebCore::PlatformScrollbar::height):
(WebCore::PlatformScrollbar::setRect):
(WebCore::PlatformScrollbar::setEnabled):
(WebCore::PlatformScrollbar::paint):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::setVScrollbarMode):
(WebCore::ScrollView::setHScrollbarMode):
(WebCore::ScrollView::setScrollbarsMode):
(WebCore::ScrollView::vScrollbarMode):
(WebCore::ScrollView::hScrollbarMode):
(WebCore::ScrollView::suppressScrollbars):
(WebCore::ScrollView::scrollbarUnderMouse):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::removeFromParent):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::destroyScrollbar):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 6 Oct 2006 00:02:40 +0000 (00:02 +0000)]
2006-10-05 Eric Seidel <eric@eseidel.com>
Reviewed by Tim H.
* coding/coding-style.html: use css styles, add example for whitespace, add example for c++ constructors
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Oct 2006 22:26:29 +0000 (22:26 +0000)]
2006-10-06 Mitz Pettel <mitz@webkit.org>
http://bugs.webkit.org/show_bug.cgi?id=8276
Fix broken manual test added back in r13990.
Add resource forks for test resources.
* manual-tests/resources/plain-text-paste/._1.textClipping: Added.
* manual-tests/resources/plain-text-paste/._2.textClipping: Added.
* manual-tests/resources/plain-text-paste/._4.txt: Added.
* manual-tests/resources/plain-text-paste/._5.webloc: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 5 Oct 2006 22:14:49 +0000 (22:14 +0000)]
Rename addClip to clip.
Reviewed by darin
* kcanvas/RenderForeignObject.cpp:
(WebCore::RenderForeignObject::paint):
* kcanvas/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
* kcanvas/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
* platform/GraphicsContext.h:
* platform/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::clip):
* platform/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::addRoundedRectClip):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::concatCTM):
* platform/cg/GraphicsContextPlatformPrivate.h:
(WebCore::GraphicsContextPlatformPrivate::save):
(WebCore::GraphicsContextPlatformPrivate::restore):
(WebCore::GraphicsContextPlatformPrivate::clip):
(WebCore::GraphicsContextPlatformPrivate::scale):
(WebCore::GraphicsContextPlatformPrivate::rotate):
(WebCore::GraphicsContextPlatformPrivate::translate):
(WebCore::GraphicsContextPlatformPrivate::concatCTM):
* platform/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::addRoundedRectClip):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBackground):
(WebCore::InlineFlowBox::paintBackgroundAndBorder):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintTextMatchMarker):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBackgroundExtended):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::paintObject):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::beginTransparencyLayers):
(WebCore::setClip):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintObject):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::paintObject):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Oct 2006 22:03:43 +0000 (22:03 +0000)]
2006-10-05 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- http://bugs.webkit.org/show_bug.cgi?id=10386
Delete RenderImageButton.* and remove references from .vcproj and .bkl files
* CMakeLists.txt:
* WebCore.vcproj/WebCore/WebCore.vcproj:
* WebCoreSources.bkl:
* rendering/RenderImageButton.cpp: Removed.
* rendering/RenderImageButton.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Oct 2006 21:56:17 +0000 (21:56 +0000)]
2006-10-05 Mitz Pettel <opendarwin.org@mitzpettel.com>
Reviewed by Darin.
- http://bugs.webkit.org/show_bug.cgi?id=11067
manual-tests/scrollbar-hittest2.html is invalid
* manual-tests/scrollbar-hittest2.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Oct 2006 21:53:59 +0000 (21:53 +0000)]
2006-10-05 Vladimir Olexa <vladimir.olexa@gmail.com>
Reviewed by Timothy.
Bug: http://bugs.webkit.org/show_bug.cgi?id=9887
Continuous spell checking now remembers user's setting. The change is applied globally,
meaning, both TextArea and TextField are affected when either of them enables/disables
spell checking.
* WebView/WebPreferenceKeysPrivate.h: added a define for WebContinuousSpellCheckingEnabled
* WebView/WebView.m:
(-[WebViewPrivate init]): reads WebContinuousSpellCheckingEnabled from NSUserDefaults
(-[WebView setContinuousSpellCheckingEnabled:]):
(-[WebView isContinuousSpellCheckingEnabled]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Oct 2006 21:43:22 +0000 (21:43 +0000)]
2006-10-05 MorganL <morganl.webkit@yahoo.com>
Reviewed by Darin.
Fixes http://bugs.webkit.org/show_bug.cgi?id=11162
* COM/WebFrame.cpp:
(WebFrame::loadDataSource):
(WebFrame::receivedResponse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Oct 2006 21:40:04 +0000 (21:40 +0000)]
2006-10-05 David Carson <dacarson@gmail.com>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11152
Adjust the tokenizer chunk size to be smaller for
mobile devices, and also decrease the yield timer
for the tokenizer so that it can resume earlier.
* html/HTMLTokenizer.cpp:
* config.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Oct 2006 21:38:44 +0000 (21:38 +0000)]
Removing accidentally-checked-in do-nothing code.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Oct 2006 21:35:58 +0000 (21:35 +0000)]
2006-10-05 David Carson <dacarson@gmail.com>
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=11158
Initialize class variables
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Oct 2006 20:27:50 +0000 (20:27 +0000)]
2006-10-05 Don Gibson <dgibson77@gmail.com>
WebCore:
Reviewed by Darin, landed by Adam.
http://bugs.webkit.org/show_bug.cgi?id=11176
Fix win32 build, adapt to Maciej's ResourceLoader changes.
* platform/win/ResourceLoaderWin.cpp:
(WebCore::ResourceLoader::start):
WebKit:
Reviewed by Darin, landed by Adam.
http://bugs.webkit.org/show_bug.cgi?id=11176
Fix win32 build, adapt to Maciej's ResourceLoader changes.
* COM/WebFrame.cpp:
(WebFrame::loadDataSource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 5 Oct 2006 20:22:47 +0000 (20:22 +0000)]
2006-10-05 Marvin Decker <marv.decker@gmail.com>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=10989
Provide a way for embedders to implement BrowserExtensionWin
WebCore:
* WebCore.vcproj/WebCore/WebCore.vcproj:
* bridge/win/BrowserExtensionWin.cpp: Added.
(BrowserExtensionWin::BrowserExtensionWin):
(BrowserExtensionWin::setTypedIconURL):
(BrowserExtensionWin::setIconURL):
(BrowserExtensionWin::getHistoryLength):
(BrowserExtensionWin::canRunModal):
(BrowserExtensionWin::createNewWindow):
(BrowserExtensionWin::canRunModalNow):
(BrowserExtensionWin::runModal):
(BrowserExtensionWin::goBackOrForward):
(BrowserExtensionWin::historyURL):
* bridge/win/BrowserExtensionWin.h:
* bridge/win/FrameWin.cpp:
(WebCore::FrameWin::createNewWindow):
* bridge/win/FrameWin.h:
* platform/win/TemporaryLinkStubs.cpp:
WebKit:
* COM/Interfaces/IWebUIDelegate.idl:
* COM/WebFrame.cpp:
(WebFrame::createNewWindow):
* COM/WebFrame.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 5 Oct 2006 19:59:28 +0000 (19:59 +0000)]
Reviewed by Darin.
Fixed <rdar://problem/
4766987>
- renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case
except for file names.
- fixed RenderLayer to properly tear down scrollbars, removing them from
their parents.
* bindings/js/kjs_window.cpp:
(KJS::showModalDialog):
(KJS::setWindowFeature):
(KJS::parseWindowFeatures):
* bridge/BrowserExtension.h:
* dom/Document.cpp:
(WebCore::Document::setInPageCache):
* html/HTMLFrameElement.cpp:
(WebCore::HTMLFrameElement::init):
(WebCore::HTMLFrameElement::parseMappedAttribute):
* html/HTMLFrameElement.h:
(WebCore::HTMLFrameElement::scrollingMode):
* page/Frame.cpp:
(WebCore::Frame::finishedParsing):
(WebCore::Frame::scrollbarsVisible):
* page/FrameView.cpp:
(WebCore::FrameViewPrivate::FrameViewPrivate):
(WebCore::FrameViewPrivate::reset):
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::resetScrollbars):
(WebCore::FrameView::clear):
(WebCore::FrameView::initScrollbars):
(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::layout):
(WebCore::FrameView::handleMousePressEvent):
(WebCore::selectCursor):
(WebCore::FrameView::handleMouseMoveEvent):
(WebCore::FrameView::setScrollbarsMode):
(WebCore::FrameView::setVScrollbarMode):
(WebCore::FrameView::setHScrollbarMode):
(WebCore::FrameView::restoreScrollbar):
(WebCore::FrameView::dispatchMouseEvent):
(WebCore::FrameView::scrollbarMoved):
* page/FrameView.h:
* page/MouseEventWithHitTestResults.cpp:
(WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
* page/MouseEventWithHitTestResults.h:
(WebCore::MouseEventWithHitTestResults::scrollbar):
* platform/ScrollBar.cpp:
(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::setValue):
(WebCore::Scrollbar::setProportion):
(WebCore::Scrollbar::setSteps):
(WebCore::Scrollbar::scroll):
* platform/ScrollBar.h:
(WebCore::):
(WebCore::ScrollbarClient::~ScrollbarClient):
(WebCore::Scrollbar::~Scrollbar):
(WebCore::Scrollbar::orientation):
(WebCore::Scrollbar::controlSize):
(WebCore::Scrollbar::hasPlatformScrollbars):
(WebCore::Scrollbar::client):
* platform/ScrollBarMode.h:
(WebCore::):
* platform/ScrollView.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::isPointInScrollbar):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::horizontaScrollbarWidget):
(WebCore::RenderLayer::verticalScrollbarWidget):
(WebCore::RenderLayer::valueChanged):
(WebCore::RenderLayer::createScrollbar):
(WebCore::RenderLayer::destroyScrollbar):
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
(WebCore::RenderLayer::verticalScrollbarWidth):
(WebCore::RenderLayer::horizontalScrollbarHeight):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::horizontalScrollbar):
(WebCore::RenderLayer::verticalScrollbar):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::~RenderListBox):
(WebCore::RenderListBox::calcMinMaxWidth):
(WebCore::RenderListBox::isPointInScrollbar):
(WebCore::RenderListBox::optionAtPoint):
(WebCore::RenderListBox::valueChanged):
* rendering/RenderListBox.h:
* rendering/RenderObject.h:
(WebCore::RenderObject::NodeInfo::scrollbar):
(WebCore::RenderObject::NodeInfo::setScrollbar):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 5 Oct 2006 19:58:23 +0000 (19:58 +0000)]
2006-10-04 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
* Scripts/run-webkit-tests:
Add an environment variable, WebKitExpectedTestResultsDirectory, which controls where expected test
results should be.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 5 Oct 2006 19:38:48 +0000 (19:38 +0000)]
2006-10-05 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by ap.
Cmake: make it possible to install the libraries after having built using 'build-webkit'.
Just set the "WebKitInstallationPrefix" environment variable to your desired prefix.
* Scripts/webkitdirs.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 5 Oct 2006 17:57:20 +0000 (17:57 +0000)]
2006-10-05 Don Gibson <dgibson77@gmail.com>
Reviewed by Adam.
http://bugs.webkit.org/show_bug.cgi?id=11138
Incorrect mouse event generation on Windows
* platform/win/MouseEventWin.cpp:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
(1) Set mouse button even for non-click-related messages.
(2) Track clicks correctly for all buttons, not just the left button.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 5 Oct 2006 17:48:53 +0000 (17:48 +0000)]
2006-10-05 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by ap.
Fix Qt/Linux build, adapt to Eric's Quartz changes and to Maciej's ResourceLoader changes.
* kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
(WebCore::KRenderingPaintServerLinearGradientQt::renderPath):
(WebCore::KRenderingPaintServerLinearGradientQt::setup):
(WebCore::KRenderingPaintServerRadialGradientQt::setup):
(WebCore::KRenderingPaintServerRadialGradientQt::renderPath):
* kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
(WebCore::KRenderingPaintServerPatternQt::renderPath):
* kcanvas/device/qt/KRenderingPaintServerQt.cpp:
(WebCore::KRenderingPaintServerQt::setPenProperties):
* kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
(WebCore::KRenderingPaintServerSolidQt::setup):
(WebCore::KRenderingPaintServerSolidQt::renderPath):
* kcanvas/device/qt/RenderPathQt.cpp:
(WebCore::getPathStroke):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 5 Oct 2006 17:20:04 +0000 (17:20 +0000)]
Reviewed by Kevin McCullough.
* wtf/Assertions.cpp: Fix build when _DEBUG is not defined.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 5 Oct 2006 16:44:15 +0000 (16:44 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11054
REGRESSION: Traditional Chinese encoding in login authentication
1. Treat GB2312 encoding as GBK (its more modern superset), to match other browsers.
2. On the Web, GB2312 is encoded as EUC-CN or HZ, while ICU provides a native encoding
for encoding GB_2312-80 and several others. So, we need to override this behavior, too.
WebCore:
* platform/StreamingTextDecoderICU.cpp:
(WebCore::TextCodecICU::registerEncodingNames):
LayoutTests:
Each of these tests is passed by Firefox 1.5 and/or WinIE 6.
* fast/encoding/GBK/EUC-CN-expected.txt: Added.
* fast/encoding/GBK/EUC-CN.html: Added.
* fast/encoding/GBK/chinese-expected.txt: Added.
* fast/encoding/GBK/chinese.html: Added.
* fast/encoding/GBK/cn-gb-expected.txt: Added.
* fast/encoding/GBK/cn-gb.html: Added.
* fast/encoding/GBK/csgb2312-expected.txt: Added.
* fast/encoding/GBK/csgb2312.html: Added.
* fast/encoding/GBK/csgb231280-expected.txt: Added.
* fast/encoding/GBK/csgb231280.html: Added.
* fast/encoding/GBK/gb2312-expected.txt: Added.
* fast/encoding/GBK/gb2312.html: Added.
* fast/encoding/GBK/gb_2312-80-expected.txt: Added.
* fast/encoding/GBK/gb_2312-80.html: Added.
* fast/encoding/GBK/gbk-expected.txt: Added.
* fast/encoding/GBK/gbk.html: Added.
* fast/encoding/GBK/iso-ir-58-expected.txt: Added.
* fast/encoding/GBK/iso-ir-58.html: Added.
* fast/encoding/GBK/x-euc-cn-expected.txt: Added.
* fast/encoding/GBK/x-euc-cn.html: Added.
* fast/encoding/GBK/x-gbk-expected.txt: Added.
* fast/encoding/GBK/x-gbk.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Thu, 5 Oct 2006 13:59:14 +0000 (13:59 +0000)]
2006-10-05 Eric Seidel <eric@eseidel.com>
Reviewed by mjs.
Removed dead code.
Filed http://bugs.webkit.org/show_bug.cgi?id=11167 to for followup on removed FIXMEs
* WebCore.xcodeproj/project.pbxproj:
* ksvg2/ecma/GlobalObject.cpp: Removed.
* ksvg2/ecma/GlobalObject.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Oct 2006 13:54:20 +0000 (13:54 +0000)]
Reviewed by Maciej.
Small ResourceLoaderInternal tweak.
* platform/ResourceLoaderInternal.h:
(WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Thu, 5 Oct 2006 13:52:39 +0000 (13:52 +0000)]
2006-10-05 Eric Seidel <eric@eseidel.com>
Reviewed by mjs.
More incremental KCanvas cleanup and optimization.
Added SVGRenderStyle::hasFill() and hasStroke() removed more KSVGPainterFactory methods.
Optimized dash array usage to not malloc.
Also removed un-needed KSVGRenderingStyle includes.
* kcanvas/KCanvasTreeDebug.cpp:
(WebCore::operator<<):
* kcanvas/RenderPath.cpp:
(WebCore::RenderPath::nodeAtPoint):
* kcanvas/device/quartz/KCanvasItemQuartz.mm:
(WebCore::RenderPath::strokeBBox):
* kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
(WebCore::KRenderingPaintServerGradientQuartz::setup):
(WebCore::KRenderingPaintServerGradientQuartz::renderPath):
(WebCore::KRenderingPaintServerGradientQuartz::teardown):
* kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
(WebCore::KRenderingPaintServerSolidQuartz::setup):
(WebCore::KRenderingPaintServerSolidQuartz::renderPath):
(WebCore::KRenderingPaintServerPatternQuartz::setup):
(WebCore::KRenderingPaintServerPatternQuartz::renderPath):
* kcanvas/device/quartz/QuartzSupport.mm:
(WebCore::applyStrokeStyleToContext):
* ksvg2/css/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::hasStroke):
(WebCore::SVGRenderStyle::hasFill):
* ksvg2/misc/KCanvasRenderingStyle.cpp:
(WebCore::KSVGPainterFactory::fillPaintServer):
(WebCore::KSVGPainterFactory::strokePaintServer):
* ksvg2/misc/KCanvasRenderingStyle.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 5 Oct 2006 13:15:04 +0000 (13:15 +0000)]
Reviewed by Adam.
- changed ResourceLoader to be refcounted
It keeps a ref on itself while loading as well. This makes
for a much saner memory management model than the previous.
* bridge/mac/WebCoreResourceLoaderImp.mm:
(-[WebCoreResourceLoaderImp finishJobAndHandle:]):
* dom/XMLTokenizer.cpp:
(WebCore::openFunc):
* loader/icon/IconLoader.cpp:
(IconLoader::IconLoader):
(IconLoader::~IconLoader):
(IconLoader::startLoading):
(IconLoader::stopLoading):
(IconLoader::receivedData):
* loader/icon/IconLoader.h:
* loader/loader.cpp:
(WebCore::Loader::servePendingRequests):
* platform/ResourceLoader.cpp:
(WebCore::ResourceLoader::create):
(WebCore::ResourceLoader::kill):
* platform/ResourceLoader.h:
* platform/ResourceLoaderInternal.h:
(WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
* platform/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::start):
* xml/XSLTProcessor.cpp:
(WebCore::docLoaderFunc):
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::send):
* xml/xmlhttprequest.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Thu, 5 Oct 2006 12:59:54 +0000 (12:59 +0000)]
2006-10-05 Eric Seidel <eric@eseidel.com>
Reviewed by mjs.
Improve SVG opacity performance by clipping to the object bbox before starting a new opacity layer.
http://bugs.webkit.org/show_bug.cgi?id=11163
No SVG performance tests yet.
* kcanvas/RenderForeignObject.cpp:
(WebCore::RenderForeignObject::paint):
* kcanvas/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
* kcanvas/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
* kcanvas/RenderSVGText.cpp:
(WebCore::RenderSVGText::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 5 Oct 2006 08:58:48 +0000 (08:58 +0000)]
Widget focusability work.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 5 Oct 2006 04:58:31 +0000 (04:58 +0000)]
2006-10-04 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adam.
* fast/frames/frame-src-attribute-expected.txt:
Update test result.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 5 Oct 2006 03:08:51 +0000 (03:08 +0000)]
Reviewed by Maciej and Tim H.
Copy some WebKit frame lifetime logic into WebCore -- just a step
along the path to frame lifetime being handled completely in WebCore.
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::setView): Move platform-independent parts of this
method into Frame.
* page/Frame.cpp:
(WebCore::Frame::setView): Adding platform-independent parts of
FrameMac::setView
(WebCore::Frame::detachChildren): New method to accomplish what
-[WebFrameBridge _detachChildren] currently does.
(WebCore::Frame::clear): Call detachChildren
* page/Frame.h: Add declaration for detachChildren
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Thu, 5 Oct 2006 01:42:00 +0000 (01:42 +0000)]
Reviewed by Adam.
- Removed an unnecessary assert that was stopping many pages. tm_gmtoff was not set for UTC time in mozilla but is always set for us.
* kjs/DateMath.cpp:
(KJS::getUTCOffset):
(KJS::msToTM):
* kjs/date_object.cpp:
(KJS::gmtoffset):
(KJS::formatTime):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 5 Oct 2006 01:07:49 +0000 (01:07 +0000)]
Patch by Darin and me, reviewed by Maciej.
Fixed <rdar://problem/
4518397> REGRESSION(?): Oft-seen but unrepro crash
in JavaScript garbage collection (KJS::Collector::collect())
<rdar://problem/
4752492> Crash in KJS::collect
The issue here was allocating one garbage-collected object in the midst
of allocating a second garbage-collected object. In such a case, the
zeroIfFree word lies.
* kjs/collector.cpp:
(KJS::Collector::allocate):
(KJS::Collector::collect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 5 Oct 2006 00:21:48 +0000 (00:21 +0000)]
2006-10-04 Mark Rowe <bdash@webkit.org>
Reviewed by Stephanie.
Switch the Qt buildbot to the standard set of build steps.
Have JavaScriptCoreTest check the output of run-javascriptcore-tests to
see if any regressions were spotted, and fail the test if so.
* BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
* BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
* BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Thu, 5 Oct 2006 00:19:21 +0000 (00:19 +0000)]
Reviewed by Adam.
- Layout test fix
* kjs/DateMath.cpp:
(KJS::dateToDayInYear): accept and correctly handle negative months
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Wed, 4 Oct 2006 23:16:36 +0000 (23:16 +0000)]
Reviewed by Darin.
Fixed <rdar://problem/
4758577> REGRESSION: Business and People widgets fails to complete search query
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::setRequestHeader):
removed exception set when the request is not open yet
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Wed, 4 Oct 2006 22:57:45 +0000 (22:57 +0000)]
build fix
* kjs/DateMath.cpp:
(KJS::dateToDayInYear):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 4 Oct 2006 22:25:28 +0000 (22:25 +0000)]
2006-10-05 Mark Rowe <bdash@webkit.org>
Reviewed by maculloch.
Gdk build fix.
* JavaScriptCoreSources.bkl: Add DateMath.cpp to file list.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Wed, 4 Oct 2006 21:27:29 +0000 (21:27 +0000)]
Reviewed by aroben
- build fix
* JavaScriptCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 4 Oct 2006 21:11:10 +0000 (21:11 +0000)]
2006-10-04 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Mitz.
Fix Qt/Linux build by adding DateMath.cpp to compilation.
* CMakeLists.txt: Also replace tabs with spaces.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Wed, 4 Oct 2006 21:08:43 +0000 (21:08 +0000)]
Reviewed by DethBakin.
- Apparently the build bot uses an older version of XCode which warns about conversions and the newest version does not. I hope this fixes the build but I cann't be sure on my system.
* kjs/DateMath.cpp:
(KJS::msToYear):
(KJS::dayInYear):
(KJS::dateToDayInYear):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 4 Oct 2006 20:44:29 +0000 (20:44 +0000)]
Reviewed by Mitz Pettel!
Bug 10708: [Drosera] Make the console input plaintext-only
http://bugs.webkit.org/show_bug.cgi?id=10708
Change the console input -webkit-user-modify property to
read-write-plaintext-only.
* Drosera/console.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 4 Oct 2006 20:37:02 +0000 (20:37 +0000)]
Reviewed by Tim H.
Bug 10473: [Drosera] Overlapping text in JavaScript Console
http://bugs.webkit.org/show_bug.cgi?id=10473
Using min-height instead of height to avoid overlapping text.
* ChangeLog:
* Drosera/console.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Wed, 4 Oct 2006 20:35:58 +0000 (20:35 +0000)]
Reviewed by Adam.
* wtf/Assertions.cpp: Changed assertion formatting to omit the "======"
lines so you can see more assertions in less space. Also improved format
of file/line information so it works with more development environments.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 4 Oct 2006 20:34:21 +0000 (20:34 +0000)]
Reviewed by Adam.
* wtf/Assertions.cpp: Changed assertion formatting to omit the "======"
lines so you can see more assertions in less space. Also improved format
of file/line information so it works with more development environments.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 4 Oct 2006 18:37:48 +0000 (18:37 +0000)]
Reviewed by Tim H.
Added a bash-style command history.
* Drosera/console.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Wed, 4 Oct 2006 18:36:29 +0000 (18:36 +0000)]
Reviewed by GGaren
- This is a big makeover for our Date implemenetation. This solves many platform specific issues, specifically dates before 1970, and simplifies some ugly code. The purpose of this was to get us to pass many of the JavaScriptCore tests on windows.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* kjs/DateMath.cpp: Added.
(KJS::):
(KJS::daysInYear):
(KJS::daysFrom1970ToYear):
(KJS::msFrom1970ToYear):
(KJS::msToDays):
(KJS::msToYear):
(KJS::isLeapYear):
(KJS::isInLeapYear):
(KJS::dayInYear):
(KJS::msToMilliseconds):
(KJS::msToWeekDay):
(KJS::msToSeconds):
(KJS::msToMinutes):
(KJS::msToHours):
(KJS::msToMonth):
(KJS::msToDayInMonth):
(KJS::monthToDayInYear):
(KJS::timeToMseconds):
(KJS::dateToDayInYear):
(KJS::equivalentYearForDST):
(KJS::getUTCOffset):
(KJS::getDSTOffsetSimple):
(KJS::getDSTOffset):
(KJS::localTimeToUTC):
(KJS::UTCToLocalTime):
(KJS::dateToMseconds):
(KJS::msToTM):
(KJS::isDST):
* kjs/DateMath.h: Added.
(KJS::):
* kjs/date_object.cpp:
(KJS::gmtoffset):
(KJS::formatTime):
(KJS::DateInstance::getTime):
(KJS::DateInstance::getUTCTime):
(KJS::DateProtoFunc::callAsFunction):
(KJS::DateObjectImp::construct):
(KJS::DateObjectFuncImp::callAsFunction):
(KJS::parseDate):
* kjs/testkjs.cpp:
* os-win32/stdint.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 4 Oct 2006 18:04:16 +0000 (18:04 +0000)]
2006-10-04 Anders Carlsson <acarlsson@apple.com>
Reviewed by John Sullivan.
<rdar://problem/
4654328>
Safari Crashes in WebCore::PluginTokenizer::writeRawData If I Try to Open a SWF File With Plug-ins Turned Off
* loader/PluginDocument.cpp:
(WebCore::PluginTokenizer::writeRawData):
Only send the data to the plug-in if plug-ins are enabled, otherwise just silently eat it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 4 Oct 2006 08:43:29 +0000 (08:43 +0000)]
Fix Gdk bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 4 Oct 2006 08:39:10 +0000 (08:39 +0000)]
Fix Gdk bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 4 Oct 2006 08:26:17 +0000 (08:26 +0000)]
Fix more win32 and qt bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 4 Oct 2006 08:21:56 +0000 (08:21 +0000)]
Fix more win32 bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 4 Oct 2006 08:19:16 +0000 (08:19 +0000)]
Fix more win32 bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 4 Oct 2006 08:11:56 +0000 (08:11 +0000)]
Fix Gdk bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 4 Oct 2006 08:10:55 +0000 (08:10 +0000)]
Fix Qt bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 4 Oct 2006 08:09:50 +0000 (08:09 +0000)]
Fix Gdk bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 4 Oct 2006 08:06:57 +0000 (08:06 +0000)]
Fix Qt bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 4 Oct 2006 08:05:57 +0000 (08:05 +0000)]
Fix Win32 bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 4 Oct 2006 07:53:55 +0000 (07:53 +0000)]
Fix Win32 bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 4 Oct 2006 07:52:09 +0000 (07:52 +0000)]
Fix Win32 bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 4 Oct 2006 04:45:28 +0000 (04:45 +0000)]
Fix mac build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Wed, 4 Oct 2006 04:34:45 +0000 (04:34 +0000)]
Reviewed by Tim H.
http://bugs.webkit.org/show_bug.cgi?id=11130
Convert "undefined" to AE missing value
WebCore:
* bridge/mac/WebCoreFrameBridge.mm:
(aeDescFromJSValue): return missing value for UndefinedType.
LayoutTests:
* fast/AppleScript/001-expected.txt:
* fast/AppleScript/array-expected.txt:
Updated the results.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 4 Oct 2006 04:22:10 +0000 (04:22 +0000)]
Scrolling work.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 4 Oct 2006 03:36:10 +0000 (03:36 +0000)]
2006-10-04 Mark Rowe <bdash@webkit.org>
Reviewed by NOBODY (build fix).
* WebView/WebView.m:
(-[WebView scrollDOMRangeToVisible:]): Move scrollDOMRangeToVisible: into the correct category.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 4 Oct 2006 02:51:10 +0000 (02:51 +0000)]
Update bug URLs in the two patches that I just landed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 4 Oct 2006 02:46:19 +0000 (02:46 +0000)]
2006-09-26 David Smith <catfish.man@gmail.com>
Reviewed by Timothy.
http://bugzilla.opendarwin.org/show_bug.cgi?id=3723
Add -scrollDOMRangeToVisible:
No automated tests are possible as this code path isn't reachable from JavaScript.
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge scrollDOMRangeToVisible:]):
2006-09-26 David Smith <catfish.man@gmail.com>
Reviewed by Timothy.
http://bugzilla.opendarwin.org/show_bug.cgi?id=3723
Add -scrollDOMRangeToVisible:
* WebView/WebView.m:
(-[WebView scrollDOMRangeToVisible:]):
* WebView/WebViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 4 Oct 2006 02:31:10 +0000 (02:31 +0000)]
2006-10-03 Graham Dennis <graham.dennis@gmail.com>
Reviewed by Timothy.
<http://bugzilla.opendarwin.org/show_bug.cgi?id=10338>
When contentEditable, cursor doesn't change to hand
Allow the behaviour of editable links to be specified by a WebPreference
The preference WebKitEditableLinkBehavior has four options:
- AlwaysLive: Safari 2.0 behaviour
- OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
- LiveWhenNotFocused: Editable links are live only when their editable block is not
focused, or when the shift key is pressed
- DefaultBehavior: This is the same as OnlyLiveWithShiftKey.
No layout tests, just a modification of a manual-test as it isn't possible to test
this automatically.
* bridge/mac/WebCoreSettings.h:
* bridge/mac/WebCoreSettings.mm:
(-[WebCoreSettings setEditableLinkBehavior:]):
(-[WebCoreSettings editableLinkBehavior]):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::HTMLAnchorElement):
(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::HTMLAnchorElement::setActive):
* html/HTMLAnchorElement.h:
* manual-tests/contenteditable-link.html:
* page/FrameView.cpp:
(WebCore::nodeIsNotBeingEdited):
(WebCore::selectCursor):
* page/Settings.h:
(WebCore::Settings::):
(WebCore::Settings::Settings):
(WebCore::Settings::editableLinkBehavior):
(WebCore::Settings::setEditableLinkBehavior):
2006-10-03 Graham Dennis <graham.dennis@gmail.com>
Reviewed by Timothy.
<http://bugzilla.opendarwin.org/show_bug.cgi?id=10338>
When contentEditable, cursor doesn't change to hand
Allow the behaviour of editable links to be specified by a WebPreference
The preference WebKitEditableLinkBehavior has four options:
- AlwaysLive: Safari 2.0 behaviour
- OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
- LiveWhenNotFocused: Editable links are live only when their editable block is not
focused, or when the shift key is pressed
- DefaultBehavior: This is the same as OnlyLiveWithShiftKey.
No layout tests, just a modification of a manual-test as it isn't possible to test
this automatically.
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.m:
(+[WebPreferences initialize]):
(-[WebPreferences editableLinkBehavior]):
(-[WebPreferences setEditableLinkBehavior:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.m:
(-[WebView _updateWebCoreSettingsFromPreferences:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Wed, 4 Oct 2006 01:12:17 +0000 (01:12 +0000)]
Reviewed Darin.
No test cases needed.
Implemented a version of StringImpl::append that takes a UChar* and
a length.
* platform/StringImpl.cpp:
(WebCore::StringImpl::append):
(WebCore::StringImpl::insert): Call new append instead of making a
new StringImpl.
* platform/StringImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 4 Oct 2006 01:10:26 +0000 (01:10 +0000)]
2006-10-03 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adam and Brady.
* DumpRenderTree/DumpRenderTree.m:
(main):
Update URL to Ahem.ttf
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 4 Oct 2006 01:09:33 +0000 (01:09 +0000)]
2006-10-03 MorganL <morganl.webkit@yahoo.com>
Reviewed by Darin.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11099
HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND
* platform/win/ResourceLoaderWin.cpp:
(WebCore::ResourceLoader::onHandleCreated):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 3 Oct 2006 23:28:49 +0000 (23:28 +0000)]
LayoutTests:
Reviewed by harrison
* editing/execCommand/paste-1-expected.checksum: Added.
* editing/execCommand/paste-1-expected.png: Added.
* editing/execCommand/paste-1-expected.txt: Added.
* editing/execCommand/paste-1.html: Added.
* editing/execCommand/paste-2-expected.checksum: Added.
* editing/execCommand/paste-2-expected.png: Added.
* editing/execCommand/paste-2-expected.txt: Added.
* editing/execCommand/paste-2.html: Added.
WebKit:
Reviewed by harrison
execCommand("Cut"/"Copy"/"Paste") broken in editable subframes.
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge issueCutCommand]): Issue the command on the WebHTMLView, not the WebView.
(-[WebFrameBridge issueCopyCommand]): Ditto.
(-[WebFrameBridge issuePasteCommand]): Ditto.
(-[WebFrameBridge issuePasteAndMatchStyleCommand]): Ditto.
(-[WebFrameBridge issueTransposeCommand]): Fixed formatting.
(-[WebFrameBridge canPaste]): Ask the WebHTMLView, not the WebView.
* WebView/WebHTMLView.m:
(-[WebHTMLView copy:]): Moved to WebInternal
(-[WebHTMLView cut:]): Ditto.
(-[WebHTMLView paste:]): Ditto.
(-[WebHTMLView pasteAsPlainText:]): Ditto.
* WebView/WebHTMLViewInternal.h:
* WebView/WebView.m: Removed the now unused _canPaste.
* WebView/WebViewInternal.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Tue, 3 Oct 2006 23:19:50 +0000 (23:19 +0000)]
Reviewed by Geoff.
Changing these two counters tests so they pass on the BuildBot.
* fast/css/counters/counter04-expected.checksum:
* fast/css/counters/counter04-expected.png:
* fast/css/counters/counter04-expected.txt:
* fast/css/counters/counter04.html:
* fast/css/counters/counters04-expected.checksum:
* fast/css/counters/counters04-expected.png:
* fast/css/counters/counters04-expected.txt:
* fast/css/counters/counters04.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 3 Oct 2006 23:00:40 +0000 (23:00 +0000)]
Reviewed by geoff
Fixed a typo, updating expected results.
* editing/execCommand/create-list-with-hr-expected.checksum:
* editing/execCommand/create-list-with-hr-expected.png:
* editing/execCommand/create-list-with-hr-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 3 Oct 2006 23:00:20 +0000 (23:00 +0000)]
Feared, loathed, reviewed by Darin.
More frame/iframe merging. Merged IFRAME::willRemove and IFRAME::detach
into FRAME, plus other cleanup.
No new behavior, so no new test. Layout tests pass. Basic browsing and
Mail editing seem to work.
* dom/Node.cpp:
(WebCore::Node::detach): Removed random commented-out code.
* html/HTMLFrameElement.cpp:
(WebCore::HTMLFrameElement::isURLAllowed):
(1) Removed reference to FrameView, to dissociate frame loading from rendering.
(2) Renamed newURL to completeURL because the difference between newURL
and URLString is that newURL is a KURL that is the complete version of URLString,
not that it is new.
(WebCore::HTMLFrameElement::willRemove):
(1) Removed close() call and moved close() code into willRemove(), also removing
close() call from detach(), since willRemove is the well-defined place
from DOM tear-down, not detach().
(2) Removed manual renderer detach code because the DOM is not responsible
for managing the render tree. I confirmed that this change not
regress <rdar://problem/
4132581>.
(3) Removed questionable ASSERT. The ASSERT assumed that iframe elements
lost their content frames after being removed from the DOM. That's our
current behavior, but it's going to change in future rounds of refactoring.
This also fixes <rdar://problem/
4750835>.
(WebCore::HTMLFrameElement::setLocation): Removed wacky manual calls to
attach/detach, because the render tree should not be in charge of deciding
when to load.
* html/HTMLFrameElement.h:
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::attach): Renamed renderPart to renderPartObject,
because the renderer is a renderPartObject, not a renderPart.
* html/HTMLIFrameElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 3 Oct 2006 22:46:08 +0000 (22:46 +0000)]
* Scripts/commit-log-editor: Added missing "close" call. Oops!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 3 Oct 2006 22:14:54 +0000 (22:14 +0000)]
2006-10-03 Mark Rowe <bdash@webkit.org>
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=11137
Bug 11137: GdkLauncher dies with "pure virtual method called" if
window is closed while page still loading
* platform/gdk/FrameGdk.cpp:
(WebCore::FrameGdk::~FrameGdk): Call cancelAndClear to allow virtual
methods to be called before the FrameGdk portion of "this" is torn down.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 3 Oct 2006 21:53:37 +0000 (21:53 +0000)]
Reviewed by geoff
<rdar://problem/
4763519> REGRESSION: Multipart/x-mixed-replace sub-resources fail to load
* Loader/WebSubresourceLoader.m:
(+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
Enable multipart/x-mixed-replace support on the request. This line was accidently removed during
some loader refactoring.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 3 Oct 2006 21:09:10 +0000 (21:09 +0000)]
Reviewed by Darin.
Handle tab key presses in the DOM.
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::defaultEventHandler): Add tab key handling.
* page/FrameView.cpp:
(WebCore::FrameView::advanceFocus): Rename and reimplement
focusNextPrevNode. Now we just call Element::focus().
* page/FrameView.h: Rename focusNextPrevNode to advanceFocus and make
it public.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 3 Oct 2006 19:01:33 +0000 (19:01 +0000)]
Reviewed by mjs
<rdar://problem/
4760612>
TOT REGRESSION: Repro assertion failure when forwarding draft in Range::compareBoundaryPoints
No layout test possible, attributedStringFrom:(DOMNode*)...etc isn't available to DRT.
* dom/Range.cpp:
(WebCore::Range::boundaryPointsValid): compareBoundaryPoints asserts that the incoming
positions are non-null since most of it's callers would be in a bad state if the positions
were null. boundaryPointsValid, which calls compareBoundaryPoints, is an exception.
Instead of removing the assert I've added nil checks in boundaryPointsValid, to keep it
from entering compareBoundaryPoints and hitting the assert.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 3 Oct 2006 18:55:19 +0000 (18:55 +0000)]
Reviewed by Geoff.
Make code for turning off new listbox implementation mac-only, since there's no implementation on other platforms.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::recalcStyle):
(WebCore::HTMLSelectElement::isKeyboardFocusable):
(WebCore::HTMLSelectElement::isMouseFocusable):
(WebCore::HTMLSelectElement::createRenderer):
(WebCore::HTMLSelectElement::setRecalcListItems):
(WebCore::HTMLSelectElement::notifyOptionSelected):
(WebCore::HTMLSelectElement::defaultEventHandler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 3 Oct 2006 18:18:08 +0000 (18:18 +0000)]
2006-10-04 Darin Adler <darin@apple.com>
Reviewed by Geoff.
- fix http://bugs.webkit.org/show_bug.cgi?id=11132
Caret disappears when you're typing
* editing/SelectionController.cpp:
(WebCore::SelectionController::setSelection): Remove unnecessary call to
clearCaretRectIfNeeded. The recomputeCaretRect now takes care of this.
(WebCore::SelectionController::recomputeCaretRect): Explicitly set m_needsLayout
to false so we can get the old caret repaint rect. Later we need to change the
design so getting the rect doesn't have a side effect of causing a layout without
invalidation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Tue, 3 Oct 2006 14:44:40 +0000 (14:44 +0000)]
LayoutTests:
Reviewed by Maciej.
<rdar://problem/
4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.
Updated test so that it actually shows the caret rect for the caret position.
Before, it was showing the caret rect for the 9th character of the test description.
* fast/text/justified-text-rect-expected.checksum:
* fast/text/justified-text-rect-expected.png:
* fast/text/justified-text-rect-expected.txt:
* fast/text/justified-text-rect.html:
WebCore:
Reviewed by Maciej.
<rdar://problem/
4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.
Updated test:
* fast/text/justified-text-rect.html
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge convertToNSRange:]):
(-[WebCoreFrameBridge convertToDOMRange:]):
Make the selection's root editable element (or the document itself) be
the basis for NSRange conversions. This supports "shadow DOM" like
that for text fields and text areas.
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs):
Pass the document element as the scope.
* editing/TextIterator.cpp:
(WebCore::TextIterator::rangeFromLocationAndLength):
Make the first parameter the scope.
* editing/TextIterator.h:
Make the first parameter of rangeFromLocationAndLength() the scope.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 3 Oct 2006 12:14:44 +0000 (12:14 +0000)]
2006-10-03 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by eseidel. Landed by eseidel.
Offer a way for BuildBot to not colorize the cmake output, when building
with the 'build-webkit' script. Add "--color" / "--no-color" option pair.
Default is colorize output, though only Qt platform handles this for now.
* Scripts/build-dumprendertree:
* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log